AbstractRepository::getAllIdsForOwnerQuery() - Code Metrics - Inspection of "Adjust mail content and fix tests" - Ecodev/my-ichtus - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 689588...137ad4 )

by Sam

created 2019-03-28 20:20 UTC

AbstractRepository::getAllIdsForOwnerQuery() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	5
nc	1
nop	1
dl	0
loc	8
ccs	6
cts	6
cp	1
crap	1
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Application\Repository;

use Application\Model\AbstractModel;
use Application\Model\User;
use Application\ORM\Query\Filter\AclFilter;
use Doctrine\ORM\EntityRepository;

/**
 * Class AbstractRepository
 *
 * @method null|AbstractModel findOneById(integer $id)
 */
abstract class AbstractRepository extends EntityRepository
{
    /**
     * Returns the AclFilter to fetch ACL filtering SQL
     *
     * @return AclFilter
     */
    public function getAclFilter(): AclFilter
    {
        return $this->getEntityManager()->getFilters()->getFilter(AclFilter::class);

    }

    /**
     * Return native SQL query to get all ID
     *
     * @return string
     */
    protected function getAllIdsQuery(): string
    {
        $qb = $this->getEntityManager()->getConnection()->createQueryBuilder()
            ->select('id')
            ->from($this->getClassMetadata()->getTableName());

        return $qb->getSQL();
    }

    /**
     * Return native SQL query to get all ID of object owned by given user
     *
     * @param User $user
     *
     * @return string
     */
    protected function getAllIdsForOwnerQuery(User $user): string
    {
        $qb = $this->getEntityManager()->getConnection()->createQueryBuilder()
            ->select('id')
            ->from($this->getClassMetadata()->getTableName())
            ->andWhere('owner_id = ' . $user->getId());

        return $qb->getSQL();
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Application\Repository;
6
7		use Application\Model\AbstractModel;
8		use Application\Model\User;
9		use Application\ORM\Query\Filter\AclFilter;
10		use Doctrine\ORM\EntityRepository;
11
12		/**
13		* Class AbstractRepository
14		*
15		* @method null\|AbstractModel findOneById(integer $id)
16		*/
17		abstract class AbstractRepository extends EntityRepository
18		{
19		/**
20		* Returns the AclFilter to fetch ACL filtering SQL
21		*
22		* @return AclFilter
23		*/
24	93	public function getAclFilter(): AclFilter
25		{
26	93	return $this->getEntityManager()->getFilters()->getFilter(AclFilter::class);
		1 ignored issue – show Bug Best Practice introduced 2018-11-08 01:40 UTC by Report Bug Copy Issue Report The expression `return $this->getEntityM...ilter\AclFilter::class)` returns the type `Doctrine\ORM\Query\Filter\SQLFilter` which includes types incompatible with the type-hinted return `Application\ORM\Query\Filter\AclFilter`. Loading history...
27		}
28
29		/**
30		* Return native SQL query to get all ID
31		*
32		* @return string
33		*/
34	23	protected function getAllIdsQuery(): string
35		{
36	23	$qb = $this->getEntityManager()->getConnection()->createQueryBuilder()
37	23	->select('id')
38	23	->from($this->getClassMetadata()->getTableName());
39
40	23	return $qb->getSQL();
41		}
42
43		/**
44		* Return native SQL query to get all ID of object owned by given user
45		*
46		* @param User $user
47		*
48		* @return string
49		*/
50	16	protected function getAllIdsForOwnerQuery(User $user): string
51		{
52	16	$qb = $this->getEntityManager()->getConnection()->createQueryBuilder()
53	16	->select('id')
54	16	->from($this->getClassMetadata()->getTableName())
55	16	->andWhere('owner_id = ' . $user->getId());
56
57	16	return $qb->getSQL();
58		}
59		}
60

Ecodev / my-ichtus

Push — master ( 689588...137ad4 )

AbstractRepository::getAllIdsForOwnerQuery() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like