Importer::__construct() - Code Metrics - Inspection of "Add bookable to test database #6184" - Ecodev/my-ichtus - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions
Push — master ( eb6487...5db91a )

by Sylvain
created 2019-04-04 21:07 UTC
Importer::__construct() A

↳ Parent: Project
Complexity

Conditions	1
Paths	1
Size

Total Lines	4
Code Lines	2
Duplication

Lines	0
Ratio	0 %
Code Coverage

Tests	0
CRAP Score	2
Importance

Changes
Metric	Value
cc	1
eloc	2
nc	1
nop	2
dl	0
loc	4
ccs	0
cts	4
cp	0
crap	2
rs	10
c	0
b	0
f	0
<?php

declare(strict_types=1);

namespace Application\Service;

use Doctrine\DBAL\Driver\PDOConnection;
use Doctrine\ORM\EntityManager;
use Interop\Container\ContainerInterface;

class Importer
{
    /**
     * @var ContainerInterface
     */
    private $container;

    /**
     * @var EntityManager
     */
    private $entityManager;

    /**
     * @var PDOConnection
     */
    private $filemaker;

    /**
     * @var PDOConnection
     */
    private $typo3;

    /**
     * @var array
     */
    private $members = [];

    /**
     * @var array
     */
    private $users = [];

    /**
     * Storage requests
     *
     * @var array
     */
    private $storage = [];

    /**
     * Allocated storage
     * [idBookable] => number of bookings
     *
     * @var array
     */
    private $storageAllocated = [];

    /**
     * Import constructor
     */
    public function __construct(ContainerInterface $container, EntityManager $entityManager)
    {
        $this->container = $container;
        $this->entityManager = $entityManager;
    }

    /**
     * Import the members from FileMaker and TYPO3
     */
    public function import(): void
    {
        $this->loadMembers();
        $this->loadPeople();
        $this->deleteTestUsers();
        $this->loadStorageRequests();
        $this->insertBookables();
        $this->insertUsers();
        $this->insertBookings();
    }

    /**
     * @return PDOConnection
     */
    private function connectFileMaker(): PDOConnection
    {
        if ($this->filemaker) {
            return $this->filemaker;
        }
        $config = $this->container->get('config');

        $dsn = sprintf('odbc:Driver={%s};Server=%s;Database=%s;charset=UTF-8', $config['filemaker']['driver'], $config['filemaker']['host'], $config['filemaker']['dbname']);
        $this->filemaker = new PDOConnection($dsn, $config['filemaker']['user'], $config['filemaker']['password']);

        return $this->filemaker;
    }

    /**
     * @return PDOConnection
     */
    private function connectTypo3(): PDOConnection
    {
        if ($this->typo3) {
            return $this->typo3;
        }
        $config = $this->container->get('config');

        $this->typo3 = new PDOConnection(sprintf('mysql:host=%s;port=%u;dbname=%s', $config['typo3']['host'], $config['typo3']['port'], $config['typo3']['dbname']), $config['typo3']['user'], $config['typo3']['password']);

        return $this->typo3;
    }

    /**
     * Load members from FileMaker "ichtus" table into memory
     */
    private function loadMembers(): void
    {
        $this->connectFileMaker();
        $query = <<<EOT
          SELECT ID_membre,
               "nom_prénom",
               "date_entrée ichtus",
               remarques,
               "liens de famille",
               "date_séance d'accueil",
               "date_formulaire_adhésion",
               membre_new,
               membre_actif,
               membre_suspension,
               "membre_archivé",
               assurances,
               envoi_papier
          FROM ichtus
          WHERE ((membre_new>0 AND "date_formulaire_adhésion">=DATE '2018-10-01') OR membre_actif>0 OR membre_suspension>0) AND "membre_archivé"=0 AND remarques NOT LIKE '%Ignorer%'
EOT;
        $statement = $this->filemaker->prepare(trim($query));
        if ($statement->execute()) {
            echo sprintf('%u membres à importer...', $statement->rowCount()) . PHP_EOL;
            foreach ($statement->fetchAll(\PDO::FETCH_ASSOC) as $member) {
                foreach ($member as $fieldName => $fieldValue) {
                    $member[$fieldName] = $this->fromMacRoman($fieldValue);
                }
                $this->members[$member['ID_membre']] = $member;
                echo sprintf('Membre %u importé', $member['ID_membre']) . PHP_EOL;
            }
        }
    }

    /**
     * Load people from TYPO3 fe_users into memory
     */
    private function loadPeople(): void
    {
        $this->connectTypo3();
        $query = <<<EOT
          SELECT *
          FROM fe_users
          WHERE FIND_IN_SET(CAST(family_uid as char), :members) AND status_archived=0;
EOT;
        $statement = $this->typo3->prepare($query);
        $statement->bindValue(':members', implode(',', array_keys($this->members)));

        if ($statement->execute()) {
            echo sprintf('%u individus à importer...', $statement->rowCount()) . PHP_EOL;
            $withoutLoginCount = 0;
            foreach ($statement->fetchAll(\PDO::FETCH_ASSOC) as $user) {
                if (($user['family_status'] === 'chef de famille' || $user['family_status'] === 'chef(fe) de famille') && $user['uid'] !== $user['family_uid']) {
                    echo sprintf('WARN: utilisateur %u ne devrait pas être de chef de la famille %u', $user['uid'], $user['family_uid']) . PHP_EOL;
                }
                if (empty($user['new_username'])) {
                    echo sprintf("WARN: utilisateur %u (%s %s) n'a pas de login MyIchtus", $user['uid'], $user['first_name'], $user['last_name']) . PHP_EOL;
                    ++$withoutLoginCount;
                }
                $this->users[$user['uid']] = $user;
                echo sprintf('Individu %u importé', $user['uid']) . PHP_EOL;
            }
            if ($withoutLoginCount > 0) {
                echo sprintf('%u individus sans login MyIchtus', $withoutLoginCount) . PHP_EOL;
            }
        }
    }

    /**
     * Create users
     */
    private function insertUsers(): void
    {
        $conn = $this->entityManager->getConnection();

        $insert = <<<EOT
                INSERT INTO user(
                  id,
                  login,
                  first_name,
                  last_name,
                  birthday,
                  sex,
                  email,
                  street,
                  postcode,
                  locality,
                  country_id,
                  mobile_phone,
                  phone,
                  internal_remarks,
                  iban,
                  has_insurance,
                  swiss_sailing,
                  swiss_sailing_type,
                  swiss_windsurf_type,
                  receives_newsletter,
                  role,
                  family_relationship,
                  billing_type,
                  welcome_session_date,
                  status,
                  creation_date
                ) VALUES (
                  :id,
                  :login,
                  :first_name,
                  :last_name,
                  :birthday,
                  :sex,
                  :email,
                  :street,
                  :postcode,
                  :locality,
                  :country_id,
                  :mobile_phone,
                  :phone,
                  :remarks,
                  :iban,
                  :has_insurance,
                  :swiss_sailing,
                  :swiss_sailing_type,
                  :swiss_windsurf_type,
                  :receives_newsletter,
                  :role,
                  :family_relationship,
                  :billing_type,
                  :welcome_session_date,
                  :status,
                  :creation_date
                )
EOT;
        $insert = $conn->prepare($insert);

        $createAccount = <<<EOT
                INSERT INTO account(
                  owner_id,
                  creation_date,
                  balance,
                  name,
                  parent_id,
                  type,
                  code
                ) VALUES (
                  :owner,
                  NOW(),
                  :balance,
                  :name,
                  10011, -- Passifs -> 2030 Acomptes de clients
                  'liability',
                  :code
                )
EOT;
        $createAccount = $conn->prepare($createAccount);

        foreach ($this->users as $user) {
            echo sprintf('Insert user %u (%s %s)', $user['uid'], $user['first_name'], $user['last_name']) . PHP_EOL;
            $insert->bindValue(':id', $user['uid']);
            $insert->bindValue(':login', $user['new_username']);
            $insert->bindValue(':first_name', $user['first_name']);
            $insert->bindValue(':last_name', $user['last_name']);
            $insert->bindValue(':birthday', $user['date_birth'] !== null && $user['date_birth'] !== '0000-00-00' ? $user['date_birth'] : null);
            $insert->bindValue(':sex', $user['sexe'] === 'F' ? 2 : 1);
            $insert->bindValue(':email', !empty($user['email']) ? $user['email'] : null);
            $insert->bindValue(':street', $user['address']);
            $insert->bindValue(':postcode', $user['zip']);
            $insert->bindValue(':locality', $user['city']);

            switch ($user['country']) {
                case 'CH': $country_id = 1;

break;
                case 'FR': $country_id = 2;

break;
                case 'DE': $country_id = 10;

break;
                case 'CA': $country_id = 6;

break;
                case 'NL': $country_id = 19;

break;
                default:
                    $country_id = null;
                    echo sprintf("WARN: pas de correspondance pour le code pays %s de l\\'individu %u (%s &s)", $user['country'], $user['uid'], $user['first_name'], $user['last_name']) . PHP_EOL;
            }
            $insert->bindValue(':country_id', $country_id);

            $insert->bindValue(':mobile_phone', !empty($user['natel']) ? $user['natel'] : '');
            $insert->bindValue(':phone', $user['telephone']);

            if ($user['uid'] === $user['family_uid']) {
                // Si responsable de l'adhésion, fusionne les notes au niveau du membre et de l'individu
                $remarks = implode(PHP_EOL, [$this->members[$user['family_uid']]['remarques'], $user['notes']]);
            } else {
                $remarks = !empty($user['notes']) ? $user['notes'] : '';
            }

            $insert->bindValue(':remarks', $remarks);
            $insert->bindValue(':iban', !empty($user['IBAN']) ? $user['IBAN'] : '');

            $hasInsurance = false;
            if (empty($this->members[$user['family_uid']]['assurances'])) {
                echo sprintf('WARN: membre %u n\'a aucune assurance', $user['family_uid']) . PHP_EOL;
            } elseif (mb_strpos($this->members[$user['family_uid']]['assurances'], 'RC privée') !== false) {
                $hasInsurance = true;
            }
            $insert->bindValue(':has_insurance', $hasInsurance);

            $insert->bindValue(':swiss_sailing', !empty($user['ichtus_swiss_sailing']) ? $user['ichtus_swiss_sailing'] : '');
            switch ($user['ichtus_swiss_sailing_type']) {
                case 'A': $swissSailingType = 'active';

break;
                case 'P': $swissSailingType = 'passive';

break;
                case 'J': $swissSailingType = 'junior';

break;
                default: $swissSailingType = null;
            }
            $insert->bindValue(':swiss_sailing_type', $swissSailingType);

            switch ($user['ichtus_swiss_windsurf_type']) {
                case 'A': $swissWindsurfType = 'active';

break;
                case 'P': $swissWindsurfType = 'passive';

break;
                default: $swissWindsurfType = null;
            }
            $insert->bindValue(':swiss_windsurf_type', $swissWindsurfType);

            $insert->bindValue(':receives_newsletter', !empty($user['email']) ? 1 : 0);

            switch ($user['family_status']) {
                case 'chef de famille':
                    $relationship = 'householder';
                    $role = 'member';

                    break;
                case 'chef(fe) de famille':
                    $relationship = 'householder';
                    $role = 'member';

                    break;
                case 'conjoint':
                    $relationship = 'partner';
                    $role = 'individual';

                    break;
                case 'enfant':
                    $relationship = 'child';
                    $role = 'individual';

                    break;
                case 'parent':
                    $relationship = 'parent';
                    $role = 'individual';

                    break;
                case 'soeur':
                    $relationship = 'sister';
                    $role = 'individual';

                    break;
                case 'frère':
                    $relationship = 'brother';
                    $role = 'individual';

                    break;
                case 'beau-frère':
                    $relationship = 'brother';
                    $role = 'individual';

                    break;
                default:
                    $relationship = 'householder';
                    $role = 'individual';
                    echo sprintf("WARN: individu %u (%s %s) n'a pas de statut familial", $user['uid'], $user['first_name'], $user['last_name']) . PHP_EOL;
            }
            if (in_array($user['uid'], [1057, 2738], true)) {
                $role = 'administrator';
            } elseif (!empty($user['ichtus_comite_fonction'])) {
                $role = 'responsible';
            }
            $insert->bindValue(':role', $role);
            $insert->bindValue(':family_relationship', $relationship);

            if ($this->members[$user['family_uid']]['envoi_papier'] && empty($user['email'])) {
                $insert->bindValue(':billing_type', 'paper');
            } else {
                $insert->bindValue(':billing_type', 'electronic');
            }
            $insert->bindValue(':welcome_session_date', $this->members[$user['family_uid']]["date_séance d'accueil"]);

            $userStatus = 'new';
            if ($user['status_new'] + $user['status_actif'] + $user['status_archived'] > 1) {
                echo sprintf('WARN individu %u (%s %s) a plus d\' un statut actif à la fois', $user['uid'], $user['first_name'], $user['last_name']) . PHP_EOL;
            }
            if ($user['status_actif']) {
                $userStatus = 'active';
            } elseif ($user['status_archived']) {
                $userStatus = 'archived';
            }
            $insert->bindValue(':status', $userStatus);

            $insert->bindValue(':creation_date', $this->members[$user['family_uid']]['date_entrée ichtus']);

            if ($insert->execute() === false) {
                echo sprintf('ERROR: création de l\'individu %u (%s %s)', $user['uid'], $user['first_name'], $user['last_name']) . PHP_EOL;

                continue;
            }

            // Crée un compte débiteur pour le membre
            $createAccount->bindValue(':owner', $user['uid']);
            $createAccount->bindValue(':name', implode(' ', [$user['first_name'], $user['last_name']]));
            $accountNumber = sprintf('2030%04u', $user['uid']); // 2030 (Acomptes de client) & ID User = numéro de compte unique
            $createAccount->bindValue(':code', $accountNumber);
            $createAccount->bindValue(':balance', 0.00); // Importer le solde des comptes 2018 ?
            if ($createAccount->execute() === false) {
                echo sprintf('ERROR: échec de création de compte débiteur n°%u pour l\'utilisateur %u (%s %s)', $accountNumber, $user['uid'], $user['first_name'], $user['last_name']) . PHP_EOL;
            }
        }

        $updateOwner = $conn->prepare('UPDATE user SET owner_id=:owner WHERE id=:id');
        foreach ($this->users as $user) {
            if ($user['family_uid'] && $user['family_uid'] !== $user['uid']) {
                // Update family ownership
                $updateOwner->bindValue(':owner', $user['family_uid']);
                $updateOwner->bindValue(':id', $user['uid']);
                $updateOwner->execute();
            }
        }
    }

    public function loadStorageRequests(): void
    {
        $this->connectTypo3();
        $query = 'SELECT * FROM tx_speciality_storage_places';
        $statement = $this->typo3->prepare($query);

        if ($statement->execute()) {
            echo sprintf('%u demandes d\'emplacement de stockage à importer...', $statement->rowCount()) . PHP_EOL;
            foreach ($statement->fetchAll(\PDO::FETCH_ASSOC) as $request) {
                if (!array_key_exists($request['uid_link'], $this->members)) {
                    echo sprintf('WARN: demande de stockage %u pour membre %u (%s %s) introuvable', $request['uid'], $request['uid_link'], $request['first_name'], $request['last_name']) . PHP_EOL;
                }
                $this->storage[$request['uid_link']] = $request;
            }
        }
    }

    /**
     * Create bookables (storage lockers, cabinets, space for boats)
     */
    private function insertBookables(): void
    {
        $conn = $this->entityManager->getConnection();

        $insert = <<<EOT
                INSERT INTO bookable(
                  code,
                  name,
                  description,
                  initial_price,
                  periodic_price,
                  simultaneous_booking_maximum,
                  booking_type,
                  creation_date
                ) VALUES (
                  :code,
                  :name,
                  :description,
                  :initial_price,
                  :periodic_price,
                  :simultaneous_booking_maximum,
                  :booking_type,
                  NOW()
                )
EOT;

        $insert = $conn->prepare($insert);

        // Armoires
        $insert->bindValue(':initial_price', 0);
        $insert->bindValue(':periodic_price', 50);
        // Une armoire peut être partagée entre 2 membres
        $insert->bindValue(':simultaneous_booking_maximum', 2);
        $insert->bindValue(':booking_type', 'admin_approved');
        $insert->bindValue(':description', 'Armoire (50 x 200 x 70 cm)');

        for ($i = 1; $i <= 120; ++$i) {
            $insert->bindValue(':name', sprintf('Armoire %u', $i));
            $insert->bindValue(':code', sprintf('STVA%u', $i));
            $insert->execute();
        }

        // Casiers
        $insert->bindValue(':periodic_price', 30);
        $insert->bindValue(':simultaneous_booking_maximum', 1);
        $insert->bindValue(':description', 'Casier (50 x 50 x 70 cm)');
        for ($i = 1; $i <= 36; ++$i) {
            $insert->bindValue(':name', sprintf('Casier %u', $i));
            $insert->bindValue(':code', sprintf('STVC%u', $i));
            $insert->execute();
        }

        // Stockage flotteurs
        $insert->bindValue(':periodic_price', 50);
        $insert->bindValue(':simultaneous_booking_maximum', -1);
        $insert->bindValue(':description', 'Stockage sous le local pour un flotteur');
        for ($i = 1; $i <= 80; ++$i) {
            $insert->bindValue(':name', sprintf('Stockage flotteur %u', $i));
            $insert->bindValue(':code', sprintf('STVF%u', $i));
            $insert->execute();
        }
    }

    /**
     * Create periodic bookings for all members
     */
    private function insertBookings(): void
    {
        $conn = $this->entityManager->getConnection();

        $insert = <<<EOT
                INSERT INTO booking(
                  owner_id,
                  creation_date,
                  status,
                  participant_count,
                  start_date
                ) VALUES (
                  :owner,
                  NOW(),
                  :status,
                  :participant_count,
                  NOW()
                )
EOT;

        $insert = $conn->prepare($insert);

        $insert2 = 'INSERT INTO booking_bookable(booking_id, bookable_id) VALUES (:booking, :bookable)';

        $insert2 = $conn->prepare($insert2);

        foreach ($this->members as $idMember => $member) {
            // Cotisation annuelle
            $insert->bindValue(':owner', $idMember);
            $insert->bindValue(':status', 'booked');
            $insert->bindValue(':participant_count', 1);
            $insert->execute();
            $insert2->bindValue(':booking', $conn->lastInsertId());
            $insert2->bindValue(':bookable', 3006); // Cotisation annuelle
            $insert2->execute();

            // Fond de réparation (optionnel)
            if (!empty($member['assurances']) && mb_strpos($member['assurances'], 'Fonds réparation') !== false) {
                $insert->execute();
                $insert2->bindValue(':booking', $conn->lastInsertId());
                $insert2->bindValue(':bookable', 3026); // Fonds de réparation interne
                $insert2->execute();
            }

            // Adhésion NFT (optionnel)
            if (!empty($this->users[$idMember]['ichtus_NFT'])) {
                $insert->execute();
                $insert2->bindValue(':booking', $conn->lastInsertId());
                $insert2->bindValue(':bookable', 3004); // Cotisation NFT
                $insert2->execute();
            }
        }

        // Attribution des emplacements de stockage
        $selectBookableByName = $conn->prepare('SELECT id, name, simultaneous_booking_maximum FROM bookable WHERE name=:name');
        foreach ($this->storage as $request) {
            if (empty($request['uid_link']) || !array_key_exists($request['uid_link'], $this->members)) {
                echo sprintf('ERROR: UID membre de %s %s inconnu dans fichier de demande de stockage', $request['first_name'], $request['last_name']) . PHP_EOL;

                continue;
            }
            $insert->bindValue(':owner', $request['uid_link']);
            foreach ([1 => 'Armoire %u', 2 => 'Armoire %u', 3 => 'Casier %u', 4 => 'Stockage floteur %u'] as $index => $bookableName) {
                if ($request["materiel{$index}"] > 0 && !empty($request["materiel{$index}attrib"])) {
                    $selectBookableByName->bindValue(':name', sprintf($bookableName, $request["materiel{$index}attrib"]));
                    $bookable = null;
                    if ($selectBookableByName->execute() && $selectBookableByName->rowCount() === 1) {
                        $bookable = $selectBookableByName->fetch(\PDO::FETCH_ASSOC);
                    }
                    if ($bookable) {
                        $insert->execute();
                        $insert2->bindValue(':booking', $conn->lastInsertId());
                        $insert2->bindValue(':bookable', $bookable['id']);
                        $insert2->execute();
                        if (!array_key_exists($bookable['id'], $this->storageAllocated)) {
                            $this->storageAllocated[$bookable['id']] = 1;
                        } else {
                            $this->storageAllocated[$bookable['id']] += 1;
                        }
                        echo sprintf('%s attribué à %s %s', $bookable['name'], $this->users[$request['uid_link']]['first_name'], $this->users[$request['uid_link']]['last_name']) . PHP_EOL;
                        if ($this->storageAllocated[$bookable['id']] > $bookable['simultaneous_booking_maximum']) {
                            echo sprintf('WARN: %s attribué %u fois dépassant la limite de %u', $bookable['name'], $this->storageAllocated[$bookable], $bookable['simultaneous_booking_maximum']) . PHP_EOL;
                        }
                    } else {
                        echo sprintf("ERROR: cannot find $bookableName in bookables", $request["materiel{$index}attrib"]) . PHP_EOL;
                    }
                }
            }
        }
    }

    /**
     * Convert MacRoman string to UTF-8
     *
     * @param mixed $string
     *
     * @return string
     */
    private function fromMacRoman($string): ?string
    {
        return !empty($string) ? iconv('MacRoman', 'UTF-8', $string) : $string;
    }

    /**
     * Delete existing test users prior importing to prevent an ID collision
     */
    private function deleteTestUsers(): void
    {
        $conn = $this->entityManager->getConnection();
        $result = $conn->executeQuery('SELECT id FROM account a where a.owner_id >= 1000 AND a.owner_id <= 1014');
        $accounts = $result->fetchAll(\PDO::FETCH_COLUMN);
        $stmt = $conn->prepare('DELETE tl, t FROM transaction_line tl JOIN transaction t ON tl.transaction_id = t.id WHERE FIND_IN_SET(CAST(tl.debit_id as char), :accounts) OR FIND_IN_SET(CAST(tl.credit_id as char), :accounts)');
        $stmt->bindValue('accounts', implode(',', $accounts));
        $stmt->execute();
        $stmt = $conn->prepare('DELETE FROM account WHERE FIND_IN_SET(CAST(id as char), :accounts)');
        $stmt->bindValue('accounts', implode(',', $accounts));
        $stmt->execute();
        $stmt = $conn->prepare('DELETE FROM message WHERE (creator_id >= 1000 AND creator_id <= 1014) OR (owner_id >= 1000 AND owner_id <= 1014)');
        $stmt->execute();
        $stmt = $conn->prepare('DELETE FROM user_tag WHERE (creator_id >= 1000 AND creator_id <= 1014) OR (owner_id >= 1000 AND owner_id <= 1014)');
        $stmt->execute();
        $stmt = $conn->prepare('DELETE FROM user_tag WHERE (creator_id >= 1000 AND creator_id <= 1014) OR (owner_id >= 1000 AND owner_id <= 1014)');
        $stmt->execute();
        $stmt = $conn->prepare('DELETE FROM expense_claim WHERE (creator_id >= 1000 AND creator_id <= 1014) OR (owner_id >= 1000 AND owner_id <= 1014)');
        $stmt->execute();
        $stmt = $conn->prepare('DELETE FROM booking WHERE (creator_id >= 1000 AND creator_id <= 1014) OR (owner_id >= 1000 AND owner_id <= 1014)');
        $stmt->execute();
        $stmt = $conn->prepare('SET FOREIGN_KEY_CHECKS=0; DELETE FROM user WHERE id >= 1000 AND id <= 1014; SET FOREIGN_KEY_CHECKS=1;');
        $stmt->execute();
    }
}

Ecodev / my-ichtus

Push — master ( eb6487...5db91a )

Importer::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like
