TransactionLineRepository::getAccessibleSubQuery() - Code Metrics - Inspection of "Introducing Excel export for TransactionLines #610..." - Ecodev/my-ichtus - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — master ( c4208e...4b96fe )

by Sylvain

created 2019-06-13 16:17 UTC

TransactionLineRepository::getAccessibleSubQuery() A

↳ Parent: TransactionLineRepository

Complexity

Conditions	3
Paths	3

Size

Total Lines	13
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	3

Importance

Changes

Metric	Value
cc	3
eloc	6
nc	3
nop	1
dl	0
loc	13
rs	10
c	0
b	0
f	0
ccs	6
cts	6
cp	1
crap	3

<?php

declare(strict_types=1);

namespace Application\Repository;

use Application\Action\ExportTransactionLinesAction;
use Application\Model\User;
use Doctrine\ORM\Query;

class TransactionLineRepository extends AbstractRepository implements LimitedAccessSubQueryInterface, ExportExcelInterface
{
    /**
     * Returns pure SQL to get ID of all objects that are accessible to given user.
     *
     * @param null|User $user
     *
     * @return string
     */
    public function getAccessibleSubQuery(?User $user): string
    {
        if (!$user) {
            return '-1';
        }

        if (in_array($user->getRole(), [User::ROLE_RESPONSIBLE, User::ROLE_ADMINISTRATOR], true)) {
            return $this->getAllIdsQuery();
        }

        return 'SELECT transaction_line.id FROM transaction_line
              JOIN account ON transaction_line.debit_id = account.id OR transaction_line.credit_id = account.id 
              WHERE account.owner_id = ' . $user->getId();
    }

    /**
     * Generates an Excel spreadsheet with the query result
     *
     * @param Query $query
     *
     * @return string name of the temporary file
     */
    public function exportExcel(Query $query): string
    {
        global $container;

        return ($container->get(ExportTransactionLinesAction::class))->generate($query);
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Application\Repository;
6
7		use Application\Action\ExportTransactionLinesAction;
8		use Application\Model\User;
9		use Doctrine\ORM\Query;
10
11		class TransactionLineRepository extends AbstractRepository implements LimitedAccessSubQueryInterface, ExportExcelInterface
12		{
13		/**
14		* Returns pure SQL to get ID of all objects that are accessible to given user.
15		*
16		* @param null\|User $user
17		*
18		* @return string
19		*/
20	7	public function getAccessibleSubQuery(?User $user): string
21		{
22	7	if (!$user) {
23	1	return '-1';
24		}
25
26	6	if (in_array($user->getRole(), [User::ROLE_RESPONSIBLE, User::ROLE_ADMINISTRATOR], true)) {
27	3	return $this->getAllIdsQuery();
28		}
29
30		return 'SELECT transaction_line.id FROM transaction_line
31		JOIN account ON transaction_line.debit_id = account.id OR transaction_line.credit_id = account.id
32	3	WHERE account.owner_id = ' . $user->getId();
33		}
34
35		/**
36		* Generates an Excel spreadsheet with the query result
37		*
38		* @param Query $query
39		*
40		* @return string name of the temporary file
41		*/
42		public function exportExcel(Query $query): string
43		{
44		global $container;
45
46		return ($container->get(ExportTransactionLinesAction::class))->generate($query);
47		}
48		}
49

Ecodev / my-ichtus

Push — master ( c4208e...4b96fe )

TransactionLineRepository::getAccessibleSubQuery() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like