Application\Api\Field\Mutation\UpdateTransaction::build()

Complexity

Conditions	2
Paths	1

Size

Total Lines	28
Code Lines	19

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	16
CRAP Score	2

Importance

Changes

0

<?php
    public static function build(): array
    {
        return [
            'name' => 'updateTransaction',
            'type' => Type::nonNull(_types()->getOutput(Transaction::class)),
            'description' => 'Update a transaction, and optionally replace all its transaction lines if given any',
            'args' => [
                'id' => Type::nonNull(_types()->getId(Transaction::class)),
                'input' => Type::nonNull(_types()->getPartialInput(Transaction::class)),
                'lines' => Type::listOf(Type::nonNull(_types()->getInput(TransactionLine::class))),
            ],
            'resolve' => function ($root, array $args, SessionInterface $session): Transaction {

The parameter $session is not used and could be removed.

                // Do it
                $transaction = $args['id']->getEntity();
                $input = $args['input'];
                Helper::hydrate($transaction, $input);

                // Check ACL
                Helper::throwIfDenied($transaction, 'update');
                $lines = $args['lines'];

                if ($lines !== null) {
                    _em()->getRepository(Transaction::class)->hydrateLinesAndFlush($transaction, $lines);
                } else {
                    _em()->flush();
                }

                return $transaction;

The expression return $transaction could return the type Application\Model\AbstractModel which includes types incompatible with the type-hinted return Application\Model\Transaction. Consider adding an additional type-check to rule them out.

            },