Conditions | 6 |
Paths | 1 |
Total Lines | 60 |
Code Lines | 32 |
Lines | 0 |
Ratio | 0 % |
Tests | 29 |
CRAP Score | 6.0012 |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
22 | 2 | public static function build(): array |
|
23 | { |
||
24 | return [ |
||
25 | 1 | 'name' => 'confirmRegistration', |
|
26 | 1 | 'type' => Type::nonNull(Type::boolean()), |
|
27 | 1 | 'description' => 'First step to register as a new user.', |
|
28 | 'args' => [ |
||
29 | 1 | 'token' => Type::nonNull(_types()->get('Token')), |
|
1 ignored issue
–
show
|
|||
30 | 1 | 'input' => Type::nonNull(_types()->get('ConfirmRegistrationInput')), |
|
31 | ], |
||
32 | 'resolve' => function ($root, array $args, SessionInterface $session): bool { |
||
1 ignored issue
–
show
|
|||
33 | |||
34 | /** @var UserRepository $repository */ |
||
35 | 2 | $repository = _em()->getRepository(User::class); |
|
36 | |||
37 | /** @var User $user */ |
||
38 | $user = $repository->getAclFilter()->runWithoutAcl(function () use ($repository, $args) { |
||
39 | 2 | return $repository->findOneByToken($args['token']); |
|
1 ignored issue
–
show
|
|||
40 | 2 | }); |
|
41 | |||
42 | 2 | if (!$user || !$user->isTokenValid()) { |
|
43 | 1 | throw new Exception('Cannot confirm registration with an invalid token'); |
|
44 | } |
||
45 | |||
46 | 1 | $input = $args['input']; |
|
47 | |||
48 | $repository->getAclFilter()->runWithoutAcl(function () use ($repository, $input): void { |
||
49 | 1 | if ($repository->findOneByLogin($input['login'])) { |
|
1 ignored issue
–
show
|
|||
50 | throw new Exception('Ce nom d\'utilisateur est déjà attribué et ne peut être utilisé'); |
||
51 | } |
||
52 | 1 | }); |
|
53 | |||
54 | // Do it |
||
55 | 1 | Helper::hydrate($user, $input); |
|
56 | |||
57 | // Active the member |
||
58 | 1 | $user->initialize(); |
|
59 | |||
60 | // Create mandatory booking for him |
||
61 | 1 | User::setCurrent($user); |
|
62 | |||
63 | 1 | $mandatoryBookables = _em()->getRepository(Bookable::class)->findByBookingType(BookingTypeType::MANDATORY); |
|
1 ignored issue
–
show
|
|||
64 | 1 | foreach ($mandatoryBookables as $bookable) { |
|
65 | 1 | $booking = new Booking(); |
|
66 | 1 | _em()->persist($booking); |
|
67 | |||
68 | 1 | $booking->setOwner($user); |
|
69 | 1 | $booking->setStatus(BookingStatusType::BOOKED); |
|
70 | 1 | $booking->setStartDate(new Chronos()); |
|
71 | 1 | $booking->setBookable($bookable); |
|
72 | |||
73 | // Non-periodic bookable must be terminated immediately |
||
74 | 1 | if ($bookable->getPeriodicPrice()->isZero()) { |
|
75 | 1 | $booking->terminate('Terminé automatiquement parce que paiement ponctuel uniquement'); |
|
76 | } |
||
77 | } |
||
78 | |||
79 | 1 | _em()->flush(); |
|
80 | |||
81 | 1 | return true; |
|
82 | 1 | }, |
|
86 |