Application\Action\AccountingDocumentAction::process()

Complexity

Conditions	3
Paths	3

Size

Total Lines	21
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

0

<?php
    public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
    {
        $id = $request->getAttribute('id');

        /** @var AccountingDocument $accountingDocument */
        $accountingDocument = $this->accountingDocumentRepository->findOneById($id);

The method findOneById() does not exist on Application\Repository\AccountingDocumentRepository. Since you implemented __call, consider adding a @method annotation.

        if (!$accountingDocument) {
            return $this->createError("AccountingDocument $id not found in database");
        }

        $path = $accountingDocument->getPath();
        if (!is_readable($path)) {
            return $this->createError("File for Accounting document $id not found on disk, or not readable");
        }

        $resource = fopen($path, 'r');
        $size = filesize($path);
        $type = mime_content_type($path);
        $response = new Response($resource, 200, ['content-type' => $type, 'content-length' => $size]);

It seems like $resource can also be of type false; however, parameter $body of Zend\Diactoros\Response::__construct() does only seem to accept Psr\Http\Message\StreamInterface|resource|string, maybe add an additional type check?

        return $response;
    }