Application\Acl\Assertion\BookingIsPendingApplication

Complexity

Total Complexity

5

Size/Duplication

Total Lines	33
Duplicated Lines	0 %

Test Coverage

Coverage

63.64%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	assert()	0	16	4
A	getName()	0	3	1

<?php

declare(strict_types=1);

namespace Application\Acl\Assertion;

use Application\DBAL\Types\BookingStatusType;
use Application\DBAL\Types\BookingTypeType;
use Application\Model\Booking;
use Ecodev\Felix\Acl\Assertion\NamedAssertion;
use Laminas\Permissions\Acl\Acl;
use Laminas\Permissions\Acl\Resource\ResourceInterface;
use Laminas\Permissions\Acl\Role\RoleInterface;

class BookingIsPendingApplication implements NamedAssertion
{
    public function getName(): string
    {
        return 'le réservable est pas encore confirmé';
    }

    /**
     * Assert that a booking is a pending application.
     *
     * @param \Application\Acl\Acl $acl
     * @param RoleInterface $role
     * @param ResourceInterface $resource
     * @param string $privilege
     *
     * @return bool
     */
    public function assert(Acl $acl, ?RoleInterface $role = null, ?ResourceInterface $resource = null, $privilege = null)
    {
        /** @var Booking $booking */
        $booking = $resource->getInstance();

The method getInstance() does not exist on Laminas\Permissions\Acl\Resource\ResourceInterface.

The method getInstance() does not exist on null.

        $bookable = $booking->getBookable();
        if (!$bookable) {
            return false;
        }

        $bookingType = $bookable->getBookingType();
        if ($booking->getStatus() === BookingStatusType::APPLICATION && in_array($bookingType, [BookingTypeType::APPLICATION, BookingTypeType::ADMIN_APPROVED], true)) {
            return true;
        }

        return $acl->reject('you cannot delete a processed application');

The method reject() does not exist on Laminas\Permissions\Acl\Acl. It seems like you code against a sub-type of Laminas\Permissions\Acl\Acl such as Ecodev\Felix\Acl\Acl.

    }
}