Application\Acl\Assertion\BookableAvailable

Complexity

Total Complexity

11

Size/Duplication

Total Lines	61
Duplicated Lines	0 %

Test Coverage

Coverage

82.61%

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
B	assert()	0	49	11

<?php

declare(strict_types=1);

namespace Application\Acl\Assertion;

use Application\Model\Booking;
use Application\Model\User;
use Zend\Permissions\Acl\Acl;
use Zend\Permissions\Acl\Assertion\AssertionInterface;
use Zend\Permissions\Acl\Resource\ResourceInterface;
use Zend\Permissions\Acl\Role\RoleInterface;

class BookableAvailable implements AssertionInterface
{
    /**
     * Assert that the bookable of the given booking can be rented by the current user
     *
     * @param \Application\Acl\Acl $acl
     * @param RoleInterface $role
     * @param ResourceInterface $resource
     * @param string $privilege
     *
     * @return bool
     */
    public function assert(Acl $acl, RoleInterface $role = null, ResourceInterface $resource = null, $privilege = null)
    {
        /** @var Booking $booking */
        $booking = $resource->getInstance();

The method getInstance() does not exist on Zend\Permissions\Acl\Resource\ResourceInterface. It seems like you code against a sub-type of Zend\Permissions\Acl\Resource\ResourceInterface such as Application\Acl\ModelResource.

The method getInstance() does not exist on null.

        if (!$booking) {
            return $acl->reject('the booking does not exist');
        }

        if (!User::getCurrent()) {
            return $acl->reject('the user is not logged in');

The method reject() does not exist on Zend\Permissions\Acl\Acl. Are you sure you never get this type here, but always one of the subclasses?

        }

        $bookable = $booking->getBookable();

        if (!$bookable) {
            // Booking using user's own equipment is always allowed
            return true;
        }

        if (!$bookable->isActive()) {
            return $acl->reject('the bookable is not active');
        }

        // Check that the user has ALL required licenses for the bookable
        if (!$bookable->getLicenses()->isEmpty() && User::getCurrent()->getRole() !== User::ROLE_BOOKING_ONLY) {
            $userLicenses = User::getCurrent()->getLicenses();

            foreach ($bookable->getLicenses() as $requiredLicense) {
                if (!$userLicenses->contains($requiredLicense)) {
                    return $acl->reject('the user does not have the required license: ' . $requiredLicense->getName());
                }
            }
        }

        if ($bookable->getSimultaneousBookingMaximum() > 0) {
            // Check that the bookable has no more running bookings than its maximum
            $runningBookings = _em()->getRepository(Booking::class)->findBy([
                'bookable' => $bookable,
                'endDate' => null,
            ]);

            $count = count($runningBookings);
            if ($count >= $bookable->getSimultaneousBookingMaximum()) {
                return $acl->reject('the bookable limit of simultaneous bookings has been reached: ' . $count . '/' . $bookable->getSimultaneousBookingMaximum());
            }
        }

        return true;
    }
}