ExportTransactionLinesHandler::writeData() - Code Metrics - Inspection of "Renamed actions to handlers #7748" - Ecodev/my-ichtus - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — master ( 4dad36...cd91a2 )

by Adrien

created 2020-12-16 08:49 UTC

ExportTransactionLinesHandler::writeData() C

↳ Parent: ExportTransactionLinesHandler

Complexity

Conditions	14
Paths	9

Size

Total Lines	80
Code Lines	47

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	107.9454

Importance

Changes

Metric	Value
eloc	47
c	0
b	0
f	0
dl	0
loc	80
rs	6.2666
ccs	10
cts	46
cp	0.2174
cc	14
nc	9
nop	2
crap	107.9454

How to fix Long Method Complexity

<?php

declare(strict_types=1);

namespace Application\Handler;

use Application\Model\TransactionLine;
use Money\Currencies\ISOCurrencies;
use Money\Formatter\DecimalMoneyFormatter;
use PhpOffice\PhpSpreadsheet\Cell\Coordinate;
use PhpOffice\PhpSpreadsheet\Worksheet\Worksheet;

class ExportTransactionLinesHandler extends AbstractExcel
{
    /**
     * @var DecimalMoneyFormatter
     */
    private $moneyFormatter;

    /**
     * ReportTransactionsAction constructor.
     */
    public function __construct(string $hostname)
    {
        parent::__construct($hostname, 'transactionLines');

        $currencies = new ISOCurrencies();
        $this->moneyFormatter = new DecimalMoneyFormatter($currencies);

        $this->outputFileName = sprintf('Ichtus_compta_ecritures_%s.xlsx', date('Y-m-d-H:i:s'));

        $sheet = $this->workbook->getActiveSheet();
        $sheet->setTitle('Compta Écritures');
        $sheet->getDefaultRowDimension()->setRowHeight(20);
    }

    /**
     * The model class name
     */
    protected function getModelClass(): string
    {
        return TransactionLine::class;
    }

    /**
     * @param TransactionLine[] $items
     */
    protected function writeData(Worksheet $sheet, array $items): void
    {
        $sheet->setShowGridlines(false);
        $initialColumn = $maxColumn = $this->column;

        $currentTransactionRowStart = null;
        $currentTransactionId = null;

        $mergeRowsFromColumns = [
            $initialColumn + 1, // Transaction.ID
            $initialColumn + 2, // Transaction.name
            $initialColumn + 3, // Transaction.remarks
            $initialColumn + 4, // Transaction.internalRemarks
        ];

        foreach ($items as $index => $line) {
            $transaction = $line->getTransaction();
            $transactionId = $transaction->getId();

            if (!$currentTransactionId) {
                $currentTransactionId = $transactionId;
                $currentTransactionRowStart = $this->row;
            } elseif ($transactionId !== $currentTransactionId) {
                // Current line starts a new transaction
                if ($currentTransactionRowStart < $this->row - 1) {
                    // Multi-line transaction
                    // Merge cells that have the same value because from the same transaction
                    foreach ($mergeRowsFromColumns as $column) {
                        $sheet->mergeCellsByColumnAndRow($column, $currentTransactionRowStart, $column, $this->row - 1);
                    }
                }
                $currentTransactionRowStart = $this->row;
                $currentTransactionId = $transactionId;
            }

            // Date
            $this->write($sheet, $line->getTransactionDate()->format('d.m.Y'));

            // Transaction.ID
            $this->write($sheet, $transactionId);
            $url = 'https://' . $this->hostname . '/admin/transaction/%u';
            $sheet->getCellByColumnAndRow($this->column - 1, $this->row)->getHyperlink()->setUrl(sprintf($url, $transactionId));
            // Transaction.name
            $this->write($sheet, $transaction->getName());
            // Transaction.remarks
            $this->write($sheet, $transaction->getRemarks());
            // Transaction.internalRemarks
            $this->write($sheet, $transaction->getInternalRemarks());

            // TransactionLine.name
            $this->write($sheet, $line->getName());
            // TransactionLine.remarks
            $this->write($sheet, $line->getRemarks());
            // Bookable.name
            $this->write($sheet, $line->getBookable() ? $line->getBookable()->getName() : '');
            // Debit account
            $debit = $line->getDebit();
            $this->write($sheet, $debit ? implode(' ', [$debit->getCode(), $debit->getName()]) : '');
            // Credit account
            $credit = $line->getCredit();
            $this->write($sheet, $credit ? implode(' ', [$credit->getCode(), $credit->getName()]) : '');
            // Debit amount
            $this->write($sheet, $debit ? $this->moneyFormatter->format($line->getBalance()) : '');
            // Credit amount
            $this->write($sheet, $credit ? $this->moneyFormatter->format($line->getBalance()) : '');
            // Reconciled
            $this->write($sheet, $line->isReconciled() ? '✔️' : '');

            $maxColumn = $this->column - 1;

            $range = Coordinate::stringFromColumnIndex($initialColumn) . $this->row . ':' . Coordinate::stringFromColumnIndex($maxColumn) . $this->row;
            // Thicker horizontal delimiter between lines of different transactions
            if ($index === max(array_keys($items)) || $line->getTransaction()->getId() !== $items[$index + 1]->getTransaction()->getId()) {
                $borderBottom = self::$bordersBottom;
            } else {
                $borderBottom = self::$bordersBottomLight;
            }
            $sheet->getStyle($range)->applyFromArray($borderBottom);

            $this->column = $initialColumn;
            ++$this->row;
        }
    }

    protected function getHeaders(): array
    {
        return [
            ['label' => 'Date', 'width' => 12, 'formats' => [self::$dateFormat]],
            ['label' => 'ID', 'width' => 7, 'formats' => [self::$headerFormat, self::$centerFormat]],
            ['label' => 'Transaction', 'width' => 25, 'formats' => [self::$wrapFormat]],
            ['label' => 'Remarques', 'width' => 25, 'formats' => [self::$wrapFormat]],
            ['label' => 'Remarques internes', 'width' => 25, 'formats' => [self::$wrapFormat]],
            ['label' => 'Écriture', 'width' => 25, 'formats' => [self::$wrapFormat]],
            ['label' => 'Remarques', 'width' => 25, 'formats' => [self::$wrapFormat]],
            ['label' => 'Réservable', 'width' => 30, 'formats' => [self::$wrapFormat]],
            ['label' => 'Compte débit', 'width' => 30, 'formats' => [self::$wrapFormat]],
            ['label' => 'Compte crédit', 'width' => 30, 'formats' => [self::$wrapFormat]],
            ['label' => 'Montant débit', 'width' => 20, 'formats' => [self::$headerFormat]],
            ['label' => 'Montant crédit', 'width' => 20, 'formats' => [self::$headerFormat]],
            ['label' => 'Pointé', 'width' => 15, 'formats' => [self::$centerFormat]],
        ];
    }

    /**
     * @param TransactionLine[] $items
     */
    protected function writeFooter(Worksheet $sheet, array $items): void
    {
        $initialColumn = $this->column;

        // Date
        $this->write($sheet, '');
        // ID
        $this->write($sheet, '');
        // Transaction.name
        $this->write($sheet, '');
        // Transaction.remarks
        $this->write($sheet, '');
        // Internal remarks
        $this->write($sheet, '');
        // TransactionLine.name
        $this->write($sheet, '');
        // Remarks
        $this->write($sheet, '');
        // Bookable.name
        $this->write($sheet, '');
        // Debit account
        $this->write($sheet, '');
        // Credit account
        $this->write($sheet, '');
        // Debit amount
        $this->write($sheet, '=SUBTOTAL(9,' . Coordinate::stringFromColumnIndex($this->column) . '2:' . Coordinate::stringFromColumnIndex($this->column) . ($this->row - 1) . ')');
        // Credit amount
        $this->write($sheet, '=SUBTOTAL(9,' . Coordinate::stringFromColumnIndex($this->column) . '2:' . Coordinate::stringFromColumnIndex($this->column) . ($this->row - 1) . ')');
        // Reconciled
        $this->write($sheet, '');

        // Apply style
        $range = Coordinate::stringFromColumnIndex($initialColumn) . $this->row . ':' . Coordinate::stringFromColumnIndex($this->column - 1) . $this->row;
        $sheet->getStyle($range)->applyFromArray(self::$totalFormat);
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Application\Handler;
6
7		use Application\Model\TransactionLine;
8		use Money\Currencies\ISOCurrencies;
9		use Money\Formatter\DecimalMoneyFormatter;
10		use PhpOffice\PhpSpreadsheet\Cell\Coordinate;
11		use PhpOffice\PhpSpreadsheet\Worksheet\Worksheet;
12
13		class ExportTransactionLinesHandler extends AbstractExcel
14		{
15		/**
16		* @var DecimalMoneyFormatter
17		*/
18		private $moneyFormatter;
19
20		/**
21		* ReportTransactionsAction constructor.
22		*/
23	1	public function __construct(string $hostname)
24		{
25	1	parent::__construct($hostname, 'transactionLines');
26
27	1	$currencies = new ISOCurrencies();
28	1	$this->moneyFormatter = new DecimalMoneyFormatter($currencies);
29
30	1	$this->outputFileName = sprintf('Ichtus_compta_ecritures_%s.xlsx', date('Y-m-d-H:i:s'));
31
32	1	$sheet = $this->workbook->getActiveSheet();
33	1	$sheet->setTitle('Compta Écritures');
34	1	$sheet->getDefaultRowDimension()->setRowHeight(20);
35	1	}
36
37		/**
38		* The model class name
39		*/
40		protected function getModelClass(): string
41		{
42		return TransactionLine::class;
43		}
44
45		/**
46		* @param TransactionLine[] $items
47		*/
48	1	protected function writeData(Worksheet $sheet, array $items): void
49		{
50	1	$sheet->setShowGridlines(false);
51	1	$initialColumn = $maxColumn = $this->column;
		0 ignored issues – show Unused Code introduced 2019-06-13 16:26 UTC by Report Bug Copy Issue Report The assignment to `$maxColumn` is dead and can be removed. Loading history...
52	1	$currentTransactionRowStart = null;
53	1	$currentTransactionId = null;
54
55		$mergeRowsFromColumns = [
56	1	$initialColumn + 1, // Transaction.ID
57	1	$initialColumn + 2, // Transaction.name
58	1	$initialColumn + 3, // Transaction.remarks
59	1	$initialColumn + 4, // Transaction.internalRemarks
60		];
61
62	1	foreach ($items as $index => $line) {
63		$transaction = $line->getTransaction();
64		$transactionId = $transaction->getId();
65
66		if (!$currentTransactionId) {
67		$currentTransactionId = $transactionId;
68		$currentTransactionRowStart = $this->row;
69		} elseif ($transactionId !== $currentTransactionId) {
70		// Current line starts a new transaction
71		if ($currentTransactionRowStart < $this->row - 1) {
72		// Multi-line transaction
73		// Merge cells that have the same value because from the same transaction
74		foreach ($mergeRowsFromColumns as $column) {
75		$sheet->mergeCellsByColumnAndRow($column, $currentTransactionRowStart, $column, $this->row - 1);
76		}
77		}
78		$currentTransactionRowStart = $this->row;
79		$currentTransactionId = $transactionId;
80		}
81
82		// Date
83		$this->write($sheet, $line->getTransactionDate()->format('d.m.Y'));
84
85		// Transaction.ID
86		$this->write($sheet, $transactionId);
87		$url = 'https://' . $this->hostname . '/admin/transaction/%u';
88		$sheet->getCellByColumnAndRow($this->column - 1, $this->row)->getHyperlink()->setUrl(sprintf($url, $transactionId));
89		// Transaction.name
90		$this->write($sheet, $transaction->getName());
91		// Transaction.remarks
92		$this->write($sheet, $transaction->getRemarks());
93		// Transaction.internalRemarks
94		$this->write($sheet, $transaction->getInternalRemarks());
95
96		// TransactionLine.name
97		$this->write($sheet, $line->getName());
98		// TransactionLine.remarks
99		$this->write($sheet, $line->getRemarks());
100		// Bookable.name
101		$this->write($sheet, $line->getBookable() ? $line->getBookable()->getName() : '');
102		// Debit account
103		$debit = $line->getDebit();
104		$this->write($sheet, $debit ? implode(' ', [$debit->getCode(), $debit->getName()]) : '');
105		// Credit account
106		$credit = $line->getCredit();
107		$this->write($sheet, $credit ? implode(' ', [$credit->getCode(), $credit->getName()]) : '');
108		// Debit amount
109		$this->write($sheet, $debit ? $this->moneyFormatter->format($line->getBalance()) : '');
110		// Credit amount
111		$this->write($sheet, $credit ? $this->moneyFormatter->format($line->getBalance()) : '');
112		// Reconciled
113		$this->write($sheet, $line->isReconciled() ? '✔️' : '');
114
115		$maxColumn = $this->column - 1;
116
117		$range = Coordinate::stringFromColumnIndex($initialColumn) . $this->row . ':' . Coordinate::stringFromColumnIndex($maxColumn) . $this->row;
118		// Thicker horizontal delimiter between lines of different transactions
119		if ($index === max(array_keys($items)) \|\| $line->getTransaction()->getId() !== $items[$index + 1]->getTransaction()->getId()) {
120		$borderBottom = self::$bordersBottom;
121		} else {
122		$borderBottom = self::$bordersBottomLight;
123		}
124		$sheet->getStyle($range)->applyFromArray($borderBottom);
125
126		$this->column = $initialColumn;
127		++$this->row;
128		}
129	1	}
130
131	1	protected function getHeaders(): array
132		{
133		return [
134	1	['label' => 'Date', 'width' => 12, 'formats' => [self::$dateFormat]],
135	1	['label' => 'ID', 'width' => 7, 'formats' => [self::$headerFormat, self::$centerFormat]],
136	1	['label' => 'Transaction', 'width' => 25, 'formats' => [self::$wrapFormat]],
137	1	['label' => 'Remarques', 'width' => 25, 'formats' => [self::$wrapFormat]],
138	1	['label' => 'Remarques internes', 'width' => 25, 'formats' => [self::$wrapFormat]],
139	1	['label' => 'Écriture', 'width' => 25, 'formats' => [self::$wrapFormat]],
140	1	['label' => 'Remarques', 'width' => 25, 'formats' => [self::$wrapFormat]],
141	1	['label' => 'Réservable', 'width' => 30, 'formats' => [self::$wrapFormat]],
142	1	['label' => 'Compte débit', 'width' => 30, 'formats' => [self::$wrapFormat]],
143	1	['label' => 'Compte crédit', 'width' => 30, 'formats' => [self::$wrapFormat]],
144	1	['label' => 'Montant débit', 'width' => 20, 'formats' => [self::$headerFormat]],
145	1	['label' => 'Montant crédit', 'width' => 20, 'formats' => [self::$headerFormat]],
146	1	['label' => 'Pointé', 'width' => 15, 'formats' => [self::$centerFormat]],
147		];
148		}
149
150		/**
151		* @param TransactionLine[] $items
152		*/
153	1	protected function writeFooter(Worksheet $sheet, array $items): void
154		{
155	1	$initialColumn = $this->column;
156
157		// Date
158	1	$this->write($sheet, '');
159		// ID
160	1	$this->write($sheet, '');
161		// Transaction.name
162	1	$this->write($sheet, '');
163		// Transaction.remarks
164	1	$this->write($sheet, '');
165		// Internal remarks
166	1	$this->write($sheet, '');
167		// TransactionLine.name
168	1	$this->write($sheet, '');
169		// Remarks
170	1	$this->write($sheet, '');
171		// Bookable.name
172	1	$this->write($sheet, '');
173		// Debit account
174	1	$this->write($sheet, '');
175		// Credit account
176	1	$this->write($sheet, '');
177		// Debit amount
178	1	$this->write($sheet, '=SUBTOTAL(9,' . Coordinate::stringFromColumnIndex($this->column) . '2:' . Coordinate::stringFromColumnIndex($this->column) . ($this->row - 1) . ')');
179		// Credit amount
180	1	$this->write($sheet, '=SUBTOTAL(9,' . Coordinate::stringFromColumnIndex($this->column) . '2:' . Coordinate::stringFromColumnIndex($this->column) . ($this->row - 1) . ')');
181		// Reconciled
182	1	$this->write($sheet, '');
183
184		// Apply style
185	1	$range = Coordinate::stringFromColumnIndex($initialColumn) . $this->row . ':' . Coordinate::stringFromColumnIndex($this->column - 1) . $this->row;
186	1	$sheet->getStyle($range)->applyFromArray(self::$totalFormat);
187	1	}
188		}
189

Ecodev / my-ichtus

Push — master ( 4dad36...cd91a2 )

ExportTransactionLinesHandler::writeData() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like