Application\Acl\Assertion\BookingIsSelfApproved

Complexity

Total Complexity

4

Size/Duplication

Total Lines	30
Duplicated Lines	0 %

Test Coverage

Coverage

70%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getName()	0	3	1
A	assert()	0	15	3

<?php

declare(strict_types=1);

namespace Application\Acl\Assertion;

use Application\Enum\BookingType;
use Application\Model\Booking;
use Ecodev\Felix\Acl\Assertion\NamedAssertion;
use Laminas\Permissions\Acl\Acl;
use Laminas\Permissions\Acl\Resource\ResourceInterface;
use Laminas\Permissions\Acl\Role\RoleInterface;

class BookingIsSelfApproved implements NamedAssertion
{
    public function getName(): string
    {
        return 'la réséveration est un carnet de sortie';
    }

    /**
     * Assert that booking's bookable is self approved (boats) or has no bookable.
     *
     * @param \Application\Acl\Acl $acl
     * @param string $privilege
     *
     * @return bool
     */
    public function assert(Acl $acl, ?RoleInterface $role = null, ?ResourceInterface $resource = null, $privilege = null)
    {
        /** @var Booking $booking */
        $booking = $resource->getInstance();

The method getInstance() does not exist on null.

        if (!$booking->getBookable()) {
            return true;
        }

        $bookingType = $booking->getBookable()->getBookingType();
        if ($bookingType === BookingType::SelfApproved) {
            return true;
        }

        return $acl->reject('the booking type for this booking is not self approved, but : ' . $bookingType->value);

The method reject() does not exist on Laminas\Permissions\Acl\Acl. It seems like you code against a sub-type of Laminas\Permissions\Acl\Acl such as Ecodev\Felix\Acl\Acl.

    }
}