AbstractSimpleOperator::getDqlCondition() - Code Metrics - Inspection of "RFC for new filtering feature" - Ecodev/graphql-doctrine - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — master (#10)

by Adrien

created 2018-05-07 07:36 UTC

AbstractSimpleOperator::getDqlCondition() A

↳ Parent: AbstractSimpleOperator

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	6
rs	9.4285
c	0
b	0
f	0
ccs	4
cts	4
cp	1
cc	1
eloc	3
nc	1
nop	6
crap	1

<?php

declare(strict_types=1);

namespace GraphQL\Doctrine\Definition\Operator;

use Doctrine\ORM\Mapping\ClassMetadata;
use Doctrine\ORM\QueryBuilder;
use GraphQL\Doctrine\Factory\UniqueNameFactory;
use GraphQL\Doctrine\Types;
use GraphQL\Type\Definition\LeafType;
use GraphQL\Type\Definition\Type;

/**
 * A simple operator with two operands
 */
abstract class AbstractSimpleOperator extends AbstractOperator
{
    abstract protected function getDqlOperator(bool $isNot): string;

    protected function getConfiguration(Types $types, LeafType $leafType): array
    {
        return [
            'fields' => [
                [
                    'name' => 'value',
                    'type' => Type::nonNull($leafType),
                ],
                [
                    'name' => 'not',
                    'type' => Type::boolean(),
                    'defaultValue' => false,
                ],
            ],
        ];
    }

    public function getDqlCondition(UniqueNameFactory $uniqueNameFactory, ClassMetadata $metadata, QueryBuilder $queryBuilder, string $alias, string $field, array $args): string
    {
        $param = $uniqueNameFactory->createParameterName();
        $queryBuilder->setParameter($param, $args['value']);

        return $alias . '.' . $field . ' ' . $this->getDqlOperator($args['not']) . ' :' . $param;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace GraphQL\Doctrine\Definition\Operator;
6
7		use Doctrine\ORM\Mapping\ClassMetadata;
8		use Doctrine\ORM\QueryBuilder;
9		use GraphQL\Doctrine\Factory\UniqueNameFactory;
10		use GraphQL\Doctrine\Types;
11		use GraphQL\Type\Definition\LeafType;
12		use GraphQL\Type\Definition\Type;
13
14		/**
15		* A simple operator with two operands
16		*/
17		abstract class AbstractSimpleOperator extends AbstractOperator
18		{
19		abstract protected function getDqlOperator(bool $isNot): string;
20
21	20	protected function getConfiguration(Types $types, LeafType $leafType): array
22		{
23		return [
24	20	'fields' => [
25		[
26	20	'name' => 'value',
27	20	'type' => Type::nonNull($leafType),
28		],
29		[
30	20	'name' => 'not',
31	20	'type' => Type::boolean(),
32		'defaultValue' => false,
33		],
34		],
35		];
36		}
37
38	17	public function getDqlCondition(UniqueNameFactory $uniqueNameFactory, ClassMetadata $metadata, QueryBuilder $queryBuilder, string $alias, string $field, array $args): string
39		{
40	17	$param = $uniqueNameFactory->createParameterName();
41	17	$queryBuilder->setParameter($param, $args['value']);
42
43	17	return $alias . '.' . $field . ' ' . $this->getDqlOperator($args['not']) . ' :' . $param;
44		}
45		}
46

Ecodev / graphql-doctrine

Pull Request — master (#10)

AbstractSimpleOperator::getDqlCondition() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like