EntityIDType::parseLiteral() - Code Metrics - Inspection of "Introduce `composer check` to check the entire pro..." - Ecodev/graphql-doctrine - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5eaa67...092141 )

by Adrien

created 2017-09-19 14:45 UTC

EntityIDType::parseLiteral() A

↳ Parent: EntityIDType

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	6
ccs	3
cts	3
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	1
crap	1

<?php

declare(strict_types=1);

namespace GraphQL\Doctrine\Definition;

use Doctrine\ORM\EntityManager;
use Doctrine\ORM\EntityRepository;
use GraphQL\Doctrine\Utils;
use GraphQL\Type\Definition\IDType;

/**
 * A specialized ID type that allows to fetch entity from DB
 */
class EntityIDType extends IDType
{
    /**
     * @var EntityManager
     */
    private $entityManager;

    /**
     * The entity class name
     *
     * @var string
     */
    private $className;

    public function __construct(EntityManager $entityManager, string $className)
function someFunction(ManagerRegistry $registry) {
    $em = $registry->getManager();
    $em->getConnection()->beginTransaction();
    try {
        // Do something.
        $em->getConnection()->commit();
    } catch (\Exception $ex) {
        $em->getConnection()->rollback();
        $em->close();

        throw $ex;
    }
}
    {
        $this->entityManager = $entityManager;
        $this->className = $className;
        $this->name = Utils::getIDTypeName($className);
        $this->description = 'Automatically generated type to be used as input where an object of type `' . Utils::getTypeName($className) . '` is needed';

        parent::__construct();
    }

    /**
     * Serializes an internal value to include in a response.
     *
     * @param mixed $value
     *
     * @return string
     */
    public function serialize($value)
    {
        $id = $this->entityManager->getClassMetadata($this->className)->getIdentifierValues($value);

        return (string) reset($id);
    }

    /**
     * Parses an externally provided value (query variable) to use as an input
     *
     * @param mixed $value
     *
     * @return mixed A Doctrine entity
     */
    public function parseValue($value)
    {
        $value = parent::parseValue($value);

        return $this->getRepository()->find($value);

    }

    /**
     * Parses an externally provided literal value (hardcoded in GraphQL query) to use as an input
     *
     * @param \GraphQL\Language\AST\Node $valueNode
     *
     * @return mixed
     */
    public function parseLiteral($valueNode)
    {
        $value = parent::parseLiteral($valueNode);

        return $this->getRepository()->find($value);

    }

    /**
     * Get the repository for our entity
     *
     * @return EntityRepository
     */
    private function getRepository(): EntityRepository
    {
        return $this->entityManager->getRepository($this->className);
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace GraphQL\Doctrine\Definition;
6
7		use Doctrine\ORM\EntityManager;
8		use Doctrine\ORM\EntityRepository;
9		use GraphQL\Doctrine\Utils;
10		use GraphQL\Type\Definition\IDType;
11
12		/**
13		* A specialized ID type that allows to fetch entity from DB
14		*/
15		class EntityIDType extends IDType
16		{
17		/**
18		* @var EntityManager
19		*/
20		private $entityManager;
21
22		/**
23		* The entity class name
24		*
25		* @var string
26		*/
27		private $className;
28
29	7	public function __construct(EntityManager $entityManager, string $className)
		0 ignored issues – show Bug introduced 2017-08-11 10:29 UTC by Report Bug Copy Issue Report You have injected the EntityManager via parameter `$entityManager`. This is generally not recommended as it might get closed and become unusable. Instead, it is recommended to inject the ManagerRegistry and retrieve the EntityManager via `getManager()` each time you need it. The `EntityManager` might become unusable for example if a transaction is rolled back and it gets closed. Let’s assume that somewhere in your application, or in a third-party library, there is code such as the following: function someFunction(ManagerRegistry $registry) { $em = $registry->getManager(); $em->getConnection()->beginTransaction(); try { // Do something. $em->getConnection()->commit(); } catch (\Exception $ex) { $em->getConnection()->rollback(); $em->close(); throw $ex; } } If that code throws an exception and the `EntityManager` is closed. Any other code which depends on the same instance of the `EntityManager` during this request will fail. On the other hand, if you instead inject the `ManagerRegistry`, the `getManager()` method guarantees that you will always get a usable manager instance. Loading history...
30		{
31	7	$this->entityManager = $entityManager;
32	7	$this->className = $className;
33	7	$this->name = Utils::getIDTypeName($className);
34	7	$this->description = 'Automatically generated type to be used as input where an object of type `' . Utils::getTypeName($className) . '` is needed';
35
36	7	parent::__construct();
37	7	}
38
39		/**
40		* Serializes an internal value to include in a response.
41		*
42		* @param mixed $value
43		*
44		* @return string
45		*/
46	1	public function serialize($value)
47		{
48	1	$id = $this->entityManager->getClassMetadata($this->className)->getIdentifierValues($value);
49
50	1	return (string) reset($id);
51		}
52
53		/**
54		* Parses an externally provided value (query variable) to use as an input
55		*
56		* @param mixed $value
57		*
58		* @return mixed A Doctrine entity
59		*/
60	1	public function parseValue($value)
61		{
62	1	$value = parent::parseValue($value);
63
64	1	return $this->getRepository()->find($value);
		0 ignored issues – show Bug Compatibility introduced 2017-08-11 10:29 UTC by Report Bug Copy Issue Report The expression `$this->getRepository()->find($value);` of type `object\|null` adds the type `object` to the return on line 64 which is incompatible with the return type of the parent method `GraphQL\Type\Definition\IDType::parseValue` of type `string`. Loading history...
65		}
66
67		/**
68		* Parses an externally provided literal value (hardcoded in GraphQL query) to use as an input
69		*
70		* @param \GraphQL\Language\AST\Node $valueNode
71		*
72		* @return mixed
73		*/
74	1	public function parseLiteral($valueNode)
75		{
76	1	$value = parent::parseLiteral($valueNode);
77
78	1	return $this->getRepository()->find($value);
		1 ignored issue – show Bug Compatibility introduced 2017-09-19 14:48 UTC by Report Bug Copy Issue Report The expression `$this->getRepository()->find($value);` of type `object\|null` adds the type `object` to the return on line 78 which is incompatible with the return type of the parent method `GraphQL\Type\Definition\IDType::parseLiteral` of type `null\|string`. Loading history...
79		}
80
81		/**
82		* Get the repository for our entity
83		*
84		* @return EntityRepository
85		*/
86	2	private function getRepository(): EntityRepository
87		{
88	2	return $this->entityManager->getRepository($this->className);
89		}
90		}
91

Ecodev / graphql-doctrine

Push — master ( 5eaa67...092141 )

EntityIDType::parseLiteral() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like