UniqueNameFactory::createParameterName() - Code Metrics - Inspection of "RFC for new filtering feature" - Ecodev/graphql-doctrine - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — master (#10)

by Adrien

created 2018-05-07 08:58 UTC

UniqueNameFactory::createParameterName() A

↳ Parent: UniqueNameFactory

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	3
rs	10
c	0
b	0
f	0
ccs	2
cts	2
cp	1
cc	1
eloc	1
nc	1
nop	0
crap	1

<?php

declare(strict_types=1);

namespace GraphQL\Doctrine\Factory;

/**
 * A factory to create unique but predictable names for aliases and parameters.
 *
 * Uniqueness is guaranteed within the same instance of factory only.
 */
final class UniqueNameFactory
{
    /**
     * @var int[]
     */
    private $aliasCount = [];

    /**
     * @var int
     */
    private $parameterCount = 1;

    /**
     * Return a string to be used as parameter name in a query
     *
     * @return string
     */
    public function createParameterName(): string
    {
        return 'filter' . $this->parameterCount++;
    }

    /**
     * Return a string to be used as alias name in a query
     *
     * @param string $className
     *
     * @return string
     */
    public function createAliasName(string $className): string
    {
        $alias = lcfirst(preg_replace('~^.*\\\\~', '', $className));
        if (!isset($this->aliasCount[$alias])) {
            $this->aliasCount[$alias] = 1;
        }

        return $alias . $this->aliasCount[$alias]++;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace GraphQL\Doctrine\Factory;
6
7		/**
8		* A factory to create unique but predictable names for aliases and parameters.
9		*
10		* Uniqueness is guaranteed within the same instance of factory only.
11		*/
12		final class UniqueNameFactory
13		{
14		/**
15		* @var int[]
16		*/
17		private $aliasCount = [];
18
19		/**
20		* @var int
21		*/
22		private $parameterCount = 1;
23
24		/**
25		* Return a string to be used as parameter name in a query
26		*
27		* @return string
28		*/
29	24	public function createParameterName(): string
30		{
31	24	return 'filter' . $this->parameterCount++;
32		}
33
34		/**
35		* Return a string to be used as alias name in a query
36		*
37		* @param string $className
38		*
39		* @return string
40		*/
41	13	public function createAliasName(string $className): string
42		{
43	13	$alias = lcfirst(preg_replace('~^.*\\\\~', '', $className));
44	13	if (!isset($this->aliasCount[$alias])) {
45	13	$this->aliasCount[$alias] = 1;
46		}
47
48	13	return $alias . $this->aliasCount[$alias]++;
49		}
50		}
51

Ecodev / graphql-doctrine

Pull Request — master (#10)

UniqueNameFactory::createParameterName() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like