AclTest.php$3 ➔ assert() - Code Metrics - Inspection of "Issue 7369" - Ecodev/felix - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Pull Request — master (#14)

by Adrien
created 2022-04-28 11:42 UTC
AclTest.php$3 ➔ assert() A

↳ Parent: anonymous//tests/Acl/AclTest.php$3
Complexity

Conditions
Size

Total Lines
Duplication

Lines	0
Ratio	0 %
Importance

Changes	1
Bugs	0	Features	0
Metric	Value
cc	1
c	1
b	0
f	0
dl	0
loc	3
rs	10
<?php

declare(strict_types=1);

namespace EcodevTests\Felix\Acl;

use Ecodev\Felix\Acl\Acl;
use Ecodev\Felix\Acl\Assertion\IsMyself;
use Ecodev\Felix\Acl\MultipleRoles;
use Ecodev\Felix\Model\CurrentUser;
use EcodevTests\Felix\Blog\Model\User;
use Laminas\Permissions\Acl\Assertion\AssertionInterface;
use Laminas\Permissions\Acl\Resource\ResourceInterface;
use Laminas\Permissions\Acl\Role\RoleInterface;
use PHPUnit\Framework\TestCase;

final class AclTest extends TestCase
{
    protected function tearDown(): void
    {
        CurrentUser::set(null);
    }

    public function testIsCurrentUserAllowed(): void
    {
        $acl = new class() extends Acl {
            public function __construct()
            {
                parent::__construct();
                $user = $this->createModelResource(User::class);
                $this->addRole('anonymous');
                $this->addRole('member');
                $this->allow('member', [$user], ['update'], new IsMyself());
            }
        };

        $user = new User();

        $owner = new User();
        $owner->setName('sarah');
        CurrentUser::set($owner);
        $user->setOwner($owner);

        CurrentUser::set(null);
        self::assertFalse($acl->isCurrentUserAllowed($user, 'update'), 'anonymous cannot update');
        self::assertSame('Non-logged user with role anonymous is not allowed on resource "User#null" with privilege "update"', $acl->getLastDenialMessage());

        CurrentUser::set($owner);
        self::assertFalse($acl->isCurrentUserAllowed($user, 'update'), 'student cannot update even if owner');
        self::assertSame('User "sarah" with role member is not allowed on resource "User#null" with privilege "update" because it is not himself', $acl->getLastDenialMessage());

        $other = new User();
        $other->setName('john');
        CurrentUser::set($other);
        self::assertFalse($acl->isCurrentUserAllowed($user, 'update'), 'other user cannot update');
        self::assertSame('User "john" with role member is not allowed on resource "User#null" with privilege "update" because it is not himself', $acl->getLastDenialMessage());

        // Test again the first case to assert that reject reason does not leak from one assertion to the next
        CurrentUser::set(null);
        self::assertFalse($acl->isCurrentUserAllowed($user, 'update'), 'anonymous cannot update');
        self::assertSame('Non-logged user with role anonymous is not allowed on resource "User#null" with privilege "update"', $acl->getLastDenialMessage());
    }

    public function testMultipleReasons(): void
    {
        $acl = new class($this->createRejectAssertion()) extends Acl {
            public function __construct(private AssertionInterface $reject)
            {
                parent::__construct();
                $user = $this->createModelResource(User::class);
                $this->addRole('anonymous');
                $this->addRole('member', 'anonymous');
                $this->allow('anonymous', [$user], ['update'], $this->reject);
                $this->allow('member', [$user], ['update'], new IsMyself());
            }
        };

        $user = new User();
        $user->setName('sarah');
        CurrentUser::set($user);

        self::assertFalse($acl->isCurrentUserAllowed(new User(), 'update'), 'student cannot update even if user');
        $expected = <<<STRING
            User "sarah" with role member is not allowed on resource "User#null" with privilege "update" because:

            - it is not himself
            - mocked reason
            STRING;
        self::assertSame($expected, $acl->getLastDenialMessage());
    }

    public function testResourceCanBeStringToo(): void
    {
        $acl = new Acl();
        $acl->addRole('anonymous');
        $acl->addResource('my-resource');
        $acl->allow('anonymous', 'my-resource', ['update'], $this->createRejectAssertion());

        self::assertFalse($acl->isCurrentUserAllowed('my-resource', 'update'), 'student cannot update even if user');
        self::assertSame('Non-logged user with role anonymous is not allowed on resource "my-resource" with privilege "update" because mocked reason', $acl->getLastDenialMessage());
    }

    public function testMultipleRoles(): void
    {
        $acl = new class() extends Acl {
            public function __construct()
            {
                parent::__construct();
                $user = $this->createModelResource(User::class);
                $this->addRole('reader');
                $this->addRole('writer');
                $this->allow('writer', [$user], ['update']);
            }
        };

        CurrentUser::set(new User(new MultipleRoles()));
        self::assertFalse($acl->isCurrentUserAllowed(new User(), 'update'));
        self::assertSame('User "" with role [] is not allowed on resource "User#null" with privilege "update"', $acl->getLastDenialMessage());

        CurrentUser::set(new User(new MultipleRoles(['reader'])));
        self::assertFalse($acl->isCurrentUserAllowed(new User(), 'update'));
        self::assertSame('User "" with role [reader] is not allowed on resource "User#null" with privilege "update"', $acl->getLastDenialMessage());

        CurrentUser::set(new User(new MultipleRoles(['reader', 'writer'])));
        self::assertTrue($acl->isCurrentUserAllowed(new User(), 'update'));
        self::assertNull($acl->getLastDenialMessage());

        self::assertFalse($acl->isAllowed(new MultipleRoles(), User::class, 'update'));
        self::assertFalse($acl->isAllowed(new MultipleRoles(['reader']), User::class, 'update'));
        self::assertTrue($acl->isAllowed(new MultipleRoles(['reader', 'writer']), User::class, 'update'));
    }

    public function testIsTranslatable(): void
    {
        $acl = new Acl();
        $acl->addRole('my-role');
        $acl->addResource('my-resource');
        $acl->allow('my-role', 'my-resource', 'my-privilege');

        $acl->setTranslations(['my-resource' => 'translated-resource'], ['my-privilege' => 'translated-privilege']);

        self::assertSame([
            [
                'resource' => 'translated-resource',
                'privileges' => [
                    [
                        'privilege' => 'translated-privilege',
                        'allowed' => true,
                        'allowIf' => [],
                        'denyIf' => [],
                    ],
                ],
            ],
        ], $acl->show('my-role'));

        self::assertSame([
            [
                'resource' => 'my-resource',
                'privileges' => [
                    [
                        'privilege' => 'my-privilege',
                        'allowed' => true,
                        'allowIf' => [],
                        'denyIf' => [],
                    ],
                ],
            ],
        ], $acl->show('my-role', false));
    }

    public function testIncompleteTranslationWillThrowException(): void
    {
        $acl = new Acl();
        $acl->addRole('my-role');
        $acl->addResource('my-resource');
        $acl->allow('my-role', 'my-resource', 'my-privilege');

        $acl->setTranslations(['my-resource' => 'translated-resource'], ['typo-here' => 'translated-privilege']);

        $this->expectExceptionMessage('Was not marked as translatable: my-privilege');
        $acl->show('my-role');
    }

    private function createRejectAssertion(): AssertionInterface
    {
        return new class() implements AssertionInterface {
            /**
             * @param Acl $acl
             */
            public function assert(\Laminas\Permissions\Acl\Acl $acl, ?RoleInterface $role = null, ?ResourceInterface $resource = null, mixed $privilege = null)
            {
                return $acl->reject('mocked reason');
                return $acl->/** @scrutinizer ignore-call */ reject('mocked reason');
            }
        };
    }
}

Ecodev / felix

Pull Request — master (#14)

AclTest.php$3 ➔ assert() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like
