Ecodev\Felix\DBAL\Types\LocalizedType

Complexity

Total Complexity

7

Size/Duplication

Total Lines	29
Duplicated Lines	0 %

Test Coverage

Coverage

84.62%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	convertToDatabaseValue()	0	11	3
A	convertToPHPValue()	0	9	3
A	getName()	0	3	1

<?php

declare(strict_types=1);

namespace Ecodev\Felix\DBAL\Types;

use Doctrine\DBAL\Platforms\AbstractPlatform;
use Doctrine\DBAL\Types\ConversionException;
use Doctrine\DBAL\Types\JsonType;

/**
 * Type specialized to store localized data as JSON.
 *
 * PHP values are expected to be an array of localized values indexed by language. The array
 * might be empty, but it can never be null or empty string.
 *
 * For convenience of DB operation the DB value might be null or an empty string, in which case
 * the PHP value will be an empty array. This allows for easy INSERT/UPDATE, and save two bytes
 * in case of empty array.
 */
final class LocalizedType extends JsonType
{
    public function getName(): string
    {
        return 'localized';
    }

    public function convertToPHPValue($value, AbstractPlatform $platform): array
    {
        if ($value === null || $value === '') {
            return [];
        }

        $val = parent::convertToPHPValue($value, $platform);

        return $val;

The expression return $val could return the type null which is incompatible with the type-hinted return array. Consider adding an additional type-check to rule them out.

    }

    public function convertToDatabaseValue($value, AbstractPlatform $platform): string
    {
        if (!is_array($value)) {
            throw ConversionException::conversionFailedSerialization($value, 'json', 'value must be a PHP array');
        }

        if (!$value) {
            return '';
        }

        return parent::convertToDatabaseValue($value, $platform);
    }
}