ImageResizer::resize() - Code Metrics - Inspection of "Serve thumbnails as WebP when browser support it" - Ecodev/felix - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 1e501a...58b99e )

by Adrien

created 2020-07-09 08:27 UTC

ImageResizer::resize() A

↳ Parent: ImageResizer

Complexity

Conditions	5
Paths	5

Size

Total Lines	18
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	5.0187

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	5
eloc	10
c	1
b	0
f	0
nc	5
nop	3
dl	0
loc	18
ccs	10
cts	11
cp	0.9091
crap	5.0187
rs	9.6111

<?php

declare(strict_types=1);

namespace Ecodev\Felix\Service;

use Ecodev\Felix\Model\Image;
use Imagine\Image\Box;
use Imagine\Image\ImagineInterface;

/**
 * Service to resize image's images
 */
class ImageResizer
{
    private const CACHE_IMAGE_PATH = 'data/cache/images/';

    /**
     * @var ImagineInterface
     */
    private $imagine;

    public function __construct(ImagineInterface $imagine)
    {
        $this->imagine = $imagine;
    }

    /**
     * Resize image as JPG and return the path to the resized version
     */
    public function resize(Image $image, int $maxHeight, bool $useWebp): string
    {
        if ($image->getHeight() <= $maxHeight || $image->getMime() === 'image/svg+xml') {
            return $image->getPath();
        }

        $basename = pathinfo($image->getFilename(), PATHINFO_FILENAME);
        $extension = $useWebp ? '.webp' : '.jpg';
        $path = realpath('.') . '/' . self::CACHE_IMAGE_PATH . $basename . '-' . $maxHeight . $extension;

        if (file_exists($path)) {
            return $path;
        }

        $image = $this->imagine->open($image->getPath());
        $image->thumbnail(new Box(1000000, $maxHeight))->save($path);

        return $path;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Ecodev\Felix\Service;
6
7		use Ecodev\Felix\Model\Image;
8		use Imagine\Image\Box;
9		use Imagine\Image\ImagineInterface;
10
11		/**
12		* Service to resize image's images
13		*/
14		class ImageResizer
15		{
16		private const CACHE_IMAGE_PATH = 'data/cache/images/';
17
18		/**
19		* @var ImagineInterface
20		*/
21		private $imagine;
22
23	12	public function __construct(ImagineInterface $imagine)
24		{
25	12	$this->imagine = $imagine;
26	12	}
27
28		/**
29		* Resize image as JPG and return the path to the resized version
30		*/
31	12	public function resize(Image $image, int $maxHeight, bool $useWebp): string
32		{
33	12	if ($image->getHeight() <= $maxHeight \|\| $image->getMime() === 'image/svg+xml') {
34	10	return $image->getPath();
35		}
36
37	2	$basename = pathinfo($image->getFilename(), PATHINFO_FILENAME);
38	2	$extension = $useWebp ? '.webp' : '.jpg';
39	2	$path = realpath('.') . '/' . self::CACHE_IMAGE_PATH . $basename . '-' . $maxHeight . $extension;
40
41	2	if (file_exists($path)) {
42		return $path;
43		}
44
45	2	$image = $this->imagine->open($image->getPath());
46	2	$image->thumbnail(new Box(1000000, $maxHeight))->save($path);
47
48	2	return $path;
49		}
50		}
51

Ecodev / felix

Push — master ( 1e501a...58b99e )

ImageResizer::resize() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like