Conditions | 1 |
Total Lines | 55 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
54 | private function createMockMessage(): Message |
||
55 | { |
||
56 | return new class() implements Message { |
||
57 | private ?Chronos $dateSent = null; |
||
58 | |||
59 | public function getSubject(): string |
||
60 | { |
||
61 | return 'my subject'; |
||
62 | } |
||
63 | |||
64 | public function getBody(): string |
||
65 | { |
||
66 | return 'my body'; |
||
67 | } |
||
68 | |||
69 | public function setDateSent(?Chronos $dateSent): void |
||
70 | { |
||
71 | $this->dateSent = $dateSent; |
||
72 | } |
||
73 | |||
74 | public function getEmail(): string |
||
75 | { |
||
76 | return '[email protected]'; |
||
77 | } |
||
78 | |||
79 | public function getRecipient(): ?User |
||
80 | { |
||
81 | return null; |
||
82 | } |
||
83 | |||
84 | public function getId(): ?int |
||
85 | { |
||
86 | return null; |
||
87 | } |
||
88 | |||
89 | public function setSubject(string $subject): void |
||
90 | { |
||
91 | } |
||
92 | |||
93 | public function setBody(string $body): void |
||
94 | { |
||
95 | } |
||
96 | |||
97 | public function getDateSent(): ?Chronos |
||
98 | { |
||
99 | return $this->dateSent; |
||
100 | } |
||
101 | |||
102 | public function setEmail(string $email): void |
||
103 | { |
||
104 | } |
||
105 | |||
106 | public function getType(): string |
||
107 | { |
||
108 | return 'my_type'; |
||
109 | } |
||
113 |