Application\Traits\HasSubscriptionLastReview

Complexity

Total Complexity

4

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Test Coverage

Coverage

42.86%

Importance

Changes	2
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	setSubscriptionLastReview()	0	7	3
A	getSubscriptionLastReviewNumber()	0	6	1

<?php

declare(strict_types=1);

namespace Application\Traits;

use Application\Model\Product;
use Application\Repository\ProductRepository;
use Doctrine\ORM\Mapping as ORM;
use InvalidArgumentException;

trait HasSubscriptionLastReview
{
    /**
     * @var null|Product
     *
     * @ORM\ManyToOne(targetEntity="Product")
     * @ORM\JoinColumns({
     *     @ORM\JoinColumn(nullable=true, onDelete="SET NULL")
     * })
     */
    private $subscriptionLastReview;

    /**
     * Get last review number available through a subscription, bypassing all ACL so it also work even if review is not active yet
     */
    public function getSubscriptionLastReviewNumber(): ?int
    {
        /** @var ProductRepository $productRepository */
        $productRepository = _em()->getRepository(Product::class);

        return $productRepository->getSubscriptionLastReviewNumber($this);

$this of type Application\Traits\HasSubscriptionLastReview is incompatible with the type Application\Model\AbstractModel expected by parameter $hasSubscriptionLastReview of Application\Repository\ProductRepository::getSubscriptionLastReviewNumber().

    }

    /**
     * Set last review available through a subscription
     *
     * @API\Exclude
     */
    public function setSubscriptionLastReview(?Product $subscriptionLastReview): void
    {
        if ($subscriptionLastReview && !$subscriptionLastReview->getReviewNumber()) {

The expression $subscriptionLastReview->getReviewNumber() of type integer|null is loosely compared to false; this is ambiguous if the integer can be 0. You might want to explicitly use === null instead.

            throw new InvalidArgumentException('The last review of a subscription must be a review, not an article');
        }

        $this->subscriptionLastReview = $subscriptionLastReview;
    }
}