Ecodev / artisans

bin/test-nginx-rules.php

#! /usr/bin/env php
<?php

/**
 * Script to test the most important nginx rules
 */
function run(string $cmd): string
{
    echo $cmd . PHP_EOL;

    return shell_exec($cmd);

The expression return shell_exec($cmd) could return the type null which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

}

function test(bool $loggedIn, string $url): void
{
    if ($loggedIn) {
        $cookie = "--cookie 'PHPSESSID=foo'";
        $pattern = '<img src="assets/logo-artisans-de-la-transition.svg"';
        $message = 'logged in user should get raw Angular';
    } else {
        $cookie = '';
        $pattern = '<natural-icon';
        $message = 'anonymous should get pre-rendered page by SSR';
    }

    // Assert HTTP status code
    $status = run("curl --insecure --silent --output /dev/null --write-out '%{http_code}' '$url' $cookie");
    if ($status !== '200') {
        echo "FAILED STATUS CODE: $status: $message" . PHP_EOL;
        exit(1);

Using exit here is not recommended.

    }

    // Assert HTML content
    $content = run("curl --insecure --silent '$url' $cookie");
    if (mb_strpos($content, $pattern) === false) {
        echo "FAILED PATTERN: '$pattern': $message" . PHP_EOL;
        exit(1);

Using exit here is not recommended.

    }
}

test(true, 'https://artisans.lan');
test(true, 'https://artisans.lan/larevuedurable/numeros');
test(true, 'https://artisans.lan/mon-compte');

test(false, 'https://artisans.lan');
test(false, 'https://artisans.lan/larevuedurable/numeros');
test(false, 'https://artisans.lan/mon-compte');

echo 'All tests OK' . PHP_EOL;