Conditions | 1 |
Paths | 1 |
Total Lines | 203 |
Code Lines | 121 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
39 | public static function providerCreateOrder(): iterable |
||
40 | { |
||
41 | return [ |
||
42 | 'free product should create order, even with transactions for zero dollars' => [ |
||
43 | [ |
||
44 | 'paymentMethod' => PaymentMethod::Bvr, |
||
45 | 'orderLines' => [ |
||
46 | [ |
||
47 | 'quantity' => 1, |
||
48 | 'isCHF' => true, |
||
49 | 'type' => ProductType::Digital, |
||
50 | 'product' => [ |
||
51 | 'name' => 'My product', |
||
52 | 'pricePerUnitCHF' => Money::CHF(0), |
||
53 | 'pricePerUnitEUR' => Money::EUR(0), |
||
54 | ], |
||
55 | 'additionalEmails' => [], |
||
56 | ], |
||
57 | ], |
||
58 | ], |
||
59 | [ |
||
60 | [ |
||
61 | 'My product', |
||
62 | 1, |
||
63 | '0', |
||
64 | '0', |
||
65 | true, |
||
66 | ProductType::Digital, |
||
67 | ], |
||
68 | ], |
||
69 | ], |
||
70 | 'normal' => [ |
||
71 | [ |
||
72 | 'paymentMethod' => PaymentMethod::Bvr, |
||
73 | 'orderLines' => [ |
||
74 | [ |
||
75 | 'quantity' => 3, |
||
76 | 'isCHF' => true, |
||
77 | 'type' => ProductType::Digital, |
||
78 | 'product' => [ |
||
79 | 'name' => 'My product 1', |
||
80 | 'pricePerUnitCHF' => Money::CHF(275), |
||
81 | 'pricePerUnitEUR' => Money::EUR(280), |
||
82 | ], |
||
83 | 'additionalEmails' => [], |
||
84 | ], |
||
85 | [ |
||
86 | 'quantity' => 1, |
||
87 | 'isCHF' => true, |
||
88 | 'type' => ProductType::Digital, |
||
89 | 'product' => [ |
||
90 | 'name' => 'My product 2', |
||
91 | 'pricePerUnitCHF' => Money::CHF(20000), |
||
92 | 'pricePerUnitEUR' => Money::EUR(25000), |
||
93 | ], |
||
94 | 'additionalEmails' => [], |
||
95 | ], |
||
96 | ], |
||
97 | ], |
||
98 | [ |
||
99 | [ |
||
100 | 'My product 1', |
||
101 | 3, |
||
102 | '825', |
||
103 | '0', |
||
104 | true, |
||
105 | ProductType::Digital, |
||
106 | ], |
||
107 | [ |
||
108 | 'My product 2', |
||
109 | 1, |
||
110 | '20000', |
||
111 | '0', |
||
112 | true, |
||
113 | ProductType::Digital, |
||
114 | ], |
||
115 | ], |
||
116 | ], |
||
117 | 'with mixed CHF/EURO prices' => [ |
||
118 | [ |
||
119 | 'paymentMethod' => PaymentMethod::Bvr, |
||
120 | 'orderLines' => [ |
||
121 | [ |
||
122 | 'quantity' => 3, |
||
123 | 'isCHF' => false, |
||
124 | 'type' => ProductType::Digital, |
||
125 | 'product' => [ |
||
126 | 'name' => 'My product 1', |
||
127 | 'pricePerUnitCHF' => Money::CHF(275), |
||
128 | 'pricePerUnitEUR' => Money::EUR(280), |
||
129 | ], |
||
130 | 'additionalEmails' => [], |
||
131 | ], |
||
132 | [ |
||
133 | 'quantity' => 1, |
||
134 | 'isCHF' => true, |
||
135 | 'type' => ProductType::Paper, |
||
136 | 'product' => [ |
||
137 | 'name' => 'My product 2', |
||
138 | 'pricePerUnitCHF' => Money::CHF(20000), |
||
139 | 'pricePerUnitEUR' => Money::EUR(25000), |
||
140 | ], |
||
141 | 'additionalEmails' => [], |
||
142 | ], |
||
143 | ], |
||
144 | ], |
||
145 | [ |
||
146 | [ |
||
147 | 'My product 1', |
||
148 | 3, |
||
149 | '0', |
||
150 | '840', |
||
151 | false, |
||
152 | ProductType::Digital, |
||
153 | ], |
||
154 | [ |
||
155 | 'My product 2', |
||
156 | 1, |
||
157 | '20000', |
||
158 | '0', |
||
159 | true, |
||
160 | ProductType::Paper, |
||
161 | ], |
||
162 | ], |
||
163 | ], |
||
164 | 'negative balance should swap accounts' => [ |
||
165 | [ |
||
166 | 'paymentMethod' => PaymentMethod::Bvr, |
||
167 | 'orderLines' => [ |
||
168 | [ |
||
169 | 'quantity' => 1, |
||
170 | 'isCHF' => true, |
||
171 | 'type' => ProductType::Digital, |
||
172 | 'product' => [ |
||
173 | 'name' => 'My product', |
||
174 | 'pricePerUnitCHF' => Money::CHF(-10000), |
||
175 | 'pricePerUnitEUR' => Money::EUR(-15000), |
||
176 | ], |
||
177 | 'additionalEmails' => [], |
||
178 | ], |
||
179 | ], |
||
180 | ], |
||
181 | [ |
||
182 | [ |
||
183 | 'My product', |
||
184 | 1, |
||
185 | '-10000', |
||
186 | '0', |
||
187 | true, |
||
188 | ProductType::Digital, |
||
189 | ], |
||
190 | ], |
||
191 | ], |
||
192 | 'can create order for subscription' => [ |
||
193 | [ |
||
194 | 'paymentMethod' => PaymentMethod::Bvr, |
||
195 | 'orderLines' => [ |
||
196 | [ |
||
197 | 'quantity' => 1, |
||
198 | 'isCHF' => true, |
||
199 | 'type' => ProductType::Digital, |
||
200 | 'subscription' => [ |
||
201 | 'name' => 'My subscription', |
||
202 | 'pricePerUnitCHF' => Money::CHF(10000), |
||
203 | 'pricePerUnitEUR' => Money::EUR(15000), |
||
204 | 'type' => ProductType::Both, |
||
205 | ], |
||
206 | 'additionalEmails' => [], |
||
207 | ], |
||
208 | ], |
||
209 | ], |
||
210 | [ |
||
211 | [ |
||
212 | 'My subscription', |
||
213 | 1, |
||
214 | '10000', |
||
215 | '0', |
||
216 | true, |
||
217 | ProductType::Both, |
||
218 | ], |
||
219 | ], |
||
220 | ], |
||
221 | 'can create order for donation' => [ |
||
222 | [ |
||
223 | 'paymentMethod' => PaymentMethod::Bvr, |
||
224 | 'orderLines' => [ |
||
225 | [ |
||
226 | 'quantity' => 1, |
||
227 | 'isCHF' => true, |
||
228 | 'type' => ProductType::Digital, |
||
229 | 'pricePerUnit' => Money::CHF(10000), |
||
230 | 'additionalEmails' => [], |
||
231 | ], |
||
232 | ], |
||
233 | ], |
||
234 | [ |
||
235 | [ |
||
236 | 'Don', |
||
237 | 1, |
||
238 | '10000', |
||
239 | '0', |
||
240 | true, |
||
241 | ProductType::Digital, |
||
242 | ], |
||
411 |