HasSubscriptionLastReview::setSubscriptionLastReview() - Code Metrics - Ecodev/artisans - Measure and Improve Code Quality continuously with Scrutinizer

setSubscriptionLastReview() A
last analyzed 2025-06-13 14:28 UTC

↳ Parent: HasSubscriptionLastReview

Complexity

Conditions	3
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
eloc	4
dl	0
loc	8
ccs	0
cts	4
cp	0
rs	10
c	0
b	0
f	0
cc	3
nc	2
nop	1
crap	12

<?php

declare(strict_types=1);

namespace Application\Traits;

use Application\Model\Product;
use Application\Repository\ProductRepository;
use Doctrine\ORM\Mapping as ORM;
use GraphQL\Doctrine\Attribute as API;
use InvalidArgumentException;

trait HasSubscriptionLastReview
{
    #[ORM\JoinColumn(onDelete: 'SET NULL')]
    #[ORM\ManyToOne(targetEntity: Product::class)]
    private ?Product $subscriptionLastReview = null;

    /**
     * Get last review number available through a subscription, bypassing all ACL so it also work even if review is not active yet.
     */
    public function getSubscriptionLastReviewNumber(): ?int
    {
        /** @var ProductRepository $productRepository */
        $productRepository = _em()->getRepository(Product::class);

        return $productRepository->getSubscriptionLastReviewNumber($this);
    }

    /**
     * Set last review available through a subscription.
     */
    #[API\Exclude]
    public function setSubscriptionLastReview(?Product $subscriptionLastReview): void
    {
        if ($subscriptionLastReview && !$subscriptionLastReview->getReviewNumber()) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
            throw new InvalidArgumentException('The last review of a subscription must be a review, not an article');
        }

        $this->subscriptionLastReview = $subscriptionLastReview;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Application\Traits;
6
7		use Application\Model\Product;
8		use Application\Repository\ProductRepository;
9		use Doctrine\ORM\Mapping as ORM;
10		use GraphQL\Doctrine\Attribute as API;
11		use InvalidArgumentException;
12
13		trait HasSubscriptionLastReview
14		{
15		#[ORM\JoinColumn(onDelete: 'SET NULL')]
16		#[ORM\ManyToOne(targetEntity: Product::class)]
17		private ?Product $subscriptionLastReview = null;
18
19		/**
20		* Get last review number available through a subscription, bypassing all ACL so it also work even if review is not active yet.
21		*/
22	2	public function getSubscriptionLastReviewNumber(): ?int
23		{
24		/** @var ProductRepository $productRepository */
25	2	$productRepository = _em()->getRepository(Product::class);
26
27	2	return $productRepository->getSubscriptionLastReviewNumber($this);
28		}
29
30		/**
31		* Set last review available through a subscription.
32		*/
33		#[API\Exclude]
34		public function setSubscriptionLastReview(?Product $subscriptionLastReview): void
35		{
36		if ($subscriptionLastReview && !$subscriptionLastReview->getReviewNumber()) {
		0 ignored issues – show Bug Best Practice introduced 2020-04-27 13:23 UTC by Report Bug Copy Issue Report The expression `$subscriptionLastReview->getReviewNumber()` of type `integer\|null` is loosely compared to `false`; this is ambiguous if the integer can be 0. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
37		throw new InvalidArgumentException('The last review of a subscription must be a review, not an article');
38		}
39
40		$this->subscriptionLastReview = $subscriptionLastReview;
41		}
42		}
43

Ecodev / artisans

setSubscriptionLastReview() A last analyzed 2025-06-13 14:28 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

setSubscriptionLastReview() A
last analyzed 2025-06-13 14:28 UTC