logged-in-user.php ➔ ip_is_private() - Code Metrics - Inspection of "Public IPs rather than private" - East-Kent-Partnership/Intranet - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( c862a9...ab6497 )

by William

created 2017-03-07 08:48 UTC

logged-in-user.php ➔ ip_is_private() A

↳ Parent: Project

Complexity

Conditions	2
Paths	2

Size

Total Lines	15
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	11
nc	2
nop	0
dl	0
loc	15
rs	9.4285
c	0
b	0
f	0

<?php

function ip_is_private() {
    $safe_ip = array(
        '194.82.168.3', //Canterbury
        '194.82.171.2', //Sheppey
        '195.194.248.2', //Broadstairs
        '', //Dover
        '195.194.250.2', //Folkstone
    );

    if (in_array($_SERVER['REMOTE_ADDR'], $safe_ip)) {
        return true;
    } else {
        return false;
    }
}

$u = new User();
global $u;

if ($u->isLoggedIn()) {
    echo '<p class="welcome-username">Welcome ' . $u->getUserName() . '</p>';
} else {
    echo '<p class="welcome-username"><a href="/login">Click here to Login</a></p>';

    $page = Page::getCurrentPage();

    if ($page->getCollectionName() == 'Home') {

        $ip = $_SERVER['REMOTE_ADDR'];
        if (ip_is_private() === FALSE) {
            header('Location: /login');
            die();
        }
    }
}
if ($u->inGroup(Group::getByName('Students'))) {
    header('Location: /dashboard/permissions');
    die();
}
?>



1			<?php
2
3			function ip_is_private() {
4			$safe_ip = array(
5			'194.82.168.3', //Canterbury
6			'194.82.171.2', //Sheppey
7			'195.194.248.2', //Broadstairs
8			'', //Dover
9			'195.194.250.2', //Folkstone
10			);
11
12			if (in_array($_SERVER['REMOTE_ADDR'], $safe_ip)) {
13			return true;
14			} else {
15			return false;
16			}
17			}
18
19			$u = new User();
20			global $u;
21
22			if ($u->isLoggedIn()) {
23			echo '<p class="welcome-username">Welcome ' . $u->getUserName() . '</p>';
24			} else {
25			echo '<p class="welcome-username"><a href="/login">Click here to Login</a></p>';
26
27			$page = Page::getCurrentPage();
28
29			if ($page->getCollectionName() == 'Home') {
30
31			$ip = $_SERVER['REMOTE_ADDR'];
32			if (ip_is_private() === FALSE) {
33			header('Location: /login');
34			die();
35			}
36			}
37			}
38			if ($u->inGroup(Group::getByName('Students'))) {
39			header('Location: /dashboard/permissions');
40			die();
41			}
42			?>
			0 ignored issues – show Best Practice introduced 2017-02-24 14:27 UTC by Report Bug Copy Issue Report It is not recommended to use PHP's closing tag `?>` in files other than templates. Using a closing tag in PHP files that only contain PHP code is not recommended as you might accidentally add whitespace after the closing tag which would then be output by PHP. This can cause severe problems, for example headers cannot be sent anymore. A simple precaution is to leave off the closing tag as it is not required, and it also has no negative effects whatsoever. Loading history...
43

East-Kent-Partnership / Intranet

Push — master ( c862a9...ab6497 )

logged-in-user.php ➔ ip_is_private() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like