Inspection of "Remove GroceryCrud Model" - East-Kent-Partnership/Intranet - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 63a7db...fb547d )

by William

created 2017-03-18 14:36 UTC

Status

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -7,7 +7,7 @@
 block discarded – undo
 $query = $this->db->get('users_ad');
 if ($query->num_rows() > 0) {
     foreach ($query->result_array() as $row) {
-        $row_set[] = htmlentities(stripslashes($row['first_name'] . ' ' . $row['last_name'] . ' (' . $row['username'] . ')')); //build an array
+        $row_set[] = htmlentities(stripslashes($row['first_name'].' '.$row['last_name'].' ('.$row['username'].')')); //build an array
     }
 }
 ?>

Please login to merge, or discard this patch.

dashboard/application/views/computing-support/ownership/view.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -7,7 +7,7 @@
 block discarded – undo
     $query = $this->db->get('users_ad');
     if ($query->num_rows() > 0) {
         foreach ($query->result_array() as $row) {
-            $row_set[] = htmlentities(stripslashes($row['first_name'] . ' ' . $row['last_name']. ' (' . $row['username']. ')')); //build an array
+            $row_set[] = htmlentities(stripslashes($row['first_name'].' '.$row['last_name'].' ('.$row['username'].')')); //build an array
         }
     }
 ?>

Please login to merge, or discard this patch.

dashboard/assets/grocery_crud/themes/dashboard/views/edit.php 1 patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -16,23 +16,23 @@  discard block
 block discarded – undo
 			</div>
 			<div class='clear'></div>
 		</div>
-		<div title="<?php echo $this->l('minimize_maximize');?>" class="ptogtitle">
+		<div title="<?php echo $this->l('minimize_maximize'); ?>" class="ptogtitle">
 			<span></span>
 		</div>
 	</div>
 <div id='main-table-box'>
-	<?php echo form_open( $update_url, 'method="post" id="crudForm"  enctype="multipart/form-data"'); ?>
+	<?php echo form_open($update_url, 'method="post" id="crudForm"  enctype="multipart/form-data"'); ?>
 	<div class='form-div'>
 		<?php
 		$counter = 0;
-			foreach($fields as $field)
+			foreach ($fields as $field)
 			{
 				$even_odd = $counter % 2 == 0 ? 'odd' : 'even';
 				$counter++;
 		?>
 			<div class='form-field-box <?php echo $even_odd?>' id="<?php echo $field->field_name; ?>_field_box">
 				<div class='form-display-as-box' id="<?php echo $field->field_name; ?>_display_as_box">
-					<?php echo $input_fields[$field->field_name]->display_as?><?php echo ($input_fields[$field->field_name]->required)? "<span class='required'>*</span> " : ""?> :
+					<?php echo $input_fields[$field->field_name]->display_as?><?php echo ($input_fields[$field->field_name]->required) ? "<span class='required'>*</span> " : ""?> :
 				</div>
 				<div class='form-input-box' id="<?php echo $field->field_name; ?>_input_box">
 					<?php echo $input_fields[$field->field_name]->input?>
@@ -40,10 +40,10 @@  discard block
 block discarded – undo
 				<div class='clear'></div>
 			</div>
 		<?php }?>
-		<?php if(!empty($hidden_fields)){?>
+		<?php if (!empty($hidden_fields)) {?>
 		<!-- Start of hidden inputs -->
 			<?php
-				foreach($hidden_fields as $hidden_field){
+				foreach ($hidden_fields as $hidden_field) {
 					echo $hidden_field->input;
 				}
 			?>
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
 		<div class='form-button-box'>
 			<input  id="form-button-save" type='submit' value='<?php echo $this->l('form_update_changes'); ?>' class="btn btn-large"/>
 		</div>
-<?php 	if(!$this->unset_back_to_list) { ?>
+<?php 	if (!$this->unset_back_to_list) { ?>
 		<div class='form-button-box'>
 			<input type='button' value='<?php echo $this->l('form_update_and_go_back'); ?>' id="save-and-go-back-button" class="btn btn-large"/>
 		</div>

Please login to merge, or discard this patch.

dashboard/assets/grocery_crud/themes/dashboard/views/read.php 1 patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -15,23 +15,23 @@  discard block
 block discarded – undo
 			</div>
 			<div class='clear'></div>
 		</div>
-		<div title="<?php echo $this->l('minimize_maximize');?>" class="ptogtitle">
+		<div title="<?php echo $this->l('minimize_maximize'); ?>" class="ptogtitle">
 			<span></span>
 		</div>
 	</div>
 <div id='main-table-box'>
-	<?php echo form_open( $read_url, 'method="post" id="crudForm"  enctype="multipart/form-data"'); ?>
+	<?php echo form_open($read_url, 'method="post" id="crudForm"  enctype="multipart/form-data"'); ?>
 	<div class='form-div'>
 		<?php
 		$counter = 0;
-			foreach($fields as $field)
+			foreach ($fields as $field)
 			{
 				$even_odd = $counter % 2 == 0 ? 'odd' : 'even';
 				$counter++;
 		?>
 			<div class='form-field-box <?php echo $even_odd?>' id="<?php echo $field->field_name; ?>_field_box">
 				<div class='form-display-as-box' id="<?php echo $field->field_name; ?>_display_as_box">
-					<?php echo $input_fields[$field->field_name]->display_as?><?php echo ($input_fields[$field->field_name]->required)? "<span class='required'>*</span> " : ""?> :
+					<?php echo $input_fields[$field->field_name]->display_as?><?php echo ($input_fields[$field->field_name]->required) ? "<span class='required'>*</span> " : ""?> :
 				</div>
 				<div class='form-input-box' id="<?php echo $field->field_name; ?>_input_box">
 					<?php echo $input_fields[$field->field_name]->input?>
@@ -39,10 +39,10 @@  discard block
 block discarded – undo
 				<div class='clear'></div>
 			</div>
 		<?php }?>
-		<?php if(!empty($hidden_fields)){?>
+		<?php if (!empty($hidden_fields)) {?>
 		<!-- Start of hidden inputs -->
 			<?php
-				foreach($hidden_fields as $hidden_field){
+				foreach ($hidden_fields as $hidden_field) {
 					echo $hidden_field->input;
 				}
 			?>

Please login to merge, or discard this patch.

dashboard/assets/grocery_crud/themes/dashboard/views/add.php 1 patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -16,23 +16,23 @@  discard block
 block discarded – undo
 			</div>
 			<div class='clear'></div>
 		</div>
-		<div title="<?php echo $this->l('minimize_maximize');?>" class="ptogtitle">
+		<div title="<?php echo $this->l('minimize_maximize'); ?>" class="ptogtitle">
 			<span></span>
 		</div>
 	</div>
 <div id='main-table-box'>
-	<?php echo form_open( $insert_url, 'method="post" id="crudForm"  enctype="multipart/form-data"'); ?>
+	<?php echo form_open($insert_url, 'method="post" id="crudForm"  enctype="multipart/form-data"'); ?>
 		<div class='form-div'>
 			<?php
 			$counter = 0;
-				foreach($fields as $field)
+				foreach ($fields as $field)
 				{
 					$even_odd = $counter % 2 == 0 ? 'odd' : 'even';
 					$counter++;
 			?>
 			<div class='form-field-box <?php echo $even_odd?>' id="<?php echo $field->field_name; ?>_field_box">
 				<div class='form-display-as-box' id="<?php echo $field->field_name; ?>_display_as_box">
-					<?php echo $input_fields[$field->field_name]->display_as; ?><?php echo ($input_fields[$field->field_name]->required)? "<span class='required'>*</span> " : ""; ?> :
+					<?php echo $input_fields[$field->field_name]->display_as; ?><?php echo ($input_fields[$field->field_name]->required) ? "<span class='required'>*</span> " : ""; ?> :
 				</div>
 				<div class='form-input-box' id="<?php echo $field->field_name; ?>_input_box">
 					<?php echo $input_fields[$field->field_name]->input?>
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
 			<?php }?>
 			<!-- Start of hidden inputs -->
 				<?php
-					foreach($hidden_fields as $hidden_field){
+					foreach ($hidden_fields as $hidden_field) {
 						echo $hidden_field->input;
 					}
 				?>
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
 			<div class='form-button-box'>
 				<input id="form-button-save" type='submit' value='<?php echo $this->l('form_save'); ?>'  class="btn btn-large"/>
 			</div>
-<?php 	if(!$this->unset_back_to_list) { ?>
+<?php 	if (!$this->unset_back_to_list) { ?>
 			<div class='form-button-box'>
 				<input type='button' value='<?php echo $this->l('form_save_and_go_back'); ?>' id="save-and-go-back-button"  class="btn btn-large"/>
 			</div>

Please login to merge, or discard this patch.

dashboard/application/views/templates/table_assets.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -1,8 +1,8 @@
 block discarded – undo
 <?php defined('BASEPATH') OR exit('No direct script access allowed'); ?>
 
-<?php foreach($css_files as $file): ?>
+<?php foreach ($css_files as $file): ?>
     <link type="text/css" rel="stylesheet" href="<?= $file; ?>" />
 <?php endforeach; ?>
-<?php foreach($js_files as $file): ?>
+<?php foreach ($js_files as $file): ?>
     <script src="<?= $file; ?>"></script>
 <?php endforeach;
\ No newline at end of file

Please login to merge, or discard this patch.

		@@ -7,7 +7,7 @@
		block discarded – undo
7	7	$query = $this->db->get('users_ad');
8	8	if ($query->num_rows() > 0) {
9	9	foreach ($query->result_array() as $row) {
10		- $row_set[] = htmlentities(stripslashes($row['first_name'] . ' ' . $row['last_name'] . ' (' . $row['username'] . ')')); //build an array
	10	+ $row_set[] = htmlentities(stripslashes($row['first_name'].' '.$row['last_name'].' ('.$row['username'].')')); //build an array
11	11	}
12	12	}
13	13	?>

		@@ -16,23 +16,23 @@ discard block
		block discarded – undo
16	16	</div>
17	17	<div class='clear'></div>
18	18	</div>
19		- <div title="<?php echo $this->l('minimize_maximize');?>" class="ptogtitle">
	19	+ <div title="<?php echo $this->l('minimize_maximize'); ?>" class="ptogtitle">
20	20	<span></span>
21	21	</div>
22	22	</div>
23	23	<div id='main-table-box'>
24		- <?php echo form_open( $update_url, 'method="post" id="crudForm" enctype="multipart/form-data"'); ?>
	24	+ <?php echo form_open($update_url, 'method="post" id="crudForm" enctype="multipart/form-data"'); ?>
25	25	<div class='form-div'>
26	26	<?php
27	27	$counter = 0;
28		- foreach($fields as $field)
	28	+ foreach ($fields as $field)
29	29	{
30	30	$even_odd = $counter % 2 == 0 ? 'odd' : 'even';
31	31	$counter++;
32	32	?>
33	33	<div class='form-field-box <?php echo $even_odd?>' id="<?php echo $field->field_name; ?>_field_box">
34	34	<div class='form-display-as-box' id="<?php echo $field->field_name; ?>_display_as_box">
35		- <?php echo $input_fields[$field->field_name]->display_as?><?php echo ($input_fields[$field->field_name]->required)? "<span class='required'>*</span> " : ""?> :
	35	+ <?php echo $input_fields[$field->field_name]->display_as?><?php echo ($input_fields[$field->field_name]->required) ? "<span class='required'>*</span> " : ""?> :
36	36	</div>
37	37	<div class='form-input-box' id="<?php echo $field->field_name; ?>_input_box">
38	38	<?php echo $input_fields[$field->field_name]->input?>
		@@ -40,10 +40,10 @@ discard block
		block discarded – undo
40	40	<div class='clear'></div>
41	41	</div>
42	42	<?php }?>
43		- <?php if(!empty($hidden_fields)){?>
	43	+ <?php if (!empty($hidden_fields)) {?>
44	44	<!-- Start of hidden inputs -->
45	45	<?php
46		- foreach($hidden_fields as $hidden_field){
	46	+ foreach ($hidden_fields as $hidden_field) {
47	47	echo $hidden_field->input;
48	48	}
49	49	?>
		@@ -57,7 +57,7 @@ discard block
		block discarded – undo
57	57	<div class='form-button-box'>
58	58	<input id="form-button-save" type='submit' value='<?php echo $this->l('form_update_changes'); ?>' class="btn btn-large"/>
59	59	</div>
60		-<?php if(!$this->unset_back_to_list) { ?>
	60	+<?php if (!$this->unset_back_to_list) { ?>
61	61	<div class='form-button-box'>
62	62	<input type='button' value='<?php echo $this->l('form_update_and_go_back'); ?>' id="save-and-go-back-button" class="btn btn-large"/>
63	63	</div>

		@@ -15,23 +15,23 @@ discard block
		block discarded – undo
15	15	</div>
16	16	<div class='clear'></div>
17	17	</div>
18		- <div title="<?php echo $this->l('minimize_maximize');?>" class="ptogtitle">
	18	+ <div title="<?php echo $this->l('minimize_maximize'); ?>" class="ptogtitle">
19	19	<span></span>
20	20	</div>
21	21	</div>
22	22	<div id='main-table-box'>
23		- <?php echo form_open( $read_url, 'method="post" id="crudForm" enctype="multipart/form-data"'); ?>
	23	+ <?php echo form_open($read_url, 'method="post" id="crudForm" enctype="multipart/form-data"'); ?>
24	24	<div class='form-div'>
25	25	<?php
26	26	$counter = 0;
27		- foreach($fields as $field)
	27	+ foreach ($fields as $field)
28	28	{
29	29	$even_odd = $counter % 2 == 0 ? 'odd' : 'even';
30	30	$counter++;
31	31	?>
32	32	<div class='form-field-box <?php echo $even_odd?>' id="<?php echo $field->field_name; ?>_field_box">
33	33	<div class='form-display-as-box' id="<?php echo $field->field_name; ?>_display_as_box">
34		- <?php echo $input_fields[$field->field_name]->display_as?><?php echo ($input_fields[$field->field_name]->required)? "<span class='required'>*</span> " : ""?> :
	34	+ <?php echo $input_fields[$field->field_name]->display_as?><?php echo ($input_fields[$field->field_name]->required) ? "<span class='required'>*</span> " : ""?> :
35	35	</div>
36	36	<div class='form-input-box' id="<?php echo $field->field_name; ?>_input_box">
37	37	<?php echo $input_fields[$field->field_name]->input?>
		@@ -39,10 +39,10 @@ discard block
		block discarded – undo
39	39	<div class='clear'></div>
40	40	</div>
41	41	<?php }?>
42		- <?php if(!empty($hidden_fields)){?>
	42	+ <?php if (!empty($hidden_fields)) {?>
43	43	<!-- Start of hidden inputs -->
44	44	<?php
45		- foreach($hidden_fields as $hidden_field){
	45	+ foreach ($hidden_fields as $hidden_field) {
46	46	echo $hidden_field->input;
47	47	}
48	48	?>

		@@ -1,8 +1,8 @@
		block discarded – undo
1	1	<?php defined('BASEPATH') OR exit('No direct script access allowed'); ?>
2	2
3		-<?php foreach($css_files as $file): ?>
	3	+<?php foreach ($css_files as $file): ?>
4	4	<link type="text/css" rel="stylesheet" href="<?= $file; ?>" />
5	5	<?php endforeach; ?>
6		-<?php foreach($js_files as $file): ?>
	6	+<?php foreach ($js_files as $file): ?>
7	7	<script src="<?= $file; ?>"></script>
8	8	<?php endforeach;
9	9	\ No newline at end of file

East-Kent-Partnership / Intranet

Push — master ( 63a7db...fb547d )

Status

Category

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch