Jobs_model

Complexity

Total Complexity

35

Size/Duplication

Total Lines	113
Duplicated Lines	48.67 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
D	update_active_ad_users()	55	106	34

<?php

defined('BASEPATH') OR exit('No direct script access allowed');

class Jobs_model extends CI_Model {

    public function __construct() {
        parent::__construct();
    }

    function update_active_ad_users() {

It is generally recommended to explicitly declare the visibility for methods.

        $ldap_password = $this->config->item('ldapbindpass');
        $ldap_username = $this->config->item('ldapshortdomain').$this->config->item('ldapbindun');
        $ldap_connection = ldap_connect($this->config->item('ldapserver'));

        ldap_set_option($ldap_connection, LDAP_OPT_PROTOCOL_VERSION, 3) or die('Unable to set LDAP protocol version');
        ldap_set_option($ldap_connection, LDAP_OPT_REFERRALS, 0);

        if (TRUE === ldap_bind($ldap_connection, $ldap_username, $ldap_password)) {
            $search_filter = '(&(objectCategory=person)(samaccountname=*))';
            $attributes = array();
            $attributes[] = 'givenname';
            $attributes[] = 'samaccountname';
            $attributes[] = 'sn';
            $attributes[] = 'mail';
            $ad_users = array();

            //empty database
            $this->db->truncate('users_ad');

            $result_admin = ldap_search($ldap_connection, $this->config->item('ldapuserjobouone'), $search_filter, $attributes);
            if (FALSE !== $result_admin) {

This code seems to be duplicated across your project.

                $entries = ldap_get_entries($ldap_connection, $result_admin);
                for ($x = 0; $x < $entries['count']; $x++) {
                    if (!empty($entries[$x]['givenname'][0]) &&
                            !empty($entries[$x]['samaccountname'][0]) &&
                            !empty($entries[$x]['sn'][0]) &&
                            !empty($entries[$x]['mail'][0])) {  
                        $ad_users[] = array('first_name' => trim($entries[$x]['givenname'][0]), 'last_name' => trim($entries[$x]['sn'][0]), 'full_name' => trim($entries[$x]['givenname'][0]).' '. trim($entries[$x]['sn'][0]), 'username' => trim($entries[$x]['samaccountname'][0]), 'email' => trim($entries[$x]['mail'][0]));
                    }
                }
            }
            $result_canterbury = ldap_search($ldap_connection, $this->config->item('ldapuserjoboutwo'), $search_filter, $attributes);
            if (FALSE !== $result_canterbury) {

This code seems to be duplicated across your project.

                $entries = ldap_get_entries($ldap_connection, $result_canterbury);
                for ($x = 0; $x < $entries['count']; $x++) {
                    if (!empty($entries[$x]['givenname'][0]) &&
                            !empty($entries[$x]['samaccountname'][0]) &&
                            !empty($entries[$x]['sn'][0]) &&
                            !empty($entries[$x]['mail'][0])) {
                        $ad_users[] = array('first_name' => trim($entries[$x]['givenname'][0]), 'last_name' => trim($entries[$x]['sn'][0]), 'full_name' => trim($entries[$x]['givenname'][0]).' '. trim($entries[$x]['sn'][0]), 'username' => trim($entries[$x]['samaccountname'][0]), 'email' => trim($entries[$x]['mail'][0]));
                    }
                }
            }
            $result_sheppy = ldap_search($ldap_connection, $this->config->item('ldapuserjobouthree'), $search_filter, $attributes);
            if (FALSE !== $result_sheppy) {

This code seems to be duplicated across your project.

                $entries = ldap_get_entries($ldap_connection, $result_sheppy);
                for ($x = 0; $x < $entries['count']; $x++) {
                    if (!empty($entries[$x]['givenname'][0]) &&
                            !empty($entries[$x]['samaccountname'][0]) &&
                            !empty($entries[$x]['sn'][0]) &&
                            !empty($entries[$x]['mail'][0])) {
                        $ad_users[] = array('first_name' => trim($entries[$x]['givenname'][0]), 'last_name' => trim($entries[$x]['sn'][0]), 'full_name' => trim($entries[$x]['givenname'][0]).' '. trim($entries[$x]['sn'][0]), 'username' => trim($entries[$x]['samaccountname'][0]), 'email' => trim($entries[$x]['mail'][0]));
                    }
                }
            }
            $result_nicks = ldap_search($ldap_connection, $this->config->item('ldapuserjoboufour'), $search_filter, $attributes);
            if (FALSE !== $result_nicks) {

This code seems to be duplicated across your project.

                $entries = ldap_get_entries($ldap_connection, $result_nicks);
                for ($x = 0; $x < $entries['count']; $x++) {
                    if (!empty($entries[$x]['givenname'][0]) &&
                            !empty($entries[$x]['samaccountname'][0]) &&
                            !empty($entries[$x]['sn'][0]) &&
                            !empty($entries[$x]['mail'][0])) {
                        $ad_users[] = array('first_name' => trim($entries[$x]['givenname'][0]), 'last_name' => trim($entries[$x]['sn'][0]), 'full_name' => trim($entries[$x]['givenname'][0]).' '. trim($entries[$x]['sn'][0]), 'username' => trim($entries[$x]['samaccountname'][0]), 'email' => trim($entries[$x]['mail'][0]));
                    }
                }
            }
            $result_nicks = ldap_search($ldap_connection, $this->config->item('ldapuserjoboufive'), $search_filter, $attributes);
            if (FALSE !== $result_nicks) {

This code seems to be duplicated across your project.

                $entries = ldap_get_entries($ldap_connection, $result_nicks);
                for ($x = 0; $x < $entries['count']; $x++) {
                    if (!empty($entries[$x]['givenname'][0]) &&
                            !empty($entries[$x]['samaccountname'][0]) &&
                            !empty($entries[$x]['sn'][0]) &&
                            !empty($entries[$x]['mail'][0])) {
                        $ad_users[] = array('first_name' => trim($entries[$x]['givenname'][0]), 'last_name' => trim($entries[$x]['sn'][0]), 'full_name' => trim($entries[$x]['givenname'][0]).' '. trim($entries[$x]['sn'][0]), 'username' => trim($entries[$x]['samaccountname'][0]), 'email' => trim($entries[$x]['mail'][0]));
                    }
                }
            }

            ldap_unbind($ldap_connection);
        }

        if ($this->db->insert_batch('users_ad', $ad_users)) {

The variable $ad_users does not seem to be defined for all execution paths leading up to this point.

            
            $ip = $_SERVER['REMOTE_ADDR'];
            $data = array(
                'timestamp' => date("Y-m-d H:i:s", time()),
                'ip' => $ip,
                'job' => 'Users updated successfully.',
            );

            return $this->db->insert('job_log', $data);
        } else {
            
            $ip = $_SERVER['REMOTE_ADDR'];
            $data = array(
                'timestamp' => date("Y-m-d H:i:s", time()),
                'ip' => $ip,
                'job' => 'Users updated failed.',
            );
            return $this->db->insert('job_log', $data);
        }
    }
}