Equipment_loan_model - Code Metrics - East-Kent-Partnership/Intranet - Measure and Improve Code Quality continuously with Scrutinizer

Equipment_loan_model A
last analyzed 2017-05-05 08:55 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	22
Duplicated Lines	68.18 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

Metric	Value
dl	15
loc	22
rs	10
c	0
b	0
f	0
wmc	2
lcom	0
cbo	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	2	1
A	loan()	15	15	1

How to fix Duplicated Code

<?php defined('BASEPATH') OR exit('No direct script access allowed');

class Equipment_loan_model extends CI_Model {

    public function __construct() {
    }

    public function loan($logged, $full_name, $ern, $make, $model, $sn) {

        
        $data = array(
            'logged' => $this->input->post('logged'),
            'full_name' => $this->input->post('full_name'),
            'ern' => $this->input->post('ern'),
            'make' => $this->input->post('make'),
            'model' => $this->input->post('model'),
            'sn' => $this->input->post('sn'),
            'date' => date("Y-m-d H:i:s", time()),
        );
        
        return $this->db->insert('equipment_loan', $data);
        
    }

}
?>





1		<?php defined('BASEPATH') OR exit('No direct script access allowed');
2
3		class Equipment_loan_model extends CI_Model {
4
5		public function __construct() {
6		}
7
8	View Code Duplication	public function loan($logged, $full_name, $ern, $make, $model, $sn) {
		0 ignored issues – show Duplication introduced 2017-03-18 11:17 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
9
10		$data = array(
11		'logged' => $this->input->post('logged'),
12		'full_name' => $this->input->post('full_name'),
13		'ern' => $this->input->post('ern'),
14		'make' => $this->input->post('make'),
15		'model' => $this->input->post('model'),
16		'sn' => $this->input->post('sn'),
17		'date' => date("Y-m-d H:i:s", time()),
18		);
19
20		return $this->db->insert('equipment_loan', $data);
21
22		}
23
24		}
25		?>
		0 ignored issues – show Best Practice introduced 2017-03-18 11:17 UTC by Report Bug Copy Issue Report It is not recommended to use PHP's closing tag `?>` in files other than templates. Using a closing tag in PHP files that only contain PHP code is not recommended as you might accidentally add whitespace after the closing tag which would then be output by PHP. This can cause severe problems, for example headers cannot be sent anymore. A simple precaution is to leave off the closing tag as it is not required, and it also has no negative effects whatsoever. Loading history...
26
27
28

East-Kent-Partnership / Intranet

Equipment_loan_model A last analyzed 2017-05-05 08:55 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

Equipment_loan_model A
last analyzed 2017-05-05 08:55 UTC