EVE-KILL / zKillboard

view/postmail.php

<?php
/* zKillboard
 * Copyright (C) 2012-2015 EVE-KILL Team and EVSCO.
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */

global $rawKillmailParser;

$error = "";

if($_POST)
{
	$keyid = Util::getPost("keyid");
	$vcode = Util::getPost("vcode");
	$killmail = Util::getPost("killmail");
	$killmailurl = Util::getPost("killmailurl");
	$rawKillmail = Util::getPost("rawkillmail");

	// Apikey stuff
	if($keyid || $vcode)

The expression $keyid of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

The expression $vcode of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

	{
		$check = Api::checkAPI($keyid, $vcode);
		if($check == "success")
		{
			Db::execute("insert ignore into zz_api (keyID, vCode) values (:keyID, :vCode)", array(":keyID" => $keyid, ":vCode" => $vcode));
			$error = "Your API Key has been added.";
		}
		else
		{
			$error = $check;
		}
	}

	// Crest Killmail
	if ($killmailurl)

The expression $killmailurl of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

	{
		// Looks like http://public-crest.eveonline.com/killmails/30290604/787fb3714062f1700560d4a83ce32c67640b1797/
		$exploded = explode("/", $killmailurl);

		if (count($exploded) != 7) $error = "Invalid killmail link.";
		else
		{
			if((int) $exploded[4] <= 0) $error = "Invalid killmail link";
			elseif(strlen($exploded[5]) != 40) $error = "Invalid killmail link";
			else
			{
				$killID = (int) $exploded[4];
				$hash = (string) $exploded[5];
				$i = Db::execute("insert ignore into zz_crest_killmail (killID, hash) values (:killID, :hash)", array(":killID" => $killID, ":hash" => $hash));
				Db::execute("update zz_crest_killmail set processed = 0 where processed = -1 and killID = :killID", array(":killID" => $killID));

				$timer = new Timer();
				do {
					// Has the kill been processed?
					$crestStatus = Db::queryField("select processed from zz_crest_killmail where killID = :killID", "processed", array(":killID" => $killID), 0);
					$processed = Db::queryField("select processed from zz_killmails where killID = :killID", "processed", array(":killID" => $killID), 0);
					if ($crestStatus == -1) $error = "There is an error with the killmail at the CREST endpoint. We'll let CCP know. Your kill has still been submitted and we'll process it as soon as the error has been fixed. Thank you.";
					else if ($processed == 1) $app->redirect("/detail/$killID/");
					else if ($processed == 2) $error = "There was an error while processing the killmail. Please open a ticket and include the external killmail link so we can examine what happened. Thank you.";
					else if ($processed == 3) $error = "Only PvP mails are accepted, the mail you just submitted was a PvE killmail.";
					else if (date("Gi") < 105) $error = "Between 00:00 and 01:05 no kills are processed while we wait for CCP's Market CREST cache to clear... However, the kill has been stored and will be processed at 01:05";
					else usleep(450000);
				} while ($timer->stop() < 60000 && $error == "");
				if ($error == "") $error = "We waited 60 seconds for the kill to be processed but the server must be busy atm, please wait!";
			}
		}
	}

	// Raw manual killmail
	if($rawKillmailParser && $rawKillmail)

The expression $rawKillmail of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

	{
		$userData = User::getUserInfo();
		if(User::isLoggedIn())
		{
			$return = Parser::parseRaw($killmail, $userData["id"]);

			if(isset($return["success"]))
				$app->redirect("/detail/" . $return["success"] . "/");

			if(isset($return["dupe"]))
				$app->redirect("/detail/" . $return["dupe"] . "/");

			if(isset($return["error"]))
				$error = $return["error"];
		}
		else
			$error = "sorry, you need to be logged in to post raw killmails";
	}
}

if(!is_array($error)) $error = array($error);

$app->render("postmail.html", array("message" => $error));