Issues (438)

Security Analysis    not enabled

This project does not seem to handle request data directly as such no vulnerable execution paths were found.

  Cross-Site Scripting
Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.
  File Exposure
File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.
  File Manipulation
File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.
  Object Injection
Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.
  Code Injection
Code Injection enables an attacker to execute arbitrary code on the server.
  Response Splitting
Response Splitting can be used to send arbitrary responses.
  File Inclusion
File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.
  Command Injection
Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.
  SQL Injection
SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.
  XPath Injection
XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.
  LDAP Injection
LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.
  Header Injection
  Other Vulnerability
This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.
  Regex Injection
Regex Injection enables an attacker to execute arbitrary code in your PHP process.
  XML Injection
XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.
  Variable Injection
Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.
Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

view/merge.php (2 issues)

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

1
<?php
2
global $cookie_secret;
3
$randomString = sha1(time());
4
// Check if user is already merged, just to be safe
5
$exists = Db::queryField("SELECT merged FROM zz_users WHERE characterID = :characterID", "merged", array(":characterID" => $characterID), 0);
6
if($exists == 1)
7
{
8
	$error = "Error: User already merged.";
9
	$app->render("merge.html", array("error" => $error, "characterID" => $characterID, "randomString" => $randomString));
10
}
11
12
// Otherwise show the page..
13
if($_POST)
14
{
15
	$username = Util::getPost("username");
16
	$password = Util::getPost("password");
17
18
	if(!$username)
0 ignored issues
show
Bug Best Practice introduced by
The expression $username of type string|null is loosely compared to false; this is ambiguous if the string can be empty. You might want to explicitly use === null instead.

In PHP, under loose comparison (like ==, or !=, or switch conditions), values of different types might be equal.

For string values, the empty string '' is a special case, in particular the following results might be unexpected:

''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
Loading history...
19
	{
20
		$error = "No username given";
21
		$app->render("merge.html", array("error" => $error, "characterID" => $characterID, "randomString" => $randomString));
22
	}
23
	elseif(!$password)
0 ignored issues
show
Bug Best Practice introduced by
The expression $password of type string|null is loosely compared to false; this is ambiguous if the string can be empty. You might want to explicitly use === null instead.

In PHP, under loose comparison (like ==, or !=, or switch conditions), values of different types might be equal.

For string values, the empty string '' is a special case, in particular the following results might be unexpected:

''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
Loading history...
24
	{
25
		$error = "No password given";
26
		$app->render("merge.html", array("error" => $error, "characterID" => $characterID, "randomString" => $randomString));
27
	}
28
	elseif($username && $password)
29
	{
30
		$check = User::checkLogin($username, $password);
31
		if($check) // Success
32
		{
33
			// Get userID for user that passes
34
			$userID = Db::queryField("SELECT id FROM zz_users WHERE username = :username", "id", array(":username" => $username));
35
36
			// Update userID in zz_crest_users
37
			Db::execute("UPDATE zz_users_crest SET userID = :userID WHERE characterID = :characterID", array(":userID" => $userID, ":characterID" => $characterID));
38
			// Update the characterID on zz_users and set merged to 1
39
			Db::execute("UPDATE zz_users SET merged = 1 WHERE id = :userID", array(":userID" => $userID));
40
			Db::execute("UPDATE zz_users SET characterID = :characterID WHERE id = :userID", array(":userID" => $userID, ":characterID" => $characterID));
41
42
			// Set the login session headers and whatnot
43
			$crestData = Db::queryRow("SELECT * FROM zz_users_crest WHERE characterID = :characterID", array(":characterID" => $characterID));
44
			$_SESSION["loggedin"] = $crestData["characterName"];
45
46
			// Redirect to /
47
			$app->redirect("/");
48
		}
49
		else
50
		{
51
			// The login failed, or the user didn't exist.. Either way, we don't give a fuck..
52
			// Randomly generate a password
53
			$password = md5(time() + $cookie_secret);
54
			// Insert no email address, [email protected]
55
			$email = "[email protected]";
56
57
			// Data from zz_user_crest
58
			$crestData = Db::queryRow("SELECT * FROM zz_users_crest WHERE characterID = :characterID", array(":characterID" => $characterID));
59
			// Insert the new user to zz_users
60
			Db::execute("INSERT INTO zz_users (username, password, email, characterID, merged) VALUES (:username, :password, :email, :characterID, :merged)", array(
61
				":username" => $crestData["characterName"],
62
				":password" => $password,
63
				":email" => $email,
64
				":characterID" => $crestData["characterID"],
65
				":merged" => 1)
66
			);
67
68
			// Set the userID in zz_users_crest
69
			$userID = Db::queryField("SELECT id FROM zz_users WHERE username = :username", "id", array(":username" => $crestData["characterName"]));
70
			Db::execute("UPDATE zz_users_crest SET userID = :userID WHERE characterID = :characterID", array(":userID" => $userID, ":characterID" => $characterID));
71
			// Set the session headers and whatnot
72
			$_SESSION["loggedin"] = $crestData["characterName"];
73
74
			// Redirect to /
75
			$app->redirect("/");
76
		}
77
	}
78
}
79
elseif($exists == 0 || $exists == NULL)
80
	$app->render("merge.html", array("characterID" => $characterID, "randomString" => $randomString));