Issues in RandomGenerator.php (master) - Issues in master - EVE-KILL/zKillboard - Measure and Improve Code Quality continuously with Scrutinizer

Issues (438)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

classes/RandomGenerator.php (1 issue)

Labels

Severity

Informational 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Generates entropy values based on strongest available methods
 * (mcrypt_create_iv(), openssl_random_pseudo_bytes(), /dev/urandom, COM.CAPICOM.Utilities.1, mt_rand()).
 * Chosen method depends on operating system and PHP version.
 *
 * Shamelessly stolen from https://raw.githubusercontent.com/silverstripe/silverstripe-framework/3.1/security/RandomGenerator.php
 */
class RandomGenerator {

	/**
	 * Note: Returned values are not guaranteed to be crypto-safe,
	 * depending on the used retrieval method.
	 * 
	 * @return string Returns a random series of bytes
	 */
	public function generateEntropy() {
		$isWin = preg_match('/WIN/', PHP_OS);
		
		// TODO Fails with "Could not gather sufficient random data" on IIS, temporarily disabled on windows
		if(!$isWin) {
			if(function_exists('mcrypt_create_iv')) {
				$e = mcrypt_create_iv(64, MCRYPT_DEV_URANDOM);
				if($e !== false) return $e;
			}
		}

		// Fall back to SSL methods - may slow down execution by a few ms
		if (function_exists('openssl_random_pseudo_bytes')) {
			$e = openssl_random_pseudo_bytes(64, $strong);
			// Only return if strong algorithm was used
			if($strong) return $e;
		}

		// Read from the unix random number generator
		if(!$isWin && !ini_get('open_basedir') && is_readable('/dev/urandom') && ($h = fopen('/dev/urandom', 'rb'))) {
			$e = fread($h, 64);
			fclose($h);
			return $e;
		}

		// Warning: Both methods below are considered weak

		// try to read from the windows RNG
		if($isWin && class_exists('COM')) {
			try {
				$comObj = new COM('CAPICOM.Utilities.1');

				if(is_callable(array($comObj,'GetRandom'))) {
					return  base64_decode($comObj->GetRandom(64, 0));
				}
			} catch (Exception $ex) {

			}
		}

		// Fallback to good old mt_rand()
		return uniqid(mt_rand(), true);
	}

	/**
	 * Generates a random token that can be used for session IDs, CSRF tokens etc., based on
	 * hash algorithms.
	 *
	 * If you are using it as a password equivalent (e.g. autologin token) do NOT store it 
	 * in the database as a plain text but encrypt it with Member::encryptWithUserSettings.
	 * 
	 * @param String $algorithm Any identifier listed in hash_algos() (Default: whirlpool)
	 *
	 * @return String Returned length will depend on the used $algorithm
	 */
	public function randomToken($algorithm = 'whirlpool') {
		return hash($algorithm, $this->generateEntropy());
	}
}

1			<?php
2			/**
3			* Generates entropy values based on strongest available methods
4			* (mcrypt_create_iv(), openssl_random_pseudo_bytes(), /dev/urandom, COM.CAPICOM.Utilities.1, mt_rand()).
5			* Chosen method depends on operating system and PHP version.
6			*
7			* Shamelessly stolen from https://raw.githubusercontent.com/silverstripe/silverstripe-framework/3.1/security/RandomGenerator.php
8			*/
9			class RandomGenerator {
10
11			/**
12			* Note: Returned values are not guaranteed to be crypto-safe,
13			* depending on the used retrieval method.
14			*
15			* @return string Returns a random series of bytes
16			*/
17			public function generateEntropy() {
18			$isWin = preg_match('/WIN/', PHP_OS);
19
20			// TODO Fails with "Could not gather sufficient random data" on IIS, temporarily disabled on windows
21			if(!$isWin) {
22			if(function_exists('mcrypt_create_iv')) {
23			$e = mcrypt_create_iv(64, MCRYPT_DEV_URANDOM);
24			if($e !== false) return $e;
25			}
26			}
27
28			// Fall back to SSL methods - may slow down execution by a few ms
29			if (function_exists('openssl_random_pseudo_bytes')) {
30			$e = openssl_random_pseudo_bytes(64, $strong);
31			// Only return if strong algorithm was used
32			if($strong) return $e;
33			}
34
35			// Read from the unix random number generator
36			if(!$isWin && !ini_get('open_basedir') && is_readable('/dev/urandom') && ($h = fopen('/dev/urandom', 'rb'))) {
37			$e = fread($h, 64);
38			fclose($h);
39			return $e;
40			}
41
42			// Warning: Both methods below are considered weak
43
44			// try to read from the windows RNG
45			if($isWin && class_exists('COM')) {
46			try {
47			$comObj = new COM('CAPICOM.Utilities.1');
48
49			if(is_callable(array($comObj,'GetRandom'))) {
50			return base64_decode($comObj->GetRandom(64, 0));
51			}
52			} catch (Exception $ex) {
			0 ignored issues – show Coding Style Comprehensibility introduced 2015-12-13 23:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider adding a comment why this CATCH block is empty. Loading history...
53			}
54			}
55
56			// Fallback to good old mt_rand()
57			return uniqid(mt_rand(), true);
58			}
59
60			/**
61			* Generates a random token that can be used for session IDs, CSRF tokens etc., based on
62			* hash algorithms.
63			*
64			* If you are using it as a password equivalent (e.g. autologin token) do NOT store it
65			* in the database as a plain text but encrypt it with Member::encryptWithUserSettings.
66			*
67			* @param String $algorithm Any identifier listed in hash_algos() (Default: whirlpool)
68			*
69			* @return String Returned length will depend on the used $algorithm
70			*/
71			public function randomToken($algorithm = 'whirlpool') {
72			return hash($algorithm, $this->generateEntropy());
73			}
74			}

EVE-KILL / zKillboard

Issues (438)

Security Analysis not enabled

classes/RandomGenerator.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like