EVE-KILL /
zKillboard
| Conditions | 12 |
| Paths | 768 |
| Total Lines | 44 |
| Code Lines | 25 |
| Lines | 0 |
| Ratio | 0 % |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 19 | public function compile(Twig_Compiler $compiler) |
||
| 20 | { |
||
| 21 | if (function_exists('twig_template_get_attributes') && !$this->getAttribute('disable_c_ext')) { |
||
| 22 | $compiler->raw('twig_template_get_attributes($this, '); |
||
| 23 | } else { |
||
| 24 | $compiler->raw('$this->getAttribute('); |
||
| 25 | } |
||
| 26 | |||
| 27 | if ($this->getAttribute('ignore_strict_check')) { |
||
| 28 | $this->getNode('node')->setAttribute('ignore_strict_check', true); |
||
| 29 | } |
||
| 30 | |||
| 31 | $compiler->subcompile($this->getNode('node')); |
||
| 32 | |||
| 33 | $compiler->raw(', ')->subcompile($this->getNode('attribute')); |
||
| 34 | |||
| 35 | // only generate optional arguments when needed (to make generated code more readable) |
||
| 36 | $needFourth = $this->getAttribute('ignore_strict_check'); |
||
| 37 | $needThird = $needFourth || $this->getAttribute('is_defined_test'); |
||
| 38 | $needSecond = $needThird || Twig_Template::ANY_CALL !== $this->getAttribute('type'); |
||
| 39 | $needFirst = $needSecond || null !== $this->getNode('arguments'); |
||
| 40 | |||
| 41 | if ($needFirst) { |
||
| 42 | if (null !== $this->getNode('arguments')) { |
||
| 43 | $compiler->raw(', ')->subcompile($this->getNode('arguments')); |
||
| 44 | } else { |
||
| 45 | $compiler->raw(', array()'); |
||
| 46 | } |
||
| 47 | } |
||
| 48 | |||
| 49 | if ($needSecond) { |
||
| 50 | $compiler->raw(', ')->repr($this->getAttribute('type')); |
||
| 51 | } |
||
| 52 | |||
| 53 | if ($needThird) { |
||
| 54 | $compiler->raw(', ')->repr($this->getAttribute('is_defined_test')); |
||
| 55 | } |
||
| 56 | |||
| 57 | if ($needFourth) { |
||
| 58 | $compiler->raw(', ')->repr($this->getAttribute('ignore_strict_check')); |
||
| 59 | } |
||
| 60 | |||
| 61 | $compiler->raw(')'); |
||
| 62 | } |
||
| 63 | } |
||
| 64 |
