Semaphore

Complexity

Total Complexity

7

Size/Duplication

Total Lines	26
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	release()	0	4	2
B	fetch()	0	11	5

<?php

The opening PHP tag must be the first content in the file

/* zLibrary
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */

class Semaphore
{
    /**
     * @param int $semaphoreID
     * @return null|resource
     */
    public static function fetch($semaphoreID)
    {
        global $useSemaphores, $semaphoreModulus;
        if (!isset($useSemaphores)) $useSemaphores = false;
        if ($useSemaphores == false) return null;

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

        if (!isset($semaphoreModulus)) $semaphoreModulus = 10;

        $sem = sem_get($semaphoreID % $semaphoreModulus);
        if (!sem_acquire($sem)) return null;
        return $sem;
    }

    /**
     * @param null|resource $semaphoreResource
     */
    public static function release($semaphoreResource)
    {
        if ($semaphoreResource != null) sem_release($semaphoreResource);
    }
}