EGroupware / egroupware

api/src/Etemplate/Widget/Customfields.php

Braces +57 added lines, -14 removed lines

@@ -89,7 +89,10 @@ 
 	public function beforeSendToClient($cname, array $expand=null)
 	{
 		// No name, no way to get parameters client-side.
-		if(!$this->id) $this->id = self::GLOBAL_ID;
+		if(!$this->id)
+		{
+			$this->id = self::GLOBAL_ID;
+		}
 
 		$form_name = self::form_name($cname, $this->id, $expand);
 
@@ -188,7 +191,10 @@ 
 			$form_name = self::$prefix.$name;
 		}
 
-		if(!is_array($fields)) $fields = array();
+		if(!is_array($fields))
+		{
+			$fields = array();
+		}
 		switch($type = $this->type)
 		{
 			case 'customfields-types':
@@ -213,11 +219,18 @@ 
 				foreach(array_reverse($fields) as $lname => $field)
 				{
 					if (!empty($this->attrs['sub-type']) && !empty($field['type2']) &&
-						strpos(','.$field['type2'].',',','.$field['type2'].',') === false) continue;    // not for our content type//
-					if (isset($value[self::$prefix.$lname]) && $value[self::$prefix.$lname] !== '') //break;
+						strpos(','.$field['type2'].',',','.$field['type2'].',') === false)
+					{
+						continue;
+					}
+					// not for our content type//
+					if (isset($value[self::$prefix.$lname]) && $value[self::$prefix.$lname] !== '')
+					{
+						//break;
 					{
 						$fields_with_vals[]=$lname;
 					}
+					}
 					//$stop_at_field = $name;
 				}
 				break;
@@ -248,7 +261,10 @@ 
 
 		// Re-format date custom fields from Y-m-d
 		$field_settings =& self::get_array(self::$request->modifications, "{$this->id}[customfields]",true);
-		if (true) $field_settings = array();
+		if (true)
+		{
+			$field_settings = array();
+		}
 		$link_types = Api\Link::app_list();
 		foreach($fields as $fname => $field)
 		{
@@ -271,7 +287,10 @@ 
 	protected function _widget($fname, array $field)
 	{
 		static $link_types = null;
-		if (!isset($link_types)) $link_types = Api\Link::app_list ();
+		if (!isset($link_types))
+		{
+			$link_types = Api\Link::app_list ();
+		}
 
 		$type = $field['type'];
 		// Link-tos needs to change from appname to link-to
@@ -298,8 +317,14 @@ 
 			case 'date':
 			case 'date-time':
 				$widget->attrs['dataformat'] = $type == 'date' ? 'Y-m-d' : 'Y-m-d H:i:s';
-				if($field['values']['min']) $widget->attrs['min'] = $field['values']['min'];
-				if($field['values']['max']) $widget->attrs['min'] = $field['values']['max'];
+				if($field['values']['min'])
+				{
+					$widget->attrs['min'] = $field['values']['min'];
+				}
+				if($field['values']['max'])
+				{
+					$widget->attrs['min'] = $field['values']['max'];
+				}
 				break;
 
 			case 'vfs-upload':
@@ -316,7 +341,10 @@ 
 				break;
 
 			default:
-				if (substr($type, 0, 7) !== 'select-' && $type != 'ajax_select') break;
+				if (substr($type, 0, 7) !== 'select-' && $type != 'ajax_select')
+				{
+					break;
+				}
 				// fall-through for all select-* widgets
 			case 'select':
 				$widget->attrs['multiple'] = $field['rows'] > 1;
@@ -377,7 +405,10 @@ 
 		$all_readonly = $this->is_readonly($cname, $form_name);
 		$value_in = self::get_array($content, $form_name);
 		// if we have no id / use self::GLOBAL_ID, we have to set $value_in in global namespace for regular widgets validation to find
-		if (!$this->id) $content = array_merge($content, $value_in);
+		if (!$this->id)
+		{
+			$content = array_merge($content, $value_in);
+		}
 		//error_log(__METHOD__."($cname, ...) form_name=$form_name, use-private={$this->attrs['use-private']}, value_in=".array2string($value_in));
 		$customfields =& $this->getElementAttribute(self::GLOBAL_VALS, 'customfields');
 		if(is_array($value_in))
@@ -402,15 +433,24 @@ 
 				// run validation method of widget implementing this custom field
 				$widget = $this->_widget($fname, $field_settings);
 				// widget has no validate method, eg. is only displaying stuff --> nothing to validate
-				if (!method_exists($widget, 'validate')) continue;
+				if (!method_exists($widget, 'validate'))
+				{
+					continue;
+				}
 				$widget->validate($form_name != self::GLOBAL_ID ? $form_name : $cname, $expand, $content, $validated);
 				$field_name = $this->id[0] == self::$prefix && $customfields[substr($this->id,1)] ? $this->id : self::form_name($form_name != self::GLOBAL_ID ? $form_name : $cname, $field);
 				$valid =& self::get_array($validated, $field_name, true);
 
-				if (is_array($valid)) $valid = implode(',', $valid);
+				if (is_array($valid))
+				{
+					$valid = implode(',', $valid);
+				}
 				// NULL is valid for most fields, but not custom fields due to backend handling
 				// See so_sql_cf->save()
-				if (is_null($valid)) $valid = false;
+				if (is_null($valid))
+				{
+					$valid = false;
+				}
 				//error_log(__METHOD__."() $field_name: ".array2string($value).' --> '.array2string($valid));
 			}
 		}
@@ -418,7 +458,10 @@ 
 		{
 			// Transformation doesn't handle validation
 			$valid =& self::get_array($validated, $this->id ? $form_name : $field, true);
-			if (true) $valid = $value_in;
+			if (true)
+			{
+				$valid = $value_in;
+			}
 			//error_log(__METHOD__."() $form_name $field: ".array2string($value).' --> '.array2string($value));
 		}
 	}