Passed
Pull Request — master (#46)
by Neo
33:01
created
api/src/Storage/Customfields.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -169,7 +169,7 @@  discard block
 block discarded – undo
169 169
 	 * @param int|boolean $account =false Filter private for given account_id,
170 170
 	 *	false for current user or true for all the private fields be returned too, default current user
171 171
 	 * @param string $only_type2 =null if given only return fields of type2 == $only_type2
172
-	 * @return boolen true: if there is a custom field useing html, false if not
172
+	 * @return boolean true: if there is a custom field useing html, false if not
173 173
 	 */
174 174
 	public static function use_html($app, $account=false, $only_type2=null)
175 175
 	{
@@ -595,6 +595,9 @@  discard block
 block discarded – undo
595 595
 		}
596 596
 	}
597 597
 
598
+	/**
599
+	 * @param string $entry_id
600
+	 */
598 601
 	protected static function handle_file($entry_id, $field, $value)
599 602
 	{
600 603
 		$path = Api\Etemplate\Widget\Vfs::get_vfs_path($field['app'].":$entry_id:".$field['label']);
Please login to merge, or discard this patch.
calendar/inc/class.calendar_import_csv.inc.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
 	 * @param calendar_egw_record record The egw_record object being imported
75 75
 	 * @param importexport_iface_import_record import_csv Import object contains current state
76 76
 	 *
77
-	 * @return boolean success
77
+	 * @return null|boolean success
78 78
 	 */
79 79
 	public function import_record(\calendar_egw_record &$record, &$import_csv)
80 80
 	{
@@ -182,8 +182,9 @@  discard block
 block discarded – undo
182 182
 	/**
183 183
 	 * Parse participants field into calendar resources
184 184
 	 *
185
-	 * @param string $participants
186 185
 	 *
186
+	 * @param calendar_egw_record $record
187
+	 * @param string $warnings
187 188
 	 * @return array
188 189
 	 */
189 190
 	protected function parse_participants($record, &$warnings)
@@ -289,7 +290,6 @@  discard block
 block discarded – undo
289 290
 	 * perform the required action
290 291
 	 *
291 292
 	 * @param int $_action one of $this->actions
292
-	 * @param array $_data record data for the action
293 293
 	 * @return bool success or not
294 294
 	 */
295 295
 	protected function action ( $_action, importexport_iface_egw_record &$record, $record_num = 0 )
@@ -423,7 +423,7 @@  discard block
 block discarded – undo
423 423
 	/**
424 424
 	 * Alter a row for preview to show multiple participants instead of Array
425 425
 	 *
426
-	 * @param egw_record $row_entry
426
+	 * @param importexport_iface_egw_record $row_entry
427 427
 	 */
428 428
 	protected function row_preview(importexport_iface_egw_record &$row_entry)
429 429
 	{
Please login to merge, or discard this patch.
api/src/Framework/Updates.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@
 block discarded – undo
46 46
 	 * Get versions of available updates
47 47
 	 *
48 48
 	 * @param string $api =null major api version to return security for, default latest
49
-	 * @return array verions for keys "current" and "security"
49
+	 * @return string verions for keys "current" and "security"
50 50
 	 */
51 51
 	public static function available($api=null)
52 52
 	{
Please login to merge, or discard this patch.
mail/tests/SaveToVfsTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -103,6 +103,10 @@
 block discarded – undo
103 103
 class VfsTestMail extends \mail_bo
104 104
 {
105 105
 	// Expose for testing
106
+
107
+	/**
108
+	 * @param string $filename
109
+	 */
106 110
 	public static function clean_subject_for_filename($filename)
107 111
 	{
108 112
 		return parent::clean_subject_for_filename($filename);
Please login to merge, or discard this patch.
infolog/tests/ProjectTemplateTest.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -116,7 +116,6 @@
 block discarded – undo
116 116
 	/**
117 117
 	 * Check that the project elements are present, and have the provided status.
118 118
 	 *
119
-	 * @param String $status
120 119
 	 */
121 120
 	protected function checkClonedElements($clone_id)
122 121
 	{
Please login to merge, or discard this patch.
notifications/inc/class.notifications_popup.inc.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -117,7 +117,6 @@
 block discarded – undo
117 117
 	 * saves notification into database so that the client can fetch it from there
118 118
 	 *
119 119
 	 * @param string $_message
120
-	 * @param array $_user_sessions
121 120
 	 * @param array $_data
122 121
 	 */
123 122
 	private function save($_message, $_data) {
Please login to merge, or discard this patch.
calendar/inc/class.calendar_merge.inc.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
179 179
 				{
180 180
 					$value = date($format, $key == 'end' ? $id['end'] : $id['start']);
181 181
 					if($key == 'month') $value = lang($value);
182
-					$values["$\$range/$key$$"] = $value;
182
+					$values["$\$range/$key$key$"] = $value;
183 183
 				}
184 184
 			}
185 185
 			$replacements += $values;
@@ -246,7 +246,7 @@  discard block
 block discarded – undo
246 246
 			}
247 247
 			foreach($types as $t_id => $type)
248 248
 			{
249
-				$replacements['$$'.($prefix ? $prefix . '/' : '') . "calendar_participants/{$t_id}$$"] = implode(', ',$type);
249
+				$replacements['$$'.($prefix ? $prefix . '/' : '') . "calendar_participants/{$t_id}}$"] = implode(', ',$type);
250 250
 			}
251 251
 		}
252 252
 		// Participant email list (not declined)
Please login to merge, or discard this patch.
mail/inc/class.mail_ui.inc.php 1 patch
Doc Comments   +11 added lines, -7 removed lines patch added patch discarded remove patch
@@ -1820,9 +1820,9 @@  discard block
 block discarded – undo
1820 1820
 	 * function header2gridelements - to populate the grid elements with the collected Data
1821 1821
 	 *
1822 1822
 	 * @param array $_headers headerdata to process
1823
-	 * @param array $cols cols to populate
1823
+	 * @param string[] $cols cols to populate
1824 1824
 	 * @param array $_folderName to ensure the uniqueness of the uid over all folders
1825
-	 * @param array $_folderType used to determine if we need to populate from/to
1825
+	 * @param integer $_folderType used to determine if we need to populate from/to
1826 1826
 	 * @return array populated result array
1827 1827
 	 */
1828 1828
 	public function header2gridelements($_headers, $cols, $_folderName, $_folderType=0)
@@ -2282,7 +2282,7 @@  discard block
 block discarded – undo
2282 2282
 
2283 2283
 	/**
2284 2284
 	 * Export stored smime certificate in database
2285
-	 * @return boolean return false if not successful
2285
+	 * @return false|null return false if not successful
2286 2286
 	 */
2287 2287
 	function smimeExportCert()
2288 2288
 	{
@@ -3256,6 +3256,9 @@  discard block
 block discarded – undo
3256 3256
 		return $GLOBALS['egw']->framework->header();
3257 3257
 	}
3258 3258
 
3259
+	/**
3260
+	 * @param string $body
3261
+	 */
3259 3262
 	function showBody(&$body, $print=true,$fullPageTags=true)
3260 3263
 	{
3261 3264
 		$BeginBody = '<div class="mailDisplayBody">
@@ -3747,7 +3750,7 @@  discard block
 block discarded – undo
3747 3750
 	 * @param string $_folder (passed by reference) will set the folder used. must be set with a folder, but will hold modifications if
3748 3751
 	 *					folder is modified
3749 3752
 	 * @param string $importID ID for the imported message, used by attachments to identify them unambiguously
3750
-	 * @return mixed $messageUID or exception
3753
+	 * @return string $messageUID or exception
3751 3754
 	 */
3752 3755
 	function importMessageToFolder($_formData,&$_folder,$importID='')
3753 3756
 	{
@@ -3908,7 +3911,7 @@  discard block
 block discarded – undo
3908 3911
 	 *
3909 3912
 	 * @param string _messageID UID
3910 3913
 	 *
3911
-	 * @return xajax response
3914
+	 * @return string|null response
3912 3915
 	 */
3913 3916
 	function loadEmailBody($_messageID=null,$_partID=null,$_htmloptions=null)
3914 3917
 	{
@@ -4455,7 +4458,7 @@  discard block
 block discarded – undo
4455 4458
 	 * ajax_deleteFolder - its called via json, so the function must start with ajax (or the class-name must contain ajax)
4456 4459
 	 * @param string $_folderName folder to delete
4457 4460
 	 * @param boolean $_return = false wheter return the success value (true) or send response to client (false)
4458
-	 * @return nothing
4461
+	 * @return boolean|null
4459 4462
 	 */
4460 4463
 	function ajax_deleteFolder($_folderName, $_return = false)
4461 4464
 	{
@@ -5224,8 +5227,9 @@  discard block
 block discarded – undo
5224 5227
 	 * @param string _move2ArchiveMarker marker to indicate if a move 2 archive was triggered
5225 5228
 	 * @param boolean _return if true the function will return the result instead of
5226 5229
 	 * responding to client
5230
+	 * @param string $_folderName
5227 5231
 	 *
5228
-	 * @return xajax response
5232
+	 * @return string|null response
5229 5233
 	 */
5230 5234
 	function ajax_copyMessages($_folderName, $_messageList, $_copyOrMove='copy', $_move2ArchiveMarker='_', $_return = false)
5231 5235
 	{
Please login to merge, or discard this patch.
mail/inc/class.mail_compose.inc.php 1 patch
Doc Comments   +9 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1600,6 +1600,10 @@  discard block
 block discarded – undo
1600 1600
 	// $_mode can be:
1601 1601
 	// single: for a reply to one address
1602 1602
 	// all: for a reply to all
1603
+
1604
+	/**
1605
+	 * @param Mail\Imap $_icServer
1606
+	 */
1603 1607
 	function getDraftData($_icServer, $_folder, $_uid, $_partID=NULL)
1604 1608
 	{
1605 1609
 		unset($_icServer);	// not used
@@ -1800,6 +1804,9 @@  discard block
 block discarded – undo
1800 1804
 		return false;
1801 1805
 	}
1802 1806
 
1807
+	/**
1808
+	 * @param Mail\Imap $_icServer
1809
+	 */
1803 1810
 	function getForwardData($_icServer, $_folder, $_uid, $_partID, $_mode=false)
1804 1811
 	{
1805 1812
 		if ($_mode)
@@ -2072,7 +2079,7 @@  discard block
 block discarded – undo
2072 2079
 	/**
2073 2080
 	 * Gather the replyData and save it with the session, to be used then
2074 2081
 	 *
2075
-	 * @param $_mode can be:
2082
+	 * @param string $_mode can be:
2076 2083
 	 * 		single: for a reply to one address
2077 2084
 	 * 		all: for a reply to all
2078 2085
 	 * 		forward: inlineforwarding of a message with its attachments
@@ -3625,7 +3632,7 @@  discard block
 block discarded – undo
3625 3632
 	 * The results are limited to 10 each of group lists and normal lists
3626 3633
 	 *
3627 3634
 	 * @param String $_searchString
3628
-	 * @param Contacts $contacts_obj
3635
+	 * @param Api\Contacts $contacts_obj
3629 3636
 	 * @return array
3630 3637
 	 */
3631 3638
 	protected static function get_lists($_searchString, &$contacts_obj)
Please login to merge, or discard this patch.