Passed
Pull Request — master (#46)
by Neo
33:01
created
resources/inc/class.resources_export_csv.inc.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@
 block discarded – undo
27 27
 	/**
28 28
 	 * Exports records as defined in $_definition
29 29
 	 *
30
-	 * @param egw_record $_definition
30
+	 * @param importexport_definition $_definition
31 31
 	 */
32 32
 	public function export( $_stream, importexport_definition $_definition) {
33 33
 		$options = $_definition->plugin_options;
Please login to merge, or discard this patch.
timesheet/inc/class.timesheet_export_csv.inc.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@  discard block
 block discarded – undo
19 19
 	/**
20 20
 	 * Exports records as defined in $_definition
21 21
 	 *
22
-	 * @param egw_record $_definition
22
+	 * @param importexport_definition $_definition
23 23
 	 */
24 24
 	public function export( $_stream, importexport_definition $_definition) {
25 25
 		$options = $_definition->plugin_options;
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
 	 * return html for options.
89 89
 	 * this way the plugin has all opportunities for options tab
90 90
 	 *
91
-	 * @return string html
91
+	 * @return boolean html
92 92
 	 */
93 93
 	public function get_options_etpl() {
94 94
 		return false;
Please login to merge, or discard this patch.
timesheet/inc/class.timesheet_favorite_portlet.inc.php 1 patch
Doc Comments   -2 removed lines patch added patch discarded remove patch
@@ -92,8 +92,6 @@
 block discarded – undo
92 92
 	 * Here we need to handle any incoming data.  Setup is done in the constructor,
93 93
 	 * output is handled by parent.
94 94
 	 *
95
-	 * @param type $id
96
-	 * @param Etemplate $etemplate
97 95
 	 */
98 96
 	public static function process($content = array())
99 97
 	{
Please login to merge, or discard this patch.
timesheet/inc/class.timesheet_import_csv.inc.php 1 patch
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -104,8 +104,7 @@
 block discarded – undo
104 104
 	/**
105 105
 	 * imports entries according to given definition object.
106 106
 	 * @param resource $_stream
107
-	 * @param string $_charset
108
-	 * @param definition $_definition
107
+	 * @param importexport_definition $_definition
109 108
 	 */
110 109
 	public function import( $_stream, importexport_definition $_definition )
111 110
 	{
Please login to merge, or discard this patch.
timesheet/inc/class.timesheet_ui.inc.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -273,7 +273,7 @@
 block discarded – undo
273 273
 	 * @param int &$success number of succeded actions
274 274
 	 * @param int &$failed number of failed actions (not enought permissions)
275 275
 	 * @param string &$action_msg translated verb for the actions, to be used in a message like %1 timesheets 'deleted'
276
-	 * @param string/array $session_name 'index' or 'email', or array with session-data depending if we are in the main list or the popup
276
+	 * @param string $session_name 'index' or 'email', or array with session-data depending if we are in the main list or the popup
277 277
 	 * @return boolean true if all actions succeded, false otherwise
278 278
 	 */
279 279
 	function action($action,$checked,$use_all,&$success,&$failed,&$action_msg,$session_name,&$msg)
Please login to merge, or discard this patch.
webdav.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@
 block discarded – undo
28 28
  * Create a session or if the user has no account return authenticate header and 401 Unauthorized
29 29
  *
30 30
  * @param array &$account
31
- * @return int session-id
31
+ * @return string session-id
32 32
  */
33 33
 function check_access(&$account)
34 34
 {
Please login to merge, or discard this patch.
api/src/loader/security.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -20,6 +20,7 @@
 block discarded – undo
20 20
  * @param array &$var reference of array to check
21 21
  * @param string $name ='' name of the array
22 22
  * @param boolean $log = true Log the results of checking to the error log
23
+ * @param string[] $var
23 24
  */
24 25
 function _check_script_tag(&$var,$name='',$log=true)
25 26
 {
Please login to merge, or discard this patch.
addressbook/inc/class.addressbook_ui.inc.php 1 patch
Doc Comments   +5 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1127,6 +1127,8 @@  discard block
 block discarded – undo
1127 1127
 	 * @param int &$failed number of failed actions (not enought permissions)
1128 1128
 	 * @param string &$action_msg translated verb for the actions, to be used in a message like %1 contacts 'deleted'
1129 1129
 	 * @param string/array $session_name 'index' or 'email', or array with session-data depending if we are in the main list or the popup
1130
+	 * @param null|integer $success
1131
+	 * @param null|integer $failed
1130 1132
 	 * @return boolean true if all actions succeded, false otherwise
1131 1133
 	 */
1132 1134
 	function action($action,$checked,$use_all,&$success,&$failed,&$action_msg,$session_name,&$msg, $checkboxes = NULL)
@@ -1433,6 +1435,8 @@  discard block
 block discarded – undo
1433 1435
 	 * @param int &$failed number of failed actions (not enought permissions)
1434 1436
 	 * @param string &$action_msg translated verb for the actions, to be used in a message like %1 contacts 'deleted'
1435 1437
 	 * @param string/array $session_name 'index' or 'email', or array with session-data depending if we are in the main list or the popup
1438
+	 * @param integer $success
1439
+	 * @param integer $failed
1436 1440
 	 *
1437 1441
 	 * @return array List of contact IDs in the provided groups
1438 1442
 	 */
@@ -1985,9 +1989,7 @@  discard block
 block discarded – undo
1985 1989
 	/**
1986 1990
 	* Edit a contact
1987 1991
 	*
1988
-	* @param array $content=null submitted content
1989
-	* @param int $_GET['contact_id'] contact_id mainly for popup use
1990
-	* @param bool $_GET['makecp'] true if you want to copy the contact given by $_GET['contact_id']
1992
+	* @param array $content submitted content
1991 1993
 	*/
1992 1994
 	function edit($content=null)
1993 1995
 	{
Please login to merge, or discard this patch.
infolog/inc/class.infolog_ui.inc.php 1 patch
Doc Comments   +9 added lines, -12 removed lines patch added patch discarded remove patch
@@ -295,6 +295,8 @@  discard block
 block discarded – undo
295 295
 	 * @param array &$query
296 296
 	 * @param array &$rows
297 297
 	 * @param array &$readonlys
298
+	 * @param type|null $rows
299
+	 * @param type|null $readonlys
298 300
 	 * @return int
299 301
 	 */
300 302
 	function get_rows(&$query,&$rows,&$readonlys)
@@ -575,7 +577,6 @@  discard block
 block discarded – undo
575 577
 	 * Hook for timesheet to set some extra data and links
576 578
 	 *
577 579
 	 * @param array $data
578
-	 * @param int $data[id] info_id
579 580
 	 * @return array with key => value pairs to set in new timesheet and link_app/link_id arrays
580 581
 	 */
581 582
 	function timesheet_set($data)
@@ -601,7 +602,6 @@  discard block
 block discarded – undo
601 602
 	 * Hook for calendar to set some extra data and links
602 603
 	 *
603 604
 	 * @param array $data event-array preset by calendar plus
604
-	 * @param int $data[entry_id] info_id
605 605
 	 * @return array with key => value pairs to set in new event and link_app/link_id arrays
606 606
 	 */
607 607
 	function calendar_set($data)
@@ -691,9 +691,6 @@  discard block
 block discarded – undo
691 691
 	 * Since the hook has no idea about infolog or preferences, we add the user's
692 692
 	 * current sorting for infolog here so they're in the expected order
693 693
 	 *
694
-	 * @param int $args[year], $args[month], $args[day] date of the events
695
-	 * @param int $args[owner] owner of the events
696
-	 * @param string $args[location] calendar_include_{events|todos}
697 694
 	 * @return array of events (array with keys starttime, endtime, title, view, icon, content)
698 695
 	 */
699 696
 	public function cal_to_include($args)
@@ -711,11 +708,11 @@  discard block
 block discarded – undo
711 708
 	/**
712 709
 	 * Shows the infolog list
713 710
 	 *
714
-	 * @param array/string $values etemplate content or 'reset_action_view' if called by index.php to reset an action-view
711
+	 * @param integer $values etemplate content or 'reset_action_view' if called by index.php to reset an action-view
715 712
 	 * @param string $action if set only entries liked to that $action:$action_id are shown
716 713
 	 * @param string $action_id if set only entries liked to that $action:$action_id are shown
717
-	 * @param mixed $called_as is how we got called, for a hook eg. the call-params of that page containing the hook
718
-	 * @param boolean $e$extra_app_header * @param boolean $return_html=false
714
+	 * @param integer $called_as is how we got called, for a hook eg. the call-params of that page containing the hook
715
+	 * @param boolean $extra_app_header * @param boolean $return_html
719 716
 	 * @param string $own_referer='' this is our own referer
720 717
 	 * @param string $action_title='' app_header for the action, if '' we try the link-title
721 718
 	 */
@@ -1327,7 +1324,7 @@  discard block
 block discarded – undo
1327 1324
 	 * @param array $query get_rows parameter
1328 1325
 	 * @param string &$msg on return user feedback
1329 1326
 	 * @param boolean $skip_notifications true to NOT notify users about changes
1330
-	 * @return boolean true if all actions succeded, false otherwise
1327
+	 * @return boolean|null true if all actions succeded, false otherwise
1331 1328
 	 */
1332 1329
 	function action($_action, $checked, $use_all, &$success, &$failed, &$action_msg,
1333 1330
 		array $query, &$msg, $skip_notifications = false)
@@ -1572,9 +1569,9 @@  discard block
 block discarded – undo
1572 1569
 	/**
1573 1570
 	 * Closes an infolog
1574 1571
 	 *
1575
-	 * @param int|array $values=0 info_id (default _GET[info_id])
1572
+	 * @param int|array $values info_id (default _GET[info_id])
1576 1573
 	 * @param string $_referer=''
1577
-	 * @param boolean $closesingle=false
1574
+	 * @param boolean $closesingle
1578 1575
 	 */
1579 1576
 	function close($values=0,$_referer='',$closesingle=false,$skip_notification = false)
1580 1577
 	{
@@ -1622,7 +1619,7 @@  discard block
 block discarded – undo
1622 1619
 	/**
1623 1620
 	 * Deletes an InfoLog entry
1624 1621
 	 *
1625
-	 * @param array|int $values info_id (default _GET[info_id])
1622
+	 * @param integer $values info_id (default _GET[info_id])
1626 1623
 	 * @param string $_referer
1627 1624
 	 * @param string $called_by
1628 1625
 	 * @param boolean $skip_notification Do not send notification of deletion
Please login to merge, or discard this patch.