Passed
Pull Request — master (#46)
by Neo
33:01
created
admin/inc/class.admin_customfields.inc.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -548,7 +548,7 @@
 block discarded – undo
548 548
 	 * Validate and create a new content type
549 549
 	 *
550 550
 	 * @param array $content
551
-	 * @return string|boolean New type ID, or false for error
551
+	 * @return false|string New type ID, or false for error
552 552
 	 */
553 553
 	function create_content_type(&$content)
554 554
 	{
Please login to merge, or discard this patch.
api/src/Storage/Merge.php 1 patch
Doc Comments   +15 added lines, -8 removed lines patch added patch discarded remove patch
@@ -373,9 +373,9 @@  discard block
 block discarded – undo
373 373
 	 *
374 374
 	 * Calls get_links() repeatedly to get all the combinations for the content.
375 375
 	 *
376
-	 * @param $app String appname
377
-	 * @param $id String ID of record
378
-	 * @param $prefix
376
+	 * @param string $app String appname
377
+	 * @param integer $id String ID of record
378
+	 * @param string $prefix
379 379
 	 * @param $content String document content
380 380
 	 */
381 381
 	protected function get_all_links($app, $id, $prefix, &$content)
@@ -535,7 +535,7 @@  discard block
 block discarded – undo
535 535
 	 * @param mixed $app_limit app_limit, if not set checks the global limit
536 536
 	 * @param string $checkas [AND|ISALLOWED], AND default; if set to ISALLOWED it is checked if Export is allowed
537 537
 	 *
538
-	 * @return bool - true if no export is allowed or a limit is set, false if there is no restriction
538
+	 * @return boolean|null - true if no export is allowed or a limit is set, false if there is no restriction
539 539
 	 */
540 540
 	public static function hasExportLimit($app_limit,$checkas='AND')
541 541
 	{
@@ -585,6 +585,9 @@  discard block
 block discarded – undo
585 585
 		return $content;
586 586
 	}
587 587
 
588
+	/**
589
+	 * @param string $mimetype
590
+	 */
588 591
 	protected function apply_styles (&$content, $mimetype, $mso_application_progid=null)
589 592
 	{
590 593
 		if (!isset($mso_application_progid))
@@ -1178,6 +1181,8 @@  discard block
 block discarded – undo
1178 1181
 
1179 1182
 	/**
1180 1183
 	 * Convert numeric values in spreadsheets into actual numeric values
1184
+	 * @param string $content
1185
+	 * @param string $mimetype
1181 1186
 	 */
1182 1187
 	protected function format_spreadsheet_numbers(&$content, $names, $mimetype)
1183 1188
 	{
@@ -1247,6 +1252,7 @@  discard block
 block discarded – undo
1247 1252
 
1248 1253
 	/**
1249 1254
 	 * Convert date / timestamp values in spreadsheets into actual date / timestamp values
1255
+	 * @param string $mimetype
1250 1256
 	 */
1251 1257
 	protected function format_spreadsheet_dates(&$content, $names, &$values, $mimetype)
1252 1258
 	{
@@ -1351,6 +1357,7 @@  discard block
 block discarded – undo
1351 1357
 	/**
1352 1358
 	 * Expand link_to custom fields with the merge replacements from the app
1353 1359
 	 * but only if the template uses them.
1360
+	 * @param string $app
1354 1361
 	 */
1355 1362
 	public function cf_link_to_expand($values, $content, &$replacements, $app = null)
1356 1363
 	{
@@ -1416,7 +1423,7 @@  discard block
 block discarded – undo
1416 1423
 	/**
1417 1424
 	 * Process special flags, such as IF or NELF
1418 1425
 	 *
1419
-	 * @param content Text to be examined and changed
1426
+	 * @param content string to be examined and changed
1420 1427
 	 * @param replacements array of markers => replacement
1421 1428
 	 *
1422 1429
 	 * @return changed content
@@ -1729,8 +1736,7 @@  discard block
 block discarded – undo
1729 1736
 	 * Get a list of document actions / files from the given directory
1730 1737
 	 *
1731 1738
 	 * @param string $dirs Directory(s comma or space separated) to search
1732
-	 * @param string $prefix='document_' prefix for array keys
1733
-	 * @param array|string $mime_filter=null allowed mime type(s), default all, negative filter if $mime_filter[0] === '!'
1739
+	 * @param array|string $mime_filter allowed mime type(s), default all, negative filter if $mime_filter[0] === '!'
1734 1740
 	 * @return array List of documents, suitable for a selectbox.  The key is document_<filename>.
1735 1741
 	 */
1736 1742
 	public static function get_documents($dirs, $prefix='document_', $mime_filter=null, $app='')
@@ -1997,7 +2003,8 @@  discard block
 block discarded – undo
1997 2003
 	 *
1998 2004
 	 * @param string &$document maybe relative path of document, on return true absolute path to existing document
1999 2005
 	 * @param string $dirs comma or whitespace separated directories
2000
-	 * @return string|boolean false if document exists, otherwise string with error-message
2006
+	 * @param string $document
2007
+	 * @return false|string false if document exists, otherwise string with error-message
2001 2008
 	 */
2002 2009
 	public static function check_document(&$document, $dirs)
2003 2010
 	{
Please login to merge, or discard this patch.
api/src/Link.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -433,7 +433,7 @@  discard block
 block discarded – undo
433 433
 	 * generate temporary link_id used as array-key
434 434
 	 *
435 435
 	 * @param string $app app-name
436
-	 * @param mixed $id
436
+	 * @param string $id
437 437
 	 * @return string
438 438
 	 */
439 439
 	static function temp_link_id($app,$id)
@@ -579,7 +579,7 @@  discard block
 block discarded – undo
579 579
 	 * @param string|array $id ='' id if $app_link_id is an appname or array with links, if 1. entry not yet created
580 580
 	 * @param string $app2 ='' second app
581 581
 	 * @param string $id2 ='' id in $app2
582
-	 * @return array with link-data or False
582
+	 * @return string with link-data or False
583 583
 	 */
584 584
 	static function get_link($app_link_id,$id='',$app2='',$id2='')
585 585
 	{
@@ -1197,7 +1197,7 @@  discard block
 block discarded – undo
1197 1197
 	 * @param string $app appname to link the file to
1198 1198
 	 * @param string $id id in $app
1199 1199
 	 * @param string $file VFS path to link to
1200
-	 * @return boolean true on success, false on failure
1200
+	 * @return null|boolean true on success, false on failure
1201 1201
 	 */
1202 1202
 	static function link_file($app,$id,$file)
1203 1203
 	{
Please login to merge, or discard this patch.
api/src/Accounts.php 1 patch
Doc Comments   +2 added lines, -3 removed lines patch added patch discarded remove patch
@@ -799,7 +799,7 @@  discard block
 block discarded – undo
799 799
 	 * Not all existing accounts are visible because off account_selection preference: 'none' or 'groupmembers'
800 800
 	 *
801 801
 	 * @param int|string $account_id nummeric account_id or account_lid
802
-	 * @return boolean true = account is visible, false = account not visible, null = account does not exist
802
+	 * @return null|boolean true = account is visible, false = account not visible, null = account does not exist
803 803
 	 */
804 804
 	function visible($account_id)
805 805
 	{
@@ -994,7 +994,6 @@  discard block
 block discarded – undo
994 994
 	 *
995 995
 	 * @param string $account_lid
996 996
 	 * @param string $passwd
997
-	 * @param array $GLOBALS['auto_create_acct'] values for 'firstname', 'lastname', 'email' and 'primary_group'
998 997
 	 * @return int|boolean account_id or false on error
999 998
 	 */
1000 999
 	function auto_add($account_lid, $passwd)
@@ -1114,7 +1113,7 @@  discard block
 block discarded – undo
1114 1113
 	 *
1115 1114
 	 * We use now an instance-wide read-cache storing account-data and members(hips).
1116 1115
 	 *
1117
-	 * @param int|array $account_ids user- or group-id(s) for which cache should be invalidated, default 0 = only search/name2id cache
1116
+	 * @param integer $account_ids user- or group-id(s) for which cache should be invalidated, default 0 = only search/name2id cache
1118 1117
 	 */
1119 1118
 	static function cache_invalidate($account_ids=0)
1120 1119
 	{
Please login to merge, or discard this patch.
api/src/Contacts/Ldap.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -213,7 +213,6 @@
 block discarded – undo
213 213
 	/**
214 214
 	 * Remove attributes we are not allowed to update
215 215
 	 *
216
-	 * @param array $attributes
217 216
 	 */
218 217
 	function sanitize_update(array &$ldapContact)
219 218
 	{
Please login to merge, or discard this patch.
api/src/Mailer.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -251,7 +251,7 @@  discard block
 block discarded – undo
251 251
 	/**
252 252
 	 * Add one or multiple addresses to Cc
253 253
 	 *
254
-	 * @param string|array|Horde_Mail_Rfc822_List $address
254
+	 * @param string $address
255 255
 	 * @param string $personal ='' only used if $address is a string
256 256
 	 */
257 257
 	function addCc($address, $personal=null)
@@ -381,7 +381,7 @@  discard block
 block discarded – undo
381 381
 	/**
382 382
 	 * Adds an embedded image or other inline attachment
383 383
 	 *
384
-	 * @param string|resource $data Path to the attachment or open file-descriptor
384
+	 * @param string $data Path to the attachment or open file-descriptor
385 385
 	 * @param string $cid Content ID of the attachment.  Use this to identify
386 386
 	 *        the Id for accessing the image in an HTML form.
387 387
 	 * @param string $name Overrides the attachment name.
Please login to merge, or discard this patch.
calendar/inc/class.calendar_category_report.inc.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -89,6 +89,7 @@
 block discarded – undo
89 89
 	 * @param int $weekend weekend option
90 90
 	 * @param int $min_days min_days option
91 91
 	 * @param int $unit unit option
92
+	 * @param integer $end_range
92 93
 	 *
93 94
 	 */
94 95
 	public function process_days(&$events_log, &$week_sum, &$day,$day_index, $events, $cat_id, $holidays, $weekend, $min_days, $unit, $start_range, $end_range)
Please login to merge, or discard this patch.
addressbook/inc/class.addressbook_export_vcard.inc.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@
 block discarded – undo
36 36
 	/**
37 37
 	 * Exports records as defined in $_definition
38 38
 	 *
39
-	 * @param egw_record $_definition
39
+	 * @param importexport_definition $_definition
40 40
 	 */
41 41
 	public function export( $_stream, importexport_definition $_definition) {
42 42
 
Please login to merge, or discard this patch.
admin/inc/class.admin_export_users_csv.inc.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@  discard block
 block discarded – undo
19 19
 	/**
20 20
 	 * Exports records as defined in $_definition
21 21
 	 *
22
-	 * @param egw_record $_definition
22
+	 * @param importexport_definition $_definition
23 23
 	 */
24 24
 	public function export( $_stream, importexport_definition $_definition) {
25 25
 		$options = $_definition->plugin_options;
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
 	 * return html for options.
89 89
 	 * this way the plugin has all opportunities for options tab
90 90
 	 *
91
-	 * @return string html
91
+	 * @return boolean html
92 92
 	 */
93 93
 	public function get_options_etpl() {
94 94
 		return false;
Please login to merge, or discard this patch.