Passed
Pull Request — master (#46)
by Neo
33:01
created
remote.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@
 block discarded – undo
28 28
  * Create a session or if the user has no account return authenticate header and 401 Unauthorized
29 29
  *
30 30
  * @param array &$account
31
- * @return int session-id
31
+ * @return string session-id
32 32
  */
33 33
 function check_access(&$account)
34 34
 {
Please login to merge, or discard this patch.
resources/inc/class.resources_acl_bo.inc.php 1 patch
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -43,7 +43,6 @@  discard block
 block discarded – undo
43 43
 	/**
44 44
 	 * Constructor
45 45
 	 *
46
-	 * @param int $user=null account_id of user whos rights to return, or null for current user
47 46
 	 * @param boolean $session
48 47
 	 */
49 48
 	function __construct($session=False, $user=null)
@@ -77,7 +76,7 @@  discard block
 block discarded – undo
77 76
 	*
78 77
 	* @author Cornelius Weiss <[email protected]>
79 78
 	* @param int $perm_type one of Acl::READ, Acl::ADD, Acl::EDIT, Acl::DELETE, self::DIRECT_BOOKING
80
-	* @param int $parent_id=0 cat_id of parent to return only children of that category
79
+	* @param int $parent_id cat_id of parent to return only children of that category
81 80
 	* @return array cat_id => cat_name
82 81
 	* TODO mark subcats and so on!
83 82
 	*/
Please login to merge, or discard this patch.
resources/inc/class.resources_import_csv.inc.php 1 patch
Doc Comments   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -28,9 +28,7 @@  discard block
 block discarded – undo
28 28
 
29 29
 	/**
30 30
 	 * imports entries according to given definition object.
31
-	 * @param resource $_stream
32
-	 * @param string $_charset
33
-	 * @param definition $_definition
31
+	 * @param importexport_definition $_definition
34 32
 	 */
35 33
 	public function init(importexport_definition $_definition ) {
36 34
 
@@ -52,7 +50,7 @@  discard block
 block discarded – undo
52 50
 	*
53 51
 	* Updates the count of actions taken
54 52
 	*
55
-	* @return boolean success
53
+	* @return null|boolean success
56 54
 	*/
57 55
 	protected function import_record(importexport_iface_egw_record &$record, &$import_csv)
58 56
 	{
Please login to merge, or discard this patch.
resources/inc/class.resources_so.inc.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@
 block discarded – undo
33 33
 	 *
34 34
 	 * @param string $key key of value to get
35 35
 	 * @param int $res_id resource id
36
-	 * @return mixed value of key and resource, false if key or id not found.
36
+	 * @return integer value of key and resource, false if key or id not found.
37 37
 	 */
38 38
 	function get_value($key,$res_id)
39 39
 	{
Please login to merge, or discard this patch.
resources/inc/class.resources_ui.inc.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -273,7 +273,7 @@
 block discarded – undo
273 273
 	 * @param int &$success number of succeded actions
274 274
 	 * @param int &$failed number of failed actions (not enought permissions)
275 275
 	 * @param string &$action_msg translated verb for the actions, to be used in a message like %1 timesheets 'deleted'
276
-	 * @param string/array $session_name 'index' or 'email', or array with session-data depending if we are in the main list or the popup
276
+	 * @param string $session_name 'index' or 'email', or array with session-data depending if we are in the main list or the popup
277 277
 	 * @return boolean true if all actions succeded, false otherwise
278 278
 	 */
279 279
 	function action($action,$checked,$use_all,&$success,&$failed,&$action_msg,$session_name,&$msg)
Please login to merge, or discard this patch.
setup/check_install.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -316,6 +316,7 @@
 block discarded – undo
316 316
  * Check if given package is installed via composer in EGroupware's vendor directory
317 317
  *
318 318
  * @param string $package package-name in composer notation eg. "pear-pear.horde.org/Horde_Imap_Client" or "pear-pear.php.net/Net_Sieve"
319
+ * @return string|null
319 320
  */
320 321
 function composer_check($package)
321 322
 {
Please login to merge, or discard this patch.
setup/inc/class.setup.inc.php 1 patch
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -741,8 +741,8 @@  discard block
 block discarded – undo
741 741
 	/**
742 742
 	 * egw version checking, is param 1 < param 2 in phpgw versionspeak?
743 743
 	 * @param	$a	phpgw version number to check if less than $b
744
-	 * @param	$b	phpgw version number to check $a against
745
-	 * @return	True if $a < $b
744
+	 * @param	string $b	phpgw version number to check $a against
745
+	 * @return	boolean if $a < $b
746 746
 	 */
747 747
 	function alessthanb($a,$b,$DEBUG=False)
748 748
 	{
@@ -829,7 +829,7 @@  discard block
 block discarded – undo
829 829
 	 *
830 830
 	 * @param	$a	phpgw version number to check if more than $b
831 831
 	 * @param	$b	phpgw version number to check $a against
832
-	 * @return	True if $a < $b
832
+	 * @return	boolean if $a < $b
833 833
 	 */
834 834
 	function amorethanb($a,$b,$DEBUG=False)
835 835
 	{
@@ -1101,7 +1101,7 @@  discard block
 block discarded – undo
1101 1101
 	 *
1102 1102
 	 * Dont use it to set group-membership, use set_memberships instead!
1103 1103
 	 *
1104
-	 * @param string|array $apps app-names
1104
+	 * @param string $apps app-names
1105 1105
 	 * @param string $location eg. "run"
1106 1106
 	 * @param int|string $account accountid or account_lid
1107 1107
 	 * @param int $rights rights to set, default 1
@@ -1147,7 +1147,7 @@  discard block
 block discarded – undo
1147 1147
 	/**
1148 1148
 	 * checks if one of the given tables exist, returns the first match
1149 1149
 	 *
1150
-	 * @param array $tables array with possible table-names
1150
+	 * @param string[] $tables array with possible table-names
1151 1151
 	 * @return string/boolean tablename or false
1152 1152
 	 */
1153 1153
 	function table_exist($tables,$force_refresh=False)
Please login to merge, or discard this patch.
setup/inc/class.setup_cmd_header.inc.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@
 block discarded – undo
35 35
 	/**
36 36
 	 * Constructor
37 37
 	 *
38
-	 * @param string|array $sub_command ='create' 'create','edit','delete'(-domain) or array with all arguments
38
+	 * @param string $sub_command ='create' 'create','edit','delete'(-domain) or array with all arguments
39 39
 	 * @param array $arguments =null comand line arguments
40 40
 	 */
41 41
 	function __construct($sub_command='create',$arguments=null)
Please login to merge, or discard this patch.
setup/inc/class.setup_cmd_hooks.inc.php 1 patch
Doc Comments   +2 added lines, -3 removed lines patch added patch discarded remove patch
@@ -19,9 +19,8 @@
 block discarded – undo
19 19
 	 * Constructor
20 20
 	 *
21 21
 	 * @param string $domain string with domain-name or array with all arguments
22
-	 * @param string $config_user=null user to config the domain (or header_admin_user)
23
-	 * @param string $config_passwd=null pw of above user
24
-	 * @param boolean $verbose=false if true, echos out some status information during the run
22
+	 * @param string $config_user user to config the domain (or header_admin_user)
23
+	 * @param string $config_passwd pw of above user
25 24
 	 */
26 25
 	function __construct($domain,$config_user=null,$config_passwd=null)
27 26
 	{
Please login to merge, or discard this patch.