Passed
Push — 17.1 ( 431f3f...4dae72 )
by Ralf
01:23 queued 12s
created
calendar/importexport/class.import_events_csv.inc.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -94,7 +94,6 @@
 block discarded – undo
94 94
 	/**
95 95
 	 * imports entries according to given definition object.
96 96
 	 * @param resource $_stream
97
-	 * @param string $_charset
98 97
 	 * @param definition $_definition
99 98
 	 */
100 99
 	public function import( $_stream, definition $_definition ) {
Please login to merge, or discard this patch.
calendar/inc/class.calendar_boupdate.inc.php 1 patch
Doc Comments   +11 added lines, -6 removed lines patch added patch discarded remove patch
@@ -519,6 +519,7 @@  discard block
 block discarded – undo
519 519
 	 * @param array $new_event Event after the change
520 520
 	 * @param string $role we treat CHAIR like event owners
521 521
 	 * @param string $status of current user
522
+	 * @param integer $msg_type
522 523
 	 * @return boolean true = update requested, false otherwise
523 524
 	 */
524 525
 	public static function update_requested($userid, $part_prefs, &$msg_type, $old_event ,$new_event, $role, $status=null)
@@ -594,7 +595,7 @@  discard block
 block discarded – undo
594 595
 	/**
595 596
 	 * Check calendar prefs, if a given user (integer account_id) or email (user or externals) should get notified
596 597
 	 *
597
-	 * @param int|string $user_or_email
598
+	 * @param string $user_or_email
598 599
 	 * @param string $ical_method ='REQUEST'
599 600
 	 * @param string $role ='REQ-PARTICIPANT'
600 601
 	 * @return boolean true if user requested to be notified, false if not
@@ -645,8 +646,7 @@  discard block
 block discarded – undo
645 646
 	 * Get iCal/iMip method from internal nummeric msg-type plus optional notification message and verbose name
646 647
 	 *
647 648
 	 * @param int $msg_type see MSG_* defines
648
-	 * @param string& $action=null on return verbose name
649
-	 * @param string& $msg=null on return notification message
649
+	 * @param string& $action on return verbose name
650 650
 	 */
651 651
 	function msg_type2ical_method($msg_type, &$action=null, &$msg=null)
652 652
 	{
@@ -1011,6 +1011,9 @@  discard block
 block discarded – undo
1011 1011
 		return true;
1012 1012
 	}
1013 1013
 
1014
+	/**
1015
+	 * @param integer $added
1016
+	 */
1014 1017
 	function get_update_message($event,$added)
1015 1018
 	{
1016 1019
 		$nul = null;
@@ -1300,8 +1303,8 @@  discard block
 block discarded – undo
1300 1303
 	 *
1301 1304
 	 * @param int $right self::CAT_ACL_{ADD|STATUS}
1302 1305
 	 * @param int|array $event
1303
-	 * @return boolean true if use has the right, false if not
1304
-	 * @return boolean false=access denied because of cat acl, true access granted because of cat acl,
1306
+	 * @return null|boolean true if use has the right, false if not
1307
+	 * @return null|boolean false=access denied because of cat acl, true access granted because of cat acl,
1305 1308
 	 * 	null = cat has no acl
1306 1309
 	 */
1307 1310
 	function check_cat_acl($right,$event)
@@ -1386,6 +1389,8 @@  discard block
 block discarded – undo
1386 1389
 	 * Check if current user has a given right on a category (if it's restricted!)
1387 1390
 	 *
1388 1391
 	 * @param int $cat_id
1392
+	 * @param integer $right
1393
+	 * @param integer $user
1389 1394
 	 * @return boolean false=access denied because of cat acl, true access granted because of cat acl,
1390 1395
 	 * 	null = cat has no acl
1391 1396
 	 */
@@ -1647,7 +1652,7 @@  discard block
 block discarded – undo
1647 1652
 	 * @param string $action
1648 1653
 	 * @param array $event_arr
1649 1654
 	 * @param array $disinvited
1650
-	 * @return array
1655
+	 * @return string
1651 1656
 	 */
1652 1657
 	function _get_event_details($event,$action,&$event_arr,$disinvited=array())
1653 1658
 	{
Please login to merge, or discard this patch.
calendar/inc/class.calendar_holidays.inc.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -135,6 +135,9 @@
 block discarded – undo
135 135
 		return $until_year ? $years : $years[$year];
136 136
 	}
137 137
 
138
+	/**
139
+	 * @param string $url
140
+	 */
138 141
 	protected static function is_url($url)
139 142
 	{
140 143
 		return $url[0] == '/' || strpos($url, '://') !== false;
Please login to merge, or discard this patch.
calendar/inc/class.calendar_timezones.inc.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -204,6 +204,7 @@
 block discarded – undo
204 204
 	 *
205 205
 	 * @param boolean &$updated=null on return true if update was neccessary, false if tz's were already up to date
206 206
 	 * @param string $file ='calendar/setup/timezones.sqlite' filename relative to EGW_SERVER_ROOT
207
+	 * @param boolean $updated
207 208
 	 * @return string message about update
208 209
 	 * @throws Api\Exception\WrongParameter if $file is not readable or wrong format/version
209 210
 	 * @throws Api\Exception\WrongUserinput if no PDO sqlite support
Please login to merge, or discard this patch.
calendar/inc/class.calendar_uiforms.inc.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1077,7 +1077,7 @@  discard block
 block discarded – undo
1077 1077
 	 *	date instead of today
1078 1078
 	 * @param boolean $no_notifications Toggle notifications to participants
1079 1079
 	 *
1080
-	 * @return false or error message
1080
+	 * @return string|false or error message
1081 1081
 	 */
1082 1082
 	function _break_recurring(&$event, $old_event, $as_of_date = null, $no_notifications = true)
1083 1083
 	{
@@ -2173,7 +2173,7 @@  discard block
 block discarded – undo
2173 2173
 	 * Freetime search
2174 2174
 	 *
2175 2175
 	 * As the function is called in a popup via javascript, parametes get initialy transfered via the url
2176
-	 * @param array $content=null array with parameters or false (default) to use the get-params
2176
+	 * @param array $content array with parameters or false (default) to use the get-params
2177 2177
 	 * @param string start[str] start-date
2178 2178
 	 * @param string start[hour] start-hour
2179 2179
 	 * @param string start[min] start-minutes
@@ -2417,7 +2417,7 @@  discard block
 block discarded – undo
2417 2417
 	/**
2418 2418
      * Export events as vCalendar version 2.0 files (iCal)
2419 2419
      *
2420
-     * @param int|array $content numeric cal_id or submitted content from etempalte::exec
2420
+     * @param integer $content numeric cal_id or submitted content from etempalte::exec
2421 2421
      * @param boolean $return_error should an error-msg be returned or a regular page with it generated (default)
2422 2422
      * @return string error-msg if $return_error
2423 2423
      */
Please login to merge, or discard this patch.
calendar/inc/class.calendar_uilist.inc.php 1 patch
Doc Comments   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -539,8 +539,9 @@
 block discarded – undo
539 539
 	 * @param int &$success number of succeded actions
540 540
 	 * @param int &$failed number of failed actions (not enought permissions)
541 541
 	 * @param string &$action_msg translated verb for the actions, to be used in a message like %1 events 'deleted'
542
-	 * @param string/array $session_name 'calendar_list'
543
-	 * @return boolean true if all actions succeded, false otherwise
542
+	 * @param string $session_name 'calendar_list'
543
+	 * @param null|string $msg
544
+	 * @return null|boolean true if all actions succeded, false otherwise
544 545
 	 */
545 546
 	function action($action,$checked,$use_all,&$success,&$failed,&$action_msg,$session_name,&$msg,$skip_notification=false)
546 547
 	{
Please login to merge, or discard this patch.
calendar/inc/class.calendar_uiviews.inc.php 1 patch
Doc Comments   +8 added lines, -6 removed lines patch added patch discarded remove patch
@@ -412,7 +412,7 @@  discard block
 block discarded – undo
412 412
 	/**
413 413
 	 * Displays the planner view
414 414
 	 *
415
-	 * @param boolean|Etemplate $home = false if etemplate return content suitable for home-page
415
+	 * @param null|Etemplate $home = false if etemplate return content suitable for home-page
416 416
 	 */
417 417
 	function &planner($content = array(), $home=false)
418 418
 	{
@@ -497,7 +497,7 @@  discard block
 block discarded – undo
497 497
 	 * Used for home app
498 498
 	 *
499 499
 	 * @param int $weeks = 0 number of weeks to show, if 0 (default) all weeks of one month are shown
500
-	 * @param boolean|etemplate2 $home = false if not false return content suitable for home-page
500
+	 * @param null|Etemplate $home = false if not false return content suitable for home-page
501 501
 	 */
502 502
 	function &month($weeks=0,$home=false)
503 503
 	{
@@ -580,6 +580,8 @@  discard block
 block discarded – undo
580 580
 	 * @param int &$first timestamp 0h of first day of week containing the first of the current month
581 581
 	 * @param int &$last timestamp 23:59:59 of last day of week containg the last day of the current month
582 582
 	 * @param int $day = 1 should the alignment be based on the 1. of the month or an other date, eg. the 15.
583
+	 * @param integer $first
584
+	 * @param integer $last
583 585
 	 */
584 586
 	function _week_align_month(&$first,&$last,$day=1)
585 587
 	{
@@ -604,7 +606,7 @@  discard block
 block discarded – undo
604 606
 	 * Displays the weekview, with 5 or 7 days
605 607
 	 *
606 608
 	 * @param int $days = 0 number of days to show, if 0 (default) the value from the URL or the prefs is used
607
-	 * @param boolean|etemplate2 $home = false if not false return content suitable for home-page
609
+	 * @param null|Etemplate $home = false if not false return content suitable for home-page
608 610
 	 */
609 611
 	function week($days=0,$home=false)
610 612
 	{
@@ -740,7 +742,7 @@  discard block
 block discarded – undo
740 742
 	/**
741 743
 	 * Query the open ToDo's via a hook from InfoLog or any other 'calendar_include_todos' provider
742 744
 	 *
743
-	 * @param array/string $todo_label label for the todo-box or array with 2 values: the label and a boolean show_all
745
+	 * @param string $todo_label label for the todo-box or array with 2 values: the label and a boolean show_all
744 746
 	 *	On return $todo_label contains the label for the todo-box
745 747
 	 * @return string/boolean Api\Html with a table of open todo's or false if no hook availible
746 748
 	 */
@@ -824,7 +826,7 @@  discard block
 block discarded – undo
824 826
 	 * - 'edit_popup' => '400x300' (optional)
825 827
 	 *
826 828
 	 * @param string $app
827
-	 * @param int|string $id
829
+	 * @param string $id
828 830
 	 * @return string
829 831
 	 */
830 832
 	public static function integration_get_popup($app,$id)
@@ -864,7 +866,7 @@  discard block
 block discarded – undo
864 866
 	 * Icons specified in $events['icons'] are always displayed!
865 867
 	 *
866 868
 	 * @param string $app
867
-	 * @param int|string $id
869
+	 * @param string $id
868 870
 	 * @param array $event
869 871
 	 * @return array
870 872
 	 */
Please login to merge, or discard this patch.
calendar/setup/tables_update.inc.php 1 patch
Doc Comments   +5 added lines, -1 removed lines patch added patch discarded remove patch
@@ -11,6 +11,10 @@  discard block
 block discarded – undo
11 11
 
12 12
 use EGroupware\Api;
13 13
 
14
+/**
15
+ * @param string $table
16
+ * @param string $field
17
+ */
14 18
 function calendar_v0_9_2to0_9_3update_owner($table, $field)
15 19
 {
16 20
 	$GLOBALS['egw_setup']->oProc->query("select distinct($field) from $table");
@@ -2306,7 +2310,7 @@  discard block
 block discarded – undo
2306 2310
  *
2307 2311
  * Also fix recurring events containing a reference to an other master, created when an exception is made a recurring event.
2308 2312
  *
2309
- * @return type
2313
+ * @return string
2310 2314
  */
2311 2315
 function calendar_upgrade14_1()
2312 2316
 {
Please login to merge, or discard this patch.
doc/fix_api.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -187,7 +187,7 @@
 block discarded – undo
187 187
  *
188 188
  * @param string $file filename
189 189
  * @param boolean $dry_run =false true: only echo fixed file, not fix it
190
- * @return boolean false on error
190
+ * @return boolean|null false on error
191 191
  */
192 192
 function fix_api($file, $dry_run=false)
193 193
 {
Please login to merge, or discard this patch.