EGroupware / egroupware

infolog/inc/class.infolog_egw_record.inc.php

Indentation +4 added lines, -4 removed lines

@@ -25,11 +25,11 @@
 	// Used in conversions
 	static $types = array(
 		'select' => array('info_type', 'info_status', 'info_priority', 'pl_id'),
-                'select-cat' => array('info_cat'),
-                'select-account' => array('info_owner','info_responsible','info_modifier'),
-                'date-time' => array('info_startdate', 'info_enddate','info_datecompleted', 'info_datemodified','info_created'),
+				'select-cat' => array('info_cat'),
+				'select-account' => array('info_owner','info_responsible','info_modifier'),
+				'date-time' => array('info_startdate', 'info_enddate','info_datecompleted', 'info_datemodified','info_created'),
 		'links' => array('info_link_id'),
-        );
+		);
 
 	/**
 	 * constructor

Spacing +10 added lines, -10 removed lines

@@ -26,8 +26,8 @@ 
 	static $types = array(
 		'select' => array('info_type', 'info_status', 'info_priority', 'pl_id'),
                 'select-cat' => array('info_cat'),
-                'select-account' => array('info_owner','info_responsible','info_modifier'),
-                'date-time' => array('info_startdate', 'info_enddate','info_datecompleted', 'info_datemodified','info_created'),
+                'select-account' => array('info_owner', 'info_responsible', 'info_modifier'),
+                'date-time' => array('info_startdate', 'info_enddate', 'info_datecompleted', 'info_datemodified', 'info_created'),
 		'links' => array('info_link_id'),
         );
 
@@ -37,10 +37,10 @@ 
 	 *
 	 * @param string $_identifier
 	 */
-	public function __construct( $_identifier='' ){
+	public function __construct($_identifier = '') {
 		$this->identifier = $_identifier;
-		if(self::$bo == null) self::$bo = new infolog_bo();
-		if($_identifier) {
+		if (self::$bo == null) self::$bo = new infolog_bo();
+		if ($_identifier) {
 			$rec = self::$bo->read($this->identifier);
 			if (is_array($rec)) $this->set_record($rec);
 		}
@@ -95,7 +95,7 @@ 
 	 * @todo add some checks
 	 * @return void
 	 */
-	public function set_record(array $_record){
+	public function set_record(array $_record) {
 		$this->record = $_record;
 	}
 
@@ -133,7 +133,7 @@ 
 	 *
 	 * @return string identifier
 	 */
-	public function save ( $_dst_identifier ) {
+	public function save($_dst_identifier) {
 
 	}
 
@@ -143,7 +143,7 @@ 
 	 * @param string $_dst_identifier
 	 * @return string dst_identifier
 	 */
-	public function copy ( $_dst_identifier ) {
+	public function copy($_dst_identifier) {
 
 	}
 
@@ -154,7 +154,7 @@ 
 	 * @param string $_dst_identifier
 	 * @return string dst_identifier
 	 */
-	public function move ( $_dst_identifier ) {
+	public function move($_dst_identifier) {
 
 	}
 
@@ -162,7 +162,7 @@ 
 	 * delets current record from backend
 	 *
 	 */
-	public function delete () {
+	public function delete() {
 
 	}
 

Braces +36 added lines, -16 removed lines

@@ -37,12 +37,20 @@ 
 	 *
 	 * @param string $_identifier
 	 */
-	public function __construct( $_identifier='' ){
+	public function __construct( $_identifier='' )
+	{
 		$this->identifier = $_identifier;
-		if(self::$bo == null) self::$bo = new infolog_bo();
-		if($_identifier) {
+		if(self::$bo == null)
+		{
+			self::$bo = new infolog_bo();
+		}
+		if($_identifier)
+		{
 			$rec = self::$bo->read($this->identifier);
-			if (is_array($rec)) $this->set_record($rec);
+			if (is_array($rec))
+			{
+				$this->set_record($rec);
+			}
 		}
 	}
 
@@ -51,7 +59,8 @@ 
 	 *
 	 * @param string $_attribute_name
 	 */
-	public function __get($_attribute_name) {
+	public function __get($_attribute_name)
+	{
 		return $this->record[$_attribute_name];
 	}
 
@@ -61,7 +70,8 @@ 
 	 * @param string $_attribute_name
 	 * @param data $data
 	 */
-	public function __set($_attribute_name, $data) {
+	public function __set($_attribute_name, $data)
+	{
 		$this->record[$_attribute_name] = $data;
 	}
 
@@ -73,7 +83,8 @@ 
 	 *
 	 * @return array complete record as associative array
 	 */
-	public function get_record_array() {
+	public function get_record_array()
+	{
 		return $this->record;
 	}
 
@@ -82,7 +93,8 @@ 
 	 *
 	 *@return string tiltle
 	 */
-	public function get_title() {
+	public function get_title()
+	{
 		return self::$bo->link_title($this->record);
 	}
 
@@ -92,7 +104,8 @@ 
 	 * @todo add some checks
 	 * @return void
 	 */
-	public function set_record(array $_record){
+	public function set_record(array $_record)
+	{
 		$this->record = $_record;
 	}
 
@@ -101,7 +114,8 @@ 
 	 *
 	 * @return string identifier of current record
 	 */
-	public function get_identifier() {
+	public function get_identifier()
+	{
 		return $this->identifier;
 	}
 
@@ -111,7 +125,8 @@ 
 	 *
 	 * @return string Full URL of an icon, or appname/icon_name
 	 */
-	public function get_icon() {
+	public function get_icon()
+	{
 		$icon = 'infolog/navbar';
 		$ui = new infolog_ui();
 		if (!($icon = $ui->icons['type'][$this->info_type]))
@@ -130,7 +145,8 @@ 
 	 *
 	 * @return string identifier
 	 */
-	public function save ( $_dst_identifier ) {
+	public function save ( $_dst_identifier )
+	{
 
 	}
 
@@ -140,7 +156,8 @@ 
 	 * @param string $_dst_identifier
 	 * @return string dst_identifier
 	 */
-	public function copy ( $_dst_identifier ) {
+	public function copy ( $_dst_identifier )
+	{
 
 	}
 
@@ -151,7 +168,8 @@ 
 	 * @param string $_dst_identifier
 	 * @return string dst_identifier
 	 */
-	public function move ( $_dst_identifier ) {
+	public function move ( $_dst_identifier )
+	{
 
 	}
 
@@ -159,7 +177,8 @@ 
 	 * delets current record from backend
 	 *
 	 */
-	public function delete () {
+	public function delete ()
+	{
 
 	}
 
@@ -167,7 +186,8 @@ 
 	 * destructor
 	 *
 	 */
-	public function __destruct() {
+	public function __destruct()
+	{
 	}
 
 } // end of egw_addressbook_record

infolog/inc/class.infolog_favorite_portlet.inc.php

Spacing +22 added lines, -22 removed lines

@@ -32,7 +32,7 @@ 
 		$context['appname'] = 'infolog';
 
 		// Let parent handle the basic stuff
-		parent::__construct($context,$need_reload);
+		parent::__construct($context, $need_reload);
 
 		$ui = new infolog_ui();
 
@@ -73,7 +73,7 @@ 
 			if ($tpl->read('infolog.index.rows.'.$query['col_filter']['info_type']))
 			{
 				$query['template'] = $tpl->name;
-				$query['custom_fields'] = true;	// read the custom fields too
+				$query['custom_fields'] = true; // read the custom fields too
 			}
 		}
 		$ui = new infolog_ui();
@@ -105,27 +105,27 @@ 
 				// Some processing to add values in for links and cats
 				$multi_action = $values['nm']['multi_action'];
 				// Action has an additional action - add / delete, etc.  Buttons named <multi-action>_action[action_name]
-				if(in_array($multi_action, array('link', 'responsible')))
+				if (in_array($multi_action, array('link', 'responsible')))
 				{
 					// eTemplate ignores the _popup namespace, but et2 doesn't
-					if($values[$multi_action.'_popup'])
+					if ($values[$multi_action.'_popup'])
 					{
-						$popup =& $values[$multi_action.'_popup'];
+						$popup = & $values[$multi_action.'_popup'];
 					}
 					else
 					{
-						$popup =& $values;
+						$popup = & $values;
 					}
-					$values['nm']['multi_action'] .= '_' . key($popup[$multi_action . '_action']);
-					if($multi_action == 'link')
+					$values['nm']['multi_action'] .= '_'.key($popup[$multi_action.'_action']);
+					if ($multi_action == 'link')
 					{
-						$popup[$multi_action] = $popup['link']['app'] . ':'.$popup['link']['id'];
+						$popup[$multi_action] = $popup['link']['app'].':'.$popup['link']['id'];
 					}
-					else if(is_array($popup[$multi_action]))
+					else if (is_array($popup[$multi_action]))
 					{
-						$popup[$multi_action] = implode(',',$popup[$multi_action]);
+						$popup[$multi_action] = implode(',', $popup[$multi_action]);
 					}
-					$values['nm']['multi_action'] .= '_' . $popup[$multi_action];
+					$values['nm']['multi_action'] .= '_'.$popup[$multi_action];
 					unset($values[$multi_action.'_popup']);
 					unset($values[$multi_action]);
 				}
@@ -133,24 +133,24 @@ 
 				if ($ui->action($values['nm']['multi_action'], $values['nm']['selected'], $values['nm']['select_all'],
 					$success, $failed, $action_msg, $values['nm'], $msg, $values['nm']['checkboxes']['no_notifications']))
 				{
-					$msg .= lang('%1 entries %2',$success,$action_msg);
-					Api\Json\Response::get()->apply('egw.message',array($msg,'success'));
-					foreach($values['nm']['selected'] as &$id)
+					$msg .= lang('%1 entries %2', $success, $action_msg);
+					Api\Json\Response::get()->apply('egw.message', array($msg, 'success'));
+					foreach ($values['nm']['selected'] as &$id)
 					{
 						$id = 'infolog::'.$id;
 					}
 					// Directly request an update - this will get infolog tab too
-					Api\Json\Response::get()->apply('egw.dataRefreshUIDs',array($values['nm']['selected']));
+					Api\Json\Response::get()->apply('egw.dataRefreshUIDs', array($values['nm']['selected']));
 				}
-				elseif(is_null($msg))
+				elseif (is_null($msg))
 				{
-					$msg .= lang('%1 entries %2, %3 failed because of insufficent rights !!!',$success,$action_msg,$failed);
-					Api\Json\Response::get()->apply('egw.message',array($msg,'error'));
+					$msg .= lang('%1 entries %2, %3 failed because of insufficent rights !!!', $success, $action_msg, $failed);
+					Api\Json\Response::get()->apply('egw.message', array($msg, 'error'));
 				}
-				elseif($msg)
+				elseif ($msg)
 				{
-					$msg .= "\n".lang('%1 entries %2, %3 failed.',$success,$action_msg,$failed);
-					Api\Json\Response::get()->apply('egw.message',array($msg,'error'));
+					$msg .= "\n".lang('%1 entries %2, %3 failed.', $success, $action_msg, $failed);
+					Api\Json\Response::get()->apply('egw.message', array($msg, 'error'));
 				}
 				unset($values['nm']['multi_action']);
 				unset($values['nm']['select_all']);

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -27,7 +27,7 @@
 	 * Construct the portlet
 	 *
 	 */
-	public function __construct(Array &$context = array(), &$need_reload = false)
+	public function __construct(array &$context = array(), &$need_reload = false)
 	{
 		$context['appname'] = 'infolog';
 

infolog/inc/class.infolog_wizard_export_csv.inc.php

Spacing +2 added lines, -2 removed lines

@@ -21,13 +21,13 @@
 		$bo = new infolog_tracking(new infolog_bo());
 		$this->export_fields = array('info_id' => 'Infolog ID', 'pm_id' => 'Project ID', 'project' => 'Project Name') + $bo->field2label;
 		// Add in created date, in the appropriate place
-		$first = array_splice($this->export_fields, 0, array_search('info_datemodified',array_keys($this->export_fields)));
+		$first = array_splice($this->export_fields, 0, array_search('info_datemodified', array_keys($this->export_fields)));
 		$this->export_fields = array_merge($first, array('info_created'=>'creation'), $this->export_fields);
 
 		// Custom fields
 		unset($this->export_fields['custom']); // Heading, not a real field
 		$custom = Api\Storage\Customfields::get('infolog', true);
-		foreach($custom as $name => $data) {
+		foreach ($custom as $name => $data) {
 			$this->export_fields['#'.$name] = $data['label'];
 		}
 	}

Braces +4 added lines, -2 removed lines

@@ -14,7 +14,8 @@ 
 
 class infolog_wizard_export_csv extends importexport_wizard_basic_export_csv
 {
-	public function __construct() {
+	public function __construct()
+	{
 		parent::__construct();
 
 		// Field mapping
@@ -27,7 +28,8 @@ 
 		// Custom fields
 		unset($this->export_fields['custom']); // Heading, not a real field
 		$custom = Api\Storage\Customfields::get('infolog', true);
-		foreach($custom as $name => $data) {
+		foreach($custom as $name => $data)
+		{
 			$this->export_fields['#'.$name] = $data['label'];
 		}
 	}

infolog/inc/class.infolog_export_ical.inc.php

Indentation +3 added lines, -3 removed lines

@@ -109,8 +109,8 @@
 	 */
 	public function get_selectors_etpl() {
 		return array(
-                        'name'  => 'infolog.export_csv_selectors',
-                        'content'       => 'search'
-                );
+						'name'  => 'infolog.export_csv_selectors',
+						'content'       => 'search'
+				);
 	}
 }

Spacing +4 added lines, -4 removed lines

@@ -23,7 +23,7 @@ 
 	 *
 	 * @param egw_record $_definition
 	 */
-	public function export( $_stream, importexport_definition $_definition) {
+	public function export($_stream, importexport_definition $_definition) {
 		$options = $_definition->plugin_options;
 		$this->bo = new infolog_bo();
 
@@ -32,7 +32,7 @@ 
 
 		$ids = array();
 		$query = array();
-		switch($options['selection'])
+		switch ($options['selection'])
 		{
 			case 'search':
 				$query = array_merge(Api\Cache::getSession('infolog', 'session_data'), $query);
@@ -44,7 +44,7 @@ 
 
 				break;
 			default:
-				$ids = $this->selection = explode(',',$options['selection']);
+				$ids = $this->selection = explode(',', $options['selection']);
 				break;
 		}
 
@@ -89,7 +89,7 @@ 
 	 */
 	public function get_filename()
 	{
-		if(is_array($this->selection) && count($this->selection) == 1)
+		if (is_array($this->selection) && count($this->selection) == 1)
 		{
 			return $this->bo->link_title(current($this->selection));
 		}

Braces +18 added lines, -8 removed lines

@@ -16,19 +16,24 @@ 
 /**
  * export iCal plugin of infolog
  */
-class infolog_export_ical extends infolog_export_csv {
+class infolog_export_ical extends infolog_export_csv
+{
 
 	/**
 	 * Exports records as defined in $_definition
 	 *
 	 * @param egw_record $_definition
 	 */
-	public function export( $_stream, importexport_definition $_definition) {
+	public function export( $_stream, importexport_definition $_definition)
+	{
 		$options = $_definition->plugin_options;
 		$this->bo = new infolog_bo();
 
 		$limit_exception = Api\Storage\Merge::is_export_limit_excepted();
-		if (!$limit_exception) $export_limit = Api\Storage\Merge::getExportLimit('infolog');
+		if (!$limit_exception)
+		{
+			$export_limit = Api\Storage\Merge::getExportLimit('infolog');
+		}
 
 		$ids = array();
 		$query = array();
@@ -57,7 +62,8 @@ 
 	 *
 	 * @return string name
 	 */
-	public static function get_name() {
+	public static function get_name()
+	{
 		return lang('Infolog iCal export');
 	}
 
@@ -66,7 +72,8 @@ 
 	 *
 	 * @return string descriprion
 	 */
-	public static function get_description() {
+	public static function get_description()
+	{
 		return lang("Exports in iCal format.");
 	}
 
@@ -75,11 +82,13 @@ 
 	 *
 	 * @return string suffix
 	 */
-	public static function get_filesuffix() {
+	public static function get_filesuffix()
+	{
 		return 'ics';
 	}
 
-	public static function get_mimetype() {
+	public static function get_mimetype()
+	{
 		return 'text/infolog';
 	}
 
@@ -118,7 +127,8 @@ 
 	 * returns selectors of this plugin
 	 *
 	 */
-	public function get_selectors_etpl() {
+	public function get_selectors_etpl()
+	{
 		return array(
                         'name'  => 'infolog.export_csv_selectors',
                         'content'       => 'search'

Doc Comments +2 added lines, -2 removed lines

@@ -27,7 +27,7 @@ 
 	/**
 	 * Exports records as defined in $_definition
 	 *
-	 * @param egw_record $_definition
+	 * @param importexport_definition $_definition
 	 */
 	public function export( $_stream, importexport_definition $_definition) {
 		$options = $_definition->plugin_options;
@@ -228,7 +228,7 @@ 
 	 *
 	 * @param $definition Specific definition
 	 *
-	 * @return array (
+	 * @return boolean (
 	 * 		name 		=> string,
 	 * 		content		=> array,
 	 * 		sel_options	=> array,

infolog/inc/class.infolog_ui.inc.php

Indentation +1 added lines, -1 removed lines

@@ -225,7 +225,7 @@
 
 				if ($show_links != 'none' && $show_links != 'no_describtion' &&
 					$link['link_id'] != $info['info_link_id'] &&
-				    ($link['app'] != $action || $link['id'] != $action_id) &&
+					($link['app'] != $action || $link['id'] != $action_id) &&
 					($show_links == 'all' || ($show_links == 'links') === ($link['app'] != Link::VFS_APPNAME)))
 				{
 					$info['filelinks'][] = $link;

Doc Comments +9 added lines, -12 removed lines

@@ -295,6 +295,8 @@ 
 	 * @param array &$query
 	 * @param array &$rows
 	 * @param array &$readonlys
+	 * @param type|null $rows
+	 * @param type|null $readonlys
 	 * @return int
 	 */
 	function get_rows(&$query,&$rows,&$readonlys)
@@ -575,7 +577,6 @@ 
 	 * Hook for timesheet to set some extra data and links
 	 *
 	 * @param array $data
-	 * @param int $data[id] info_id
 	 * @return array with key => value pairs to set in new timesheet and link_app/link_id arrays
 	 */
 	function timesheet_set($data)
@@ -601,7 +602,6 @@ 
 	 * Hook for calendar to set some extra data and links
 	 *
 	 * @param array $data event-array preset by calendar plus
-	 * @param int $data[entry_id] info_id
 	 * @return array with key => value pairs to set in new event and link_app/link_id arrays
 	 */
 	function calendar_set($data)
@@ -691,9 +691,6 @@ 
 	 * Since the hook has no idea about infolog or preferences, we add the user's
 	 * current sorting for infolog here so they're in the expected order
 	 *
-	 * @param int $args[year], $args[month], $args[day] date of the events
-	 * @param int $args[owner] owner of the events
-	 * @param string $args[location] calendar_include_{events|todos}
 	 * @return array of events (array with keys starttime, endtime, title, view, icon, content)
 	 */
 	public function cal_to_include($args)
@@ -711,11 +708,11 @@ 
 	/**
 	 * Shows the infolog list
 	 *
-	 * @param array/string $values etemplate content or 'reset_action_view' if called by index.php to reset an action-view
+	 * @param integer $values etemplate content or 'reset_action_view' if called by index.php to reset an action-view
 	 * @param string $action if set only entries liked to that $action:$action_id are shown
 	 * @param string $action_id if set only entries liked to that $action:$action_id are shown
-	 * @param mixed $called_as is how we got called, for a hook eg. the call-params of that page containing the hook
-	 * @param boolean $e$extra_app_header * @param boolean $return_html=false
+	 * @param integer $called_as is how we got called, for a hook eg. the call-params of that page containing the hook
+	 * @param boolean $extra_app_header * @param boolean $return_html
 	 * @param string $own_referer='' this is our own referer
 	 * @param string $action_title='' app_header for the action, if '' we try the link-title
 	 */
@@ -1327,7 +1324,7 @@ 
 	 * @param array $query get_rows parameter
 	 * @param string &$msg on return user feedback
 	 * @param boolean $skip_notifications true to NOT notify users about changes
-	 * @return boolean true if all actions succeded, false otherwise
+	 * @return boolean|null true if all actions succeded, false otherwise
 	 */
 	function action($_action, $checked, $use_all, &$success, &$failed, &$action_msg,
 		array $query, &$msg, $skip_notifications = false)
@@ -1572,9 +1569,9 @@ 
 	/**
 	 * Closes an infolog
 	 *
-	 * @param int|array $values=0 info_id (default _GET[info_id])
+	 * @param int|array $values info_id (default _GET[info_id])
 	 * @param string $_referer=''
-	 * @param boolean $closesingle=false
+	 * @param boolean $closesingle
 	 */
 	function close($values=0,$_referer='',$closesingle=false,$skip_notification = false)
 	{
@@ -1622,7 +1619,7 @@ 
 	/**
 	 * Deletes an InfoLog entry
 	 *
-	 * @param array|int $values info_id (default _GET[info_id])
+	 * @param integer $values info_id (default _GET[info_id])
 	 * @param string $_referer
 	 * @param string $called_by
 	 * @param boolean $skip_notification Do not send notification of deletion

Spacing +337 added lines, -343 removed lines

@@ -55,32 +55,32 @@ 
 	 *
 	 * @var string
 	 */
-	var $duration_format = ',';	// comma is necessary!
+	var $duration_format = ','; // comma is necessary!
 
 	var $icons = array(
 		'type' => array(
-			'task'      => 'task.gif',      'task_alt'      => 'Task',
-			'phone'     => 'phone.gif',     'phone_alt'     => 'Phonecall',
-			'note'      => 'note.gif',      'note_alt'      => 'Note',
-			'confirm'   => 'confirm.gif',   'confirm_alt'   => 'Confirmation',
-			'reject'    => 'reject.gif',    'reject_alt'    => 'Reject',
-			'email'     => 'email.gif',     'email_alt'     => 'Email' ),
+			'task'      => 'task.gif', 'task_alt'      => 'Task',
+			'phone'     => 'phone.gif', 'phone_alt'     => 'Phonecall',
+			'note'      => 'note.gif', 'note_alt'      => 'Note',
+			'confirm'   => 'confirm.gif', 'confirm_alt'   => 'Confirmation',
+			'reject'    => 'reject.gif', 'reject_alt'    => 'Reject',
+			'email'     => 'email.gif', 'email_alt'     => 'Email' ),
 		'action' => array(
-			'new'       => 'new.gif',       'new_alt'       => 'Add Sub',
-			'view'      => 'view.gif',      'view_alt'      => 'View Subs',
-			'parent'    => 'parent.gif',    'parent_alt'    => 'View other Subs',
-			'edit'      => 'edit.gif',      'edit_alt'      => 'Edit',
-			'addfile'   => 'addfile.gif',   'addfile_alt'   => 'Add a file',
-			'delete'    => 'delete.gif',    'delete_alt'    => 'Delete',
-			'close'     => 'done.gif',      'close_alt'     => 'Close' ,
-			'close_all' => 'done_all.gif',  'close_all_alt' => 'Close' ),
+			'new'       => 'new.gif', 'new_alt'       => 'Add Sub',
+			'view'      => 'view.gif', 'view_alt'      => 'View Subs',
+			'parent'    => 'parent.gif', 'parent_alt'    => 'View other Subs',
+			'edit'      => 'edit.gif', 'edit_alt'      => 'Edit',
+			'addfile'   => 'addfile.gif', 'addfile_alt'   => 'Add a file',
+			'delete'    => 'delete.gif', 'delete_alt'    => 'Delete',
+			'close'     => 'done.gif', 'close_alt'     => 'Close',
+			'close_all' => 'done_all.gif', 'close_all_alt' => 'Close' ),
 		'status' => array(
-			'billed'    => 'billed.gif',    'billed_alt'    => 'billed',
-			'done'      => 'done.gif',      'done_alt'      => 'done',
+			'billed'    => 'billed.gif', 'billed_alt'    => 'billed',
+			'done'      => 'done.gif', 'done_alt'      => 'done',
 			'will-call' => 'will-call.gif', 'will-call_alt' => 'will-call',
-			'call'      => 'call.gif',      'call_alt'      => 'call',
-			'ongoing'   => 'ongoing.gif',   'ongoing_alt'   => 'ongoing',
-			'offer'     => 'offer.gif',     'offer_alt'     => 'offer' )
+			'call'      => 'call.gif', 'call_alt'      => 'call',
+			'ongoing'   => 'ongoing.gif', 'ongoing_alt'   => 'ongoing',
+			'offer'     => 'offer.gif', 'offer_alt'     => 'offer' )
 	);
 	var $filters;
 	var $messages = array(
@@ -100,14 +100,14 @@ 
 		if ($GLOBALS['egw_info']['flags']['currentapp'] != 'infolog') Api\Translation::add_app('infolog');
 
 		// Make sure Global category is infolog - on first load, it may not be
-		if($GLOBALS['egw_info']['flags']['currentapp'] == 'infolog' && !$GLOBALS['egw']->categories->app_name)
+		if ($GLOBALS['egw_info']['flags']['currentapp'] == 'infolog' && !$GLOBALS['egw']->categories->app_name)
 		{
 			$GLOBALS['egw']->categories = new Api\Categories();
 		}
 
 		$this->bo = new infolog_bo();
 
-		if($etemplate === null)
+		if ($etemplate === null)
 		{
 			$etemplate = new Etemplate();
 		}
@@ -115,18 +115,18 @@ 
 
 		$this->user = $GLOBALS['egw_info']['user']['account_id'];
 
-		$this->prefs =& $GLOBALS['egw_info']['user']['preferences']['infolog'];
+		$this->prefs = & $GLOBALS['egw_info']['user']['preferences']['infolog'];
 
 		// read the duration format from project-manager
 		if ($GLOBALS['egw_info']['apps']['projectmanager'])
 		{
 			$pm_config = Api\Config::read('projectmanager');
-			$this->duration_format = str_replace(',','',implode('', (array)$pm_config['duration_units']));
+			$this->duration_format = str_replace(',', '', implode('', (array)$pm_config['duration_units']));
 			//error_log(__METHOD__."() ".__LINE__." duration_format=$this->duration_format, duration_unit=".array2string($pm_config['duration_units']));
 			$this->hours_per_workday = $pm_config['hours_per_workday'];
 			unset($pm_config);
 		}
-		$this->filters =& $this->bo->filters;
+		$this->filters = & $this->bo->filters;
 		/* these are just for testing of the notifications
 		for($i = -1; $i <= 3; ++$i)
 		{
@@ -145,7 +145,7 @@ 
 			$this->filters['responsible-open-date'.date('Y-m-d',time()+$i*24*60*60)] = "responsible starting in $i day(s)";
 		}
 		*/
-		$GLOBALS['infolog_ui'] =& $this;	// make ourself availible for ExecMethod of get_rows function
+		$GLOBALS['infolog_ui'] = & $this; // make ourself availible for ExecMethod of get_rows function
 	}
 
 	/**
@@ -159,7 +159,7 @@ 
 	 * @param int $details
 	 * @return array
 	 */
-	function get_info($info,&$readonlys,$action='',$action_id='',$show_links=false,$details = 1)
+	function get_info($info, &$readonlys, $action = '', $action_id = '', $show_links = false, $details = 1)
 	{
 		if (!is_array($info))
 		{
@@ -169,19 +169,19 @@ 
 		$done = $info['info_status'] == 'done' || $info['info_status'] == 'billed' || $info['info_status'] == 'cancelled'; //cancelled is regarded as a completed status as well in bo
 		// regard an infolog as done/billed/cancelled if its percentage is 100% when there is to status like the above for that type
 		if (!$done && !isset($this->bo->status[$info['info_type']]['done']) && !isset($this->bo->status[$info['info_type']]['billed']) &&
-			!isset($this->bo->status[$info['info_type']]['cancelled']) && (int)$info['info_percent']==100) $done = true ;
-		$info['sub_class'] = $this->bo->enums['priority'][$info['info_priority']] . ($done ? '_done' : '');
+			!isset($this->bo->status[$info['info_type']]['cancelled']) && (int)$info['info_percent'] == 100) $done = true;
+		$info['sub_class'] = $this->bo->enums['priority'][$info['info_priority']].($done ? '_done' : '');
 		if (!$done && $info['info_enddate'] < $this->bo->user_time_now)
 		{
 			$info['end_class'] = 'infolog_overdue';
 		}
 		if (!isset($info['info_anz_subs'])) $info['info_anz_subs'] = $this->bo->anzSubs($id);
-		$this->bo->link_id2from($info,$action,$action_id);	// unset from for $action:$action_id
-		$info['info_percent'] = (int) $info['info_percent'].'%';
-		$editrights = $this->bo->check_access($info,Acl::EDIT);
+		$this->bo->link_id2from($info, $action, $action_id); // unset from for $action:$action_id
+		$info['info_percent'] = (int)$info['info_percent'].'%';
+		$editrights = $this->bo->check_access($info, Acl::EDIT);
 		$isresposible = $this->bo->is_responsible($info);
 		if ((!($editrights || // edit rights or more then standard responsible rights
-			$isresposible && array_diff($this->bo->responsible_edit,array('info_status','info_percent','info_datecompleted')))))
+			$isresposible && array_diff($this->bo->responsible_edit, array('info_status', 'info_percent', 'info_datecompleted')))))
 		{
 			$info['class'] .= 'rowNoEdit ';
 		}
@@ -200,11 +200,11 @@ 
 		{
 			$info['class'] .= 'rowNoCloseAll ';
 		}
-		if (!$this->bo->check_access($info,Acl::DELETE))
+		if (!$this->bo->check_access($info, Acl::DELETE))
 		{
 			$info['class'] .= 'rowNoDelete ';
 		}
-		if (!$this->bo->check_access($info,Acl::ADD))
+		if (!$this->bo->check_access($info, Acl::ADD))
 		{
 			$info['class'] .= 'rowNoSubs ';
 		}
@@ -216,7 +216,7 @@ 
 		if (!$show_links) $show_links = $this->prefs['show_links'];
 		if (($show_links != 'none' && $show_links != 'no_describtion' ||
 			 $this->prefs['show_times'] || isset($GLOBALS['egw_info']['user']['apps']['timesheet'])) &&
-			(isset($info['links']) || ($info['links'] = Link::get_links('infolog',$info['info_id'],'','link_lastmod DESC',true,true))))
+			(isset($info['links']) || ($info['links'] = Link::get_links('infolog', $info['info_id'], '', 'link_lastmod DESC', true, true))))
 		{
 			$timesheets = array();
 			foreach ($info['links'] as $link)
@@ -225,7 +225,7 @@ 
 				$link_mod = Api\DateTime::server2user($link['lastmod']);
 				if ($info['row_mod'] < $link_mod) $info['row_mod'] = $link_mod;
 
-				if ($link['deleted']) continue;	// skip deleted links, but incl. them in row_mod!
+				if ($link['deleted']) continue; // skip deleted links, but incl. them in row_mod!
 
 				if ($show_links != 'none' && $show_links != 'no_describtion' &&
 					$link['link_id'] != $info['info_link_id'] &&
@@ -242,7 +242,7 @@ 
 			}
 			if ($this->prefs['show_times'] && isset($GLOBALS['egw_info']['user']['apps']['timesheet']) && $timesheets)
 			{
-				$sum = ExecMethod('timesheet.timesheet_bo.sum',$timesheets);
+				$sum = ExecMethod('timesheet.timesheet_bo.sum', $timesheets);
 				$info['info_sum_timesheets'] = $sum['duration'];
 				// incl. max timesheet modification in row_mod
 				if ($info['row_mod'] < $sum['max_modified']) $info['row_mod'] = $sum['max_modified'];
@@ -260,7 +260,7 @@ 
 			}
 			$readonlys["edit_percent[$id]"] = true;
 		}
-		elseif($readonlys["edit_percent[$id]"])	// show percent, but button is switched off
+		elseif ($readonlys["edit_percent[$id]"])	// show percent, but button is switched off
 		{
 			$info['info_percent2'] = $info['info_percent'];
 		}
@@ -281,7 +281,7 @@ 
 	protected static function filter(array $query)
 	{
 		$filter = $query['filter'] ? 'filter' : ($query['cat_id'] ? 'cat_id' : null);
-		foreach((array)$query['col_filter'] as $name => $value)
+		foreach ((array)$query['col_filter'] as $name => $value)
 		{
 			if ((string)$value !== '')
 			{
@@ -301,7 +301,7 @@ 
 	 * @param array &$readonlys
 	 * @return int
 	 */
-	function get_rows(&$query,&$rows,&$readonlys)
+	function get_rows(&$query, &$rows, &$readonlys)
 	{
 		//error_log(__METHOD__."() query[csv_export]=".array2string($query['csv_export']).", query[filter]=".array2string($query['filter']).", query[col_filter]=".array2string(array_diff($query['col_filter'],array('',0))).' '.function_backtrace());
 		if (!$query['csv_export'])
@@ -318,20 +318,20 @@ 
 			}
 			//error_log(__METHOD__."() prefs[listNoSubs]=".array2string($this->prefs['listNoSubs'])." --> parent_id=$parent_id");
 			unset($query['col_filter']['parent_id']);
-			if(!$query['action'])
+			if (!$query['action'])
 			{
 				Api\Cache::setSession('infolog', $query['session_for'].'session_data',
-					array_diff_key ($query, array_flip(array('rows','actions','action_links','placeholder_actions'))));
+					array_diff_key($query, array_flip(array('rows', 'actions', 'action_links', 'placeholder_actions'))));
 			}
 			$query['actions'] = $this->get_actions($query);
 			$query['row_id'] = 'info_id';
 			$query['row_modified'] = 'row_mod';
 			$query['parent_id'] = 'info_id_parent';
 			$query['is_parent'] = 'info_anz_subs';
-			$query['action_var'] = 'multi_action';	// as 'action' is already used in infolog
+			$query['action_var'] = 'multi_action'; // as 'action' is already used in infolog
 		}
 		// nextmatch opened an infolog containing children --> do not filter them, always show all children
-		elseif($query['csv_export'] === 'children')
+		elseif ($query['csv_export'] === 'children')
 		{
 			$query['filter'] = $query['search'] = $query['cat_id'] = '';
 			$query['col_filter'] = array('info_id_parent' => $query['col_filter']['info_id_parent']);
@@ -351,17 +351,17 @@ 
 			$links['linked'] = array();
 			unset($query['col_filter']['linked']);
 		}
-		if($query['action'] && in_array($query['action'], array_keys($GLOBALS['egw_info']['apps'])) && $query['action_id'])
+		if ($query['action'] && in_array($query['action'], array_keys($GLOBALS['egw_info']['apps'])) && $query['action_id'])
 		{
 			$link_filters['action'] = array('app'=>$query['action'], 'id' => $query['action_id']);
 			$links['action'] = array();
 		}
-		foreach($link_filters as $key => $link)
+		foreach ($link_filters as $key => $link)
 		{
-			if(!is_array($link))
+			if (!is_array($link))
 			{
 				// Legacy string style
-				list($app,$id) = explode(':',$link);
+				list($app, $id) = explode(':', $link);
 			}
 			else
 			{
@@ -369,25 +369,25 @@ 
 				$app = $link['app'];
 				$id = $link['id'];
 			}
-			if(!is_array($id)) $id = explode(',',$id);
-			if (!($linked = Link::get_links_multiple($app,$id,true,'infolog','',$query['col_filter']['info_status'] == 'deleted')))
+			if (!is_array($id)) $id = explode(',', $id);
+			if (!($linked = Link::get_links_multiple($app, $id, true, 'infolog', '', $query['col_filter']['info_status'] == 'deleted')))
 			{
-				$rows = array();	// no infologs linked to selected link --> no rows to return
+				$rows = array(); // no infologs linked to selected link --> no rows to return
 				return 0;
 			}
 
 
-			foreach($linked as $infos)
+			foreach ($linked as $infos)
 			{
-				$links[$key] = array_merge($links[$key],$infos);
+				$links[$key] = array_merge($links[$key], $infos);
 			}
 			$links[$key] = array_unique($links[$key]);
-			if($key == 'linked')
+			if ($key == 'linked')
 			{
 				$linked = array('app' => $app, 'id' => $id, 'title' => (count($id) == 1 ? Link::title($app, $id) : lang('multiple')));
 			}
 		}
-		if(count($links))
+		if (count($links))
 		{
 			$query['col_filter']['info_id'] = count($links) > 1 ? call_user_func_array('array_intersect', $links) : $links[$key];
 		}
@@ -396,7 +396,7 @@ 
 		$old_template = $query['template'];
 
 		// Reset custom, type-specific template if type was cleared (without changing it for home)
-		if(!$query['template'] || stripos($query['template'], 'infolog.index.rows') === 0)
+		if (!$query['template'] || stripos($query['template'], 'infolog.index.rows') === 0)
 		{
 			$query['template'] = 'infolog.index.rows';
 		}
@@ -407,10 +407,10 @@ 
 			if ($tpl->read('infolog.index.rows.'.$query['col_filter']['info_type']))
 			{
 				$query['template'] = $tpl->name;
-				$query['custom_fields'] = true;	// read the custom fields too
+				$query['custom_fields'] = true; // read the custom fields too
 			}
 			// If status is not valid for selected type, clear status filter
-			if($query['col_filter']['info_status'] && $query['col_filter']['info_status'] != 'deleted' &&
+			if ($query['col_filter']['info_status'] && $query['col_filter']['info_status'] != 'deleted' &&
 				!in_array($query['col_filter']['info_status'], array_keys($this->bo->status[$query['col_filter']['info_type']])))
 			{
 				$query['col_filter']['info_status'] = '';
@@ -418,7 +418,7 @@ 
 			}
 		}
 		// Framework\Template change forces the UI to do a full update first, no point in getting rows right now
-		if($old_template && $old_template != $query['template']) return 0;
+		if ($old_template && $old_template != $query['template']) return 0;
 
 		// do we need to read the custom fields, depends on the column is enabled and customfields exist, prefs are filter specific
 		// so we have to check that as well
@@ -431,14 +431,14 @@ 
 
 		if (!$query['selectcols'] && $columselection)
 		{
-			$columselection = is_array($columselection) ? $columselection : explode(',',$columselection);
+			$columselection = is_array($columselection) ? $columselection : explode(',', $columselection);
 		}
 		else
 		{
-			$columselection = $query['selectcols'] ? (is_array($query['selectcols']) ? $query['selectcols'] : explode(',',$query['selectcols'])) : array();
+			$columselection = $query['selectcols'] ? (is_array($query['selectcols']) ? $query['selectcols'] : explode(',', $query['selectcols'])) : array();
 		}
 		// do we need to query the cf's
-		$query['custom_fields'] = $this->bo->customfields && (!$columselection || in_array('customfields',$columselection));
+		$query['custom_fields'] = $this->bo->customfields && (!$columselection || in_array('customfields', $columselection));
 
 		$infos = $this->bo->search($query);
 		$query['col_filter'] = $orginal_colfilter;
@@ -456,12 +456,12 @@ 
 			$query['default_cols'] = '!cat_id,info_datemodified,info_used_time_info_planned_time,info_used_time_info_planned_time_info_replanned_time,info_id';
 		}
 		// set old show_times pref, that get_info calculates the cumulated time of the timesheets (we only check used&planned to work for both time cols)
-		$this->prefs['show_times'] = strpos($this->prefs[$query['columnselection_pref']],'info_used_time_info_planned_time') !== false;
+		$this->prefs['show_times'] = strpos($this->prefs[$query['columnselection_pref']], 'info_used_time_info_planned_time') !== false;
 
 		// query all links and sub counts in one go
 		if ($infos && (!$query['csv_export'] || !is_array($query['csv_export'])))
 		{
-			$links = Link::get_links_multiple('infolog',array_keys($infos),true,'','link_lastmod DESC',true);	// true=incl. deleted
+			$links = Link::get_links_multiple('infolog', array_keys($infos), true, '', 'link_lastmod DESC', true); // true=incl. deleted
 			$anzSubs = $this->bo->anzSubs(array_keys($infos));
 		}
 		$rows = array();
@@ -472,26 +472,26 @@ 
 			$parents = $query['action'] == 'sp' && $query['action_id'] ? (array)$query['action_id'] : array();
 			if (!empty($parents) && count($parents) == 1 && is_array($query['action_id']))
 			{
-				$query['action_id'] = array_shift($query['action_id']);	// display single parent as app_header
+				$query['action_id'] = array_shift($query['action_id']); // display single parent as app_header
 			}
 		}
 
 		$parent_first = !empty($parents) && count($parents) == 1;
 		$parent_index = 0;
 		// et2 nextmatch listens to total, and only displays that many rows, so add parent in or we'll lose the last row
-		if($parent_first || $query['action'] == 'sp' && is_array($query['action_id'])) $query['total']++;
+		if ($parent_first || $query['action'] == 'sp' && is_array($query['action_id'])) $query['total']++;
 
 		// Check to see if we need to remove description
-		foreach($infos as $id => $info)
+		foreach ($infos as $id => $info)
 		{
 			if (!$query['csv_export'] || !is_array($query['csv_export']))
 			{
-				$info['links'] =& $links[$id];
+				$info['links'] = & $links[$id];
 				$info['info_anz_subs'] = (int)$anzSubs[$id];
-				$info = $this->get_info($info,$readonlys,null,null,false,$details);
+				$info = $this->get_info($info, $readonlys, null, null, false, $details);
 			}
 			// for subs view ('sp') add parent(s) in front of subs once(!)
-			if ( $parent_first && ($main = $this->bo->read($query['action_id'])) ||
+			if ($parent_first && ($main = $this->bo->read($query['action_id'])) ||
 				$parents && ($parent_index = array_search($info['info_id_parent'], $parents)) !== false &&
 				($main = $this->bo->read($info['info_id_parent'])))
 			{
@@ -501,11 +501,11 @@ 
 				// as read() always read them all, while search() only reads the selected ones
 				if ($query['custom_fields'])
 				{
-					foreach($columselection as $col)
+					foreach ($columselection as $col)
 					{
 						if ($col[0] == '#')
 						{
-							foreach(array_keys($main) as $n)
+							foreach (array_keys($main) as $n)
 							{
 								if ($n[0] == '#' && !in_array($n, $columselection)) unset($main[$n]);
 							}
@@ -514,7 +514,7 @@ 
 					}
 				}
 				$parent_first = false;
-				if($query['start'] == 0)
+				if ($query['start'] == 0)
 				{
 					array_splice($rows, $id, 0, array($main));
 					unset($parents[$parent_index]);
@@ -527,7 +527,7 @@ 
 		if ($query['cat_id']) $rows['no_cat_id'] = true;
 		if ($query['no_actions']) $rows['no_actions'] = true;
 		$rows['no_timesheet'] = !isset($GLOBALS['egw_info']['user']['apps']['timesheet']);
-		if($clear_status_filter)
+		if ($clear_status_filter)
 		{
 			$rows['info_status'] = '';
 		}
@@ -558,7 +558,7 @@ 
 				$headers[] = lang($this->filters[$query['filter']]);
 			}
 			if ($query['action'] && ($title = $query['action_title'] || is_array($query['action_id']) ?
-				$query['action_title'] : Link::title($query['action']=='sp'?'infolog':$query['action'],$query['action_id'])))
+				$query['action_title'] : Link::title($query['action'] == 'sp' ? 'infolog' : $query['action'], $query['action_id'])))
 			{
 				$headers[] = $title;
 			}
@@ -569,7 +569,7 @@ 
 			$GLOBALS['egw_info']['flags']['app_header'] = implode(': ', $headers);
 		}
 
-		if (isset($linked)) $query['col_filter']['linked'] = $linked;  // add linked back to the colfilter
+		if (isset($linked)) $query['col_filter']['linked'] = $linked; // add linked back to the colfilter
 
 		return $query['total'];
 	}
@@ -600,7 +600,7 @@ 
 				$set['ts_unitprice'] = $info['info_price'];
 			}
 
-			foreach(Link::get_links('infolog',$info['info_id'],'','link_lastmod DESC',true) as $link)
+			foreach (Link::get_links('infolog', $info['info_id'], '', 'link_lastmod DESC', true) as $link)
 			{
 				if ($link['app'] != 'timesheet' && $link['app'] != Link::VFS_APPNAME)
 				{
@@ -626,7 +626,7 @@ 
 		{
 			return $data;
 		}
-		$event = array_merge($data,array(
+		$event = array_merge($data, array(
 			'category'	=> $GLOBALS['egw']->categories->check_list(Acl::READ, $infolog['info_cat']),
 			'priority'	=> $infolog['info_priority'] + 1,
 			'public'	=> $infolog['info_access'] != 'private',
@@ -637,7 +637,7 @@ 
 			'end'		=> $infolog['info_enddate'] ? $infolog['info_enddate'] : $infolog['info_datecompleted']
 		));
 		unset($event['entry_id']);
-		if (!$event['end']) $event['end'] = $event['start'] + (int) $GLOBALS['egw_info']['user']['preferences']['calendar']['defaultlength']*60;
+		if (!$event['end']) $event['end'] = $event['start'] + (int)$GLOBALS['egw_info']['user']['preferences']['calendar']['defaultlength'] * 60;
 
 		// Match Api\Categories by name
 		$event['category'] = $GLOBALS['egw']->categories->name2id(Api\Categories::id2name($infolog['info_cat']));
@@ -646,38 +646,38 @@ 
 		$event['owner'] = $user = $GLOBALS['egw_info']['user']['account_id'];
 
 		// add/modify participants according to prefs
-		$prefs = explode(',',$this->prefs['calendar_set'] ? $this->prefs['calendar_set'] : 'responsible,contact,user');
+		$prefs = explode(',', $this->prefs['calendar_set'] ? $this->prefs['calendar_set'] : 'responsible,contact,user');
 
 		// if no default participants (selected calendars) --> remove all
-		if (!in_array('selected',$prefs))
+		if (!in_array('selected', $prefs))
 		{
 			$event['participants'] = $event['participant_types'] = array();
 		}
 		// Add responsible as participant
-		if (in_array('responsible',$prefs))
+		if (in_array('responsible', $prefs))
 		{
-			foreach($infolog['info_responsible'] as $responsible)
+			foreach ($infolog['info_responsible'] as $responsible)
 			{
 				$event['participants'][$responsible] = $event['participant_types']['u'][$responsible] =
-					calendar_so::combine_status($user==$responsible?'A':'U');
+					calendar_so::combine_status($user == $responsible ? 'A' : 'U');
 			}
 		}
 		// Add linked contact as participant
-		if (in_array('contact',$prefs) && $infolog['info_link']['app'] == 'addressbook')
+		if (in_array('contact', $prefs) && $infolog['info_link']['app'] == 'addressbook')
 		{
-			$event['participants'][calendar_so::combine_user('c',$infolog['info_link']['id'])] =
+			$event['participants'][calendar_so::combine_user('c', $infolog['info_link']['id'])] =
 				$event['participant_types']['c'][$infolog['info_link']['id']] = calendar_so::combine_status('U');
 		}
-		if (in_array('owner',$prefs))
+		if (in_array('owner', $prefs))
 		{
 			$event['participants'][$infolog['info_owner']] = $event['participant_types']['u'][$infolog['info_owner']] =
-				calendar_so::combine_status('A',1,'CHAIR');
+				calendar_so::combine_status('A', 1, 'CHAIR');
 		}
 		// Add current user, if set or no other participants, which is not allowed
-		if (in_array('user',$prefs))
+		if (in_array('user', $prefs))
 		{
 			$event['participants'][$user] = $event['participant_types']['u'][$user] =
-				calendar_so::combine_status('A',1,'CHAIR');
+				calendar_so::combine_status('A', 1, 'CHAIR');
 		}
 
 		// Add infolog link to calendar entry
@@ -685,7 +685,7 @@ 
 		$event['link_id'][]  = $infolog['info_link']['id'];
 
 		// Copy infolog's links
-		foreach(Link::get_links('infolog',$infolog['info_id'],'','link_lastmod DESC',true) as $link)
+		foreach (Link::get_links('infolog', $infolog['info_id'], '', 'link_lastmod DESC', true) as $link)
 		{
 			if ($link['app'] != Link::VFS_APPNAME)
 			{
@@ -694,7 +694,7 @@ 
 			}
 		}
 		// Copy same custom fields
-		foreach(array_keys(Api\Storage\Customfields::get('calendar')) as $name)
+		foreach (array_keys(Api\Storage\Customfields::get('calendar')) as $name)
 		{
 			if ($this->bo->customfields[$name]) $event['#'.$name] = $infolog['#'.$name];
 		}
@@ -715,7 +715,7 @@ 
 	public function cal_to_include($args)
 	{
 		$nm = Api\Cache::getSession('infolog', 'session_data');
-		if($nm)
+		if ($nm)
 		{
 			$args['order'] = $nm['order'];
 			$args['sort'] = $nm['sort'];
@@ -735,9 +735,9 @@ 
 	 * @param string $own_referer='' this is our own referer
 	 * @param string $action_title='' app_header for the action, if '' we try the link-title
 	 */
-	function index($values = null,$action='',$action_id='',$called_as=0,$extra_app_header=False,$return_html=False,$own_referer='',$action_title='')
+	function index($values = null, $action = '', $action_id = '', $called_as = 0, $extra_app_header = False, $return_html = False, $own_referer = '', $action_title = '')
 	{
-		unset($extra_app_header);	// not used, but dont want to change signature
+		unset($extra_app_header); // not used, but dont want to change signature
 		if (is_array($values))
 		{
 			$called_as = $values['called_as'];
@@ -746,7 +746,7 @@ 
 		elseif ($own_referer === '')
 		{
 			$own_referer = Api\Header\Referer::get();
-			if (strpos($own_referer,'menuaction=infolog.infolog_ui.edit') !== false)
+			if (strpos($own_referer, 'menuaction=infolog.infolog_ui.edit') !== false)
 			{
 				$own_referer = Api\Cache::getSession('infolog', 'own_session');
 			}
@@ -757,11 +757,11 @@ 
 		}
 
 		// Handle legacy buttons like actions
-		if(is_array($values))
+		if (is_array($values))
 		{
-			foreach(array('document', 'view', 'delete') as $button)
+			foreach (array('document', 'view', 'delete') as $button)
 			{
-				if(isset($values['nm']['rows'][$button]))
+				if (isset($values['nm']['rows'][$button]))
 				{
 					list($id) = @each($values['nm']['rows'][$button]);
 					$values['nm']['multi_action'] = $button;
@@ -781,27 +781,27 @@ 
 				// Some processing to add values in for links and cats
 				$multi_action = $values['nm']['multi_action'];
 				// Action has an additional action - add / delete, etc.  Buttons named <multi-action>_action[action_name]
-				if(in_array($multi_action, array('link', 'responsible', 'startdate', 'enddate')))
+				if (in_array($multi_action, array('link', 'responsible', 'startdate', 'enddate')))
 				{
 					// eTemplate ignores the _popup namespace, but et2 doesn't
-					if($values[$multi_action.'_popup'])
+					if ($values[$multi_action.'_popup'])
 					{
-						$popup =& $values[$multi_action.'_popup'];
+						$popup = & $values[$multi_action.'_popup'];
 					}
 					else
 					{
-						$popup =& $values;
+						$popup = & $values;
 					}
-					$values['nm']['multi_action'] .= '_' . key($popup[$multi_action . '_action']);
-					if($multi_action == 'link')
+					$values['nm']['multi_action'] .= '_'.key($popup[$multi_action.'_action']);
+					if ($multi_action == 'link')
 					{
-						$popup[$multi_action] = $popup['link']['app'] . ':'.$popup['link']['id'];
+						$popup[$multi_action] = $popup['link']['app'].':'.$popup['link']['id'];
 					}
-					else if(is_array($popup[$multi_action]))
+					else if (is_array($popup[$multi_action]))
 					{
-						$popup[$multi_action] = implode(',',$popup[$multi_action]);
+						$popup[$multi_action] = implode(',', $popup[$multi_action]);
 					}
-					$values['nm']['multi_action'] .= '_' . $popup[$multi_action];
+					$values['nm']['multi_action'] .= '_'.$popup[$multi_action];
 					unset($values[$multi_action.'_popup']);
 					unset($values[$multi_action]);
 				}
@@ -809,18 +809,18 @@ 
 				if ($this->action($values['nm']['multi_action'], $values['nm']['selected'], $values['nm']['select_all'],
 					$success, $failed, $action_msg, $values['nm'], $msg, $values['nm']['checkboxes']['no_notifications']))
 				{
-					$msg .= lang('%1 entries %2',$success,$action_msg);
+					$msg .= lang('%1 entries %2', $success, $action_msg);
 					Framework::message($msg);
 				}
-				elseif(is_null($msg))
+				elseif (is_null($msg))
 				{
-					$msg .= lang('%1 entries %2, %3 failed because of insufficent rights !!!',$success,$action_msg,$failed);
-					Framework::message($msg,'error');
+					$msg .= lang('%1 entries %2, %3 failed because of insufficent rights !!!', $success, $action_msg, $failed);
+					Framework::message($msg, 'error');
 				}
-				elseif($msg)
+				elseif ($msg)
 				{
-					$msg .= "\n".lang('%1 entries %2, %3 failed.',$success,$action_msg,$failed);
-					Framework::message($msg,'error');
+					$msg .= "\n".lang('%1 entries %2, %3 failed.', $success, $action_msg, $failed);
+					Framework::message($msg, 'error');
 				}
 				unset($values['nm']['multi_action']);
 				unset($values['nm']['select_all']);
@@ -843,7 +843,7 @@ 
 				$action_id = 0;
 				$action_title = '';
 			}
-			if($_GET['ajax'] === 'true')
+			if ($_GET['ajax'] === 'true')
 			{
 				$nm['action'] = '';
 				$nm['action_id'] = 0;
@@ -859,8 +859,7 @@ 
 
 			if (isset($_GET['filter']) && $_GET['filter'] != 'default' || !isset($values['nm']['filter']) && !$this->called_by)
 			{
-				$values['nm']['filter'] = $_GET['filter'] && $_GET['filter'] != 'default' ? $_GET['filter'] :
-					$this->prefs['defaultFilter'];
+				$values['nm']['filter'] = $_GET['filter'] && $_GET['filter'] != 'default' ? $_GET['filter'] : $this->prefs['defaultFilter'];
 			}
 			if (!isset($values['nm']['order']) || !$values['nm']['order'])
 			{
@@ -874,21 +873,21 @@ 
 			$action_title = $values['action_title'] = $action ? $action_title : $nm['action_title'];
 			$action = $values['action'] = $action ? $action : $nm['action'];
 		}
-		if($_GET['search']) $values['nm']['search'] = $_GET['search'];
+		if ($_GET['search']) $values['nm']['search'] = $_GET['search'];
 
 		if ($values['nm']['add'])
 		{
 			$values['add'] = $values['nm']['add'];
 			unset($values['nm']['add']);
 		}
-		unset($values['nm']['rows']['checked']);	// not longer used, but hides button actions
+		unset($values['nm']['rows']['checked']); // not longer used, but hides button actions
 
 		if ($values['add'] || $values['cancel'] || isset($values['main']))
 		{
 			if ($values['add'])
 			{
 				list($type) = each($values['add']);
-				return $this->edit(0,$action,$action_id,$type,$called_as);
+				return $this->edit(0, $action, $action_id, $type, $called_as);
 			}
 			elseif ($values['cancel'] && $own_referer)
 			{
@@ -900,14 +899,14 @@ 
 			}
 			else
 			{
-				list($do,$do2) = each($values['main']);
+				list($do, $do2) = each($values['main']);
 				list($do_id) = @each($do2);
-				switch((string)$do)
+				switch ((string)$do)
 				{
 					case 'close':
-						$closesingle=true;
+						$closesingle = true;
 					case 'close_all':
-						$this->close($do_id,$called_as,$closesingle);
+						$this->close($do_id, $called_as, $closesingle);
 						break;
 					case 'view':
 						$value = array();
@@ -945,7 +944,7 @@ 
 		$this->tmpl->read('infolog.index');
 		$values['nm']['options-filter'] = $this->filters;
 		$values['nm']['get_rows'] = 'infolog.infolog_ui.get_rows';
-		$values['nm']['options-filter2'] = (in_array($this->prefs['show_links'],array('all','no_describtion')) ? array() : array(
+		$values['nm']['options-filter2'] = (in_array($this->prefs['show_links'], array('all', 'no_describtion')) ? array() : array(
 			''               => 'default',
 		)) + array(
 			'no_describtion' => 'no details',
@@ -966,34 +965,34 @@ 
 		else
 		{
 			// Allow saving parent ID into favorites
-			$values['nm']['favorites'] = array('action','action_id');
+			$values['nm']['favorites'] = array('action', 'action_id');
 		}
 
 		// Allow add actions even when there's no rows
 		$values['nm']['placeholder_actions'] = array('new');
 
-		if(!isset($values['nm']['filter2'])) $values['nm']['filter2'] = $this->prefs['nextmatch-'.($action ? 'infolog.'.$action : 'infolog.index.rows').'-details-pref'];
+		if (!isset($values['nm']['filter2'])) $values['nm']['filter2'] = $this->prefs['nextmatch-'.($action ? 'infolog.'.$action : 'infolog.index.rows').'-details-pref'];
 
 		// disable columns for main entry as set in the pref for details or no details
 		$values['nm']['columnselection_pref'] = 'nextmatch-'.($action ? 'infolog.'.$action : 'infolog.index.rows')
-			.($values['nm']['filter2']=='all' ? '-details' : '');
+			.($values['nm']['filter2'] == 'all' ? '-details' : '');
 		if ($action == 'sp')
 		{
 			$pref = $values['nm']['columnselection_pref'];
-			foreach(array('info_used_time_info_planned_time_info_replanned_time','info_datemodified','info_owner_info_responsible','customfields') as $name)
+			foreach (array('info_used_time_info_planned_time_info_replanned_time', 'info_datemodified', 'info_owner_info_responsible', 'customfields') as $name)
 			{
-				$values['main']['no_'.$name] = strpos($this->prefs[$pref],$name) === false;
+				$values['main']['no_'.$name] = strpos($this->prefs[$pref], $name) === false;
 			}
 			if (!$values['main']['no_customfields'])
 			{
 				// set the column-header of the main table for the customfields.
-				foreach(array_keys($this->bo->customfields) as $lname)
+				foreach (array_keys($this->bo->customfields) as $lname)
 				{
-					$values['main']['customfields'].=$lname."\n";
+					$values['main']['customfields'] .= $lname."\n";
 				}
 			}
 		}
-		if ($values['nm']['filter']=='bydate')
+		if ($values['nm']['filter'] == 'bydate')
 		{
 			foreach (array_keys($values['nm']['col_filter']) as $colfk)
 			{
@@ -1026,7 +1025,7 @@ 
 		{
 			$values['css'] .= '<style type="text/css">@media screen { .infoDes {  '.
 				' max-height: '.
-				(($this->prefs['limit_des_lines'] ? $this->prefs['limit_des_lines'] : 5) * 1.35).	// dono why em is not real lines
+				(($this->prefs['limit_des_lines'] ? $this->prefs['limit_des_lines'] : 5) * 1.35).// dono why em is not real lines
 				'em; overflow: auto; }}</style>';
 		}
 
@@ -1038,13 +1037,13 @@ 
 
 		// remove group-types user has not any rights to as filter
 		// does not take implicit rights as delegated into account, so they will not be available as filters
-		foreach($this->bo->group_owners as $type => $group)
+		foreach ($this->bo->group_owners as $type => $group)
 		{
 			if (!isset($this->bo->grants[$group])) unset($sel_options['info_type'][$type]);
 		}
 
 
-		return $this->tmpl->exec('infolog.infolog_ui.index',$values,$sel_options,$readonlys,$persist,$return_html ? -1 : 0);
+		return $this->tmpl->exec('infolog.infolog_ui.index', $values, $sel_options, $readonlys, $persist, $return_html ? -1 : 0);
 	}
 
 	/**
@@ -1059,9 +1058,9 @@ 
 		if ($this->bo->group_owners)
 		{
 			// remove types owned by groups the user has no edit grant
-			foreach($this->bo->group_owners as $type => $group)
+			foreach ($this->bo->group_owners as $type => $group)
 			{
-				if (!($this->bo->grants[$group] & Acl::EDIT))
+				if (!($this->bo->grants[$group]&Acl::EDIT))
 				{
 					unset($types[$type]);
 				}
@@ -1078,7 +1077,7 @@ 
 	 */
 	private function get_actions(array $query)
 	{
-		for($i = 0; $i <= 100; $i += 10)
+		for ($i = 0; $i <= 100; $i += 10)
 		{
 			$percent[$i] = $i.'%';
 		}
@@ -1087,9 +1086,9 @@ 
 		$types_add = array();
 		// Do not add deleted type to add or change menus
 		unset($types['delete']);
-		foreach($types as $type => &$data)
+		foreach ($types as $type => &$data)
 		{
-			$image_exists = Api\Image::find('infolog',$type);
+			$image_exists = Api\Image::find('infolog', $type);
 			$data = array(
 				'caption' => $data,
 				'icon' => $image_exists ? $type : 'infolog/navbar',
@@ -1101,9 +1100,9 @@ 
 
 		$icons = null;
 		$statis = $this->bo->get_status($query['col_filter']['info_type'], $icons);
-		foreach($statis as $type => &$data)
+		foreach ($statis as $type => &$data)
 		{
-			$image_exists = Api\Image::find('infolog',$icons[$type]);
+			$image_exists = Api\Image::find('infolog', $icons[$type]);
 			$data = array(
 				'caption' => $data,
 				'icon' => $image_exists ? $icons[$type] : 'infolog/status',
@@ -1115,10 +1114,10 @@ 
 				'caption' => 'Open',
 				'default' => true,
 				'allowOnMultiple' => false,
-				'onExecute' => Api\Header\UserAgent::mobile()?'javaScript:app.infolog.viewEntry':'',
+				'onExecute' => Api\Header\UserAgent::mobile() ? 'javaScript:app.infolog.viewEntry' : '',
 				'url' => 'menuaction=infolog.infolog_ui.edit&info_id=$id',
 				'popup' => Link::get_registry('infolog', 'add_popup'),
-				'group' => $group=1,
+				'group' => $group = 1,
 				'mobileViewTemplate' => 'view?'.filemtime(Api\Etemplate\Widget\Template::rel2path('/infolog/templates/mobile/view.xet'))
 			),
 			'parent' => array(
@@ -1192,7 +1191,7 @@ 
 						'icon' => 'completed',
 					),
 					'cat' =>  Etemplate\Widget\Nextmatch::category_action(
-						'infolog',$group,'Change category','cat_'
+						'infolog', $group, 'Change category', 'cat_'
 					),
 					'startdate' => array(
 						'caption' => 'Start date',
@@ -1240,7 +1239,7 @@ 
 				'onExecute' => 'javaScript:app.infolog.infolog_menu_print'
 			)
 		);
-		++$group;	// integration with other apps
+		++$group; // integration with other apps
 		if ($GLOBALS['egw_info']['user']['apps']['filemanager'])
 		{
 			$actions['filemanager'] = array(
@@ -1258,7 +1257,7 @@ 
 				'caption' => 'Schedule appointment',
 				'group' => $group,
 				'url' => 'menuaction=calendar.calendar_uiforms.edit&'.
-					Link::get_registry('calendar', 'add_app') . '[]=infolog&'.Link::get_registry('calendar','add_id').'[]=$id',
+					Link::get_registry('calendar', 'add_app').'[]=infolog&'.Link::get_registry('calendar', 'add_id').'[]=$id',
 				'allowOnMultiple' => false,
 				'popup' => Link::get_registry('calendar', 'add_popup'),
 			);
@@ -1296,7 +1295,7 @@ 
 				'hint' => 'Convert to a ticket',
 				'group' => $group,
 				'url' => 'menuaction=tracker.tracker_ui.edit&'.
-					Link::get_registry('tracker', 'add_app') . '[]=infolog&'.Link::get_registry('tracker','add_id').'[]=$id',
+					Link::get_registry('tracker', 'add_app').'[]=infolog&'.Link::get_registry('tracker', 'add_id').'[]=$id',
 				'allowOnMultiple' => false,
 				'popup' => Link::get_registry('tracker', 'add_popup'),
 			);
@@ -1309,7 +1308,7 @@ 
 		$actions['ical'] = array(
 			'icon' => 'ical',
 			'caption' => 'Export iCal',
-			'postSubmit' => true,	// download needs post submit to work
+			'postSubmit' => true, // download needs post submit to work
 			'group' => $group,
 			'allowOnMultiple' => true,
 			'hideOnMobile' => true
@@ -1362,14 +1361,14 @@ 
 		$success = $failed = 0;
 		if ($use_all)
 		{
-			@set_time_limit(0);                     // switch off the execution time limit, as it's for big selections to small
-			$query['num_rows'] = -1;        // all
+			@set_time_limit(0); // switch off the execution time limit, as it's for big selections to small
+			$query['num_rows'] = -1; // all
 			$result = $readonlys = null;
-			$this->get_rows($query,$result,$readonlys);
+			$this->get_rows($query, $result, $readonlys);
 			$checked = array();
-			foreach($result as $key => $info)
+			foreach ($result as $key => $info)
 			{
-				if(is_numeric($key))
+				if (is_numeric($key))
 				{
 					$checked[] = $info['info_id'];
 				}
@@ -1380,29 +1379,29 @@ 
 		list($action, $settings) = explode('_', $_action, 2);
 
 		// Actions that can handle a list of IDs
-		switch($action)
+		switch ($action)
 		{
 			case 'link':
 				list($add_remove, $link) = explode('_', $settings, 2);
-				list($app, $link_id) = explode(strpos($link,':') !== false ? ':' : ',', $link);
-				if(!$link_id)
+				list($app, $link_id) = explode(strpos($link, ':') !== false ? ':' : ',', $link);
+				if (!$link_id)
 				{
 					$action_msg = 'linked';
 					$msg = lang('You need to select an entry for linking.');
 					break;
 				}
 				$title = Link::title($app, $link_id);
-				foreach($checked as $id)
+				foreach ($checked as $id)
 				{
-					if(!$this->bo->check_access($id, Acl::EDIT))
+					if (!$this->bo->check_access($id, Acl::EDIT))
 					{
 						$failed++;
 						continue;
 					}
-					if($add_remove == 'add')
+					if ($add_remove == 'add')
 					{
 						$action_msg = lang('linked to %1', $title);
-						if(Link::link('infolog', $id, $app, $link_id))
+						if (Link::link('infolog', $id, $app, $link_id))
 						{
 							$success++;
 						}
@@ -1429,20 +1428,20 @@ 
 			case 'ical':
 				// infolog_ical lets horde be auto-loaded, so it must go first
 				$boical = new infolog_ical();
-				Api\Header\Content::type('todo.ics','text/calendar');
+				Api\Header\Content::type('todo.ics', 'text/calendar');
 				echo $boical->exportvCalendar($checked);
 				exit();
 
 		}
 
 		// Actions that need to loop
-		foreach($checked as $id)
+		foreach ($checked as $id)
 		{
-			if(!$entry = $this->bo->read($id))
+			if (!$entry = $this->bo->read($id))
 			{
 				continue;
 			}
-			switch($action)
+			switch ($action)
 			{
 				case 'close':
 					$action_msg = lang('closed');
@@ -1452,8 +1451,8 @@ 
 
 				case 'delete':
 					$action_msg = $settings == 'sub' ? lang(' (and children) deleted') : lang('deleted');
-					$result = $this->bo->delete($id, $settings=='sub', false, $skip_notifications);
-					if($result == true)
+					$result = $this->bo->delete($id, $settings == 'sub', false, $skip_notifications);
+					if ($result == true)
 					{
 						$success++;
 					}
@@ -1466,14 +1465,14 @@ 
 				case 'type':
 					$action_msg = lang('changed type');
 					// Dont allow to change the type, if user has no delete rights from the group-owner
-					if ($id && !($this->bo->grants[$entry['info_owner']] & Acl::DELETE))
+					if ($id && !($this->bo->grants[$entry['info_owner']]&Acl::DELETE))
 					{
 						$failed++;
 						break;
 					}
 					$entry['info_type'] = $settings;
 					try {
-						$this->bo->write($entry, true,true,true,$skip_notifications,true); // Throw exceptions
+						$this->bo->write($entry, true, true, true, $skip_notifications, true); // Throw exceptions
 					}
 					catch (Api\Exception\WrongUserinput $e)
 					{
@@ -1488,11 +1487,11 @@ 
 					$action_msg = lang('changed completion to %1%', $settings);
 					$entry['info_percent'] = $settings;
 					// Done and not-started entries will get changed right back if we don't change the status too
-					if(in_array($entry['info_status'],array('not-started','done','billed','cancelled','archive')))
+					if (in_array($entry['info_status'], array('not-started', 'done', 'billed', 'cancelled', 'archive')))
 					{
 						$entry['info_status'] = 'ongoing';
 					}
-					if($entry['info_percent'] == 0)
+					if ($entry['info_percent'] == 0)
 					{
 						$entry['info_status'] = 'not-started';
 					}
@@ -1500,7 +1499,7 @@ 
 					{
 						$entry['info_status'] = 'done';
 					}
-					if($this->bo->write($entry, true,true,true,$skip_notifications))
+					if ($this->bo->write($entry, true, true, true, $skip_notifications))
 					{
 						$success++;
 					}
@@ -1512,24 +1511,23 @@ 
 
 				case 'undelete':	// set it to valid status != 'deleted' for that type
 					$settings = isset($this->bo->status[$entry['info_type']]['done']) ?
-						$this->bo->status[$entry['info_type']]['done'] :
-						$this->bo->status['defaults'][$entry['info_type']];
+						$this->bo->status[$entry['info_type']]['done'] : $this->bo->status['defaults'][$entry['info_type']];
 					// fall-through
 				case 'status':
-					if(isset($this->bo->status[$entry['info_type']][$settings]))
+					if (isset($this->bo->status[$entry['info_type']][$settings]))
 					{
 						$action_msg = lang('changed status to %1', lang($this->bo->status[$entry['info_type']][$settings]));
-						if(!in_array($settings,array('done','billed','cancelled','archive')) && $entry['info_percent'] == 100)
+						if (!in_array($settings, array('done', 'billed', 'cancelled', 'archive')) && $entry['info_percent'] == 100)
 						{
 							// Done entries will get changed right back if we don't change the completion too
 							$entry['info_percent'] = 10;
 						}
-						if(in_array($settings, array('not-started')) && $entry['info_percent'] > 0)
+						if (in_array($settings, array('not-started')) && $entry['info_percent'] > 0)
 						{
 							$entry['info_percent'] = 0;
 						}
 						$entry['info_status'] = $settings;
-						if($this->bo->write($entry, true,true,true,$skip_notifications))
+						if ($this->bo->write($entry, true, true, true, $skip_notifications))
 						{
 							$success++;
 						}
@@ -1542,7 +1540,7 @@ 
 					break;
 
 				case 'cat':
-					if($settings)
+					if ($settings)
 					{
 						$cat_name = Api\Categories::id2name($settings);
 						$action_msg = lang('changed category to %1', $cat_name);
@@ -1552,7 +1550,7 @@ 
 						$action_msg = lang('removed category');
 					}
 					$entry['info_cat'] = $settings;
-					if($this->bo->write($entry, true,true,true,$skip_notifications))
+					if ($this->bo->write($entry, true, true, true, $skip_notifications))
 					{
 						$success++;
 					}
@@ -1564,15 +1562,15 @@ 
 
 				case 'responsible':
 					list($add_remove, $user_str) = explode('_', $settings, 2);
-					$action_msg = ($add_remove == 'ok' ? lang('changed') : ($add_remove == 'add' ? lang('added') : lang('removed'))) . ' ';
+					$action_msg = ($add_remove == 'ok' ? lang('changed') : ($add_remove == 'add' ? lang('added') : lang('removed'))).' ';
 					$names = array();
 					$users = explode(',', $user_str);
-					foreach($users as $account_id)
+					foreach ($users as $account_id)
 					{
 						$names[] = Api\Accounts::username($account_id);
 					}
 					$action_msg .= implode(', ', $names);
-					if($add_remove == 'ok')
+					if ($add_remove == 'ok')
 					{
 						$entry['info_responsible'] = (array)$users;
 					}
@@ -1581,7 +1579,7 @@ 
 						$function = $add_remove == 'add' ? 'array_merge' : 'array_diff';
 						$entry['info_responsible'] = array_unique($function($entry['info_responsible'], (array)$users));
 					}
-					if($this->bo->write($entry, true,true,true,$skip_notifications))
+					if ($this->bo->write($entry, true, true, true, $skip_notifications))
 					{
 						$success++;
 					}
@@ -1596,7 +1594,7 @@ 
 					list($ok, $date) = explode('_', $settings, 2);
 					$entry[$field] = $date ? Api\DateTime::to($date, 'ts') : null;
 					$action_msg = lang('changed');
-					if($this->bo->write($entry, true,true,true,$skip_notifications))
+					if ($this->bo->write($entry, true, true, true, $skip_notifications))
 					{
 						$success++;
 					}
@@ -1617,10 +1615,10 @@ 
 	 * @param string $_referer=''
 	 * @param boolean $closesingle=false
 	 */
-	function close($values=0,$_referer='',$closesingle=false,$skip_notification = false)
+	function close($values = 0, $_referer = '', $closesingle = false, $skip_notification = false)
 	{
 		//echo "<p>".__METHOD__."($values,$referer,$closeall)</p>\n";
-		$info_id = (int) (is_array($values) ? $values['info_id'] : ($values ? $values : $_GET['info_id']));
+		$info_id = (int)(is_array($values) ? $values['info_id'] : ($values ? $values : $_GET['info_id']));
 		$referer = is_array($values) ? $values['referer'] : $_referer;
 
 		if ($info_id)
@@ -1630,11 +1628,11 @@ 
 			$status = $info['info_status'];
 			// closed stati assumed array('done','billed','cancelled')
 			if (isset($this->bo->status[$info['info_type']]['done'])) {
-				$status ='done';
+				$status = 'done';
 			} elseif (isset($this->bo->status[$info['info_type']]['billed'])) {
-				$status ='billed';
+				$status = 'billed';
 			} elseif (isset($this->bo->status[$info['info_type']]['cancelled'])) {
-				$status ='cancelled';
+				$status = 'cancelled';
 			}
 			#_debug_array($status);
 			$values = array(
@@ -1644,15 +1642,15 @@ 
 				'info_percent'=> 100,
 				'info_datecompleted' => $this->bo->now_su,
 			);
-			$this->bo->write($values, true,true,true,$skip_notification);
+			$this->bo->write($values, true, true, true, $skip_notification);
 
-			$query = array('action'=>'sp','action_id'=>$info_id);
+			$query = array('action'=>'sp', 'action_id'=>$info_id);
 			if (!$closesingle) {
-				foreach((array)$this->bo->search($query) as $info)
+				foreach ((array)$this->bo->search($query) as $info)
 				{
 					if ($info['info_id_parent'] == $info_id)	// search also returns linked entries!
 					{
-						$this->close($info['info_id'],$referer,$closesingle,$skip_notification);	// we call ourselfs recursive to process subs from subs too
+						$this->close($info['info_id'], $referer, $closesingle, $skip_notification); // we call ourselfs recursive to process subs from subs too
 					}
 				}
 			}
@@ -1668,9 +1666,9 @@ 
 	 * @param string $called_by
 	 * @param boolean $skip_notification Do not send notification of deletion
 	 */
-	function delete($values=0,$_referer='',$called_by='',$skip_notification=False)
+	function delete($values = 0, $_referer = '', $called_by = '', $skip_notification = False)
 	{
-		$info_id = (int) (is_array($values) ? $values['info_id'] : ($values ? $values : $_GET['info_id']));
+		$info_id = (int)(is_array($values) ? $values['info_id'] : ($values ? $values : $_GET['info_id']));
 		$referer = is_array($values) ? $values['referer'] : $_referer;
 
 		if (!is_array($values) && $info_id > 0 && !$this->bo->anzSubs($info_id))	// entries without subs get confirmed by javascript
@@ -1681,9 +1679,9 @@ 
 
 		if (is_array($values) || $info_id <= 0)
 		{
-			if (($values['delete'] || $values['delete_subs']) && $info_id > 0 && $this->bo->check_access($info_id,Acl::DELETE))
+			if (($values['delete'] || $values['delete_subs']) && $info_id > 0 && $this->bo->check_access($info_id, Acl::DELETE))
 			{
-				$deleted = $this->bo->delete($info_id,$values['delete_subs'],$values['info_id_parent'], $skip_notification);
+				$deleted = $this->bo->delete($info_id, $values['delete_subs'], $values['info_id_parent'], $skip_notification);
 			}
 			if ($called_by)		// direct call from the same request
 			{
@@ -1693,7 +1691,7 @@ 
 			{
 				$this->edit(array(
 					'info_id' => $info_id,
-					'button'  => array('deleted' => true),	// not delete!
+					'button'  => array('deleted' => true), // not delete!
 					'referer' => $referer,
 					'msg'     => $deleted ? lang('Infolog entry deleted') : '',
 				));
@@ -1701,7 +1699,7 @@ 
 			return $referer ? $this->tmpl->location($referer) : $this->index();
 		}
 		$readonlys = $values = array();
-		$values['main'][1] = $this->get_info($info_id,$readonlys['main']);
+		$values['main'][1] = $this->get_info($info_id, $readonlys['main']);
 
 		$this->tmpl->read('infolog.delete');
 
@@ -1722,7 +1720,7 @@ 
 		$GLOBALS['egw_info']['flags']['app_header'] = lang('InfoLog').' - '.lang('Delete');
 		$GLOBALS['egw_info']['flags']['params']['manual'] = array('page' => 'ManualInfologDelete');
 
-		$this->tmpl->exec('infolog.infolog_ui.delete',$values,array(),$readonlys,$persist,$called_by == 'edit' ? 2 : 0);
+		$this->tmpl->exec('infolog.infolog_ui.delete', $values, array(), $readonlys, $persist, $called_by == 'edit' ? 2 : 0);
 	}
 
 	/**
@@ -1734,68 +1732,68 @@ 
 	 * @param string $type Type of log-entry: note,todo,task
 	 * @param string $referer array with param/get-vars of the refering page
 	 */
-	function edit($content = null,$action = '',$action_id=0,$type='',$referer='')
+	function edit($content = null, $action = '', $action_id = 0, $type = '', $referer = '')
 	{
 		if (($submit = is_array($content)))
 		{
 			//echo "infolog_ui::edit: content="; _debug_array($content);
 			$info_id   = $content['info_id'];
-			$action    = $content['action'];    unset($content['action']);
+			$action    = $content['action']; unset($content['action']);
 			$action_id = $content['action_id']; unset($content['action_id']);
-			$referer   = $content['referer'];   unset($content['referer']);
-			$no_popup  = $content['no_popup'];  unset($content['no_popup']);
+			$referer   = $content['referer']; unset($content['referer']);
+			$no_popup  = $content['no_popup']; unset($content['no_popup']);
 
 			list($button) = @each($content['button']);
-			if (!$button && $action) $button = $action;	// action selectbox
+			if (!$button && $action) $button = $action; // action selectbox
 			//info_cc expects an comma separated string
 			//error_log(__METHOD__.__LINE__.array2string($content));
 			if (empty($content['info_cc'])) $content['info_cc'] = "";
 			if (is_array($content['info_cc']))
 			{
-				foreach($content['info_cc'] as $i => $value)
+				foreach ($content['info_cc'] as $i => $value)
 				{
 					//imap_rfc822 should not be used, but it works reliable here, until we have some regex solution or use horde stuff
 					$addresses = imap_rfc822_parse_adrlist($value, '');
 					//error_log(__METHOD__.__LINE__.$value.'->'.array2string($addresses[0]));
-					$content['info_cc'][$i]=$addresses[0]->host ? $addresses[0]->mailbox.'@'.$addresses[0]->host : $addresses[0]->mailbox;
+					$content['info_cc'][$i] = $addresses[0]->host ? $addresses[0]->mailbox.'@'.$addresses[0]->host : $addresses[0]->mailbox;
 				}
-				if (!empty($content['info_cc'])) $content['info_cc'] = implode(',',$content['info_cc']);
+				if (!empty($content['info_cc'])) $content['info_cc'] = implode(',', $content['info_cc']);
 			}
 			unset($content['button']);
 			if ($button)
 			{
 				// Copy or schedule Infolog
-				if (in_array($button,array('copy','schedule','ical','tracker')))
+				if (in_array($button, array('copy', 'schedule', 'ical', 'tracker')))
 				{
 					$action = $button;
-					if (!$info_id || $this->bo->check_access($info_id,Acl::EDIT))
+					if (!$info_id || $this->bo->check_access($info_id, Acl::EDIT))
 					{
-						$button = 'apply';	// need to store infolog first
+						$button = 'apply'; // need to store infolog first
 					}
 				}
 				//Validate the enddate must be grather than startdate
 				if (!empty($content['info_enddate']) && !empty($content['info_startdate']))
 				{
-					$duration_date = $content['info_enddate']-$content['info_startdate'];
+					$duration_date = $content['info_enddate'] - $content['info_startdate'];
 					if ($duration_date < 0)
 					{
 						$this->tmpl->set_validation_error('info_startdate', lang('Startdate must be before Enddate!!!'));
-						$button = $action = '';	// stop save or apply
+						$button = $action = ''; // stop save or apply
 					}
 				}
 				//echo "<p>infolog_ui::edit(info_id=$info_id) '$button' button pressed, content="; _debug_array($content);
 				if (($button == 'save' || $button == 'apply') && isset($content['info_subject']) && empty($content['info_subject']))
 				{
-					$this->tmpl->set_validation_error('info_subject',lang('Field must not be empty !!!'));
-					$button = $action = '';	// stop save or apply
+					$this->tmpl->set_validation_error('info_subject', lang('Field must not be empty !!!'));
+					$button = $action = ''; // stop save or apply
 				}
 				if (($button == 'save' || $button == 'apply') && $info_id)
 				{
 					$old = $this->bo->read($info_id);
-					if (!($edit_acl = $this->bo->check_access($info_id,Acl::EDIT)))
+					if (!($edit_acl = $this->bo->check_access($info_id, Acl::EDIT)))
 					{
 						$status_only = $this->bo->is_responsible($old);
-						$undelete = $this->bo->check_access($old,infolog_bo::ACL_UNDELETE);
+						$undelete = $this->bo->check_access($old, infolog_bo::ACL_UNDELETE);
 					}
 					// enddate in the past gives warning
 					if (isset($content['info_enddate'])
@@ -1808,46 +1806,45 @@ 
 				}
 				if (($button == 'save' || $button == 'apply') && (!$info_id || $edit_acl || $status_only || $undelete))
 				{
-					$operation = $info_id ?  'edit' : 'add';
+					$operation = $info_id ? 'edit' : 'add';
 
 					if (is_array($content['link_to']['to_id']) && count($content['link_to']['to_id']))
 					{
-						$content['info_link_id'] = 0;	// as field has to be int
+						$content['info_link_id'] = 0; // as field has to be int
 					}
 					$active_tab = $content['tabs'];
 					if (!($info_id = $this->bo->write($content, true, true, true, $content['no_notifications'])))
 					{
-						$content['msg'] = $info_id !== 0 || !$content['info_id'] ? lang('Error: saving the entry') :
-							lang('Error: the entry has been updated since you opened it for editing!').'<br />'.
-							lang('Copy your changes to the clipboard, %1reload the entry%2 and merge them.','<a href="'.
-								htmlspecialchars(Egw::link('/index.php',array(
+						$content['msg'] = $info_id !== 0 || !$content['info_id'] ? lang('Error: saving the entry') : lang('Error: the entry has been updated since you opened it for editing!').'<br />'.
+							lang('Copy your changes to the clipboard, %1reload the entry%2 and merge them.', '<a href="'.
+								htmlspecialchars(Egw::link('/index.php', array(
 									'menuaction' => 'infolog.infolog_ui.edit',
 									'info_id'    => $content['info_id'],
 									'no_popup'   => $no_popup,
 									'referer'    => $referer,
-								))).'">','</a>');
-						$button = $action = '';	// not exiting edit
+								))).'">', '</a>');
+						$button = $action = ''; // not exiting edit
 						$info_id = $content['info_id'];
 					}
 					else
 					{
-						$GLOBALS['egw']->preferences->add('infolog','preferred_type',$content['info_type']);
-						$GLOBALS['egw']->preferences->save_repository(false,'user',false);
+						$GLOBALS['egw']->preferences->add('infolog', 'preferred_type', $content['info_type']);
+						$GLOBALS['egw']->preferences->save_repository(false, 'user', false);
 						$content['msg'] = lang('InfoLog entry saved');
-						Framework::refresh_opener($content['msg'],'infolog',$info_id,$operation);
+						Framework::refresh_opener($content['msg'], 'infolog', $info_id, $operation);
 					}
 					$content['tabs'] = $active_tab;
 
-					$pm_links = Link::get_links('infolog',$content['info_id'],'projectmanager');
+					$pm_links = Link::get_links('infolog', $content['info_id'], 'projectmanager');
 
 					$content['link_to']['to_app'] = 'infolog';
 					$content['link_to']['to_id'] = $info_id;
 
-					if ($info_link_id && strpos($info_link_id,':') !== false)	// updating info_link_id if necessary
+					if ($info_link_id && strpos($info_link_id, ':') !== false)	// updating info_link_id if necessary
 					{
-						list($app,$id) = explode(':',$info_link_id);
-						$link = Link::get_link('infolog',$info_id,$app,$id);
-						if ((int) $content['info_link_id'] != (int) $link['link_id'])
+						list($app, $id) = explode(':', $info_link_id);
+						$link = Link::get_link('infolog', $info_id, $app, $id);
+						if ((int)$content['info_link_id'] != (int)$link['link_id'])
 						{
 							$content['info_link_id'] = $link['link_id'];
 
@@ -1859,7 +1856,7 @@ 
 								'info_owner'   => $content['info_owner'],
 							);
 							//echo "<p>updating info_link_id: ".print_r($to_write,true)."</p>\n";
-							$this->bo->write($to_write,False,true,true,true);	// last true = no notifications, as no real change
+							$this->bo->write($to_write, False, true, true, true); // last true = no notifications, as no real change
 
 							// Do not override info_contact if is already filled with contact
 							if ($content['info_contact'])
@@ -1869,7 +1866,7 @@ 
 							}
 
 							// we need eg. the new modification date, for further updates
-							$content = array_merge($content,$to_write);
+							$content = array_merge($content, $to_write);
 						}
 					}
 				}
@@ -1880,33 +1877,33 @@ 
 						'action' => $action,
 						'action_id' => $action_id
 					);
-					if (!($content['msg'] = $this->delete($info_id,$referer,'edit'))) return;	// checks ACL first
+					if (!($content['msg'] = $this->delete($info_id, $referer, 'edit'))) return; // checks ACL first
 
-					Framework::refresh_opener($content['msg'],'infolog',$info_id,'delete');
+					Framework::refresh_opener($content['msg'], 'infolog', $info_id, 'delete');
 				}
 				// called again after delete confirmation dialog
-				elseif ($button == 'deleted'  && $content['msg'])
+				elseif ($button == 'deleted' && $content['msg'])
 				{
-					Framework::refresh_opener($content['msg'],'infolog',$info_id,'delete');
+					Framework::refresh_opener($content['msg'], 'infolog', $info_id, 'delete');
 				}
 				if ($button == 'save' || $button == 'cancel' || $button == 'delete' || $button == 'deleted')
 				{
 					if ($no_popup)
 					{
-						Egw::redirect_link($referer,array('msg' => $content['msg']));
+						Egw::redirect_link($referer, array('msg' => $content['msg']));
 					}
 					Framework::window_close();
 				}
 			}
 			// on a type-change, set the status to the default status of that type, if the actual status is not supported by the new type
-			if (!array_key_exists($content['info_status'],$this->bo->status[$content['info_type']]))
+			if (!array_key_exists($content['info_status'], $this->bo->status[$content['info_type']]))
 			{
 				$content['info_status'] = $this->bo->status['defaults'][$content['info_type']];
 				// Make sure we don't end up with invalid status / percent combinations
 				if ($content['info_status'] != 'done')
 				{
 					$content['info_datecompleted'] = '';
-					if((int)$content['info_percent'] === 100)
+					if ((int)$content['info_percent'] === 100)
 					{
 						$content['info_percent'] = 10;
 					}
@@ -1915,7 +1912,7 @@ 
 				{
 					$content['info_percent'] = 100;
 				}
-				if($content['info_status'] != 'not-started' && (int)$content['info_percent'] == 0)
+				if ($content['info_status'] != 'not-started' && (int)$content['info_percent'] == 0)
 				{
 					$content['info_percent'] = 10;
 				}
@@ -1924,18 +1921,17 @@ 
 		else	// new call via GET
 		{
 			//echo "<p>infolog_ui::edit: info_id=$info_id,  action='$action', action_id='$action_id', type='$type', referer='$referer'</p>\n";
-			$action    = $action    ? $action    : $_REQUEST['action'];
+			$action    = $action ? $action : $_REQUEST['action'];
 			$action_id = $action_id ? $action_id : $_REQUEST['action_id'];
-			$info_id   = $content   ? $content   : $_REQUEST['info_id'];
-			$type      = $type      ? $type      : $_REQUEST['type'];
-			$referer   = $referer !== '' ? $referer : ($_GET['referer'] ? $_GET['referer'] :
-				Api\Header\Referer::get('/index.php?menuaction=infolog.infolog_ui.index'));
-			if (strpos($referer, 'msg=') !== false) $referer = preg_replace('/([&?]{1})msg=[^&]+&?/','\\1',$referer);	// remove previou/old msg from referer
+			$info_id   = $content ? $content : $_REQUEST['info_id'];
+			$type      = $type ? $type : $_REQUEST['type'];
+			$referer   = $referer !== '' ? $referer : ($_GET['referer'] ? $_GET['referer'] : Api\Header\Referer::get('/index.php?menuaction=infolog.infolog_ui.index'));
+			if (strpos($referer, 'msg=') !== false) $referer = preg_replace('/([&?]{1})msg=[^&]+&?/', '\\1', $referer); // remove previou/old msg from referer
 			$no_popup  = $_GET['no_popup'];
-			$print = (int) $_REQUEST['print'];
+			$print = (int)$_REQUEST['print'];
 			//echo "<p>infolog_ui::edit: info_id=$info_id,  action='$action', action_id='$action_id', type='$type', referer='$referer'</p>\n";
 
-			if (($content = $this->bo->read( $info_id || $action != 'sp' ? $info_id : $action_id )) === false)
+			if (($content = $this->bo->read($info_id || $action != 'sp' ? $info_id : $action_id)) === false)
 			{
 				Framework::window_close(lang('Permission denied!'));
 			}
@@ -1947,29 +1943,29 @@ 
 			{
 				$content['info_cat'] = $this->prefs['cat_add_default'];
 			}
-			if ($_GET['msg']) $content['msg'] = strip_tags($_GET['msg']);	// dont allow HTML!
+			if ($_GET['msg']) $content['msg'] = strip_tags($_GET['msg']); // dont allow HTML!
 
-			switch($this->prefs['set_start'])
+			switch ($this->prefs['set_start'])
 			{
-				case 'date': default: $set_startdate = mktime(0,0,0,date('m',$this->bo->user_time_now),date('d',$this->bo->user_time_now),date('Y',$this->bo->user_time_now)); break;
+				case 'date': default: $set_startdate = mktime(0, 0, 0, date('m', $this->bo->user_time_now), date('d', $this->bo->user_time_now), date('Y', $this->bo->user_time_now)); break;
 				case 'datetime':      $set_startdate = $this->bo->user_time_now; break;
 				case 'empty':         $set_startdate = 0; break;
 			}
 			if ((int)$content['info_link_id'] > 0 && !Link::get_link($content['info_link_id']))
 			{
-				$content['info_link_id'] = 0;	// link has been deleted
+				$content['info_link_id'] = 0; // link has been deleted
 				if (!$content['info_custom_link']) $content['info_from'] = '';
 			}
 			if (!$info_id && $action_id && $action == 'sp')    // new SubProject
 			{
-				if (!$this->bo->check_access($action_id,Acl::ADD))
+				if (!$this->bo->check_access($action_id, Acl::ADD))
 				{
-					return $referer ? $this->tmpl->location($referer) : $this->index(0,$action,$action_id);
+					return $referer ? $this->tmpl->location($referer) : $this->index(0, $action, $action_id);
 				}
 			}
 			else
 			{
-				$undelete = $this->bo->check_access($content,infolog_bo::ACL_UNDELETE);
+				$undelete = $this->bo->check_access($content, infolog_bo::ACL_UNDELETE);
 			}
 			$content['links'] = $content['link_to'] = array(
 				'to_id' => $info_id,
@@ -1977,12 +1973,12 @@ 
 			);
 		}
 		// new call via GET or some actions handled here, as they can happen both ways ($_GET[action] or button/action in GUI)
-		if (!$submit || in_array($action,array('sp','copy','schedule','ical','to_tracker')))
+		if (!$submit || in_array($action, array('sp', 'copy', 'schedule', 'ical', 'to_tracker')))
 		{
 			switch ($action)
 			{
 				case 'schedule':
-					Egw::redirect_link('/index.php',array(
+					Egw::redirect_link('/index.php', array(
 						'menuaction' => 'calendar.calendar_uiforms.edit',
 						'link_app' => 'infolog',
 						'link_id' => $info_id,
@@ -1990,7 +1986,7 @@ 
 					break;
 				case 'ical':
 					$boical = new infolog_ical();
-					$result = $boical->exportVTODO($content,'2.0','PUBLISH',false);
+					$result = $boical->exportVTODO($content, '2.0', 'PUBLISH', false);
 					Api\Header\Content::type('todo.ics', 'text/calendar');
 					echo $result;
 					exit();
@@ -2001,23 +1997,23 @@ 
 					if ($action == 'sp')	// for sub-entries use type or category, like for new entries
 					{
 						if ($type) $content['info_type'] = $type;
-						if (is_numeric($_REQUEST['cat_id'])) $content['info_cat'] = (int) $_REQUEST['cat_id'];
+						if (is_numeric($_REQUEST['cat_id'])) $content['info_cat'] = (int)$_REQUEST['cat_id'];
 					}
-					unset($action);	// it get stored in $content and will cause an other copy after [apply]
+					unset($action); // it get stored in $content and will cause an other copy after [apply]
 					break;
 				case 'to_tracker':
-					Egw::redirect_link('/index.php',array(
+					Egw::redirect_link('/index.php', array(
 						'menuaction' => 'tracker.tracker_ui.edit',
 						Link::get_registry('tracker', 'add_app').'[]' => 'infolog',
-						Link::get_registry('tracker','add_id').'[]' => $info_id,
+						Link::get_registry('tracker', 'add_id').'[]' => $info_id,
 					));
 					break;
 				case 'projectmanager':
 					$content['pm_id'] = $action_id;
 				default:	// to allow other apps to participate
 					$content['info_subject'] = Link::title($action, $id);
-					$action_ids = explode(',',$action_id);
-					if(count($action_ids) == 1)
+					$action_ids = explode(',', $action_id);
+					if (count($action_ids) == 1)
 					{
 						$content['info_contact'] = array('app' => $action, 'id' => $action_id);
 					}
@@ -2026,11 +2022,11 @@ 
 						Link::link('infolog', $content['link_to']['to_id'], $action, $id);
 
 						// calling "infolog_set" hook for first, in case app wants to set some more values
-						if (!$n && ($set = Api\Hooks::single(array('location'=>'infolog_set','id'=>$action_id),$action)))
+						if (!$n && ($set = Api\Hooks::single(array('location'=>'infolog_set', 'id'=>$action_id), $action)))
 						{
-							foreach((array)$set['link_app'] as $i => $l_app)
+							foreach ((array)$set['link_app'] as $i => $l_app)
 							{
-								if (($l_id=$set['link_id'][$i])) Link::link('infolog',$content['link_to']['to_id'],$l_app,$l_id);
+								if (($l_id = $set['link_id'][$i])) Link::link('infolog', $content['link_to']['to_id'], $l_app, $l_id);
 							}
 							unset($set['link_app']);
 							unset($set['link_id']);
@@ -2044,12 +2040,12 @@ 
 					{
 						if (!isset($pm_links))
 						{
-							$pm_links = Link::get_links('infolog',$info_id,'projectmanager');
+							$pm_links = Link::get_links('infolog', $info_id, 'projectmanager');
 						}
-						break;	// normal edit
+						break; // normal edit
 					}
 				case 'new':		// new entry, set some defaults, if not set by infolog_set hook
-					if (empty($content['info_startdate'])) $content['info_startdate'] = (int) $_GET['startdate'] ? (int) $_GET['startdate'] : $set_startdate;
+					if (empty($content['info_startdate'])) $content['info_startdate'] = (int)$_GET['startdate'] ? (int)$_GET['startdate'] : $set_startdate;
 					if (empty($content['info_priority'])) $content['info_priority'] = 1; // normal
 					$content['info_owner'] = $this->user;
 					if ($type != '' && empty($content['info_type']))
@@ -2074,9 +2070,9 @@ 
 		if ($this->bo->group_owners)
 		{
 			// remove types owned by groups the user has no edit grant (current type is made readonly)
-			foreach($this->bo->group_owners as $type => $group)
+			foreach ($this->bo->group_owners as $type => $group)
 			{
-				if (!($this->bo->grants[$group] & Acl::EDIT))
+				if (!($this->bo->grants[$group]&Acl::EDIT))
 				{
 					if ($type == $content['info_type'])
 					{
@@ -2094,7 +2090,7 @@ 
 			{
 				$content['info_owner'] = $this->bo->group_owners[$content['info_type']];
 				// Dont allow to change the type, if user has no delete rights from the group-owner
-				if ($info_id && !($this->bo->grants[$content['info_owner']] & Acl::DELETE))
+				if ($info_id && !($this->bo->grants[$content['info_owner']]&Acl::DELETE))
 				{
 					//echo "<p>setting type to r/o as user has no delete rights from group #$group</p>\n";
 					$readonlys['info_type'] = true;
@@ -2102,7 +2098,7 @@ 
 				// disable info_access for group-owners
 				$readonlys['info_access'] = true;
 			}
-			elseif($GLOBALS['egw']->accounts->get_type($content['info_owner']) == 'g')
+			elseif ($GLOBALS['egw']->accounts->get_type($content['info_owner']) == 'g')
 			{
 				$content['info_owner'] = $this->user;
 			}
@@ -2116,17 +2112,17 @@ 
 		// for no edit rights or implizit edit of responsible user make all fields readonly, but status and percent
 		if ($info_id && !$this->bo->check_access($content, Acl::EDIT) && !$undelete)
 		{
-			$readonlys['__ALL__'] = true;	// make all fields not explicitly set readonly
+			$readonlys['__ALL__'] = true; // make all fields not explicitly set readonly
 			if ($this->bo->is_responsible($content))
 			{
-				foreach($this->bo->responsible_edit as $name)
+				foreach ($this->bo->responsible_edit as $name)
 				{
 					$readonlys[$name] = false;
 				}
 				$readonlys['timestamp'] = $readonlys['info_des'];
 				$readonlys['button[edit]'] = $readonlys['button[save]'] = $readonlys['button[apply]'] = $readonlys['no_notifications'] = false;
 			}
-			$readonlys['action'] = $readonlys['button[cancel]'] = false;	// always allowed
+			$readonlys['action'] = $readonlys['button[cancel]'] = false; // always allowed
 		}
 		elseif (!$info_id)
 		{
@@ -2141,14 +2137,14 @@ 
 
 		if (!($readonlys['button[delete]'] = !$info_id || !$this->bo->check_access($content, Acl::DELETE)))
 		{
-			$content['info_anz_subs'] = $this->bo->anzSubs($info_id);	// to determine js confirmation of delete or not
+			$content['info_anz_subs'] = $this->bo->anzSubs($info_id); // to determine js confirmation of delete or not
 		}
 		$GLOBALS['egw_info']['flags']['app_header'] = lang($this->messages[$info_id ? 'edit' : ($action == 'sp' ? 'add_sub' : 'add')]);
 
 		// use a typ-specific template (infolog.edit.xyz), if one exists, otherwise fall back to the generic one
 		if (!$this->tmpl->read('infolog.edit.'.$content['info_type']))
 		{
-			$this->tmpl->read($print ? 'infolog.edit.print':'infolog.edit');
+			$this->tmpl->read($print ? 'infolog.edit.print' : 'infolog.edit');
 		}
 		if ($this->bo->has_customfields($content['info_type']))
 		{
@@ -2160,7 +2156,7 @@ 
 		}
 		if (!isset($GLOBALS['egw_info']['user']['apps']['projectmanager']))
 		{
-			$readonlys['tabs']['project'] = true;	// disable the project tab
+			$readonlys['tabs']['project'] = true; // disable the project tab
 		}
 
 		$content['duration_format'] = $this->duration_format;
@@ -2168,15 +2164,14 @@ 
 		if ($this->prefs['show_id']) $content['info_number'] = $info_id;
 
 		// Check no notification preference, update if type changed
-		if($content['info_type'] != $content['old_type'])
+		if ($content['info_type'] != $content['old_type'])
 		{
 			$content['no_notifications'] = in_array($content['info_type'], !is_array($this->prefs['no_notification_types']) ?
-					explode(',',$this->prefs['no_notification_types']):
-					$this->prefs['no_notification_types']
+					explode(',', $this->prefs['no_notification_types']) : $this->prefs['no_notification_types']
 			);
 		}
 
-		$content['info_anz_subs'] = (int)$content['info_anz_subs'];	// gives javascript error if empty!
+		$content['info_anz_subs'] = (int)$content['info_anz_subs']; // gives javascript error if empty!
 
 		$old_pm_id = is_array($pm_links) ? array_shift($pm_links) : $content['old_pm_id'];
 		unset($content['old_pm_id']);
@@ -2194,7 +2189,7 @@ 
 					'Pr' => $this->bo->enums['priority'],
 					'Ow' => 'select-account',
 					//'Ac',	//	info_access: private||public
-					'St' => $this->bo->status[$content['info_type']]+array('deleted' => 'deleted'),
+					'St' => $this->bo->status[$content['info_type']] + array('deleted' => 'deleted'),
 					'Pe' => 'select-percent',
 					'Co' => 'date-time',
 					'st' => 'date-time',
@@ -2211,7 +2206,7 @@ 
 			);
 			$history_stati = array();
 			$tracking = new infolog_tracking($this);
-			foreach($tracking->field2history as $field => $history)
+			foreach ($tracking->field2history as $field => $history)
 			{
 				$history_stati[$history] = $tracking->field2label[$field];
 			}
@@ -2256,8 +2251,8 @@ 
 		//$content['info_des'] = substr($content['info_des'],0,1793);
 		//echo "<p>infolog_ui.edit(info_id='$info_id',action='$action',action_id='$action_id') readonlys="; print_r($readonlys); echo ", content = "; _debug_array($content);
 		//$content['info_cc'] is expected (by the widget) to be an array of emailaddresses, but is stored as comma separated string
-		if (!empty($content['info_cc'])&&!is_array($content['info_cc']))$content['info_cc'] = explode(',',$content['info_cc']);
-		$preserve = array_merge( $preserv, array(	// preserved values
+		if (!empty($content['info_cc']) && !is_array($content['info_cc']))$content['info_cc'] = explode(',', $content['info_cc']);
+		$preserve = array_merge($preserv, array(	// preserved values
 			'info_id'       => $info_id,
 			'action'        => $action,
 			'action_id'     => $action_id,
@@ -2266,7 +2261,7 @@ 
 			'old_pm_id'     => $old_pm_id,
 			'old_type'      => $content['info_type'],
 		));
-		$this->tmpl->exec('infolog.infolog_ui.edit',$content,$sel_options,$readonlys,$preserve,$no_popup ? 0 : 2);
+		$this->tmpl->exec('infolog.infolog_ui.edit', $content, $sel_options, $readonlys, $preserve, $no_popup ? 0 : 2);
 	}
 
 	/**
@@ -2277,16 +2272,16 @@ 
 	 * @param array &$content
 	 * @param boolean $create_sub true: create a sub-entry instead of a copy, default false to create a copy
 	 */
-	private function create_copy(array &$content, $create_sub=false)
+	private function create_copy(array &$content, $create_sub = false)
 	{
-		$info_id = $content['info_id'];	// it will be unset by exclude-fields
+		$info_id = $content['info_id']; // it will be unset by exclude-fields
 
 		// empty fields configured to be excluded (also contains id, uid, ...)
 		$exclude_fields = $create_sub ? $this->bo->sub_excludefields : $this->bo->copy_excludefields;
 		foreach ($exclude_fields as $field)
 		{
 			unset($content[$field]);
-			if ($field == 'info_from') unset($content['info_link_id']);	// both together is called contact in UI
+			if ($field == 'info_from') unset($content['info_link_id']); // both together is called contact in UI
 		}
 		if ($create_sub)
 		{
@@ -2295,9 +2290,9 @@ 
 		// no startdate or startdate in the past --> set startdate from pref
 		if (!isset($content['info_startdate']) || $content['info_startdate'] < $this->bo->user_time_now)
 		{
-			switch($this->prefs['set_start'])
+			switch ($this->prefs['set_start'])
 			{
-				case 'date': default: $set_startdate = mktime(0,0,0,date('m',$this->bo->user_time_now),date('d',$this->bo->user_time_now),date('Y',$this->bo->user_time_now)); break;
+				case 'date': default: $set_startdate = mktime(0, 0, 0, date('m', $this->bo->user_time_now), date('d', $this->bo->user_time_now), date('Y', $this->bo->user_time_now)); break;
 				case 'datetime':      $set_startdate = $this->bo->user_time_now; break;
 				case 'empty':         $set_startdate = 0; break;
 			}
@@ -2316,17 +2311,17 @@ 
 		// get a consistent status, percent and date-completed
 		if (!isset($content['info_status'])) $content['info_status'] = $this->bo->status['defaults'][$content['info_type']];
 		if (!isset($content['info_percent'])) $content['info_percent'] = $content['info_status'] == 'done' ? '100%' : '0%';
-		$content['info_datecompleted'] =$content['info_status'] == 'done' ? $this->bo->user_time_now : 0;
+		$content['info_datecompleted'] = $content['info_status'] == 'done' ? $this->bo->user_time_now : 0;
 
 		if (!isset($content['info_cat'])) $content['info_cat'] = $this->prefs['cat_add_default'];
 
-		if(!is_array($content['link_to'])) $content['link_to'] = array();
+		if (!is_array($content['link_to'])) $content['link_to'] = array();
 		$content['link_to']['to_app'] = 'infolog';
 		$content['link_to']['to_id'] = 0;
 		// Get links to be copied, if not excluded
-		if (!in_array('link_to',$exclude_fields) || !in_array('attachments',$exclude_fields))
+		if (!in_array('link_to', $exclude_fields) || !in_array('attachments', $exclude_fields))
 		{
-			foreach(Link::get_links($content['link_to']['to_app'], $info_id) as $link)
+			foreach (Link::get_links($content['link_to']['to_app'], $info_id) as $link)
 			{
 				if ($link['app'] != Link::VFS_APPNAME && !in_array('link_to', $exclude_fields))
 				{
@@ -2350,24 +2345,23 @@ 
 			if (!isset($content['info_contact']) || empty($content['info_contact']) || $content['info_contact'] === 'copy:')
 			{
 				$linkinfos = Link::get_link($info_link_id);
-				$content['info_contact'] = $linkinfos['link_app1']=='infolog'?
-						array('app' => $linkinfos['link_app2'], 'id' => $linkinfos['link_id2']):
-						array('app' => $linkinfos['link_app1'], 'id' => $linkinfos['link_id1']);
+				$content['info_contact'] = $linkinfos['link_app1'] == 'infolog' ?
+						array('app' => $linkinfos['link_app2'], 'id' => $linkinfos['link_id2']) : array('app' => $linkinfos['link_app1'], 'id' => $linkinfos['link_id1']);
 				if ($content['info_contact']['app'] == 'projectmanager')
 				{
-					$content['pm_id'] = $linkinfos['link_app1']=='projectmanager'? $linkinfos['link_id1']:$linkinfos['link_id2'];
+					$content['pm_id'] = $linkinfos['link_app1'] == 'projectmanager' ? $linkinfos['link_id1'] : $linkinfos['link_id2'];
 				}
 			}
 			unset($content['info_link_id']);
 		}
-		$content['info_owner'] = !(int)$this->owner || !$this->bo->check_perms(Acl::ADD,0,$this->owner) ? $this->user : $this->owner;
+		$content['info_owner'] = !(int)$this->owner || !$this->bo->check_perms(Acl::ADD, 0, $this->owner) ? $this->user : $this->owner;
 
 		if (!empty($content['info_subject']))
 		{
 			if ($create_sub)
 			{
 				$config = Api\Config::read('infolog');
-				$prefix = lang(empty($config['sub_prefix']) ? 'Re:': $config['sub_prefix']);
+				$prefix = lang(empty($config['sub_prefix']) ? 'Re:' : $config['sub_prefix']);
 			}
 			else
 			{
@@ -2377,11 +2371,11 @@ 
 		}
 		if (!$create_sub)
 		{
-			$content['msg'] .= ($content['msg']?"\n":'').lang('%1 copied - the copy can now be edited', lang(Link::get_registry('infolog','entry')));
+			$content['msg'] .= ($content['msg'] ? "\n" : '').lang('%1 copied - the copy can now be edited', lang(Link::get_registry('infolog', 'entry')));
 		}
 	}
 
-	function icon($cat,$id,$status='')
+	function icon($cat, $id, $status = '')
 	{
 		if (!$status || !($icon = $this->icons[$cat][$id.'_'.$status]))
 		{
@@ -2398,7 +2392,7 @@ 
 				$alt = $id;
 			}
 		}
-		return $icon ? Api\Html::image('infolog',$icon,lang($alt),'border=0') : lang($alt);
+		return $icon ? Api\Html::image('infolog', $icon, lang($alt), 'border=0') : lang($alt);
 	}
 
 	/**
@@ -2446,27 +2440,27 @@ 
 			'info_cc' => 'CC',
 		);
 		// add customfields to field list
-		foreach(Api\Storage\Customfields::get('infolog') as $name => $data)
+		foreach (Api\Storage\Customfields::get('infolog') as $name => $data)
 		{
 			$excludefields['#'.$name] = $data['label'];
 		}
 		$sub_excludefields = $excludefields;
-		unset($sub_excludefields['info_id_parent']);	// always set to parent!
+		unset($sub_excludefields['info_id_parent']); // always set to parent!
 
 		$config = Api\Config::read('infolog');
 
-		if($content)
+		if ($content)
 		{
 			// Save
 			$button = key($content['button']);
-			if($button == 'save' || $button == 'apply')
+			if ($button == 'save' || $button == 'apply')
 			{
-				$this->bo->responsible_edit = array('info_status','info_percent','info_datecompleted');
+				$this->bo->responsible_edit = array('info_status', 'info_percent', 'info_datecompleted');
 
 				if ($content['responsible_edit'])
 				{
-					$extra = array_intersect($content['responsible_edit'],array_keys($fields));
-					$this->bo->responsible_edit = array_unique(array_merge($this->bo->responsible_edit,$extra));
+					$extra = array_intersect($content['responsible_edit'], array_keys($fields));
+					$this->bo->responsible_edit = array_unique(array_merge($this->bo->responsible_edit, $extra));
 				}
 				Api\Config::save_value('copy_excludefields', $content['copy_excludefields'] ? $content['copy_excludefields'] : null, 'infolog');
 				Api\Config::save_value('sub_excludefields', $content['sub_excludefields'] ? $content['sub_excludefields'] : array('*NONE*'), 'infolog');
@@ -2477,12 +2471,12 @@ 
 				Api\Config::save_value('sub_prefix', $content['sub_prefix'], 'infolog');
 				Api\Config::save_value('allow_past_due_date', $content['allow_past_due_date'], 'infolog');
 				// Notifications
-				$notifications =& $config[infolog_tracking::CUSTOM_NOTIFICATION];
+				$notifications = & $config[infolog_tracking::CUSTOM_NOTIFICATION];
 				$notifications[$content['notification_type']] = $content['notification'];
-				Api\Config::save_value(infolog_tracking::CUSTOM_NOTIFICATION, $notifications,'infolog');
+				Api\Config::save_value(infolog_tracking::CUSTOM_NOTIFICATION, $notifications, 'infolog');
 			}
 
-			if($button == 'save' || $button == 'cancel')
+			if ($button == 'save' || $button == 'cancel')
 			{
 				Egw::redirect_link('/index.php', array(
 					'menuaction' => 'admin.admin_ui.index',
@@ -2505,7 +2499,7 @@ 
 		$GLOBALS['egw_info']['flags']['app_header'] = lang('InfoLog').' - '.lang('Site configuration');
 
 		// Load selected custom notification
-		if(!$content['notification_type'])
+		if (!$content['notification_type'])
 		{
 			$content['notification_type'] = '~global~';
 		}
@@ -2529,7 +2523,7 @@ 
 		);
 		$preserve['notification_old_type'] = $content['notification_type'];
 		$this->tmpl->read('infolog.config');
-		$this->tmpl->exec('infolog.infolog_ui.admin',$content,$sel_options,array(),$preserve);
+		$this->tmpl->exec('infolog.infolog_ui.admin', $content, $sel_options, array(), $preserve);
 	}
 
 	/**
@@ -2538,13 +2532,13 @@ 
 	 * @param array $mailContent = null content of mail
 	 * @return  array
 	 */
-	function mail_import(array $mailContent=null)
+	function mail_import(array $mailContent = null)
 	{
 		// It would get called from compose as a popup with egw_data
 		if (!is_array($mailContent) && ($_GET['egw_data']))
 		{
 			// get the mail raw data
-			Link::get_data ($_GET['egw_data']);
+			Link::get_data($_GET['egw_data']);
 			return false;
 		}
 
@@ -2575,7 +2569,7 @@ 
 	function hook_view($args)
 	{
 		// Load JS for infolog actions
-		Framework::includeJS('.','app','infolog');
+		Framework::includeJS('.', 'app', 'infolog');
 
 		switch ($args['location'])
 		{
@@ -2603,7 +2597,7 @@ 
 		{
 			return False;
 		}
-		$this->called_by = $app;	// for read/save_sessiondata, to have different sessions for the hooks
+		$this->called_by = $app; // for read/save_sessiondata, to have different sessions for the hooks
 
 		// Set to calling app, so actions wind up in the correct place client side
 		$GLOBALS['egw_info']['flags']['currentapp'] = $app;
@@ -2611,11 +2605,11 @@ 
 		Api\Translation::add_app('infolog');
 
 		// Still want infolog Api\Categories though
-		$GLOBALS['egw']->categories = new Api\Categories('','infolog');
-		$this->index(null,$app,$args[$view_id],array(
+		$GLOBALS['egw']->categories = new Api\Categories('', 'infolog');
+		$this->index(null, $app, $args[$view_id], array(
 			'menuaction' => $view,
 			isset($view_id2) ? $view_id2 : $view_id => $args[$view_id]
-		),True);
+		), True);
 	}
 
 	/**
@@ -2624,25 +2618,25 @@ 
 	 * @param string $type infolog type to include only the matching custom fields if set
 	 * @return array
 	 */
-	function csv_export_fields($type=null)
+	function csv_export_fields($type = null)
 	{
 		$fields = array(
 			'info_type'          => lang('Type'),
 			'info_from'          => lang('Contact'),
 //			'info_link_id'       => lang('primary link'),
-			'info_cat'           => array('label' => lang('Category'),'type' => 'select-cat'),
+			'info_cat'           => array('label' => lang('Category'), 'type' => 'select-cat'),
 			'info_priority'      => lang('Priority'),
-			'info_owner'         => array('label' => lang('Owner'),'type' => 'select-account'),
+			'info_owner'         => array('label' => lang('Owner'), 'type' => 'select-account'),
 			'info_access'        => lang('Access'),
 			'info_status'        => lang('Status'),
 			'info_percent'       => lang('Completed'),
 			'info_datecompleted' => lang('Date completed'),
 			'info_datemodified'  => lang('Last modified'),
-			'info_modifier'      => array('label' => lang('Modifier'),'type' => 'select-account'),
+			'info_modifier'      => array('label' => lang('Modifier'), 'type' => 'select-account'),
 			'info_location'      => lang('Location'),
 			'info_startdate'     => lang('Startdate'),
 			'info_enddate'       => lang('Enddate'),
-			'info_responsible'   => array('label' => lang('Responsible'),'type' => 'select-account'),
+			'info_responsible'   => array('label' => lang('Responsible'), 'type' => 'select-account'),
 			'info_subject'       => lang('Subject'),
 			'info_des'           => lang('Description'),
 			'info_id'            => lang('Id'),
@@ -2652,13 +2646,13 @@ 
 			'pl_id'              => lang('pricelist'),
 			'info_price'         => lang('price'),
 		);
-		foreach($this->bo->timestamps as $name)
+		foreach ($this->bo->timestamps as $name)
 		{
-			$fields[$name] = array('label' => $fields[$name],'type' => 'date-time');
+			$fields[$name] = array('label' => $fields[$name], 'type' => 'date-time');
 		}
-		foreach($this->bo->customfields as $name => $data)
+		foreach ($this->bo->customfields as $name => $data)
 		{
-			if ($data['type2'] && $type && !in_array($type,explode(',',$data['type2']))) continue;
+			if ($data['type2'] && $type && !in_array($type, explode(',', $data['type2']))) continue;
 
 			$fields['#'.$name] = array(
 				'label' => $data['label'],

Braces +260 added lines, -65 removed lines

@@ -97,7 +97,10 @@ 
 	 */
 	function __construct(Etemplate $etemplate = null)
 	{
-		if ($GLOBALS['egw_info']['flags']['currentapp'] != 'infolog') Api\Translation::add_app('infolog');
+		if ($GLOBALS['egw_info']['flags']['currentapp'] != 'infolog')
+		{
+			Api\Translation::add_app('infolog');
+		}
 
 		// Make sure Global category is infolog - on first load, it may not be
 		if($GLOBALS['egw_info']['flags']['currentapp'] == 'infolog' && !$GLOBALS['egw']->categories->app_name)
@@ -169,13 +172,19 @@ 
 		$done = $info['info_status'] == 'done' || $info['info_status'] == 'billed' || $info['info_status'] == 'cancelled'; //cancelled is regarded as a completed status as well in bo
 		// regard an infolog as done/billed/cancelled if its percentage is 100% when there is to status like the above for that type
 		if (!$done && !isset($this->bo->status[$info['info_type']]['done']) && !isset($this->bo->status[$info['info_type']]['billed']) &&
-			!isset($this->bo->status[$info['info_type']]['cancelled']) && (int)$info['info_percent']==100) $done = true ;
+			!isset($this->bo->status[$info['info_type']]['cancelled']) && (int)$info['info_percent']==100)
+		{
+			$done = true ;
+		}
 		$info['sub_class'] = $this->bo->enums['priority'][$info['info_priority']] . ($done ? '_done' : '');
 		if (!$done && $info['info_enddate'] < $this->bo->user_time_now)
 		{
 			$info['end_class'] = 'infolog_overdue';
 		}
-		if (!isset($info['info_anz_subs'])) $info['info_anz_subs'] = $this->bo->anzSubs($id);
+		if (!isset($info['info_anz_subs']))
+		{
+			$info['info_anz_subs'] = $this->bo->anzSubs($id);
+		}
 		$this->bo->link_id2from($info,$action,$action_id);	// unset from for $action:$action_id
 		$info['info_percent'] = (int) $info['info_percent'].'%';
 		$editrights = $this->bo->check_access($info,Acl::EDIT);
@@ -208,12 +217,21 @@ 
 		{
 			$info['class'] .= 'rowNoSubs ';
 		}
-		if ($info['info_id_parent']) $info['class'] .= 'infolog_rowHasParent ';
-		if ($info['info_anz_subs'] > 0) $info['class'] .= 'infolog_rowHasSubs ';
+		if ($info['info_id_parent'])
+		{
+			$info['class'] .= 'infolog_rowHasParent ';
+		}
+		if ($info['info_anz_subs'] > 0)
+		{
+			$info['class'] .= 'infolog_rowHasSubs ';
+		}
 
 		$info['row_mod'] = $info['info_datemodified'];
 
-		if (!$show_links) $show_links = $this->prefs['show_links'];
+		if (!$show_links)
+		{
+			$show_links = $this->prefs['show_links'];
+		}
 		if (($show_links != 'none' && $show_links != 'no_describtion' ||
 			 $this->prefs['show_times'] || isset($GLOBALS['egw_info']['user']['apps']['timesheet'])) &&
 			(isset($info['links']) || ($info['links'] = Link::get_links('infolog',$info['info_id'],'','link_lastmod DESC',true,true))))
@@ -223,9 +241,16 @@ 
 			{
 				// incl. link modification time into row_mod (link's lastmod is always in server-time!)
 				$link_mod = Api\DateTime::server2user($link['lastmod']);
-				if ($info['row_mod'] < $link_mod) $info['row_mod'] = $link_mod;
+				if ($info['row_mod'] < $link_mod)
+				{
+					$info['row_mod'] = $link_mod;
+				}
 
-				if ($link['deleted']) continue;	// skip deleted links, but incl. them in row_mod!
+				if ($link['deleted'])
+				{
+					continue;
+				}
+				// skip deleted links, but incl. them in row_mod!
 
 				if ($show_links != 'none' && $show_links != 'no_describtion' &&
 					$link['link_id'] != $info['info_link_id'] &&
@@ -238,14 +263,20 @@ 
 				{
 					$info['pm_id'] = $link['id'];
 				}
-				if ($link['app'] == 'timesheet') $timesheets[] = $link['id'];
+				if ($link['app'] == 'timesheet')
+				{
+					$timesheets[] = $link['id'];
+				}
 			}
 			if ($this->prefs['show_times'] && isset($GLOBALS['egw_info']['user']['apps']['timesheet']) && $timesheets)
 			{
 				$sum = ExecMethod('timesheet.timesheet_bo.sum',$timesheets);
 				$info['info_sum_timesheets'] = $sum['duration'];
 				// incl. max timesheet modification in row_mod
-				if ($info['row_mod'] < $sum['max_modified']) $info['row_mod'] = $sum['max_modified'];
+				if ($info['row_mod'] < $sum['max_modified'])
+				{
+					$info['row_mod'] = $sum['max_modified'];
+				}
 			}
 		}
 		$info['info_type_label'] = $this->bo->enums['type'][$info['info_type']];
@@ -260,10 +291,13 @@ 
 			}
 			$readonlys["edit_percent[$id]"] = true;
 		}
-		elseif($readonlys["edit_percent[$id]"])	// show percent, but button is switched off
+		elseif($readonlys["edit_percent[$id]"])
+		{
+			// show percent, but button is switched off
 		{
 			$info['info_percent2'] = $info['info_percent'];
 		}
+		}
 		if ($this->prefs['show_id'] == 1 || $this->prefs['show_id'] == 2 && $details)
 		{
 			$info['info_number'] = $info['info_id'];
@@ -337,10 +371,16 @@ 
 			$query['col_filter'] = array('info_id_parent' => $query['col_filter']['info_id_parent']);
 		}
 		$orginal_colfilter = $query['col_filter'];
-		if (isset($parent_id)) $query['col_filter']['info_id_parent'] = (string)$parent_id;
+		if (isset($parent_id))
+		{
+			$query['col_filter']['info_id_parent'] = (string)$parent_id;
+		}
 
 		//echo "<p>infolog_ui.get_rows(start=$query[start],search='$query[search]',filter='$query[filter]',cat_id=$query[cat_id],action='$query[action]/$query[action_id]',col_filter=".print_r($query['col_filter'],True).",sort=$query[sort],order=$query[order])</p>\n";
-		if (!isset($query['start'])) $query['start'] = 0;
+		if (!isset($query['start']))
+		{
+			$query['start'] = 0;
+		}
 
 		// handle action and linked filter (show only entries linked to a certain other entry)
 		$link_filters = array();
@@ -369,7 +409,10 @@ 
 				$app = $link['app'];
 				$id = $link['id'];
 			}
-			if(!is_array($id)) $id = explode(',',$id);
+			if(!is_array($id))
+			{
+				$id = explode(',',$id);
+			}
 			if (!($linked = Link::get_links_multiple($app,$id,true,'infolog','',$query['col_filter']['info_status'] == 'deleted')))
 			{
 				$rows = array();	// no infologs linked to selected link --> no rows to return
@@ -418,7 +461,10 @@ 
 			}
 		}
 		// Framework\Template change forces the UI to do a full update first, no point in getting rows right now
-		if($old_template && $old_template != $query['template']) return 0;
+		if($old_template && $old_template != $query['template'])
+		{
+			return 0;
+		}
 
 		// do we need to read the custom fields, depends on the column is enabled and customfields exist, prefs are filter specific
 		// so we have to check that as well
@@ -479,7 +525,10 @@ 
 		$parent_first = !empty($parents) && count($parents) == 1;
 		$parent_index = 0;
 		// et2 nextmatch listens to total, and only displays that many rows, so add parent in or we'll lose the last row
-		if($parent_first || $query['action'] == 'sp' && is_array($query['action_id'])) $query['total']++;
+		if($parent_first || $query['action'] == 'sp' && is_array($query['action_id']))
+		{
+			$query['total']++;
+		}
 
 		// Check to see if we need to remove description
 		foreach($infos as $id => $info)
@@ -507,7 +556,10 @@ 
 						{
 							foreach(array_keys($main) as $n)
 							{
-								if ($n[0] == '#' && !in_array($n, $columselection)) unset($main[$n]);
+								if ($n[0] == '#' && !in_array($n, $columselection))
+								{
+									unset($main[$n]);
+								}
 							}
 							break;
 						}
@@ -524,8 +576,14 @@ 
 		}
 		unset($links);
 
-		if ($query['cat_id']) $rows['no_cat_id'] = true;
-		if ($query['no_actions']) $rows['no_actions'] = true;
+		if ($query['cat_id'])
+		{
+			$rows['no_cat_id'] = true;
+		}
+		if ($query['no_actions'])
+		{
+			$rows['no_actions'] = true;
+		}
 		$rows['no_timesheet'] = !isset($GLOBALS['egw_info']['user']['apps']['timesheet']);
 		if($clear_status_filter)
 		{
@@ -569,7 +627,11 @@ 
 			$GLOBALS['egw_info']['flags']['app_header'] = implode(': ', $headers);
 		}
 
-		if (isset($linked)) $query['col_filter']['linked'] = $linked;  // add linked back to the colfilter
+		if (isset($linked))
+		{
+			$query['col_filter']['linked'] = $linked;
+		}
+		// add linked back to the colfilter
 
 		return $query['total'];
 	}
@@ -586,7 +648,10 @@ 
 		$set = array();
 		if ((int)$data['id'] && ($info = $this->bo->read($data['id'])))
 		{
-			if ($info['info_cat']) $set['cat_id'] = $info['info_cat'];
+			if ($info['info_cat'])
+			{
+				$set['cat_id'] = $info['info_cat'];
+			}
 			if ($info['info_used_time'])
 			{
 				$set['ts_duration'] = $info['info_used_time'];
@@ -637,7 +702,10 @@ 
 			'end'		=> $infolog['info_enddate'] ? $infolog['info_enddate'] : $infolog['info_datecompleted']
 		));
 		unset($event['entry_id']);
-		if (!$event['end']) $event['end'] = $event['start'] + (int) $GLOBALS['egw_info']['user']['preferences']['calendar']['defaultlength']*60;
+		if (!$event['end'])
+		{
+			$event['end'] = $event['start'] + (int) $GLOBALS['egw_info']['user']['preferences']['calendar']['defaultlength']*60;
+		}
 
 		// Match Api\Categories by name
 		$event['category'] = $GLOBALS['egw']->categories->name2id(Api\Categories::id2name($infolog['info_cat']));
@@ -696,7 +764,10 @@ 
 		// Copy same custom fields
 		foreach(array_keys(Api\Storage\Customfields::get('calendar')) as $name)
 		{
-			if ($this->bo->customfields[$name]) $event['#'.$name] = $infolog['#'.$name];
+			if ($this->bo->customfields[$name])
+			{
+				$event['#'.$name] = $infolog['#'.$name];
+			}
 		}
 		//error_log(__METHOD__.'('.array2string($data).') infolog='.array2string($infolog).' returning '.array2string($event));
 		return $event;
@@ -868,13 +939,19 @@ 
 				$values['nm']['sort'] = 'DESC';
 			}
 
-			if (!$values['nm']['session_for'] && $this->called_by) $values['nm']['session_for'] = $this->called_by;
+			if (!$values['nm']['session_for'] && $this->called_by)
+			{
+				$values['nm']['session_for'] = $this->called_by;
+			}
 
 			$action_id = $values['action_id'] = $action ? $action_id : $nm['action_id'];
 			$action_title = $values['action_title'] = $action ? $action_title : $nm['action_title'];
 			$action = $values['action'] = $action ? $action : $nm['action'];
 		}
-		if($_GET['search']) $values['nm']['search'] = $_GET['search'];
+		if($_GET['search'])
+		{
+			$values['nm']['search'] = $_GET['search'];
+		}
 
 		if ($values['nm']['add'])
 		{
@@ -925,7 +1002,10 @@ 
 		switch ($action)
 		{
 			case 'sp':
-				if (!is_array($action_id) && strpos($action_id, 'infolog:') === 0) $action_id = (int)substr($action_id, 8);
+				if (!is_array($action_id) && strpos($action_id, 'infolog:') === 0)
+				{
+					$action_id = (int)substr($action_id, 8);
+				}
 				if ((is_array($action_id) && !$this->bo->read(current($action_id))) || !$this->bo->read($action_id))
 				{
 					$action = '';
@@ -972,7 +1052,10 @@ 
 		// Allow add actions even when there's no rows
 		$values['nm']['placeholder_actions'] = array('new');
 
-		if(!isset($values['nm']['filter2'])) $values['nm']['filter2'] = $this->prefs['nextmatch-'.($action ? 'infolog.'.$action : 'infolog.index.rows').'-details-pref'];
+		if(!isset($values['nm']['filter2']))
+		{
+			$values['nm']['filter2'] = $this->prefs['nextmatch-'.($action ? 'infolog.'.$action : 'infolog.index.rows').'-details-pref'];
+		}
 
 		// disable columns for main entry as set in the pref for details or no details
 		$values['nm']['columnselection_pref'] = 'nextmatch-'.($action ? 'infolog.'.$action : 'infolog.index.rows')
@@ -997,7 +1080,10 @@ 
 		{
 			foreach (array_keys($values['nm']['col_filter']) as $colfk)
 			{
-				if (is_int($colfk)) unset($values['nm']['col_filter']);
+				if (is_int($colfk))
+				{
+					unset($values['nm']['col_filter']);
+				}
 			}
 		}
 		$values['action'] = $persist['action'] = $values['nm']['action'] = $action;
@@ -1040,7 +1126,10 @@ 
 		// does not take implicit rights as delegated into account, so they will not be available as filters
 		foreach($this->bo->group_owners as $type => $group)
 		{
-			if (!isset($this->bo->grants[$group])) unset($sel_options['info_type'][$type]);
+			if (!isset($this->bo->grants[$group]))
+			{
+				unset($sel_options['info_type'][$type]);
+			}
 		}
 
 
@@ -1421,7 +1510,10 @@ 
 				return $failed == 0;
 
 			case 'document':
-				if (!$settings) $settings = $this->prefs['default_document'];
+				if (!$settings)
+				{
+					$settings = $this->prefs['default_document'];
+				}
 				$document_merge = new infolog_merge();
 				$msg = $document_merge->download($settings, $checked, '', $this->prefs['document_dir']);
 				$failed = count($checked);
@@ -1629,11 +1721,16 @@ 
 			#_debug_array($info);
 			$status = $info['info_status'];
 			// closed stati assumed array('done','billed','cancelled')
-			if (isset($this->bo->status[$info['info_type']]['done'])) {
+			if (isset($this->bo->status[$info['info_type']]['done']))
+			{
 				$status ='done';
-			} elseif (isset($this->bo->status[$info['info_type']]['billed'])) {
+			}
+			elseif (isset($this->bo->status[$info['info_type']]['billed']))
+			{
 				$status ='billed';
-			} elseif (isset($this->bo->status[$info['info_type']]['cancelled'])) {
+			}
+			elseif (isset($this->bo->status[$info['info_type']]['cancelled']))
+			{
 				$status ='cancelled';
 			}
 			#_debug_array($status);
@@ -1647,17 +1744,25 @@ 
 			$this->bo->write($values, true,true,true,$skip_notification);
 
 			$query = array('action'=>'sp','action_id'=>$info_id);
-			if (!$closesingle) {
+			if (!$closesingle)
+			{
 				foreach((array)$this->bo->search($query) as $info)
 				{
-					if ($info['info_id_parent'] == $info_id)	// search also returns linked entries!
+					if ($info['info_id_parent'] == $info_id)
 					{
-						$this->close($info['info_id'],$referer,$closesingle,$skip_notification);	// we call ourselfs recursive to process subs from subs too
+						// search also returns linked entries!
+					{
+						$this->close($info['info_id'],$referer,$closesingle,$skip_notification);
+					}
+					// we call ourselfs recursive to process subs from subs too
 					}
 				}
 			}
 		}
-		if ($referer) $this->tmpl->location($referer);
+		if ($referer)
+		{
+			$this->tmpl->location($referer);
+		}
 	}
 
 	/**
@@ -1673,10 +1778,13 @@ 
 		$info_id = (int) (is_array($values) ? $values['info_id'] : ($values ? $values : $_GET['info_id']));
 		$referer = is_array($values) ? $values['referer'] : $_referer;
 
-		if (!is_array($values) && $info_id > 0 && !$this->bo->anzSubs($info_id))	// entries without subs get confirmed by javascript
+		if (!is_array($values) && $info_id > 0 && !$this->bo->anzSubs($info_id))
+		{
+			// entries without subs get confirmed by javascript
 		{
 			$values = array('delete' => true);
 		}
+		}
 		//echo "<p>infolog_ui::delete(".print_r($values,true).",'$referer','$called_by') info_id=$info_id</p>\n";
 
 		if (is_array($values) || $info_id <= 0)
@@ -1685,11 +1793,16 @@ 
 			{
 				$deleted = $this->bo->delete($info_id,$values['delete_subs'],$values['info_id_parent'], $skip_notification);
 			}
-			if ($called_by)		// direct call from the same request
+			if ($called_by)
+			{
+				// direct call from the same request
 			{
 				return $deleted ? lang('InfoLog entry deleted') : '';
 			}
-			if ($values['called_by'] == 'edit')	// we run in the edit popup => give control back to edit
+			}
+			if ($values['called_by'] == 'edit')
+			{
+				// we run in the edit popup => give control back to edit
 			{
 				$this->edit(array(
 					'info_id' => $info_id,
@@ -1698,6 +1811,7 @@ 
 					'msg'     => $deleted ? lang('Infolog entry deleted') : '',
 				));
 			}
+			}
 			return $referer ? $this->tmpl->location($referer) : $this->index();
 		}
 		$readonlys = $values = array();
@@ -1746,10 +1860,17 @@ 
 			$no_popup  = $content['no_popup'];  unset($content['no_popup']);
 
 			list($button) = @each($content['button']);
-			if (!$button && $action) $button = $action;	// action selectbox
+			if (!$button && $action)
+			{
+				$button = $action;
+			}
+			// action selectbox
 			//info_cc expects an comma separated string
 			//error_log(__METHOD__.__LINE__.array2string($content));
-			if (empty($content['info_cc'])) $content['info_cc'] = "";
+			if (empty($content['info_cc']))
+			{
+				$content['info_cc'] = "";
+			}
 			if (is_array($content['info_cc']))
 			{
 				foreach($content['info_cc'] as $i => $value)
@@ -1759,7 +1880,10 @@ 
 					//error_log(__METHOD__.__LINE__.$value.'->'.array2string($addresses[0]));
 					$content['info_cc'][$i]=$addresses[0]->host ? $addresses[0]->mailbox.'@'.$addresses[0]->host : $addresses[0]->mailbox;
 				}
-				if (!empty($content['info_cc'])) $content['info_cc'] = implode(',',$content['info_cc']);
+				if (!empty($content['info_cc']))
+				{
+					$content['info_cc'] = implode(',',$content['info_cc']);
+				}
 			}
 			unset($content['button']);
 			if ($button)
@@ -1843,9 +1967,12 @@ 
 					$content['link_to']['to_app'] = 'infolog';
 					$content['link_to']['to_id'] = $info_id;
 
-					if ($info_link_id && strpos($info_link_id,':') !== false)	// updating info_link_id if necessary
+					if ($info_link_id && strpos($info_link_id,':') !== false)
+					{
+						// updating info_link_id if necessary
 					{
 						list($app,$id) = explode(':',$info_link_id);
+					}
 						$link = Link::get_link('infolog',$info_id,$app,$id);
 						if ((int) $content['info_link_id'] != (int) $link['link_id'])
 						{
@@ -1875,12 +2002,19 @@ 
 				}
 				elseif ($button == 'delete' && $info_id > 0)
 				{
-					if (!$referer && $action) $referer = array(
+					if (!$referer && $action)
+					{
+						$referer = array(
 						'menuaction' => 'infolog.infolog_ui.index',
 						'action' => $action,
 						'action_id' => $action_id
 					);
-					if (!($content['msg'] = $this->delete($info_id,$referer,'edit'))) return;	// checks ACL first
+					}
+					if (!($content['msg'] = $this->delete($info_id,$referer,'edit')))
+					{
+						return;
+					}
+					// checks ACL first
 
 					Framework::refresh_opener($content['msg'],'infolog',$info_id,'delete');
 				}
@@ -1930,7 +2064,11 @@ 
 			$type      = $type      ? $type      : $_REQUEST['type'];
 			$referer   = $referer !== '' ? $referer : ($_GET['referer'] ? $_GET['referer'] :
 				Api\Header\Referer::get('/index.php?menuaction=infolog.infolog_ui.index'));
-			if (strpos($referer, 'msg=') !== false) $referer = preg_replace('/([&?]{1})msg=[^&]+&?/','\\1',$referer);	// remove previou/old msg from referer
+			if (strpos($referer, 'msg=') !== false)
+			{
+				$referer = preg_replace('/([&?]{1})msg=[^&]+&?/','\\1',$referer);
+			}
+			// remove previou/old msg from referer
 			$no_popup  = $_GET['no_popup'];
 			$print = (int) $_REQUEST['print'];
 			//echo "<p>infolog_ui::edit: info_id=$info_id,  action='$action', action_id='$action_id', type='$type', referer='$referer'</p>\n";
@@ -1947,7 +2085,11 @@ 
 			{
 				$content['info_cat'] = $this->prefs['cat_add_default'];
 			}
-			if ($_GET['msg']) $content['msg'] = strip_tags($_GET['msg']);	// dont allow HTML!
+			if ($_GET['msg'])
+			{
+				$content['msg'] = strip_tags($_GET['msg']);
+			}
+			// dont allow HTML!
 
 			switch($this->prefs['set_start'])
 			{
@@ -1958,13 +2100,19 @@ 
 			if ((int)$content['info_link_id'] > 0 && !Link::get_link($content['info_link_id']))
 			{
 				$content['info_link_id'] = 0;	// link has been deleted
-				if (!$content['info_custom_link']) $content['info_from'] = '';
+				if (!$content['info_custom_link'])
+				{
+					$content['info_from'] = '';
+				}
 			}
-			if (!$info_id && $action_id && $action == 'sp')    // new SubProject
+			if (!$info_id && $action_id && $action == 'sp')
+			{
+				// new SubProject
 			{
 				if (!$this->bo->check_access($action_id,Acl::ADD))
 				{
 					return $referer ? $this->tmpl->location($referer) : $this->index(0,$action,$action_id);
+			}
 				}
 			}
 			else
@@ -1998,10 +2146,16 @@ 
 				case 'copy':
 					$info_id = 0;
 					$this->create_copy($content, $action == 'sp');
-					if ($action == 'sp')	// for sub-entries use type or category, like for new entries
+					if ($action == 'sp')
+					{
+						// for sub-entries use type or category, like for new entries
 					{
 						if ($type) $content['info_type'] = $type;
-						if (is_numeric($_REQUEST['cat_id'])) $content['info_cat'] = (int) $_REQUEST['cat_id'];
+					}
+						if (is_numeric($_REQUEST['cat_id']))
+						{
+							$content['info_cat'] = (int) $_REQUEST['cat_id'];
+						}
 					}
 					unset($action);	// it get stored in $content and will cause an other copy after [apply]
 					break;
@@ -2030,7 +2184,10 @@ 
 						{
 							foreach((array)$set['link_app'] as $i => $l_app)
 							{
-								if (($l_id=$set['link_id'][$i])) Link::link('infolog',$content['link_to']['to_id'],$l_app,$l_id);
+								if (($l_id=$set['link_id'][$i]))
+								{
+									Link::link('infolog',$content['link_to']['to_id'],$l_app,$l_id);
+								}
 							}
 							unset($set['link_app']);
 							unset($set['link_id']);
@@ -2049,8 +2206,15 @@ 
 						break;	// normal edit
 					}
 				case 'new':		// new entry, set some defaults, if not set by infolog_set hook
-					if (empty($content['info_startdate'])) $content['info_startdate'] = (int) $_GET['startdate'] ? (int) $_GET['startdate'] : $set_startdate;
-					if (empty($content['info_priority'])) $content['info_priority'] = 1; // normal
+					if (empty($content['info_startdate']))
+					{
+						$content['info_startdate'] = (int) $_GET['startdate'] ? (int) $_GET['startdate'] : $set_startdate;
+					}
+					if (empty($content['info_priority']))
+					{
+						$content['info_priority'] = 1;
+					}
+					// normal
 					$content['info_owner'] = $this->user;
 					if ($type != '' && empty($content['info_type']))
 					{
@@ -2060,8 +2224,14 @@ 
 					{
 						$content['info_type'] = $GLOBALS['egw_info']['user']['preferences']['infolog']['preferred_type'];
 					}
-					if (empty($content['info_status'])) $content['info_status'] = $this->bo->status['defaults'][$content['info_type']];
-					if (empty($content['info_percent'])) $content['info_percent'] = $content['info_status'] == 'done' ? '100%' : '0%';
+					if (empty($content['info_status']))
+					{
+						$content['info_status'] = $this->bo->status['defaults'][$content['info_type']];
+					}
+					if (empty($content['info_percent']))
+					{
+						$content['info_percent'] = $content['info_status'] == 'done' ? '100%' : '0%';
+					}
 					break;
 			}
 			if (!isset($this->bo->enums['type'][$content['info_type']]))
@@ -2165,7 +2335,10 @@ 
 
 		$content['duration_format'] = $this->duration_format;
 		$content['hours_per_workday'] = $this->hours_per_workday;
-		if ($this->prefs['show_id']) $content['info_number'] = $info_id;
+		if ($this->prefs['show_id'])
+		{
+			$content['info_number'] = $info_id;
+		}
 
 		// Check no notification preference, update if type changed
 		if($content['info_type'] != $content['old_type'])
@@ -2256,7 +2429,10 @@ 
 		//$content['info_des'] = substr($content['info_des'],0,1793);
 		//echo "<p>infolog_ui.edit(info_id='$info_id',action='$action',action_id='$action_id') readonlys="; print_r($readonlys); echo ", content = "; _debug_array($content);
 		//$content['info_cc'] is expected (by the widget) to be an array of emailaddresses, but is stored as comma separated string
-		if (!empty($content['info_cc'])&&!is_array($content['info_cc']))$content['info_cc'] = explode(',',$content['info_cc']);
+		if (!empty($content['info_cc'])&&!is_array($content['info_cc']))
+		{
+			$content['info_cc'] = explode(',',$content['info_cc']);
+		}
 		$preserve = array_merge( $preserv, array(	// preserved values
 			'info_id'       => $info_id,
 			'action'        => $action,
@@ -2286,7 +2462,11 @@ 
 		foreach ($exclude_fields as $field)
 		{
 			unset($content[$field]);
-			if ($field == 'info_from') unset($content['info_link_id']);	// both together is called contact in UI
+			if ($field == 'info_from')
+			{
+				unset($content['info_link_id']);
+			}
+			// both together is called contact in UI
 		}
 		if ($create_sub)
 		{
@@ -2314,13 +2494,25 @@ 
 			$content['info_type'] = $types[0];
 		}
 		// get a consistent status, percent and date-completed
-		if (!isset($content['info_status'])) $content['info_status'] = $this->bo->status['defaults'][$content['info_type']];
-		if (!isset($content['info_percent'])) $content['info_percent'] = $content['info_status'] == 'done' ? '100%' : '0%';
+		if (!isset($content['info_status']))
+		{
+			$content['info_status'] = $this->bo->status['defaults'][$content['info_type']];
+		}
+		if (!isset($content['info_percent']))
+		{
+			$content['info_percent'] = $content['info_status'] == 'done' ? '100%' : '0%';
+		}
 		$content['info_datecompleted'] =$content['info_status'] == 'done' ? $this->bo->user_time_now : 0;
 
-		if (!isset($content['info_cat'])) $content['info_cat'] = $this->prefs['cat_add_default'];
+		if (!isset($content['info_cat']))
+		{
+			$content['info_cat'] = $this->prefs['cat_add_default'];
+		}
 
-		if(!is_array($content['link_to'])) $content['link_to'] = array();
+		if(!is_array($content['link_to']))
+		{
+			$content['link_to'] = array();
+		}
 		$content['link_to']['to_app'] = 'infolog';
 		$content['link_to']['to_id'] = 0;
 		// Get links to be copied, if not excluded
@@ -2658,7 +2850,10 @@ 
 		}
 		foreach($this->bo->customfields as $name => $data)
 		{
-			if ($data['type2'] && $type && !in_array($type,explode(',',$data['type2']))) continue;
+			if ($data['type2'] && $type && !in_array($type,explode(',',$data['type2'])))
+			{
+				continue;
+			}
 
 			$fields['#'.$name] = array(
 				'label' => $data['label'],

infolog/inc/class.infolog_wizard_import_infologs_csv.inc.php

Spacing +14 added lines, -14 removed lines

@@ -34,7 +34,7 @@ 
 		// List each custom field
 		unset($this->mapping_fields['custom']);
 		$custom = Api\Storage\Customfields::get('infolog');
-		foreach($custom as $name => $data) {
+		foreach ($custom as $name => $data) {
 			$this->mapping_fields['#'.$name] = $data['label'];
 		}
 
@@ -62,20 +62,20 @@ 
 	# Skipped for now (or forever)
 	function wizard_step60(&$content, &$sel_options, &$readonlys, &$preserv)
 	{
-		if($this->debug) error_log(__METHOD__.'->$content '.print_r($content,true));
+		if ($this->debug) error_log(__METHOD__.'->$content '.print_r($content, true));
 		unset($content['no_owner_map']);
 		// Check that record owner has access
 		$access = true;
-		if($content['record_owner'])
+		if ($content['record_owner'])
 		{
 			$bo = new infolog_bo();
-			$access = $bo->check_access(0,Acl::EDIT, $content['record_owner']);
+			$access = $bo->check_access(0, Acl::EDIT, $content['record_owner']);
 		}
 
 		// return from step60
 		if ($content['step'] == 'wizard_step60')
 		{
-			if(!$access) {
+			if (!$access) {
 				$step = $content['step'];
 				unset($content['step']);
 				return $step;
@@ -83,34 +83,34 @@ 
 			switch (array_search('pressed', $content['button']))
 			{
 				case 'next':
-					return $GLOBALS['egw']->importexport_definitions_ui->get_step($content['step'],1);
+					return $GLOBALS['egw']->importexport_definitions_ui->get_step($content['step'], 1);
 				case 'previous' :
-					return $GLOBALS['egw']->importexport_definitions_ui->get_step($content['step'],-1);
+					return $GLOBALS['egw']->importexport_definitions_ui->get_step($content['step'], -1);
 				case 'finish':
 					return 'wizard_finish';
 				default :
-					return $this->wizard_step60($content,$sel_options,$readonlys,$preserv);
+					return $this->wizard_step60($content, $sel_options, $readonlys, $preserv);
 			}
 		}
 		// init step60
 		else
 		{
 			$content['msg'] = $this->steps['wizard_step60'];
-			if(!$access) {
-				$content['msg'] .= "\n* " . lang('Owner does not have edit rights');
+			if (!$access) {
+				$content['msg'] .= "\n* ".lang('Owner does not have edit rights');
 			}
 			$content['step'] = 'wizard_step60';
-			if(!array_key_exists($content['record_owner']) && $content['plugin_options']) {
+			if (!array_key_exists($content['record_owner']) && $content['plugin_options']) {
 				$content['record_owner'] = $content['plugin_options']['record_owner'];
 			}
-			if(!array_key_exists($content['owner_from_csv']) && $content['plugin_options']) {
+			if (!array_key_exists($content['owner_from_csv']) && $content['plugin_options']) {
 				$content['owner_from_csv'] = $content['plugin_options']['owner_from_csv'];
 			}
-			if(!array_key_exists($content['change_owner']) && $content['plugin_options']) {
+			if (!array_key_exists($content['change_owner']) && $content['plugin_options']) {
 				$content['change_owner'] = $content['plugin_options']['change_owner'];
 			}
 
-			if(!in_array('info_owner', $content['field_mapping'])) {
+			if (!in_array('info_owner', $content['field_mapping'])) {
 				$content['no_owner_map'] = true;
 			}
 

Braces +18 added lines, -8 removed lines

@@ -34,7 +34,8 @@ 
 		// List each custom field
 		unset($this->mapping_fields['custom']);
 		$custom = Api\Storage\Customfields::get('infolog');
-		foreach($custom as $name => $data) {
+		foreach($custom as $name => $data)
+		{
 			$this->mapping_fields['#'.$name] = $data['label'];
 		}
 
@@ -62,7 +63,10 @@ 
 	# Skipped for now (or forever)
 	function wizard_step60(&$content, &$sel_options, &$readonlys, &$preserv)
 	{
-		if($this->debug) error_log(__METHOD__.'->$content '.print_r($content,true));
+		if($this->debug)
+		{
+			error_log(__METHOD__.'->$content '.print_r($content,true));
+		}
 		unset($content['no_owner_map']);
 		// Check that record owner has access
 		$access = true;
@@ -75,7 +79,8 @@ 
 		// return from step60
 		if ($content['step'] == 'wizard_step60')
 		{
-			if(!$access) {
+			if(!$access)
+			{
 				$step = $content['step'];
 				unset($content['step']);
 				return $step;
@@ -96,21 +101,26 @@ 
 		else
 		{
 			$content['msg'] = $this->steps['wizard_step60'];
-			if(!$access) {
+			if(!$access)
+			{
 				$content['msg'] .= "\n* " . lang('Owner does not have edit rights');
 			}
 			$content['step'] = 'wizard_step60';
-			if(!array_key_exists($content['record_owner']) && $content['plugin_options']) {
+			if(!array_key_exists($content['record_owner']) && $content['plugin_options'])
+			{
 				$content['record_owner'] = $content['plugin_options']['record_owner'];
 			}
-			if(!array_key_exists($content['owner_from_csv']) && $content['plugin_options']) {
+			if(!array_key_exists($content['owner_from_csv']) && $content['plugin_options'])
+			{
 				$content['owner_from_csv'] = $content['plugin_options']['owner_from_csv'];
 			}
-			if(!array_key_exists($content['change_owner']) && $content['plugin_options']) {
+			if(!array_key_exists($content['change_owner']) && $content['plugin_options'])
+			{
 				$content['change_owner'] = $content['plugin_options']['change_owner'];
 			}
 
-			if(!in_array('info_owner', $content['field_mapping'])) {
+			if(!in_array('info_owner', $content['field_mapping']))
+			{
 				$content['no_owner_map'] = true;
 			}
 

infolog/inc/class.infolog_ical.inc.php

Indentation +16 added lines, -16 removed lines

@@ -67,10 +67,10 @@ 
 	var $productName = '';
 
 	/**
-	* Shall we use the UID extensions of the description field?
-	*
-	* @var boolean
-	*/
+	 * Shall we use the UID extensions of the description field?
+	 *
+	 * @var boolean
+	 */
 	var $uidExtension = false;
 
 	/**
@@ -509,10 +509,10 @@ 
 	 * @param boolean $merge =false	merge data with existing entry (no longer used)
 	 * @param int $user =null delegate new task to this account_id, default null
 	 * @param string $charset =null The encoding charset for $text. Defaults to
-     *                         utf-8 for new format, iso-8859-1 for old format.
-     * @param string $caldav_name =null CalDAV URL name-part for new entries
-     * @param array $callback_data =null array with callback and further parameters, first param is task to save
-     * 	signature array callback($task, $param1, ...)
+	 *                         utf-8 for new format, iso-8859-1 for old format.
+	 * @param string $caldav_name =null CalDAV URL name-part for new entries
+	 * @param array $callback_data =null array with callback and further parameters, first param is task to save
+	 * 	signature array callback($task, $param1, ...)
 	 * @return int|boolean integer info_id or false on error
 	 */
 	function importVTODO(&$_vcalData, $_taskID=-1, $merge=false, $user=null, $charset=null, $caldav_name=null,
@@ -597,7 +597,7 @@ 
 	 * @param int $contentID =null 	infolog_id (or null, if unkown)
 	 * @param boolean $relax =false 	if true, a weaker match algorithm is used
 	 * @param string $charset  The encoding charset for $text. Defaults to
-     *                         utf-8 for new format, iso-8859-1 for old format.
+	 *                         utf-8 for new format, iso-8859-1 for old format.
 	 *
 	 * @return array of infolog_ids of matching entries
 	 */
@@ -642,8 +642,8 @@ 
 	 * @param string $_vcalData 	VTODO data
 	 * @param int $_taskID =-1		infolog_id of the entry
 	 * @param string $charset  The encoding charset for $text. Defaults to
-     *                         utf-8 for new format, iso-8859-1 for old format.
-     *
+	 *                         utf-8 for new format, iso-8859-1 for old format.
+	 *
 	 * @return array infolog entry or false on error
 	 */
 	function vtodotoegw($_vcalData, $_taskID=-1, $charset=null)
@@ -1010,8 +1010,8 @@ 
 	 * @param int $_noteID =-1 info_id, default -1 = new entry
 	 * @param boolean $merge =false	merge data with existing entry (no longer used)
 	 * @param string $charset  The encoding charset for $text. Defaults to
-     *                         utf-8 for new format, iso-8859-1 for old format.
-     *
+	 *                         utf-8 for new format, iso-8859-1 for old format.
+	 *
 	 * @return int|boolean integer info_id or false on error
 	 */
 	function importVNOTE(&$_vcalData, $_type, $_noteID=-1, $merge=false, $charset=null)
@@ -1045,7 +1045,7 @@ 
 	 * @param int $contentID=null 	infolog_id (or null, if unkown)
 	 * @param boolean $relax=false 	if true, a weaker match algorithm is used
 	 * @param string $charset  The encoding charset for $text. Defaults to
-     *                         utf-8 for new format, iso-8859-1 for old format.
+	 *                         utf-8 for new format, iso-8859-1 for old format.
 	 *
 	 * @return infolog_id of a matching entry or false, if nothing was found
 	 */
@@ -1067,8 +1067,8 @@ 
 	 * @param string $_type		content type (eg.g text/plain)
 	 * @param int $_noteID =-1	infolog_id of the entry
 	 * @param string $charset  The encoding charset for $text. Defaults to
-     *                         utf-8 for new format, iso-8859-1 for old format.
-     *
+	 *                         utf-8 for new format, iso-8859-1 for old format.
+	 *
 	 * @return array infolog entry or false on error
 	 */
 	function vnotetoegw($_data, $_type, $_noteID=-1, $charset=null)

Spacing +125 added lines, -126 removed lines

@@ -23,39 +23,39 @@ 
 	 * @var array $priority_egw2ical conversion of the priority egw => ical
 	 */
 	var $priority_egw2ical = array(
-		0 => 9,		// low
-		1 => 5,		// normal
-		2 => 3,		// high
-		3 => 1,		// urgent
+		0 => 9, // low
+		1 => 5, // normal
+		2 => 3, // high
+		3 => 1, // urgent
 	);
 
 	/**
 	 * @var array $priority_ical2egw conversion of the priority ical => egw
 	 */
 	var $priority_ical2egw = array(
-		9 => 0,	8 => 0, 7 => 0,	// low
-		6 => 1, 5 => 1, 4 => 1, 0 => 1,	// normal
-		3 => 2,	2 => 2,	// high
-		1 => 3,			// urgent
+		9 => 0, 8 => 0, 7 => 0, // low
+		6 => 1, 5 => 1, 4 => 1, 0 => 1, // normal
+		3 => 2, 2 => 2, // high
+		1 => 3, // urgent
 	);
 
 	/**
 	 * @var array $priority_egw2funambol conversion of the priority egw => funambol
 	 */
 	var $priority_egw2funambol = array(
-		0 => 0,		// low
-		1 => 1,		// normal
-		2 => 2,		// high
-		3 => 2,		// urgent
+		0 => 0, // low
+		1 => 1, // normal
+		2 => 2, // high
+		3 => 2, // urgent
 	);
 
 	/**
 	 * @var array $priority_funambol2egw conversion of the priority funambol => egw
 	 */
 	var $priority_funambol2egw = array(
-		0 => 0,		// low
-		1 => 1,		// normal
-		2 => 3,		// high
+		0 => 0, // low
+		1 => 1, // normal
+		2 => 3, // high
 	);
 
 	/**
@@ -93,7 +93,7 @@ 
 	 * @var boolean
 	 */
 	var $log = false;
-	var $logfile="/tmp/log-infolog-vcal";
+	var $logfile = "/tmp/log-infolog-vcal";
 
 
 	/**
@@ -117,11 +117,11 @@ 
 	 * @param string $charset ='UTF-8'
 	 * @return string|boolean string with vCal or false on error (eg. no permission to read the event)
 	 */
-	function exportVCalendar(array $tasks, $_version='2.0', $_method=null, $charset='UTF-8')
+	function exportVCalendar(array $tasks, $_version = '2.0', $_method = null, $charset = 'UTF-8')
 	{
 		$vcal = new Horde_Icalendar;
 
-		foreach($tasks as $task)
+		foreach ($tasks as $task)
 		{
 			if (!$this->exportVTODO($task, $_version, $_method, $charset, $vcal))
 			{
@@ -142,7 +142,7 @@ 
 	 *
 	 * @return string|boolean string with vCal or false on error (eg. no permission to read the event)
 	 */
-	function exportVTODO($task, $_version='2.0',$_method='PUBLISH', $charset='UTF-8',Horde_Icalendar $vcal=null)
+	function exportVTODO($task, $_version = '2.0', $_method = 'PUBLISH', $charset = 'UTF-8', Horde_Icalendar $vcal = null)
 	{
 		if (is_array($task))
 		{
@@ -167,10 +167,10 @@ 
 		{
 			if (!preg_match('/\[UID:.+\]/m', $taskData['info_des']))
 			{
-				$taskData['info_des'] .= "\n[UID:" . $taskData['info_uid'] . "]";
+				$taskData['info_des'] .= "\n[UID:".$taskData['info_uid']."]";
 				if ($taskData['info_id_parent'] != '')
 				{
-					$taskData['info_des'] .= "\n[PARENT_UID:" . $taskData['info_id_parent'] . "]";
+					$taskData['info_des'] .= "\n[PARENT_UID:".$taskData['info_id_parent']."]";
 				}
 			}
 		}
@@ -186,15 +186,15 @@ 
 
 		if ($this->log)
 		{
-			error_log(__FILE__.'['.__LINE__.'] '.__METHOD__."()\n" .
-				array2string($taskData)."\n",3,$this->logfile);
+			error_log(__FILE__.'['.__LINE__.'] '.__METHOD__."()\n".
+				array2string($taskData)."\n", 3, $this->logfile);
 		}
 
 		if (!isset($vcal)) $vcal = new Horde_Icalendar;
-		$vcal->setAttribute('PRODID','-//EGroupware//NONSGML EGroupware InfoLog '.$GLOBALS['egw_info']['apps']['infolog']['version'].'//'.
-			strtoupper($GLOBALS['egw_info']['user']['preferences']['common']['lang']),array(),false);
-		$vcal->setAttribute('VERSION',$_version,array(),false);
-		if ($_method) $vcal->setAttribute('METHOD',$_method,array(),false);
+		$vcal->setAttribute('PRODID', '-//EGroupware//NONSGML EGroupware InfoLog '.$GLOBALS['egw_info']['apps']['infolog']['version'].'//'.
+			strtoupper($GLOBALS['egw_info']['user']['preferences']['common']['lang']), array(), false);
+		$vcal->setAttribute('VERSION', $_version, array(), false);
+		if ($_method) $vcal->setAttribute('METHOD', $_method, array(), false);
 
 		$tzid = $this->tzid;
 		if ($tzid && $tzid != 'UTC')
@@ -212,7 +212,7 @@ 
 			}
 		}
 
-		$vevent = Horde_Icalendar::newComponent('VTODO',$vcal);
+		$vevent = Horde_Icalendar::newComponent('VTODO', $vcal);
 
 		if (!isset($this->clientProperties['SUMMARY']['Size']))
 		{
@@ -236,9 +236,9 @@ 
 				$noTruncate = $this->clientProperties[$field]['NoTruncate'];
 				if ($this->log && $size > 0)
 				{
-					error_log(__FILE__.'['.__LINE__.'] '.__METHOD__ .
-						"() $field Size: $size, NoTruncate: " .
-						($noTruncate ? 'TRUE' : 'FALSE') . "\n",3,$this->logfile);
+					error_log(__FILE__.'['.__LINE__.'] '.__METHOD__.
+						"() $field Size: $size, NoTruncate: ".
+						($noTruncate ? 'TRUE' : 'FALSE')."\n", 3, $this->logfile);
 				}
 				//Horde::logMessage("VTODO $field Size: $size, NoTruncate: " .
 				//	($noTruncate ? 'TRUE' : 'FALSE'), __FILE__, __LINE__, PEAR_LOG_DEBUG);
@@ -255,19 +255,19 @@ 
 				{
 					if ($this->log)
 					{
-						error_log(__FILE__.'['.__LINE__.'] '.__METHOD__ .
-							"() $field omitted due to maximum size $size\n",3,$this->logfile);
+						error_log(__FILE__.'['.__LINE__.'] '.__METHOD__.
+							"() $field omitted due to maximum size $size\n", 3, $this->logfile);
 					}
 					//Horde::logMessage("VTODO $field omitted due to maximum size $size",
 					//	__FILE__, __LINE__, PEAR_LOG_WARNING);
 					continue; // skip field
 				}
 				// truncate the value to size
-				$value = substr($value, 0, $size -1);
+				$value = substr($value, 0, $size - 1);
 				if ($this->log)
 				{
-					error_log(__FILE__.'['.__LINE__.'] '.__METHOD__ .
-						"() $field truncated to maximum size $size\n",3,$this->logfile);
+					error_log(__FILE__.'['.__LINE__.'] '.__METHOD__.
+						"() $field truncated to maximum size $size\n", 3, $this->logfile);
 				}
 				//Horde::logMessage("VTODO $field truncated to maximum size $size",
 				//	__FILE__, __LINE__, PEAR_LOG_INFO);
@@ -286,7 +286,7 @@ 
 
 			if ($_version == '1.0' && preg_match('/[^\x20-\x7F]/', $value))
 			{
-				$options['CHARSET']	= $charset;
+				$options['CHARSET'] = $charset;
 				switch ($this->productManufacturer)
 				{
 					case 'groupdav':
@@ -328,23 +328,23 @@ 
 			self::setDateOrTime($vevent, 'COMPLETED', $taskData['info_datecompleted'], $tzid);
 		}
 
-		$vevent->setAttribute('DTSTAMP',time());
+		$vevent->setAttribute('DTSTAMP', time());
 		$vevent->setAttribute('CREATED', $taskData['info_created']);
 		$vevent->setAttribute('LAST-MODIFIED', $taskData['info_datemodified']);
-		$vevent->setAttribute('CLASS',$taskData['info_access'] == 'public' ? 'PUBLIC' : 'PRIVATE');
-		$vevent->setAttribute('STATUS',$this->status2vtodo($taskData['info_status']));
+		$vevent->setAttribute('CLASS', $taskData['info_access'] == 'public' ? 'PUBLIC' : 'PRIVATE');
+		$vevent->setAttribute('STATUS', $this->status2vtodo($taskData['info_status']));
 		// we try to preserv the original infolog status as X-INFOLOG-STATUS, so we can restore it, if the user does not modify STATUS
-		$vevent->setAttribute('X-INFOLOG-STATUS',$taskData['info_status']);
-		$vevent->setAttribute('PERCENT-COMPLETE',$taskData['info_percent']);
+		$vevent->setAttribute('X-INFOLOG-STATUS', $taskData['info_status']);
+		$vevent->setAttribute('PERCENT-COMPLETE', $taskData['info_percent']);
 		if ($this->productManufacturer == 'funambol' &&
 			(strpos($this->productName, 'outlook') !== false
 				|| strpos($this->productName, 'pocket pc') !== false))
 		{
-			$priority = (int) $this->priority_egw2funambol[$taskData['info_priority']];
+			$priority = (int)$this->priority_egw2funambol[$taskData['info_priority']];
 		}
 		else
 		{
-			$priority = (int) $this->priority_egw2ical[$taskData['info_priority']];
+			$priority = (int)$this->priority_egw2ical[$taskData['info_priority']];
 		}
 		$vevent->setAttribute('PRIORITY', $priority);
 
@@ -353,7 +353,7 @@ 
 			(count($taskData['info_responsible']) > 1 ||
 				$taskData['info_responsible'][0] != $taskData['info_onwer']))
 		{
-			if (($url = $GLOBALS['egw']->accounts->id2name($taskData['info_owner'],'account_email')))
+			if (($url = $GLOBALS['egw']->accounts->id2name($taskData['info_owner'], 'account_email')))
 			{
 				$url = 'MAILTO:'.$url;
 			}
@@ -361,13 +361,13 @@ 
 			{
 				$url = 'urn:uuid:'.Api\CalDAV::generate_uid('accounts', $taskData['info_owner']);
 			}
-			$vevent->setAttribute('ORGANIZER',$url,array(
-				'CN'		=>	$GLOBALS['egw']->accounts->id2name($taskData['info_owner'],'account_fullname'),
+			$vevent->setAttribute('ORGANIZER', $url, array(
+				'CN'		=>	$GLOBALS['egw']->accounts->id2name($taskData['info_owner'], 'account_fullname'),
 				'X-EGROUPWARE-UID'	=> $taskData['info_owner'],
 			), true);
-			foreach($taskData['info_responsible'] as $responsible)
+			foreach ($taskData['info_responsible'] as $responsible)
 			{
-				if (($url = $GLOBALS['egw']->accounts->id2name($responsible,'account_email')))
+				if (($url = $GLOBALS['egw']->accounts->id2name($responsible, 'account_email')))
 				{
 					$url = 'MAILTO:'.$url;
 				}
@@ -377,15 +377,15 @@ 
 				}
 				if ($responsible > 0)
 				{
-					$vevent->setAttribute('ATTENDEE',$url,array(
-						'CN'		=>	$GLOBALS['egw']->accounts->id2name($responsible,'account_fullname'),
+					$vevent->setAttribute('ATTENDEE', $url, array(
+						'CN'		=>	$GLOBALS['egw']->accounts->id2name($responsible, 'account_fullname'),
 						'CUTYPE'	=> 'INDIVIDUAL',
 						'X-EGROUPWARE-UID'	=> $responsible,
 					), true);
 				}
 				elseif ($responsible < 0)
 				{
-					$vevent->setAttribute('ATTENDEE',$url,array(
+					$vevent->setAttribute('ATTENDEE', $url, array(
 						'CN'		=>	$GLOBALS['egw']->accounts->id2name($responsible),
 						'CUTYPE'	=> 'GROUP',
 						'X-EGROUPWARE-UID'	=> $responsible,
@@ -396,17 +396,17 @@ 
 		// for CalDAV add all X-Properties previously parsed
 		if ($this->productManufacturer == 'groupdav')
 		{
-			foreach($taskData as $name => $value)
+			foreach ($taskData as $name => $value)
 			{
 				if (substr($name, 0, 2) == '##')
 				{
 					if ($name[2] == ':')
 					{
 						if (($v = json_php_unserialize($value)) && is_array($v)) $value = $v;
-						foreach((array)$value as $compvData)
+						foreach ((array)$value as $compvData)
 						{
-							$comp = Horde_Icalendar::newComponent(substr($name,3), $vevent);
-							$comp->parsevCalendar($compvData,substr($name,3));
+							$comp = Horde_Icalendar::newComponent(substr($name, 3), $vevent);
+							$comp->parsevCalendar($compvData, substr($name, 3));
 							$vevent->addComponent($comp);
 						}
 					}
@@ -426,8 +426,8 @@ 
 		$retval = $vcal->exportvCalendar();
 		if ($this->log)
 		{
-			error_log(__FILE__.'['.__LINE__.'] '.__METHOD__."()\n" .
-				array2string($retval)."\n",3,$this->logfile);
+			error_log(__FILE__.'['.__LINE__.'] '.__METHOD__."()\n".
+				array2string($retval)."\n", 3, $this->logfile);
 		}
 		// Horde::logMessage("exportVTODO:\n" . print_r($retval, true),
 		//	__FILE__, __LINE__, PEAR_LOG_DEBUG);
@@ -456,7 +456,7 @@ 
 			}
 			$tz = self::$tz_cache[$tzid];
 		}
-		elseif(is_null($tzid))
+		elseif (is_null($tzid))
 		{
 			$tz = Api\DateTime::$user_timezone;
 		}
@@ -464,9 +464,9 @@ 
 		{
 			$tz = Api\DateTime::$server_timezone;
 		}
-		if (!is_a($time,'DateTime'))
+		if (!is_a($time, 'DateTime'))
 		{
-			$time = new Api\DateTime($time,Api\DateTime::$server_timezone);
+			$time = new Api\DateTime($time, Api\DateTime::$server_timezone);
 		}
 		$time->setTimezone($tz);
 
@@ -515,16 +515,16 @@ 
      * 	signature array callback($task, $param1, ...)
 	 * @return int|boolean integer info_id or false on error
 	 */
-	function importVTODO(&$_vcalData, $_taskID=-1, $merge=false, $user=null, $charset=null, $caldav_name=null,
-		array $callback_data=null)
+	function importVTODO(&$_vcalData, $_taskID = -1, $merge = false, $user = null, $charset = null, $caldav_name = null,
+		array $callback_data = null)
 	{
-		unset($merge);	// no longer used, but required by function signature
+		unset($merge); // no longer used, but required by function signature
 
 		if ($this->tzid)
 		{
 			date_default_timezone_set($this->tzid);
 		}
-		$taskData = $this->vtodotoegw($_vcalData,$_taskID, $charset);
+		$taskData = $this->vtodotoegw($_vcalData, $_taskID, $charset);
 		if ($this->tzid)
 		{
 			date_default_timezone_set($GLOBALS['egw_info']['server']['server_timezone']);
@@ -555,8 +555,8 @@ 
 
 		if ($this->log)
 		{
-			error_log(__FILE__.'['.__LINE__.'] '.__METHOD__."()\n" .
-				array2string($taskData)."\n",3,$this->logfile);
+			error_log(__FILE__.'['.__LINE__.'] '.__METHOD__."()\n".
+				array2string($taskData)."\n", 3, $this->logfile);
 		}
 
 		if ($caldav_name)
@@ -565,18 +565,18 @@ 
 		}
 
 		// make sure not to empty fields not supported by iCal or not allowed to change by CalDAV
-		if ($_taskID > 0 && ($old = $this->read($_taskID,true,'server')))
+		if ($_taskID > 0 && ($old = $this->read($_taskID, true, 'server')))
 		{
 			// remove all values supported by iCal standard
 			$old = array_diff_key($old, array_flip(array(
-				'info_subject','info_des','info_location','info_cat','info_responsible',
-				'info_startdate','info_enddate','info_priority','info_location',
-				'info_access','info_status','info_percent','info_datecompleted',
+				'info_subject', 'info_des', 'info_location', 'info_cat', 'info_responsible',
+				'info_startdate', 'info_enddate', 'info_priority', 'info_location',
+				'info_access', 'info_status', 'info_percent', 'info_datecompleted',
 			)));
 			// remove all iCal fields not supported by EGroupware (stored like custom fields)
-			foreach(array_keys($old) as $name)
+			foreach (array_keys($old) as $name)
 			{
-				if (substr($name,0,2) == '##') unset($old[$name]);
+				if (substr($name, 0, 2) == '##') unset($old[$name]);
 			}
 			// merge in again all infolog fields not supported by iCal or not allowed to change
 			$taskData = array_merge($taskData, $old);
@@ -601,7 +601,7 @@ 
 	 *
 	 * @return array of infolog_ids of matching entries
 	 */
-	function searchVTODO($_vcalData, $contentID=null, $relax=false, $charset=null)
+	function searchVTODO($_vcalData, $contentID = null, $relax = false, $charset = null)
 	{
 		$result = array();
 
@@ -646,12 +646,12 @@ 
      *
 	 * @return array infolog entry or false on error
 	 */
-	function vtodotoegw($_vcalData, $_taskID=-1, $charset=null)
+	function vtodotoegw($_vcalData, $_taskID = -1, $charset = null)
 	{
 		if ($this->log)
 		{
-			error_log(__FILE__.'['.__LINE__.'] '.__METHOD__."($_taskID)\n" .
-				array2string($_vcalData)."\n",3,$this->logfile);
+			error_log(__FILE__.'['.__LINE__.'] '.__METHOD__."($_taskID)\n".
+				array2string($_vcalData)."\n", 3, $this->logfile);
 		}
 
 		$vcal = new Horde_Icalendar;
@@ -664,7 +664,7 @@ 
 			if ($this->log)
 			{
 				error_log(__FILE__.'['.__LINE__.'] '.__METHOD__.
-					"(): No vCalendar Container found!\n",3,$this->logfile);
+					"(): No vCalendar Container found!\n", 3, $this->logfile);
 			}
 			return false;
 		}
@@ -687,7 +687,7 @@ 
 				if ($this->log)
 				{
 					error_log(__FILE__.'['.__LINE__.'] '.__METHOD__.
-						"(): Not a vTODO container, skipping...\n",3,$this->logfile);
+						"(): Not a vTODO container, skipping...\n", 3, $this->logfile);
 				}
 				continue;
 			}
@@ -714,24 +714,23 @@ 
 					($this->_status2vtodo[$x_infolog_status] === 'COMPLETED') != is_scalar($completed))
 				{
 					$percent_completed = $component->getAttributeDefault('PERCENT-COMPLETE', null);
-					$status = $completed && is_scalar($completed) ? 'COMPLETED' :
-						($percent_completed && is_scalar($percent_completed) && $percent_completed > 0 ? 'IN-PROCESS' : 'NEEDS-ACTION');
+					$status = $completed && is_scalar($completed) ? 'COMPLETED' : ($percent_completed && is_scalar($percent_completed) && $percent_completed > 0 ? 'IN-PROCESS' : 'NEEDS-ACTION');
 					$component->setAttribute('STATUS', $status);
 					if (!is_scalar($percent_completed))
 					{
 						$component->setAttribute('PERCENT-COMPLETE', $percent_completed = $status == 'COMPLETED' ?
 							100 : ($status == 'NEEDS-ACTION' ? 0 : 10));
 					}
-					if ($this->log) error_log(__METHOD__."() setting STATUS='$status' and PERCENT-COMPLETE=$percent_completed from COMPLETED and X-INFOLOG-STATUS='$x_infolog_status'\n",3,$this->logfile);
+					if ($this->log) error_log(__METHOD__."() setting STATUS='$status' and PERCENT-COMPLETE=$percent_completed from COMPLETED and X-INFOLOG-STATUS='$x_infolog_status'\n", 3, $this->logfile);
 				}
 				// new task without status --> set a default status of NEEDS-ACTION, as otherwise task is marked closed
-				elseif($_taskID <= 0 && !is_scalar($x_infolog_status) && !is_scalar($completed))
+				elseif ($_taskID <= 0 && !is_scalar($x_infolog_status) && !is_scalar($completed))
 				{
 					$component->setAttribute('STATUS', 'NEEDS-ACTION');
 				}
 				else
 				{
-					if ($this->log) error_log(__METHOD__."() no STATUS, X-INFOLOG-STATUS='$x_infolog_status', COMPLETED".(is_scalar($completed)?'='.$completed:' not set')." --> leaving status and percent unchanged",3,$this->logfile);
+					if ($this->log) error_log(__METHOD__."() no STATUS, X-INFOLOG-STATUS='$x_infolog_status', COMPLETED".(is_scalar($completed) ? '='.$completed : ' not set')." --> leaving status and percent unchanged", 3, $this->logfile);
 				}
 			}
 			foreach ($component->getAllAttributes() as $attribute)
@@ -775,7 +774,7 @@ 
 					case 'DURATION':
 						if (!isset($taskData['info_startdate']))
 						{
-							$taskData['info_startdate']	= $component->getAttributeDefault('DTSTART', null);
+							$taskData['info_startdate'] = $component->getAttributeDefault('DTSTART', null);
 						}
 						$attribute['value'] += $taskData['info_startdate'];
 						$taskData['##DURATION'] = $attribute['value'];
@@ -787,11 +786,11 @@ 
 						break;
 
 					case 'COMPLETED':
-						$taskData['info_datecompleted']	= self::date2ts($attribute['value']);
+						$taskData['info_datecompleted'] = self::date2ts($attribute['value']);
 						break;
 
 					case 'DTSTART':
-						$taskData['info_startdate']	= self::date2ts($attribute['value']);
+						$taskData['info_startdate'] = self::date2ts($attribute['value']);
 						break;
 
 					case 'PRIORITY':
@@ -801,16 +800,16 @@ 
 								(strpos($this->productName, 'outlook') !== false
 									|| strpos($this->productName, 'pocket pc') !== false))
 							{
-								$taskData['info_priority'] = (int) $this->priority_funambol2egw[$attribute['value']];
+								$taskData['info_priority'] = (int)$this->priority_funambol2egw[$attribute['value']];
 							}
 							else
 							{
-								$taskData['info_priority'] = (int) $this->priority_ical2egw[$attribute['value']];
+								$taskData['info_priority'] = (int)$this->priority_ical2egw[$attribute['value']];
 							}
 						}
 						else
 						{
-							$taskData['info_priority'] = 1;	// default = normal
+							$taskData['info_priority'] = 1; // default = normal
 						}
 						break;
 
@@ -833,7 +832,7 @@ 
 					case 'CATEGORIES':
 						if (!empty($attribute['value']))
 						{
-							$cats = $this->find_or_add_categories(explode(',',$attribute['value']), $_taskID);
+							$cats = $this->find_or_add_categories(explode(',', $attribute['value']), $_taskID);
 							$taskData['info_cat'] = $cats[0];
 						}
 						break;
@@ -846,7 +845,7 @@ 
 						break;
 
 					case 'PERCENT-COMPLETE':
-						$taskData['info_percent'] = (int) $attribute['value'];
+						$taskData['info_percent'] = (int)$attribute['value'];
 						break;
 
 					case 'ATTENDEE':
@@ -888,10 +887,10 @@ 
 			break;
 		}
 		// store included, but unsupported components like valarm as x-properties
-		foreach($component->getComponents() as $comp)
+		foreach ($component->getComponents() as $comp)
 		{
 			$name = '##:'.strtoupper($comp->getType());
-			$compvData = $comp->exportvCalendar($comp,'utf-8');
+			$compvData = $comp->exportvCalendar($comp, 'utf-8');
 			if (isset($taskData[$name]))
 			{
 				$taskData[$name] = array($taskData[$name]);
@@ -904,8 +903,8 @@ 
 		}
 		if ($this->log)
 		{
-			error_log(__FILE__.'['.__LINE__.'] '.__METHOD__."($_taskID)\n" .
-				($taskData ? array2string($taskData) : 'FALSE') . "\n",3,$this->logfile);
+			error_log(__FILE__.'['.__LINE__.'] '.__METHOD__."($_taskID)\n".
+				($taskData ? array2string($taskData) : 'FALSE')."\n", 3, $this->logfile);
 		}
 		return $taskData;
 	}
@@ -919,14 +918,14 @@ 
 	 *
 	 * @return string|boolean VNOTE representation of the infolog entry or false on error
 	 */
-	function exportVNOTE($_noteID, $_type, $charset='UTF-8')
+	function exportVNOTE($_noteID, $_type, $charset = 'UTF-8')
 	{
-		if(!($note = $this->read($_noteID, true, 'server'))) return false;
+		if (!($note = $this->read($_noteID, true, 'server'))) return false;
 
 		$note = Api\Translation::convert($note,
 			Api\Translation::charset(), $charset);
 
-		switch	($_type)
+		switch ($_type)
 		{
 			case 'text/plain':
 				$txt = $note['info_subject']."\n\n".$note['info_des'];
@@ -940,10 +939,10 @@ 
 						Api\Translation::charset(), $charset);
 				}
 				$vnote = new Horde_Icalendar_Vnote();
-				$vnote->setAttribute('PRODID','-//EGroupware//NONSGML EGroupware InfoLog '.$GLOBALS['egw_info']['apps']['infolog']['version'].'//'.
+				$vnote->setAttribute('PRODID', '-//EGroupware//NONSGML EGroupware InfoLog '.$GLOBALS['egw_info']['apps']['infolog']['version'].'//'.
 					strtoupper($GLOBALS['egw_info']['user']['preferences']['common']['lang']));
 				$vnote->setAttribute('VERSION', '1.1');
-				foreach (array(	'SUMMARY'		=> $note['info_subject'],
+				foreach (array('SUMMARY'		=> $note['info_subject'],
 								'BODY'			=> $note['info_des'],
 								'CATEGORIES'	=> $note['info_cat'],
 							) as $field => $value)
@@ -951,7 +950,7 @@ 
 					$options = array();
 					if (preg_match('/[^\x20-\x7F]/', $value))
 					{
-						$options['CHARSET']	= $charset;
+						$options['CHARSET'] = $charset;
 						switch ($this->productManufacturer)
 						{
 							case 'groupdav':
@@ -981,21 +980,21 @@ 
 				}
 				if ($note['info_startdate'])
 				{
-					$vnote->setAttribute('CREATED',$note['info_startdate']);
+					$vnote->setAttribute('CREATED', $note['info_startdate']);
 				}
 				else
 				{
-					$vnote->setAttribute('CREATED',$GLOBALS['egw']->contenthistory->getTSforAction('infolog_note',$_noteID,'add'));
+					$vnote->setAttribute('CREATED', $GLOBALS['egw']->contenthistory->getTSforAction('infolog_note', $_noteID, 'add'));
 				}
-				$vnote->setAttribute('LAST-MODIFIED',$GLOBALS['egw']->contenthistory->getTSforAction('infolog_note',$_noteID,'modify'));
+				$vnote->setAttribute('LAST-MODIFIED', $GLOBALS['egw']->contenthistory->getTSforAction('infolog_note', $_noteID, 'modify'));
 
 				#$vnote->setAttribute('CLASS',$taskData['info_access'] == 'public' ? 'PUBLIC' : 'PRIVATE');
 
 				$retval = $vnote->exportvCalendar();
 				if ($this->log)
 				{
-					error_log(__FILE__.'['.__LINE__.'] '.__METHOD__."()\n" .
-						array2string($retval)."\n",3,$this->logfile);
+					error_log(__FILE__.'['.__LINE__.'] '.__METHOD__."()\n".
+						array2string($retval)."\n", 3, $this->logfile);
 				}
 				return $retval;
 		}
@@ -1014,25 +1013,25 @@ 
      *
 	 * @return int|boolean integer info_id or false on error
 	 */
-	function importVNOTE(&$_vcalData, $_type, $_noteID=-1, $merge=false, $charset=null)
+	function importVNOTE(&$_vcalData, $_type, $_noteID = -1, $merge = false, $charset = null)
 	{
-		unset($merge);	// no longer used, but required by function signature
+		unset($merge); // no longer used, but required by function signature
 		if ($this->log)
 		{
-			error_log(__FILE__.'['.__LINE__.'] '.__METHOD__."()\n" .
-				array2string($_vcalData)."\n",3,$this->logfile);
+			error_log(__FILE__.'['.__LINE__.'] '.__METHOD__."()\n".
+				array2string($_vcalData)."\n", 3, $this->logfile);
 		}
 
 		if (!($note = $this->vnotetoegw($_vcalData, $_type, $_noteID, $charset))) return false;
 
-		if($_noteID > 0) $note['info_id'] = $_noteID;
+		if ($_noteID > 0) $note['info_id'] = $_noteID;
 
 		if (empty($note['info_status'])) $note['info_status'] = 'done';
 
 		if ($this->log)
 		{
-			error_log(__FILE__.'['.__LINE__.'] '.__METHOD__."()\n" .
-				array2string($note)."\n",3,$this->logfile);
+			error_log(__FILE__.'['.__LINE__.'] '.__METHOD__."()\n".
+				array2string($note)."\n", 3, $this->logfile);
 		}
 
 		return $this->write($note, true, true, false);
@@ -1049,7 +1048,7 @@ 
 	 *
 	 * @return infolog_id of a matching entry or false, if nothing was found
 	 */
-	function searchVNOTE($_vcalData, $_type, $contentID=null, $relax=false, $charset=null)
+	function searchVNOTE($_vcalData, $_type, $contentID = null, $relax = false, $charset = null)
 	{
 		if (!($note = $this->vnotetoegw($_vcalData, $_type, $contentID, $charset))) return array();
 
@@ -1071,12 +1070,12 @@ 
      *
 	 * @return array infolog entry or false on error
 	 */
-	function vnotetoegw($_data, $_type, $_noteID=-1, $charset=null)
+	function vnotetoegw($_data, $_type, $_noteID = -1, $charset = null)
 	{
 		if ($this->log)
 		{
-			error_log(__FILE__.'['.__LINE__.'] '.__METHOD__."($_type, $_noteID)\n" .
-				array2string($_data)."\n",3,$this->logfile);
+			error_log(__FILE__.'['.__LINE__.'] '.__METHOD__."($_type, $_noteID)\n".
+				array2string($_data)."\n", 3, $this->logfile);
 		}
 		$note = false;
 
@@ -1130,7 +1129,7 @@ 
 								case 'CATEGORIES':
 									if ($attribute['value'])
 									{
-										$cats = $this->find_or_add_categories(explode(',',$attribute['value']), $_noteID);
+										$cats = $this->find_or_add_categories(explode(',', $attribute['value']), $_noteID);
 										$note['info_cat'] = $cats[0];
 									}
 									break;
@@ -1141,8 +1140,8 @@ 
 		}
 		if ($this->log)
 		{
-			error_log(__FILE__.'['.__LINE__.'] '.__METHOD__."($_type, $_noteID)\n" .
-				($note ? array2string($note) : 'FALSE') ."\n",3,$this->logfile);
+			error_log(__FILE__.'['.__LINE__.'] '.__METHOD__."($_type, $_noteID)\n".
+				($note ? array2string($note) : 'FALSE')."\n", 3, $this->logfile);
 		}
 		return $note;
 	}
@@ -1155,7 +1154,7 @@ 
 	 * @param string $_productManufacturer
 	 * @param string $_productName
 	 */
-	function setSupportedFields($_productManufacturer='', $_productName='')
+	function setSupportedFields($_productManufacturer = '', $_productName = '')
 	{
 		$state = &$_SESSION['SyncML.state'];
 		if (isset($state))
@@ -1207,10 +1206,10 @@ 
 		if ($this->log)
 		{
 			error_log(__FILE__.'['.__LINE__.'] '.__METHOD__.
-				'(' . $this->productManufacturer .
-				', '. $this->productName .', ' .
-				($this->tzid ? $this->tzid : Api\DateTime::$user_timezone->getName()) .
-				")\n" , 3, $this->logfile);
+				'('.$this->productManufacturer.
+				', '.$this->productName.', '.
+				($this->tzid ? $this->tzid : Api\DateTime::$user_timezone->getName()).
+				")\n", 3, $this->logfile);
 		}
 
 		//Horde::logMessage('setSupportedFields(' . $this->productManufacturer . ', '

Braces +72 added lines, -18 removed lines

@@ -104,7 +104,10 @@ 
 	function __construct(&$_clientProperties = array())
 	{
 		parent::__construct();
-		if ($this->log) $this->logfile = $GLOBALS['egw_info']['server']['temp_dir']."/log-infolog-vcal";
+		if ($this->log)
+		{
+			$this->logfile = $GLOBALS['egw_info']['server']['temp_dir']."/log-infolog-vcal";
+		}
 		$this->clientProperties = $_clientProperties;
 	}
 
@@ -150,7 +153,10 @@ 
 		}
 		else
 		{
-			if (!($taskData = $this->read($task, true, 'server'))) return false;
+			if (!($taskData = $this->read($task, true, 'server')))
+			{
+				return false;
+			}
 		}
 
 		if ($taskData['info_id_parent'])
@@ -190,11 +196,17 @@ 
 				array2string($taskData)."\n",3,$this->logfile);
 		}
 
-		if (!isset($vcal)) $vcal = new Horde_Icalendar;
+		if (!isset($vcal))
+		{
+			$vcal = new Horde_Icalendar;
+		}
 		$vcal->setAttribute('PRODID','-//EGroupware//NONSGML EGroupware InfoLog '.$GLOBALS['egw_info']['apps']['infolog']['version'].'//'.
 			strtoupper($GLOBALS['egw_info']['user']['preferences']['common']['lang']),array(),false);
 		$vcal->setAttribute('VERSION',$_version,array(),false);
-		if ($_method) $vcal->setAttribute('METHOD',$_method,array(),false);
+		if ($_method)
+		{
+			$vcal->setAttribute('METHOD',$_method,array(),false);
+		}
 
 		$tzid = $this->tzid;
 		if ($tzid && $tzid != 'UTC')
@@ -273,7 +285,10 @@ 
 				//	__FILE__, __LINE__, PEAR_LOG_INFO);
 			}
 
-			if (empty($value) && ($size < 0 || $noTruncate)) continue;
+			if (empty($value) && ($size < 0 || $noTruncate))
+			{
+				continue;
+			}
 
 			if ($field == 'RELATED-TO')
 			{
@@ -402,7 +417,10 @@ 
 				{
 					if ($name[2] == ':')
 					{
-						if (($v = json_php_unserialize($value)) && is_array($v)) $value = $v;
+						if (($v = json_php_unserialize($value)) && is_array($v))
+						{
+							$value = $v;
+						}
 						foreach((array)$value as $compvData)
 						{
 							$comp = Horde_Icalendar::newComponent(substr($name,3), $vevent);
@@ -530,7 +548,10 @@ 
 			date_default_timezone_set($GLOBALS['egw_info']['server']['server_timezone']);
 		}
 
-		if (!$taskData) return false;
+		if (!$taskData)
+		{
+			return false;
+		}
 
 		// keep the dates
 		$this->time2time($taskData, $this->tzid, false);
@@ -576,7 +597,10 @@ 
 			// remove all iCal fields not supported by EGroupware (stored like custom fields)
 			foreach(array_keys($old) as $name)
 			{
-				if (substr($name,0,2) == '##') unset($old[$name]);
+				if (substr($name,0,2) == '##')
+				{
+					unset($old[$name]);
+				}
 			}
 			// merge in again all infolog fields not supported by iCal or not allowed to change
 			$taskData = array_merge($taskData, $old);
@@ -722,7 +746,10 @@ 
 						$component->setAttribute('PERCENT-COMPLETE', $percent_completed = $status == 'COMPLETED' ?
 							100 : ($status == 'NEEDS-ACTION' ? 0 : 10));
 					}
-					if ($this->log) error_log(__METHOD__."() setting STATUS='$status' and PERCENT-COMPLETE=$percent_completed from COMPLETED and X-INFOLOG-STATUS='$x_infolog_status'\n",3,$this->logfile);
+					if ($this->log)
+					{
+						error_log(__METHOD__."() setting STATUS='$status' and PERCENT-COMPLETE=$percent_completed from COMPLETED and X-INFOLOG-STATUS='$x_infolog_status'\n",3,$this->logfile);
+					}
 				}
 				// new task without status --> set a default status of NEEDS-ACTION, as otherwise task is marked closed
 				elseif($_taskID <= 0 && !is_scalar($x_infolog_status) && !is_scalar($completed))
@@ -731,12 +758,18 @@ 
 				}
 				else
 				{
-					if ($this->log) error_log(__METHOD__."() no STATUS, X-INFOLOG-STATUS='$x_infolog_status', COMPLETED".(is_scalar($completed)?'='.$completed:' not set')." --> leaving status and percent unchanged",3,$this->logfile);
+					if ($this->log)
+					{
+						error_log(__METHOD__."() no STATUS, X-INFOLOG-STATUS='$x_infolog_status', COMPLETED".(is_scalar($completed)?'='.$completed:' not set')." --> leaving status and percent unchanged",3,$this->logfile);
+					}
 				}
 			}
 			foreach ($component->getAllAttributes() as $attribute)
 			{
-				if (!$attribute['value'] && $attribute['value'] !== '0') continue;
+				if (!$attribute['value'] && $attribute['value'] !== '0')
+				{
+					continue;
+				}
 
 				switch ($attribute['name'])
 				{
@@ -921,7 +954,10 @@ 
 	 */
 	function exportVNOTE($_noteID, $_type, $charset='UTF-8')
 	{
-		if(!($note = $this->read($_noteID, true, 'server'))) return false;
+		if(!($note = $this->read($_noteID, true, 'server')))
+		{
+			return false;
+		}
 
 		$note = Api\Translation::convert($note,
 			Api\Translation::charset(), $charset);
@@ -1023,11 +1059,20 @@ 
 				array2string($_vcalData)."\n",3,$this->logfile);
 		}
 
-		if (!($note = $this->vnotetoegw($_vcalData, $_type, $_noteID, $charset))) return false;
+		if (!($note = $this->vnotetoegw($_vcalData, $_type, $_noteID, $charset)))
+		{
+			return false;
+		}
 
-		if($_noteID > 0) $note['info_id'] = $_noteID;
+		if($_noteID > 0)
+		{
+			$note['info_id'] = $_noteID;
+		}
 
-		if (empty($note['info_status'])) $note['info_status'] = 'done';
+		if (empty($note['info_status']))
+		{
+			$note['info_status'] = 'done';
+		}
 
 		if ($this->log)
 		{
@@ -1051,9 +1096,15 @@ 
 	 */
 	function searchVNOTE($_vcalData, $_type, $contentID=null, $relax=false, $charset=null)
 	{
-		if (!($note = $this->vnotetoegw($_vcalData, $_type, $contentID, $charset))) return array();
+		if (!($note = $this->vnotetoegw($_vcalData, $_type, $contentID, $charset)))
+		{
+			return array();
+		}
 
-		if ($contentID)	$note['info_id'] = $contentID;
+		if ($contentID)
+		{
+			$note['info_id'] = $contentID;
+		}
 
 		unset($note['info_startdate']);
 
@@ -1105,7 +1156,10 @@ 
 				{
 					$_data = Api\Translation::convert($_data, $charset, 'utf-8');
 				}
-				if (!$vnote->parsevCalendar($_data, 'VCALENDAR'))	return false;
+				if (!$vnote->parsevCalendar($_data, 'VCALENDAR'))
+				{
+					return false;
+				}
 
 				$components = $vnote->getComponent();
 				foreach ($components as $component)

Doc Comments +4 added lines, -5 removed lines

@@ -112,7 +112,7 @@ 
 	 * @param string $_version ='2.0'
 	 * @param string $_method =null only set for iTip messages
 	 * @param string $charset ='UTF-8'
-	 * @return string|boolean string with vCal or false on error (eg. no permission to read the event)
+	 * @return false|string string with vCal or false on error (eg. no permission to read the event)
 	 */
 	function exportVCalendar(array $tasks, $_version='2.0', $_method=null, $charset='UTF-8')
 	{
@@ -137,7 +137,7 @@ 
 	 * @param string $charset ='UTF-8' encoding of the vcalendar, default UTF-8
 	 * @param Horde_Icalendar $vcal =null optional iCalendar object to add vtodo to
 	 *
-	 * @return string|boolean string with vCal or false on error (eg. no permission to read the event)
+	 * @return false|string string with vCal or false on error (eg. no permission to read the event)
 	 */
 	function exportVTODO($task, $_version='2.0',$_method='PUBLISH', $charset='UTF-8',Horde_Icalendar $vcal=null)
 	{
@@ -916,7 +916,7 @@ 
 	 * @param string $_type		content type (e.g. text/plain)
 	 * @param string $charset ='UTF-8' encoding of the vcalendar, default UTF-8
 	 *
-	 * @return string|boolean VNOTE representation of the infolog entry or false on error
+	 * @return false|string VNOTE representation of the infolog entry or false on error
 	 */
 	function exportVNOTE($_noteID, $_type, $charset='UTF-8')
 	{
@@ -1041,8 +1041,7 @@ 
 	 * Search a matching infolog entry for the VNOTE data
 	 *
 	 * @param string $_vcalData		VNOTE
-	 * @param int $contentID=null 	infolog_id (or null, if unkown)
-	 * @param boolean $relax=false 	if true, a weaker match algorithm is used
+	 * @param int $contentID 	infolog_id (or null, if unkown)
 	 * @param string $charset  The encoding charset for $text. Defaults to
      *                         utf-8 for new format, iso-8859-1 for old format.
 	 *

infolog/index.php

Spacing +3 added lines, -3 removed lines

@@ -23,10 +23,10 @@
 if ($setup_info['infolog']['version'] != $GLOBALS['egw_info']['apps']['infolog']['version'])
 {
 	$GLOBALS['egw']->framework->render('<p style="text-align: center; color:red; font-weight: bold;">'.lang('Your database is NOT up to date (%1 vs. %2), please run %3setup%4 to update your database.',
-		$setup_info['infolog']['version'],$GLOBALS['egw_info']['apps']['infolog']['version'],
-		'<a href="../setup/">','</a>')."</p>\n");
+		$setup_info['infolog']['version'], $GLOBALS['egw_info']['apps']['infolog']['version'],
+		'<a href="../setup/">', '</a>')."</p>\n");
 	exit();
 }
 unset($setup_info);
 
-ExecMethod('infolog.infolog_ui.index','reset_action_view');
+ExecMethod('infolog.infolog_ui.index', 'reset_action_view');

preferences/inc/class.preferences_hooks.inc.php

Spacing +10 added lines, -10 removed lines

@@ -81,7 +81,7 @@ 
 		);
 
 		$account_display = array(
-			'firstname' => lang('Firstname'). ' '.lang('Lastname'),
+			'firstname' => lang('Firstname').' '.lang('Lastname'),
 			'lastname'  => lang('Lastname').', '.lang('Firstname'),
 			'username'  => lang('username'),
 			'firstall'  => lang('Firstname').' '.lang('Lastname').' ['.lang('username').']',
@@ -95,7 +95,7 @@ 
 			$lang = setup::get_lang();
 		}
 		if (empty($lang)) $lang = 'en';
-		list(,$country) = explode('-',$lang);
+		list(,$country) = explode('-', $lang);
 		if (empty($country) && class_exists('Locale')) $country = Locale::getRegion(Locale::getDefault());
 		if (empty($country)) $country = 'de';
 		
@@ -104,7 +104,7 @@ 
 			substr($GLOBALS['egw_info']['user']['preferences']['common']['rte_font_size'], -2) == 'px')
 		{
 			$prefs = $GLOBALS['egw']->preferences;
-			foreach(array('user','default','forced') as $type)
+			foreach (array('user', 'default', 'forced') as $type)
 			{
 				if (substr($prefs->{$type}['common']['rte_font_size'], -2) == 'px')
 				{
@@ -131,7 +131,7 @@ 
 				'size'  => 3,
 				'xmlrpc' => True,
 				'admin'  => False,
-				'forced' => 20,	// hidden as not used in eTemplate2
+				'forced' => 20, // hidden as not used in eTemplate2
 			),
 			'template_set' => array(
 				'type'   => 'select',
@@ -157,7 +157,7 @@ 
 				'type'   => 'select',
 				'label'  => 'Audio effect',
 				'name'   => 'audio_effect',
-				'values' => array('0'=>lang('Disable'),'1'=>lang('Enable')),
+				'values' => array('0'=>lang('Disable'), '1'=>lang('Enable')),
 				'help'   => 'Audio effect enables|disables sound effects used in the theme',
 				'xmlrpc' => True,
 				'admin'  => False,
@@ -278,7 +278,7 @@ 
 				'type'   => 'multiselect',
 				'label'  => 'Permanent time zone selection',
 				'name'   => 'tz_selection',
-				'values' => $tzs ? call_user_func_array('array_merge',$tzs) : null,	// only flat arrays supported
+				'values' => $tzs ? call_user_func_array('array_merge', $tzs) : null, // only flat arrays supported
 				'help'   => 'Please select timezones, you want to be able to quickly switch between. Switch is NOT shown, if less then two are selected.',
 				'xmlrpc' => True,
 				'admin'  => False,
@@ -409,7 +409,7 @@ 
 				'type'   => 'select',
 				'label'  => 'Features of the editor',
 				'name'   => 'rte_features',
-				'values' => array('simple'=>'simple','extended'=>'regular','advanced'=>'everything'),
+				'values' => array('simple'=>'simple', 'extended'=>'regular', 'advanced'=>'everything'),
 				'help'   => 'How many toolbar buttons are available',
 				'admin'  => false,
 				'default'=> 'extended'
@@ -430,7 +430,7 @@ 
 	{
 		$account_id = (int)$data['account_id'];
 
-		if($account_id > 0)	// user
+		if ($account_id > 0)	// user
 		{
 			$GLOBALS['egw']->preferences->delete_user($account_id);
 		}
@@ -462,10 +462,10 @@ 
 	 */
 	static function admin($args)
 	{
-		unset($args);	// unused, but required by function signature
+		unset($args); // unused, but required by function signature
 		$appname = 'preferences';
 		$file = Array(
-			'Site configuration' => Egw::link('/index.php','menuaction=admin.admin_config.index&appname=' . $appname.'&ajax=true'),
+			'Site configuration' => Egw::link('/index.php', 'menuaction=admin.admin_config.index&appname='.$appname.'&ajax=true'),
 		);
 		display_section($appname, $file);
 	}

Braces +28 added lines, -7 removed lines

@@ -90,14 +90,26 @@ 
 			'all'       => '['.lang('username').'] '.lang('Lastname').','.lang('Firstname'),
 		);
 
-		if ($hook_data['setup'])	// called via setup
+		if ($hook_data['setup'])
+		{
+			// called via setup
 		{
 			$lang = setup::get_lang();
 		}
-		if (empty($lang)) $lang = 'en';
+		}
+		if (empty($lang))
+		{
+			$lang = 'en';
+		}
 		list(,$country) = explode('-',$lang);
-		if (empty($country) && class_exists('Locale')) $country = Locale::getRegion(Locale::getDefault());
-		if (empty($country)) $country = 'de';
+		if (empty($country) && class_exists('Locale'))
+		{
+			$country = Locale::getRegion(Locale::getDefault());
+		}
+		if (empty($country))
+		{
+			$country = 'de';
+		}
 		
 		// check for old rte_font_size pref including px and split it in size and unit
 		if (!isset($GLOBALS['egw_setup']) &&
@@ -416,7 +428,10 @@ 
 			),
 		);
 		// disable thumbnails, if no size configured by admin
-		if (!$GLOBALS['egw_info']['server']['link_list_thumbnail']) unset($settings['link_list_thumbnail']);
+		if (!$GLOBALS['egw_info']['server']['link_list_thumbnail'])
+		{
+			unset($settings['link_list_thumbnail']);
+		}
 
 		return $settings;
 	}
@@ -430,14 +445,20 @@ 
 	{
 		$account_id = (int)$data['account_id'];
 
-		if($account_id > 0)	// user
+		if($account_id > 0)
+		{
+			// user
 		{
 			$GLOBALS['egw']->preferences->delete_user($account_id);
 		}
-		elseif ($account_id < 0)	// group
+		}
+		elseif ($account_id < 0)
+		{
+			// group
 		{
 			$GLOBALS['egw']->preferences->delete_group($account_id);
 		}
+		}
 	}
 
 	/**

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -464,7 +464,7 @@
 	{
 		unset($args);	// unused, but required by function signature
 		$appname = 'preferences';
-		$file = Array(
+		$file = array(
 			'Site configuration' => Egw::link('/index.php','menuaction=admin.admin_config.index&appname=' . $appname.'&ajax=true'),
 		);
 		display_section($appname, $file);