EGroupware / egroupware

api/src/Db/Exception.php

Spacing +2 added lines, -2 removed lines

@@ -27,10 +27,10 @@
 	 * @param string $msg =null message, default "Database error!"
 	 * @param int $code =100
 	 */
-	function __construct($msg=null,$code=100)
+	function __construct($msg = null, $code = 100)
 	{
 		if (is_null($msg)) $msg = lang('Database error!');
 
-		parent::__construct($msg,$code);
+		parent::__construct($msg, $code);
 	}
 }

Braces +4 added lines, -1 removed lines

@@ -29,7 +29,10 @@
 	 */
 	function __construct($msg=null,$code=100)
 	{
-		if (is_null($msg)) $msg = lang('Database error!');
+		if (is_null($msg))
+		{
+			$msg = lang('Database error!');
+		}
 
 		parent::__construct($msg,$code);
 	}

api/src/Egw/Base.php

Spacing +4 added lines, -4 removed lines

@@ -64,12 +64,12 @@ 
 	 */
 	static $sub_objects = array(
 		'log' => 'errorlog',
-		'link' => 'bolink',		// depricated use static egw_link methods
+		'link' => 'bolink', // depricated use static egw_link methods
 		'datetime' => 'egw_datetime',
 		// classes moved to new api dir
 		'template' => true,
 		'applications' => 'EGroupware\\Api\\Egw\\Applications',
-		'framework' => true,	// special handling in __get()
+		'framework' => true, // special handling in __get()
 		'ldap' => true,
 	);
 
@@ -95,7 +95,7 @@ 
 	{
 		//error_log(__METHOD__."($name)".function_backtrace());
 
-		if ($name == 'js') $name = 'framework';	// javascript class is integrated now into framework
+		if ($name == 'js') $name = 'framework'; // javascript class is integrated now into framework
 
 		if (isset($this->$name))
 		{
@@ -107,7 +107,7 @@ 
 			if ($name != 'ADOdb') error_log(__METHOD__.": There's NO $name object! ".function_backtrace());
 			return null;
 		}
-		switch($name)
+		switch ($name)
 		{
 			case 'framework':
 				return $this->framework = Api\Framework::factory();

Braces +13 added lines, -3 removed lines

@@ -95,7 +95,11 @@ 
 	{
 		//error_log(__METHOD__."($name)".function_backtrace());
 
-		if ($name == 'js') $name = 'framework';	// javascript class is integrated now into framework
+		if ($name == 'js')
+		{
+			$name = 'framework';
+		}
+		// javascript class is integrated now into framework
 
 		if (isset($this->$name))
 		{
@@ -104,7 +108,10 @@ 
 
 		if (!isset(self::$sub_objects[$name]) && !class_exists('EGroupware\\Api\\'.ucfirst($name)) && !class_exists($name))
 		{
-			if ($name != 'ADOdb') error_log(__METHOD__.": There's NO $name object! ".function_backtrace());
+			if ($name != 'ADOdb')
+			{
+				error_log(__METHOD__.": There's NO $name object! ".function_backtrace());
+			}
 			return null;
 		}
 		switch($name)
@@ -121,7 +128,10 @@ 
 				return $this->ldap = Api\Ldap::factory(false);
 			default:
 				$class = isset(self::$sub_objects[$name]) ? self::$sub_objects[$name] : 'EGroupware\\Api\\'.ucfirst($name);
-				if (!class_exists($class)) $class = $name;
+				if (!class_exists($class))
+				{
+					$class = $name;
+				}
 				break;
 		}
 		return $this->$name = new $class();

api/src/Contacts/Univention.php

Spacing +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
 	 * @param array $keys if given $keys are copied to data before saveing => allows a save as
 	 * @return int 0 on success and errno != 0 else
 	 */
-	function save($keys=null)
+	function save($keys = null)
 	{
 		// UCS lowercases email when storing
 		$keys['email'] = strtolower(!empty($keys['email']) ? $keys['email'] : $this->data['email']);

api/src/Contacts/Ldap.php

Indentation +17 added lines, -17 removed lines

@@ -41,33 +41,33 @@ 
 	var $contacts_id='id';
 
 	/**
-	* @var string $accountName holds the accountname of the current user
-	*/
+	 * @var string $accountName holds the accountname of the current user
+	 */
 	var $accountName;
 
 	/**
-	* @var object $ldapServerInfo holds the information about the current used ldap server
-	*/
+	 * @var object $ldapServerInfo holds the information about the current used ldap server
+	 */
 	var $ldapServerInfo;
 
 	/**
-	* @var int $ldapLimit how many rows to fetch from ldap server
-	*/
+	 * @var int $ldapLimit how many rows to fetch from ldap server
+	 */
 	var $ldapLimit = 2000;
 
 	/**
-	* @var string $personalContactsDN holds the base DN for the personal addressbooks
-	*/
+	 * @var string $personalContactsDN holds the base DN for the personal addressbooks
+	 */
 	var $personalContactsDN;
 
 	/**
-	* @var string $sharedContactsDN holds the base DN for the shared addressbooks
-	*/
+	 * @var string $sharedContactsDN holds the base DN for the shared addressbooks
+	 */
 	var $sharedContactsDN;
 
 	/**
-	* @var string $accountContactsDN holds the base DN for accounts addressbook
-	*/
+	 * @var string $accountContactsDN holds the base DN for accounts addressbook
+	 */
 	var $accountContactsDN;
 
 	/**
@@ -77,8 +77,8 @@ 
 	var $accountsFilter = '(objectclass=posixaccount)';
 
 	/**
-	* @var string $allContactsDN holds the base DN of all addressbook
-	*/
+	 * @var string $allContactsDN holds the base DN of all addressbook
+	 */
 	var $allContactsDN;
 
 	/**
@@ -96,8 +96,8 @@ 
 	var $never_change_dn = false;
 
 	/**
-	* @var int $total holds the total count of found rows
-	*/
+	 * @var int $total holds the total count of found rows
+	 */
 	var $total;
 
 	/**
@@ -403,7 +403,7 @@ 
 	 *
 	 * @param string|array $contact_id contact_id or array with values for id or account_id
 	 * @return array/boolean data if row could be retrived else False
-	*/
+	 */
 	function read($contact_id)
 	{
 		if (is_array($contact_id) && isset($contact_id['account_id']) ||

Doc Comments -1 removed lines

@@ -213,7 +213,6 @@
 	/**
 	 * Remove attributes we are not allowed to update
 	 *
-	 * @param array $attributes
 	 */
 	function sanitize_update(array &$ldapContact)
 	{

Spacing +183 added lines, -185 removed lines

@@ -38,7 +38,7 @@ 
 	 *
 	 * @var string
 	 */
-	var $contacts_id='id';
+	var $contacts_id = 'id';
 
 	/**
 	* @var string $accountName holds the accountname of the current user
@@ -86,7 +86,7 @@ 
 	 *
 	 * @var string
 	 */
-	var $dn_attribute='uid';
+	var $dn_attribute = 'uid';
 
 	/**
 	 * Do NOT attempt to change DN (dn-attribute can NOT be part of schemas used in addressbook!)
@@ -113,9 +113,9 @@ 
 	 * minimum: $this->columns_to_search = array('n_family','n_given','org_name','email');
 	 */
 	var $search_attributes = array(
-		'n_family','n_middle','n_given','org_name','org_unit',
-		'adr_one_locality','adr_two_locality','note',
-		'email','mozillasecondemail','uidnumber',
+		'n_family', 'n_middle', 'n_given', 'org_name', 'org_unit',
+		'adr_one_locality', 'adr_two_locality', 'note',
+		'email', 'mozillasecondemail', 'uidnumber',
 	);
 
 	/**
@@ -171,8 +171,8 @@ 
 		#postOfficeBox
 		'mozillaabpersonalpha' => array(
 			'adr_one_street2'	=> 'mozillaworkstreet2',
-			'adr_one_countryname'	=> 'c',	// 2 letter country code
-			'adr_one_countrycode'	=> 'c',	// 2 letter country code
+			'adr_one_countryname'	=> 'c', // 2 letter country code
+			'adr_one_countrycode'	=> 'c', // 2 letter country code
 			'adr_two_street'	=> 'mozillahomestreet',
 			'adr_two_street2'	=> 'mozillahomestreet2',
 			'adr_two_locality'	=> 'mozillahomelocalityname',
@@ -186,8 +186,8 @@ 
 		// similar to the newer mozillaAbPerson, but uses mozillaPostalAddress2 instead of mozillaStreet2
 		'mozillaorgperson' => array(
 			'adr_one_street2'	=> 'mozillapostaladdress2',
-			'adr_one_countrycode'	=> 'c',	// 2 letter country code
-			'adr_one_countryname'	=> 'co',	// human readable country name, must be after 'c' to take precedence on read!
+			'adr_one_countrycode'	=> 'c', // 2 letter country code
+			'adr_one_countryname'	=> 'co', // human readable country name, must be after 'c' to take precedence on read!
 			'adr_two_street'	=> 'mozillahomestreet',
 			'adr_two_street2'	=> 'mozillahomepostaladdress2',
 			'adr_two_locality'	=> 'mozillahomelocalityname',
@@ -213,7 +213,7 @@ 
 			'note'			=> 'note',
 			'tel_car'		=> 'carphone',
 			'tel_prefer'	=> 'primaryphone',
-			'cat_id'		=> 'category',	// special handling in _egw2evolutionperson method
+			'cat_id'		=> 'category', // special handling in _egw2evolutionperson method
 			'role'			=> 'businessrole',
 			'tel_assistent'	=> 'assistantphone',
 			'assistent'		=> 'assistantname',
@@ -222,7 +222,7 @@ 
 			'freebusy_uri'	=> 'freeBusyuri',
 			'calendar_uri'	=> 'calendaruri',
 			'tel_other'		=> 'otherphone',
-			'tel_cell_private' => 'callbackphone',	// not the best choice, but better then nothing
+			'tel_cell_private' => 'callbackphone', // not the best choice, but better then nothing
 		),
 		// additional schema can be added here, including special functions
 
@@ -270,10 +270,10 @@ 
 	 * @param array $ldap_config =null default use from $GLOBALS['egw_info']['server']
 	 * @param resource $ds =null ldap connection to use
 	 */
-	function __construct(array $ldap_config=null, $ds=null)
+	function __construct(array $ldap_config = null, $ds = null)
 	{
 		//$this->db_data_cols 	= $this->stock_contact_fields + $this->non_contact_fields;
-		$this->accountName 		= $GLOBALS['egw_info']['user']['account_lid'];
+		$this->accountName = $GLOBALS['egw_info']['user']['account_lid'];
 
 		if ($ldap_config)
 		{
@@ -281,12 +281,12 @@ 
 		}
 		else
 		{
-			$this->ldap_config =& $GLOBALS['egw_info']['server'];
+			$this->ldap_config = & $GLOBALS['egw_info']['server'];
 		}
 		$this->accountContactsDN	= $this->ldap_config['ldap_context'];
-		$this->allContactsDN		= $this->ldap_config['ldap_contact_context'];
-		$this->personalContactsDN	= 'ou=personal,ou=contacts,'. $this->allContactsDN;
-		$this->sharedContactsDN		= 'ou=shared,ou=contacts,'. $this->allContactsDN;
+		$this->allContactsDN = $this->ldap_config['ldap_contact_context'];
+		$this->personalContactsDN = 'ou=personal,ou=contacts,'.$this->allContactsDN;
+		$this->sharedContactsDN		= 'ou=shared,ou=contacts,'.$this->allContactsDN;
 
 		if ($ds)
 		{
@@ -298,9 +298,9 @@ 
 		}
 		$this->ldapServerInfo = $GLOBALS['egw']->ldap->getLDAPServerInfo($this->ldap_config['ldap_contact_host']);
 
-		foreach($this->schema2egw as $attributes)
+		foreach ($this->schema2egw as $attributes)
 		{
-			$this->all_attributes = array_merge($this->all_attributes,array_values($attributes));
+			$this->all_attributes = array_merge($this->all_attributes, array_values($attributes));
 		}
 		$this->all_attributes = array_values(array_unique($this->all_attributes));
 
@@ -327,7 +327,7 @@ 
 			$this->ds = Api\Ldap::factory();
 		}
 		// if ldap is NOT the contact repository, we only do accounts and need to use the account-data
-		elseif (substr($GLOBALS['egw_info']['server']['contact_repository'],-4) != 'ldap')	// not (ldap or sql-ldap)
+		elseif (substr($GLOBALS['egw_info']['server']['contact_repository'], -4) != 'ldap')	// not (ldap or sql-ldap)
 		{
 			$this->ldap_config['ldap_contact_host'] = $this->ldap_config['ldap_host'];
 			$this->allContactsDN = $this->ldap_config['ldap_context'];
@@ -351,17 +351,17 @@ 
 	function supported_fields()
 	{
 		$fields = array(
-			'id','tid','owner',
-			'n_middle','n_prefix','n_suffix',	// stored in the cn
-			'created','modified',				// automatic timestamps
-			'creator','modifier',				// automatic for non accounts
-			'private',							// true for personal addressbooks, false otherwise
+			'id', 'tid', 'owner',
+			'n_middle', 'n_prefix', 'n_suffix', // stored in the cn
+			'created', 'modified', // automatic timestamps
+			'creator', 'modifier', // automatic for non accounts
+			'private', // true for personal addressbooks, false otherwise
 		);
-		foreach($this->schema2egw as $objectclass => $mapping)
+		foreach ($this->schema2egw as $objectclass => $mapping)
 		{
-			if($this->ldapServerInfo->supportsObjectClass($objectclass))
+			if ($this->ldapServerInfo->supportsObjectClass($objectclass))
 			{
-				$fields = array_merge($fields,array_keys($mapping));
+				$fields = array_merge($fields, array_keys($mapping));
 			}
 		}
 		return array_values(array_unique($fields));
@@ -391,7 +391,7 @@ 
 			return $this->id_filter(is_array($ids) ? array_shift($ids) : $ids);
 		}
 		$filter = array();
-		foreach($ids as $id)
+		foreach ($ids as $id)
 		{
 			$filter[] = $this->id_filter($id);
 		}
@@ -407,9 +407,9 @@ 
 	function read($contact_id)
 	{
 		if (is_array($contact_id) && isset($contact_id['account_id']) ||
-			!is_array($contact_id) && substr($contact_id,0,8) == 'account:')
+			!is_array($contact_id) && substr($contact_id, 0, 8) == 'account:')
 		{
-			$filter = 'uidNumber='.(int)(is_array($contact_id) ? $contact_id['account_id'] : substr($contact_id,8));
+			$filter = 'uidNumber='.(int)(is_array($contact_id) ? $contact_id['account_id'] : substr($contact_id, 8));
 		}
 		else
 		{
@@ -432,7 +432,7 @@ 
 		// never allow to change the uidNumber (account_id) on update, as it could be misused by eg. xmlrpc or syncml
 		unset($ldapContact['uidnumber']);
 
-		unset($ldapContact['entryuuid']);	// not allowed to modify that, no need either
+		unset($ldapContact['entryuuid']); // not allowed to modify that, no need either
 
 		unset($ldapContact['objectClass']);
 	}
@@ -443,28 +443,28 @@ 
 	 * @param array $keys if given $keys are copied to data before saveing => allows a save as
 	 * @return int 0 on success and errno != 0 else
 	 */
-	function save($keys=null)
+	function save($keys = null)
 	{
 		//error_log(__METHOD__."(".array2string($keys).") this->data=".array2string($this->data));
-		if(is_array($keys))
+		if (is_array($keys))
 		{
-			$this->data = is_array($this->data) ? array_merge($this->data,$keys) : $keys;
+			$this->data = is_array($this->data) ? array_merge($this->data, $keys) : $keys;
 		}
 
-		$data =& $this->data;
+		$data = & $this->data;
 		$isUpdate = false;
 		$ldapContact = array();
 
 		// generate addressbook dn
-		if((int)$data['owner'])
+		if ((int)$data['owner'])
 		{
 			// group address book
-			if(!($cn = strtolower($GLOBALS['egw']->accounts->id2name((int)$data['owner']))))
+			if (!($cn = strtolower($GLOBALS['egw']->accounts->id2name((int)$data['owner']))))
 			{
 				error_log('Unknown owner');
 				return true;
 			}
-			$baseDN = 'cn='. $cn .','.($data['owner'] < 0 ? $this->sharedContactsDN : $this->personalContactsDN);
+			$baseDN = 'cn='.$cn.','.($data['owner'] < 0 ? $this->sharedContactsDN : $this->personalContactsDN);
 		}
 		// only an admin or the user itself is allowed to change the data of an account
 		elseif ($data['account_id'] && ($GLOBALS['egw_info']['user']['apps']['admin'] ||
@@ -472,7 +472,7 @@ 
 		{
 			// account
 			$baseDN = $this->accountContactsDN;
-			$cn	= false;
+			$cn = false;
 			// we need an admin connection
 			$this->connect(true);
 
@@ -485,7 +485,7 @@ 
 		else
 		{
 			error_log("Permission denied, to write: data[owner]=$data[owner], data[account_id]=$data[account_id], account_id=".$GLOBALS['egw_info']['user']['account_id']);
-			return lang('Permission denied !!!');	// only admin or the user itself is allowd to write accounts!
+			return lang('Permission denied !!!'); // only admin or the user itself is allowd to write accounts!
 		}
 		// check if $baseDN exists. If not create it
 		if (($err = $this->_check_create_dn($baseDN)))
@@ -494,55 +494,54 @@ 
 		}
 		// check the existing objectclasses of an entry, none = array() for new ones
 		$oldObjectclasses = array();
-		$attributes = array('dn','cn','objectClass',$this->dn_attribute,'mail');
+		$attributes = array('dn', 'cn', 'objectClass', $this->dn_attribute, 'mail');
 
 		$contactUID	= $this->data[$this->contacts_id];
 		if (!empty($contactUID) &&
-			($result = ldap_search($this->ds, $base=$this->allContactsDN, $this->id_filter($contactUID), $attributes)) &&
+			($result = ldap_search($this->ds, $base = $this->allContactsDN, $this->id_filter($contactUID), $attributes)) &&
 			($oldContactInfo = ldap_get_entries($this->ds, $result)) && $oldContactInfo['count'])
 		{
 			unset($oldContactInfo[0]['objectclass']['count']);
-			foreach($oldContactInfo[0]['objectclass'] as $objectclass)
+			foreach ($oldContactInfo[0]['objectclass'] as $objectclass)
 			{
-				$oldObjectclasses[]	= strtolower($objectclass);
+				$oldObjectclasses[] = strtolower($objectclass);
 			}
 		   	$isUpdate = true;
 		}
 
-		if(empty($contactUID))
+		if (empty($contactUID))
 		{
 			$ldapContact[$this->dn_attribute] = $this->data[$this->contacts_id] = $contactUID = md5(Api\Auth::randomstring(15));
 		}
 		//error_log(__METHOD__."() contactUID='$contactUID', isUpdate=".array2string($isUpdate).", oldContactInfo=".array2string($oldContactInfo));
 		// add for all supported objectclasses the objectclass and it's attributes
-		foreach($this->schema2egw as $objectclass => $mapping)
+		foreach ($this->schema2egw as $objectclass => $mapping)
 		{
-			if(!$this->ldapServerInfo->supportsObjectClass($objectclass)) continue;
+			if (!$this->ldapServerInfo->supportsObjectClass($objectclass)) continue;
 
-			if($objectclass != 'posixaccount' && !in_array($objectclass, $oldObjectclasses))
+			if ($objectclass != 'posixaccount' && !in_array($objectclass, $oldObjectclasses))
 			{
 				$ldapContact['objectClass'][] = $objectclass;
 			}
 			if (isset($this->required_subs[$objectclass]))
 			{
-				foreach($this->required_subs[$objectclass] as $sub)
+				foreach ($this->required_subs[$objectclass] as $sub)
 				{
-					if(!in_array($sub, $oldObjectclasses))
+					if (!in_array($sub, $oldObjectclasses))
 					{
 						$ldapContact['objectClass'][] = $sub;
 					}
 				}
 			}
-			foreach($mapping as $egwFieldName => $ldapFieldName)
+			foreach ($mapping as $egwFieldName => $ldapFieldName)
 			{
 				if (is_int($egwFieldName)) continue;
-				if(!empty($data[$egwFieldName]))
+				if (!empty($data[$egwFieldName]))
 				{
 					// dont convert the (binary) jpegPhoto!
-					$ldapContact[$ldapFieldName] = $ldapFieldName == 'jpegphoto' ? $data[$egwFieldName] :
-						Api\Translation::convert(trim($data[$egwFieldName]),$this->charset,'utf-8');
+					$ldapContact[$ldapFieldName] = $ldapFieldName == 'jpegphoto' ? $data[$egwFieldName] : Api\Translation::convert(trim($data[$egwFieldName]), $this->charset, 'utf-8');
 				}
-				elseif($isUpdate && isset($data[$egwFieldName]))
+				elseif ($isUpdate && isset($data[$egwFieldName]))
 				{
 					$ldapContact[$ldapFieldName] = array();
 				}
@@ -550,9 +549,9 @@ 
 			}
 			// handling of special attributes, like cat_id in evolutionPerson
 			$egw2objectclass = '_egw2'.$objectclass;
-			if (method_exists($this,$egw2objectclass))
+			if (method_exists($this, $egw2objectclass))
 			{
-				$this->$egw2objectclass($ldapContact,$data,$isUpdate);
+				$this->$egw2objectclass($ldapContact, $data, $isUpdate);
 			}
 		}
 		if ($isUpdate)
@@ -570,11 +569,11 @@ 
 			$needRecreation = false;
 
 			// add missing objectclasses
-			if($ldapContact['objectClass'] && ($missing=array_diff($ldapContact['objectClass'],$oldObjectclasses)))
+			if ($ldapContact['objectClass'] && ($missing = array_diff($ldapContact['objectClass'], $oldObjectclasses)))
 			{
 				if (!@ldap_mod_add($this->ds, $dn, array('objectClass' => $ldapContact['objectClass'])))
 				{
-					if(in_array(ldap_errno($this->ds),array(69,20)))
+					if (in_array(ldap_errno($this->ds), array(69, 20)))
 					{
 						// need to modify structural objectclass
 						$needRecreation = true;
@@ -583,15 +582,15 @@ 
 					else
 					{
 						//echo "<p>ldap_mod_add($this->ds,'$dn',array(objectClass =>".print_r($ldapContact['objectClass'],true)."))</p>\n";
-						error_log(__METHOD__.'() '.__LINE__.' update of '. $dn .' failed errorcode: '. ldap_errno($this->ds) .' ('. ldap_error($this->ds) .')');
+						error_log(__METHOD__.'() '.__LINE__.' update of '.$dn.' failed errorcode: '.ldap_errno($this->ds).' ('.ldap_error($this->ds).')');
 						return $this->_error(__LINE__);
 					}
 				}
 			}
 
 			// check if we need to rename the DN or need to recreate the contact
-			$newRDN = $this->dn_attribute.'='. $ldapContact[$this->dn_attribute];
-			$newDN = $newRDN .','. $baseDN;
+			$newRDN = $this->dn_attribute.'='.$ldapContact[$this->dn_attribute];
+			$newDN = $newRDN.','.$baseDN;
 			if ($needRecreation)
 			{
 				$result = ldap_read($this->ds, $dn, 'objectclass=*');
@@ -602,20 +601,20 @@ 
 				$newContact = $oldContact;
 				$newContact[$this->dn_attribute] = $ldapContact[$this->dn_attribute];
 
-				if(is_array($ldapContact['objectClass']) && count($ldapContact['objectClass']) > 0)
+				if (is_array($ldapContact['objectClass']) && count($ldapContact['objectClass']) > 0)
 				{
-					$newContact['objectclass'] = array_unique(array_map('strtolower',	// objectclasses my have different case
+					$newContact['objectclass'] = array_unique(array_map('strtolower', // objectclasses my have different case
 						array_merge($newContact['objectclass'], $ldapContact['objectClass'])));
 				}
 
-				if(!ldap_delete($this->ds, $dn))
+				if (!ldap_delete($this->ds, $dn))
 				{
-					error_log(__METHOD__.'() '.__LINE__.' delete of old '. $dn .' failed errorcode: '. ldap_errno($this->ds) .' ('. ldap_error($this->ds) .')');
+					error_log(__METHOD__.'() '.__LINE__.' delete of old '.$dn.' failed errorcode: '.ldap_errno($this->ds).' ('.ldap_error($this->ds).')');
 					return $this->_error(__LINE__);
 				}
-				if(!@ldap_add($this->ds, $newDN, $newContact))
+				if (!@ldap_add($this->ds, $newDN, $newContact))
 				{
-					error_log(__METHOD__.'() '.__LINE__.' re-create contact as '. $newDN .' failed errorcode: '. ldap_errno($this->ds) .' ('. ldap_error($this->ds) .') newContact='.array2string($newContact));
+					error_log(__METHOD__.'() '.__LINE__.' re-create contact as '.$newDN.' failed errorcode: '.ldap_errno($this->ds).' ('.ldap_error($this->ds).') newContact='.array2string($newContact));
 					// if adding with new objectclass or dn fails, re-add deleted contact
 					@ldap_add($this->ds, $dn, $oldContact);
 					return $this->_error(__LINE__);
@@ -644,22 +643,22 @@ 
 
 			if (!@ldap_modify($this->ds, $dn, $ldapContact))
 			{
-				error_log(__METHOD__.'() '.__LINE__.' update of '. $dn .' failed errorcode: '. ldap_errno($this->ds) .' ('. ldap_error($this->ds) .') ldapContact='.array2string($ldapContact));
+				error_log(__METHOD__.'() '.__LINE__.' update of '.$dn.' failed errorcode: '.ldap_errno($this->ds).' ('.ldap_error($this->ds).') ldapContact='.array2string($ldapContact));
 				return $this->_error(__LINE__);
 			}
 		}
 		else
 		{
-			$dn = $this->dn_attribute.'='. $ldapContact[$this->dn_attribute] .','. $baseDN;
-			unset($ldapContact['entryuuid']);	// trying to write it, gives an error
+			$dn = $this->dn_attribute.'='.$ldapContact[$this->dn_attribute].','.$baseDN;
+			unset($ldapContact['entryuuid']); // trying to write it, gives an error
 
 			if (!@ldap_add($this->ds, $dn, $ldapContact))
 			{
-				error_log(__METHOD__.'() '.__LINE__.' add of '. $dn .' failed errorcode: '. ldap_errno($this->ds) .' ('. ldap_error($this->ds) .') ldapContact='.array2string($ldapContact));
+				error_log(__METHOD__.'() '.__LINE__.' add of '.$dn.' failed errorcode: '.ldap_errno($this->ds).' ('.ldap_error($this->ds).') ldapContact='.array2string($ldapContact));
 				return $this->_error(__LINE__);
 			}
 		}
-		return 0;	// Ok, no error
+		return 0; // Ok, no error
 	}
 
 	/**
@@ -668,28 +667,28 @@ 
 	 * @param array $keys if given array with col => value pairs to characterise the rows to delete
 	 * @return int affected rows, should be 1 if ok, 0 if an error
 	 */
-	function delete($keys=null)
+	function delete($keys = null)
 	{
 		// single entry
-		if($keys[$this->contacts_id]) $keys = array( 0 => $keys);
+		if ($keys[$this->contacts_id]) $keys = array(0 => $keys);
 
-		if(!is_array($keys))
+		if (!is_array($keys))
 		{
-			$keys = array( $keys);
+			$keys = array($keys);
 		}
 
 		$ret = 0;
 
 		$attributes = array('dn');
 
-		foreach($keys as $entry)
+		foreach ($keys as $entry)
 		{
 			$entry = Api\Ldap::quote(is_array($entry) ? $entry['id'] : $entry);
-			if(($result = ldap_search($this->ds, $this->allContactsDN,
+			if (($result = ldap_search($this->ds, $this->allContactsDN,
 				"(|(entryUUID=$entry)(uid=$entry))", $attributes)))
 			{
 				$contactInfo = ldap_get_entries($this->ds, $result);
-				if(@ldap_delete($this->ds, $contactInfo[0]['dn']))
+				if (@ldap_delete($this->ds, $contactInfo[0]['dn']))
 				{
 					$ret++;
 				}
@@ -717,10 +716,10 @@ 
 	 * @param boolean $need_full_no_count =false If true an unlimited query is run to determine the total number of rows, default false
 	 * @return array of matching rows (the row is an array of the cols) or False
 	 */
-	function &search($criteria,$only_keys=True,$order_by='',$extra_cols='',$wildcard='',$empty=False,$op='AND',$start=false,$filter=null,$join='',$need_full_no_count=false)
+	function &search($criteria, $only_keys = True, $order_by = '', $extra_cols = '', $wildcard = '', $empty = False, $op = 'AND', $start = false, $filter = null, $join = '', $need_full_no_count = false)
 	{
 		//error_log(__METHOD__."(".array2string($criteria).", ".array2string($only_keys).", '$order_by', ".array2string($extra_cols).", '$wildcard', '$empty', '$op', ".array2string($start).", ".array2string($filter).")");
-		unset($only_keys, $extra_cols, $empty, $join, $need_full_no_count);	// not used, but required by function signature
+		unset($only_keys, $extra_cols, $empty, $join, $need_full_no_count); // not used, but required by function signature
 
 		if (is_array($filter['owner']))
 		{
@@ -742,7 +741,7 @@ 
 			'created' => 'createtimestamp',
 			'modified' => 'modifytimestamp',
 		);
-		foreach($filter as $key => $value)
+		foreach ($filter as $key => $value)
 		{
 			$matches = null;
 			if (is_int($key) && preg_match('/^(contact_)?(modified|created)([<=>]+)([0-9]+)$/', $value, $matches))
@@ -758,11 +757,11 @@ 
 			}
 		}
 
-		if((int)$filter['owner'])
+		if ((int)$filter['owner'])
 		{
 			if (!($accountName = $GLOBALS['egw']->accounts->id2name($filter['owner']))) return false;
 
-			$searchDN = 'cn='. Api\Ldap::quote(strtolower($accountName)) .',';
+			$searchDN = 'cn='.Api\Ldap::quote(strtolower($accountName)).',';
 
 			if ($filter['owner'] < 0)
 			{
@@ -786,7 +785,7 @@ 
 			$addressbookType = self::ACCOUNTS;
 		}
 		// create the search filter
-		switch($addressbookType)
+		switch ($addressbookType)
 		{
 			case self::ACCOUNTS:
 				$objectFilter = $this->accountsFilter;
@@ -801,28 +800,28 @@ 
 		// shadowExpire>= does NOT work, as shadow schema only specifies integerMatch and not integerOrderingMatch :-(
 
 		$searchFilter = '';
-		if(is_array($criteria) && count($criteria) > 0)
+		if (is_array($criteria) && count($criteria) > 0)
 		{
 			$wildcard = $wildcard === '%' ? '*' : '';
 			$searchFilter = '';
-			foreach($criteria as $egwSearchKey => $searchValue)
+			foreach ($criteria as $egwSearchKey => $searchValue)
 			{
-				if (in_array($egwSearchKey, array('id','contact_id')))
+				if (in_array($egwSearchKey, array('id', 'contact_id')))
 				{
 					$searchFilter .= $this->ids_filter($searchValue);
 					continue;
 				}
-				foreach($this->schema2egw as $mapping)
+				foreach ($this->schema2egw as $mapping)
 				{
-					if(($ldapSearchKey = $mapping[$egwSearchKey]))
+					if (($ldapSearchKey = $mapping[$egwSearchKey]))
 					{
-						$searchString = Api\Translation::convert($searchValue,$this->charset,'utf-8');
+						$searchString = Api\Translation::convert($searchValue, $this->charset, 'utf-8');
 						$searchFilter .= '('.$ldapSearchKey.'='.$wildcard.Api\Ldap::quote($searchString).$wildcard.')';
 						break;
 					}
 				}
 			}
-			if($op == 'AND')
+			if ($op == 'AND')
 			{
 				$searchFilter = "(&$searchFilter)";
 			}
@@ -841,9 +840,9 @@ 
 		// only return certain owners --> unset not matching ones
 		if ($owner_filter)
 		{
-			foreach($rows as $k => $row)
+			foreach ($rows as $k => $row)
 			{
-				if (!in_array($row['owner'],$owner_filter))
+				if (!in_array($row['owner'], $owner_filter))
 				{
 					unset($rows[$k]);
 					--$this->total;
@@ -854,18 +853,18 @@ 
 		{
 			$order = array();
 			$sort = 'ASC';
-			foreach(explode(',',$order_by) as $o)
+			foreach (explode(',', $order_by) as $o)
 			{
-				if (substr($o,0,8) == 'contact_') $o = substr($o,8);
-				if (substr($o,-4) == ' ASC')
+				if (substr($o, 0, 8) == 'contact_') $o = substr($o, 8);
+				if (substr($o, -4) == ' ASC')
 				{
 					$sort = 'ASC';
-					$order[] = substr($o,0,-4);
+					$order[] = substr($o, 0, -4);
 				}
-				elseif (substr($o,-5) == ' DESC')
+				elseif (substr($o, -5) == ' DESC')
 				{
 					$sort = 'DESC';
-					$order[] = substr($o,0,-5);
+					$order[] = substr($o, 0, -5);
 				}
 				elseif ($o)
 				{
@@ -874,9 +873,9 @@ 
 			}
 			usort($rows, function($a, $b) use ($order, $sort)
 			{
-				foreach($order as $f)
+				foreach ($order as $f)
 				{
-					if($sort == 'ASC')
+					if ($sort == 'ASC')
 					{
 						$strc = strcmp($a[$f], $b[$f]);
 					}
@@ -892,13 +891,13 @@ 
 		// if requested ($start !== false) return only limited resultset
 		if (is_array($start))
 		{
-			list($start,$offset) = $start;
+			list($start, $offset) = $start;
 		}
-		if(is_numeric($start) && is_numeric($offset) && $offset >= 0)
+		if (is_numeric($start) && is_numeric($offset) && $offset >= 0)
 		{
 			return array_slice($rows, $start, $offset);
 		}
-		elseif(is_numeric($start))
+		elseif (is_numeric($start))
 		{
 			return array_slice($rows, $start, $GLOBALS['egw_info']['user']['preferences']['common']['maxmatchs']);
 		}
@@ -916,11 +915,11 @@ 
 		if (!is_array($filter)) return '';
 
 		$filters = '';
-		foreach($filter as $key => $value)
+		foreach ($filter as $key => $value)
 		{
 			if ($key != 'cat_id' && $key != 'account_id' && !$value) continue;
 
-			switch((string) $key)
+			switch ((string)$key)
 			{
 				case 'owner':	// already handled
 				case 'tid':		// ignored
@@ -934,7 +933,7 @@ 
 					elseif ($value)
 					{
 						if (is_array($value)) $filters .= '(|';
-						foreach((array)$value as $value)
+						foreach ((array)$value as $value)
 						{
 							$filters .= '(uidNumber='.(int)$value.')';
 						}
@@ -947,7 +946,7 @@ 
 					{
 						$filters .= '(!(category=*))';
 					}
-					elseif((int)$value)
+					elseif ((int)$value)
 					{
 						if (!is_object($GLOBALS['egw']->categories))
 						{
@@ -955,10 +954,10 @@ 
 						}
 						$cats = $GLOBALS['egw']->categories->return_all_children((int)$value);
 						if (count($cats) > 1) $filters .= '(|';
-						foreach($cats as $cat)
+						foreach ($cats as $cat)
 						{
 							$catName = Api\Translation::convert(
-								$GLOBALS['egw']->categories->id2name($cat),$this->charset,'utf-8');
+								$GLOBALS['egw']->categories->id2name($cat), $this->charset, 'utf-8');
 							$filters .= '(category='.Api\Ldap::quote($catName).')';
 						}
 						if (count($cats) > 1) $filters .= ')';
@@ -967,7 +966,7 @@ 
 
 				case 'carddav_name':
 					if (!is_array($value)) $value = array($value);
-					foreach($value as &$v)
+					foreach ($value as &$v)
 					{
 						$v = basename($v, '.vcf');
 					}
@@ -985,28 +984,27 @@ 
 					$matches = null;
 					if (!is_int($key))
 					{
-						foreach($this->schema2egw as $mapping)
+						foreach ($this->schema2egw as $mapping)
 						{
 							if (isset($mapping[$key]))
 							{
 								// todo: value = "!''"
-								$filters .= '('.$mapping[$key].'='.($value === "!''" ? '*' :
-									Api\Ldap::quote(Api\Translation::convert($value,$this->charset,'utf-8'))).')';
+								$filters .= '('.$mapping[$key].'='.($value === "!''" ? '*' : Api\Ldap::quote(Api\Translation::convert($value, $this->charset, 'utf-8'))).')';
 								break;
 							}
 						}
 					}
 					// filter for letter-search
-					elseif (preg_match("/^([^ ]+) ".preg_quote($GLOBALS['egw']->db->capabilities[Api\Db::CAPABILITY_CASE_INSENSITIV_LIKE])." '(.*)%'$/",$value,$matches))
+					elseif (preg_match("/^([^ ]+) ".preg_quote($GLOBALS['egw']->db->capabilities[Api\Db::CAPABILITY_CASE_INSENSITIV_LIKE])." '(.*)%'$/", $value, $matches))
 					{
-						list(,$name,$value) = $matches;
-						if (strpos($name,'.') !== false) list(,$name) = explode('.',$name);
-						foreach($this->schema2egw as $mapping)
+						list(,$name, $value) = $matches;
+						if (strpos($name, '.') !== false) list(,$name) = explode('.', $name);
+						foreach ($this->schema2egw as $mapping)
 						{
 							if (isset($mapping[$name]))
 							{
 								$filters .= '('.$mapping[$name].'='.Api\Ldap::quote(
-									Api\Translation::convert($value,$this->charset,'utf-8')).'*)';
+									Api\Translation::convert($value, $this->charset, 'utf-8')).'*)';
 								break;
 							}
 						}
@@ -1030,7 +1028,7 @@ 
 		{
 			$filter .= '(|';
 			// unfortunately we have no group-membership attribute in LDAP, like in AD
-			foreach($GLOBALS['egw']->accounts->members($gid, true) as $account_id)
+			foreach ($GLOBALS['egw']->accounts->members($gid, true) as $account_id)
 			{
 				$filter .= '(uidNumber='.(int)$account_id.')';
 			}
@@ -1052,7 +1050,7 @@ 
 	 * @param array $_skipPlugins =null schema-plugins to skip
 	 * @return array/boolean with eGW contacts or false on error
 	 */
-	function _searchLDAP($_ldapContext, $_filter, $_attributes, $_addressbooktype, array $_skipPlugins=null)
+	function _searchLDAP($_ldapContext, $_filter, $_attributes, $_addressbooktype, array $_skipPlugins = null)
 	{
 		$this->total = 0;
 
@@ -1065,7 +1063,7 @@ 
 
 		//error_log(__METHOD__."('$_ldapContext', '$_filter', ".array2string($_attributes).", $_addressbooktype)");
 
-		if($_addressbooktype == self::ALL || $_ldapContext == $this->allContactsDN)
+		if ($_addressbooktype == self::ALL || $_ldapContext == $this->allContactsDN)
 		{
 			$result = ldap_search($this->ds, $_ldapContext, $_filter, $_attributes, 0, $this->ldapLimit);
 		}
@@ -1073,36 +1071,36 @@ 
 		{
 			$result = @ldap_list($this->ds, $_ldapContext, $_filter, $_attributes, 0, $this->ldapLimit);
 		}
-		if(!$result || !$entries = ldap_get_entries($this->ds, $result)) return array();
+		if (!$result || !$entries = ldap_get_entries($this->ds, $result)) return array();
 		//error_log(__METHOD__."('$_ldapContext', '$_filter', ".array2string($_attributes).", $_addressbooktype) result of $entries[count]");
 
 		$this->total = $entries['count'];
-		foreach($entries as $i => $entry)
+		foreach ($entries as $i => $entry)
 		{
-			if (!is_int($i)) continue;	// eg. count
+			if (!is_int($i)) continue; // eg. count
 
 			$contact = array(
 				'id'  => $entry['uid'][0] ? $entry['uid'][0] : $entry['entryuuid'][0],
-				'tid' => 'n',	// the type id for the addressbook
+				'tid' => 'n', // the type id for the addressbook
 			);
-			foreach($entry['objectclass'] as $ii => $objectclass)
+			foreach ($entry['objectclass'] as $ii => $objectclass)
 			{
 				$objectclass = strtolower($objectclass);
 				if (!is_int($ii) || !isset($this->schema2egw[$objectclass]))
 				{
-					continue;	// eg. count or unsupported objectclass
+					continue; // eg. count or unsupported objectclass
 				}
-				foreach($this->schema2egw[$objectclass] as $egwFieldName => $ldapFieldName)
+				foreach ($this->schema2egw[$objectclass] as $egwFieldName => $ldapFieldName)
 				{
-					if(!empty($entry[$ldapFieldName][0]) && !is_int($egwFieldName) && !isset($contact[$egwFieldName]))
+					if (!empty($entry[$ldapFieldName][0]) && !is_int($egwFieldName) && !isset($contact[$egwFieldName]))
 					{
-						$contact[$egwFieldName] = Api\Translation::convert($entry[$ldapFieldName][0],'utf-8');
+						$contact[$egwFieldName] = Api\Translation::convert($entry[$ldapFieldName][0], 'utf-8');
 					}
 				}
 				$objectclass2egw = '_'.$objectclass.'2egw';
-				if (!in_array($objectclass2egw, (array)$_skipPlugins) &&method_exists($this,$objectclass2egw))
+				if (!in_array($objectclass2egw, (array)$_skipPlugins) && method_exists($this, $objectclass2egw))
 				{
-					if (($ret=$this->$objectclass2egw($contact,$entry)) === false)
+					if (($ret = $this->$objectclass2egw($contact, $entry)) === false)
 					{
 						--$this->total;
 						continue 2;
@@ -1112,20 +1110,20 @@ 
 			// read binary jpegphoto only for one result == call by read
 			if ($this->total == 1 && isset($entry['jpegphoto'][0]))
 			{
-				$bin = ldap_get_values_len($this->ds,ldap_first_entry($this->ds,$result),'jpegphoto');
+				$bin = ldap_get_values_len($this->ds, ldap_first_entry($this->ds, $result), 'jpegphoto');
 				$contact['jpegphoto'] = $bin[0];
 			}
 			$matches = null;
-			if(preg_match('/cn=([^,]+),'.preg_quote($this->personalContactsDN,'/').'$/i',$entry['dn'],$matches))
+			if (preg_match('/cn=([^,]+),'.preg_quote($this->personalContactsDN, '/').'$/i', $entry['dn'], $matches))
 			{
 				// personal addressbook
-				$contact['owner'] = $GLOBALS['egw']->accounts->name2id($matches[1],'account_lid','u');
+				$contact['owner'] = $GLOBALS['egw']->accounts->name2id($matches[1], 'account_lid', 'u');
 				$contact['private'] = 0;
 			}
-			elseif(preg_match('/cn=([^,]+),'.preg_quote($this->sharedContactsDN,'/').'$/i',$entry['dn'],$matches))
+			elseif (preg_match('/cn=([^,]+),'.preg_quote($this->sharedContactsDN, '/').'$/i', $entry['dn'], $matches))
 			{
 				// group addressbook
-				$contact['owner'] = $GLOBALS['egw']->accounts->name2id($matches[1],'account_lid','g');
+				$contact['owner'] = $GLOBALS['egw']->accounts->name2id($matches[1], 'account_lid', 'g');
 				$contact['private'] = 0;
 			}
 			else
@@ -1134,12 +1132,12 @@ 
 				$contact['owner'] = 0;
 				$contact['private'] = 0;
 			}
-			foreach(array(
+			foreach (array(
 				'createtimestamp' => 'created',
 				'modifytimestamp' => 'modified',
 			) as $ldapFieldName => $egwFieldName)
 			{
-				if(!empty($entry[$ldapFieldName][0]))
+				if (!empty($entry[$ldapFieldName][0]))
 				{
 					$contact[$egwFieldName] = $this->_ldap2ts($entry[$ldapFieldName][0]);
 				}
@@ -1158,8 +1156,8 @@ 
 	 */
 	static function _ldap2ts($date)
 	{
-		return gmmktime(substr($date,8,2),substr($date,10,2),substr($date,12,2),
-			substr($date,4,2),substr($date,6,2),substr($date,0,4));
+		return gmmktime(substr($date, 8, 2), substr($date, 10, 2), substr($date, 12, 2),
+			substr($date, 4, 2), substr($date, 6, 2), substr($date, 0, 4));
 	}
 
 	/**
@@ -1182,20 +1180,20 @@ 
 	function _check_create_dn($baseDN)
 	{
 		// check if $baseDN exists. If not create new one
-		if(@ldap_read($this->ds, $baseDN, 'objectclass=*'))
+		if (@ldap_read($this->ds, $baseDN, 'objectclass=*'))
 		{
 			return false;
 		}
 		//error_log(__METHOD__."('$baseDN') !ldap_read({$this->ds}, '$baseDN', 'objectclass=*') ldap_errno()=".ldap_errno($this->ds).', ldap_error()='.ldap_error($this->ds).get_class($this));
-		if(ldap_errno($this->ds) != 32 || substr($baseDN,0,3) != 'cn=')
+		if (ldap_errno($this->ds) != 32 || substr($baseDN, 0, 3) != 'cn=')
 		{
 			error_log(__METHOD__."('$baseDN') baseDN does NOT exist and we cant/wont create it! ldap_errno()=".ldap_errno($this->ds).', ldap_error()='.ldap_error($this->ds));
-			return $this->_error(__LINE__);	// baseDN does NOT exist and we cant/wont create it
+			return $this->_error(__LINE__); // baseDN does NOT exist and we cant/wont create it
 		}
 
-		list(,$ou) = explode(',',$baseDN);
+		list(,$ou) = explode(',', $baseDN);
 		$adminDS = null;
-		foreach(array(
+		foreach (array(
 			'ou=contacts,'.$this->allContactsDN,
 			$ou.',ou=contacts,'.$this->allContactsDN,
 			$baseDN,
@@ -1204,18 +1202,18 @@ 
 			if (!@ldap_read($this->ds, $dn, 'objectclass=*') && ldap_errno($this->ds) == 32)
 			{
 				// entry does not exist, lets try to create it
-				list($top) = explode(',',$dn);
-				list($var,$val) = explode('=',$top);
+				list($top) = explode(',', $dn);
+				list($var, $val) = explode('=', $top);
 				$data = array(
 					'objectClass' => $var == 'cn' ? 'organizationalRole' : 'organizationalUnit',
 					$var => $val,
 				);
 				// create a admin connection to add the needed DN
 				if (!isset($adminDS)) $adminDS = Api\Ldap::factory();
-				if(!@ldap_add($adminDS, $dn, $data))
+				if (!@ldap_add($adminDS, $dn, $data))
 				{
 					//echo "<p>ldap_add($adminDS,'$dn',".print_r($data,true).")</p>\n";
-					$err = lang("Can't create dn %1",$dn).': '.$this->_error(__LINE__,$adminDS);
+					$err = lang("Can't create dn %1", $dn).': '.$this->_error(__LINE__, $adminDS);
 					return $err;
 				}
 			}
@@ -1230,7 +1228,7 @@ 
 	 * @param int $line
 	 * @return string
 	 */
-	function _error($line,$ds=null)
+	function _error($line, $ds = null)
 	{
 		return ldap_error($ds ? $ds : $this->ds).': '.__CLASS__.': '.$line;
 	}
@@ -1245,27 +1243,27 @@ 
 	 * @param array $data eGW contact data
 	 * @param boolean $isUpdate
 	 */
-	function _egw2evolutionperson(&$ldapContact,$data,$isUpdate)
+	function _egw2evolutionperson(&$ldapContact, $data, $isUpdate)
 	{
-		if(!empty($data['cat_id']))
+		if (!empty($data['cat_id']))
 		{
 			$ldapContact['category'] = array();
-			foreach(is_array($data['cat_id']) ? $data['cat_id'] : explode(',',$data['cat_id'])  as $cat)
+			foreach (is_array($data['cat_id']) ? $data['cat_id'] : explode(',', $data['cat_id'])  as $cat)
 			{
 				$ldapContact['category'][] = Api\Translation::convert(
-					Api\Categories::id2name($cat),$this->charset,'utf-8');
+					Api\Categories::id2name($cat), $this->charset, 'utf-8');
 			}
 		}
-		foreach(array(
-			'postaladdress' => $data['adr_one_street'] .'$'. $data['adr_one_locality'] .', '. $data['adr_one_region'] .'$'. $data['adr_one_postalcode'] .'$$'. $data['adr_one_countryname'],
-			'homepostaladdress' => $data['adr_two_street'] .'$'. $data['adr_two_locality'] .', '. $data['adr_two_region'] .'$'. $data['adr_two_postalcode'] .'$$'. $data['adr_two_countryname'],
+		foreach (array(
+			'postaladdress' => $data['adr_one_street'].'$'.$data['adr_one_locality'].', '.$data['adr_one_region'].'$'.$data['adr_one_postalcode'].'$$'.$data['adr_one_countryname'],
+			'homepostaladdress' => $data['adr_two_street'].'$'.$data['adr_two_locality'].', '.$data['adr_two_region'].'$'.$data['adr_two_postalcode'].'$$'.$data['adr_two_countryname'],
 		) as $attr => $value)
 		{
-			if($value != '$, $$$')
+			if ($value != '$, $$$')
 			{
-				$ldapContact[$attr] = Api\Translation::convert($value,$this->charset,'utf-8');
+				$ldapContact[$attr] = Api\Translation::convert($value, $this->charset, 'utf-8');
 			}
-			elseif($isUpdate)
+			elseif ($isUpdate)
 			{
 				$ldapContact[$attr] = array();
 			}
@@ -1275,7 +1273,7 @@ 
 		{
 			$ldapContact['primaryphone'] = $data[$data['tel_prefer']];
 		}
-		elseif($isUpdate)
+		elseif ($isUpdate)
 		{
 			$ldapContact['primaryphone'] = array();
 		}
@@ -1290,23 +1288,23 @@ 
 	 * @param array &$contact already copied fields according to the mapping
 	 * @param array $data eGW contact data
 	 */
-	function _evolutionperson2egw(&$contact,$data)
+	function _evolutionperson2egw(&$contact, $data)
 	{
 		if ($data['category'] && is_array($data['category']))
 		{
 			$contact['cat_id'] = array();
-			foreach($data['category'] as $iii => $cat)
+			foreach ($data['category'] as $iii => $cat)
 			{
 				if (!is_int($iii)) continue;
 
 				$contact['cat_id'][] = $GLOBALS['egw']->categories->name2id($cat);
 			}
-			if ($contact['cat_id']) $contact['cat_id'] = implode(',',$contact['cat_id']);
+			if ($contact['cat_id']) $contact['cat_id'] = implode(',', $contact['cat_id']);
 		}
 		if ($data['primaryphone'])
 		{
-			unset($contact['tel_prefer']);	// to not find itself
-			$contact['tel_prefer'] = array_search($data['primaryphone'][0],$contact);
+			unset($contact['tel_prefer']); // to not find itself
+			$contact['tel_prefer'] = array_search($data['primaryphone'][0], $contact);
 		}
 	}
 
@@ -1319,10 +1317,10 @@ 
 	 * @param array &$contact already copied fields according to the mapping
 	 * @param array $data eGW contact data
 	 */
-	function _inetorgperson2egw(&$contact, $data, $cn='cn')
+	function _inetorgperson2egw(&$contact, $data, $cn = 'cn')
 	{
 		$matches = null;
-		if(empty($data['givenname'][0]))
+		if (empty($data['givenname'][0]))
 		{
 			$parts = explode($data['sn'][0], $data[$cn][0]);
 			$contact['n_prefix'] = trim($parts[0]);
@@ -1330,8 +1328,8 @@ 
 		}
 		// iOS addressbook either use "givenname surname" or "surname givenname" depending on contact preference display-order
 		// in full name, so we need to check for both when trying to parse prefix, middle name and suffix form full name
-		elseif (preg_match($preg='/^(.*) *'.preg_quote($data['givenname'][0], '/').' *(.*) *'.preg_quote($data['sn'][0], '/').' *(.*)$/', $data[$cn][0], $matches) ||
-			preg_match($preg='/^(.*) *'.preg_quote($data['sn'][0], '/').'[, ]*(.*) *'.preg_quote($data['givenname'][0], '/').' *(.*)$/', $data[$cn][0], $matches))
+		elseif (preg_match($preg = '/^(.*) *'.preg_quote($data['givenname'][0], '/').' *(.*) *'.preg_quote($data['sn'][0], '/').' *(.*)$/', $data[$cn][0], $matches) ||
+			preg_match($preg = '/^(.*) *'.preg_quote($data['sn'][0], '/').'[, ]*(.*) *'.preg_quote($data['givenname'][0], '/').' *(.*)$/', $data[$cn][0], $matches))
 		{
 			list(,$contact['n_prefix'], $contact['n_middle'], $contact['n_suffix']) = $matches;
 			//error_log(__METHOD__."() preg_match('$preg', '{$data[$cn][0]}') = ".array2string($matches));
@@ -1352,11 +1350,11 @@ 
 	 * @param array &$contact already copied fields according to the mapping
 	 * @param array $data eGW contact data
 	 */
-	function _posixaccount2egw(&$contact,$data)
+	function _posixaccount2egw(&$contact, $data)
 	{
-		unset($contact);	// not used, but required by function signature
-		static $shadowExpireNow=null;
-		if (!isset($shadowExpireNow)) $shadowExpireNow = floor((time()-date('Z'))/86400);
+		unset($contact); // not used, but required by function signature
+		static $shadowExpireNow = null;
+		if (!isset($shadowExpireNow)) $shadowExpireNow = floor((time() - date('Z')) / 86400);
 
 		// exclude expired or deactivated accounts
 		if (isset($data['shadowexpire']) && $data['shadowexpire'][0] <= $shadowExpireNow)
@@ -1374,7 +1372,7 @@ 
 	 * @param array &$contact already copied fields according to the mapping
 	 * @param array $data eGW contact data
 	 */
-	function _mozillaabpersonalpha2egw(&$contact,$data)
+	function _mozillaabpersonalpha2egw(&$contact, $data)
 	{
 		if ($data['c'])
 		{
@@ -1392,7 +1390,7 @@ 
 	 * @param array $data eGW contact data
 	 * @param boolean $isUpdate
 	 */
-	function _egw2mozillaabpersonalpha(&$ldapContact,$data,$isUpdate)
+	function _egw2mozillaabpersonalpha(&$ldapContact, $data, $isUpdate)
 	{
 		if ($data['adr_one_countrycode'])
 		{
@@ -1421,9 +1419,9 @@ 
 	 * @param array &$contact already copied fields according to the mapping
 	 * @param array $data eGW contact data
 	 */
-	function _mozillaorgperson2egw(&$contact,$data)
+	function _mozillaorgperson2egw(&$contact, $data)
 	{
-		unset($contact, $data);	// not used, but required by function signature
+		unset($contact, $data); // not used, but required by function signature
 		// no special handling necessary, as it supports two distinct attributes: c, cn
 	}
 
@@ -1437,7 +1435,7 @@ 
 	 * @param array $data eGW contact data
 	 * @param boolean $isUpdate
 	 */
-	function _egw2mozillaorgperson(&$ldapContact,$data,$isUpdate)
+	function _egw2mozillaorgperson(&$ldapContact, $data, $isUpdate)
 	{
 		if ($data['adr_one_countrycode'])
 		{
@@ -1465,7 +1463,7 @@ 
 	 * @param int $account_id account-id of the old owner
 	 * @param int $new_owner account-id of the new owner
 	 */
-	function change_owner($account_id,$new_owner)
+	function change_owner($account_id, $new_owner)
 	{
 		error_log(__METHOD__."($account_id,$new_owner) not yet implemented");
 	}

Braces +105 added lines, -27 removed lines

@@ -327,9 +327,12 @@ 
 			$this->ds = Api\Ldap::factory();
 		}
 		// if ldap is NOT the contact repository, we only do accounts and need to use the account-data
-		elseif (substr($GLOBALS['egw_info']['server']['contact_repository'],-4) != 'ldap')	// not (ldap or sql-ldap)
+		elseif (substr($GLOBALS['egw_info']['server']['contact_repository'],-4) != 'ldap')
+		{
+			// not (ldap or sql-ldap)
 		{
 			$this->ldap_config['ldap_contact_host'] = $this->ldap_config['ldap_host'];
+		}
 			$this->allContactsDN = $this->ldap_config['ldap_context'];
 			$this->ds = Api\Ldap::factory();
 		}
@@ -413,7 +416,10 @@ 
 		}
 		else
 		{
-			if (is_array($contact_id)) $contact_id = isset ($contact_id['id']) ? $contact_id['id'] : $contact_id['uid'];
+			if (is_array($contact_id))
+			{
+				$contact_id = isset ($contact_id['id']) ? $contact_id['id'] : $contact_id['uid'];
+			}
 			$filter = $this->id_filter($contact_id);
 		}
 		$rows = $this->_searchLDAP($this->allContactsDN,
@@ -517,7 +523,10 @@ 
 		// add for all supported objectclasses the objectclass and it's attributes
 		foreach($this->schema2egw as $objectclass => $mapping)
 		{
-			if(!$this->ldapServerInfo->supportsObjectClass($objectclass)) continue;
+			if(!$this->ldapServerInfo->supportsObjectClass($objectclass))
+			{
+				continue;
+			}
 
 			if($objectclass != 'posixaccount' && !in_array($objectclass, $oldObjectclasses))
 			{
@@ -535,7 +544,10 @@ 
 			}
 			foreach($mapping as $egwFieldName => $ldapFieldName)
 			{
-				if (is_int($egwFieldName)) continue;
+				if (is_int($egwFieldName))
+				{
+					continue;
+				}
 				if(!empty($data[$egwFieldName]))
 				{
 					// dont convert the (binary) jpegPhoto!
@@ -671,7 +683,10 @@ 
 	function delete($keys=null)
 	{
 		// single entry
-		if($keys[$this->contacts_id]) $keys = array( 0 => $keys);
+		if($keys[$this->contacts_id])
+		{
+			$keys = array( 0 => $keys);
+		}
 
 		if(!is_array($keys))
 		{
@@ -760,7 +775,10 @@ 
 
 		if((int)$filter['owner'])
 		{
-			if (!($accountName = $GLOBALS['egw']->accounts->id2name($filter['owner']))) return false;
+			if (!($accountName = $GLOBALS['egw']->accounts->id2name($filter['owner'])))
+			{
+				return false;
+			}
 
 			$searchDN = 'cn='. Api\Ldap::quote(strtolower($accountName)) .',';
 
@@ -856,7 +874,10 @@ 
 			$sort = 'ASC';
 			foreach(explode(',',$order_by) as $o)
 			{
-				if (substr($o,0,8) == 'contact_') $o = substr($o,8);
+				if (substr($o,0,8) == 'contact_')
+				{
+					$o = substr($o,8);
+				}
 				if (substr($o,-4) == ' ASC')
 				{
 					$sort = 'ASC';
@@ -884,7 +905,10 @@ 
 					{
 						$strc = strcmp($b[$f], $a[$f]);
 					}
-					if ($strc) return $strc;
+					if ($strc)
+					{
+						return $strc;
+					}
 				}
 				return 0;
 			});
@@ -913,12 +937,18 @@ 
 	 */
 	function _colFilter($filter)
 	{
-		if (!is_array($filter)) return '';
+		if (!is_array($filter))
+		{
+			return '';
+		}
 
 		$filters = '';
 		foreach($filter as $key => $value)
 		{
-			if ($key != 'cat_id' && $key != 'account_id' && !$value) continue;
+			if ($key != 'cat_id' && $key != 'account_id' && !$value)
+			{
+				continue;
+			}
 
 			switch((string) $key)
 			{
@@ -933,12 +963,18 @@ 
 					}
 					elseif ($value)
 					{
-						if (is_array($value)) $filters .= '(|';
+						if (is_array($value))
+						{
+							$filters .= '(|';
+						}
 						foreach((array)$value as $value)
 						{
 							$filters .= '(uidNumber='.(int)$value.')';
 						}
-						if (is_array($value)) $filters .= ')';
+						if (is_array($value))
+						{
+							$filters .= ')';
+						}
 					}
 					break;
 
@@ -954,19 +990,28 @@ 
 							$GLOBALS['egw']->categories = new Api\Categories();
 						}
 						$cats = $GLOBALS['egw']->categories->return_all_children((int)$value);
-						if (count($cats) > 1) $filters .= '(|';
+						if (count($cats) > 1)
+						{
+							$filters .= '(|';
+						}
 						foreach($cats as $cat)
 						{
 							$catName = Api\Translation::convert(
 								$GLOBALS['egw']->categories->id2name($cat),$this->charset,'utf-8');
 							$filters .= '(category='.Api\Ldap::quote($catName).')';
 						}
-						if (count($cats) > 1) $filters .= ')';
+						if (count($cats) > 1)
+						{
+							$filters .= ')';
+						}
 					}
 					break;
 
 				case 'carddav_name':
-					if (!is_array($value)) $value = array($value);
+					if (!is_array($value))
+					{
+						$value = array($value);
+					}
 					foreach($value as &$v)
 					{
 						$v = basename($v, '.vcf');
@@ -1000,7 +1045,10 @@ 
 					elseif (preg_match("/^([^ ]+) ".preg_quote($GLOBALS['egw']->db->capabilities[Api\Db::CAPABILITY_CASE_INSENSITIV_LIKE])." '(.*)%'$/",$value,$matches))
 					{
 						list(,$name,$value) = $matches;
-						if (strpos($name,'.') !== false) list(,$name) = explode('.',$name);
+						if (strpos($name,'.') !== false)
+						{
+							list(,$name) = explode('.',$name);
+						}
 						foreach($this->schema2egw as $mapping)
 						{
 							if (isset($mapping[$name]))
@@ -1073,13 +1121,20 @@ 
 		{
 			$result = @ldap_list($this->ds, $_ldapContext, $_filter, $_attributes, 0, $this->ldapLimit);
 		}
-		if(!$result || !$entries = ldap_get_entries($this->ds, $result)) return array();
+		if(!$result || !$entries = ldap_get_entries($this->ds, $result))
+		{
+			return array();
+		}
 		//error_log(__METHOD__."('$_ldapContext', '$_filter', ".array2string($_attributes).", $_addressbooktype) result of $entries[count]");
 
 		$this->total = $entries['count'];
 		foreach($entries as $i => $entry)
 		{
-			if (!is_int($i)) continue;	// eg. count
+			if (!is_int($i))
+			{
+				continue;
+			}
+			// eg. count
 
 			$contact = array(
 				'id'  => $entry['uid'][0] ? $entry['uid'][0] : $entry['entryuuid'][0],
@@ -1211,7 +1266,10 @@ 
 					$var => $val,
 				);
 				// create a admin connection to add the needed DN
-				if (!isset($adminDS)) $adminDS = Api\Ldap::factory();
+				if (!isset($adminDS))
+				{
+					$adminDS = Api\Ldap::factory();
+				}
 				if(!@ldap_add($adminDS, $dn, $data))
 				{
 					//echo "<p>ldap_add($adminDS,'$dn',".print_r($data,true).")</p>\n";
@@ -1297,11 +1355,17 @@ 
 			$contact['cat_id'] = array();
 			foreach($data['category'] as $iii => $cat)
 			{
-				if (!is_int($iii)) continue;
+				if (!is_int($iii))
+				{
+					continue;
+				}
 
 				$contact['cat_id'][] = $GLOBALS['egw']->categories->name2id($cat);
 			}
-			if ($contact['cat_id']) $contact['cat_id'] = implode(',',$contact['cat_id']);
+			if ($contact['cat_id'])
+			{
+				$contact['cat_id'] = implode(',',$contact['cat_id']);
+			}
 		}
 		if ($data['primaryphone'])
 		{
@@ -1356,7 +1420,10 @@ 
 	{
 		unset($contact);	// not used, but required by function signature
 		static $shadowExpireNow=null;
-		if (!isset($shadowExpireNow)) $shadowExpireNow = floor((time()-date('Z'))/86400);
+		if (!isset($shadowExpireNow))
+		{
+			$shadowExpireNow = floor((time()-date('Z'))/86400);
+		}
 
 		// exclude expired or deactivated accounts
 		if (isset($data['shadowexpire']) && $data['shadowexpire'][0] <= $shadowExpireNow)
@@ -1401,9 +1468,13 @@ 
 		elseif ($data['adr_one_countryname'])
 		{
 			$ldapContact['c'] = Api\Country::country_code($data['adr_one_countryname']);
-			if ($ldapContact['c'] && strlen($ldapContact['c']) > 2)	// Bad countryname when "custom" selected!
+			if ($ldapContact['c'] && strlen($ldapContact['c']) > 2)
 			{
-				$ldapContact['c'] = array(); // should return error...
+				// Bad countryname when "custom" selected!
+			{
+				$ldapContact['c'] = array();
+			}
+			// should return error...
 			}
 		}
 		elseif ($isUpdate)
@@ -1442,14 +1513,21 @@ 
 		if ($data['adr_one_countrycode'])
 		{
 			$ldapContact['c'] = $data['adr_one_countrycode'];
-			if ($isUpdate) $ldapContact['co'] = array();
+			if ($isUpdate)
+			{
+				$ldapContact['co'] = array();
+			}
 		}
 		elseif ($data['adr_one_countryname'])
 		{
 			$ldapContact['c'] = Api\Country::country_code($data['adr_one_countryname']);
-			if ($ldapContact['c'] && strlen($ldapContact['c']) > 2)	// Bad countryname when "custom" selected!
+			if ($ldapContact['c'] && strlen($ldapContact['c']) > 2)
+			{
+				// Bad countryname when "custom" selected!
 			{
-				$ldapContact['c'] = array(); // should return error...
+				$ldapContact['c'] = array();
+			}
+			// should return error...
 			}
 		}
 		elseif ($isUpdate)

api/src/Vfs/Sqlfs/StreamWrapper.php

Indentation +5 added lines, -5 removed lines

@@ -447,10 +447,10 @@ 
  	 * Important: PHP 5.0 introduced a bug that wasn't fixed until 5.1: the return value has to be the oposite!
  	 *
  	 * if(version_compare(PHP_VERSION,'5.0','>=') && version_compare(PHP_VERSION,'5.1','<'))
-  	 * {
+ 	 * {
  	 * 		$eof = !$eof;
  	 * }
-  	 *
+ 	 *
  	 * @return boolean true if the read/write position is at the end of the stream and no more data availible, false otherwise
  	 */
 	function stream_eof ( )
@@ -485,7 +485,7 @@ 
  	 * See fseek() for more information about these parameters.
  	 *
  	 * @param integer $offset
-  	 * @param integer $whence	SEEK_SET - 0 - Set position equal to offset bytes
+ 	 * @param integer $whence	SEEK_SET - 0 - Set position equal to offset bytes
  	 * 							SEEK_CUR - 1 - Set position to current location plus offset.
  	 * 							SEEK_END - 2 - Set position to end-of-file plus offset. (To move to a position before the end-of-file, you need to pass a negative value in offset.)
  	 * @return boolean TRUE if the position was updated, FALSE otherwise.
@@ -681,8 +681,8 @@ 
 		$maxdepth=10;
 		$depth2propagate = (int)$depth + 1;
 		if ($depth2propagate > $maxdepth) return is_dir($pathname);
-    	is_dir(Vfs::dirname($pathname)) || self::mkdir_recursive(Vfs::dirname($pathname), $mode, $depth2propagate);
-    	return is_dir($pathname) || @mkdir($pathname, $mode);
+		is_dir(Vfs::dirname($pathname)) || self::mkdir_recursive(Vfs::dirname($pathname), $mode, $depth2propagate);
+		return is_dir($pathname) || @mkdir($pathname, $mode);
 	}
 
 	/**

Doc Comments +7 added lines, -4 removed lines

@@ -504,7 +504,7 @@ 
 	 *
 	 * If you have cached data in your stream but not yet stored it into the underlying storage, you should do so now.
 	 *
-	 * @return booelan TRUE if the cached data was successfully stored (or if there was no data to store), or FALSE if the data could not be stored.
+	 * @return boolean TRUE if the cached data was successfully stored (or if there was no data to store), or FALSE if the data could not be stored.
 	 */
 	function stream_flush ( )
 	{
@@ -673,6 +673,8 @@ 
 
 	/**
 	 * due to problems with recursive directory creation, we have our own here
+	 * @param false|string $pathname
+	 * @param integer $mode
 	 */
 	protected static function mkdir_recursive($pathname, $mode, $depth=0)
 	{
@@ -1058,7 +1060,7 @@ 
 	 *
 	 * @param string $url URL that was passed to opendir() and that this object is expected to explore.
 	 * @param int $options
-	 * @return booelan
+	 * @return boolean
 	 */
 	function dir_opendir ( $url, $options )
 	{
@@ -1458,7 +1460,7 @@ 
 	 *
 	 * @param string $path string with path
 	 * @param int $rights =null rights to set, or null to delete the entry
-	 * @param int|boolean $owner =null owner for whom to set the rights, null for the current user, or false to delete all rights for $path
+	 * @param boolean $owner =null owner for whom to set the rights, null for the current user, or false to delete all rights for $path
 	 * @param int $fs_id =null fs_id to use, to not query it again (eg. because it's already deleted)
 	 * @return boolean true if acl is set/deleted, false on error
 	 */
@@ -1782,6 +1784,7 @@ 
 	 * Replace the password of an url with '...' for error messages
 	 *
 	 * @param string &$url
+	 * @param string $url
 	 */
 	static protected function _remove_password(&$url)
 	{
@@ -1797,7 +1800,7 @@ 
 	/**
 	 * Get storage mode from url (get parameter 'storage', eg. ?storage=db)
 	 *
-	 * @param string|array $url complete url or array of url-parts from parse_url
+	 * @param string $url complete url or array of url-parts from parse_url
 	 * @return int self::STORE2FS or self::STORE2DB
 	 */
 	static function url2operation($url)

Spacing +226 added lines, -228 removed lines

@@ -67,7 +67,7 @@ 
 	/**
 	 * mode-bits, which have to be set for directories
 	 */
-	const MODE_DIR =   040000;
+	const MODE_DIR = 040000;
 	/**
 	 * mode-bits, which have to be set for links
 	 */
@@ -169,10 +169,10 @@ 
 	 *
 	 * @param string $path ='/'
 	 */
-	public static function clearstatcache($path='/')
+	public static function clearstatcache($path = '/')
 	{
 		//error_log(__METHOD__."('$path')");
-		unset($path);	// not used
+		unset($path); // not used
 
 		self::$stat_cache = array();
 
@@ -191,32 +191,32 @@ 
 	 * @param string &$opened_path full path of the file/resource, if the open was successfull and STREAM_USE_PATH was set
 	 * @return boolean true if the ressource was opened successful, otherwise false
 	 */
-	function stream_open ($url, $mode, $options, &$opened_path)
+	function stream_open($url, $mode, $options, &$opened_path)
 	{
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url,$mode,$options)");
 
-		$path = Vfs::parse_url($url,PHP_URL_PATH);
+		$path = Vfs::parse_url($url, PHP_URL_PATH);
 		$this->operation = self::url2operation($url);
 		$dir = Vfs::dirname($url);
 
 		$this->opened_path = $opened_path = $path;
-		$this->opened_mode = $mode = str_replace('b','',$mode);	// we are always binary, like every Linux system
+		$this->opened_mode = $mode = str_replace('b', '', $mode); // we are always binary, like every Linux system
 		$this->opened_stream = null;
 
 		parse_str(parse_url($url, PHP_URL_QUERY), $this->dir_url_params);
 
-		if (!is_null($this->overwrite_new) || !($stat = $this->url_stat($path,STREAM_URL_STAT_QUIET)) || $mode[0] == 'x')	// file not found or file should NOT exist
+		if (!is_null($this->overwrite_new) || !($stat = $this->url_stat($path, STREAM_URL_STAT_QUIET)) || $mode[0] == 'x')	// file not found or file should NOT exist
 		{
-			if (!$dir || $mode[0] == 'r' ||	// does $mode require the file to exist (r,r+)
-				$mode[0] == 'x' && $stat ||	// or file should not exist, but does
-				!($dir_stat=$this->url_stat($dir,STREAM_URL_STAT_QUIET)) ||	// or parent dir does not exist																																			create it
-				!Vfs::check_access($dir,Vfs::WRITABLE,$dir_stat))	// or we are not allowed to 																																			create it
+			if (!$dir || $mode[0] == 'r' || // does $mode require the file to exist (r,r+)
+				$mode[0] == 'x' && $stat || // or file should not exist, but does
+				!($dir_stat = $this->url_stat($dir, STREAM_URL_STAT_QUIET)) || // or parent dir does not exist																																			create it
+				!Vfs::check_access($dir, Vfs::WRITABLE, $dir_stat))	// or we are not allowed to 																																			create it
 			{
 				self::_remove_password($url);
 				if (self::LOG_LEVEL) error_log(__METHOD__."($url,$mode,$options) file does not exist or can not be created!");
-				if (($options & STREAM_REPORT_ERRORS))
+				if (($options&STREAM_REPORT_ERRORS))
 				{
-					trigger_error(__METHOD__."($url,$mode,$options) file does not exist or can not be created!",E_USER_WARNING);
+					trigger_error(__METHOD__."($url,$mode,$options) file does not exist or can not be created!", E_USER_WARNING);
 				}
 				$this->opened_stream = $this->opened_path = $this->opened_mode = null;
 				return false;
@@ -231,7 +231,7 @@ 
 				'fs_name' => self::limit_filename(Vfs::basename($path)),
 				'fs_dir'  => $dir_stat['ino'],
 				// we use the mode of the dir, so files in group dirs stay accessible by all members
-				'fs_mode' => $dir_stat['mode'] & 0666,
+				'fs_mode' => $dir_stat['mode']&0666,
 				// for the uid we use the uid of the dir if not 0=root or the current user otherwise
 				'fs_uid'  => $dir_stat['uid'] ? $dir_stat['uid'] : Vfs::$user,
 				// we allways use the group of the dir
@@ -239,7 +239,7 @@ 
 				'fs_created'  => self::_pdo_timestamp(time()),
 				'fs_modified' => self::_pdo_timestamp(time()),
 				'fs_creator'  => Vfs::$user,
-				'fs_mime'     => 'application/octet-stream',	// required NOT NULL!
+				'fs_mime'     => 'application/octet-stream', // required NOT NULL!
 				'fs_size'     => 0,
 				'fs_active'   => self::_pdo_boolean(true),
 			);
@@ -256,35 +256,35 @@ 
 				$this->opened_stream = tmpfile();
 			}
 			// create the hash-dirs, if they not yet exist
-			elseif(!file_exists($fs_dir=Vfs::dirname(self::_fs_path($this->opened_fs_id))))
+			elseif (!file_exists($fs_dir = Vfs::dirname(self::_fs_path($this->opened_fs_id))))
 			{
 				$umaskbefore = umask();
 				if (self::LOG_LEVEL > 1) error_log(__METHOD__." about to call mkdir for $fs_dir # Present UMASK:".decoct($umaskbefore)." called from:".function_backtrace());
-				self::mkdir_recursive($fs_dir,0700,true);
+				self::mkdir_recursive($fs_dir, 0700, true);
 			}
 		}
 		// check if opend file is a directory
-		elseif($stat && ($stat['mode'] & self::MODE_DIR) == self::MODE_DIR)
+		elseif ($stat && ($stat['mode']&self::MODE_DIR) == self::MODE_DIR)
 		{
 				if (self::LOG_LEVEL) error_log(__METHOD__."($url,$mode,$options) Is a directory!");
-				if (($options & STREAM_REPORT_ERRORS))
+				if (($options&STREAM_REPORT_ERRORS))
 				{
-					trigger_error(__METHOD__."($url,$mode,$options) Is a directory!",E_USER_WARNING);
+					trigger_error(__METHOD__."($url,$mode,$options) Is a directory!", E_USER_WARNING);
 				}
 				$this->opened_stream = $this->opened_path = $this->opened_mode = null;
 				return false;
 		}
 		else
 		{
-			if ($mode == 'r' && !Vfs::check_access($url,Vfs::READABLE ,$stat) ||// we are not allowed to read
-				$mode != 'r' && !Vfs::check_access($url,Vfs::WRITABLE,$stat))	// or edit it
+			if ($mode == 'r' && !Vfs::check_access($url, Vfs::READABLE, $stat) || // we are not allowed to read
+				$mode != 'r' && !Vfs::check_access($url, Vfs::WRITABLE, $stat))	// or edit it
 			{
 				self::_remove_password($url);
 				$op = $mode == 'r' ? 'read' : 'edited';
 				if (self::LOG_LEVEL) error_log(__METHOD__."($url,$mode,$options) file can not be $op!");
-				if (($options & STREAM_REPORT_ERRORS))
+				if (($options&STREAM_REPORT_ERRORS))
 				{
-					trigger_error(__METHOD__."($url,$mode,$options) file can not be $op!",E_USER_WARNING);
+					trigger_error(__METHOD__."($url,$mode,$options) file can not be $op!", E_USER_WARNING);
 				}
 				$this->opened_stream = $this->opened_path = $this->opened_mode = null;
 				return false;
@@ -293,9 +293,9 @@ 
 
 			if ($this->operation == self::STORE2DB)
 			{
-				$stmt = self::$pdo->prepare($sql='SELECT fs_content FROM '.self::TABLE.' WHERE fs_id=?');
+				$stmt = self::$pdo->prepare($sql = 'SELECT fs_content FROM '.self::TABLE.' WHERE fs_id=?');
 				$stmt->execute(array($stat['ino']));
-				$stmt->bindColumn(1,$this->opened_stream,\PDO::PARAM_LOB);
+				$stmt->bindColumn(1, $this->opened_stream, \PDO::PARAM_LOB);
 				$stmt->fetch(\PDO::FETCH_BOUND);
 				// hack to work around a current php bug (http://bugs.php.net/bug.php?id=40913)
 				// PDOStatement::bindColumn(,,\PDO::PARAM_LOB) is not working for MySQL, content is returned as string :-(
@@ -314,7 +314,7 @@ 
 		if ($this->operation == self::STORE2FS)
 		{
 			if (self::LOG_LEVEL > 1) error_log(__METHOD__." fopen (may create a directory? mkdir) ($this->opened_fs_id,$mode,$options)");
-			if (!($this->opened_stream = fopen(self::_fs_path($this->opened_fs_id),$mode)) && $new_file)
+			if (!($this->opened_stream = fopen(self::_fs_path($this->opened_fs_id), $mode)) && $new_file)
 			{
 				// delete db entry again, if we are not able to open a new(!) file
 				unset($stmt);
@@ -324,7 +324,7 @@ 
 		}
 		if ($mode[0] == 'a')	// append modes: a, a+
 		{
-			$this->stream_seek(0,SEEK_END);
+			$this->stream_seek(0, SEEK_END);
 		}
 		if (!is_resource($this->opened_stream)) error_log(__METHOD__."($url,$mode,$options) NO stream, returning false!");
 
@@ -336,7 +336,7 @@ 
 	 *
 	 * You must release any resources that were locked or allocated by the stream.
 	 */
-	function stream_close ( )
+	function stream_close( )
 	{
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."()");
 
@@ -347,7 +347,7 @@ 
 
 		if ($this->opened_mode != 'r')
 		{
-			$this->stream_seek(0,SEEK_END);
+			$this->stream_seek(0, SEEK_END);
 
 			// we need to update the mime-type, size and content (if STORE2DB)
 			$values = array(
@@ -370,10 +370,10 @@ 
 			else
 			{
 				$stmt = self::$pdo->prepare('UPDATE '.self::TABLE.' SET fs_size=:fs_size,fs_mime=:fs_mime,fs_modifier=:fs_modifier,fs_modified=:fs_modified,fs_content=:fs_content WHERE fs_id=:fs_id');
-				$this->stream_seek(0,SEEK_SET);	// rewind to the start
-				foreach($values as $name => &$value)
+				$this->stream_seek(0, SEEK_SET); // rewind to the start
+				foreach ($values as $name => &$value)
 				{
-					$stmt->bindParam($name,$value);
+					$stmt->bindParam($name, $value);
 				}
 				$stmt->bindParam('fs_content', $this->opened_stream, \PDO::PARAM_LOB);
 				if (!($ret = $stmt->execute()))
@@ -406,13 +406,13 @@ 
 	 * @param int $count
 	 * @return string/false up to count bytes read or false on EOF
 	 */
-	function stream_read ( $count )
+	function stream_read($count)
 	{
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($count) pos=$this->opened_pos");
 
 		if (is_resource($this->opened_stream))
 		{
-			return fread($this->opened_stream,$count);
+			return fread($this->opened_stream, $count);
 		}
 		return false;
 	}
@@ -428,13 +428,13 @@ 
 	 * @param string $data
 	 * @return integer
 	 */
-	function stream_write ( $data )
+	function stream_write($data)
 	{
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($data)");
 
 		if (is_resource($this->opened_stream))
 		{
-			return fwrite($this->opened_stream,$data);
+			return fwrite($this->opened_stream, $data);
 		}
 		return false;
 	}
@@ -451,7 +451,7 @@ 
   	 *
  	 * @return boolean true if the read/write position is at the end of the stream and no more data availible, false otherwise
  	 */
-	function stream_eof ( )
+	function stream_eof( )
 	{
 		if (is_resource($this->opened_stream))
 		{
@@ -465,7 +465,7 @@ 
 	 *
 	 * @return integer current read/write position of the stream
 	 */
- 	function stream_tell ( )
+ 	function stream_tell( )
  	{
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."()");
 
@@ -488,13 +488,13 @@ 
  	 * 							SEEK_END - 2 - Set position to end-of-file plus offset. (To move to a position before the end-of-file, you need to pass a negative value in offset.)
  	 * @return boolean TRUE if the position was updated, FALSE otherwise.
  	 */
-	function stream_seek ( $offset, $whence )
+	function stream_seek($offset, $whence)
 	{
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($offset,$whence)");
 
 		if (is_resource($this->opened_stream))
 		{
-			return !fseek($this->opened_stream,$offset,$whence);	// fseek returns 0 on success and -1 on failure
+			return !fseek($this->opened_stream, $offset, $whence); // fseek returns 0 on success and -1 on failure
 		}
 		return false;
 	}
@@ -506,7 +506,7 @@ 
 	 *
 	 * @return booelan TRUE if the cached data was successfully stored (or if there was no data to store), or FALSE if the data could not be stored.
 	 */
-	function stream_flush ( )
+	function stream_flush( )
 	{
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."()");
 
@@ -531,11 +531,11 @@ 
 	 *
 	 * @return array containing the same values as appropriate for the stream.
 	 */
-	function stream_stat ( )
+	function stream_stat( )
 	{
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($this->opened_path)");
 
-		return $this->url_stat($this->opened_path,0);
+		return $this->url_stat($this->opened_path, 0);
 	}
 
 	/**
@@ -547,28 +547,28 @@ 
 	 * @param string $url
 	 * @return boolean TRUE on success or FALSE on failure
 	 */
-	function unlink ( $url )
+	function unlink($url)
 	{
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url)");
 
-		$path = Vfs::parse_url($url,PHP_URL_PATH);
+		$path = Vfs::parse_url($url, PHP_URL_PATH);
 
 		// need to get parent stat from Sqlfs, not Vfs
 		$parent_stat = !($dir = Vfs::dirname($path)) ? false :
 			$this->url_stat($dir, STREAM_URL_STAT_LINK);
 
-		if (!$parent_stat || !($stat = $this->url_stat($path,STREAM_URL_STAT_LINK)) ||
+		if (!$parent_stat || !($stat = $this->url_stat($path, STREAM_URL_STAT_LINK)) ||
 			!$dir || !Vfs::check_access($dir, Vfs::WRITABLE, $parent_stat))
 		{
 			self::_remove_password($url);
 			if (self::LOG_LEVEL) error_log(__METHOD__."($url) permission denied!");
-			return false;	// no permission or file does not exist
+			return false; // no permission or file does not exist
 		}
 		if ($stat['mime'] == self::DIR_MIME_TYPE)
 		{
 			self::_remove_password($url);
 			if (self::LOG_LEVEL) error_log(__METHOD__."($url) is NO file!");
-			return false;	// no permission or file does not exist
+			return false; // no permission or file does not exist
 		}
 		$stmt = self::$pdo->prepare('DELETE FROM '.self::TABLE.' WHERE fs_id=:fs_id');
 		unset(self::$stat_cache[$path]);
@@ -576,7 +576,7 @@ 
 		if (($ret = $stmt->execute(array('fs_id' => $stat['ino']))))
 		{
 			if (self::url2operation($url) == self::STORE2FS &&
-				($stat['mode'] & self::MODE_LINK) != self::MODE_LINK)
+				($stat['mode']&self::MODE_LINK) != self::MODE_LINK)
 			{
 				unlink(self::_fs_path($stat['ino']));
 			}
@@ -600,13 +600,13 @@ 
 	 * @param string $url_to
 	 * @return boolean TRUE on success or FALSE on failure
 	 */
-	function rename ( $url_from, $url_to)
+	function rename($url_from, $url_to)
 	{
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url_from,$url_to)");
 
-		$path_from = Vfs::parse_url($url_from,PHP_URL_PATH);
+		$path_from = Vfs::parse_url($url_from, PHP_URL_PATH);
 		$from_dir = Vfs::dirname($path_from);
-		$path_to = Vfs::parse_url($url_to,PHP_URL_PATH);
+		$path_to = Vfs::parse_url($url_to, PHP_URL_PATH);
 		$to_dir = Vfs::dirname($path_to);
 
 		if (!($from_stat = $this->url_stat($path_from, 0)) || !$from_dir ||
@@ -615,14 +615,14 @@ 
 			self::_remove_password($url_from);
 			self::_remove_password($url_to);
 			if (self::LOG_LEVEL) error_log(__METHOD__."($url_from,$url_to): $path_from permission denied!");
-			return false;	// no permission or file does not exist
+			return false; // no permission or file does not exist
 		}
 		if (!$to_dir || !Vfs::check_access($to_dir, Vfs::WRITABLE, $to_dir_stat = $this->url_stat($to_dir, 0)))
 		{
 			self::_remove_password($url_from);
 			self::_remove_password($url_to);
 			if (self::LOG_LEVEL) error_log(__METHOD__."($url_from,$url_to): $path_to permission denied!");
-			return false;	// no permission or parent-dir does not exist
+			return false; // no permission or parent-dir does not exist
 		}
 		// the filesystem stream-wrapper does NOT allow to rename files to directories, as this makes problems
 		// for our vfs too, we abort here with an error, like the filesystem one does
@@ -633,7 +633,7 @@ 
 			self::_remove_password($url_to);
 			$is_dir = $to_stat['mime'] === self::DIR_MIME_TYPE ? 'a' : 'no';
 			if (self::LOG_LEVEL) error_log(__METHOD__."($url_to,$url_from) $path_to is $is_dir directory!");
-			return false;	// no permission or file does not exist
+			return false; // no permission or file does not exist
 		}
 		// if destination file already exists, delete it
 		if ($to_stat && !$this->unlink($url_to))
@@ -657,7 +657,7 @@ 
 
 		// check if extension changed and update mime-type in that case (as we currently determine mime-type by it's extension!)
 		// fixes eg. problems with MsWord storing file with .tmp extension and then renaming to .doc
-		if ($ok && ($new_mime = Vfs::mime_content_type($url_to,true)) != Vfs::mime_content_type($url_to))
+		if ($ok && ($new_mime = Vfs::mime_content_type($url_to, true)) != Vfs::mime_content_type($url_to))
 		{
 			//echo "<p>Vfs::nime_content_type($url_to,true) = $new_mime</p>\n";
 			$stmt = self::$pdo->prepare('UPDATE '.self::TABLE.' SET fs_mime=:fs_mime WHERE fs_id=:fs_id');
@@ -673,9 +673,9 @@ 
 	/**
 	 * due to problems with recursive directory creation, we have our own here
 	 */
-	protected static function mkdir_recursive($pathname, $mode, $depth=0)
+	protected static function mkdir_recursive($pathname, $mode, $depth = 0)
 	{
-		$maxdepth=10;
+		$maxdepth = 10;
 		$depth2propagate = (int)$depth + 1;
 		if ($depth2propagate > $maxdepth) return is_dir($pathname);
     	is_dir(Vfs::dirname($pathname)) || self::mkdir_recursive(Vfs::dirname($pathname), $mode, $depth2propagate);
@@ -693,19 +693,19 @@ 
 	 * @param int $options Posible values include STREAM_REPORT_ERRORS and STREAM_MKDIR_RECURSIVE
 	 * @return boolean TRUE on success or FALSE on failure
 	 */
-	function mkdir ( $url, $mode, $options )
+	function mkdir($url, $mode, $options)
 	{
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url,$mode,$options)");
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__." called from:".function_backtrace());
-		$path = Vfs::parse_url($url,PHP_URL_PATH);
+		$path = Vfs::parse_url($url, PHP_URL_PATH);
 
-		if ($this->url_stat($path,STREAM_URL_STAT_QUIET))
+		if ($this->url_stat($path, STREAM_URL_STAT_QUIET))
 		{
 			self::_remove_password($url);
 			if (self::LOG_LEVEL) error_log(__METHOD__."('$url',$mode,$options) already exist!");
-			if (!($options & STREAM_REPORT_ERRORS))
+			if (!($options&STREAM_REPORT_ERRORS))
 			{
-				trigger_error(__METHOD__."('$url',$mode,$options) already exist!",E_USER_WARNING);
+				trigger_error(__METHOD__."('$url',$mode,$options) already exist!", E_USER_WARNING);
 			}
 			return false;
 		}
@@ -713,35 +713,35 @@ 
 		{
 			self::_remove_password($url);
 			if (self::LOG_LEVEL) error_log(__METHOD__."('$url',$mode,$options) dirname('$path')===false!");
-			if (!($options & STREAM_REPORT_ERRORS))
+			if (!($options&STREAM_REPORT_ERRORS))
 			{
 				trigger_error(__METHOD__."('$url',$mode,$options) dirname('$path')===false!", E_USER_WARNING);
 			}
 			return false;
 		}
-		if (($query = Vfs::parse_url($url,PHP_URL_QUERY))) $parent_path .= '?'.$query;
-		$parent = $this->url_stat($parent_path,STREAM_URL_STAT_QUIET);
+		if (($query = Vfs::parse_url($url, PHP_URL_QUERY))) $parent_path .= '?'.$query;
+		$parent = $this->url_stat($parent_path, STREAM_URL_STAT_QUIET);
 
 		// check if we should also create all non-existing path components and our parent does not exist,
 		// if yes call ourself recursive with the parent directory
-		if (($options & STREAM_MKDIR_RECURSIVE) && $parent_path != '/' && !$parent)
+		if (($options&STREAM_MKDIR_RECURSIVE) && $parent_path != '/' && !$parent)
 		{
 			if (self::LOG_LEVEL > 1) error_log(__METHOD__." creating parents: $parent_path, $mode");
-			if (!$this->mkdir($parent_path,$mode,$options))
+			if (!$this->mkdir($parent_path, $mode, $options))
 			{
 				return false;
 			}
-			$parent = $this->url_stat($parent_path,0);
+			$parent = $this->url_stat($parent_path, 0);
 		}
-		if (!$parent || !Vfs::check_access($parent_path,Vfs::WRITABLE,$parent))
+		if (!$parent || !Vfs::check_access($parent_path, Vfs::WRITABLE, $parent))
 		{
 			self::_remove_password($url);
 			if (self::LOG_LEVEL) error_log(__METHOD__."('$url',$mode,$options) permission denied!");
-			if (!($options & STREAM_REPORT_ERRORS))
+			if (!($options&STREAM_REPORT_ERRORS))
 			{
-				trigger_error(__METHOD__."('$url',$mode,$options) permission denied!",E_USER_WARNING);
+				trigger_error(__METHOD__."('$url',$mode,$options) permission denied!", E_USER_WARNING);
 			}
-			return false;	// no permission or file does not exist
+			return false; // no permission or file does not exist
 		}
 		unset(self::$stat_cache[$path]);
 		$stmt = self::$pdo->prepare('INSERT INTO '.self::TABLE.' (fs_name,fs_dir,fs_mode,fs_uid,fs_gid,fs_size,fs_mime,fs_created,fs_modified,fs_creator'.
@@ -762,9 +762,9 @@ 
 			// check if some other process created the directory parallel to us (sqlfs would gives SQL errors later!)
 			$new_fs_id = self::$pdo->lastInsertId('egw_sqlfs_fs_id_seq');
 
-			unset($stmt);	// free statement object, on some installs a new prepare fails otherwise!
+			unset($stmt); // free statement object, on some installs a new prepare fails otherwise!
 
-			$stmt = self::$pdo->prepare($q='SELECT COUNT(*) FROM '.self::TABLE.
+			$stmt = self::$pdo->prepare($q = 'SELECT COUNT(*) FROM '.self::TABLE.
 				' WHERE fs_dir=:fs_dir AND fs_active=:fs_active AND fs_name'.self::$case_sensitive_equal.':fs_name');
 			if ($stmt->execute(array(
 				'fs_dir'  => $parent['ino'],
@@ -788,25 +788,24 @@ 
 	 * @param int $options Possible values include STREAM_REPORT_ERRORS.
 	 * @return boolean TRUE on success or FALSE on failure.
 	 */
-	function rmdir ( $url, $options )
+	function rmdir($url, $options)
 	{
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url)");
 
-		$path = Vfs::parse_url($url,PHP_URL_PATH);
+		$path = Vfs::parse_url($url, PHP_URL_PATH);
 
 		if (!($parent = Vfs::dirname($path)) ||
 			!($stat = $this->url_stat($path, 0)) || $stat['mime'] != self::DIR_MIME_TYPE ||
-			!Vfs::check_access($parent, Vfs::WRITABLE, $this->url_stat($parent,0)))
+			!Vfs::check_access($parent, Vfs::WRITABLE, $this->url_stat($parent, 0)))
 		{
 			self::_remove_password($url);
-			$err_msg = __METHOD__."($url,$options) ".(!$stat ? 'not found!' :
-				($stat['mime'] != self::DIR_MIME_TYPE ? 'not a directory!' : 'permission denied!'));
+			$err_msg = __METHOD__."($url,$options) ".(!$stat ? 'not found!' : ($stat['mime'] != self::DIR_MIME_TYPE ? 'not a directory!' : 'permission denied!'));
 			if (self::LOG_LEVEL) error_log($err_msg);
-			if (!($options & STREAM_REPORT_ERRORS))
+			if (!($options&STREAM_REPORT_ERRORS))
 			{
-				trigger_error($err_msg,E_USER_WARNING);
+				trigger_error($err_msg, E_USER_WARNING);
 			}
-			return false;	// no permission or file does not exist
+			return false; // no permission or file does not exist
 		}
 		$stmt = self::$pdo->prepare('SELECT COUNT(*) FROM '.self::TABLE.' WHERE fs_dir=?');
 		$stmt->execute(array($stat['ino']));
@@ -814,19 +813,19 @@ 
 		{
 			self::_remove_password($url);
 			if (self::LOG_LEVEL) error_log(__METHOD__."($url,$options) dir is not empty!");
-			if (!($options & STREAM_REPORT_ERRORS))
+			if (!($options&STREAM_REPORT_ERRORS))
 			{
-				trigger_error(__METHOD__."('$url',$options) dir is not empty!",E_USER_WARNING);
+				trigger_error(__METHOD__."('$url',$options) dir is not empty!", E_USER_WARNING);
 			}
 			return false;
 		}
 		unset(self::$stat_cache[$path]);
-		unset($stmt);	// free statement object, on some installs a new prepare fails otherwise!
+		unset($stmt); // free statement object, on some installs a new prepare fails otherwise!
 
 		$del_stmt = self::$pdo->prepare('DELETE FROM '.self::TABLE.' WHERE fs_id=?');
 		if (($ret = $del_stmt->execute(array($stat['ino']))))
 		{
-			self::eacl($path,null,false,$stat['ino']);	// remove all (=false) evtl. existing extended acl for that dir
+			self::eacl($path, null, false, $stat['ino']); // remove all (=false) evtl. existing extended acl for that dir
 			// delete props
 			unset($del_stmt);
 			$del_stmt = self::$pdo->prepare('DELETE FROM '.self::PROPS_TABLE.' WHERE fs_id=?');
@@ -853,10 +852,10 @@ 
 	{
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($path, $option, ".array2string($value).")");
 
-		switch($option)
+		switch ($option)
 		{
 			case STREAM_META_TOUCH:
-				return $this->touch($path, $value[0]);	// atime is not supported
+				return $this->touch($path, $value[0]); // atime is not supported
 
 			case STREAM_META_ACCESS:
 				return $this->chmod($path, $value);
@@ -885,26 +884,26 @@ 
 	 * @param int $time =null modification time (unix timestamp), default null = current time
 	 * @param int $atime =null access time (unix timestamp), default null = current time, not implemented in the vfs!
 	 */
-	protected function touch($url,$time=null,$atime=null)
+	protected function touch($url, $time = null, $atime = null)
 	{
-		unset($atime);	// not used
+		unset($atime); // not used
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url, $time)");
 
-		$path = Vfs::parse_url($url,PHP_URL_PATH);
+		$path = Vfs::parse_url($url, PHP_URL_PATH);
 
 		$vfs = new self();
-		if (!($stat = $vfs->url_stat($path,STREAM_URL_STAT_QUIET)))
+		if (!($stat = $vfs->url_stat($path, STREAM_URL_STAT_QUIET)))
 		{
 			// file does not exist --> create an empty one
-			if (!($f = fopen(self::SCHEME.'://default'.$path,'w')) || !fclose($f))
+			if (!($f = fopen(self::SCHEME.'://default'.$path, 'w')) || !fclose($f))
 			{
 				return false;
 			}
 			if (!$time)
 			{
-				return true;	// new (empty) file created with current mod time
+				return true; // new (empty) file created with current mod time
 			}
-			$stat = $vfs->url_stat($path,0);
+			$stat = $vfs->url_stat($path, 0);
 		}
 		unset(self::$stat_cache[$path]);
 		$stmt = self::$pdo->prepare('UPDATE '.self::TABLE.' SET fs_modified=:fs_modified,fs_modifier=:fs_modifier WHERE fs_id=:fs_id');
@@ -923,40 +922,40 @@ 
 	 * @param int $owner
 	 * @return boolean
 	 */
-	protected function chown($url,$owner)
+	protected function chown($url, $owner)
 	{
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url,$owner)");
 
-		$path = Vfs::parse_url($url,PHP_URL_PATH);
+		$path = Vfs::parse_url($url, PHP_URL_PATH);
 
 		$vfs = new self();
-		if (!($stat = $vfs->url_stat($path,0)))
+		if (!($stat = $vfs->url_stat($path, 0)))
 		{
 			if (self::LOG_LEVEL) error_log(__METHOD__."($url,$owner) no such file or directory!");
-			trigger_error("No such file or directory $url !",E_USER_WARNING);
+			trigger_error("No such file or directory $url !", E_USER_WARNING);
 			return false;
 		}
 		if (!Vfs::$is_root)
 		{
 			if (self::LOG_LEVEL) error_log(__METHOD__."($url,$owner) only root can do that!");
-			trigger_error("Only root can do that!",E_USER_WARNING);
+			trigger_error("Only root can do that!", E_USER_WARNING);
 			return false;
 		}
 		if ($owner < 0 || $owner && !$GLOBALS['egw']->accounts->id2name($owner))	// not a user (0 == root)
 		{
 			if (self::LOG_LEVEL) error_log(__METHOD__."($url,$owner) unknown (numeric) user id!");
-			trigger_error(__METHOD__."($url,$owner) Unknown (numeric) user id!",E_USER_WARNING);
+			trigger_error(__METHOD__."($url,$owner) Unknown (numeric) user id!", E_USER_WARNING);
 			//throw new Exception(__METHOD__."($url,$owner) Unknown (numeric) user id!");
 			return false;
 		}
 		$stmt = self::$pdo->prepare('UPDATE '.self::TABLE.' SET fs_uid=:fs_uid WHERE fs_id=:fs_id');
 
 		// update stat-cache
-		if ($path != '/' && substr($path,-1) == '/') $path = substr($path, 0, -1);
+		if ($path != '/' && substr($path, -1) == '/') $path = substr($path, 0, -1);
 		self::$stat_cache[$path]['fs_uid'] = $owner;
 
 		return $stmt->execute(array(
-			'fs_uid' => (int) $owner,
+			'fs_uid' => (int)$owner,
 			'fs_id' => $stat['ino'],
 		));
 	}
@@ -968,37 +967,37 @@ 
 	 * @param int $owner
 	 * @return boolean
 	 */
-	protected function chgrp($url,$owner)
+	protected function chgrp($url, $owner)
 	{
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url,$owner)");
 
-		$path = Vfs::parse_url($url,PHP_URL_PATH);
+		$path = Vfs::parse_url($url, PHP_URL_PATH);
 
 		$vfs = new self();
-		if (!($stat = $vfs->url_stat($path,0)))
+		if (!($stat = $vfs->url_stat($path, 0)))
 		{
 			if (self::LOG_LEVEL) error_log(__METHOD__."($url,$owner) no such file or directory!");
-			trigger_error("No such file or directory $url !",E_USER_WARNING);
+			trigger_error("No such file or directory $url !", E_USER_WARNING);
 			return false;
 		}
-		if (!Vfs::has_owner_rights($path,$stat))
+		if (!Vfs::has_owner_rights($path, $stat))
 		{
 			if (self::LOG_LEVEL) error_log(__METHOD__."($url,$owner) only owner or root can do that!");
-			trigger_error("Only owner or root can do that!",E_USER_WARNING);
+			trigger_error("Only owner or root can do that!", E_USER_WARNING);
 			return false;
 		}
-		if ($owner < 0) $owner = -$owner;	// sqlfs uses a positiv group id's!
+		if ($owner < 0) $owner = -$owner; // sqlfs uses a positiv group id's!
 
 		if ($owner && !$GLOBALS['egw']->accounts->id2name(-$owner))	// not a group
 		{
 			if (self::LOG_LEVEL) error_log(__METHOD__."($url,$owner) unknown (numeric) group id!");
-			trigger_error("Unknown (numeric) group id!",E_USER_WARNING);
+			trigger_error("Unknown (numeric) group id!", E_USER_WARNING);
 			return false;
 		}
 		$stmt = self::$pdo->prepare('UPDATE '.self::TABLE.' SET fs_gid=:fs_gid WHERE fs_id=:fs_id');
 
 		// update stat-cache
-		if ($path != '/' && substr($path,-1) == '/') $path = substr($path, 0, -1);
+		if ($path != '/' && substr($path, -1) == '/') $path = substr($path, 0, -1);
 		self::$stat_cache[$path]['fs_gid'] = $owner;
 
 		return $stmt->execute(array(
@@ -1014,39 +1013,39 @@ 
 	 * @param int $mode
 	 * @return boolean
 	 */
-	protected function chmod($url,$mode)
+	protected function chmod($url, $mode)
 	{
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url, $mode)");
 
-		$path = Vfs::parse_url($url,PHP_URL_PATH);
+		$path = Vfs::parse_url($url, PHP_URL_PATH);
 
 		$vfs = new self();
-		if (!($stat = $vfs->url_stat($path,0)))
+		if (!($stat = $vfs->url_stat($path, 0)))
 		{
 			if (self::LOG_LEVEL) error_log(__METHOD__."($url, $mode) no such file or directory!");
-			trigger_error("No such file or directory $url !",E_USER_WARNING);
+			trigger_error("No such file or directory $url !", E_USER_WARNING);
 			return false;
 		}
-		if (!Vfs::has_owner_rights($path,$stat))
+		if (!Vfs::has_owner_rights($path, $stat))
 		{
 			if (self::LOG_LEVEL) error_log(__METHOD__."($url, $mode) only owner or root can do that!");
-			trigger_error("Only owner or root can do that!",E_USER_WARNING);
+			trigger_error("Only owner or root can do that!", E_USER_WARNING);
 			return false;
 		}
 		if (!is_numeric($mode))	// not a mode
 		{
 			if (self::LOG_LEVEL) error_log(__METHOD__."($url, $mode) no (numeric) mode!");
-			trigger_error("No (numeric) mode!",E_USER_WARNING);
+			trigger_error("No (numeric) mode!", E_USER_WARNING);
 			return false;
 		}
 		$stmt = self::$pdo->prepare('UPDATE '.self::TABLE.' SET fs_mode=:fs_mode WHERE fs_id=:fs_id');
 
 		// update stat cache
-		if ($path != '/' && substr($path,-1) == '/') $path = substr($path, 0, -1);
-		self::$stat_cache[$path]['fs_mode'] = ((int) $mode) & 0777;
+		if ($path != '/' && substr($path, -1) == '/') $path = substr($path, 0, -1);
+		self::$stat_cache[$path]['fs_mode'] = ((int)$mode)&0777;
 
 		return $stmt->execute(array(
-			'fs_mode' => ((int) $mode) & 0777,		// we dont store the file and dir bits, give int overflow!
+			'fs_mode' => ((int)$mode)&0777, // we dont store the file and dir bits, give int overflow!
 			'fs_id' => $stat['ino'],
 		));
 	}
@@ -1059,18 +1058,18 @@ 
 	 * @param int $options
 	 * @return booelan
 	 */
-	function dir_opendir ( $url, $options )
+	function dir_opendir($url, $options)
 	{
 		$this->opened_dir = null;
 
-		$path = Vfs::parse_url($url,PHP_URL_PATH);
+		$path = Vfs::parse_url($url, PHP_URL_PATH);
 
-		if (!($stat = $this->url_stat($url,0)) || 		// dir not found
-			!($stat['mode'] & self::MODE_DIR) && $stat['mime'] != self::DIR_MIME_TYPE ||		// no dir
-			!Vfs::check_access($url,Vfs::EXECUTABLE|Vfs::READABLE,$stat))	// no access
+		if (!($stat = $this->url_stat($url, 0)) || // dir not found
+			!($stat['mode']&self::MODE_DIR) && $stat['mime'] != self::DIR_MIME_TYPE || // no dir
+			!Vfs::check_access($url, Vfs::EXECUTABLE|Vfs::READABLE, $stat))	// no access
 		{
 			self::_remove_password($url);
-			$msg = !($stat['mode'] & self::MODE_DIR) && $stat['mime'] != self::DIR_MIME_TYPE ?
+			$msg = !($stat['mode']&self::MODE_DIR) && $stat['mime'] != self::DIR_MIME_TYPE ?
 				"$url is no directory" : 'permission denied';
 			if (self::LOG_LEVEL) error_log(__METHOD__."('$url',$options) $msg!");
 			$this->opened_dir = null;
@@ -1087,13 +1086,13 @@ 
 		$stmt->setFetchMode(\PDO::FETCH_ASSOC);
 		if ($stmt->execute(array($stat['ino'])))
 		{
-			foreach($stmt as $file)
+			foreach ($stmt as $file)
 			{
 				$this->opened_dir[] = $file['fs_name'];
-				self::$stat_cache[Vfs::concat($path,$file['fs_name'])] = $file;
+				self::$stat_cache[Vfs::concat($path, $file['fs_name'])] = $file;
 			}
 		}
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url,$options): ".implode(', ',$this->opened_dir));
+		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url,$options): ".implode(', ', $this->opened_dir));
 		reset($this->opened_dir);
 
 		return true;
@@ -1125,26 +1124,26 @@ 
 	 *                          stat triggers it's own warning anyway, so it makes no sense to trigger one by our stream-wrapper!
 	 * @return array
 	 */
-	function url_stat ( $url, $flags )
+	function url_stat($url, $flags)
 	{
-		static $max_subquery_depth=null;
+		static $max_subquery_depth = null;
 		if (is_null($max_subquery_depth))
 		{
 			$max_subquery_depth = $GLOBALS['egw_info']['server']['max_subquery_depth'];
-			if (!$max_subquery_depth) $max_subquery_depth = 7;	// setting current default of 7, if nothing set
+			if (!$max_subquery_depth) $max_subquery_depth = 7; // setting current default of 7, if nothing set
 		}
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."('$url',$flags)");
 
-		$path = Vfs::parse_url($url,PHP_URL_PATH);
+		$path = Vfs::parse_url($url, PHP_URL_PATH);
 
 		// webdav adds a trailing slash to dirs, which causes url_stat to NOT find the file otherwise
-		if ($path != '/' && substr($path,-1) == '/')
+		if ($path != '/' && substr($path, -1) == '/')
 		{
-			$path = substr($path,0,-1);
+			$path = substr($path, 0, -1);
 		}
 		if (empty($path))
 		{
-			return false;	// is invalid and gives sql error
+			return false; // is invalid and gives sql error
 		}
 		// check if we already have the info from the last dir_open call, as the old vfs reads it anyway from the db
 		if (self::$stat_cache && isset(self::$stat_cache[$path]) && self::$stat_cache[$path] !== false)
@@ -1159,25 +1158,25 @@ 
 		$base_query = 'SELECT fs_id,fs_name,fs_mode,fs_uid,fs_gid,fs_size,fs_mime,fs_created,fs_modified'.self::$extra_columns.
 			' FROM '.self::TABLE.' WHERE fs_active='.self::_pdo_boolean(true).
 			' AND fs_name'.self::$case_sensitive_equal.'? AND fs_dir=';
-		$parts = explode('/',$path);
+		$parts = explode('/', $path);
 
 		// if we have extended acl access to the url, we dont need and can NOT include the sql for the readable check
-		$eacl_access = static::check_extended_acl($path,Vfs::READABLE);
+		$eacl_access = static::check_extended_acl($path, Vfs::READABLE);
 
 		try {
-			foreach($parts as $n => $name)
+			foreach ($parts as $n => $name)
 			{
 				if ($n == 0)
 				{
-					$query = (int) ($path != '/');	// / always has fs_id == 1, no need to query it ($path=='/' needs fs_dir=0!)
+					$query = (int)($path != '/'); // / always has fs_id == 1, no need to query it ($path=='/' needs fs_dir=0!)
 				}
-				elseif ($n < count($parts)-1)
+				elseif ($n < count($parts) - 1)
 				{
 					// MySQL 5.0 has a nesting limit for subqueries
 					// --> we replace the so far cumulated subqueries with their result
 					// no idea about the other DBMS, but this does NOT hurt ...
 					// --> depth limit of subqueries is now dynamicly decremented in catch
-					if ($n > 1 && !(($n-1) % $max_subquery_depth) && !($query = self::$pdo->query($query)->fetchColumn()))
+					if ($n > 1 && !(($n - 1) % $max_subquery_depth) && !($query = self::$pdo->query($query)->fetchColumn()))
 					{
 						if (self::LOG_LEVEL > 1)
 						{
@@ -1204,7 +1203,7 @@ 
 				}
 				else
 				{
-					$query = str_replace('fs_name'.self::$case_sensitive_equal.'?','fs_name'.self::$case_sensitive_equal.self::$pdo->quote($name),$base_query).'('.$query.')';
+					$query = str_replace('fs_name'.self::$case_sensitive_equal.'?', 'fs_name'.self::$case_sensitive_equal.self::$pdo->quote($name), $base_query).'('.$query.')';
 				}
 			}
 			if (self::LOG_LEVEL > 2) $query = '/* '.__METHOD__."($url,$flags) eacl_access=$eacl_access".' */ '.$query;
@@ -1230,7 +1229,7 @@ 
 			$GLOBALS['egw_info']['server']['max_subquery_depth'] = --$max_subquery_depth;
 			error_log(__METHOD__."() decremented max_subquery_depth to $max_subquery_depth");
 			Api\Config::save_value('max_subquery_depth', $max_subquery_depth, 'phpgwapi');
-			if (method_exists($GLOBALS['egw'],'invalidate_session_cache')) $GLOBALS['egw']->invalidate_session_cache();
+			if (method_exists($GLOBALS['egw'], 'invalidate_session_cache')) $GLOBALS['egw']->invalidate_session_cache();
 			return $this->url_stat($url, $flags);
 		}
 		self::$stat_cache[$path] = $info;
@@ -1246,18 +1245,18 @@ 
 	 */
 	protected static function _sql_readable()
 	{
-		static $sql_read_acl=null;
+		static $sql_read_acl = null;
 
 		if (is_null($sql_read_acl))
 		{
-			foreach($GLOBALS['egw']->accounts->memberships(Vfs::$user,true) as $gid)
+			foreach ($GLOBALS['egw']->accounts->memberships(Vfs::$user, true) as $gid)
 			{
-				$memberships[] = abs($gid);	// sqlfs stores the gid's positiv
+				$memberships[] = abs($gid); // sqlfs stores the gid's positiv
 			}
 			// using octal numbers with mysql leads to funny results (select 384 & 0400 --> 384 not 256=0400)
 			// 256 = 0400, 32 = 040
 			$sql_read_acl = '((fs_mode & 4)=4 OR (fs_mode & 256)=256 AND fs_uid='.(int)Vfs::$user.
-				($memberships ? ' OR (fs_mode & 32)=32 AND fs_gid IN('.implode(',',$memberships).')' : '').')';
+				($memberships ? ' OR (fs_mode & 32)=32 AND fs_gid IN('.implode(',', $memberships).')' : '').')';
 			//error_log(__METHOD__."() Vfs::\$user=".array2string(Vfs::$user).' --> memberships='.array2string($memberships).' --> '.$sql_read_acl.($memberships?'':': '.function_backtrace()));
 		}
 		return $sql_read_acl;
@@ -1270,7 +1269,7 @@ 
 	 *
 	 * @return string
 	 */
-	function dir_readdir ( )
+	function dir_readdir( )
 	{
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."( )");
 
@@ -1289,7 +1288,7 @@ 
 	 *
 	 * @return boolean
 	 */
-	function dir_rewinddir ( )
+	function dir_rewinddir( )
 	{
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."( )");
 
@@ -1307,7 +1306,7 @@ 
 	 *
 	 * @return boolean
 	 */
-	function dir_closedir ( )
+	function dir_closedir( )
 	{
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."( )");
 
@@ -1329,7 +1328,7 @@ 
 	static function readlink($path)
 	{
 		$vfs = new self();
-		$link = !($lstat = $vfs->url_stat($path,STREAM_URL_STAT_LINK)) || is_null($lstat['readlink']) ? false : $lstat['readlink'];
+		$link = !($lstat = $vfs->url_stat($path, STREAM_URL_STAT_LINK)) || is_null($lstat['readlink']) ? false : $lstat['readlink'];
 
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."('$path') = $link");
 
@@ -1343,32 +1342,32 @@ 
 	 * @param string $link
 	 * @return boolean true on success false on error
 	 */
-	static function symlink($target,$link)
+	static function symlink($target, $link)
 	{
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."('$target','$link')");
 
 		$inst = new static();
-		if ($inst->url_stat($link,0))
+		if ($inst->url_stat($link, 0))
 		{
 			if (self::LOG_LEVEL > 0) error_log(__METHOD__."('$target','$link') $link exists, returning false!");
-			return false;	// $link already exists
+			return false; // $link already exists
 		}
 		if (!($dir = Vfs::dirname($link)) ||
-			!Vfs::check_access($dir,Vfs::WRITABLE,$dir_stat=$inst->url_stat($dir,0)))
+			!Vfs::check_access($dir, Vfs::WRITABLE, $dir_stat = $inst->url_stat($dir, 0)))
 		{
 			if (self::LOG_LEVEL > 0) error_log(__METHOD__."('$target','$link') returning false! (!is_writable('$dir'), dir_stat=".array2string($dir_stat).")");
-			return false;	// parent dir does not exist or is not writable
+			return false; // parent dir does not exist or is not writable
 		}
 		$query = 'INSERT INTO '.self::TABLE.' (fs_name,fs_dir,fs_mode,fs_uid,fs_gid,fs_created,fs_modified,fs_creator,fs_mime,fs_size,fs_link'.
 			') VALUES (:fs_name,:fs_dir,:fs_mode,:fs_uid,:fs_gid,:fs_created,:fs_modified,:fs_creator,:fs_mime,:fs_size,:fs_link)';
 		if (self::LOG_LEVEL > 2) $query = '/* '.__METHOD__.': '.__LINE__.' */ '.$query;
 		$stmt = self::$pdo->prepare($query);
-		unset(self::$stat_cache[Vfs::parse_url($link,PHP_URL_PATH)]);
+		unset(self::$stat_cache[Vfs::parse_url($link, PHP_URL_PATH)]);
 
 		return !!$stmt->execute(array(
 			'fs_name' => self::limit_filename(Vfs::basename($link)),
 			'fs_dir'  => $dir_stat['ino'],
-			'fs_mode' => ($dir_stat['mode'] & 0666),
+			'fs_mode' => ($dir_stat['mode']&0666),
 			'fs_uid'  => $dir_stat['uid'] ? $dir_stat['uid'] : Vfs::$user,
 			'fs_gid'  => $dir_stat['gid'],
 			'fs_created'  => self::_pdo_timestamp(time()),
@@ -1392,24 +1391,24 @@ 
 	 * @param int $check mode to check: one or more or'ed together of: 4 = read, 2 = write, 1 = executable
 	 * @return boolean
 	 */
-	static function check_extended_acl($url,$check)
+	static function check_extended_acl($url, $check)
 	{
-		$url_path = Vfs::parse_url($url,PHP_URL_PATH);
+		$url_path = Vfs::parse_url($url, PHP_URL_PATH);
 
 		if (is_null(self::$extended_acl))
 		{
 			self::_read_extended_acl();
 		}
 		$access = false;
-		foreach(self::$extended_acl as $path => $rights)
+		foreach (self::$extended_acl as $path => $rights)
 		{
-			if ($path == $url_path || substr($url_path,0,strlen($path)+1) == $path.'/')
+			if ($path == $url_path || substr($url_path, 0, strlen($path) + 1) == $path.'/')
 			{
-				$access = ($rights & $check) == $check;
+				$access = ($rights&$check) == $check;
 				break;
 			}
 		}
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url,$check) ".($access?"access granted by $path=$rights":'no access!!!'));
+		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url,$check) ".($access ? "access granted by $path=$rights" : 'no access!!!'));
 		return $access;
 	}
 
@@ -1421,14 +1420,14 @@ 
 	{
 		if ((self::$extended_acl = Api\Cache::getSession(self::EACL_APPNAME, 'extended_acl')))
 		{
-			return;		// ext. ACL read from session.
+			return; // ext. ACL read from session.
 		}
 		self::$extended_acl = array();
-		if (($rights = $GLOBALS['egw']->acl->get_all_location_rights(Vfs::$user,self::EACL_APPNAME)))
+		if (($rights = $GLOBALS['egw']->acl->get_all_location_rights(Vfs::$user, self::EACL_APPNAME)))
 		{
 			$pathes = self::id2path(array_keys($rights));
 		}
-		foreach($rights as $fs_id => $right)
+		foreach ($rights as $fs_id => $right)
 		{
 			$path = $pathes[$fs_id];
 			if (isset($path))
@@ -1437,8 +1436,8 @@ 
 			}
 		}
 		// sort by length descending, to allow more specific pathes to have precedence
-		uksort(self::$extended_acl, function($a,$b) {
-			return strlen($b)-strlen($a);
+		uksort(self::$extended_acl, function($a, $b) {
+			return strlen($b) - strlen($a);
 		});
 		Api\Cache::setSession(self::EACL_APPNAME, 'extended_acl', self::$extended_acl);
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__.'() '.array2string(self::$extended_acl));
@@ -1460,24 +1459,24 @@ 
 	 * @param int $fs_id =null fs_id to use, to not query it again (eg. because it's already deleted)
 	 * @return boolean true if acl is set/deleted, false on error
 	 */
-	static function eacl($path,$rights=null,$owner=null,$fs_id=null)
+	static function eacl($path, $rights = null, $owner = null, $fs_id = null)
 	{
 		if ($path[0] != '/')
 		{
-			$path = Vfs::parse_url($path,PHP_URL_PATH);
+			$path = Vfs::parse_url($path, PHP_URL_PATH);
 		}
 		if (is_null($fs_id))
 		{
 			$vfs = new self();
-			if (!($stat = $vfs->url_stat($path,0)))
+			if (!($stat = $vfs->url_stat($path, 0)))
 			{
 				if (self::LOG_LEVEL) error_log(__METHOD__."($path,$rights,$owner,$fs_id) no such file or directory!");
-				return false;	// $path not found
+				return false; // $path not found
 			}
-			if (!Vfs::has_owner_rights($path,$stat))		// not group dir and user is eGW admin
+			if (!Vfs::has_owner_rights($path, $stat))		// not group dir and user is eGW admin
 			{
 				if (self::LOG_LEVEL) error_log(__METHOD__."($path,$rights,$owner,$fs_id) permission denied!");
-				return false;	// permission denied
+				return false; // permission denied
 			}
 			$fs_id = $stat['ino'];
 		}
@@ -1489,16 +1488,16 @@ 
 		{
 			// delete eacl
 			if (is_null($owner) || $owner == Vfs::$user ||
-				$owner < 0 && Vfs::$user && in_array($owner,$GLOBALS['egw']->accounts->memberships(Vfs::$user,true)))
+				$owner < 0 && Vfs::$user && in_array($owner, $GLOBALS['egw']->accounts->memberships(Vfs::$user, true)))
 			{
-				self::$extended_acl = null;	// force new read of eACL, as there could be multiple eACL for that path
+				self::$extended_acl = null; // force new read of eACL, as there could be multiple eACL for that path
 			}
 			$ret = $GLOBALS['egw']->acl->delete_repository(self::EACL_APPNAME, $fs_id, (int)$owner, false);
 		}
 		else
 		{
 			if (isset(self::$extended_acl) && ($owner == Vfs::$user ||
-				$owner < 0 && Vfs::$user && in_array($owner,$GLOBALS['egw']->accounts->memberships(Vfs::$user,true))))
+				$owner < 0 && Vfs::$user && in_array($owner, $GLOBALS['egw']->accounts->memberships(Vfs::$user, true))))
 			{
 				// set rights for this class, if applicable
 				self::$extended_acl[$path] |= $rights;
@@ -1527,10 +1526,10 @@ 
 		if (!($stat = $inst->url_stat($path, STREAM_URL_STAT_QUIET)))
 		{
 			error_log(__METHOD__.__LINE__.' '.array2string($path).' not found!');
-			return false;	// not found
+			return false; // not found
 		}
 		$eacls = array();
-		foreach($GLOBALS['egw']->acl->get_all_rights($stat['ino'],self::EACL_APPNAME) as $owner => $rights)
+		foreach ($GLOBALS['egw']->acl->get_all_rights($stat['ino'], self::EACL_APPNAME) as $owner => $rights)
 		{
 			$eacls[] = array(
 				'path'   => $path,
@@ -1541,7 +1540,7 @@ 
 		}
 		if (($path = Vfs::dirname($path)))
 		{
-			$eacls = array_merge((array)self::get_eacl($path),$eacls);
+			$eacls = array_merge((array)self::get_eacl($path), $eacls);
 		}
 		// sort by length descending, to show precedence
 		usort($eacls, function($a, $b) {
@@ -1560,7 +1559,7 @@ 
 	static function get_minimum_file_id($path)
 	{
 		$vfs = new self();
-		$stat = $vfs->url_stat($path,0);
+		$stat = $vfs->url_stat($path, 0);
 		if ($stat['readlink'])
 		{
 			$stat = $vfs->url_stat($stat['readlink'], 0);
@@ -1600,7 +1599,7 @@ 
 	 * @param int $recursion_count =0 internally used to break infinit recursions
 	 * @return false|string|array path or array or pathes indexed by fs_id, or false on error
 	 */
-	static function id2path($fs_ids, $recursion_count=0)
+	static function id2path($fs_ids, $recursion_count = 0)
 	{
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__.'('.array2string($fs_ids).')');
 		if ($recursion_count > self::MAX_ID2PATH_RECURSION)
@@ -1611,9 +1610,9 @@ 
 		$ids = (array)$fs_ids;
 		$pathes = array();
 		// first check our stat-cache for the ids
-		foreach(self::$stat_cache as $path => $stat)
+		foreach (self::$stat_cache as $path => $stat)
 		{
-			if (($key = array_search($stat['fs_id'],$ids)) !== false)
+			if (($key = array_search($stat['fs_id'], $ids)) !== false)
 			{
 				$pathes[$stat['fs_id']] = $path;
 				unset($ids[$key]);
@@ -1627,7 +1626,7 @@ 
 		// now search via the database
 		if (count($ids) > 1) $ids = array_map(function($v) { return (int)$v; }, $ids);
 		$query = 'SELECT fs_id,fs_dir,fs_name FROM '.self::TABLE.' WHERE fs_id'.
-			(count($ids) == 1 ? '='.(int)$ids[0] : ' IN ('.implode(',',$ids).')');
+			(count($ids) == 1 ? '='.(int)$ids[0] : ' IN ('.implode(',', $ids).')');
 		if (self::LOG_LEVEL > 2) $query = '/* '.__METHOD__.': '.__LINE__.' */ '.$query;
 
 		if (!is_object(self::$pdo))
@@ -1638,12 +1637,12 @@ 
 		$stmt->setFetchMode(\PDO::FETCH_ASSOC);
 		if (!$stmt->execute())
 		{
-			return false;	// not found
+			return false; // not found
 		}
 		$parents = array();
-		foreach($stmt as $row)
+		foreach ($stmt as $row)
 		{
-			if ($row['fs_dir'] > 1 && !in_array($row['fs_dir'],$parents))
+			if ($row['fs_dir'] > 1 && !in_array($row['fs_dir'], $parents))
 			{
 				$parents[] = $row['fs_dir'];
 			}
@@ -1651,16 +1650,16 @@ 
 		}
 		unset($stmt);
 
-		if ($parents && !($parents = self::id2path($parents, $recursion_count+1)))
+		if ($parents && !($parents = self::id2path($parents, $recursion_count + 1)))
 		{
-			return false;	// parent not found, should never happen ...
+			return false; // parent not found, should never happen ...
 		}
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__." trying foreach with:".print_r($rows,true)."#");
-		foreach((array)$rows as $fs_id => $row)
+		if (self::LOG_LEVEL > 1) error_log(__METHOD__." trying foreach with:".print_r($rows, true)."#");
+		foreach ((array)$rows as $fs_id => $row)
 		{
 			$parent = $row['fs_dir'] > 1 ? $parents[$row['fs_dir']] : '';
 
-			$pathes[$fs_id] = $parent . '/' . $row['fs_name'];
+			$pathes[$fs_id] = $parent.'/'.$row['fs_name'];
 		}
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__.'('.array2string($fs_ids).')='.array2string($pathes));
 		return is_array($fs_ids) ? $pathes : array_shift($pathes);
@@ -1684,7 +1683,7 @@ 
 			$parts = explode('.', $name);
 			if ($parts > 1 && mb_strlen($extension = '.'.array_pop($parts)) <= $fs_name_precision)
 			{
-				$name = mb_substr(implode('.', $parts), 0, $fs_name_precision-mb_strlen($extension)).$extension;
+				$name = mb_substr(implode('.', $parts), 0, $fs_name_precision - mb_strlen($extension)).$extension;
 			}
 			else
 			{
@@ -1705,9 +1704,8 @@ 
 		$stat = array(
 			'ino'   => $info['fs_id'],
 			'name'  => $info['fs_name'],
-			'mode'  => $info['fs_mode'] |
-				($info['fs_mime'] == self::DIR_MIME_TYPE ? self::MODE_DIR :
-				($info['fs_mime'] == self::SYMLINK_MIME_TYPE ? self::MODE_LINK : self::MODE_FILE)),	// required by the stream wrapper
+			'mode'  => $info['fs_mode']|
+				($info['fs_mime'] == self::DIR_MIME_TYPE ? self::MODE_DIR : ($info['fs_mime'] == self::SYMLINK_MIME_TYPE ? self::MODE_LINK : self::MODE_FILE)), // required by the stream wrapper
 			'size'  => $info['fs_size'],
 			'uid'   => $info['fs_uid'],
 			'gid'   => $info['fs_gid'],
@@ -1752,10 +1750,10 @@ 
 		{
 			if (is_object($GLOBALS['egw_setup']->db))	// if we run under setup, query the db for the files dir
 			{
-				$GLOBALS['egw_info']['server']['files_dir'] = $GLOBALS['egw_setup']->db->select('egw_config','config_value',array(
+				$GLOBALS['egw_info']['server']['files_dir'] = $GLOBALS['egw_setup']->db->select('egw_config', 'config_value', array(
 					'config_name' => 'files_dir',
 					'config_app' => 'phpgwapi',
-				),__LINE__,__FILE__)->fetchColumn();
+				), __LINE__, __FILE__)->fetchColumn();
 			}
 		}
 		if (!$GLOBALS['egw_info']['server']['files_dir'])
@@ -1764,14 +1762,14 @@ 
 		}
 		$hash = array();
 		$n = $id;
-		while(($n = (int) ($n / self::HASH_MAX)))
+		while (($n = (int)($n / self::HASH_MAX)))
 		{
-			$hash[] = sprintf('%02d',$n % self::HASH_MAX);
+			$hash[] = sprintf('%02d', $n % self::HASH_MAX);
 		}
-		if (!$hash) $hash[] = '00';		// we need at least one directory, to not conflict with the dir-names
-		array_unshift($hash,$id);
+		if (!$hash) $hash[] = '00'; // we need at least one directory, to not conflict with the dir-names
+		array_unshift($hash, $id);
 
-		$path = '/sqlfs/'.implode('/',array_reverse($hash));
+		$path = '/sqlfs/'.implode('/', array_reverse($hash));
 		//error_log(__METHOD__."($id) = '$path'");
 		return $GLOBALS['egw_info']['server']['files_dir'].$path;
 	}
@@ -1787,7 +1785,7 @@ 
 
 		if ($parts['pass'] || $parts['scheme'])
 		{
-			$url = $parts['scheme'].'://'.($parts['user'] ? $parts['user'].($parts['pass']?':...':'').'@' : '').
+			$url = $parts['scheme'].'://'.($parts['user'] ? $parts['user'].($parts['pass'] ? ':...' : '').'@' : '').
 				$parts['host'].$parts['path'];
 		}
 	}
@@ -1802,10 +1800,10 @@ 
 	{
 		$operation = self::DEFAULT_OPERATION;
 
-		if (strpos(is_array($url) ? $url['query'] : $url,'storage=') !== false)
+		if (strpos(is_array($url) ? $url['query'] : $url, 'storage=') !== false)
 		{
 			$query = null;
-			parse_str(is_array($url) ? $url['query'] : Vfs::parse_url($url,PHP_URL_QUERY), $query);
+			parse_str(is_array($url) ? $url['query'] : Vfs::parse_url($url, PHP_URL_QUERY), $query);
 			switch ($query['storage'])
 			{
 				case 'db':
@@ -1828,29 +1826,29 @@ 
 	 * @param array $props array of array with values for keys 'name', 'ns', 'val' (null to delete the prop)
 	 * @return boolean true if props are updated, false otherwise (eg. ressource not found)
 	 */
-	static function proppatch($path,array $props)
+	static function proppatch($path, array $props)
 	{
 		static $inst = null;
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."(".array2string($path).','.array2string($props));
 		if (!is_numeric($path))
 		{
 			if (!isset($inst)) $inst = new self();
-			if (!($stat = $inst->url_stat($path,0)))
+			if (!($stat = $inst->url_stat($path, 0)))
 			{
 				return false;
 			}
 			$id = $stat['ino'];
 		}
-		elseif(!($path = self::id2path($id=$path)))
+		elseif (!($path = self::id2path($id = $path)))
 		{
 			return false;
 		}
-		if (!Vfs::check_access($path,Api\Acl::EDIT,$stat))
+		if (!Vfs::check_access($path, Api\Acl::EDIT, $stat))
 		{
-			return false;	// permission denied
+			return false; // permission denied
 		}
 		$ins_stmt = $del_stmt = null;
-		foreach($props as &$prop)
+		foreach ($props as &$prop)
 		{
 			if (!isset($prop['ns'])) $prop['ns'] = Vfs::DEFAULT_PROP_NAMESPACE;
 
@@ -1895,17 +1893,17 @@ 
 	 * @return array|boolean false on error ($path_ids does not exist), array with props (values for keys 'name', 'ns', 'value'), or
 	 * 	fs_id/path => array of props for $depth==1 or is_array($path_ids)
 	 */
-	static function propfind($path_ids,$ns=Vfs::DEFAULT_PROP_NAMESPACE)
+	static function propfind($path_ids, $ns = Vfs::DEFAULT_PROP_NAMESPACE)
 	{
 		static $inst = null;
 
 		$ids = is_array($path_ids) ? $path_ids : array($path_ids);
-		foreach($ids as &$id)
+		foreach ($ids as &$id)
 		{
 			if (!is_numeric($id))
 			{
 				if (!isset($inst)) $inst = new self();
-				if (!($stat = $inst->url_stat($id,0)))
+				if (!($stat = $inst->url_stat($id, 0)))
 				{
 					if (self::LOG_LEVEL) error_log(__METHOD__."(".array2string($path_ids).",$ns) path '$id' not found!");
 					return false;
@@ -1915,7 +1913,7 @@ 
 		}
 		if (count($ids) >= 1) $ids = array_map(function($v) { return (int)$v; }, $ids);
 		$query = 'SELECT * FROM '.self::PROPS_TABLE.' WHERE (fs_id'.
-			(count($ids) == 1 ? '='.(int)implode('',$ids) : ' IN ('.implode(',',$ids).')').')'.
+			(count($ids) == 1 ? '='.(int)implode('', $ids) : ' IN ('.implode(',', $ids).')').')'.
 			(!is_null($ns) ? ' AND prop_namespace=?' : '');
 		if (self::LOG_LEVEL > 2) $query = '/* '.__METHOD__.': '.__LINE__.' */ '.$query;
 
@@ -1924,7 +1922,7 @@ 
 		$stmt->execute(!is_null($ns) ? array($ns) : array());
 
 		$props = array();
-		foreach($stmt as $row)
+		foreach ($stmt as $row)
 		{
 			$props[$row['fs_id']][] = array(
 				'val'  => $row['prop_value'],
@@ -1934,19 +1932,19 @@ 
 		}
 		if (!is_array($path_ids))
 		{
-			$props = $props[$row['fs_id']] ? $props[$row['fs_id']] : array();	// return empty array for no props
+			$props = $props[$row['fs_id']] ? $props[$row['fs_id']] : array(); // return empty array for no props
 		}
 		elseif ($props && isset($stat) && is_array($id2path = self::id2path(array_keys($props))))	// need to map fs_id's to pathes
 		{
-			foreach($id2path as $id => $path)
+			foreach ($id2path as $id => $path)
 			{
-				$props[$path] =& $props[$id];
+				$props[$path] = & $props[$id];
 				unset($props[$id]);
 			}
 		}
 		if (self::LOG_LEVEL > 1)
 		{
-			foreach((array)$props as $k => $v)
+			foreach ((array)$props as $k => $v)
 			{
 				error_log(__METHOD__."($path_ids,$ns) $k => ".array2string($v));
 			}

Braces +423 added lines, -106 removed lines

@@ -193,7 +193,10 @@ 
 	 */
 	function stream_open ($url, $mode, $options, &$opened_path)
 	{
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url,$mode,$options)");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."($url,$mode,$options)");
+		}
 
 		$path = Vfs::parse_url($url,PHP_URL_PATH);
 		$this->operation = self::url2operation($url);
@@ -205,7 +208,9 @@ 
 
 		parse_str(parse_url($url, PHP_URL_QUERY), $this->dir_url_params);
 
-		if (!is_null($this->overwrite_new) || !($stat = $this->url_stat($path,STREAM_URL_STAT_QUIET)) || $mode[0] == 'x')	// file not found or file should NOT exist
+		if (!is_null($this->overwrite_new) || !($stat = $this->url_stat($path,STREAM_URL_STAT_QUIET)) || $mode[0] == 'x')
+		{
+			// file not found or file should NOT exist
 		{
 			if (!$dir || $mode[0] == 'r' ||	// does $mode require the file to exist (r,r+)
 				$mode[0] == 'x' && $stat ||	// or file should not exist, but does
@@ -213,7 +218,11 @@ 
 				!Vfs::check_access($dir,Vfs::WRITABLE,$dir_stat))	// or we are not allowed to 																																			create it
 			{
 				self::_remove_password($url);
-				if (self::LOG_LEVEL) error_log(__METHOD__."($url,$mode,$options) file does not exist or can not be created!");
+		}
+				if (self::LOG_LEVEL)
+				{
+					error_log(__METHOD__."($url,$mode,$options) file does not exist or can not be created!");
+				}
 				if (($options & STREAM_REPORT_ERRORS))
 				{
 					trigger_error(__METHOD__."($url,$mode,$options) file does not exist or can not be created!",E_USER_WARNING);
@@ -225,7 +234,10 @@ 
 			$new_file = true;
 			$query = 'INSERT INTO '.self::TABLE.' (fs_name,fs_dir,fs_mode,fs_uid,fs_gid,fs_created,fs_modified,fs_creator,fs_mime,fs_size,fs_active'.
 				') VALUES (:fs_name,:fs_dir,:fs_mode,:fs_uid,:fs_gid,:fs_created,:fs_modified,:fs_creator,:fs_mime,:fs_size,:fs_active)';
-			if (self::LOG_LEVEL > 2) $query = '/* '.__METHOD__.': '.__LINE__.' */ '.$query;
+			if (self::LOG_LEVEL > 2)
+			{
+				$query = '/* '.__METHOD__.': '.__LINE__.' */ '.$query;
+			}
 			$stmt = self::$pdo->prepare($query);
 			$values = array(
 				'fs_name' => self::limit_filename(Vfs::basename($path)),
@@ -243,11 +255,17 @@ 
 				'fs_size'     => 0,
 				'fs_active'   => self::_pdo_boolean(true),
 			);
-			if ($this->overwrite_new) $values = array_merge($values, $this->overwrite_new);
+			if ($this->overwrite_new)
+			{
+				$values = array_merge($values, $this->overwrite_new);
+			}
 			if (!$stmt->execute($values) || !($this->opened_fs_id = self::$pdo->lastInsertId('egw_sqlfs_fs_id_seq')))
 			{
 				$this->opened_stream = $this->opened_path = $this->opened_mode = null;
-				if (self::LOG_LEVEL) error_log(__METHOD__."($url,$mode,$options) execute() failed: ".self::$pdo->errorInfo());
+				if (self::LOG_LEVEL)
+				{
+					error_log(__METHOD__."($url,$mode,$options) execute() failed: ".self::$pdo->errorInfo());
+				}
 				return false;
 			}
 			if ($this->operation == self::STORE2DB)
@@ -259,14 +277,20 @@ 
 			elseif(!file_exists($fs_dir=Vfs::dirname(self::_fs_path($this->opened_fs_id))))
 			{
 				$umaskbefore = umask();
-				if (self::LOG_LEVEL > 1) error_log(__METHOD__." about to call mkdir for $fs_dir # Present UMASK:".decoct($umaskbefore)." called from:".function_backtrace());
+				if (self::LOG_LEVEL > 1)
+				{
+					error_log(__METHOD__." about to call mkdir for $fs_dir # Present UMASK:".decoct($umaskbefore)." called from:".function_backtrace());
+				}
 				self::mkdir_recursive($fs_dir,0700,true);
 			}
 		}
 		// check if opend file is a directory
 		elseif($stat && ($stat['mode'] & self::MODE_DIR) == self::MODE_DIR)
 		{
-				if (self::LOG_LEVEL) error_log(__METHOD__."($url,$mode,$options) Is a directory!");
+				if (self::LOG_LEVEL)
+				{
+					error_log(__METHOD__."($url,$mode,$options) Is a directory!");
+				}
 				if (($options & STREAM_REPORT_ERRORS))
 				{
 					trigger_error(__METHOD__."($url,$mode,$options) Is a directory!",E_USER_WARNING);
@@ -277,11 +301,17 @@ 
 		else
 		{
 			if ($mode == 'r' && !Vfs::check_access($url,Vfs::READABLE ,$stat) ||// we are not allowed to read
-				$mode != 'r' && !Vfs::check_access($url,Vfs::WRITABLE,$stat))	// or edit it
+				$mode != 'r' && !Vfs::check_access($url,Vfs::WRITABLE,$stat))
+			{
+				// or edit it
 			{
 				self::_remove_password($url);
+			}
 				$op = $mode == 'r' ? 'read' : 'edited';
-				if (self::LOG_LEVEL) error_log(__METHOD__."($url,$mode,$options) file can not be $op!");
+				if (self::LOG_LEVEL)
+				{
+					error_log(__METHOD__."($url,$mode,$options) file can not be $op!");
+				}
 				if (($options & STREAM_REPORT_ERRORS))
 				{
 					trigger_error(__METHOD__."($url,$mode,$options) file can not be $op!",E_USER_WARNING);
@@ -313,7 +343,10 @@ 
 		// do we operate directly on the filesystem --> open file from there
 		if ($this->operation == self::STORE2FS)
 		{
-			if (self::LOG_LEVEL > 1) error_log(__METHOD__." fopen (may create a directory? mkdir) ($this->opened_fs_id,$mode,$options)");
+			if (self::LOG_LEVEL > 1)
+			{
+				error_log(__METHOD__." fopen (may create a directory? mkdir) ($this->opened_fs_id,$mode,$options)");
+			}
 			if (!($this->opened_stream = fopen(self::_fs_path($this->opened_fs_id),$mode)) && $new_file)
 			{
 				// delete db entry again, if we are not able to open a new(!) file
@@ -322,11 +355,17 @@ 
 				$stmt->execute(array('fs_id' => $this->opened_fs_id));
 			}
 		}
-		if ($mode[0] == 'a')	// append modes: a, a+
+		if ($mode[0] == 'a')
+		{
+			// append modes: a, a+
 		{
 			$this->stream_seek(0,SEEK_END);
 		}
-		if (!is_resource($this->opened_stream)) error_log(__METHOD__."($url,$mode,$options) NO stream, returning false!");
+		}
+		if (!is_resource($this->opened_stream))
+		{
+			error_log(__METHOD__."($url,$mode,$options) NO stream, returning false!");
+		}
 
 		return is_resource($this->opened_stream);
 	}
@@ -338,7 +377,10 @@ 
 	 */
 	function stream_close ( )
 	{
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."()");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."()");
+		}
 
 		if (is_null($this->opened_path) || !is_resource($this->opened_stream) || !$this->opened_fs_id)
 		{
@@ -408,7 +450,10 @@ 
 	 */
 	function stream_read ( $count )
 	{
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($count) pos=$this->opened_pos");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."($count) pos=$this->opened_pos");
+		}
 
 		if (is_resource($this->opened_stream))
 		{
@@ -430,7 +475,10 @@ 
 	 */
 	function stream_write ( $data )
 	{
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($data)");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."($data)");
+		}
 
 		if (is_resource($this->opened_stream))
 		{
@@ -467,7 +515,10 @@ 
 	 */
  	function stream_tell ( )
  	{
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."()");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."()");
+		}
 
 		if (is_resource($this->opened_stream))
 		{
@@ -490,7 +541,10 @@ 
  	 */
 	function stream_seek ( $offset, $whence )
 	{
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($offset,$whence)");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."($offset,$whence)");
+		}
 
 		if (is_resource($this->opened_stream))
 		{
@@ -508,7 +562,10 @@ 
 	 */
 	function stream_flush ( )
 	{
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."()");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."()");
+		}
 
 		if (is_resource($this->opened_stream))
 		{
@@ -533,7 +590,10 @@ 
 	 */
 	function stream_stat ( )
 	{
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($this->opened_path)");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."($this->opened_path)");
+		}
 
 		return $this->url_stat($this->opened_path,0);
 	}
@@ -549,7 +609,10 @@ 
 	 */
 	function unlink ( $url )
 	{
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url)");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."($url)");
+		}
 
 		$path = Vfs::parse_url($url,PHP_URL_PATH);
 
@@ -561,13 +624,19 @@ 
 			!$dir || !Vfs::check_access($dir, Vfs::WRITABLE, $parent_stat))
 		{
 			self::_remove_password($url);
-			if (self::LOG_LEVEL) error_log(__METHOD__."($url) permission denied!");
+			if (self::LOG_LEVEL)
+			{
+				error_log(__METHOD__."($url) permission denied!");
+			}
 			return false;	// no permission or file does not exist
 		}
 		if ($stat['mime'] == self::DIR_MIME_TYPE)
 		{
 			self::_remove_password($url);
-			if (self::LOG_LEVEL) error_log(__METHOD__."($url) is NO file!");
+			if (self::LOG_LEVEL)
+			{
+				error_log(__METHOD__."($url) is NO file!");
+			}
 			return false;	// no permission or file does not exist
 		}
 		$stmt = self::$pdo->prepare('DELETE FROM '.self::TABLE.' WHERE fs_id=:fs_id');
@@ -602,7 +671,10 @@ 
 	 */
 	function rename ( $url_from, $url_to)
 	{
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url_from,$url_to)");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."($url_from,$url_to)");
+		}
 
 		$path_from = Vfs::parse_url($url_from,PHP_URL_PATH);
 		$from_dir = Vfs::dirname($path_from);
@@ -614,14 +686,20 @@ 
 		{
 			self::_remove_password($url_from);
 			self::_remove_password($url_to);
-			if (self::LOG_LEVEL) error_log(__METHOD__."($url_from,$url_to): $path_from permission denied!");
+			if (self::LOG_LEVEL)
+			{
+				error_log(__METHOD__."($url_from,$url_to): $path_from permission denied!");
+			}
 			return false;	// no permission or file does not exist
 		}
 		if (!$to_dir || !Vfs::check_access($to_dir, Vfs::WRITABLE, $to_dir_stat = $this->url_stat($to_dir, 0)))
 		{
 			self::_remove_password($url_from);
 			self::_remove_password($url_to);
-			if (self::LOG_LEVEL) error_log(__METHOD__."($url_from,$url_to): $path_to permission denied!");
+			if (self::LOG_LEVEL)
+			{
+				error_log(__METHOD__."($url_from,$url_to): $path_to permission denied!");
+			}
 			return false;	// no permission or parent-dir does not exist
 		}
 		// the filesystem stream-wrapper does NOT allow to rename files to directories, as this makes problems
@@ -632,14 +710,20 @@ 
 			self::_remove_password($url_from);
 			self::_remove_password($url_to);
 			$is_dir = $to_stat['mime'] === self::DIR_MIME_TYPE ? 'a' : 'no';
-			if (self::LOG_LEVEL) error_log(__METHOD__."($url_to,$url_from) $path_to is $is_dir directory!");
+			if (self::LOG_LEVEL)
+			{
+				error_log(__METHOD__."($url_to,$url_from) $path_to is $is_dir directory!");
+			}
 			return false;	// no permission or file does not exist
 		}
 		// if destination file already exists, delete it
 		if ($to_stat && !$this->unlink($url_to))
 		{
 			self::_remove_password($url_to);
-			if (self::LOG_LEVEL) error_log(__METHOD__."($url_to,$url_from) can't unlink existing $url_to!");
+			if (self::LOG_LEVEL)
+			{
+				error_log(__METHOD__."($url_to,$url_from) can't unlink existing $url_to!");
+			}
 			return false;
 		}
 		unset(self::$stat_cache[$path_from]);
@@ -677,7 +761,10 @@ 
 	{
 		$maxdepth=10;
 		$depth2propagate = (int)$depth + 1;
-		if ($depth2propagate > $maxdepth) return is_dir($pathname);
+		if ($depth2propagate > $maxdepth)
+		{
+			return is_dir($pathname);
+		}
     	is_dir(Vfs::dirname($pathname)) || self::mkdir_recursive(Vfs::dirname($pathname), $mode, $depth2propagate);
     	return is_dir($pathname) || @mkdir($pathname, $mode);
 	}
@@ -695,14 +782,23 @@ 
 	 */
 	function mkdir ( $url, $mode, $options )
 	{
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url,$mode,$options)");
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__." called from:".function_backtrace());
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."($url,$mode,$options)");
+		}
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__." called from:".function_backtrace());
+		}
 		$path = Vfs::parse_url($url,PHP_URL_PATH);
 
 		if ($this->url_stat($path,STREAM_URL_STAT_QUIET))
 		{
 			self::_remove_password($url);
-			if (self::LOG_LEVEL) error_log(__METHOD__."('$url',$mode,$options) already exist!");
+			if (self::LOG_LEVEL)
+			{
+				error_log(__METHOD__."('$url',$mode,$options) already exist!");
+			}
 			if (!($options & STREAM_REPORT_ERRORS))
 			{
 				trigger_error(__METHOD__."('$url',$mode,$options) already exist!",E_USER_WARNING);
@@ -712,21 +808,30 @@ 
 		if (!($parent_path = Vfs::dirname($path)))
 		{
 			self::_remove_password($url);
-			if (self::LOG_LEVEL) error_log(__METHOD__."('$url',$mode,$options) dirname('$path')===false!");
+			if (self::LOG_LEVEL)
+			{
+				error_log(__METHOD__."('$url',$mode,$options) dirname('$path')===false!");
+			}
 			if (!($options & STREAM_REPORT_ERRORS))
 			{
 				trigger_error(__METHOD__."('$url',$mode,$options) dirname('$path')===false!", E_USER_WARNING);
 			}
 			return false;
 		}
-		if (($query = Vfs::parse_url($url,PHP_URL_QUERY))) $parent_path .= '?'.$query;
+		if (($query = Vfs::parse_url($url,PHP_URL_QUERY)))
+		{
+			$parent_path .= '?'.$query;
+		}
 		$parent = $this->url_stat($parent_path,STREAM_URL_STAT_QUIET);
 
 		// check if we should also create all non-existing path components and our parent does not exist,
 		// if yes call ourself recursive with the parent directory
 		if (($options & STREAM_MKDIR_RECURSIVE) && $parent_path != '/' && !$parent)
 		{
-			if (self::LOG_LEVEL > 1) error_log(__METHOD__." creating parents: $parent_path, $mode");
+			if (self::LOG_LEVEL > 1)
+			{
+				error_log(__METHOD__." creating parents: $parent_path, $mode");
+			}
 			if (!$this->mkdir($parent_path,$mode,$options))
 			{
 				return false;
@@ -736,7 +841,10 @@ 
 		if (!$parent || !Vfs::check_access($parent_path,Vfs::WRITABLE,$parent))
 		{
 			self::_remove_password($url);
-			if (self::LOG_LEVEL) error_log(__METHOD__."('$url',$mode,$options) permission denied!");
+			if (self::LOG_LEVEL)
+			{
+				error_log(__METHOD__."('$url',$mode,$options) permission denied!");
+			}
 			if (!($options & STREAM_REPORT_ERRORS))
 			{
 				trigger_error(__METHOD__."('$url',$mode,$options) permission denied!",E_USER_WARNING);
@@ -770,10 +878,13 @@ 
 				'fs_dir'  => $parent['ino'],
 				'fs_active' => self::_pdo_boolean(true),
 				'fs_name' => self::limit_filename(Vfs::basename($path)),
-			)) && $stmt->fetchColumn() > 1)	// if there's more then one --> remove our new dir
+			)) && $stmt->fetchColumn() > 1)
+			{
+				// if there's more then one --> remove our new dir
 			{
 				self::$pdo->query('DELETE FROM '.self::TABLE.' WHERE fs_id='.$new_fs_id);
 			}
+			}
 		}
 		return $ok;
 	}
@@ -790,7 +901,10 @@ 
 	 */
 	function rmdir ( $url, $options )
 	{
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url)");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."($url)");
+		}
 
 		$path = Vfs::parse_url($url,PHP_URL_PATH);
 
@@ -801,7 +915,10 @@ 
 			self::_remove_password($url);
 			$err_msg = __METHOD__."($url,$options) ".(!$stat ? 'not found!' :
 				($stat['mime'] != self::DIR_MIME_TYPE ? 'not a directory!' : 'permission denied!'));
-			if (self::LOG_LEVEL) error_log($err_msg);
+			if (self::LOG_LEVEL)
+			{
+				error_log($err_msg);
+			}
 			if (!($options & STREAM_REPORT_ERRORS))
 			{
 				trigger_error($err_msg,E_USER_WARNING);
@@ -813,7 +930,10 @@ 
 		if ($stmt->fetchColumn())
 		{
 			self::_remove_password($url);
-			if (self::LOG_LEVEL) error_log(__METHOD__."($url,$options) dir is not empty!");
+			if (self::LOG_LEVEL)
+			{
+				error_log(__METHOD__."($url,$options) dir is not empty!");
+			}
 			if (!($options & STREAM_REPORT_ERRORS))
 			{
 				trigger_error(__METHOD__."('$url',$options) dir is not empty!",E_USER_WARNING);
@@ -851,7 +971,10 @@ 
 	 */
 	function stream_metadata($path, $option, $value)
 	{
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($path, $option, ".array2string($value).")");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."($path, $option, ".array2string($value).")");
+		}
 
 		switch($option)
 		{
@@ -863,14 +986,18 @@ 
 
 			case STREAM_META_OWNER_NAME:
 				if (($value = $GLOBALS['egw']->accounts->name2id($value, 'account_lid', 'u')) === false)
-					return false;
+				{
+									return false;
+				}
 				// fall through
 			case STREAM_META_OWNER:
 				return $this->chown($path, $value);
 
 			case STREAM_META_GROUP_NAME:
 				if (($value = $GLOBALS['egw']->accounts->name2id($value, 'account_lid', 'g')) === false)
-					return false;
+				{
+									return false;
+				}
 				// fall through
 			case STREAM_META_GROUP:
 				return $this->chgrp($path, $value);
@@ -888,7 +1015,10 @@ 
 	protected function touch($url,$time=null,$atime=null)
 	{
 		unset($atime);	// not used
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url, $time)");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."($url, $time)");
+		}
 
 		$path = Vfs::parse_url($url,PHP_URL_PATH);
 
@@ -925,26 +1055,38 @@ 
 	 */
 	protected function chown($url,$owner)
 	{
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url,$owner)");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."($url,$owner)");
+		}
 
 		$path = Vfs::parse_url($url,PHP_URL_PATH);
 
 		$vfs = new self();
 		if (!($stat = $vfs->url_stat($path,0)))
 		{
-			if (self::LOG_LEVEL) error_log(__METHOD__."($url,$owner) no such file or directory!");
+			if (self::LOG_LEVEL)
+			{
+				error_log(__METHOD__."($url,$owner) no such file or directory!");
+			}
 			trigger_error("No such file or directory $url !",E_USER_WARNING);
 			return false;
 		}
 		if (!Vfs::$is_root)
 		{
-			if (self::LOG_LEVEL) error_log(__METHOD__."($url,$owner) only root can do that!");
+			if (self::LOG_LEVEL)
+			{
+				error_log(__METHOD__."($url,$owner) only root can do that!");
+			}
 			trigger_error("Only root can do that!",E_USER_WARNING);
 			return false;
 		}
-		if ($owner < 0 || $owner && !$GLOBALS['egw']->accounts->id2name($owner))	// not a user (0 == root)
+		if ($owner < 0 || $owner && !$GLOBALS['egw']->accounts->id2name($owner))
+		{
+			// not a user (0 == root)
 		{
 			if (self::LOG_LEVEL) error_log(__METHOD__."($url,$owner) unknown (numeric) user id!");
+		}
 			trigger_error(__METHOD__."($url,$owner) Unknown (numeric) user id!",E_USER_WARNING);
 			//throw new Exception(__METHOD__."($url,$owner) Unknown (numeric) user id!");
 			return false;
@@ -952,7 +1094,10 @@ 
 		$stmt = self::$pdo->prepare('UPDATE '.self::TABLE.' SET fs_uid=:fs_uid WHERE fs_id=:fs_id');
 
 		// update stat-cache
-		if ($path != '/' && substr($path,-1) == '/') $path = substr($path, 0, -1);
+		if ($path != '/' && substr($path,-1) == '/')
+		{
+			$path = substr($path, 0, -1);
+		}
 		self::$stat_cache[$path]['fs_uid'] = $owner;
 
 		return $stmt->execute(array(
@@ -970,35 +1115,54 @@ 
 	 */
 	protected function chgrp($url,$owner)
 	{
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url,$owner)");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."($url,$owner)");
+		}
 
 		$path = Vfs::parse_url($url,PHP_URL_PATH);
 
 		$vfs = new self();
 		if (!($stat = $vfs->url_stat($path,0)))
 		{
-			if (self::LOG_LEVEL) error_log(__METHOD__."($url,$owner) no such file or directory!");
+			if (self::LOG_LEVEL)
+			{
+				error_log(__METHOD__."($url,$owner) no such file or directory!");
+			}
 			trigger_error("No such file or directory $url !",E_USER_WARNING);
 			return false;
 		}
 		if (!Vfs::has_owner_rights($path,$stat))
 		{
-			if (self::LOG_LEVEL) error_log(__METHOD__."($url,$owner) only owner or root can do that!");
+			if (self::LOG_LEVEL)
+			{
+				error_log(__METHOD__."($url,$owner) only owner or root can do that!");
+			}
 			trigger_error("Only owner or root can do that!",E_USER_WARNING);
 			return false;
 		}
-		if ($owner < 0) $owner = -$owner;	// sqlfs uses a positiv group id's!
+		if ($owner < 0)
+		{
+			$owner = -$owner;
+		}
+		// sqlfs uses a positiv group id's!
 
-		if ($owner && !$GLOBALS['egw']->accounts->id2name(-$owner))	// not a group
+		if ($owner && !$GLOBALS['egw']->accounts->id2name(-$owner))
+		{
+			// not a group
 		{
 			if (self::LOG_LEVEL) error_log(__METHOD__."($url,$owner) unknown (numeric) group id!");
+		}
 			trigger_error("Unknown (numeric) group id!",E_USER_WARNING);
 			return false;
 		}
 		$stmt = self::$pdo->prepare('UPDATE '.self::TABLE.' SET fs_gid=:fs_gid WHERE fs_id=:fs_id');
 
 		// update stat-cache
-		if ($path != '/' && substr($path,-1) == '/') $path = substr($path, 0, -1);
+		if ($path != '/' && substr($path,-1) == '/')
+		{
+			$path = substr($path, 0, -1);
+		}
 		self::$stat_cache[$path]['fs_gid'] = $owner;
 
 		return $stmt->execute(array(
@@ -1016,33 +1180,48 @@ 
 	 */
 	protected function chmod($url,$mode)
 	{
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url, $mode)");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."($url, $mode)");
+		}
 
 		$path = Vfs::parse_url($url,PHP_URL_PATH);
 
 		$vfs = new self();
 		if (!($stat = $vfs->url_stat($path,0)))
 		{
-			if (self::LOG_LEVEL) error_log(__METHOD__."($url, $mode) no such file or directory!");
+			if (self::LOG_LEVEL)
+			{
+				error_log(__METHOD__."($url, $mode) no such file or directory!");
+			}
 			trigger_error("No such file or directory $url !",E_USER_WARNING);
 			return false;
 		}
 		if (!Vfs::has_owner_rights($path,$stat))
 		{
-			if (self::LOG_LEVEL) error_log(__METHOD__."($url, $mode) only owner or root can do that!");
+			if (self::LOG_LEVEL)
+			{
+				error_log(__METHOD__."($url, $mode) only owner or root can do that!");
+			}
 			trigger_error("Only owner or root can do that!",E_USER_WARNING);
 			return false;
 		}
-		if (!is_numeric($mode))	// not a mode
+		if (!is_numeric($mode))
+		{
+			// not a mode
 		{
 			if (self::LOG_LEVEL) error_log(__METHOD__."($url, $mode) no (numeric) mode!");
+		}
 			trigger_error("No (numeric) mode!",E_USER_WARNING);
 			return false;
 		}
 		$stmt = self::$pdo->prepare('UPDATE '.self::TABLE.' SET fs_mode=:fs_mode WHERE fs_id=:fs_id');
 
 		// update stat cache
-		if ($path != '/' && substr($path,-1) == '/') $path = substr($path, 0, -1);
+		if ($path != '/' && substr($path,-1) == '/')
+		{
+			$path = substr($path, 0, -1);
+		}
 		self::$stat_cache[$path]['fs_mode'] = ((int) $mode) & 0777;
 
 		return $stmt->execute(array(
@@ -1067,12 +1246,18 @@ 
 
 		if (!($stat = $this->url_stat($url,0)) || 		// dir not found
 			!($stat['mode'] & self::MODE_DIR) && $stat['mime'] != self::DIR_MIME_TYPE ||		// no dir
-			!Vfs::check_access($url,Vfs::EXECUTABLE|Vfs::READABLE,$stat))	// no access
+			!Vfs::check_access($url,Vfs::EXECUTABLE|Vfs::READABLE,$stat))
+		{
+			// no access
 		{
 			self::_remove_password($url);
+		}
 			$msg = !($stat['mode'] & self::MODE_DIR) && $stat['mime'] != self::DIR_MIME_TYPE ?
 				"$url is no directory" : 'permission denied';
-			if (self::LOG_LEVEL) error_log(__METHOD__."('$url',$options) $msg!");
+			if (self::LOG_LEVEL)
+			{
+				error_log(__METHOD__."('$url',$options) $msg!");
+			}
 			$this->opened_dir = null;
 			return false;
 		}
@@ -1081,7 +1266,10 @@ 
 			' FROM '.self::TABLE.' WHERE fs_dir=? AND fs_active='.self::_pdo_boolean(true).
 			" ORDER BY fs_mime='httpd/unix-directory' DESC, fs_name ASC";
 		//if (self::LOG_LEVEL > 2) $query = '/* '.__METHOD__.': '.__LINE__.' */ '.$query;
-		if (self::LOG_LEVEL > 2) $query = '/* '.__METHOD__."($url,$options)".' */ '.$query;
+		if (self::LOG_LEVEL > 2)
+		{
+			$query = '/* '.__METHOD__."($url,$options)".' */ '.$query;
+		}
 
 		$stmt = self::$pdo->prepare($query);
 		$stmt->setFetchMode(\PDO::FETCH_ASSOC);
@@ -1093,7 +1281,10 @@ 
 				self::$stat_cache[Vfs::concat($path,$file['fs_name'])] = $file;
 			}
 		}
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url,$options): ".implode(', ',$this->opened_dir));
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."($url,$options): ".implode(', ',$this->opened_dir));
+		}
 		reset($this->opened_dir);
 
 		return true;
@@ -1131,9 +1322,16 @@ 
 		if (is_null($max_subquery_depth))
 		{
 			$max_subquery_depth = $GLOBALS['egw_info']['server']['max_subquery_depth'];
-			if (!$max_subquery_depth) $max_subquery_depth = 7;	// setting current default of 7, if nothing set
+			if (!$max_subquery_depth)
+			{
+				$max_subquery_depth = 7;
+			}
+			// setting current default of 7, if nothing set
+		}
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."('$url',$flags)");
 		}
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."('$url',$flags)");
 
 		$path = Vfs::parse_url($url,PHP_URL_PATH);
 
@@ -1196,7 +1394,10 @@ 
 						if (!Vfs::$user)
 						{
 							self::_remove_password($url);
-							if (self::LOG_LEVEL > 1) error_log(__METHOD__."('$url',$flags) permission denied, no user-id and not root!");
+							if (self::LOG_LEVEL > 1)
+							{
+								error_log(__METHOD__."('$url',$flags) permission denied, no user-id and not root!");
+							}
 							return false;
 						}
 						$query .= ' AND '.self::_sql_readable();
@@ -1207,7 +1408,10 @@ 
 					$query = str_replace('fs_name'.self::$case_sensitive_equal.'?','fs_name'.self::$case_sensitive_equal.self::$pdo->quote($name),$base_query).'('.$query.')';
 				}
 			}
-			if (self::LOG_LEVEL > 2) $query = '/* '.__METHOD__."($url,$flags) eacl_access=$eacl_access".' */ '.$query;
+			if (self::LOG_LEVEL > 2)
+			{
+				$query = '/* '.__METHOD__."($url,$flags) eacl_access=$eacl_access".' */ '.$query;
+			}
 			//if (self::LOG_LEVEL > 2) $query = '/* '.__METHOD__.': '.__LINE__.' */ '.$query;
 
 			if (!($result = self::$pdo->query($query)) || !($info = $result->fetch(\PDO::FETCH_ASSOC)))
@@ -1230,12 +1434,18 @@ 
 			$GLOBALS['egw_info']['server']['max_subquery_depth'] = --$max_subquery_depth;
 			error_log(__METHOD__."() decremented max_subquery_depth to $max_subquery_depth");
 			Api\Config::save_value('max_subquery_depth', $max_subquery_depth, 'phpgwapi');
-			if (method_exists($GLOBALS['egw'],'invalidate_session_cache')) $GLOBALS['egw']->invalidate_session_cache();
+			if (method_exists($GLOBALS['egw'],'invalidate_session_cache'))
+			{
+				$GLOBALS['egw']->invalidate_session_cache();
+			}
 			return $this->url_stat($url, $flags);
 		}
 		self::$stat_cache[$path] = $info;
 
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url,$flags)=".array2string($info));
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."($url,$flags)=".array2string($info));
+		}
 		return self::_vfsinfo2stat($info);
 	}
 
@@ -1272,9 +1482,15 @@ 
 	 */
 	function dir_readdir ( )
 	{
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."( )");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."( )");
+		}
 
-		if (!is_array($this->opened_dir)) return false;
+		if (!is_array($this->opened_dir))
+		{
+			return false;
+		}
 
 		$file = current($this->opened_dir); next($this->opened_dir);
 
@@ -1291,9 +1507,15 @@ 
 	 */
 	function dir_rewinddir ( )
 	{
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."( )");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."( )");
+		}
 
-		if (!is_array($this->opened_dir)) return false;
+		if (!is_array($this->opened_dir))
+		{
+			return false;
+		}
 
 		reset($this->opened_dir);
 
@@ -1309,9 +1531,15 @@ 
 	 */
 	function dir_closedir ( )
 	{
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."( )");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."( )");
+		}
 
-		if (!is_array($this->opened_dir)) return false;
+		if (!is_array($this->opened_dir))
+		{
+			return false;
+		}
 
 		$this->opened_dir = null;
 
@@ -1331,7 +1559,10 @@ 
 		$vfs = new self();
 		$link = !($lstat = $vfs->url_stat($path,STREAM_URL_STAT_LINK)) || is_null($lstat['readlink']) ? false : $lstat['readlink'];
 
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."('$path') = $link");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."('$path') = $link");
+		}
 
 		return $link;
 	}
@@ -1345,23 +1576,35 @@ 
 	 */
 	static function symlink($target,$link)
 	{
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."('$target','$link')");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."('$target','$link')");
+		}
 
 		$inst = new static();
 		if ($inst->url_stat($link,0))
 		{
-			if (self::LOG_LEVEL > 0) error_log(__METHOD__."('$target','$link') $link exists, returning false!");
+			if (self::LOG_LEVEL > 0)
+			{
+				error_log(__METHOD__."('$target','$link') $link exists, returning false!");
+			}
 			return false;	// $link already exists
 		}
 		if (!($dir = Vfs::dirname($link)) ||
 			!Vfs::check_access($dir,Vfs::WRITABLE,$dir_stat=$inst->url_stat($dir,0)))
 		{
-			if (self::LOG_LEVEL > 0) error_log(__METHOD__."('$target','$link') returning false! (!is_writable('$dir'), dir_stat=".array2string($dir_stat).")");
+			if (self::LOG_LEVEL > 0)
+			{
+				error_log(__METHOD__."('$target','$link') returning false! (!is_writable('$dir'), dir_stat=".array2string($dir_stat).")");
+			}
 			return false;	// parent dir does not exist or is not writable
 		}
 		$query = 'INSERT INTO '.self::TABLE.' (fs_name,fs_dir,fs_mode,fs_uid,fs_gid,fs_created,fs_modified,fs_creator,fs_mime,fs_size,fs_link'.
 			') VALUES (:fs_name,:fs_dir,:fs_mode,:fs_uid,:fs_gid,:fs_created,:fs_modified,:fs_creator,:fs_mime,:fs_size,:fs_link)';
-		if (self::LOG_LEVEL > 2) $query = '/* '.__METHOD__.': '.__LINE__.' */ '.$query;
+		if (self::LOG_LEVEL > 2)
+		{
+			$query = '/* '.__METHOD__.': '.__LINE__.' */ '.$query;
+		}
 		$stmt = self::$pdo->prepare($query);
 		unset(self::$stat_cache[Vfs::parse_url($link,PHP_URL_PATH)]);
 
@@ -1409,7 +1652,10 @@ 
 				break;
 			}
 		}
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url,$check) ".($access?"access granted by $path=$rights":'no access!!!'));
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."($url,$check) ".($access?"access granted by $path=$rights":'no access!!!'));
+		}
 		return $access;
 	}
 
@@ -1437,11 +1683,15 @@ 
 			}
 		}
 		// sort by length descending, to allow more specific pathes to have precedence
-		uksort(self::$extended_acl, function($a,$b) {
+		uksort(self::$extended_acl, function($a,$b)
+		{
 			return strlen($b)-strlen($a);
 		});
 		Api\Cache::setSession(self::EACL_APPNAME, 'extended_acl', self::$extended_acl);
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__.'() '.array2string(self::$extended_acl));
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__.'() '.array2string(self::$extended_acl));
+		}
 	}
 
 	/**
@@ -1471,12 +1721,18 @@ 
 			$vfs = new self();
 			if (!($stat = $vfs->url_stat($path,0)))
 			{
-				if (self::LOG_LEVEL) error_log(__METHOD__."($path,$rights,$owner,$fs_id) no such file or directory!");
+				if (self::LOG_LEVEL)
+				{
+					error_log(__METHOD__."($path,$rights,$owner,$fs_id) no such file or directory!");
+				}
 				return false;	// $path not found
 			}
-			if (!Vfs::has_owner_rights($path,$stat))		// not group dir and user is eGW admin
+			if (!Vfs::has_owner_rights($path,$stat))
+			{
+				// not group dir and user is eGW admin
 			{
 				if (self::LOG_LEVEL) error_log(__METHOD__."($path,$rights,$owner,$fs_id) permission denied!");
+			}
 				return false;	// permission denied
 			}
 			$fs_id = $stat['ino'];
@@ -1509,7 +1765,10 @@ 
 		{
 			Api\Cache::setSession(self::EACL_APPNAME, 'extended_acl', self::$extended_acl);
 		}
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($path,$rights,$owner,$fs_id)=".(int)$ret);
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."($path,$rights,$owner,$fs_id)=".(int)$ret);
+		}
 		return $ret;
 	}
 
@@ -1544,7 +1803,8 @@ 
 			$eacls = array_merge((array)self::get_eacl($path),$eacls);
 		}
 		// sort by length descending, to show precedence
-		usort($eacls, function($a, $b) {
+		usort($eacls, function($a, $b)
+		{
 			return strlen($b['path']) - strlen($a['path']);
 		});
 		//error_log(__METHOD__."('$_path') returning ".array2string($eacls));
@@ -1602,7 +1862,10 @@ 
 	 */
 	static function id2path($fs_ids, $recursion_count=0)
 	{
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__.'('.array2string($fs_ids).')');
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__.'('.array2string($fs_ids).')');
+		}
 		if ($recursion_count > self::MAX_ID2PATH_RECURSION)
 		{
 			error_log(__METHOD__."(".array2string($fs_ids).", $recursion_count) max recursion depth reached, probably broken filesystem!");
@@ -1619,16 +1882,26 @@ 
 				unset($ids[$key]);
 				if (!$ids)
 				{
-					if (self::LOG_LEVEL > 1) error_log(__METHOD__.'('.array2string($fs_ids).')='.array2string($pathes).' *from stat_cache*');
+					if (self::LOG_LEVEL > 1)
+					{
+						error_log(__METHOD__.'('.array2string($fs_ids).')='.array2string($pathes).' *from stat_cache*');
+					}
 					return is_array($fs_ids) ? $pathes : array_shift($pathes);
 				}
 			}
 		}
 		// now search via the database
-		if (count($ids) > 1) $ids = array_map(function($v) { return (int)$v; }, $ids);
+		if (count($ids) > 1)
+		{
+			$ids = array_map(function($v) { return (int)$v;
+		}
+		}, $ids);
 		$query = 'SELECT fs_id,fs_dir,fs_name FROM '.self::TABLE.' WHERE fs_id'.
 			(count($ids) == 1 ? '='.(int)$ids[0] : ' IN ('.implode(',',$ids).')');
-		if (self::LOG_LEVEL > 2) $query = '/* '.__METHOD__.': '.__LINE__.' */ '.$query;
+		if (self::LOG_LEVEL > 2)
+		{
+			$query = '/* '.__METHOD__.': '.__LINE__.' */ '.$query;
+		}
 
 		if (!is_object(self::$pdo))
 		{
@@ -1655,14 +1928,20 @@ 
 		{
 			return false;	// parent not found, should never happen ...
 		}
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__." trying foreach with:".print_r($rows,true)."#");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__." trying foreach with:".print_r($rows,true)."#");
+		}
 		foreach((array)$rows as $fs_id => $row)
 		{
 			$parent = $row['fs_dir'] > 1 ? $parents[$row['fs_dir']] : '';
 
 			$pathes[$fs_id] = $parent . '/' . $row['fs_name'];
 		}
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__.'('.array2string($fs_ids).')='.array2string($pathes));
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__.'('.array2string($fs_ids).')='.array2string($pathes));
+		}
 		return is_array($fs_ids) ? $pathes : array_shift($pathes);
 	}
 
@@ -1718,7 +1997,10 @@ 
 			'mime'  => $info['fs_mime'],
 			'readlink' => $info['fs_link'],
 		);
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($info[name]) = ".array2string($stat));
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."($info[name]) = ".array2string($stat));
+		}
 		return $stat;
 	}
 
@@ -1750,13 +2032,16 @@ 
 		}
 		if (!isset($GLOBALS['egw_info']['server']['files_dir']))
 		{
-			if (is_object($GLOBALS['egw_setup']->db))	// if we run under setup, query the db for the files dir
+			if (is_object($GLOBALS['egw_setup']->db))
+			{
+				// if we run under setup, query the db for the files dir
 			{
 				$GLOBALS['egw_info']['server']['files_dir'] = $GLOBALS['egw_setup']->db->select('egw_config','config_value',array(
 					'config_name' => 'files_dir',
 					'config_app' => 'phpgwapi',
 				),__LINE__,__FILE__)->fetchColumn();
 			}
+			}
 		}
 		if (!$GLOBALS['egw_info']['server']['files_dir'])
 		{
@@ -1768,7 +2053,11 @@ 
 		{
 			$hash[] = sprintf('%02d',$n % self::HASH_MAX);
 		}
-		if (!$hash) $hash[] = '00';		// we need at least one directory, to not conflict with the dir-names
+		if (!$hash)
+		{
+			$hash[] = '00';
+		}
+		// we need at least one directory, to not conflict with the dir-names
 		array_unshift($hash,$id);
 
 		$path = '/sqlfs/'.implode('/',array_reverse($hash));
@@ -1831,10 +2120,16 @@ 
 	static function proppatch($path,array $props)
 	{
 		static $inst = null;
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."(".array2string($path).','.array2string($props));
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."(".array2string($path).','.array2string($props));
+		}
 		if (!is_numeric($path))
 		{
-			if (!isset($inst)) $inst = new self();
+			if (!isset($inst))
+			{
+				$inst = new self();
+			}
 			if (!($stat = $inst->url_stat($path,0)))
 			{
 				return false;
@@ -1852,13 +2147,19 @@ 
 		$ins_stmt = $del_stmt = null;
 		foreach($props as &$prop)
 		{
-			if (!isset($prop['ns'])) $prop['ns'] = Vfs::DEFAULT_PROP_NAMESPACE;
+			if (!isset($prop['ns']))
+			{
+				$prop['ns'] = Vfs::DEFAULT_PROP_NAMESPACE;
+			}
 
-			if (!isset($prop['val']) || self::$pdo_type != 'mysql')	// for non mysql, we have to delete the prop anyway, as there's no REPLACE!
+			if (!isset($prop['val']) || self::$pdo_type != 'mysql')
+			{
+				// for non mysql, we have to delete the prop anyway, as there's no REPLACE!
 			{
 				if (!isset($del_stmt))
 				{
 					$del_stmt = self::$pdo->prepare('DELETE FROM '.self::PROPS_TABLE.' WHERE fs_id=:fs_id AND prop_namespace=:prop_namespace AND prop_name=:prop_name');
+			}
 				}
 				$del_stmt->execute(array(
 					'fs_id'          => $id,
@@ -1904,20 +2205,33 @@ 
 		{
 			if (!is_numeric($id))
 			{
-				if (!isset($inst)) $inst = new self();
+				if (!isset($inst))
+				{
+					$inst = new self();
+				}
 				if (!($stat = $inst->url_stat($id,0)))
 				{
-					if (self::LOG_LEVEL) error_log(__METHOD__."(".array2string($path_ids).",$ns) path '$id' not found!");
+					if (self::LOG_LEVEL)
+					{
+						error_log(__METHOD__."(".array2string($path_ids).",$ns) path '$id' not found!");
+					}
 					return false;
 				}
 				$id = $stat['ino'];
 			}
 		}
-		if (count($ids) >= 1) $ids = array_map(function($v) { return (int)$v; }, $ids);
+		if (count($ids) >= 1)
+		{
+			$ids = array_map(function($v) { return (int)$v;
+		}
+		}, $ids);
 		$query = 'SELECT * FROM '.self::PROPS_TABLE.' WHERE (fs_id'.
 			(count($ids) == 1 ? '='.(int)implode('',$ids) : ' IN ('.implode(',',$ids).')').')'.
 			(!is_null($ns) ? ' AND prop_namespace=?' : '');
-		if (self::LOG_LEVEL > 2) $query = '/* '.__METHOD__.': '.__LINE__.' */ '.$query;
+		if (self::LOG_LEVEL > 2)
+		{
+			$query = '/* '.__METHOD__.': '.__LINE__.' */ '.$query;
+		}
 
 		$stmt = self::$pdo->prepare($query);
 		$stmt->setFetchMode(\PDO::FETCH_ASSOC);
@@ -1936,11 +2250,14 @@ 
 		{
 			$props = $props[$row['fs_id']] ? $props[$row['fs_id']] : array();	// return empty array for no props
 		}
-		elseif ($props && isset($stat) && is_array($id2path = self::id2path(array_keys($props))))	// need to map fs_id's to pathes
+		elseif ($props && isset($stat) && is_array($id2path = self::id2path(array_keys($props))))
+		{
+			// need to map fs_id's to pathes
 		{
 			foreach($id2path as $id => $path)
 			{
 				$props[$path] =& $props[$id];
+		}
 				unset($props[$id]);
 			}
 		}

api/src/Header/UserAgent.php

Spacing +6 added lines, -6 removed lines

@@ -76,11 +76,11 @@ 
 	{
 		// should be Ok for all HTML 4 compatible browsers
 		$parts = $all_parts = null;
-		if(!preg_match('/compatible; ([a-z]+)[\/ ]+([0-9.]+)/i',$_SERVER['HTTP_USER_AGENT'],$parts))
+		if (!preg_match('/compatible; ([a-z]+)[\/ ]+([0-9.]+)/i', $_SERVER['HTTP_USER_AGENT'], $parts))
 		{
-			preg_match_all('/([a-z]+)\/([0-9.]+)/i',$_SERVER['HTTP_USER_AGENT'],$all_parts,PREG_SET_ORDER);
+			preg_match_all('/([a-z]+)\/([0-9.]+)/i', $_SERVER['HTTP_USER_AGENT'], $all_parts, PREG_SET_ORDER);
 			$parts = array_pop($all_parts);
-			foreach($all_parts as $p)
+			foreach ($all_parts as $p)
 			{
 				if ($p[1] == 'Chrome' && $parts[1] != 'Edge')
 				{
@@ -89,12 +89,12 @@ 
 				}
 			}
 		}
-		list(,self::$user_agent,self::$ua_version) = $parts;
+		list(,self::$user_agent, self::$ua_version) = $parts;
 		if ((self::$user_agent = strtolower(self::$user_agent)) == 'version') self::$user_agent = 'opera';
 		// IE no longer reports MSIE, but "Trident/7.0; rv:11.0"
-		if (self::$user_agent=='trident')
+		if (self::$user_agent == 'trident')
 		{
-			self::$user_agent='msie';
+			self::$user_agent = 'msie';
 			$matches = null;
 			self::$ua_version = preg_match('|Trident/[0-9.]+; rv:([0-9.]+)|i', $_SERVER['HTTP_USER_AGENT'], $matches) ?
 				$matches[1] : 11.0;

Braces +4 added lines, -1 removed lines

@@ -90,7 +90,10 @@
 			}
 		}
 		list(,self::$user_agent,self::$ua_version) = $parts;
-		if ((self::$user_agent = strtolower(self::$user_agent)) == 'version') self::$user_agent = 'opera';
+		if ((self::$user_agent = strtolower(self::$user_agent)) == 'version')
+		{
+			self::$user_agent = 'opera';
+		}
 		// IE no longer reports MSIE, but "Trident/7.0; rv:11.0"
 		if (self::$user_agent=='trident')
 		{

api/src/Header/Referer.php

Spacing +3 added lines, -3 removed lines

@@ -26,7 +26,7 @@ 
 	 * @return string
 	 * @todo get "real" referer for jDots template
 	 */
-	static function get($default='',$referer='')
+	static function get($default = '', $referer = '')
 	{
 		// HTTP_REFERER seems NOT to get urldecoded
 		if (!$referer) $referer = urldecode($_SERVER['HTTP_REFERER']);
@@ -34,11 +34,11 @@ 
 		$webserver_url = $GLOBALS['egw_info']['server']['webserver_url'];
 		if (empty($webserver_url) || $webserver_url{0} == '/')	// url is just a path
 		{
-			$referer = preg_replace('/^https?:\/\/[^\/]+/','',$referer);	// removing the domain part
+			$referer = preg_replace('/^https?:\/\/[^\/]+/', '', $referer); // removing the domain part
 		}
 		if (strlen($webserver_url) > 1)
 		{
-			list(,$referer) = explode($webserver_url,$referer,2);
+			list(,$referer) = explode($webserver_url, $referer, 2);
 		}
 		$ret = str_replace('/etemplate/process_exec.php', '/index.php', $referer);
 

Braces +14 added lines, -4 removed lines

@@ -29,12 +29,19 @@ 
 	static function get($default='',$referer='')
 	{
 		// HTTP_REFERER seems NOT to get urldecoded
-		if (!$referer) $referer = urldecode($_SERVER['HTTP_REFERER']);
+		if (!$referer)
+		{
+			$referer = urldecode($_SERVER['HTTP_REFERER']);
+		}
 
 		$webserver_url = $GLOBALS['egw_info']['server']['webserver_url'];
-		if (empty($webserver_url) || $webserver_url{0} == '/')	// url is just a path
+		if (empty($webserver_url) || $webserver_url{0} == '/')
+		{
+			// url is just a path
 		{
-			$referer = preg_replace('/^https?:\/\/[^\/]+/','',$referer);	// removing the domain part
+			$referer = preg_replace('/^https?:\/\/[^\/]+/','',$referer);
+		}
+		// removing the domain part
 		}
 		if (strlen($webserver_url) > 1)
 		{
@@ -42,7 +49,10 @@ 
 		}
 		$ret = str_replace('/etemplate/process_exec.php', '/index.php', $referer);
 
-		if (empty($ret) || strpos($ret, 'cd=yes') !== false) $ret = $default;
+		if (empty($ret) || strpos($ret, 'cd=yes') !== false)
+		{
+			$ret = $default;
+		}
 
 		return $ret;
 	}

api/src/Etemplate/Widget/Transformer.php

Spacing +21 added lines, -21 removed lines

@@ -73,7 +73,7 @@ 
 	 *
 	 * @param string $cname
 	 */
-	public function beforeSendToClient($cname, array $expand=array())
+	public function beforeSendToClient($cname, array $expand = array())
 	{
 		$attrs = $this->attrs;
 		$form_name = self::form_name($cname, $this->id);
@@ -82,14 +82,14 @@ 
 			error_log(__METHOD__."() $this has no id!");
 			return;
 		}
-		$attrs['value'] = $value =& self::get_array(self::$request->content, $form_name, false, true);
+		$attrs['value'] = $value = & self::get_array(self::$request->content, $form_name, false, true);
 		$attrs['type'] = $this->type;
 		$attrs['id'] = $this->id;
 
 		$unmodified = $attrs;
 
 		// run the transformation
-		foreach(static::$transformation as $filter => $data)
+		foreach (static::$transformation as $filter => $data)
 		{
 			$this->action($filter, $data, $attrs);
 		}
@@ -97,14 +97,14 @@ 
 		//echo $this; _debug_array($unmodified); _debug_array($attrs); _debug_array(array_diff_assoc($attrs, $unmodified));
 		// compute the difference and send it to the client as modifications
 		$type_changed = false;
-		foreach(array_diff_assoc($attrs, $unmodified) as $attr => $val)
+		foreach (array_diff_assoc($attrs, $unmodified) as $attr => $val)
 		{
-			switch($attr)
+			switch ($attr)
 			{
 				case 'value':
 					if ($val != $value)
 					{
-						$value = $val;	// $value is reference to self::$request->content
+						$value = $val; // $value is reference to self::$request->content
 					}
 					break;
 				case 'sel_options':
@@ -112,15 +112,15 @@ 
 					break;
 				case 'type':	// not an attribute in etemplate2
 					$type_changed = true;
-					if($val == 'template')
+					if ($val == 'template')
 					{
 						// If the widget has been transformed into a template, we
 						// also need to try and instanciate & parse the template too
 						$transformed_template = Template::instance($attrs['template']);
-						if($transformed_template)
+						if ($transformed_template)
 						{
 							$this->expand_widget($transformed_template, $expand);
-							$transformed_template->run('beforeSendToClient',array($cname,$expand));
+							$transformed_template->run('beforeSendToClient', array($cname, $expand));
 						}
 						$type_changed = false;
 					}
@@ -129,14 +129,14 @@ 
 					break;
 			}
 		}
-		if($type_changed)
+		if ($type_changed)
 		{
 			// Run the new widget type's beforeSendToClient
-			$expanded_child = self::factory($attrs['type'], false,$this->id);
+			$expanded_child = self::factory($attrs['type'], false, $this->id);
 			$expanded_child->id = $this->id;
 			$expanded_child->type = $attrs['type'];
 			$expanded_child->attrs = $attrs;
-			$expanded_child->run('beforeSendToClient',array($cname,$expand));
+			$expanded_child->run('beforeSendToClient', array($cname, $expand));
 		}
 	}
 
@@ -158,7 +158,7 @@ 
 			if (strpos($action, '@') !== false)
 			{
 				$replace = array();
-				foreach($attrs as $a => $v)
+				foreach ($attrs as $a => $v)
 				{
 					if (is_scalar($v) || is_null($v)) $replace['@'.$a] = $v;
 				}
@@ -166,14 +166,14 @@ 
 				// now replace with non-scalar value, eg. if values is an array: "@value", "@value[key] or "@value[@key]"
 				if (($a = strstr($action, '@')))
 				{
-					$action = self::get_array($attrs, substr($a,1));
+					$action = self::get_array($attrs, substr($a, 1));
 				}
 			}
 			$attrs[$attr] = $action;
 			if (self::DEBUG) error_log(__METHOD__."('$attr', ".array2string($action).") attrs['$attr'] = ".array2string($action).', attrs='.array2string($attrs));
 		}
 		// action is a serverside callback
-		elseif(is_array($action) && isset($action['__callback__']))
+		elseif (is_array($action) && isset($action['__callback__']))
 		{
 			if (!is_string(($callback = $action['__callback__'])))
 			{
@@ -183,7 +183,7 @@ 
 			{
 				$attrs[$attr] = $this->$callback($attrs[$attr], $attrs);
 			}
-			elseif(count(explode('.', $callback)) == 3)
+			elseif (count(explode('.', $callback)) == 3)
 			{
 				$attrs[$attr] = ExecMethod($callback, $attrs[$attr], $attrs);
 			}
@@ -197,29 +197,29 @@ 
 			}
 		}
 		// action is a clientside callback
-		elseif(is_array($action) && isset($action['__js__']))
+		elseif (is_array($action) && isset($action['__js__']))
 		{
 			// nothing to do here
 		}
 		// TODO: Might be a better way to handle when value to be set is an array
-		elseif(is_array($action) && $attr == 'sel_options')
+		elseif (is_array($action) && $attr == 'sel_options')
 		{
 			$attrs[$attr] = $action;
 		}
 		// action is a switch --> check cases
-		elseif(is_array($action))
+		elseif (is_array($action))
 		{
 			// case matches --> run all actions
 			if (isset($action[$attrs[$attr]]) || !isset($action[$attrs[$attr]]) && isset($action['__default__']))
 			{
 				$actions = isset($action[$attrs[$attr]]) ? $action[$attrs[$attr]] : $action['__default__'];
-				if(!is_array($actions))
+				if (!is_array($actions))
 				{
 					$attrs[$attr] = $actions;
 					$actions = array($attr => $actions);
 				}
 				if (self::DEBUG) error_log(__METHOD__."(attr='$attr', action=".array2string($action).") attrs['$attr']=='{$attrs[$attr]}' --> running actions");
-				foreach($actions as $attr => $action)
+				foreach ($actions as $attr => $action)
 				{
 					$this->action($attr, $action, $attrs);
 				}

Braces +16 added lines, -4 removed lines

@@ -150,7 +150,10 @@ 
 	 */
 	protected function action($attr, $action, array &$attrs)
 	{
-		if (self::DEBUG) error_log(__METHOD__."('$attr', ".array2string($action).')');
+		if (self::DEBUG)
+		{
+			error_log(__METHOD__."('$attr', ".array2string($action).')');
+		}
 		// action is an assignment
 		if (is_scalar($action) || is_null($action))
 		{
@@ -160,7 +163,10 @@ 
 				$replace = array();
 				foreach($attrs as $a => $v)
 				{
-					if (is_scalar($v) || is_null($v)) $replace['@'.$a] = $v;
+					if (is_scalar($v) || is_null($v))
+					{
+						$replace['@'.$a] = $v;
+					}
 				}
 				$action = strtr($action, $replace);
 				// now replace with non-scalar value, eg. if values is an array: "@value", "@value[key] or "@value[@key]"
@@ -170,7 +176,10 @@ 
 				}
 			}
 			$attrs[$attr] = $action;
-			if (self::DEBUG) error_log(__METHOD__."('$attr', ".array2string($action).") attrs['$attr'] = ".array2string($action).', attrs='.array2string($attrs));
+			if (self::DEBUG)
+			{
+				error_log(__METHOD__."('$attr', ".array2string($action).") attrs['$attr'] = ".array2string($action).', attrs='.array2string($attrs));
+			}
 		}
 		// action is a serverside callback
 		elseif(is_array($action) && isset($action['__callback__']))
@@ -218,7 +227,10 @@ 
 					$attrs[$attr] = $actions;
 					$actions = array($attr => $actions);
 				}
-				if (self::DEBUG) error_log(__METHOD__."(attr='$attr', action=".array2string($action).") attrs['$attr']=='{$attrs[$attr]}' --> running actions");
+				if (self::DEBUG)
+				{
+					error_log(__METHOD__."(attr='$attr', action=".array2string($action).") attrs['$attr']=='{$attrs[$attr]}' --> running actions");
+				}
 				foreach($actions as $attr => $action)
 				{
 					$this->action($attr, $action, $attrs);

api/src/Etemplate/Widget/Contact.php

Spacing +7 added lines, -7 removed lines

@@ -128,7 +128,7 @@ 
 
 		$this->contacts->__construct();
 		$options = $this->contacts->contact_fields;
-		foreach($this->contacts->customfields as $name => $data)
+		foreach ($this->contacts->customfields as $name => $data)
 		{
 			$options['#'.$name] = $data['label'];
 		}
@@ -148,28 +148,28 @@ 
 	 */
 	public function get_contact($value, array $attrs)
 	{
-		if (is_array($value) && !(array_key_exists('app',$value) && array_key_exists('id', $value))) return $value;
+		if (is_array($value) && !(array_key_exists('app', $value) && array_key_exists('id', $value))) return $value;
 
-		if(is_array($value) && array_key_exists('app', $value) && array_key_exists('id', $value)) $value = $value['id'];
-		switch($attrs['type'])
+		if (is_array($value) && array_key_exists('app', $value) && array_key_exists('id', $value)) $value = $value['id'];
+		switch ($attrs['type'])
 		{
 			case 'contact-account':
 			case 'contact-template':
-				if (substr($value,0,8) != 'account:')
+				if (substr($value, 0, 8) != 'account:')
 				{
 					$value = 'account:'.($attrs['name'] != 'account:' ? $value : $GLOBALS['egw_info']['user']['account_id']);
 				}
 				// fall-through
 			case 'contact-value':
 			default:
-				if (substr($value,0,12) == 'addressbook:') $value = substr($value,12);	// link-entry syntax
+				if (substr($value, 0, 12) == 'addressbook:') $value = substr($value, 12); // link-entry syntax
 				if (!($contact = $this->contacts->read($value)))
 				{
 					$contact = array();
 				}
 				break;
 		}
-		unset($contact['jpegphoto']);	// makes no sense to return binary image
+		unset($contact['jpegphoto']); // makes no sense to return binary image
 
 		//error_log(__METHOD__."('$value') returning ".array2string($contact));
 		return $contact;

Braces +13 added lines, -3 removed lines

@@ -148,9 +148,15 @@ 
 	 */
 	public function get_contact($value, array $attrs)
 	{
-		if (is_array($value) && !(array_key_exists('app',$value) && array_key_exists('id', $value))) return $value;
+		if (is_array($value) && !(array_key_exists('app',$value) && array_key_exists('id', $value)))
+		{
+			return $value;
+		}
 
-		if(is_array($value) && array_key_exists('app', $value) && array_key_exists('id', $value)) $value = $value['id'];
+		if(is_array($value) && array_key_exists('app', $value) && array_key_exists('id', $value))
+		{
+			$value = $value['id'];
+		}
 		switch($attrs['type'])
 		{
 			case 'contact-account':
@@ -162,7 +168,11 @@ 
 				// fall-through
 			case 'contact-value':
 			default:
-				if (substr($value,0,12) == 'addressbook:') $value = substr($value,12);	// link-entry syntax
+				if (substr($value,0,12) == 'addressbook:')
+				{
+					$value = substr($value,12);
+				}
+				// link-entry syntax
 				if (!($contact = $this->contacts->read($value)))
 				{
 					$contact = array();