EGroupware / egroupware

importexport/inc/class.importexport_iface_egw_record.inc.php

Doc Comments +3 added lines

@@ -35,6 +35,7 @@ 
 	 * reads record from backend if identifier is given.
 	 *
 	 * @param string $_identifier
+	 * @return void
 	 */
 	public function __construct( $_identifier='' );
 	
@@ -50,6 +51,7 @@ 
 	 *
 	 * @param string $_attribute_name
 	 * @param data $data
+	 * @return void
 	 */
 	public function __set($_attribute_name, $data);
 	
@@ -126,6 +128,7 @@ 
 	/**
 	 * destructor
 	 *
+	 * @return void
 	 */
 	public function __destruct();
 

Spacing +5 added lines, -5 removed lines

@@ -36,7 +36,7 @@ 
 	 *
 	 * @param string $_identifier
 	 */
-	public function __construct( $_identifier='' );
+	public function __construct($_identifier = '');
 	
 	/**
 	 * magic method to set attributes of record
@@ -97,7 +97,7 @@ 
 	 *
 	 * @return string identifier
 	 */
-	public function save ( $_dst_identifier );
+	public function save($_dst_identifier);
 	
 	/**
 	 * copys current record to record identified by $_dst_identifier
@@ -105,7 +105,7 @@ 
 	 * @param string $_dst_identifier
 	 * @return string dst_identifier
 	 */
-	public function copy ( $_dst_identifier );
+	public function copy($_dst_identifier);
 	
 	/**
 	 * moves current record to record identified by $_dst_identifier
@@ -114,14 +114,14 @@ 
 	 * @param string $_dst_identifier
 	 * @return string dst_identifier
 	 */
-	public function move ( $_dst_identifier );
+	public function move($_dst_identifier);
 	
 	/**
 	 * delets current record from backend
 	 * @return void
 	 *
 	 */
-	public function delete ();
+	public function delete();
 	
 	/**
 	 * destructor

importexport/inc/class.importexport_iface_export_plugin.inc.php

Doc Comments +1 added lines, -1 removed lines

@@ -107,7 +107,7 @@
 	 * and automatic conversions.  In most cases they are named <appname>_egw_record,
 	 * but projectmanager is an exception to this.
 	 *
-	 * @return string;
+	 * @return string
 	 */
 	public static function get_egw_record_class();
 } // end of iface_export_plugin

Braces +2 added lines, -1 removed lines

@@ -34,7 +34,8 @@
  *
  * get_selector();  //returns array
  */
-interface importexport_iface_export_plugin {
+interface importexport_iface_export_plugin
+{
 	
 	/**
 	 * exports entries according to given definition object.

importexport/inc/class.importexport_iface_export_record.inc.php

Doc Comments +1 added lines, -1 removed lines

@@ -54,7 +54,7 @@
 	 * destructor
 	 *
 	 * @return 
-	 */
+	 void
 	public function __destruct( );
 
 } // end of iface_export_record

Spacing +2 added lines, -2 removed lines

@@ -33,7 +33,7 @@ 
 	 * @param array $_options options for specific backends
 	 * @return bool
 	 */
-	public function __construct( $_stream, array $_options );
+	public function __construct($_stream, array $_options);
 	
 	/**
 	 * exports a record into resource of handle
@@ -41,7 +41,7 @@ 
 	 * @param object of interface egw_record _record
 	 * @return bool
 	 */
-	public function export_record( importexport_iface_egw_record $_record );
+	public function export_record(importexport_iface_egw_record $_record);
 
 	/**
 	 * Retruns total number of exported records.

importexport/inc/class.importexport_iface_import_plugin.inc.php

Doc Comments +2 added lines, -2 removed lines

@@ -29,8 +29,8 @@
 	/**
 	 * imports entries according to given definition object.
 	 *
-	 * @param stram $_stram
-	 * @param definition $_definition
+	 * @param stram $_stream
+	 * @param importexport_definition $_definition
 	 * @return int number of successful imports
 	 */
 	public function import( $_stream, importexport_definition $_definition );

Indentation +21 added lines, -21 removed lines

@@ -88,33 +88,33 @@
 	public function get_selectors_etpl();
 
 	/**
-	* Returns errors that were encountered during importing
-	* Maximum of one error message per record, but you can concatenate them if you need to
-	*
-	* @return Array (
-	*	record_# => error message
-	*	)
-	*/
+	 * Returns errors that were encountered during importing
+	 * Maximum of one error message per record, but you can concatenate them if you need to
+	 *
+	 * @return Array (
+	 *	record_# => error message
+	 *	)
+	 */
 	public function get_errors();
 
 	/**
-	* Returns warnings that were encountered during importing
-	* Maximum of one warning message per record, but you can concatenate them if you need to
-	*
-	* @return Array (
-	*	record_# => warning message
-	*	)
-	*/
+	 * Returns warnings that were encountered during importing
+	 * Maximum of one warning message per record, but you can concatenate them if you need to
+	 *
+	 * @return Array (
+	 *	record_# => warning message
+	 *	)
+	 */
 	public function get_warnings();
 
 	/**
-	* Returns a list of actions taken, and the number of records for that action.
-	* Actions are things like 'insert', 'update', 'delete', and may be different for each plugin.
-	*
-	* @return Array (
-	*	action => record count
-	* )
-	*/
+	 * Returns a list of actions taken, and the number of records for that action.
+	 * Actions are things like 'insert', 'update', 'delete', and may be different for each plugin.
+	 *
+	 * @return Array (
+	 *	action => record count
+	 * )
+	 */
 	public function get_results();
 
 } // end of iface_export_plugin

Spacing +1 added lines, -1 removed lines

@@ -33,7 +33,7 @@
 	 * @param definition $_definition
 	 * @return int number of successful imports
 	 */
-	public function import( $_stream, importexport_definition $_definition );
+	public function import($_stream, importexport_definition $_definition);
 
 	/**
 	 * Reads entries, and presents them back as they will be understood

Braces +2 added lines, -1 removed lines

@@ -24,7 +24,8 @@
  * So this interface just garanties the interaction with userinterfaces. It
  * has nothing to do with datatypes.
  */
-interface importexport_iface_import_plugin {
+interface importexport_iface_import_plugin
+{
 	
 	/**
 	 * imports entries according to given definition object.

importexport/inc/class.importexport_iface_import_record.inc.php

Doc Comments +1 added lines, -1 removed lines

@@ -33,7 +33,7 @@
 	 * cleanup
 	 *
 	 * @return 
-	 */
+	 void
 	public function __destruct( );
 
 	/**

Spacing +2 added lines, -2 removed lines

@@ -27,7 +27,7 @@ 
 	 * @param array $_options options for specific backends
 	 * @return bool
 	 */
-	public function __construct( $_stream, array $_options );
+	public function __construct($_stream, array $_options);
 
 	/**
 	 * cleanup
@@ -42,7 +42,7 @@ 
 	 * @param string _position may be: {first|last|next|previous|somenumber}
 	 * @return bool
 	 */
-	public function get_record( $_position = 'next' );
+	public function get_record($_position = 'next');
 
 	/**
 	 * Retruns total number of records for the open resource.

importexport/inc/class.importexport_import_csv.inc.php

Doc Comments +3 added lines, -3 removed lines

@@ -137,8 +137,8 @@ 
 	/**
 	 * updates $this->record
 	 *
-	 * @param mixed $_position
-	 * @return bool
+	 * @param string $_position
+	 * @return null|false
 	 */
 	private function get_raw_record( $_position = 'next' ) {
 		switch ($_position) {
@@ -244,7 +244,7 @@ 
 	/**
 	 * does conversions according to $this->conversion
 	 *
-	 * @return bool
+	 * @return boolean|null
 	 */
 	protected function do_conversions() {
 		if ( $record = importexport_helper_functions::conversion( $this->record, $this->conversion, $this->conversion_class )) {

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -264,7 +264,7 @@
 	 *
 	 * @return string warnings, if any
 	 */
-	public static function convert(Array &$record, Array $fields = array(), $appname = null, Array $selects = array(), $format=0) {
+	public static function convert(array &$record, array $fields = array(), $appname = null, array $selects = array(), $format=0) {
 		$warnings = array();
 
 		// Automatic conversions

Spacing +82 added lines, -82 removed lines

@@ -83,10 +83,10 @@ 
 	 * @param string $_resource resource containing data. May be each valid php-stream
 	 * @param array $_options options for the resource array with keys: charset and fieldsep
 	 */
-	public function __construct( $_resource,  array $_options ) {
+	public function __construct($_resource, array $_options) {
 		$this->resource = $_resource;
 		$this->csv_fieldsep = $_options['fieldsep'];
-		if($_options['charset'] == 'user') $_options['charset'] = $GLOBALS['egw_info']['user']['preferences']['common']['csv_charset'];
+		if ($_options['charset'] == 'user') $_options['charset'] = $GLOBALS['egw_info']['user']['preferences']['common']['csv_charset'];
 		$this->csv_charset = $_options['charset'];
 		return;
 	} // end of member function __construct
@@ -103,20 +103,20 @@ 
 	 * @param mixed _position may be: {current|first|last|next|previous|somenumber}
 	 * @return mixed array with data / false if no furtor records
 	 */
-	public function get_record( $_position = 'next' ) {
+	public function get_record($_position = 'next') {
 		
-		if ($this->get_raw_record( $_position ) === false) {
+		if ($this->get_raw_record($_position) === false) {
 			return false;
 		}
 		
 		// skip empty records
-		if( count( array_unique( $this->record ) ) < 2 ) return $this->get_record( $_position );
+		if (count(array_unique($this->record)) < 2) return $this->get_record($_position);
 		
-		if ( !empty( $this->conversion ) ) {
+		if (!empty($this->conversion)) {
 			$this->do_conversions();
 		}
 		
-		if ( !empty( $this->mapping ) ) {
+		if (!empty($this->mapping)) {
 			$this->do_fieldmapping();
 		}
 		
@@ -128,9 +128,9 @@ 
 	 *
 	 * @param int $_numToSkip
 	 */
-	public function skip_records( $_numToSkip ) {
-		while ( (int)$_numToSkip-- !== 0 ) {
-			fgetcsv( $this->resource, self::csv_max_linelength, $this->csv_fieldsep);
+	public function skip_records($_numToSkip) {
+		while ((int)$_numToSkip-- !== 0) {
+			fgetcsv($this->resource, self::csv_max_linelength, $this->csv_fieldsep);
 		}
 	}
 	
@@ -140,7 +140,7 @@ 
 	 * @param mixed $_position
 	 * @return bool
 	 */
-	private function get_raw_record( $_position = 'next' ) {
+	private function get_raw_record($_position = 'next') {
 		switch ($_position) {
 			case 'current' :
 				if ($this->current_position == 0) {
@@ -154,7 +154,7 @@ 
 				}
 				
 			case 'next' :
-				$csv_data = fgetcsv( $this->resource, self::csv_max_linelength, $this->csv_fieldsep);
+				$csv_data = fgetcsv($this->resource, self::csv_max_linelength, $this->csv_fieldsep);
 				if (!is_array($csv_data)) {
 					return false;
 				}
@@ -235,7 +235,7 @@ 
 		$this->record = array();
 		foreach ($this->mapping as $cvs_idx => $new_idx)
 		{
-			if( $new_idx == '' ) continue;
+			if ($new_idx == '') continue;
 			$this->record[$new_idx] = $record[$cvs_idx];
 		}
 		return true;
@@ -247,7 +247,7 @@ 
 	 * @return bool
 	 */
 	protected function do_conversions() {
-		if ( $record = importexport_helper_functions::conversion( $this->record, $this->conversion, $this->conversion_class )) {
+		if ($record = importexport_helper_functions::conversion($this->record, $this->conversion, $this->conversion_class)) {
 			$this->record = $record;
 			return;
 		}
@@ -264,25 +264,25 @@ 
 	 *
 	 * @return string warnings, if any
 	 */
-	public static function convert(Array &$record, Array $fields = array(), $appname = null, Array $selects = array(), $format=0) {
+	public static function convert(Array &$record, Array $fields = array(), $appname = null, Array $selects = array(), $format = 0) {
 		$warnings = array();
 
 		// Automatic conversions
-		if($appname) {
+		if ($appname) {
 
 			// Load translations
 			Api\Translation::add_app($appname);
 
-			if(!self::$cf_parse_cache[$appname]) {
+			if (!self::$cf_parse_cache[$appname]) {
 				$c_fields = importexport_export_csv::convert_parse_custom_fields($appname, $selects, $links, $methods);
 				self::$cf_parse_cache[$appname] = array($c_fields, $selects, $links, $methods);
 			}
 			list($c_fields, $c_selects, $links, $methods) = self::$cf_parse_cache[$appname];
 
 			// Add in any fields that are keys to another app
-			foreach((array)$fields['links'] as $link_field => $app)
+			foreach ((array)$fields['links'] as $link_field => $app)
 			{
-				if(is_numeric($link_field)) continue;
+				if (is_numeric($link_field)) continue;
 				$links[$link_field] = $app;
 				// Set it as a normal link field
 				$fields['links'][] = $link_field;
@@ -290,9 +290,9 @@ 
 			}
 
 			// Not quite a recursive merge, since only one level
-			foreach($fields as $type => &$list)
+			foreach ($fields as $type => &$list)
 			{
-				if($c_fields[$type]) {
+				if ($c_fields[$type]) {
 					$list = array_merge($c_fields[$type], $list);
 					unset($c_fields[$type]);
 				}
@@ -300,26 +300,26 @@ 
 			$fields += $c_fields;
 			$selects += $c_selects;
 		}
-		if($fields) {
-			foreach((array)$fields['select'] as $name) {
+		if ($fields) {
+			foreach ((array)$fields['select'] as $name) {
 				$record[$name] = static::find_select_key($record[$name], $selects[$name]);
 			}
 			
-			foreach((array)$fields['links'] as $name) {
-				if($record[$name] && $links[$name])
+			foreach ((array)$fields['links'] as $name) {
+				if ($record[$name] && $links[$name])
 				{
 					// Primary key to another app, not a link
 					// Text - search for a matching record
-					if(!is_numeric($record[$name]))
+					if (!is_numeric($record[$name]))
 					{
 						$results = Link::query($links[$name], $record[$name]);
-						if(count($results) >= 1)
+						if (count($results) >= 1)
 						{
 							// More than 1 result.  Check for exact match
 							$exact_count = 0;
-							foreach($results as $id => $title)
+							foreach ($results as $id => $title)
 							{
-								if($title == $record[$name])
+								if ($title == $record[$name])
 								{
 									$exact_count++;
 									$app_id = $id;
@@ -328,11 +328,11 @@ 
 								unset($results[$id]);
 							}
 							// Too many exact matches, or none good enough
-							if($exact_count > 1 || count($results) == 0)
+							if ($exact_count > 1 || count($results) == 0)
 							{
 								$warnings[] = lang('Unable to link to %1 "%2"',
 									lang($links[$name]), $record[$name]).
- 									' - ' .lang('too many matches');
+ 									' - '.lang('too many matches');
 								continue;
 							}
 							elseif ($exact_count == 1)
@@ -345,7 +345,7 @@ 
 						{
 							$warnings[] = lang('Unable to link to %1 "%2"',
 								lang($links[$name]), $record[$name]).
- 								' - ' . lang('no matches');
+ 								' - '.lang('no matches');
 							continue;
 						} else {
 							$record[$name] = key($results);
@@ -353,17 +353,17 @@ 
 					}
 				}
 			}
-			foreach((array)$fields['select-account'] as $name) {
+			foreach ((array)$fields['select-account'] as $name) {
 				// Compare against null to deal with empty arrays
 				if ($record[$name]) {
 					// Automatically handle text owner without explicit translation
 					$new_owner = importexport_helper_functions::account_name2id($record[$name]);
-					if(count($new_owner) != count(explode(',',$record[$name])))
+					if (count($new_owner) != count(explode(',', $record[$name])))
 					{
 						// Unable to parse value into account
-						$warnings[] = $name . ': ' .lang('%1 is not a known user or group', $record[$name]);
+						$warnings[] = $name.': '.lang('%1 is not a known user or group', $record[$name]);
 					}
-					if($new_owner != '') {
+					if ($new_owner != '') {
 						$record[$name] = $new_owner;
 					} else {
 						// Clear it to prevent trouble later on
@@ -371,24 +371,24 @@ 
 					}
 				}
 			}
-			foreach((array)$fields['select-bool'] as $name) {
-				if($record[$name] != null && $record[$name] != '') {
+			foreach ((array)$fields['select-bool'] as $name) {
+				if ($record[$name] != null && $record[$name] != '') {
 					$record[$name] = ($record[$name] == lang('Yes') || $record[$name] == '1' ? 1 : 0);
 				}
 			}
-			foreach((array)$fields['date-time'] as $name) {
+			foreach ((array)$fields['date-time'] as $name) {
 				if (isset($record[$name]) && !is_numeric($record[$name]) && strlen(trim($record[$name])) > 0)
 				{
 					// Need to handle format first
-					if($format == 1)
+					if ($format == 1)
 					{
 						$formatted = Api\DateTime::createFromFormat(
-							'!'.Api\DateTime::$user_dateformat . ' ' .Api\DateTime::$user_timeformat,
+							'!'.Api\DateTime::$user_dateformat.' '.Api\DateTime::$user_timeformat,
 							$record[$name],
 							Api\DateTime::$user_timezone
 						);
 
-						if(!$formatted && $errors = Api\DateTime::getLastErrors())
+						if (!$formatted && $errors = Api\DateTime::getLastErrors())
 						{
 							// Try again, without time
 							$formatted = Api\DateTime::createFromFormat(
@@ -397,70 +397,70 @@ 
 								Api\DateTime::$user_timezone
 							);
 							
-							if(!$formatted && $errors = Api\DateTime::getLastErrors())
+							if (!$formatted && $errors = Api\DateTime::getLastErrors())
 							{
 								// Try again, anything goes
 								try {
 									$formatted = new Api\DateTime($record[$name]);
 								} catch (Exception $e) {
-									$warnings[] = $name.': ' . $e->getMessage() . "\n" .
-										'Format: '.'!'.Api\DateTime::$user_dateformat . ' ' .Api\DateTime::$user_timeformat;
+									$warnings[] = $name.': '.$e->getMessage()."\n".
+										'Format: '.'!'.Api\DateTime::$user_dateformat.' '.Api\DateTime::$user_timeformat;
 									continue;
 								}
 								$errors = Api\DateTime::getLastErrors();
-								foreach($errors['errors'] as $char => $msg)
+								foreach ($errors['errors'] as $char => $msg)
 								{
 									$warnings[] = "$name: [$char] $msg\n".
-										'Format: '.'!'.Api\DateTime::$user_dateformat . ' ' .Api\DateTime::$user_timeformat;
+										'Format: '.'!'.Api\DateTime::$user_dateformat.' '.Api\DateTime::$user_timeformat;
 								}
 							}
 						}
-						if($formatted)
+						if ($formatted)
 						{
 							$record[$name] = $formatted->getTimestamp();
 							// Timestamp is apparently in server time, but apps will do the same conversion
-							$record[$name] = Api\DateTime::server2user($record[$name],'ts');
+							$record[$name] = Api\DateTime::server2user($record[$name], 'ts');
 						}
 					}
 					
-					if(is_array(self::$cf_parse_cache[$appname][0]['date-time']) &&
+					if (is_array(self::$cf_parse_cache[$appname][0]['date-time']) &&
 							in_array($name, self::$cf_parse_cache[$appname][0]['date-time'])) {
 						// Custom fields stored in a particular format (from customfields_widget)
 						$record[$name] = date('Y-m-d H:i:s', $record[$name]);
 					}
 				}
-				if(array_key_exists($name, $record) && strlen(trim($record[$name])) == 0)
+				if (array_key_exists($name, $record) && strlen(trim($record[$name])) == 0)
 				{
 					$record[$name] = null;
 				}
 			}
-			foreach((array)$fields['date'] as $name) {
+			foreach ((array)$fields['date'] as $name) {
 				if (isset($record[$name]) && !is_numeric($record[$name]) && strlen(trim($record[$name])) > 0)
 				{
 					// Need to handle format first
-					if($format == 1)
+					if ($format == 1)
 					{
 						$formatted = Api\DateTime::createFromFormat('!'.Api\DateTime::$user_dateformat, $record[$name]);
-						if($formatted && $errors = Api\DateTime::getLastErrors() && $errors['error_count'] == 0)
+						if ($formatted && $errors = Api\DateTime::getLastErrors() && $errors['error_count'] == 0)
 						{
 							$record[$name] = $formatted->getTimestamp();
 						}
 					}
-					$record[$name] = Api\DateTime::server2user($record[$name],'ts');
-					if(is_array(self::$cf_parse_cache[$appname][0]['date']) &&
+					$record[$name] = Api\DateTime::server2user($record[$name], 'ts');
+					if (is_array(self::$cf_parse_cache[$appname][0]['date']) &&
 							in_array($name, self::$cf_parse_cache[$appname][0]['date'])) {
 						// Custom fields stored in a particular format (from customfields_widget)
 						$record[$name] = date('Y-m-d', $record[$name]);
 					}
 				}
-				if(array_key_exists($name, $record) && strlen(trim($record[$name])) == 0)
+				if (array_key_exists($name, $record) && strlen(trim($record[$name])) == 0)
 				{
 					$record[$name] = null;
 				}
 			}
-			foreach((array)$fields['float'] as $name)
+			foreach ((array)$fields['float'] as $name)
 			{
-				if($record[$name] != null && $record[$name] != '') {
+				if ($record[$name] != null && $record[$name] != '') {
 					$dec_point = $GLOBALS['egw_info']['user']['preferences']['common']['number_format'][0];
 					if (empty($dec_point)) $dec_point = '.';
 					$record[$name] = floatval(str_replace($dec_point, '.', preg_replace('/[^\d'.preg_quote($dec_point).']/', '', $record[$name])));
@@ -468,23 +468,23 @@ 
 			}
 
 			// Some custom methods for conversion
-			foreach((array)$methods as $name => $method) {
-				if($record[$name]) $record[$name] = ExecMethod($method, $record[$name]);
+			foreach ((array)$methods as $name => $method) {
+				if ($record[$name]) $record[$name] = ExecMethod($method, $record[$name]);
 			}
 
 			// cat_name2id will use currentapp to create new categories
 			$current_app = $GLOBALS['egw_info']['flags']['currentapp'];
-			if($appname) {
+			if ($appname) {
 				$GLOBALS['egw_info']['flags']['currentapp'] = $appname;
 			}
-			$categories = new Api\Categories('',$appname);
-			foreach((array)$fields['select-cat'] as $name) {
-				if($record[$name]) {
+			$categories = new Api\Categories('', $appname);
+			foreach ((array)$fields['select-cat'] as $name) {
+				if ($record[$name]) {
 					// Only parse name if it needs it
-					if($format == 1)
+					if ($format == 1)
 					{
-						$existing_cat = $categories->exists('all',$record[$name]);
-						if($existing_cat)
+						$existing_cat = $categories->exists('all', $record[$name]);
+						if ($existing_cat)
 						{
 							$cat_id = $existing_cat;
 						}
@@ -493,14 +493,14 @@ 
 							$cat_id = importexport_helper_functions::cat_name2id($record[$name]);
 						}
 						// Don't clear it if it wasn't found
-						if($cat_id) $record[$name] = $cat_id;
+						if ($cat_id) $record[$name] = $cat_id;
 					}
 				}
 			}
 			$GLOBALS['egw_info']['flags']['currentapp'] = $current_app;
 		}
 
-		return implode("\n",$warnings);
+		return implode("\n", $warnings);
 	}
 
 	/**
@@ -514,36 +514,36 @@ 
 	 */
 	protected static function find_select_key($record_value, $selects)
 	{
-		if($record_value != null && is_array($selects)) {
-			if(is_array($record_value) || is_string($record_value) && strpos($record_value, ',') !== FALSE)
+		if ($record_value != null && is_array($selects)) {
+			if (is_array($record_value) || is_string($record_value) && strpos($record_value, ',') !== FALSE)
 			{
 				// Array, or CSV
 				$key = array();
-				$subs = explode(',',$record_value);
-				for($sub_index = 0; $sub_index < count($subs); $sub_index++)
+				$subs = explode(',', $record_value);
+				for ($sub_index = 0; $sub_index < count($subs); $sub_index++)
 				{
 					$sub_key = static::find_select_key($subs[$sub_index], $selects);
-					if(!$sub_key)
+					if (!$sub_key)
 					{
-						$sub_key = static::find_select_key($subs[$sub_index].','.$subs[$sub_index+1], $selects);
-						if($sub_key) $sub_index++;
+						$sub_key = static::find_select_key($subs[$sub_index].','.$subs[$sub_index + 1], $selects);
+						if ($sub_key) $sub_index++;
 					}
-					if($sub_key)
+					if ($sub_key)
 					{
 						$key[] = $sub_key;
 					}
 				}
 				return $key;
 			}
-			$key = array_search(strtolower($record_value), array_map('strtolower',$selects));
-			if($key !== false)
+			$key = array_search(strtolower($record_value), array_map('strtolower', $selects));
+			if ($key !== false)
 			{
 				$record_value = $key;
 			}
 			else
 			{
-				$key = array_search(strtolower($record_value), array_map('strtolower',array_map('lang',$selects)));
-				if($key !== false) $record_value = $key;
+				$key = array_search(strtolower($record_value), array_map('strtolower', array_map('lang', $selects)));
+				if ($key !== false) $record_value = $key;
 			}
 		}
 

Braces +147 added lines, -62 removed lines

@@ -22,7 +22,9 @@ 
  * @todo Throw away spechial chars and trim() entries ?
  * @todo Check for XSS like userinput! (see common_functions)
  */
-class importexport_import_csv implements importexport_iface_import_record { //, Iterator {
+class importexport_import_csv implements importexport_iface_import_record
+{
+//, Iterator {
 
 	const csv_max_linelength = 8000;
 	
@@ -83,10 +85,14 @@ 
 	 * @param string $_resource resource containing data. May be each valid php-stream
 	 * @param array $_options options for the resource array with keys: charset and fieldsep
 	 */
-	public function __construct( $_resource,  array $_options ) {
+	public function __construct( $_resource,  array $_options )
+	{
 		$this->resource = $_resource;
 		$this->csv_fieldsep = $_options['fieldsep'];
-		if($_options['charset'] == 'user') $_options['charset'] = $GLOBALS['egw_info']['user']['preferences']['common']['csv_charset'];
+		if($_options['charset'] == 'user')
+		{
+			$_options['charset'] = $GLOBALS['egw_info']['user']['preferences']['common']['csv_charset'];
+		}
 		$this->csv_charset = $_options['charset'];
 		return;
 	} // end of member function __construct
@@ -94,7 +100,8 @@ 
 	/**
 	 * cleanup
 	 */
-	public function __destruct( ) {
+	public function __destruct( )
+	{
 	} // end of member function __destruct
 
 	/**
@@ -103,20 +110,27 @@ 
 	 * @param mixed _position may be: {current|first|last|next|previous|somenumber}
 	 * @return mixed array with data / false if no furtor records
 	 */
-	public function get_record( $_position = 'next' ) {
+	public function get_record( $_position = 'next' )
+	{
 		
-		if ($this->get_raw_record( $_position ) === false) {
+		if ($this->get_raw_record( $_position ) === false)
+		{
 			return false;
 		}
 		
 		// skip empty records
-		if( count( array_unique( $this->record ) ) < 2 ) return $this->get_record( $_position );
+		if( count( array_unique( $this->record ) ) < 2 )
+		{
+			return $this->get_record( $_position );
+		}
 		
-		if ( !empty( $this->conversion ) ) {
+		if ( !empty( $this->conversion ) )
+		{
 			$this->do_conversions();
 		}
 		
-		if ( !empty( $this->mapping ) ) {
+		if ( !empty( $this->mapping ) )
+		{
 			$this->do_fieldmapping();
 		}
 		
@@ -128,8 +142,10 @@ 
 	 *
 	 * @param int $_numToSkip
 	 */
-	public function skip_records( $_numToSkip ) {
-		while ( (int)$_numToSkip-- !== 0 ) {
+	public function skip_records( $_numToSkip )
+	{
+		while ( (int)$_numToSkip-- !== 0 )
+		{
 			fgetcsv( $this->resource, self::csv_max_linelength, $this->csv_fieldsep);
 		}
 	}
@@ -140,22 +156,27 @@ 
 	 * @param mixed $_position
 	 * @return bool
 	 */
-	private function get_raw_record( $_position = 'next' ) {
-		switch ($_position) {
+	private function get_raw_record( $_position = 'next' )
+	{
+		switch ($_position)
+		{
 			case 'current' :
-				if ($this->current_position == 0) {
+				if ($this->current_position == 0)
+				{
 					return;
 				}
 				break;
 			case 'first' :
-				if (!$this->current_position == 0) {
+				if (!$this->current_position == 0)
+				{
 					$this->current_position = 0;
 					rewind($this->resource);
 				}
 				
 			case 'next' :
 				$csv_data = fgetcsv( $this->resource, self::csv_max_linelength, $this->csv_fieldsep);
-				if (!is_array($csv_data)) {
+				if (!is_array($csv_data))
+				{
 					return false;
 				}
 				$this->current_position++;
@@ -163,33 +184,41 @@ 
 				break;
 				
 			case 'previous' :
-				if ($this->current_position < 2) {
+				if ($this->current_position < 2)
+				{
 					throw new Exception('Error: There is no previous record!');
 				}
 				$final_position = --$this->current_position;
 				$this->current_position = 0;
 				rewind($this->resource);
-				while ($this->current_position !== $final_position) {
+				while ($this->current_position !== $final_position)
+				{
 					$this->get_raw_record();
 				}
 				break;
 				
 			case 'last' :
-				while ($this->get_raw_record()) {}
+				while ($this->get_raw_record())
+				{
+}
 				break;
 				
 			default: //somenumber
-				if (!is_int($_position)) {
+				if (!is_int($_position))
+				{
 					throw new Exception('Error: $position must be one of {current|first|last|next|previous} or an integer value');
 				}
-				if ($_position == $this->current_position) {
+				if ($_position == $this->current_position)
+				{
 					break;
 				}
-				elseif ($_position < $this->current_position) {
+				elseif ($_position < $this->current_position)
+				{
 					$this->current_position = 0;
 					rewind($this->resource);
 				}
-				while ($this->current_position !== $_position) {
+				while ($this->current_position !== $_position)
+				{
 					$this->get_raw_record();
 				}
 				break;				
@@ -202,12 +231,16 @@ 
 	 *
 	 * @return int
 	 */
-	public function get_num_of_records( ) {
-		if ($this->num_of_records > 0) {
+	public function get_num_of_records( )
+	{
+		if ($this->num_of_records > 0)
+		{
 			return $this->num_of_records;
 		}
 		$current_position = $this->current_position;
-		while ($this->get_raw_record()) {}
+		while ($this->get_raw_record())
+		{
+}
 		$this->num_of_records = $this->current_position;
 		$this->get_record($current_position);
 		return $this->num_of_records;
@@ -218,7 +251,8 @@ 
 	 *
 	 * @return int
 	 */
-	public function get_current_position( ) {
+	public function get_current_position( )
+	{
 		
 		return $this->current_position;
 		
@@ -230,12 +264,16 @@ 
 	 *
 	 * @return
 	 */
-	protected function do_fieldmapping( ) {
+	protected function do_fieldmapping( )
+	{
 		$record = $this->record;
 		$this->record = array();
 		foreach ($this->mapping as $cvs_idx => $new_idx)
 		{
-			if( $new_idx == '' ) continue;
+			if( $new_idx == '' )
+			{
+				continue;
+			}
 			$this->record[$new_idx] = $record[$cvs_idx];
 		}
 		return true;
@@ -246,8 +284,10 @@ 
 	 *
 	 * @return bool
 	 */
-	protected function do_conversions() {
-		if ( $record = importexport_helper_functions::conversion( $this->record, $this->conversion, $this->conversion_class )) {
+	protected function do_conversions()
+	{
+		if ( $record = importexport_helper_functions::conversion( $this->record, $this->conversion, $this->conversion_class ))
+		{
 			$this->record = $record;
 			return;
 		}
@@ -264,16 +304,19 @@ 
 	 *
 	 * @return string warnings, if any
 	 */
-	public static function convert(Array &$record, Array $fields = array(), $appname = null, Array $selects = array(), $format=0) {
+	public static function convert(Array &$record, Array $fields = array(), $appname = null, Array $selects = array(), $format=0)
+	{
 		$warnings = array();
 
 		// Automatic conversions
-		if($appname) {
+		if($appname)
+		{
 
 			// Load translations
 			Api\Translation::add_app($appname);
 
-			if(!self::$cf_parse_cache[$appname]) {
+			if(!self::$cf_parse_cache[$appname])
+			{
 				$c_fields = importexport_export_csv::convert_parse_custom_fields($appname, $selects, $links, $methods);
 				self::$cf_parse_cache[$appname] = array($c_fields, $selects, $links, $methods);
 			}
@@ -282,7 +325,10 @@ 
 			// Add in any fields that are keys to another app
 			foreach((array)$fields['links'] as $link_field => $app)
 			{
-				if(is_numeric($link_field)) continue;
+				if(is_numeric($link_field))
+				{
+					continue;
+				}
 				$links[$link_field] = $app;
 				// Set it as a normal link field
 				$fields['links'][] = $link_field;
@@ -292,7 +338,8 @@ 
 			// Not quite a recursive merge, since only one level
 			foreach($fields as $type => &$list)
 			{
-				if($c_fields[$type]) {
+				if($c_fields[$type])
+				{
 					$list = array_merge($c_fields[$type], $list);
 					unset($c_fields[$type]);
 				}
@@ -300,12 +347,15 @@ 
 			$fields += $c_fields;
 			$selects += $c_selects;
 		}
-		if($fields) {
-			foreach((array)$fields['select'] as $name) {
+		if($fields)
+		{
+			foreach((array)$fields['select'] as $name)
+			{
 				$record[$name] = static::find_select_key($record[$name], $selects[$name]);
 			}
 			
-			foreach((array)$fields['links'] as $name) {
+			foreach((array)$fields['links'] as $name)
+			{
 				if($record[$name] && $links[$name])
 				{
 					// Primary key to another app, not a link
@@ -347,15 +397,19 @@ 
 								lang($links[$name]), $record[$name]).
  								' - ' . lang('no matches');
 							continue;
-						} else {
+						}
+						else
+						{
 							$record[$name] = key($results);
 						}
 					}
 				}
 			}
-			foreach((array)$fields['select-account'] as $name) {
+			foreach((array)$fields['select-account'] as $name)
+			{
 				// Compare against null to deal with empty arrays
-				if ($record[$name]) {
+				if ($record[$name])
+				{
 					// Automatically handle text owner without explicit translation
 					$new_owner = importexport_helper_functions::account_name2id($record[$name]);
 					if(count($new_owner) != count(explode(',',$record[$name])))
@@ -363,20 +417,26 @@ 
 						// Unable to parse value into account
 						$warnings[] = $name . ': ' .lang('%1 is not a known user or group', $record[$name]);
 					}
-					if($new_owner != '') {
+					if($new_owner != '')
+					{
 						$record[$name] = $new_owner;
-					} else {
+					}
+					else
+					{
 						// Clear it to prevent trouble later on
 						$record[$name] = '';
 					}
 				}
 			}
-			foreach((array)$fields['select-bool'] as $name) {
-				if($record[$name] != null && $record[$name] != '') {
+			foreach((array)$fields['select-bool'] as $name)
+			{
+				if($record[$name] != null && $record[$name] != '')
+				{
 					$record[$name] = ($record[$name] == lang('Yes') || $record[$name] == '1' ? 1 : 0);
 				}
 			}
-			foreach((array)$fields['date-time'] as $name) {
+			foreach((array)$fields['date-time'] as $name)
+			{
 				if (isset($record[$name]) && !is_numeric($record[$name]) && strlen(trim($record[$name])) > 0)
 				{
 					// Need to handle format first
@@ -402,7 +462,8 @@ 
 								// Try again, anything goes
 								try {
 									$formatted = new Api\DateTime($record[$name]);
-								} catch (Exception $e) {
+								}
+								catch (Exception $e) {
 									$warnings[] = $name.': ' . $e->getMessage() . "\n" .
 										'Format: '.'!'.Api\DateTime::$user_dateformat . ' ' .Api\DateTime::$user_timeformat;
 									continue;
@@ -424,7 +485,8 @@ 
 					}
 					
 					if(is_array(self::$cf_parse_cache[$appname][0]['date-time']) &&
-							in_array($name, self::$cf_parse_cache[$appname][0]['date-time'])) {
+							in_array($name, self::$cf_parse_cache[$appname][0]['date-time']))
+					{
 						// Custom fields stored in a particular format (from customfields_widget)
 						$record[$name] = date('Y-m-d H:i:s', $record[$name]);
 					}
@@ -434,7 +496,8 @@ 
 					$record[$name] = null;
 				}
 			}
-			foreach((array)$fields['date'] as $name) {
+			foreach((array)$fields['date'] as $name)
+			{
 				if (isset($record[$name]) && !is_numeric($record[$name]) && strlen(trim($record[$name])) > 0)
 				{
 					// Need to handle format first
@@ -448,7 +511,8 @@ 
 					}
 					$record[$name] = Api\DateTime::server2user($record[$name],'ts');
 					if(is_array(self::$cf_parse_cache[$appname][0]['date']) &&
-							in_array($name, self::$cf_parse_cache[$appname][0]['date'])) {
+							in_array($name, self::$cf_parse_cache[$appname][0]['date']))
+					{
 						// Custom fields stored in a particular format (from customfields_widget)
 						$record[$name] = date('Y-m-d', $record[$name]);
 					}
@@ -460,26 +524,37 @@ 
 			}
 			foreach((array)$fields['float'] as $name)
 			{
-				if($record[$name] != null && $record[$name] != '') {
+				if($record[$name] != null && $record[$name] != '')
+				{
 					$dec_point = $GLOBALS['egw_info']['user']['preferences']['common']['number_format'][0];
-					if (empty($dec_point)) $dec_point = '.';
+					if (empty($dec_point))
+					{
+						$dec_point = '.';
+					}
 					$record[$name] = floatval(str_replace($dec_point, '.', preg_replace('/[^\d'.preg_quote($dec_point).']/', '', $record[$name])));
 				}
 			}
 
 			// Some custom methods for conversion
-			foreach((array)$methods as $name => $method) {
-				if($record[$name]) $record[$name] = ExecMethod($method, $record[$name]);
+			foreach((array)$methods as $name => $method)
+			{
+				if($record[$name])
+				{
+					$record[$name] = ExecMethod($method, $record[$name]);
+				}
 			}
 
 			// cat_name2id will use currentapp to create new categories
 			$current_app = $GLOBALS['egw_info']['flags']['currentapp'];
-			if($appname) {
+			if($appname)
+			{
 				$GLOBALS['egw_info']['flags']['currentapp'] = $appname;
 			}
 			$categories = new Api\Categories('',$appname);
-			foreach((array)$fields['select-cat'] as $name) {
-				if($record[$name]) {
+			foreach((array)$fields['select-cat'] as $name)
+			{
+				if($record[$name])
+				{
 					// Only parse name if it needs it
 					if($format == 1)
 					{
@@ -493,7 +568,10 @@ 
 							$cat_id = importexport_helper_functions::cat_name2id($record[$name]);
 						}
 						// Don't clear it if it wasn't found
-						if($cat_id) $record[$name] = $cat_id;
+						if($cat_id)
+						{
+							$record[$name] = $cat_id;
+						}
 					}
 				}
 			}
@@ -514,7 +592,8 @@ 
 	 */
 	protected static function find_select_key($record_value, $selects)
 	{
-		if($record_value != null && is_array($selects)) {
+		if($record_value != null && is_array($selects))
+		{
 			if(is_array($record_value) || is_string($record_value) && strpos($record_value, ',') !== FALSE)
 			{
 				// Array, or CSV
@@ -526,7 +605,10 @@ 
 					if(!$sub_key)
 					{
 						$sub_key = static::find_select_key($subs[$sub_index].','.$subs[$sub_index+1], $selects);
-						if($sub_key) $sub_index++;
+						if($sub_key)
+						{
+							$sub_index++;
+						}
 					}
 					if($sub_key)
 					{
@@ -543,7 +625,10 @@ 
 			else
 			{
 				$key = array_search(strtolower($record_value), array_map('strtolower',array_map('lang',$selects)));
-				if($key !== false) $record_value = $key;
+				if($key !== false)
+				{
+					$record_value = $key;
+				}
 			}
 		}
 

importexport/inc/class.importexport_import_ui.inc.php

Doc Comments +1 added lines, -1 removed lines

@@ -295,7 +295,7 @@
 		 *
 		 * @param importexport_iface_import_plugin $plugin Instance of plugin to be used
 		 * @param resource $stream
-		 * @param importexport_definition $definition
+		 * @param importexport_definition $definition_obj
 		 * @return String HTML fragment illustrating how the data will be understood by Egw
 		 */
 		protected function preview(importexport_iface_import_plugin &$plugin, &$stream, importexport_definition &$definition_obj)

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -226,7 +226,7 @@
 		/**
 		* Get options for select boxes
 		*/
-		public static function get_select_options(Array $data) {
+		public static function get_select_options(array $data) {
 			$options = array(
 				'delimiter' => array(
 					''	=>	lang('From definition'),

Indentation +4 added lines, -4 removed lines

@@ -40,8 +40,8 @@ 
 		}
 
 		/**
-		*  Step user through importing their file
-		*/
+		 *  Step user through importing their file
+		 */
 		public function import_dialog($content = array()) {
 			$appname = $_GET['appname'] ? $_GET['appname'] : $content['appname'];
 			$definition = $_GET['definition'] ? $_GET['definition'] : $content['definition'];
@@ -223,8 +223,8 @@ 
 		}
 
 		/**
-		* Get options for select boxes
-		*/
+		 * Get options for select boxes
+		 */
 		public static function get_select_options(Array $data) {
 			$options = array(
 				'delimiter' => array(

Spacing +77 added lines, -77 removed lines

@@ -36,7 +36,7 @@ 
 		private $plugins;
 
 		public function __construct() {
-			$this->plugins = importexport_helper_functions::get_plugins('all','import');
+			$this->plugins = importexport_helper_functions::get_plugins('all', 'import');
 		}
 
 		/**
@@ -52,20 +52,20 @@ 
 			$template = new Etemplate('importexport.import_dialog');
 
 			// Load application's translations
-			if($appname)
+			if ($appname)
 			{
 				Api\Translation::add_app($appname);
 			}
-			if($content['import'] && $definition) {
+			if ($content['import'] && $definition) {
 				try {
 					$definition_obj = new importexport_definition($content['definition']);
-					if($content['dry-run']) {
+					if ($content['dry-run']) {
 						// Set this so plugin doesn't do any data changes
 						$definition_obj->plugin_options = (array)$definition_obj->plugin_options + array('dry_run' => true);
 					}
-					$options =& $definition_obj->plugin_options;
+					$options = & $definition_obj->plugin_options;
 					$options['no_notification'] = $content['no_notifications'];
-					if($content['delimiter']) {
+					if ($content['delimiter']) {
 						$options['fieldsep'] =
 							$content['delimiter'] == 'other' ? $content['other_delimiter'] : $content['delimiter'];
 					}
@@ -74,8 +74,8 @@ 
 					$plugin = new $definition_obj->plugin;
 
 					// Check file encoding matches import
-					$sample = file_get_contents($content['file']['tmp_name'],false, null, 0, 1024);
-					if($appname == 'addressbook' && $definition_obj->plugin == 'addressbook_import_vcard')
+					$sample = file_get_contents($content['file']['tmp_name'], false, null, 0, 1024);
+					if ($appname == 'addressbook' && $definition_obj->plugin == 'addressbook_import_vcard')
 					{
 						$preference = $GLOBALS['egw_info']['user']['preferences']['addressbook']['vcard_charset'];
 					}
@@ -85,7 +85,7 @@ 
 					}
 					$required = $options['charset'] == 'user' || !$options['charset'] ? $preference : $options['charset'];
 					$encoding = Api\Translation::detect_encoding($sample, $required);
-					if($encoding && strtoupper($required) != strtoupper($encoding))
+					if ($encoding && strtoupper($required) != strtoupper($encoding))
 					{
 						$this->message = lang("Encoding mismatch.  Expected %1 file, you uploaded %2.<br />\n",
 							$required,
@@ -100,37 +100,37 @@ 
 					$GLOBALS['egw_info']['flags']['currentapp'] = $appname;
 
 					// Destination if we need to hold the file
-					if($file)
+					if ($file)
 					{
 						$cachefile = new Api\Cache\Files(array());
 						$dst_file = $cachefile->filename(Api\Cache::keys(Api\Cache::INSTANCE, 'importexport',
-							'import_'.md5($content['file']['name'].$GLOBALS['egw_info']['user']['account_id']), true),true);
+							'import_'.md5($content['file']['name'].$GLOBALS['egw_info']['user']['account_id']), true), true);
 						// Keep file
-						if($dst_file)
+						if ($dst_file)
 						{
-							if($content['file']['name'] && copy($content['file']['tmp_name'],$dst_file)) {
+							if ($content['file']['name'] && copy($content['file']['tmp_name'], $dst_file)) {
 								$preserve['file']['tmp_name'] = $dst_file;
 							}
 						}
 
 						// Check on matching columns
 						$check_message = array();
-						if(!self::check_file($file, $definition_obj, $check_message, $dst_file))
+						if (!self::check_file($file, $definition_obj, $check_message, $dst_file))
 						{
 							// Set this so plugin doesn't do any data changes
 							$content['dry-run'] = true;
 							importexport_helper_functions::$dry_run = true;
-							$this->message .= '<b>' . lang('Import aborted').":</b><br />\n";
+							$this->message .= '<b>'.lang('Import aborted').":</b><br />\n";
 							$definition_obj->plugin_options = (array)$definition_obj->plugin_options + array('dry_run' => true);
 						}
-						if(count($check_message))
+						if (count($check_message))
 						{
-							$this->message .= implode($check_message, "<br />\n") . "<br />\n";
+							$this->message .= implode($check_message, "<br />\n")."<br />\n";
 						}
-						if($content['dry-run'])
+						if ($content['dry-run'])
 						{
 							$preview = $this->preview($plugin, $file, $definition_obj);
-							if(trim($this->message) == '')
+							if (trim($this->message) == '')
 							{
 								// Clear first, to prevent request from being collected if the result is the same
 								$template->setElementAttribute('preview', 'value', '');
@@ -149,34 +149,34 @@ 
 						$this->message .= lang('please select file to import'."<br />\n");
 					}
 
-					if($content['dry-run'])
+					if ($content['dry-run'])
 					{
-						$this->message .= '<b>' . lang('test only').":</b><br />\n";
+						$this->message .= '<b>'.lang('test only').":</b><br />\n";
 					}
 					$this->message .= lang('%1 records processed', $count);
 
 					// Refresh opening window
-					if(!$content['dry-run'])
+					if (!$content['dry-run'])
 					{
-						Framework::refresh_opener(lang('%1 records processed',$count), $appname, null,null,$appname);
+						Framework::refresh_opener(lang('%1 records processed', $count), $appname, null, null, $appname);
 					}
 					$total_processed = 0;
-					foreach($plugin->get_results() as $action => $a_count) {
-						$this->message .= "<br />\n" . lang($action) . ": $a_count";
+					foreach ($plugin->get_results() as $action => $a_count) {
+						$this->message .= "<br />\n".lang($action).": $a_count";
 						$total_processed += $a_count;
 					}
-					if(count($plugin->get_warnings())) {
+					if (count($plugin->get_warnings())) {
 						$this->message .= "<br />\n".lang('Warnings').':';
-						foreach($plugin->get_warnings() as $record => $message) {
+						foreach ($plugin->get_warnings() as $record => $message) {
 							$this->message .= "\n$record: $message";
 						}
 					}
-					if(count($plugin->get_errors())) {
+					if (count($plugin->get_errors())) {
 						$this->message .= "<br />\n".lang('Problems during import:');
-						foreach($plugin->get_errors() as $record => $message) {
+						foreach ($plugin->get_errors() as $record => $message) {
 							$this->message .= "<br />\n$record: $message";
 						}
-						if($count != $total_processed) $this->message .= "<br />\n".lang('Some records may not have been imported');
+						if ($count != $total_processed) $this->message .= "<br />\n".lang('Some records may not have been imported');
 					}
 					if ($dst_file && $content['file']['tmp_name'] == $dst_file) {
 						// Remove file
@@ -189,7 +189,7 @@ 
 					$this->message .= $e->getMessage();
 				}
 			}
-			elseif($content['cancel'])
+			elseif ($content['cancel'])
 			{
 				egw_framework::set_onload('window.close();');
 			}
@@ -202,7 +202,7 @@ 
 				);
 			}
 
-			if(!array_key_exists('dry-run',$content))
+			if (!array_key_exists('dry-run', $content))
 			{
 				$data['dry-run'] = true;
 			}
@@ -210,14 +210,14 @@ 
 			$data['appname'] = $preserve['appname'] = $appname ? $appname : ($definition_obj ? $definition_obj->application : '');
 			$data['definition'] = $definition;
 			$data['delimiter'] = $definition_obj->plugin_options['delimiter'];
-			$data['no_notifications'] = true;	// switch notifications off by default
+			$data['no_notifications'] = true; // switch notifications off by default
 
 			$sel_options = self::get_select_options($data);
 
 			$data['message'] = $this->message;
-			Framework::includeJS('.','importexport','importexport');
+			Framework::includeJS('.', 'importexport', 'importexport');
 
-			if($_GET['appname']) $readonlys['appname'] = true;
+			if ($_GET['appname']) $readonlys['appname'] = true;
 
 			$template->exec('importexport.importexport_import_ui.import_dialog', $data, $sel_options, $readonlys, $preserve, 2);
 		}
@@ -239,12 +239,12 @@ 
 			);
 
 			(array)$apps = importexport_helper_functions::get_apps('import');
-			$options['appname'] = array('' => lang('Select one')) + array_combine($apps,$apps);
+			$options['appname'] = array('' => lang('Select one')) + array_combine($apps, $apps);
 
-			if($data['appname']) {
+			if ($data['appname']) {
 				$options['definition'] = array();
 
-				if($data['file'] && !is_array($data['file'])) {
+				if ($data['file'] && !is_array($data['file'])) {
 					$extension = substr($data['file'], -3);
 				}
 				$definitions = new importexport_definitions_bo(array(
@@ -282,28 +282,28 @@ 
 		 * @param importexport_definition $definition
 		 * @return String HTML fragment illustrating how the data will be understood by Egw
 		 */
-		protected function preview(importexport_iface_import_plugin &$plugin, &$stream, importexport_definition &$definition_obj)
+		protected function preview(importexport_iface_import_plugin&$plugin, &$stream, importexport_definition&$definition_obj)
 		{
-			if(method_exists($plugin, 'preview'))
+			if (method_exists($plugin, 'preview'))
 			{
 				$preview = $plugin->preview($stream, $definition_obj);
 			}
-			elseif($definition_obj->plugin_options['csv_fields'])
+			elseif ($definition_obj->plugin_options['csv_fields'])
 			{
-				$import_csv = new importexport_import_csv( $stream, array(
+				$import_csv = new importexport_import_csv($stream, array(
 					'fieldsep' => $definition_obj->plugin_options['fieldsep'],
 					'charset' => $definition_obj->plugin_options['charset'],
 				));
 				// set FieldMapping.
 				$import_csv->mapping = $definition_obj->plugin_options['field_mapping'];
 
-				$rows = array('h1'=>array(),'f1'=>array(),'.h1'=>'class=th');
-				for($row = 0; $row < $GLOBALS['egw_info']['user']['preferences']['common']['maxmatchs']; $row++)
+				$rows = array('h1'=>array(), 'f1'=>array(), '.h1'=>'class=th');
+				for ($row = 0; $row < $GLOBALS['egw_info']['user']['preferences']['common']['maxmatchs']; $row++)
 				{
 					$row_data = $import_csv->get_record();
-					if($row_data === false) break;
+					if ($row_data === false) break;
 					$rows[$import_csv->get_current_position() <= $definition_obj->plugin_options['num_header_lines'] ? 'h1' : $row] = $row_data;
-					if($import_csv->get_current_position() <= $definition_obj->plugin_options['num_header_lines']) $row--;
+					if ($import_csv->get_current_position() <= $definition_obj->plugin_options['num_header_lines']) $row--;
 				}
 				$preview = Api\Html::table($rows);
 				rewind($stream);
@@ -312,22 +312,22 @@ 
 			{
 				$preview = lang('Preview not supported by %1', $plugin->get_name());
 			}
-			if(count($plugin->get_warnings())) {
+			if (count($plugin->get_warnings())) {
 				$this->message .= "<br />\n".lang('Warnings').':';
-				foreach($plugin->get_warnings() as $record => $message) {
+				foreach ($plugin->get_warnings() as $record => $message) {
 					$this->message .= "\n$record: $message";
 				}
 				$this->message .= "<br />\n";
 			};
-			if(count($plugin->get_errors())) {
+			if (count($plugin->get_errors())) {
 				$this->message .= "<br />\n".lang('Problems during import:');
-				foreach($plugin->get_errors() as $record => $message) {
+				foreach ($plugin->get_errors() as $record => $message) {
 					$this->message .= "<br />\n$record: $message";
 				}
-				if($count != $total_processed) $this->message .= "<br />\n".lang('Some records may not have been imported');
+				if ($count != $total_processed) $this->message .= "<br />\n".lang('Some records may not have been imported');
 				$this->message .= "<br />\n";
 			}
-			return '<div class="header">' . lang('Preview') . ' - ' . $plugin->get_name() . '</div>' . $preview;
+			return '<div class="header">'.lang('Preview').' - '.$plugin->get_name().'</div>'.$preview;
 		}
 
 		/**
@@ -345,24 +345,24 @@ 
 		 */
 		public static function check_file(&$file, &$definition, &$message = array(), $dst_file = false)
 		{
-			$options =& $definition->plugin_options;
+			$options = & $definition->plugin_options;
 			$message_count = count($message);
 
 			// Only CSV files
-			if(!$options['csv_fields']) return true;
+			if (!$options['csv_fields']) return true;
 
 			// Can't check if definition has no header
-			if($options['num_header_lines'] == 0) return true;
+			if ($options['num_header_lines'] == 0) return true;
 
 			$preference = $GLOBALS['egw_info']['user']['preferences']['common']['csv_charset'];
 			$charset = $options['charset'] == 'user' || !$options['charset'] ? $preference : $options['charset'];
 
 			$data = fgetcsv($file, 8000, $options['fieldsep']);
 			rewind($file);
-			$data = Api\Translation::convert($data,$charset);
+			$data = Api\Translation::convert($data, $charset);
 
 			$ok = true;
-			if(count($data) != count($options['csv_fields']) && max(array_keys($data)) != max(array_keys($options['csv_fields'])))
+			if (count($data) != count($options['csv_fields']) && max(array_keys($data)) != max(array_keys($options['csv_fields'])))
 			{
 				$message[] = lang("Column mismatch.  Expected %1 columns, your file has %2.",
 					count($options['field_mapping']),
@@ -370,9 +370,9 @@ 
 				);
 				$ok = false;
 			}
-			foreach($data as $index => $header)
+			foreach ($data as $index => $header)
 			{
-				if($index < count($options['csv_fields']) && !$options['field_mapping'][$index])
+				if ($index < count($options['csv_fields']) && !$options['field_mapping'][$index])
 				{
 					// Skipped column in definition
 					continue;
@@ -384,16 +384,16 @@ 
 				}
 
 				// Check for matching headers
-				if($options['csv_fields'][$index] == $header)
+				if ($options['csv_fields'][$index] == $header)
 				{
 					// Simple match
 					continue;
 				}
 				// Check column headers, taking into account different translations - make sure no *
-				$lang_defn = mb_strtoupper(Api\Translation::translate($options['csv_fields'][$index],false,''));
-				$lang_file = mb_strtoupper(Api\Translation::translate($header,false,''));
+				$lang_defn = mb_strtoupper(Api\Translation::translate($options['csv_fields'][$index], false, ''));
+				$lang_file = mb_strtoupper(Api\Translation::translate($header, false, ''));
 
-				if($lang_defn == $lang_file ||
+				if ($lang_defn == $lang_file ||
 					$lang_defn == mb_strtoupper($header) ||
 					$lang_file == mb_strtoupper($options['csv_fields'][$index])
 				)
@@ -405,7 +405,7 @@ 
 				$file_message_id = Api\Translation::get_message_id($header, $definition->application);
 				$defn_message_id = Api\Translation::get_message_id($options['csv_fields'][$index], $definition->application);
 
-				if($file_message_id && $defn_message_id && $file_message_id == $defn_message_id)
+				if ($file_message_id && $defn_message_id && $file_message_id == $defn_message_id)
 				{
 					continue;
 				}
@@ -413,19 +413,19 @@ 
 
 				// Problem
 				$message[] = lang("Column mismatch: %1 should be %2, not %3",
-					$index,$options['csv_fields'][$index], $header);
+					$index, $options['csv_fields'][$index], $header);
 				// But can still continue
 				// $ok = false;
 			}
-			if(!$ok || count($message) != $message_count)
+			if (!$ok || count($message) != $message_count)
 			{
 				// Add links for new / edit definition
 				$config = Api\Config::read('importexport');
-				if($GLOBALS['egw_info']['user']['apps']['admin'] || $config['users_create_definitions'])
+				if ($GLOBALS['egw_info']['user']['apps']['admin'] || $config['users_create_definitions'])
 				{
 					$actions = '';
 					// New definition
-					$add_link = Egw::link('/index.php',array(
+					$add_link = Egw::link('/index.php', array(
 						'menuaction' => 'importexport.importexport_definitions_ui.edit',
 						'application' => $definition->application,
 						'plugin' => $definition->plugin,
@@ -437,13 +437,13 @@ 
 							'menuaction' => 'importexport.importexport_import_ui.import_dialog',
 							// Don't set appname, or user won't be able to select & see their new definition
 							//'appname' => $definition->application,
-						)) . "';
+						))."';
 						egw_openWindowCentered2('$add_link','_blank',500,500,'yes');
 					";
 					$actions[] = lang('Create a <a href="%1">new definition</a> for this file', $add_link);
 
 					// Edit selected definition, if allowed
-					if($definition->owner == $GLOBALS['egw_info']['user']['account_id'] ||
+					if ($definition->owner == $GLOBALS['egw_info']['user']['account_id'] ||
 						!$definition->owner && $GLOBALS['egw_info']['user']['apps']['admin'])
 					{
 						$edit_link = array(
@@ -452,20 +452,20 @@ 
 							// Jump to file step
 							'step' => 'wizard_step21'
 						);
-						if($dst_file)
+						if ($dst_file)
 						{
 							// Still have uploaded file, jump there
-							Api\Cache::setSession($definition->application,'csvfile',$dst_file);
+							Api\Cache::setSession($definition->application, 'csvfile', $dst_file);
 							$edit_link['step'] = 'wizard_step30';
 						}
-						$edit_link = Egw::link('/index.php',$edit_link);
+						$edit_link = Egw::link('/index.php', $edit_link);
 						$edit_link = "javascript:egw_openWindowCentered2('$edit_link','_blank',500,500,'yes')";
 						$actions[] = lang('Edit definition <a href="%1">%2</a> to match your file',
-							$edit_link, $definition->name );
+							$edit_link, $definition->name);
 					}
-					$actions[] = lang('Edit your file to match the definition:') . ' '
-					. implode(array_map('lang',array_intersect_key($options['csv_fields'],$options['field_mapping'])),', ');
-					$message[] = "\n<li>".implode($actions,"\n<li>");
+					$actions[] = lang('Edit your file to match the definition:').' '
+					. implode(array_map('lang', array_intersect_key($options['csv_fields'], $options['field_mapping'])), ', ');
+					$message[] = "\n<li>".implode($actions, "\n<li>");
 				}
 			}
 			return $ok;

Braces +77 added lines, -33 removed lines

@@ -20,7 +20,8 @@ 
  *
 */
 
-	class importexport_import_ui {
+	class importexport_import_ui
+	{
 
 		const _appname = 'importexport';
 
@@ -35,14 +36,16 @@ 
 		 */
 		private $plugins;
 
-		public function __construct() {
+		public function __construct()
+		{
 			$this->plugins = importexport_helper_functions::get_plugins('all','import');
 		}
 
 		/**
 		*  Step user through importing their file
 		*/
-		public function import_dialog($content = array()) {
+		public function import_dialog($content = array())
+		{
 			$appname = $_GET['appname'] ? $_GET['appname'] : $content['appname'];
 			$definition = $_GET['definition'] ? $_GET['definition'] : $content['definition'];
 
@@ -56,16 +59,19 @@ 
 			{
 				Api\Translation::add_app($appname);
 			}
-			if($content['import'] && $definition) {
+			if($content['import'] && $definition)
+			{
 				try {
 					$definition_obj = new importexport_definition($content['definition']);
-					if($content['dry-run']) {
+					if($content['dry-run'])
+					{
 						// Set this so plugin doesn't do any data changes
 						$definition_obj->plugin_options = (array)$definition_obj->plugin_options + array('dry_run' => true);
 					}
 					$options =& $definition_obj->plugin_options;
 					$options['no_notification'] = $content['no_notifications'];
-					if($content['delimiter']) {
+					if($content['delimiter'])
+					{
 						$options['fieldsep'] =
 							$content['delimiter'] == 'other' ? $content['other_delimiter'] : $content['delimiter'];
 					}
@@ -108,7 +114,8 @@ 
 						// Keep file
 						if($dst_file)
 						{
-							if($content['file']['name'] && copy($content['file']['tmp_name'],$dst_file)) {
+							if($content['file']['name'] && copy($content['file']['tmp_name'],$dst_file))
+							{
 								$preserve['file']['tmp_name'] = $dst_file;
 							}
 						}
@@ -161,33 +168,44 @@ 
 						Framework::refresh_opener(lang('%1 records processed',$count), $appname, null,null,$appname);
 					}
 					$total_processed = 0;
-					foreach($plugin->get_results() as $action => $a_count) {
+					foreach($plugin->get_results() as $action => $a_count)
+					{
 						$this->message .= "<br />\n" . lang($action) . ": $a_count";
 						$total_processed += $a_count;
 					}
-					if(count($plugin->get_warnings())) {
+					if(count($plugin->get_warnings()))
+					{
 						$this->message .= "<br />\n".lang('Warnings').':';
-						foreach($plugin->get_warnings() as $record => $message) {
+						foreach($plugin->get_warnings() as $record => $message)
+						{
 							$this->message .= "\n$record: $message";
 						}
 					}
-					if(count($plugin->get_errors())) {
+					if(count($plugin->get_errors()))
+					{
 						$this->message .= "<br />\n".lang('Problems during import:');
-						foreach($plugin->get_errors() as $record => $message) {
+						foreach($plugin->get_errors() as $record => $message)
+						{
 							$this->message .= "<br />\n$record: $message";
 						}
-						if($count != $total_processed) $this->message .= "<br />\n".lang('Some records may not have been imported');
+						if($count != $total_processed)
+						{
+							$this->message .= "<br />\n".lang('Some records may not have been imported');
+						}
 					}
-					if ($dst_file && $content['file']['tmp_name'] == $dst_file) {
+					if ($dst_file && $content['file']['tmp_name'] == $dst_file)
+					{
 						// Remove file
 						$cachefile->delete(Api\Cache::keys(Api\Cache::INSTANCE, 'importexport',
 							'import_'.md5($content['file']['name'].$GLOBALS['egw_info']['user']['account_id'])));
 						unset($dst_file);
 					}
 
-				} catch (Api\Db\Exception $db_ex) {
+				}
+				catch (Api\Db\Exception $db_ex) {
 					$this->message .= lang('Database error');
-				} catch (Exception $e) {
+				}
+				catch (Exception $e) {
 					$this->message .= $e->getMessage();
 				}
 			}
@@ -219,7 +237,10 @@ 
 			$data['message'] = $this->message;
 			Framework::includeJS('.','importexport','importexport');
 
-			if($_GET['appname']) $readonlys['appname'] = true;
+			if($_GET['appname'])
+			{
+				$readonlys['appname'] = true;
+			}
 
 			$template->exec('importexport.importexport_import_ui.import_dialog', $data, $sel_options, $readonlys, $preserve, 2);
 		}
@@ -227,7 +248,8 @@ 
 		/**
 		* Get options for select boxes
 		*/
-		public static function get_select_options(Array $data) {
+		public static function get_select_options(Array $data)
+		{
 			$options = array(
 				'delimiter' => array(
 					''	=>	lang('From definition'),
@@ -243,17 +265,20 @@ 
 			(array)$apps = importexport_helper_functions::get_apps('import');
 			$options['appname'] = array('' => lang('Select one')) + array_combine($apps,$apps);
 
-			if($data['appname']) {
+			if($data['appname'])
+			{
 				$options['definition'] = array();
 
-				if($data['file'] && !is_array($data['file'])) {
+				if($data['file'] && !is_array($data['file']))
+				{
 					$extension = substr($data['file'], -3);
 				}
 				$definitions = new importexport_definitions_bo(array(
 					'type' => 'import',
 					'application' => $data['appname']
 				));
-				foreach ((array)$definitions->get_definitions() as $identifier) {
+				foreach ((array)$definitions->get_definitions() as $identifier)
+				{
 					try
 					{
 						$definition = new importexport_definition($identifier);
@@ -263,7 +288,8 @@ 
 						// Permission error
 						continue;
 					}
-					if ($title = $definition->get_title()) {
+					if ($title = $definition->get_title())
+					{
 						$options['definition'][$title] = $title;
 					}
 					unset($definition);
@@ -303,9 +329,15 @@ 
 				for($row = 0; $row < $GLOBALS['egw_info']['user']['preferences']['common']['maxmatchs']; $row++)
 				{
 					$row_data = $import_csv->get_record();
-					if($row_data === false) break;
+					if($row_data === false)
+					{
+						break;
+					}
 					$rows[$import_csv->get_current_position() <= $definition_obj->plugin_options['num_header_lines'] ? 'h1' : $row] = $row_data;
-					if($import_csv->get_current_position() <= $definition_obj->plugin_options['num_header_lines']) $row--;
+					if($import_csv->get_current_position() <= $definition_obj->plugin_options['num_header_lines'])
+					{
+						$row--;
+					}
 				}
 				$preview = Api\Html::table($rows);
 				rewind($stream);
@@ -314,19 +346,26 @@ 
 			{
 				$preview = lang('Preview not supported by %1', $plugin->get_name());
 			}
-			if(count($plugin->get_warnings())) {
+			if(count($plugin->get_warnings()))
+			{
 				$this->message .= "<br />\n".lang('Warnings').':';
-				foreach($plugin->get_warnings() as $record => $message) {
+				foreach($plugin->get_warnings() as $record => $message)
+				{
 					$this->message .= "\n$record: $message";
 				}
 				$this->message .= "<br />\n";
 			};
-			if(count($plugin->get_errors())) {
+			if(count($plugin->get_errors()))
+			{
 				$this->message .= "<br />\n".lang('Problems during import:');
-				foreach($plugin->get_errors() as $record => $message) {
+				foreach($plugin->get_errors() as $record => $message)
+				{
 					$this->message .= "<br />\n$record: $message";
 				}
-				if($count != $total_processed) $this->message .= "<br />\n".lang('Some records may not have been imported');
+				if($count != $total_processed)
+				{
+					$this->message .= "<br />\n".lang('Some records may not have been imported');
+				}
 				$this->message .= "<br />\n";
 			}
 			return '<div class="header">' . lang('Preview') . ' - ' . $plugin->get_name() . '</div>' . $preview;
@@ -351,10 +390,16 @@ 
 			$message_count = count($message);
 
 			// Only CSV files
-			if(!$options['csv_fields']) return true;
+			if(!$options['csv_fields'])
+			{
+				return true;
+			}
 
 			// Can't check if definition has no header
-			if($options['num_header_lines'] == 0) return true;
+			if($options['num_header_lines'] == 0)
+			{
+				return true;
+			}
 
 			$preference = $GLOBALS['egw_info']['user']['preferences']['common']['csv_charset'];
 			$charset = $options['charset'] == 'user' || !$options['charset'] ? $preference : $options['charset'];
@@ -398,8 +443,7 @@ 
 				if($lang_defn == $lang_file ||
 					$lang_defn == mb_strtoupper($header) ||
 					$lang_file == mb_strtoupper($options['csv_fields'][$index])
-				)
-				{
+				) {
 					continue;
 				}
 

infolog/inc/class.infolog_bo.inc.php

Doc Comments +2 added lines, -5 removed lines

@@ -1226,7 +1226,7 @@ 
 	 * Is called as hook to participate in the linking
 	 *
 	 * @param int|array $info int info_id or array with infolog entry
-	 * @return string|boolean string with the title, null if $info not found, false if no perms to view
+	 * @return string string with the title, null if $info not found, false if no perms to view
 	 */
 	function link_title($info)
 	{
@@ -1324,9 +1324,6 @@ 
 	/**
 	 * hook called be calendar to include events or todos in the cal-dayview
 	 *
-	 * @param int $args[year], $args[month], $args[day] date of the events
-	 * @param int $args[owner] owner of the events
-	 * @param string $args[location] calendar_include_{events|todos}
 	 * @return array of events (array with keys starttime, endtime, title, view, icon, content)
 	 */
 	function cal_to_include($args)
@@ -1515,7 +1512,7 @@ 
 	 * Get names for categories specified by their id's
 	 *
 	 * @param array|string $cat_id_list array or comma-sparated list of id's
-	 * @return array with names
+	 * @return string|boolean with names
 	 */
 	function get_categories($cat_id_list)
 	{

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -1272,7 +1272,7 @@
 	 * @param array $options Array of options for the search
 	 * @return array with info_id - title pairs of the matching entries
 	 */
-	function link_query($pattern, Array &$options = array())
+	function link_query($pattern, array &$options = array())
 	{
 		$query = array(
 			'search' => $pattern,

Indentation +16 added lines, -16 removed lines

@@ -701,21 +701,21 @@ 
 	}
 
 	/**
-	* writes the given $values to InfoLog, a new entry gets created if info_id is not set or 0
-	*
-	* checks and asures ACL
-	*
-	* @param array &$values values to write
-	* @param boolean $check_defaults = true check and set certain defaults
-	* @param boolean|int $touch_modified = true touch the modification date and sets the modifier's user-id, 2: only modifier
-	* @param boolean $user2server = true conversion between user- and server-time necessary
-	* @param boolean $skip_notification = false true = do NOT send notification, false (default) = send notifications
-	* @param boolean $throw_exception = false Throw an exception (if required fields are not set)
-	* @param string $purge_cfs = null null=dont, 'ical'=only iCal X-properties (cfs name starting with "#"), 'all'=all cfs
-	* @param boolean $ignore_acl =true
-	*
-	* @return int|boolean info_id on a successfull write or false
-	*/
+	 * writes the given $values to InfoLog, a new entry gets created if info_id is not set or 0
+	 *
+	 * checks and asures ACL
+	 *
+	 * @param array &$values values to write
+	 * @param boolean $check_defaults = true check and set certain defaults
+	 * @param boolean|int $touch_modified = true touch the modification date and sets the modifier's user-id, 2: only modifier
+	 * @param boolean $user2server = true conversion between user- and server-time necessary
+	 * @param boolean $skip_notification = false true = do NOT send notification, false (default) = send notifications
+	 * @param boolean $throw_exception = false Throw an exception (if required fields are not set)
+	 * @param string $purge_cfs = null null=dont, 'ical'=only iCal X-properties (cfs name starting with "#"), 'all'=all cfs
+	 * @param boolean $ignore_acl =true
+	 *
+	 * @return int|boolean info_id on a successfull write or false
+	 */
 	function write(&$values_in, $check_defaults=true, $touch_modified=true, $user2server=true,
 		$skip_notification=false, $throw_exception=false, $purge_cfs=null, $ignore_acl=false)
 	{
@@ -752,7 +752,7 @@ 
 			}
 		}
 		if (!$ignore_acl && ($values['info_id'] && !$this->check_access($values['info_id'],Acl::EDIT) && !$status_only ||
-		    !$values['info_id'] && $values['info_id_parent'] && !$this->check_access($values['info_id_parent'],Acl::ADD)))
+			!$values['info_id'] && $values['info_id_parent'] && !$this->check_access($values['info_id_parent'],Acl::ADD)))
 		{
 			return false;
 		}

Braces +203 added lines, -56 removed lines

@@ -232,7 +232,10 @@ 
 				$this->enums['type'] += $config_data['types'];
 				//echo "types:<pre>"; print_r($this->enums['type']); echo "</pre>\n";
 			}
-			if ($config_data['group_owners']) $this->group_owners = $config_data['group_owners'];
+			if ($config_data['group_owners'])
+			{
+				$this->group_owners = $config_data['group_owners'];
+			}
 
 			$this->customfields = Api\Storage\Customfields::get('infolog');
 			if ($this->customfields)
@@ -242,17 +245,35 @@ 
 					// old infolog customefield record
 					if(empty($field['type']))
 					{
-						if (count($field['values'])) $field['type'] = 'select'; // selectbox
-						elseif ($field['rows'] > 1) $field['type'] = 'textarea'; // textarea
-						elseif (intval($field['len']) > 0) $field['type'] = 'text'; // regular input field
-						else $field['type'] = 'label'; // header-row
+						if (count($field['values']))
+						{
+							$field['type'] = 'select';
+						}
+						// selectbox
+						elseif ($field['rows'] > 1)
+						{
+							$field['type'] = 'textarea';
+						}
+						// textarea
+						elseif (intval($field['len']) > 0)
+						{
+							$field['type'] = 'text';
+						}
+						// regular input field
+						else {
+							$field['type'] = 'label';
+						}
+						// header-row
 						$field['type2'] = $field['typ'];
 						unset($field['typ']);
 						$this->customfields[$name] = $field;
 						$save_config = true;
 					}
 				}
-				if ($save_config) Api\Config::save_value('customfields',$this->customfields,'infolog');
+				if ($save_config)
+				{
+					Api\Config::save_value('customfields',$this->customfields,'infolog');
+				}
 			}
 			if (is_array($config_data['responsible_edit']))
 			{
@@ -279,7 +300,10 @@ 
 		// sort types by there translation
 		foreach($this->enums['type'] as $key => $val)
 		{
-			if (($val = lang($key)) != $key.'*') $this->enums['type'][$key] = lang($key);
+			if (($val = lang($key)) != $key.'*')
+			{
+				$this->enums['type'][$key] = lang($key);
+			}
 		}
 		natcasesort($this->enums['type']);
 
@@ -334,11 +358,18 @@ 
 
 		$info_id = is_array($info) ? $info['info_id'] : $info;
 
-		if (!$user) $user = $this->user;
+		if (!$user)
+		{
+			$user = $this->user;
+		}
 		if ($user == $this->user)
 		{
 			$grants = $this->grants;
-			if ($info_id) $access =& $cache[$info_id][$required_rights];	// we only cache the current user!
+			if ($info_id)
+			{
+				$access =& $cache[$info_id][$required_rights];
+			}
+			// we only cache the current user!
 		}
 		else
 		{
@@ -357,16 +388,22 @@ 
 			// handle delete for the various history modes
 			if ($this->history)
 			{
-				if (!is_array($info) && !($info = $this->so->read(array('info_id' => $info_id)))) return false;
+				if (!is_array($info) && !($info = $this->so->read(array('info_id' => $info_id))))
+				{
+					return false;
+				}
 
 				if ($info['info_status'] == 'deleted' &&
 					($required_rights == Acl::EDIT ||		// no edit rights for deleted entries
 					 $required_rights == Acl::ADD  ||		// no add rights for deleted entries
 					 $required_rights == Acl::DELETE && ($this->history == 'history_no_delete' || // no delete at all!
-					 $this->history == 'history_admin_delete' && (!isset($GLOBALS['egw_info']['user']['apps']['admin']) || $user!=$this->user))))	// delete only for admins
+					 $this->history == 'history_admin_delete' && (!isset($GLOBALS['egw_info']['user']['apps']['admin']) || $user!=$this->user))))
+				{
+					// delete only for admins
 				{
 					$access = false;
 				}
+				}
 				elseif ($required_rights == self::ACL_UNDELETE)
 				{
 					if ($info['info_status'] != 'deleted')
@@ -427,11 +464,14 @@ 
 
 		if ($info['info_link_id'] > 0 &&
 			(isset($info['links']) && ($link = $info['links'][$info['info_link_id']]) ||	// use supplied links info
-			 ($link = Link::get_link($info['info_link_id'])) !== False))	// if link not found in supplied links, we always search!
+			 ($link = Link::get_link($info['info_link_id'])) !== False))
+		{
+			// if link not found in supplied links, we always search!
 		{
 			if (isset($info['links']) && isset($link['app']))
 			{
 				$app = $link['app'];
+		}
 				$id  = $link['id'];
 			}
 			else
@@ -442,10 +482,13 @@ 
 			}
 			$title = Link::title($app,$id);
 
-			if ((string)$info['info_custom_from'] === '')	// old entry
+			if ((string)$info['info_custom_from'] === '')
+			{
+				// old entry
 			{
 				$info['info_custom_from'] = (int) ($title != $info['info_from'] && @htmlentities($title) != $info['info_from']);
 			}
+			}
 			if (!$info['info_custom_from'])
 			{
 				$info['info_from'] = '';
@@ -495,12 +538,15 @@ 
 	 function time2time(&$values, $fromTZId=false, $toTZId=null)
 	 {
 
-		if ($fromTZId === $toTZId) return;
+		if ($fromTZId === $toTZId)
+		{
+			return;
+		}
 
 		$tz = Api\DateTime::$server_timezone;
 
 	 	if ($fromTZId)
-		{
+	 	{
 			if (!isset(self::$tz_cache[$fromTZId]))
 			{
 				self::$tz_cache[$fromTZId] = calendar_timezones::DateTimeZone($fromTZId);
@@ -534,7 +580,7 @@ 
 		}
 		//error_log(__METHOD__.'(values[info_enddate]='.date('Y-m-d H:i:s',$values['info_enddate']).", from=".array2string($fromTZId).", to=".array2string($toTZId).") tz=".$tz->getName().', fromTZ='.$fromTZ->getName().', toTZ='.$toTZ->getName().', userTZ='.Api\DateTime::$user_timezone->getName());
 	 	foreach($this->timestamps as $key)
-		{
+	 	{
 		 	if ($values[$key])
 		 	{
 			 	$time = new Api\DateTime($values[$key], $tz);
@@ -564,7 +610,10 @@ 
 	 */
 	function date2usertime($ts,$date_format='ts')
 	{
-		if (empty($ts) || $date_format == 'server') return $ts;
+		if (empty($ts) || $date_format == 'server')
+		{
+			return $ts;
+		}
 
 		return Api\DateTime::server2user($ts,$date_format);
 	}
@@ -601,16 +650,22 @@ 
 			return null;
 		}
 
-		if (!$ignore_acl && !$this->check_access($data,Acl::READ))	// check behind read, to prevent a double read
+		if (!$ignore_acl && !$this->check_access($data,Acl::READ))
+		{
+			// check behind read, to prevent a double read
 		{
 			return False;
 		}
+		}
 
 		if ($data['info_subject'] == $this->subject_from_des($data['info_des']))
 		{
 			$data['info_subject'] = '';
 		}
-		if ($run_link_id2from) $this->link_id2from($data);
+		if ($run_link_id2from)
+		{
+			$this->link_id2from($data);
+		}
 
 		// convert server- to user-time
 		if ($date_format == 'ts')
@@ -673,7 +728,11 @@ 
 		// if we have history switched on and not an already deleted item --> set only status deleted
 		if ($this->history && $info['info_status'] != 'deleted')
 		{
-			if ($info['info_status'] == 'deleted') return false;	// entry already deleted
+			if ($info['info_status'] == 'deleted')
+			{
+				return false;
+			}
+			// entry already deleted
 
 			$this->so->write($deleted);
 
@@ -685,7 +744,9 @@ 
 
 			Link::unlink(0,'infolog',$info_id);
 		}
-		if ($info['info_status'] != 'deleted')	// dont notify of final purge of already deleted items
+		if ($info['info_status'] != 'deleted')
+		{
+			// dont notify of final purge of already deleted items
 		{
 			// send email notifications and do the history logging
 			if(!$skip_notification)
@@ -693,6 +754,7 @@ 
 				if (!is_object($this->tracking))
 				{
 					$this->tracking = new infolog_tracking($this);
+		}
 				}
 				$this->tracking->track($deleted,$info,$this->user,true);
 			}
@@ -742,10 +804,13 @@ 
 			{
 				$responsible = $values['info_responsible'];
 			}
-			if (!($status_only = in_array($this->user, (array)$responsible)))	// responsible has implicit right to change status
+			if (!($status_only = in_array($this->user, (array)$responsible)))
+			{
+				// responsible has implicit right to change status
 			{
 				$status_only = !!array_intersect((array)$responsible,array_keys($GLOBALS['egw']->accounts->memberships($this->user)));
 			}
+			}
 			if (!$status_only && $values['info_status'] != 'deleted')
 			{
 				$status_only = $undelete = $this->check_access($values['info_id'],self::ACL_UNDELETE);
@@ -766,17 +831,23 @@ 
 				$values['info_status'] = $this->status['defaults'][$values['info_type']];
 			}
 		}
-		if ($status_only && !$undelete)	// make sure only status gets writen
+		if ($status_only && !$undelete)
+		{
+			// make sure only status gets writen
 		{
 			$set_completed = !$values['info_datecompleted'] &&	// set date completed of finished job, only if its not already set
 				in_array($values['info_status'],array('done','billed','cancelled'));
+		}
 
 			$values = $old;
 			// only overwrite explicitly allowed fields
 			$values['info_datemodified'] = $values_in['info_datemodified'];
 			foreach ($this->responsible_edit as $name)
 			{
-				if (isset($values_in[$name])) $values[$name] = $values_in[$name];
+				if (isset($values_in[$name]))
+				{
+					$values[$name] = $values_in[$name];
+				}
 			}
 			if ($set_completed)
 			{
@@ -784,21 +855,30 @@ 
 				$values['info_percent'] = 100;
 				$forcestatus = true;
 				$status = 'done';
-				if (isset($values['info_type']) && !in_array($values['info_status'],array('done','billed','cancelled'))) {
+				if (isset($values['info_type']) && !in_array($values['info_status'],array('done','billed','cancelled')))
+				{
 					$forcestatus = false;
 					//echo "set_completed:"; _debug_array($this->status[$values['info_type']]);
-					if (isset($this->status[$values['info_type']]['done'])) {
+					if (isset($this->status[$values['info_type']]['done']))
+					{
 						$forcestatus = true;
 						$status = 'done';
-					} elseif (isset($this->status[$values['info_type']]['billed'])) {
+					}
+					elseif (isset($this->status[$values['info_type']]['billed']))
+					{
 						$forcestatus = true;
 						$status = 'billed';
-					} elseif (isset($this->status[$values['info_type']]['cancelled'])) {
+					}
+					elseif (isset($this->status[$values['info_type']]['cancelled']))
+					{
 						$forcestatus = true;
 						$status = 'cancelled';
 					}
 				}
-				if ($forcestatus && !in_array($values['info_status'],array('done','billed','cancelled'))) $values['info_status'] = $status;
+				if ($forcestatus && !in_array($values['info_status'],array('done','billed','cancelled')))
+				{
+					$values['info_status'] = $status;
+				}
 			}
 			$check_defaults = false;
 		}
@@ -830,14 +910,22 @@ 
 				//echo "check_defaults:"; _debug_array($this->status[$values['info_type']]);
 				//$values['info_status'] = 'done';
 				$status = 'done';
-				if (isset($values['info_type'])) {
-					if (isset($this->status[$values['info_type']]['done'])) {
+				if (isset($values['info_type']))
+				{
+					if (isset($this->status[$values['info_type']]['done']))
+					{
 						$status = 'done';
-					} elseif (isset($this->status[$values['info_type']]['billed'])) {
+					}
+					elseif (isset($this->status[$values['info_type']]['billed']))
+					{
 						$status = 'billed';
-					} elseif (isset($this->status[$values['info_type']]['cancelled'])) {
+					}
+					elseif (isset($this->status[$values['info_type']]['cancelled']))
+					{
 						$status = 'cancelled';
-					} else {
+					}
+					else
+					{
 						// since the comlete stati above do not exist for that type, dont change it
 						$status = $values['info_status'];
 					}
@@ -859,7 +947,10 @@ 
 				$custom = Api\Storage\Customfields::get('infolog');
 				foreach($custom as $c_name => $c_field)
 				{
-					if($c_field['type2']) $type2 = is_array($c_field['type2']) ? $c_field['type2'] : explode(',',$c_field['type2']);
+					if($c_field['type2'])
+					{
+						$type2 = is_array($c_field['type2']) ? $c_field['type2'] : explode(',',$c_field['type2']);
+					}
 					if($c_field['needed'] && (!$c_field['type2'] || $c_field['type2'] && in_array($values['info_type'],$type2)))
 					{
 						// Required custom field
@@ -878,8 +969,7 @@ 
 			{
 				if (!$this->check_access($values['info_id'],Acl::EDIT) ||
 					!$values['info_id'] && !$this->check_access($values,Acl::ADD)
-				)
-				{
+				) {
 					return false;	// no edit rights from the group-owner and no implicit rights (delegated and sufficient rights)
 				}
 			}
@@ -938,10 +1028,16 @@ 
 			$to_write['info_id'] = $info_id;
 
 			// if the info responbsible array is not passed, fetch it from old.
-			if (!array_key_exists('info_responsible',$values)) $values['info_responsible'] = $old['info_responsible'];
-			if (!is_array($values['info_responsible']))		// this should not happen, bug it does ;-)
+			if (!array_key_exists('info_responsible',$values))
+			{
+				$values['info_responsible'] = $old['info_responsible'];
+			}
+			if (!is_array($values['info_responsible']))
+			{
+				// this should not happen, bug it does ;-)
 			{
 				$values['info_responsible'] = $values['info_responsible'] ? explode(',',$values['info_responsible']) : array();
+			}
 				$to_write['info_responsible'] = $values['info_responsible'];
 			}
 
@@ -1013,7 +1109,10 @@ 
 			$this->tracking->track($to_write,$old,$this->user,$values['info_status'] == 'deleted' || $old['info_status'] == 'deleted',
 				null,$skip_notification);
 
-			if ($info_from_set) $values['info_from'] = '';
+			if ($info_from_set)
+			{
+				$values['info_from'] = '';
+			}
 
 			// Change new values back to user time before sending them back
 			if($user2server)
@@ -1126,13 +1225,25 @@ 
 
 		if($query['filter'] == 'bydate')
 		{
-			if (is_int($query['startdate'])) $query['col_filter'][] = 'info_startdate >= '.$GLOBALS['egw']->db->quote($query['startdate']);
-			if (is_int($query['enddate'])) $query['col_filter'][] = 'info_startdate <= '.$GLOBALS['egw']->db->quote($query['enddate']+(60*60*24)-1);
+			if (is_int($query['startdate']))
+			{
+				$query['col_filter'][] = 'info_startdate >= '.$GLOBALS['egw']->db->quote($query['startdate']);
+			}
+			if (is_int($query['enddate']))
+			{
+				$query['col_filter'][] = 'info_startdate <= '.$GLOBALS['egw']->db->quote($query['enddate']+(60*60*24)-1);
+			}
 		}
 		elseif ($query['filter'] == 'duedate')
 		{
-			if (is_int($query['startdate'])) $query['col_filter'][] = 'info_enddate >= '.$GLOBALS['egw']->db->quote($query['startdate']);
-			if (is_int($query['enddate'])) $query['col_filter'][] = 'info_enddate <= '.$GLOBALS['egw']->db->quote($query['enddate']+(60*60*24)-1);
+			if (is_int($query['startdate']))
+			{
+				$query['col_filter'][] = 'info_enddate >= '.$GLOBALS['egw']->db->quote($query['startdate']);
+			}
+			if (is_int($query['enddate']))
+			{
+				$query['col_filter'][] = 'info_enddate <= '.$GLOBALS['egw']->db->quote($query['enddate']+(60*60*24)-1);
+			}
 		}
 		elseif ($query['filter'] == 'private')
 		{
@@ -1214,7 +1325,10 @@ 
 
 		$result =& $this->search($filter);
 
-		if (empty($result)) return 'EGw-empty-wGE';
+		if (empty($result))
+		{
+			return 'EGw-empty-wGE';
+		}
 
 		$entry = array_shift($result);
 
@@ -1261,7 +1375,10 @@ 
 				'to_id' => 0,
 			),
 		);
-		if ($GLOBALS['egw_info']['user']['preferences']['infolog']['cat_add_default']) $info['info_cat'] = $GLOBALS['egw_info']['user']['preferences']['infolog']['cat_add_default'];
+		if ($GLOBALS['egw_info']['user']['preferences']['infolog']['cat_add_default'])
+		{
+			$info['info_cat'] = $GLOBALS['egw_info']['user']['preferences']['infolog']['cat_add_default'];
+		}
 		// find the addressbookentry to link with
 		$addressbook = new Api\Contacts();
 		$contacts = array();
@@ -1522,7 +1639,10 @@ 
 			{
 				foreach($anzSubs as $info_id => $subs)
 				{
-					if ($subs) $infos[$info_id]['class'] .= ' infolog_rowHasSubs';
+					if ($subs)
+					{
+						$infos[$info_id]['class'] .= ' infolog_rowHasSubs';
+					}
 				}
 			}
 		}
@@ -1649,7 +1769,10 @@ 
 		$save_prefs      = $GLOBALS['egw_info']['user']['preferences'];
 		foreach($users as $user)
 		{
-			if (!($email = $GLOBALS['egw']->accounts->id2name($user,'account_email'))) continue;
+			if (!($email = $GLOBALS['egw']->accounts->id2name($user,'account_email')))
+			{
+				continue;
+			}
 			// create the enviroment for $user
 			$this->user = $GLOBALS['egw_info']['user']['account_id'] = $user;
 			$GLOBALS['egw']->preferences->__construct($user);
@@ -1667,7 +1790,10 @@ 
 				'notify_start_delegated'   => 'open-delegated-date',
 			) as $pref => $filter)
 			{
-				if (!($pref_value = $GLOBALS['egw_info']['user']['preferences']['infolog'][$pref])) continue;
+				if (!($pref_value = $GLOBALS['egw_info']['user']['preferences']['infolog'][$pref]))
+				{
+					continue;
+				}
 
 				$filter .= date('Y-m-d',time()+24*60*60*(int)$pref_value);
 				//error_log(__METHOD__."() checking with filter '$filter' ($pref_value) for user $user ($email)");
@@ -1676,7 +1802,10 @@ 
 				foreach($this->so->search($params) as $info)
 				{
 					// check if we already send a notification for that infolog entry, eg. starting and due on same day
-					if (in_array($info['info_id'],$notified_info_ids)) continue;
+					if (in_array($info['info_id'],$notified_info_ids))
+					{
+						continue;
+					}
 
 					if (is_null($this->tracking) || $this->tracking->user != $user)
 					{
@@ -1805,11 +1934,17 @@ 
 			$statis = $icons = array();
 			foreach($this->status as $t => $stati)
 			{
-				if ($t === 'defaults') continue;
+				if ($t === 'defaults')
+				{
+					continue;
+				}
 				foreach($stati as $val => $label)
 				{
 					$statis[$val][$label] = lang($label);
-					if (!isset($icons[$val])) $icons[$val] = $label;
+					if (!isset($icons[$val]))
+					{
+						$icons[$val] = $label;
+					}
 				}
 			}
 			foreach($statis as $val => &$labels)
@@ -1885,7 +2020,10 @@ 
 			{
 				return array($egwData['info_id']);
 			}
-			if (!$relax) return array();
+			if (!$relax)
+			{
+				return array();
+			}
 		}
 		unset($infoData['info_id']);
 
@@ -1894,7 +2032,10 @@ 
 			$filter = array('col_filter' => array('info_uid' => $infoData['info_uid']));
 			foreach($this->so->search($filter) as $egwData)
 			{
-				if (!$this->check_access($egwData,Acl::READ)) continue;
+				if (!$this->check_access($egwData,Acl::READ))
+				{
+					continue;
+				}
 				$foundInfoLogs[$egwData['info_id']] = $egwData['info_id'];
 			}
 			return $foundInfoLogs;
@@ -1946,7 +2087,10 @@ 
 
 		foreach ($this->so->search($filter) as $itemID => $egwData)
 		{
-			if (!$this->check_access($egwData,Acl::READ)) continue;
+			if (!$this->check_access($egwData,Acl::READ))
+			{
+				continue;
+			}
 
 			switch ($infoData['info_type'])
 			{
@@ -2019,7 +2163,10 @@ 
 		//	__FILE__, __LINE__, PEAR_LOG_DEBUG);
 		foreach ($this->so->search($filter) as $itemID => $egwData)
 		{
-			if (!$this->check_access($egwData,Acl::READ)) continue;
+			if (!$this->check_access($egwData,Acl::READ))
+			{
+				continue;
+			}
 			// Horde::logMessage("findVTODO Trying\n"
 			//	. print_r($egwData, true),
 			//	__FILE__, __LINE__, PEAR_LOG_DEBUG);

Spacing +246 added lines, -247 removed lines

@@ -40,7 +40,7 @@ 
 	 */
 	var $total;
 	var $vfs;
-	var $vfs_basedir='/infolog';
+	var $vfs_basedir = '/infolog';
 	/**
 	 * Set Logging
 	 *
@@ -65,13 +65,13 @@ 
 	 *
 	 * @var array
 	 */
-	var $timestamps = array('info_startdate','info_enddate','info_datemodified','info_datecompleted','info_created');
+	var $timestamps = array('info_startdate', 'info_enddate', 'info_datemodified', 'info_datecompleted', 'info_created');
 	/**
 	 * fields the responsible user can change
 	 *
 	 * @var array
 	 */
-	var $responsible_edit=array('info_status','info_percent','info_datecompleted');
+	var $responsible_edit = array('info_status', 'info_percent', 'info_datecompleted');
 	/**
 	 * Fields to exclude from copy, if an entry is copied, the ones below are excluded by default.
 	 *
@@ -95,19 +95,19 @@ 
 	 *
 	 * @var string
 	 */
-	var $implicit_rights='read';
+	var $implicit_rights = 'read';
 	/**
 	 * Custom fields read from the infolog config
 	 *
 	 * @var array
 	 */
-	var $customfields=array();
+	var $customfields = array();
 	/**
 	 * Group owners for certain types read from the infolog config
 	 *
 	 * @var array
 	 */
-	var $group_owners=array();
+	var $group_owners = array();
 	/**
 	 * Current user
 	 *
@@ -174,55 +174,55 @@ 
 	function __construct($info_id = 0)
 	{
 		$this->enums = $this->stock_enums = array(
-			'priority' => array (
+			'priority' => array(
 				3 => 'urgent',
 				2 => 'high',
 				1 => 'normal',
 				0 => 'low'
 			),
 			'confirm'   => array(
-				'not' => 'not','accept' => 'accept','finish' => 'finish',
+				'not' => 'not', 'accept' => 'accept', 'finish' => 'finish',
 				'both' => 'both' ),
 			'type'      => array(
-				'task' => 'task','phone' => 'phone','note' => 'note','email' => 'email'
+				'task' => 'task', 'phone' => 'phone', 'note' => 'note', 'email' => 'email'
 			/*	,'confirm' => 'confirm','reject' => 'reject','fax' => 'fax' not implemented so far */ )
 		);
 		$this->status = $this->stock_status = array(
 			'defaults' => array(
-				'task' => 'not-started', 'phone' => 'not-started', 'note' => 'done','email' => 'done'),
+				'task' => 'not-started', 'phone' => 'not-started', 'note' => 'done', 'email' => 'done'),
 			'task' => array(
-				'offer' => 'offer',				// -->  NEEDS-ACTION
-				'not-started' => 'not-started',	// iCal NEEDS-ACTION
-				'ongoing' => 'ongoing',			// iCal IN-PROCESS
-				'done' => 'done',				// iCal COMPLETED
-				'cancelled' => 'cancelled',		// iCal CANCELLED
-				'billed' => 'billed',			// -->  DONE
-				'template' => 'template',		// -->  cancelled
-				'nonactive' => 'nonactive',		// -->  cancelled
-				'archive' => 'archive' ), 		// -->  cancelled
+				'offer' => 'offer', // -->  NEEDS-ACTION
+				'not-started' => 'not-started', // iCal NEEDS-ACTION
+				'ongoing' => 'ongoing', // iCal IN-PROCESS
+				'done' => 'done', // iCal COMPLETED
+				'cancelled' => 'cancelled', // iCal CANCELLED
+				'billed' => 'billed', // -->  DONE
+				'template' => 'template', // -->  cancelled
+				'nonactive' => 'nonactive', // -->  cancelled
+				'archive' => 'archive' ), // -->  cancelled
 			'phone' => array(
-				'not-started' => 'call',		// iCal NEEDS-ACTION
-				'ongoing' => 'will-call',		// iCal IN-PROCESS
-				'done' => 'done', 				// iCal COMPLETED
-				'billed' => 'billed' ),			// -->  DONE
+				'not-started' => 'call', // iCal NEEDS-ACTION
+				'ongoing' => 'will-call', // iCal IN-PROCESS
+				'done' => 'done', // iCal COMPLETED
+				'billed' => 'billed' ), // -->  DONE
 			'note' => array(
-				'ongoing' => 'ongoing',			// iCal has no status on notes
+				'ongoing' => 'ongoing', // iCal has no status on notes
 				'done' => 'done' ),
 			'email' => array(
-				'ongoing' => 'ongoing',			// iCal has no status on notes
+				'ongoing' => 'ongoing', // iCal has no status on notes
 				'done' => 'done' ),
 		);
 		if (($config_data = Api\Config::read('infolog')))
 		{
 			if (isset($config_data['status']) && is_array($config_data['status']))
 			{
-				foreach(array_keys($config_data['status']) as $key)
+				foreach (array_keys($config_data['status']) as $key)
 				{
 					if (!is_array($this->status[$key]))
 					{
 						$this->status[$key] = array();
 					}
-					$this->status[$key] = array_merge($this->status[$key],(array)$config_data['status'][$key]);
+					$this->status[$key] = array_merge($this->status[$key], (array)$config_data['status'][$key]);
 				}
 			}
 			if (isset($config_data['types']) && is_array($config_data['types']))
@@ -237,10 +237,10 @@ 
 			$this->customfields = Api\Storage\Customfields::get('infolog');
 			if ($this->customfields)
 			{
-				foreach($this->customfields as $name => $field)
+				foreach ($this->customfields as $name => $field)
 				{
 					// old infolog customefield record
-					if(empty($field['type']))
+					if (empty($field['type']))
 					{
 						if (count($field['values'])) $field['type'] = 'select'; // selectbox
 						elseif ($field['rows'] > 1) $field['type'] = 'textarea'; // textarea
@@ -252,23 +252,23 @@ 
 						$save_config = true;
 					}
 				}
-				if ($save_config) Api\Config::save_value('customfields',$this->customfields,'infolog');
+				if ($save_config) Api\Config::save_value('customfields', $this->customfields, 'infolog');
 			}
 			if (is_array($config_data['responsible_edit']))
 			{
-				$this->responsible_edit = array_merge($this->responsible_edit,$config_data['responsible_edit']);
+				$this->responsible_edit = array_merge($this->responsible_edit, $config_data['responsible_edit']);
 			}
 			if (is_array($config_data['copy_excludefields']))
 			{
-				$this->copy_excludefields = array_merge($this->copy_excludefields,$config_data['copy_excludefields']);
+				$this->copy_excludefields = array_merge($this->copy_excludefields, $config_data['copy_excludefields']);
 			}
 			if (is_array($config_data['sub_excludefields']) && $config_data['sub_excludefields'])
 			{
-				$this->sub_excludefields = array_merge($this->sub_excludefields,$config_data['sub_excludefields']);
+				$this->sub_excludefields = array_merge($this->sub_excludefields, $config_data['sub_excludefields']);
 			}
 			else
 			{
-				$this->sub_excludefields = array_merge($this->sub_excludefields,$this->default_sub_excludefields);
+				$this->sub_excludefields = array_merge($this->sub_excludefields, $this->default_sub_excludefields);
 			}
 			if ($config_data['implicit_rights'] == 'edit')
 			{
@@ -277,7 +277,7 @@ 
 			$this->history = $config_data['history'];
 		}
 		// sort types by there translation
-		foreach($this->enums['type'] as $key => $val)
+		foreach ($this->enums['type'] as $key => $val)
 		{
 			if (($val = lang($key)) != $key.'*') $this->enums['type'][$key] = lang($key);
 		}
@@ -286,14 +286,14 @@ 
 		$this->user = $GLOBALS['egw_info']['user']['account_id'];
 
 		$this->now = time();
-		$this->user_time_now = Api\DateTime::server2user($this->now,'ts');
+		$this->user_time_now = Api\DateTime::server2user($this->now, 'ts');
 
-		$this->grants = $GLOBALS['egw']->acl->get_grants('infolog',$this->group_owners ? $this->group_owners : true);
+		$this->grants = $GLOBALS['egw']->acl->get_grants('infolog', $this->group_owners ? $this->group_owners : true);
 		$this->so = new infolog_so($this->grants);
 
 		if ($info_id)
 		{
-			$this->read( $info_id );
+			$this->read($info_id);
 		}
 		else
 		{
@@ -309,9 +309,9 @@ 
 	 */
 	function has_customfields($type)
 	{
-		foreach($this->customfields as $field)
+		foreach ($this->customfields as $field)
 		{
-			if ((!$type || empty($field['type2']) || in_array($type,is_array($field['type2']) ? $field['type2'] : explode(',',$field['type2']))))
+			if ((!$type || empty($field['type2']) || in_array($type, is_array($field['type2']) ? $field['type2'] : explode(',', $field['type2']))))
 			{
 				return True;
 			}
@@ -328,7 +328,7 @@ 
 	 * @param int $user = null user whos rights to check, default current user
 	 * @return boolean
 	 */
-	function check_access($info,$required_rights,$other=0,$user=null)
+	function check_access($info, $required_rights, $other = 0, $user = null)
 	{
 		static $cache = array();
 
@@ -338,17 +338,17 @@ 
 		if ($user == $this->user)
 		{
 			$grants = $this->grants;
-			if ($info_id) $access =& $cache[$info_id][$required_rights];	// we only cache the current user!
+			if ($info_id) $access = & $cache[$info_id][$required_rights]; // we only cache the current user!
 		}
 		else
 		{
-			$grants = $GLOBALS['egw']->acl->get_grants('infolog',$this->group_owners ? $this->group_owners : true,$user);
+			$grants = $GLOBALS['egw']->acl->get_grants('infolog', $this->group_owners ? $this->group_owners : true, $user);
 		}
 		if (!$info)
 		{
 			$owner = $other ? $other : $user;
 			$grant = $grants[$owner];
-			return $grant & $required_rights;
+			return $grant&$required_rights;
 		}
 
 
@@ -360,10 +360,10 @@ 
 				if (!is_array($info) && !($info = $this->so->read(array('info_id' => $info_id)))) return false;
 
 				if ($info['info_status'] == 'deleted' &&
-					($required_rights == Acl::EDIT ||		// no edit rights for deleted entries
-					 $required_rights == Acl::ADD  ||		// no add rights for deleted entries
+					($required_rights == Acl::EDIT || // no edit rights for deleted entries
+					 $required_rights == Acl::ADD || // no add rights for deleted entries
 					 $required_rights == Acl::DELETE && ($this->history == 'history_no_delete' || // no delete at all!
-					 $this->history == 'history_admin_delete' && (!isset($GLOBALS['egw_info']['user']['apps']['admin']) || $user!=$this->user))))	// delete only for admins
+					 $this->history == 'history_admin_delete' && (!isset($GLOBALS['egw_info']['user']['apps']['admin']) || $user != $this->user))))	// delete only for admins
 				{
 					$access = false;
 				}
@@ -371,12 +371,12 @@ 
 				{
 					if ($info['info_status'] != 'deleted')
 					{
-						$access = false;	// can only undelete deleted items
+						$access = false; // can only undelete deleted items
 					}
 					else
 					{
 						// undelete requires edit rights
-						$access = $this->so->check_access( $info,Acl::EDIT,$this->implicit_rights == 'edit',$grants,$user );
+						$access = $this->so->check_access($info, Acl::EDIT, $this->implicit_rights == 'edit', $grants, $user);
 					}
 				}
 			}
@@ -386,7 +386,7 @@ 
 			}
 			if (!isset($access))
 			{
-				$access = $this->so->check_access( $info,$required_rights,$this->implicit_rights == 'edit',$grants,$user );
+				$access = $this->so->check_access($info, $required_rights, $this->implicit_rights == 'edit', $grants, $user);
 			}
 		}
 		// else $cached = ' (from cache)';
@@ -421,12 +421,12 @@ 
 	 * @param string $not_id = '' id to exclude
 	 * @return boolean True if we have a linked item, False otherwise
 	 */
-	function link_id2from(&$info,$not_app='',$not_id='')
+	function link_id2from(&$info, $not_app = '', $not_id = '')
 	{
 		//error_log(__METHOD__ . "(subject='{$info['info_subject']}', link_id='{$info['info_link_id']}', from='{$info['info_from']}', not_app='$not_app', not_id='$not_id')");
 
 		if ($info['info_link_id'] > 0 &&
-			(isset($info['links']) && ($link = $info['links'][$info['info_link_id']]) ||	// use supplied links info
+			(isset($info['links']) && ($link = $info['links'][$info['info_link_id']]) || // use supplied links info
 			 ($link = Link::get_link($info['info_link_id'])) !== False))	// if link not found in supplied links, we always search!
 		{
 			if (isset($info['links']) && isset($link['app']))
@@ -440,11 +440,11 @@ 
 				$app = $link['link_app'.$nr];
 				$id  = $link['link_id'.$nr];
 			}
-			$title = Link::title($app,$id);
+			$title = Link::title($app, $id);
 
 			if ((string)$info['info_custom_from'] === '')	// old entry
 			{
-				$info['info_custom_from'] = (int) ($title != $info['info_from'] && @htmlentities($title) != $info['info_from']);
+				$info['info_custom_from'] = (int)($title != $info['info_from'] && @htmlentities($title) != $info['info_from']);
 			}
 			if (!$info['info_custom_from'])
 			{
@@ -466,7 +466,7 @@ 
 			return $info['blur_title'] = $title;
 		}
 		$info['info_link'] = array('title' => $info['info_from']);
-		$info['info_link_id'] = 0;	// link might have been deleted
+		$info['info_link_id'] = 0; // link might have been deleted
 		$info['info_custom_from'] = (int)!!$info['info_from'];
 
 		return False;
@@ -477,7 +477,7 @@ 
 	 */
 	static function subject_from_des($des)
 	{
-		return substr($des,0,60).' ...';
+		return substr($des, 0, 60).' ...';
 	}
 
 	/**
@@ -492,7 +492,7 @@ 
 	 * 			or NULL for timestamps in user-time
 	 * 			or false for timestamps in server-time
 	 */
-	 function time2time(&$values, $fromTZId=false, $toTZId=null)
+	 function time2time(&$values, $fromTZId = false, $toTZId = null)
 	 {
 
 		if ($fromTZId === $toTZId) return;
@@ -533,7 +533,7 @@ 
 			$toTZ = Api\DateTime::$server_timezone;
 		}
 		//error_log(__METHOD__.'(values[info_enddate]='.date('Y-m-d H:i:s',$values['info_enddate']).", from=".array2string($fromTZId).", to=".array2string($toTZId).") tz=".$tz->getName().', fromTZ='.$fromTZ->getName().', toTZ='.$toTZ->getName().', userTZ='.Api\DateTime::$user_timezone->getName());
-	 	foreach($this->timestamps as $key)
+	 	foreach ($this->timestamps as $key)
 		{
 		 	if ($values[$key])
 		 	{
@@ -542,14 +542,14 @@ 
 			 	if ($time->format('Hi') == '0000')
 			 	{
 				 	// we keep dates the same in new timezone
-				 	$arr = Api\DateTime::to($time,'array');
+				 	$arr = Api\DateTime::to($time, 'array');
 				 	$time = new Api\DateTime($arr, $toTZ);
 			 	}
 			 	else
 			 	{
 				 	$time->setTimezone($toTZ);
 			 	}
-			 	$values[$key] = Api\DateTime::to($time,'ts');
+			 	$values[$key] = Api\DateTime::to($time, 'ts');
 		 	}
 		}
 		//error_log(__METHOD__.'() --> values[info_enddate]='.date('Y-m-d H:i:s',$values['info_enddate']));
@@ -562,11 +562,11 @@ 
 	 * @param string $date_format = 'ts' date-formats: 'ts'=timestamp, 'server'=timestamp in server-time, 'array'=array or string with date-format
 	 * @return mixed depending of $date_format
 	 */
-	function date2usertime($ts,$date_format='ts')
+	function date2usertime($ts, $date_format = 'ts')
 	{
 		if (empty($ts) || $date_format == 'server') return $ts;
 
-		return Api\DateTime::server2user($ts,$date_format);
+		return Api\DateTime::server2user($ts, $date_format);
 	}
 
 	/**
@@ -581,10 +581,10 @@ 
 	 *
 	 * @return array|boolean infolog entry, null if not found or false if no permission to read it
 	 */
-	function &read($info_id,$run_link_id2from=true,$date_format='ts',$ignore_acl=false)
+	function &read($info_id, $run_link_id2from = true, $date_format = 'ts', $ignore_acl = false)
 	{
 		//error_log(__METHOD__.'('.array2string($info_id).', '.array2string($run_link_id2from).", '$date_format') ".function_backtrace());
-		if (is_scalar($info_id) || isset($info_id[count($info_id)-1]))
+		if (is_scalar($info_id) || isset($info_id[count($info_id) - 1]))
 		{
 			if (is_scalar($info_id) && !is_numeric($info_id))
 			{
@@ -601,7 +601,7 @@ 
 			return null;
 		}
 
-		if (!$ignore_acl && !$this->check_access($data,Acl::READ))	// check behind read, to prevent a double read
+		if (!$ignore_acl && !$this->check_access($data, Acl::READ))	// check behind read, to prevent a double read
 		{
 			return False;
 		}
@@ -633,7 +633,7 @@ 
 	 * @param boolean $skip_notification Do not send notification of delete
 	 * @return boolean True if delete was successful, False otherwise ($info_id does not exist or no rights)
 	 */
-	function delete($info_id,$delete_children=False,$new_parent=False, $skip_notification=False)
+	function delete($info_id, $delete_children = False, $new_parent = False, $skip_notification = False)
 	{
 		if (is_array($info_id))
 		{
@@ -643,18 +643,18 @@ 
 		{
 			return False;
 		}
-		if (!$this->check_access($info,Acl::DELETE))
+		if (!$this->check_access($info, Acl::DELETE))
 		{
 			return False;
 		}
 		// check if we have children and delete or re-parent them
 		if (($children = $this->so->get_children($info_id)))
 		{
-			foreach($children as $id => $owner)
+			foreach ($children as $id => $owner)
 			{
-				if ($delete_children && $this->so->grants[$owner] & Acl::DELETE)
+				if ($delete_children && $this->so->grants[$owner]&Acl::DELETE)
 				{
-					$this->delete($id,$delete_children,$new_parent,$skip_notification);	// call ourself recursive to delete the child
+					$this->delete($id, $delete_children, $new_parent, $skip_notification); // call ourself recursive to delete the child
 				}
 				else	// dont delete or no rights to delete the child --> re-parent it
 				{
@@ -673,28 +673,28 @@ 
 		// if we have history switched on and not an already deleted item --> set only status deleted
 		if ($this->history && $info['info_status'] != 'deleted')
 		{
-			if ($info['info_status'] == 'deleted') return false;	// entry already deleted
+			if ($info['info_status'] == 'deleted') return false; // entry already deleted
 
 			$this->so->write($deleted);
 
-			Link::unlink(0,'infolog',$info_id,'','!file','',true);	// keep the file attachments, hide the rest
+			Link::unlink(0, 'infolog', $info_id, '', '!file', '', true); // keep the file attachments, hide the rest
 		}
 		else
 		{
-			$this->so->delete($info_id,false);	// we delete the children via bo to get all notifications!
+			$this->so->delete($info_id, false); // we delete the children via bo to get all notifications!
 
-			Link::unlink(0,'infolog',$info_id);
+			Link::unlink(0, 'infolog', $info_id);
 		}
 		if ($info['info_status'] != 'deleted')	// dont notify of final purge of already deleted items
 		{
 			// send email notifications and do the history logging
-			if(!$skip_notification)
+			if (!$skip_notification)
 			{
 				if (!is_object($this->tracking))
 				{
 					$this->tracking = new infolog_tracking($this);
 				}
-				$this->tracking->track($deleted,$info,$this->user,true);
+				$this->tracking->track($deleted, $info, $this->user, true);
 			}
 		}
 		return True;
@@ -716,13 +716,13 @@ 
 	*
 	* @return int|boolean info_id on a successfull write or false
 	*/
-	function write(&$values_in, $check_defaults=true, $touch_modified=true, $user2server=true,
-		$skip_notification=false, $throw_exception=false, $purge_cfs=null, $ignore_acl=false)
+	function write(&$values_in, $check_defaults = true, $touch_modified = true, $user2server = true,
+		$skip_notification = false, $throw_exception = false, $purge_cfs = null, $ignore_acl = false)
 	{
 		$values = $values_in;
 		//echo "boinfolog::write()values="; _debug_array($values);
-		if (!$ignore_acl && (!$values['info_id'] && !$this->check_access(0,Acl::EDIT,$values['info_owner']) &&
-			!$this->check_access(0,Acl::ADD,$values['info_owner'])))
+		if (!$ignore_acl && (!$values['info_id'] && !$this->check_access(0, Acl::EDIT, $values['info_owner']) &&
+			!$this->check_access(0, Acl::ADD, $values['info_owner'])))
 		{
 			return false;
 		}
@@ -732,7 +732,7 @@ 
 			$old = $this->read($values['info_id'], false, 'server', $ignore_acl);
 		}
 
-		if (($status_only = !$ignore_acl && $values['info_id'] && !$this->check_access($values,Acl::EDIT)))
+		if (($status_only = !$ignore_acl && $values['info_id'] && !$this->check_access($values, Acl::EDIT)))
 		{
 			if (!isset($values['info_responsible']))
 			{
@@ -744,21 +744,21 @@ 
 			}
 			if (!($status_only = in_array($this->user, (array)$responsible)))	// responsible has implicit right to change status
 			{
-				$status_only = !!array_intersect((array)$responsible,array_keys($GLOBALS['egw']->accounts->memberships($this->user)));
+				$status_only = !!array_intersect((array)$responsible, array_keys($GLOBALS['egw']->accounts->memberships($this->user)));
 			}
 			if (!$status_only && $values['info_status'] != 'deleted')
 			{
-				$status_only = $undelete = $this->check_access($values['info_id'],self::ACL_UNDELETE);
+				$status_only = $undelete = $this->check_access($values['info_id'], self::ACL_UNDELETE);
 			}
 		}
-		if (!$ignore_acl && ($values['info_id'] && !$this->check_access($values['info_id'],Acl::EDIT) && !$status_only ||
-		    !$values['info_id'] && $values['info_id_parent'] && !$this->check_access($values['info_id_parent'],Acl::ADD)))
+		if (!$ignore_acl && ($values['info_id'] && !$this->check_access($values['info_id'], Acl::EDIT) && !$status_only ||
+		    !$values['info_id'] && $values['info_id_parent'] && !$this->check_access($values['info_id_parent'], Acl::ADD)))
 		{
 			return false;
 		}
 
 		// Make sure status is still valid if the type changes
-		if($old['info_type'] != $values['info_type'] && $values['info_status'])
+		if ($old['info_type'] != $values['info_type'] && $values['info_status'])
 		{
 			if (isset($this->status[$values['info_type']]) &&
 				!in_array($values['info_status'], array_keys($this->status[$values['info_type']])))
@@ -768,8 +768,8 @@ 
 		}
 		if ($status_only && !$undelete)	// make sure only status gets writen
 		{
-			$set_completed = !$values['info_datecompleted'] &&	// set date completed of finished job, only if its not already set
-				in_array($values['info_status'],array('done','billed','cancelled'));
+			$set_completed = !$values['info_datecompleted'] && // set date completed of finished job, only if its not already set
+				in_array($values['info_status'], array('done', 'billed', 'cancelled'));
 
 			$values = $old;
 			// only overwrite explicitly allowed fields
@@ -784,7 +784,7 @@ 
 				$values['info_percent'] = 100;
 				$forcestatus = true;
 				$status = 'done';
-				if (isset($values['info_type']) && !in_array($values['info_status'],array('done','billed','cancelled'))) {
+				if (isset($values['info_type']) && !in_array($values['info_status'], array('done', 'billed', 'cancelled'))) {
 					$forcestatus = false;
 					//echo "set_completed:"; _debug_array($this->status[$values['info_type']]);
 					if (isset($this->status[$values['info_type']]['done'])) {
@@ -798,19 +798,19 @@ 
 						$status = 'cancelled';
 					}
 				}
-				if ($forcestatus && !in_array($values['info_status'],array('done','billed','cancelled'))) $values['info_status'] = $status;
+				if ($forcestatus && !in_array($values['info_status'], array('done', 'billed', 'cancelled'))) $values['info_status'] = $status;
 			}
 			$check_defaults = false;
 		}
 		if ($check_defaults)
 		{
 			if (!$values['info_datecompleted'] &&
-				(in_array($values['info_status'],array('done','billed'))))
+				(in_array($values['info_status'], array('done', 'billed'))))
 			{
-				$values['info_datecompleted'] = $user2server ? $this->user_time_now : $this->now;	// set date completed to today if status == done
+				$values['info_datecompleted'] = $user2server ? $this->user_time_now : $this->now; // set date completed to today if status == done
 			}
 			// Check for valid status / percent combinations
-			if (in_array($values['info_status'],array('done','billed')))
+			if (in_array($values['info_status'], array('done', 'billed')))
 			{
 				$values['info_percent'] = 100;
 			}
@@ -825,7 +825,7 @@ 
 				// We change percent to match status, not status to match percent
 				$values['info_percent'] = 10;
 			}
-			if ((int)$values['info_percent'] == 100 && !in_array($values['info_status'],array('done','billed','cancelled','archive')))
+			if ((int)$values['info_percent'] == 100 && !in_array($values['info_status'], array('done', 'billed', 'cancelled', 'archive')))
 			{
 				//echo "check_defaults:"; _debug_array($this->status[$values['info_type']]);
 				//$values['info_status'] = 'done';
@@ -846,7 +846,7 @@ 
 			}
 			if ($values['info_responsible'] && $values['info_status'] == 'offer')
 			{
-				$values['info_status'] = 'not-started';   // have to match if not finished
+				$values['info_status'] = 'not-started'; // have to match if not finished
 			}
 			if (isset($values['info_subject']) && empty($values['info_subject']))
 			{
@@ -854,18 +854,18 @@ 
 			}
 
 			// Check required custom fields
-			if($throw_exception)
+			if ($throw_exception)
 			{
 				$custom = Api\Storage\Customfields::get('infolog');
-				foreach($custom as $c_name => $c_field)
+				foreach ($custom as $c_name => $c_field)
 				{
-					if($c_field['type2']) $type2 = is_array($c_field['type2']) ? $c_field['type2'] : explode(',',$c_field['type2']);
-					if($c_field['needed'] && (!$c_field['type2'] || $c_field['type2'] && in_array($values['info_type'],$type2)))
+					if ($c_field['type2']) $type2 = is_array($c_field['type2']) ? $c_field['type2'] : explode(',', $c_field['type2']);
+					if ($c_field['needed'] && (!$c_field['type2'] || $c_field['type2'] && in_array($values['info_type'], $type2)))
 					{
 						// Required custom field
-						if(!$values['#'.$c_name])
+						if (!$values['#'.$c_name])
 						{
-							throw new Api\Exception\WrongUserinput(lang('For infolog type %1, %2 is required',lang($values['info_type']),$c_field['label']));
+							throw new Api\Exception\WrongUserinput(lang('For infolog type %1, %2 is required', lang($values['info_type']), $c_field['label']));
 						}
 					}
 				}
@@ -874,16 +874,16 @@ 
 		if (isset($this->group_owners[$values['info_type']]))
 		{
 			$values['info_owner'] = $this->group_owners[$values['info_type']];
-			if (!$ignore_acl && !($this->grants[$this->group_owners[$values['info_type']]] & Acl::EDIT))
+			if (!$ignore_acl && !($this->grants[$this->group_owners[$values['info_type']]]&Acl::EDIT))
 			{
-				if (!$this->check_access($values['info_id'],Acl::EDIT) ||
-					!$values['info_id'] && !$this->check_access($values,Acl::ADD)
+				if (!$this->check_access($values['info_id'], Acl::EDIT) ||
+					!$values['info_id'] && !$this->check_access($values, Acl::ADD)
 				)
 				{
-					return false;	// no edit rights from the group-owner and no implicit rights (delegated and sufficient rights)
+					return false; // no edit rights from the group-owner and no implicit rights (delegated and sufficient rights)
 				}
 			}
-			$values['info_access'] = 'public';	// group-owners are allways public
+			$values['info_access'] = 'public'; // group-owners are allways public
 		}
 		elseif (!$values['info_id'] && !$values['info_owner'] || $GLOBALS['egw']->accounts->get_type($values['info_owner']) == 'g')
 		{
@@ -938,10 +938,10 @@ 
 			$to_write['info_id'] = $info_id;
 
 			// if the info responbsible array is not passed, fetch it from old.
-			if (!array_key_exists('info_responsible',$values)) $values['info_responsible'] = $old['info_responsible'];
+			if (!array_key_exists('info_responsible', $values)) $values['info_responsible'] = $old['info_responsible'];
 			if (!is_array($values['info_responsible']))		// this should not happen, bug it does ;-)
 			{
-				$values['info_responsible'] = $values['info_responsible'] ? explode(',',$values['info_responsible']) : array();
+				$values['info_responsible'] = $values['info_responsible'] ? explode(',', $values['info_responsible']) : array();
 				$to_write['info_responsible'] = $values['info_responsible'];
 			}
 
@@ -949,11 +949,11 @@ 
 			if (!$old && is_array($to_write['link_to']['to_id']) && count($to_write['link_to']['to_id']))
 			{
 				//echo "<p>writing links for new entry $info_id</p>\n"; _debug_array($content['link_to']['to_id']);
-				Link::link('infolog',$info_id,$to_write['link_to']['to_id']);
+				Link::link('infolog', $info_id, $to_write['link_to']['to_id']);
 				$values['link_to']['to_id'] = $info_id;
 			}
 			$this->write_check_links($to_write);
-			if(!$values['info_link_id'] || $values['info_link_id'] != $to_write['info_link_id'])
+			if (!$values['info_link_id'] || $values['info_link_id'] != $to_write['info_link_id'])
 			{
 				// Just got a link ID, need to save it
 				$this->so->write($to_write);
@@ -968,20 +968,20 @@ 
 			}
 
 			// create (and remove) links in custom fields
-			if(!is_array($old))
+			if (!is_array($old))
 			{
 				$old = array();
 			}
-			Api\Storage\Customfields::update_links('infolog',$values,$old,'info_id');
+			Api\Storage\Customfields::update_links('infolog', $values, $old, 'info_id');
 
 			// Check for restore of deleted entry, restore held links
-			if($old['info_status'] == 'deleted' && $values['info_status'] != 'deleted')
+			if ($old['info_status'] == 'deleted' && $values['info_status'] != 'deleted')
 			{
 				Link::restore('infolog', $info_id);
 			}
 
 			// notify the link-class about the update, as other apps may be subscribt to it
-			Link::notify_update('infolog',$info_id,$values);
+			Link::notify_update('infolog', $info_id, $values);
 
 			// pre-cache the new values
 			self::set_link_cache($values);
@@ -992,39 +992,39 @@ 
 				$this->tracking = new infolog_tracking($this);
 			}
 
-			if ($old && ($missing_fields = array_diff_key($old,$values)))
+			if ($old && ($missing_fields = array_diff_key($old, $values)))
 			{
 				// Some custom fields (multiselect with nothing selected) will be missing,
 				// and that's OK.  Don't put them back.
-				foreach(array_keys($missing_fields) as $field)
+				foreach (array_keys($missing_fields) as $field)
 				{
-					if(array_key_exists($field, $values_in))
+					if (array_key_exists($field, $values_in))
 					{
 						unset($missing_fields[$field]);
 					}
 				}
-				$values = array_merge($values,$missing_fields);
+				$values = array_merge($values, $missing_fields);
 			}
 			// Add keys missing in the $to_write array
-			if (($missing_fields = array_diff_key($values,$to_write)))
+			if (($missing_fields = array_diff_key($values, $to_write)))
 			{
-				$to_write = array_merge($to_write,$missing_fields);
+				$to_write = array_merge($to_write, $missing_fields);
 			}
-			$this->tracking->track($to_write,$old,$this->user,$values['info_status'] == 'deleted' || $old['info_status'] == 'deleted',
-				null,$skip_notification);
+			$this->tracking->track($to_write, $old, $this->user, $values['info_status'] == 'deleted' || $old['info_status'] == 'deleted',
+				null, $skip_notification);
 
 			if ($info_from_set) $values['info_from'] = '';
 
 			// Change new values back to user time before sending them back
-			if($user2server)
+			if ($user2server)
 			{
 				$this->time2time($values);
 			}
 			// merge changes (keeping extra values from the UI)
-			$values_in = array_merge($values_in,$values);
+			$values_in = array_merge($values_in, $values);
 
 			// Update modified timestamp of parent
-			if($values['info_id_parent'] && $touch_modified)
+			if ($values['info_id_parent'] && $touch_modified)
 			{
 				$parent = $this->read($values['info_id_parent'], false, 'server', true);
 				$this->write($parent, false, true, false, true, false, null, $ignore_acl);
@@ -1044,9 +1044,9 @@ 
 	protected function write_check_links(&$values)
 	{
 		$old_link_id = (int)$values['info_link_id'];
-		if($values['info_contact'])
+		if ($values['info_contact'])
 		{
-			if(is_array($values['info_contact']))
+			if (is_array($values['info_contact']))
 			{
 				// eTemplate2 returns the array all ready
 				$app = $values['info_contact']['app'];
@@ -1063,14 +1063,14 @@ 
 			}
 			elseif ($app && $id)
 			{
-				if(!is_array($values['link_to']))
+				if (!is_array($values['link_to']))
 				{
 					$values['link_to'] = array();
 				}
 				$values['info_link_id'] = (int)($info_link_id = Link::link(
 						'infolog',
 						$values['info_id'],
-						$app,$id
+						$app, $id
 				));
 			}
 			else
@@ -1082,7 +1082,7 @@ 
 		{
 			$link = Link::get_link($old_link_id);
 			// remove selected project, if removed link is that project
-			if($link['link_app2'] == 'projectmanager' && $link['link_id2'] == $values['old_pm_id'])
+			if ($link['link_app2'] == 'projectmanager' && $link['link_id2'] == $values['old_pm_id'])
 			{
 				unset($values['pm_id'], $values['old_pm_id']);
 			}
@@ -1101,9 +1101,9 @@ 
 	 * @param int|array $info_id id
 	 * @return int|array number of subs
 	 */
-	function anzSubs( $info_id )
+	function anzSubs($info_id)
 	{
-		return $this->so->anzSubs( $info_id );
+		return $this->so->anzSubs($info_id);
 	}
 
 	/**
@@ -1120,23 +1120,23 @@ 
 	 * @param boolean $no_acl =false true: ignore all acl
 	 * @return array with id's as key of the matching log-entries
 	 */
-	function &search(&$query, $no_acl=false)
+	function &search(&$query, $no_acl = false)
 	{
 		//error_log(__METHOD__.'('.array2string($query).')');
 
-		if($query['filter'] == 'bydate')
+		if ($query['filter'] == 'bydate')
 		{
 			if (is_int($query['startdate'])) $query['col_filter'][] = 'info_startdate >= '.$GLOBALS['egw']->db->quote($query['startdate']);
-			if (is_int($query['enddate'])) $query['col_filter'][] = 'info_startdate <= '.$GLOBALS['egw']->db->quote($query['enddate']+(60*60*24)-1);
+			if (is_int($query['enddate'])) $query['col_filter'][] = 'info_startdate <= '.$GLOBALS['egw']->db->quote($query['enddate'] + (60 * 60 * 24) - 1);
 		}
 		elseif ($query['filter'] == 'duedate')
 		{
 			if (is_int($query['startdate'])) $query['col_filter'][] = 'info_enddate >= '.$GLOBALS['egw']->db->quote($query['startdate']);
-			if (is_int($query['enddate'])) $query['col_filter'][] = 'info_enddate <= '.$GLOBALS['egw']->db->quote($query['enddate']+(60*60*24)-1);
+			if (is_int($query['enddate'])) $query['col_filter'][] = 'info_enddate <= '.$GLOBALS['egw']->db->quote($query['enddate'] + (60 * 60 * 24) - 1);
 		}
 		elseif ($query['filter'] == 'private')
 		{
-			$query['col_filter'][] = 'info_access = ' . $GLOBALS['egw']->db->quote('private');
+			$query['col_filter'][] = 'info_access = '.$GLOBALS['egw']->db->quote('private');
 		}
 		if (!isset($query['date_format']) || $query['date_format'] != 'server')
 		{
@@ -1146,7 +1146,7 @@ 
 				{
 					if (!empty($query['col_filter'][$key]))
 					{
-						$query['col_filter'][$key] = Api\DateTime::user2server($query['col_filter'][$key],'ts');
+						$query['col_filter'][$key] = Api\DateTime::user2server($query['col_filter'][$key], 'ts');
 					}
 				}
 			}
@@ -1159,7 +1159,7 @@ 
 		{
 			foreach ($ret as $id => &$data)
 			{
-				if (!$no_acl && !$this->check_access($data,Acl::READ))
+				if (!$no_acl && !$this->check_access($data, Acl::READ))
 				{
 					unset($ret[$id]);
 					continue;
@@ -1175,7 +1175,7 @@ 
 							if ($time->format('Hi') == '0000')
 							{
 								// we keep dates the same in user-time
-								$arr = Api\DateTime::to($time,'array');
+								$arr = Api\DateTime::to($time, 'array');
 								$time = new Api\DateTime($arr, Api\DateTime::$user_timezone);
 							}
 							else
@@ -1183,7 +1183,7 @@ 
 								$time->setTimezone(Api\DateTime::$user_timezone);
 							}
 						}
-						$data[$key] = Api\DateTime::to($time,'ts');
+						$data[$key] = Api\DateTime::to($time, 'ts');
 					}
 				}
 				// pre-cache title and file access
@@ -1200,7 +1200,7 @@ 
 	 * @param array $filter = array('filter'=>'own','info_type'=>'task')
 	 * @return string
 	 */
-	public function getctag(array $filter=array('filter'=>'own','info_type'=>'task'))
+	public function getctag(array $filter = array('filter'=>'own', 'info_type'=>'task'))
 	{
 		$filter += array(
 			'order'			=> 'info_datemodified',
@@ -1212,7 +1212,7 @@ 
 		// we need to query deleted entries too for a ctag!
 		$filter['filter'] .= '+deleted';
 
-		$result =& $this->search($filter);
+		$result = & $this->search($filter);
 
 		if (empty($result)) return 'EGw-empty-wGE';
 
@@ -1234,12 +1234,12 @@ 
 	 * @param string $_date
 	 * @return array $content array for uiinfolog
 	 */
-	function import_mail($_addresses,$_subject,$_message,$_attachments,$_date)
+	function import_mail($_addresses, $_subject, $_message, $_attachments, $_date)
 	{
-		foreach($_addresses as $address)
+		foreach ($_addresses as $address)
 		{
 			$names[] = $address['name'];
-			$emails[] =$address['email'];
+			$emails[] = $address['email'];
 		}
 
 		$type = isset($this->enums['type']['email']) ? 'email' : 'note';
@@ -1247,8 +1247,8 @@ 
 		$info = array(
 			'info_id' => 0,
 			'info_type' => $type,
-			'info_from' => implode(', ',$names),
-			'info_addr' => implode(', ',$emails),
+			'info_from' => implode(', ', $names),
+			'info_addr' => implode(', ', $emails),
 			'info_subject' => $_subject,
 			'info_des' => $_message,
 			'info_startdate' => Api\DateTime::server2user($_date),
@@ -1267,16 +1267,16 @@ 
 		$contacts = array();
 		foreach ($emails as $mailadr)
 		{
-			$contacts = array_merge($contacts,(array)$addressbook->search(
+			$contacts = array_merge($contacts, (array)$addressbook->search(
 				array(
 					'email' => $mailadr,
 					'email_home' => $mailadr
-				),True,'','','',false,'OR',false,null,'',false));
+				), True, '', '', '', false, 'OR', false, null, '', false));
 		}
 		if (!$contacts || !is_array($contacts) || !is_array($contacts[0]))
 		{
-			$info['msg'] = lang('Attention: No Contact with address %1 found.',$info['info_addr']);
-			$info['info_custom_from'] = true;	// show the info_from line and NOT only the link
+			$info['msg'] = lang('Attention: No Contact with address %1 found.', $info['info_addr']);
+			$info['info_custom_from'] = true; // show the info_from line and NOT only the link
 		}
 		else
 		{
@@ -1286,21 +1286,21 @@ 
 			// create the rest a "ordinary" links
 			foreach ($contacts as $contact)
 			{
-				Link::link('infolog',$info['link_to']['to_id'],'addressbook',$contact['id']);
+				Link::link('infolog', $info['link_to']['to_id'], 'addressbook', $contact['id']);
 			}
 		}
 		if (is_array($_attachments))
 		{
 			foreach ($_attachments as $attachment)
 			{
-				if($attachment['egw_data'])
+				if ($attachment['egw_data'])
 				{
-					Link::link('infolog',$info['link_to']['to_id'],Link::DATA_APPNAME,  $attachment);
+					Link::link('infolog', $info['link_to']['to_id'], Link::DATA_APPNAME, $attachment);
 				}
-				else if(is_readable($attachment['tmp_name']) ||
+				else if (is_readable($attachment['tmp_name']) ||
 					(Vfs::is_readable($attachment['tmp_name']) && parse_url($attachment['tmp_name'], PHP_URL_SCHEME) === 'vfs'))
 				{
-					Link::link('infolog',$info['link_to']['to_id'],'file',  $attachment);
+					Link::link('infolog', $info['link_to']['to_id'], 'file', $attachment);
 				}
 			}
 		}
@@ -1319,14 +1319,14 @@ 
 	{
 		if (!is_array($info))
 		{
-			$info = $this->read( $info,false );
+			$info = $this->read($info, false);
 		}
 		if (!$info)
 		{
 			return $info;
 		}
-		$title = !empty($info['info_subject']) ? $info['info_subject'] :self::subject_from_des($info['info_descr']);
-		return $title.($GLOBALS['egw_info']['user']['preferences']['infolog']['show_id']?' (#'.$info['info_id'].')':'');
+		$title = !empty($info['info_subject']) ? $info['info_subject'] : self::subject_from_des($info['info_descr']);
+		return $title.($GLOBALS['egw_info']['user']['preferences']['infolog']['show_id'] ? ' (#'.$info['info_id'].')' : '');
 	}
 
 	/**
@@ -1337,15 +1337,15 @@ 
 	function link_titles(array $ids)
 	{
 		$titles = array();
-		foreach ($this->search($params=array(
+		foreach ($this->search($params = array(
 			'col_filter' => array('info_id' => $ids),
 		)) as $info)
 		{
 			$titles[$info['info_id']] = $this->link_title($info);
 		}
-		foreach (array_diff($ids,array_keys($titles)) as $id)
+		foreach (array_diff($ids, array_keys($titles)) as $id)
 		{
-			$titles[$id] = false;	// we assume every not returned entry to be not readable, as we notify the link class about all deletes
+			$titles[$id] = false; // we assume every not returned entry to be not readable, as we notify the link class about all deletes
 		}
 		return $titles;
 	}
@@ -1372,7 +1372,7 @@ 
 		$content = array();
 		if (is_array($ids))
 		{
-			foreach(array_keys($ids) as $id)
+			foreach (array_keys($ids) as $id)
 			{
 				$content[$id] = $this->link_title($id);
 			}
@@ -1389,10 +1389,10 @@ 
 	 * @param int $user = null for which user to check, default current user
 	 * @return boolean true if access is granted or false otherwise
 	 */
-	function file_access($id,$check,$rel_path=null,$user=null)
+	function file_access($id, $check, $rel_path = null, $user = null)
 	{
-		unset($rel_path);	// not used
-		return $this->check_access($id,$check,0,$user);
+		unset($rel_path); // not used
+		return $this->check_access($id, $check, 0, $user);
 	}
 
 	/**
@@ -1402,10 +1402,9 @@ 
 	 */
 	function set_link_cache(array $info)
 	{
-		Link::set_cache('infolog',$info['info_id'],
+		Link::set_cache('infolog', $info['info_id'],
 			$this->link_title($info),
-			$this->file_access($info,Acl::EDIT) ? EGW_ACL_READ|EGW_ACL_EDIT :
-			($this->file_access($info,Acl::READ) ? Acl::READ : 0));
+			$this->file_access($info, Acl::EDIT) ? EGW_ACL_READ|EGW_ACL_EDIT : ($this->file_access($info, Acl::READ) ? Acl::READ : 0));
 	}
 
 	/**
@@ -1419,8 +1418,8 @@ 
 	function cal_to_include($args)
 	{
 		//echo "<p>cal_to_include("; print_r($args); echo ")</p>\n";
-		$user = (int) $args['owner'];
-		if ($user <= 0 && !checkdate($args['month'],$args['day'],$args['year']))
+		$user = (int)$args['owner'];
+		if ($user <= 0 && !checkdate($args['month'], $args['day'], $args['year']))
 		{
 			return False;
 		}
@@ -1428,7 +1427,7 @@ 
 
 		$do_events = $args['location'] == 'calendar_include_events';
 		$to_include = array();
-		$date_wanted = sprintf('%04d/%02d/%02d',$args['year'],$args['month'],$args['day']);
+		$date_wanted = sprintf('%04d/%02d/%02d', $args['year'], $args['month'], $args['day']);
 		$query = array(
 			'order' => $args['order'] ? $args['order'] : 'info_startdate',
 			'sort'  => $args['sort'] ? $args['sort'] : ($do_events ? 'ASC' : 'DESC'),
@@ -1437,34 +1436,34 @@ 
 		);
 		if ($GLOBALS['egw_info']['user']['preferences']['infolog']['cal_show'] || $GLOBALS['egw_info']['user']['preferences']['infolog']['cal_show'] === '0')
 		{
-			$query['col_filter']['info_type'] = explode(',',$GLOBALS['egw_info']['user']['preferences']['infolog']['cal_show']);
+			$query['col_filter']['info_type'] = explode(',', $GLOBALS['egw_info']['user']['preferences']['infolog']['cal_show']);
 		}
 		elseif ($this->customfields && !$GLOBALS['egw_info']['user']['preferences']['infolog']['cal_show_custom'])
 		{
-			$query['col_filter']['info_type'] = array('task','phone','note','email');
+			$query['col_filter']['info_type'] = array('task', 'phone', 'note', 'email');
 		}
 		while ($infos = $this->search($query))
 		{
 			foreach ($infos as $info)
 			{
-				$start = new Api\DateTime($info['info_startdate'],Api\DateTime::$user_timezone);
+				$start = new Api\DateTime($info['info_startdate'], Api\DateTime::$user_timezone);
 				$title = ($do_events ? $start->format(false).' ' : '').
 					$info['info_subject'];
-				$view = Link::view('infolog',$info['info_id']);
+				$view = Link::view('infolog', $info['info_id']);
 				$size = null;
-				$edit = Link::edit('infolog',$info['info_id'], $size);
+				$edit = Link::edit('infolog', $info['info_id'], $size);
 				$edit['size'] = $size;
-				$content=array();
+				$content = array();
 				$status = $this->status[$info['info_type']][$info['info_status']];
 				$icons = array();
-				foreach(array(
+				foreach (array(
 					$info['info_type'] => 'navbar',
 					$status => 'status'
 				) as $icon => $default)
 				{
-					$icons[Api\Image::find('infolog',$icon) ? $icon : $default] = $icon;
+					$icons[Api\Image::find('infolog', $icon) ? $icon : $default] = $icon;
 				}
-				$content[] = Api\Html::a_href($title,$view);
+				$content[] = Api\Html::a_href($title, $view);
 				$html = Api\Html::table(array(1 => $content));
 
 				$to_include[] = array(
@@ -1477,9 +1476,9 @@ 
 					'content'   => $html,
 				);
 			}
-			if ($query['total'] <= ($query['start']+=count($infos)))
+			if ($query['total'] <= ($query['start'] += count($infos)))
 			{
-				break;	// no more availible
+				break; // no more availible
 			}
 		}
 		//echo "boinfolog::cal_to_include("; print_r($args); echo ")<pre>"; print_r($to_include); echo "</pre>\n";
@@ -1502,7 +1501,7 @@ 
 				'cols' => 'main.info_id,info_type,info_status,info_percent,info_id_parent',
 			);
 			$infos = array();
-			foreach($this->search($query) as $row)
+			foreach ($this->search($query) as $row)
 			{
 				$infos[$row['info_id']] = array(
 					'status' => $row['info_type'] != 'phone' && $row['info_status'] == 'ongoing' ?
@@ -1511,16 +1510,16 @@ 
 						'ongoing' : 'infolog/'.$row['info_status'],
 					'class'  => $row['info_id_parent'] ? 'infolog_rowHasParent' : null,
 				);
-				if (Api\Image::find('infolog', $icon=$row['info_type'].'_element') ||
-					Api\Image::find('infolog', $icon=$row['info_type']))
+				if (Api\Image::find('infolog', $icon = $row['info_type'].'_element') ||
+					Api\Image::find('infolog', $icon = $row['info_type']))
 				{
 					$infos[$row['info_id']]['icon'] = 'infolog/'.$icon;
 				}
 			}
 			$anzSubs = $this->anzSubs(array_keys($infos));
-			if($anzSubs && is_array($anzSubs))
+			if ($anzSubs && is_array($anzSubs))
 			{
-				foreach($anzSubs as $info_id => $subs)
+				foreach ($anzSubs as $info_id => $subs)
 				{
 					if ($subs) $infos[$info_id]['class'] .= ' infolog_rowHasSubs';
 				}
@@ -1540,18 +1539,18 @@ 
 	 *  by the ones the user normally does not see due to category permissions - used to preserve categories
 	 * @return array category ids (found, added and preserved categories)
 	 */
-	function find_or_add_categories($catname_list, $info_id=-1)
+	function find_or_add_categories($catname_list, $info_id = -1)
 	{
 		if (!is_object($this->categories))
 		{
-			$this->categories = new Api\Categories($this->user,'infolog');
+			$this->categories = new Api\Categories($this->user, 'infolog');
 		}
 		$old_cats_preserve = array();
 		if ($info_id && $info_id > 0)
 		{
 			// preserve Api\Categories without users read access
 			$old_infolog = $this->read($info_id);
-			$old_categories = explode(',',$old_infolog['info_cat']);
+			$old_categories = explode(',', $old_infolog['info_cat']);
 			if (is_array($old_categories) && count($old_categories) > 0)
 			{
 				foreach ($old_categories as $cat_id)
@@ -1612,15 +1611,15 @@ 
 	{
 		if (!is_object($this->categories))
 		{
-			$this->categories = new Api\Categories($this->user,'infolog');
+			$this->categories = new Api\Categories($this->user, 'infolog');
 		}
 
 		if (!is_array($cat_id_list))
 		{
-			$cat_id_list = explode(',',$cat_id_list);
+			$cat_id_list = explode(',', $cat_id_list);
 		}
 		$cat_list = array();
-		foreach($cat_id_list as $cat_id)
+		foreach ($cat_id_list as $cat_id)
 		{
 			if ($cat_id && $this->categories->check_perms(Acl::READ, $cat_id) &&
 					($cat_name = $this->categories->id2name($cat_id)) && $cat_name != '--')
@@ -1647,19 +1646,19 @@ 
 
 		$save_account_id = $GLOBALS['egw_info']['user']['account_id'];
 		$save_prefs      = $GLOBALS['egw_info']['user']['preferences'];
-		foreach($users as $user)
+		foreach ($users as $user)
 		{
-			if (!($email = $GLOBALS['egw']->accounts->id2name($user,'account_email'))) continue;
+			if (!($email = $GLOBALS['egw']->accounts->id2name($user, 'account_email'))) continue;
 			// create the enviroment for $user
 			$this->user = $GLOBALS['egw_info']['user']['account_id'] = $user;
 			$GLOBALS['egw']->preferences->__construct($user);
 			$GLOBALS['egw_info']['user']['preferences'] = $GLOBALS['egw']->preferences->read_repository();
 			$GLOBALS['egw']->acl->__construct($user);
-			$this->grants = $GLOBALS['egw']->acl->get_grants('infolog',$this->group_owners ? $this->group_owners : true);
-			$this->so = new infolog_so($this->grants);	// so caches it's filters
+			$this->grants = $GLOBALS['egw']->acl->get_grants('infolog', $this->group_owners ? $this->group_owners : true);
+			$this->so = new infolog_so($this->grants); // so caches it's filters
 
 			$notified_info_ids = array();
-			foreach(array(
+			foreach (array(
 				'notify_due_responsible'   => 'open-responsible-enddate',
 				'notify_due_delegated'     => 'open-delegated-enddate',
 				'notify_start_responsible' => 'open-responsible-date',
@@ -1668,44 +1667,44 @@ 
 			{
 				if (!($pref_value = $GLOBALS['egw_info']['user']['preferences']['infolog'][$pref])) continue;
 
-				$filter .= date('Y-m-d',time()+24*60*60*(int)$pref_value);
+				$filter .= date('Y-m-d', time() + 24 * 60 * 60 * (int)$pref_value);
 				//error_log(__METHOD__."() checking with filter '$filter' ($pref_value) for user $user ($email)");
 
 				$params = array('filter' => $filter, 'custom_fields' => true, 'subs' => true);
-				foreach($this->so->search($params) as $info)
+				foreach ($this->so->search($params) as $info)
 				{
 					// check if we already send a notification for that infolog entry, eg. starting and due on same day
-					if (in_array($info['info_id'],$notified_info_ids)) continue;
+					if (in_array($info['info_id'], $notified_info_ids)) continue;
 
 					if (is_null($this->tracking) || $this->tracking->user != $user)
 					{
 						$this->tracking = new infolog_tracking($this);
 					}
-					switch($pref)
+					switch ($pref)
 					{
 						case 'notify_due_responsible':
-							$info['prefix'] = lang('Due %1',$this->enums['type'][$info['info_type']]);
-							$info['message'] = lang('%1 you are responsible for is due at %2',$this->enums['type'][$info['info_type']],
-								$this->tracking->datetime($info['info_enddate'],false));
+							$info['prefix'] = lang('Due %1', $this->enums['type'][$info['info_type']]);
+							$info['message'] = lang('%1 you are responsible for is due at %2', $this->enums['type'][$info['info_type']],
+								$this->tracking->datetime($info['info_enddate'], false));
 							break;
 						case 'notify_due_delegated':
-							$info['prefix'] = lang('Due %1',$this->enums['type'][$info['info_type']]);
-							$info['message'] = lang('%1 you delegated is due at %2',$this->enums['type'][$info['info_type']],
-								$this->tracking->datetime($info['info_enddate'],false));
+							$info['prefix'] = lang('Due %1', $this->enums['type'][$info['info_type']]);
+							$info['message'] = lang('%1 you delegated is due at %2', $this->enums['type'][$info['info_type']],
+								$this->tracking->datetime($info['info_enddate'], false));
 							break;
 						case 'notify_start_responsible':
-							$info['prefix'] = lang('Starting %1',$this->enums['type'][$info['info_type']]);
-							$info['message'] = lang('%1 you are responsible for is starting at %2',$this->enums['type'][$info['info_type']],
-								$this->tracking->datetime($info['info_startdate'],null));
+							$info['prefix'] = lang('Starting %1', $this->enums['type'][$info['info_type']]);
+							$info['message'] = lang('%1 you are responsible for is starting at %2', $this->enums['type'][$info['info_type']],
+								$this->tracking->datetime($info['info_startdate'], null));
 							break;
 						case 'notify_start_delegated':
-							$info['prefix'] = lang('Starting %1',$this->enums['type'][$info['info_type']]);
-							$info['message'] = lang('%1 you delegated is starting at %2',$this->enums['type'][$info['info_type']],
-								$this->tracking->datetime($info['info_startdate'],null));
+							$info['prefix'] = lang('Starting %1', $this->enums['type'][$info['info_type']]);
+							$info['message'] = lang('%1 you delegated is starting at %2', $this->enums['type'][$info['info_type']],
+								$this->tracking->datetime($info['info_startdate'], null));
 							break;
 					}
 					//error_log("notifiying $user($email) about $info[info_subject]: $info[message]");
-					$this->tracking->send_notification($info,null,$email,$user,$pref);
+					$this->tracking->send_notification($info, null, $email, $user, $pref);
 
 					$notified_info_ids[] = $info['info_id'];
 				}
@@ -1768,7 +1767,7 @@ 
 	 * @param string $x_infolog_status preserved original infolog status
 	 * @return string
 	 */
-	function vtodo2status($_vtodo_status,$x_infolog_status=null)
+	function vtodo2status($_vtodo_status, $x_infolog_status = null)
 	{
 		$vtodo_status = strtoupper($_vtodo_status);
 
@@ -1792,7 +1791,7 @@ 
 	 * @param array &$icons = null on return name of icons
 	 * @return array value => (commaseparated) translations
 	 */
-	function get_status($type=null, array &$icons=null)
+	function get_status($type = null, array &$icons = null)
 	{
 		// if filtered by type, show only the stati of the filtered type
 		if ($type && isset($this->status[$type]))
@@ -1802,16 +1801,16 @@ 
 		else	// show all stati
 		{
 			$statis = $icons = array();
-			foreach($this->status as $t => $stati)
+			foreach ($this->status as $t => $stati)
 			{
 				if ($t === 'defaults') continue;
-				foreach($stati as $val => $label)
+				foreach ($stati as $val => $label)
 				{
 					$statis[$val][$label] = lang($label);
 					if (!isset($icons[$val])) $icons[$val] = $label;
 				}
 			}
-			foreach($statis as $val => &$labels)
+			foreach ($statis as $val => &$labels)
 			{
 				$labels = implode(', ', $labels);
 			}
@@ -1827,7 +1826,7 @@ 
 	 */
 	function activate($info)
 	{
-		switch((int)$info['info_percent'])
+		switch ((int)$info['info_percent'])
 		{
 			case 0:		return 'not-started';
 			case 100:	return 'done';
@@ -1846,8 +1845,8 @@ 
 		#Horde::logMessage("getParentID($_guid)",  __FILE__, __LINE__, PEAR_LOG_DEBUG);
 
 		$parentID = False;
-		$myfilter = array('col_filter' => array('info_uid'=>$_guid)) ;
-		if ($_guid && ($found=$this->search($myfilter)) && ($uidmatch = array_shift($found)))
+		$myfilter = array('col_filter' => array('info_uid'=>$_guid));
+		if ($_guid && ($found = $this->search($myfilter)) && ($uidmatch = array_shift($found)))
 		{
 			$parentID = $uidmatch['info_id'];
 		}
@@ -1864,7 +1863,7 @@ 
 	 *
 	 * @return array of infolog_ids of matching entries
 	 */
-	function findInfo($infoData, $relax=false, $tzid=null)
+	function findInfo($infoData, $relax = false, $tzid = null)
 	{
 		$foundInfoLogs = array();
 		$filter = array();
@@ -1872,7 +1871,7 @@ 
 		if ($this->log)
 		{
 			error_log(__FILE__.'['.__LINE__.'] '.__METHOD__
-				. '('. ($relax ? 'RELAX, ': 'EXACT, ') . $tzid . ')[InfoData]:'
+				. '('.($relax ? 'RELAX, ' : 'EXACT, ').$tzid.')[InfoData]:'
 				. array2string($infoData));
 		}
 
@@ -1891,9 +1890,9 @@ 
 		if (!$relax && !empty($infoData['info_uid']))
 		{
 			$filter = array('col_filter' => array('info_uid' => $infoData['info_uid']));
-			foreach($this->so->search($filter) as $egwData)
+			foreach ($this->so->search($filter) as $egwData)
 			{
-				if (!$this->check_access($egwData,Acl::READ)) continue;
+				if (!$this->check_access($egwData, Acl::READ)) continue;
 				$foundInfoLogs[$egwData['info_id']] = $egwData['info_id'];
 			}
 			return $foundInfoLogs;
@@ -1921,7 +1920,7 @@ 
 				$text = '';
 				foreach ($matches as $chunk)
 				{
-					if (strlen($text) <  strlen($chunk[0]))
+					if (strlen($text) < strlen($chunk[0]))
 					{
 						$text = $chunk[0];
 					}
@@ -1945,7 +1944,7 @@ 
 
 		foreach ($this->so->search($filter) as $itemID => $egwData)
 		{
-			if (!$this->check_access($egwData,Acl::READ)) continue;
+			if (!$this->check_access($egwData, Acl::READ)) continue;
 
 			switch ($infoData['info_type'])
 			{
@@ -1962,7 +1961,7 @@ 
 						{
 							error_log(__FILE__.'['.__LINE__.'] '.__METHOD__
 								. '()[location mismatch]: '
-								. $infoData['info_location'] . ' <> ' . $egwData['info_location']);
+								. $infoData['info_location'].' <> '.$egwData['info_location']);
 						}
 						continue;
 					}
@@ -1979,7 +1978,7 @@ 
 						{
 							error_log(__FILE__.'['.__LINE__.'] '.__METHOD__
 								. '()[description mismatch]: '
-								. $infoData['info_des'] . ' <> ' . $egwData['info_des']);
+								. $infoData['info_des'].' <> '.$egwData['info_des']);
 						}
 						continue;
 					}
@@ -1993,7 +1992,7 @@ 
 			if ($this->log)
 			{
 				error_log(__FILE__.'['.__LINE__.'] '.__METHOD__
-					. '()[FOUND]:' . array2string($foundInfoLogs));
+					. '()[FOUND]:'.array2string($foundInfoLogs));
 			}
 			return $foundInfoLogs;
 		}
@@ -2018,7 +2017,7 @@ 
 		//	__FILE__, __LINE__, PEAR_LOG_DEBUG);
 		foreach ($this->so->search($filter) as $itemID => $egwData)
 		{
-			if (!$this->check_access($egwData,Acl::READ)) continue;
+			if (!$this->check_access($egwData, Acl::READ)) continue;
 			// Horde::logMessage("findVTODO Trying\n"
 			//	. print_r($egwData, true),
 			//	__FILE__, __LINE__, PEAR_LOG_DEBUG);
@@ -2030,7 +2029,7 @@ 
 				{
 					error_log(__FILE__.'['.__LINE__.'] '.__METHOD__
 						. '()[category mismatch]: '
-						. $infoData['info_cat'] . ' <> ' . $egwData['info_cat']);
+						. $infoData['info_cat'].' <> '.$egwData['info_cat']);
 				}
 				continue;
 			}
@@ -2040,15 +2039,15 @@ 
 				if (isset($egwData['info_startdate']) && $egwData['info_startdate'])
 				{
 					// We compare the date only
-					$taskTime = new Api\DateTime($infoData['info_startdate'],Api\DateTime::$server_timezone);
-					$egwTime = new Api\DateTime($egwData['info_startdate'],Api\DateTime::$server_timezone);
+					$taskTime = new Api\DateTime($infoData['info_startdate'], Api\DateTime::$server_timezone);
+					$egwTime = new Api\DateTime($egwData['info_startdate'], Api\DateTime::$server_timezone);
 					if ($taskTime->format('Ymd') != $egwTime->format('Ymd'))
 					{
 						if ($this->log)
 						{
 							error_log(__FILE__.'['.__LINE__.'] '.__METHOD__
 								. '()[start mismatch]: '
-								. $taskTime->format('Ymd') . ' <> ' . $egwTime->format('Ymd'));
+								. $taskTime->format('Ymd').' <> '.$egwTime->format('Ymd'));
 						}
 						continue;
 					}
@@ -2075,7 +2074,7 @@ 
 					{
 						error_log(__FILE__.'['.__LINE__.'] '.__METHOD__
 							. '()[status mismatch]: '
-							. $infoData['info_status'] . ' <> ' . $egwData['info_status']);
+							. $infoData['info_status'].' <> '.$egwData['info_status']);
 					}
 					continue;
 				}
@@ -2085,15 +2084,15 @@ 
 					if (isset($egwData['info_enddate']) && $egwData['info_enddate'])
 					{
 						// We compare the date only
-						$taskTime = new Api\DateTime($infoData['info_enddate'],Api\DateTime::$server_timezone);
-						$egwTime = new Api\DateTime($egwData['info_enddate'],Api\DateTime::$server_timezone);
+						$taskTime = new Api\DateTime($infoData['info_enddate'], Api\DateTime::$server_timezone);
+						$egwTime = new Api\DateTime($egwData['info_enddate'], Api\DateTime::$server_timezone);
 						if ($taskTime->format('Ymd') != $egwTime->format('Ymd'))
 						{
 							if ($this->log)
 							{
 								error_log(__FILE__.'['.__LINE__.'] '.__METHOD__
 									. '()[DUE mismatch]: '
-									. $taskTime->format('Ymd') . ' <> ' . $egwTime->format('Ymd'));
+									. $taskTime->format('Ymd').' <> '.$egwTime->format('Ymd'));
 							}
 							continue;
 						}
@@ -2114,15 +2113,15 @@ 
 					if (isset($egwData['info_datecompleted']) && $egwData['info_datecompleted'])
 					{
 						// We compare the date only
-						$taskTime = new Api\DateTime($infoData['info_datecompleted'],Api\DateTime::$server_timezone);
-						$egwTime = new Api\DateTime($egwData['info_datecompleted'],Api\DateTime::$server_timezone);
+						$taskTime = new Api\DateTime($infoData['info_datecompleted'], Api\DateTime::$server_timezone);
+						$egwTime = new Api\DateTime($egwData['info_datecompleted'], Api\DateTime::$server_timezone);
 						if ($taskTime->format('Ymd') != $egwTime->format('Ymd'))
 						{
 							if ($this->log)
 							{
 								error_log(__FILE__.'['.__LINE__.'] '.__METHOD__
 									. '()[completed mismatch]: '
-									. $taskTime->format('Ymd') . ' <> ' . $egwTime->format('Ymd'));
+									. $taskTime->format('Ymd').' <> '.$egwTime->format('Ymd'));
 							}
 							continue;
 						}
@@ -2152,7 +2151,7 @@ 
 		if ($this->log)
 		{
 			error_log(__FILE__.'['.__LINE__.'] '.__METHOD__
-				. '()[FOUND]:' . array2string($foundInfoLogs));
+				. '()[FOUND]:'.array2string($foundInfoLogs));
 		}
 		return $foundInfoLogs;
 	}

infolog/inc/class.infolog_groupdav.inc.php

Doc Comments +6 added lines, -6 removed lines

@@ -141,7 +141,7 @@ 
 	 * @param array &$options
 	 * @param array &$files
 	 * @param int $user account_id
-	 * @return mixed boolean true on success, false on failure or string with http status (eg. '404 Not Found')
+	 * @return boolean boolean true on success, false on failure or string with http status (eg. '404 Not Found')
 	 */
 	function propfind($path,&$options,&$files,$user,$id='')
 	{
@@ -221,7 +221,7 @@ 
 	 *
 	 * @param string $path
 	 * @param array $filter
-	 * @param array|boolean $start =false false=return all or array(start,num)
+	 * @param integer[] $start =false false=return all or array(start,num)
 	 * @return array with "files" array with values for keys path and props
 	 */
 	function &propfind_callback($path,array $filter,$start=false)
@@ -521,7 +521,7 @@ 
 	 * @param array &$options
 	 * @param int $id
 	 * @param int $user =null account_id
-	 * @return mixed boolean true on success, false on failure or string with http status (eg. '404 Not Found')
+	 * @return string|boolean boolean true on success, false on failure or string with http status (eg. '404 Not Found')
 	 */
 	function get(&$options,$id,$user=null)
 	{
@@ -546,7 +546,7 @@ 
 	 * @param int $id
 	 * @param int $user =null account_id of owner, default null
 	 * @param string $prefix =null user prefix from path (eg. /ralf from /ralf/addressbook)
-	 * @return mixed boolean true on success, false on failure or string with http status (eg. '404 Not Found')
+	 * @return string|boolean boolean true on success, false on failure or string with http status (eg. '404 Not Found')
 	 */
 	function put(&$options,$id,$user=null,$prefix=null)
 	{
@@ -682,7 +682,7 @@ 
 	 *
 	 * @param array &$options
 	 * @param int $id
-	 * @return mixed boolean true on success, false on failure or string with http status (eg. '404 Not Found')
+	 * @return string|boolean boolean true on success, false on failure or string with http status (eg. '404 Not Found')
 	 */
 	function delete(&$options,$id)
 	{
@@ -757,7 +757,7 @@ 
 	 * etag currently uses the modifcation time (info_datemodified), 1.9.002 adds etag column, but it's not yet used!
 	 *
 	 * @param array|int $info array with infolog entry or info_id
-	 * @return string|boolean string with etag or false
+	 * @return false|string string with etag or false
 	 */
 	function get_etag($info)
 	{

Spacing +71 added lines, -71 removed lines

@@ -112,7 +112,7 @@ 
 		}
 		if ($path == '/infolog/')
 		{
-			$task_filter= 'own';
+			$task_filter = 'own';
 		}
 		else
 		{
@@ -122,7 +122,7 @@ 
 			}
 			else
 			{
-				$task_filter = 'user' . $user;
+				$task_filter = 'user'.$user;
 			}
 		}
 
@@ -143,7 +143,7 @@ 
 	 * @param int $user account_id
 	 * @return mixed boolean true on success, false on failure or string with http status (eg. '404 Not Found')
 	 */
-	function propfind($path,&$options,&$files,$user,$id='')
+	function propfind($path, &$options, &$files, $user, $id = '')
 	{
 		// todo add a filter to limit how far back entries from the past get synced
 		$filter = $this->get_infolog_filter($path, $user);
@@ -159,7 +159,7 @@ 
 		// enable time-range filter for tests via propfind / autoindex
 		//$filter[] = $sql = $this->_time_range_filter(array('end' => '20001231T000000Z'));
 
-		if ($id) $path = dirname($path).'/';	// caldav_name get's added anyway in the callback
+		if ($id) $path = dirname($path).'/'; // caldav_name get's added anyway in the callback
 
 		if ($this->debug > 1)
 		{
@@ -171,7 +171,7 @@ 
 		if (!($filter['calendar_data'] = $options['props'] == 'all' &&
 			$options['root']['ns'] == Api\CalDAV::CALDAV) && is_array($options['props']))
 		{
-			foreach($options['props'] as $prop)
+			foreach ($options['props'] as $prop)
 			{
 				if ($prop['name'] == 'calendar-data')
 				{
@@ -191,7 +191,7 @@ 
 
 			$this->sync_collection_token = null;
 
-			$filter['order'] = 'info_datemodified ASC';	// return oldest modifications first
+			$filter['order'] = 'info_datemodified ASC'; // return oldest modifications first
 			$filter['sync-collection'] = true;
 		}
 
@@ -205,13 +205,13 @@ 
 			if ($options['root']['name'] == 'sync-collection' && $this->bo->total > $nresults)
 			{
 				--$this->sync_collection_token;
-				$files['sync-token-params'][] = true;	// tel get_sync_collection_token that we have more entries
+				$files['sync-token-params'][] = true; // tel get_sync_collection_token that we have more entries
 			}
 		}
 		else
 		{
 			// return iterator, calling ourself to return result in chunks
-			$files['files'] = new Api\CalDAV\PropfindIterator($this,$path,$filter,$files['files']);
+			$files['files'] = new Api\CalDAV\PropfindIterator($this, $path, $filter, $files['files']);
 		}
 		return true;
 	}
@@ -224,7 +224,7 @@ 
 	 * @param array|boolean $start =false false=return all or array(start,num)
 	 * @return array with "files" array with values for keys path and props
 	 */
-	function &propfind_callback($path,array $filter,$start=false)
+	function &propfind_callback($path, array $filter, $start = false)
 	{
 		if ($this->debug) $starttime = microtime(true);
 
@@ -251,7 +251,7 @@ 
 			'filter'    	=> $task_filter,
 			'date_format'	=> 'server',
 			'col_filter'	=> $filter,
-			'custom_fields' => true,	// otherwise custom fields get NOT loaded!
+			'custom_fields' => true, // otherwise custom fields get NOT loaded!
 		);
 
 		if (!$calendar_data)
@@ -273,10 +273,10 @@ 
 
 		$files = array();
 		// ToDo: add parameter to only return id & etag
-		$tasks =& $this->bo->search($query);
+		$tasks = & $this->bo->search($query);
 		if ($tasks && $offset == $query['start'])
 		{
-			foreach($tasks as $task)
+			foreach ($tasks as $task)
 			{
 				// remove task from requested multiget ids, to be able to report not found urls
 				if ($requested_multiget_ids && ($k = array_search($task[self::$path_attr], $requested_multiget_ids)) !== false)
@@ -290,15 +290,15 @@ 
 					continue;
 				}
 				$props = array(
-					'getcontenttype' => $this->agent != 'kde' ? 'text/calendar; charset=utf-8; component=VTODO' : 'text/calendar',	// Konqueror (3.5) dont understand it otherwise
+					'getcontenttype' => $this->agent != 'kde' ? 'text/calendar; charset=utf-8; component=VTODO' : 'text/calendar', // Konqueror (3.5) dont understand it otherwise
 					'getlastmodified' => $task['info_datemodified'],
 					'displayname' => $task['info_subject'],
 				);
 				if ($calendar_data)
 				{
-					$content = $handler->exportVTODO($task, '2.0', null);	// no METHOD:PUBLISH for CalDAV
+					$content = $handler->exportVTODO($task, '2.0', null); // no METHOD:PUBLISH for CalDAV
 					$props['getcontentlength'] = bytes($content);
-					$props[] = Api\CalDAV::mkprop(Api\CalDAV::CALDAV,'calendar-data',$content);
+					$props[] = Api\CalDAV::mkprop(Api\CalDAV::CALDAV, 'calendar-data', $content);
 				}
 				$files[] = $this->add_resource($path, $task, $props);
 			}
@@ -306,13 +306,13 @@ 
 		// report not found multiget urls
 		if ($requested_multiget_ids)
 		{
-			foreach($requested_multiget_ids as $id)
+			foreach ($requested_multiget_ids as $id)
 			{
 				$files[] = array('path' => $path.$id.self::$path_extension);
 			}
 		}
 		// sync-collection report --> return modified of last contact as sync-token
-		$sync_collection_report =  $filter['sync-collection'];
+		$sync_collection_report = $filter['sync-collection'];
 		if ($sync_collection_report)
 		{
 			$this->sync_collection_token = $task['date_modified'];
@@ -338,18 +338,18 @@ 
 	 * @param int &$nresult on return limit for number or results or unchanged/null
 	 * @return boolean true if filter could be processed
 	 */
-	function _report_filters($options,&$cal_filters,$id, &$nresults)
+	function _report_filters($options, &$cal_filters, $id, &$nresults)
 	{
 		if ($options['filters'])
 		{
-			foreach($options['filters'] as $filter)
+			foreach ($options['filters'] as $filter)
 			{
-				switch($filter['name'])
+				switch ($filter['name'])
 				{
 					case 'comp-filter':
 						if ($this->debug > 1) error_log(__METHOD__."($options[path],...) comp-filter='{$filter['attrs']['name']}'");
 
-						switch($filter['attrs']['name'])
+						switch ($filter['attrs']['name'])
 						{
 							case 'VTODO':
 							case 'VCALENDAR':
@@ -392,9 +392,9 @@ 
 		    <B:nresults>10</B:nresults>
 		  </B:limit>
 		*/
-		foreach((array)$options['other'] as $option)
+		foreach ((array)$options['other'] as $option)
 		{
-			switch($option['name'])
+			switch ($option['name'])
 			{
 				case 'nresults':
 					$nresults = (int)$option['data'];
@@ -403,7 +403,7 @@ 
 				case 'limit':
 					break;
 				case 'href':
-					break;	// from addressbook-multiget, handled below
+					break; // from addressbook-multiget, handled below
 				// rfc 6578 sync-report
 				case 'sync-token':
 					if (!empty($option['data']))
@@ -411,7 +411,7 @@ 
 						$parts = explode('/', $option['data']);
 						$sync_token = array_pop($parts);
 						$cal_filters[] = 'info_datemodified>'.(int)$sync_token;
-						$cal_filters['filter'] .= '+deleted';	// to return deleted entries too
+						$cal_filters['filter'] .= '+deleted'; // to return deleted entries too
 					}
 					break;
 				case 'sync-level':
@@ -433,24 +433,24 @@ 
 			if ($id)
 			{
 				$cal_filters[self::$path_attr] = self::$path_extension ?
-					basename($id,self::$path_extension) : $id;
+					basename($id, self::$path_extension) : $id;
 			}
 			else	// fetch all given url's
 			{
-				foreach($options['other'] as $option)
+				foreach ($options['other'] as $option)
 				{
 					if ($option['name'] == 'href')
 					{
-						$parts = explode('/',$option['data']);
+						$parts = explode('/', $option['data']);
 						if (($id = basename(urldecode(array_pop($parts)))))
 						{
 							$cal_filters[self::$path_attr][] = self::$path_extension ?
-								basename($id,self::$path_extension) : $id;
+								basename($id, self::$path_extension) : $id;
 						}
 					}
 				}
 			}
-			if ($this->debug > 1) error_log(__METHOD__ ."($options[path],...,$id) calendar-multiget: ids=".implode(',',$ids));
+			if ($this->debug > 1) error_log(__METHOD__."($options[path],...,$id) calendar-multiget: ids=".implode(',', $ids));
 		}
 		return true;
 	}
@@ -478,7 +478,7 @@ 
 		elseif (empty($attrs['start']))
 		{
 			$this->caldav->log(__METHOD__.'('.array2string($attrs).') minimum one of start or end is required!');
-			return '1';	// to not give sql error, but simply not filter out anything
+			return '1'; // to not give sql error, but simply not filter out anything
 		}
 		// we dont need to care for DURATION line in rfc4791#section-9.9, as we always put that in DUE/info_enddate
 
@@ -508,10 +508,10 @@ 
 			"info_datecompleted > 0".(isset($start) ? " AND ($start <= info_datecompleted OR $start <= info_created)" : '').
 				(isset($end) ? " AND (info_datecompleted <= $end OR info_created <= $end)" : '').' OR '.
 			// we have no completed date, but always a created date
- 			"NOT info_datecompleted > 0". (isset($end) ? " AND info_created < $end" : '').
+ 			"NOT info_datecompleted > 0".(isset($end) ? " AND info_created < $end" : '').
 		')';
 		$sql = '('.implode(' OR ', $to_or).')';
-		if ($this->debug > 1) error_log(__FILE__ . __METHOD__.'('.array2string($attrs).") time-range=$attrs[start]-$attrs[end] --> $sql");
+		if ($this->debug > 1) error_log(__FILE__.__METHOD__.'('.array2string($attrs).") time-range=$attrs[start]-$attrs[end] --> $sql");
 		return $sql;
 	}
 
@@ -523,16 +523,16 @@ 
 	 * @param int $user =null account_id
 	 * @return mixed boolean true on success, false on failure or string with http status (eg. '404 Not Found')
 	 */
-	function get(&$options,$id,$user=null)
+	function get(&$options, $id, $user = null)
 	{
-		unset($user);	// not used, but required by function signature
+		unset($user); // not used, but required by function signature
 
-		if (!is_array($task = $this->_common_get_put_delete('GET',$options,$id)))
+		if (!is_array($task = $this->_common_get_put_delete('GET', $options, $id)))
 		{
 			return $task;
 		}
 		$handler = $this->_get_handler();
-		$options['data'] = $handler->exportVTODO($task, '2.0', null);	// no METHOD:PUBLISH for CalDAV
+		$options['data'] = $handler->exportVTODO($task, '2.0', null); // no METHOD:PUBLISH for CalDAV
 		$options['mimetype'] = 'text/calendar; charset=utf-8';
 		header('Content-Encoding: identity');
 		header('ETag: "'.$this->get_etag($task).'"');
@@ -548,13 +548,13 @@ 
 	 * @param string $prefix =null user prefix from path (eg. /ralf from /ralf/addressbook)
 	 * @return mixed boolean true on success, false on failure or string with http status (eg. '404 Not Found')
 	 */
-	function put(&$options,$id,$user=null,$prefix=null)
+	function put(&$options, $id, $user = null, $prefix = null)
 	{
-		unset($prefix);	// not used, but required by function signature
+		unset($prefix); // not used, but required by function signature
 
-		if ($this->debug) error_log(__METHOD__."($id, $user)".print_r($options,true));
+		if ($this->debug) error_log(__METHOD__."($id, $user)".print_r($options, true));
 
-		$oldTask = $this->_common_get_put_delete('PUT',$options,$id);
+		$oldTask = $this->_common_get_put_delete('PUT', $options, $id);
 		if (!is_null($oldTask) && !is_array($oldTask))
 		{
 			return $oldTask;
@@ -619,7 +619,7 @@ 
 	 * @param array $oldTask =null
 	 * @return array modified task data
 	 */
-	public function cat_action(array $task, $oldTask=null)
+	public function cat_action(array $task, $oldTask = null)
 	{
 		$action = $GLOBALS['egw_info']['user']['preferences']['groupdav']['infolog-cat-action'];
 
@@ -650,13 +650,13 @@ 
 			{
 				unset($task['info_responsible'][$key]);
 			}
-			switch($action)
+			switch ($action)
 			{
 				case 'set':
 					$task['info_responsible'] = array();
 					// fall through
 				case 'set-user':
-					foreach($task['info_responsible'] as $key => $account_id)
+					foreach ($task['info_responsible'] as $key => $account_id)
 					{
 						if ($GLOBALS['egw']->accounts->get_type($account_id) == 'u')
 						{
@@ -684,9 +684,9 @@ 
 	 * @param int $id
 	 * @return mixed boolean true on success, false on failure or string with http status (eg. '404 Not Found')
 	 */
-	function delete(&$options,$id)
+	function delete(&$options, $id)
 	{
-		if (!is_array($task = $this->_common_get_put_delete('DELETE',$options,$id)))
+		if (!is_array($task = $this->_common_get_put_delete('DELETE', $options, $id)))
 		{
 			return $task;
 		}
@@ -704,7 +704,7 @@ 
 	 */
 	function read($id)
 	{
-		return $this->bo->read(array(self::$path_attr => $id, "info_status!='deleted'"),false,'server');
+		return $this->bo->read(array(self::$path_attr => $id, "info_status!='deleted'"), false, 'server');
 	}
 
 	/**
@@ -727,15 +727,15 @@ 
 	 * @param array|int $task task-array or id
 	 * @return boolean null if entry does not exist, false if no access, true if access permitted
 	 */
-	function check_access($acl,$task)
+	function check_access($acl, $task)
 	{
 		if (is_null($task)) return true;
 
-		$access = $this->bo->check_access($task,$acl);
+		$access = $this->bo->check_access($task, $acl);
 
 		if (!$access && $acl == Acl::EDIT && $this->bo->is_responsible($task))
 		{
-			$access = true;	// access limited to $this->bo->responsible_edit fields (handled in infolog_bo::write())
+			$access = true; // access limited to $this->bo->responsible_edit fields (handled in infolog_bo::write())
 		}
 		if ($this->debug > 1) error_log(__METHOD__."($acl, ".array2string($task).') returning '.array2string($access));
 		return $access;
@@ -746,7 +746,7 @@ 
 	 *
 	 * @return string
 	 */
-	public function getctag($path,$user)
+	public function getctag($path, $user)
 	{
 		return $this->bo->getctag($this->get_infolog_filter($path, $user));
 	}
@@ -763,7 +763,7 @@ 
 	{
 		if (!is_array($info))
 		{
-			$info = $this->bo->read($info,true,'server');
+			$info = $this->bo->read($info, true, 'server');
 		}
 		if (!is_array($info) || !isset($info['info_id']) || !isset($info['info_datemodified']))
 		{
@@ -781,39 +781,39 @@ 
 	 * @param int $user =null account_id of owner of collection
 	 * @return array
 	 */
-	public function extra_properties(array $props, $displayname, $base_uri=null,$user=null)
+	public function extra_properties(array $props, $displayname, $base_uri = null, $user = null)
 	{
-		unset($base_uri);	// not used, but required by function signature
+		unset($base_uri); // not used, but required by function signature
 
 		// calendar description
-		$displayname = Api\Translation::convert(lang('Tasks of'),Api\Translation::charset(),'utf-8').' '.$displayname;
-		$props['calendar-description'] = Api\CalDAV::mkprop(Api\CalDAV::CALDAV,'calendar-description',$displayname);
+		$displayname = Api\Translation::convert(lang('Tasks of'), Api\Translation::charset(), 'utf-8').' '.$displayname;
+		$props['calendar-description'] = Api\CalDAV::mkprop(Api\CalDAV::CALDAV, 'calendar-description', $displayname);
 		// supported components, currently only VEVENT
-		$props['supported-calendar-component-set'] = Api\CalDAV::mkprop(Api\CalDAV::CALDAV,'supported-calendar-component-set',array(
-			Api\CalDAV::mkprop(Api\CalDAV::CALDAV,'comp',array('name' => 'VCALENDAR')),
-			Api\CalDAV::mkprop(Api\CalDAV::CALDAV,'comp',array('name' => 'VTODO')),
+		$props['supported-calendar-component-set'] = Api\CalDAV::mkprop(Api\CalDAV::CALDAV, 'supported-calendar-component-set', array(
+			Api\CalDAV::mkprop(Api\CalDAV::CALDAV, 'comp', array('name' => 'VCALENDAR')),
+			Api\CalDAV::mkprop(Api\CalDAV::CALDAV, 'comp', array('name' => 'VTODO')),
 		));
 		// supported reports
 		$props['supported-report-set'] = array(
-			'calendar-query' => Api\CalDAV::mkprop('supported-report',array(
-				Api\CalDAV::mkprop('report',array(
-					Api\CalDAV::mkprop(Api\CalDAV::CALDAV,'calendar-query',''))))),
-			'calendar-multiget' => Api\CalDAV::mkprop('supported-report',array(
-				Api\CalDAV::mkprop('report',array(
-					Api\CalDAV::mkprop(Api\CalDAV::CALDAV,'calendar-multiget',''))))),
+			'calendar-query' => Api\CalDAV::mkprop('supported-report', array(
+				Api\CalDAV::mkprop('report', array(
+					Api\CalDAV::mkprop(Api\CalDAV::CALDAV, 'calendar-query', ''))))),
+			'calendar-multiget' => Api\CalDAV::mkprop('supported-report', array(
+				Api\CalDAV::mkprop('report', array(
+					Api\CalDAV::mkprop(Api\CalDAV::CALDAV, 'calendar-multiget', ''))))),
 		);
 		// only advertice rfc 6578 sync-collection report, if "delete-prevention" is switched on (deleted entries get marked deleted but not actualy deleted
 		$config = Api\Config::read('infolog');
 		if ($config['history'])
 		{
-			$props['supported-report-set']['sync-collection'] = Api\CalDAV::mkprop('supported-report',array(
-				Api\CalDAV::mkprop('report',array(
-					Api\CalDAV::mkprop('sync-collection','')))));
+			$props['supported-report-set']['sync-collection'] = Api\CalDAV::mkprop('supported-report', array(
+				Api\CalDAV::mkprop('report', array(
+					Api\CalDAV::mkprop('sync-collection', '')))));
 		}
 		// get timezone of calendar
 		if ($this->caldav->prop_requested('calendar-timezone'))
 		{
-			$props['calendar-timezone'] = Api\CalDAV::mkprop(Api\CalDAV::CALDAV,'calendar-timezone',
+			$props['calendar-timezone'] = Api\CalDAV::mkprop(Api\CalDAV::CALDAV, 'calendar-timezone',
 				calendar_timezones::user_timezone($user));
 		}
 		return $props;
@@ -827,8 +827,8 @@ 
 	private function _get_handler()
 	{
 		$handler = new infolog_ical();
-		$handler->tzid = false;	//	as we read server-time timestamps (!= null=user-time), exports UTC times
-		$handler->setSupportedFields('GroupDAV',$this->agent);
+		$handler->tzid = false; //	as we read server-time timestamps (!= null=user-time), exports UTC times
+		$handler->setSupportedFields('GroupDAV', $this->agent);
 
 		return $handler;
 	}

Braces +76 added lines, -19 removed lines

@@ -91,7 +91,10 @@ 
 		}
 		else
 		{
-			if (!is_array($info)) $info = $this->bo->read($info);
+			if (!is_array($info))
+			{
+				$info = $this->bo->read($info);
+			}
 			$name = $info[self::$path_attr];
 		}
 		return $name.self::$path_extension;
@@ -159,7 +162,11 @@ 
 		// enable time-range filter for tests via propfind / autoindex
 		//$filter[] = $sql = $this->_time_range_filter(array('end' => '20001231T000000Z'));
 
-		if ($id) $path = dirname($path).'/';	// caldav_name get's added anyway in the callback
+		if ($id)
+		{
+			$path = dirname($path).'/';
+		}
+		// caldav_name get's added anyway in the callback
 
 		if ($this->debug > 1)
 		{
@@ -226,7 +233,10 @@ 
 	 */
 	function &propfind_callback($path,array $filter,$start=false)
 	{
-		if ($this->debug) $starttime = microtime(true);
+		if ($this->debug)
+		{
+			$starttime = microtime(true);
+		}
 
 		if (($calendar_data = $filter['calendar_data']))
 		{
@@ -242,7 +252,10 @@ 
 		if (preg_match('/^([a-z0-9_]+)( DESC| ASC)?$/i', $filter['order'], $matches))
 		{
 			$order = $matches[1];
-			if ($matches[2]) $sort = $matches[2];
+			if ($matches[2])
+			{
+				$sort = $matches[2];
+			}
 			unset($filter['order']);
 		}
 		$query = array(
@@ -325,7 +338,10 @@ 
 				--$this->sync_collection_token;
 			}
 		}
-		if ($this->debug) error_log(__METHOD__."($path) took ".(microtime(true) - $starttime).' to return '.count($files).' items');
+		if ($this->debug)
+		{
+			error_log(__METHOD__."($path) took ".(microtime(true) - $starttime).' to return '.count($files).' items');
+		}
 		return $files;
 	}
 
@@ -347,7 +363,10 @@ 
 				switch($filter['name'])
 				{
 					case 'comp-filter':
-						if ($this->debug > 1) error_log(__METHOD__."($options[path],...) comp-filter='{$filter['attrs']['name']}'");
+						if ($this->debug > 1)
+						{
+							error_log(__METHOD__."($options[path],...) comp-filter='{$filter['attrs']['name']}'");
+						}
 
 						switch($filter['attrs']['name'])
 						{
@@ -359,14 +378,23 @@ 
 						}
 						break;
 					case 'prop-filter':
-						if ($this->debug > 1) error_log(__METHOD__."($options[path],...) prop-filter='{$filter['attrs']['name']}'");
+						if ($this->debug > 1)
+						{
+							error_log(__METHOD__."($options[path],...) prop-filter='{$filter['attrs']['name']}'");
+						}
 						$prop_filter = $filter['attrs']['name'];
 						break;
 					case 'text-match':
-						if ($this->debug > 1) error_log(__METHOD__."($options[path],...) text-match: $prop_filter='{$filter['data']}'");
+						if ($this->debug > 1)
+						{
+							error_log(__METHOD__."($options[path],...) text-match: $prop_filter='{$filter['data']}'");
+						}
 						if (!isset($this->filter_prop2infolog[strtoupper($prop_filter)]))
 						{
-							if ($this->debug) error_log(__METHOD__."($options[path],".array2string($options).",...) unknown property '$prop_filter' --> ignored");
+							if ($this->debug)
+							{
+								error_log(__METHOD__."($options[path],".array2string($options).",...) unknown property '$prop_filter' --> ignored");
+							}
 						}
 						else
 						{
@@ -375,13 +403,19 @@ 
 						unset($prop_filter);
 						break;
 					case 'param-filter':
-						if ($this->debug) error_log(__METHOD__."($options[path],...) param-filter='{$filter['attrs']['name']}' not (yet) implemented!");
+						if ($this->debug)
+						{
+							error_log(__METHOD__."($options[path],...) param-filter='{$filter['attrs']['name']}' not (yet) implemented!");
+						}
 						break;
 					case 'time-range':
 						$cal_filters[] = $this->_time_range_filter($filter['attrs']);
 						break;
 					default:
-						if ($this->debug) error_log(__METHOD__."($options[path],".array2string($options).",...) unknown filter --> ignored");
+						if ($this->debug)
+						{
+							error_log(__METHOD__."($options[path],".array2string($options).",...) unknown filter --> ignored");
+						}
 						break;
 				}
 			}
@@ -450,7 +484,10 @@ 
 					}
 				}
 			}
-			if ($this->debug > 1) error_log(__METHOD__ ."($options[path],...,$id) calendar-multiget: ids=".implode(',',$ids));
+			if ($this->debug > 1)
+			{
+				error_log(__METHOD__ ."($options[path],...,$id) calendar-multiget: ids=".implode(',',$ids));
+			}
 		}
 		return true;
 	}
@@ -511,7 +548,10 @@ 
  			"NOT info_datecompleted > 0". (isset($end) ? " AND info_created < $end" : '').
 		')';
 		$sql = '('.implode(' OR ', $to_or).')';
-		if ($this->debug > 1) error_log(__FILE__ . __METHOD__.'('.array2string($attrs).") time-range=$attrs[start]-$attrs[end] --> $sql");
+		if ($this->debug > 1)
+		{
+			error_log(__FILE__ . __METHOD__.'('.array2string($attrs).") time-range=$attrs[start]-$attrs[end] --> $sql");
+		}
 		return $sql;
 	}
 
@@ -552,7 +592,10 @@ 
 	{
 		unset($prefix);	// not used, but required by function signature
 
-		if ($this->debug) error_log(__METHOD__."($id, $user)".print_r($options,true));
+		if ($this->debug)
+		{
+			error_log(__METHOD__."($id, $user)".print_r($options,true));
+		}
 
 		$oldTask = $this->_common_get_put_delete('PUT',$options,$id);
 		if (!is_null($oldTask) && !is_array($oldTask))
@@ -580,7 +623,10 @@ 
 		}
 		if (!($infoId = $handler->importVTODO($vTodo, $taskId, false, $user, null, $id, $callback_data)))
 		{
-			if ($this->debug) error_log(__METHOD__."(,$id) import_vtodo($options[content]) returned false");
+			if ($this->debug)
+			{
+				error_log(__METHOD__."(,$id) import_vtodo($options[content]) returned false");
+			}
 			return '403 Forbidden';
 		}
 
@@ -592,11 +638,13 @@ 
 		// send evtl. necessary respose headers: Location, etag, ...
 		// but only for new entries, as X-INFOLOG-STATUS get's not updated on client, if we confirm with an etag
 		if ($retval !== true)
-			// POST with add-member query parameter
+		{
+					// POST with add-member query parameter
 			//$_SERVER['REQUEST_METHOD'] == 'POST' && isset($_GET['add-member'])))
 		{
 			$this->put_response_headers($infoId, $options['path'], $retval, self::$path_attr == 'caldav_name');
 		}
+		}
 		return $retval;
 	}
 
@@ -607,7 +655,10 @@ 
 	 */
 	public function update_tags($entry)
 	{
-		if (!is_array($entry)) $entry = $this->read($entry);
+		if (!is_array($entry))
+		{
+			$entry = $this->read($entry);
+		}
 
 		$this->bo->write($entry, true);
 	}
@@ -729,7 +780,10 @@ 
 	 */
 	function check_access($acl,$task)
 	{
-		if (is_null($task)) return true;
+		if (is_null($task))
+		{
+			return true;
+		}
 
 		$access = $this->bo->check_access($task,$acl);
 
@@ -737,7 +791,10 @@ 
 		{
 			$access = true;	// access limited to $this->bo->responsible_edit fields (handled in infolog_bo::write())
 		}
-		if ($this->debug > 1) error_log(__METHOD__."($acl, ".array2string($task).') returning '.array2string($access));
+		if ($this->debug > 1)
+		{
+			error_log(__METHOD__."($acl, ".array2string($task).') returning '.array2string($access));
+		}
 		return $access;
 	}