EGroupware / egroupware

home/inc/class.home_note_portlet.inc.php

Spacing +15 added lines, -15 removed lines

@@ -35,7 +35,7 @@ 
 		if (false) parent::__construct();
 
 		// Title not set for new widgets created via context menu
-		if(!$context['title'])
+		if (!$context['title'])
 		{
 			// Set initial size to 3x2, default is too small
 			$context['width'] = 3;
@@ -56,7 +56,7 @@ 
 		$id = $_GET['id'] ? $_GET['id'] : $content['id'];
 		$height = $_GET['height'] ? $_GET['height'] : $content['height'];
 
-		if($content['group'] && $GLOBALS['egw_info']['apps']['admin'])
+		if ($content['group'] && $GLOBALS['egw_info']['apps']['admin'])
 		{
 			$prefs = new Api\Preferences(is_numeric($content['group']) ? $content['group'] : $GLOBALS['egw_info']['user']['account_id']);
 		}
@@ -67,18 +67,18 @@ 
 		$type = is_numeric($content['group']) ? "user" : $content['group'];
 		$arr = $prefs->read_repository();
 		$portlets = $arr['home'];
-		if($content['button'])
+		if ($content['button'])
 		{
 			// Save updated Api\Preferences
 			$portlets[$id]['note'] = $content['note'];
-			$prefs->add('home', $id, $portlets[$id],$type);
-			$prefs->save_repository(True,$type);
+			$prefs->add('home', $id, $portlets[$id], $type);
+			$prefs->save_repository(True, $type);
 			// Yay for AJAX submit
-			Api\Json\Response::get()->apply('window.opener.app.home.refresh',array($id));
+			Api\Json\Response::get()->apply('window.opener.app.home.refresh', array($id));
 
-			if(key($content['button'])=='save')
+			if (key($content['button']) == 'save')
 			{
-				Api\Json\Response::get()->apply('window.close',array());
+				Api\Json\Response::get()->apply('window.close', array());
 			}
 		}
 		$etemplate = new Etemplate('home.note');
@@ -90,15 +90,15 @@ 
 			'height'	=>	$height,
 			'group'		=>	$portlets[$id]['group']
 		);
-		$etemplate->exec('home.home_note_portlet.edit',array(
+		$etemplate->exec('home.home_note_portlet.edit', array(
 			'note'	=> $portlets[$id]['note']
-		), array(),array('note'=>false,'save'=>false), $preserve);
+		), array(), array('note'=>false, 'save'=>false), $preserve);
 	}
 
-	public function exec($id = null, Etemplate &$etemplate = null)
+	public function exec($id = null, Etemplate&$etemplate = null)
 	{
 		// Allow to submit directly back here
-		if(is_array($id) && $id['id'])
+		if (is_array($id) && $id['id'])
 		{
 			$id = $id['id'];
 		}
@@ -107,13 +107,13 @@ 
 		$etemplate->set_dom_id($id);
 		$content = $this->context;
 
-		if(!$content['note'])
+		if (!$content['note'])
 		{
 			$content['note'] = '';
-			Api\Json\Response::get()->apply('app.home.note_edit',array($id));
+			Api\Json\Response::get()->apply('app.home.note_edit', array($id));
 		}
 
-		$etemplate->exec('home.home_note_portlet.exec',$content,array(),array('__ALL__'=>true),array('id' =>$id));
+		$etemplate->exec('home.home_note_portlet.exec', $content, array(), array('__ALL__'=>true), array('id' =>$id));
 	}
 
 	public function get_actions()

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
 	 *
 	 * @param boolean $need_reload Flag to indicate that the portlet needs to be reloaded (exec will be called)
 	 */
-	public function __construct(Array &$context = array(), &$need_reload = false)
+	public function __construct(array &$context = array(), &$need_reload = false)
 	{
 		if (false) parent::__construct();
 

Braces +4 added lines, -1 removed lines

@@ -51,7 +51,10 @@
 	 */
 	public function __construct(Array &$context = array(), &$need_reload = false)
 	{
-		if (false) parent::__construct();
+		if (false)
+		{
+			parent::__construct();
+		}
 
 		// Process dropped data into something useable
 		if($context['dropped_data'])

home/inc/class.home_weather_portlet.inc.php

Spacing +41 added lines, -41 removed lines

@@ -39,7 +39,7 @@ 
 		if (false) parent::__construct();
 
 		// City not set for new widgets created via context menu
-		if(!$context['city'] || $context['height'] < 2)
+		if (!$context['city'] || $context['height'] < 2)
 		{
 			// Set initial size to 3x2, default is too small
 			$context['width'] = 3;
@@ -51,10 +51,10 @@ 
 		$this->context = $context;
 	}
 
-	public function exec($id = null, Etemplate &$etemplate = null)
+	public function exec($id = null, Etemplate&$etemplate = null)
 	{
 		// Allow to submit directly back here
-		if(is_array($id) && $id['id'])
+		if (is_array($id) && $id['id'])
 		{
 			$id = $id['id'];
 		}
@@ -68,24 +68,24 @@ 
 			// Always get (& cache) 10 days, we'll cut down later
 			'cnt'	=> 10
 		);
-		if($this->context['city_id'])
+		if ($this->context['city_id'])
 		{
 			$request['id'] = $this->context['city_id'];
 			$content += $this->get_weather($request);
 		}
-		elseif($this->context['city'])
+		elseif ($this->context['city'])
 		{
 			$request['q'] = $this->context['city'];
 			$content += $this->get_weather($request);
 		}
 		elseif ($this->context['position'])
 		{
-			list($request['lat'],$request['lon']) = explode(',',$this->context['position']);
+			list($request['lat'], $request['lon']) = explode(',', $this->context['position']);
 			$content += $this->get_weather($request);
 		}
 
 		// Caching is best done by city ID, so store that
-		if($content['city_id'] && (!$this->context['city_id'] || $content['city_id'] != $this->context['city_id']))
+		if ($content['city_id'] && (!$this->context['city_id'] || $content['city_id'] != $this->context['city_id']))
 		{
 
 			$arr = $GLOBALS['egw']->preferences->read_repository();
@@ -101,7 +101,7 @@ 
 		}
 
 		// Adjust data to match portlet size
-		if($this->context['height'] <= 2 && $this->context['width'] <= 3)
+		if ($this->context['height'] <= 2 && $this->context['width'] <= 3)
 		{
 			// Too small for the other days
 			unset($content['list']);
@@ -112,16 +112,16 @@ 
 			unset($content['current']);
 		}
 		// Even too small for current high/low
-		if($this->context['width'] < 3)
+		if ($this->context['width'] < 3)
 		{
 			$content['current']['no_current_temp'] = true;
 		}
 
 
 		// Direct to full forecast page
-		$content['attribution'] ='http://openweathermap.org/city/'.$content['city_id'];
+		$content['attribution'] = 'http://openweathermap.org/city/'.$content['city_id'];
 
-		$etemplate->exec('home.home_weather_portlet.exec',$content,array(),array('__ALL__'=>true),array('id' =>$id));
+		$etemplate->exec('home.home_weather_portlet.exec', $content, array(), array('__ALL__'=>true), array('id' =>$id));
 	}
 
 	/**
@@ -133,27 +133,27 @@ 
 	public function get_weather(Array $query, $api_url = '')
 	{
 		static $debug = false;
-		if(!$api_url)
+		if (!$api_url)
 		{
-			$api_url = self::API_URL . '/weather?';
+			$api_url = self::API_URL.'/weather?';
 		}
-		if(self::API_KEY)
+		if (self::API_KEY)
 		{
 			$query['APPID'] = self::API_KEY;
 		}
 		$data = Api\Cache::getTree('home', json_encode($query), function($query)
 		{
 			$debug = false;
-			if($debug) error_log('Fetching fresh data from ' . static::API_URL);
+			if ($debug) error_log('Fetching fresh data from '.static::API_URL);
 
-			$url = static::API_URL.'forecast/daily?'. http_build_query($query);
+			$url = static::API_URL.'forecast/daily?'.http_build_query($query);
 			$forecast = file_get_contents($url);
 
-			$url = static::API_URL.'weather?'. http_build_query($query);
+			$url = static::API_URL.'weather?'.http_build_query($query);
 			$current = file_get_contents($url);
-			if($debug) error_log(__METHOD__ . ' current: ' . $current);
+			if ($debug) error_log(__METHOD__.' current: '.$current);
 
-			return array_merge(array('current' => json_decode($current,true)), json_decode($forecast,true));
+			return array_merge(array('current' => json_decode($current, true)), json_decode($forecast, true));
 		}, array($query), self::CACHE_TIME);
 
 		// Some sample data, if you need to test
@@ -161,22 +161,22 @@ 
 		//$weather = '{"coord":{"lon":-114.05,"lat":53.23},"sys":{"message":0.3098,"country":"Canada","sunrise":1420559329,"sunset":1420587344},"weather":[{"id":802,"main":"Clouds","description":"scattered clouds","icon":"03n"}],"base":"cmc stations","main":{"temp":-21.414,"temp_min":-21.414,"temp_max":-21.414,"pressure":947.79,"sea_level":1050.73,"grnd_level":947.79,"humidity":69},"wind":{"speed":3,"deg":273.5},"clouds":{"all":32},"dt":1420502430,"id":0,"name":"Thorsby","cod":200}';
 		//$weather = '{"cod":"200","message":0.1743,"city":{"id":"5978233","name":"Thorsby","coord":{"lon":-114.051,"lat":53.2285},"country":"Canada","population":0},"cnt":6,"list":[{"dt":1420743600,"temp":{"day":-17.49,"min":-27.86,"max":-16.38,"night":-27.86,"eve":-19.91,"morn":-16.77},"pressure":966.21,"humidity":66,"weather":[{"id":800,"main":"Clear","description":"sky is clear","icon":"01d"}],"speed":6.91,"deg":312,"clouds":0,"snow":0.02},{"dt":1420830000,"temp":{"day":-24.86,"min":-29.71,"max":-17.98,"night":-18.31,"eve":-18.32,"morn":-29.51},"pressure":948.46,"humidity":54,"weather":[{"id":801,"main":"Clouds","description":"few clouds","icon":"02d"}],"speed":3.21,"deg":166,"clouds":20},{"dt":1420916400,"temp":{"day":-18.51,"min":-25.57,"max":-17.86,"night":-23.83,"eve":-23.91,"morn":-19.28},"pressure":947.22,"humidity":74,"weather":[{"id":802,"main":"Clouds","description":"scattered clouds","icon":"03d"}],"speed":1.97,"deg":314,"clouds":48},{"dt":1421002800,"temp":{"day":-26.69,"min":-29.86,"max":-20.19,"night":-21.82,"eve":-24.66,"morn":-28.85},"pressure":951.93,"humidity":22,"weather":[{"id":800,"main":"Clear","description":"sky is clear","icon":"02d"}],"speed":1.36,"deg":196,"clouds":8},{"dt":1421089200,"temp":{"day":0.9,"min":-8.24,"max":0.9,"night":-4.99,"eve":-0.21,"morn":-8.24},"pressure":929.31,"humidity":0,"weather":[{"id":800,"main":"Clear","description":"sky is clear","icon":"01d"}],"speed":6.01,"deg":302,"clouds":5,"snow":0},{"dt":1421175600,"temp":{"day":-1.53,"min":-6.7,"max":2.23,"night":-3.65,"eve":2.23,"morn":-6.7},"pressure":934.51,"humidity":0,"weather":[{"id":800,"main":"Clear","description":"sky is clear","icon":"01d"}],"speed":3.9,"deg":201,"clouds":78}]}';
 
-		if($debug)
+		if ($debug)
 		{
-			error_log(__METHOD__ .' weather info:');
-			foreach(array_keys($data) as $key)
+			error_log(__METHOD__.' weather info:');
+			foreach (array_keys($data) as $key)
 			{
-				error_log($key . ': ' .array2string($data[$key]));
+				error_log($key.': '.array2string($data[$key]));
 			}
 		}
-		if(is_string($data['message']))
+		if (is_string($data['message']))
 		{
 			$desc = $this->get_description();
-			Framework::message($desc['displayName'] . ': ' . $desc['title'] . "\n".$data['message'], 'warning');
+			Framework::message($desc['displayName'].': '.$desc['title']."\n".$data['message'], 'warning');
 			return array();
 		}
 
-		if(array_key_exists('city', $data))
+		if (array_key_exists('city', $data))
 		{
 			$data['city_id'] = $data['city']['id'];
 		}
@@ -184,23 +184,23 @@ 
 		{
 			$data['city_id'] = $data['id'];
 		}
-		if($data['list'])
+		if ($data['list'])
 		{
-			$massage =& $data['list'];
+			$massage = & $data['list'];
 
-			for($i = 0; $i <  min(count($massage), $this->context['width']); $i++)
+			for ($i = 0; $i < min(count($massage), $this->context['width']); $i++)
 			{
-				$forecast =& $massage[$i];
-				$forecast['day'] = Api\DateTime::to($forecast['dt'],'l');
+				$forecast = & $massage[$i];
+				$forecast['day'] = Api\DateTime::to($forecast['dt'], 'l');
 				self::format_forecast($forecast);
 			}
 			// Chop data to fit into portlet
-			for($i; $i < count($massage); $i++)
+			for ($i; $i < count($massage); $i++)
 			{
 				unset($massage[$i]);
 			}
 		}
-		if($data['current'] && is_array($data['current']))
+		if ($data['current'] && is_array($data['current']))
 		{
 			// Current weather
 			$data['current']['temp'] = $data['current']['main'];
@@ -210,7 +210,7 @@ 
 
 		if ($data['list'])
 		{
-			$data['current']['temp'] = array_merge($data['current']['temp'],$data['list'][0]['temp']);
+			$data['current']['temp'] = array_merge($data['current']['temp'], $data['list'][0]['temp']);
 		}
 		return $data;
 	}
@@ -220,22 +220,22 @@ 
 	 */
 	protected static function format_forecast(&$data)
 	{
-		$weather =& $data['weather'] ? $data['weather'] : $data;
-		$temp =& $data['temp'] ? $data['temp'] : $data;
+		$weather = & $data['weather'] ? $data['weather'] : $data;
+		$temp = & $data['temp'] ? $data['temp'] : $data;
 
 		// Full URL for icon
-		if(is_array($weather))
+		if (is_array($weather))
 		{
-			foreach($weather as &$w)
+			foreach ($weather as &$w)
 			{
-				$w['icon'] = static::ICON_URL . $w['icon'].'.png';
+				$w['icon'] = static::ICON_URL.$w['icon'].'.png';
 			}
 		}
 
 		// Round
-		foreach(array('temp','temp_min','temp_max','min','max') as $temp_name)
+		foreach (array('temp', 'temp_min', 'temp_max', 'min', 'max') as $temp_name)
 		{
-			if(array_key_exists($temp_name, $temp))
+			if (array_key_exists($temp_name, $temp))
 			{
 				$temp[$temp_name] = ''.round($temp[$temp_name]);
 			}

Braces +12 added lines, -3 removed lines

@@ -36,7 +36,10 @@ 
 	 */
 	public function __construct(Array &$context = array(), &$need_reload = false)
 	{
-		if (false) parent::__construct();
+		if (false)
+		{
+			parent::__construct();
+		}
 
 		// City not set for new widgets created via context menu
 		if(!$context['city'] || $context['height'] < 2)
@@ -144,14 +147,20 @@ 
 		$data = Api\Cache::getTree('home', json_encode($query), function($query)
 		{
 			$debug = false;
-			if($debug) error_log('Fetching fresh data from ' . static::API_URL);
+			if($debug)
+			{
+				error_log('Fetching fresh data from ' . static::API_URL);
+			}
 
 			$url = static::API_URL.'forecast/daily?'. http_build_query($query);
 			$forecast = file_get_contents($url);
 
 			$url = static::API_URL.'weather?'. http_build_query($query);
 			$current = file_get_contents($url);
-			if($debug) error_log(__METHOD__ . ' current: ' . $current);
+			if($debug)
+			{
+				error_log(__METHOD__ . ' current: ' . $current);
+			}
 
 			return array_merge(array('current' => json_decode($current,true)), json_decode($forecast,true));
 		}, array($query), self::CACHE_TIME);

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -34,7 +34,7 @@ 
 	/**
 	 * Context for this portlet
 	 */
-	public function __construct(Array &$context = array(), &$need_reload = false)
+	public function __construct(array &$context = array(), &$need_reload = false)
 	{
 		if (false) parent::__construct();
 
@@ -130,7 +130,7 @@ 
 	 * @see http://openweathermap.org/api
 	 * @param array $query
 	 */
-	public function get_weather(Array $query, $api_url = '')
+	public function get_weather(array $query, $api_url = '')
 	{
 		static $debug = false;
 		if(!$api_url)

home/inc/class.home_birthday_portlet.inc.php

Indentation +8 added lines, -8 removed lines

@@ -1,13 +1,13 @@
 <?php
 /**
-  * Egroupware
-  * @license http://opensource.org/licenses/gpl-license.php GPL - GNU General Public License
-  * @package home
-  * @subpackage portlet
-  * @link http://www.egroupware.org
-  * @author Nathan Gray
-  * @version $Id$
-  */
+ * Egroupware
+ * @license http://opensource.org/licenses/gpl-license.php GPL - GNU General Public License
+ * @package home
+ * @subpackage portlet
+ * @link http://www.egroupware.org
+ * @author Nathan Gray
+ * @version $Id$
+ */
 
 use EGroupware\Api;
 use EGroupware\Api\Etemplate;

Spacing +19 added lines, -19 removed lines

@@ -31,7 +31,7 @@ 
 	 */
 	public function __construct(Array &$context = array(), &$need_reload = false)
 	{
-		unset($need_reload);	// not used, but required by function signature
+		unset($need_reload); // not used, but required by function signature
 		if (false) parent::__construct();
 
 		$this->context = $context;
@@ -64,7 +64,7 @@ 
 	 * 	unique, if needed.
 	 * @param etemplate Etemplate Etemplate to generate content
 	 */
-	public function exec($id = null, Etemplate &$etemplate = null)
+	public function exec($id = null, Etemplate&$etemplate = null)
 	{
 		$content = array();
 
@@ -76,7 +76,7 @@ 
 		}
 		$etemplate->set_dom_id($id);
 
-		$etemplate->exec('home.home_list_portlet.exec',$content);
+		$etemplate->exec('home.home_list_portlet.exec', $content);
 	}
 
 	/**
@@ -85,30 +85,30 @@ 
 	protected function get_birthdays()
 	{
 		$contacts = new Api\Contacts();
-		$month_start = date('-m-',$contacts->now_su);
+		$month_start = date('-m-', $contacts->now_su);
 		$days = $this->context['days'];
 		$birthdays = array();
 
-		$bdays =& $contacts->search(array('bday' => $month_start),array('id','n_family','n_given','bday'),'n_given,n_family','','%');
+		$bdays = & $contacts->search(array('bday' => $month_start), array('id', 'n_family', 'n_given', 'bday'), 'n_given,n_family', '', '%');
 		// search accounts too, if not stored in accounts repository
 		$extra_accounts_search = $contacts->account_repository == 'ldap' && !is_null($contacts->so_accounts) &&
 			!$GLOBALS['egw_info']['user']['preferences']['addressbook']['hide_accounts'];
-		if ($extra_accounts_search && ($bdays2 = $contacts->search(array('bday' => $month_start),array('id','n_family','n_given','bday'),
-			'n_given,n_family','','%',false,'AND',false,array('owner' => 0))))
+		if ($extra_accounts_search && ($bdays2 = $contacts->search(array('bday' => $month_start), array('id', 'n_family', 'n_given', 'bday'),
+			'n_given,n_family', '', '%', false, 'AND', false, array('owner' => 0))))
 		{
-			$bdays = !$bdays ? $bdays2 : array_merge($bdays,$bdays2);
+			$bdays = !$bdays ? $bdays2 : array_merge($bdays, $bdays2);
 		}
-		if (($month_end = date('-m-',$contacts->now_su+$days*24*3600)) != $month_start)
+		if (($month_end = date('-m-', $contacts->now_su + $days * 24 * 3600)) != $month_start)
 		{
-			if (($bdays2 =& $contacts->search(array('bday' => $month_end),array('id','n_family','n_given','bday'),'n_given,n_family','','%')))
+			if (($bdays2 = & $contacts->search(array('bday' => $month_end), array('id', 'n_family', 'n_given', 'bday'), 'n_given,n_family', '', '%')))
 			{
-				$bdays = !$bdays ? $bdays2 : array_merge($bdays,$bdays2);
+				$bdays = !$bdays ? $bdays2 : array_merge($bdays, $bdays2);
 			}
 			// search accounts too, if not stored in accounts repository
-			if ($extra_accounts_search && ($bdays2 = $contacts->search(array('bday' => $month_end),array('id','n_family','n_given','bday'),
-				'n_given,n_family','','%',false,'AND',false,array('owner' => 0))))
+			if ($extra_accounts_search && ($bdays2 = $contacts->search(array('bday' => $month_end), array('id', 'n_family', 'n_given', 'bday'),
+				'n_given,n_family', '', '%', false, 'AND', false, array('owner' => 0))))
 			{
-				$bdays = !$bdays ? $bdays2 : array_merge($bdays,$bdays2);
+				$bdays = !$bdays ? $bdays2 : array_merge($bdays, $bdays2);
 			}
 		}
 		unset($bdays2); unset($extra_accounts_search);
@@ -116,15 +116,15 @@ 
 		if ($bdays)
 		{
 			$ab_lang_loaded = 0;
-			for($n = 0; $n <= $days; ++$n)
+			for ($n = 0; $n <= $days; ++$n)
 			{
-				$day = date('-m-d',$contacts->now_su+$n*24*3600);
-				foreach($bdays as $contact)
+				$day = date('-m-d', $contacts->now_su + $n * 24 * 3600);
+				foreach ($bdays as $contact)
 				{
-					if(substr($contact['bday'],-6) == $day)
+					if (substr($contact['bday'], -6) == $day)
 					{
 						if (!$ab_lang_loaded++) Api\Translation::add_app('addressbook');
-						switch($n)
+						switch ($n)
 						{
 							case 0:
 								$text = lang("Today is %1's birthday!", $contact['n_given'].' '.$contact['n_family']);

Braces +13 added lines, -4 removed lines

@@ -17,7 +17,7 @@ 
   *
   */
  class home_birthday_portlet extends home_portlet
-{
+ {
 	/**
 	 * Constructor sets up the portlet according to the user's saved property values
 	 * for this particular portlet.  It is possible to have multiple instances of the
@@ -32,7 +32,10 @@ 
 	public function __construct(Array &$context = array(), &$need_reload = false)
 	{
 		unset($need_reload);	// not used, but required by function signature
-		if (false) parent::__construct();
+		if (false)
+		{
+			parent::__construct();
+		}
 
 		$this->context = $context;
 	}
@@ -70,10 +73,13 @@ 
 
 		$etemplate->read('home.birthdays');
 
-		if ($GLOBALS['egw_info']['server']['hide_birthdays'] != 'yes')	// calendar Api\Config
+		if ($GLOBALS['egw_info']['server']['hide_birthdays'] != 'yes')
+		{
+			// calendar Api\Config
 		{
 			$content = $this->get_birthdays();
 		}
+		}
 		$etemplate->set_dom_id($id);
 
 		$etemplate->exec('home.home_list_portlet.exec',$content);
@@ -123,7 +129,10 @@ 
 				{
 					if(substr($contact['bday'],-6) == $day)
 					{
-						if (!$ab_lang_loaded++) Api\Translation::add_app('addressbook');
+						if (!$ab_lang_loaded++)
+						{
+							Api\Translation::add_app('addressbook');
+						}
 						switch($n)
 						{
 							case 0:

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
 	 *
 	 * @param boolean $need_reload Flag to indicate that the portlet needs to be reloaded (exec will be called)
 	 */
-	public function __construct(Array &$context = array(), &$need_reload = false)
+	public function __construct(array &$context = array(), &$need_reload = false)
 	{
 		if (false) parent::__construct();
 

home/inc/class.home_favorite_portlet.inc.php

Spacing +20 added lines, -20 removed lines

@@ -38,7 +38,7 @@ 
 	 */
 	protected $nm_settings = array(
 		'lettersearch'	=> false,
-		'favorites'		=> false,	// Hide favorite control
+		'favorites'		=> false, // Hide favorite control
 		'actions'		=> array(),
 		'placeholder_actions' => array()
 	);
@@ -62,9 +62,9 @@ 
 		if (false) parent::__construct();
 
 		// Process dropped data (Should be [appname => <appname>, id => <favorite ID>]) into something useable
-		if($context['dropped_data'])
+		if ($context['dropped_data'])
 		{
-			foreach((Array)$context['dropped_data'] as $dropped)
+			foreach ((Array)$context['dropped_data'] as $dropped)
 			{
 				// Only handle one, but dropped is an array
 				$context['appname'] = $dropped['appname'];
@@ -77,7 +77,7 @@ 
 			$need_reload = true;
 		}
 		// Favorite not set for new widgets created via context menu
-		if(!$context['favorite'])
+		if (!$context['favorite'])
 		{
 			// Set initial size to 6x3, default is way too small
 			$context['width'] = max($context['width'], 6);
@@ -87,7 +87,7 @@ 
 		}
 
 		// Load and copy favorite
-		if($context['favorite'] && !is_array($context['favorite']))
+		if ($context['favorite'] && !is_array($context['favorite']))
 		{
 			$favorites = Framework\Favorites::get_favorites($context['appname']);
 			$context['favorite'] = $favorites[$context['favorite']];
@@ -95,12 +95,12 @@ 
 		}
 
 		$this->favorite = $context['favorite'];
-		$this->title = lang($context['appname']) . ': ' . $this->favorite['name'];
+		$this->title = lang($context['appname']).': '.$this->favorite['name'];
 		$this->context = $context;
-		if($this->favorite)
+		if ($this->favorite)
 		{
 			$this->nm_settings['favorite'] = $this->context['favorite'];
-			if(is_array($this->favorite['state']))
+			if (is_array($this->favorite['state']))
 			{
 				$this->nm_settings += $this->favorite['state'];
 			}
@@ -110,9 +110,9 @@ 
 		Api\Translation::add_app($context['appname']);
 	}
 
-	public function exec($id = null, Etemplate &$etemplate = null)
+	public function exec($id = null, Etemplate&$etemplate = null)
 	{
-		if($etemplate == null)
+		if ($etemplate == null)
 		{
 			$etemplate = new Etemplate();
 		}
@@ -124,34 +124,34 @@ 
 		$content['header_node'] = "home-index_{$id}_header";
 		$sel_options = $content['sel_options'] ? $content['sel_options'] : array();
 		unset($content['sel_options']);
-		$etemplate->setElementAttribute('nm', 'template',$this->nm_settings['template']);
+		$etemplate->setElementAttribute('nm', 'template', $this->nm_settings['template']);
 
 
 		// Always load app's css
 		Framework::includeCSS($this->context['appname'], 'app-'.$GLOBALS['egw_info']['user']['preferences']['common']['theme']) ||
-			Framework::includeCSS($this->context['appname'],'app');
+			Framework::includeCSS($this->context['appname'], 'app');
 
 		// Always load app's javascript, so most actions have a chance of working
-		Framework::includeJS('.','app',$this->context['appname']);
+		Framework::includeJS('.', 'app', $this->context['appname']);
 
 		// Set this so app's JS gets initialized
 		$old_app = $GLOBALS['egw_info']['flags']['currentapp'];
 		$GLOBALS['egw_info']['flags']['currentapp'] = $this->context['appname'];
 
-		$etemplate->exec(get_called_class() .'::process',$content,$sel_options);
+		$etemplate->exec(get_called_class().'::process', $content, $sel_options);
 
 		$GLOBALS['egw_info']['flags']['currentapp'] = $old_app;
 	}
 
 	public static function process($content = array())
 	{
-		unset($content);	// not used, but required by function signature
+		unset($content); // not used, but required by function signature
 
 		// We need to keep the template going, thanks.
-		Etemplate\Widget::setElementAttribute('','','');
+		Etemplate\Widget::setElementAttribute('', '', '');
 	}
 
-	public function get_actions(){
+	public function get_actions() {
 		return array();
 	}
 
@@ -195,9 +195,9 @@ 
 		$properties = parent::get_properties();
 		$favorites = Framework\Favorites::get_favorites($this->context['appname']);
 		$favorite_list = array();
-		foreach($favorites as $id => $favorite)
+		foreach ($favorites as $id => $favorite)
 		{
-			if($favorite)
+			if ($favorite)
 			{
 				$favorite_list[$id] = $favorite['name'];
 			}
@@ -208,7 +208,7 @@ 
 			'type'	=>	'select',
 			'select_options' => $favorite_list
 		);
-		if($this->context['favorite'])
+		if ($this->context['favorite'])
 		{
 			$favorite['type'] = 'select_ro';
 		}

Braces +6 added lines, -2 removed lines

@@ -59,7 +59,10 @@ 
 	 */
 	public function __construct(Array &$context = array(), &$need_reload = false)
 	{
-		if (false) parent::__construct();
+		if (false)
+		{
+			parent::__construct();
+		}
 
 		// Process dropped data (Should be [appname => <appname>, id => <favorite ID>]) into something useable
 		if($context['dropped_data'])
@@ -151,7 +154,8 @@ 
 		Etemplate\Widget::setElementAttribute('','','');
 	}
 
-	public function get_actions(){
+	public function get_actions()
+	{
 		return array();
 	}
 

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
 	 *
 	 * @param boolean $need_reload Flag to indicate that the portlet needs to be reloaded (exec will be called)
 	 */
-	public function __construct(Array &$context = array(), &$need_reload = false)
+	public function __construct(array &$context = array(), &$need_reload = false)
 	{
 		if (false) parent::__construct();
 

home/inc/class.home_legacy_portlet.inc.php

Spacing +9 added lines, -9 removed lines

@@ -34,14 +34,14 @@ 
 
 	public function __construct(array &$context = array(), &$need_reload = false)
 	{
-		unset($need_reload);	// not used, but required by function signature
+		unset($need_reload); // not used, but required by function signature
 		if (false) parent::__construct();
 
 		$this->context = $context;
 
 		// Try to load content here, so all needed info is available
 		$appname = $this->context['app'];
-		if(!$appname || !Api\Hooks::exists('home', $appname))
+		if (!$appname || !Api\Hooks::exists('home', $appname))
 		{
 			return;
 		}
@@ -50,30 +50,30 @@ 
 
 		// Execute hook to get content
 		ob_start();
-		$_content = Api\Hooks::single('home',$appname);
+		$_content = Api\Hooks::single('home', $appname);
 		if (!$_content || $_content == 1)   // content has been echoed and not returned
 		{
 			$_content = ob_get_contents();
 			ob_end_clean();
 		}
-		if($_content)
+		if ($_content)
 		{
 			// Now we have to extract the actual content
 			$dom = new DOMDocument();
 			libxml_use_internal_errors(true);
-			$dom->loadHTML($_content,LIBXML_NOWARNING + LIBXML_NOERROR);
+			$dom->loadHTML($_content, LIBXML_NOWARNING + LIBXML_NOERROR);
 			$finder = new DOMXPath($dom);
 
 			// Find header for title
 			$title = $finder->query("//div[contains(@class,'divSideboxHeader')]/descendant::strong");
-			if($title->length)
+			if ($title->length)
 			{
 				$this->title = $title->item(0)->textContent;
 			}
 
 			// Remove header
 			$content = $finder->query("//div[contains(@class,'divSideboxHeader')]/descendant::strong/ancestor::tr");
-			for($i = 0; $i < $content->length; $i++)
+			for ($i = 0; $i < $content->length; $i++)
 			{
 				$content->item($i)->parentNode->removeChild($content->item($i));
 			}
@@ -95,13 +95,13 @@ 
 	 * 	unique, if needed.
 	 * @return string HTML fragment for display
 	 */
-	public function exec($id = null, Etemplate &$etemplate = null)
+	public function exec($id = null, Etemplate&$etemplate = null)
 	{
 		$etemplate->read('home.legacy');
 
 		$etemplate->set_dom_id($id);
 
-		$etemplate->exec('home.home_link_portlet.exec',array('legacy' => $this->content), array(),array(),array(),2);
+		$etemplate->exec('home.home_link_portlet.exec', array('legacy' => $this->content), array(), array(), array(), 2);
 	}
 
 	/**

Braces +8 added lines, -2 removed lines

@@ -35,7 +35,10 @@ 
 	public function __construct(array &$context = array(), &$need_reload = false)
 	{
 		unset($need_reload);	// not used, but required by function signature
-		if (false) parent::__construct();
+		if (false)
+		{
+			parent::__construct();
+		}
 
 		$this->context = $context;
 
@@ -51,9 +54,12 @@ 
 		// Execute hook to get content
 		ob_start();
 		$_content = Api\Hooks::single('home',$appname);
-		if (!$_content || $_content == 1)   // content has been echoed and not returned
+		if (!$_content || $_content == 1)
+		{
+			// content has been echoed and not returned
 		{
 			$_content = ob_get_contents();
+		}
 			ob_end_clean();
 		}
 		if($_content)

home/inc/class.home_link_portlet.inc.php

Spacing +24 added lines, -24 removed lines

@@ -54,13 +54,13 @@ 
 		if (false) parent::__construct();
 
 		// Process dropped data into something useable
-		if($context['dropped_data'])
+		if ($context['dropped_data'])
 		{
 			list($context['entry']['app'], $context['entry']['id']) = explode('::', $context['dropped_data'][0], 2);
 			unset($context['dropped_data']);
 			$need_reload = true;
 		}
-		if($context['entry'] && is_array($context['entry']))
+		if ($context['entry'] && is_array($context['entry']))
 		{
 			$this->title = $context['entry']['title'] = Link::title($context['entry']['app'], $context['entry']['id']);
 
@@ -97,12 +97,12 @@ 
 	 * @param id String unique ID, provided to the portlet so it can make sure content is
 	 * 	unique, if needed.
 	 */
-	public function exec($id = null, Etemplate &$etemplate = null)
+	public function exec($id = null, Etemplate&$etemplate = null)
 	{
 		// Check for custom template for app
 		$custom_template = false;
-		if($this->context && $this->context['entry'] && $this->context['entry']['app'] &&
-			$etemplate->read($this->context['entry']['app'] . '.' . $this->template_name))
+		if ($this->context && $this->context['entry'] && $this->context['entry']['app'] &&
+			$etemplate->read($this->context['entry']['app'].'.'.$this->template_name))
 		{
 			// No action needed, custom template loaded as side-effect
 			$custom_template = true;
@@ -120,50 +120,50 @@ 
 		);
 
 		// Try to load entry
-		if($this->context['entry'] && $this->context['entry']['app'])
+		if ($this->context['entry'] && $this->context['entry']['app'])
 		{
 
 			// Always load app's css
 			Framework::includeCSS($this->context['entry']['app'], 'app-'.$GLOBALS['egw_info']['user']['preferences']['common']['theme']) ||
-				Framework::includeCSS($this->context['entry']['app'],'app');
+				Framework::includeCSS($this->context['entry']['app'], 'app');
 
 			try
 			{
-				$classname = $this->context['entry']['app'] . '_egw_record';
-				if(class_exists($classname))
+				$classname = $this->context['entry']['app'].'_egw_record';
+				if (class_exists($classname))
 				{
 					$record = new $classname($this->context['entry']['id']);
-					if($record && $record->get_record_array())
+					if ($record && $record->get_record_array())
 					{
 						// If there's a custom template, send the full record
-						if($custom_template)
+						if ($custom_template)
 						{
 							$content += $record->get_record_array();
 						}
 						// Use calendar hover for calendar
-						if($this->context['entry']['app'] == 'calendar')
+						if ($this->context['entry']['app'] == 'calendar')
 						{
-							$etemplate->setElementAttribute('tooltip','class', 'tooltip calendar_uitooltip');
+							$etemplate->setElementAttribute('tooltip', 'class', 'tooltip calendar_uitooltip');
 						}
-						if($content['image'] == false)
+						if ($content['image'] == false)
 						{
 							$content['image'] = $record->get_icon();
 						}
 					}
 				}
 			}
-			catch(Exception $e)
+			catch (Exception $e)
 			{
-				error_log("Problem loading record " . array2string($this->context['entry']));
+				error_log("Problem loading record ".array2string($this->context['entry']));
 				throw $e;
 			}
 
 			// Set a fallback image
-			if($content['image'] == false)
+			if ($content['image'] == false)
 			{
-				if($this->context['entry'] && $this->context['entry']['app'])
+				if ($this->context['entry'] && $this->context['entry']['app'])
 				{
-					$content['image'] = $this->context['entry']['app'] . '/navbar';
+					$content['image'] = $this->context['entry']['app'].'/navbar';
 				}
 				else
 				{
@@ -173,22 +173,22 @@ 
 		}
 
 		// Filemanager support - links need app = 'file' and type set
-		if($this->context && $this->context['entry'] && $this->context['entry']['app'] == 'filemanager')
+		if ($this->context && $this->context['entry'] && $this->context['entry']['app'] == 'filemanager')
 		{
 			$this->context['entry']['app'] = 'file';
 			$this->context['entry']['path'] = $this->context['entry']['title'] = $this->context['entry']['id'];
 			$this->context['entry']['type'] = Vfs::mime_content_type($this->context['entry']['id']);
-			$content['image'] = Framework::link('/api/thumbnail.php',array('path' => $this->context['entry']['id']));
+			$content['image'] = Framework::link('/api/thumbnail.php', array('path' => $this->context['entry']['id']));
 		}
 
 		$content += $this->context;
 
-		if(!is_array($content['entry']))
+		if (!is_array($content['entry']))
 		{
 			$content['entry'] = null;
 		}
 
-		$etemplate->exec('home.home_link_portlet.exec',$content);
+		$etemplate->exec('home.home_link_portlet.exec', $content);
 	}
 
 	/**
@@ -252,6 +252,6 @@ 
 	 */
 	public function accept_drop()
 	{
-		return array('file','link');
+		return array('file', 'link');
 	}
 }

Doc Comments +1 added lines, -1 removed lines

@@ -198,7 +198,7 @@
 	/**
 	 * This portlet accepts files and links
 	 *
-	 * @return boolean|String[]
+	 * @return string[]
 	 */
 	public function accept_drop()
 	{

Braces +4 added lines, -1 removed lines

@@ -51,7 +51,10 @@
 	 */
 	public function __construct(Array &$context = array(), &$need_reload = false)
 	{
-		if (false) parent::__construct();
+		if (false)
+		{
+			parent::__construct();
+		}
 
 		// Process dropped data into something useable
 		if($context['dropped_data'])

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
 	 *
 	 * @param boolean $need_reload Flag to indicate that the portlet needs to be reloaded (exec will be called)
 	 */
-	public function __construct(Array &$context = array(), &$need_reload = false)
+	public function __construct(array &$context = array(), &$need_reload = false)
 	{
 		if (false) parent::__construct();
 

home/index.php

Spacing +1 added lines, -1 removed lines

@@ -19,7 +19,7 @@
 );
 
 include('../header.inc.php');
-$GLOBALS['egw_info']['flags']['nonavbar']=false;
+$GLOBALS['egw_info']['flags']['nonavbar'] = false;
 
 // Home is treated specially, so a redirect won't work.
 $home = new home_ui();

calendar/inc/class.calendar_wizard_export_csv.inc.php

Spacing +1 added lines, -1 removed lines

@@ -47,7 +47,7 @@
                 );
 
 		$custom = Api\Storage\Customfields::get('resources', true);
-		foreach($custom as $name => $data) {
+		foreach ($custom as $name => $data) {
 			$this->mapping_fields['#'.$name] = $data['label'];
 		}
 

Braces +4 added lines, -2 removed lines

@@ -14,7 +14,8 @@ 
 
 class infolog_wizard_export_csv extends importexport_wizard_basic_export_csv
 {
-	public function __construct() {
+	public function __construct()
+	{
 		parent::__construct();
 
 		// Field mapping
@@ -27,7 +28,8 @@ 
 		// Custom fields
 		unset($this->export_fields['custom']); // Heading, not a real field
 		$custom = Api\Storage\Customfields::get('infolog', true);
-		foreach($custom as $name => $data) {
+		foreach($custom as $name => $data)
+		{
 			$this->export_fields['#'.$name] = $data['label'];
 		}
 	}

api/src/Json/Exception/InvalidName.php

Braces +3 added lines, -1 removed lines

@@ -20,4 +20,6 @@
  *
  * As you get this only by an error in the code or during development, the message does not need to be translated
  */
-class InvalidName extends Exception\NoPermission { }
+class InvalidName extends Exception\NoPermission
+{
+}