EGroupware / egroupware

mail/inc/class.mail_zpush.inc.php

Doc Comments +3 added lines, -3 removed lines

@@ -1305,7 +1305,7 @@ 
 	 * @param string              $newfolderid         id of the destination folder
 	 * @param ContentParameters   $contentParameters
 	 *
-	 * @return boolean                      status of the operation
+	 * @return string                      status of the operation
 	 * @throws StatusException              could throw specific SYNC_MOVEITEMSSTATUS_* exceptions
 	 */
 	public function MoveMessage($folderid, $id, $newfolderid, $contentParameters)
@@ -1832,7 +1832,7 @@ 
 	 * @param string $displayname => new folder name (to be created, or to be renamed to)
 	 * @param string $type folder type, ignored in IMAP
 	 *
-	 * @return array|boolean stat array or false on error
+	 * @return boolean stat array or false on error
 	 */
 	public function ChangeFolder($id, $oldid, $displayname, $type)
 	{
@@ -1847,7 +1847,7 @@ 
 	 * @param string $id of the folder to delete
 	 *
 	 * @return
-	 * @TODO check what is to be returned
+	 boolean @TODO check what is to be returned
 	 */
 	public function DeleteFolder($parentid, $id)
 	{

Indentation +105 added lines, -105 removed lines

@@ -296,44 +296,44 @@ 
 		return $folderlist;
 	}
 
-    /**
-     * Sends a message which is passed as rfc822. You basically can do two things
-     * 1) Send the message to an SMTP server as-is
-     * 2) Parse the message yourself, and send it some other way
-     * It is up to you whether you want to put the message in the sent items folder. If you
-     * want it in 'sent items', then the next sync on the 'sent items' folder should return
-     * the new message as any other new message in a folder.
-     *
-     * @param array $smartdata = IMAP-SendMail: SyncSendMail (
-     *        (S) clientid => SendMail-30722448149304
-     *        (S) saveinsent => empty
-     *        (S) replacemime => null
-     *        (S) accountid => null
-     *        (S) source => SyncSendMailSource (
-     *                                (S) folderid => 101000000000
-     *                                (S) itemid => 33776
-     *                                (S) longid => null
-     *                                (S) instanceid => null
-     *                                unsetVars(Array) size: 0
-     *                                flags => false
-     *                                content => null
-     *                        )
-     *        (S) mime => Date: Tue, 23 Jun 2015 14:13:23 +0200
-     *Subject: AW: Blauer himmel
-     *....
-     *        (S) replyflag => true
-     *        (S) forwardflag => null
-     *        unsetVars(Array) size: 0
-     *        flags => false
-     *        content => null
-     *)
+	/**
+	 * Sends a message which is passed as rfc822. You basically can do two things
+	 * 1) Send the message to an SMTP server as-is
+	 * 2) Parse the message yourself, and send it some other way
+	 * It is up to you whether you want to put the message in the sent items folder. If you
+	 * want it in 'sent items', then the next sync on the 'sent items' folder should return
+	 * the new message as any other new message in a folder.
+	 *
+	 * @param array $smartdata = IMAP-SendMail: SyncSendMail (
+	 *        (S) clientid => SendMail-30722448149304
+	 *        (S) saveinsent => empty
+	 *        (S) replacemime => null
+	 *        (S) accountid => null
+	 *        (S) source => SyncSendMailSource (
+	 *                                (S) folderid => 101000000000
+	 *                                (S) itemid => 33776
+	 *                                (S) longid => null
+	 *                                (S) instanceid => null
+	 *                                unsetVars(Array) size: 0
+	 *                                flags => false
+	 *                                content => null
+	 *                        )
+	 *        (S) mime => Date: Tue, 23 Jun 2015 14:13:23 +0200
+	 *Subject: AW: Blauer himmel
+	 *....
+	 *        (S) replyflag => true
+	 *        (S) forwardflag => null
+	 *        unsetVars(Array) size: 0
+	 *        flags => false
+	 *        content => null
+	 *)
 	 *
-     * @return boolean true on success, false on error
-     *
-     * @see eg. BackendIMAP::SendMail()
-     * @todo implement either here or in mail backend
-     * 	(maybe sending here and storing to sent folder in plugin, as sending is supposed to always work in EGroupware)
-     */
+	 * @return boolean true on success, false on error
+	 *
+	 * @see eg. BackendIMAP::SendMail()
+	 * @todo implement either here or in mail backend
+	 * 	(maybe sending here and storing to sent folder in plugin, as sending is supposed to always work in EGroupware)
+	 */
 	public function SendMail($smartdata)
 	{
 		//$this->debugLevel=2;
@@ -456,8 +456,8 @@ 
 		//error_log(__METHOD__.__LINE__.array2string($mailObject));
 		// if this is a multipart message with a boundary, we must use the original body
 		//if ($this->debugLevel>2) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' mailObject after Inital Parse:'.array2string($mailObject));
-        if ($use_orgbody) {
-    	    ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__.") use_orgbody = true ContentType:".$ContentType);
+		if ($use_orgbody) {
+			ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__.") use_orgbody = true ContentType:".$ContentType);
  			// if it is a ClientSideMeetingRequest, we report it as send at all times
 			if (($cal_body = $mailObject->findBody('calendar')) &&
 				($cSMRMethod = $cal_body->getContentTypeParameter('method')))
@@ -469,7 +469,7 @@ 
 				if ($this->debugLevel) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__.") we have a Client Side Meeting Request from organizer=$organizer");
 				$ClientSideMeetingRequest = true;
 			}
-        }
+		}
 		// now handle the addressee list
 		$toCount = 0;
 		//error_log(__METHOD__.__LINE__.array2string($toMailAddr));
@@ -559,7 +559,7 @@ 
 			$bodyStruct = $this->mail->getMessageBody($uid, 'html_only');
 			$bodyBUFFHtml = $this->mail->getdisplayableBody($this->mail,$bodyStruct,true,false);
 			if ($this->debugLevel>3) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' html_only:'.$bodyBUFFHtml);
-		    if ($bodyBUFFHtml != "" && (is_array($bodyStruct) && $bodyStruct[0]['mimeType']=='text/html')) {
+			if ($bodyBUFFHtml != "" && (is_array($bodyStruct) && $bodyStruct[0]['mimeType']=='text/html')) {
 				// may be html
 				if ($this->debugLevel>0) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__.") MIME Body".' Type:html (fetched with html_only):'.$bodyBUFFHtml);
 				$AltBody = $AltBody."</br>".$bodyBUFFHtml.$sigTextHtml;
@@ -606,7 +606,7 @@ 
 			$this->splitID($smartdata->source->folderid, $account, $folder);
 
 			$this->mail->reopen($folder);
-            // receive entire mail (header + body)
+			// receive entire mail (header + body)
 			// get message headers for specified message
 			$headers	= $this->mail->getMessageEnvelope($uid, $_partID, true, $folder);
 			// build a new mime message, forward entire old mail as file
@@ -690,7 +690,7 @@ 
 		}
 		//advanced debugging
 		// Horde SMTP Class uses utf-8 by default.
-        //debugLog("IMAP-SendMail: parsed message: ". print_r($message,1));
+		//debugLog("IMAP-SendMail: parsed message: ". print_r($message,1));
 		if ($this->debugLevel>2) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__."): MailObject:".array2string($mailObject));
 
 		// set a higher timeout for big messages
@@ -783,7 +783,7 @@ 
 						//$asf = false;
 						ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.'->'.lang("Import of message %1 failed. Destination Folder %2 does not exist.",$mailObject->getHeader('Subject'),$folderName));
 					}
-			        ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__."): Outgoing mail saved in configured 'Sent' folder '".$folderName."': ". (($asf)?"success":"failed"));
+					ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__."): Outgoing mail saved in configured 'Sent' folder '".$folderName."': ". (($asf)?"success":"failed"));
 				}
 				//$this->mail->closeConnection();
 			}
@@ -991,7 +991,7 @@ 
 					$output->asbody->type = 1;
 					$output->nativebodytype = 1;
 					if(isset($truncsize) &&
-			    		strlen($plainBody) > $truncsize)
+						strlen($plainBody) > $truncsize)
 					{
 						$plainBody = Utils::Utf8_truncate($plainBody, $truncsize);
 						$output->asbody->truncated = 1;
@@ -1125,8 +1125,8 @@ 
 			// end handle Attachments
 			unset($attachments);
 
-            // Language Code Page ID: http://msdn.microsoft.com/en-us/library/windows/desktop/dd317756%28v=vs.85%29.aspx
-            $output->internetcpid = INTERNET_CPID_UTF8;
+			// Language Code Page ID: http://msdn.microsoft.com/en-us/library/windows/desktop/dd317756%28v=vs.85%29.aspx
+			$output->internetcpid = INTERNET_CPID_UTF8;
 
 			if ($this->debugLevel>3) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.array2string($output));
 //$this->debugLevel=0;
@@ -1184,8 +1184,8 @@ 
 	 * the exact string that is returned in the 'AttName' property of an SyncAttachment. So, you should
 	 * encode any information you need to find the attachment in that 'attname' property.
 	 *
-     * @param string $fid - id
-     * @param string $attname - should contain (folder)id
+	 * @param string $fid - id
+	 * @param string $attname - should contain (folder)id
 	 * @return true, prints the content of the attachment
 	 */
 	function GetAttachmentData($fid,$attname) {
@@ -1199,16 +1199,16 @@ 
 
 		$this->mail->reopen($folder);
 		$attachment = $this->mail->getAttachment($id,$part,0,false,true,$folder);
-        $SIOattachment = new SyncItemOperationsAttachment();
+		$SIOattachment = new SyncItemOperationsAttachment();
 		fseek($attachment['attachment'], 0, SEEK_SET);	// z-push requires stream seeked to start
-        $SIOattachment->data = $attachment['attachment'];
+		$SIOattachment->data = $attachment['attachment'];
 		//ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.": $fid (attname: '$attname') Data:".$attachment['attachment']);
-        if (isset($attachment['type']) )
-            $SIOattachment->contenttype = $attachment['type'];
+		if (isset($attachment['type']) )
+			$SIOattachment->contenttype = $attachment['type'];
 
 		unset($attachment);
 
-        return $SIOattachment;
+		return $SIOattachment;
 	}
 
 	/**
@@ -1217,8 +1217,8 @@ 
 	 * the exact string that is returned in the 'AttName' property of an SyncAttachment. So, you should
 	 * encode any information you need to find the attachment in that 'attname' property.
 	 *
-     * @param string $fid - id
-     * @param string $attname - should contain (folder)id
+	 * @param string $fid - id
+	 * @param string $attname - should contain (folder)id
 	 * @return SyncItemOperationsAttachment-object
 	 */
 	function ItemOperationsGetAttachmentData($fid,$attname) {
@@ -1232,15 +1232,15 @@ 
 
 		$this->mail->reopen($folder);
 		$attachment = $this->mail->getAttachment($id,$part,0,false,true,$folder);
-        $SIOattachment = new SyncItemOperationsAttachment();
+		$SIOattachment = new SyncItemOperationsAttachment();
 		fseek($attachment['attachment'], 0, SEEK_SET);	// z-push requires stream seeked to start
-        $SIOattachment->data = $attachment['attachment'];
-        if (isset($attachment['type']) )
-            $SIOattachment->contenttype = $attachment['type'];
+		$SIOattachment->data = $attachment['attachment'];
+		if (isset($attachment['type']) )
+			$SIOattachment->contenttype = $attachment['type'];
 
 		unset($attachment);
 
-        return $SIOattachment;
+		return $SIOattachment;
 	}
 
 	/**
@@ -1702,21 +1702,21 @@ 
 		$account = $folder = null;
 		$this->splitID($folderid, $account, $folder);
 		if (is_numeric($account)) $type = 'mail';
-        ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.": on $folderid -> $folder ($account) type: ". $type);
+		ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.": on $folderid -> $folder ($account) type: ". $type);
 		if ($type != 'mail') return false;
 
 		if (!isset($this->mail)) $this->mail = Mail::getInstance(false,self::$profileID,true,false,true);
 
 		$changes = array();
-        ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.": on $folderid ($folder) stat: ". $syncstate);
-        $this->mail->reopen($folder);
-        $status = $this->mail->getFolderStatus($folder,$ignoreStatusCache=true);
-        if (!$status) {
-            ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.": could not stat folder $folder ");
-            return false;
-        } else {
-            $syncstate = "M:". $status['messages'] ."-R:". $status['recent'] ."-U:". $status['unseen']."-NUID:".$status['uidnext']."-UIDV:".$status['uidvalidity'];
-        }
+		ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.": on $folderid ($folder) stat: ". $syncstate);
+		$this->mail->reopen($folder);
+		$status = $this->mail->getFolderStatus($folder,$ignoreStatusCache=true);
+		if (!$status) {
+			ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.": could not stat folder $folder ");
+			return false;
+		} else {
+			$syncstate = "M:". $status['messages'] ."-R:". $status['recent'] ."-U:". $status['unseen']."-NUID:".$status['uidnext']."-UIDV:".$status['uidvalidity'];
+		}
 		ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.' called with ('.$folderid.', ....) returning '.array2string($syncstate));
 		return $changes;
 	}
@@ -1735,22 +1735,22 @@ 
 		return $id;
 	}
 
-    /**
-     * Called when the user has requested to delete (really delete) a message. Usually
-     * this means just unlinking the file its in or somesuch. After this call has succeeded, a call to
-     * GetMessageList() should no longer list the message. If it does, the message will be re-sent to the mobile
-     * as it will be seen as a 'new' item. This means that if this method is not implemented, it's possible to
-     * delete messages on the PDA, but as soon as a sync is done, the item will be resynched to the mobile
-     *
-     * @param string              $folderid             id of the folder
-     * @param string              $id                   id of the message
-     * @param ContentParameters   $contentParameters
-     *
-     * @access public
-     * @return boolean                      status of the operation
-     * @throws StatusException              could throw specific SYNC_STATUS_* exceptions
-     */
-    public function DeleteMessage($folderid, $id, $contentParameters)
+	/**
+	 * Called when the user has requested to delete (really delete) a message. Usually
+	 * this means just unlinking the file its in or somesuch. After this call has succeeded, a call to
+	 * GetMessageList() should no longer list the message. If it does, the message will be re-sent to the mobile
+	 * as it will be seen as a 'new' item. This means that if this method is not implemented, it's possible to
+	 * delete messages on the PDA, but as soon as a sync is done, the item will be resynched to the mobile
+	 *
+	 * @param string              $folderid             id of the folder
+	 * @param string              $id                   id of the message
+	 * @param ContentParameters   $contentParameters
+	 *
+	 * @access public
+	 * @return boolean                      status of the operation
+	 * @throws StatusException              could throw specific SYNC_STATUS_* exceptions
+	 */
+	public function DeleteMessage($folderid, $id, $contentParameters)
 	{
 		unset($contentParameters);	// not used, but required by function signature
 		debugLog("IMAP-DeleteMessage: (fid: '$folderid'  id: '$id' )");
@@ -1792,24 +1792,24 @@ 
 		return $rv;
 	}
 
-    /**
-     * Changes the 'read' flag of a message on disk. The $flags
-     * parameter can only be '1' (read) or '0' (unread). After a call to
-     * SetReadFlag(), GetMessageList() should return the message with the
-     * new 'flags' but should not modify the 'mod' parameter. If you do
-     * change 'mod', simply setting the message to 'read' on the mobile will trigger
-     * a full resync of the item from the server.
-     *
-     * @param string              $folderid            id of the folder
-     * @param string              $id                  id of the message
-     * @param int                 $flags               read flag of the message
-     * @param ContentParameters   $contentParameters
-     *
-     * @access public
-     * @return boolean                      status of the operation
-     * @throws StatusException              could throw specific SYNC_STATUS_* exceptions
-     */
-    public function SetReadFlag($folderid, $id, $flags, $contentParameters)
+	/**
+	 * Changes the 'read' flag of a message on disk. The $flags
+	 * parameter can only be '1' (read) or '0' (unread). After a call to
+	 * SetReadFlag(), GetMessageList() should return the message with the
+	 * new 'flags' but should not modify the 'mod' parameter. If you do
+	 * change 'mod', simply setting the message to 'read' on the mobile will trigger
+	 * a full resync of the item from the server.
+	 *
+	 * @param string              $folderid            id of the folder
+	 * @param string              $id                  id of the message
+	 * @param int                 $flags               read flag of the message
+	 * @param ContentParameters   $contentParameters
+	 *
+	 * @access public
+	 * @return boolean                      status of the operation
+	 * @throws StatusException              could throw specific SYNC_STATUS_* exceptions
+	 */
+	public function SetReadFlag($folderid, $id, $flags, $contentParameters)
 	{
 		unset($contentParameters);	// not used, but required by function signature
 		// debugLog("IMAP-SetReadFlag: (fid: '$folderid'  id: '$id'  flags: '$flags' )");

Spacing +355 added lines, -356 removed lines

@@ -87,23 +87,23 @@ 
 		$this->backend = $backend;
 		if (!isset($GLOBALS['egw_info']['user']['preferences']['activesync']['mail-ActiveSyncProfileID']))
 		{
-			if ($this->debugLevel>1) error_log(__METHOD__.__LINE__.' Noprefs set: using 0 as default');
+			if ($this->debugLevel > 1) error_log(__METHOD__.__LINE__.' Noprefs set: using 0 as default');
 			// globals preferences add appname varname value
-			$GLOBALS['egw']->preferences->add('activesync','mail-ActiveSyncProfileID',0,'user');
+			$GLOBALS['egw']->preferences->add('activesync', 'mail-ActiveSyncProfileID', 0, 'user');
 			// save prefs
 			$GLOBALS['egw']->preferences->save_repository(true);
 		}
-		if ($this->debugLevel>1) error_log(__METHOD__.__LINE__.' ActiveProfileID:'.array2string(self::$profileID));
+		if ($this->debugLevel > 1) error_log(__METHOD__.__LINE__.' ActiveProfileID:'.array2string(self::$profileID));
 
 		if (is_null(self::$profileID))
 		{
-			if ($this->debugLevel>1) error_log(__METHOD__.__LINE__.' self::ProfileID isNUll:'.array2string(self::$profileID));
-			self::$profileID =& Api\Cache::getSession('mail','activeSyncProfileID');
-			if ($this->debugLevel>1) error_log(__METHOD__.__LINE__.' ActiveProfileID (after reading Cache):'.array2string(self::$profileID));
+			if ($this->debugLevel > 1) error_log(__METHOD__.__LINE__.' self::ProfileID isNUll:'.array2string(self::$profileID));
+			self::$profileID = & Api\Cache::getSession('mail', 'activeSyncProfileID');
+			if ($this->debugLevel > 1) error_log(__METHOD__.__LINE__.' ActiveProfileID (after reading Cache):'.array2string(self::$profileID));
 		}
 		if (isset($GLOBALS['egw_info']['user']['preferences']['activesync']['mail-ActiveSyncProfileID']))
 		{
-			if ($this->debugLevel>1) error_log(__METHOD__.__LINE__.' Pref for ProfileID:'.array2string($GLOBALS['egw_info']['user']['preferences']['activesync']['mail-ActiveSyncProfileID']));
+			if ($this->debugLevel > 1) error_log(__METHOD__.__LINE__.' Pref for ProfileID:'.array2string($GLOBALS['egw_info']['user']['preferences']['activesync']['mail-ActiveSyncProfileID']));
 			if ($GLOBALS['egw_info']['user']['preferences']['activesync']['mail-ActiveSyncProfileID'] == 'G')
 			{
 				self::$profileID = 'G'; // this should trigger the fetch of the first negative profile (or if no negative profile is available the firstb there is)
@@ -113,7 +113,7 @@ 
 				self::$profileID = (int)$GLOBALS['egw_info']['user']['preferences']['activesync']['mail-ActiveSyncProfileID'];
 			}
 		}
-		if ($this->debugLevel>1) error_log(__METHOD__.__LINE__.' Profile Selected (after reading Prefs):'.array2string(self::$profileID));
+		if ($this->debugLevel > 1) error_log(__METHOD__.__LINE__.' Profile Selected (after reading Prefs):'.array2string(self::$profileID));
 
 		// verify we are on an existing profile, if not running in setup (settings can not be static according to interface!)
 		if (!isset($GLOBALS['egw_setup']))
@@ -121,12 +121,12 @@ 
 			try {
 				Mail\Account::read(self::$profileID);
 			}
-			catch(Exception $e) {
+			catch (Exception $e) {
 				unset($e);
 				self::$profileID = Mail\Account::get_default_acc_id();
 			}
 		}
-		if ($this->debugLevel>0) error_log(__METHOD__.'::'.__LINE__.' ProfileSelected:'.self::$profileID);
+		if ($this->debugLevel > 0) error_log(__METHOD__.'::'.__LINE__.' ProfileSelected:'.self::$profileID);
 		//$this->debugLevel=0;
 	}
 
@@ -198,13 +198,13 @@ 
 			$this->__construct($this->backend);
 
 			try {
-				$this->_connect(0,true);
+				$this->_connect(0, true);
 				$this->_disconnect();
 
 				if (!$this->_wasteID) $errors[] = lang('No valid %1 folder configured!', '<b>'.lang('trash').'</b>');
 				if (!$this->_sentID) $errors[] = lang('No valid %1 folder configured!', '<b>'.lang('send').'</b>');
 			}
-			catch(Exception $e) {
+			catch (Exception $e) {
 				$errors[] = lang('Can not open IMAP connection').': '.$e->getMessage();
 			}
 			if ($errors)
@@ -222,7 +222,7 @@ 
 	 * @param int $account integer id of account to use
 	 * @todo support different accounts
 	 */
-	private function _connect($account=0)
+	private function _connect($account = 0)
 	{
 		if (!$account) $account = self::$profileID ? self::$profileID : 0;
 		if ($this->mail && $this->account != $account) $this->_disconnect();
@@ -235,7 +235,7 @@ 
 			$this->account = $account;
 			// todo: tell mail which account to use
 			//error_log(__METHOD__.__LINE__.' create object with ProfileID:'.array2string(self::$profileID));
-			$this->mail = Mail::getInstance(false,self::$profileID,true,false,true);
+			$this->mail = Mail::getInstance(false, self::$profileID, true, false, true);
 			if (self::$profileID == 0 && isset($this->mail->icServer->ImapServerId) && !empty($this->mail->icServer->ImapServerId)) self::$profileID = $this->mail->icServer->ImapServerId;
 		}
 		else
@@ -243,7 +243,7 @@ 
 			//error_log(__METHOD__.__LINE__." connect with profileID: ".self::$profileID);
 			if (self::$profileID == 0 && isset($this->mail->icServer->ImapServerId) && !empty($this->mail->icServer->ImapServerId)) self::$profileID = $this->mail->icServer->ImapServerId;
 		}
-		$this->mail->openConnection(self::$profileID,false);
+		$this->mail->openConnection(self::$profileID, false);
 
 		$this->_wasteID = $this->mail->getTrashFolder(false);
 		//error_log(__METHOD__.__LINE__.' TrashFolder:'.$this->_wasteID);
@@ -258,7 +258,7 @@ 
 	 */
 	private function _disconnect()
 	{
-		if ($this->debugLevel>0) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__);
+		if ($this->debugLevel > 0) ZLog::Write(LOGLEVEL_DEBUG, __METHOD__);
 		if ($this->mail) $this->mail->closeConnection();
 
 		unset($this->mail);
@@ -274,24 +274,24 @@ 
 	public function GetFolderList()
 	{
 		$folderlist = array();
-		if ($this->debugLevel>0) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__);
+		if ($this->debugLevel > 0) ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__);
 		/*foreach($available_accounts as $account)*/ $account = 0;
 		{
 			$this->_connect($account);
-			if (!isset($this->folders)) $this->folders = $this->mail->getFolderObjects(true,false,$_alwaysGetDefaultFolders=true);
-			if ($this->debugLevel>1) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.array2string($this->folders));
+			if (!isset($this->folders)) $this->folders = $this->mail->getFolderObjects(true, false, $_alwaysGetDefaultFolders = true);
+			if ($this->debugLevel > 1) ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__.array2string($this->folders));
 
 			foreach ($this->folders as $folder => $folderObj) {
-				if ($this->debugLevel>1) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' folder='.$folder);
+				if ($this->debugLevel > 1) ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__.' folder='.$folder);
 				$folderlist[] = $f = array(
-					'id'     => $this->createID($account,$folder),
+					'id'     => $this->createID($account, $folder),
 					'mod'    => $folderObj->shortDisplayName,
-					'parent' => $this->getParentID($account,$folder),
+					'parent' => $this->getParentID($account, $folder),
 				);
-				if ($this->debugLevel>1) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."() returning ".array2string($f));
+				if ($this->debugLevel > 1) ZLog::Write(LOGLEVEL_DEBUG, __METHOD__."() returning ".array2string($f));
 			}
 		}
-		if ($this->debugLevel>0) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."() returning ".array2string($folderlist));
+		if ($this->debugLevel > 0) ZLog::Write(LOGLEVEL_DEBUG, __METHOD__."() returning ".array2string($folderlist));
 
 		return $folderlist;
 	}
@@ -340,59 +340,59 @@ 
 		$ClientSideMeetingRequest = false;
 		$allowSendingInvitations = 'sendifnocalnotif';
 		if (isset($GLOBALS['egw_info']['user']['preferences']['activesync']['mail-allowSendingInvitations']) &&
-			$GLOBALS['egw_info']['user']['preferences']['activesync']['mail-allowSendingInvitations']=='nosend')
+			$GLOBALS['egw_info']['user']['preferences']['activesync']['mail-allowSendingInvitations'] == 'nosend')
 		{
 			$allowSendingInvitations = false;
 		}
 		elseif (isset($GLOBALS['egw_info']['user']['preferences']['activesync']['mail-allowSendingInvitations']) &&
-			$GLOBALS['egw_info']['user']['preferences']['activesync']['mail-allowSendingInvitations']!='nosend')
+			$GLOBALS['egw_info']['user']['preferences']['activesync']['mail-allowSendingInvitations'] != 'nosend')
 		{
 			$allowSendingInvitations = $GLOBALS['egw_info']['user']['preferences']['activesync']['mail-allowSendingInvitations'];
 		}
-		$smartdata_task = ($smartdata->replyflag?'reply':($smartdata->forwardflag?'forward':'new'));
+		$smartdata_task = ($smartdata->replyflag ? 'reply' : ($smartdata->forwardflag ? 'forward' : 'new'));
 
-   		ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__ . (isset($smartdata->mime) ? $smartdata->mime : ""). "task: ".(isset($smartdata_task) ? $smartdata_task : "")." itemid: ".(isset($smartdata->source->itemid) ? $smartdata->source->itemid : "")." folder: ".(isset($smartdata->source->folderid) ? $smartdata->source->folderid : ""));
-		if ($this->debugLevel>0) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__."): Smartdata = ".array2string($smartdata));
+   		ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__.(isset($smartdata->mime) ? $smartdata->mime : "")."task: ".(isset($smartdata_task) ? $smartdata_task : "")." itemid: ".(isset($smartdata->source->itemid) ? $smartdata->source->itemid : "")." folder: ".(isset($smartdata->source->folderid) ? $smartdata->source->folderid : ""));
+		if ($this->debugLevel > 0) ZLog::Write(LOGLEVEL_DEBUG, __METHOD__."(".__LINE__."): Smartdata = ".array2string($smartdata));
 		//error_log("IMAP-Sendmail: Smartdata = ".array2string($smartdata));
 
 		// initialize our Mail
-		if (!isset($this->mail)) $this->mail = Mail::getInstance(false,self::$profileID,true,false,true);
+		if (!isset($this->mail)) $this->mail = Mail::getInstance(false, self::$profileID, true, false, true);
 		$activeMailProfiles = $this->mail->getAccountIdentities(self::$profileID);
 		// use the standardIdentity
-		$activeMailProfile = Mail::getStandardIdentityForProfile($activeMailProfiles,self::$profileID);
+		$activeMailProfile = Mail::getStandardIdentityForProfile($activeMailProfiles, self::$profileID);
 
-		ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__.")".' ProfileID:'.self::$profileID.' ActiveMailProfile:'.array2string($activeMailProfile));
+		ZLog::Write(LOGLEVEL_DEBUG, __METHOD__."(".__LINE__.")".' ProfileID:'.self::$profileID.' ActiveMailProfile:'.array2string($activeMailProfile));
 
 		// initialize the new Api\Mailer object for sending
 		$mailObject = new Api\Mailer(self::$profileID);
-		$this->mail->parseRawMessageIntoMailObject($mailObject,$smartdata->mime);
+		$this->mail->parseRawMessageIntoMailObject($mailObject, $smartdata->mime);
 		// Horde SMTP Class uses utf-8 by default. as we set charset always to utf-8
-		$mailObject->Sender  = $activeMailProfile['ident_email'];
-		$mailObject->From 	= $activeMailProfile['ident_email'];
-		$mailObject->FromName = $mailObject->EncodeHeader(Mail::generateIdentityString($activeMailProfile,false));
+		$mailObject->Sender = $activeMailProfile['ident_email'];
+		$mailObject->From = $activeMailProfile['ident_email'];
+		$mailObject->FromName = $mailObject->EncodeHeader(Mail::generateIdentityString($activeMailProfile, false));
 		$mailObject->AddCustomHeader('X-Mailer: mail-Activesync');
 
 
 		// prepare addressee list; moved the adding of addresses to the mailobject down
 		// to
 
-		foreach(Mail::parseAddressList($mailObject->getHeader("To")) as $addressObject) {
+		foreach (Mail::parseAddressList($mailObject->getHeader("To")) as $addressObject) {
 			if (!$addressObject->valid) continue;
-			ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__.") Header Sentmail To: ".array2string($addressObject) );
+			ZLog::Write(LOGLEVEL_DEBUG, __METHOD__."(".__LINE__.") Header Sentmail To: ".array2string($addressObject));
 			//$mailObject->AddAddress($addressObject->mailbox. ($addressObject->host ? '@'.$addressObject->host : ''),$addressObject->personal);
 			$toMailAddr[] = imap_rfc822_write_address($addressObject->mailbox, $addressObject->host, $addressObject->personal);
 		}
 		// CC
-		foreach(Mail::parseAddressList($mailObject->getHeader("Cc")) as $addressObject) {
+		foreach (Mail::parseAddressList($mailObject->getHeader("Cc")) as $addressObject) {
 			if (!$addressObject->valid) continue;
-			ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__.") Header Sentmail CC: ".array2string($addressObject) );
+			ZLog::Write(LOGLEVEL_DEBUG, __METHOD__."(".__LINE__.") Header Sentmail CC: ".array2string($addressObject));
 			//$mailObject->AddCC($addressObject->mailbox. ($addressObject->host ? '@'.$addressObject->host : ''),$addressObject->personal);
 			$ccMailAddr[] = imap_rfc822_write_address($addressObject->mailbox, $addressObject->host, $addressObject->personal);
 		}
 		// BCC
-		foreach(Mail::parseAddressList($mailObject->getHeader("Bcc")) as $addressObject) {
+		foreach (Mail::parseAddressList($mailObject->getHeader("Bcc")) as $addressObject) {
 			if (!$addressObject->valid) continue;
-			ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__.") Header Sentmail BCC: ".array2string($addressObject) );
+			ZLog::Write(LOGLEVEL_DEBUG, __METHOD__."(".__LINE__.") Header Sentmail BCC: ".array2string($addressObject));
 			//$mailObject->AddBCC($addressObject->mailbox. ($addressObject->host ? '@'.$addressObject->host : ''),$addressObject->personal);
 			$bccMailAddr[] = imap_rfc822_write_address($addressObject->mailbox, $addressObject->host, $addressObject->personal);
 		}
@@ -401,7 +401,7 @@ 
 		$use_orgbody = false;
 
 		$k = 'Content-Type';
-		$ContentType =$mailObject->getHeader('Content-Type');
+		$ContentType = $mailObject->getHeader('Content-Type');
 		//error_log(__METHOD__.__LINE__." Header Sentmail original Header (filtered): " . $k.  " = ".trim($ContentType));
 		// if the message is a multipart message, then we should use the sent body
 		if (preg_match("/multipart/i", $ContentType)) {
@@ -421,43 +421,43 @@ 
 			$k == "Content-Type" && preg_match("/multipart/i", $ContentType))) {
 			$use_orgbody = true;
 		}
-		$Body =  $AltBody = "";
+		$Body = $AltBody = "";
 		// get body of the transmitted message
 		// if this is a simple message, no structure at all
 		if (preg_match("/text/i", $ContentType))
 		{
-			$simpleBodyType = (preg_match("/html/i", $ContentType)?'text/html':'text/plain');
+			$simpleBodyType = (preg_match("/html/i", $ContentType) ? 'text/html' : 'text/plain');
 			$bodyObj = $mailObject->findBody(preg_match("/html/i", $ContentType) ? 'html' : 'plain');
-			$body = preg_replace("/(<|&lt;)*(([\w\.,-.,_.,0-9.]+)@([\w\.,-.,_.,0-9.]+))(>|&gt;)*/i","[$2]", $bodyObj ?$bodyObj->getContents() : null);
-			if  ($simpleBodyType == "text/plain")
+			$body = preg_replace("/(<|&lt;)*(([\w\.,-.,_.,0-9.]+)@([\w\.,-.,_.,0-9.]+))(>|&gt;)*/i", "[$2]", $bodyObj ? $bodyObj->getContents() : null);
+			if ($simpleBodyType == "text/plain")
 			{
 				$Body = $body;
 				$AltBody = "<pre>".nl2br($body)."</pre>";
-				ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__.") fetched Body as :". $simpleBodyType.'=> Created AltBody');
+				ZLog::Write(LOGLEVEL_DEBUG, __METHOD__."(".__LINE__.") fetched Body as :".$simpleBodyType.'=> Created AltBody');
 			}
 			else
 			{
 				$AltBody = $body;
-				$Body =  trim(Api\Mail\Html::convertHTMLToText($body));
-				ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__.") fetched Body as :". $simpleBodyType.'=> Created Body');
+				$Body = trim(Api\Mail\Html::convertHTMLToText($body));
+				ZLog::Write(LOGLEVEL_DEBUG, __METHOD__."(".__LINE__.") fetched Body as :".$simpleBodyType.'=> Created Body');
 			}
 		}
 		else
 		{
 			// if this is a structured message
 			// prefer plain over html
-			$Body = preg_replace("/(<|&lt;)*(([\w\.,-.,_.,0-9.]+)@([\w\.,-.,_.,0-9.]+))(>|&gt;)*/i","[$2]",
+			$Body = preg_replace("/(<|&lt;)*(([\w\.,-.,_.,0-9.]+)@([\w\.,-.,_.,0-9.]+))(>|&gt;)*/i", "[$2]",
 				($text_body = $mailObject->findBody('plain')) ? $text_body->getContents() : null);
-			$AltBody = preg_replace("/(<|&lt;)*(([\w\.,-.,_.,0-9.]+)@([\w\.,-.,_.,0-9.]+))(>|&gt;)*/i","[$2]",
+			$AltBody = preg_replace("/(<|&lt;)*(([\w\.,-.,_.,0-9.]+)@([\w\.,-.,_.,0-9.]+))(>|&gt;)*/i", "[$2]",
 				($html_body = $mailObject->findBody('html')) ? $html_body->getContents() : null);
 		}
-		if ($this->debugLevel>1 && $Body) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__.") fetched Body as with MessageContentType:". $ContentType.'=>'.$Body);
-		if ($this->debugLevel>1 && $AltBody) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__.") fetched AltBody as with MessageContentType:". $ContentType.'=>'.$AltBody);
+		if ($this->debugLevel > 1 && $Body) ZLog::Write(LOGLEVEL_DEBUG, __METHOD__."(".__LINE__.") fetched Body as with MessageContentType:".$ContentType.'=>'.$Body);
+		if ($this->debugLevel > 1 && $AltBody) ZLog::Write(LOGLEVEL_DEBUG, __METHOD__."(".__LINE__.") fetched AltBody as with MessageContentType:".$ContentType.'=>'.$AltBody);
 		//error_log(__METHOD__.__LINE__.array2string($mailObject));
 		// if this is a multipart message with a boundary, we must use the original body
 		//if ($this->debugLevel>2) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' mailObject after Inital Parse:'.array2string($mailObject));
         if ($use_orgbody) {
-    	    ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__.") use_orgbody = true ContentType:".$ContentType);
+    	    ZLog::Write(LOGLEVEL_DEBUG, __METHOD__."(".__LINE__.") use_orgbody = true ContentType:".$ContentType);
  			// if it is a ClientSideMeetingRequest, we report it as send at all times
 			if (($cal_body = $mailObject->findBody('calendar')) &&
 				($cSMRMethod = $cal_body->getContentTypeParameter('method')))
@@ -466,21 +466,21 @@ 
 				{
 					$organizer = calendar_ical::getIcalOrganizer($cal_body->getContents());
 				}
-				if ($this->debugLevel) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__.") we have a Client Side Meeting Request from organizer=$organizer");
+				if ($this->debugLevel) ZLog::Write(LOGLEVEL_DEBUG, __METHOD__."(".__LINE__.") we have a Client Side Meeting Request from organizer=$organizer");
 				$ClientSideMeetingRequest = true;
 			}
         }
 		// now handle the addressee list
 		$toCount = 0;
 		//error_log(__METHOD__.__LINE__.array2string($toMailAddr));
-		foreach((array)$toMailAddr as $address) {
-			foreach(Mail::parseAddressList((get_magic_quotes_gpc()?stripslashes($address):$address)) as $addressObject) {
-				$emailAddress = $addressObject->mailbox. ($addressObject->host ? '@'.$addressObject->host : '');
+		foreach ((array)$toMailAddr as $address) {
+			foreach (Mail::parseAddressList((get_magic_quotes_gpc() ? stripslashes($address) : $address)) as $addressObject) {
+				$emailAddress = $addressObject->mailbox.($addressObject->host ? '@'.$addressObject->host : '');
 				if ($ClientSideMeetingRequest === true && $allowSendingInvitations == 'sendifnocalnotif' &&
 					calendar_boupdate::email_update_requested($emailAddress, isset($cSMRMethod) ? $cSMRMethod : 'REQUEST',
 						$organizer && !strcasecmp($emailAddress, $organizer) ? 'CHAIR' : ''))
 				{
-					ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__.") skiping mail to organizer '$organizer', as it will be send by calendar app");
+					ZLog::Write(LOGLEVEL_DEBUG, __METHOD__."(".__LINE__.") skiping mail to organizer '$organizer', as it will be send by calendar app");
 					continue;
 				}
 				$mailObject->AddAddress($emailAddress, $addressObject->personal);
@@ -488,29 +488,29 @@ 
 			}
 		}
 		$ccCount = 0;
-		foreach((array)$ccMailAddr as $address) {
-			foreach(Mail::parseAddressList((get_magic_quotes_gpc()?stripslashes($address):$address)) as $addressObject) {
-				$emailAddress = $addressObject->mailbox. ($addressObject->host ? '@'.$addressObject->host : '');
+		foreach ((array)$ccMailAddr as $address) {
+			foreach (Mail::parseAddressList((get_magic_quotes_gpc() ? stripslashes($address) : $address)) as $addressObject) {
+				$emailAddress = $addressObject->mailbox.($addressObject->host ? '@'.$addressObject->host : '');
 				if ($ClientSideMeetingRequest === true && $allowSendingInvitations == 'sendifnocalnotif' && calendar_boupdate::email_update_requested($emailAddress)) continue;
 				$mailObject->AddCC($emailAddress, $addressObject->personal);
 				$ccCount++;
 			}
 		}
 		$bccCount = 0;
-		foreach((array)$bccMailAddr as $address) {
-			foreach(Mail::parseAddressList((get_magic_quotes_gpc()?stripslashes($address):$address)) as $addressObject) {
-				$emailAddress = $addressObject->mailbox. ($addressObject->host ? '@'.$addressObject->host : '');
+		foreach ((array)$bccMailAddr as $address) {
+			foreach (Mail::parseAddressList((get_magic_quotes_gpc() ? stripslashes($address) : $address)) as $addressObject) {
+				$emailAddress = $addressObject->mailbox.($addressObject->host ? '@'.$addressObject->host : '');
 				if ($ClientSideMeetingRequest === true && $allowSendingInvitations == 'sendifnocalnotif' && calendar_boupdate::email_update_requested($emailAddress)) continue;
 				$mailObject->AddBCC($emailAddress, $addressObject->personal);
 				$bccCount++;
 			}
 		}
 		// typical organizer reply will end here with nothing send --> return true, because we suppressed the send above
-		if ($toCount+$ccCount+$bccCount == 0)
+		if ($toCount + $ccCount + $bccCount == 0)
 		{
 			return $ClientSideMeetingRequest && $allowSendingInvitations === 'sendifnocalnotif' && $organizer ? true : 0; // noone to send mail to
 		}
-		if ($ClientSideMeetingRequest === true && $allowSendingInvitations===false) return true;
+		if ($ClientSideMeetingRequest === true && $allowSendingInvitations === false) return true;
 		// as we use our mailer (horde mailer) it is detecting / setting the mimetype by itself while creating the mail
 /*
 		if ($this->debugLevel>2) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' retrieved Body:'.$body);
@@ -518,29 +518,29 @@ 
 		if ($this->debugLevel>2) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' retrieved Body (modified):'.$body);
 */
 		// add signature!! -----------------------------------------------------------------
-		ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' ActiveMailProfile:'.array2string($activeMailProfile));
+		ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__.' ActiveMailProfile:'.array2string($activeMailProfile));
 		try
 		{
 			$acc = Mail\Account::read($this->mail->icServer->ImapServerId);
 			//error_log(__METHOD__.__LINE__.array2string($acc));
-			$_signature = Mail\Account::read_identity($acc['ident_id'],true);
+			$_signature = Mail\Account::read_identity($acc['ident_id'], true);
 		}
 		catch (Exception $e)
 		{
-			$_signature=array();
+			$_signature = array();
 		}
 		$signature = $_signature['ident_signature'];
 		if ((isset($preferencesArray['disableRulerForSignatureSeparation']) &&
 			$preferencesArray['disableRulerForSignatureSeparation']) ||
-			empty($signature) || trim(Api\Mail\Html::convertHTMLToText($signature)) =='')
+			empty($signature) || trim(Api\Mail\Html::convertHTMLToText($signature)) == '')
 		{
 			$disableRuler = true;
 		}
 		$beforePlain = $beforeHtml = "";
-		$beforeHtml = ($disableRuler ?'&nbsp;<br>':'&nbsp;<br><hr style="border:dotted 1px silver; width:90%; border:dotted 1px silver;">');
-		$beforePlain = ($disableRuler ?"\r\n\r\n":"\r\n\r\n-- \r\n");
-		$sigText = Mail::merge($signature,array($GLOBALS['egw']->accounts->id2name($GLOBALS['egw_info']['user']['account_id'],'person_id')));
-		if ($this->debugLevel>0) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' Signature to use:'.$sigText);
+		$beforeHtml = ($disableRuler ? '&nbsp;<br>' : '&nbsp;<br><hr style="border:dotted 1px silver; width:90%; border:dotted 1px silver;">');
+		$beforePlain = ($disableRuler ? "\r\n\r\n" : "\r\n\r\n-- \r\n");
+		$sigText = Mail::merge($signature, array($GLOBALS['egw']->accounts->id2name($GLOBALS['egw_info']['user']['account_id'], 'person_id')));
+		if ($this->debugLevel > 0) ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__.' Signature to use:'.$sigText);
 		$sigTextHtml = $beforeHtml.$sigText;
 		$sigTextPlain = $beforePlain.Api\Mail\Html::convertHTMLToText($sigText);
 		$isreply = $isforward = false;
@@ -552,26 +552,26 @@ 
 		{
 			// now get on, and fetch the original mail
 			$uid = $smartdata->source->itemid;
-			ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__.") IMAP Smartreply is called with FolderID:".$smartdata->source->folderid.' and ItemID:'.$smartdata->source->itemid);
+			ZLog::Write(LOGLEVEL_DEBUG, __METHOD__."(".__LINE__.") IMAP Smartreply is called with FolderID:".$smartdata->source->folderid.' and ItemID:'.$smartdata->source->itemid);
 			$this->splitID($smartdata->source->folderid, $account, $folder);
 
 			$this->mail->reopen($folder);
 			$bodyStruct = $this->mail->getMessageBody($uid, 'html_only');
-			$bodyBUFFHtml = $this->mail->getdisplayableBody($this->mail,$bodyStruct,true,false);
-			if ($this->debugLevel>3) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' html_only:'.$bodyBUFFHtml);
-		    if ($bodyBUFFHtml != "" && (is_array($bodyStruct) && $bodyStruct[0]['mimeType']=='text/html')) {
+			$bodyBUFFHtml = $this->mail->getdisplayableBody($this->mail, $bodyStruct, true, false);
+			if ($this->debugLevel > 3) ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__.' html_only:'.$bodyBUFFHtml);
+		    if ($bodyBUFFHtml != "" && (is_array($bodyStruct) && $bodyStruct[0]['mimeType'] == 'text/html')) {
 				// may be html
-				if ($this->debugLevel>0) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__.") MIME Body".' Type:html (fetched with html_only):'.$bodyBUFFHtml);
+				if ($this->debugLevel > 0) ZLog::Write(LOGLEVEL_DEBUG, __METHOD__."(".__LINE__.") MIME Body".' Type:html (fetched with html_only):'.$bodyBUFFHtml);
 				$AltBody = $AltBody."</br>".$bodyBUFFHtml.$sigTextHtml;
 				$isreply = true;
 			}
 			// plain text Message part
-			ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__.") MIME Body".' Type:plain, fetch text:');
+			ZLog::Write(LOGLEVEL_DEBUG, __METHOD__."(".__LINE__.") MIME Body".' Type:plain, fetch text:');
 			// if the new part of the message is html, we must preserve it, and handle that the original mail is text/plain
-			$bodyStruct = $this->mail->getMessageBody($uid,'never_display');//'never_display');
-			$bodyBUFF = $this->mail->getdisplayableBody($this->mail,$bodyStruct,false,false);
-			if ($bodyBUFF != "" && (is_array($bodyStruct) && $bodyStruct[0]['mimeType']=='text/plain')) {
-				if ($this->debugLevel>0) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__.") MIME Body".' Type:plain (fetched with never_display):'.$bodyBUFF);
+			$bodyStruct = $this->mail->getMessageBody($uid, 'never_display'); //'never_display');
+			$bodyBUFF = $this->mail->getdisplayableBody($this->mail, $bodyStruct, false, false);
+			if ($bodyBUFF != "" && (is_array($bodyStruct) && $bodyStruct[0]['mimeType'] == 'text/plain')) {
+				if ($this->debugLevel > 0) ZLog::Write(LOGLEVEL_DEBUG, __METHOD__."(".__LINE__.") MIME Body".' Type:plain (fetched with never_display):'.$bodyBUFF);
 				$Body = $Body."\r\n".$bodyBUFF.$sigTextPlain;
 				$isreply = true;
 			}
@@ -579,12 +579,12 @@ 
 			{
 				$isreply = true;
 				$AltBody = $AltBody."</br><pre>".nl2br($bodyBUFF).'</pre>'.$sigTextHtml;
-				if ($this->debugLevel>0) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__." no Api\Html Body found use modified plaintext body for txt/html: ".$AltBody);
+				if ($this->debugLevel > 0) ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__." no Api\Html Body found use modified plaintext body for txt/html: ".$AltBody);
 			}
 		}
 
 		// how to forward and other prefs
-		$preferencesArray =& $GLOBALS['egw_info']['user']['preferences']['mail'];
+		$preferencesArray = & $GLOBALS['egw_info']['user']['preferences']['mail'];
 
 		// forward -------------------------------------------------------------------------
 		if ($smartdata_task == 'forward' && isset($smartdata->source->itemid) &&
@@ -594,7 +594,7 @@ 
 		{
 			//force the default for the forwarding -> asmail
 			if (is_array($preferencesArray)) {
-				if (!array_key_exists('message_forwarding',$preferencesArray)
+				if (!array_key_exists('message_forwarding', $preferencesArray)
 					|| !isset($preferencesArray['message_forwarding'])
 					|| empty($preferencesArray['message_forwarding'])) $preferencesArray['message_forwarding'] = 'asmail';
 			} else {
@@ -602,18 +602,18 @@ 
 			}
 			// construct the uid of the message out of the itemid - seems to be the uid, no construction needed
 			$uid = $smartdata->source->itemid;
-			ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__.")IMAP Smartfordward is called with FolderID:".$smartdata->source->folderid.' and ItemID:'.$smartdata->source->itemid);
+			ZLog::Write(LOGLEVEL_DEBUG, __METHOD__."(".__LINE__.")IMAP Smartfordward is called with FolderID:".$smartdata->source->folderid.' and ItemID:'.$smartdata->source->itemid);
 			$this->splitID($smartdata->source->folderid, $account, $folder);
 
 			$this->mail->reopen($folder);
             // receive entire mail (header + body)
 			// get message headers for specified message
-			$headers	= $this->mail->getMessageEnvelope($uid, $_partID, true, $folder);
+			$headers = $this->mail->getMessageEnvelope($uid, $_partID, true, $folder);
 			// build a new mime message, forward entire old mail as file
 			if ($preferencesArray['message_forwarding'] == 'asmail')
 			{
-				$rawHeader      = $this->mail->getMessageRawHeader($smartdata->source->itemid, $_partID,$folder);
-				$rawBody        = $this->mail->getMessageRawBody($smartdata->source->itemid, $_partID,$folder);
+				$rawHeader      = $this->mail->getMessageRawHeader($smartdata->source->itemid, $_partID, $folder);
+				$rawBody        = $this->mail->getMessageRawBody($smartdata->source->itemid, $_partID, $folder);
 				$mailObject->AddStringAttachment($rawHeader.$rawBody, $headers['SUBJECT'].'.eml', 'message/rfc822');
 				$AltBody = $AltBody."</br>".lang("See Attachments for Content of the Orignial Mail").$sigTextHtml;
 				$Body = $Body."\r\n".lang("See Attachments for Content of the Orignial Mail").$sigTextPlain;
@@ -623,50 +623,50 @@ 
 			{
 				// now get on, and fetch the original mail
 				$uid = $smartdata->source->itemid;
-				ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__.") IMAP Smartreply is called with FolderID:".$smartdata->source->folderid.' and ItemID:'.$smartdata->source->itemid);
+				ZLog::Write(LOGLEVEL_DEBUG, __METHOD__."(".__LINE__.") IMAP Smartreply is called with FolderID:".$smartdata->source->folderid.' and ItemID:'.$smartdata->source->itemid);
 				$this->splitID($smartdata->source->folderid, $account, $folder);
 
 				$this->mail->reopen($folder);
 				$bodyStruct = $this->mail->getMessageBody($uid, 'html_only');
-				$bodyBUFFHtml = $this->mail->getdisplayableBody($this->mail,$bodyStruct,true,false);
-				if ($this->debugLevel>0) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' html_only:'.$bodyBUFFHtml);
-				if ($bodyBUFFHtml != "" && (is_array($bodyStruct) && $bodyStruct[0]['mimeType']=='text/html')) {
+				$bodyBUFFHtml = $this->mail->getdisplayableBody($this->mail, $bodyStruct, true, false);
+				if ($this->debugLevel > 0) ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__.' html_only:'.$bodyBUFFHtml);
+				if ($bodyBUFFHtml != "" && (is_array($bodyStruct) && $bodyStruct[0]['mimeType'] == 'text/html')) {
 					// may be html
-					if ($this->debugLevel>0) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__.") MIME Body".' Type:html (fetched with html_only):'.$bodyBUFFHtml);
+					if ($this->debugLevel > 0) ZLog::Write(LOGLEVEL_DEBUG, __METHOD__."(".__LINE__.") MIME Body".' Type:html (fetched with html_only):'.$bodyBUFFHtml);
 					$AltBody = $AltBody."</br>".$bodyBUFFHtml.$sigTextHtml;
 					$isforward = true;
 				}
 				// plain text Message part
-				if ($this->debugLevel>0) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__.") MIME Body".' Type:plain, fetch text:');
+				if ($this->debugLevel > 0) ZLog::Write(LOGLEVEL_DEBUG, __METHOD__."(".__LINE__.") MIME Body".' Type:plain, fetch text:');
 				// if the new part of the message is html, we must preserve it, and handle that the original mail is text/plain
-				$bodyStruct = $this->mail->getMessageBody($uid,'never_display');//'never_display');
-				$bodyBUFF = $this->mail->getdisplayableBody($this->mail,$bodyStruct,false,false);
-				if ($bodyBUFF != "" && (is_array($bodyStruct) && $bodyStruct[0]['mimeType']=='text/plain')) {
-					if ($this->debugLevel>0) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__.") MIME Body".' Type:plain (fetched with never_display):'.$bodyBUFF);
+				$bodyStruct = $this->mail->getMessageBody($uid, 'never_display'); //'never_display');
+				$bodyBUFF = $this->mail->getdisplayableBody($this->mail, $bodyStruct, false, false);
+				if ($bodyBUFF != "" && (is_array($bodyStruct) && $bodyStruct[0]['mimeType'] == 'text/plain')) {
+					if ($this->debugLevel > 0) ZLog::Write(LOGLEVEL_DEBUG, __METHOD__."(".__LINE__.") MIME Body".' Type:plain (fetched with never_display):'.$bodyBUFF);
 					$Body = $Body."\r\n".$bodyBUFF.$sigTextPlain;
 					$isforward = true;
 				}
 				if (!empty($bodyBUFF) && empty($bodyBUFFHtml) && !empty($AltBody))
 				{
 					$AltBody = $AltBody."</br><pre>".nl2br($bodyBUFF).'</pre>'.$sigTextHtml;
-					if ($this->debugLevel>0) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__." no html Body found use modified plaintext body for txt/html: ".$AltBody);
+					if ($this->debugLevel > 0) ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__." no html Body found use modified plaintext body for txt/html: ".$AltBody);
 					$isforward = true;
 				}
 				// get all the attachments and add them too.
 				// start handle Attachments
 				//												$_uid, $_partID=null, Horde_Mime_Part $_structure=null, $fetchEmbeddedImages=true, $fetchTextCalendar=false, $resolveTNEF=true, $_folderName=''
-				$attachments = $this->mail->getMessageAttachments($uid, null,          null,								true,						false,				 true			, $folder);
+				$attachments = $this->mail->getMessageAttachments($uid, null, null, true, false, true, $folder);
 				$attachmentNames = false;
-				if (is_array($attachments) && count($attachments)>0)
+				if (is_array($attachments) && count($attachments) > 0)
 				{
-					ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' gather Attachments for BodyCreation of/for MessageID:'.$uid.' found:'.count($attachments));
-					foreach((array)$attachments as $key => $attachment)
+					ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__.' gather Attachments for BodyCreation of/for MessageID:'.$uid.' found:'.count($attachments));
+					foreach ((array)$attachments as $key => $attachment)
 					{
-						if ($this->debugLevel>0) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' Key:'.$key.'->'.array2string($attachment));
+						if ($this->debugLevel > 0) ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__.' Key:'.$key.'->'.array2string($attachment));
 						$attachmentNames .= $attachment['name']."\n";
-						$attachmentData	= $this->mail->getAttachment($uid, $attachment['partID'],0,false,false,$folder);
+						$attachmentData = $this->mail->getAttachment($uid, $attachment['partID'], 0, false, false, $folder);
 						/*$x =*/ $mailObject->AddStringAttachment($attachmentData['attachment'], $mailObject->EncodeHeader($attachment['name']), $attachment['mimeType']);
-						ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' added part with number:'.$x);
+						ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__.' added part with number:'.$x);
 					}
 				}
 			}
@@ -680,36 +680,36 @@ 
 		// now set the body
 		if ($AltBody && ($html_body = $mailObject->findBody('html')))
 		{
-			if ($this->debugLevel>1) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' -> '.$AltBody);
-			$html_body->setContents($AltBody,array('encoding'=>Horde_Mime_Part::DEFAULT_ENCODING));
+			if ($this->debugLevel > 1) ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__.' -> '.$AltBody);
+			$html_body->setContents($AltBody, array('encoding'=>Horde_Mime_Part::DEFAULT_ENCODING));
 		}
 		if ($Body && ($text_body = $mailObject->findBody('plain')))
 		{
-			if ($this->debugLevel>1) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' -> '.$Body);
-			$text_body->setContents($Body,array('encoding'=>Horde_Mime_Part::DEFAULT_ENCODING));
+			if ($this->debugLevel > 1) ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__.' -> '.$Body);
+			$text_body->setContents($Body, array('encoding'=>Horde_Mime_Part::DEFAULT_ENCODING));
 		}
 		//advanced debugging
 		// Horde SMTP Class uses utf-8 by default.
         //debugLog("IMAP-SendMail: parsed message: ". print_r($message,1));
-		if ($this->debugLevel>2) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__."): MailObject:".array2string($mailObject));
+		if ($this->debugLevel > 2) ZLog::Write(LOGLEVEL_DEBUG, __METHOD__."(".__LINE__."): MailObject:".array2string($mailObject));
 
 		// set a higher timeout for big messages
 		@set_time_limit(120);
-		ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' -> '.' about to send ....');
+		ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__.' -> '.' about to send ....');
 		// send
 		$send = true;
 		try {
 			$mailObject->Send();
 		}
-		catch(Exception $e) {
-			ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__.") The email could not be sent. Last-SMTP-error: ". $e->getMessage());
+		catch (Exception $e) {
+			ZLog::Write(LOGLEVEL_DEBUG, __METHOD__."(".__LINE__.") The email could not be sent. Last-SMTP-error: ".$e->getMessage());
 			$send = false;
 		}
 
-		if (( $smartdata_task == 'reply' || $smartdata_task == 'forward') && $send == true)
+		if (($smartdata_task == 'reply' || $smartdata_task == 'forward') && $send == true)
 		{
 			$uid = $smartdata->source->itemid;
-			ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' tASK:'.$smartdata_task." FolderID:".$smartdata->source->folderid.' and ItemID:'.$smartdata->source->itemid);
+			ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__.' tASK:'.$smartdata_task." FolderID:".$smartdata->source->folderid.' and ItemID:'.$smartdata->source->itemid);
 			$this->splitID($smartdata->source->folderid, $account, $folder);
 			//error_log(__METHOD__.__LINE__.' Folder:'.$folder.' Uid:'.$uid);
 			$this->mail->reopen($folder);
@@ -717,89 +717,89 @@ 
 			// unless your templatefolder is a subfolder of your draftfolder, and the message is in there
 			if ($this->mail->isDraftFolder($folder) && !$this->mail->isTemplateFolder($folder))
 			{
-				$this->mail->deleteMessages(array($uid),$folder);
+				$this->mail->deleteMessages(array($uid), $folder);
 			} else {
-				$this->mail->flagMessages("answered", array($uid),$folder);
-				if ($smartdata_task== "forward")
+				$this->mail->flagMessages("answered", array($uid), $folder);
+				if ($smartdata_task == "forward")
 				{
-					$this->mail->flagMessages("forwarded", array($uid),$folder);
+					$this->mail->flagMessages("forwarded", array($uid), $folder);
 				}
 			}
 		}
 
-		$asf = ($send ? true:false); // initalize accordingly
-		if (/*($smartdata->saveinsent==1 || !isset($smartdata->saveinsent)) && */  $send==true && $this->mail->mailPreferences['sendOptions'] != 'send_only')
+		$asf = ($send ? true : false); // initalize accordingly
+		if (/*($smartdata->saveinsent==1 || !isset($smartdata->saveinsent)) && */  $send == true && $this->mail->mailPreferences['sendOptions'] != 'send_only')
 		{
 			$asf = false;
 			$sentFolder = $this->mail->getSentFolder();
 			if ($this->_sentID) {
 				$folderArray[] = $this->_sentID;
 			}
-			else if(isset($sentFolder) && $sentFolder != 'none')
+			else if (isset($sentFolder) && $sentFolder != 'none')
 			{
 				$folderArray[] = $sentFolder;
 			}
 			// No Sent folder set, try defaults
 			else
 			{
-				ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__.") IMAP-SendMail: No Sent mailbox set");
+				ZLog::Write(LOGLEVEL_DEBUG, __METHOD__."(".__LINE__.") IMAP-SendMail: No Sent mailbox set");
 				// we dont try guessing
 				$asf = true;
 			}
 			if (count($folderArray) > 0) {
-				foreach((array)$bccMailAddr as $address) {
-					foreach(Mail::parseAddressList((get_magic_quotes_gpc()?stripslashes($address):$address)) as $addressObject) {
-						$emailAddress = $addressObject->mailbox. ($addressObject->host ? '@'.$addressObject->host : '');
+				foreach ((array)$bccMailAddr as $address) {
+					foreach (Mail::parseAddressList((get_magic_quotes_gpc() ? stripslashes($address) : $address)) as $addressObject) {
+						$emailAddress = $addressObject->mailbox.($addressObject->host ? '@'.$addressObject->host : '');
 						$mailAddr[] = array($emailAddress, $addressObject->personal);
 					}
 				}
-				$BCCmail='';
-				if (count($mailAddr)>0) $BCCmail = $mailObject->AddrAppend("Bcc",$mailAddr);
-				foreach($folderArray as $folderName) {
-					if($this->mail->isSentFolder($folderName)) {
+				$BCCmail = '';
+				if (count($mailAddr) > 0) $BCCmail = $mailObject->AddrAppend("Bcc", $mailAddr);
+				foreach ($folderArray as $folderName) {
+					if ($this->mail->isSentFolder($folderName)) {
 						$flags = '\\Seen';
-					} elseif($this->mail->isDraftFolder($folderName)) {
+					} elseif ($this->mail->isDraftFolder($folderName)) {
 						$flags = '\\Draft';
 					} else {
 						$flags = '';
 					}
 					$asf = true;
 					//ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.'->'.array2string($this->mail->icServer));
-					$this->mail->openConnection(self::$profileID,false);
+					$this->mail->openConnection(self::$profileID, false);
 					if ($this->mail->folderExists($folderName)) {
 						try
 						{
-							$this->mail->appendMessage($folderName,$mailObject->getRaw(), null,
+							$this->mail->appendMessage($folderName, $mailObject->getRaw(), null,
 									$flags);
 						}
 						catch (Api\Exception\WrongUserinput $e)
 						{
 							//$asf = false;
-							ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.'->'.lang("Import of message %1 failed. Could not save message to folder %2 due to: %3",$mailObject->getHeader('Subject'),$folderName,$e->getMessage()));
+							ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__.'->'.lang("Import of message %1 failed. Could not save message to folder %2 due to: %3", $mailObject->getHeader('Subject'), $folderName, $e->getMessage()));
 						}
 					}
 					else
 					{
 						//$asf = false;
-						ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.'->'.lang("Import of message %1 failed. Destination Folder %2 does not exist.",$mailObject->getHeader('Subject'),$folderName));
+						ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__.'->'.lang("Import of message %1 failed. Destination Folder %2 does not exist.", $mailObject->getHeader('Subject'), $folderName));
 					}
-			        ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__."): Outgoing mail saved in configured 'Sent' folder '".$folderName."': ". (($asf)?"success":"failed"));
+			        ZLog::Write(LOGLEVEL_DEBUG, __METHOD__."(".__LINE__."): Outgoing mail saved in configured 'Sent' folder '".$folderName."': ".(($asf) ? "success" : "failed"));
 				}
 				//$this->mail->closeConnection();
 			}
 		}
 
-		$this->debugLevel=0;
+		$this->debugLevel = 0;
 
 		if ($send && $asf)
 		{
-			ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' -> send successfully');
+			ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__.' -> send successfully');
 			return true;
 		}
 		else
 		{
-			ZLog::Write(LOGLEVEL_DEBUG,__METHOD__." returning ".($ClientSideMeetingRequest ? true : 120)." (MailSubmissionFailed)".($ClientSideMeetingRequest ?" is ClientSideMeetingRequest (we ignore the failure)":""));
-			return ($ClientSideMeetingRequest ? true : 120);   //MAIL Submission failed, see MS-ASCMD
+			ZLog::Write(LOGLEVEL_DEBUG, __METHOD__." returning ".($ClientSideMeetingRequest ? true : 120)." (MailSubmissionFailed)".($ClientSideMeetingRequest ? " is ClientSideMeetingRequest (we ignore the failure)" : ""));
+			return ($ClientSideMeetingRequest ? true : 120); //MAIL Submission failed, see MS-ASCMD
 		}
 	}
 
@@ -817,48 +817,48 @@ 
 	public function GetMessage($folderid, $id, $contentparameters)
 	{
 		//$this->debugLevel=4;
-		ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' FolderID:'.$folderid.' ID:'.$id.' ContentParams='.array2string($contentparameters));
+		ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__.' FolderID:'.$folderid.' ID:'.$id.' ContentParams='.array2string($contentparameters));
 		$truncsize = Utils::GetTruncSize($contentparameters->GetTruncation());
 		$mimesupport = $contentparameters->GetMimeSupport();
-		ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."() truncsize=$truncsize, mimeSupport=".array2string($mimesupport));
+		ZLog::Write(LOGLEVEL_DEBUG, __METHOD__."() truncsize=$truncsize, mimeSupport=".array2string($mimesupport));
 		$bodypreference = $contentparameters->GetBodyPreference(); /* fmbiete's contribution r1528, ZP-320 */
 
 		// fix for z-push bug returning additional bodypreference type 4, even if only 1 is requested and mimessupport = 0
 		if (!$mimesupport && ($key = array_search('4', $bodypreference))) unset($bodypreference[$key]);
 
 		//$this->debugLevel=4;
-		if (!isset($this->mail)) $this->mail = Mail::getInstance(false,self::$profileID,true,false,true);
-		ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' FolderID:'.$folderid.' ID:'.$id.' TruncSize:'.$truncsize.' Bodypreference: '.array2string($bodypreference));
+		if (!isset($this->mail)) $this->mail = Mail::getInstance(false, self::$profileID, true, false, true);
+		ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__.' FolderID:'.$folderid.' ID:'.$id.' TruncSize:'.$truncsize.' Bodypreference: '.array2string($bodypreference));
 		$account = $_folderName = $xid = null;
-		$this->splitID($folderid,$account,$_folderName,$xid);
+		$this->splitID($folderid, $account, $_folderName, $xid);
 		$this->mail->reopen($_folderName);
 		$stat = $this->StatMessage($folderid, $id);
-		if ($this->debugLevel>3) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.array2string($stat));
+		if ($this->debugLevel > 3) ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__.array2string($stat));
 		// StatMessage should reopen the folder in question, so we dont need folderids in the following statements.
 		if ($stat)
 		{
-			ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__." Message $id with stat ".array2string($stat));
+			ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__." Message $id with stat ".array2string($stat));
 			// initialize the object
 			$output = new SyncMail();
-			$headers = $this->mail->getMessageHeader($id,'',true,true,$_folderName);
+			$headers = $this->mail->getMessageHeader($id, '', true, true, $_folderName);
 			if (empty($headers))
 			{
 				error_log(__METHOD__.__LINE__.' Retrieval of Headers Failed! for .'.$this->account.'/'.$GLOBALS['egw_info']['user']['account_lid'].' ServerID:'.self::$profileID.'FolderID:'.$folderid.'/'.$_folderName.' ID:'.$id.' TruncSize:'.$truncsize.' Bodypreference: '.array2string($bodypreference).' Stat was:'.array2string($stat));
-				return $output;//empty object
+				return $output; //empty object
 			}
 			//$rawHeaders = $this->mail->getMessageRawHeader($id);
 			// simple style
 			// start AS12 Stuff (bodypreference === false) case = old behaviour
-			if ($this->debugLevel>0) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__. ' for message with ID:'.$id.' with headers:'.array2string($headers));
+			if ($this->debugLevel > 0) ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__.' for message with ID:'.$id.' with headers:'.array2string($headers));
 
 			if ($bodypreference === false) {
-				$bodyStruct = $this->mail->getMessageBody($id, 'only_if_no_text', '', null, true,$_folderName);
-				$raw_body = $this->mail->getdisplayableBody($this->mail,$bodyStruct,false,false);
+				$bodyStruct = $this->mail->getMessageBody($id, 'only_if_no_text', '', null, true, $_folderName);
+				$raw_body = $this->mail->getdisplayableBody($this->mail, $bodyStruct, false, false);
 				//$body = html_entity_decode($body,ENT_QUOTES,$this->mail->detect_encoding($body));
-				if (stripos($raw_body,'<style')!==false) $body = preg_replace("/<style.*?<\/style>/is", "", $raw_body); // in case there is only a html part
+				if (stripos($raw_body, '<style') !== false) $body = preg_replace("/<style.*?<\/style>/is", "", $raw_body); // in case there is only a html part
 				// remove all other html
 				$body = strip_tags($raw_body);
-				if(strlen($body) > $truncsize) {
+				if (strlen($body) > $truncsize) {
 					$body = Utils::Utf8_truncate($body, $truncsize);
 					$output->bodytruncated = 1;
 				}
@@ -872,7 +872,7 @@ 
 			else // style with bodypreferences
 			{
 				//Select body type preference
-				$bpReturnType = 1;//SYNC_BODYPREFERENCE_PLAIN;
+				$bpReturnType = 1; //SYNC_BODYPREFERENCE_PLAIN;
 				if ($bodypreference !== false) {
 					// bodypreference can occur multiple times
 					// usually we would use Utils::GetBodyPreferenceBestMatch($bodypreference);
@@ -886,66 +886,66 @@ 
 					}
 */
 				}
-				ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__." getBodyPreferenceBestMatch: ".array2string($bpReturnType));
+				ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__." getBodyPreferenceBestMatch: ".array2string($bpReturnType));
 				// set the protocoll class
 				$output->asbody = new SyncBaseBody();
 				// fetch the body (try to gather data only once)
-				$css ='';
-				$bodyStruct = $this->mail->getMessageBody($id, 'html_only', '', null, true,$_folderName);
-				if ($this->debugLevel>2) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' html_only Struct:'.array2string($bodyStruct));
-				$body = $this->mail->getdisplayableBody($this->mail,$bodyStruct,true,false);
-				if ($this->debugLevel>3) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' html_only:'.$body);
-				if ($body != "" && (is_array($bodyStruct) && $bodyStruct[0]['mimeType']=='text/html')) {
+				$css = '';
+				$bodyStruct = $this->mail->getMessageBody($id, 'html_only', '', null, true, $_folderName);
+				if ($this->debugLevel > 2) ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__.' html_only Struct:'.array2string($bodyStruct));
+				$body = $this->mail->getdisplayableBody($this->mail, $bodyStruct, true, false);
+				if ($this->debugLevel > 3) ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__.' html_only:'.$body);
+				if ($body != "" && (is_array($bodyStruct) && $bodyStruct[0]['mimeType'] == 'text/html')) {
 					// may be html
-					if ($this->debugLevel>0) debugLog("MIME Body".' Type:html (fetched with html_only)');
+					if ($this->debugLevel > 0) debugLog("MIME Body".' Type:html (fetched with html_only)');
 					$css = $this->mail->getStyles($bodyStruct);
-					$output->nativebodytype=2;
+					$output->nativebodytype = 2;
 				} else {
 					// plain text Message
-					if ($this->debugLevel>0) debugLog("MIME Body".' Type:plain, fetch text (HTML, if no text available)');
-					$output->nativebodytype=1;
-					$bodyStruct = $this->mail->getMessageBody($id,'never_display', '', null, true,$_folderName); //'only_if_no_text');
-					if ($this->debugLevel>3) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' plain text Struct:'.array2string($bodyStruct));
-					$body = $this->mail->getdisplayableBody($this->mail,$bodyStruct,false,false);
-					if ($this->debugLevel>3) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' never display html(plain text only):'.$body);
+					if ($this->debugLevel > 0) debugLog("MIME Body".' Type:plain, fetch text (HTML, if no text available)');
+					$output->nativebodytype = 1;
+					$bodyStruct = $this->mail->getMessageBody($id, 'never_display', '', null, true, $_folderName); //'only_if_no_text');
+					if ($this->debugLevel > 3) ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__.' plain text Struct:'.array2string($bodyStruct));
+					$body = $this->mail->getdisplayableBody($this->mail, $bodyStruct, false, false);
+					if ($this->debugLevel > 3) ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__.' never display html(plain text only):'.$body);
 				}
 				// whatever format decode (using the correct encoding)
-				if ($this->debugLevel>3) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__."MIME Body".' Type:'.($output->nativebodytype==2?' html ':' plain ').$body);
+				if ($this->debugLevel > 3) ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__."MIME Body".' Type:'.($output->nativebodytype == 2 ? ' html ' : ' plain ').$body);
 				//$body = html_entity_decode($body,ENT_QUOTES,$this->mail->detect_encoding($body));
 				// prepare plaintextbody
-				$plainBody='';
+				$plainBody = '';
 				if ($output->nativebodytype == 2)
 				{
-					$bodyStructplain = $this->mail->getMessageBody($id,'never_display', '', null, true,$_folderName); //'only_if_no_text');
-					if(isset($bodyStructplain[0])&&isset($bodyStructplain[0]['error'])&&$bodyStructplain[0]['error']==1)
+					$bodyStructplain = $this->mail->getMessageBody($id, 'never_display', '', null, true, $_folderName); //'only_if_no_text');
+					if (isset($bodyStructplain[0]) && isset($bodyStructplain[0]['error']) && $bodyStructplain[0]['error'] == 1)
 					{
 						$plainBody = Api\Mail\Html::convertHTMLToText($body); // always display with preserved HTML
 					}
 					else
 					{
-						$plainBody = $this->mail->getdisplayableBody($this->mail,$bodyStructplain,false,false);
+						$plainBody = $this->mail->getdisplayableBody($this->mail, $bodyStructplain, false, false);
 					}
 				}
 				//if ($this->debugLevel>0) debugLog("MIME Body".$body);
-				$plainBody = preg_replace("/<style.*?<\/style>/is", "", (strlen($plainBody)?$plainBody:$body));
+				$plainBody = preg_replace("/<style.*?<\/style>/is", "", (strlen($plainBody) ? $plainBody : $body));
 				// remove all other html
-				$plainBody = preg_replace("/<br.*>/is","\r\n",$plainBody);
+				$plainBody = preg_replace("/<br.*>/is", "\r\n", $plainBody);
 				$plainBody = strip_tags($plainBody);
-				if ($this->debugLevel>3 && $output->nativebodytype==1) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' Plain Text:'.$plainBody);
+				if ($this->debugLevel > 3 && $output->nativebodytype == 1) ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__.' Plain Text:'.$plainBody);
 				//$body = str_replace("\n","\r\n", str_replace("\r","",$body)); // do we need that?
-				if ($bpReturnType==SYNC_BODYPREFERENCE_MIME)//4)//$mimesupport==2 || $mimesupport ==1 && stristr($headers['CONTENT-TYPE'],'signed') !== false)
+				if ($bpReturnType == SYNC_BODYPREFERENCE_MIME)//4)//$mimesupport==2 || $mimesupport ==1 && stristr($headers['CONTENT-TYPE'],'signed') !== false)
 				{
 					//SYNC_BODYPREFERENCE_MIME
-					ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__." bodypreference 4 requested");
-					$output->asbody->type = SYNC_BODYPREFERENCE_MIME;//4;
+					ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__." bodypreference 4 requested");
+					$output->asbody->type = SYNC_BODYPREFERENCE_MIME; //4;
 					// use Api\Mailer::convert to convert charset of all text parts to utf-8, which is a z-push or AS requirement!
 					$Body = Api\Mailer::convert($this->mail->getMessageRawBody($id, '', $_folderName));
-					if ($this->debugLevel>2) debugLog(__METHOD__.__LINE__." Setting Mailobjectcontent to output:".$Body);
+					if ($this->debugLevel > 2) debugLog(__METHOD__.__LINE__." Setting Mailobjectcontent to output:".$Body);
 					$output->asbody->data = $Body;
 				}
-				else if ($bpReturnType==2) //SYNC_BODYPREFERENCE_HTML
+				else if ($bpReturnType == 2) //SYNC_BODYPREFERENCE_HTML
 				{
-					if ($this->debugLevel>0) debugLog("HTML Body with requested pref 2");
+					if ($this->debugLevel > 0) debugLog("HTML Body with requested pref 2");
 					// Send HTML if requested and native type was html
 					$output->asbody->type = 2;
 					$htmlbody = '<html>'.
@@ -955,7 +955,7 @@ 
 						$css.
 						'</head>'.
 						'<body>';
-					if ($output->nativebodytype==2)
+					if ($output->nativebodytype == 2)
 					{
 						// as we fetch html, and body is HTML, we may not need to handle this
 						$htmlbody .= $body;
@@ -963,14 +963,14 @@ 
 					else
 					{
 						// html requested but got only plaintext, so fake html
-						$htmlbody .= str_replace("\n","<BR>",str_replace("\r","<BR>", str_replace("\r\n","<BR>",$plainBody)));
+						$htmlbody .= str_replace("\n", "<BR>", str_replace("\r", "<BR>", str_replace("\r\n", "<BR>", $plainBody)));
 					}
 					$htmlbody .= '</body>'.
 							'</html>';
 
-					if(isset($truncsize) && strlen($htmlbody) > $truncsize)
+					if (isset($truncsize) && strlen($htmlbody) > $truncsize)
 					{
-						$htmlbody = Utils::Utf8_truncate($htmlbody,$truncsize);
+						$htmlbody = Utils::Utf8_truncate($htmlbody, $truncsize);
 						$output->asbody->truncated = 1;
 					}
 					// output->nativebodytype is used as marker that the original message was of type ... but is now converted to, as type 2 is requested.
@@ -980,7 +980,7 @@ 
 				else
 				{
 					// Send Plaintext as Fallback or if original body is plainttext
-					if ($this->debugLevel>0) debugLog("Plaintext Body:".$plainBody);
+					if ($this->debugLevel > 0) debugLog("Plaintext Body:".$plainBody);
 					/* we use plainBody (set above) instead
 					$bodyStruct = $this->mail->getMessageBody($id,'only_if_no_text'); //'never_display');
 					$plain = $this->mail->getdisplayableBody($this->mail,$bodyStruct);
@@ -990,7 +990,7 @@ 
 					*/
 					$output->asbody->type = 1;
 					$output->nativebodytype = 1;
-					if(isset($truncsize) &&
+					if (isset($truncsize) &&
 			    		strlen($plainBody) > $truncsize)
 					{
 						$plainBody = Utils::Utf8_truncate($plainBody, $truncsize);
@@ -1008,7 +1008,7 @@ 
 				$output->asbody->estimatedDataSize = strlen($output->asbody->data);
 			}
 			// end AS12 Stuff
-			ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' gather Header info:'.$headers['SUBJECT'].' from:'.$headers['DATE']);
+			ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__.' gather Header info:'.$headers['SUBJECT'].' from:'.$headers['DATE']);
 			$output->read = $stat["flags"];
 
 			$output->flag = new SyncMailFlags();
@@ -1028,20 +1028,19 @@ 
 				$output->lastverexecuted = AS_FORWARD;
 			}
 			$output->subject = $this->messages[$id]['subject'];
-			$output->importance = $this->messages[$id]['priority'] > 3 ? 0 :
-				($this->messages[$id]['priority'] < 3 ? 2 : 1) ;
-			$output->datereceived = $this->mail->_strtotime($headers['DATE'],'ts',true);
+			$output->importance = $this->messages[$id]['priority'] > 3 ? 0 : ($this->messages[$id]['priority'] < 3 ? 2 : 1);
+			$output->datereceived = $this->mail->_strtotime($headers['DATE'], 'ts', true);
 //error_log(__METHOD__.__LINE__.' To:'.$headers['TO']);
 			$output->to = $headers['TO'];
-			if ($headers['TO']) $output->displayto = ($headers['TO'] ? $headers['TO']:null); //$stat['FETCHED_HEADER']['to_name']
+			if ($headers['TO']) $output->displayto = ($headers['TO'] ? $headers['TO'] : null); //$stat['FETCHED_HEADER']['to_name']
 //error_log(__METHOD__.__LINE__.' From:'.$headers['FROM']);
 			$output->from = $headers['FROM'];
-			if (isset($headers['CC']) && $headers['CC']) $output->cc = ($headers['CC'] ? $headers['CC']:null);
-			if (isset($headers['REPLY_TO']) && $headers['REPLY_TO']) $output->reply_to = ($headers['REPLY_TO']?$headers['REPLY_TO']:null);
+			if (isset($headers['CC']) && $headers['CC']) $output->cc = ($headers['CC'] ? $headers['CC'] : null);
+			if (isset($headers['REPLY_TO']) && $headers['REPLY_TO']) $output->reply_to = ($headers['REPLY_TO'] ? $headers['REPLY_TO'] : null);
 
 			$output->messageclass = "IPM.Note";
-			if (stripos($this->messages[$id]['mimetype'],'multipart')!== false &&
-				stripos($this->messages[$id]['mimetype'],'signed')!== false)
+			if (stripos($this->messages[$id]['mimetype'], 'multipart') !== false &&
+				stripos($this->messages[$id]['mimetype'], 'signed') !== false)
 			{
 				$output->messageclass = "IPM.Note.SMIME.MultipartSigned";
 			}
@@ -1050,20 +1049,20 @@ 
 			}
 
 			// start handle Attachments (include text/calendar multipart alternative)
-			$attachments = $this->mail->getMessageAttachments($id, $_partID='', $_structure=null, $fetchEmbeddedImages=true, $fetchTextCalendar=true, true, $_folderName);
+			$attachments = $this->mail->getMessageAttachments($id, $_partID = '', $_structure = null, $fetchEmbeddedImages = true, $fetchTextCalendar = true, true, $_folderName);
 			// Attachments should not needed for MIME messages, so skip this part if bpReturnType==4
-			if (/*$bpReturnType != SYNC_BODYPREFERENCE_MIME &&*/ is_array($attachments) && count($attachments)>0)
+			if (/*$bpReturnType != SYNC_BODYPREFERENCE_MIME &&*/ is_array($attachments) && count($attachments) > 0)
 			{
-				ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' gather Attachments for MessageID:'.$id.' found:'.count($attachments));
+				ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__.' gather Attachments for MessageID:'.$id.' found:'.count($attachments));
 				//error_log(__METHOD__.__LINE__.array2string($attachments));
 				foreach ($attachments as $key => $attach)
 				{
-					if ($this->debugLevel>0) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' Key:'.$key.'->'.array2string($attach));
+					if ($this->debugLevel > 0) ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__.' Key:'.$key.'->'.array2string($attach));
 
 					// pass meeting requests to calendar plugin
 					if (strtolower($attach['mimeType']) == 'text/calendar' && strtolower($attach['method']) == 'request' &&
 						isset($GLOBALS['egw_info']['user']['apps']['calendar']) &&
-						($attachment = $this->mail->getAttachment($id, $attach['partID'],0,false,false,$_folderName)) &&
+						($attachment = $this->mail->getAttachment($id, $attach['partID'], 0, false, false, $_folderName)) &&
 						($output->meetingrequest = calendar_zpush::meetingRequest($attachment['attachment'])))
 					{
 						//overwrite the globalobjId from calendar object, as: if you delete the mail, that is
@@ -1073,7 +1072,7 @@ 
 						$output->messageclass = "IPM.Schedule.Meeting.Request";
 						//$output->messageclass = "IPM.Schedule.Meeting";
 						unset($attachment);
-						continue;	// do NOT add attachment as attachment
+						continue; // do NOT add attachment as attachment
 					}
 					if (Request::GetProtocolVersion() >= 12.0) {
 						$attachment = new SyncBaseAttachment();
@@ -1081,33 +1080,33 @@ 
 							$output->asattachments = array();
 						$attachment->estimatedDataSize = $attach['size'];
 						$attachment->method = 1;
-						$attachment->filereference = $folderid . ":" . $id . ":" . $attach['partID'];
+						$attachment->filereference = $folderid.":".$id.":".$attach['partID'];
 					} else {
 						$attachment = new SyncAttachment();
 						if (!isset($output->attachments) || !is_array($output->attachments))
 							$output->attachments = array();
 						$attachment->attsize = $attach['size'];
 						$attachment->attmethod = 1;
-						$attachment->attname = $folderid . ":" . $id . ":" . $attach['partID'];//$key;
+						$attachment->attname = $folderid.":".$id.":".$attach['partID']; //$key;
 					}
 
 					$attachment->displayname = $attach['name'];
 					//error_log(__METHOD__.__LINE__.'->'.$folderid . ":" . $id . ":" . $attach['partID']);
 
-					$attachment->attoid = "";//isset($part->headers['content-id']) ? trim($part->headers['content-id']) : "";
+					$attachment->attoid = ""; //isset($part->headers['content-id']) ? trim($part->headers['content-id']) : "";
 					//$attachment->isinline=0; // if not inline, do not use isinline
-					if (!empty($attach['cid']) && $attach['cid'] <> 'NIL' )
+					if (!empty($attach['cid']) && $attach['cid'] <> 'NIL')
 					{
 						if ($bpReturnType != 4 && $attach['disposition'] == 'inline')
 						{
 							$attachment->isinline = true;
 						}
 						if (Request::GetProtocolVersion() >= 12.0) {
-							$attachment->method=1;
-							$attachment->contentid= str_replace(array("<",">"), "",$attach['cid']);
+							$attachment->method = 1;
+							$attachment->contentid = str_replace(array("<", ">"), "", $attach['cid']);
 						} else {
-							$attachment->attmethod=6;
-							$attachment->attoid = str_replace(array("<",">"), "",$attach['cid']);
+							$attachment->attmethod = 6;
+							$attachment->attoid = str_replace(array("<", ">"), "", $attach['cid']);
 						}
 						//	debugLog("'".$part->headers['content-id']."'  ".$attachment->contentid);
 						$attachment->contenttype = trim($attach['mimeType']);
@@ -1128,7 +1127,7 @@ 
             // Language Code Page ID: http://msdn.microsoft.com/en-us/library/windows/desktop/dd317756%28v=vs.85%29.aspx
             $output->internetcpid = INTERNET_CPID_UTF8;
 
-			if ($this->debugLevel>3) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.array2string($output));
+			if ($this->debugLevel > 3) ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__.array2string($output));
 //$this->debugLevel=0;
 			return $output;
 		}
@@ -1151,30 +1150,30 @@ 
 	{
 		if (!class_exists('calendar_zpush'))
 		{
-			ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(...) no EGroupware calendar installed!");
+			ZLog::Write(LOGLEVEL_DEBUG, __METHOD__."(...) no EGroupware calendar installed!");
 			return null;
 		}
 		if (!($stat = $this->StatMessage($folderid, $requestid)))
 		{
-			ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."($requestid, '$folderid', $response) returning FALSE (can NOT stat message)");
+			ZLog::Write(LOGLEVEL_DEBUG, __METHOD__."($requestid, '$folderid', $response) returning FALSE (can NOT stat message)");
 			return false;
 		}
 		$ret = false;
-		foreach($this->mail->getMessageAttachments($requestid, $_partID='', $_structure=null, $fetchEmbeddedImages=true, $fetchTextCalendar=true) as $key => $attach)
+		foreach ($this->mail->getMessageAttachments($requestid, $_partID = '', $_structure = null, $fetchEmbeddedImages = true, $fetchTextCalendar = true) as $key => $attach)
 		{
 			if (strtolower($attach['mimeType']) == 'text/calendar' && strtolower($attach['method']) == 'request' &&
-				($attachment = $this->mail->getAttachment($requestid, $attach['partID'],0,false)))
+				($attachment = $this->mail->getAttachment($requestid, $attach['partID'], 0, false)))
 			{
-				ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."($requestid, '$folderid', $response) iCal found, calling now backend->MeetingResponse('$attachment[attachment]')");
+				ZLog::Write(LOGLEVEL_DEBUG, __METHOD__."($requestid, '$folderid', $response) iCal found, calling now backend->MeetingResponse('$attachment[attachment]')");
 
 				// calling backend again with iCal attachment, to let calendar add the event
 				$ret = $this->backend->MeetingResponse($attachment['attachment'],
-					$this->backend->createID('calendar',$GLOBALS['egw_info']['user']['account_id']),
+					$this->backend->createID('calendar', $GLOBALS['egw_info']['user']['account_id']),
 					$response);
 				break;
 			}
 		}
-		ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."($requestid, '$folderid', $response) returning ".array2string($ret));
+		ZLog::Write(LOGLEVEL_DEBUG, __METHOD__."($requestid, '$folderid', $response) returning ".array2string($ret));
 		return $ret;
 	}
 
@@ -1188,22 +1187,22 @@ 
      * @param string $attname - should contain (folder)id
 	 * @return true, prints the content of the attachment
 	 */
-	function GetAttachmentData($fid,$attname) {
-		ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.": $fid (attname: '$attname')".function_backtrace());
+	function GetAttachmentData($fid, $attname) {
+		ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.": $fid (attname: '$attname')".function_backtrace());
 		//error_log(__METHOD__.__LINE__." Fid: $fid (attname: '$attname')");
 		list($folderid, $id, $part) = explode(":", $attname);
 
 		$this->splitID($folderid, $account, $folder);
 
-		if (!isset($this->mail)) $this->mail = Mail::getInstance(false,self::$profileID,true,false,true);
+		if (!isset($this->mail)) $this->mail = Mail::getInstance(false, self::$profileID, true, false, true);
 
 		$this->mail->reopen($folder);
-		$attachment = $this->mail->getAttachment($id,$part,0,false,true,$folder);
+		$attachment = $this->mail->getAttachment($id, $part, 0, false, true, $folder);
         $SIOattachment = new SyncItemOperationsAttachment();
-		fseek($attachment['attachment'], 0, SEEK_SET);	// z-push requires stream seeked to start
+		fseek($attachment['attachment'], 0, SEEK_SET); // z-push requires stream seeked to start
         $SIOattachment->data = $attachment['attachment'];
 		//ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.": $fid (attname: '$attname') Data:".$attachment['attachment']);
-        if (isset($attachment['type']) )
+        if (isset($attachment['type']))
             $SIOattachment->contenttype = $attachment['type'];
 
 		unset($attachment);
@@ -1221,21 +1220,21 @@ 
      * @param string $attname - should contain (folder)id
 	 * @return SyncItemOperationsAttachment-object
 	 */
-	function ItemOperationsGetAttachmentData($fid,$attname) {
-		ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.": $fid (attname: '$attname')".function_backtrace());
+	function ItemOperationsGetAttachmentData($fid, $attname) {
+		ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.": $fid (attname: '$attname')".function_backtrace());
 		//error_log(__METHOD__.__LINE__." Fid: $fid (attname: '$attname')");
 		list($folderid, $id, $part) = explode(":", $attname);
 
 		$this->splitID($folderid, $account, $folder);
 
-		if (!isset($this->mail)) $this->mail = Mail::getInstance(false,self::$profileID,true,false,true);
+		if (!isset($this->mail)) $this->mail = Mail::getInstance(false, self::$profileID, true, false, true);
 
 		$this->mail->reopen($folder);
-		$attachment = $this->mail->getAttachment($id,$part,0,false,true,$folder);
+		$attachment = $this->mail->getAttachment($id, $part, 0, false, true, $folder);
         $SIOattachment = new SyncItemOperationsAttachment();
-		fseek($attachment['attachment'], 0, SEEK_SET);	// z-push requires stream seeked to start
+		fseek($attachment['attachment'], 0, SEEK_SET); // z-push requires stream seeked to start
         $SIOattachment->data = $attachment['attachment'];
-        if (isset($attachment['type']) )
+        if (isset($attachment['type']))
             $SIOattachment->contenttype = $attachment['type'];
 
 		unset($attachment);
@@ -1278,17 +1277,17 @@ 
 	 */
 	function ChangeMessage($folderid, $id, $message, $contentParameters)
 	{
-		ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__." $folderid, $id,".array2string($message).",".array2string($contentParameters));
+		ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__." $folderid, $id,".array2string($message).",".array2string($contentParameters));
 		//unset($folderid, $id, $message, $contentParameters);
 		$account = $folder = null;
 		$this->splitID($folderid, $account, $folder);
 		if (isset($message->flag)) {
 			if (isset($message->flag->flagstatus) && $message->flag->flagstatus == 2) {
-				$rv = $this->mail->flagMessages((($message->flag->flagstatus == 2) ? "flagged" : "unflagged"), $id,$folder);
-				ZLog::Write(LOGLEVEL_DEBUG,__METHOD__." -> set ".array2string($id).' in Folder '.$folder." as " . (($message->flag->flagstatus == 2) ? "flagged" : "unflagged") . "-->". $rv);
+				$rv = $this->mail->flagMessages((($message->flag->flagstatus == 2) ? "flagged" : "unflagged"), $id, $folder);
+				ZLog::Write(LOGLEVEL_DEBUG, __METHOD__." -> set ".array2string($id).' in Folder '.$folder." as ".(($message->flag->flagstatus == 2) ? "flagged" : "unflagged")."-->".$rv);
 			} else {
-				$rv = $this->mail->flagMessages("unflagged", $id,$folder);
-				ZLog::Write(LOGLEVEL_DEBUG,__METHOD__." -> set ".array2string($id).' in Folder '.$folder." as " . "unflagged" . "-->". $rv);
+				$rv = $this->mail->flagMessages("unflagged", $id, $folder);
+				ZLog::Write(LOGLEVEL_DEBUG, __METHOD__." -> set ".array2string($id).' in Folder '.$folder." as "."unflagged"."-->".$rv);
 			}
 		}
 		return $this->StatMessage($folderid, $id);
@@ -1310,23 +1309,23 @@ 
 	 */
 	public function MoveMessage($folderid, $id, $newfolderid, $contentParameters)
 	{
-		unset($contentParameters);	// not used, but required by function signature
+		unset($contentParameters); // not used, but required by function signature
 		debugLog("IMAP-MoveMessage: (sfid: '$folderid'  id: '$id'  dfid: '$newfolderid' )");
 		$account = $srcFolder = $destFolder = null;
 		$this->splitID($folderid, $account, $srcFolder);
 		$this->splitID($newfolderid, $account, $destFolder);
 		debugLog("IMAP-MoveMessage: (SourceFolder: '$srcFolder'  id: '$id'  DestFolder: '$destFolder' )");
-		if (!isset($this->mail)) $this->mail = Mail::getInstance(false,self::$profileID,true,false,true);
+		if (!isset($this->mail)) $this->mail = Mail::getInstance(false, self::$profileID, true, false, true);
 		$this->mail->reopen($destFolder);
 		$status = $this->mail->getFolderStatus($destFolder);
 		$uidNext = $status['uidnext'];
 		$this->mail->reopen($srcFolder);
 
 		// move message
-		$rv = $this->mail->moveMessages($destFolder,(array)$id,true,$srcFolder,true);
-		ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.": New Status of $destFolder :".array2string($status).", ReturnValOf moveMessage".array2string($rv)); // this may be true, so try using the nextUID value by examine
+		$rv = $this->mail->moveMessages($destFolder, (array)$id, true, $srcFolder, true);
+		ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__.": New Status of $destFolder :".array2string($status).", ReturnValOf moveMessage".array2string($rv)); // this may be true, so try using the nextUID value by examine
 		// return the new id "as string"
-		return ($rv===true ? $uidNext : $rv[$id]) . "";
+		return ($rv === true ? $uidNext : $rv[$id])."";
 	}
 
 	/**
@@ -1334,87 +1333,87 @@ 
 	 *
 	 *  @ToDo loop over available email accounts
 	 */
-	public function GetMessageList($folderid, $cutoffdate=NULL)
+	public function GetMessageList($folderid, $cutoffdate = NULL)
 	{
-		static $cutdate=null;
-		if (!empty($cutoffdate) && $cutoffdate >0 && (empty($cutdate) || $cutoffdate != $cutdate))  $cutdate = $cutoffdate;
-		debugLog (__METHOD__.' for Folder:'.$folderid.' SINCE:'.$cutdate.'/'.date("d-M-Y", $cutdate));
+		static $cutdate = null;
+		if (!empty($cutoffdate) && $cutoffdate > 0 && (empty($cutdate) || $cutoffdate != $cutdate))  $cutdate = $cutoffdate;
+		debugLog(__METHOD__.' for Folder:'.$folderid.' SINCE:'.$cutdate.'/'.date("d-M-Y", $cutdate));
 		if (empty($cutdate))
 		{
-			$cutdate = Api\DateTime::to('now','ts')-(3600*24*28*3);
-			ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.' Client set no truncationdate. Using 12 weeks.'.date("d-M-Y", $cutdate));
+			$cutdate = Api\DateTime::to('now', 'ts') - (3600 * 24 * 28 * 3);
+			ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.' Client set no truncationdate. Using 12 weeks.'.date("d-M-Y", $cutdate));
 		}
 		return $this->fetchMessages($folderid, $cutdate);
 	}
 
-	private function fetchMessages($folderid, $cutoffdate=NULL, $_id=NULL)
+	private function fetchMessages($folderid, $cutoffdate = NULL, $_id = NULL)
 	{
-		if ($this->debugLevel>1) $gstarttime = microtime (true);
+		if ($this->debugLevel > 1) $gstarttime = microtime(true);
 		//ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__);
 		$rv_messages = array();
 		// if the message is still available within the class, we use it instead of fetching it again
-		if (is_array($_id) && count($_id)==1 && is_array($this->messages) && isset($this->messages[$_id[0]]) && is_array($this->messages[$_id[0]]))
+		if (is_array($_id) && count($_id) == 1 && is_array($this->messages) && isset($this->messages[$_id[0]]) && is_array($this->messages[$_id[0]]))
 		{
 			//ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__." the message ".$_id[0]." is still available within the class, we use it instead of fetching it again");
 			$rv_messages = array('header'=>array($this->messages[$_id[0]]));
 		}
 		if (empty($rv_messages))
 		{
-			if ($this->debugLevel>1) $starttime = microtime (true);
+			if ($this->debugLevel > 1) $starttime = microtime(true);
 			$this->_connect($this->account);
-			if ($this->debugLevel>1)
+			if ($this->debugLevel > 1)
 			{
 				$endtime = microtime(true) - $starttime;
-				ZLog::Write(LOGLEVEL_DEBUG,__METHOD__. " connect took : ".$endtime.' for account:'.$this->account);
+				ZLog::Write(LOGLEVEL_DEBUG, __METHOD__." connect took : ".$endtime.' for account:'.$this->account);
 			}
 			$messagelist = $_filter = array();
 			// if not connected, any further action must fail
-			if (!empty($cutoffdate)) $_filter = array('status'=>array('UNDELETED'),'range'=>"SINCE",'date'=> date("d-M-Y", $cutoffdate));
-			if ($this->debugLevel>1) $starttime = microtime (true);
+			if (!empty($cutoffdate)) $_filter = array('status'=>array('UNDELETED'), 'range'=>"SINCE", 'date'=> date("d-M-Y", $cutoffdate));
+			if ($this->debugLevel > 1) $starttime = microtime(true);
 			$account = $_folderName = $id = null;
-			$this->splitID($folderid,$account,$_folderName,$id);
-			if ($this->debugLevel>1)
+			$this->splitID($folderid, $account, $_folderName, $id);
+			if ($this->debugLevel > 1)
 			{
 				$endtime = microtime(true) - $starttime;
-				ZLog::Write(LOGLEVEL_DEBUG,__METHOD__. " splitID took : ".$endtime.' for FolderID:'.$folderid);
+				ZLog::Write(LOGLEVEL_DEBUG, __METHOD__." splitID took : ".$endtime.' for FolderID:'.$folderid);
 			}
-			if ($this->debugLevel>1) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.' for Folder:'.$_folderName.' Filter:'.array2string($_filter).' Ids:'.array2string($_id).'/'.$id);
-			if ($this->debugLevel>1) $starttime = microtime (true);
-			$_numberOfMessages = (empty($cutoffdate)?250:99999);
-			$rv_messages = $this->mail->getHeaders($_folderName, $_startMessage=1, $_numberOfMessages, $_sort=0, $_reverse=false, $_filter, $_id);
-			if ($this->debugLevel>1)
+			if ($this->debugLevel > 1) ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.' for Folder:'.$_folderName.' Filter:'.array2string($_filter).' Ids:'.array2string($_id).'/'.$id);
+			if ($this->debugLevel > 1) $starttime = microtime(true);
+			$_numberOfMessages = (empty($cutoffdate) ? 250 : 99999);
+			$rv_messages = $this->mail->getHeaders($_folderName, $_startMessage = 1, $_numberOfMessages, $_sort = 0, $_reverse = false, $_filter, $_id);
+			if ($this->debugLevel > 1)
 			{
 				$endtime = microtime(true) - $starttime;
-				ZLog::Write(LOGLEVEL_DEBUG,__METHOD__. " getHeaders call took : ".$endtime.' for FolderID:'.$_folderName);
+				ZLog::Write(LOGLEVEL_DEBUG, __METHOD__." getHeaders call took : ".$endtime.' for FolderID:'.$_folderName);
 			}
 		}
-		if ($_id == NULL && $this->debugLevel>1)  ZLog::Write(LOGLEVEL_DEBUG,__METHOD__." found :". count($rv_messages['header']));
+		if ($_id == NULL && $this->debugLevel > 1)  ZLog::Write(LOGLEVEL_DEBUG, __METHOD__." found :".count($rv_messages['header']));
 		//ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' Result:'.array2string($rv_messages));
 		$messagelist = array();
-		if (!isset($rv_messages['header'])||empty($rv_messages['header'])) return $messagelist;
+		if (!isset($rv_messages['header']) || empty($rv_messages['header'])) return $messagelist;
 		//if ($_returnModHash) $messageFolderHash = array();
 		foreach ((array)$rv_messages['header'] as $k => $vars)
 		{
-			if ($this->debugLevel>3) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' ID to process:'.$vars['uid'].' Subject:'.$vars['subject']);
+			if ($this->debugLevel > 3) ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__.' ID to process:'.$vars['uid'].' Subject:'.$vars['subject']);
 			$this->messages[$vars['uid']] = $vars;
-			if ($this->debugLevel>3) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' MailID:'.$k.'->'.array2string($vars));
+			if ($this->debugLevel > 3) ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__.' MailID:'.$k.'->'.array2string($vars));
 			if (!empty($vars['deleted'])) continue; // cut of deleted messages
 			if ($cutoffdate && $vars['date'] < $cutoffdate) continue; // message is out of range for cutoffdate, ignore it
-			if ($this->debugLevel>0) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' ID to report:'.$vars['uid'].' Subject:'.$vars['subject']);
+			if ($this->debugLevel > 0) ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__.' ID to report:'.$vars['uid'].' Subject:'.$vars['subject']);
 			$mess["mod"] = self::doFlagsMod($vars).$vars['date'];
 			$mess["id"] = $vars['uid'];
 			// 'seen' aka 'read' is the only flag we want to know about
 			$mess["flags"] = 0;
 			// outlook supports additional flags, set them to 0
-			if($vars["seen"]) $mess["flags"] = 1;
-			if ($this->debugLevel>3) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.array2string($mess));
+			if ($vars["seen"]) $mess["flags"] = 1;
+			if ($this->debugLevel > 3) ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__.array2string($mess));
 			$messagelist[$vars['uid']] = $mess;
 			unset($mess);
 		}
-		if ($this->debugLevel>1)
+		if ($this->debugLevel > 1)
 		{
 			$endtime = microtime(true) - $gstarttime;
-			ZLog::Write(LOGLEVEL_DEBUG,__METHOD__. " total time used : ".$endtime.' for Folder:'.$_folderName.' Filter:'.array2string($_filter).' Ids:'.array2string($_id).'/'.$id);
+			ZLog::Write(LOGLEVEL_DEBUG, __METHOD__." total time used : ".$endtime.' for Folder:'.$_folderName.' Filter:'.array2string($_filter).' Ids:'.array2string($_id).'/'.$id);
 		}
 		return $messagelist;
 	}
@@ -1465,32 +1464,32 @@ 
 	public function getSearchResultsMailbox($_searchquery)
 	{
 		//$this->debugLevel=1;
-		$searchquery=$_searchquery->GetDataArray();
+		$searchquery = $_searchquery->GetDataArray();
 		if (!is_array($searchquery)) return array();
-		if ($this->debugLevel>0) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.array2string($searchquery));
+		if ($this->debugLevel > 0) ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__.array2string($searchquery));
 
 		if (isset($searchquery['searchrebuildresults'])) {
 			$rebuildresults = $searchquery['searchrebuildresults'];
 		} else {
 			$rebuildresults = false;
 		}
-		if ($this->debugLevel>0) debugLog( 'RebuildResults ['.$rebuildresults.']' );
+		if ($this->debugLevel > 0) debugLog('RebuildResults ['.$rebuildresults.']');
 
 		if (isset($searchquery['deeptraversal'])) {
 			$deeptraversal = $searchquery['deeptraversal'];
 		} else {
 			$deeptraversal = false;
 		}
-		if ($this->debugLevel>0) debugLog( 'DeepTraversal ['.$deeptraversal.']' );
+		if ($this->debugLevel > 0) debugLog('DeepTraversal ['.$deeptraversal.']');
 
 		if (isset($searchquery['searchrange'])) {
-			$range = explode("-",$_searchquery->GetSearchRange());
-			$start =$range[0] + 1;
+			$range = explode("-", $_searchquery->GetSearchRange());
+			$start = $range[0] + 1;
 			$limit = $range[1] - $range[0] + 1;
 		} else {
 			$range = false;
 		}
-		if ($this->debugLevel>0) debugLog( 'Range ['.print_r($range, true).']' );
+		if ($this->debugLevel > 0) debugLog('Range ['.print_r($range, true).']');
 
 		//foreach($searchquery['query'] as $k => $value) {
 		//	$query = $value;
@@ -1513,15 +1512,15 @@ 
 		}
 		if (!$folderid)
 		{
-			$_folderName = ($this->mail->sessionData['mailbox']?$this->mail->sessionData['mailbox']:'INBOX');
-			$folderid = $this->createID($account=0,$_folderName);
+			$_folderName = ($this->mail->sessionData['mailbox'] ? $this->mail->sessionData['mailbox'] : 'INBOX');
+			$folderid = $this->createID($account = 0, $_folderName);
 		}
-		$rv = $this->splitID($folderid,$account,$_folderName,$id);
-		ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' ProfileID:'.self::$profileID.' FolderID:'.$folderid.' Foldername:'.$_folderName);
+		$rv = $this->splitID($folderid, $account, $_folderName, $id);
+		ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__.' ProfileID:'.self::$profileID.' FolderID:'.$folderid.' Foldername:'.$_folderName);
 		$this->_connect($account);
 		// this should not be needed ???
-		Mail::$supportsORinQuery[self::$profileID]=true; // trigger quicksearch (if possible)
-		$_filter = array('type'=> (Mail::$supportsORinQuery[self::$profileID]?'quick':'subject'),
+		Mail::$supportsORinQuery[self::$profileID] = true; // trigger quicksearch (if possible)
+		$_filter = array('type'=> (Mail::$supportsORinQuery[self::$profileID] ? 'quick' : 'subject'),
 						 'string'=> $searchText,
 						 'status'=>'any'
 						);
@@ -1536,22 +1535,22 @@ 
 		 * 		[searchvalueless] => 2015-07-14T15:11:00.000Z , BEFORE
 		 */
 			$_filter['range'] = "BETWEEN";
-			list($sincedate,$crap) = explode('T',$searchquery['searchvaluegreater']);
-			list($beforedate,$crap) = explode('T',$searchquery['searchvalueless']);
-			$_filter['before'] = date("d-M-Y", Api\DateTime::to($beforedate,'ts'));
-			$_filter['since'] = date("d-M-Y", Api\DateTime::to($sincedate,'ts'));
+			list($sincedate, $crap) = explode('T', $searchquery['searchvaluegreater']);
+			list($beforedate, $crap) = explode('T', $searchquery['searchvalueless']);
+			$_filter['before'] = date("d-M-Y", Api\DateTime::to($beforedate, 'ts'));
+			$_filter['since'] = date("d-M-Y", Api\DateTime::to($sincedate, 'ts'));
 		}
 		//$_filter[] = array('type'=>"SINCE",'string'=> date("d-M-Y", $cutoffdate));
-		if ($this->debugLevel>1) debugLog (__METHOD__.' for Folder:'.$_folderName.' Filter:'.array2string($_filter));
-		$rv_messages = $this->mail->getHeaders($_folderName, $_startMessage=($range?$start:1), $_numberOfMessages=($limit?$limit:9999999), $_sort=0, $_reverse=false, $_filter, $_id=NULL);
+		if ($this->debugLevel > 1) debugLog(__METHOD__.' for Folder:'.$_folderName.' Filter:'.array2string($_filter));
+		$rv_messages = $this->mail->getHeaders($_folderName, $_startMessage = ($range ? $start : 1), $_numberOfMessages = ($limit ? $limit : 9999999), $_sort = 0, $_reverse = false, $_filter, $_id = NULL);
 		//ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.array2string($rv_messages));
-		$list=array();
+		$list = array();
 
 		$cnt = count($rv_messages['header']);
 		//$list['status'] = 1;
 		$list['searchtotal'] = $cnt;
 		$list["range"] = $_searchquery->GetSearchRange();
-		foreach((array)$rv_messages['header'] as $i => $vars)
+		foreach ((array)$rv_messages['header'] as $i => $vars)
 		{
 			$list[] = array(
 				"class" => "Email",
@@ -1571,20 +1570,20 @@ 
 	 * @param string $folder
 	 * @return string
 	 */
-	private function getParentID($account,$folder)
+	private function getParentID($account, $folder)
 	{
 		$this->_connect($account);
-		if (!isset($this->folders)) $this->folders = $this->mail->getFolderObjects(true,false);
+		if (!isset($this->folders)) $this->folders = $this->mail->getFolderObjects(true, false);
 
 		$mailFolder = $this->folders[$folder];
 		if (!isset($mailFolder)) return false;
-		$delimiter = (isset($mailFolder->delimiter)?$mailFolder->delimiter:$this->mail->getHierarchyDelimiter());
-		$parent = explode($delimiter,$folder);
+		$delimiter = (isset($mailFolder->delimiter) ? $mailFolder->delimiter : $this->mail->getHierarchyDelimiter());
+		$parent = explode($delimiter, $folder);
 		array_pop($parent);
-		$parent = implode($delimiter,$parent);
+		$parent = implode($delimiter, $parent);
 
 		$id = $parent ? $this->createID($account, $parent) : '0';
-		if ($this->debugLevel>1) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."('$folder') --> parent=$parent --> $id");
+		if ($this->debugLevel > 1) ZLog::Write(LOGLEVEL_DEBUG, __METHOD__."('$folder') --> parent=$parent --> $id");
 		return $id;
 	}
 
@@ -1604,48 +1603,48 @@ 
 			$account = $folder = null;
 			$this->splitID($id, $account, $folder);
 		}
-		catch(Exception $e) {
-			ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' failed for '.$e->getMessage());
-			return $folderObj=false;
+		catch (Exception $e) {
+			ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__.' failed for '.$e->getMessage());
+			return $folderObj = false;
 		}
 		$this->_connect($account);
-		if (!isset($this->folders)) $this->folders = $this->mail->getFolderObjects(true,false);
+		if (!isset($this->folders)) $this->folders = $this->mail->getFolderObjects(true, false);
 
 		$mailFolder = $this->folders[$folder];
-		if (!isset($mailFolder)) return $folderObj=false;
+		if (!isset($mailFolder)) return $folderObj = false;
 
 		$folderObj = new SyncFolder();
 		$folderObj->serverid = $id;
-		$folderObj->parentid = $this->getParentID($account,$folder);
+		$folderObj->parentid = $this->getParentID($account, $folder);
 		$folderObj->displayname = $mailFolder->shortDisplayName;
-		if ($this->debugLevel>1) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__." ID: $id, Account:$account, Folder:$folder");
+		if ($this->debugLevel > 1) ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__." ID: $id, Account:$account, Folder:$folder");
 		// get folder-type
-		foreach($this->folders as $inbox => $mailFolder) break;
+		foreach ($this->folders as $inbox => $mailFolder) break;
 		if ($folder == $inbox)
 		{
 			$folderObj->type = SYNC_FOLDER_TYPE_INBOX;
 		}
-		elseif($this->mail->isDraftFolder($folder, false))
+		elseif ($this->mail->isDraftFolder($folder, false))
 		{
 			//ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.' isDraft');
 			$folderObj->type = SYNC_FOLDER_TYPE_DRAFTS;
 			$folderObj->parentid = 0; // required by devices
 		}
-		elseif($this->mail->isTrashFolder($folder, false))
+		elseif ($this->mail->isTrashFolder($folder, false))
 		{
 			$folderObj->type = SYNC_FOLDER_TYPE_WASTEBASKET;
 			$this->_wasteID = $folder;
 			//error_log(__METHOD__.__LINE__.' TrashFolder:'.$this->_wasteID);
 			$folderObj->parentid = 0; // required by devices
 		}
-		elseif($this->mail->isSentFolder($folder, false))
+		elseif ($this->mail->isSentFolder($folder, false))
 		{
 			$folderObj->type = SYNC_FOLDER_TYPE_SENTMAIL;
 			$folderObj->parentid = 0; // required by devices
 			$this->_sentID = $folder;
 			//error_log(__METHOD__.__LINE__.' SentFolder:'.$this->_sentID);
 		}
-		elseif($this->mail->isOutbox($folder, false))
+		elseif ($this->mail->isOutbox($folder, false))
 		{
 			//ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.' isOutbox');
 			$folderObj->type = SYNC_FOLDER_TYPE_OUTBOX;
@@ -1657,7 +1656,7 @@ 
 			$folderObj->type = SYNC_FOLDER_TYPE_USER_MAIL;
 		}
 
-		if ($this->debugLevel>1) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."($id) --> $folder --> type=$folderObj->type, parentID=$folderObj->parentid, displayname=$folderObj->displayname");
+		if ($this->debugLevel > 1) ZLog::Write(LOGLEVEL_DEBUG, __METHOD__."($id) --> $folder --> type=$folderObj->type, parentID=$folderObj->parentid, displayname=$folderObj->displayname");
 		return $folderObj;
 	}
 
@@ -1702,22 +1701,22 @@ 
 		$account = $folder = null;
 		$this->splitID($folderid, $account, $folder);
 		if (is_numeric($account)) $type = 'mail';
-        ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.": on $folderid -> $folder ($account) type: ". $type);
+        ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.": on $folderid -> $folder ($account) type: ".$type);
 		if ($type != 'mail') return false;
 
-		if (!isset($this->mail)) $this->mail = Mail::getInstance(false,self::$profileID,true,false,true);
+		if (!isset($this->mail)) $this->mail = Mail::getInstance(false, self::$profileID, true, false, true);
 
 		$changes = array();
-        ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.": on $folderid ($folder) stat: ". $syncstate);
+        ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.": on $folderid ($folder) stat: ".$syncstate);
         $this->mail->reopen($folder);
-        $status = $this->mail->getFolderStatus($folder,$ignoreStatusCache=true);
+        $status = $this->mail->getFolderStatus($folder, $ignoreStatusCache = true);
         if (!$status) {
-            ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.": could not stat folder $folder ");
+            ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.": could not stat folder $folder ");
             return false;
         } else {
-            $syncstate = "M:". $status['messages'] ."-R:". $status['recent'] ."-U:". $status['unseen']."-NUID:".$status['uidnext']."-UIDV:".$status['uidvalidity'];
+            $syncstate = "M:".$status['messages']."-R:".$status['recent']."-U:".$status['unseen']."-NUID:".$status['uidnext']."-UIDV:".$status['uidvalidity'];
         }
-		ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.' called with ('.$folderid.', ....) returning '.array2string($syncstate));
+		ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.' called with ('.$folderid.', ....) returning '.array2string($syncstate));
 		return $changes;
 	}
 
@@ -1730,8 +1729,8 @@ 
 	function GetWasteBasket()
 	{
 		$this->_connect($this->account);
-		$id = $this->createID($account=0, $this->_wasteID);
-		ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__."() account=$this->account returned $id for folder $this->_wasteID");
+		$id = $this->createID($account = 0, $this->_wasteID);
+		ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__."() account=$this->account returned $id for folder $this->_wasteID");
 		return $id;
 	}
 
@@ -1752,7 +1751,7 @@ 
      */
     public function DeleteMessage($folderid, $id, $contentParameters)
 	{
-		unset($contentParameters);	// not used, but required by function signature
+		unset($contentParameters); // not used, but required by function signature
 		debugLog("IMAP-DeleteMessage: (fid: '$folderid'  id: '$id' )");
 		/*
 		$this->imap_reopenFolder($folderid);
@@ -1763,7 +1762,7 @@ 
 		// we may have to split folderid
 		$account = $folder = null;
 		$this->splitID($folderid, $account, $folder);
-		ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' '.$folderid.'->'.$folder);
+		ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__.' '.$folderid.'->'.$folder);
 		$_messageUID = (array)$id;
 
 		$this->_connect($this->account);
@@ -1775,9 +1774,9 @@ 
 		catch (Api\Exception $e)
 		{
 			$error = $e->getMessage();
-			ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__." $_messageUID, $folder ->".$error);
+			ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.__LINE__." $_messageUID, $folder ->".$error);
 			// if the server thinks the message does not exist report deletion as success
-			if (stripos($error,'[NONEXISTENT]')!==false) return true;
+			if (stripos($error, '[NONEXISTENT]') !== false) return true;
 			return false;
 		}
 
@@ -1811,15 +1810,15 @@ 
      */
     public function SetReadFlag($folderid, $id, $flags, $contentParameters)
 	{
-		unset($contentParameters);	// not used, but required by function signature
+		unset($contentParameters); // not used, but required by function signature
 		// debugLog("IMAP-SetReadFlag: (fid: '$folderid'  id: '$id'  flags: '$flags' )");
 		$account = $folder = null;
 		$this->splitID($folderid, $account, $folder);
 
 		$_messageUID = (array)$id;
 		$this->_connect($this->account);
-		$rv = $this->mail->flagMessages((($flags) ? "read" : "unread"), $_messageUID,$folder);
-		debugLog("IMAP-SetReadFlag -> set ".array2string($_messageUID).' in Folder '.$folder." as " . (($flags) ? "read" : "unread") . "-->". $rv);
+		$rv = $this->mail->flagMessages((($flags) ? "read" : "unread"), $_messageUID, $folder);
+		debugLog("IMAP-SetReadFlag -> set ".array2string($_messageUID).' in Folder '.$folder." as ".(($flags) ? "read" : "unread")."-->".$rv);
 
 		return $rv;
 	}
@@ -1836,7 +1835,7 @@ 
 	 */
 	public function ChangeFolder($id, $oldid, $displayname, $type)
 	{
-		ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."('$id', '$oldid', '$displayname', $type) NOT supported!");
+		ZLog::Write(LOGLEVEL_DEBUG, __METHOD__."('$id', '$oldid', '$displayname', $type) NOT supported!");
 		return false;
 	}
 
@@ -1851,7 +1850,7 @@ 
 	 */
 	public function DeleteFolder($parentid, $id)
 	{
-		ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."('$parentid', '$id') NOT supported!");
+		ZLog::Write(LOGLEVEL_DEBUG, __METHOD__."('$parentid', '$id') NOT supported!");
 		return false;
 	}
 
@@ -1871,8 +1870,8 @@ 
 		$this->_connect($this->account);
 		$account = $folder = null;
 		$this->splitID($folderid, $account, $folder);
-		$rv = $this->mail->flagMessages((($flags->flagstatus == 2) ? "flagged" : "unflagged"), $_messageUID,$folder);
-		debugLog("IMAP-SetFlaggedFlag -> set ".array2string($_messageUID).' in Folder '.$folder." as " . (($flags->flagstatus == 2) ? "flagged" : "unflagged") . "-->". $rv);
+		$rv = $this->mail->flagMessages((($flags->flagstatus == 2) ? "flagged" : "unflagged"), $_messageUID, $folder);
+		debugLog("IMAP-SetFlaggedFlag -> set ".array2string($_messageUID).' in Folder '.$folder." as ".(($flags->flagstatus == 2) ? "flagged" : "unflagged")."-->".$rv);
 
 		return $rv;
 	}
@@ -1886,17 +1885,17 @@ 
 	 * @return string
 	 * @throws Api\Exception\WrongParameter
 	 */
-	private function createID($account,$folder,$id=0)
+	private function createID($account, $folder, $id = 0)
 	{
 		if (!is_numeric($folder))
 		{
 			// convert string $folder in numeric id
-			$folder = $this->folder2hash($account,$f=$folder);
+			$folder = $this->folder2hash($account, $f = $folder);
 		}
 
 		$str = $this->backend->createID($account, $folder, $id);
 
-		if ($this->debugLevel>1) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."($account,'$f',$id) type=$account, folder=$folder --> '$str'");
+		if ($this->debugLevel > 1) ZLog::Write(LOGLEVEL_DEBUG, __METHOD__."($account,'$f',$id) type=$account, folder=$folder --> '$str'");
 
 		return $str;
 	}
@@ -1910,14 +1909,14 @@ 
 	 * @param int &$id=null
 	 * @throws Api\Exception\WrongParameter
 	 */
-	private function splitID($str,&$account,&$folder,&$id=null)
+	private function splitID($str, &$account, &$folder, &$id = null)
 	{
 		$this->backend->splitID($str, $account, $folder, $id);
 
 		// convert numeric folder-id back to folder name
-		$folder = $this->hash2folder($account,$f=$folder);
+		$folder = $this->hash2folder($account, $f = $folder);
 
-		if ($this->debugLevel>1) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."('$str','$account','$folder',$id)");
+		if ($this->debugLevel > 1) ZLog::Write(LOGLEVEL_DEBUG, __METHOD__."('$str','$account','$folder',$id)");
 	}
 
 	/**
@@ -1934,9 +1933,9 @@ 
 	 * @param string $folder
 	 * @return int
 	 */
-	private function folder2hash($account,$folder)
+	private function folder2hash($account, $folder)
 	{
-		if(!isset($this->folderHashes)) $this->readFolderHashes();
+		if (!isset($this->folderHashes)) $this->readFolderHashes();
 
 		if (($index = array_search($folder, (array)$this->folderHashes[$account])) === false)
 		{
@@ -1957,9 +1956,9 @@ 
 	 * @param int $index
 	 * @return string NULL if not used so far
 	 */
-	private function hash2folder($account,$index)
+	private function hash2folder($account, $index)
 	{
-		if(!isset($this->folderHashes)) $this->readFolderHashes();
+		if (!isset($this->folderHashes)) $this->readFolderHashes();
 
 		return isset($this->folderHashes[$account]) ? $this->folderHashes[$account][$index] : null;
 	}
@@ -1974,9 +1973,9 @@ 
 		if ((file_exists($file = $this->hashFile()) || file_exists($file = $this->hashFile(true))) &&
 			($hashes = file_get_contents($file)))
 		{
-			$this->folderHashes = json_decode($hashes,true);
+			$this->folderHashes = json_decode($hashes, true);
 			// fallback in case hashes have been serialized instead of being json-encoded
-			if (json_last_error()!=JSON_ERROR_NONE)
+			if (json_last_error() != JSON_ERROR_NONE)
 			{
 				//error_log(__METHOD__.__LINE__." error decoding with json");
 				$this->folderHashes = unserialize($hashes);
@@ -1996,7 +1995,7 @@ 
 	private function storeFolderHashes()
 	{
 		// make sure $this->folderHashes is an array otherwise json_encode may fail on decode for string,integer,float or boolean
-		return file_put_contents($this->hashFile(), json_encode((is_array($this->folderHashes)?$this->folderHashes:array($this->folderHashes))));
+		return file_put_contents($this->hashFile(), json_encode((is_array($this->folderHashes) ? $this->folderHashes : array($this->folderHashes))));
 	}
 
 	/**
@@ -2008,9 +2007,9 @@ 
 	 * @param boolean $old =false true: return old / pre-15 hash-file
 	 * @throws Api\Exception\AssertionFailed
 	 */
-	private function hashFile($old=false)
+	private function hashFile($old = false)
 	{
-		if (!($dev_id=Request::GetDeviceID()))
+		if (!($dev_id = Request::GetDeviceID()))
 		{
 			throw new Api\Exception\AssertionFailed(__METHOD__."() no DeviceID set!");
 		}

Braces +609 added lines, -179 removed lines

@@ -81,29 +81,47 @@ 
 	 */
 	public function __construct(activesync_backend $backend)
 	{
-		if ($GLOBALS['egw_setup']) return;
+		if ($GLOBALS['egw_setup'])
+		{
+			return;
+		}
 
 		//$this->debugLevel=2;
 		$this->backend = $backend;
 		if (!isset($GLOBALS['egw_info']['user']['preferences']['activesync']['mail-ActiveSyncProfileID']))
 		{
-			if ($this->debugLevel>1) error_log(__METHOD__.__LINE__.' Noprefs set: using 0 as default');
+			if ($this->debugLevel>1)
+			{
+				error_log(__METHOD__.__LINE__.' Noprefs set: using 0 as default');
+			}
 			// globals preferences add appname varname value
 			$GLOBALS['egw']->preferences->add('activesync','mail-ActiveSyncProfileID',0,'user');
 			// save prefs
 			$GLOBALS['egw']->preferences->save_repository(true);
 		}
-		if ($this->debugLevel>1) error_log(__METHOD__.__LINE__.' ActiveProfileID:'.array2string(self::$profileID));
+		if ($this->debugLevel>1)
+		{
+			error_log(__METHOD__.__LINE__.' ActiveProfileID:'.array2string(self::$profileID));
+		}
 
 		if (is_null(self::$profileID))
 		{
-			if ($this->debugLevel>1) error_log(__METHOD__.__LINE__.' self::ProfileID isNUll:'.array2string(self::$profileID));
+			if ($this->debugLevel>1)
+			{
+				error_log(__METHOD__.__LINE__.' self::ProfileID isNUll:'.array2string(self::$profileID));
+			}
 			self::$profileID =& Api\Cache::getSession('mail','activeSyncProfileID');
-			if ($this->debugLevel>1) error_log(__METHOD__.__LINE__.' ActiveProfileID (after reading Cache):'.array2string(self::$profileID));
+			if ($this->debugLevel>1)
+			{
+				error_log(__METHOD__.__LINE__.' ActiveProfileID (after reading Cache):'.array2string(self::$profileID));
+			}
 		}
 		if (isset($GLOBALS['egw_info']['user']['preferences']['activesync']['mail-ActiveSyncProfileID']))
 		{
-			if ($this->debugLevel>1) error_log(__METHOD__.__LINE__.' Pref for ProfileID:'.array2string($GLOBALS['egw_info']['user']['preferences']['activesync']['mail-ActiveSyncProfileID']));
+			if ($this->debugLevel>1)
+			{
+				error_log(__METHOD__.__LINE__.' Pref for ProfileID:'.array2string($GLOBALS['egw_info']['user']['preferences']['activesync']['mail-ActiveSyncProfileID']));
+			}
 			if ($GLOBALS['egw_info']['user']['preferences']['activesync']['mail-ActiveSyncProfileID'] == 'G')
 			{
 				self::$profileID = 'G'; // this should trigger the fetch of the first negative profile (or if no negative profile is available the firstb there is)
@@ -113,7 +131,10 @@ 
 				self::$profileID = (int)$GLOBALS['egw_info']['user']['preferences']['activesync']['mail-ActiveSyncProfileID'];
 			}
 		}
-		if ($this->debugLevel>1) error_log(__METHOD__.__LINE__.' Profile Selected (after reading Prefs):'.array2string(self::$profileID));
+		if ($this->debugLevel>1)
+		{
+			error_log(__METHOD__.__LINE__.' Profile Selected (after reading Prefs):'.array2string(self::$profileID));
+		}
 
 		// verify we are on an existing profile, if not running in setup (settings can not be static according to interface!)
 		if (!isset($GLOBALS['egw_setup']))
@@ -126,7 +147,10 @@ 
 				self::$profileID = Mail\Account::get_default_acc_id();
 			}
 		}
-		if ($this->debugLevel>0) error_log(__METHOD__.'::'.__LINE__.' ProfileSelected:'.self::$profileID);
+		if ($this->debugLevel>0)
+		{
+			error_log(__METHOD__.'::'.__LINE__.' ProfileSelected:'.self::$profileID);
+		}
 		//$this->debugLevel=0;
 	}
 
@@ -201,8 +225,14 @@ 
 				$this->_connect(0,true);
 				$this->_disconnect();
 
-				if (!$this->_wasteID) $errors[] = lang('No valid %1 folder configured!', '<b>'.lang('trash').'</b>');
-				if (!$this->_sentID) $errors[] = lang('No valid %1 folder configured!', '<b>'.lang('send').'</b>');
+				if (!$this->_wasteID)
+				{
+					$errors[] = lang('No valid %1 folder configured!', '<b>'.lang('trash').'</b>');
+				}
+				if (!$this->_sentID)
+				{
+					$errors[] = lang('No valid %1 folder configured!', '<b>'.lang('send').'</b>');
+				}
 			}
 			catch(Exception $e) {
 				$errors[] = lang('Can not open IMAP connection').': '.$e->getMessage();
@@ -224,8 +254,14 @@ 
 	 */
 	private function _connect($account=0)
 	{
-		if (!$account) $account = self::$profileID ? self::$profileID : 0;
-		if ($this->mail && $this->account != $account) $this->_disconnect();
+		if (!$account)
+		{
+			$account = self::$profileID ? self::$profileID : 0;
+		}
+		if ($this->mail && $this->account != $account)
+		{
+			$this->_disconnect();
+		}
 
 		$this->_wasteID = false;
 		$this->_sentID = false;
@@ -236,12 +272,18 @@ 
 			// todo: tell mail which account to use
 			//error_log(__METHOD__.__LINE__.' create object with ProfileID:'.array2string(self::$profileID));
 			$this->mail = Mail::getInstance(false,self::$profileID,true,false,true);
-			if (self::$profileID == 0 && isset($this->mail->icServer->ImapServerId) && !empty($this->mail->icServer->ImapServerId)) self::$profileID = $this->mail->icServer->ImapServerId;
+			if (self::$profileID == 0 && isset($this->mail->icServer->ImapServerId) && !empty($this->mail->icServer->ImapServerId))
+			{
+				self::$profileID = $this->mail->icServer->ImapServerId;
+			}
 		}
 		else
 		{
 			//error_log(__METHOD__.__LINE__." connect with profileID: ".self::$profileID);
-			if (self::$profileID == 0 && isset($this->mail->icServer->ImapServerId) && !empty($this->mail->icServer->ImapServerId)) self::$profileID = $this->mail->icServer->ImapServerId;
+			if (self::$profileID == 0 && isset($this->mail->icServer->ImapServerId) && !empty($this->mail->icServer->ImapServerId))
+			{
+				self::$profileID = $this->mail->icServer->ImapServerId;
+			}
 		}
 		$this->mail->openConnection(self::$profileID,false);
 
@@ -258,8 +300,14 @@ 
 	 */
 	private function _disconnect()
 	{
-		if ($this->debugLevel>0) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__);
-		if ($this->mail) $this->mail->closeConnection();
+		if ($this->debugLevel>0)
+		{
+			ZLog::Write(LOGLEVEL_DEBUG,__METHOD__);
+		}
+		if ($this->mail)
+		{
+			$this->mail->closeConnection();
+		}
 
 		unset($this->mail);
 		unset($this->account);
@@ -274,24 +322,43 @@ 
 	public function GetFolderList()
 	{
 		$folderlist = array();
-		if ($this->debugLevel>0) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__);
+		if ($this->debugLevel>0)
+		{
+			ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__);
+		}
 		/*foreach($available_accounts as $account)*/ $account = 0;
 		{
 			$this->_connect($account);
-			if (!isset($this->folders)) $this->folders = $this->mail->getFolderObjects(true,false,$_alwaysGetDefaultFolders=true);
-			if ($this->debugLevel>1) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.array2string($this->folders));
+			if (!isset($this->folders))
+			{
+				$this->folders = $this->mail->getFolderObjects(true,false,$_alwaysGetDefaultFolders=true);
+			}
+			if ($this->debugLevel>1)
+			{
+				ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.array2string($this->folders));
+			}
 
-			foreach ($this->folders as $folder => $folderObj) {
-				if ($this->debugLevel>1) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' folder='.$folder);
+			foreach ($this->folders as $folder => $folderObj)
+			{
+				if ($this->debugLevel>1)
+				{
+					ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' folder='.$folder);
+				}
 				$folderlist[] = $f = array(
 					'id'     => $this->createID($account,$folder),
 					'mod'    => $folderObj->shortDisplayName,
 					'parent' => $this->getParentID($account,$folder),
 				);
-				if ($this->debugLevel>1) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."() returning ".array2string($f));
+				if ($this->debugLevel>1)
+				{
+					ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."() returning ".array2string($f));
+				}
 			}
 		}
-		if ($this->debugLevel>0) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."() returning ".array2string($folderlist));
+		if ($this->debugLevel>0)
+		{
+			ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."() returning ".array2string($folderlist));
+		}
 
 		return $folderlist;
 	}
@@ -352,11 +419,17 @@ 
 		$smartdata_task = ($smartdata->replyflag?'reply':($smartdata->forwardflag?'forward':'new'));
 
    		ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__ . (isset($smartdata->mime) ? $smartdata->mime : ""). "task: ".(isset($smartdata_task) ? $smartdata_task : "")." itemid: ".(isset($smartdata->source->itemid) ? $smartdata->source->itemid : "")." folder: ".(isset($smartdata->source->folderid) ? $smartdata->source->folderid : ""));
-		if ($this->debugLevel>0) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__."): Smartdata = ".array2string($smartdata));
+		if ($this->debugLevel>0)
+		{
+			ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__."): Smartdata = ".array2string($smartdata));
+		}
 		//error_log("IMAP-Sendmail: Smartdata = ".array2string($smartdata));
 
 		// initialize our Mail
-		if (!isset($this->mail)) $this->mail = Mail::getInstance(false,self::$profileID,true,false,true);
+		if (!isset($this->mail))
+		{
+			$this->mail = Mail::getInstance(false,self::$profileID,true,false,true);
+		}
 		$activeMailProfiles = $this->mail->getAccountIdentities(self::$profileID);
 		// use the standardIdentity
 		$activeMailProfile = Mail::getStandardIdentityForProfile($activeMailProfiles,self::$profileID);
@@ -376,22 +449,34 @@ 
 		// prepare addressee list; moved the adding of addresses to the mailobject down
 		// to
 
-		foreach(Mail::parseAddressList($mailObject->getHeader("To")) as $addressObject) {
-			if (!$addressObject->valid) continue;
+		foreach(Mail::parseAddressList($mailObject->getHeader("To")) as $addressObject)
+		{
+			if (!$addressObject->valid)
+			{
+				continue;
+			}
 			ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__.") Header Sentmail To: ".array2string($addressObject) );
 			//$mailObject->AddAddress($addressObject->mailbox. ($addressObject->host ? '@'.$addressObject->host : ''),$addressObject->personal);
 			$toMailAddr[] = imap_rfc822_write_address($addressObject->mailbox, $addressObject->host, $addressObject->personal);
 		}
 		// CC
-		foreach(Mail::parseAddressList($mailObject->getHeader("Cc")) as $addressObject) {
-			if (!$addressObject->valid) continue;
+		foreach(Mail::parseAddressList($mailObject->getHeader("Cc")) as $addressObject)
+		{
+			if (!$addressObject->valid)
+			{
+				continue;
+			}
 			ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__.") Header Sentmail CC: ".array2string($addressObject) );
 			//$mailObject->AddCC($addressObject->mailbox. ($addressObject->host ? '@'.$addressObject->host : ''),$addressObject->personal);
 			$ccMailAddr[] = imap_rfc822_write_address($addressObject->mailbox, $addressObject->host, $addressObject->personal);
 		}
 		// BCC
-		foreach(Mail::parseAddressList($mailObject->getHeader("Bcc")) as $addressObject) {
-			if (!$addressObject->valid) continue;
+		foreach(Mail::parseAddressList($mailObject->getHeader("Bcc")) as $addressObject)
+		{
+			if (!$addressObject->valid)
+			{
+				continue;
+			}
 			ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__.") Header Sentmail BCC: ".array2string($addressObject) );
 			//$mailObject->AddBCC($addressObject->mailbox. ($addressObject->host ? '@'.$addressObject->host : ''),$addressObject->personal);
 			$bccMailAddr[] = imap_rfc822_write_address($addressObject->mailbox, $addressObject->host, $addressObject->personal);
@@ -404,12 +489,14 @@ 
 		$ContentType =$mailObject->getHeader('Content-Type');
 		//error_log(__METHOD__.__LINE__." Header Sentmail original Header (filtered): " . $k.  " = ".trim($ContentType));
 		// if the message is a multipart message, then we should use the sent body
-		if (preg_match("/multipart/i", $ContentType)) {
+		if (preg_match("/multipart/i", $ContentType))
+		{
 			$use_orgbody = true;
 		}
 
 		// save the original content-type header for the body part when forwarding
-		if ($smartdata_task == 'forward' && $smartdata->source->itemid && !$use_orgbody) {
+		if ($smartdata_task == 'forward' && $smartdata->source->itemid && !$use_orgbody)
+		{
 			//continue; // ignore
 		}
 		// horde/egw_ mailer does everything as utf-8, the following should not be needed
@@ -418,7 +505,8 @@ 
 		// if the message is a multipart message, then we should use the sent body
 		if (($smartdata_task == 'new' || $smartdata_task == 'reply' || $smartdata_task == 'forward') &&
 			((isset($smartdata->replacemime) && $smartdata->replacemime == true) ||
-			$k == "Content-Type" && preg_match("/multipart/i", $ContentType))) {
+			$k == "Content-Type" && preg_match("/multipart/i", $ContentType)))
+		{
 			$use_orgbody = true;
 		}
 		$Body =  $AltBody = "";
@@ -451,12 +539,19 @@ 
 			$AltBody = preg_replace("/(<|&lt;)*(([\w\.,-.,_.,0-9.]+)@([\w\.,-.,_.,0-9.]+))(>|&gt;)*/i","[$2]",
 				($html_body = $mailObject->findBody('html')) ? $html_body->getContents() : null);
 		}
-		if ($this->debugLevel>1 && $Body) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__.") fetched Body as with MessageContentType:". $ContentType.'=>'.$Body);
-		if ($this->debugLevel>1 && $AltBody) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__.") fetched AltBody as with MessageContentType:". $ContentType.'=>'.$AltBody);
+		if ($this->debugLevel>1 && $Body)
+		{
+			ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__.") fetched Body as with MessageContentType:". $ContentType.'=>'.$Body);
+		}
+		if ($this->debugLevel>1 && $AltBody)
+		{
+			ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__.") fetched AltBody as with MessageContentType:". $ContentType.'=>'.$AltBody);
+		}
 		//error_log(__METHOD__.__LINE__.array2string($mailObject));
 		// if this is a multipart message with a boundary, we must use the original body
 		//if ($this->debugLevel>2) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' mailObject after Inital Parse:'.array2string($mailObject));
-        if ($use_orgbody) {
+        if ($use_orgbody)
+        {
     	    ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__.") use_orgbody = true ContentType:".$ContentType);
  			// if it is a ClientSideMeetingRequest, we report it as send at all times
 			if (($cal_body = $mailObject->findBody('calendar')) &&
@@ -466,15 +561,20 @@ 
 				{
 					$organizer = calendar_ical::getIcalOrganizer($cal_body->getContents());
 				}
-				if ($this->debugLevel) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__.") we have a Client Side Meeting Request from organizer=$organizer");
+				if ($this->debugLevel)
+				{
+					ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__.") we have a Client Side Meeting Request from organizer=$organizer");
+				}
 				$ClientSideMeetingRequest = true;
 			}
         }
 		// now handle the addressee list
 		$toCount = 0;
 		//error_log(__METHOD__.__LINE__.array2string($toMailAddr));
-		foreach((array)$toMailAddr as $address) {
-			foreach(Mail::parseAddressList((get_magic_quotes_gpc()?stripslashes($address):$address)) as $addressObject) {
+		foreach((array)$toMailAddr as $address)
+		{
+			foreach(Mail::parseAddressList((get_magic_quotes_gpc()?stripslashes($address):$address)) as $addressObject)
+			{
 				$emailAddress = $addressObject->mailbox. ($addressObject->host ? '@'.$addressObject->host : '');
 				if ($ClientSideMeetingRequest === true && $allowSendingInvitations == 'sendifnocalnotif' &&
 					calendar_boupdate::email_update_requested($emailAddress, isset($cSMRMethod) ? $cSMRMethod : 'REQUEST',
@@ -488,19 +588,29 @@ 
 			}
 		}
 		$ccCount = 0;
-		foreach((array)$ccMailAddr as $address) {
-			foreach(Mail::parseAddressList((get_magic_quotes_gpc()?stripslashes($address):$address)) as $addressObject) {
+		foreach((array)$ccMailAddr as $address)
+		{
+			foreach(Mail::parseAddressList((get_magic_quotes_gpc()?stripslashes($address):$address)) as $addressObject)
+			{
 				$emailAddress = $addressObject->mailbox. ($addressObject->host ? '@'.$addressObject->host : '');
-				if ($ClientSideMeetingRequest === true && $allowSendingInvitations == 'sendifnocalnotif' && calendar_boupdate::email_update_requested($emailAddress)) continue;
+				if ($ClientSideMeetingRequest === true && $allowSendingInvitations == 'sendifnocalnotif' && calendar_boupdate::email_update_requested($emailAddress))
+				{
+					continue;
+				}
 				$mailObject->AddCC($emailAddress, $addressObject->personal);
 				$ccCount++;
 			}
 		}
 		$bccCount = 0;
-		foreach((array)$bccMailAddr as $address) {
-			foreach(Mail::parseAddressList((get_magic_quotes_gpc()?stripslashes($address):$address)) as $addressObject) {
+		foreach((array)$bccMailAddr as $address)
+		{
+			foreach(Mail::parseAddressList((get_magic_quotes_gpc()?stripslashes($address):$address)) as $addressObject)
+			{
 				$emailAddress = $addressObject->mailbox. ($addressObject->host ? '@'.$addressObject->host : '');
-				if ($ClientSideMeetingRequest === true && $allowSendingInvitations == 'sendifnocalnotif' && calendar_boupdate::email_update_requested($emailAddress)) continue;
+				if ($ClientSideMeetingRequest === true && $allowSendingInvitations == 'sendifnocalnotif' && calendar_boupdate::email_update_requested($emailAddress))
+				{
+					continue;
+				}
 				$mailObject->AddBCC($emailAddress, $addressObject->personal);
 				$bccCount++;
 			}
@@ -510,7 +620,10 @@ 
 		{
 			return $ClientSideMeetingRequest && $allowSendingInvitations === 'sendifnocalnotif' && $organizer ? true : 0; // noone to send mail to
 		}
-		if ($ClientSideMeetingRequest === true && $allowSendingInvitations===false) return true;
+		if ($ClientSideMeetingRequest === true && $allowSendingInvitations===false)
+		{
+			return true;
+		}
 		// as we use our mailer (horde mailer) it is detecting / setting the mimetype by itself while creating the mail
 /*
 		if ($this->debugLevel>2) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' retrieved Body:'.$body);
@@ -540,7 +653,10 @@ 
 		$beforeHtml = ($disableRuler ?'&nbsp;<br>':'&nbsp;<br><hr style="border:dotted 1px silver; width:90%; border:dotted 1px silver;">');
 		$beforePlain = ($disableRuler ?"\r\n\r\n":"\r\n\r\n-- \r\n");
 		$sigText = Mail::merge($signature,array($GLOBALS['egw']->accounts->id2name($GLOBALS['egw_info']['user']['account_id'],'person_id')));
-		if ($this->debugLevel>0) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' Signature to use:'.$sigText);
+		if ($this->debugLevel>0)
+		{
+			ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' Signature to use:'.$sigText);
+		}
 		$sigTextHtml = $beforeHtml.$sigText;
 		$sigTextPlain = $beforePlain.Api\Mail\Html::convertHTMLToText($sigText);
 		$isreply = $isforward = false;
@@ -558,10 +674,17 @@ 
 			$this->mail->reopen($folder);
 			$bodyStruct = $this->mail->getMessageBody($uid, 'html_only');
 			$bodyBUFFHtml = $this->mail->getdisplayableBody($this->mail,$bodyStruct,true,false);
-			if ($this->debugLevel>3) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' html_only:'.$bodyBUFFHtml);
-		    if ($bodyBUFFHtml != "" && (is_array($bodyStruct) && $bodyStruct[0]['mimeType']=='text/html')) {
+			if ($this->debugLevel>3)
+			{
+				ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' html_only:'.$bodyBUFFHtml);
+			}
+		    if ($bodyBUFFHtml != "" && (is_array($bodyStruct) && $bodyStruct[0]['mimeType']=='text/html'))
+		    {
 				// may be html
-				if ($this->debugLevel>0) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__.") MIME Body".' Type:html (fetched with html_only):'.$bodyBUFFHtml);
+				if ($this->debugLevel>0)
+				{
+					ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__.") MIME Body".' Type:html (fetched with html_only):'.$bodyBUFFHtml);
+				}
 				$AltBody = $AltBody."</br>".$bodyBUFFHtml.$sigTextHtml;
 				$isreply = true;
 			}
@@ -570,8 +693,12 @@ 
 			// if the new part of the message is html, we must preserve it, and handle that the original mail is text/plain
 			$bodyStruct = $this->mail->getMessageBody($uid,'never_display');//'never_display');
 			$bodyBUFF = $this->mail->getdisplayableBody($this->mail,$bodyStruct,false,false);
-			if ($bodyBUFF != "" && (is_array($bodyStruct) && $bodyStruct[0]['mimeType']=='text/plain')) {
-				if ($this->debugLevel>0) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__.") MIME Body".' Type:plain (fetched with never_display):'.$bodyBUFF);
+			if ($bodyBUFF != "" && (is_array($bodyStruct) && $bodyStruct[0]['mimeType']=='text/plain'))
+			{
+				if ($this->debugLevel>0)
+				{
+					ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__.") MIME Body".' Type:plain (fetched with never_display):'.$bodyBUFF);
+				}
 				$Body = $Body."\r\n".$bodyBUFF.$sigTextPlain;
 				$isreply = true;
 			}
@@ -579,7 +706,10 @@ 
 			{
 				$isreply = true;
 				$AltBody = $AltBody."</br><pre>".nl2br($bodyBUFF).'</pre>'.$sigTextHtml;
-				if ($this->debugLevel>0) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__." no Api\Html Body found use modified plaintext body for txt/html: ".$AltBody);
+				if ($this->debugLevel>0)
+				{
+					ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__." no Api\Html Body found use modified plaintext body for txt/html: ".$AltBody);
+				}
 			}
 		}
 
@@ -593,11 +723,17 @@ 
 			(isset($smartdata->replacemime) && $smartdata->replacemime == false)))
 		{
 			//force the default for the forwarding -> asmail
-			if (is_array($preferencesArray)) {
+			if (is_array($preferencesArray))
+			{
 				if (!array_key_exists('message_forwarding',$preferencesArray)
 					|| !isset($preferencesArray['message_forwarding'])
-					|| empty($preferencesArray['message_forwarding'])) $preferencesArray['message_forwarding'] = 'asmail';
-			} else {
+					|| empty($preferencesArray['message_forwarding']))
+				{
+					$preferencesArray['message_forwarding'] = 'asmail';
+				}
+			}
+			else
+			{
 				$preferencesArray['message_forwarding'] = 'asmail';
 			}
 			// construct the uid of the message out of the itemid - seems to be the uid, no construction needed
@@ -629,27 +765,44 @@ 
 				$this->mail->reopen($folder);
 				$bodyStruct = $this->mail->getMessageBody($uid, 'html_only');
 				$bodyBUFFHtml = $this->mail->getdisplayableBody($this->mail,$bodyStruct,true,false);
-				if ($this->debugLevel>0) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' html_only:'.$bodyBUFFHtml);
-				if ($bodyBUFFHtml != "" && (is_array($bodyStruct) && $bodyStruct[0]['mimeType']=='text/html')) {
+				if ($this->debugLevel>0)
+				{
+					ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' html_only:'.$bodyBUFFHtml);
+				}
+				if ($bodyBUFFHtml != "" && (is_array($bodyStruct) && $bodyStruct[0]['mimeType']=='text/html'))
+				{
 					// may be html
-					if ($this->debugLevel>0) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__.") MIME Body".' Type:html (fetched with html_only):'.$bodyBUFFHtml);
+					if ($this->debugLevel>0)
+					{
+						ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__.") MIME Body".' Type:html (fetched with html_only):'.$bodyBUFFHtml);
+					}
 					$AltBody = $AltBody."</br>".$bodyBUFFHtml.$sigTextHtml;
 					$isforward = true;
 				}
 				// plain text Message part
-				if ($this->debugLevel>0) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__.") MIME Body".' Type:plain, fetch text:');
+				if ($this->debugLevel>0)
+				{
+					ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__.") MIME Body".' Type:plain, fetch text:');
+				}
 				// if the new part of the message is html, we must preserve it, and handle that the original mail is text/plain
 				$bodyStruct = $this->mail->getMessageBody($uid,'never_display');//'never_display');
 				$bodyBUFF = $this->mail->getdisplayableBody($this->mail,$bodyStruct,false,false);
-				if ($bodyBUFF != "" && (is_array($bodyStruct) && $bodyStruct[0]['mimeType']=='text/plain')) {
-					if ($this->debugLevel>0) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__.") MIME Body".' Type:plain (fetched with never_display):'.$bodyBUFF);
+				if ($bodyBUFF != "" && (is_array($bodyStruct) && $bodyStruct[0]['mimeType']=='text/plain'))
+				{
+					if ($this->debugLevel>0)
+					{
+						ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__.") MIME Body".' Type:plain (fetched with never_display):'.$bodyBUFF);
+					}
 					$Body = $Body."\r\n".$bodyBUFF.$sigTextPlain;
 					$isforward = true;
 				}
 				if (!empty($bodyBUFF) && empty($bodyBUFFHtml) && !empty($AltBody))
 				{
 					$AltBody = $AltBody."</br><pre>".nl2br($bodyBUFF).'</pre>'.$sigTextHtml;
-					if ($this->debugLevel>0) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__." no html Body found use modified plaintext body for txt/html: ".$AltBody);
+					if ($this->debugLevel>0)
+					{
+						ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__." no html Body found use modified plaintext body for txt/html: ".$AltBody);
+					}
 					$isforward = true;
 				}
 				// get all the attachments and add them too.
@@ -662,7 +815,10 @@ 
 					ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' gather Attachments for BodyCreation of/for MessageID:'.$uid.' found:'.count($attachments));
 					foreach((array)$attachments as $key => $attachment)
 					{
-						if ($this->debugLevel>0) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' Key:'.$key.'->'.array2string($attachment));
+						if ($this->debugLevel>0)
+						{
+							ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' Key:'.$key.'->'.array2string($attachment));
+						}
 						$attachmentNames .= $attachment['name']."\n";
 						$attachmentData	= $this->mail->getAttachment($uid, $attachment['partID'],0,false,false,$folder);
 						/*$x =*/ $mailObject->AddStringAttachment($attachmentData['attachment'], $mailObject->EncodeHeader($attachment['name']), $attachment['mimeType']);
@@ -680,18 +836,27 @@ 
 		// now set the body
 		if ($AltBody && ($html_body = $mailObject->findBody('html')))
 		{
-			if ($this->debugLevel>1) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' -> '.$AltBody);
+			if ($this->debugLevel>1)
+			{
+				ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' -> '.$AltBody);
+			}
 			$html_body->setContents($AltBody,array('encoding'=>Horde_Mime_Part::DEFAULT_ENCODING));
 		}
 		if ($Body && ($text_body = $mailObject->findBody('plain')))
 		{
-			if ($this->debugLevel>1) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' -> '.$Body);
+			if ($this->debugLevel>1)
+			{
+				ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' -> '.$Body);
+			}
 			$text_body->setContents($Body,array('encoding'=>Horde_Mime_Part::DEFAULT_ENCODING));
 		}
 		//advanced debugging
 		// Horde SMTP Class uses utf-8 by default.
         //debugLog("IMAP-SendMail: parsed message: ". print_r($message,1));
-		if ($this->debugLevel>2) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__."): MailObject:".array2string($mailObject));
+		if ($this->debugLevel>2)
+		{
+			ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."(".__LINE__."): MailObject:".array2string($mailObject));
+		}
 
 		// set a higher timeout for big messages
 		@set_time_limit(120);
@@ -718,7 +883,9 @@ 
 			if ($this->mail->isDraftFolder($folder) && !$this->mail->isTemplateFolder($folder))
 			{
 				$this->mail->deleteMessages(array($uid),$folder);
-			} else {
+			}
+			else
+			{
 				$this->mail->flagMessages("answered", array($uid),$folder);
 				if ($smartdata_task== "forward")
 				{
@@ -732,7 +899,8 @@ 
 		{
 			$asf = false;
 			$sentFolder = $this->mail->getSentFolder();
-			if ($this->_sentID) {
+			if ($this->_sentID)
+			{
 				$folderArray[] = $this->_sentID;
 			}
 			else if(isset($sentFolder) && $sentFolder != 'none')
@@ -746,27 +914,40 @@ 
 				// we dont try guessing
 				$asf = true;
 			}
-			if (count($folderArray) > 0) {
-				foreach((array)$bccMailAddr as $address) {
-					foreach(Mail::parseAddressList((get_magic_quotes_gpc()?stripslashes($address):$address)) as $addressObject) {
+			if (count($folderArray) > 0)
+			{
+				foreach((array)$bccMailAddr as $address)
+				{
+					foreach(Mail::parseAddressList((get_magic_quotes_gpc()?stripslashes($address):$address)) as $addressObject)
+					{
 						$emailAddress = $addressObject->mailbox. ($addressObject->host ? '@'.$addressObject->host : '');
 						$mailAddr[] = array($emailAddress, $addressObject->personal);
 					}
 				}
 				$BCCmail='';
-				if (count($mailAddr)>0) $BCCmail = $mailObject->AddrAppend("Bcc",$mailAddr);
-				foreach($folderArray as $folderName) {
-					if($this->mail->isSentFolder($folderName)) {
+				if (count($mailAddr)>0)
+				{
+					$BCCmail = $mailObject->AddrAppend("Bcc",$mailAddr);
+				}
+				foreach($folderArray as $folderName)
+				{
+					if($this->mail->isSentFolder($folderName))
+					{
 						$flags = '\\Seen';
-					} elseif($this->mail->isDraftFolder($folderName)) {
+					}
+					elseif($this->mail->isDraftFolder($folderName))
+					{
 						$flags = '\\Draft';
-					} else {
+					}
+					else
+					{
 						$flags = '';
 					}
 					$asf = true;
 					//ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.'->'.array2string($this->mail->icServer));
 					$this->mail->openConnection(self::$profileID,false);
-					if ($this->mail->folderExists($folderName)) {
+					if ($this->mail->folderExists($folderName))
+					{
 						try
 						{
 							$this->mail->appendMessage($folderName,$mailObject->getRaw(), null,
@@ -824,16 +1005,25 @@ 
 		$bodypreference = $contentparameters->GetBodyPreference(); /* fmbiete's contribution r1528, ZP-320 */
 
 		// fix for z-push bug returning additional bodypreference type 4, even if only 1 is requested and mimessupport = 0
-		if (!$mimesupport && ($key = array_search('4', $bodypreference))) unset($bodypreference[$key]);
+		if (!$mimesupport && ($key = array_search('4', $bodypreference)))
+		{
+			unset($bodypreference[$key]);
+		}
 
 		//$this->debugLevel=4;
-		if (!isset($this->mail)) $this->mail = Mail::getInstance(false,self::$profileID,true,false,true);
+		if (!isset($this->mail))
+		{
+			$this->mail = Mail::getInstance(false,self::$profileID,true,false,true);
+		}
 		ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' FolderID:'.$folderid.' ID:'.$id.' TruncSize:'.$truncsize.' Bodypreference: '.array2string($bodypreference));
 		$account = $_folderName = $xid = null;
 		$this->splitID($folderid,$account,$_folderName,$xid);
 		$this->mail->reopen($_folderName);
 		$stat = $this->StatMessage($folderid, $id);
-		if ($this->debugLevel>3) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.array2string($stat));
+		if ($this->debugLevel>3)
+		{
+			ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.array2string($stat));
+		}
 		// StatMessage should reopen the folder in question, so we dont need folderids in the following statements.
 		if ($stat)
 		{
@@ -849,16 +1039,25 @@ 
 			//$rawHeaders = $this->mail->getMessageRawHeader($id);
 			// simple style
 			// start AS12 Stuff (bodypreference === false) case = old behaviour
-			if ($this->debugLevel>0) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__. ' for message with ID:'.$id.' with headers:'.array2string($headers));
+			if ($this->debugLevel>0)
+			{
+				ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__. ' for message with ID:'.$id.' with headers:'.array2string($headers));
+			}
 
-			if ($bodypreference === false) {
+			if ($bodypreference === false)
+			{
 				$bodyStruct = $this->mail->getMessageBody($id, 'only_if_no_text', '', null, true,$_folderName);
 				$raw_body = $this->mail->getdisplayableBody($this->mail,$bodyStruct,false,false);
 				//$body = html_entity_decode($body,ENT_QUOTES,$this->mail->detect_encoding($body));
-				if (stripos($raw_body,'<style')!==false) $body = preg_replace("/<style.*?<\/style>/is", "", $raw_body); // in case there is only a html part
+				if (stripos($raw_body,'<style')!==false)
+				{
+					$body = preg_replace("/<style.*?<\/style>/is", "", $raw_body);
+				}
+				// in case there is only a html part
 				// remove all other html
 				$body = strip_tags($raw_body);
-				if(strlen($body) > $truncsize) {
+				if(strlen($body) > $truncsize)
+				{
 					$body = Utils::Utf8_truncate($body, $truncsize);
 					$output->bodytruncated = 1;
 				}
@@ -873,7 +1072,8 @@ 
 			{
 				//Select body type preference
 				$bpReturnType = 1;//SYNC_BODYPREFERENCE_PLAIN;
-				if ($bodypreference !== false) {
+				if ($bodypreference !== false)
+				{
 					// bodypreference can occur multiple times
 					// usually we would use Utils::GetBodyPreferenceBestMatch($bodypreference);
 					$bpReturnType = Utils::GetBodyPreferenceBestMatch($bodypreference);
@@ -892,25 +1092,49 @@ 
 				// fetch the body (try to gather data only once)
 				$css ='';
 				$bodyStruct = $this->mail->getMessageBody($id, 'html_only', '', null, true,$_folderName);
-				if ($this->debugLevel>2) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' html_only Struct:'.array2string($bodyStruct));
+				if ($this->debugLevel>2)
+				{
+					ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' html_only Struct:'.array2string($bodyStruct));
+				}
 				$body = $this->mail->getdisplayableBody($this->mail,$bodyStruct,true,false);
-				if ($this->debugLevel>3) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' html_only:'.$body);
-				if ($body != "" && (is_array($bodyStruct) && $bodyStruct[0]['mimeType']=='text/html')) {
+				if ($this->debugLevel>3)
+				{
+					ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' html_only:'.$body);
+				}
+				if ($body != "" && (is_array($bodyStruct) && $bodyStruct[0]['mimeType']=='text/html'))
+				{
 					// may be html
-					if ($this->debugLevel>0) debugLog("MIME Body".' Type:html (fetched with html_only)');
+					if ($this->debugLevel>0)
+					{
+						debugLog("MIME Body".' Type:html (fetched with html_only)');
+					}
 					$css = $this->mail->getStyles($bodyStruct);
 					$output->nativebodytype=2;
-				} else {
+				}
+				else
+				{
 					// plain text Message
-					if ($this->debugLevel>0) debugLog("MIME Body".' Type:plain, fetch text (HTML, if no text available)');
+					if ($this->debugLevel>0)
+					{
+						debugLog("MIME Body".' Type:plain, fetch text (HTML, if no text available)');
+					}
 					$output->nativebodytype=1;
 					$bodyStruct = $this->mail->getMessageBody($id,'never_display', '', null, true,$_folderName); //'only_if_no_text');
-					if ($this->debugLevel>3) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' plain text Struct:'.array2string($bodyStruct));
+					if ($this->debugLevel>3)
+					{
+						ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' plain text Struct:'.array2string($bodyStruct));
+					}
 					$body = $this->mail->getdisplayableBody($this->mail,$bodyStruct,false,false);
-					if ($this->debugLevel>3) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' never display html(plain text only):'.$body);
+					if ($this->debugLevel>3)
+					{
+						ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' never display html(plain text only):'.$body);
+					}
 				}
 				// whatever format decode (using the correct encoding)
-				if ($this->debugLevel>3) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__."MIME Body".' Type:'.($output->nativebodytype==2?' html ':' plain ').$body);
+				if ($this->debugLevel>3)
+				{
+					ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__."MIME Body".' Type:'.($output->nativebodytype==2?' html ':' plain ').$body);
+				}
 				//$body = html_entity_decode($body,ENT_QUOTES,$this->mail->detect_encoding($body));
 				// prepare plaintextbody
 				$plainBody='';
@@ -931,21 +1155,33 @@ 
 				// remove all other html
 				$plainBody = preg_replace("/<br.*>/is","\r\n",$plainBody);
 				$plainBody = strip_tags($plainBody);
-				if ($this->debugLevel>3 && $output->nativebodytype==1) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' Plain Text:'.$plainBody);
+				if ($this->debugLevel>3 && $output->nativebodytype==1)
+				{
+					ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' Plain Text:'.$plainBody);
+				}
 				//$body = str_replace("\n","\r\n", str_replace("\r","",$body)); // do we need that?
-				if ($bpReturnType==SYNC_BODYPREFERENCE_MIME)//4)//$mimesupport==2 || $mimesupport ==1 && stristr($headers['CONTENT-TYPE'],'signed') !== false)
+				if ($bpReturnType==SYNC_BODYPREFERENCE_MIME)
+				{
+					//4)//$mimesupport==2 || $mimesupport ==1 && stristr($headers['CONTENT-TYPE'],'signed') !== false)
 				{
 					//SYNC_BODYPREFERENCE_MIME
 					ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__." bodypreference 4 requested");
+				}
 					$output->asbody->type = SYNC_BODYPREFERENCE_MIME;//4;
 					// use Api\Mailer::convert to convert charset of all text parts to utf-8, which is a z-push or AS requirement!
 					$Body = Api\Mailer::convert($this->mail->getMessageRawBody($id, '', $_folderName));
-					if ($this->debugLevel>2) debugLog(__METHOD__.__LINE__." Setting Mailobjectcontent to output:".$Body);
+					if ($this->debugLevel>2)
+					{
+						debugLog(__METHOD__.__LINE__." Setting Mailobjectcontent to output:".$Body);
+					}
 					$output->asbody->data = $Body;
 				}
-				else if ($bpReturnType==2) //SYNC_BODYPREFERENCE_HTML
+				else if ($bpReturnType==2)
+				{
+					//SYNC_BODYPREFERENCE_HTML
 				{
 					if ($this->debugLevel>0) debugLog("HTML Body with requested pref 2");
+				}
 					// Send HTML if requested and native type was html
 					$output->asbody->type = 2;
 					$htmlbody = '<html>'.
@@ -980,7 +1216,10 @@ 
 				else
 				{
 					// Send Plaintext as Fallback or if original body is plainttext
-					if ($this->debugLevel>0) debugLog("Plaintext Body:".$plainBody);
+					if ($this->debugLevel>0)
+					{
+						debugLog("Plaintext Body:".$plainBody);
+					}
 					/* we use plainBody (set above) instead
 					$bodyStruct = $this->mail->getMessageBody($id,'only_if_no_text'); //'never_display');
 					$plain = $this->mail->getdisplayableBody($this->mail,$bodyStruct);
@@ -1016,7 +1255,9 @@ 
 			{
 				$output->flag->flagstatus = 2;
 				//$output->flag->flagtype = "Flag for Follow up";
-			} else {
+			}
+			else
+			{
 				$output->flag->flagstatus = 0;
 			}
 			if ($this->messages[$id]['answered'])
@@ -1033,11 +1274,21 @@ 
 			$output->datereceived = $this->mail->_strtotime($headers['DATE'],'ts',true);
 //error_log(__METHOD__.__LINE__.' To:'.$headers['TO']);
 			$output->to = $headers['TO'];
-			if ($headers['TO']) $output->displayto = ($headers['TO'] ? $headers['TO']:null); //$stat['FETCHED_HEADER']['to_name']
+			if ($headers['TO'])
+			{
+				$output->displayto = ($headers['TO'] ? $headers['TO']:null);
+			}
+			//$stat['FETCHED_HEADER']['to_name']
 //error_log(__METHOD__.__LINE__.' From:'.$headers['FROM']);
 			$output->from = $headers['FROM'];
-			if (isset($headers['CC']) && $headers['CC']) $output->cc = ($headers['CC'] ? $headers['CC']:null);
-			if (isset($headers['REPLY_TO']) && $headers['REPLY_TO']) $output->reply_to = ($headers['REPLY_TO']?$headers['REPLY_TO']:null);
+			if (isset($headers['CC']) && $headers['CC'])
+			{
+				$output->cc = ($headers['CC'] ? $headers['CC']:null);
+			}
+			if (isset($headers['REPLY_TO']) && $headers['REPLY_TO'])
+			{
+				$output->reply_to = ($headers['REPLY_TO']?$headers['REPLY_TO']:null);
+			}
 
 			$output->messageclass = "IPM.Note";
 			if (stripos($this->messages[$id]['mimetype'],'multipart')!== false &&
@@ -1045,7 +1296,8 @@ 
 			{
 				$output->messageclass = "IPM.Note.SMIME.MultipartSigned";
 			}
-			if (Request::GetProtocolVersion() >= 12.0) {
+			if (Request::GetProtocolVersion() >= 12.0)
+			{
 				$output->contentclass = "urn:content-classes:message";
 			}
 
@@ -1058,7 +1310,10 @@ 
 				//error_log(__METHOD__.__LINE__.array2string($attachments));
 				foreach ($attachments as $key => $attach)
 				{
-					if ($this->debugLevel>0) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' Key:'.$key.'->'.array2string($attach));
+					if ($this->debugLevel>0)
+					{
+						ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' Key:'.$key.'->'.array2string($attach));
+					}
 
 					// pass meeting requests to calendar plugin
 					if (strtolower($attach['mimeType']) == 'text/calendar' && strtolower($attach['method']) == 'request' &&
@@ -1075,17 +1330,24 @@ 
 						unset($attachment);
 						continue;	// do NOT add attachment as attachment
 					}
-					if (Request::GetProtocolVersion() >= 12.0) {
+					if (Request::GetProtocolVersion() >= 12.0)
+					{
 						$attachment = new SyncBaseAttachment();
 						if (!isset($output->asattachments) || !is_array($output->asattachments))
-							$output->asattachments = array();
+						{
+													$output->asattachments = array();
+						}
 						$attachment->estimatedDataSize = $attach['size'];
 						$attachment->method = 1;
 						$attachment->filereference = $folderid . ":" . $id . ":" . $attach['partID'];
-					} else {
+					}
+					else
+					{
 						$attachment = new SyncAttachment();
 						if (!isset($output->attachments) || !is_array($output->attachments))
-							$output->attachments = array();
+						{
+													$output->attachments = array();
+						}
 						$attachment->attsize = $attach['size'];
 						$attachment->attmethod = 1;
 						$attachment->attname = $folderid . ":" . $id . ":" . $attach['partID'];//$key;
@@ -1102,10 +1364,13 @@ 
 						{
 							$attachment->isinline = true;
 						}
-						if (Request::GetProtocolVersion() >= 12.0) {
+						if (Request::GetProtocolVersion() >= 12.0)
+						{
 							$attachment->method=1;
 							$attachment->contentid= str_replace(array("<",">"), "",$attach['cid']);
-						} else {
+						}
+						else
+						{
 							$attachment->attmethod=6;
 							$attachment->attoid = str_replace(array("<",">"), "",$attach['cid']);
 						}
@@ -1113,9 +1378,12 @@ 
 						$attachment->contenttype = trim($attach['mimeType']);
 						//	debugLog("'".$part->headers['content-type']."'  ".$attachment->contentid);
 					}
-					if (Request::GetProtocolVersion() >= 12.0) {
+					if (Request::GetProtocolVersion() >= 12.0)
+					{
 						array_push($output->asattachments, $attachment);
-					} else {
+					}
+					else
+					{
 						array_push($output->attachments, $attachment);
 					}
 					unset($attachment);
@@ -1128,8 +1396,11 @@ 
             // Language Code Page ID: http://msdn.microsoft.com/en-us/library/windows/desktop/dd317756%28v=vs.85%29.aspx
             $output->internetcpid = INTERNET_CPID_UTF8;
 
-			if ($this->debugLevel>3) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.array2string($output));
-//$this->debugLevel=0;
+			if ($this->debugLevel>3)
+			{
+				ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.array2string($output));
+			}
+			//$this->debugLevel=0;
 			return $output;
 		}
 //$this->debugLevel=0;
@@ -1188,14 +1459,18 @@ 
      * @param string $attname - should contain (folder)id
 	 * @return true, prints the content of the attachment
 	 */
-	function GetAttachmentData($fid,$attname) {
+	function GetAttachmentData($fid,$attname)
+	{
 		ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.": $fid (attname: '$attname')".function_backtrace());
 		//error_log(__METHOD__.__LINE__." Fid: $fid (attname: '$attname')");
 		list($folderid, $id, $part) = explode(":", $attname);
 
 		$this->splitID($folderid, $account, $folder);
 
-		if (!isset($this->mail)) $this->mail = Mail::getInstance(false,self::$profileID,true,false,true);
+		if (!isset($this->mail))
+		{
+			$this->mail = Mail::getInstance(false,self::$profileID,true,false,true);
+		}
 
 		$this->mail->reopen($folder);
 		$attachment = $this->mail->getAttachment($id,$part,0,false,true,$folder);
@@ -1204,7 +1479,9 @@ 
         $SIOattachment->data = $attachment['attachment'];
 		//ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.": $fid (attname: '$attname') Data:".$attachment['attachment']);
         if (isset($attachment['type']) )
-            $SIOattachment->contenttype = $attachment['type'];
+        {
+                    $SIOattachment->contenttype = $attachment['type'];
+        }
 
 		unset($attachment);
 
@@ -1221,14 +1498,18 @@ 
      * @param string $attname - should contain (folder)id
 	 * @return SyncItemOperationsAttachment-object
 	 */
-	function ItemOperationsGetAttachmentData($fid,$attname) {
+	function ItemOperationsGetAttachmentData($fid,$attname)
+	{
 		ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.": $fid (attname: '$attname')".function_backtrace());
 		//error_log(__METHOD__.__LINE__." Fid: $fid (attname: '$attname')");
 		list($folderid, $id, $part) = explode(":", $attname);
 
 		$this->splitID($folderid, $account, $folder);
 
-		if (!isset($this->mail)) $this->mail = Mail::getInstance(false,self::$profileID,true,false,true);
+		if (!isset($this->mail))
+		{
+			$this->mail = Mail::getInstance(false,self::$profileID,true,false,true);
+		}
 
 		$this->mail->reopen($folder);
 		$attachment = $this->mail->getAttachment($id,$part,0,false,true,$folder);
@@ -1236,7 +1517,9 @@ 
 		fseek($attachment['attachment'], 0, SEEK_SET);	// z-push requires stream seeked to start
         $SIOattachment->data = $attachment['attachment'];
         if (isset($attachment['type']) )
-            $SIOattachment->contenttype = $attachment['type'];
+        {
+                    $SIOattachment->contenttype = $attachment['type'];
+        }
 
 		unset($attachment);
 
@@ -1282,11 +1565,15 @@ 
 		//unset($folderid, $id, $message, $contentParameters);
 		$account = $folder = null;
 		$this->splitID($folderid, $account, $folder);
-		if (isset($message->flag)) {
-			if (isset($message->flag->flagstatus) && $message->flag->flagstatus == 2) {
+		if (isset($message->flag))
+		{
+			if (isset($message->flag->flagstatus) && $message->flag->flagstatus == 2)
+			{
 				$rv = $this->mail->flagMessages((($message->flag->flagstatus == 2) ? "flagged" : "unflagged"), $id,$folder);
 				ZLog::Write(LOGLEVEL_DEBUG,__METHOD__." -> set ".array2string($id).' in Folder '.$folder." as " . (($message->flag->flagstatus == 2) ? "flagged" : "unflagged") . "-->". $rv);
-			} else {
+			}
+			else
+			{
 				$rv = $this->mail->flagMessages("unflagged", $id,$folder);
 				ZLog::Write(LOGLEVEL_DEBUG,__METHOD__." -> set ".array2string($id).' in Folder '.$folder." as " . "unflagged" . "-->". $rv);
 			}
@@ -1316,7 +1603,10 @@ 
 		$this->splitID($folderid, $account, $srcFolder);
 		$this->splitID($newfolderid, $account, $destFolder);
 		debugLog("IMAP-MoveMessage: (SourceFolder: '$srcFolder'  id: '$id'  DestFolder: '$destFolder' )");
-		if (!isset($this->mail)) $this->mail = Mail::getInstance(false,self::$profileID,true,false,true);
+		if (!isset($this->mail))
+		{
+			$this->mail = Mail::getInstance(false,self::$profileID,true,false,true);
+		}
 		$this->mail->reopen($destFolder);
 		$status = $this->mail->getFolderStatus($destFolder);
 		$uidNext = $status['uidnext'];
@@ -1337,7 +1627,10 @@ 
 	public function GetMessageList($folderid, $cutoffdate=NULL)
 	{
 		static $cutdate=null;
-		if (!empty($cutoffdate) && $cutoffdate >0 && (empty($cutdate) || $cutoffdate != $cutdate))  $cutdate = $cutoffdate;
+		if (!empty($cutoffdate) && $cutoffdate >0 && (empty($cutdate) || $cutoffdate != $cutdate))
+		{
+			$cutdate = $cutoffdate;
+		}
 		debugLog (__METHOD__.' for Folder:'.$folderid.' SINCE:'.$cutdate.'/'.date("d-M-Y", $cutdate));
 		if (empty($cutdate))
 		{
@@ -1349,7 +1642,10 @@ 
 
 	private function fetchMessages($folderid, $cutoffdate=NULL, $_id=NULL)
 	{
-		if ($this->debugLevel>1) $gstarttime = microtime (true);
+		if ($this->debugLevel>1)
+		{
+			$gstarttime = microtime (true);
+		}
 		//ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__);
 		$rv_messages = array();
 		// if the message is still available within the class, we use it instead of fetching it again
@@ -1360,7 +1656,10 @@ 
 		}
 		if (empty($rv_messages))
 		{
-			if ($this->debugLevel>1) $starttime = microtime (true);
+			if ($this->debugLevel>1)
+			{
+				$starttime = microtime (true);
+			}
 			$this->_connect($this->account);
 			if ($this->debugLevel>1)
 			{
@@ -1369,8 +1668,14 @@ 
 			}
 			$messagelist = $_filter = array();
 			// if not connected, any further action must fail
-			if (!empty($cutoffdate)) $_filter = array('status'=>array('UNDELETED'),'range'=>"SINCE",'date'=> date("d-M-Y", $cutoffdate));
-			if ($this->debugLevel>1) $starttime = microtime (true);
+			if (!empty($cutoffdate))
+			{
+				$_filter = array('status'=>array('UNDELETED'),'range'=>"SINCE",'date'=> date("d-M-Y", $cutoffdate));
+			}
+			if ($this->debugLevel>1)
+			{
+				$starttime = microtime (true);
+			}
 			$account = $_folderName = $id = null;
 			$this->splitID($folderid,$account,$_folderName,$id);
 			if ($this->debugLevel>1)
@@ -1378,8 +1683,14 @@ 
 				$endtime = microtime(true) - $starttime;
 				ZLog::Write(LOGLEVEL_DEBUG,__METHOD__. " splitID took : ".$endtime.' for FolderID:'.$folderid);
 			}
-			if ($this->debugLevel>1) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.' for Folder:'.$_folderName.' Filter:'.array2string($_filter).' Ids:'.array2string($_id).'/'.$id);
-			if ($this->debugLevel>1) $starttime = microtime (true);
+			if ($this->debugLevel>1)
+			{
+				ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.' for Folder:'.$_folderName.' Filter:'.array2string($_filter).' Ids:'.array2string($_id).'/'.$id);
+			}
+			if ($this->debugLevel>1)
+			{
+				$starttime = microtime (true);
+			}
 			$_numberOfMessages = (empty($cutoffdate)?250:99999);
 			$rv_messages = $this->mail->getHeaders($_folderName, $_startMessage=1, $_numberOfMessages, $_sort=0, $_reverse=false, $_filter, $_id);
 			if ($this->debugLevel>1)
@@ -1388,26 +1699,55 @@ 
 				ZLog::Write(LOGLEVEL_DEBUG,__METHOD__. " getHeaders call took : ".$endtime.' for FolderID:'.$_folderName);
 			}
 		}
-		if ($_id == NULL && $this->debugLevel>1)  ZLog::Write(LOGLEVEL_DEBUG,__METHOD__." found :". count($rv_messages['header']));
+		if ($_id == NULL && $this->debugLevel>1)
+		{
+			ZLog::Write(LOGLEVEL_DEBUG,__METHOD__." found :". count($rv_messages['header']));
+		}
 		//ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' Result:'.array2string($rv_messages));
 		$messagelist = array();
-		if (!isset($rv_messages['header'])||empty($rv_messages['header'])) return $messagelist;
+		if (!isset($rv_messages['header'])||empty($rv_messages['header']))
+		{
+			return $messagelist;
+		}
 		//if ($_returnModHash) $messageFolderHash = array();
 		foreach ((array)$rv_messages['header'] as $k => $vars)
 		{
-			if ($this->debugLevel>3) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' ID to process:'.$vars['uid'].' Subject:'.$vars['subject']);
+			if ($this->debugLevel>3)
+			{
+				ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' ID to process:'.$vars['uid'].' Subject:'.$vars['subject']);
+			}
 			$this->messages[$vars['uid']] = $vars;
-			if ($this->debugLevel>3) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' MailID:'.$k.'->'.array2string($vars));
-			if (!empty($vars['deleted'])) continue; // cut of deleted messages
-			if ($cutoffdate && $vars['date'] < $cutoffdate) continue; // message is out of range for cutoffdate, ignore it
-			if ($this->debugLevel>0) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' ID to report:'.$vars['uid'].' Subject:'.$vars['subject']);
+			if ($this->debugLevel>3)
+			{
+				ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' MailID:'.$k.'->'.array2string($vars));
+			}
+			if (!empty($vars['deleted']))
+			{
+				continue;
+			}
+			// cut of deleted messages
+			if ($cutoffdate && $vars['date'] < $cutoffdate)
+			{
+				continue;
+			}
+			// message is out of range for cutoffdate, ignore it
+			if ($this->debugLevel>0)
+			{
+				ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.' ID to report:'.$vars['uid'].' Subject:'.$vars['subject']);
+			}
 			$mess["mod"] = self::doFlagsMod($vars).$vars['date'];
 			$mess["id"] = $vars['uid'];
 			// 'seen' aka 'read' is the only flag we want to know about
 			$mess["flags"] = 0;
 			// outlook supports additional flags, set them to 0
-			if($vars["seen"]) $mess["flags"] = 1;
-			if ($this->debugLevel>3) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.array2string($mess));
+			if($vars["seen"])
+			{
+				$mess["flags"] = 1;
+			}
+			if ($this->debugLevel>3)
+			{
+				ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.array2string($mess));
+			}
 			$messagelist[$vars['uid']] = $mess;
 			unset($mess);
 		}
@@ -1432,9 +1772,18 @@ 
 	static function doFlagsMod($headerFlags)
 	{
 		$flags = 'nnn';
-		if ($headerFlags['flagged']) $flags[0] = 'f';
-		if ($headerFlags['answered']) $flags[1] = 'a';
-		if ($headerFlags['forwarded']) $flags[2] = 'f';
+		if ($headerFlags['flagged'])
+		{
+			$flags[0] = 'f';
+		}
+		if ($headerFlags['answered'])
+		{
+			$flags[1] = 'a';
+		}
+		if ($headerFlags['forwarded'])
+		{
+			$flags[2] = 'f';
+		}
 		//ZLog::Write(LOGLEVEL_DEBUG, __METHOD__.'('.array2string($headerFlags).') returning '.array2string($flags));
 		return $flags;
 	}
@@ -1466,31 +1815,55 @@ 
 	{
 		//$this->debugLevel=1;
 		$searchquery=$_searchquery->GetDataArray();
-		if (!is_array($searchquery)) return array();
-		if ($this->debugLevel>0) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.array2string($searchquery));
+		if (!is_array($searchquery))
+		{
+			return array();
+		}
+		if ($this->debugLevel>0)
+		{
+			ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.array2string($searchquery));
+		}
 
-		if (isset($searchquery['searchrebuildresults'])) {
+		if (isset($searchquery['searchrebuildresults']))
+		{
 			$rebuildresults = $searchquery['searchrebuildresults'];
-		} else {
+		}
+		else
+		{
 			$rebuildresults = false;
 		}
-		if ($this->debugLevel>0) debugLog( 'RebuildResults ['.$rebuildresults.']' );
+		if ($this->debugLevel>0)
+		{
+			debugLog( 'RebuildResults ['.$rebuildresults.']' );
+		}
 
-		if (isset($searchquery['deeptraversal'])) {
+		if (isset($searchquery['deeptraversal']))
+		{
 			$deeptraversal = $searchquery['deeptraversal'];
-		} else {
+		}
+		else
+		{
 			$deeptraversal = false;
 		}
-		if ($this->debugLevel>0) debugLog( 'DeepTraversal ['.$deeptraversal.']' );
+		if ($this->debugLevel>0)
+		{
+			debugLog( 'DeepTraversal ['.$deeptraversal.']' );
+		}
 
-		if (isset($searchquery['searchrange'])) {
+		if (isset($searchquery['searchrange']))
+		{
 			$range = explode("-",$_searchquery->GetSearchRange());
 			$start =$range[0] + 1;
 			$limit = $range[1] - $range[0] + 1;
-		} else {
+		}
+		else
+		{
 			$range = false;
 		}
-		if ($this->debugLevel>0) debugLog( 'Range ['.print_r($range, true).']' );
+		if ($this->debugLevel>0)
+		{
+			debugLog( 'Range ['.print_r($range, true).']' );
+		}
 
 		//foreach($searchquery['query'] as $k => $value) {
 		//	$query = $value;
@@ -1542,7 +1915,10 @@ 
 			$_filter['since'] = date("d-M-Y", Api\DateTime::to($sincedate,'ts'));
 		}
 		//$_filter[] = array('type'=>"SINCE",'string'=> date("d-M-Y", $cutoffdate));
-		if ($this->debugLevel>1) debugLog (__METHOD__.' for Folder:'.$_folderName.' Filter:'.array2string($_filter));
+		if ($this->debugLevel>1)
+		{
+			debugLog (__METHOD__.' for Folder:'.$_folderName.' Filter:'.array2string($_filter));
+		}
 		$rv_messages = $this->mail->getHeaders($_folderName, $_startMessage=($range?$start:1), $_numberOfMessages=($limit?$limit:9999999), $_sort=0, $_reverse=false, $_filter, $_id=NULL);
 		//ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__.array2string($rv_messages));
 		$list=array();
@@ -1574,17 +1950,26 @@ 
 	private function getParentID($account,$folder)
 	{
 		$this->_connect($account);
-		if (!isset($this->folders)) $this->folders = $this->mail->getFolderObjects(true,false);
+		if (!isset($this->folders))
+		{
+			$this->folders = $this->mail->getFolderObjects(true,false);
+		}
 
 		$mailFolder = $this->folders[$folder];
-		if (!isset($mailFolder)) return false;
+		if (!isset($mailFolder))
+		{
+			return false;
+		}
 		$delimiter = (isset($mailFolder->delimiter)?$mailFolder->delimiter:$this->mail->getHierarchyDelimiter());
 		$parent = explode($delimiter,$folder);
 		array_pop($parent);
 		$parent = implode($delimiter,$parent);
 
 		$id = $parent ? $this->createID($account, $parent) : '0';
-		if ($this->debugLevel>1) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."('$folder') --> parent=$parent --> $id");
+		if ($this->debugLevel>1)
+		{
+			ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."('$folder') --> parent=$parent --> $id");
+		}
 		return $id;
 	}
 
@@ -1598,7 +1983,10 @@ 
 	{
 		static $last_id = null;
 		static $folderObj = null;
-		if (isset($last_id) && $last_id === $id) return $folderObj;
+		if (isset($last_id) && $last_id === $id)
+		{
+			return $folderObj;
+		}
 
 		try {
 			$account = $folder = null;
@@ -1609,18 +1997,30 @@ 
 			return $folderObj=false;
 		}
 		$this->_connect($account);
-		if (!isset($this->folders)) $this->folders = $this->mail->getFolderObjects(true,false);
+		if (!isset($this->folders))
+		{
+			$this->folders = $this->mail->getFolderObjects(true,false);
+		}
 
 		$mailFolder = $this->folders[$folder];
-		if (!isset($mailFolder)) return $folderObj=false;
+		if (!isset($mailFolder))
+		{
+			return $folderObj=false;
+		}
 
 		$folderObj = new SyncFolder();
 		$folderObj->serverid = $id;
 		$folderObj->parentid = $this->getParentID($account,$folder);
 		$folderObj->displayname = $mailFolder->shortDisplayName;
-		if ($this->debugLevel>1) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__." ID: $id, Account:$account, Folder:$folder");
+		if ($this->debugLevel>1)
+		{
+			ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__." ID: $id, Account:$account, Folder:$folder");
+		}
 		// get folder-type
-		foreach($this->folders as $inbox => $mailFolder) break;
+		foreach($this->folders as $inbox => $mailFolder)
+		{
+			break;
+		}
 		if ($folder == $inbox)
 		{
 			$folderObj->type = SYNC_FOLDER_TYPE_INBOX;
@@ -1657,7 +2057,10 @@ 
 			$folderObj->type = SYNC_FOLDER_TYPE_USER_MAIL;
 		}
 
-		if ($this->debugLevel>1) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."($id) --> $folder --> type=$folderObj->type, parentID=$folderObj->parentid, displayname=$folderObj->displayname");
+		if ($this->debugLevel>1)
+		{
+			ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."($id) --> $folder --> type=$folderObj->type, parentID=$folderObj->parentid, displayname=$folderObj->displayname");
+		}
 		return $folderObj;
 	}
 
@@ -1701,20 +2104,32 @@ 
 	{
 		$account = $folder = null;
 		$this->splitID($folderid, $account, $folder);
-		if (is_numeric($account)) $type = 'mail';
+		if (is_numeric($account))
+		{
+			$type = 'mail';
+		}
         ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.": on $folderid -> $folder ($account) type: ". $type);
-		if ($type != 'mail') return false;
+		if ($type != 'mail')
+		{
+			return false;
+		}
 
-		if (!isset($this->mail)) $this->mail = Mail::getInstance(false,self::$profileID,true,false,true);
+		if (!isset($this->mail))
+		{
+			$this->mail = Mail::getInstance(false,self::$profileID,true,false,true);
+		}
 
 		$changes = array();
         ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.": on $folderid ($folder) stat: ". $syncstate);
         $this->mail->reopen($folder);
         $status = $this->mail->getFolderStatus($folder,$ignoreStatusCache=true);
-        if (!$status) {
+        if (!$status)
+        {
             ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.": could not stat folder $folder ");
             return false;
-        } else {
+        }
+        else
+        {
             $syncstate = "M:". $status['messages'] ."-R:". $status['recent'] ."-U:". $status['unseen']."-NUID:".$status['uidnext']."-UIDV:".$status['uidvalidity'];
         }
 		ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.' called with ('.$folderid.', ....) returning '.array2string($syncstate));
@@ -1751,7 +2166,7 @@ 
      * @throws StatusException              could throw specific SYNC_STATUS_* exceptions
      */
     public function DeleteMessage($folderid, $id, $contentParameters)
-	{
+    {
 		unset($contentParameters);	// not used, but required by function signature
 		debugLog("IMAP-DeleteMessage: (fid: '$folderid'  id: '$id' )");
 		/*
@@ -1777,7 +2192,10 @@ 
 			$error = $e->getMessage();
 			ZLog::Write(LOGLEVEL_DEBUG,__METHOD__.__LINE__." $_messageUID, $folder ->".$error);
 			// if the server thinks the message does not exist report deletion as success
-			if (stripos($error,'[NONEXISTENT]')!==false) return true;
+			if (stripos($error,'[NONEXISTENT]')!==false)
+			{
+				return true;
+			}
 			return false;
 		}
 
@@ -1810,7 +2228,7 @@ 
      * @throws StatusException              could throw specific SYNC_STATUS_* exceptions
      */
     public function SetReadFlag($folderid, $id, $flags, $contentParameters)
-	{
+    {
 		unset($contentParameters);	// not used, but required by function signature
 		// debugLog("IMAP-SetReadFlag: (fid: '$folderid'  id: '$id'  flags: '$flags' )");
 		$account = $folder = null;
@@ -1896,7 +2314,10 @@ 
 
 		$str = $this->backend->createID($account, $folder, $id);
 
-		if ($this->debugLevel>1) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."($account,'$f',$id) type=$account, folder=$folder --> '$str'");
+		if ($this->debugLevel>1)
+		{
+			ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."($account,'$f',$id) type=$account, folder=$folder --> '$str'");
+		}
 
 		return $str;
 	}
@@ -1917,7 +2338,10 @@ 
 		// convert numeric folder-id back to folder name
 		$folder = $this->hash2folder($account,$f=$folder);
 
-		if ($this->debugLevel>1) ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."('$str','$account','$folder',$id)");
+		if ($this->debugLevel>1)
+		{
+			ZLog::Write(LOGLEVEL_DEBUG,__METHOD__."('$str','$account','$folder',$id)");
+		}
 	}
 
 	/**
@@ -1936,7 +2360,10 @@ 
 	 */
 	private function folder2hash($account,$folder)
 	{
-		if(!isset($this->folderHashes)) $this->readFolderHashes();
+		if(!isset($this->folderHashes))
+		{
+			$this->readFolderHashes();
+		}
 
 		if (($index = array_search($folder, (array)$this->folderHashes[$account])) === false)
 		{
@@ -1959,7 +2386,10 @@ 
 	 */
 	private function hash2folder($account,$index)
 	{
-		if(!isset($this->folderHashes)) $this->readFolderHashes();
+		if(!isset($this->folderHashes))
+		{
+			$this->readFolderHashes();
+		}
 
 		return isset($this->folderHashes[$account]) ? $this->folderHashes[$account][$index] : null;
 	}

notifications/inc/class.notifications.inc.php

Doc Comments +1 added lines, -1 removed lines

@@ -434,7 +434,7 @@
 	 * Sets backends that should be skipped even if the user
 	 * defined them in its chain
 	 *
-	 * @param array $_skip_backends array with names of the backends to be skipped
+	 * @param string[] $_skip_backends array with names of the backends to be skipped
 	 * e.g. array('popup', 'winpopup')
 	 */
 	public function set_skip_backends(array $_skip_backends) {

Indentation +8 added lines, -8 removed lines

@@ -660,14 +660,14 @@
 	 }
 
 	 /**
-	 * returns notification chains based on admin prefs
-	 * @abstract the available chains can be retrieved in two different output formats:
-	 * routing: array with common and enabled chains, chain-name as key and the chain-array as value (used for message-routing)
-	 * human: array with common, enabled and disabled chains, chain-name as key and a human-readable description as value (used for config)
-	 *
-	 * @param string $_output one of: 'routing' or 'human', defaults to 'routing'
-	 * @return array containing notification chains, output like given in $_output
-	 */
+	  * returns notification chains based on admin prefs
+	  * @abstract the available chains can be retrieved in two different output formats:
+	  * routing: array with common and enabled chains, chain-name as key and the chain-array as value (used for message-routing)
+	  * human: array with common, enabled and disabled chains, chain-name as key and a human-readable description as value (used for config)
+	  *
+	  * @param string $_output one of: 'routing' or 'human', defaults to 'routing'
+	  * @return array containing notification chains, output like given in $_output
+	  */
 	public function get_available_chains($_output = 'routing') {
 		// determine enabled backends from Api\Config
 		$enabled_backends = array();

Spacing +78 added lines, -78 removed lines

@@ -179,7 +179,7 @@ 
 	 *
 	 */
 	public function __construct() {
-		$this->config = (object) Api\Config::read(self::_appname);
+		$this->config = (object)Api\Config::read(self::_appname);
 	}
 
 	/**
@@ -188,7 +188,7 @@ 
 	 * @param boolean $reset =false true: reset all errors
 	 * @return array
 	 */
-	public static function errors($reset=false)
+	public static function errors($reset = false)
 	{
 		$ret = self::$errors;
 		if ($reset) self::$errors = array();
@@ -203,19 +203,19 @@ 
 	 * it's an int with the account id or the e-mail address of a non-eGW user
 	 */
 	public function set_sender($_sender) {
-		if(is_object($_sender)) {
+		if (is_object($_sender)) {
 			$this->sender = $_sender;
 			return true;
 		} else {
 			// no object atm, we have to handle this and make a pseudo-object
-			if(is_numeric($_sender)) {
-				$this->sender = (object) $GLOBALS['egw']->accounts->read($_sender);
+			if (is_numeric($_sender)) {
+				$this->sender = (object)$GLOBALS['egw']->accounts->read($_sender);
 				return true;
 			}
-			if(is_string($_sender) && strpos($_sender,'@')) {
-				$this->sender = (object) array (
-									'account_email' => $this->get_addresspart($_sender,'email'),
-									'account_fullname' => $this->get_addresspart($_sender,'fullname'),
+			if (is_string($_sender) && strpos($_sender, '@')) {
+				$this->sender = (object)array(
+									'account_email' => $this->get_addresspart($_sender, 'email'),
+									'account_fullname' => $this->get_addresspart($_sender, 'fullname'),
 									);
 				return true;
 			}
@@ -245,19 +245,19 @@ 
 	 * it's an int with the account id or the e-mail address of a non-eGW user
 	 */
 	public function add_receiver($_receiver) {
-		if(is_object($_receiver)) {
+		if (is_object($_receiver)) {
 			$this->receivers[] = $_receiver;
 			return true;
 		} else {
 			// no object atm, we have to handle this and make a pseudo-object
-			if(is_numeric($_receiver)) {
-				$this->receivers[] = (object) $GLOBALS['egw']->accounts->read($_receiver);
+			if (is_numeric($_receiver)) {
+				$this->receivers[] = (object)$GLOBALS['egw']->accounts->read($_receiver);
 				return true;
 			}
-			if(is_string($_receiver) && strpos($_receiver,'@')) {
-				$this->receivers[] = (object) array (
-									'account_email' => $this->get_addresspart($_receiver,'email'),
-									'account_fullname' => $this->get_addresspart($_receiver,'fullname'),
+			if (is_string($_receiver) && strpos($_receiver, '@')) {
+				$this->receivers[] = (object)array(
+									'account_email' => $this->get_addresspart($_receiver, 'email'),
+									'account_fullname' => $this->get_addresspart($_receiver, 'fullname'),
 									);
 				return true;
 			}
@@ -296,7 +296,7 @@ 
 	 * @param string $_message
 	 */
 	public function set_message($_message) {
-		if(strlen($_message) == strlen(strip_tags($_message))) {
+		if (strlen($_message) == strlen(strip_tags($_message))) {
 			$this->message_plain = $_message;
 		} else {
 			$this->message_html = $_message;
@@ -314,7 +314,7 @@ 
 	 */
 	public function set_popupmessage($_message) {
 		//popup requires html
-		if(strlen($_message) == strlen(strip_tags($_message))) $_message = self::plain2html($_message);
+		if (strlen($_message) == strlen(strip_tags($_message))) $_message = self::plain2html($_message);
 		$this->message_popup = $_message;
 		return true;
 	}
@@ -326,9 +326,9 @@ 
 	 */
 	public function set_links(array $_links) {
 		$this->links = array(); // clear array if set
-		foreach($_links as $link) {
-			if(is_array($link)) {
-				$this->add_link($link['text'], $link['view'], $link['popup'], $link['app'],$link['id']);
+		foreach ($_links as $link) {
+			if (is_array($link)) {
+				$this->add_link($link['text'], $link['view'], $link['popup'], $link['app'], $link['id']);
 			}
 		}
 		return true;
@@ -341,8 +341,8 @@ 
 	 */
 	public function set_popuplinks(array $_links) {
 		$this->popup_links = array(); // clear array if set
-		foreach($_links as $link) {
-			if(is_array($link)) {
+		foreach ($_links as $link) {
+			if (is_array($link)) {
 				$this->add_popuplink($link['text'], $link['view'], $link['popup']);
 			}
 		}
@@ -359,7 +359,7 @@ 
 	 * @param string $_id Application ID, to use link registry (popup & view ignored)
 	 */
 	public function add_link($_text, $_view, $_popup = false, $_app = false, $_id = false) {
-		if(!$_view || !$_text) { return false; }
+		if (!$_view || !$_text) { return false; }
 		$this->links[] = (object)array(
 			'text'	=> $_text,
 			'view'	=> $_view,
@@ -378,8 +378,8 @@ 
 	 * @param string $_popup if link can be viewed in a popup something like '300x200' otherwise false
 	 */
 	public function add_popuplink($_text, $_view, $_popup = false) {
-		if(!$_view || !$_text) { return false; }
-		$this->popup_links[] = (object)array(	'text'	=> $_text,
+		if (!$_view || !$_text) { return false; }
+		$this->popup_links[] = (object)array('text'	=> $_text,
 										'view'	=> $_view,
 										'popup'	=> $_popup,
 										);
@@ -393,8 +393,8 @@ 
 	 */
 	public function set_attachments(array $_attachments) {
 		$this->attachments = array(); // clear array if set
-		foreach($_attachments as $attachment) {
-			if(is_array($attachment)) {
+		foreach ($_attachments as $attachment) {
+			if (is_array($attachment)) {
 				$this->add_attachment(
 					$attachment['string'],
 					$attachment['filename'],
@@ -418,8 +418,8 @@ 
 	 * @param string $_type File extension (MIME) type.
 	 * @param string $_path optional path to attachment, if !$_string
 	 */
-	public function add_attachment($_string, $_filename, $_encoding = "base64", $_type = "application/octet-stream", $_path=null) {
-		if(!$_string && (!$_path || !file_exists($_path)) || !$_filename) return false;
+	public function add_attachment($_string, $_filename, $_encoding = "base64", $_type = "application/octet-stream", $_path = null) {
+		if (!$_string && (!$_path || !file_exists($_path)) || !$_filename) return false;
 		$this->attachments[] = (object)array(
 			'string' => $_string,
 			'filename' => $_filename,
@@ -451,7 +451,7 @@ 
 		if (!is_array($this->receivers) || count($this->receivers) == 0) {
 			throw new Exception('Error: cannot send notifications. No receivers supplied');
 		}
-		if(!$messages = $this->create_messages($this->message_plain, $this->message_html, $this->message_popup)) {
+		if (!$messages = $this->create_messages($this->message_plain, $this->message_html, $this->message_popup)) {
 			throw new Exception('Error: cannot send notifications. No valid messages supplied');
 		}
 
@@ -463,7 +463,7 @@ 
 			$backend_errors = array();
 			try {
 				// system or non-system user
-				if($receiver->account_id && is_numeric($receiver->account_id)) {
+				if ($receiver->account_id && is_numeric($receiver->account_id)) {
 					// system user, collect data and check for Status and expire state, skip notification if expired or not active
 					$userData = $GLOBALS['egw']->accounts->read($receiver->account_id);
 					//error_log(__METHOD__.__LINE__." fetched data for User:".array2string($userData['account_lid']).'#'.$userData['account_type'].'#'.$userData['account_status'].'#'.$GLOBALS['egw']->accounts->is_expired($userData).'#');
@@ -476,17 +476,17 @@ 
 					}
 					$receiver->handle = $receiver->account_lid;
 					// check if the receiver has rights to run the notifcation app
-					$ids = $GLOBALS['egw']->accounts->memberships($receiver->account_id,true);
+					$ids = $GLOBALS['egw']->accounts->memberships($receiver->account_id, true);
 					$ids[] = $receiver->account_id;
-					if ($GLOBALS['egw']->acl->get_specific_rights_for_account($ids,'run','notifications')) {
+					if ($GLOBALS['egw']->acl->get_specific_rights_for_account($ids, 'run', 'notifications')) {
 						// read the users notification chain
 						$prefs = new Api\Preferences($receiver->account_id);
 						$preferences_all = $prefs->read();
 						$preferences = (object)$preferences_all[self::_appname];
-						if($preferences->notification_chain) {
+						if ($preferences->notification_chain) {
 							// fallback: admin disabled user-chosen chain
-							if(!$notification_chain = $available_chains[$preferences->notification_chain]) {
-								$prepend_message .= lang(	'This eGroupWare notification has been sent to you by mail because your'
+							if (!$notification_chain = $available_chains[$preferences->notification_chain]) {
+								$prepend_message .= lang('This eGroupWare notification has been sent to you by mail because your'
 															.' chosen notification-chain has been disabled by the administrator.'
 															.' Please choose another notification-chain in your preferences!');
 								$notification_chain = $available_chains[self::_fallback];
@@ -503,28 +503,28 @@ 
 					$notification_chain = $available_chains[self::_fallback]; // fallback: non-system user
 				}
 
-				if($notification_chain == 'disable') {
+				if ($notification_chain == 'disable') {
 					continue; //user disabled notifications
 				}
 
-				foreach($notification_chain as $backend => $action) {
+				foreach ($notification_chain as $backend => $action) {
 					$notification_backend = null;
 					try {
 						// check if backend should be skipped
-						if( in_array($backend, $this->skip_backends) ) {
+						if (in_array($backend, $this->skip_backends)) {
 							// log as error just for the case too much skipping prevents user from being notified
 							$backend_errors[] = $backend.' will be skipped (as defined by calling application)';
 							continue;
 						}
 
 						$notification_backend = self::_appname.'_'.$backend;
-						if(!file_exists(EGW_INCLUDE_ROOT.'/'. self::_appname.'/inc/class.'. $notification_backend. '.inc.php')) {
-							throw new Exception('file for '.$notification_backend. ' does not exist');
+						if (!file_exists(EGW_INCLUDE_ROOT.'/'.self::_appname.'/inc/class.'.$notification_backend.'.inc.php')) {
+							throw new Exception('file for '.$notification_backend.' does not exist');
 						}
-						$obj = new $notification_backend( $this->sender, $receiver, $this->config, $preferences );
-						if ( !($obj instanceof notifications_iface) ) {
-							unset ( $obj );
-					 		throw new Exception($notification_backend. ' is no implementation of notifications_iface');
+						$obj = new $notification_backend($this->sender, $receiver, $this->config, $preferences);
+						if (!($obj instanceof notifications_iface)) {
+							unset ($obj);
+					 		throw new Exception($notification_backend.' is no implementation of notifications_iface');
 						}
 						$lsubject = $this->subject;
 						$llinks = $this->links;
@@ -538,17 +538,17 @@ 
 					catch (Exception $exception) {
 						$backend_errors[] = $notification_backend.' failed: '.$exception->getMessage();
 						// try next backend
-						if($action == 'fail' || $action == 'continue') {
+						if ($action == 'fail' || $action == 'continue') {
 							continue;
 						}
 						break; // stop running through chain
 					}
 					// backend sucseeded
 					$user_notified = true;
-					if($action == 'stop' || $action == 'fail') { break; } // stop running through chain
+					if ($action == 'stop' || $action == 'fail') { break; } // stop running through chain
 				}
 				// check if the user has been notified at all
-				if(!$user_notified) {
+				if (!$user_notified) {
 					/*error_log('Error: notification of receiver '.$receiver->handle.' failed for the following reasons:');
 					foreach($backend_errors as $id=>$backend_error) {
 						error_log($backend_error);
@@ -575,22 +575,22 @@ 
 	 * @return plain and html message in one array, $messages['plain'] and $messages['html'] and, if exists $messages['popup']
 	 */
 	private function create_messages($_message_plain = '', $_message_html = '', $_message_popup = '') {
-		if(empty($_message_plain) && empty($_message_html) && empty($_message_popup)) { return false; } // no message set
+		if (empty($_message_plain) && empty($_message_html) && empty($_message_popup)) { return false; } // no message set
 		$messages = array();
 
 		// create the messages
-		if(!empty($_message_plain)) {
+		if (!empty($_message_plain)) {
 			$messages['plain'] = $_message_plain;
 		} else {
 			$messages['plain'] = Api\Mail\Html::convertHTMLToText($_message_html, false, true);
 		}
 
-		if(!empty($_message_html)) {
+		if (!empty($_message_html)) {
 			$messages['html'] = $_message_html;
 		} else {
 			$messages['html'] = self::plain2html($_message_plain);
 		}
-		if (!empty($_message_popup)) $messages['popup']=$_message_popup;
+		if (!empty($_message_popup)) $messages['popup'] = $_message_popup;
 		return $messages;
 	}
 
@@ -613,9 +613,9 @@ 
 	 * @return plain and html message in one array including the prepended message, $messages['plain'] and $messages['html']
 	 */
 	 private function prepend_message(array $_messages, $_prepend = null) {
-		if(strlen($_prepend) > 0) {
-			foreach($_messages as $key => $value) {
-				switch($key) {
+		if (strlen($_prepend) > 0) {
+			foreach ($_messages as $key => $value) {
+				switch ($key) {
 					case 'plain':
 						$_messages[$key] = $_prepend."\n\n".$value;
 						break;
@@ -639,17 +639,17 @@ 
 	 * @param string $_part
 	 * @return string chosen part of the address
 	 */
-	private function get_addresspart($_address, $_part='email')
+	private function get_addresspart($_address, $_part = 'email')
 	{
 		$parts = null;
-	 	if(strpos($_address,'<') && preg_match('/^(.*)\S?\<(.*)\>/',$_address, $parts)) { // _address contains a fullname part
-	 		$fullname = trim(trim($parts[1]),'\"');
+	 	if (strpos($_address, '<') && preg_match('/^(.*)\S?\<(.*)\>/', $_address, $parts)) { // _address contains a fullname part
+	 		$fullname = trim(trim($parts[1]), '\"');
 	 		$email = $parts[2];
 	 	} else {
 	 		$fullname = false;
 	 		$email = $_address;
 	 	}
-	 	switch($_part) {
+	 	switch ($_part) {
 	 		case 'fullname':
 	 			return $fullname;
 	 		case 'email':
@@ -671,8 +671,8 @@ 
 	public function get_available_chains($_output = 'routing') {
 		// determine enabled backends from Api\Config
 		$enabled_backends = array();
-		foreach($this->backends as $backend) {
-			switch($backend) {
+		foreach ($this->backends as $backend) {
+			switch ($backend) {
 				case 'email':
 				case 'popup':
 				case 'jpopup':
@@ -687,15 +687,15 @@ 
 
 		$enabled_chains = array();
 		$disabled_chains = array();
-		foreach($this->notification_chains as $key => $chain) {
+		foreach ($this->notification_chains as $key => $chain) {
 			$allow_chain = true;
-			if(is_array($chain)) {
-				foreach(array_keys($chain) as $name) {
-					if(!$enabled_backends[$name]) {
+			if (is_array($chain)) {
+				foreach (array_keys($chain) as $name) {
+					if (!$enabled_backends[$name]) {
 						$allow_chain = false; // disable whole chain if one backend is disabled
 					}
 				}
-				if($allow_chain) {
+				if ($allow_chain) {
 					$enabled_chains[$key] = $chain;
 				} else {
 					$disabled_chains[$key] = $chain;
@@ -710,15 +710,15 @@ 
 		// create the 'all' chain from the enabled backends
 		$chain_all = array();
 		$backend_count = 1;
-		foreach($enabled_backends as $backend => $enabled) {
-			if($enabled) {
+		foreach ($enabled_backends as $backend => $enabled) {
+			if ($enabled) {
 				$chain_all[$backend] = count($enabled_backends) == $backend_count ? 'stop' : 'continue';
 			}
 			$backend_count++;
 		}
 		$common_chains['all'] = $chain_all;
 
-		switch($_output) {
+		switch ($_output) {
 			case 'human':
 				$chain_groups = array(
 					lang('Common chains')	=> 'common_chains',
@@ -727,10 +727,10 @@ 
 					);
 				$suffix = '_human';
 				// create descriptions for each chain key in each group
-				foreach($chain_groups as $name => $arr_name) {
+				foreach ($chain_groups as $name => $arr_name) {
 					${$arr_name.$suffix} = array();
-					foreach(array_keys(${$arr_name}) as $key) {
-						if($arr_name == 'disabled_chains') {
+					foreach (array_keys(${$arr_name}) as $key) {
+						if ($arr_name == 'disabled_chains') {
 							${$arr_name.$suffix}[$key] = '('.lang('Disabled').') '.lang($this->chains_descriptions[$key]);
 						} else {
 							${$arr_name.$suffix}[$key] = lang($this->chains_descriptions[$key]);
@@ -739,8 +739,8 @@ 
 				}
 				// summarize all groups with minimum one chain to the final array
 				$chains_final = array();
-				foreach($chain_groups as $name => $arr_name) {
-					if(is_array(${$arr_name.$suffix}) && count(${$arr_name.$suffix}) > 0) {
+				foreach ($chain_groups as $name => $arr_name) {
+					if (is_array(${$arr_name.$suffix}) && count(${$arr_name.$suffix}) > 0) {
 						$chains_final[$name] = ${$arr_name.$suffix};
 					}
 				}
@@ -760,10 +760,10 @@ 
 	 * @param settings array with keys account_id and new_owner (new_owner is optional)
 	 */
 	public function deleteaccount($settings) {
-		foreach($this->backends as $backend) {
-			$backend_hook = array(self::_appname.'_'.$backend,'deleteaccount');
+		foreach ($this->backends as $backend) {
+			$backend_hook = array(self::_appname.'_'.$backend, 'deleteaccount');
 			if (is_callable($backend_hook)) {
-				call_user_func($backend_hook,$settings);
+				call_user_func($backend_hook, $settings);
 			}
 		}
 	}

Braces +222 added lines, -96 removed lines

@@ -24,7 +24,8 @@ 
  * called from this class. The backend's job is to deliver ONE message to ONE recipient.
  *
  */
-final class notifications {
+final class notifications
+{
 
 	/**
 	 * Appname
@@ -178,7 +179,8 @@ 
 	 * constructor of notifications
 	 *
 	 */
-	public function __construct() {
+	public function __construct()
+	{
 		$this->config = (object) Api\Config::read(self::_appname);
 	}
 
@@ -191,7 +193,10 @@ 
 	public static function errors($reset=false)
 	{
 		$ret = self::$errors;
-		if ($reset) self::$errors = array();
+		if ($reset)
+		{
+			self::$errors = array();
+		}
 		return $ret;
 	}
 
@@ -202,17 +207,23 @@ 
 	 * as long as the accounts class isn't a nice object,
 	 * it's an int with the account id or the e-mail address of a non-eGW user
 	 */
-	public function set_sender($_sender) {
-		if(is_object($_sender)) {
+	public function set_sender($_sender)
+	{
+		if(is_object($_sender))
+		{
 			$this->sender = $_sender;
 			return true;
-		} else {
+		}
+		else
+		{
 			// no object atm, we have to handle this and make a pseudo-object
-			if(is_numeric($_sender)) {
+			if(is_numeric($_sender))
+			{
 				$this->sender = (object) $GLOBALS['egw']->accounts->read($_sender);
 				return true;
 			}
-			if(is_string($_sender) && strpos($_sender,'@')) {
+			if(is_string($_sender) && strpos($_sender,'@'))
+			{
 				$this->sender = (object) array (
 									'account_email' => $this->get_addresspart($_sender,'email'),
 									'account_fullname' => $this->get_addresspart($_sender,'fullname'),
@@ -230,9 +241,11 @@ 
 	 * as long as the accounts class isn't a nice object,
 	 * it's an array with the int of the account id or the e-mail address of a non-eGW user
 	 */
-	public function set_receivers(array $_receivers) {
+	public function set_receivers(array $_receivers)
+	{
 		$this->receivers = array();
-		foreach ($_receivers as $receiver) {
+		foreach ($_receivers as $receiver)
+		{
 			$this->add_receiver($receiver);
 		}
 	}
@@ -244,17 +257,23 @@ 
 	 * as long as the accounts class isn't a nice object,
 	 * it's an int with the account id or the e-mail address of a non-eGW user
 	 */
-	public function add_receiver($_receiver) {
-		if(is_object($_receiver)) {
+	public function add_receiver($_receiver)
+	{
+		if(is_object($_receiver))
+		{
 			$this->receivers[] = $_receiver;
 			return true;
-		} else {
+		}
+		else
+		{
 			// no object atm, we have to handle this and make a pseudo-object
-			if(is_numeric($_receiver)) {
+			if(is_numeric($_receiver))
+			{
 				$this->receivers[] = (object) $GLOBALS['egw']->accounts->read($_receiver);
 				return true;
 			}
-			if(is_string($_receiver) && strpos($_receiver,'@')) {
+			if(is_string($_receiver) && strpos($_receiver,'@'))
+			{
 				$this->receivers[] = (object) array (
 									'account_email' => $this->get_addresspart($_receiver,'email'),
 									'account_fullname' => $this->get_addresspart($_receiver,'fullname'),
@@ -270,7 +289,8 @@ 
 	 *
 	 * @param string $_subject
 	 */
-	public function set_subject($_subject) {
+	public function set_subject($_subject)
+	{
 		$this->subject = $_subject;
 		return true;
 	}
@@ -280,7 +300,8 @@ 
 	 *
 	 * @param string $_subject
 	 */
-	public function set_popupsubject($_subject) {
+	public function set_popupsubject($_subject)
+	{
 		$this->popupsubject = $_subject;
 		return true;
 	}
@@ -295,10 +316,14 @@ 
 	 *
 	 * @param string $_message
 	 */
-	public function set_message($_message) {
-		if(strlen($_message) == strlen(strip_tags($_message))) {
+	public function set_message($_message)
+	{
+		if(strlen($_message) == strlen(strip_tags($_message)))
+		{
 			$this->message_plain = $_message;
-		} else {
+		}
+		else
+		{
 			$this->message_html = $_message;
 		}
 		return true;
@@ -312,9 +337,13 @@ 
 	 *
 	 * @param string $_message
 	 */
-	public function set_popupmessage($_message) {
+	public function set_popupmessage($_message)
+	{
 		//popup requires html
-		if(strlen($_message) == strlen(strip_tags($_message))) $_message = self::plain2html($_message);
+		if(strlen($_message) == strlen(strip_tags($_message)))
+		{
+			$_message = self::plain2html($_message);
+		}
 		$this->message_popup = $_message;
 		return true;
 	}
@@ -324,10 +353,13 @@ 
 	 *
 	 * @param array $_links link array (like defined in $this->add_link)
 	 */
-	public function set_links(array $_links) {
+	public function set_links(array $_links)
+	{
 		$this->links = array(); // clear array if set
-		foreach($_links as $link) {
-			if(is_array($link)) {
+		foreach($_links as $link)
+		{
+			if(is_array($link))
+			{
 				$this->add_link($link['text'], $link['view'], $link['popup'], $link['app'],$link['id']);
 			}
 		}
@@ -339,10 +371,13 @@ 
 	 *
 	 * @param array $_links link array (like defined in $this->add_link)
 	 */
-	public function set_popuplinks(array $_links) {
+	public function set_popuplinks(array $_links)
+	{
 		$this->popup_links = array(); // clear array if set
-		foreach($_links as $link) {
-			if(is_array($link)) {
+		foreach($_links as $link)
+		{
+			if(is_array($link))
+			{
 				$this->add_popuplink($link['text'], $link['view'], $link['popup']);
 			}
 		}
@@ -358,8 +393,11 @@ 
 	 * @param string $_app Application name, to use link registry (popup & view ignored)
 	 * @param string $_id Application ID, to use link registry (popup & view ignored)
 	 */
-	public function add_link($_text, $_view, $_popup = false, $_app = false, $_id = false) {
-		if(!$_view || !$_text) { return false; }
+	public function add_link($_text, $_view, $_popup = false, $_app = false, $_id = false)
+	{
+		if(!$_view || !$_text)
+		{
+return false; }
 		$this->links[] = (object)array(
 			'text'	=> $_text,
 			'view'	=> $_view,
@@ -377,8 +415,11 @@ 
 	 * @param array $_view all params needed to view the link (name => value pairs)
 	 * @param string $_popup if link can be viewed in a popup something like '300x200' otherwise false
 	 */
-	public function add_popuplink($_text, $_view, $_popup = false) {
-		if(!$_view || !$_text) { return false; }
+	public function add_popuplink($_text, $_view, $_popup = false)
+	{
+		if(!$_view || !$_text)
+		{
+return false; }
 		$this->popup_links[] = (object)array(	'text'	=> $_text,
 										'view'	=> $_view,
 										'popup'	=> $_popup,
@@ -391,10 +432,13 @@ 
 	 *
 	 * @param array $_attachments attachment array (like defined in $this->add_attachment)
 	 */
-	public function set_attachments(array $_attachments) {
+	public function set_attachments(array $_attachments)
+	{
 		$this->attachments = array(); // clear array if set
-		foreach($_attachments as $attachment) {
-			if(is_array($attachment)) {
+		foreach($_attachments as $attachment)
+		{
+			if(is_array($attachment))
+			{
 				$this->add_attachment(
 					$attachment['string'],
 					$attachment['filename'],
@@ -418,8 +462,12 @@ 
 	 * @param string $_type File extension (MIME) type.
 	 * @param string $_path optional path to attachment, if !$_string
 	 */
-	public function add_attachment($_string, $_filename, $_encoding = "base64", $_type = "application/octet-stream", $_path=null) {
-		if(!$_string && (!$_path || !file_exists($_path)) || !$_filename) return false;
+	public function add_attachment($_string, $_filename, $_encoding = "base64", $_type = "application/octet-stream", $_path=null)
+	{
+		if(!$_string && (!$_path || !file_exists($_path)) || !$_filename)
+		{
+			return false;
+		}
 		$this->attachments[] = (object)array(
 			'string' => $_string,
 			'filename' => $_filename,
@@ -437,33 +485,40 @@ 
 	 * @param array $_skip_backends array with names of the backends to be skipped
 	 * e.g. array('popup', 'winpopup')
 	 */
-	public function set_skip_backends(array $_skip_backends) {
+	public function set_skip_backends(array $_skip_backends)
+	{
 		$this->skip_backends = $_skip_backends;
 	}
 
 	/**
 	 * sends notifications
 	 */
-	public function send() {
-		if (!is_object($this->sender)) {
+	public function send()
+	{
+		if (!is_object($this->sender))
+		{
 			throw new Exception('Error: cannot send notifications. No sender supplied');
 		}
-		if (!is_array($this->receivers) || count($this->receivers) == 0) {
+		if (!is_array($this->receivers) || count($this->receivers) == 0)
+		{
 			throw new Exception('Error: cannot send notifications. No receivers supplied');
 		}
-		if(!$messages = $this->create_messages($this->message_plain, $this->message_html, $this->message_popup)) {
+		if(!$messages = $this->create_messages($this->message_plain, $this->message_html, $this->message_popup))
+		{
 			throw new Exception('Error: cannot send notifications. No valid messages supplied');
 		}
 
 		$available_chains = $this->get_available_chains('routing');
 
-		foreach ($this->receivers as $receiver) {
+		foreach ($this->receivers as $receiver)
+		{
 			$user_notified = false;
 			$prepend_message = '';
 			$backend_errors = array();
 			try {
 				// system or non-system user
-				if($receiver->account_id && is_numeric($receiver->account_id)) {
+				if($receiver->account_id && is_numeric($receiver->account_id))
+				{
 					// system user, collect data and check for Status and expire state, skip notification if expired or not active
 					$userData = $GLOBALS['egw']->accounts->read($receiver->account_id);
 					//error_log(__METHOD__.__LINE__." fetched data for User:".array2string($userData['account_lid']).'#'.$userData['account_type'].'#'.$userData['account_status'].'#'.$GLOBALS['egw']->accounts->is_expired($userData).'#');
@@ -478,51 +533,65 @@ 
 					// check if the receiver has rights to run the notifcation app
 					$ids = $GLOBALS['egw']->accounts->memberships($receiver->account_id,true);
 					$ids[] = $receiver->account_id;
-					if ($GLOBALS['egw']->acl->get_specific_rights_for_account($ids,'run','notifications')) {
+					if ($GLOBALS['egw']->acl->get_specific_rights_for_account($ids,'run','notifications'))
+					{
 						// read the users notification chain
 						$prefs = new Api\Preferences($receiver->account_id);
 						$preferences_all = $prefs->read();
 						$preferences = (object)$preferences_all[self::_appname];
-						if($preferences->notification_chain) {
+						if($preferences->notification_chain)
+						{
 							// fallback: admin disabled user-chosen chain
-							if(!$notification_chain = $available_chains[$preferences->notification_chain]) {
+							if(!$notification_chain = $available_chains[$preferences->notification_chain])
+							{
 								$prepend_message .= lang(	'This eGroupWare notification has been sent to you by mail because your'
 															.' chosen notification-chain has been disabled by the administrator.'
 															.' Please choose another notification-chain in your preferences!');
 								$notification_chain = $available_chains[self::_fallback];
 							}
-						} else {
+						}
+						else
+						{
 							$notification_chain = $available_chains[self::user_fallback]; // fallback: no prefs
 						}
-					} else {
+					}
+					else
+					{
 						$notification_chain = $available_chains[self::_fallback]; // fallback: no rights to app
 					}
-				} else {
+				}
+				else
+				{
 					// non-system user
 					$receiver->handle = $receiver->account_email;
 					$notification_chain = $available_chains[self::_fallback]; // fallback: non-system user
 				}
 
-				if($notification_chain == 'disable') {
+				if($notification_chain == 'disable')
+				{
 					continue; //user disabled notifications
 				}
 
-				foreach($notification_chain as $backend => $action) {
+				foreach($notification_chain as $backend => $action)
+				{
 					$notification_backend = null;
 					try {
 						// check if backend should be skipped
-						if( in_array($backend, $this->skip_backends) ) {
+						if( in_array($backend, $this->skip_backends) )
+						{
 							// log as error just for the case too much skipping prevents user from being notified
 							$backend_errors[] = $backend.' will be skipped (as defined by calling application)';
 							continue;
 						}
 
 						$notification_backend = self::_appname.'_'.$backend;
-						if(!file_exists(EGW_INCLUDE_ROOT.'/'. self::_appname.'/inc/class.'. $notification_backend. '.inc.php')) {
+						if(!file_exists(EGW_INCLUDE_ROOT.'/'. self::_appname.'/inc/class.'. $notification_backend. '.inc.php'))
+						{
 							throw new Exception('file for '.$notification_backend. ' does not exist');
 						}
 						$obj = new $notification_backend( $this->sender, $receiver, $this->config, $preferences );
-						if ( !($obj instanceof notifications_iface) ) {
+						if ( !($obj instanceof notifications_iface) )
+						{
 							unset ( $obj );
 					 		throw new Exception($notification_backend. ' is no implementation of notifications_iface');
 						}
@@ -530,31 +599,44 @@ 
 						$llinks = $this->links;
 						if ($backend == 'popup')
 						{
-							if (!empty($this->popupsubject)) $lsubject = $this->popupsubject;
-							if ($this->popup_links) $llinks = $this->popup_links;
+							if (!empty($this->popupsubject))
+							{
+								$lsubject = $this->popupsubject;
+							}
+							if ($this->popup_links)
+							{
+								$llinks = $this->popup_links;
+							}
 						}
 						$obj->send($this->prepend_message($messages, $prepend_message), $lsubject, $llinks, $this->attachments);
 					}
 					catch (Exception $exception) {
 						$backend_errors[] = $notification_backend.' failed: '.$exception->getMessage();
 						// try next backend
-						if($action == 'fail' || $action == 'continue') {
+						if($action == 'fail' || $action == 'continue')
+						{
 							continue;
 						}
 						break; // stop running through chain
 					}
 					// backend sucseeded
 					$user_notified = true;
-					if($action == 'stop' || $action == 'fail') { break; } // stop running through chain
+					if($action == 'stop' || $action == 'fail')
+					{
+break; } // stop running through chain
 				}
 				// check if the user has been notified at all
-				if(!$user_notified) {
+				if(!$user_notified)
+				{
 					/*error_log('Error: notification of receiver '.$receiver->handle.' failed for the following reasons:');
 					foreach($backend_errors as $id=>$backend_error) {
 						error_log($backend_error);
 					}*/
 					$error = implode(', ', $backend_errors);
-					if (stripos($error, (string)$receiver->handle) !== false) $error = $receiver->handle.': '.$error;
+					if (stripos($error, (string)$receiver->handle) !== false)
+					{
+						$error = $receiver->handle.': '.$error;
+					}
 					self::$errors[] = $error;
 				}
 			}
@@ -574,23 +656,35 @@ 
 	 * @param string $_message_popup
 	 * @return plain and html message in one array, $messages['plain'] and $messages['html'] and, if exists $messages['popup']
 	 */
-	private function create_messages($_message_plain = '', $_message_html = '', $_message_popup = '') {
-		if(empty($_message_plain) && empty($_message_html) && empty($_message_popup)) { return false; } // no message set
+	private function create_messages($_message_plain = '', $_message_html = '', $_message_popup = '')
+	{
+		if(empty($_message_plain) && empty($_message_html) && empty($_message_popup))
+		{
+return false; } // no message set
 		$messages = array();
 
 		// create the messages
-		if(!empty($_message_plain)) {
+		if(!empty($_message_plain))
+		{
 			$messages['plain'] = $_message_plain;
-		} else {
+		}
+		else
+		{
 			$messages['plain'] = Api\Mail\Html::convertHTMLToText($_message_html, false, true);
 		}
 
-		if(!empty($_message_html)) {
+		if(!empty($_message_html))
+		{
 			$messages['html'] = $_message_html;
-		} else {
+		}
+		else
+		{
 			$messages['html'] = self::plain2html($_message_plain);
 		}
-		if (!empty($_message_popup)) $messages['popup']=$_message_popup;
+		if (!empty($_message_popup))
+		{
+			$messages['popup']=$_message_popup;
+		}
 		return $messages;
 	}
 
@@ -612,10 +706,14 @@ 
 	 * @param string $_prepend just a plain message to prepend, no html!
 	 * @return plain and html message in one array including the prepended message, $messages['plain'] and $messages['html']
 	 */
-	 private function prepend_message(array $_messages, $_prepend = null) {
-		if(strlen($_prepend) > 0) {
-			foreach($_messages as $key => $value) {
-				switch($key) {
+	 private function prepend_message(array $_messages, $_prepend = null)
+	 {
+		if(strlen($_prepend) > 0)
+		{
+			foreach($_messages as $key => $value)
+			{
+				switch($key)
+				{
 					case 'plain':
 						$_messages[$key] = $_prepend."\n\n".$value;
 						break;
@@ -642,14 +740,19 @@ 
 	private function get_addresspart($_address, $_part='email')
 	{
 		$parts = null;
-	 	if(strpos($_address,'<') && preg_match('/^(.*)\S?\<(.*)\>/',$_address, $parts)) { // _address contains a fullname part
+	 	if(strpos($_address,'<') && preg_match('/^(.*)\S?\<(.*)\>/',$_address, $parts))
+	 	{
+// _address contains a fullname part
 	 		$fullname = trim(trim($parts[1]),'\"');
 	 		$email = $parts[2];
-	 	} else {
+	 	}
+	 	else
+	 	{
 	 		$fullname = false;
 	 		$email = $_address;
 	 	}
-	 	switch($_part) {
+	 	switch($_part)
+	 	{
 	 		case 'fullname':
 	 			return $fullname;
 	 		case 'email':
@@ -668,11 +771,14 @@ 
 	 * @param string $_output one of: 'routing' or 'human', defaults to 'routing'
 	 * @return array containing notification chains, output like given in $_output
 	 */
-	public function get_available_chains($_output = 'routing') {
+	public function get_available_chains($_output = 'routing')
+	{
 		// determine enabled backends from Api\Config
 		$enabled_backends = array();
-		foreach($this->backends as $backend) {
-			switch($backend) {
+		foreach($this->backends as $backend)
+		{
+			switch($backend)
+			{
 				case 'email':
 				case 'popup':
 				case 'jpopup':
@@ -687,17 +793,24 @@ 
 
 		$enabled_chains = array();
 		$disabled_chains = array();
-		foreach($this->notification_chains as $key => $chain) {
+		foreach($this->notification_chains as $key => $chain)
+		{
 			$allow_chain = true;
-			if(is_array($chain)) {
-				foreach(array_keys($chain) as $name) {
-					if(!$enabled_backends[$name]) {
+			if(is_array($chain))
+			{
+				foreach(array_keys($chain) as $name)
+				{
+					if(!$enabled_backends[$name])
+					{
 						$allow_chain = false; // disable whole chain if one backend is disabled
 					}
 				}
-				if($allow_chain) {
+				if($allow_chain)
+				{
 					$enabled_chains[$key] = $chain;
-				} else {
+				}
+				else
+				{
 					$disabled_chains[$key] = $chain;
 				}
 			}
@@ -710,15 +823,18 @@ 
 		// create the 'all' chain from the enabled backends
 		$chain_all = array();
 		$backend_count = 1;
-		foreach($enabled_backends as $backend => $enabled) {
-			if($enabled) {
+		foreach($enabled_backends as $backend => $enabled)
+		{
+			if($enabled)
+			{
 				$chain_all[$backend] = count($enabled_backends) == $backend_count ? 'stop' : 'continue';
 			}
 			$backend_count++;
 		}
 		$common_chains['all'] = $chain_all;
 
-		switch($_output) {
+		switch($_output)
+		{
 			case 'human':
 				$chain_groups = array(
 					lang('Common chains')	=> 'common_chains',
@@ -727,20 +843,27 @@ 
 					);
 				$suffix = '_human';
 				// create descriptions for each chain key in each group
-				foreach($chain_groups as $name => $arr_name) {
+				foreach($chain_groups as $name => $arr_name)
+				{
 					${$arr_name.$suffix} = array();
-					foreach(array_keys(${$arr_name}) as $key) {
-						if($arr_name == 'disabled_chains') {
+					foreach(array_keys(${$arr_name}) as $key)
+					{
+						if($arr_name == 'disabled_chains')
+						{
 							${$arr_name.$suffix}[$key] = '('.lang('Disabled').') '.lang($this->chains_descriptions[$key]);
-						} else {
+						}
+						else
+						{
 							${$arr_name.$suffix}[$key] = lang($this->chains_descriptions[$key]);
 						}
 					}
 				}
 				// summarize all groups with minimum one chain to the final array
 				$chains_final = array();
-				foreach($chain_groups as $name => $arr_name) {
-					if(is_array(${$arr_name.$suffix}) && count(${$arr_name.$suffix}) > 0) {
+				foreach($chain_groups as $name => $arr_name)
+				{
+					if(is_array(${$arr_name.$suffix}) && count(${$arr_name.$suffix}) > 0)
+					{
 						$chains_final[$name] = ${$arr_name.$suffix};
 					}
 				}
@@ -759,10 +882,13 @@ 
 	 *
 	 * @param settings array with keys account_id and new_owner (new_owner is optional)
 	 */
-	public function deleteaccount($settings) {
-		foreach($this->backends as $backend) {
+	public function deleteaccount($settings)
+	{
+		foreach($this->backends as $backend)
+		{
 			$backend_hook = array(self::_appname.'_'.$backend,'deleteaccount');
-			if (is_callable($backend_hook)) {
+			if (is_callable($backend_hook))
+			{
 				call_user_func($backend_hook,$settings);
 			}
 		}

notifications/inc/class.notifications_email.inc.php

Doc Comments +1 added lines, -1 removed lines

@@ -131,7 +131,7 @@
 	 * @param array $_links
 	 * @param boolean $_render_html
 	 * @param boolean $_render_external
-	 * @return plain or html rendered link(s) as complete string
+	 * @return false|string or html rendered link(s) as complete string
 	 */
 	private function render_links($_links = false, $_render_html = false, $_render_external = true) {
 		if(!is_array($_links) || count($_links) == 0) { return false; }

Spacing +14 added lines, -14 removed lines

@@ -66,13 +66,13 @@ 
 	 * @param object $_preferences
 	 */
 	public function __construct($_sender, $_recipient, $_config = null, $_preferences = null) {
-		if(!is_object($_sender)) { throw new Exception("no sender given."); }
-		if(!is_object($_recipient)) { throw new Exception("no recipient given."); }
+		if (!is_object($_sender)) { throw new Exception("no sender given."); }
+		if (!is_object($_recipient)) { throw new Exception("no recipient given."); }
 		$this->sender = $_sender;
 		$this->recipient = $_recipient;
 		$this->config = $_config;
 		$this->preferences = $_preferences;
-		if(is_object($this->mail))
+		if (is_object($this->mail))
 		{
 			unset($this->mail);
 		}
@@ -104,18 +104,18 @@ 
 		$this->mail->setFrom($this->sender->account_email, $this->sender->account_fullname);
 
 		$this->mail->addHeader('Subject', trim($_subject)); // trim the subject to avoid strange wrong encoding problem
-		$this->mail->setHtmlBody($body_html, null, false);	// no automatic alternativ
+		$this->mail->setHtmlBody($body_html, null, false); // no automatic alternativ
 		$this->mail->setBody($body_plain);
 
-		if(is_array($_attachments) && count($_attachments) > 0)
+		if (is_array($_attachments) && count($_attachments) > 0)
 		{
-			foreach($_attachments as $attachment)
+			foreach ($_attachments as $attachment)
 			{
 				if ($attachment->string)
 				{
 					$this->mail->AddStringAttachment($attachment->string, $attachment->filename, $attachment->encoding, $attachment->type);
 				}
-				elseif($attachment->path)
+				elseif ($attachment->path)
 				{
 					$this->mail->AddAttachment($attachment->path, $attachment->filename, $attachment->encoding, $attachment->type);
 				}
@@ -134,20 +134,20 @@ 
 	 * @return plain or html rendered link(s) as complete string
 	 */
 	private function render_links($_links = false, $_render_html = false, $_render_external = true) {
-		if(!is_array($_links) || count($_links) == 0) { return false; }
+		if (!is_array($_links) || count($_links) == 0) { return false; }
 
 		// provide defaults if given arguments are null
 		// php distinguishes between missing and present(null) arguments
-		if(is_null($_render_html)) { $_render_html = false; }
-		if(is_null($_render_external)) { $_render_external = true; }
+		if (is_null($_render_html)) { $_render_html = false; }
+		if (is_null($_render_external)) { $_render_external = true; }
 		$newline = $_render_html ? "<br />" : "\n";
 		$hruler = $_render_html ? Api\Html::hr() : '';
 
 		$rendered_links = array();
-		foreach($_links as $link) {
-			if($_render_external || ! $link->popup) { $link->view['no_popup'] = 1; }
+		foreach ($_links as $link) {
+			if ($_render_external || !$link->popup) { $link->view['no_popup'] = 1; }
 			// do not expose sensitive data
-			$url = preg_replace('/(sessionid|kp3|domain)=[^&]+&?/','',Api\Html::link('/index.php', $link->view));
+			$url = preg_replace('/(sessionid|kp3|domain)=[^&]+&?/', '', Api\Html::link('/index.php', $link->view));
 			// complete missing protocol and domain part if needed
 			if ($url{0} == '/' && $_render_external) {
 				$url = ($_SERVER['HTTPS'] || $GLOBALS['egw_info']['server']['enforce_ssl'] ? 'https://' : 'http://').
@@ -157,7 +157,7 @@ 
 			$rendered_links[] = $_render_html ? $a_href : $url;
 		}
 
-		return $hruler.$newline.lang('Linked entries:').$newline.implode($newline,$rendered_links);
+		return $hruler.$newline.lang('Linked entries:').$newline.implode($newline, $rendered_links);
 	}
 
 }

Braces +28 added lines, -11 removed lines

@@ -15,7 +15,8 @@ 
 /**
  * User notification via email.
  */
-class notifications_email implements notifications_iface {
+class notifications_email implements notifications_iface
+{
 
 	/**
 	 * Appname
@@ -65,9 +66,14 @@ 
 	 * @param object $_config
 	 * @param object $_preferences
 	 */
-	public function __construct($_sender, $_recipient, $_config = null, $_preferences = null) {
-		if(!is_object($_sender)) { throw new Exception("no sender given."); }
-		if(!is_object($_recipient)) { throw new Exception("no recipient given."); }
+	public function __construct($_sender, $_recipient, $_config = null, $_preferences = null)
+	{
+		if(!is_object($_sender))
+		{
+throw new Exception("no sender given."); }
+		if(!is_object($_recipient))
+		{
+throw new Exception("no recipient given."); }
 		$this->sender = $_sender;
 		$this->recipient = $_recipient;
 		$this->config = $_config;
@@ -133,23 +139,34 @@ 
 	 * @param boolean $_render_external
 	 * @return plain or html rendered link(s) as complete string
 	 */
-	private function render_links($_links = false, $_render_html = false, $_render_external = true) {
-		if(!is_array($_links) || count($_links) == 0) { return false; }
+	private function render_links($_links = false, $_render_html = false, $_render_external = true)
+	{
+		if(!is_array($_links) || count($_links) == 0)
+		{
+return false; }
 
 		// provide defaults if given arguments are null
 		// php distinguishes between missing and present(null) arguments
-		if(is_null($_render_html)) { $_render_html = false; }
-		if(is_null($_render_external)) { $_render_external = true; }
+		if(is_null($_render_html))
+		{
+$_render_html = false; }
+		if(is_null($_render_external))
+		{
+$_render_external = true; }
 		$newline = $_render_html ? "<br />" : "\n";
 		$hruler = $_render_html ? Api\Html::hr() : '';
 
 		$rendered_links = array();
-		foreach($_links as $link) {
-			if($_render_external || ! $link->popup) { $link->view['no_popup'] = 1; }
+		foreach($_links as $link)
+		{
+			if($_render_external || ! $link->popup)
+			{
+$link->view['no_popup'] = 1; }
 			// do not expose sensitive data
 			$url = preg_replace('/(sessionid|kp3|domain)=[^&]+&?/','',Api\Html::link('/index.php', $link->view));
 			// complete missing protocol and domain part if needed
-			if ($url{0} == '/' && $_render_external) {
+			if ($url{0} == '/' && $_render_external)
+			{
 				$url = ($_SERVER['HTTPS'] || $GLOBALS['egw_info']['server']['enforce_ssl'] ? 'https://' : 'http://').
 					($GLOBALS['egw_info']['server']['hostname'] ? $GLOBALS['egw_info']['server']['hostname'] : $_SERVER['HTTP_HOST']).$url;
 			}

notifications/inc/class.notifications_jpopup.inc.php

Doc Comments -1 removed lines

@@ -152,7 +152,6 @@
 	* saves notification into database so that the client can fetch it from there
 	*
 	* @param string $_message
-	* @param array $_user_sessions
 	*/
 	private function save( $_message ) {
 		$result = $this->db->insert( self::_notification_table, array(

Indentation +50 added lines, -50 removed lines

@@ -15,63 +15,63 @@ 
 {
 
 	/**
-	* Appname
-	*/
+	 * Appname
+	 */
 	const _appname = 'notifications';
 
 	/**
-	* Notification table in SQL database
-	*/
+	 * Notification table in SQL database
+	 */
 	const _notification_table = 'egw_notificationpopup';
 
 	/**
-	* Notification type
-	*/
+	 * Notification type
+	 */
 	const _type = 'jpopup';
 
 	/**
-	* holds account object for user who sends the message
-	*
-	* @var object
-	*/
+	 * holds account object for user who sends the message
+	 *
+	 * @var object
+	 */
 	private $sender;
 
 	/**
-	* holds account object for user to notify
-	*
-	* @var object
-	*/
+	 * holds account object for user to notify
+	 *
+	 * @var object
+	 */
 	private $recipient;
 
 	/**
-	* holds config object (sitewide application config)
-	*
-	* @var object
-	*/
+	 * holds config object (sitewide application config)
+	 *
+	 * @var object
+	 */
 	private $config;
 
 	/**
-	* holds preferences object of user to notify
-	*
-	* @var object
-	*/
+	 * holds preferences object of user to notify
+	 *
+	 * @var object
+	 */
 	private $preferences;
 
 	/**
-	* holds db object of SQL database
-	*
-	* @var Api\Db
-	*/
+	 * holds db object of SQL database
+	 *
+	 * @var Api\Db
+	 */
 	private $db;
 
 	/**
-	* constructor of notifications_egwpopup
-	*
-	* @param object $_sender
-	* @param object $_recipient
-	* @param object $_config
-	* @param object $_preferences
-	*/
+	 * constructor of notifications_egwpopup
+	 *
+	 * @param object $_sender
+	 * @param object $_recipient
+	 * @param object $_config
+	 * @param object $_preferences
+	 */
 	public function __construct($_sender, $_recipient, $_config = null, $_preferences = null)
 	{
 		if( !is_object($_sender) ) { throw new Exception("no sender given."); }
@@ -85,13 +85,13 @@ 
 	}
 
 	/**
-	* sends notification if user is online
-	*
-	* @param array $_messages
-	* @param string $_subject
-	* @param array $_links
-	* @param array $_attachments
-	*/
+	 * sends notification if user is online
+	 *
+	 * @param array $_messages
+	 * @param string $_subject
+	 * @param array $_links
+	 * @param array $_attachments
+	 */
 	public function send(array $_messages, $_subject=false, $_links=false, $_attachments=false)
 	{
 		unset($_attachments);	// not used
@@ -133,11 +133,11 @@ 
 	}
 
 	/**
-	* renders additional infos from sender and subject
-	*
-	* @param string $_subject
-	* @return string html rendered info as complete string
-	*/
+	 * renders additional infos from sender and subject
+	 *
+	 * @param string $_subject
+	 * @return string html rendered info as complete string
+	 */
 	private function render_infos($_subject = false) {
 		$infos = array();
 		$newline = "<br />";
@@ -149,11 +149,11 @@ 
 	}
 
 	/**
-	* saves notification into database so that the client can fetch it from there
-	*
-	* @param string $_message
-	* @param array $_user_sessions
-	*/
+	 * saves notification into database so that the client can fetch it from there
+	 *
+	 * @param string $_message
+	 * @param array $_user_sessions
+	 */
 	private function save( $_message ) {
 		$result = $this->db->insert( self::_notification_table, array(
 			'account_id'     => $this->recipient->account_id,

Spacing +21 added lines, -21 removed lines

@@ -74,14 +74,14 @@ 
 	*/
 	public function __construct($_sender, $_recipient, $_config = null, $_preferences = null)
 	{
-		if( !is_object($_sender) ) { throw new Exception("no sender given."); }
-		if( !is_object($_recipient) ) { throw new Exception("no recipient given."); }
+		if (!is_object($_sender)) { throw new Exception("no sender given."); }
+		if (!is_object($_recipient)) { throw new Exception("no recipient given."); }
 
 		$this->sender		= $_sender;
-		$this->recipient	= $_recipient;
+		$this->recipient = $_recipient;
 		$this->config		= $_config;
-		$this->preferences	= $_preferences;
-		$this->db			= $GLOBALS['egw']->db;
+		$this->preferences = $_preferences;
+		$this->db = $GLOBALS['egw']->db;
 	}
 
 	/**
@@ -92,19 +92,19 @@ 
 	* @param array $_links
 	* @param array $_attachments
 	*/
-	public function send(array $_messages, $_subject=false, $_links=false, $_attachments=false)
+	public function send(array $_messages, $_subject = false, $_links = false, $_attachments = false)
 	{
-		unset($_attachments);	// not used
+		unset($_attachments); // not used
 
 		$jmessage = array();
 
 		// app-message
-		if( ($_links != null) && (count($_links) > 0) )
+		if (($_links != null) && (count($_links) > 0))
 		{
-			$tlink		= $_links[0];
-			$appname	= "";
+			$tlink = $_links[0];
+			$appname = "";
 
-			if( key_exists('menuaction', $tlink->view) )
+			if (key_exists('menuaction', $tlink->view))
 			{
 				$tmp = explode(".", $tlink->view['menuaction']);
 				$appname = $tmp[0];
@@ -112,9 +112,9 @@ 
 
 			$link = array();
 
-			foreach( $tlink->view as $pkey => $pvalue )
+			foreach ($tlink->view as $pkey => $pvalue)
 			{
-				$link[] = $pkey . '=' . $pvalue;
+				$link[] = $pkey.'='.$pvalue;
 			}
 
 			// TODO more links?
@@ -125,11 +125,11 @@ 
 			.Api\Html::hr()
 			.$_messages['html'];
 
-		$jmessage['msghtml']	= $message;
-		$jmessage['app']		= $appname;
+		$jmessage['msghtml'] = $message;
+		$jmessage['app'] = $appname;
 
 
-		$this->save( serialize($jmessage) );
+		$this->save(serialize($jmessage));
 	}
 
 	/**
@@ -144,8 +144,8 @@ 
 
 		$sender = $this->sender->account_fullname ? $this->sender->account_fullname : $this->sender_account_email;
 		$infos[] = lang('Message from').': '.$sender;
-		if(!empty($_subject)) { $infos[] = Api\Html::bold($_subject); }
-		return implode($newline,$infos);
+		if (!empty($_subject)) { $infos[] = Api\Html::bold($_subject); }
+		return implode($newline, $infos);
 	}
 
 	/**
@@ -154,12 +154,12 @@ 
 	* @param string $_message
 	* @param array $_user_sessions
 	*/
-	private function save( $_message ) {
-		$result = $this->db->insert( self::_notification_table, array(
+	private function save($_message) {
+		$result = $this->db->insert(self::_notification_table, array(
 			'account_id'     => $this->recipient->account_id,
 			'notify_message' => $_message,
 			'notify_type'	 => self::_type
-			), false,__LINE__,__FILE__,self::_appname);
+			), false, __LINE__, __FILE__, self::_appname);
 		if ($result === false) throw new Exception("Can't save notification into SQL table");
 	}
 }

Braces +17 added lines, -6 removed lines

@@ -74,8 +74,12 @@ 
 	*/
 	public function __construct($_sender, $_recipient, $_config = null, $_preferences = null)
 	{
-		if( !is_object($_sender) ) { throw new Exception("no sender given."); }
-		if( !is_object($_recipient) ) { throw new Exception("no recipient given."); }
+		if( !is_object($_sender) )
+		{
+throw new Exception("no sender given."); }
+		if( !is_object($_recipient) )
+		{
+throw new Exception("no recipient given."); }
 
 		$this->sender		= $_sender;
 		$this->recipient	= $_recipient;
@@ -138,13 +142,16 @@ 
 	* @param string $_subject
 	* @return string html rendered info as complete string
 	*/
-	private function render_infos($_subject = false) {
+	private function render_infos($_subject = false)
+	{
 		$infos = array();
 		$newline = "<br />";
 
 		$sender = $this->sender->account_fullname ? $this->sender->account_fullname : $this->sender_account_email;
 		$infos[] = lang('Message from').': '.$sender;
-		if(!empty($_subject)) { $infos[] = Api\Html::bold($_subject); }
+		if(!empty($_subject))
+		{
+$infos[] = Api\Html::bold($_subject); }
 		return implode($newline,$infos);
 	}
 
@@ -154,12 +161,16 @@ 
 	* @param string $_message
 	* @param array $_user_sessions
 	*/
-	private function save( $_message ) {
+	private function save( $_message )
+	{
 		$result = $this->db->insert( self::_notification_table, array(
 			'account_id'     => $this->recipient->account_id,
 			'notify_message' => $_message,
 			'notify_type'	 => self::_type
 			), false,__LINE__,__FILE__,self::_appname);
-		if ($result === false) throw new Exception("Can't save notification into SQL table");
+		if ($result === false)
+		{
+			throw new Exception("Can't save notification into SQL table");
+		}
 	}
 }

notifications/inc/class.notifications_popup.inc.php

Doc Comments -1 removed lines

@@ -121,7 +121,6 @@
 	 * saves notification into database so that the client can fetch it from there
 	 *
 	 * @param string $_message
-	 * @param array $_user_sessions
 	 */
 	private function save( $_message ) {
 		$result = $this->db->insert( self::_notification_table, array(

Spacing +28 added lines, -28 removed lines

@@ -83,8 +83,8 @@ 
 	 */
 	public function __construct($_sender, $_recipient, $_config = null, $_preferences = null) {
 		//error_log(__METHOD__."(".array2string($_sender).', '.array2string($_recipient).', '.array2string($config).',...)');
-		if(!is_object($_sender)) { throw new Exception("no sender given."); }
-		if(!is_object($_recipient)) { throw new Exception("no recipient given."); }
+		if (!is_object($_sender)) { throw new Exception("no sender given."); }
+		if (!is_object($_recipient)) { throw new Exception("no recipient given."); }
 		$this->sender = $_sender;
 		$this->recipient = $_recipient;
 		$this->config = $_config;
@@ -102,19 +102,19 @@ 
 	 */
 	public function send(array $_messages, $_subject = false, $_links = false, $_attachments = false)
 	{
-		unset($_attachments);	// not used
+		unset($_attachments); // not used
 		// Check access log to see if user is still logged in
-		if ( !Api\Session::notifications_active($this->recipient->account_id) )
+		if (!Api\Session::notifications_active($this->recipient->account_id))
 		{
 			throw new Exception("User {$this->recipient->account_lid} isn't online. Can't send notification via popup");
 		}
 
-		$message = 	$this->render_infos($_subject)
+		$message = $this->render_infos($_subject)
 					.Api\Html::hr()
-					.(isset($_messages['popup'])&&!empty($_messages['popup'])?$_messages['popup']:$_messages['html'])
+					.(isset($_messages['popup']) && !empty($_messages['popup']) ? $_messages['popup'] : $_messages['html'])
 					.$this->render_links($_links);
 
-		$this->save( $message );
+		$this->save($message);
 	}
 
 	/**
@@ -123,12 +123,12 @@ 
 	 * @param string $_message
 	 * @param array $_user_sessions
 	 */
-	private function save( $_message ) {
-		$result = $this->db->insert( self::_notification_table, array(
+	private function save($_message) {
+		$result = $this->db->insert(self::_notification_table, array(
 			'account_id'     => $this->recipient->account_id,
 			'notify_message' => $_message,
 			'notify_type'	 => self::_type
-			), false,__LINE__,__FILE__,self::_appname);
+			), false, __LINE__, __FILE__, self::_appname);
 		if ($result === false) throw new Exception("Can't save notification into SQL table");
 	}
 
@@ -140,25 +140,25 @@ 
 	 * @return string html rendered link(s) as complete string with jspopup or a new window
 	 */
 	private function render_links($_links = false) {
-		if(!is_array($_links) || count($_links) == 0) { return false; }
+		if (!is_array($_links) || count($_links) == 0) { return false; }
 		$newline = "<br />";
 
 		$rendered_links = array();
-		foreach($_links as $link) {
-			if(!$link->popup) { $link->view['no_popup'] = 1; }
+		foreach ($_links as $link) {
+			if (!$link->popup) { $link->view['no_popup'] = 1; }
 
 			// do not expose sensitive data
-			$url = preg_replace('/(sessionid|kp3|domain)=[^&]+&?/','',
+			$url = preg_replace('/(sessionid|kp3|domain)=[^&]+&?/', '',
 				Api\Html::link('/index.php', $link->view));
 			// extract application-icon from menuaction
-			if($link->view['menuaction']) {
-				$menuaction_arr = explode('.',$link->view['menuaction']);
+			if ($link->view['menuaction']) {
+				$menuaction_arr = explode('.', $link->view['menuaction']);
 				$application = $menuaction_arr[0];
-				$image = $application ? Api\Html::image($application,'navbar',$link->text,'align="middle" style="width: 24px; margin-right: 0.5em;"') : '';
+				$image = $application ? Api\Html::image($application, 'navbar', $link->text, 'align="middle" style="width: 24px; margin-right: 0.5em;"') : '';
 			} else {
 				$image = '';
 			}
-			if($link->popup && !$GLOBALS['egw_info']['user']['preferences']['notifications']['external_mailclient'])
+			if ($link->popup && !$GLOBALS['egw_info']['user']['preferences']['notifications']['external_mailclient'])
 			{
 				$data = array(
 					"data-app = '{$link->app}'",
@@ -167,14 +167,14 @@ 
 					"data-popup = '{$link->popup}'"
 				);
 
-				$rendered_links[] = Api\Html::div($image.$link->text,implode(' ',$data),'link');
+				$rendered_links[] = Api\Html::div($image.$link->text, implode(' ', $data), 'link');
 			} else {
-				$rendered_links[] = Api\Html::div('<a href="'.$url.'" target="_blank">'.$image.$link->text.'</a>','','link');
+				$rendered_links[] = Api\Html::div('<a href="'.$url.'" target="_blank">'.$image.$link->text.'</a>', '', 'link');
 			}
 
 		}
-		if(count($rendered_links) > 0) {
-			return Api\Html::hr().Api\Html::bold(lang('Linked entries:')).$newline.implode($newline,$rendered_links);
+		if (count($rendered_links) > 0) {
+			return Api\Html::hr().Api\Html::bold(lang('Linked entries:')).$newline.implode($newline, $rendered_links);
 		}
 	}
 
@@ -187,9 +187,9 @@ 
 	 * @param int $height =400 height of the window
 	 * @return string javascript (using single quotes)
 	 */
-	private function jspopup($link,$target='_blank',$width=750,$height=410)
+	private function jspopup($link, $target = '_blank', $width = 750, $height = 410)
 	{
-		if($GLOBALS['egw_info']['user']['preferences']['notifications']['external_mailclient'])
+		if ($GLOBALS['egw_info']['user']['preferences']['notifications']['external_mailclient'])
 		{
 			return 'window.open('.($link == 'this.href' ? $link : "'".$link."'").','.
 				($target == 'this.target' ? $target : "'".$target."'").",$width,$height,'yes')";
@@ -213,8 +213,8 @@ 
 
 		$sender = $this->sender->account_fullname ? $this->sender->account_fullname : $this->sender_account_email;
 		$infos[] = lang('Message from').': '.$sender;
-		if(!empty($_subject)) { $infos[] = Api\Html::bold($_subject); }
-		return implode($newline,$infos);
+		if (!empty($_subject)) { $infos[] = Api\Html::bold($_subject); }
+		return implode($newline, $infos);
 	}
 
 	/**
@@ -223,8 +223,8 @@ 
 	 * @param settings array with keys account_id and new_owner (new_owner is optional)
 	 */
 	public static function deleteaccount($settings) {
-		$GLOBALS['egw']->db->delete( self::_notification_table, array(
+		$GLOBALS['egw']->db->delete(self::_notification_table, array(
 			'account_id'	=> $settings['account_id']
-		),__LINE__,__FILE__,self::_appname);
+		), __LINE__, __FILE__, self::_appname);
 	}
 }

Braces +43 added lines, -17 removed lines

@@ -21,7 +21,8 @@ 
  * out the table to look if there is a notificaton for this
  * client. The second stage is done in class.notifications_ajax.inc.php
  */
-class notifications_popup implements notifications_iface {
+class notifications_popup implements notifications_iface
+{
 
 	/**
 	 * Appname
@@ -81,10 +82,15 @@ 
 	 * @param object $_config
 	 * @param object $_preferences
 	 */
-	public function __construct($_sender, $_recipient, $_config = null, $_preferences = null) {
+	public function __construct($_sender, $_recipient, $_config = null, $_preferences = null)
+	{
 		//error_log(__METHOD__."(".array2string($_sender).', '.array2string($_recipient).', '.array2string($config).',...)');
-		if(!is_object($_sender)) { throw new Exception("no sender given."); }
-		if(!is_object($_recipient)) { throw new Exception("no recipient given."); }
+		if(!is_object($_sender))
+		{
+throw new Exception("no sender given."); }
+		if(!is_object($_recipient))
+		{
+throw new Exception("no recipient given."); }
 		$this->sender = $_sender;
 		$this->recipient = $_recipient;
 		$this->config = $_config;
@@ -123,13 +129,17 @@ 
 	 * @param string $_message
 	 * @param array $_user_sessions
 	 */
-	private function save( $_message ) {
+	private function save( $_message )
+	{
 		$result = $this->db->insert( self::_notification_table, array(
 			'account_id'     => $this->recipient->account_id,
 			'notify_message' => $_message,
 			'notify_type'	 => self::_type
 			), false,__LINE__,__FILE__,self::_appname);
-		if ($result === false) throw new Exception("Can't save notification into SQL table");
+		if ($result === false)
+		{
+			throw new Exception("Can't save notification into SQL table");
+		}
 	}
 
 	/**
@@ -139,23 +149,32 @@ 
 	 * @param array $_links
 	 * @return string html rendered link(s) as complete string with jspopup or a new window
 	 */
-	private function render_links($_links = false) {
-		if(!is_array($_links) || count($_links) == 0) { return false; }
+	private function render_links($_links = false)
+	{
+		if(!is_array($_links) || count($_links) == 0)
+		{
+return false; }
 		$newline = "<br />";
 
 		$rendered_links = array();
-		foreach($_links as $link) {
-			if(!$link->popup) { $link->view['no_popup'] = 1; }
+		foreach($_links as $link)
+		{
+			if(!$link->popup)
+			{
+$link->view['no_popup'] = 1; }
 
 			// do not expose sensitive data
 			$url = preg_replace('/(sessionid|kp3|domain)=[^&]+&?/','',
 				Api\Html::link('/index.php', $link->view));
 			// extract application-icon from menuaction
-			if($link->view['menuaction']) {
+			if($link->view['menuaction'])
+			{
 				$menuaction_arr = explode('.',$link->view['menuaction']);
 				$application = $menuaction_arr[0];
 				$image = $application ? Api\Html::image($application,'navbar',$link->text,'align="middle" style="width: 24px; margin-right: 0.5em;"') : '';
-			} else {
+			}
+			else
+			{
 				$image = '';
 			}
 			if($link->popup && !$GLOBALS['egw_info']['user']['preferences']['notifications']['external_mailclient'])
@@ -168,12 +187,15 @@ 
 				);
 
 				$rendered_links[] = Api\Html::div($image.$link->text,implode(' ',$data),'link');
-			} else {
+			}
+			else
+			{
 				$rendered_links[] = Api\Html::div('<a href="'.$url.'" target="_blank">'.$image.$link->text.'</a>','','link');
 			}
 
 		}
-		if(count($rendered_links) > 0) {
+		if(count($rendered_links) > 0)
+		{
 			return Api\Html::hr().Api\Html::bold(lang('Linked entries:')).$newline.implode($newline,$rendered_links);
 		}
 	}
@@ -207,13 +229,16 @@ 
 	 * @param string $_subject
 	 * @return string html rendered info as complete string
 	 */
-	private function render_infos($_subject = false) {
+	private function render_infos($_subject = false)
+	{
 		$infos = array();
 		$newline = "<br />";
 
 		$sender = $this->sender->account_fullname ? $this->sender->account_fullname : $this->sender_account_email;
 		$infos[] = lang('Message from').': '.$sender;
-		if(!empty($_subject)) { $infos[] = Api\Html::bold($_subject); }
+		if(!empty($_subject))
+		{
+$infos[] = Api\Html::bold($_subject); }
 		return implode($newline,$infos);
 	}
 
@@ -222,7 +247,8 @@ 
 	 *
 	 * @param settings array with keys account_id and new_owner (new_owner is optional)
 	 */
-	public static function deleteaccount($settings) {
+	public static function deleteaccount($settings)
+	{
 		$GLOBALS['egw']->db->delete( self::_notification_table, array(
 			'account_id'	=> $settings['account_id']
 		),__LINE__,__FILE__,self::_appname);

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -106,7 +106,7 @@
 		// Check access log to see if user is still logged in
 		if ( !Api\Session::notifications_active($this->recipient->account_id) )
 		{
-			throw new Exception("User {$this->recipient->account_lid} isn't online. Can't send notification via popup");
+			throw new Exception("user {$this->recipient->account_lid} isn't online. Can't send notification via popup");
 		}
 
 		$message = 	$this->render_infos($_subject)

notifications/inc/class.notifications_winpopup.inc.php

Doc Comments +2 added lines, -2 removed lines

@@ -155,7 +155,7 @@ 
 	 * checks for a valid IPv4-address without CIDR notation
 	 *
 	 * @param string $_ip
-	 * @return true or false
+	 * @return integer or false
 	 */
 	private function valid_ip($_ip) {
 		return eregi('^[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}$',$_ip);
@@ -165,7 +165,7 @@ 
 	 * renders additional info from subject
 	 *
 	 * @param string $_subject
-	 * @return plain rendered info as complete string
+	 * @return string|false rendered info as complete string
 	 */
 	private function render_infos($_subject = false) {
 		$newline = "\n";

Spacing +21 added lines, -21 removed lines

@@ -81,12 +81,12 @@ 
 	 * @param object $_preferences
 	 */
 	public function __construct($_sender, $_recipient, $_config = null, $_preferences = null) {
-		if(!is_object($_sender)) { throw new Exception("no sender given."); }
-		if(!is_object($_recipient)) { throw new Exception("no recipient given."); }
-		if(!$this->netbios_command) {
-			throw new Exception(	'Winpopup plugin not configured yet. Skipped sending notification message. '.
+		if (!is_object($_sender)) { throw new Exception("no sender given."); }
+		if (!is_object($_recipient)) { throw new Exception("no recipient given."); }
+		if (!$this->netbios_command) {
+			throw new Exception('Winpopup plugin not configured yet. Skipped sending notification message. '.
 									'Please check var "netbios_command" in winpopup backend '.
-									'('.EGW_INCLUDE_ROOT. SEP. self::_appname. SEP. 'inc'. SEP. 'class.notifications_winpopup.inc.php).');
+									'('.EGW_INCLUDE_ROOT.SEP.self::_appname.SEP.'inc'.SEP.'class.notifications_winpopup.inc.php).');
 		}
 		$this->sender = $_sender;
 		$this->recipient = $_recipient;
@@ -104,19 +104,19 @@ 
 	 */
 	public function send(array $_messages, $_subject = false, $_links = false, $_attachments = false)
 	{
-		unset($_links, $_attachments);	// not used
+		unset($_links, $_attachments); // not used
 
 		$user_sessions = array();
 		foreach (Api\Session::session_list(0, 'asc', 'session_dla', true) as $session) {
-			if ($session['session_lid'] == $this->recipient->account_lid. '@'. $GLOBALS['egw_info']['user']['domain']) {
-				if($this->valid_ip($session['session_ip'])) {
+			if ($session['session_lid'] == $this->recipient->account_lid.'@'.$GLOBALS['egw_info']['user']['domain']) {
+				if ($this->valid_ip($session['session_ip'])) {
 					$user_sessions[] = $session['session_ip'];
 				}
 			}
 		}
-		if ( empty($user_sessions) ) throw new Exception("User #{$this->recipient->account_id} isn't online. Can't send notification via winpopup");
+		if (empty($user_sessions)) throw new Exception("User #{$this->recipient->account_id} isn't online. Can't send notification via winpopup");
 
-		$this->send_winpopup( $this->render_infos($_subject).$_messages['plain'], $user_sessions );
+		$this->send_winpopup($this->render_infos($_subject).$_messages['plain'], $user_sessions);
 		return true;
 	}
 
@@ -126,15 +126,15 @@ 
 	 * @param string $_message
 	 * @param array $_user_sessions
 	 */
-	private function send_winpopup( $_message, array $_user_sessions ) {
-		foreach($_user_sessions as $user_session) {
-			$ip_octets=explode(".",$user_session);
+	private function send_winpopup($_message, array $_user_sessions) {
+		foreach ($_user_sessions as $user_session) {
+			$ip_octets = explode(".", $user_session);
 			// format the ip_octets to 3 digits each
-			foreach($ip_octets as $id=>$ip_octet) {
-				if(strlen($ip_octet)==1) { $ip_octets[$id] = '00'.$ip_octet; }
-				if(strlen($ip_octet)==2) { $ip_octets[$id] = '0'.$ip_octet; }
+			foreach ($ip_octets as $id=>$ip_octet) {
+				if (strlen($ip_octet) == 1) { $ip_octets[$id] = '00'.$ip_octet; }
+				if (strlen($ip_octet) == 2) { $ip_octets[$id] = '0'.$ip_octet; }
 			}
-			$placeholders = array(	'/\[MESSAGE\]/' => escapeshellarg($_message), // prevent code injection
+			$placeholders = array('/\[MESSAGE\]/' => escapeshellarg($_message), // prevent code injection
 									'/\[1\]/' => $ip_octets[0],
 									'/\[2\]/' => $ip_octets[1],
 									'/\[3\]/' => $ip_octets[2],
@@ -144,8 +144,8 @@ 
 									);
 			$command = preg_replace(array_keys($placeholders), $placeholders, $this->netbios_command);
 			$output = $returncode = null;
-			exec($command,$output,$returncode);
-			if($returncode != 0) {
+			exec($command, $output, $returncode);
+			if ($returncode != 0) {
 				throw new Exception("Failed sending notification message via winpopup. Error while executing the specified command.");
 			}
 		}
@@ -158,7 +158,7 @@ 
 	 * @return true or false
 	 */
 	private function valid_ip($_ip) {
-		return eregi('^[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}$',$_ip);
+		return eregi('^[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}$', $_ip);
 	}
 
 	/**
@@ -169,7 +169,7 @@ 
 	 */
 	private function render_infos($_subject = false) {
 		$newline = "\n";
-		if(!empty($_subject)) { return $_subject.$newline; }
+		if (!empty($_subject)) { return $_subject.$newline; }
 		return false;
 	}
 }
\ No newline at end of file

Braces +43 added lines, -18 removed lines

@@ -15,7 +15,8 @@ 
 /**
  * User notification via winpopup.
  */
-class notifications_winpopup implements notifications_iface {
+class notifications_winpopup implements notifications_iface
+{
 
 	/**
 	 * Appname
@@ -80,10 +81,16 @@ 
 	 * @param object $_config
 	 * @param object $_preferences
 	 */
-	public function __construct($_sender, $_recipient, $_config = null, $_preferences = null) {
-		if(!is_object($_sender)) { throw new Exception("no sender given."); }
-		if(!is_object($_recipient)) { throw new Exception("no recipient given."); }
-		if(!$this->netbios_command) {
+	public function __construct($_sender, $_recipient, $_config = null, $_preferences = null)
+	{
+		if(!is_object($_sender))
+		{
+throw new Exception("no sender given."); }
+		if(!is_object($_recipient))
+		{
+throw new Exception("no recipient given."); }
+		if(!$this->netbios_command)
+		{
 			throw new Exception(	'Winpopup plugin not configured yet. Skipped sending notification message. '.
 									'Please check var "netbios_command" in winpopup backend '.
 									'('.EGW_INCLUDE_ROOT. SEP. self::_appname. SEP. 'inc'. SEP. 'class.notifications_winpopup.inc.php).');
@@ -107,14 +114,20 @@ 
 		unset($_links, $_attachments);	// not used
 
 		$user_sessions = array();
-		foreach (Api\Session::session_list(0, 'asc', 'session_dla', true) as $session) {
-			if ($session['session_lid'] == $this->recipient->account_lid. '@'. $GLOBALS['egw_info']['user']['domain']) {
-				if($this->valid_ip($session['session_ip'])) {
+		foreach (Api\Session::session_list(0, 'asc', 'session_dla', true) as $session)
+		{
+			if ($session['session_lid'] == $this->recipient->account_lid. '@'. $GLOBALS['egw_info']['user']['domain'])
+			{
+				if($this->valid_ip($session['session_ip']))
+				{
 					$user_sessions[] = $session['session_ip'];
 				}
 			}
 		}
-		if ( empty($user_sessions) ) throw new Exception("User #{$this->recipient->account_id} isn't online. Can't send notification via winpopup");
+		if ( empty($user_sessions) )
+		{
+			throw new Exception("User #{$this->recipient->account_id} isn't online. Can't send notification via winpopup");
+		}
 
 		$this->send_winpopup( $this->render_infos($_subject).$_messages['plain'], $user_sessions );
 		return true;
@@ -126,13 +139,20 @@ 
 	 * @param string $_message
 	 * @param array $_user_sessions
 	 */
-	private function send_winpopup( $_message, array $_user_sessions ) {
-		foreach($_user_sessions as $user_session) {
+	private function send_winpopup( $_message, array $_user_sessions )
+	{
+		foreach($_user_sessions as $user_session)
+		{
 			$ip_octets=explode(".",$user_session);
 			// format the ip_octets to 3 digits each
-			foreach($ip_octets as $id=>$ip_octet) {
-				if(strlen($ip_octet)==1) { $ip_octets[$id] = '00'.$ip_octet; }
-				if(strlen($ip_octet)==2) { $ip_octets[$id] = '0'.$ip_octet; }
+			foreach($ip_octets as $id=>$ip_octet)
+			{
+				if(strlen($ip_octet)==1)
+				{
+$ip_octets[$id] = '00'.$ip_octet; }
+				if(strlen($ip_octet)==2)
+				{
+$ip_octets[$id] = '0'.$ip_octet; }
 			}
 			$placeholders = array(	'/\[MESSAGE\]/' => escapeshellarg($_message), // prevent code injection
 									'/\[1\]/' => $ip_octets[0],
@@ -145,7 +165,8 @@ 
 			$command = preg_replace(array_keys($placeholders), $placeholders, $this->netbios_command);
 			$output = $returncode = null;
 			exec($command,$output,$returncode);
-			if($returncode != 0) {
+			if($returncode != 0)
+			{
 				throw new Exception("Failed sending notification message via winpopup. Error while executing the specified command.");
 			}
 		}
@@ -157,7 +178,8 @@ 
 	 * @param string $_ip
 	 * @return true or false
 	 */
-	private function valid_ip($_ip) {
+	private function valid_ip($_ip)
+	{
 		return eregi('^[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}$',$_ip);
 	}
 
@@ -167,9 +189,12 @@ 
 	 * @param string $_subject
 	 * @return plain rendered info as complete string
 	 */
-	private function render_infos($_subject = false) {
+	private function render_infos($_subject = false)
+	{
 		$newline = "\n";
-		if(!empty($_subject)) { return $_subject.$newline; }
+		if(!empty($_subject))
+		{
+return $_subject.$newline; }
 		return false;
 	}
 }
\ No newline at end of file

pixelegg/inc/class.pixelegg_framework.inc.php

Doc Comments +1 added lines, -1 removed lines

@@ -55,7 +55,7 @@
 	 * Overwritten to load our slider.js
 	 *
 	 * @param array $extra
-	 * @return type
+	 * @return string|null
 	 */
 	function header(array $extra=array())
 	{

Spacing +10 added lines, -10 removed lines

@@ -41,12 +41,12 @@ 
 	 *
 	 * @param string $template ='pixelegg' name of the template
 	 */
-	function __construct($template=self::APP)
+	function __construct($template = self::APP)
 	{
-		parent::__construct($template);		// call the constructor of the extended class
+		parent::__construct($template); // call the constructor of the extended class
 
 		// search 'mobile' dirs first
-		if (Api\Header\UserAgent::mobile()) array_unshift ($this->template_dirs, 'mobile');
+		if (Api\Header\UserAgent::mobile()) array_unshift($this->template_dirs, 'mobile');
 	}
 
 	/**
@@ -57,7 +57,7 @@ 
 	 * @param array $extra
 	 * @return type
 	 */
-	function header(array $extra=array())
+	function header(array $extra = array())
 	{
 		// load our slider.js, but only if framework requested
 		if (!self::$header_done && $_GET['cd'] === 'yes' &&
@@ -79,9 +79,9 @@ 
 	{
 		if ($color[0] == '#') $color = ltrim($color, '#');
 
-		$R = hexdec(substr($color,0,2));
-		$G = hexdec(substr($color,2,2));
-		$B = hexdec(substr($color,4,2));
+		$R = hexdec(substr($color, 0, 2));
+		$G = hexdec(substr($color, 2, 2));
+		$B = hexdec(substr($color, 4, 2));
 
 		$Rs = round($R * (100 + $percent) / 100);
 		$Gs = round($G * (100 + $percent) / 100);
@@ -104,7 +104,7 @@ 
 	{
 		$ret = parent::_get_css();
 		// color to use
-		$color = str_replace('custom',$GLOBALS['egw_info']['user']['preferences']['common']['template_custom_color'],
+		$color = str_replace('custom', $GLOBALS['egw_info']['user']['preferences']['common']['template_custom_color'],
 			$GLOBALS['egw_info']['user']['preferences']['common']['template_color']);
 
 		// Create a dark variant of the color
@@ -129,7 +129,7 @@ 
 			$loginbox_color = $color_darker;
 		}
 
-		if (preg_match('/^(#[0-9A-F]+|[A-Z]+)$/i',$color))	// a little xss check
+		if (preg_match('/^(#[0-9A-F]+|[A-Z]+)$/i', $color))	// a little xss check
 		{
 			if (!Api\Header\UserAgent::mobile())
 			{
@@ -206,7 +206,7 @@ 
 	 * @param string $extra_vars for login url
 	 * @param string $change_passwd =null string with message to render input fields for password change
 	 */
-	function login_screen($extra_vars, $change_passwd=null)
+	function login_screen($extra_vars, $change_passwd = null)
 	{
 		if (empty($GLOBALS['loginscreenmessage']))
 		{

Braces +24 added lines, -6 removed lines

@@ -46,7 +46,10 @@ 
 		parent::__construct($template);		// call the constructor of the extended class
 
 		// search 'mobile' dirs first
-		if (Api\Header\UserAgent::mobile()) array_unshift ($this->template_dirs, 'mobile');
+		if (Api\Header\UserAgent::mobile())
+		{
+			array_unshift ($this->template_dirs, 'mobile');
+		}
 	}
 
 	/**
@@ -77,7 +80,10 @@ 
 	 */
 	function _color_shader($color, $percent)
 	{
-		if ($color[0] == '#') $color = ltrim($color, '#');
+		if ($color[0] == '#')
+		{
+			$color = ltrim($color, '#');
+		}
 
 		$R = hexdec(substr($color,0,2));
 		$G = hexdec(substr($color,2,2));
@@ -87,9 +93,18 @@ 
 		$Gs = round($G * (100 + $percent) / 100);
 		$Bs = round($B * (100 + $percent) / 100);
 
-		if ($Rs > 255) $Rs = 255;
-		if ($Gs > 255) $Gs = 255;
-		if ($Bs > 255) $Bs = 255;
+		if ($Rs > 255)
+		{
+			$Rs = 255;
+		}
+		if ($Gs > 255)
+		{
+			$Gs = 255;
+		}
+		if ($Bs > 255)
+		{
+			$Bs = 255;
+		}
 
 		return '#'.sprintf('%02X%02X%02X', $Rs, $Gs, $Bs);
 	}
@@ -129,7 +144,9 @@ 
 			$loginbox_color = $color_darker;
 		}
 
-		if (preg_match('/^(#[0-9A-F]+|[A-Z]+)$/i',$color))	// a little xss check
+		if (preg_match('/^(#[0-9A-F]+|[A-Z]+)$/i',$color))
+		{
+			// a little xss check
 		{
 			if (!Api\Header\UserAgent::mobile())
 			{
@@ -168,6 +185,7 @@ 
 
 
 ";
+		}
 				if ($GLOBALS['egw_info']['user']['preferences']['common']['theme'] == 'traditional')
 				{
 					$ret['app_css'] .= ".dialogFooterToolbar {background-color: $color !important;}";

preferences/inc/class.preferences_settings.inc.php

Doc Comments +1 added lines, -1 removed lines

@@ -292,7 +292,7 @@
 	 * @param array &$sel_options
 	 * @param array &$readonlys
 	 * @param array &$types on return setting-name => setting-type
-	 * @param etemplate $tpl
+	 * @param Etemplate $tpl
 	 * @throws Api\Exception\WrongParameter
 	 * @return array content
 	 */

Spacing +55 added lines, -56 removed lines

@@ -45,7 +45,7 @@ 
 	 * @param array $content =null
 	 * @param string $msg =''
 	 */
-	function index(array $content=null, $msg='')
+	function index(array $content = null, $msg = '')
 	{
 		$tpl = new Etemplate('preferences.settings');
 		if (!is_array($content))
@@ -70,7 +70,7 @@ 
 			{
 				list($button) = each($content['button']);
 				$appname = $content['old_appname'] ? $content['old_appname'] : 'common';
-				switch($button)
+				switch ($button)
 				{
 					case 'save':
 					case 'apply':
@@ -79,10 +79,10 @@ 
 						{
 							throw new Api\Exception\NoPermission\Admin;
 						}
-						list($type,$account_id) = explode(':', $content['old_type']);
+						list($type, $account_id) = explode(':', $content['old_type']);
 						// merge prefs of all tabs together again
 						$prefs = array();
-						foreach($content as $name => $val)
+						foreach ($content as $name => $val)
 						{
 							if (is_array($val) && strpos($name, 'tab') === 0)
 							{
@@ -100,7 +100,7 @@ 
 						$old_values = array_intersect_key($GLOBALS['egw_info']['user']['preferences']['common'], array_flip($require_reload));
 
 						$attribute = $type == 'group' ? 'user' : $type;
-						if (!($msg=$this->process_array($GLOBALS['egw']->preferences->$attribute, $prefs, $content['types'], $appname, $attribute)))
+						if (!($msg = $this->process_array($GLOBALS['egw']->preferences->$attribute, $prefs, $content['types'], $appname, $attribute)))
 						{
 							$msg_type = 'success';
 							$msg = lang('Preferences saved.');
@@ -124,14 +124,14 @@ 
 						// update client-side Api\Preferences in response
 						Framework::ajax_get_preference($appname);
 				}
-				if (in_array($button, array('save','cancel')))
+				if (in_array($button, array('save', 'cancel')))
 				{
 					Api\Json\Response::get()->call('egw.message', $msg, $msg_type);
 					Framework::window_close();
 				}
 			}
 			$appname = $content['appname'] ? $content['appname'] : 'common';
-			list($type,$account_id) = explode(':', $content['type']);
+			list($type, $account_id) = explode(':', $content['type']);
 			//_debug_array($prefs);
 		}
 		if ($account_id && $account_id != $GLOBALS['egw']->preferences->get_account_id())
@@ -150,7 +150,7 @@ 
 		$preserve['current_app'] = $content['current_app'];
 		$GLOBALS['egw_info']['flags']['currentapp'] = $content['current_app'] == 'common' ?
 			'preferences' : $content['current_app'];
-		Framework::includeCSS('preferences','app');
+		Framework::includeCSS('preferences', 'app');
 
 		// if not just saved, call validation before, to be able to show failed validation of current prefs
 		if (!isset($button))
@@ -182,17 +182,17 @@ 
 	 * @param boolean $only_verify =false
 	 * @return string with verification error or null on success
 	 */
-	function process_array(array &$repository, array $values, array $types, $appname, $type, $only_verify=false)
+	function process_array(array &$repository, array $values, array $types, $appname, $type, $only_verify = false)
 	{
 		//_debug_array($repository);
 		$prefs = &$repository[$appname];
 
 		unset($prefs['']);
 		//_debug_array($values);exit;
-		foreach($values as $var => $value)
+		foreach ($values as $var => $value)
 		{
 			// type specific validation
-			switch((string)$types[$var])
+			switch ((string)$types[$var])
 			{
 				case 'password':	// dont write empty password-fields
 					if (empty($value)) continue 2;
@@ -205,7 +205,7 @@ 
 						// empty is always allowed
 
 						// If forced, empty == not set
-						if($type == 'forced')
+						if ($type == 'forced')
 						{
 							unset($prefs[$var]);
 							// need to call preferences::delete, to also set affective prefs!
@@ -217,19 +217,19 @@ 
 					{
 						if ($value[0] != '/' || !Vfs::stat($value) || Vfs::is_dir($value))
 						{
-							$error = lang('%1 is no existing vfs file!',htmlspecialchars($value));
+							$error = lang('%1 is no existing vfs file!', htmlspecialchars($value));
 						}
 					}
 					else
 					{
 						// split multiple comma or whitespace separated directories
 						// to still allow space or comma in dirnames, we also use the trailing slash of all pathes to split
-						foreach($types[$var] == 'vfs_dir' ? array($value) : preg_split('/[,\s]+\//', $value) as $n => $dir)
+						foreach ($types[$var] == 'vfs_dir' ? array($value) : preg_split('/[,\s]+\//', $value) as $n => $dir)
 						{
-							if ($n) $dir = '/'.$dir;	// re-adding trailing slash removed by split
+							if ($n) $dir = '/'.$dir; // re-adding trailing slash removed by split
 							if ($dir[0] != '/' || !Vfs::stat($dir) || !Vfs::is_dir($dir))
 							{
-								$error .= ($error ? ' ' : '').lang('%1 is no existing vfs directory!',$dir);
+								$error .= ($error ? ' ' : '').lang('%1 is no existing vfs directory!', $dir);
 							}
 						}
 					}
@@ -241,7 +241,7 @@ 
 
 			if (isset($value) && $value !== '' && $value !== '**NULL**' && $value !== array())
 			{
-				if (is_array($value)) $value = implode(',',$value);	// multiselect
+				if (is_array($value)) $value = implode(',', $value); // multiselect
 
 				$prefs[$var] = $value;
 
@@ -261,7 +261,7 @@ 
 		// if you return something else than False, it is treated as an error-msg and
 		// displayed to the user (the prefs are not saved)
 		//
-		if(($error .= Api\Hooks::single(array(
+		if (($error .= Api\Hooks::single(array(
 				'location' => 'verify_settings',
 				'prefs'    => &$repository[$appname],
 				'type'     => $type,
@@ -273,7 +273,7 @@ 
 			return $error;
 		}
 
-		if (!$only_verify) $GLOBALS['egw']->preferences->save_repository(True,$type);
+		if (!$only_verify) $GLOBALS['egw']->preferences->save_repository(True, $type);
 
 		// certain common prefs (language, template, ...) require the session to be re-created
 		if ($appname == 'common' && !$only_verify)
@@ -309,19 +309,19 @@ 
 		$sel_options = $readonlys = $content = $tabs = array();
 		// disable all but first tab and name current tab "tab1", for apps not using sections
 		$tab = 'tab1';
-		foreach($this->settings as $setting)
+		foreach ($this->settings as $setting)
 		{
 			if (!is_array($setting)) continue;
 			if ($type != 'forced' && (string)$GLOBALS['egw']->preferences->forced[$appname][$setting['name']] !== '')
 			{
-				continue;	// forced preferences are not displayed, unless we edit them
+				continue; // forced preferences are not displayed, unless we edit them
 			}
 			$types[$setting['name']] = $old_type = $setting['type'];
 
-			switch($old_type)
+			switch ($old_type)
 			{
 				case 'section':
-					$tab = 'tab'.(1+count($tabs));
+					$tab = 'tab'.(1 + count($tabs));
 					$tabs[] = array(
 						'id' => $tab,
 						'template' => 'preferences.settings.tab1',
@@ -336,24 +336,24 @@ 
 					if (is_array($setting['values'])) $vars += $setting['values'];
 					$GLOBALS['egw']->preferences->{$attribute}[$appname][$setting['name']] =
 						$GLOBALS['egw']->preferences->lang_notify($GLOBALS['egw']->preferences->{$attribute}[$appname][$setting['name']], $vars);
-					$types[$setting['name']] = $vars;	// store vars for re-translation, instead type "notify"
+					$types[$setting['name']] = $vars; // store vars for re-translation, instead type "notify"
 					if ($setting['help'] && ($setting['run_lang'] || !isset($setting['run_lang'])))
 					{
 						$setting['help'] = lang($setting['help']);
 					}
 					$setting['help'] .= '<p><b>'.lang('Substitutions and their meanings:').'</b>';
-					foreach($vars as $var => $var_help)
+					foreach ($vars as $var => $var_help)
 					{
 						$lname = ($lname = lang($var)) == $var.'*' ? $var : $lname;
 						$setting['help'] .= "<br>\n".'<b>$$'.$lname.'$$</b>: '.$var_help;
 					}
 					$setting['help'] .= "</p>\n";
-					$setting['run_lang'] = false;	// already done now
+					$setting['run_lang'] = false; // already done now
 					// handle as textarea
 				case 'textarea':
 					$setting['type'] = is_a($tpl, 'etemplate') ? 'textarea' : 'textbox';
 					$tpl->setElementAttribute($tab.'['.$setting['name'].']', 'multiline', 'true');
-					$tpl->setElementAttribute($tab. '[' . $setting['name'] . ']','width', '99%' );
+					$tpl->setElementAttribute($tab.'['.$setting['name'].']', 'width', '99%');
 					// anyway setting via css: width: 99%, height: 5em
 					// for old eT use size attribute
 					if (is_a($tpl, 'etemplate') && (!empty($setting['cols']) || !empty($setting['rows'])))
@@ -375,7 +375,7 @@ 
 				case 'multiselect':
 					$setting['type'] = 'select';
 					$tpl->setElementAttribute($tab.'['.$setting['name'].']', 'rows', 5);
-					if (!isset($setting['size'])) $setting['size'] = '5';	// old eT
+					if (!isset($setting['size'])) $setting['size'] = '5'; // old eT
 					break;
 				case 'color':
 					$setting['type'] = 'colorpicker';
@@ -383,7 +383,7 @@ 
 				case 'date-duration':
 					if (!isset($setting['size'])) $setting['size'] = 'm,dhm,24,1';
 					$attrs = explode(',', $setting['size']);
-					foreach(array("data_format","display_format", "hours_per_day", "empty_not_0", "short_labels") as $n => $name)
+					foreach (array("data_format", "display_format", "hours_per_day", "empty_not_0", "short_labels") as $n => $name)
 					{
 						if ((string)$attrs[$n] !== '') $tpl->setElementAttribute($tab.'['.$setting['name'].']', $name, $attrs[$n]);
 					}
@@ -394,17 +394,17 @@ 
 			{
 				if ($old_type != 'multiselect' && $old_type != 'notify')
 				{
-					switch($type)
+					switch ($type)
 					{
 						case 'user':
-							$setting['values'] = array('' => lang('Use default'))+$setting['values'];
+							$setting['values'] = array('' => lang('Use default')) + $setting['values'];
 							break;
 						case 'default':
 						case 'group':
-							$setting['values'] = array('' => lang('No default'))+$setting['values'];
+							$setting['values'] = array('' => lang('No default')) + $setting['values'];
 							break;
 						case 'forced';
-							$setting['values'] = array('**NULL**' => lang('Users choice'))+$setting['values'];
+							$setting['values'] = array('**NULL**' => lang('Users choice')) + $setting['values'];
 							break;
 					}
 				}
@@ -413,8 +413,7 @@ 
 			if ($type == 'user')
 			{
 				$default = $GLOBALS['egw']->preferences->group[$appname][$setting['name']] ?
-					$GLOBALS['egw']->preferences->group[$appname][$setting['name']] :
-					$GLOBALS['egw']->preferences->default[$appname][$setting['name']];
+					$GLOBALS['egw']->preferences->group[$appname][$setting['name']] : $GLOBALS['egw']->preferences->default[$appname][$setting['name']];
 
 				// replace default value(s) for selectboxes with selectbox labels
 				if (isset($setting['values']) && is_array($setting['values']))
@@ -434,7 +433,7 @@ 
 				'name' => $setting['name'],
 				'type' => $setting['type'],
 				'label' => preg_replace('|<br[ /]*>|i', "\n", $setting['label']),
-				'help' => lang($setting['help']),	// is html
+				'help' => lang($setting['help']), // is html
 				//'size' => $setting['size'],	// old eT
 				'default' => !empty($default) ? lang('Default').': '.$default : null,
 				'onchange' => $setting['onchange'],
@@ -460,7 +459,7 @@ 
 
 		$content['appname'] = $appname;
 		$sel_options['appname'] = array();
-		foreach(Api\Hooks::implemented('settings') as $app)
+		foreach (Api\Hooks::implemented('settings') as $app)
 		{
 			if ($app != 'preferences' && $GLOBALS['egw_info']['user']['apps'][$app])
 			{
@@ -486,7 +485,7 @@ 
 				$user_apps = $GLOBALS['egw']->acl->get_user_applications($id);
 				$sel_options['appname'] = array_intersect_key($sel_options['appname'], $user_apps);
 			}
-			foreach($GLOBALS['egw']->accounts->search(array('type' => 'groups', 'order' => 'account_lid')) as $account_id => $group)
+			foreach ($GLOBALS['egw']->accounts->search(array('type' => 'groups', 'order' => 'account_lid')) as $account_id => $group)
 			{
 				$sel_options['type']['group:'.$account_id] = lang('Preferences').' '.Api\Accounts::format_username($group['account_lid'], '', '', $account_id);
 			}
@@ -509,7 +508,7 @@ 
 	 * @param boolean $lang =true
 	 * @return string comma-separated and translated labels
 	 */
-	protected static function get_default_label($default, array $values, $lang=true)
+	protected static function get_default_label($default, array $values, $lang = true)
 	{
 		// explode comma-separated multiple default values
 		if (!is_array($default) && !isset($values[$default]) && strpos($default, ',') !== false)
@@ -520,7 +519,7 @@ 
 		{
 			$labels = (array)$default;
 		}
-		foreach($labels as &$def)
+		foreach ($labels as &$def)
 		{
 			if (isset($values[$def]))
 			{
@@ -528,7 +527,7 @@ 
 			}
 			else	// value could be in an optgroup
 			{
-				foreach($values as $value)
+				foreach ($values as $value)
 				{
 					if (is_array($value) && !isset($value['label']) && isset($value[$def]))
 					{
@@ -554,16 +553,16 @@ 
 	 * @param int|string $account_id =null account_id for user or group prefs, or "forced" or "default"
 	 * @return boolean
 	 */
-	protected function call_hook($appname, $type='user', $account_id=null)
+	protected function call_hook($appname, $type = 'user', $account_id = null)
 	{
 		$this->appname = $appname == 'common' ? 'preferences' : $appname;
 
 		// Set framework here to make sure we get the right settings for user's [newly] selected template
 		$GLOBALS['egw_info']['server']['template_set'] = $GLOBALS['egw']->preferences->data['common']['template_set'];
 		Api\Translation::add_app($this->appname);
-		if($this->appname != 'preferences')
+		if ($this->appname != 'preferences')
 		{
-			Api\Translation::add_app('preferences');	// we need the prefs translations too
+			Api\Translation::add_app('preferences'); // we need the prefs translations too
 		}
 
 		// make type available, to hooks from Egw\Applications can use it, eg. activesync
@@ -572,7 +571,7 @@ 
 			'type' => $type,
 			'account_id' => $account_id,
 		);
-		$GLOBALS['type'] = $type;	// old global variable
+		$GLOBALS['type'] = $type; // old global variable
 
 		// calling app specific settings hook
 		$settings = Api\Hooks::single($hook_data, $this->appname);
@@ -581,30 +580,30 @@ 
 		{
 			$this->settings = array_merge($this->settings, $settings);
 		}
-		elseif(isset($GLOBALS['settings']) && is_array($GLOBALS['settings']) && $GLOBALS['settings'])
+		elseif (isset($GLOBALS['settings']) && is_array($GLOBALS['settings']) && $GLOBALS['settings'])
 		{
 			$this->settings = array_merge($this->settings, $GLOBALS['settings']);
 		}
 		else
 		{
-			return False;	// no settings returned
+			return False; // no settings returned
 		}
 
 		// calling settings hook all apps can answer (for a specific app)
 		$hook_data['location'] = 'settings_'.$this->appname;
-		foreach(Api\Hooks::process($hook_data, $this->appname,true) as $settings)
+		foreach (Api\Hooks::process($hook_data, $this->appname, true) as $settings)
 		{
 			if (isset($settings) && is_array($settings) && $settings)
 			{
-				$this->settings = array_merge($this->settings,$settings);
+				$this->settings = array_merge($this->settings, $settings);
 			}
 		}
 		/* Remove ui-only settings */
-		if($this->xmlrpc)
+		if ($this->xmlrpc)
 		{
-			foreach($this->settings as $key => $valarray)
+			foreach ($this->settings as $key => $valarray)
 			{
-				if(!$valarray['xmlrpc'])
+				if (!$valarray['xmlrpc'])
 				{
 					unset($this->settings[$key]);
 				}
@@ -616,10 +615,10 @@ 
 			 This is not handled by the hooks class and is only valid if not using xml-rpc.
 			*/
 			$tmpl_settings = EGW_SERVER_ROOT.$GLOBALS['egw']->framework->template_dir.'/hook_settings.inc.php';
-			if($this->appname == 'preferences' && file_exists($tmpl_settings))
+			if ($this->appname == 'preferences' && file_exists($tmpl_settings))
 			{
 				include($tmpl_settings);
-				$this->settings = array_merge($this->settings,$GLOBALS['settings']);
+				$this->settings = array_merge($this->settings, $GLOBALS['settings']);
 			}
 		}
 		// check if we have a default/forced value from the settings hook,
@@ -640,9 +639,9 @@ 
 		}
 		if ($need_update)
 		{
-			$GLOBALS['egw']->preferences->save_repository(false,'default',true);
+			$GLOBALS['egw']->preferences->save_repository(false, 'default', true);
 		}
-		if($this->debug)
+		if ($this->debug)
 		{
 			_debug_array($this->settings);
 		}

Braces +67 added lines, -16 removed lines

@@ -164,9 +164,15 @@ 
 		$data = $this->get_content($appname, $type, $sel_options, $readonlys, $preserve['types'], $tpl);
 		$preserve['appname'] = $preserve['old_appname'] = $data['appname'];
 		$preserve['type'] = $preserve['old_type'] = $data['type'];
-		if (isset($old_tab)) $data['tabs'] = $old_tab;
+		if (isset($old_tab))
+		{
+			$data['tabs'] = $old_tab;
+		}
 
-		if ($msg) Framework::message($msg, $msg_type ? $msg_type : 'error');
+		if ($msg)
+		{
+			Framework::message($msg, $msg_type ? $msg_type : 'error');
+		}
 
 		$tpl->exec('preferences.preferences_settings.index', $data, $sel_options, $readonlys, $preserve, 2);
 	}
@@ -195,7 +201,10 @@ 
 			switch((string)$types[$var])
 			{
 				case 'password':	// dont write empty password-fields
-					if (empty($value)) continue 2;
+					if (empty($value))
+					{
+						continue 2;
+					}
 					break;
 				case 'vfs_file':
 				case 'vfs_dir':
@@ -209,7 +218,10 @@ 
 						{
 							unset($prefs[$var]);
 							// need to call preferences::delete, to also set affective prefs!
-							if (!$only_verify) $GLOBALS['egw']->preferences->delete($appname, $var, $type);
+							if (!$only_verify)
+							{
+								$GLOBALS['egw']->preferences->delete($appname, $var, $type);
+							}
 							continue 2;
 						}
 					}
@@ -226,7 +238,11 @@ 
 						// to still allow space or comma in dirnames, we also use the trailing slash of all pathes to split
 						foreach($types[$var] == 'vfs_dir' ? array($value) : preg_split('/[,\s]+\//', $value) as $n => $dir)
 						{
-							if ($n) $dir = '/'.$dir;	// re-adding trailing slash removed by split
+							if ($n)
+							{
+								$dir = '/'.$dir;
+							}
+							// re-adding trailing slash removed by split
 							if ($dir[0] != '/' || !Vfs::stat($dir) || !Vfs::is_dir($dir))
 							{
 								$error .= ($error ? ' ' : '').lang('%1 is no existing vfs directory!',$dir);
@@ -241,19 +257,29 @@ 
 
 			if (isset($value) && $value !== '' && $value !== '**NULL**' && $value !== array())
 			{
-				if (is_array($value)) $value = implode(',',$value);	// multiselect
+				if (is_array($value))
+				{
+					$value = implode(',',$value);
+				}
+				// multiselect
 
 				$prefs[$var] = $value;
 
 				// need to call preferences::add, to also set affective prefs!
-				if (!$only_verify) $GLOBALS['egw']->preferences->add($appname, $var, $prefs[$var], $type);
+				if (!$only_verify)
+				{
+					$GLOBALS['egw']->preferences->add($appname, $var, $prefs[$var], $type);
+				}
 			}
 			else
 			{
 				unset($prefs[$var]);
 
 				// need to call preferences::delete, to also set affective prefs!
-				if (!$only_verify) $GLOBALS['egw']->preferences->delete($appname, $var, $type);
+				if (!$only_verify)
+				{
+					$GLOBALS['egw']->preferences->delete($appname, $var, $type);
+				}
 			}
 		}
 
@@ -273,7 +299,10 @@ 
 			return $error;
 		}
 
-		if (!$only_verify) $GLOBALS['egw']->preferences->save_repository(True,$type);
+		if (!$only_verify)
+		{
+			$GLOBALS['egw']->preferences->save_repository(True,$type);
+		}
 
 		// certain common prefs (language, template, ...) require the session to be re-created
 		if ($appname == 'common' && !$only_verify)
@@ -311,7 +340,10 @@ 
 		$tab = 'tab1';
 		foreach($this->settings as $setting)
 		{
-			if (!is_array($setting)) continue;
+			if (!is_array($setting))
+			{
+				continue;
+			}
 			if ($type != 'forced' && (string)$GLOBALS['egw']->preferences->forced[$appname][$setting['name']] !== '')
 			{
 				continue;	// forced preferences are not displayed, unless we edit them
@@ -333,7 +365,10 @@ 
 
 				case 'notify':
 					$vars = $GLOBALS['egw']->preferences->vars;
-					if (is_array($setting['values'])) $vars += $setting['values'];
+					if (is_array($setting['values']))
+					{
+						$vars += $setting['values'];
+					}
 					$GLOBALS['egw']->preferences->{$attribute}[$appname][$setting['name']] =
 						$GLOBALS['egw']->preferences->lang_notify($GLOBALS['egw']->preferences->{$attribute}[$appname][$setting['name']], $vars);
 					$types[$setting['name']] = $vars;	// store vars for re-translation, instead type "notify"
@@ -375,17 +410,27 @@ 
 				case 'multiselect':
 					$setting['type'] = 'select';
 					$tpl->setElementAttribute($tab.'['.$setting['name'].']', 'rows', 5);
-					if (!isset($setting['size'])) $setting['size'] = '5';	// old eT
+					if (!isset($setting['size']))
+					{
+						$setting['size'] = '5';
+					}
+					// old eT
 					break;
 				case 'color':
 					$setting['type'] = 'colorpicker';
 					break;
 				case 'date-duration':
-					if (!isset($setting['size'])) $setting['size'] = 'm,dhm,24,1';
+					if (!isset($setting['size']))
+					{
+						$setting['size'] = 'm,dhm,24,1';
+					}
 					$attrs = explode(',', $setting['size']);
 					foreach(array("data_format","display_format", "hours_per_day", "empty_not_0", "short_labels") as $n => $name)
 					{
-						if ((string)$attrs[$n] !== '') $tpl->setElementAttribute($tab.'['.$setting['name'].']', $name, $attrs[$n]);
+						if ((string)$attrs[$n] !== '')
+						{
+							$tpl->setElementAttribute($tab.'['.$setting['name'].']', $name, $attrs[$n]);
+						}
 					}
 					break;
 			}
@@ -421,10 +466,13 @@ 
 				{
 					$default = self::get_default_label($default, $setting['values']);
 				}
-				if (is_array($types[$setting['name']]))	// translate the substitution names
+				if (is_array($types[$setting['name']]))
+				{
+					// translate the substitution names
 				{
 					$default = $GLOBALS['egw']->preferences->lang_notify($default, $types[$setting['name']]);
 				}
+				}
 			}
 			if ($setting['help'] && ($setting['run_lang'] || !isset($setting['run_lang'])))
 			{
@@ -537,7 +585,10 @@ 
 					}
 				}
 			}
-			if ($lang) $def = lang($def);
+			if ($lang)
+			{
+				$def = lang($def);
+			}
 		}
 		$label = implode(', ', $labels);
 		//error_log(__METHOD__."(".array2string($default).', '.array2string($values).") returning $label");

redirect.php

Doc Comments +4 added lines

@@ -24,6 +24,10 @@
 
 	if(!function_exists('html_entity_decode'))
 	{
+
+		/**
+		 * @param integer $quote_style
+		 */
 		function html_entity_decode($given_html, $quote_style = ENT_QUOTES)
 		{
 			$trans_table = array_flip(get_html_translation_table( HTML_SPECIALCHARS, $quote_style));

Spacing +9 added lines, -9 removed lines

@@ -22,11 +22,11 @@ 
 	  "<a href=\"$webserverURL/redirect.php?go=".htmlentities(urlencode('http://www.egroupware.org')).'">'
 	*/
 
-	if(!function_exists('html_entity_decode'))
+	if (!function_exists('html_entity_decode'))
 	{
 		function html_entity_decode($given_html, $quote_style = ENT_QUOTES)
 		{
-			$trans_table = array_flip(get_html_translation_table( HTML_SPECIALCHARS, $quote_style));
+			$trans_table = array_flip(get_html_translation_table(HTML_SPECIALCHARS, $quote_style));
 			$trans_table['&#39;'] = "'";
 			return(strtr($given_html, $trans_table));
 		}
@@ -45,17 +45,17 @@ 
 
 	/* Only allow redirects from inside this eGroupware installation. */
 	$valid_referer = array();
-	$path = preg_replace('/\/[^\/]*$/','',$_SERVER['PHP_SELF']) . '/';
+	$path = preg_replace('/\/[^\/]*$/', '', $_SERVER['PHP_SELF']).'/';
 	array_push($valid_referer, $path);
-	array_push($valid_referer, ($_SERVER['HTTPS'] ? 'https://' : 'http://') . $_SERVER['SERVER_ADDR'] . $path);
-	array_push($valid_referer, ($_SERVER['HTTPS'] ? 'https://' : 'http://') . $_SERVER['SERVER_NAME'] . $path);
+	array_push($valid_referer, ($_SERVER['HTTPS'] ? 'https://' : 'http://').$_SERVER['SERVER_ADDR'].$path);
+	array_push($valid_referer, ($_SERVER['HTTPS'] ? 'https://' : 'http://').$_SERVER['SERVER_NAME'].$path);
 
 	$referrer = trim($_SERVER['HTTP_REFERER']);
 	if ((!isset($_SERVER['HTTP_REFERER'])) || (empty($referrer)))
 	{
 		echo "Only usable from within eGroupware.\n";
 	}
-	else if($_GET['go'])
+	else if ($_GET['go'])
 	{
 		$allow = false;
 		foreach ($valid_referer as $urlRoot)
@@ -69,15 +69,15 @@ 
 		}
 		if ($allow)
 		{
-			$url= html_entity_decode(urldecode($_GET['go']));
+			$url = html_entity_decode(urldecode($_GET['go']));
 			unset($_GET['go']);
 			/* Only add "&" if there is something to append. */
 			if (!empty($_GET))
 			{
-				$url=$url."&".http_build_query($_GET);
+				$url = $url."&".http_build_query($_GET);
 			}
 
-			Header('Location: ' . html_entity_decode(urldecode($url)));
+			Header('Location: '.html_entity_decode(urldecode($url)));
 			exit;
 		}
 		else