EGroupware / egroupware

api/src/Vfs/Links/StreamWrapper.php

Doc Comments +1 added lines, -1 removed lines

@@ -316,7 +316,7 @@
 	 *
 	 * @param string $url URL that was passed to opendir() and that this object is expected to explore.
 	 * @param $options
-	 * @return booelan
+	 * @return boolean
 	 */
 	function dir_opendir ( $url, $options )
 	{

Spacing +43 added lines, -43 removed lines

@@ -76,34 +76,34 @@ 
 	 * @param int $check mode to check: one or more or'ed together of: 4 = read, 2 = write, 1 = executable
 	 * @return boolean
 	 */
-	static function check_extended_acl($url,$check)
+	static function check_extended_acl($url, $check)
 	{
 		if (Vfs::$is_root)
 		{
 			return true;
 		}
-		$path = Vfs::parse_url($url,PHP_URL_PATH);
+		$path = Vfs::parse_url($url, PHP_URL_PATH);
 
-		list(,$apps,$app,$id,$rel_path) = explode('/',$path,5);
+		list(,$apps, $app, $id, $rel_path) = explode('/', $path, 5);
 
 		if ($apps != 'apps')
 		{
-			$access = false;							// no access to anything, but /apps
+			$access = false; // no access to anything, but /apps
 			$what = '!= apps';
 		}
 		elseif (!$app)
 		{
-			$access = !($check & Vfs::WRITABLE);	// always grant read access to /apps
+			$access = !($check&Vfs::WRITABLE); // always grant read access to /apps
 			$what = '!$app';
 		}
-		elseif(!isset($GLOBALS['egw_info']['user']['apps'][$app]))
+		elseif (!isset($GLOBALS['egw_info']['user']['apps'][$app]))
 		{
-			$access = false;							// user has no access to the $app application
+			$access = false; // user has no access to the $app application
 			$what = 'no app-rights';
 		}
 		elseif (!$id)
 		{
-			$access = true;								// grant read&write access to /apps/$app
+			$access = true; // grant read&write access to /apps/$app
 			$what = 'app dir';
 		}
 		// allow applications to implement their own access control to the file storage
@@ -112,11 +112,11 @@ 
 		else
 		{
 			// vfs & stream-wrapper use posix rights, Api\Link::file_access uses Api\Acl::{EDIT|READ}!
-			$required = $check & Vfs::WRITABLE ? Api\Acl::EDIT : Api\Acl::READ;
-			$access = Api\Link::file_access($app,$id,$required,$rel_path,Vfs::$user);
+			$required = $check&Vfs::WRITABLE ? Api\Acl::EDIT : Api\Acl::READ;
+			$access = Api\Link::file_access($app, $id, $required, $rel_path, Vfs::$user);
 			$what = "from Api\Link::file_access('$app',$id,$required,'$rel_path,".Vfs::$user.")";
 		}
-		if (self::DEBUG) error_log(__METHOD__."($url,$check) user=".Vfs::$user." ($what) ".($access?"access granted ($app:$id:$rel_path)":'no access!!!'));
+		if (self::DEBUG) error_log(__METHOD__."($url,$check) user=".Vfs::$user." ($what) ".($access ? "access granted ($app:$id:$rel_path)" : 'no access!!!'));
 		return $access;
 	}
 
@@ -137,19 +137,19 @@ 
 	 *                          stat triggers it's own warning anyway, so it makes no sense to trigger one by our stream-wrapper!
 	 * @return array
 	 */
-	static function url_stat ( $url, $flags )
+	static function url_stat($url, $flags)
 	{
-		$eacl_check=self::check_extended_acl($url,Vfs::READABLE);
+		$eacl_check = self::check_extended_acl($url, Vfs::READABLE);
 
 		// return vCard as /.entry
-		if ( $eacl_check && substr($url,-7) == '/.entry' &&
-			(list($app) = array_slice(explode('/',$url),-3,1)) && $app === 'addressbook')
+		if ($eacl_check && substr($url, -7) == '/.entry' &&
+			(list($app) = array_slice(explode('/', $url), -3, 1)) && $app === 'addressbook')
 		{
 			$ret = array(
 				'ino'   => md5($url),
 				'name'  => '.entry',
-				'mode'  => self::MODE_FILE|Vfs::READABLE,	// required by the stream wrapper
-				'size'  => 1024,	// fmail does NOT attach files with size 0!
+				'mode'  => self::MODE_FILE|Vfs::READABLE, // required by the stream wrapper
+				'size'  => 1024, // fmail does NOT attach files with size 0!
 				'uid'   => 0,
 				'gid'   => 0,
 				'mtime' => time(),
@@ -160,15 +160,15 @@ 
 			);
 		}
 		// if entry directory does not exist --> return fake directory
-		elseif (!($ret = parent::url_stat($url,$flags,$eacl_check)) && $eacl_check)
+		elseif (!($ret = parent::url_stat($url, $flags, $eacl_check)) && $eacl_check)
 		{
-			list(,/*$apps*/,/*$app*/,$id,$rel_path) = explode('/', Vfs::parse_url($url, PHP_URL_PATH), 5);
+			list(,/*$apps*/, /*$app*/, $id, $rel_path) = explode('/', Vfs::parse_url($url, PHP_URL_PATH), 5);
 			if ($id && !isset($rel_path))
 			{
 				$ret = array(
 					'ino'   => md5($url),
 					'name'  => $id,
-					'mode'  => self::MODE_DIR,	// required by the stream wrapper
+					'mode'  => self::MODE_DIR, // required by the stream wrapper
 					'size'  => 0,
 					'uid'   => 0,
 					'gid'   => 0,
@@ -195,9 +195,9 @@ 
 	 * @param int $fs_id =null fs_id to use, to not query it again (eg. because it's already deleted)
 	 * @return boolean true if acl is set/deleted, false on error
 	 */
-	static function eacl($path,$rights=null,$owner=null,$fs_id=null)
+	static function eacl($path, $rights = null, $owner = null, $fs_id = null)
 	{
-		unset($path, $rights, $owner, $fs_id);	// not used, but required by function signature
+		unset($path, $rights, $owner, $fs_id); // not used, but required by function signature
 
 		return false;
 	}
@@ -212,7 +212,7 @@ 
 	 */
 	static function get_eacl($path)
 	{
-		unset($path);	// not used, but required by function signature
+		unset($path); // not used, but required by function signature
 
 		return false;
 	}
@@ -232,25 +232,25 @@ 
 	 * @param int $options Posible values include STREAM_REPORT_ERRORS and STREAM_MKDIR_RECURSIVE, we allways use recursive!
 	 * @return boolean TRUE on success or FALSE on failure
 	 */
-	static function mkdir($path,$mode,$options)
+	static function mkdir($path, $mode, $options)
 	{
-		unset($mode);	// not used, but required by function signature
+		unset($mode); // not used, but required by function signature
 
-		if($path[0] != '/')
+		if ($path[0] != '/')
 		{
-			if (strpos($path,'?') !== false) $query = Vfs::parse_url($path,PHP_URL_QUERY);
-			$path = Vfs::parse_url($path,PHP_URL_PATH).($query ? '?'.$query : '');
+			if (strpos($path, '?') !== false) $query = Vfs::parse_url($path, PHP_URL_QUERY);
+			$path = Vfs::parse_url($path, PHP_URL_PATH).($query ? '?'.$query : '');
 		}
-		list(,$apps,$app,$id) = explode('/',$path);
+		list(,$apps, $app, $id) = explode('/', $path);
 
 		$ret = false;
-		if ($apps == 'apps' && $app && !$id || self::check_extended_acl($path,Vfs::WRITABLE))	// app directory itself is allways ok
+		if ($apps == 'apps' && $app && !$id || self::check_extended_acl($path, Vfs::WRITABLE))	// app directory itself is allways ok
 		{
 			$current_is_root = Vfs::$is_root; Vfs::$is_root = true;
 			$current_user = Vfs::$user; Vfs::$user = 0;
 
-			$ret = parent::mkdir($path,0,$options|STREAM_MKDIR_RECURSIVE);
-			if ($id) parent::chmod($path,0);	// no other rights
+			$ret = parent::mkdir($path, 0, $options|STREAM_MKDIR_RECURSIVE);
+			if ($id) parent::chmod($path, 0); // no other rights
 
 			Vfs::$user = $current_user;
 			Vfs::$is_root = $current_is_root;
@@ -274,23 +274,23 @@ 
 	 * @param string $opened_path full path of the file/resource, if the open was successfull and STREAM_USE_PATH was set
 	 * @return boolean true if the ressource was opened successful, otherwise false
 	 */
-	function stream_open ( $url, $mode, $options, &$opened_path )
+	function stream_open($url, $mode, $options, &$opened_path)
 	{
 		// the following call is necessary to fill sqlfs_stream_wrapper::$stat_cache, WITH the extendes ACL!
-		$stat = self::url_stat($url,0);
+		$stat = self::url_stat($url, 0);
 		//error_log(__METHOD__."('$url', '$mode', $options) stat=".array2string($stat));
 
 		// return vCard as /.entry
-		if ($stat && $mode[0] == 'r' && substr($url,-7) === '/.entry' &&
-			(list($app) = array_slice(explode('/',$url),-3,1)) && $app === 'addressbook')
+		if ($stat && $mode[0] == 'r' && substr($url, -7) === '/.entry' &&
+			(list($app) = array_slice(explode('/', $url), -3, 1)) && $app === 'addressbook')
 		{
-			list($id) = array_slice(explode('/',$url),-2,1);
-			$ab_vcard = new addressbook_vcal('addressbook','text/vcard');
+			list($id) = array_slice(explode('/', $url), -2, 1);
+			$ab_vcard = new addressbook_vcal('addressbook', 'text/vcard');
 			if (!($charset = $GLOBALS['egw_info']['user']['preferences']['addressbook']['vcard_charset']))
 			{
 				$charset = 'utf-8';
 			}
-			if (!($vcard =& $ab_vcard->getVCard($id, $charset)))
+			if (!($vcard = & $ab_vcard->getVCard($id, $charset)))
 			{
 				error_log(__METHOD__."('$url', '$mode', $options) addressbook_vcal::getVCard($id) returned false!");
 				return false;
@@ -302,11 +302,11 @@ 
 			return true;
 		}
 		// create not existing entry directories on the fly
-		if ($mode[0] != 'r' && !parent::url_stat($dir = Vfs::dirname($url),0) && self::check_extended_acl($dir,Vfs::WRITABLE))
+		if ($mode[0] != 'r' && !parent::url_stat($dir = Vfs::dirname($url), 0) && self::check_extended_acl($dir, Vfs::WRITABLE))
 		{
-			self::mkdir($dir,0,STREAM_MKDIR_RECURSIVE);
+			self::mkdir($dir, 0, STREAM_MKDIR_RECURSIVE);
 		}
-		return parent::stream_open($url,$mode,$options,$opened_path);
+		return parent::stream_open($url, $mode, $options, $opened_path);
 	}
 
 	/**
@@ -318,7 +318,7 @@ 
 	 * @param $options
 	 * @return booelan
 	 */
-	function dir_opendir ( $url, $options )
+	function dir_opendir($url, $options)
 	{
 		if (!parent::url_stat($url, STREAM_URL_STAT_QUIET) && self::url_stat($url, STREAM_URL_STAT_QUIET))
 		{

Braces +26 added lines, -7 removed lines

@@ -26,7 +26,9 @@ 
  */
 if (!class_exists('EGroupware\\Api\\Vfs\\Links\\LinksParent', false))
 {
-	class LinksParent extends Vfs\Sqlfs\StreamWrapper {}
+	class LinksParent extends Vfs\Sqlfs\StreamWrapper
+	{
+}
 }
 
 /**
@@ -116,7 +118,10 @@ 
 			$access = Api\Link::file_access($app,$id,$required,$rel_path,Vfs::$user);
 			$what = "from Api\Link::file_access('$app',$id,$required,'$rel_path,".Vfs::$user.")";
 		}
-		if (self::DEBUG) error_log(__METHOD__."($url,$check) user=".Vfs::$user." ($what) ".($access?"access granted ($app:$id:$rel_path)":'no access!!!'));
+		if (self::DEBUG)
+		{
+			error_log(__METHOD__."($url,$check) user=".Vfs::$user." ($what) ".($access?"access granted ($app:$id:$rel_path)":'no access!!!'));
+		}
 		return $access;
 	}
 
@@ -180,7 +185,10 @@ 
 				);
 			}
 		}
-		if (self::DEBUG) error_log(__METHOD__."('$url', $flags) calling parent::url_stat(,,".array2string($eacl_check).') returning '.array2string($ret));
+		if (self::DEBUG)
+		{
+			error_log(__METHOD__."('$url', $flags) calling parent::url_stat(,,".array2string($eacl_check).') returning '.array2string($ret));
+		}
 		return $ret;
 	}
 
@@ -238,19 +246,30 @@ 
 
 		if($path[0] != '/')
 		{
-			if (strpos($path,'?') !== false) $query = Vfs::parse_url($path,PHP_URL_QUERY);
+			if (strpos($path,'?') !== false)
+			{
+				$query = Vfs::parse_url($path,PHP_URL_QUERY);
+			}
 			$path = Vfs::parse_url($path,PHP_URL_PATH).($query ? '?'.$query : '');
 		}
 		list(,$apps,$app,$id) = explode('/',$path);
 
 		$ret = false;
-		if ($apps == 'apps' && $app && !$id || self::check_extended_acl($path,Vfs::WRITABLE))	// app directory itself is allways ok
+		if ($apps == 'apps' && $app && !$id || self::check_extended_acl($path,Vfs::WRITABLE))
+		{
+			// app directory itself is allways ok
 		{
-			$current_is_root = Vfs::$is_root; Vfs::$is_root = true;
+			$current_is_root = Vfs::$is_root;
+		}
+		Vfs::$is_root = true;
 			$current_user = Vfs::$user; Vfs::$user = 0;
 
 			$ret = parent::mkdir($path,0,$options|STREAM_MKDIR_RECURSIVE);
-			if ($id) parent::chmod($path,0);	// no other rights
+			if ($id)
+			{
+				parent::chmod($path,0);
+			}
+			// no other rights
 
 			Vfs::$user = $current_user;
 			Vfs::$is_root = $current_is_root;

api/src/Vfs/Sharing.php

Doc Comments +1 added lines, -1 removed lines

@@ -98,7 +98,6 @@ 
 	/**
 	 * Protected constructor called via self::create_session
 	 *
-	 * @param string $token
 	 * @param array $share
 	 */
 	protected function __construct(array $share)
@@ -109,6 +108,7 @@ 
 
 	/**
 	 * Get token from url
+	 * @return string
 	 */
 	public static function get_token()
 	{

Indentation +13 added lines, -13 removed lines

@@ -72,10 +72,10 @@ 
 	const WRITABLE = 'share_rw';
 
  	/**
-	 * Modes for sharing files
-	 *
-	 * @var array
-	 */
+ 	 * Modes for sharing files
+ 	 *
+ 	 * @var array
+ 	 */
 	static $modes = array(
 		self::ATTACH => array(
 			'label' => 'Attachment',
@@ -112,16 +112,16 @@ 
 	 */
 	public static function get_token()
 	{
-        // WebDAV has no concept of a query string and clients (including cadaver)
-        // seem to pass '?' unencoded, so we need to extract the path info out
-        // of the request URI ourselves
-        // if request URI contains a full url, remove schema and domain
+		// WebDAV has no concept of a query string and clients (including cadaver)
+		// seem to pass '?' unencoded, so we need to extract the path info out
+		// of the request URI ourselves
+		// if request URI contains a full url, remove schema and domain
 		$matches = null;
-        if (preg_match('|^https?://[^/]+(/.*)$|', $path_info=$_SERVER['REQUEST_URI'], $matches))
-        {
-        	$path_info = $matches[1];
-        }
-        $path_info = substr($path_info, strlen($_SERVER['SCRIPT_NAME']));
+		if (preg_match('|^https?://[^/]+(/.*)$|', $path_info=$_SERVER['REQUEST_URI'], $matches))
+		{
+			$path_info = $matches[1];
+		}
+		$path_info = substr($path_info, strlen($_SERVER['SCRIPT_NAME']));
 		list(, $token/*, $path*/) = preg_split('|[/?]|', $path_info, 3);
 
 		return $token;

Spacing +26 added lines, -27 removed lines

@@ -117,7 +117,7 @@ 
         // of the request URI ourselves
         // if request URI contains a full url, remove schema and domain
 		$matches = null;
-        if (preg_match('|^https?://[^/]+(/.*)$|', $path_info=$_SERVER['REQUEST_URI'], $matches))
+        if (preg_match('|^https?://[^/]+(/.*)$|', $path_info = $_SERVER['REQUEST_URI'], $matches))
         {
         	$path_info = $matches[1];
         }
@@ -155,7 +155,7 @@ 
 	 * @param boolean $keep_session =null null: create a new session, true: try mounting it into existing (already verified) session
 	 * @return string with sessionid, does NOT return if no session created
 	 */
-	public static function create_session($keep_session=null)
+	public static function create_session($keep_session = null)
 	{
 		self::$db = $GLOBALS['egw']->db;
 
@@ -208,11 +208,11 @@ 
 		// need to reset fs_tab, as resolve_url does NOT work with just share mounted
 		if (count($GLOBALS['egw_info']['server']['vfs_fstab']) <= 1)
 		{
-			unset($GLOBALS['egw_info']['server']['vfs_fstab']);	// triggers reset of fstab in mount()
+			unset($GLOBALS['egw_info']['server']['vfs_fstab']); // triggers reset of fstab in mount()
 			$GLOBALS['egw_info']['server']['vfs_fstab'] = Vfs::mount();
 			Vfs::clearstatcache();
 		}
-		$share['resolve_url'] = Vfs::resolve_url($share['share_path'], true, true, true, true);	// true = fix evtl. contained url parameter
+		$share['resolve_url'] = Vfs::resolve_url($share['share_path'], true, true, true, true); // true = fix evtl. contained url parameter
 		// if share not writable append ro=1 to mount url to make it readonly
 		if (!self::$db->from_bool($share['share_writable']))
 		{
@@ -257,7 +257,7 @@ 
 
 		// update accessed timestamp
 		self::$db->update(self::TABLE, array(
-			'share_last_accessed' => $share['share_last_accessed']=time(),
+			'share_last_accessed' => $share['share_last_accessed'] = time(),
 		), array(
 			'share_id' => $share['share_id'],
 		), __LINE__, __FILE__);
@@ -299,7 +299,7 @@ 
 		if ($keep_session || $sessionid)
 		{
 			$_SESSION[Api\Session::EGW_INFO_CACHE] = $GLOBALS['egw_info'];
-			unset($_SESSION[Api\Session::EGW_INFO_CACHE]['flags']);	// dont save the flags, they change on each request
+			unset($_SESSION[Api\Session::EGW_INFO_CACHE]['flags']); // dont save the flags, they change on each request
 
 			$_SESSION[Api\Session::EGW_OBJECT_CACHE] = serialize($GLOBALS['egw']);
 		}
@@ -368,8 +368,7 @@ 
 		// generate random token (using oppenssl if available otherwise mt_rand based Api\Auth::randomstring)
 		do {
 			$token = function_exists('openssl_random_pseudo_bytes') ?
-				base64_encode(openssl_random_pseudo_bytes(3*self::TOKEN_LENGTH/4)) :
-				Api\Auth::randomstring(self::TOKEN_LENGTH);
+				base64_encode(openssl_random_pseudo_bytes(3 * self::TOKEN_LENGTH / 4)) : Api\Auth::randomstring(self::TOKEN_LENGTH);
 			// base64 can contain chars not allowed in our vfs-urls eg. / or #
 		} while ($token != Vfs::encodePathComponent($token));
 
@@ -389,13 +388,13 @@ 
 	 * @throw Api\Exception\AssertionFailed if user temp. directory does not exist and can not be created
 	 * @return array with share data, eg. value for key 'share_token'
 	 */
-	public static function create($path, $mode, $name, $recipients, $extra=array())
+	public static function create($path, $mode, $name, $recipients, $extra = array())
 	{
 		if (!isset(self::$db)) self::$db = $GLOBALS['egw']->db;
 
 		if (empty($name)) $name = $path;
 
-		$path2tmp =& Api\Cache::getSession(__CLASS__, 'path2tmp');
+		$path2tmp = & Api\Cache::getSession(__CLASS__, 'path2tmp');
 
 		// allow filesystem path only for temp_dir
 		$temp_dir = $GLOBALS['egw_info']['server']['temp_dir'].'/';
@@ -406,7 +405,7 @@ 
 		}
 		else
 		{
-			if(parse_url($path, PHP_URL_SCHEME) !== 'vfs')
+			if (parse_url($path, PHP_URL_SCHEME) !== 'vfs')
 			{
 				$path = 'vfs://default'.($path[0] == '/' ? '' : '/').$path;
 			}
@@ -420,7 +419,7 @@ 
 		}
 		// check if file has been shared before, with identical attributes
 		if (($mode != self::LINK || isset($path2tmp[$path])) &&
-			($share = self::$db->select(self::TABLE, '*', $extra+array(
+			($share = self::$db->select(self::TABLE, '*', $extra + array(
 				'share_path' => $mode == 'link' ? $path2tmp[$path] : $vfs_path,
 				'share_owner' => $GLOBALS['egw_info']['user']['account_id'],
 				'share_expires' => null,
@@ -431,7 +430,7 @@ 
 			// if yes, just add additional recipients
 			$share['share_with'] = $share['share_with'] ? explode(',', $share['share_with']) : array();
 			$need_save = false;
-			foreach((array)$recipients as $recipient)
+			foreach ((array)$recipients as $recipient)
 			{
 				if (!in_array($recipient, $share['share_with']))
 				{
@@ -461,9 +460,9 @@ 
 				}
 				$n = 0;
 				do {
-					$tmp_file = Vfs::concat($user_tmp, ($n?$n.'.':'').Vfs::basename($name));
+					$tmp_file = Vfs::concat($user_tmp, ($n ? $n.'.' : '').Vfs::basename($name));
 				}
-				while(!(is_dir($path) && Vfs::mkdir($tmp_file, null, STREAM_MKDIR_RECURSIVE) ||
+				while (!(is_dir($path) && Vfs::mkdir($tmp_file, null, STREAM_MKDIR_RECURSIVE) ||
 					!is_dir($path) && (!Vfs::file_exists($tmp_file) && ($fp = Vfs::fopen($tmp_file, 'x')) ||
 						// do not copy identical files again to users tmp dir, just re-use them
 						Vfs::file_exists($tmp_file) && Vfs::compare(Vfs::PREFIX.$tmp_file, $path))) && $n++ < 100);
@@ -488,12 +487,12 @@ 
 				$async = new Api\Asyncservice();
 				if (!$async->read('egw_sharing-tmp-cleanup'))
 				{
-					$async->set_timer(array('day' => 28),'egw_sharing-tmp_cleanup','egw_sharing::tmp_cleanup',null);
+					$async->set_timer(array('day' => 28), 'egw_sharing-tmp_cleanup', 'egw_sharing::tmp_cleanup', null);
 				}
 			}
 
 			$i = 0;
-			while(true)	// self::token() can return an existing value
+			while (true)	// self::token() can return an existing value
 			{
 				try {
 					self::$db->insert(self::TABLE, $share = array(
@@ -502,12 +501,12 @@ 
 						'share_owner' => $GLOBALS['egw_info']['user']['account_id'],
 						'share_with' => implode(',', (array)$recipients),
 						'share_created' => time(),
-					)+$extra, false, __LINE__, __FILE__);
+					) + $extra, false, __LINE__, __FILE__);
 
 					$share['share_id'] = self::$db->get_last_insert_id(self::TABLE, 'share_id');
 					break;
 				}
-				catch(Api\Db\Exception $e) {
+				catch (Api\Db\Exception $e) {
 					if ($i++ > 3) throw $e;
 					unset($e);
 				}
@@ -550,8 +549,8 @@ 
 
 		// get all temp. files, to be able to delete them
 		$tmp_paths = array();
-		foreach(self::$db->select(self::TABLE, 'share_path', array(
-			"share_path LIKE '/home/%/.tmp/%'")+$keys, __LINE__, __FILE__, false) as $row)
+		foreach (self::$db->select(self::TABLE, 'share_path', array(
+			"share_path LIKE '/home/%/.tmp/%'") + $keys, __LINE__, __FILE__, false) as $row)
 		{
 			$tmp_paths[] = $row['share_path'];
 		}
@@ -563,7 +562,7 @@ 
 		// check if temp. files are used elsewhere
 		if ($tmp_paths)
 		{
-			foreach(self::$db->select(self::TABLE, 'share_path,COUNT(*) AS cnt', array(
+			foreach (self::$db->select(self::TABLE, 'share_path,COUNT(*) AS cnt', array(
 				'share_path' => $tmp_paths,
 			), __LINE__, __FILE__, false, 'GROUP BY share_path') as $row)
 			{
@@ -573,7 +572,7 @@ 
 				}
 			}
 			// if not delete them
-			foreach($tmp_paths as $path)
+			foreach ($tmp_paths as $path)
 			{
 				Vfs::remove($path);
 			}
@@ -607,11 +606,11 @@ 
 			// remove expired tmp-files unconditionally
 			$having = 'HAVING share_expires < '.self::$db->quote(self::$db->to_timestamp(time())).' OR '.
 				// remove without expiration date, when created over 100 days ago AND
-				'share_expires IS NULL AND share_created < '.self::$db->quote(self::$db->to_timestamp(time()-self::TMP_KEEP)). ' AND '.
+				'share_expires IS NULL AND share_created < '.self::$db->quote(self::$db->to_timestamp(time() - self::TMP_KEEP)).' AND '.
 					// (last accessed over 100 days ago OR never)
-					'(share_last_accessed IS NULL OR share_last_accessed < '.self::$db->quote(self::$db->to_timestamp(time()-self::TMP_KEEP)).')';
+					'(share_last_accessed IS NULL OR share_last_accessed < '.self::$db->quote(self::$db->to_timestamp(time() - self::TMP_KEEP)).')';
 
-			foreach(self::$db->select(self::TABLE, $cols, array(
+			foreach (self::$db->select(self::TABLE, $cols, array(
 				"share_path LIKE '/home/%/.tmp/%'",
 			), __LINE__, __FILE__, false, 'GROUP BY share_path '.$having) as $row)
 			{
@@ -624,7 +623,7 @@ 
 				else
 				{
 					$share_ids = array();
-					foreach(self::$db->selec(self::TABLE, 'share_id', array(
+					foreach (self::$db->selec(self::TABLE, 'share_id', array(
 						'share_path' => $row['share_path'],
 					), __LINE__, __FILE__) as $id)
 					{

Braces +48 added lines, -12 removed lines

@@ -166,7 +166,10 @@ 
 		if ($token && !$keep_session)
 		{
 			$_SERVER['PHP_AUTH_USER'] = $token;
-			if (!isset($_SERVER['PHP_AUTH_PW'])) $_SERVER['PHP_AUTH_PW'] = '';
+			if (!isset($_SERVER['PHP_AUTH_PW']))
+			{
+				$_SERVER['PHP_AUTH_PW'] = '';
+			}
 
 			unset($GLOBALS['egw_info']['flags']['autocreate_session_callback']);
 			if ($GLOBALS['egw']->session->verify() && isset($GLOBALS['egw']->sharing) &&
@@ -220,9 +223,12 @@ 
 		}
 		//_debug_array($share);
 
-		if ($keep_session)	// add share to existing session
+		if ($keep_session)
+		{
+			// add share to existing session
 		{
 			$share['share_root'] = '/'.$share['share_token'];
+		}
 
 			// if current user is not the share owner, we cant just mount share
 			if (Vfs::$user != $share['share_owner'])
@@ -230,12 +236,15 @@ 
 				$keep_session = false;
 			}
 		}
-		if (!$keep_session)	// do NOT change to else, as we might have set $keep_session=false!
+		if (!$keep_session)
+		{
+			// do NOT change to else, as we might have set $keep_session=false!
 		{
 			// only allow filemanager app
 			$GLOBALS['egw_info']['user']['apps'] = array(
 				'filemanager' => $GLOBALS['egw_info']['apps']['filemanager']
 			);
+		}
 
 			$share['share_root'] = '/';
 			Vfs::$user = $share['share_owner'];
@@ -391,9 +400,15 @@ 
 	 */
 	public static function create($path, $mode, $name, $recipients, $extra=array())
 	{
-		if (!isset(self::$db)) self::$db = $GLOBALS['egw']->db;
+		if (!isset(self::$db))
+		{
+			self::$db = $GLOBALS['egw']->db;
+		}
 
-		if (empty($name)) $name = $path;
+		if (empty($name))
+		{
+			$name = $path;
+		}
 
 		$path2tmp =& Api\Cache::getSession(__CLASS__, 'path2tmp');
 
@@ -472,7 +487,10 @@ 
 				{
 					throw new Api\Exception\AssertionFailed("Could NOT create temp. file '$tmp_file'!");
 				}
-				if ($fp) fclose($fp);
+				if ($fp)
+				{
+					fclose($fp);
+				}
 
 				if (is_dir($path) && !Vfs::copy_files(array($path), $tmp_file) ||
 					!is_dir($path) && !copy($path, Vfs::PREFIX.$tmp_file))
@@ -493,7 +511,9 @@ 
 			}
 
 			$i = 0;
-			while(true)	// self::token() can return an existing value
+			while(true)
+			{
+				// self::token() can return an existing value
 			{
 				try {
 					self::$db->insert(self::TABLE, $share = array(
@@ -503,12 +523,16 @@ 
 						'share_with' => implode(',', (array)$recipients),
 						'share_created' => time(),
 					)+$extra, false, __LINE__, __FILE__);
+			}
 
 					$share['share_id'] = self::$db->get_last_insert_id(self::TABLE, 'share_id');
 					break;
 				}
 				catch(Api\Db\Exception $e) {
-					if ($i++ > 3) throw $e;
+					if ($i++ > 3)
+					{
+						throw $e;
+					}
 					unset($e);
 				}
 			}
@@ -546,7 +570,10 @@ 
 	{
 		self::$db = $GLOBALS['egw']->db;
 
-		if (is_scalar($keys)) $keys = array('share_id' => $keys);
+		if (is_scalar($keys))
+		{
+			$keys = array('share_id' => $keys);
+		}
 
 		// get all temp. files, to be able to delete them
 		$tmp_paths = array();
@@ -593,7 +620,10 @@ 
 	 */
 	public static function tmp_cleanup()
 	{
-		if (!isset(self::$db)) self::$db = $GLOBALS['egw']->db;
+		if (!isset(self::$db))
+		{
+			self::$db = $GLOBALS['egw']->db;
+		}
 		Vfs::$is_root = true;
 
 		try {
@@ -603,7 +633,10 @@ 
 				'MAX(share_created) AS share_created',
 				'MAX(share_last_accessed) AS share_last_accessed',
 			);
-			if (($group_concat = self::$db->group_concat('share_id'))) $cols[] = $group_concat.' AS share_id';
+			if (($group_concat = self::$db->group_concat('share_id')))
+			{
+				$cols[] = $group_concat.' AS share_id';
+			}
 			// remove expired tmp-files unconditionally
 			$having = 'HAVING share_expires < '.self::$db->quote(self::$db->to_timestamp(time())).' OR '.
 				// remove without expiration date, when created over 100 days ago AND
@@ -651,7 +684,10 @@ 
 	 */
 	public static function share2link($share)
 	{
-		if (is_array($share)) $share = $share['share_token'];
+		if (is_array($share))
+		{
+			$share = $share['share_token'];
+		}
 
 		$link = Api\Framework::link('/share.php').'/'.$share;
 		if ($link[0] == '/')

api/src/Vfs/Sqlfs/StreamWrapper.php

Doc Comments +9 added lines, -5 removed lines

@@ -506,7 +506,7 @@ 
 	 *
 	 * If you have cached data in your stream but not yet stored it into the underlying storage, you should do so now.
 	 *
-	 * @return booelan TRUE if the cached data was successfully stored (or if there was no data to store), or FALSE if the data could not be stored.
+	 * @return boolean TRUE if the cached data was successfully stored (or if there was no data to store), or FALSE if the data could not be stored.
 	 */
 	function stream_flush ( )
 	{
@@ -547,6 +547,7 @@ 
 	 * In order for the appropriate error message to be returned, do not define this method if your wrapper does not support unlinking!
 	 *
 	 * @param string $url
+	 * @param integer $parent_stat
 	 * @return boolean TRUE on success or FALSE on failure
 	 */
 	static function unlink ( $url, $parent_stat=null )
@@ -675,6 +676,8 @@ 
 
 	/**
 	 * due to problems with recursive directory creation, we have our own here
+	 * @param false|string $pathname
+	 * @param integer $mode
 	 */
 	protected static function mkdir_recursive($pathname, $mode, $depth=0)
 	{
@@ -1005,7 +1008,7 @@ 
 	 *
 	 * @param string $url URL that was passed to opendir() and that this object is expected to explore.
 	 * @param int $options
-	 * @return booelan
+	 * @return boolean
 	 */
 	function dir_opendir ( $url, $options )
 	{
@@ -1405,7 +1408,7 @@ 
 	 *
 	 * @param string $path string with path
 	 * @param int $rights =null rights to set, or null to delete the entry
-	 * @param int|boolean $owner =null owner for whom to set the rights, null for the current user, or false to delete all rights for $path
+	 * @param boolean $owner =null owner for whom to set the rights, null for the current user, or false to delete all rights for $path
 	 * @param int $fs_id =null fs_id to use, to not query it again (eg. because it's already deleted)
 	 * @return boolean true if acl is set/deleted, false on error
 	 */
@@ -1707,7 +1710,7 @@ 
 	/**
 	 * Just a little abstration 'til I know how to organise stuff like that with PDO
 	 *
-	 * @param mixed $time
+	 * @param integer $time
 	 * @return string Y-m-d H:i:s
 	 */
 	static protected function _pdo_timestamp($time)
@@ -1792,6 +1795,7 @@ 
 	 * Replace the password of an url with '...' for error messages
 	 *
 	 * @param string &$url
+	 * @param string $url
 	 */
 	static protected function _remove_password(&$url)
 	{
@@ -1807,7 +1811,7 @@ 
 	/**
 	 * Get storage mode from url (get parameter 'storage', eg. ?storage=db)
 	 *
-	 * @param string|array $url complete url or array of url-parts from parse_url
+	 * @param string $url complete url or array of url-parts from parse_url
 	 * @return int self::STORE2FS or self::STORE2DB
 	 */
 	static function url2operation($url)

Indentation +5 added lines, -5 removed lines

@@ -447,10 +447,10 @@ 
  	 * Important: PHP 5.0 introduced a bug that wasn't fixed until 5.1: the return value has to be the oposite!
  	 *
  	 * if(version_compare(PHP_VERSION,'5.0','>=') && version_compare(PHP_VERSION,'5.1','<'))
-  	 * {
+ 	 * {
  	 * 		$eof = !$eof;
  	 * }
-  	 *
+ 	 *
  	 * @return boolean true if the read/write position is at the end of the stream and no more data availible, false otherwise
  	 */
 	function stream_eof ( )
@@ -485,7 +485,7 @@ 
  	 * See fseek() for more information about these parameters.
  	 *
  	 * @param integer $offset
-  	 * @param integer $whence	SEEK_SET - 0 - Set position equal to offset bytes
+ 	 * @param integer $whence	SEEK_SET - 0 - Set position equal to offset bytes
  	 * 							SEEK_CUR - 1 - Set position to current location plus offset.
  	 * 							SEEK_END - 2 - Set position to end-of-file plus offset. (To move to a position before the end-of-file, you need to pass a negative value in offset.)
  	 * @return boolean TRUE if the position was updated, FALSE otherwise.
@@ -681,8 +681,8 @@ 
 		$maxdepth=10;
 		$depth2propagate = (int)$depth + 1;
 		if ($depth2propagate > $maxdepth) return is_dir($pathname);
-    	is_dir(Vfs::dirname($pathname)) || self::mkdir_recursive(Vfs::dirname($pathname), $mode, $depth2propagate);
-    	return is_dir($pathname) || @mkdir($pathname, $mode);
+		is_dir(Vfs::dirname($pathname)) || self::mkdir_recursive(Vfs::dirname($pathname), $mode, $depth2propagate);
+		return is_dir($pathname) || @mkdir($pathname, $mode);
 	}
 
 	/**

Spacing +234 added lines, -236 removed lines

@@ -67,7 +67,7 @@ 
 	/**
 	 * mode-bits, which have to be set for directories
 	 */
-	const MODE_DIR =   040000;
+	const MODE_DIR = 040000;
 	/**
 	 * mode-bits, which have to be set for links
 	 */
@@ -170,10 +170,10 @@ 
 	 *
 	 * @param string $path ='/'
 	 */
-	public static function clearstatcache($path='/')
+	public static function clearstatcache($path = '/')
 	{
 		//error_log(__METHOD__."('$path')");
-		unset($path);	// not used
+		unset($path); // not used
 
 		self::$stat_cache = array();
 
@@ -193,32 +193,32 @@ 
 	 * @param array $overwrite_new =null if set create new file with values overwriten by the given ones
 	 * @return boolean true if the ressource was opened successful, otherwise false
 	 */
-	function stream_open ( $url, $mode, $options, &$opened_path, array $overwrite_new=null )
+	function stream_open($url, $mode, $options, &$opened_path, array $overwrite_new = null)
 	{
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url,$mode,$options)");
 
-		$path = Vfs::parse_url($url,PHP_URL_PATH);
+		$path = Vfs::parse_url($url, PHP_URL_PATH);
 		$this->operation = self::url2operation($url);
 		$dir = Vfs::dirname($url);
 
 		$this->opened_path = $opened_path = $path;
-		$this->opened_mode = $mode = str_replace('b','',$mode);	// we are always binary, like every Linux system
+		$this->opened_mode = $mode = str_replace('b', '', $mode); // we are always binary, like every Linux system
 		$this->opened_stream = null;
 
 		parse_str(parse_url($url, PHP_URL_QUERY), $this->dir_url_params);
 
-		if (!is_null($overwrite_new) || !($stat = static::url_stat($path,STREAM_URL_STAT_QUIET)) || $mode[0] == 'x')	// file not found or file should NOT exist
+		if (!is_null($overwrite_new) || !($stat = static::url_stat($path, STREAM_URL_STAT_QUIET)) || $mode[0] == 'x')	// file not found or file should NOT exist
 		{
-			if ($mode[0] == 'r' ||	// does $mode require the file to exist (r,r+)
-				$mode[0] == 'x' && $stat ||	// or file should not exist, but does
-				!($dir_stat=static::url_stat($dir,STREAM_URL_STAT_QUIET)) ||	// or parent dir does not exist																																			create it
-				!Vfs::check_access($dir,Vfs::WRITABLE,$dir_stat))	// or we are not allowed to 																																			create it
+			if ($mode[0] == 'r' || // does $mode require the file to exist (r,r+)
+				$mode[0] == 'x' && $stat || // or file should not exist, but does
+				!($dir_stat = static::url_stat($dir, STREAM_URL_STAT_QUIET)) || // or parent dir does not exist																																			create it
+				!Vfs::check_access($dir, Vfs::WRITABLE, $dir_stat))	// or we are not allowed to 																																			create it
 			{
 				self::_remove_password($url);
 				if (self::LOG_LEVEL) error_log(__METHOD__."($url,$mode,$options) file does not exist or can not be created!");
-				if (($options & STREAM_REPORT_ERRORS))
+				if (($options&STREAM_REPORT_ERRORS))
 				{
-					trigger_error(__METHOD__."($url,$mode,$options) file does not exist or can not be created!",E_USER_WARNING);
+					trigger_error(__METHOD__."($url,$mode,$options) file does not exist or can not be created!", E_USER_WARNING);
 				}
 				$this->opened_stream = $this->opened_path = $this->opened_mode = null;
 				return false;
@@ -233,7 +233,7 @@ 
 				'fs_name' => self::limit_filename(Vfs::basename($path)),
 				'fs_dir'  => $dir_stat['ino'],
 				// we use the mode of the dir, so files in group dirs stay accessible by all members
-				'fs_mode' => $dir_stat['mode'] & 0666,
+				'fs_mode' => $dir_stat['mode']&0666,
 				// for the uid we use the uid of the dir if not 0=root or the current user otherwise
 				'fs_uid'  => $dir_stat['uid'] ? $dir_stat['uid'] : Vfs::$user,
 				// we allways use the group of the dir
@@ -241,11 +241,11 @@ 
 				'fs_created'  => self::_pdo_timestamp(time()),
 				'fs_modified' => self::_pdo_timestamp(time()),
 				'fs_creator'  => Vfs::$user,
-				'fs_mime'     => 'application/octet-stream',	// required NOT NULL!
+				'fs_mime'     => 'application/octet-stream', // required NOT NULL!
 				'fs_size'     => 0,
 				'fs_active'   => self::_pdo_boolean(true),
 			);
-			if ($overwrite_new) $values = array_merge($values,$overwrite_new);
+			if ($overwrite_new) $values = array_merge($values, $overwrite_new);
 			if (!$stmt->execute($values) || !($this->opened_fs_id = self::$pdo->lastInsertId('egw_sqlfs_fs_id_seq')))
 			{
 				$this->opened_stream = $this->opened_path = $this->opened_mode = null;
@@ -258,35 +258,35 @@ 
 				$this->opened_stream = tmpfile();
 			}
 			// create the hash-dirs, if they not yet exist
-			elseif(!file_exists($fs_dir=Vfs::dirname(self::_fs_path($this->opened_fs_id))))
+			elseif (!file_exists($fs_dir = Vfs::dirname(self::_fs_path($this->opened_fs_id))))
 			{
 				$umaskbefore = umask();
 				if (self::LOG_LEVEL > 1) error_log(__METHOD__." about to call mkdir for $fs_dir # Present UMASK:".decoct($umaskbefore)." called from:".function_backtrace());
-				self::mkdir_recursive($fs_dir,0700,true);
+				self::mkdir_recursive($fs_dir, 0700, true);
 			}
 		}
 		// check if opend file is a directory
-		elseif($stat && ($stat['mode'] & self::MODE_DIR) == self::MODE_DIR)
+		elseif ($stat && ($stat['mode']&self::MODE_DIR) == self::MODE_DIR)
 		{
 				if (self::LOG_LEVEL) error_log(__METHOD__."($url,$mode,$options) Is a directory!");
-				if (($options & STREAM_REPORT_ERRORS))
+				if (($options&STREAM_REPORT_ERRORS))
 				{
-					trigger_error(__METHOD__."($url,$mode,$options) Is a directory!",E_USER_WARNING);
+					trigger_error(__METHOD__."($url,$mode,$options) Is a directory!", E_USER_WARNING);
 				}
 				$this->opened_stream = $this->opened_path = $this->opened_mode = null;
 				return false;
 		}
 		else
 		{
-			if ($mode == 'r' && !Vfs::check_access($url,Vfs::READABLE ,$stat) ||// we are not allowed to read
-				$mode != 'r' && !Vfs::check_access($url,Vfs::WRITABLE,$stat))	// or edit it
+			if ($mode == 'r' && !Vfs::check_access($url, Vfs::READABLE, $stat) || // we are not allowed to read
+				$mode != 'r' && !Vfs::check_access($url, Vfs::WRITABLE, $stat))	// or edit it
 			{
 				self::_remove_password($url);
 				$op = $mode == 'r' ? 'read' : 'edited';
 				if (self::LOG_LEVEL) error_log(__METHOD__."($url,$mode,$options) file can not be $op!");
-				if (($options & STREAM_REPORT_ERRORS))
+				if (($options&STREAM_REPORT_ERRORS))
 				{
-					trigger_error(__METHOD__."($url,$mode,$options) file can not be $op!",E_USER_WARNING);
+					trigger_error(__METHOD__."($url,$mode,$options) file can not be $op!", E_USER_WARNING);
 				}
 				$this->opened_stream = $this->opened_path = $this->opened_mode = null;
 				return false;
@@ -295,9 +295,9 @@ 
 
 			if ($this->operation == self::STORE2DB)
 			{
-				$stmt = self::$pdo->prepare($sql='SELECT fs_content FROM '.self::TABLE.' WHERE fs_id=?');
+				$stmt = self::$pdo->prepare($sql = 'SELECT fs_content FROM '.self::TABLE.' WHERE fs_id=?');
 				$stmt->execute(array($stat['ino']));
-				$stmt->bindColumn(1,$this->opened_stream,\PDO::PARAM_LOB);
+				$stmt->bindColumn(1, $this->opened_stream, \PDO::PARAM_LOB);
 				$stmt->fetch(\PDO::FETCH_BOUND);
 				// hack to work around a current php bug (http://bugs.php.net/bug.php?id=40913)
 				// PDOStatement::bindColumn(,,\PDO::PARAM_LOB) is not working for MySQL, content is returned as string :-(
@@ -316,7 +316,7 @@ 
 		if ($this->operation == self::STORE2FS)
 		{
 			if (self::LOG_LEVEL > 1) error_log(__METHOD__." fopen (may create a directory? mkdir) ($this->opened_fs_id,$mode,$options)");
-			if (!($this->opened_stream = fopen(self::_fs_path($this->opened_fs_id),$mode)) && $new_file)
+			if (!($this->opened_stream = fopen(self::_fs_path($this->opened_fs_id), $mode)) && $new_file)
 			{
 				// delete db entry again, if we are not able to open a new(!) file
 				unset($stmt);
@@ -326,7 +326,7 @@ 
 		}
 		if ($mode[0] == 'a')	// append modes: a, a+
 		{
-			$this->stream_seek(0,SEEK_END);
+			$this->stream_seek(0, SEEK_END);
 		}
 		if (!is_resource($this->opened_stream)) error_log(__METHOD__."($url,$mode,$options) NO stream, returning false!");
 
@@ -338,7 +338,7 @@ 
 	 *
 	 * You must release any resources that were locked or allocated by the stream.
 	 */
-	function stream_close ( )
+	function stream_close( )
 	{
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."()");
 
@@ -349,7 +349,7 @@ 
 
 		if ($this->opened_mode != 'r')
 		{
-			$this->stream_seek(0,SEEK_END);
+			$this->stream_seek(0, SEEK_END);
 
 			// we need to update the mime-type, size and content (if STORE2DB)
 			$values = array(
@@ -372,10 +372,10 @@ 
 			else
 			{
 				$stmt = self::$pdo->prepare('UPDATE '.self::TABLE.' SET fs_size=:fs_size,fs_mime=:fs_mime,fs_modifier=:fs_modifier,fs_modified=:fs_modified,fs_content=:fs_content WHERE fs_id=:fs_id');
-				$this->stream_seek(0,SEEK_SET);	// rewind to the start
-				foreach($values as $name => &$value)
+				$this->stream_seek(0, SEEK_SET); // rewind to the start
+				foreach ($values as $name => &$value)
 				{
-					$stmt->bindParam($name,$value);
+					$stmt->bindParam($name, $value);
 				}
 				$stmt->bindParam('fs_content', $this->opened_stream, \PDO::PARAM_LOB);
 				if (!($ret = $stmt->execute()))
@@ -408,13 +408,13 @@ 
 	 * @param int $count
 	 * @return string/false up to count bytes read or false on EOF
 	 */
-	function stream_read ( $count )
+	function stream_read($count)
 	{
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($count) pos=$this->opened_pos");
 
 		if (is_resource($this->opened_stream))
 		{
-			return fread($this->opened_stream,$count);
+			return fread($this->opened_stream, $count);
 		}
 		return false;
 	}
@@ -430,13 +430,13 @@ 
 	 * @param string $data
 	 * @return integer
 	 */
-	function stream_write ( $data )
+	function stream_write($data)
 	{
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($data)");
 
 		if (is_resource($this->opened_stream))
 		{
-			return fwrite($this->opened_stream,$data);
+			return fwrite($this->opened_stream, $data);
 		}
 		return false;
 	}
@@ -453,7 +453,7 @@ 
   	 *
  	 * @return boolean true if the read/write position is at the end of the stream and no more data availible, false otherwise
  	 */
-	function stream_eof ( )
+	function stream_eof( )
 	{
 		if (is_resource($this->opened_stream))
 		{
@@ -467,7 +467,7 @@ 
 	 *
 	 * @return integer current read/write position of the stream
 	 */
- 	function stream_tell ( )
+ 	function stream_tell( )
  	{
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."()");
 
@@ -490,13 +490,13 @@ 
  	 * 							SEEK_END - 2 - Set position to end-of-file plus offset. (To move to a position before the end-of-file, you need to pass a negative value in offset.)
  	 * @return boolean TRUE if the position was updated, FALSE otherwise.
  	 */
-	function stream_seek ( $offset, $whence )
+	function stream_seek($offset, $whence)
 	{
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($offset,$whence)");
 
 		if (is_resource($this->opened_stream))
 		{
-			return !fseek($this->opened_stream,$offset,$whence);	// fseek returns 0 on success and -1 on failure
+			return !fseek($this->opened_stream, $offset, $whence); // fseek returns 0 on success and -1 on failure
 		}
 		return false;
 	}
@@ -508,7 +508,7 @@ 
 	 *
 	 * @return booelan TRUE if the cached data was successfully stored (or if there was no data to store), or FALSE if the data could not be stored.
 	 */
-	function stream_flush ( )
+	function stream_flush( )
 	{
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."()");
 
@@ -533,11 +533,11 @@ 
 	 *
 	 * @return array containing the same values as appropriate for the stream.
 	 */
-	function stream_stat ( )
+	function stream_stat( )
 	{
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($this->opened_path)");
 
-		return $this->url_stat($this->opened_path,0);
+		return $this->url_stat($this->opened_path, 0);
 	}
 
 	/**
@@ -549,27 +549,27 @@ 
 	 * @param string $url
 	 * @return boolean TRUE on success or FALSE on failure
 	 */
-	static function unlink ( $url, $parent_stat=null )
+	static function unlink($url, $parent_stat = null)
 	{
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url)");
 
-		$path = Vfs::parse_url($url,PHP_URL_PATH);
+		$path = Vfs::parse_url($url, PHP_URL_PATH);
 
 		// need to get parent stat from Sqlfs, not Vfs
 		if (!isset($parent_stat)) $parent_stat = static::url_stat(Vfs::dirname($path), STREAM_URL_STAT_LINK);
 
-		if (!$parent_stat || !($stat = self::url_stat($path,STREAM_URL_STAT_LINK)) ||
-			!Vfs::check_access(Vfs::dirname($path),Vfs::WRITABLE, $parent_stat))
+		if (!$parent_stat || !($stat = self::url_stat($path, STREAM_URL_STAT_LINK)) ||
+			!Vfs::check_access(Vfs::dirname($path), Vfs::WRITABLE, $parent_stat))
 		{
 			self::_remove_password($url);
 			if (self::LOG_LEVEL) error_log(__METHOD__."($url) permission denied!");
-			return false;	// no permission or file does not exist
+			return false; // no permission or file does not exist
 		}
 		if ($stat['mime'] == self::DIR_MIME_TYPE)
 		{
 			self::_remove_password($url);
 			if (self::LOG_LEVEL) error_log(__METHOD__."($url) is NO file!");
-			return false;	// no permission or file does not exist
+			return false; // no permission or file does not exist
 		}
 		$stmt = self::$pdo->prepare('DELETE FROM '.self::TABLE.' WHERE fs_id=:fs_id');
 		unset(self::$stat_cache[$path]);
@@ -577,7 +577,7 @@ 
 		if (($ret = $stmt->execute(array('fs_id' => $stat['ino']))))
 		{
 			if (self::url2operation($url) == self::STORE2FS &&
-				($stat['mode'] & self::MODE_LINK) != self::MODE_LINK)
+				($stat['mode']&self::MODE_LINK) != self::MODE_LINK)
 			{
 				unlink(self::_fs_path($stat['ino']));
 			}
@@ -601,13 +601,13 @@ 
 	 * @param string $url_to
 	 * @return boolean TRUE on success or FALSE on failure
 	 */
-	static function rename ( $url_from, $url_to)
+	static function rename($url_from, $url_to)
 	{
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url_from,$url_to)");
 
-		$path_from = Vfs::parse_url($url_from,PHP_URL_PATH);
+		$path_from = Vfs::parse_url($url_from, PHP_URL_PATH);
 		$from_dir = Vfs::dirname($path_from);
-		$path_to = Vfs::parse_url($url_to,PHP_URL_PATH);
+		$path_to = Vfs::parse_url($url_to, PHP_URL_PATH);
 		$to_dir = Vfs::dirname($path_to);
 		$operation = self::url2operation($url_from);
 
@@ -618,14 +618,14 @@ 
 			self::_remove_password($url_from);
 			self::_remove_password($url_to);
 			if (self::LOG_LEVEL) error_log(__METHOD__."($url_from,$url_to): $path_from permission denied!");
-			return false;	// no permission or file does not exist
+			return false; // no permission or file does not exist
 		}
 		if (!Vfs::check_access($to_dir, Vfs::WRITABLE, $to_dir_stat = static::url_stat($to_dir, 0)))
 		{
 			self::_remove_password($url_from);
 			self::_remove_password($url_to);
 			if (self::LOG_LEVEL) error_log(__METHOD__."($url_from,$url_to): $path_to permission denied!");
-			return false;	// no permission or parent-dir does not exist
+			return false; // no permission or parent-dir does not exist
 		}
 		// the filesystem stream-wrapper does NOT allow to rename files to directories, as this makes problems
 		// for our vfs too, we abort here with an error, like the filesystem one does
@@ -636,10 +636,10 @@ 
 			self::_remove_password($url_to);
 			$is_dir = $to_stat['mime'] === self::DIR_MIME_TYPE ? 'a' : 'no';
 			if (self::LOG_LEVEL) error_log(__METHOD__."($url_to,$url_from) $path_to is $is_dir directory!");
-			return false;	// no permission or file does not exist
+			return false; // no permission or file does not exist
 		}
 		// if destination file already exists, delete it
-		if ($to_stat && !static::unlink($url_to,$operation))
+		if ($to_stat && !static::unlink($url_to, $operation))
 		{
 			self::_remove_password($url_to);
 			if (self::LOG_LEVEL) error_log(__METHOD__."($url_to,$url_from) can't unlink existing $url_to!");
@@ -660,7 +660,7 @@ 
 
 		// check if extension changed and update mime-type in that case (as we currently determine mime-type by it's extension!)
 		// fixes eg. problems with MsWord storing file with .tmp extension and then renaming to .doc
-		if ($ok && ($new_mime = Vfs::mime_content_type($url_to,true)) != Vfs::mime_content_type($url_to))
+		if ($ok && ($new_mime = Vfs::mime_content_type($url_to, true)) != Vfs::mime_content_type($url_to))
 		{
 			//echo "<p>Vfs::nime_content_type($url_to,true) = $new_mime</p>\n";
 			$stmt = self::$pdo->prepare('UPDATE '.self::TABLE.' SET fs_mime=:fs_mime WHERE fs_id=:fs_id');
@@ -676,9 +676,9 @@ 
 	/**
 	 * due to problems with recursive directory creation, we have our own here
 	 */
-	protected static function mkdir_recursive($pathname, $mode, $depth=0)
+	protected static function mkdir_recursive($pathname, $mode, $depth = 0)
 	{
-		$maxdepth=10;
+		$maxdepth = 10;
 		$depth2propagate = (int)$depth + 1;
 		if ($depth2propagate > $maxdepth) return is_dir($pathname);
     	is_dir(Vfs::dirname($pathname)) || self::mkdir_recursive(Vfs::dirname($pathname), $mode, $depth2propagate);
@@ -696,47 +696,47 @@ 
 	 * @param int $options Posible values include STREAM_REPORT_ERRORS and STREAM_MKDIR_RECURSIVE
 	 * @return boolean TRUE on success or FALSE on failure
 	 */
-	static function mkdir ( $url, $mode, $options )
+	static function mkdir($url, $mode, $options)
 	{
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url,$mode,$options)");
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__." called from:".function_backtrace());
-		$path = Vfs::parse_url($url,PHP_URL_PATH);
+		$path = Vfs::parse_url($url, PHP_URL_PATH);
 
-		if (self::url_stat($path,STREAM_URL_STAT_QUIET))
+		if (self::url_stat($path, STREAM_URL_STAT_QUIET))
 		{
 			self::_remove_password($url);
 			if (self::LOG_LEVEL) error_log(__METHOD__."('$url',$mode,$options) already exist!");
-			if (!($options & STREAM_REPORT_ERRORS))
+			if (!($options&STREAM_REPORT_ERRORS))
 			{
 				//throw new Exception(__METHOD__."('$url',$mode,$options) already exist!");
-				trigger_error(__METHOD__."('$url',$mode,$options) already exist!",E_USER_WARNING);
+				trigger_error(__METHOD__."('$url',$mode,$options) already exist!", E_USER_WARNING);
 			}
 			return false;
 		}
 		$parent_path = Vfs::dirname($path);
-		if (($query = Vfs::parse_url($url,PHP_URL_QUERY))) $parent_path .= '?'.$query;
-		$parent = self::url_stat($parent_path,STREAM_URL_STAT_QUIET);
+		if (($query = Vfs::parse_url($url, PHP_URL_QUERY))) $parent_path .= '?'.$query;
+		$parent = self::url_stat($parent_path, STREAM_URL_STAT_QUIET);
 
 		// check if we should also create all non-existing path components and our parent does not exist,
 		// if yes call ourself recursive with the parent directory
-		if (($options & STREAM_MKDIR_RECURSIVE) && $parent_path != '/' && !$parent)
+		if (($options&STREAM_MKDIR_RECURSIVE) && $parent_path != '/' && !$parent)
 		{
 			if (self::LOG_LEVEL > 1) error_log(__METHOD__." creating parents: $parent_path, $mode");
-			if (!self::mkdir($parent_path,$mode,$options))
+			if (!self::mkdir($parent_path, $mode, $options))
 			{
 				return false;
 			}
-			$parent = self::url_stat($parent_path,0);
+			$parent = self::url_stat($parent_path, 0);
 		}
-		if (!$parent || !Vfs::check_access($parent_path,Vfs::WRITABLE,$parent))
+		if (!$parent || !Vfs::check_access($parent_path, Vfs::WRITABLE, $parent))
 		{
 			self::_remove_password($url);
 			if (self::LOG_LEVEL) error_log(__METHOD__."('$url',$mode,$options) permission denied!");
-			if (!($options & STREAM_REPORT_ERRORS))
+			if (!($options&STREAM_REPORT_ERRORS))
 			{
-				trigger_error(__METHOD__."('$url',$mode,$options) permission denied!",E_USER_WARNING);
+				trigger_error(__METHOD__."('$url',$mode,$options) permission denied!", E_USER_WARNING);
 			}
-			return false;	// no permission or file does not exist
+			return false; // no permission or file does not exist
 		}
 		unset(self::$stat_cache[$path]);
 		$stmt = self::$pdo->prepare('INSERT INTO '.self::TABLE.' (fs_name,fs_dir,fs_mode,fs_uid,fs_gid,fs_size,fs_mime,fs_created,fs_modified,fs_creator'.
@@ -757,9 +757,9 @@ 
 			// check if some other process created the directory parallel to us (sqlfs would gives SQL errors later!)
 			$new_fs_id = self::$pdo->lastInsertId('egw_sqlfs_fs_id_seq');
 
-			unset($stmt);	// free statement object, on some installs a new prepare fails otherwise!
+			unset($stmt); // free statement object, on some installs a new prepare fails otherwise!
 
-			$stmt = self::$pdo->prepare($q='SELECT COUNT(*) FROM '.self::TABLE.
+			$stmt = self::$pdo->prepare($q = 'SELECT COUNT(*) FROM '.self::TABLE.
 				' WHERE fs_dir=:fs_dir AND fs_active=:fs_active AND fs_name'.self::$case_sensitive_equal.':fs_name');
 			if ($stmt->execute(array(
 				'fs_dir'  => $parent['ino'],
@@ -783,25 +783,24 @@ 
 	 * @param int $options Possible values include STREAM_REPORT_ERRORS.
 	 * @return boolean TRUE on success or FALSE on failure.
 	 */
-	static function rmdir ( $url, $options )
+	static function rmdir($url, $options)
 	{
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url)");
 
-		$path = Vfs::parse_url($url,PHP_URL_PATH);
+		$path = Vfs::parse_url($url, PHP_URL_PATH);
 		$parent = Vfs::dirname($path);
 
-		if (!($stat = self::url_stat($path,0)) || $stat['mime'] != self::DIR_MIME_TYPE ||
-			!Vfs::check_access($parent, Vfs::WRITABLE, static::url_stat($parent,0)))
+		if (!($stat = self::url_stat($path, 0)) || $stat['mime'] != self::DIR_MIME_TYPE ||
+			!Vfs::check_access($parent, Vfs::WRITABLE, static::url_stat($parent, 0)))
 		{
 			self::_remove_password($url);
-			$err_msg = __METHOD__."($url,$options) ".(!$stat ? 'not found!' :
-				($stat['mime'] != self::DIR_MIME_TYPE ? 'not a directory!' : 'permission denied!'));
+			$err_msg = __METHOD__."($url,$options) ".(!$stat ? 'not found!' : ($stat['mime'] != self::DIR_MIME_TYPE ? 'not a directory!' : 'permission denied!'));
 			if (self::LOG_LEVEL) error_log($err_msg);
-			if (!($options & STREAM_REPORT_ERRORS))
+			if (!($options&STREAM_REPORT_ERRORS))
 			{
-				trigger_error($err_msg,E_USER_WARNING);
+				trigger_error($err_msg, E_USER_WARNING);
 			}
-			return false;	// no permission or file does not exist
+			return false; // no permission or file does not exist
 		}
 		$stmt = self::$pdo->prepare('SELECT COUNT(*) FROM '.self::TABLE.' WHERE fs_dir=?');
 		$stmt->execute(array($stat['ino']));
@@ -809,19 +808,19 @@ 
 		{
 			self::_remove_password($url);
 			if (self::LOG_LEVEL) error_log(__METHOD__."($url,$options) dir is not empty!");
-			if (!($options & STREAM_REPORT_ERRORS))
+			if (!($options&STREAM_REPORT_ERRORS))
 			{
-				trigger_error(__METHOD__."('$url',$options) dir is not empty!",E_USER_WARNING);
+				trigger_error(__METHOD__."('$url',$options) dir is not empty!", E_USER_WARNING);
 			}
 			return false;
 		}
 		unset(self::$stat_cache[$path]);
-		unset($stmt);	// free statement object, on some installs a new prepare fails otherwise!
+		unset($stmt); // free statement object, on some installs a new prepare fails otherwise!
 
 		$del_stmt = self::$pdo->prepare('DELETE FROM '.self::TABLE.' WHERE fs_id=?');
 		if (($ret = $del_stmt->execute(array($stat['ino']))))
 		{
-			self::eacl($path,null,false,$stat['ino']);	// remove all (=false) evtl. existing extended acl for that dir
+			self::eacl($path, null, false, $stat['ino']); // remove all (=false) evtl. existing extended acl for that dir
 			// delete props
 			unset($del_stmt);
 			$del_stmt = self::$pdo->prepare('DELETE FROM '.self::PROPS_TABLE.' WHERE fs_id=?');
@@ -837,25 +836,25 @@ 
 	 * @param int $time =null modification time (unix timestamp), default null = current time
 	 * @param int $atime =null access time (unix timestamp), default null = current time, not implemented in the vfs!
 	 */
-	static function touch($url,$time=null,$atime=null)
+	static function touch($url, $time = null, $atime = null)
 	{
-		unset($atime);	// not used
+		unset($atime); // not used
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url, $time)");
 
-		$path = Vfs::parse_url($url,PHP_URL_PATH);
+		$path = Vfs::parse_url($url, PHP_URL_PATH);
 
-		if (!($stat = self::url_stat($path,STREAM_URL_STAT_QUIET)))
+		if (!($stat = self::url_stat($path, STREAM_URL_STAT_QUIET)))
 		{
 			// file does not exist --> create an empty one
-			if (!($f = fopen(self::SCHEME.'://default'.$path,'w')) || !fclose($f))
+			if (!($f = fopen(self::SCHEME.'://default'.$path, 'w')) || !fclose($f))
 			{
 				return false;
 			}
 			if (is_null($time))
 			{
-				return true;	// new (empty) file created with current mod time
+				return true; // new (empty) file created with current mod time
 			}
-			$stat = self::url_stat($path,0);
+			$stat = self::url_stat($path, 0);
 		}
 		unset(self::$stat_cache[$path]);
 		$stmt = self::$pdo->prepare('UPDATE '.self::TABLE.' SET fs_modified=:fs_modified,fs_modifier=:fs_modifier WHERE fs_id=:fs_id');
@@ -874,39 +873,39 @@ 
 	 * @param int $owner
 	 * @return boolean
 	 */
-	static function chown($url,$owner)
+	static function chown($url, $owner)
 	{
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url,$owner)");
 
-		$path = Vfs::parse_url($url,PHP_URL_PATH);
+		$path = Vfs::parse_url($url, PHP_URL_PATH);
 
-		if (!($stat = self::url_stat($path,0)))
+		if (!($stat = self::url_stat($path, 0)))
 		{
 			if (self::LOG_LEVEL) error_log(__METHOD__."($url,$owner) no such file or directory!");
-			trigger_error("No such file or directory $url !",E_USER_WARNING);
+			trigger_error("No such file or directory $url !", E_USER_WARNING);
 			return false;
 		}
 		if (!Vfs::$is_root)
 		{
 			if (self::LOG_LEVEL) error_log(__METHOD__."($url,$owner) only root can do that!");
-			trigger_error("Only root can do that!",E_USER_WARNING);
+			trigger_error("Only root can do that!", E_USER_WARNING);
 			return false;
 		}
 		if ($owner < 0 || $owner && !$GLOBALS['egw']->accounts->id2name($owner))	// not a user (0 == root)
 		{
 			if (self::LOG_LEVEL) error_log(__METHOD__."($url,$owner) unknown (numeric) user id!");
-			trigger_error(__METHOD__."($url,$owner) Unknown (numeric) user id!",E_USER_WARNING);
+			trigger_error(__METHOD__."($url,$owner) Unknown (numeric) user id!", E_USER_WARNING);
 			//throw new Exception(__METHOD__."($url,$owner) Unknown (numeric) user id!");
 			return false;
 		}
 		$stmt = self::$pdo->prepare('UPDATE '.self::TABLE.' SET fs_uid=:fs_uid WHERE fs_id=:fs_id');
 
 		// update stat-cache
-		if ($path != '/' && substr($path,-1) == '/') $path = substr($path, 0, -1);
+		if ($path != '/' && substr($path, -1) == '/') $path = substr($path, 0, -1);
 		self::$stat_cache[$path]['fs_uid'] = $owner;
 
 		return $stmt->execute(array(
-			'fs_uid' => (int) $owner,
+			'fs_uid' => (int)$owner,
 			'fs_id' => $stat['ino'],
 		));
 	}
@@ -918,36 +917,36 @@ 
 	 * @param int $owner
 	 * @return boolean
 	 */
-	static function chgrp($url,$owner)
+	static function chgrp($url, $owner)
 	{
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url,$owner)");
 
-		$path = Vfs::parse_url($url,PHP_URL_PATH);
+		$path = Vfs::parse_url($url, PHP_URL_PATH);
 
-		if (!($stat = self::url_stat($path,0)))
+		if (!($stat = self::url_stat($path, 0)))
 		{
 			if (self::LOG_LEVEL) error_log(__METHOD__."($url,$owner) no such file or directory!");
-			trigger_error("No such file or directory $url !",E_USER_WARNING);
+			trigger_error("No such file or directory $url !", E_USER_WARNING);
 			return false;
 		}
-		if (!Vfs::has_owner_rights($path,$stat))
+		if (!Vfs::has_owner_rights($path, $stat))
 		{
 			if (self::LOG_LEVEL) error_log(__METHOD__."($url,$owner) only owner or root can do that!");
-			trigger_error("Only owner or root can do that!",E_USER_WARNING);
+			trigger_error("Only owner or root can do that!", E_USER_WARNING);
 			return false;
 		}
-		if ($owner < 0) $owner = -$owner;	// sqlfs uses a positiv group id's!
+		if ($owner < 0) $owner = -$owner; // sqlfs uses a positiv group id's!
 
 		if ($owner && !$GLOBALS['egw']->accounts->id2name(-$owner))	// not a group
 		{
 			if (self::LOG_LEVEL) error_log(__METHOD__."($url,$owner) unknown (numeric) group id!");
-			trigger_error("Unknown (numeric) group id!",E_USER_WARNING);
+			trigger_error("Unknown (numeric) group id!", E_USER_WARNING);
 			return false;
 		}
 		$stmt = self::$pdo->prepare('UPDATE '.self::TABLE.' SET fs_gid=:fs_gid WHERE fs_id=:fs_id');
 
 		// update stat-cache
-		if ($path != '/' && substr($path,-1) == '/') $path = substr($path, 0, -1);
+		if ($path != '/' && substr($path, -1) == '/') $path = substr($path, 0, -1);
 		self::$stat_cache[$path]['fs_gid'] = $owner;
 
 		return $stmt->execute(array(
@@ -963,38 +962,38 @@ 
 	 * @param int $mode
 	 * @return boolean
 	 */
-	static function chmod($url,$mode)
+	static function chmod($url, $mode)
 	{
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url, $mode)");
 
-		$path = Vfs::parse_url($url,PHP_URL_PATH);
+		$path = Vfs::parse_url($url, PHP_URL_PATH);
 
-		if (!($stat = self::url_stat($path,0)))
+		if (!($stat = self::url_stat($path, 0)))
 		{
 			if (self::LOG_LEVEL) error_log(__METHOD__."($url, $mode) no such file or directory!");
-			trigger_error("No such file or directory $url !",E_USER_WARNING);
+			trigger_error("No such file or directory $url !", E_USER_WARNING);
 			return false;
 		}
-		if (!Vfs::has_owner_rights($path,$stat))
+		if (!Vfs::has_owner_rights($path, $stat))
 		{
 			if (self::LOG_LEVEL) error_log(__METHOD__."($url, $mode) only owner or root can do that!");
-			trigger_error("Only owner or root can do that!",E_USER_WARNING);
+			trigger_error("Only owner or root can do that!", E_USER_WARNING);
 			return false;
 		}
 		if (!is_numeric($mode))	// not a mode
 		{
 			if (self::LOG_LEVEL) error_log(__METHOD__."($url, $mode) no (numeric) mode!");
-			trigger_error("No (numeric) mode!",E_USER_WARNING);
+			trigger_error("No (numeric) mode!", E_USER_WARNING);
 			return false;
 		}
 		$stmt = self::$pdo->prepare('UPDATE '.self::TABLE.' SET fs_mode=:fs_mode WHERE fs_id=:fs_id');
 
 		// update stat cache
-		if ($path != '/' && substr($path,-1) == '/') $path = substr($path, 0, -1);
-		self::$stat_cache[$path]['fs_mode'] = ((int) $mode) & 0777;
+		if ($path != '/' && substr($path, -1) == '/') $path = substr($path, 0, -1);
+		self::$stat_cache[$path]['fs_mode'] = ((int)$mode)&0777;
 
 		return $stmt->execute(array(
-			'fs_mode' => ((int) $mode) & 0777,		// we dont store the file and dir bits, give int overflow!
+			'fs_mode' => ((int)$mode)&0777, // we dont store the file and dir bits, give int overflow!
 			'fs_id' => $stat['ino'],
 		));
 	}
@@ -1007,15 +1006,15 @@ 
 	 * @param int $options
 	 * @return booelan
 	 */
-	function dir_opendir ( $url, $options )
+	function dir_opendir($url, $options)
 	{
 		$this->opened_dir = null;
 
-		$path = Vfs::parse_url($url,PHP_URL_PATH);
+		$path = Vfs::parse_url($url, PHP_URL_PATH);
 
-		if (!($stat = self::url_stat($url,0)) || 		// dir not found
-			$stat['mime'] != self::DIR_MIME_TYPE ||		// no dir
-			!Vfs::check_access($url,Vfs::EXECUTABLE|Vfs::READABLE,$stat))	// no access
+		if (!($stat = self::url_stat($url, 0)) || // dir not found
+			$stat['mime'] != self::DIR_MIME_TYPE || // no dir
+			!Vfs::check_access($url, Vfs::EXECUTABLE|Vfs::READABLE, $stat))	// no access
 		{
 			self::_remove_password($url);
 			$msg = $stat['mime'] != self::DIR_MIME_TYPE ? "$url is no directory" : 'permission denied';
@@ -1034,13 +1033,13 @@ 
 		$stmt->setFetchMode(\PDO::FETCH_ASSOC);
 		if ($stmt->execute(array($stat['ino'])))
 		{
-			foreach($stmt as $file)
+			foreach ($stmt as $file)
 			{
 				$this->opened_dir[] = $file['fs_name'];
-				self::$stat_cache[Vfs::concat($path,$file['fs_name'])] = $file;
+				self::$stat_cache[Vfs::concat($path, $file['fs_name'])] = $file;
 			}
 		}
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url,$options): ".implode(', ',$this->opened_dir));
+		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url,$options): ".implode(', ', $this->opened_dir));
 		reset($this->opened_dir);
 
 		return true;
@@ -1073,26 +1072,26 @@ 
 	 * @param boolean $eacl_access =null allows extending classes to pass the value of their check_extended_acl() method (no lsb!)
 	 * @return array
 	 */
-	static function url_stat ( $url, $flags, $eacl_access=null )
+	static function url_stat($url, $flags, $eacl_access = null)
 	{
-		static $max_subquery_depth=null;
+		static $max_subquery_depth = null;
 		if (is_null($max_subquery_depth))
 		{
 			$max_subquery_depth = $GLOBALS['egw_info']['server']['max_subquery_depth'];
-			if (!$max_subquery_depth) $max_subquery_depth = 7;	// setting current default of 7, if nothing set
+			if (!$max_subquery_depth) $max_subquery_depth = 7; // setting current default of 7, if nothing set
 		}
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."('$url',$flags,$eacl_access)");
 
-		$path = Vfs::parse_url($url,PHP_URL_PATH);
+		$path = Vfs::parse_url($url, PHP_URL_PATH);
 
 		// webdav adds a trailing slash to dirs, which causes url_stat to NOT find the file otherwise
-		if ($path != '/' && substr($path,-1) == '/')
+		if ($path != '/' && substr($path, -1) == '/')
 		{
-			$path = substr($path,0,-1);
+			$path = substr($path, 0, -1);
 		}
 		if (empty($path))
 		{
-			return false;	// is invalid and gives sql error
+			return false; // is invalid and gives sql error
 		}
 		// check if we already have the info from the last dir_open call, as the old vfs reads it anyway from the db
 		if (self::$stat_cache && isset(self::$stat_cache[$path]) && (is_null($eacl_access) || self::$stat_cache[$path] !== false))
@@ -1107,28 +1106,28 @@ 
 		$base_query = 'SELECT fs_id,fs_name,fs_mode,fs_uid,fs_gid,fs_size,fs_mime,fs_created,fs_modified'.self::$extra_columns.
 			' FROM '.self::TABLE.' WHERE fs_active='.self::_pdo_boolean(true).
 			' AND fs_name'.self::$case_sensitive_equal.'? AND fs_dir=';
-		$parts = explode('/',$path);
+		$parts = explode('/', $path);
 
 		// if we have extendes acl access to the url, we dont need and can NOT include the sql for the readable check
 		if (is_null($eacl_access))
 		{
-			$eacl_access = self::check_extended_acl($path,Vfs::READABLE);	// should be static::check_extended_acl, but no lsb!
+			$eacl_access = self::check_extended_acl($path, Vfs::READABLE); // should be static::check_extended_acl, but no lsb!
 		}
 
 		try {
-			foreach($parts as $n => $name)
+			foreach ($parts as $n => $name)
 			{
 				if ($n == 0)
 				{
-					$query = (int) ($path != '/');	// / always has fs_id == 1, no need to query it ($path=='/' needs fs_dir=0!)
+					$query = (int)($path != '/'); // / always has fs_id == 1, no need to query it ($path=='/' needs fs_dir=0!)
 				}
-				elseif ($n < count($parts)-1)
+				elseif ($n < count($parts) - 1)
 				{
 					// MySQL 5.0 has a nesting limit for subqueries
 					// --> we replace the so far cumulated subqueries with their result
 					// no idea about the other DBMS, but this does NOT hurt ...
 					// --> depth limit of subqueries is now dynamicly decremented in catch
-					if ($n > 1 && !(($n-1) % $max_subquery_depth) && !($query = self::$pdo->query($query)->fetchColumn()))
+					if ($n > 1 && !(($n - 1) % $max_subquery_depth) && !($query = self::$pdo->query($query)->fetchColumn()))
 					{
 						if (self::LOG_LEVEL > 1)
 						{
@@ -1155,7 +1154,7 @@ 
 				}
 				else
 				{
-					$query = str_replace('fs_name'.self::$case_sensitive_equal.'?','fs_name'.self::$case_sensitive_equal.self::$pdo->quote($name),$base_query).'('.$query.')';
+					$query = str_replace('fs_name'.self::$case_sensitive_equal.'?', 'fs_name'.self::$case_sensitive_equal.self::$pdo->quote($name), $base_query).'('.$query.')';
 				}
 			}
 			if (self::LOG_LEVEL > 2) $query = '/* '.__METHOD__."($url,$flags,$eacl_access)".' */ '.$query;
@@ -1181,7 +1180,7 @@ 
 			$GLOBALS['egw_info']['server']['max_subquery_depth'] = --$max_subquery_depth;
 			error_log(__METHOD__."() decremented max_subquery_depth to $max_subquery_depth");
 			Api\Config::save_value('max_subquery_depth', $max_subquery_depth, 'phpgwapi');
-			if (method_exists($GLOBALS['egw'],'invalidate_session_cache')) $GLOBALS['egw']->invalidate_session_cache();
+			if (method_exists($GLOBALS['egw'], 'invalidate_session_cache')) $GLOBALS['egw']->invalidate_session_cache();
 			return self::url_stat($url, $flags, $eacl_access);
 		}
 		self::$stat_cache[$path] = $info;
@@ -1197,18 +1196,18 @@ 
 	 */
 	protected static function _sql_readable()
 	{
-		static $sql_read_acl=null;
+		static $sql_read_acl = null;
 
 		if (is_null($sql_read_acl))
 		{
-			foreach($GLOBALS['egw']->accounts->memberships(Vfs::$user,true) as $gid)
+			foreach ($GLOBALS['egw']->accounts->memberships(Vfs::$user, true) as $gid)
 			{
-				$memberships[] = abs($gid);	// sqlfs stores the gid's positiv
+				$memberships[] = abs($gid); // sqlfs stores the gid's positiv
 			}
 			// using octal numbers with mysql leads to funny results (select 384 & 0400 --> 384 not 256=0400)
 			// 256 = 0400, 32 = 040
 			$sql_read_acl = '((fs_mode & 4)=4 OR (fs_mode & 256)=256 AND fs_uid='.(int)Vfs::$user.
-				($memberships ? ' OR (fs_mode & 32)=32 AND fs_gid IN('.implode(',',$memberships).')' : '').')';
+				($memberships ? ' OR (fs_mode & 32)=32 AND fs_gid IN('.implode(',', $memberships).')' : '').')';
 			//error_log(__METHOD__."() Vfs::\$user=".array2string(Vfs::$user).' --> memberships='.array2string($memberships).' --> '.$sql_read_acl.($memberships?'':': '.function_backtrace()));
 		}
 		return $sql_read_acl;
@@ -1221,7 +1220,7 @@ 
 	 *
 	 * @return string
 	 */
-	function dir_readdir ( )
+	function dir_readdir( )
 	{
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."( )");
 
@@ -1240,7 +1239,7 @@ 
 	 *
 	 * @return boolean
 	 */
-	function dir_rewinddir ( )
+	function dir_rewinddir( )
 	{
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."( )");
 
@@ -1258,7 +1257,7 @@ 
 	 *
 	 * @return boolean
 	 */
-	function dir_closedir ( )
+	function dir_closedir( )
 	{
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."( )");
 
@@ -1279,7 +1278,7 @@ 
 	 */
 	static function readlink($path)
 	{
-		$link = !($lstat = self::url_stat($path,STREAM_URL_STAT_LINK)) || is_null($lstat['readlink']) ? false : $lstat['readlink'];
+		$link = !($lstat = self::url_stat($path, STREAM_URL_STAT_LINK)) || is_null($lstat['readlink']) ? false : $lstat['readlink'];
 
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."('$path') = $link");
 
@@ -1293,31 +1292,31 @@ 
 	 * @param string $link
 	 * @return boolean true on success false on error
 	 */
-	static function symlink($target,$link)
+	static function symlink($target, $link)
 	{
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."('$target','$link')");
 
-		if (self::url_stat($link,0))
+		if (self::url_stat($link, 0))
 		{
 			if (self::LOG_LEVEL > 0) error_log(__METHOD__."('$target','$link') $link exists, returning false!");
-			return false;	// $link already exists
+			return false; // $link already exists
 		}
 		if (!($dir = Vfs::dirname($link)) ||
-			!Vfs::check_access($dir,Vfs::WRITABLE,$dir_stat=static::url_stat($dir,0)))
+			!Vfs::check_access($dir, Vfs::WRITABLE, $dir_stat = static::url_stat($dir, 0)))
 		{
 			if (self::LOG_LEVEL > 0) error_log(__METHOD__."('$target','$link') returning false! (!is_writable('$dir'), dir_stat=".array2string($dir_stat).")");
-			return false;	// parent dir does not exist or is not writable
+			return false; // parent dir does not exist or is not writable
 		}
 		$query = 'INSERT INTO '.self::TABLE.' (fs_name,fs_dir,fs_mode,fs_uid,fs_gid,fs_created,fs_modified,fs_creator,fs_mime,fs_size,fs_link'.
 			') VALUES (:fs_name,:fs_dir,:fs_mode,:fs_uid,:fs_gid,:fs_created,:fs_modified,:fs_creator,:fs_mime,:fs_size,:fs_link)';
 		if (self::LOG_LEVEL > 2) $query = '/* '.__METHOD__.': '.__LINE__.' */ '.$query;
 		$stmt = self::$pdo->prepare($query);
-		unset(self::$stat_cache[Vfs::parse_url($link,PHP_URL_PATH)]);
+		unset(self::$stat_cache[Vfs::parse_url($link, PHP_URL_PATH)]);
 
 		return !!$stmt->execute(array(
 			'fs_name' => self::limit_filename(Vfs::basename($link)),
 			'fs_dir'  => $dir_stat['ino'],
-			'fs_mode' => ($dir_stat['mode'] & 0666),
+			'fs_mode' => ($dir_stat['mode']&0666),
 			'fs_uid'  => $dir_stat['uid'] ? $dir_stat['uid'] : Vfs::$user,
 			'fs_gid'  => $dir_stat['gid'],
 			'fs_created'  => self::_pdo_timestamp(time()),
@@ -1341,24 +1340,24 @@ 
 	 * @param int $check mode to check: one or more or'ed together of: 4 = read, 2 = write, 1 = executable
 	 * @return boolean
 	 */
-	static function check_extended_acl($url,$check)
+	static function check_extended_acl($url, $check)
 	{
-		$url_path = Vfs::parse_url($url,PHP_URL_PATH);
+		$url_path = Vfs::parse_url($url, PHP_URL_PATH);
 
 		if (is_null(self::$extended_acl))
 		{
 			self::_read_extended_acl();
 		}
 		$access = false;
-		foreach(self::$extended_acl as $path => $rights)
+		foreach (self::$extended_acl as $path => $rights)
 		{
-			if ($path == $url_path || substr($url_path,0,strlen($path)+1) == $path.'/')
+			if ($path == $url_path || substr($url_path, 0, strlen($path) + 1) == $path.'/')
 			{
-				$access = ($rights & $check) == $check;
+				$access = ($rights&$check) == $check;
 				break;
 			}
 		}
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url,$check) ".($access?"access granted by $path=$rights":'no access!!!'));
+		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url,$check) ".($access ? "access granted by $path=$rights" : 'no access!!!'));
 		return $access;
 	}
 
@@ -1370,14 +1369,14 @@ 
 	{
 		if ((self::$extended_acl = Api\Cache::getSession(self::EACL_APPNAME, 'extended_acl')))
 		{
-			return;		// ext. ACL read from session.
+			return; // ext. ACL read from session.
 		}
 		self::$extended_acl = array();
-		if (($rights = $GLOBALS['egw']->acl->get_all_location_rights(Vfs::$user,self::EACL_APPNAME)))
+		if (($rights = $GLOBALS['egw']->acl->get_all_location_rights(Vfs::$user, self::EACL_APPNAME)))
 		{
 			$pathes = self::id2path(array_keys($rights));
 		}
-		foreach($rights as $fs_id => $right)
+		foreach ($rights as $fs_id => $right)
 		{
 			$path = $pathes[$fs_id];
 			if (isset($path))
@@ -1386,8 +1385,8 @@ 
 			}
 		}
 		// sort by length descending, to allow more specific pathes to have precedence
-		uksort(self::$extended_acl, function($a,$b) {
-			return strlen($b)-strlen($a);
+		uksort(self::$extended_acl, function($a, $b) {
+			return strlen($b) - strlen($a);
 		});
 		Api\Cache::setSession(self::EACL_APPNAME, 'extended_acl', self::$extended_acl);
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__.'() '.array2string(self::$extended_acl));
@@ -1409,23 +1408,23 @@ 
 	 * @param int $fs_id =null fs_id to use, to not query it again (eg. because it's already deleted)
 	 * @return boolean true if acl is set/deleted, false on error
 	 */
-	static function eacl($path,$rights=null,$owner=null,$fs_id=null)
+	static function eacl($path, $rights = null, $owner = null, $fs_id = null)
 	{
 		if ($path[0] != '/')
 		{
-			$path = Vfs::parse_url($path,PHP_URL_PATH);
+			$path = Vfs::parse_url($path, PHP_URL_PATH);
 		}
 		if (is_null($fs_id))
 		{
-			if (!($stat = self::url_stat($path,0)))
+			if (!($stat = self::url_stat($path, 0)))
 			{
 				if (self::LOG_LEVEL) error_log(__METHOD__."($path,$rights,$owner,$fs_id) no such file or directory!");
-				return false;	// $path not found
+				return false; // $path not found
 			}
-			if (!Vfs::has_owner_rights($path,$stat))		// not group dir and user is eGW admin
+			if (!Vfs::has_owner_rights($path, $stat))		// not group dir and user is eGW admin
 			{
 				if (self::LOG_LEVEL) error_log(__METHOD__."($path,$rights,$owner,$fs_id) permission denied!");
-				return false;	// permission denied
+				return false; // permission denied
 			}
 			$fs_id = $stat['ino'];
 		}
@@ -1437,21 +1436,21 @@ 
 		{
 			// delete eacl
 			if (is_null($owner) || $owner == Vfs::$user ||
-				$owner < 0 && Vfs::$user && in_array($owner,$GLOBALS['egw']->accounts->memberships(Vfs::$user,true)))
+				$owner < 0 && Vfs::$user && in_array($owner, $GLOBALS['egw']->accounts->memberships(Vfs::$user, true)))
 			{
-				self::$extended_acl = null;	// force new read of eACL, as there could be multiple eACL for that path
+				self::$extended_acl = null; // force new read of eACL, as there could be multiple eACL for that path
 			}
-			$ret = $GLOBALS['egw']->acl->delete_repository(self::EACL_APPNAME,$fs_id,(int)$owner);
+			$ret = $GLOBALS['egw']->acl->delete_repository(self::EACL_APPNAME, $fs_id, (int)$owner);
 		}
 		else
 		{
 			if (isset(self::$extended_acl) && ($owner == Vfs::$user ||
-				$owner < 0 && Vfs::$user && in_array($owner,$GLOBALS['egw']->accounts->memberships(Vfs::$user,true))))
+				$owner < 0 && Vfs::$user && in_array($owner, $GLOBALS['egw']->accounts->memberships(Vfs::$user, true))))
 			{
 				// set rights for this class, if applicable
 				self::$extended_acl[$path] |= $rights;
 			}
-			$ret = $GLOBALS['egw']->acl->add_repository(self::EACL_APPNAME,$fs_id,$owner,$rights);
+			$ret = $GLOBALS['egw']->acl->add_repository(self::EACL_APPNAME, $fs_id, $owner, $rights);
 		}
 		if ($ret)
 		{
@@ -1474,10 +1473,10 @@ 
 		if (!($stat = static::url_stat($path, STREAM_URL_STAT_QUIET)))
 		{
 			error_log(__METHOD__.__LINE__.' '.array2string($path).' not found!');
-			return false;	// not found
+			return false; // not found
 		}
 		$eacls = array();
-		foreach($GLOBALS['egw']->acl->get_all_rights($stat['ino'],self::EACL_APPNAME) as $owner => $rights)
+		foreach ($GLOBALS['egw']->acl->get_all_rights($stat['ino'], self::EACL_APPNAME) as $owner => $rights)
 		{
 			$eacls[] = array(
 				'path'   => $path,
@@ -1488,7 +1487,7 @@ 
 		}
 		if (($path = Vfs::dirname($path)))
 		{
-			$eacls = array_merge((array)self::get_eacl($path),$eacls);
+			$eacls = array_merge((array)self::get_eacl($path), $eacls);
 		}
 		// sort by length descending, to show precedence
 		usort($eacls, function($a, $b) {
@@ -1513,9 +1512,9 @@ 
 		$ids = (array)$fs_ids;
 		$pathes = array();
 		// first check our stat-cache for the ids
-		foreach(self::$stat_cache as $path => $stat)
+		foreach (self::$stat_cache as $path => $stat)
 		{
-			if (($key = array_search($stat['fs_id'],$ids)) !== false)
+			if (($key = array_search($stat['fs_id'], $ids)) !== false)
 			{
 				$pathes[$stat['fs_id']] = $path;
 				unset($ids[$key]);
@@ -1529,7 +1528,7 @@ 
 		// now search via the database
 		if (count($ids) > 1) array_map(function(&$v) { $v = (int)$v; },$ids);
 		$query = 'SELECT fs_id,fs_dir,fs_name FROM '.self::TABLE.' WHERE fs_id'.
-			(count($ids) == 1 ? '='.(int)$ids[0] : ' IN ('.implode(',',$ids).')');
+			(count($ids) == 1 ? '='.(int)$ids[0] : ' IN ('.implode(',', $ids).')');
 		if (self::LOG_LEVEL > 2) $query = '/* '.__METHOD__.': '.__LINE__.' */ '.$query;
 
 		if (!is_object(self::$pdo))
@@ -1540,12 +1539,12 @@ 
 		$stmt->setFetchMode(\PDO::FETCH_ASSOC);
 		if (!$stmt->execute())
 		{
-			return false;	// not found
+			return false; // not found
 		}
 		$parents = array();
-		foreach($stmt as $row)
+		foreach ($stmt as $row)
 		{
-			if ($row['fs_dir'] > 1 && !in_array($row['fs_dir'],$parents))
+			if ($row['fs_dir'] > 1 && !in_array($row['fs_dir'], $parents))
 			{
 				$parents[] = $row['fs_dir'];
 			}
@@ -1555,14 +1554,14 @@ 
 
 		if ($parents && !($parents = self::id2path($parents)))
 		{
-			return false;	// parent not found, should never happen ...
+			return false; // parent not found, should never happen ...
 		}
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__." trying foreach with:".print_r($rows,true)."#");
-		foreach((array)$rows as $fs_id => $row)
+		if (self::LOG_LEVEL > 1) error_log(__METHOD__." trying foreach with:".print_r($rows, true)."#");
+		foreach ((array)$rows as $fs_id => $row)
 		{
 			$parent = $row['fs_dir'] > 1 ? $parents[$row['fs_dir']] : '';
 
-			$pathes[$fs_id] = $parent . '/' . $row['fs_name'];
+			$pathes[$fs_id] = $parent.'/'.$row['fs_name'];
 		}
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__.'('.array2string($fs_ids).')='.array2string($pathes));
 		return is_array($fs_ids) ? $pathes : array_shift($pathes);
@@ -1586,7 +1585,7 @@ 
 			$parts = explode('.', $name);
 			if ($parts > 1 && mb_strlen($extension = '.'.array_pop($parts)) <= $fs_name_precision)
 			{
-				$name = mb_substr(implode('.', $parts), 0, $fs_name_precision-mb_strlen($extension)).$extension;
+				$name = mb_substr(implode('.', $parts), 0, $fs_name_precision - mb_strlen($extension)).$extension;
 			}
 			else
 			{
@@ -1607,9 +1606,8 @@ 
 		$stat = array(
 			'ino'   => $info['fs_id'],
 			'name'  => $info['fs_name'],
-			'mode'  => $info['fs_mode'] |
-				($info['fs_mime'] == self::DIR_MIME_TYPE ? self::MODE_DIR :
-				($info['fs_mime'] == self::SYMLINK_MIME_TYPE ? self::MODE_LINK : self::MODE_FILE)),	// required by the stream wrapper
+			'mode'  => $info['fs_mode']|
+				($info['fs_mime'] == self::DIR_MIME_TYPE ? self::MODE_DIR : ($info['fs_mime'] == self::SYMLINK_MIME_TYPE ? self::MODE_LINK : self::MODE_FILE)), // required by the stream wrapper
 			'size'  => $info['fs_size'],
 			'uid'   => $info['fs_uid'],
 			'gid'   => $info['fs_gid'],
@@ -1649,7 +1647,7 @@ 
 	{
 		$egw_db = isset($GLOBALS['egw_setup']) ? $GLOBALS['egw_setup']->db : $GLOBALS['egw']->db;
 
-		switch($egw_db->Type)
+		switch ($egw_db->Type)
 		{
 			case 'mysqli':
 			case 'mysqlt':
@@ -1667,17 +1665,17 @@ 
 
 		$dsn = self::$pdo_type.':dbname='.$egw_db->Database.($host ? ';host='.$host.($egw_db->Port ? ';port='.$egw_db->Port : '') : '');
 		// check once if pdo extension and DB specific driver is loaded or can be loaded
-		static $pdo_available=null;
+		static $pdo_available = null;
 		if (is_null($pdo_available))
 		{
-			foreach(array('pdo','pdo_'.self::$pdo_type) as $ext)
+			foreach (array('pdo', 'pdo_'.self::$pdo_type) as $ext)
 			{
-				check_load_extension($ext,true);	// true = throw Exception
+				check_load_extension($ext, true); // true = throw Exception
 			}
 			$pdo_available = true;
 		}
 		// set client charset of the connection
-		switch(self::$pdo_type)
+		switch (self::$pdo_type)
 		{
 			case 'mysql':
 				$dsn .= ';charset=utf8';
@@ -1687,15 +1685,15 @@ 
 				break;
 		}
 		try {
-			self::$pdo = new \PDO($dsn,$egw_db->User,$egw_db->Password,array(
+			self::$pdo = new \PDO($dsn, $egw_db->User, $egw_db->Password, array(
 				\PDO::ATTR_ERRMODE=>\PDO::ERRMODE_EXCEPTION,
 			));
 		}
-		catch(\PDOException $e)
+		catch (\PDOException $e)
 		{
 			unset($e);
 			// Exception reveals password, so we ignore the exception and connect again without pw, to get the right exception without pw
-			self::$pdo = new \PDO($dsn,$egw_db->User,'$egw_db->Password');
+			self::$pdo = new \PDO($dsn, $egw_db->User, '$egw_db->Password');
 		}
 		if ($query)
 		{
@@ -1714,7 +1712,7 @@ 
 	{
 		if (is_numeric($time))
 		{
-			$time = date('Y-m-d H:i:s',$time);
+			$time = date('Y-m-d H:i:s', $time);
 		}
 		return $time;
 	}
@@ -1764,10 +1762,10 @@ 
 		{
 			if (is_object($GLOBALS['egw_setup']->db))	// if we run under setup, query the db for the files dir
 			{
-				$GLOBALS['egw_info']['server']['files_dir'] = $GLOBALS['egw_setup']->db->select('egw_config','config_value',array(
+				$GLOBALS['egw_info']['server']['files_dir'] = $GLOBALS['egw_setup']->db->select('egw_config', 'config_value', array(
 					'config_name' => 'files_dir',
 					'config_app' => 'phpgwapi',
-				),__LINE__,__FILE__)->fetchColumn();
+				), __LINE__, __FILE__)->fetchColumn();
 			}
 		}
 		if (!$GLOBALS['egw_info']['server']['files_dir'])
@@ -1776,14 +1774,14 @@ 
 		}
 		$hash = array();
 		$n = $id;
-		while(($n = (int) ($n / self::HASH_MAX)))
+		while (($n = (int)($n / self::HASH_MAX)))
 		{
-			$hash[] = sprintf('%02d',$n % self::HASH_MAX);
+			$hash[] = sprintf('%02d', $n % self::HASH_MAX);
 		}
-		if (!$hash) $hash[] = '00';		// we need at least one directory, to not conflict with the dir-names
-		array_unshift($hash,$id);
+		if (!$hash) $hash[] = '00'; // we need at least one directory, to not conflict with the dir-names
+		array_unshift($hash, $id);
 
-		$path = '/sqlfs/'.implode('/',array_reverse($hash));
+		$path = '/sqlfs/'.implode('/', array_reverse($hash));
 		//error_log(__METHOD__."($id) = '$path'");
 		return $GLOBALS['egw_info']['server']['files_dir'].$path;
 	}
@@ -1799,7 +1797,7 @@ 
 
 		if ($parts['pass'] || $parts['scheme'])
 		{
-			$url = $parts['scheme'].'://'.($parts['user'] ? $parts['user'].($parts['pass']?':...':'').'@' : '').
+			$url = $parts['scheme'].'://'.($parts['user'] ? $parts['user'].($parts['pass'] ? ':...' : '').'@' : '').
 				$parts['host'].$parts['path'];
 		}
 	}
@@ -1814,10 +1812,10 @@ 
 	{
 		$operation = self::DEFAULT_OPERATION;
 
-		if (strpos(is_array($url) ? $url['query'] : $url,'storage=') !== false)
+		if (strpos(is_array($url) ? $url['query'] : $url, 'storage=') !== false)
 		{
 			$query = null;
-			parse_str(is_array($url) ? $url['query'] : Vfs::parse_url($url,PHP_URL_QUERY), $query);
+			parse_str(is_array($url) ? $url['query'] : Vfs::parse_url($url, PHP_URL_QUERY), $query);
 			switch ($query['storage'])
 			{
 				case 'db':
@@ -1840,27 +1838,27 @@ 
 	 * @param array $props array of array with values for keys 'name', 'ns', 'val' (null to delete the prop)
 	 * @return boolean true if props are updated, false otherwise (eg. ressource not found)
 	 */
-	static function proppatch($path,array $props)
+	static function proppatch($path, array $props)
 	{
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."(".array2string($path).','.array2string($props));
 		if (!is_numeric($path))
 		{
-			if (!($stat = self::url_stat($path,0)))
+			if (!($stat = self::url_stat($path, 0)))
 			{
 				return false;
 			}
 			$id = $stat['ino'];
 		}
-		elseif(!($path = self::id2path($id=$path)))
+		elseif (!($path = self::id2path($id = $path)))
 		{
 			return false;
 		}
-		if (!Vfs::check_access($path,Api\Acl::EDIT,$stat))
+		if (!Vfs::check_access($path, Api\Acl::EDIT, $stat))
 		{
-			return false;	// permission denied
+			return false; // permission denied
 		}
 		$ins_stmt = $del_stmt = null;
-		foreach($props as &$prop)
+		foreach ($props as &$prop)
 		{
 			if (!isset($prop['ns'])) $prop['ns'] = Vfs::DEFAULT_PROP_NAMESPACE;
 
@@ -1905,14 +1903,14 @@ 
 	 * @return array|boolean false on error ($path_ids does not exist), array with props (values for keys 'name', 'ns', 'value'), or
 	 * 	fs_id/path => array of props for $depth==1 or is_array($path_ids)
 	 */
-	static function propfind($path_ids,$ns=Vfs::DEFAULT_PROP_NAMESPACE)
+	static function propfind($path_ids, $ns = Vfs::DEFAULT_PROP_NAMESPACE)
 	{
 		$ids = is_array($path_ids) ? $path_ids : array($path_ids);
-		foreach($ids as &$id)
+		foreach ($ids as &$id)
 		{
 			if (!is_numeric($id))
 			{
-				if (!($stat = self::url_stat($id,0)))
+				if (!($stat = self::url_stat($id, 0)))
 				{
 					if (self::LOG_LEVEL) error_log(__METHOD__."(".array2string($path_ids).",$ns) path '$id' not found!");
 					return false;
@@ -1922,7 +1920,7 @@ 
 		}
 		if (count($ids) >= 1) array_map(function(&$v) { $v = (int)$v; },$ids);
 		$query = 'SELECT * FROM '.self::PROPS_TABLE.' WHERE (fs_id'.
-			(count($ids) == 1 ? '='.(int)implode('',$ids) : ' IN ('.implode(',',$ids).')').')'.
+			(count($ids) == 1 ? '='.(int)implode('', $ids) : ' IN ('.implode(',', $ids).')').')'.
 			(!is_null($ns) ? ' AND prop_namespace=?' : '');
 		if (self::LOG_LEVEL > 2) $query = '/* '.__METHOD__.': '.__LINE__.' */ '.$query;
 
@@ -1931,7 +1929,7 @@ 
 		$stmt->execute(!is_null($ns) ? array($ns) : array());
 
 		$props = array();
-		foreach($stmt as $row)
+		foreach ($stmt as $row)
 		{
 			$props[$row['fs_id']][] = array(
 				'val'  => $row['prop_value'],
@@ -1941,19 +1939,19 @@ 
 		}
 		if (!is_array($path_ids))
 		{
-			$props = $props[$row['fs_id']] ? $props[$row['fs_id']] : array();	// return empty array for no props
+			$props = $props[$row['fs_id']] ? $props[$row['fs_id']] : array(); // return empty array for no props
 		}
 		elseif ($props && isset($stat))	// need to map fs_id's to pathes
 		{
-			foreach(self::id2path(array_keys($props)) as $id => $path)
+			foreach (self::id2path(array_keys($props)) as $id => $path)
 			{
-				$props[$path] =& $props[$id];
+				$props[$path] = & $props[$id];
 				unset($props[$id]);
 			}
 		}
 		if (self::LOG_LEVEL > 1)
 		{
-			foreach((array)$props as $k => $v)
+			foreach ((array)$props as $k => $v)
 			{
 				error_log(__METHOD__."($path_ids,$ns) $k => ".array2string($v));
 			}

Braces +405 added lines, -101 removed lines

@@ -195,7 +195,10 @@ 
 	 */
 	function stream_open ( $url, $mode, $options, &$opened_path, array $overwrite_new=null )
 	{
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url,$mode,$options)");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."($url,$mode,$options)");
+		}
 
 		$path = Vfs::parse_url($url,PHP_URL_PATH);
 		$this->operation = self::url2operation($url);
@@ -207,7 +210,9 @@ 
 
 		parse_str(parse_url($url, PHP_URL_QUERY), $this->dir_url_params);
 
-		if (!is_null($overwrite_new) || !($stat = static::url_stat($path,STREAM_URL_STAT_QUIET)) || $mode[0] == 'x')	// file not found or file should NOT exist
+		if (!is_null($overwrite_new) || !($stat = static::url_stat($path,STREAM_URL_STAT_QUIET)) || $mode[0] == 'x')
+		{
+			// file not found or file should NOT exist
 		{
 			if ($mode[0] == 'r' ||	// does $mode require the file to exist (r,r+)
 				$mode[0] == 'x' && $stat ||	// or file should not exist, but does
@@ -215,7 +220,11 @@ 
 				!Vfs::check_access($dir,Vfs::WRITABLE,$dir_stat))	// or we are not allowed to 																																			create it
 			{
 				self::_remove_password($url);
-				if (self::LOG_LEVEL) error_log(__METHOD__."($url,$mode,$options) file does not exist or can not be created!");
+		}
+				if (self::LOG_LEVEL)
+				{
+					error_log(__METHOD__."($url,$mode,$options) file does not exist or can not be created!");
+				}
 				if (($options & STREAM_REPORT_ERRORS))
 				{
 					trigger_error(__METHOD__."($url,$mode,$options) file does not exist or can not be created!",E_USER_WARNING);
@@ -227,7 +236,10 @@ 
 			$new_file = true;
 			$query = 'INSERT INTO '.self::TABLE.' (fs_name,fs_dir,fs_mode,fs_uid,fs_gid,fs_created,fs_modified,fs_creator,fs_mime,fs_size,fs_active'.
 				') VALUES (:fs_name,:fs_dir,:fs_mode,:fs_uid,:fs_gid,:fs_created,:fs_modified,:fs_creator,:fs_mime,:fs_size,:fs_active)';
-			if (self::LOG_LEVEL > 2) $query = '/* '.__METHOD__.': '.__LINE__.' */ '.$query;
+			if (self::LOG_LEVEL > 2)
+			{
+				$query = '/* '.__METHOD__.': '.__LINE__.' */ '.$query;
+			}
 			$stmt = self::$pdo->prepare($query);
 			$values = array(
 				'fs_name' => self::limit_filename(Vfs::basename($path)),
@@ -245,11 +257,17 @@ 
 				'fs_size'     => 0,
 				'fs_active'   => self::_pdo_boolean(true),
 			);
-			if ($overwrite_new) $values = array_merge($values,$overwrite_new);
+			if ($overwrite_new)
+			{
+				$values = array_merge($values,$overwrite_new);
+			}
 			if (!$stmt->execute($values) || !($this->opened_fs_id = self::$pdo->lastInsertId('egw_sqlfs_fs_id_seq')))
 			{
 				$this->opened_stream = $this->opened_path = $this->opened_mode = null;
-				if (self::LOG_LEVEL) error_log(__METHOD__."($url,$mode,$options) execute() failed: ".self::$pdo->errorInfo());
+				if (self::LOG_LEVEL)
+				{
+					error_log(__METHOD__."($url,$mode,$options) execute() failed: ".self::$pdo->errorInfo());
+				}
 				return false;
 			}
 			if ($this->operation == self::STORE2DB)
@@ -261,14 +279,20 @@ 
 			elseif(!file_exists($fs_dir=Vfs::dirname(self::_fs_path($this->opened_fs_id))))
 			{
 				$umaskbefore = umask();
-				if (self::LOG_LEVEL > 1) error_log(__METHOD__." about to call mkdir for $fs_dir # Present UMASK:".decoct($umaskbefore)." called from:".function_backtrace());
+				if (self::LOG_LEVEL > 1)
+				{
+					error_log(__METHOD__." about to call mkdir for $fs_dir # Present UMASK:".decoct($umaskbefore)." called from:".function_backtrace());
+				}
 				self::mkdir_recursive($fs_dir,0700,true);
 			}
 		}
 		// check if opend file is a directory
 		elseif($stat && ($stat['mode'] & self::MODE_DIR) == self::MODE_DIR)
 		{
-				if (self::LOG_LEVEL) error_log(__METHOD__."($url,$mode,$options) Is a directory!");
+				if (self::LOG_LEVEL)
+				{
+					error_log(__METHOD__."($url,$mode,$options) Is a directory!");
+				}
 				if (($options & STREAM_REPORT_ERRORS))
 				{
 					trigger_error(__METHOD__."($url,$mode,$options) Is a directory!",E_USER_WARNING);
@@ -279,11 +303,17 @@ 
 		else
 		{
 			if ($mode == 'r' && !Vfs::check_access($url,Vfs::READABLE ,$stat) ||// we are not allowed to read
-				$mode != 'r' && !Vfs::check_access($url,Vfs::WRITABLE,$stat))	// or edit it
+				$mode != 'r' && !Vfs::check_access($url,Vfs::WRITABLE,$stat))
+			{
+				// or edit it
 			{
 				self::_remove_password($url);
+			}
 				$op = $mode == 'r' ? 'read' : 'edited';
-				if (self::LOG_LEVEL) error_log(__METHOD__."($url,$mode,$options) file can not be $op!");
+				if (self::LOG_LEVEL)
+				{
+					error_log(__METHOD__."($url,$mode,$options) file can not be $op!");
+				}
 				if (($options & STREAM_REPORT_ERRORS))
 				{
 					trigger_error(__METHOD__."($url,$mode,$options) file can not be $op!",E_USER_WARNING);
@@ -315,7 +345,10 @@ 
 		// do we operate directly on the filesystem --> open file from there
 		if ($this->operation == self::STORE2FS)
 		{
-			if (self::LOG_LEVEL > 1) error_log(__METHOD__." fopen (may create a directory? mkdir) ($this->opened_fs_id,$mode,$options)");
+			if (self::LOG_LEVEL > 1)
+			{
+				error_log(__METHOD__." fopen (may create a directory? mkdir) ($this->opened_fs_id,$mode,$options)");
+			}
 			if (!($this->opened_stream = fopen(self::_fs_path($this->opened_fs_id),$mode)) && $new_file)
 			{
 				// delete db entry again, if we are not able to open a new(!) file
@@ -324,11 +357,17 @@ 
 				$stmt->execute(array('fs_id' => $this->opened_fs_id));
 			}
 		}
-		if ($mode[0] == 'a')	// append modes: a, a+
+		if ($mode[0] == 'a')
+		{
+			// append modes: a, a+
 		{
 			$this->stream_seek(0,SEEK_END);
 		}
-		if (!is_resource($this->opened_stream)) error_log(__METHOD__."($url,$mode,$options) NO stream, returning false!");
+		}
+		if (!is_resource($this->opened_stream))
+		{
+			error_log(__METHOD__."($url,$mode,$options) NO stream, returning false!");
+		}
 
 		return is_resource($this->opened_stream);
 	}
@@ -340,7 +379,10 @@ 
 	 */
 	function stream_close ( )
 	{
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."()");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."()");
+		}
 
 		if (is_null($this->opened_path) || !is_resource($this->opened_stream) || !$this->opened_fs_id)
 		{
@@ -410,7 +452,10 @@ 
 	 */
 	function stream_read ( $count )
 	{
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($count) pos=$this->opened_pos");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."($count) pos=$this->opened_pos");
+		}
 
 		if (is_resource($this->opened_stream))
 		{
@@ -432,7 +477,10 @@ 
 	 */
 	function stream_write ( $data )
 	{
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($data)");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."($data)");
+		}
 
 		if (is_resource($this->opened_stream))
 		{
@@ -469,7 +517,10 @@ 
 	 */
  	function stream_tell ( )
  	{
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."()");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."()");
+		}
 
 		if (is_resource($this->opened_stream))
 		{
@@ -492,7 +543,10 @@ 
  	 */
 	function stream_seek ( $offset, $whence )
 	{
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($offset,$whence)");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."($offset,$whence)");
+		}
 
 		if (is_resource($this->opened_stream))
 		{
@@ -510,7 +564,10 @@ 
 	 */
 	function stream_flush ( )
 	{
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."()");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."()");
+		}
 
 		if (is_resource($this->opened_stream))
 		{
@@ -535,7 +592,10 @@ 
 	 */
 	function stream_stat ( )
 	{
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($this->opened_path)");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."($this->opened_path)");
+		}
 
 		return $this->url_stat($this->opened_path,0);
 	}
@@ -551,24 +611,36 @@ 
 	 */
 	static function unlink ( $url, $parent_stat=null )
 	{
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url)");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."($url)");
+		}
 
 		$path = Vfs::parse_url($url,PHP_URL_PATH);
 
 		// need to get parent stat from Sqlfs, not Vfs
-		if (!isset($parent_stat)) $parent_stat = static::url_stat(Vfs::dirname($path), STREAM_URL_STAT_LINK);
+		if (!isset($parent_stat))
+		{
+			$parent_stat = static::url_stat(Vfs::dirname($path), STREAM_URL_STAT_LINK);
+		}
 
 		if (!$parent_stat || !($stat = self::url_stat($path,STREAM_URL_STAT_LINK)) ||
 			!Vfs::check_access(Vfs::dirname($path),Vfs::WRITABLE, $parent_stat))
 		{
 			self::_remove_password($url);
-			if (self::LOG_LEVEL) error_log(__METHOD__."($url) permission denied!");
+			if (self::LOG_LEVEL)
+			{
+				error_log(__METHOD__."($url) permission denied!");
+			}
 			return false;	// no permission or file does not exist
 		}
 		if ($stat['mime'] == self::DIR_MIME_TYPE)
 		{
 			self::_remove_password($url);
-			if (self::LOG_LEVEL) error_log(__METHOD__."($url) is NO file!");
+			if (self::LOG_LEVEL)
+			{
+				error_log(__METHOD__."($url) is NO file!");
+			}
 			return false;	// no permission or file does not exist
 		}
 		$stmt = self::$pdo->prepare('DELETE FROM '.self::TABLE.' WHERE fs_id=:fs_id');
@@ -603,7 +675,10 @@ 
 	 */
 	static function rename ( $url_from, $url_to)
 	{
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url_from,$url_to)");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."($url_from,$url_to)");
+		}
 
 		$path_from = Vfs::parse_url($url_from,PHP_URL_PATH);
 		$from_dir = Vfs::dirname($path_from);
@@ -617,14 +692,20 @@ 
 		{
 			self::_remove_password($url_from);
 			self::_remove_password($url_to);
-			if (self::LOG_LEVEL) error_log(__METHOD__."($url_from,$url_to): $path_from permission denied!");
+			if (self::LOG_LEVEL)
+			{
+				error_log(__METHOD__."($url_from,$url_to): $path_from permission denied!");
+			}
 			return false;	// no permission or file does not exist
 		}
 		if (!Vfs::check_access($to_dir, Vfs::WRITABLE, $to_dir_stat = static::url_stat($to_dir, 0)))
 		{
 			self::_remove_password($url_from);
 			self::_remove_password($url_to);
-			if (self::LOG_LEVEL) error_log(__METHOD__."($url_from,$url_to): $path_to permission denied!");
+			if (self::LOG_LEVEL)
+			{
+				error_log(__METHOD__."($url_from,$url_to): $path_to permission denied!");
+			}
 			return false;	// no permission or parent-dir does not exist
 		}
 		// the filesystem stream-wrapper does NOT allow to rename files to directories, as this makes problems
@@ -635,14 +716,20 @@ 
 			self::_remove_password($url_from);
 			self::_remove_password($url_to);
 			$is_dir = $to_stat['mime'] === self::DIR_MIME_TYPE ? 'a' : 'no';
-			if (self::LOG_LEVEL) error_log(__METHOD__."($url_to,$url_from) $path_to is $is_dir directory!");
+			if (self::LOG_LEVEL)
+			{
+				error_log(__METHOD__."($url_to,$url_from) $path_to is $is_dir directory!");
+			}
 			return false;	// no permission or file does not exist
 		}
 		// if destination file already exists, delete it
 		if ($to_stat && !static::unlink($url_to,$operation))
 		{
 			self::_remove_password($url_to);
-			if (self::LOG_LEVEL) error_log(__METHOD__."($url_to,$url_from) can't unlink existing $url_to!");
+			if (self::LOG_LEVEL)
+			{
+				error_log(__METHOD__."($url_to,$url_from) can't unlink existing $url_to!");
+			}
 			return false;
 		}
 		unset(self::$stat_cache[$path_from]);
@@ -680,7 +767,10 @@ 
 	{
 		$maxdepth=10;
 		$depth2propagate = (int)$depth + 1;
-		if ($depth2propagate > $maxdepth) return is_dir($pathname);
+		if ($depth2propagate > $maxdepth)
+		{
+			return is_dir($pathname);
+		}
     	is_dir(Vfs::dirname($pathname)) || self::mkdir_recursive(Vfs::dirname($pathname), $mode, $depth2propagate);
     	return is_dir($pathname) || @mkdir($pathname, $mode);
 	}
@@ -698,14 +788,23 @@ 
 	 */
 	static function mkdir ( $url, $mode, $options )
 	{
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url,$mode,$options)");
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__." called from:".function_backtrace());
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."($url,$mode,$options)");
+		}
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__." called from:".function_backtrace());
+		}
 		$path = Vfs::parse_url($url,PHP_URL_PATH);
 
 		if (self::url_stat($path,STREAM_URL_STAT_QUIET))
 		{
 			self::_remove_password($url);
-			if (self::LOG_LEVEL) error_log(__METHOD__."('$url',$mode,$options) already exist!");
+			if (self::LOG_LEVEL)
+			{
+				error_log(__METHOD__."('$url',$mode,$options) already exist!");
+			}
 			if (!($options & STREAM_REPORT_ERRORS))
 			{
 				//throw new Exception(__METHOD__."('$url',$mode,$options) already exist!");
@@ -714,14 +813,20 @@ 
 			return false;
 		}
 		$parent_path = Vfs::dirname($path);
-		if (($query = Vfs::parse_url($url,PHP_URL_QUERY))) $parent_path .= '?'.$query;
+		if (($query = Vfs::parse_url($url,PHP_URL_QUERY)))
+		{
+			$parent_path .= '?'.$query;
+		}
 		$parent = self::url_stat($parent_path,STREAM_URL_STAT_QUIET);
 
 		// check if we should also create all non-existing path components and our parent does not exist,
 		// if yes call ourself recursive with the parent directory
 		if (($options & STREAM_MKDIR_RECURSIVE) && $parent_path != '/' && !$parent)
 		{
-			if (self::LOG_LEVEL > 1) error_log(__METHOD__." creating parents: $parent_path, $mode");
+			if (self::LOG_LEVEL > 1)
+			{
+				error_log(__METHOD__." creating parents: $parent_path, $mode");
+			}
 			if (!self::mkdir($parent_path,$mode,$options))
 			{
 				return false;
@@ -731,7 +836,10 @@ 
 		if (!$parent || !Vfs::check_access($parent_path,Vfs::WRITABLE,$parent))
 		{
 			self::_remove_password($url);
-			if (self::LOG_LEVEL) error_log(__METHOD__."('$url',$mode,$options) permission denied!");
+			if (self::LOG_LEVEL)
+			{
+				error_log(__METHOD__."('$url',$mode,$options) permission denied!");
+			}
 			if (!($options & STREAM_REPORT_ERRORS))
 			{
 				trigger_error(__METHOD__."('$url',$mode,$options) permission denied!",E_USER_WARNING);
@@ -765,10 +873,13 @@ 
 				'fs_dir'  => $parent['ino'],
 				'fs_active' => self::_pdo_boolean(true),
 				'fs_name' => self::limit_filename(Vfs::basename($path)),
-			)) && $stmt->fetchColumn() > 1)	// if there's more then one --> remove our new dir
+			)) && $stmt->fetchColumn() > 1)
+			{
+				// if there's more then one --> remove our new dir
 			{
 				self::$pdo->query('DELETE FROM '.self::TABLE.' WHERE fs_id='.$new_fs_id);
 			}
+			}
 		}
 		return $ok;
 	}
@@ -785,7 +896,10 @@ 
 	 */
 	static function rmdir ( $url, $options )
 	{
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url)");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."($url)");
+		}
 
 		$path = Vfs::parse_url($url,PHP_URL_PATH);
 		$parent = Vfs::dirname($path);
@@ -796,7 +910,10 @@ 
 			self::_remove_password($url);
 			$err_msg = __METHOD__."($url,$options) ".(!$stat ? 'not found!' :
 				($stat['mime'] != self::DIR_MIME_TYPE ? 'not a directory!' : 'permission denied!'));
-			if (self::LOG_LEVEL) error_log($err_msg);
+			if (self::LOG_LEVEL)
+			{
+				error_log($err_msg);
+			}
 			if (!($options & STREAM_REPORT_ERRORS))
 			{
 				trigger_error($err_msg,E_USER_WARNING);
@@ -808,7 +925,10 @@ 
 		if ($stmt->fetchColumn())
 		{
 			self::_remove_password($url);
-			if (self::LOG_LEVEL) error_log(__METHOD__."($url,$options) dir is not empty!");
+			if (self::LOG_LEVEL)
+			{
+				error_log(__METHOD__."($url,$options) dir is not empty!");
+			}
 			if (!($options & STREAM_REPORT_ERRORS))
 			{
 				trigger_error(__METHOD__."('$url',$options) dir is not empty!",E_USER_WARNING);
@@ -840,7 +960,10 @@ 
 	static function touch($url,$time=null,$atime=null)
 	{
 		unset($atime);	// not used
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url, $time)");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."($url, $time)");
+		}
 
 		$path = Vfs::parse_url($url,PHP_URL_PATH);
 
@@ -876,25 +999,37 @@ 
 	 */
 	static function chown($url,$owner)
 	{
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url,$owner)");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."($url,$owner)");
+		}
 
 		$path = Vfs::parse_url($url,PHP_URL_PATH);
 
 		if (!($stat = self::url_stat($path,0)))
 		{
-			if (self::LOG_LEVEL) error_log(__METHOD__."($url,$owner) no such file or directory!");
+			if (self::LOG_LEVEL)
+			{
+				error_log(__METHOD__."($url,$owner) no such file or directory!");
+			}
 			trigger_error("No such file or directory $url !",E_USER_WARNING);
 			return false;
 		}
 		if (!Vfs::$is_root)
 		{
-			if (self::LOG_LEVEL) error_log(__METHOD__."($url,$owner) only root can do that!");
+			if (self::LOG_LEVEL)
+			{
+				error_log(__METHOD__."($url,$owner) only root can do that!");
+			}
 			trigger_error("Only root can do that!",E_USER_WARNING);
 			return false;
 		}
-		if ($owner < 0 || $owner && !$GLOBALS['egw']->accounts->id2name($owner))	// not a user (0 == root)
+		if ($owner < 0 || $owner && !$GLOBALS['egw']->accounts->id2name($owner))
+		{
+			// not a user (0 == root)
 		{
 			if (self::LOG_LEVEL) error_log(__METHOD__."($url,$owner) unknown (numeric) user id!");
+		}
 			trigger_error(__METHOD__."($url,$owner) Unknown (numeric) user id!",E_USER_WARNING);
 			//throw new Exception(__METHOD__."($url,$owner) Unknown (numeric) user id!");
 			return false;
@@ -902,7 +1037,10 @@ 
 		$stmt = self::$pdo->prepare('UPDATE '.self::TABLE.' SET fs_uid=:fs_uid WHERE fs_id=:fs_id');
 
 		// update stat-cache
-		if ($path != '/' && substr($path,-1) == '/') $path = substr($path, 0, -1);
+		if ($path != '/' && substr($path,-1) == '/')
+		{
+			$path = substr($path, 0, -1);
+		}
 		self::$stat_cache[$path]['fs_uid'] = $owner;
 
 		return $stmt->execute(array(
@@ -920,34 +1058,53 @@ 
 	 */
 	static function chgrp($url,$owner)
 	{
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url,$owner)");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."($url,$owner)");
+		}
 
 		$path = Vfs::parse_url($url,PHP_URL_PATH);
 
 		if (!($stat = self::url_stat($path,0)))
 		{
-			if (self::LOG_LEVEL) error_log(__METHOD__."($url,$owner) no such file or directory!");
+			if (self::LOG_LEVEL)
+			{
+				error_log(__METHOD__."($url,$owner) no such file or directory!");
+			}
 			trigger_error("No such file or directory $url !",E_USER_WARNING);
 			return false;
 		}
 		if (!Vfs::has_owner_rights($path,$stat))
 		{
-			if (self::LOG_LEVEL) error_log(__METHOD__."($url,$owner) only owner or root can do that!");
+			if (self::LOG_LEVEL)
+			{
+				error_log(__METHOD__."($url,$owner) only owner or root can do that!");
+			}
 			trigger_error("Only owner or root can do that!",E_USER_WARNING);
 			return false;
 		}
-		if ($owner < 0) $owner = -$owner;	// sqlfs uses a positiv group id's!
+		if ($owner < 0)
+		{
+			$owner = -$owner;
+		}
+		// sqlfs uses a positiv group id's!
 
-		if ($owner && !$GLOBALS['egw']->accounts->id2name(-$owner))	// not a group
+		if ($owner && !$GLOBALS['egw']->accounts->id2name(-$owner))
+		{
+			// not a group
 		{
 			if (self::LOG_LEVEL) error_log(__METHOD__."($url,$owner) unknown (numeric) group id!");
+		}
 			trigger_error("Unknown (numeric) group id!",E_USER_WARNING);
 			return false;
 		}
 		$stmt = self::$pdo->prepare('UPDATE '.self::TABLE.' SET fs_gid=:fs_gid WHERE fs_id=:fs_id');
 
 		// update stat-cache
-		if ($path != '/' && substr($path,-1) == '/') $path = substr($path, 0, -1);
+		if ($path != '/' && substr($path,-1) == '/')
+		{
+			$path = substr($path, 0, -1);
+		}
 		self::$stat_cache[$path]['fs_gid'] = $owner;
 
 		return $stmt->execute(array(
@@ -965,32 +1122,47 @@ 
 	 */
 	static function chmod($url,$mode)
 	{
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url, $mode)");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."($url, $mode)");
+		}
 
 		$path = Vfs::parse_url($url,PHP_URL_PATH);
 
 		if (!($stat = self::url_stat($path,0)))
 		{
-			if (self::LOG_LEVEL) error_log(__METHOD__."($url, $mode) no such file or directory!");
+			if (self::LOG_LEVEL)
+			{
+				error_log(__METHOD__."($url, $mode) no such file or directory!");
+			}
 			trigger_error("No such file or directory $url !",E_USER_WARNING);
 			return false;
 		}
 		if (!Vfs::has_owner_rights($path,$stat))
 		{
-			if (self::LOG_LEVEL) error_log(__METHOD__."($url, $mode) only owner or root can do that!");
+			if (self::LOG_LEVEL)
+			{
+				error_log(__METHOD__."($url, $mode) only owner or root can do that!");
+			}
 			trigger_error("Only owner or root can do that!",E_USER_WARNING);
 			return false;
 		}
-		if (!is_numeric($mode))	// not a mode
+		if (!is_numeric($mode))
+		{
+			// not a mode
 		{
 			if (self::LOG_LEVEL) error_log(__METHOD__."($url, $mode) no (numeric) mode!");
+		}
 			trigger_error("No (numeric) mode!",E_USER_WARNING);
 			return false;
 		}
 		$stmt = self::$pdo->prepare('UPDATE '.self::TABLE.' SET fs_mode=:fs_mode WHERE fs_id=:fs_id');
 
 		// update stat cache
-		if ($path != '/' && substr($path,-1) == '/') $path = substr($path, 0, -1);
+		if ($path != '/' && substr($path,-1) == '/')
+		{
+			$path = substr($path, 0, -1);
+		}
 		self::$stat_cache[$path]['fs_mode'] = ((int) $mode) & 0777;
 
 		return $stmt->execute(array(
@@ -1015,11 +1187,17 @@ 
 
 		if (!($stat = self::url_stat($url,0)) || 		// dir not found
 			$stat['mime'] != self::DIR_MIME_TYPE ||		// no dir
-			!Vfs::check_access($url,Vfs::EXECUTABLE|Vfs::READABLE,$stat))	// no access
+			!Vfs::check_access($url,Vfs::EXECUTABLE|Vfs::READABLE,$stat))
+		{
+			// no access
 		{
 			self::_remove_password($url);
+		}
 			$msg = $stat['mime'] != self::DIR_MIME_TYPE ? "$url is no directory" : 'permission denied';
-			if (self::LOG_LEVEL) error_log(__METHOD__."('$url',$options) $msg!");
+			if (self::LOG_LEVEL)
+			{
+				error_log(__METHOD__."('$url',$options) $msg!");
+			}
 			$this->opened_dir = null;
 			return false;
 		}
@@ -1028,7 +1206,10 @@ 
 			' FROM '.self::TABLE.' WHERE fs_dir=? AND fs_active='.self::_pdo_boolean(true).
 			" ORDER BY fs_mime='httpd/unix-directory' DESC, fs_name ASC";
 		//if (self::LOG_LEVEL > 2) $query = '/* '.__METHOD__.': '.__LINE__.' */ '.$query;
-		if (self::LOG_LEVEL > 2) $query = '/* '.__METHOD__."($url,$options)".' */ '.$query;
+		if (self::LOG_LEVEL > 2)
+		{
+			$query = '/* '.__METHOD__."($url,$options)".' */ '.$query;
+		}
 
 		$stmt = self::$pdo->prepare($query);
 		$stmt->setFetchMode(\PDO::FETCH_ASSOC);
@@ -1040,7 +1221,10 @@ 
 				self::$stat_cache[Vfs::concat($path,$file['fs_name'])] = $file;
 			}
 		}
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url,$options): ".implode(', ',$this->opened_dir));
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."($url,$options): ".implode(', ',$this->opened_dir));
+		}
 		reset($this->opened_dir);
 
 		return true;
@@ -1079,9 +1263,16 @@ 
 		if (is_null($max_subquery_depth))
 		{
 			$max_subquery_depth = $GLOBALS['egw_info']['server']['max_subquery_depth'];
-			if (!$max_subquery_depth) $max_subquery_depth = 7;	// setting current default of 7, if nothing set
+			if (!$max_subquery_depth)
+			{
+				$max_subquery_depth = 7;
+			}
+			// setting current default of 7, if nothing set
+		}
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."('$url',$flags,$eacl_access)");
 		}
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."('$url',$flags,$eacl_access)");
 
 		$path = Vfs::parse_url($url,PHP_URL_PATH);
 
@@ -1147,7 +1338,10 @@ 
 						if (!Vfs::$user)
 						{
 							self::_remove_password($url);
-							if (self::LOG_LEVEL > 1) error_log(__METHOD__."('$url',$flags) permission denied, no user-id and not root!");
+							if (self::LOG_LEVEL > 1)
+							{
+								error_log(__METHOD__."('$url',$flags) permission denied, no user-id and not root!");
+							}
 							return false;
 						}
 						$query .= ' AND '.self::_sql_readable();
@@ -1158,7 +1352,10 @@ 
 					$query = str_replace('fs_name'.self::$case_sensitive_equal.'?','fs_name'.self::$case_sensitive_equal.self::$pdo->quote($name),$base_query).'('.$query.')';
 				}
 			}
-			if (self::LOG_LEVEL > 2) $query = '/* '.__METHOD__."($url,$flags,$eacl_access)".' */ '.$query;
+			if (self::LOG_LEVEL > 2)
+			{
+				$query = '/* '.__METHOD__."($url,$flags,$eacl_access)".' */ '.$query;
+			}
 			//if (self::LOG_LEVEL > 2) $query = '/* '.__METHOD__.': '.__LINE__.' */ '.$query;
 
 			if (!($result = self::$pdo->query($query)) || !($info = $result->fetch(\PDO::FETCH_ASSOC)))
@@ -1181,12 +1378,18 @@ 
 			$GLOBALS['egw_info']['server']['max_subquery_depth'] = --$max_subquery_depth;
 			error_log(__METHOD__."() decremented max_subquery_depth to $max_subquery_depth");
 			Api\Config::save_value('max_subquery_depth', $max_subquery_depth, 'phpgwapi');
-			if (method_exists($GLOBALS['egw'],'invalidate_session_cache')) $GLOBALS['egw']->invalidate_session_cache();
+			if (method_exists($GLOBALS['egw'],'invalidate_session_cache'))
+			{
+				$GLOBALS['egw']->invalidate_session_cache();
+			}
 			return self::url_stat($url, $flags, $eacl_access);
 		}
 		self::$stat_cache[$path] = $info;
 
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url,$flags)=".array2string($info));
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."($url,$flags)=".array2string($info));
+		}
 		return self::_vfsinfo2stat($info);
 	}
 
@@ -1223,9 +1426,15 @@ 
 	 */
 	function dir_readdir ( )
 	{
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."( )");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."( )");
+		}
 
-		if (!is_array($this->opened_dir)) return false;
+		if (!is_array($this->opened_dir))
+		{
+			return false;
+		}
 
 		$file = current($this->opened_dir); next($this->opened_dir);
 
@@ -1242,9 +1451,15 @@ 
 	 */
 	function dir_rewinddir ( )
 	{
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."( )");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."( )");
+		}
 
-		if (!is_array($this->opened_dir)) return false;
+		if (!is_array($this->opened_dir))
+		{
+			return false;
+		}
 
 		reset($this->opened_dir);
 
@@ -1260,9 +1475,15 @@ 
 	 */
 	function dir_closedir ( )
 	{
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."( )");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."( )");
+		}
 
-		if (!is_array($this->opened_dir)) return false;
+		if (!is_array($this->opened_dir))
+		{
+			return false;
+		}
 
 		$this->opened_dir = null;
 
@@ -1281,7 +1502,10 @@ 
 	{
 		$link = !($lstat = self::url_stat($path,STREAM_URL_STAT_LINK)) || is_null($lstat['readlink']) ? false : $lstat['readlink'];
 
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."('$path') = $link");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."('$path') = $link");
+		}
 
 		return $link;
 	}
@@ -1295,22 +1519,34 @@ 
 	 */
 	static function symlink($target,$link)
 	{
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."('$target','$link')");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."('$target','$link')");
+		}
 
 		if (self::url_stat($link,0))
 		{
-			if (self::LOG_LEVEL > 0) error_log(__METHOD__."('$target','$link') $link exists, returning false!");
+			if (self::LOG_LEVEL > 0)
+			{
+				error_log(__METHOD__."('$target','$link') $link exists, returning false!");
+			}
 			return false;	// $link already exists
 		}
 		if (!($dir = Vfs::dirname($link)) ||
 			!Vfs::check_access($dir,Vfs::WRITABLE,$dir_stat=static::url_stat($dir,0)))
 		{
-			if (self::LOG_LEVEL > 0) error_log(__METHOD__."('$target','$link') returning false! (!is_writable('$dir'), dir_stat=".array2string($dir_stat).")");
+			if (self::LOG_LEVEL > 0)
+			{
+				error_log(__METHOD__."('$target','$link') returning false! (!is_writable('$dir'), dir_stat=".array2string($dir_stat).")");
+			}
 			return false;	// parent dir does not exist or is not writable
 		}
 		$query = 'INSERT INTO '.self::TABLE.' (fs_name,fs_dir,fs_mode,fs_uid,fs_gid,fs_created,fs_modified,fs_creator,fs_mime,fs_size,fs_link'.
 			') VALUES (:fs_name,:fs_dir,:fs_mode,:fs_uid,:fs_gid,:fs_created,:fs_modified,:fs_creator,:fs_mime,:fs_size,:fs_link)';
-		if (self::LOG_LEVEL > 2) $query = '/* '.__METHOD__.': '.__LINE__.' */ '.$query;
+		if (self::LOG_LEVEL > 2)
+		{
+			$query = '/* '.__METHOD__.': '.__LINE__.' */ '.$query;
+		}
 		$stmt = self::$pdo->prepare($query);
 		unset(self::$stat_cache[Vfs::parse_url($link,PHP_URL_PATH)]);
 
@@ -1358,7 +1594,10 @@ 
 				break;
 			}
 		}
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url,$check) ".($access?"access granted by $path=$rights":'no access!!!'));
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."($url,$check) ".($access?"access granted by $path=$rights":'no access!!!'));
+		}
 		return $access;
 	}
 
@@ -1386,11 +1625,15 @@ 
 			}
 		}
 		// sort by length descending, to allow more specific pathes to have precedence
-		uksort(self::$extended_acl, function($a,$b) {
+		uksort(self::$extended_acl, function($a,$b)
+		{
 			return strlen($b)-strlen($a);
 		});
 		Api\Cache::setSession(self::EACL_APPNAME, 'extended_acl', self::$extended_acl);
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__.'() '.array2string(self::$extended_acl));
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__.'() '.array2string(self::$extended_acl));
+		}
 	}
 
 	/**
@@ -1419,12 +1662,18 @@ 
 		{
 			if (!($stat = self::url_stat($path,0)))
 			{
-				if (self::LOG_LEVEL) error_log(__METHOD__."($path,$rights,$owner,$fs_id) no such file or directory!");
+				if (self::LOG_LEVEL)
+				{
+					error_log(__METHOD__."($path,$rights,$owner,$fs_id) no such file or directory!");
+				}
 				return false;	// $path not found
 			}
-			if (!Vfs::has_owner_rights($path,$stat))		// not group dir and user is eGW admin
+			if (!Vfs::has_owner_rights($path,$stat))
+			{
+				// not group dir and user is eGW admin
 			{
 				if (self::LOG_LEVEL) error_log(__METHOD__."($path,$rights,$owner,$fs_id) permission denied!");
+			}
 				return false;	// permission denied
 			}
 			$fs_id = $stat['ino'];
@@ -1457,7 +1706,10 @@ 
 		{
 			Api\Cache::setSession(self::EACL_APPNAME, 'extended_acl', self::$extended_acl);
 		}
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($path,$rights,$owner,$fs_id)=".(int)$ret);
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."($path,$rights,$owner,$fs_id)=".(int)$ret);
+		}
 		return $ret;
 	}
 
@@ -1491,7 +1743,8 @@ 
 			$eacls = array_merge((array)self::get_eacl($path),$eacls);
 		}
 		// sort by length descending, to show precedence
-		usort($eacls, function($a, $b) {
+		usort($eacls, function($a, $b)
+		{
 			return strlen($b['path']) - strlen($a['path']);
 		});
 		//error_log(__METHOD__."('$_path') returning ".array2string($eacls));
@@ -1509,7 +1762,10 @@ 
 	 */
 	static function id2path($fs_ids)
 	{
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__.'('.array2string($fs_ids).')');
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__.'('.array2string($fs_ids).')');
+		}
 		$ids = (array)$fs_ids;
 		$pathes = array();
 		// first check our stat-cache for the ids
@@ -1521,16 +1777,26 @@ 
 				unset($ids[$key]);
 				if (!$ids)
 				{
-					if (self::LOG_LEVEL > 1) error_log(__METHOD__.'('.array2string($fs_ids).')='.array2string($pathes).' *from stat_cache*');
+					if (self::LOG_LEVEL > 1)
+					{
+						error_log(__METHOD__.'('.array2string($fs_ids).')='.array2string($pathes).' *from stat_cache*');
+					}
 					return is_array($fs_ids) ? $pathes : array_shift($pathes);
 				}
 			}
 		}
 		// now search via the database
-		if (count($ids) > 1) array_map(function(&$v) { $v = (int)$v; },$ids);
+		if (count($ids) > 1)
+		{
+			array_map(function(&$v) { $v = (int)$v;
+		}
+		},$ids);
 		$query = 'SELECT fs_id,fs_dir,fs_name FROM '.self::TABLE.' WHERE fs_id'.
 			(count($ids) == 1 ? '='.(int)$ids[0] : ' IN ('.implode(',',$ids).')');
-		if (self::LOG_LEVEL > 2) $query = '/* '.__METHOD__.': '.__LINE__.' */ '.$query;
+		if (self::LOG_LEVEL > 2)
+		{
+			$query = '/* '.__METHOD__.': '.__LINE__.' */ '.$query;
+		}
 
 		if (!is_object(self::$pdo))
 		{
@@ -1557,14 +1823,20 @@ 
 		{
 			return false;	// parent not found, should never happen ...
 		}
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__." trying foreach with:".print_r($rows,true)."#");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__." trying foreach with:".print_r($rows,true)."#");
+		}
 		foreach((array)$rows as $fs_id => $row)
 		{
 			$parent = $row['fs_dir'] > 1 ? $parents[$row['fs_dir']] : '';
 
 			$pathes[$fs_id] = $parent . '/' . $row['fs_name'];
 		}
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__.'('.array2string($fs_ids).')='.array2string($pathes));
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__.'('.array2string($fs_ids).')='.array2string($pathes));
+		}
 		return is_array($fs_ids) ? $pathes : array_shift($pathes);
 	}
 
@@ -1620,7 +1892,10 @@ 
 			'mime'  => $info['fs_mime'],
 			'readlink' => $info['fs_link'],
 		);
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($info[name]) = ".array2string($stat));
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."($info[name]) = ".array2string($stat));
+		}
 		return $stat;
 	}
 
@@ -1762,13 +2037,16 @@ 
 		}
 		if (!isset($GLOBALS['egw_info']['server']['files_dir']))
 		{
-			if (is_object($GLOBALS['egw_setup']->db))	// if we run under setup, query the db for the files dir
+			if (is_object($GLOBALS['egw_setup']->db))
+			{
+				// if we run under setup, query the db for the files dir
 			{
 				$GLOBALS['egw_info']['server']['files_dir'] = $GLOBALS['egw_setup']->db->select('egw_config','config_value',array(
 					'config_name' => 'files_dir',
 					'config_app' => 'phpgwapi',
 				),__LINE__,__FILE__)->fetchColumn();
 			}
+			}
 		}
 		if (!$GLOBALS['egw_info']['server']['files_dir'])
 		{
@@ -1780,7 +2058,11 @@ 
 		{
 			$hash[] = sprintf('%02d',$n % self::HASH_MAX);
 		}
-		if (!$hash) $hash[] = '00';		// we need at least one directory, to not conflict with the dir-names
+		if (!$hash)
+		{
+			$hash[] = '00';
+		}
+		// we need at least one directory, to not conflict with the dir-names
 		array_unshift($hash,$id);
 
 		$path = '/sqlfs/'.implode('/',array_reverse($hash));
@@ -1842,7 +2124,10 @@ 
 	 */
 	static function proppatch($path,array $props)
 	{
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."(".array2string($path).','.array2string($props));
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."(".array2string($path).','.array2string($props));
+		}
 		if (!is_numeric($path))
 		{
 			if (!($stat = self::url_stat($path,0)))
@@ -1862,13 +2147,19 @@ 
 		$ins_stmt = $del_stmt = null;
 		foreach($props as &$prop)
 		{
-			if (!isset($prop['ns'])) $prop['ns'] = Vfs::DEFAULT_PROP_NAMESPACE;
+			if (!isset($prop['ns']))
+			{
+				$prop['ns'] = Vfs::DEFAULT_PROP_NAMESPACE;
+			}
 
-			if (!isset($prop['val']) || self::$pdo_type != 'mysql')	// for non mysql, we have to delete the prop anyway, as there's no REPLACE!
+			if (!isset($prop['val']) || self::$pdo_type != 'mysql')
+			{
+				// for non mysql, we have to delete the prop anyway, as there's no REPLACE!
 			{
 				if (!isset($del_stmt))
 				{
 					$del_stmt = self::$pdo->prepare('DELETE FROM '.self::PROPS_TABLE.' WHERE fs_id=:fs_id AND prop_namespace=:prop_namespace AND prop_name=:prop_name');
+			}
 				}
 				$del_stmt->execute(array(
 					'fs_id'          => $id,
@@ -1914,17 +2205,27 @@ 
 			{
 				if (!($stat = self::url_stat($id,0)))
 				{
-					if (self::LOG_LEVEL) error_log(__METHOD__."(".array2string($path_ids).",$ns) path '$id' not found!");
+					if (self::LOG_LEVEL)
+					{
+						error_log(__METHOD__."(".array2string($path_ids).",$ns) path '$id' not found!");
+					}
 					return false;
 				}
 				$id = $stat['ino'];
 			}
 		}
-		if (count($ids) >= 1) array_map(function(&$v) { $v = (int)$v; },$ids);
+		if (count($ids) >= 1)
+		{
+			array_map(function(&$v) { $v = (int)$v;
+		}
+		},$ids);
 		$query = 'SELECT * FROM '.self::PROPS_TABLE.' WHERE (fs_id'.
 			(count($ids) == 1 ? '='.(int)implode('',$ids) : ' IN ('.implode(',',$ids).')').')'.
 			(!is_null($ns) ? ' AND prop_namespace=?' : '');
-		if (self::LOG_LEVEL > 2) $query = '/* '.__METHOD__.': '.__LINE__.' */ '.$query;
+		if (self::LOG_LEVEL > 2)
+		{
+			$query = '/* '.__METHOD__.': '.__LINE__.' */ '.$query;
+		}
 
 		$stmt = self::$pdo->prepare($query);
 		$stmt->setFetchMode(\PDO::FETCH_ASSOC);
@@ -1943,11 +2244,14 @@ 
 		{
 			$props = $props[$row['fs_id']] ? $props[$row['fs_id']] : array();	// return empty array for no props
 		}
-		elseif ($props && isset($stat))	// need to map fs_id's to pathes
+		elseif ($props && isset($stat))
+		{
+			// need to map fs_id's to pathes
 		{
 			foreach(self::id2path(array_keys($props)) as $id => $path)
 			{
 				$props[$path] =& $props[$id];
+		}
 				unset($props[$id]);
 			}
 		}

api/src/Vfs/StreamWrapper.php

Doc Comments +4 added lines, -4 removed lines

@@ -454,7 +454,7 @@ 
 	 *
 	 * If you have cached data in your stream but not yet stored it into the underlying storage, you should do so now.
 	 *
-	 * @return booelan TRUE if the cached data was successfully stored (or if there was no data to store), or FALSE if the data could not be stored.
+	 * @return boolean TRUE if the cached data was successfully stored (or if there was no data to store), or FALSE if the data could not be stored.
 	 */
 	function stream_flush ( )
 	{
@@ -856,7 +856,7 @@ 
 	 * This method is called immediately when your stream object is created for examining directory contents with opendir().
 	 *
 	 * @param string $path URL that was passed to opendir() and that this object is expected to explore.
-	 * @return booelan
+	 * @return boolean
 	 */
 	function dir_opendir ( $path, $options )
 	{
@@ -1213,7 +1213,7 @@ 
 	 * It should reset the output generated by dir_readdir(). i.e.:
 	 * The next call to dir_readdir() should return the first entry in the location returned by dir_opendir().
 	 *
-	 * @return boolean
+	 * @return boolean|null
 	 */
 	function dir_rewinddir ( )
 	{
@@ -1227,7 +1227,7 @@ 
 	 *
 	 * You should release any resources which were locked or allocated during the opening and use of the directory stream.
 	 *
-	 * @return boolean
+	 * @return boolean|null
 	 */
 	function dir_closedir ( )
 	{

Indentation +3 added lines, -3 removed lines

@@ -411,10 +411,10 @@ 
  	 * Important: PHP 5.0 introduced a bug that wasn't fixed until 5.1: the return value has to be the oposite!
  	 *
  	 * if(version_compare(PHP_VERSION,'5.0','>=') && version_compare(PHP_VERSION,'5.1','<'))
-  	 * {
+ 	 * {
  	 * 		$eof = !$eof;
  	 * }
-  	 *
+ 	 *
  	 * @return boolean true if the read/write position is at the end of the stream and no more data availible, false otherwise
  	 */
 	function stream_eof ( )
@@ -1053,7 +1053,7 @@ 
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."('$path',$flags,'$url'): ".function_backtrace(1));
 
 		while (($rel_path = Vfs::basename($url).($rel_path ? '/'.$rel_path : '')) &&
-		       ($url = Vfs::dirname($url)))
+			   ($url = Vfs::dirname($url)))
 		{
 			if (($stat = self::url_stat($url,0,false,false)))
 			{

Spacing +149 added lines, -150 removed lines

@@ -157,14 +157,14 @@ 
 	 * @param array|boolean &$stat=null on return: stat of existing file or false for non-existing files
 	 * @return string|boolean false if the url cant be resolved, should not happen if fstab has a root entry
 	 */
-	static function resolve_url_symlinks($_path,$file_exists=true,$resolve_last_symlink=true,&$stat=null)
+	static function resolve_url_symlinks($_path, $file_exists = true, $resolve_last_symlink = true, &$stat = null)
 	{
 		$path = self::get_path($_path);
 
-		if (!($stat = self::url_stat($path,$resolve_last_symlink?0:STREAM_URL_STAT_LINK)) && !$file_exists)
+		if (!($stat = self::url_stat($path, $resolve_last_symlink ? 0 : STREAM_URL_STAT_LINK)) && !$file_exists)
 		{
 			$url = null;
-			$stat = self::check_symlink_components($path,0,$url);
+			$stat = self::check_symlink_components($path, 0, $url);
 			if (self::LOG_LEVEL > 1) $log = " (check_symlink_components('$path',0,'$url') = $stat)";
 		}
 		else
@@ -172,9 +172,9 @@ 
 			$url = $stat['url'];
 		}
 		// if the url resolves to a symlink to the vfs, resolve this vfs:// url direct
-		if ($url && self::parse_url($url,PHP_URL_SCHEME) == self::SCHEME)
+		if ($url && self::parse_url($url, PHP_URL_SCHEME) == self::SCHEME)
 		{
-			$url = self::resolve_url(self::parse_url($url,PHP_URL_PATH));
+			$url = self::resolve_url(self::parse_url($url, PHP_URL_PATH));
 		}
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($path,file_exists=$file_exists,resolve_last_symlink=$resolve_last_symlink) = '$url'$log");
 		return $url;
@@ -197,7 +197,7 @@ 
 	 * @param boolean $fix_url_query =false true append relativ path to url query parameter, default not
 	 * @return string|boolean false if the url cant be resolved, should not happen if fstab has a root entry
 	 */
-	static function resolve_url($_path,$do_symlink=true,$use_symlinkcache=true,$replace_user_pass_host=true,$fix_url_query=false)
+	static function resolve_url($_path, $do_symlink = true, $use_symlinkcache = true, $replace_user_pass_host = true, $fix_url_query = false)
 	{
 		$path = self::get_path($_path);
 
@@ -210,52 +210,52 @@ 
 		// check if we can already resolve path (or a part of it) with a known symlinks
 		if ($use_symlinkcache)
 		{
-			$path = self::symlinkCache_resolve($path,$do_symlink);
+			$path = self::symlinkCache_resolve($path, $do_symlink);
 		}
 		// setting default user, passwd and domain, if it's not contained int the url
-		static $defaults=null;
+		static $defaults = null;
 		if (is_null($defaults))
 		{
 			$defaults = array(
 				'user' => $GLOBALS['egw_info']['user']['account_lid'],
 				'pass' => urlencode($GLOBALS['egw_info']['user']['passwd']),
 				'host' => $GLOBALS['egw_info']['user']['domain'],
-				'home' => str_replace(array('\\\\','\\'),array('','/'),$GLOBALS['egw_info']['user']['homedirectory']),
+				'home' => str_replace(array('\\\\', '\\'), array('', '/'), $GLOBALS['egw_info']['user']['homedirectory']),
 			);
 		}
-		$parts = array_merge(self::parse_url($path),$defaults);
-		if (!$parts['host']) $parts['host'] = 'default';	// otherwise we get an invalid url (scheme:///path/to/something)!
+		$parts = array_merge(self::parse_url($path), $defaults);
+		if (!$parts['host']) $parts['host'] = 'default'; // otherwise we get an invalid url (scheme:///path/to/something)!
 
 		if (!empty($parts['scheme']) && $parts['scheme'] != self::SCHEME)
 		{
 			if (self::LOG_LEVEL > 1) error_log(__METHOD__."('$path') = '$path' (path is already an url)");
-			return $path;	// path is already a non-vfs url --> nothing to do
+			return $path; // path is already a non-vfs url --> nothing to do
 		}
 		if (empty($parts['path'])) $parts['path'] = '/';
 
-		foreach(array_reverse(self::$fstab) as $mounted => $url)
+		foreach (array_reverse(self::$fstab) as $mounted => $url)
 		{
-			if ($mounted == '/' || $mounted == $parts['path'] || $mounted.'/' == substr($parts['path'],0,strlen($mounted)+1))
+			if ($mounted == '/' || $mounted == $parts['path'] || $mounted.'/' == substr($parts['path'], 0, strlen($mounted) + 1))
 			{
-				$scheme = self::parse_url($url,PHP_URL_SCHEME);
-				if (is_null(self::$wrappers) || !in_array($scheme,self::$wrappers))
+				$scheme = self::parse_url($url, PHP_URL_SCHEME);
+				if (is_null(self::$wrappers) || !in_array($scheme, self::$wrappers))
 				{
 					self::load_wrapper($scheme);
 				}
-				if (($relative = substr($parts['path'],strlen($mounted))))
+				if (($relative = substr($parts['path'], strlen($mounted))))
 				{
-					$url = Vfs::concat($url,$relative);
+					$url = Vfs::concat($url, $relative);
 				}
 				// if url contains url parameter, eg. from filesystem streamwrapper, we need to append relative path here too
 				$matches = null;
 				if ($fix_url_query && preg_match('|([?&]url=)([^&]+)|', $url, $matches))
 				{
-					$url = str_replace($matches[0], $matches[1].Vfs::concat($matches[2], substr($parts['path'],strlen($mounted))), $url);
+					$url = str_replace($matches[0], $matches[1].Vfs::concat($matches[2], substr($parts['path'], strlen($mounted))), $url);
 				}
 
 				if ($replace_user_pass_host)
 				{
-					$url = str_replace(array('$user','$pass','$host','$home'),array($parts['user'],$parts['pass'],$parts['host'],$parts['home']),$url);
+					$url = str_replace(array('$user', '$pass', '$host', '$home'), array($parts['user'], $parts['pass'], $parts['host'], $parts['home']), $url);
 				}
 				if ($parts['query']) $url .= '?'.$parts['query'];
 				if ($parts['fragment']) $url .= '#'.$parts['fragment'];
@@ -268,7 +268,7 @@ 
 			}
 		}
 		if (self::LOG_LEVEL > 0) error_log(__METHOD__."('$path') can't resolve path!\n");
-		trigger_error(__METHOD__."($path) can't resolve path!\n",E_USER_WARNING);
+		trigger_error(__METHOD__."($path) can't resolve path!\n", E_USER_WARNING);
 		return false;
 	}
 
@@ -280,10 +280,10 @@ 
 	 */
 	static function mount_url($fullurl)
 	{
-		foreach(array_reverse(self::$fstab) as $url)
+		foreach (array_reverse(self::$fstab) as $url)
 		{
-			list($url_no_query) = explode('?',$url);
-			if (substr($fullurl,0,1+strlen($url_no_query)) === $url_no_query.'/')
+			list($url_no_query) = explode('?', $url);
+			if (substr($fullurl, 0, 1 + strlen($url_no_query)) === $url_no_query.'/')
 			{
 				return $url;
 			}
@@ -310,13 +310,13 @@ 
 	 * @param string $opened_path full path of the file/resource, if the open was successfull and STREAM_USE_PATH was set
 	 * @return boolean true if the ressource was opened successful, otherwise false
 	 */
-	function stream_open ( $path, $mode, $options, &$opened_path )
+	function stream_open($path, $mode, $options, &$opened_path)
 	{
-		unset($options,$opened_path);	// not used but required by function signature
+		unset($options, $opened_path); // not used but required by function signature
 		$this->opened_stream = null;
 
 		$stat = null;
-		if (!($url = self::resolve_url_symlinks($path,$mode[0]=='r',true,$stat)))
+		if (!($url = self::resolve_url_symlinks($path, $mode[0] == 'r', true, $stat)))
 		{
 			return false;
 		}
@@ -351,7 +351,7 @@ 
 	 *
 	 * VFS calls either "vfs_read", "vfs_added" or "vfs_modified" hook
 	 */
-	function stream_close ( )
+	function stream_close( )
 	{
 		$ret = fclose($this->opened_stream);
 		// clear PHP's stat cache, it contains wrong size of just closed file,
@@ -361,12 +361,11 @@ 
 		if (isset($GLOBALS['egw']) && isset($GLOBALS['egw']->hooks))
 		{
 			Api\Hooks::process(array(
-				'location' => str_replace('b','',$this->opened_stream_mode) == 'r' ? 'vfs_read' :
-					($this->opened_stream_is_new ? 'vfs_added' : 'vfs_modified'),
+				'location' => str_replace('b', '', $this->opened_stream_mode) == 'r' ? 'vfs_read' : ($this->opened_stream_is_new ? 'vfs_added' : 'vfs_modified'),
 				'path' => $this->opened_stream_path,
 				'mode' => $this->opened_stream_mode,
 				'url'  => $this->opened_stream_url,
-			),'',true);
+			), '', true);
 		}
 		$this->opened_stream = $this->opened_stream_mode = $this->opened_stream_path = $this->opened_stream_url = $this->opened_stream_is_new = null;
 
@@ -384,9 +383,9 @@ 
 	 * @param int $count
 	 * @return string/false up to count bytes read or false on EOF
 	 */
-	function stream_read ( $count )
+	function stream_read($count)
 	{
-		return fread($this->opened_stream,$count);
+		return fread($this->opened_stream, $count);
 	}
 
 	/**
@@ -400,9 +399,9 @@ 
 	 * @param string $data
 	 * @return integer
 	 */
-	function stream_write ( $data )
+	function stream_write($data)
 	{
-		return fwrite($this->opened_stream,$data);
+		return fwrite($this->opened_stream, $data);
 	}
 
  	/**
@@ -417,7 +416,7 @@ 
   	 *
  	 * @return boolean true if the read/write position is at the end of the stream and no more data availible, false otherwise
  	 */
-	function stream_eof ( )
+	function stream_eof( )
 	{
 		return feof($this->opened_stream);
 	}
@@ -427,7 +426,7 @@ 
 	 *
 	 * @return integer current read/write position of the stream
 	 */
- 	function stream_tell ( )
+ 	function stream_tell( )
  	{
  		return ftell($this->opened_stream);
  	}
@@ -444,9 +443,9 @@ 
  	 * 							SEEK_END - 2 - Set position to end-of-file plus offset. (To move to a position before the end-of-file, you need to pass a negative value in offset.)
  	 * @return boolean TRUE if the position was updated, FALSE otherwise.
  	 */
-	function stream_seek ( $offset, $whence )
+	function stream_seek($offset, $whence)
 	{
-		return !fseek($this->opened_stream,$offset,$whence);	// fseek returns 0 on success and -1 on failure
+		return !fseek($this->opened_stream, $offset, $whence); // fseek returns 0 on success and -1 on failure
 	}
 
 	/**
@@ -456,7 +455,7 @@ 
 	 *
 	 * @return booelan TRUE if the cached data was successfully stored (or if there was no data to store), or FALSE if the data could not be stored.
 	 */
-	function stream_flush ( )
+	function stream_flush( )
 	{
 		return fflush($this->opened_stream);
 	}
@@ -475,7 +474,7 @@ 
 	 *
 	 * @return array containing the same values as appropriate for the stream.
 	 */
-	function stream_stat ( )
+	function stream_stat( )
 	{
 		return fstat($this->opened_stream);
 	}
@@ -489,9 +488,9 @@ 
 	 * @param string $path
 	 * @return boolean TRUE on success or FALSE on failure
 	 */
-	static function unlink ( $path )
+	static function unlink($path)
 	{
-		if (!($url = self::resolve_url_symlinks($path,true,false)))	// true,false file need to exist, but do not resolve last component
+		if (!($url = self::resolve_url_symlinks($path, true, false)))	// true,false file need to exist, but do not resolve last component
 		{
 			return false;
 		}
@@ -512,7 +511,7 @@ 
 				'path' => $path[0] == '/' ? $path : self::parse_url($path, PHP_URL_PATH),
 				'url'  => $url,
 				'stat' => $stat,
-			),'',true);
+			), '', true);
 		}
 		return $ok;
 	}
@@ -529,22 +528,22 @@ 
 	 * @param string $path_to
 	 * @return boolean TRUE on success or FALSE on failure
 	 */
-	static function rename ( $path_from, $path_to )
+	static function rename($path_from, $path_to)
 	{
-		if (!($url_from = self::resolve_url_symlinks($path_from,true,false)) ||
-			!($url_to = self::resolve_url_symlinks($path_to,false)))
+		if (!($url_from = self::resolve_url_symlinks($path_from, true, false)) ||
+			!($url_to = self::resolve_url_symlinks($path_to, false)))
 		{
 			return false;
 		}
 		// if file is moved from one filesystem / wrapper to an other --> copy it (rename fails cross wrappers)
-		if (self::parse_url($url_from,PHP_URL_SCHEME) == self::parse_url($url_to,PHP_URL_SCHEME))
+		if (self::parse_url($url_from, PHP_URL_SCHEME) == self::parse_url($url_to, PHP_URL_SCHEME))
 		{
 			self::symlinkCache_remove($path_from);
-			$ret = rename($url_from,$url_to);
+			$ret = rename($url_from, $url_to);
 		}
-		elseif (($from = fopen($url_from,'r')) && ($to = fopen($url_to,'w')))
+		elseif (($from = fopen($url_from, 'r')) && ($to = fopen($url_to, 'w')))
 		{
-			$ret = stream_copy_to_stream($from,$to) !== false;
+			$ret = stream_copy_to_stream($from, $to) !== false;
 			fclose($from);
 			fclose($to);
 			if ($ret) self::unlink($path_from);
@@ -566,7 +565,7 @@ 
 				'to' => $path_to[0] == '/' ? $path_to : self::parse_url($path_to, PHP_URL_PATH),
 				'url_from' => $url_from,
 				'url_to' => $url_to,
-			),'',true);
+			), '', true);
 		}
 		return $ret;
 	}
@@ -582,13 +581,13 @@ 
 	 * @param int $options Posible values include STREAM_REPORT_ERRORS and STREAM_MKDIR_RECURSIVE
 	 * @return boolean TRUE on success or FALSE on failure
 	 */
-	static function mkdir ( $path, $mode, $options )
+	static function mkdir($path, $mode, $options)
 	{
-		if (!($url = self::resolve_url_symlinks($path,false)))	// false = directory does not need to exists
+		if (!($url = self::resolve_url_symlinks($path, false)))	// false = directory does not need to exists
 		{
 			return false;
 		}
-		$ret = mkdir($url,$mode,$options);
+		$ret = mkdir($url, $mode, $options);
 
 		// call "vfs_mkdir" hook
 		if ($ret && isset($GLOBALS['egw']) && isset($GLOBALS['egw']->hooks))
@@ -597,7 +596,7 @@ 
 				'location' => 'vfs_mkdir',
 				'path' => $path[0] == '/' ? $path : self::parse_url($path, PHP_URL_PATH),
 				'url' => $url,
-			),'',true);
+			), '', true);
 		}
 		return $ret;
 	}
@@ -612,9 +611,9 @@ 
 	 * @param int $options Possible values include STREAM_REPORT_ERRORS.
 	 * @return boolean TRUE on success or FALSE on failure.
 	 */
-	static function rmdir ( $path, $options )
+	static function rmdir($path, $options)
 	{
-		unset($options);	// not uses but required by function signature
+		unset($options); // not uses but required by function signature
 		if (!($url = self::resolve_url_symlinks($path)))
 		{
 			return false;
@@ -636,7 +635,7 @@ 
 				'path' => $path[0] == '/' ? $path : self::parse_url($path, PHP_URL_PATH),
 				'url' => $url,
 				'stat' => $stat,
-			),'',true);
+			), '', true);
 		}
 		return $ok;
 	}
@@ -653,60 +652,60 @@ 
 	 * @param int $path_param_key =0 key in params containing the path, default 0
 	 * @return mixed return value of backend or false if function does not exist on backend
 	 */
-	static protected function _call_on_backend($name,$params,$fail_silent=false,$path_param_key=0)
+	static protected function _call_on_backend($name, $params, $fail_silent = false, $path_param_key = 0)
 	{
 		$pathes = $params[$path_param_key];
 
 		$scheme2urls = array();
-		foreach(is_array($pathes) ? $pathes : array($pathes) as $path)
+		foreach (is_array($pathes) ? $pathes : array($pathes) as $path)
 		{
-			if (!($url = self::resolve_url_symlinks($path,false,false)))
+			if (!($url = self::resolve_url_symlinks($path, false, false)))
 			{
 				return false;
 			}
-			$k=(string)self::parse_url($url,PHP_URL_SCHEME);
+			$k = (string)self::parse_url($url, PHP_URL_SCHEME);
 			if (!(is_array($scheme2urls[$k]))) $scheme2urls[$k] = array();
 			$scheme2urls[$k][$path] = $url;
 		}
 		$ret = array();
-		foreach($scheme2urls as $scheme => $urls)
+		foreach ($scheme2urls as $scheme => $urls)
 		{
 			if ($scheme)
 			{
-				if (!class_exists($class = self::scheme2class($scheme)) || !method_exists($class,$name))
+				if (!class_exists($class = self::scheme2class($scheme)) || !method_exists($class, $name))
 				{
-					if (!$fail_silent) trigger_error("Can't $name for scheme $scheme!\n",E_USER_WARNING);
+					if (!$fail_silent) trigger_error("Can't $name for scheme $scheme!\n", E_USER_WARNING);
 					return false;
 				}
 				if (!is_array($pathes))
 				{
 					$params[$path_param_key] = $url;
 
-					return call_user_func_array(array($class,$name),$params);
+					return call_user_func_array(array($class, $name), $params);
 				}
 				$params[$path_param_key] = $urls;
-				if (!is_array($r = call_user_func_array(array($class,$name),$params)))
+				if (!is_array($r = call_user_func_array(array($class, $name), $params)))
 				{
 					return $r;
 				}
 				// we need to re-translate the urls to pathes, as they can eg. contain symlinks
-				foreach($urls as $path => $url)
+				foreach ($urls as $path => $url)
 				{
-					if (isset($r[$url]) || isset($r[$url=self::parse_url($url,PHP_URL_PATH)]))
+					if (isset($r[$url]) || isset($r[$url = self::parse_url($url, PHP_URL_PATH)]))
 					{
 						$ret[$path] = $r[$url];
 					}
 				}
 			}
 			// call the filesystem specific function (dont allow to use arrays!)
-			elseif(!function_exists($name) || is_array($pathes))
+			elseif (!function_exists($name) || is_array($pathes))
 			{
 				return false;
 			}
 			else
 			{
 				$time = null;
-				return $name($url,$time);
+				return $name($url, $time);
 			}
 		}
 		return $ret;
@@ -720,9 +719,9 @@ 
 	 * @param int $atime =null access time (unix timestamp), default null = current time, not implemented in the vfs!
 	 * @return boolean true on success, false otherwise
 	 */
-	static function touch($path,$time=null,$atime=null)
+	static function touch($path, $time = null, $atime = null)
 	{
-		return self::_call_on_backend('touch',array($path,$time,$atime));
+		return self::_call_on_backend('touch', array($path, $time, $atime));
 	}
 
 	/**
@@ -734,9 +733,9 @@ 
 	 * @param string $mode mode string see Vfs::mode2int
 	 * @return boolean true on success, false otherwise
 	 */
-	static function chmod($path,$mode)
+	static function chmod($path, $mode)
 	{
-		return self::_call_on_backend('chmod',array($path,$mode));
+		return self::_call_on_backend('chmod', array($path, $mode));
 	}
 
 	/**
@@ -748,9 +747,9 @@ 
 	 * @param int $owner numeric user id
 	 * @return boolean true on success, false otherwise
 	 */
-	static function chown($path,$owner)
+	static function chown($path, $owner)
 	{
-		return self::_call_on_backend('chown',array($path,$owner));
+		return self::_call_on_backend('chown', array($path, $owner));
 	}
 
 	/**
@@ -762,9 +761,9 @@ 
 	 * @param int $group numeric group id
 	 * @return boolean true on success, false otherwise
 	 */
-	static function chgrp($path,$group)
+	static function chgrp($path, $group)
 	{
-		return self::_call_on_backend('chgrp',array($path,$group));
+		return self::_call_on_backend('chgrp', array($path, $group));
 	}
 
 	/**
@@ -777,7 +776,7 @@ 
 	 */
 	static function readlink($path)
 	{
-		$ret = self::_call_on_backend('readlink',array($path),true);	// true = fail silent, if backend does not support readlink
+		$ret = self::_call_on_backend('readlink', array($path), true); // true = fail silent, if backend does not support readlink
 		//error_log(__METHOD__."('$path') returning ".array2string($ret).' '.function_backtrace());
 		return $ret;
 	}
@@ -791,9 +790,9 @@ 
 	 * @param string $link path of the link to create
 	 * @return boolean true on success, false on error
 	 */
-	static function symlink($target,$link)
+	static function symlink($target, $link)
 	{
-		if (($ret = self::_call_on_backend('symlink',array($target,$link),false,1)))	// 1=path is in $link!
+		if (($ret = self::_call_on_backend('symlink', array($target, $link), false, 1)))	// 1=path is in $link!
 		{
 			self::symlinkCache_remove($link);
 		}
@@ -813,13 +812,13 @@ 
 	 * @param boolean $recheck =false true = do a new check, false = rely on stored mime type (if existing)
 	 * @return string mime-type (self::DIR_MIME_TYPE for directories)
 	 */
-	static function mime_content_type($path,$recheck=false)
+	static function mime_content_type($path, $recheck = false)
 	{
 		if (!($url = self::resolve_url_symlinks($path)))
 		{
 			return false;
 		}
-		if (($scheme = self::parse_url($url,PHP_URL_SCHEME)) && !$recheck)
+		if (($scheme = self::parse_url($url, PHP_URL_SCHEME)) && !$recheck)
 		{
 			// check it it's an eGW stream wrapper returning mime-type via url_stat
 			// we need to first check if the constant is defined, as we get a fatal error in php5.3 otherwise
@@ -827,7 +826,7 @@ 
 				defined($class.'::STAT_RETURN_MIME_TYPE') &&
 				($mime_attr = constant($class.'::STAT_RETURN_MIME_TYPE')))
 			{
-				$stat = call_user_func(array($class,'url_stat'),self::parse_url($url,PHP_URL_PATH),0);
+				$stat = call_user_func(array($class, 'url_stat'), self::parse_url($url, PHP_URL_PATH), 0);
 				if ($stat && $stat[$mime_attr])
 				{
 					$mime = $stat[$mime_attr];
@@ -846,7 +845,7 @@ 
 		// using EGw's own mime magic (currently only checking the extension!)
 		if (!$mime)
 		{
-			$mime = Api\MimeMagic::filename2mime(self::parse_url($url,PHP_URL_PATH));
+			$mime = Api\MimeMagic::filename2mime(self::parse_url($url, PHP_URL_PATH));
 		}
 		//error_log(__METHOD__."($path,$recheck) mime=$mime");
 		return $mime;
@@ -858,7 +857,7 @@ 
 	 * @param string $path URL that was passed to opendir() and that this object is expected to explore.
 	 * @return booelan
 	 */
-	function dir_opendir ( $path, $options )
+	function dir_opendir($path, $options)
 	{
 		$this->opened_dir = $this->extra_dirs = null;
 		$this->dir_url_params = array();
@@ -875,15 +874,15 @@ 
 			if (self::LOG_LEVEL > 0) error_log(__METHOD__."( $path,$options) opendir($this->opened_dir_url) failed!");
 			return false;
 		}
-		$this->opened_dir_writable = Vfs::check_access($this->opened_dir_url,Vfs::WRITABLE);
+		$this->opened_dir_writable = Vfs::check_access($this->opened_dir_url, Vfs::WRITABLE);
 		// check our fstab if we need to add some of the mountpoints
-		$basepath = self::parse_url($path,PHP_URL_PATH);
-		foreach(array_keys(self::$fstab) as $mounted)
+		$basepath = self::parse_url($path, PHP_URL_PATH);
+		foreach (array_keys(self::$fstab) as $mounted)
 		{
 			if (((Vfs::dirname($mounted) == $basepath || Vfs::dirname($mounted).'/' == $basepath) && $mounted != '/') &&
 				// only return children readable by the user, if dir is not writable
 				(!self::HIDE_UNREADABLES || $this->opened_dir_writable ||
-					Vfs::check_access($mounted,Vfs::READABLE)))
+					Vfs::check_access($mounted, Vfs::READABLE)))
 			{
 				$this->extra_dirs[] = basename($mounted);
 			}
@@ -922,24 +921,24 @@ 
 	 * @param boolean $check_symlink_components =true check if path contains symlinks in path components other then the last one
 	 * @return array
 	 */
-	static function url_stat ( $path, $flags, $try_create_home=false, $check_symlink_components=true, $check_symlink_depth=self::MAX_SYMLINK_DEPTH, $try_reconnect=true )
+	static function url_stat($path, $flags, $try_create_home = false, $check_symlink_components = true, $check_symlink_depth = self::MAX_SYMLINK_DEPTH, $try_reconnect = true)
 	{
-		if (!($url = self::resolve_url($path,!($flags & STREAM_URL_STAT_LINK), $check_symlink_components)))
+		if (!($url = self::resolve_url($path, !($flags&STREAM_URL_STAT_LINK), $check_symlink_components)))
 		{
 			if (self::LOG_LEVEL > 0) error_log(__METHOD__."('$path',$flags) can NOT resolve path!");
 			return false;
 		}
 
 		try {
-			if ($flags & STREAM_URL_STAT_LINK)
+			if ($flags&STREAM_URL_STAT_LINK)
 			{
-				$stat = @lstat($url);	// suppressed the stat failed warnings
+				$stat = @lstat($url); // suppressed the stat failed warnings
 			}
 			else
 			{
-				$stat = @stat($url);	// suppressed the stat failed warnings
+				$stat = @stat($url); // suppressed the stat failed warnings
 
-				if ($stat && ($stat['mode'] & self::MODE_LINK))
+				if ($stat && ($stat['mode']&self::MODE_LINK))
 				{
 					if (!$check_symlink_depth)
 					{
@@ -950,25 +949,25 @@ 
 					{
 						if ($lpath[0] != '/')	// concat relative path
 						{
-							$lpath = Vfs::concat(self::parse_url($path,PHP_URL_PATH),'../'.$lpath);
+							$lpath = Vfs::concat(self::parse_url($path, PHP_URL_PATH), '../'.$lpath);
 						}
-						$u_query = parse_url($url,PHP_URL_QUERY);
+						$u_query = parse_url($url, PHP_URL_QUERY);
 						$url = Vfs::PREFIX.$lpath;
 						if (self::LOG_LEVEL > 1) error_log(__METHOD__."($path,$flags) symlif (substr($path,-1) == '/' && $path != '/') $path = substr($path,0,-1);	// remove trailing slash eg. added by WebDAVink found and resolved to $url");
 						// try reading the stat of the link
-						if (($stat = self::url_stat($lpath, STREAM_URL_STAT_QUIET, false, true, $check_symlink_depth-1)))
+						if (($stat = self::url_stat($lpath, STREAM_URL_STAT_QUIET, false, true, $check_symlink_depth - 1)))
 						{
 							$stat_query = parse_url($stat['url'], PHP_URL_QUERY);
-							if($u_query || $stat_query)
+							if ($u_query || $stat_query)
 							{
 								$stat_url = parse_url($stat['url']);
-								parse_str($stat_query,$stat_query);
+								parse_str($stat_query, $stat_query);
 								parse_str($u_query, $u_query);
 								$stat_query = http_build_query(array_merge($stat_query, $u_query));
 								$stat['url'] = $stat_url['scheme'].'://'.$stat_url['host'].$stat_url['path'].'?'.$stat_query;
 							}
-							if(isset($stat['url'])) $url = $stat['url'];	// if stat returns an url use that, as there might be more links ...
-							self::symlinkCache_add($path,$url);
+							if (isset($stat['url'])) $url = $stat['url']; // if stat returns an url use that, as there might be more links ...
+							self::symlinkCache_add($path, $url);
 						}
 					}
 				}
@@ -988,7 +987,7 @@ 
 			throw $e;
 		}
 		// check if a failed url_stat was for a home dir, in that case silently create it
-		if (!$stat && $try_create_home && Vfs::dirname(self::parse_url($path,PHP_URL_PATH)) == '/home' &&
+		if (!$stat && $try_create_home && Vfs::dirname(self::parse_url($path, PHP_URL_PATH)) == '/home' &&
 			($id = $GLOBALS['egw']->accounts->name2id(basename($path))) &&
 			$GLOBALS['egw']->accounts->id2name($id) == basename($path))	// make sure path has the right case!
 		{
@@ -998,25 +997,25 @@ 
 				'account_lid' => basename($path),
 				'account_name' => basename($path),
 			);
-			call_user_func(array(__NAMESPACE__.'\\Hooks',$hook_data['location']),$hook_data);
+			call_user_func(array(__NAMESPACE__.'\\Hooks', $hook_data['location']), $hook_data);
 			unset($hook_data);
-			$stat = self::url_stat($path,$flags,false);
+			$stat = self::url_stat($path, $flags, false);
 		}
 		$query = parse_url($url, PHP_URL_QUERY);
 		if (!$stat && $check_symlink_components)	// check if there's a symlink somewhere inbetween the path
 		{
-			$stat = self::check_symlink_components($path,$flags,$url);
-			if ($stat && isset($stat['url']) && !$query) self::symlinkCache_add($path,$stat['url']);
+			$stat = self::check_symlink_components($path, $flags, $url);
+			if ($stat && isset($stat['url']) && !$query) self::symlinkCache_add($path, $stat['url']);
 		}
-		elseif(is_array($stat) && !isset($stat['url']))
+		elseif (is_array($stat) && !isset($stat['url']))
 		{
 			$stat['url'] = $url;
 		}
-		if (($stat['mode'] & 0222) && self::url_is_readonly($stat['url']))
+		if (($stat['mode']&0222) && self::url_is_readonly($stat['url']))
 		{
 			$stat['mode'] &= ~0222;
 		}
-		if($stat['url'] && $query && strpos($stat['url'],'?'.$query)===false)
+		if ($stat['url'] && $query && strpos($stat['url'], '?'.$query) === false)
 		{
 			$stat['url'] .= '?'.$query;
 		}
@@ -1043,7 +1042,7 @@ 
 	 * @param string &$url=null already resolved path
 	 * @return array|boolean stat array or false if not found
 	 */
-	static private function check_symlink_components($path,$flags=0,&$url=null)
+	static private function check_symlink_components($path, $flags = 0, &$url = null)
 	{
 		if (is_null($url) && !($url = self::resolve_url($path)))
 		{
@@ -1055,7 +1054,7 @@ 
 		while (($rel_path = Vfs::basename($url).($rel_path ? '/'.$rel_path : '')) &&
 		       ($url = Vfs::dirname($url)))
 		{
-			if (($stat = self::url_stat($url,0,false,false)))
+			if (($stat = self::url_stat($url, 0, false, false)))
 			{
 				if (is_link($url) && ($lpath = self::readlink($url)))
 				{
@@ -1063,20 +1062,20 @@ 
 
 					if ($lpath[0] != '/')
 					{
-						$lpath = Vfs::concat(self::parse_url($url,PHP_URL_PATH),'../'.$lpath);
+						$lpath = Vfs::concat(self::parse_url($url, PHP_URL_PATH), '../'.$lpath);
 					}
 					//self::symlinkCache_add($path,Vfs::PREFIX.$lpath);
-					$url = Vfs::PREFIX.Vfs::concat($lpath,$rel_path);
+					$url = Vfs::PREFIX.Vfs::concat($lpath, $rel_path);
 					if (self::LOG_LEVEL > 1) error_log("$log --> lpath='$lpath', url='$url'");
-					return self::url_stat($url,$flags);
+					return self::url_stat($url, $flags);
 				}
-				$url = Vfs::concat($url,$rel_path);
+				$url = Vfs::concat($url, $rel_path);
 				if (self::LOG_LEVEL > 1) error_log(__METHOD__."('$path',$flags,'$url') returning null");
 				return null;
 			}
 		}
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."('$path',$flags,'$url') returning false");
-		return false;	// $path does not exist
+		return false; // $path does not exist
 	}
 
 	/**
@@ -1092,13 +1091,13 @@ 
 	 * @param string $_path vfs path
 	 * @param string $target target path
 	 */
-	static protected function symlinkCache_add($_path,$target)
+	static protected function symlinkCache_add($_path, $target)
 	{
 		$path = self::get_path($_path);
 
-		if (isset(self::$symlink_cache[$path])) return;	// nothing to do
+		if (isset(self::$symlink_cache[$path])) return; // nothing to do
 
-		if ($target[0] != '/') $target = self::parse_url($target,PHP_URL_PATH);
+		if ($target[0] != '/') $target = self::parse_url($target, PHP_URL_PATH);
 
 		self::$symlink_cache[$path] = $target;
 
@@ -1132,25 +1131,25 @@ 
 	 * @param boolean $do_symlink =true is a direct match allowed, default yes (must be false for a lstat or readlink!)
 	 * @return string target or path, if path not found
 	 */
-	static public function symlinkCache_resolve($_path,$do_symlink=true)
+	static public function symlinkCache_resolve($_path, $do_symlink = true)
 	{
 		// remove vfs scheme, but no other schemes (eg. filesystem!)
 		$path = self::get_path($_path);
 
 		$strlen_path = strlen($path);
 
-		foreach(self::$symlink_cache as $p => $t)
+		foreach (self::$symlink_cache as $p => $t)
 		{
-			if (($strlen_p = strlen($p)) > $strlen_path) continue;	// $path can NOT start with $p
+			if (($strlen_p = strlen($p)) > $strlen_path) continue; // $path can NOT start with $p
 
 			if ($path == $p)
 			{
 				if ($do_symlink) $target = $t;
 				break;
 			}
-			elseif (substr($path,0,$strlen_p+1) == $p.'/')
+			elseif (substr($path, 0, $strlen_p + 1) == $p.'/')
 			{
-				$target = $t . substr($path,$strlen_p);
+				$target = $t.substr($path, $strlen_p);
 				break;
 			}
 		}
@@ -1168,7 +1167,7 @@ 
 	 *
 	 * @param string $path ='/' path of backend, whos cache to clear
 	 */
-	static function clearstatcache($path='/')
+	static function clearstatcache($path = '/')
 	{
 		//error_log(__METHOD__."('$path')");
 		self::$symlink_cache = self::$resolve_url_cache = array();
@@ -1186,7 +1185,7 @@ 
 	 *
 	 * @return string
 	 */
-	function dir_readdir ( )
+	function dir_readdir( )
 	{
 		if ($this->extra_dirs && count($this->extra_dirs) > $this->extra_dir_ptr)
 		{
@@ -1198,10 +1197,10 @@ 
 			do {
 				$file = readdir($this->opened_dir);
 			}
-			while($file !== false &&
-				(is_array($this->extra_dirs) && in_array($file,$this->extra_dirs) || // do NOT return extra_dirs twice
+			while ($file !== false &&
+				(is_array($this->extra_dirs) && in_array($file, $this->extra_dirs) || // do NOT return extra_dirs twice
 				self::HIDE_UNREADABLES && !$this->opened_dir_writable &&
-				!Vfs::check_access(Vfs::concat($this->opened_dir_url,$file),Vfs::READABLE)));
+				!Vfs::check_access(Vfs::concat($this->opened_dir_url, $file), Vfs::READABLE)));
 		}
 		if (self::LOG_LEVEL > 1) error_log(__METHOD__."( $this->opened_dir ) = '$file'");
 		return $file;
@@ -1215,7 +1214,7 @@ 
 	 *
 	 * @return boolean
 	 */
-	function dir_rewinddir ( )
+	function dir_rewinddir( )
 	{
 		$this->extra_dir_ptr = 0;
 
@@ -1229,7 +1228,7 @@ 
 	 *
 	 * @return boolean
 	 */
-	function dir_closedir ( )
+	function dir_closedir( )
 	{
 		$ret = closedir($this->opened_dir);
 
@@ -1246,9 +1245,9 @@ 
 	 */
 	static function load_wrapper($scheme)
 	{
-		if (!in_array($scheme,self::get_wrappers()))
+		if (!in_array($scheme, self::get_wrappers()))
 		{
-			switch($scheme)
+			switch ($scheme)
 			{
 				case 'webdav':
 				case 'webdavs':
@@ -1256,16 +1255,16 @@ 
 					self::$wrappers[] = $scheme;
 					break;
 				case '':
-					break;	// default file, always loaded
+					break; // default file, always loaded
 				default:
 					// check if scheme is buildin in php or one of our own stream wrappers
-					if (in_array($scheme,stream_get_wrappers()) || class_exists(self::scheme2class($scheme)))
+					if (in_array($scheme, stream_get_wrappers()) || class_exists(self::scheme2class($scheme)))
 					{
 						self::$wrappers[] = $scheme;
 					}
 					else
 					{
-						trigger_error("Can't load stream-wrapper for scheme '$scheme'!",E_USER_WARNING);
+						trigger_error("Can't load stream-wrapper for scheme '$scheme'!", E_USER_WARNING);
 						return false;
 					}
 			}
@@ -1299,10 +1298,10 @@ 
 	static function scheme2class($scheme)
 	{
 		list($app, $app_scheme) = explode('.', $scheme);
-		foreach(array(
-			empty($app_scheme) ? 'EGroupware\\Api\\Vfs\\'.ucfirst($scheme).'\\StreamWrapper' :	// streamwrapper in Api\Vfs
+		foreach (array(
+			empty($app_scheme) ? 'EGroupware\\Api\\Vfs\\'.ucfirst($scheme).'\\StreamWrapper' : // streamwrapper in Api\Vfs
 				'EGroupware\\'.ucfirst($app).'\\Vfs\\'.ucfirst($app_scheme).'\\StreamWrapper', // streamwrapper in $app\Vfs
-			str_replace('.','_',$scheme).'_stream_wrapper',	// old (flat) name
+			str_replace('.', '_', $scheme).'_stream_wrapper', // old (flat) name
 		) as $class)
 		{
 			//error_log(__METHOD__."('$scheme') class_exists('$class')=".array2string(class_exists($class)));
@@ -1319,7 +1318,7 @@ 
 	 * @param int $component =-1 PHP_URL_* constants
 	 * @return array|string|boolean on success array or string, if $component given, or false on failure
 	 */
-	static function parse_url($url, $component=-1)
+	static function parse_url($url, $component = -1)
 	{
 		static $component2str = array(
 			PHP_URL_SCHEME => 'scheme',
@@ -1331,9 +1330,9 @@ 
 			PHP_URL_QUERY => 'query',
 			PHP_URL_FRAGMENT => 'fragment',
 		);
-		static $cache = array();	// some caching
+		static $cache = array(); // some caching
 
-		$result =& $cache[$url];
+		$result = & $cache[$url];
 
 		if (!isset($result))
 		{
@@ -1370,7 +1369,7 @@ 
 	 * @param string $only_remove_scheme =self::SCHEME if given only that scheme get's removed
 	 * @return string path without training slash
 	 */
-	static protected function get_path($path,$only_remove_scheme=self::SCHEME)
+	static protected function get_path($path, $only_remove_scheme = self::SCHEME)
 	{
 		if ($path[0] != '/' && (!$only_remove_scheme || self::parse_url($path, PHP_URL_SCHEME) == $only_remove_scheme))
 		{
@@ -1381,7 +1380,7 @@ 
 		{
 			while (mb_substr($path, -1) == '/' && $path != '/' && ($path[0] == '/' || self::parse_url($path, PHP_URL_PATH) != '/'))
 			{
-				$path = mb_substr($path,0,-1);
+				$path = mb_substr($path, 0, -1);
 			}
 		}
 		return $path;
@@ -1396,7 +1395,7 @@ 
 	static function url_is_readonly($url)
 	{
 		static $cache = array();
-		$ret =& $cache[$url];
+		$ret = & $cache[$url];
 		if (!isset($ret))
 		{
 			$matches = null;
@@ -1411,7 +1410,7 @@ 
 	 */
 	static function init_static()
 	{
-		stream_register_wrapper(self::SCHEME,__CLASS__);
+		stream_register_wrapper(self::SCHEME, __CLASS__);
 
 		if (($fstab = $GLOBALS['egw_info']['server']['vfs_fstab']) && is_array($fstab) && count($fstab))
 		{

Braces +184 added lines, -45 removed lines

@@ -165,7 +165,10 @@ 
 		{
 			$url = null;
 			$stat = self::check_symlink_components($path,0,$url);
-			if (self::LOG_LEVEL > 1) $log = " (check_symlink_components('$path',0,'$url') = $stat)";
+			if (self::LOG_LEVEL > 1)
+			{
+				$log = " (check_symlink_components('$path',0,'$url') = $stat)";
+			}
 		}
 		else
 		{
@@ -176,7 +179,10 @@ 
 		{
 			$url = self::resolve_url(self::parse_url($url,PHP_URL_PATH));
 		}
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($path,file_exists=$file_exists,resolve_last_symlink=$resolve_last_symlink) = '$url'$log");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."($path,file_exists=$file_exists,resolve_last_symlink=$resolve_last_symlink) = '$url'$log");
+		}
 		return $url;
 	}
 
@@ -204,7 +210,10 @@ 
 		// we do some caching here
 		if (isset(self::$resolve_url_cache[$path]) && $replace_user_pass_host)
 		{
-			if (self::LOG_LEVEL > 1) error_log(__METHOD__."('$path') = '".self::$resolve_url_cache[$path]."' (from cache)");
+			if (self::LOG_LEVEL > 1)
+			{
+				error_log(__METHOD__."('$path') = '".self::$resolve_url_cache[$path]."' (from cache)");
+			}
 			return self::$resolve_url_cache[$path];
 		}
 		// check if we can already resolve path (or a part of it) with a known symlinks
@@ -224,14 +233,24 @@ 
 			);
 		}
 		$parts = array_merge(self::parse_url($path),$defaults);
-		if (!$parts['host']) $parts['host'] = 'default';	// otherwise we get an invalid url (scheme:///path/to/something)!
+		if (!$parts['host'])
+		{
+			$parts['host'] = 'default';
+		}
+		// otherwise we get an invalid url (scheme:///path/to/something)!
 
 		if (!empty($parts['scheme']) && $parts['scheme'] != self::SCHEME)
 		{
-			if (self::LOG_LEVEL > 1) error_log(__METHOD__."('$path') = '$path' (path is already an url)");
+			if (self::LOG_LEVEL > 1)
+			{
+				error_log(__METHOD__."('$path') = '$path' (path is already an url)");
+			}
 			return $path;	// path is already a non-vfs url --> nothing to do
 		}
-		if (empty($parts['path'])) $parts['path'] = '/';
+		if (empty($parts['path']))
+		{
+			$parts['path'] = '/';
+		}
 
 		foreach(array_reverse(self::$fstab) as $mounted => $url)
 		{
@@ -257,17 +276,32 @@ 
 				{
 					$url = str_replace(array('$user','$pass','$host','$home'),array($parts['user'],$parts['pass'],$parts['host'],$parts['home']),$url);
 				}
-				if ($parts['query']) $url .= '?'.$parts['query'];
-				if ($parts['fragment']) $url .= '#'.$parts['fragment'];
+				if ($parts['query'])
+				{
+					$url .= '?'.$parts['query'];
+				}
+				if ($parts['fragment'])
+				{
+					$url .= '#'.$parts['fragment'];
+				}
 
-				if (self::LOG_LEVEL > 1) error_log(__METHOD__."('$path') = '$url'");
+				if (self::LOG_LEVEL > 1)
+				{
+					error_log(__METHOD__."('$path') = '$url'");
+				}
 
-				if ($replace_user_pass_host) self::$resolve_url_cache[$path] = $url;
+				if ($replace_user_pass_host)
+				{
+					self::$resolve_url_cache[$path] = $url;
+				}
 
 				return $url;
 			}
 		}
-		if (self::LOG_LEVEL > 0) error_log(__METHOD__."('$path') can't resolve path!\n");
+		if (self::LOG_LEVEL > 0)
+		{
+			error_log(__METHOD__."('$path') can't resolve path!\n");
+		}
 		trigger_error(__METHOD__."($path) can't resolve path!\n",E_USER_WARNING);
 		return false;
 	}
@@ -491,10 +525,13 @@ 
 	 */
 	static function unlink ( $path )
 	{
-		if (!($url = self::resolve_url_symlinks($path,true,false)))	// true,false file need to exist, but do not resolve last component
+		if (!($url = self::resolve_url_symlinks($path,true,false)))
+		{
+			// true,false file need to exist, but do not resolve last component
 		{
 			return false;
 		}
+		}
 		if (self::url_is_readonly($url))
 		{
 			return false;
@@ -547,7 +584,10 @@ 
 			$ret = stream_copy_to_stream($from,$to) !== false;
 			fclose($from);
 			fclose($to);
-			if ($ret) self::unlink($path_from);
+			if ($ret)
+			{
+				self::unlink($path_from);
+			}
 		}
 		else
 		{
@@ -584,10 +624,13 @@ 
 	 */
 	static function mkdir ( $path, $mode, $options )
 	{
-		if (!($url = self::resolve_url_symlinks($path,false)))	// false = directory does not need to exists
+		if (!($url = self::resolve_url_symlinks($path,false)))
+		{
+			// false = directory does not need to exists
 		{
 			return false;
 		}
+		}
 		$ret = mkdir($url,$mode,$options);
 
 		// call "vfs_mkdir" hook
@@ -665,7 +708,10 @@ 
 				return false;
 			}
 			$k=(string)self::parse_url($url,PHP_URL_SCHEME);
-			if (!(is_array($scheme2urls[$k]))) $scheme2urls[$k] = array();
+			if (!(is_array($scheme2urls[$k])))
+			{
+				$scheme2urls[$k] = array();
+			}
 			$scheme2urls[$k][$path] = $url;
 		}
 		$ret = array();
@@ -675,7 +721,10 @@ 
 			{
 				if (!class_exists($class = self::scheme2class($scheme)) || !method_exists($class,$name))
 				{
-					if (!$fail_silent) trigger_error("Can't $name for scheme $scheme!\n",E_USER_WARNING);
+					if (!$fail_silent)
+					{
+						trigger_error("Can't $name for scheme $scheme!\n",E_USER_WARNING);
+					}
 					return false;
 				}
 				if (!is_array($pathes))
@@ -793,10 +842,13 @@ 
 	 */
 	static function symlink($target,$link)
 	{
-		if (($ret = self::_call_on_backend('symlink',array($target,$link),false,1)))	// 1=path is in $link!
+		if (($ret = self::_call_on_backend('symlink',array($target,$link),false,1)))
+		{
+			// 1=path is in $link!
 		{
 			self::symlinkCache_remove($link);
 		}
+		}
 		return $ret;
 	}
 
@@ -866,13 +918,19 @@ 
 
 		if (!($this->opened_dir_url = self::resolve_url_symlinks($path)))
 		{
-			if (self::LOG_LEVEL > 0) error_log(__METHOD__."( $path,$options) resolve_url_symlinks() failed!");
+			if (self::LOG_LEVEL > 0)
+			{
+				error_log(__METHOD__."( $path,$options) resolve_url_symlinks() failed!");
+			}
 			return false;
 		}
 		if (!($this->opened_dir = $this->context ?
 			opendir($this->opened_dir_url, $this->context) : opendir($this->opened_dir_url)))
 		{
-			if (self::LOG_LEVEL > 0) error_log(__METHOD__."( $path,$options) opendir($this->opened_dir_url) failed!");
+			if (self::LOG_LEVEL > 0)
+			{
+				error_log(__METHOD__."( $path,$options) opendir($this->opened_dir_url) failed!");
+			}
 			return false;
 		}
 		$this->opened_dir_writable = Vfs::check_access($this->opened_dir_url,Vfs::WRITABLE);
@@ -890,7 +948,10 @@ 
 		}
 
 
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."( $path,$options): opendir($this->opened_dir_url)=$this->opened_dir, extra_dirs=".array2string($this->extra_dirs).', '.function_backtrace());
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."( $path,$options): opendir($this->opened_dir_url)=$this->opened_dir, extra_dirs=".array2string($this->extra_dirs).', '.function_backtrace());
+		}
 		return true;
 	}
 
@@ -926,7 +987,10 @@ 
 	{
 		if (!($url = self::resolve_url($path,!($flags & STREAM_URL_STAT_LINK), $check_symlink_components)))
 		{
-			if (self::LOG_LEVEL > 0) error_log(__METHOD__."('$path',$flags) can NOT resolve path!");
+			if (self::LOG_LEVEL > 0)
+			{
+				error_log(__METHOD__."('$path',$flags) can NOT resolve path!");
+			}
 			return false;
 		}
 
@@ -943,18 +1007,27 @@ 
 				{
 					if (!$check_symlink_depth)
 					{
-						if (self::LOG_LEVEL > 0) error_log(__METHOD__."('$path',$flags) maximum symlink depth exceeded, might be a circular symlink!");
+						if (self::LOG_LEVEL > 0)
+						{
+							error_log(__METHOD__."('$path',$flags) maximum symlink depth exceeded, might be a circular symlink!");
+						}
 						$stat = false;
 					}
 					elseif (($lpath = self::readlink($url)))
 					{
-						if ($lpath[0] != '/')	// concat relative path
+						if ($lpath[0] != '/')
+						{
+							// concat relative path
 						{
 							$lpath = Vfs::concat(self::parse_url($path,PHP_URL_PATH),'../'.$lpath);
 						}
+						}
 						$u_query = parse_url($url,PHP_URL_QUERY);
 						$url = Vfs::PREFIX.$lpath;
-						if (self::LOG_LEVEL > 1) error_log(__METHOD__."($path,$flags) symlif (substr($path,-1) == '/' && $path != '/') $path = substr($path,0,-1);	// remove trailing slash eg. added by WebDAVink found and resolved to $url");
+						if (self::LOG_LEVEL > 1)
+						{
+							error_log(__METHOD__."($path,$flags) symlif (substr($path,-1) == '/' && $path != '/') $path = substr($path,0,-1);	// remove trailing slash eg. added by WebDAVink found and resolved to $url");
+						}
 						// try reading the stat of the link
 						if (($stat = self::url_stat($lpath, STREAM_URL_STAT_QUIET, false, true, $check_symlink_depth-1)))
 						{
@@ -967,7 +1040,11 @@ 
 								$stat_query = http_build_query(array_merge($stat_query, $u_query));
 								$stat['url'] = $stat_url['scheme'].'://'.$stat_url['host'].$stat_url['path'].'?'.$stat_query;
 							}
-							if(isset($stat['url'])) $url = $stat['url'];	// if stat returns an url use that, as there might be more links ...
+							if(isset($stat['url']))
+							{
+								$url = $stat['url'];
+							}
+							// if stat returns an url use that, as there might be more links ...
 							self::symlinkCache_add($path,$url);
 						}
 					}
@@ -990,7 +1067,9 @@ 
 		// check if a failed url_stat was for a home dir, in that case silently create it
 		if (!$stat && $try_create_home && Vfs::dirname(self::parse_url($path,PHP_URL_PATH)) == '/home' &&
 			($id = $GLOBALS['egw']->accounts->name2id(basename($path))) &&
-			$GLOBALS['egw']->accounts->id2name($id) == basename($path))	// make sure path has the right case!
+			$GLOBALS['egw']->accounts->id2name($id) == basename($path))
+		{
+			// make sure path has the right case!
 		{
 			$hook_data = array(
 				'location' => $GLOBALS['egw']->accounts->get_type($id) == 'g' ? 'addgroup' : 'addaccount',
@@ -998,15 +1077,22 @@ 
 				'account_lid' => basename($path),
 				'account_name' => basename($path),
 			);
+		}
 			call_user_func(array(__NAMESPACE__.'\\Hooks',$hook_data['location']),$hook_data);
 			unset($hook_data);
 			$stat = self::url_stat($path,$flags,false);
 		}
 		$query = parse_url($url, PHP_URL_QUERY);
-		if (!$stat && $check_symlink_components)	// check if there's a symlink somewhere inbetween the path
+		if (!$stat && $check_symlink_components)
+		{
+			// check if there's a symlink somewhere inbetween the path
 		{
 			$stat = self::check_symlink_components($path,$flags,$url);
-			if ($stat && isset($stat['url']) && !$query) self::symlinkCache_add($path,$stat['url']);
+		}
+			if ($stat && isset($stat['url']) && !$query)
+			{
+				self::symlinkCache_add($path,$stat['url']);
+			}
 		}
 		elseif(is_array($stat) && !isset($stat['url']))
 		{
@@ -1021,7 +1107,10 @@ 
 			$stat['url'] .= '?'.$query;
 		}
 
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."('$path',$flags,try_create_home=$try_create_home,check_symlink_components=$check_symlink_components) returning ".array2string($stat));
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."('$path',$flags,try_create_home=$try_create_home,check_symlink_components=$check_symlink_components) returning ".array2string($stat));
+		}
 
 		return $stat;
 
@@ -1047,10 +1136,16 @@ 
 	{
 		if (is_null($url) && !($url = self::resolve_url($path)))
 		{
-			if (self::LOG_LEVEL > 0) error_log(__METHOD__."('$path',$flags,'$url') can NOT resolve path: ".function_backtrace(1));
+			if (self::LOG_LEVEL > 0)
+			{
+				error_log(__METHOD__."('$path',$flags,'$url') can NOT resolve path: ".function_backtrace(1));
+			}
 			return false;
 		}
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."('$path',$flags,'$url'): ".function_backtrace(1));
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."('$path',$flags,'$url'): ".function_backtrace(1));
+		}
 
 		while (($rel_path = Vfs::basename($url).($rel_path ? '/'.$rel_path : '')) &&
 		       ($url = Vfs::dirname($url)))
@@ -1059,7 +1154,10 @@ 
 			{
 				if (is_link($url) && ($lpath = self::readlink($url)))
 				{
-					if (self::LOG_LEVEL > 1) $log = "rel_path='$rel_path', url='$url': lpath='$lpath'";
+					if (self::LOG_LEVEL > 1)
+					{
+						$log = "rel_path='$rel_path', url='$url': lpath='$lpath'";
+					}
 
 					if ($lpath[0] != '/')
 					{
@@ -1067,15 +1165,24 @@ 
 					}
 					//self::symlinkCache_add($path,Vfs::PREFIX.$lpath);
 					$url = Vfs::PREFIX.Vfs::concat($lpath,$rel_path);
-					if (self::LOG_LEVEL > 1) error_log("$log --> lpath='$lpath', url='$url'");
+					if (self::LOG_LEVEL > 1)
+					{
+						error_log("$log --> lpath='$lpath', url='$url'");
+					}
 					return self::url_stat($url,$flags);
 				}
 				$url = Vfs::concat($url,$rel_path);
-				if (self::LOG_LEVEL > 1) error_log(__METHOD__."('$path',$flags,'$url') returning null");
+				if (self::LOG_LEVEL > 1)
+				{
+					error_log(__METHOD__."('$path',$flags,'$url') returning null");
+				}
 				return null;
 			}
 		}
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."('$path',$flags,'$url') returning false");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."('$path',$flags,'$url') returning false");
+		}
 		return false;	// $path does not exist
 	}
 
@@ -1096,9 +1203,16 @@ 
 	{
 		$path = self::get_path($_path);
 
-		if (isset(self::$symlink_cache[$path])) return;	// nothing to do
+		if (isset(self::$symlink_cache[$path]))
+		{
+			return;
+		}
+		// nothing to do
 
-		if ($target[0] != '/') $target = self::parse_url($target,PHP_URL_PATH);
+		if ($target[0] != '/')
+		{
+			$target = self::parse_url($target,PHP_URL_PATH);
+		}
 
 		self::$symlink_cache[$path] = $target;
 
@@ -1107,7 +1221,10 @@ 
 		{
 			return strlen($a) - strlen($b);
 		});
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($path,$target) cache now ".array2string(self::$symlink_cache));
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."($path,$target) cache now ".array2string(self::$symlink_cache));
+		}
 	}
 
 	/**
@@ -1120,7 +1237,10 @@ 
 		$path = self::get_path($_path);
 
 		unset(self::$symlink_cache[$path]);
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($path) cache now ".array2string(self::$symlink_cache));
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."($path) cache now ".array2string(self::$symlink_cache));
+		}
 	}
 
 	/**
@@ -1141,11 +1261,18 @@ 
 
 		foreach(self::$symlink_cache as $p => $t)
 		{
-			if (($strlen_p = strlen($p)) > $strlen_path) continue;	// $path can NOT start with $p
+			if (($strlen_p = strlen($p)) > $strlen_path)
+			{
+				continue;
+			}
+			// $path can NOT start with $p
 
 			if ($path == $p)
 			{
-				if ($do_symlink) $target = $t;
+				if ($do_symlink)
+				{
+					$target = $t;
+				}
 				break;
 			}
 			elseif (substr($path,0,$strlen_p+1) == $p.'/')
@@ -1154,7 +1281,10 @@ 
 				break;
 			}
 		}
-		if (self::LOG_LEVEL > 1 && isset($target)) error_log(__METHOD__."($path) = $target");
+		if (self::LOG_LEVEL > 1 && isset($target))
+		{
+			error_log(__METHOD__."($path) = $target");
+		}
 		return isset($target) ? $target : $path;
 	}
 
@@ -1203,7 +1333,10 @@ 
 				self::HIDE_UNREADABLES && !$this->opened_dir_writable &&
 				!Vfs::check_access(Vfs::concat($this->opened_dir_url,$file),Vfs::READABLE)));
 		}
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."( $this->opened_dir ) = '$file'");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."( $this->opened_dir ) = '$file'");
+		}
 		return $file;
 	}
 
@@ -1306,7 +1439,10 @@ 
 		) as $class)
 		{
 			//error_log(__METHOD__."('$scheme') class_exists('$class')=".array2string(class_exists($class)));
-			if (class_exists($class))  return $class;
+			if (class_exists($class))
+			{
+				return $class;
+			}
 		}
 	}
 
@@ -1341,7 +1477,10 @@ 
 			static $entities = array('%21', '%2A', '%27', '%28', '%29', '%3B', '%3A', '%40', '%26', '%3D', '%24', '%2C', '%2F', '%3F', '%23', '%5B', '%5D');
 			static $replacements = array('!', '*', "'", "(", ")", ";", ":", "@", "&", "=", "$", ",", "/", "?", "#", "[", "]");
 			static $str_replace = null;
-			if (!isset($str_replace)) $str_replace = function_exists('mb_str_replace') ? 'mb_str_replace' : 'str_replace';
+			if (!isset($str_replace))
+			{
+				$str_replace = function_exists('mb_str_replace') ? 'mb_str_replace' : 'str_replace';
+			}
 
 			// Create encoded URL with special URL characters decoded so it can be parsed
 			// All other characters will be encoded

api/src/Vfs/StreamWrapperIface.php

Doc Comments +4 added lines, -3 removed lines

@@ -45,6 +45,7 @@ 
 	 * This method is called when the stream is closed, using fclose().
 	 *
 	 * You must release any resources that were locked or allocated by the stream.
+	 * @return boolean
 	 */
 	function stream_close ( );
 
@@ -57,7 +58,7 @@ 
 	 * You must also update the read/write position of the stream by the number of bytes that were successfully read.
 	 *
 	 * @param int $count
-	 * @return string/false up to count bytes read or false on EOF
+	 * @return string|false up to count bytes read or false on EOF
 	 */
 	function stream_read ( $count );
 
@@ -114,7 +115,7 @@ 
 	 *
 	 * If you have cached data in your stream but not yet stored it into the underlying storage, you should do so now.
 	 *
-	 * @return booelan TRUE if the cached data was successfully stored (or if there was no data to store), or FALSE if the data could not be stored.
+	 * @return boolean TRUE if the cached data was successfully stored (or if there was no data to store), or FALSE if the data could not be stored.
 	 */
 	function stream_flush ( );
 
@@ -188,7 +189,7 @@ 
 	 * This method is called immediately when your stream object is created for examining directory contents with opendir().
 	 *
 	 * @param string $path URL that was passed to opendir() and that this object is expected to explore.
-	 * @return booelan
+	 * @return boolean
 	 */
 	function dir_opendir ( $path, $options );
 

Indentation +2 added lines, -2 removed lines

@@ -80,10 +80,10 @@
  	 * Important: PHP 5.0 introduced a bug that wasn't fixed until 5.1: the return value has to be the oposite!
  	 *
  	 * if(version_compare(PHP_VERSION,'5.0','>=') && version_compare(PHP_VERSION,'5.1','<'))
-  	 * {
+ 	 * {
  	 * 		$eof = !$eof;
  	 * }
-  	 *
+ 	 *
  	 * @return boolean true if the read/write position is at the end of the stream and no more data availible, false otherwise
  	 */
 	function stream_eof ( );

Spacing +18 added lines, -18 removed lines

@@ -39,14 +39,14 @@ 
 	 * @param string $opened_path full path of the file/resource, if the open was successfull and STREAM_USE_PATH was set
 	 * @return boolean true if the ressource was opened successful, otherwise false
 	 */
-	function stream_open ( $path, $mode, $options, &$opened_path );
+	function stream_open($path, $mode, $options, &$opened_path);
 
 	/**
 	 * This method is called when the stream is closed, using fclose().
 	 *
 	 * You must release any resources that were locked or allocated by the stream.
 	 */
-	function stream_close ( );
+	function stream_close( );
 
 	/**
 	 * This method is called in response to fread() and fgets() calls on the stream.
@@ -59,7 +59,7 @@ 
 	 * @param int $count
 	 * @return string/false up to count bytes read or false on EOF
 	 */
-	function stream_read ( $count );
+	function stream_read($count);
 
 	/**
 	 * This method is called in response to fwrite() calls on the stream.
@@ -72,7 +72,7 @@ 
 	 * @param string $data
 	 * @return integer
 	 */
-	function stream_write ( $data );
+	function stream_write($data);
 
  	/**
  	 * This method is called in response to feof() calls on the stream.
@@ -86,14 +86,14 @@ 
   	 *
  	 * @return boolean true if the read/write position is at the end of the stream and no more data availible, false otherwise
  	 */
-	function stream_eof ( );
+	function stream_eof( );
 
 	/**
 	 * This method is called in response to ftell() calls on the stream.
 	 *
 	 * @return integer current read/write position of the stream
 	 */
- 	function stream_tell ( );
+ 	function stream_tell( );
 
  	/**
  	 * This method is called in response to fseek() calls on the stream.
@@ -107,7 +107,7 @@ 
  	 * 							SEEK_END - Set position to end-of-file plus offset. (To move to a position before the end-of-file, you need to pass a negative value in offset.)
  	 * @return boolean TRUE if the position was updated, FALSE otherwise.
  	 */
-	function stream_seek ( $offset, $whence );
+	function stream_seek($offset, $whence);
 
 	/**
 	 * This method is called in response to fflush() calls on the stream.
@@ -116,7 +116,7 @@ 
 	 *
 	 * @return booelan TRUE if the cached data was successfully stored (or if there was no data to store), or FALSE if the data could not be stored.
 	 */
-	function stream_flush ( );
+	function stream_flush( );
 
 	/**
 	 * This method is called in response to fstat() calls on the stream.
@@ -132,7 +132,7 @@ 
 	 *
 	 * @return array containing the same values as appropriate for the stream.
 	 */
-	function stream_stat ( );
+	function stream_stat( );
 
 	/**
 	 * This method is called in response to unlink() calls on URL paths associated with the wrapper.
@@ -143,7 +143,7 @@ 
 	 * @param string $path
 	 * @return boolean TRUE on success or FALSE on failure
 	 */
-	static function unlink ( $path );
+	static function unlink($path);
 
 	/**
 	 * This method is called in response to rename() calls on URL paths associated with the wrapper.
@@ -157,7 +157,7 @@ 
 	 * @param string $path_to
 	 * @return boolean TRUE on success or FALSE on failure
 	 */
-	static function rename ( $path_from, $path_to );
+	static function rename($path_from, $path_to);
 
 	/**
 	 * This method is called in response to mkdir() calls on URL paths associated with the wrapper.
@@ -170,7 +170,7 @@ 
 	 * @param int $options Posible values include STREAM_REPORT_ERRORS and STREAM_MKDIR_RECURSIVE
 	 * @return boolean TRUE on success or FALSE on failure
 	 */
-	static function mkdir ( $path, $mode, $options );
+	static function mkdir($path, $mode, $options);
 
 	/**
 	 * This method is called in response to rmdir() calls on URL paths associated with the wrapper.
@@ -182,7 +182,7 @@ 
 	 * @param int $options Possible values include STREAM_REPORT_ERRORS.
 	 * @return boolean TRUE on success or FALSE on failure.
 	 */
-	static function rmdir ( $path, $options );
+	static function rmdir($path, $options);
 
 	/**
 	 * This method is called immediately when your stream object is created for examining directory contents with opendir().
@@ -190,7 +190,7 @@ 
 	 * @param string $path URL that was passed to opendir() and that this object is expected to explore.
 	 * @return booelan
 	 */
-	function dir_opendir ( $path, $options );
+	function dir_opendir($path, $options);
 
 	/**
 	 * This method is called in response to stat() calls on the URL paths associated with the wrapper.
@@ -218,7 +218,7 @@ 
 	 *                          stat triggers it's own warning anyway, so it makes no sense to trigger one by our stream-wrapper!
 	 * @return array
 	 */
-	static function url_stat ( $path, $flags );
+	static function url_stat($path, $flags);
 
 	/**
 	 * This method is called in response to readdir().
@@ -227,7 +227,7 @@ 
 	 *
 	 * @return string
 	 */
-	function dir_readdir ( );
+	function dir_readdir( );
 
 	/**
 	 * This method is called in response to rewinddir().
@@ -237,7 +237,7 @@ 
 	 *
 	 * @return boolean
 	 */
-	function dir_rewinddir ( );
+	function dir_rewinddir( );
 
 	/**
 	 * This method is called in response to closedir().
@@ -246,5 +246,5 @@ 
 	 *
 	 * @return boolean
 	 */
-	function dir_closedir ( );
+	function dir_closedir( );
 }

api/src/Vfs/WebDAV.php

Doc Comments +8 added lines, -8 removed lines

@@ -57,7 +57,7 @@ 
 	* Reimplemented to not check our vfs base path with realpath and connect to mysql DB
 	*
 	* @access public
-    * @param  $prefix =null prefix filesystem path with given path, eg. "/webdav" for owncloud 4.5 remote.php
+    * @param  string $prefix =null prefix filesystem path with given path, eg. "/webdav" for owncloud 4.5 remote.php
 	*/
 	function ServeRequest($prefix=null)
 	{
@@ -76,7 +76,7 @@ 
 	* DELETE method handler
 	*
 	* @param  array  general parameter passing array
-	* @return bool   true on success
+	* @return string   true on success
 	*/
 	function DELETE($options)
 	{
@@ -116,7 +116,7 @@ 
      * Reimplemented to NOT use dirname/basename, which has problems with utf-8 chars
      *
      * @param  array  general parameter passing array
-     * @return bool   true on success
+     * @return string   true on success
      */
     function MKCOL($options)
     {
@@ -151,7 +151,7 @@ 
      * COPY method handler
      *
      * @param  array  general parameter passing array
-     * @return bool   true on success
+     * @return string   true on success
      */
     function COPY($options, $del=false)
     {
@@ -477,7 +477,7 @@ 
 	 * but in the regular vfs attributes.
 	 *
 	 * @param  array  general parameter passing array
-	 * @return bool   true on success
+	 * @return string   true on success
 	 */
 	function PROPPATCH(&$options)
 	{
@@ -557,7 +557,7 @@ 
 	 * LOCK method handler
 	 *
 	 * @param  array  general parameter passing array
-	 * @return bool   true on success
+	 * @return string|boolean   true on success
 	 */
 	function LOCK(&$options)
 	{
@@ -583,7 +583,7 @@ 
 	 * UNLOCK method handler
 	 *
 	 * @param  array  general parameter passing array
-	 * @return bool   true on success
+	 * @return string   true on success
 	 */
 	function UNLOCK(&$options)
 	{
@@ -640,7 +640,7 @@ 
 	 * Reimplement to add a Content-Disposition header, if ?download is appended to the REQUEST_URI
 	 *
 	 * @param  array  parameter passing array
-	 * @return bool   true on success
+	 * @return boolean|null   true on success
 	 */
 	function GET(&$options)
 	{

Indentation +199 added lines, -199 removed lines

@@ -52,13 +52,13 @@ 
 	var $debug = 0;
 
 	/**
-	* Serve a webdav request
-	*
-	* Reimplemented to not check our vfs base path with realpath and connect to mysql DB
-	*
-	* @access public
-    * @param  $prefix =null prefix filesystem path with given path, eg. "/webdav" for owncloud 4.5 remote.php
-	*/
+	 * Serve a webdav request
+	 *
+	 * Reimplemented to not check our vfs base path with realpath and connect to mysql DB
+	 *
+	 * @access public
+	 * @param  $prefix =null prefix filesystem path with given path, eg. "/webdav" for owncloud 4.5 remote.php
+	 */
 	function ServeRequest($prefix=null)
 	{
 		// special treatment for litmus compliance test
@@ -73,11 +73,11 @@ 
 	}
 
 	/**
-	* DELETE method handler
-	*
-	* @param  array  general parameter passing array
-	* @return bool   true on success
-	*/
+	 * DELETE method handler
+	 *
+	 * @param  array  general parameter passing array
+	 * @return bool   true on success
+	 */
 	function DELETE($options)
 	{
 		$path = $this->base . $options['path'];
@@ -110,165 +110,165 @@ 
 		return '204 No Content';
 	}
 
-    /**
-     * MKCOL method handler
-     *
-     * Reimplemented to NOT use dirname/basename, which has problems with utf-8 chars
-     *
-     * @param  array  general parameter passing array
-     * @return bool   true on success
-     */
-    function MKCOL($options)
-    {
-        $path   = $this->_unslashify($this->base .$options["path"]);
-        $parent = Vfs::dirname($path);
-
-        if (!file_exists($parent)) {
-            return "409 Conflict";
-        }
-
-        if (!is_dir($parent)) {
-            return "403 Forbidden";
-        }
-
-        if ( file_exists($path) ) {
-            return "405 Method not allowed";
-        }
-
-        if (!empty($this->_SERVER["CONTENT_LENGTH"])) { // no body parsing yet
-            return "415 Unsupported media type";
-        }
-
-        $stat = mkdir($path, 0777);
-        if (!$stat) {
-            return "403 Forbidden";
-        }
-
-        return ("201 Created");
-    }
+	/**
+	 * MKCOL method handler
+	 *
+	 * Reimplemented to NOT use dirname/basename, which has problems with utf-8 chars
+	 *
+	 * @param  array  general parameter passing array
+	 * @return bool   true on success
+	 */
+	function MKCOL($options)
+	{
+		$path   = $this->_unslashify($this->base .$options["path"]);
+		$parent = Vfs::dirname($path);
+
+		if (!file_exists($parent)) {
+			return "409 Conflict";
+		}
+
+		if (!is_dir($parent)) {
+			return "403 Forbidden";
+		}
+
+		if ( file_exists($path) ) {
+			return "405 Method not allowed";
+		}
+
+		if (!empty($this->_SERVER["CONTENT_LENGTH"])) { // no body parsing yet
+			return "415 Unsupported media type";
+		}
+
+		$stat = mkdir($path, 0777);
+		if (!$stat) {
+			return "403 Forbidden";
+		}
+
+		return ("201 Created");
+	}
 
 	/**
-     * COPY method handler
-     *
-     * @param  array  general parameter passing array
-     * @return bool   true on success
-     */
-    function COPY($options, $del=false)
-    {
-        // TODO Property updates still broken (Litmus should detect this?)
-
-        if (!empty($this->_SERVER["CONTENT_LENGTH"])) { // no body parsing yet
-            return "415 Unsupported media type";
-        }
-
-        // no copying to different WebDAV Servers yet
-        if (isset($options["dest_url"])) {
-            return "502 bad gateway";
-        }
-
-        $source = $this->base .$options["path"];
-        if (!file_exists($source)) return "404 Not found";
-
-        if (is_dir($source)) { // resource is a collection
-            switch ($options["depth"]) {
-            case "infinity": // valid
-                break;
-            case "0": // valid for COPY only
-                if ($del) { // MOVE?
-                    return "400 Bad request";
-                }
-                break;
-            case "1": // invalid for both COPY and MOVE
-            default:
-                return "400 Bad request";
-            }
-        }
-
-        $dest         = $this->base . $options["dest"];
-        $destdir      = dirname($dest);
-
-        if (!file_exists($destdir) || !is_dir($destdir)) {
-            return "409 Conflict";
-        }
-
-        $new          = !file_exists($dest);
-        $existing_col = false;
-
-        if (!$new) {
-            if ($del && is_dir($dest)) {
-                if (!$options["overwrite"]) {
-                    return "412 precondition failed";
-                }
-                $dest .= basename($source);
-                if (file_exists($dest)) {
-                    $options["dest"] .= basename($source);
-                } else {
-                    $new          = true;
-                    $existing_col = true;
-                }
-            }
-        }
-
-        if (!$new) {
-            if ($options["overwrite"]) {
-                $stat = $this->DELETE(array("path" => $options["dest"]));
-                if (($stat{0} != "2") && (substr($stat, 0, 3) != "404")) {
-                    return $stat;
-                }
-            } else {
-                return "412 precondition failed";
-            }
-        }
-
-        if ($del) {
-            if (!rename($source, $dest)) {
-                return "500 Internal server error";
-            }
-        } else {
-            if (is_dir($source) && $options['depth'] == 'infinity') {
-            	$files = Vfs::find($source,array('depth' => true,'url' => true));	// depth=true: return dirs first, url=true: allow urls!
-            } else {
-                $files = array($source);
-            }
-
-            if (!is_array($files) || empty($files)) {
-                return "500 Internal server error";
-            }
-
-
-            foreach ($files as $file) {
-                if (is_dir($file)) {
-                    $file = $this->_slashify($file);
-                }
-
-                $destfile = str_replace($source, $dest, $file);
-
-                if (is_dir($file)) {
-                    if (!is_dir($destfile)) {
-                        // TODO "mkdir -p" here? (only natively supported by PHP 5)
-                        if (!@mkdir($destfile)) {
-                            return "409 Conflict";
-                        }
-                    }
-                } else {
-                    if (!@copy($file, $destfile)) {
-                        return "409 Conflict";
-                    }
-                }
-            }
-        }
-        // adding Location header as shown in example in rfc2518 section 8.9.5
+	 * COPY method handler
+	 *
+	 * @param  array  general parameter passing array
+	 * @return bool   true on success
+	 */
+	function COPY($options, $del=false)
+	{
+		// TODO Property updates still broken (Litmus should detect this?)
+
+		if (!empty($this->_SERVER["CONTENT_LENGTH"])) { // no body parsing yet
+			return "415 Unsupported media type";
+		}
+
+		// no copying to different WebDAV Servers yet
+		if (isset($options["dest_url"])) {
+			return "502 bad gateway";
+		}
+
+		$source = $this->base .$options["path"];
+		if (!file_exists($source)) return "404 Not found";
+
+		if (is_dir($source)) { // resource is a collection
+			switch ($options["depth"]) {
+			case "infinity": // valid
+				break;
+			case "0": // valid for COPY only
+				if ($del) { // MOVE?
+					return "400 Bad request";
+				}
+				break;
+			case "1": // invalid for both COPY and MOVE
+			default:
+				return "400 Bad request";
+			}
+		}
+
+		$dest         = $this->base . $options["dest"];
+		$destdir      = dirname($dest);
+
+		if (!file_exists($destdir) || !is_dir($destdir)) {
+			return "409 Conflict";
+		}
+
+		$new          = !file_exists($dest);
+		$existing_col = false;
+
+		if (!$new) {
+			if ($del && is_dir($dest)) {
+				if (!$options["overwrite"]) {
+					return "412 precondition failed";
+				}
+				$dest .= basename($source);
+				if (file_exists($dest)) {
+					$options["dest"] .= basename($source);
+				} else {
+					$new          = true;
+					$existing_col = true;
+				}
+			}
+		}
+
+		if (!$new) {
+			if ($options["overwrite"]) {
+				$stat = $this->DELETE(array("path" => $options["dest"]));
+				if (($stat{0} != "2") && (substr($stat, 0, 3) != "404")) {
+					return $stat;
+				}
+			} else {
+				return "412 precondition failed";
+			}
+		}
+
+		if ($del) {
+			if (!rename($source, $dest)) {
+				return "500 Internal server error";
+			}
+		} else {
+			if (is_dir($source) && $options['depth'] == 'infinity') {
+				$files = Vfs::find($source,array('depth' => true,'url' => true));	// depth=true: return dirs first, url=true: allow urls!
+			} else {
+				$files = array($source);
+			}
+
+			if (!is_array($files) || empty($files)) {
+				return "500 Internal server error";
+			}
+
+
+			foreach ($files as $file) {
+				if (is_dir($file)) {
+					$file = $this->_slashify($file);
+				}
+
+				$destfile = str_replace($source, $dest, $file);
+
+				if (is_dir($file)) {
+					if (!is_dir($destfile)) {
+						// TODO "mkdir -p" here? (only natively supported by PHP 5)
+						if (!@mkdir($destfile)) {
+							return "409 Conflict";
+						}
+					}
+				} else {
+					if (!@copy($file, $destfile)) {
+						return "409 Conflict";
+					}
+				}
+			}
+		}
+		// adding Location header as shown in example in rfc2518 section 8.9.5
 		header('Location: '.$this->base_uri.$options['dest']);
 
-        return ($new && !$existing_col) ? "201 Created" : "204 No Content";
-    }
+		return ($new && !$existing_col) ? "201 Created" : "204 No Content";
+	}
 
-    /**
-	* Get properties for a single file/resource
-	*
-	* @param  string  $_path resource path
-	* @return array   resource properties
-	*/
+	/**
+	 * Get properties for a single file/resource
+	 *
+	 * @param  string  $_path resource path
+	 * @return array   resource properties
+	 */
 	function fileinfo($_path)
 	{
 		// internally we require some url-encoding, as vfs_stream_wrapper uses URL's internally
@@ -296,9 +296,9 @@ 
 		$info['props'][] = self::mkprop	('creationdate',    filectime($fspath));
 		$info['props'][] = self::mkprop	('getlastmodified', filemtime($fspath));
 
-        // Microsoft extensions: last access time and 'hidden' status
-        $info["props"][] = self::mkprop("lastaccessed",    fileatime($fspath));
-        $info["props"][] = self::mkprop("ishidden",        Vfs::is_hidden($fspath));
+		// Microsoft extensions: last access time and 'hidden' status
+		$info["props"][] = self::mkprop("lastaccessed",    fileatime($fspath));
+		$info["props"][] = self::mkprop("ishidden",        Vfs::is_hidden($fspath));
 
 		// type and size (caller already made sure that path exists)
 		if (is_dir($fspath)) {
@@ -436,38 +436,38 @@ 
 	}
 
  	/**
-	 * Used eg. by get
-	 *
-	 * @todo replace all calls to _mimetype with Vfs::mime_content_type()
-	 * @param string $path
-	 * @return string
-	 */
+ 	 * Used eg. by get
+ 	 *
+ 	 * @todo replace all calls to _mimetype with Vfs::mime_content_type()
+ 	 * @param string $path
+ 	 * @return string
+ 	 */
 	function _mimetype($path)
 	{
 		return Vfs::mime_content_type($path);
 	}
 
-    /**
-     * Check if path is readable by current user
-     *
-     * @param string $fspath
-     * @return boolean
-     */
-    function _is_readable($fspath)
-    {
-    	return Vfs::is_readable($fspath);
-    }
-
-    /**
-     * Check if path is writable by current user
-     *
-     * @param string $fspath
-     * @return boolean
-     */
-    function _is_writable($fspath)
-    {
-    	return Vfs::is_writable($fspath);
-    }
+	/**
+	 * Check if path is readable by current user
+	 *
+	 * @param string $fspath
+	 * @return boolean
+	 */
+	function _is_readable($fspath)
+	{
+		return Vfs::is_readable($fspath);
+	}
+
+	/**
+	 * Check if path is writable by current user
+	 *
+	 * @param string $fspath
+	 * @return boolean
+	 */
+	function _is_writable($fspath)
+	{
+		return Vfs::is_writable($fspath);
+	}
 
 	/**
 	 * PROPPATCH method handler
@@ -610,13 +610,13 @@ 
 	 * @param  string  directory path
 	 * @return void    function has to handle HTTP response itself
 	 */
-    function GetDir($fspath, &$options)
-    {
+	function GetDir($fspath, &$options)
+	{
 		// add a content-type header to overwrite an existing default charset in apache (AddDefaultCharset directiv)
 		header('Content-type: text/html; charset='.Api\Translation::charset());
 
 		parent::GetDir($fspath, $options);
-    }
+	}
 
 	private $force_download = false;
 

Switch Indentation +10 added lines, -10 removed lines

@@ -171,16 +171,16 @@
 
         if (is_dir($source)) { // resource is a collection
             switch ($options["depth"]) {
-            case "infinity": // valid
-                break;
-            case "0": // valid for COPY only
-                if ($del) { // MOVE?
-                    return "400 Bad request";
-                }
-                break;
-            case "1": // invalid for both COPY and MOVE
-            default:
-                return "400 Bad request";
+            	case "infinity": // valid
+                	break;
+            	case "0": // valid for COPY only
+                	if ($del) { // MOVE?
+                    	return "400 Bad request";
+                	}
+                	break;
+            	case "1": // invalid for both COPY and MOVE
+            	default:
+                	return "400 Bad request";
             }
         }
 

Spacing +85 added lines, -85 removed lines

@@ -59,7 +59,7 @@ 
 	* @access public
     * @param  $prefix =null prefix filesystem path with given path, eg. "/webdav" for owncloud 4.5 remote.php
 	*/
-	function ServeRequest($prefix=null)
+	function ServeRequest($prefix = null)
 	{
 		// special treatment for litmus compliance test
 		// reply on its identifier header
@@ -80,7 +80,7 @@ 
 	*/
 	function DELETE($options)
 	{
-		$path = $this->base . $options['path'];
+		$path = $this->base.$options['path'];
 
 		if (!file_exists($path))
 		{
@@ -120,7 +120,7 @@ 
      */
     function MKCOL($options)
     {
-        $path   = $this->_unslashify($this->base .$options["path"]);
+        $path   = $this->_unslashify($this->base.$options["path"]);
         $parent = Vfs::dirname($path);
 
         if (!file_exists($parent)) {
@@ -131,7 +131,7 @@ 
             return "403 Forbidden";
         }
 
-        if ( file_exists($path) ) {
+        if (file_exists($path)) {
             return "405 Method not allowed";
         }
 
@@ -153,7 +153,7 @@ 
      * @param  array  general parameter passing array
      * @return bool   true on success
      */
-    function COPY($options, $del=false)
+    function COPY($options, $del = false)
     {
         // TODO Property updates still broken (Litmus should detect this?)
 
@@ -166,7 +166,7 @@ 
             return "502 bad gateway";
         }
 
-        $source = $this->base .$options["path"];
+        $source = $this->base.$options["path"];
         if (!file_exists($source)) return "404 Not found";
 
         if (is_dir($source)) { // resource is a collection
@@ -184,7 +184,7 @@ 
             }
         }
 
-        $dest         = $this->base . $options["dest"];
+        $dest         = $this->base.$options["dest"];
         $destdir      = dirname($dest);
 
         if (!file_exists($destdir) || !is_dir($destdir)) {
@@ -226,7 +226,7 @@ 
             }
         } else {
             if (is_dir($source) && $options['depth'] == 'infinity') {
-            	$files = Vfs::find($source,array('depth' => true,'url' => true));	// depth=true: return dirs first, url=true: allow urls!
+            	$files = Vfs::find($source, array('depth' => true, 'url' => true)); // depth=true: return dirs first, url=true: allow urls!
             } else {
                 $files = array($source);
             }
@@ -272,16 +272,16 @@ 
 	function fileinfo($_path)
 	{
 		// internally we require some url-encoding, as vfs_stream_wrapper uses URL's internally
-		$path = str_replace(array('#','?'),array('%23','%3F'),$_path);
+		$path = str_replace(array('#', '?'), array('%23', '%3F'), $_path);
 
 		//error_log(__METHOD__."($path)");
 		// map URI path to filesystem path
-		$fspath = $this->base . $path;
+		$fspath = $this->base.$path;
 
 		// create result array
 		$info = array();
 		// TODO remove slash append code when base class is able to do it itself
-		$info['path']  = is_dir($fspath) ? $this->_slashify($path) : $path;
+		$info['path'] = is_dir($fspath) ? $this->_slashify($path) : $path;
 
 		// remove all urlencoding we need internally in EGw, HTTP_WebDAV_Server will add it's own!
 		// rawurldecode does NOT touch +
@@ -290,32 +290,32 @@ 
 		$info['props'] = array();
 
 		// no special beautified displayname here ...
-		$info['props'][] = self::mkprop	('displayname', Vfs::basename(self::_unslashify($info['path'])));
+		$info['props'][] = self::mkprop('displayname', Vfs::basename(self::_unslashify($info['path'])));
 
 		// creation and modification time
-		$info['props'][] = self::mkprop	('creationdate',    filectime($fspath));
-		$info['props'][] = self::mkprop	('getlastmodified', filemtime($fspath));
+		$info['props'][] = self::mkprop('creationdate', filectime($fspath));
+		$info['props'][] = self::mkprop('getlastmodified', filemtime($fspath));
 
         // Microsoft extensions: last access time and 'hidden' status
-        $info["props"][] = self::mkprop("lastaccessed",    fileatime($fspath));
-        $info["props"][] = self::mkprop("ishidden",        Vfs::is_hidden($fspath));
+        $info["props"][] = self::mkprop("lastaccessed", fileatime($fspath));
+        $info["props"][] = self::mkprop("ishidden", Vfs::is_hidden($fspath));
 
 		// type and size (caller already made sure that path exists)
 		if (is_dir($fspath)) {
 			// directory (WebDAV collection)
-			$info['props'][] = self::mkprop	('resourcetype', array(
+			$info['props'][] = self::mkprop('resourcetype', array(
 			 	self::mkprop('collection', '')));
-			$info['props'][] = self::mkprop	('getcontenttype', 'httpd/unix-directory');
+			$info['props'][] = self::mkprop('getcontenttype', 'httpd/unix-directory');
 		} else {
 			// plain file (WebDAV resource)
-			$info['props'][] = self::mkprop	('resourcetype', '');
+			$info['props'][] = self::mkprop('resourcetype', '');
 			if (Vfs::is_readable($path)) {
-				$info['props'][] = self::mkprop	('getcontenttype', Vfs::mime_content_type($path));
+				$info['props'][] = self::mkprop('getcontenttype', Vfs::mime_content_type($path));
 			} else {
 				error_log(__METHOD__."($path) $fspath is not readable!");
-				$info['props'][] = self::mkprop	('getcontenttype', 'application/x-non-readable');
+				$info['props'][] = self::mkprop('getcontenttype', 'application/x-non-readable');
 			}
-			$info['props'][] = self::mkprop	('getcontentlength', filesize($fspath));
+			$info['props'][] = self::mkprop('getcontentlength', filesize($fspath));
 		}
 		// generate etag from inode (sqlfs: fs_id), modification time and size
 		$stat = stat($fspath);
@@ -369,21 +369,21 @@ 
 	 */
 	function PROPFIND(&$options, &$files)
 	{
-		if (!parent::PROPFIND($options,$files))
+		if (!parent::PROPFIND($options, $files))
 		{
 			return false;
 		}
 		$path2n = array();
-		foreach($files['files'] as $n => $info)
+		foreach ($files['files'] as $n => $info)
 		{
 			// do NOT report /clientsync/.favorites/, as it fails
-			if (strpos($info['path'],'/clientsync/.favorites/') === 0)
+			if (strpos($info['path'], '/clientsync/.favorites/') === 0)
 			{
 				unset($files['files'][$n]);
 				continue;
 			}
 			$_path = $info['path'];
-			if (!$n && $info['path'] != '/' && substr($info['path'],-1) == '/') $_path = substr($info['path'],0,-1);
+			if (!$n && $info['path'] != '/' && substr($info['path'], -1) == '/') $_path = substr($info['path'], 0, -1);
 
 			// need to encode path again, as $info['path'] is NOT encoded, but Vfs::(stat|propfind) require it
 			// otherwise pathes containing url special chars like ? or # will not stat
@@ -393,21 +393,21 @@ 
 			// adding some properties used instead of regular DAV times
 			if (($stat = Vfs::stat($path)))
 			{
-				$fileprops =& $files['files'][$path2n[$path]]['props'];
-				foreach(self::$auto_props as $attr => $props)
+				$fileprops = & $files['files'][$path2n[$path]]['props'];
+				foreach (self::$auto_props as $attr => $props)
 				{
-					switch($attr)
+					switch ($attr)
 					{
 						case 'ctime':
 						case 'mtime':
 						case 'atime':
-							$value = gmdate('D, d M Y H:i:s T',$stat[$attr]);
+							$value = gmdate('D, d M Y H:i:s T', $stat[$attr]);
 							break;
 
 						default:
 							continue 2;
 					}
-					foreach($props as $prop)
+					foreach ($props as $prop)
 					{
 						$prop['val'] = $value;
 						$fileprops[] = $prop;
@@ -415,17 +415,17 @@ 
 				}
 			}
 		}
-		if ($path2n && ($path2props = Vfs::propfind(array_keys($path2n),null)))
+		if ($path2n && ($path2props = Vfs::propfind(array_keys($path2n), null)))
 		{
-			foreach($path2props as $path => $props)
+			foreach ($path2props as $path => $props)
 			{
-				$fileprops =& $files['files'][$path2n[$path]]['props'];
-				foreach($props as $prop)
+				$fileprops = & $files['files'][$path2n[$path]]['props'];
+				foreach ($props as $prop)
 				{
 					if ($prop['ns'] == Vfs::DEFAULT_PROP_NAMESPACE && $prop['name'][0] == '#')	// eGW's customfields
 					{
 						$prop['ns'] .= 'customfields/';
-						$prop['name'] = substr($prop['name'],1);
+						$prop['name'] = substr($prop['name'], 1);
 					}
 					$fileprops[] = $prop;
 				}
@@ -481,36 +481,36 @@ 
 	 */
 	function PROPPATCH(&$options)
 	{
-		$path = Api\Translation::convert($options['path'],'utf-8');
+		$path = Api\Translation::convert($options['path'], 'utf-8');
 
 		foreach ($options['props'] as $key => $prop) {
 			$attributes = array();
-			switch($prop['ns'])
+			switch ($prop['ns'])
 			{
 				// allow Webdrive to set creation and modification time
 				case 'http://www.southrivertech.com/':
-					switch($prop['name'])
+					switch ($prop['name'])
 					{
 						case 'srt_modifiedtime':
 						case 'getlastmodified':
-							Vfs::touch($path,strtotime($prop['val']));
+							Vfs::touch($path, strtotime($prop['val']));
 							break;
 						//case 'srt_creationtime':
 							// no streamwrapper interface / php function to set the ctime currently
 							//$attributes['created'] = strtotime($prop['val']);
 							//break;
 						default:
-							if (!Vfs::proppatch($path,array($prop))) $options['props'][$key]['status'] = '403 Forbidden';
+							if (!Vfs::proppatch($path, array($prop))) $options['props'][$key]['status'] = '403 Forbidden';
 							break;
 					}
 					break;
 
 				case 'DAV:':
-					switch($prop['name'])
+					switch ($prop['name'])
 					{
 						// allow netdrive to change the modification time
 						case 'getlastmodified':
-							Vfs::touch($path,strtotime($prop['val']));
+							Vfs::touch($path, strtotime($prop['val']));
 							break;
 						// not sure why, the filesystem example of the WebDAV class does it ...
 						default:
@@ -520,16 +520,16 @@ 
 					break;
 
 				case 'urn:schemas-microsoft-com:':
-					switch($prop['name'])
+					switch ($prop['name'])
 					{
 						case 'Win32LastModifiedTime':
-							Vfs::touch($path,strtotime($prop['val']));
+							Vfs::touch($path, strtotime($prop['val']));
 							break;
 						case 'Win32CreationTime':	// eg. "Wed, 14 Sep 2011 15:48:26 GMT"
 						case 'Win32LastAccessTime':
 						case 'Win32FileAttributes':	// not sure what that is, it was always "00000000"
 						default:
-							if (!Vfs::proppatch($path,array($prop))) $options['props'][$key]['status'] = '403 Forbidden';
+							if (!Vfs::proppatch($path, array($prop))) $options['props'][$key]['status'] = '403 Forbidden';
 							break;
 					}
 					break;
@@ -539,18 +539,18 @@ 
 					$prop['name'] = '#'.$prop['name'];
 					// fall through
 				default:
-					if (!Vfs::proppatch($path,array($prop))) $options['props'][$key]['status'] = '403 Forbidden';
+					if (!Vfs::proppatch($path, array($prop))) $options['props'][$key]['status'] = '403 Forbidden';
 					break;
 			}
 			if ($this->debug) $props[] = '('.$prop['ns'].')'.$prop['name'].'='.$prop['val'];
 		}
 		if ($this->debug)
 		{
-			error_log(__METHOD__.": path=$options[path], props=".implode(', ',$props));
-			if ($attributes) error_log(__METHOD__.": path=$options[path], set attributes=".str_replace("\n",' ',print_r($attributes,true)));
+			error_log(__METHOD__.": path=$options[path], props=".implode(', ', $props));
+			if ($attributes) error_log(__METHOD__.": path=$options[path], set attributes=".str_replace("\n", ' ', print_r($attributes, true)));
 		}
 
-		return '';	// this is as the filesystem example handler does it, no true or false ...
+		return ''; // this is as the filesystem example handler does it, no true or false ...
 	}
 
 	/**
@@ -561,18 +561,18 @@ 
 	 */
 	function LOCK(&$options)
 	{
-		if ($this->debug) error_log(__METHOD__.'('.str_replace(array("\n",'    '),'',print_r($options,true)).')');
+		if ($this->debug) error_log(__METHOD__.'('.str_replace(array("\n", '    '), '', print_r($options, true)).')');
 		// TODO recursive locks on directories not supported yet
-		if (is_dir($this->base . $options['path']) && !empty($options['depth']))
+		if (is_dir($this->base.$options['path']) && !empty($options['depth']))
 		{
 			return '409 Conflict';
 		}
-		$options['timeout'] = time()+300; // 5min. hardcoded
+		$options['timeout'] = time() + 300; // 5min. hardcoded
 
 		// dont know why, but HTTP_WebDAV_Server passes the owner in D:href tags, which get's passed unchanged to checkLock/PROPFIND
 		// that's wrong according to the standard and cadaver does not show it on discover --> strip_tags removes eventual tags
-		if (($ret = Vfs::lock($options['path'],$options['locktoken'],$options['timeout'],strip_tags($options['owner']),
-			$options['scope'],$options['type'],isset($options['update']))) && !isset($options['update']))
+		if (($ret = Vfs::lock($options['path'], $options['locktoken'], $options['timeout'], strip_tags($options['owner']),
+			$options['scope'], $options['type'], isset($options['update']))) && !isset($options['update']))
 		{
 			return $ret ? '200 OK' : '409 Conflict';
 		}
@@ -587,8 +587,8 @@ 
 	 */
 	function UNLOCK(&$options)
 	{
-		if ($this->debug) error_log(__METHOD__.'('.str_replace(array("\n",'    '),'',print_r($options,true)).')');
-		return Vfs::unlock($options['path'],$options['token']) ? '204 No Content' : '409 Conflict';
+		if ($this->debug) error_log(__METHOD__.'('.str_replace(array("\n", '    '), '', print_r($options, true)).')');
+		return Vfs::unlock($options['path'], $options['token']) ? '204 No Content' : '409 Conflict';
 	}
 
 	/**
@@ -627,9 +627,9 @@ 
 	 */
 	function __construct()
 	{
-		if ($_SERVER['REQUEST_METHOD'] == 'GET' && (($this->force_download = strpos($_SERVER['REQUEST_URI'],'?download')) !== false))
+		if ($_SERVER['REQUEST_METHOD'] == 'GET' && (($this->force_download = strpos($_SERVER['REQUEST_URI'], '?download')) !== false))
 		{
-			$_SERVER['REQUEST_URI'] = substr($_SERVER['REQUEST_URI'],0,$this->force_download);
+			$_SERVER['REQUEST_URI'] = substr($_SERVER['REQUEST_URI'], 0, $this->force_download);
 		}
 		parent::__construct();
 	}
@@ -644,7 +644,7 @@ 
 	 */
 	function GET(&$options)
 	{
-		if (is_dir($this->base . $options["path"]))
+		if (is_dir($this->base.$options["path"]))
 		{
 			return $this->autoindex($options);
 		}
@@ -652,11 +652,11 @@ 
 		{
 			// mitigate risks of serving javascript or css from our domain
 			Api\Header\Content::safe($options['stream'], $options['path'], $options['mimetype'], $options['size'], false,
-				$this->force_download, true);	// true = do not send content-type and content-length header, but modify values
+				$this->force_download, true); // true = do not send content-type and content-length header, but modify values
 
 			if (!is_resource($options['stream']))
 			{
-				$options['data'] =& $options['stream'];
+				$options['data'] = & $options['stream'];
 				unset($options['stream']);
 			}
 		}
@@ -675,9 +675,9 @@ 
 			'depth' => 1,
 		);
 		$files = array();
-		if (($ret = $this->PROPFIND($propfind_options,$files)) !== true)
+		if (($ret = $this->PROPFIND($propfind_options, $files)) !== true)
 		{
-			return $ret;	// no collection
+			return $ret; // no collection
 		}
 		header('Content-type: text/html; charset='.Api\Translation::charset());
 		echo "<html>\n<head>\n\t<title>".'EGroupware WebDAV server '.htmlspecialchars($options['path'])."</title>\n";
@@ -689,10 +689,10 @@ 
 		echo '<h1>WebDAV ';
 		list(,$base) = explode(parse_url($GLOBALS['egw_info']['server']['webserver_url'], PHP_URL_PATH), $this->base_uri, 2);
 		$path = $base;
-		foreach(explode('/',$this->_unslashify($options['path'])) as $n => $name)
+		foreach (explode('/', $this->_unslashify($options['path'])) as $n => $name)
 		{
 			$path .= ($n != 1 ? '/' : '').$name;
-			echo Api\Html::a_href(htmlspecialchars($name.'/'),$path);
+			echo Api\Html::a_href(htmlspecialchars($name.'/'), $path);
 		}
 		echo "</h1>\n";
 
@@ -709,18 +709,18 @@ 
 		);
 		$n = 0;
 		$collection_props = null;
-		foreach($files['files'] as $file)
+		foreach ($files['files'] as $file)
 		{
 			if (!isset($collection_props))
 			{
 				$collection_props = $this->props2array($file['props']);
 				echo '<h3>'.lang('Collection listing').': '.htmlspecialchars($collection_props['DAV:displayname'])."</h3>\n";
-				continue;	// own entry --> displaying properies later
+				continue; // own entry --> displaying properies later
 			}
-			if(!$n++)
+			if (!$n++)
 			{
 				echo "<table>\n\t<tr class='th'>\n\t\t<th>#</th>\n\t\t<th>".lang('Name')."</th>";
-				foreach($props2show as $label)
+				foreach ($props2show as $label)
 				{
 					echo "\t\t<th>".lang($label)."</th>\n";
 				}
@@ -730,9 +730,9 @@ 
 			//echo $file['path']; _debug_array($props);
 			$class = $class == 'row_on' ? 'row_off' : 'row_on';
 
-			if (substr($file['path'],-1) == '/')
+			if (substr($file['path'], -1) == '/')
 			{
-				$name = basename(substr($file['path'],0,-1)).'/';
+				$name = basename(substr($file['path'], 0, -1)).'/';
 			}
 			else
 			{
@@ -740,14 +740,14 @@ 
 			}
 
 			echo "\t<tr class='$class'>\n\t\t<td>$n</td>\n\t\t<td>".
-				Api\Html::a_href(htmlspecialchars($name),$base.strtr($file['path'], array(
+				Api\Html::a_href(htmlspecialchars($name), $base.strtr($file['path'], array(
 					'%' => '%25',
 					'#' => '%23',
 					'?' => '%3F',
 				)))."</td>\n";
-			foreach($props2show as $prop => $label)
+			foreach ($props2show as $prop => $label)
 			{
-				echo "\t\t<td>".($prop=='DAV:getlastmodified'&&!empty($props[$prop])?date('Y-m-d H:i:s',$props[$prop]):$props[$prop])."</td>\n";
+				echo "\t\t<td>".($prop == 'DAV:getlastmodified' && !empty($props[$prop]) ? date('Y-m-d H:i:s', $props[$prop]) : $props[$prop])."</td>\n";
 			}
 			echo "\t</tr>\n";
 		}
@@ -761,12 +761,12 @@ 
 		}
 		echo '<h3>'.lang('Properties')."</h3>\n";
 		echo "<table>\n\t<tr class='th'><th>".lang('Namespace')."</th><th>".lang('Name')."</th><th>".lang('Value')."</th></tr>\n";
-		foreach($collection_props as $name => $value)
+		foreach ($collection_props as $name => $value)
 		{
 			$class = $class == 'row_on' ? 'row_off' : 'row_on';
-			$parts = explode(':',$name);
+			$parts = explode(':', $name);
 			$name = array_pop($parts);
-			$ns = implode(':',$parts);
+			$ns = implode(':', $parts);
 			echo "\t<tr class='$class'>\n\t\t<td>".htmlspecialchars($ns)."</td><td style='white-space: nowrap'>".htmlspecialchars($name)."</td>\n";
 			echo "\t\t<td>".$value."</td>\n\t</tr>\n";
 		}
@@ -809,11 +809,11 @@ 
 				'wrap'            => 0,
 			));
 		}
-		if (($href=preg_match('/\<(D:)?href\>[^<]+\<\/(D:)?href\>/i',$value)))
+		if (($href = preg_match('/\<(D:)?href\>[^<]+\<\/(D:)?href\>/i', $value)))
 		{
-			$value = preg_replace('/\<(D:)?href\>('.preg_quote($this->base_uri.'/','/').')?([^<]+)\<\/(D:)?href\>/i','<\\1href><a href="\\2\\3">\\3</a></\\4href>',$value);
+			$value = preg_replace('/\<(D:)?href\>('.preg_quote($this->base_uri.'/', '/').')?([^<]+)\<\/(D:)?href\>/i', '<\\1href><a href="\\2\\3">\\3</a></\\4href>', $value);
 		}
-		$ret = $value[0] == '<'  || strpos($value, "\n") !== false ?
+		$ret = $value[0] == '<' || strpos($value, "\n") !== false ?
 			'<pre>'.htmlspecialchars($value).'</pre>' : htmlspecialchars($value);
 
 		if ($href)
@@ -833,10 +833,10 @@ 
 	protected function props2array(array $props)
 	{
 		$arr = array();
-		foreach($props as $prop)
+		foreach ($props as $prop)
 		{
 			$ns_hash = array('DAV:' => 'D');
-			switch($prop['ns'])
+			switch ($prop['ns'])
 			{
 				case 'DAV:';
 					$ns = 'DAV';
@@ -846,10 +846,10 @@ 
 			}
 			if (is_array($prop['val']))
 			{
-				$prop['val'] = $this->_hierarchical_prop_encode($prop['val'], $prop['ns'], $ns_defs='', $ns_hash);
+				$prop['val'] = $this->_hierarchical_prop_encode($prop['val'], $prop['ns'], $ns_defs = '', $ns_hash);
 				// hack to show real namespaces instead of not (visibly) defined shortcuts
 				unset($ns_hash['DAV:']);
-				$value = strtr($v=$this->prop_value($prop['val']),array_flip($ns_hash));
+				$value = strtr($v = $this->prop_value($prop['val']), array_flip($ns_hash));
 			}
 			else
 			{

Braces +133 added lines, -50 removed lines

@@ -64,7 +64,8 @@ 
 		// special treatment for litmus compliance test
 		// reply on its identifier header
 		// not needed for the test itself but eases debugging
-		if (isset($this->_SERVER['HTTP_X_LITMUS'])) {
+		if (isset($this->_SERVER['HTTP_X_LITMUS']))
+		{
 			error_log("Litmus test ".$this->_SERVER['HTTP_X_LITMUS']);
 			header("X-Litmus-reply: ".$this->_SERVER['HTTP_X_LITMUS']);
 		}
@@ -123,24 +124,30 @@ 
         $path   = $this->_unslashify($this->base .$options["path"]);
         $parent = Vfs::dirname($path);
 
-        if (!file_exists($parent)) {
+        if (!file_exists($parent))
+        {
             return "409 Conflict";
         }
 
-        if (!is_dir($parent)) {
+        if (!is_dir($parent))
+        {
             return "403 Forbidden";
         }
 
-        if ( file_exists($path) ) {
+        if ( file_exists($path) )
+        {
             return "405 Method not allowed";
         }
 
-        if (!empty($this->_SERVER["CONTENT_LENGTH"])) { // no body parsing yet
+        if (!empty($this->_SERVER["CONTENT_LENGTH"]))
+        {
+// no body parsing yet
             return "415 Unsupported media type";
         }
 
         $stat = mkdir($path, 0777);
-        if (!$stat) {
+        if (!$stat)
+        {
             return "403 Forbidden";
         }
 
@@ -157,24 +164,35 @@ 
     {
         // TODO Property updates still broken (Litmus should detect this?)
 
-        if (!empty($this->_SERVER["CONTENT_LENGTH"])) { // no body parsing yet
+        if (!empty($this->_SERVER["CONTENT_LENGTH"]))
+        {
+// no body parsing yet
             return "415 Unsupported media type";
         }
 
         // no copying to different WebDAV Servers yet
-        if (isset($options["dest_url"])) {
+        if (isset($options["dest_url"]))
+        {
             return "502 bad gateway";
         }
 
         $source = $this->base .$options["path"];
-        if (!file_exists($source)) return "404 Not found";
+        if (!file_exists($source))
+        {
+        	return "404 Not found";
+        }
 
-        if (is_dir($source)) { // resource is a collection
-            switch ($options["depth"]) {
+        if (is_dir($source))
+        {
+// resource is a collection
+            switch ($options["depth"])
+            {
             case "infinity": // valid
                 break;
             case "0": // valid for COPY only
-                if ($del) { // MOVE?
+                if ($del)
+                {
+// MOVE?
                     return "400 Bad request";
                 }
                 break;
@@ -187,71 +205,99 @@ 
         $dest         = $this->base . $options["dest"];
         $destdir      = dirname($dest);
 
-        if (!file_exists($destdir) || !is_dir($destdir)) {
+        if (!file_exists($destdir) || !is_dir($destdir))
+        {
             return "409 Conflict";
         }
 
         $new          = !file_exists($dest);
         $existing_col = false;
 
-        if (!$new) {
-            if ($del && is_dir($dest)) {
-                if (!$options["overwrite"]) {
+        if (!$new)
+        {
+            if ($del && is_dir($dest))
+            {
+                if (!$options["overwrite"])
+                {
                     return "412 precondition failed";
                 }
                 $dest .= basename($source);
-                if (file_exists($dest)) {
+                if (file_exists($dest))
+                {
                     $options["dest"] .= basename($source);
-                } else {
+                }
+                else
+                {
                     $new          = true;
                     $existing_col = true;
                 }
             }
         }
 
-        if (!$new) {
-            if ($options["overwrite"]) {
+        if (!$new)
+        {
+            if ($options["overwrite"])
+            {
                 $stat = $this->DELETE(array("path" => $options["dest"]));
-                if (($stat{0} != "2") && (substr($stat, 0, 3) != "404")) {
+                if (($stat{0} != "2") && (substr($stat, 0, 3) != "404"))
+                {
                     return $stat;
                 }
-            } else {
+            }
+            else
+            {
                 return "412 precondition failed";
             }
         }
 
-        if ($del) {
-            if (!rename($source, $dest)) {
+        if ($del)
+        {
+            if (!rename($source, $dest))
+            {
                 return "500 Internal server error";
             }
-        } else {
-            if (is_dir($source) && $options['depth'] == 'infinity') {
+        }
+        else
+        {
+            if (is_dir($source) && $options['depth'] == 'infinity')
+            {
             	$files = Vfs::find($source,array('depth' => true,'url' => true));	// depth=true: return dirs first, url=true: allow urls!
-            } else {
+            }
+            else
+            {
                 $files = array($source);
             }
 
-            if (!is_array($files) || empty($files)) {
+            if (!is_array($files) || empty($files))
+            {
                 return "500 Internal server error";
             }
 
 
-            foreach ($files as $file) {
-                if (is_dir($file)) {
+            foreach ($files as $file)
+            {
+                if (is_dir($file))
+                {
                     $file = $this->_slashify($file);
                 }
 
                 $destfile = str_replace($source, $dest, $file);
 
-                if (is_dir($file)) {
-                    if (!is_dir($destfile)) {
+                if (is_dir($file))
+                {
+                    if (!is_dir($destfile))
+                    {
                         // TODO "mkdir -p" here? (only natively supported by PHP 5)
-                        if (!@mkdir($destfile)) {
+                        if (!@mkdir($destfile))
+                        {
                             return "409 Conflict";
                         }
                     }
-                } else {
-                    if (!@copy($file, $destfile)) {
+                }
+                else
+                {
+                    if (!@copy($file, $destfile))
+                    {
                         return "409 Conflict";
                     }
                 }
@@ -301,17 +347,23 @@ 
         $info["props"][] = self::mkprop("ishidden",        Vfs::is_hidden($fspath));
 
 		// type and size (caller already made sure that path exists)
-		if (is_dir($fspath)) {
+		if (is_dir($fspath))
+		{
 			// directory (WebDAV collection)
 			$info['props'][] = self::mkprop	('resourcetype', array(
 			 	self::mkprop('collection', '')));
 			$info['props'][] = self::mkprop	('getcontenttype', 'httpd/unix-directory');
-		} else {
+		}
+		else
+		{
 			// plain file (WebDAV resource)
 			$info['props'][] = self::mkprop	('resourcetype', '');
-			if (Vfs::is_readable($path)) {
+			if (Vfs::is_readable($path))
+			{
 				$info['props'][] = self::mkprop	('getcontenttype', Vfs::mime_content_type($path));
-			} else {
+			}
+			else
+			{
 				error_log(__METHOD__."($path) $fspath is not readable!");
 				$info['props'][] = self::mkprop	('getcontenttype', 'application/x-non-readable');
 			}
@@ -383,7 +435,10 @@ 
 				continue;
 			}
 			$_path = $info['path'];
-			if (!$n && $info['path'] != '/' && substr($info['path'],-1) == '/') $_path = substr($info['path'],0,-1);
+			if (!$n && $info['path'] != '/' && substr($info['path'],-1) == '/')
+			{
+				$_path = substr($info['path'],0,-1);
+			}
 
 			// need to encode path again, as $info['path'] is NOT encoded, but Vfs::(stat|propfind) require it
 			// otherwise pathes containing url special chars like ? or # will not stat
@@ -422,16 +477,22 @@ 
 				$fileprops =& $files['files'][$path2n[$path]]['props'];
 				foreach($props as $prop)
 				{
-					if ($prop['ns'] == Vfs::DEFAULT_PROP_NAMESPACE && $prop['name'][0] == '#')	// eGW's customfields
+					if ($prop['ns'] == Vfs::DEFAULT_PROP_NAMESPACE && $prop['name'][0] == '#')
+					{
+						// eGW's customfields
 					{
 						$prop['ns'] .= 'customfields/';
+					}
 						$prop['name'] = substr($prop['name'],1);
 					}
 					$fileprops[] = $prop;
 				}
 			}
 		}
-		if ($this->debug) error_log(__METHOD__."() props=".array2string($files['files']));
+		if ($this->debug)
+		{
+			error_log(__METHOD__."() props=".array2string($files['files']));
+		}
 		return true;
 	}
 
@@ -483,7 +544,8 @@ 
 	{
 		$path = Api\Translation::convert($options['path'],'utf-8');
 
-		foreach ($options['props'] as $key => $prop) {
+		foreach ($options['props'] as $key => $prop)
+		{
 			$attributes = array();
 			switch($prop['ns'])
 			{
@@ -500,7 +562,10 @@ 
 							//$attributes['created'] = strtotime($prop['val']);
 							//break;
 						default:
-							if (!Vfs::proppatch($path,array($prop))) $options['props'][$key]['status'] = '403 Forbidden';
+							if (!Vfs::proppatch($path,array($prop)))
+							{
+								$options['props'][$key]['status'] = '403 Forbidden';
+							}
 							break;
 					}
 					break;
@@ -529,7 +594,10 @@ 
 						case 'Win32LastAccessTime':
 						case 'Win32FileAttributes':	// not sure what that is, it was always "00000000"
 						default:
-							if (!Vfs::proppatch($path,array($prop))) $options['props'][$key]['status'] = '403 Forbidden';
+							if (!Vfs::proppatch($path,array($prop)))
+							{
+								$options['props'][$key]['status'] = '403 Forbidden';
+							}
 							break;
 					}
 					break;
@@ -539,15 +607,24 @@ 
 					$prop['name'] = '#'.$prop['name'];
 					// fall through
 				default:
-					if (!Vfs::proppatch($path,array($prop))) $options['props'][$key]['status'] = '403 Forbidden';
+					if (!Vfs::proppatch($path,array($prop)))
+					{
+						$options['props'][$key]['status'] = '403 Forbidden';
+					}
 					break;
 			}
-			if ($this->debug) $props[] = '('.$prop['ns'].')'.$prop['name'].'='.$prop['val'];
+			if ($this->debug)
+			{
+				$props[] = '('.$prop['ns'].')'.$prop['name'].'='.$prop['val'];
+			}
 		}
 		if ($this->debug)
 		{
 			error_log(__METHOD__.": path=$options[path], props=".implode(', ',$props));
-			if ($attributes) error_log(__METHOD__.": path=$options[path], set attributes=".str_replace("\n",' ',print_r($attributes,true)));
+			if ($attributes)
+			{
+				error_log(__METHOD__.": path=$options[path], set attributes=".str_replace("\n",' ',print_r($attributes,true)));
+			}
 		}
 
 		return '';	// this is as the filesystem example handler does it, no true or false ...
@@ -561,7 +638,10 @@ 
 	 */
 	function LOCK(&$options)
 	{
-		if ($this->debug) error_log(__METHOD__.'('.str_replace(array("\n",'    '),'',print_r($options,true)).')');
+		if ($this->debug)
+		{
+			error_log(__METHOD__.'('.str_replace(array("\n",'    '),'',print_r($options,true)).')');
+		}
 		// TODO recursive locks on directories not supported yet
 		if (is_dir($this->base . $options['path']) && !empty($options['depth']))
 		{
@@ -587,7 +667,10 @@ 
 	 */
 	function UNLOCK(&$options)
 	{
-		if ($this->debug) error_log(__METHOD__.'('.str_replace(array("\n",'    '),'',print_r($options,true)).')');
+		if ($this->debug)
+		{
+			error_log(__METHOD__.'('.str_replace(array("\n",'    '),'',print_r($options,true)).')');
+		}
 		return Vfs::unlock($options['path'],$options['token']) ? '204 No Content' : '409 Conflict';
 	}
 

api/src/WebDAV/Server.php

Doc Comments +9 added lines, -1 removed lines

@@ -2170,6 +2170,9 @@ 
 
     // {{{ _copymove()
 
+    /**
+     * @param string $what
+     */
     function _copymove($what)
     {
         $options         = Array();
@@ -2509,7 +2512,7 @@ 
      * defined in RFC 2518 section 9.4
      *
      * @param  void
-     * @return void
+     * @return boolean
      */
     function _check_if_header_conditions()
     {
@@ -2581,6 +2584,7 @@ 
      *
      * @param  string  path of resource to check
      * @param  bool    exclusive lock?
+     * @param string $path
      */
     function _check_lock_status($path, $exclusive_only = false)
     {
@@ -2733,6 +2737,7 @@ 
      * not really needed but added for completenes
      *
      * @param  string  URL to decode
+     * @param string $path
      * @return string  decoded URL
      */
     public static function _urldecode($path)
@@ -2835,6 +2840,7 @@ 
      * UTF-8 encode property values if not already done so
      *
      * @param  string  text to encode
+     * @param string $text
      * @return string  utf-8 encoded text
      */
     function _prop_encode($text)
@@ -2876,6 +2882,7 @@ 
      *
      * @param   string directory path
      * @returns string directory path wihtout trailing slash
+     * @return string
      */
     public static function _unslashify($path)
     {
@@ -2892,6 +2899,7 @@ 
      *
      * @param  string  parent path
      * @param  string  child path
+     * @param string $child
      * @return string  merged path
      */
     public static function _mergePaths($parent, $child)

Indentation +2524 added lines, -2524 removed lines

@@ -48,632 +48,632 @@ 
  */
 class HTTP_WebDAV_Server
 {
-    // {{{ Member Variables
+	// {{{ Member Variables
 
-    /**
-     * complete URI for this request
-     *
-     * @var string
-     */
-    var $uri;
+	/**
+	 * complete URI for this request
+	 *
+	 * @var string
+	 */
+	var $uri;
 
-    /**
-     * base URI for this request
-     *
-     * @var string
-     */
-    var $base_uri;
+	/**
+	 * base URI for this request
+	 *
+	 * @var string
+	 */
+	var $base_uri;
 
-    /**
-     * Set if client requires <D:href> to be a url (true) or a path (false).
-     * RFC 4918 allows both: http://www.webdav.org/specs/rfc4918.html#ELEMENT_href
-     * But some clients can NOT deal with one or the other!
-     *
-     * @var boolean
-     */
-    var $client_require_href_as_url;
-
-     /**
-     * Set if client requires or does not allow namespace redundacy.
-     * The XML Namespace specification does allow both
-     * But some clients can NOT deal with one or the other!
-     *
-     * $this->crrnd === false:
-     * <D:multistatus xmlns:D="DAV:">
-     *  <D:response xmlns:ns0="urn:uuid:c2f41010-65b3-11d1-a29f-00aa00c14882/">
-     *   <D:href>/egroupware/webdav.php/home/ralf/</D:href>
-     *    <D:propstat>
-     *     <D:prop>
-     *      <D:resourcetype><D:collection /></D:resourcetype>
-     *     </D:prop>
-     *    <D:status>HTTP/1.1 200 OK</D:status>
-     *   </D:propstat>
-     *  </D:response>
-     * </D:multistatus>
-     *
-     * $this->crrnd === true:
-     * <multistatus xmlns="DAV:">
-     *  <response xmlns:ns0="urn:uuid:c2f41010-65b3-11d1-a29f-00aa00c14882/">
-     *   <href>/egroupware/webdav.php/home/ralf/</href>
-     *    <propstat>
-     *     <prop>
-     *      <resourcetype><collection /></resourcetype>
-     *     </prop>
-     *    <status>HTTP/1.1 200 OK</status>
-     *   </propstat>
-     *  </response>
-     * </multistatus>
-     *
-     * @var boolean (client_refuses_redundand_namespace_declarations)
-     */
-    var $crrnd = false;
+	/**
+	 * Set if client requires <D:href> to be a url (true) or a path (false).
+	 * RFC 4918 allows both: http://www.webdav.org/specs/rfc4918.html#ELEMENT_href
+	 * But some clients can NOT deal with one or the other!
+	 *
+	 * @var boolean
+	 */
+	var $client_require_href_as_url;
+
+	 /**
+	  * Set if client requires or does not allow namespace redundacy.
+	  * The XML Namespace specification does allow both
+	  * But some clients can NOT deal with one or the other!
+	  *
+	  * $this->crrnd === false:
+	  * <D:multistatus xmlns:D="DAV:">
+	  *  <D:response xmlns:ns0="urn:uuid:c2f41010-65b3-11d1-a29f-00aa00c14882/">
+	  *   <D:href>/egroupware/webdav.php/home/ralf/</D:href>
+	  *    <D:propstat>
+	  *     <D:prop>
+	  *      <D:resourcetype><D:collection /></D:resourcetype>
+	  *     </D:prop>
+	  *    <D:status>HTTP/1.1 200 OK</D:status>
+	  *   </D:propstat>
+	  *  </D:response>
+	  * </D:multistatus>
+	  *
+	  * $this->crrnd === true:
+	  * <multistatus xmlns="DAV:">
+	  *  <response xmlns:ns0="urn:uuid:c2f41010-65b3-11d1-a29f-00aa00c14882/">
+	  *   <href>/egroupware/webdav.php/home/ralf/</href>
+	  *    <propstat>
+	  *     <prop>
+	  *      <resourcetype><collection /></resourcetype>
+	  *     </prop>
+	  *    <status>HTTP/1.1 200 OK</status>
+	  *   </propstat>
+	  *  </response>
+	  * </multistatus>
+	  *
+	  * @var boolean (client_refuses_redundand_namespace_declarations)
+	  */
+	var $crrnd = false;
 
-    /**
+	/**
 
 
     /**
-     * URI path for this request
-     *
-     * @var string
-     */
-    var $path;
+	 * URI path for this request
+	 *
+	 * @var string
+	 */
+	var $path;
 
-    /**
-     * Realm string to be used in authentification popups
-     *
-     * @var string
-     */
-    var $http_auth_realm = "PHP WebDAV";
+	/**
+	 * Realm string to be used in authentification popups
+	 *
+	 * @var string
+	 */
+	var $http_auth_realm = "PHP WebDAV";
 
-    /**
-     * String to be used in "X-Dav-Powered-By" header
-     *
-     * @var string
-     */
-    var $dav_powered_by = "";
+	/**
+	 * String to be used in "X-Dav-Powered-By" header
+	 *
+	 * @var string
+	 */
+	var $dav_powered_by = "";
 
-    /**
-     * Remember parsed If: (RFC2518/9.4) header conditions
-     *
-     * @var array
-     */
-    var $_if_header_uris = array();
+	/**
+	 * Remember parsed If: (RFC2518/9.4) header conditions
+	 *
+	 * @var array
+	 */
+	var $_if_header_uris = array();
 
-    /**
-     * HTTP response status/message
-     *
-     * @var string
-     */
-    var $_http_status = "200 OK";
+	/**
+	 * HTTP response status/message
+	 *
+	 * @var string
+	 */
+	var $_http_status = "200 OK";
 
-    /**
-     * encoding of property values passed in
-     *
-     * @var string
-     */
-    var $_prop_encoding = "utf-8";
+	/**
+	 * encoding of property values passed in
+	 *
+	 * @var string
+	 */
+	var $_prop_encoding = "utf-8";
 
-    /**
-     * Copy of $_SERVER superglobal array
-     *
-     * Derived classes may extend the constructor to
-     * modify its contents
-     *
-     * @var array
-     */
-    var $_SERVER;
+	/**
+	 * Copy of $_SERVER superglobal array
+	 *
+	 * Derived classes may extend the constructor to
+	 * modify its contents
+	 *
+	 * @var array
+	 */
+	var $_SERVER;
 
-    // }}}
+	// }}}
 
-    // {{{ Constructor
+	// {{{ Constructor
 
-    /**
-     * Constructor
-     *
-     * @param void
-     */
-    function __construct()
-    {
-        // PHP messages destroy XML output -> switch them off
-        ini_set("display_errors", 0);
-
-        // copy $_SERVER variables to local _SERVER array
-        // so that derived classes can simply modify these
-        $this->_SERVER = $_SERVER;
-    }
-
-    // }}}
-
-    // {{{ ServeRequest()
-    /**
-     * Serve WebDAV HTTP request
-     *
-     * dispatch WebDAV HTTP request to the apropriate method handler
-     *
-     * @param  $prefix =null prefix filesystem path with given path, eg. "/webdav" for owncloud 4.5 remote.php
-     * @return void
-     */
-    function ServeRequest($prefix=null)
-    {
-        // prevent warning in litmus check 'delete_fragment'
-        if (strstr($this->_SERVER["REQUEST_URI"], '#')) {
-            $this->http_status("400 Bad Request");
-            return;
-        }
-
-        // default is currently to use just the path, extending class can set $this->client_require_href_as_url depending on user-agent
-        if ($this->client_require_href_as_url)
-        {
-	        // default uri is the complete request uri
-	        $uri = (@$this->_SERVER["HTTPS"] === "on" ? "https:" : "http:") . '//'.$this->_SERVER['HTTP_HOST'];
-        }
-        $uri .= $this->_SERVER["SCRIPT_NAME"];
-
-        // WebDAV has no concept of a query string and clients (including cadaver)
-        // seem to pass '?' unencoded, so we need to extract the path info out
-        // of the request URI ourselves
-        // if request URI contains a full url, remove schema and domain
+	/**
+	 * Constructor
+	 *
+	 * @param void
+	 */
+	function __construct()
+	{
+		// PHP messages destroy XML output -> switch them off
+		ini_set("display_errors", 0);
+
+		// copy $_SERVER variables to local _SERVER array
+		// so that derived classes can simply modify these
+		$this->_SERVER = $_SERVER;
+	}
+
+	// }}}
+
+	// {{{ ServeRequest()
+	/**
+	 * Serve WebDAV HTTP request
+	 *
+	 * dispatch WebDAV HTTP request to the apropriate method handler
+	 *
+	 * @param  $prefix =null prefix filesystem path with given path, eg. "/webdav" for owncloud 4.5 remote.php
+	 * @return void
+	 */
+	function ServeRequest($prefix=null)
+	{
+		// prevent warning in litmus check 'delete_fragment'
+		if (strstr($this->_SERVER["REQUEST_URI"], '#')) {
+			$this->http_status("400 Bad Request");
+			return;
+		}
+
+		// default is currently to use just the path, extending class can set $this->client_require_href_as_url depending on user-agent
+		if ($this->client_require_href_as_url)
+		{
+			// default uri is the complete request uri
+			$uri = (@$this->_SERVER["HTTPS"] === "on" ? "https:" : "http:") . '//'.$this->_SERVER['HTTP_HOST'];
+		}
+		$uri .= $this->_SERVER["SCRIPT_NAME"];
+
+		// WebDAV has no concept of a query string and clients (including cadaver)
+		// seem to pass '?' unencoded, so we need to extract the path info out
+		// of the request URI ourselves
+		// if request URI contains a full url, remove schema and domain
 		$matches = null;
-        if (preg_match('|^https?://[^/]+(/.*)$|', $path_info=$this->_SERVER["REQUEST_URI"], $matches))
-        {
-        	$path_info = $matches[1];
-        }
-        $path_info_raw = substr($path_info, strlen($this->_SERVER["SCRIPT_NAME"]));
-
-        // just in case the path came in empty ...
-        if (empty($path_info_raw)) {
-            $path_info_raw = "/";
-        }
-
-        $path_info = self::_urldecode($path_info_raw);
-
-        if ($prefix && strpos($path_info, $prefix) === 0)
-        {
-        	$uri .= $prefix;
-        	list(,$path_info) = explode($prefix, $path_info, 2);
-        }
-
-        $this->base_uri = $uri;
-        $this->uri      = $uri . $path_info;
-
-        // set path
-        // $_SERVER['PATH_INFO'] is already urldecoded
-        //$this->path = self::_urldecode($path_info);
-        // quote '#' (e.g. OpenOffice uses this for lock-files)
-        $this->path = strtr($path_info,array(
-        	'%' => '%25',
-        	'#' => '%23',
-        	'?' => '%3F',
-        ));
-        if (!strlen($this->path)) {
-            if ($this->_SERVER["REQUEST_METHOD"] == "GET") {
-                // redirect clients that try to GET a collection
-                // WebDAV clients should never try this while
-                // regular HTTP clients might ...
-                header("Location: ".$this->base_uri."/");
-                return;
-            } else {
-                // if a WebDAV client didn't give a path we just assume '/'
-                $this->path = "/";
-            }
-        }
-
-        if (ini_get("magic_quotes_gpc")) {
-            $this->path = stripslashes($this->path);
-        }
-
-
-        // identify ourselves
-        if (empty($this->dav_powered_by)) {
-            header("X-Dav-Powered-By: PHP class: ".get_class($this));
-        } else {
-            header("X-Dav-Powered-By: ".$this->dav_powered_by);
-        }
-
-        // check authentication
-        // for the motivation for not checking OPTIONS requests on / see
-        // http://pear.php.net/bugs/bug.php?id=5363
-        if ( (   !(($this->_SERVER['REQUEST_METHOD'] == 'OPTIONS') && ($this->path == "/")))
-             && (!$this->_check_auth())) {
-            // RFC2518 says we must use Digest instead of Basic
-            // but Microsoft Clients do not support Digest
-            // and we don't support NTLM and Kerberos
-            // so we are stuck with Basic here
-            header('WWW-Authenticate: Basic realm="'.($this->http_auth_realm).'"');
-
-            // Windows seems to require this being the last header sent
-            // (changed according to PECL bug #3138)
-            $this->http_status('401 Unauthorized');
-
-            return;
-        }
-
-        // check
-        if (! $this->_check_if_header_conditions()) {
-            return;
-        }
-
-        // detect requested method names
-        $method  = strtolower($this->_SERVER["REQUEST_METHOD"]);
-        $wrapper = "http_".$method;
-
-        // activate HEAD emulation by GET if no HEAD method found
-        if ($method == "head" && !method_exists($this, "head")) {
-            $method = "get";
-        }
-
-        if (method_exists($this, $wrapper) && ($method == "options" || method_exists($this, $method))) {
-            $this->$wrapper();  // call method by name
-        } else { // method not found/implemented
-            if ($this->_SERVER["REQUEST_METHOD"] == "LOCK") {
-            	$error = '412 Precondition failed';
-            } else {
-                $error = '405 Method not allowed';
-                header("Allow: ".join(", ", $this->_allow()));  // tell client what's allowed
-            }
-            $this->http_status($error);
-            echo "<html><head><title>Error $error</title></head>\n";
-            echo "<body><h1>$error</h1>\n";
-            echo "The requested could not by handled by this server.\n";
-            echo '(URI ' . $this->_SERVER['REQUEST_URI'] . ")<br>\n<br>\n";
-            echo "</body></html>\n";
-        }
-    }
-
-    // }}}
-
-    // {{{ abstract WebDAV methods
-
-    // {{{ GET()
-    /**
-     * GET implementation
-     *
-     * overload this method to retrieve resources from your server
-     * <br>
-     *
-     *
-     * @abstract
-     * @param array &$params Array of input and output parameters
-     * <br><b>input</b><ul>
-     * <li> path -
-     * </ul>
-     * <br><b>output</b><ul>
-     * <li> size -
-     * </ul>
-     * @returns int HTTP-Statuscode
-     */
-
-    /* abstract
+		if (preg_match('|^https?://[^/]+(/.*)$|', $path_info=$this->_SERVER["REQUEST_URI"], $matches))
+		{
+			$path_info = $matches[1];
+		}
+		$path_info_raw = substr($path_info, strlen($this->_SERVER["SCRIPT_NAME"]));
+
+		// just in case the path came in empty ...
+		if (empty($path_info_raw)) {
+			$path_info_raw = "/";
+		}
+
+		$path_info = self::_urldecode($path_info_raw);
+
+		if ($prefix && strpos($path_info, $prefix) === 0)
+		{
+			$uri .= $prefix;
+			list(,$path_info) = explode($prefix, $path_info, 2);
+		}
+
+		$this->base_uri = $uri;
+		$this->uri      = $uri . $path_info;
+
+		// set path
+		// $_SERVER['PATH_INFO'] is already urldecoded
+		//$this->path = self::_urldecode($path_info);
+		// quote '#' (e.g. OpenOffice uses this for lock-files)
+		$this->path = strtr($path_info,array(
+			'%' => '%25',
+			'#' => '%23',
+			'?' => '%3F',
+		));
+		if (!strlen($this->path)) {
+			if ($this->_SERVER["REQUEST_METHOD"] == "GET") {
+				// redirect clients that try to GET a collection
+				// WebDAV clients should never try this while
+				// regular HTTP clients might ...
+				header("Location: ".$this->base_uri."/");
+				return;
+			} else {
+				// if a WebDAV client didn't give a path we just assume '/'
+				$this->path = "/";
+			}
+		}
+
+		if (ini_get("magic_quotes_gpc")) {
+			$this->path = stripslashes($this->path);
+		}
+
+
+		// identify ourselves
+		if (empty($this->dav_powered_by)) {
+			header("X-Dav-Powered-By: PHP class: ".get_class($this));
+		} else {
+			header("X-Dav-Powered-By: ".$this->dav_powered_by);
+		}
+
+		// check authentication
+		// for the motivation for not checking OPTIONS requests on / see
+		// http://pear.php.net/bugs/bug.php?id=5363
+		if ( (   !(($this->_SERVER['REQUEST_METHOD'] == 'OPTIONS') && ($this->path == "/")))
+			 && (!$this->_check_auth())) {
+			// RFC2518 says we must use Digest instead of Basic
+			// but Microsoft Clients do not support Digest
+			// and we don't support NTLM and Kerberos
+			// so we are stuck with Basic here
+			header('WWW-Authenticate: Basic realm="'.($this->http_auth_realm).'"');
+
+			// Windows seems to require this being the last header sent
+			// (changed according to PECL bug #3138)
+			$this->http_status('401 Unauthorized');
+
+			return;
+		}
+
+		// check
+		if (! $this->_check_if_header_conditions()) {
+			return;
+		}
+
+		// detect requested method names
+		$method  = strtolower($this->_SERVER["REQUEST_METHOD"]);
+		$wrapper = "http_".$method;
+
+		// activate HEAD emulation by GET if no HEAD method found
+		if ($method == "head" && !method_exists($this, "head")) {
+			$method = "get";
+		}
+
+		if (method_exists($this, $wrapper) && ($method == "options" || method_exists($this, $method))) {
+			$this->$wrapper();  // call method by name
+		} else { // method not found/implemented
+			if ($this->_SERVER["REQUEST_METHOD"] == "LOCK") {
+				$error = '412 Precondition failed';
+			} else {
+				$error = '405 Method not allowed';
+				header("Allow: ".join(", ", $this->_allow()));  // tell client what's allowed
+			}
+			$this->http_status($error);
+			echo "<html><head><title>Error $error</title></head>\n";
+			echo "<body><h1>$error</h1>\n";
+			echo "The requested could not by handled by this server.\n";
+			echo '(URI ' . $this->_SERVER['REQUEST_URI'] . ")<br>\n<br>\n";
+			echo "</body></html>\n";
+		}
+	}
+
+	// }}}
+
+	// {{{ abstract WebDAV methods
+
+	// {{{ GET()
+	/**
+	 * GET implementation
+	 *
+	 * overload this method to retrieve resources from your server
+	 * <br>
+	 *
+	 *
+	 * @abstract
+	 * @param array &$params Array of input and output parameters
+	 * <br><b>input</b><ul>
+	 * <li> path -
+	 * </ul>
+	 * <br><b>output</b><ul>
+	 * <li> size -
+	 * </ul>
+	 * @returns int HTTP-Statuscode
+	 */
+
+	/* abstract
      function GET(&$params)
      {
      // dummy entry for PHPDoc
      }
     */
 
-    // }}}
+	// }}}
 
-    // {{{ PUT()
-    /**
-     * PUT implementation
-     *
-     * PUT implementation
-     *
-     * @abstract
-     * @param array &$params
-     * @returns int HTTP-Statuscode
-     */
-
-    /* abstract
+	// {{{ PUT()
+	/**
+	 * PUT implementation
+	 *
+	 * PUT implementation
+	 *
+	 * @abstract
+	 * @param array &$params
+	 * @returns int HTTP-Statuscode
+	 */
+
+	/* abstract
      function PUT()
      {
      // dummy entry for PHPDoc
      }
     */
 
-    // }}}
+	// }}}
 
-    // {{{ COPY()
+	// {{{ COPY()
 
-    /**
-     * COPY implementation
-     *
-     * COPY implementation
-     *
-     * @abstract
-     * @param array &$params
-     * @returns int HTTP-Statuscode
-     */
-
-    /* abstract
+	/**
+	 * COPY implementation
+	 *
+	 * COPY implementation
+	 *
+	 * @abstract
+	 * @param array &$params
+	 * @returns int HTTP-Statuscode
+	 */
+
+	/* abstract
      function COPY()
      {
      // dummy entry for PHPDoc
      }
     */
 
-    // }}}
+	// }}}
 
-    // {{{ MOVE()
+	// {{{ MOVE()
 
-    /**
-     * MOVE implementation
-     *
-     * MOVE implementation
-     *
-     * @abstract
-     * @param array &$params
-     * @returns int HTTP-Statuscode
-     */
-
-    /* abstract
+	/**
+	 * MOVE implementation
+	 *
+	 * MOVE implementation
+	 *
+	 * @abstract
+	 * @param array &$params
+	 * @returns int HTTP-Statuscode
+	 */
+
+	/* abstract
      function MOVE()
      {
      // dummy entry for PHPDoc
      }
     */
 
-    // }}}
+	// }}}
 
-    // {{{ DELETE()
+	// {{{ DELETE()
 
-    /**
-     * DELETE implementation
-     *
-     * DELETE implementation
-     *
-     * @abstract
-     * @param array &$params
-     * @returns int HTTP-Statuscode
-     */
-
-    /* abstract
+	/**
+	 * DELETE implementation
+	 *
+	 * DELETE implementation
+	 *
+	 * @abstract
+	 * @param array &$params
+	 * @returns int HTTP-Statuscode
+	 */
+
+	/* abstract
      function DELETE()
      {
      // dummy entry for PHPDoc
      }
     */
-    // }}}
+	// }}}
 
-    // {{{ PROPFIND()
+	// {{{ PROPFIND()
 
-    /**
-     * PROPFIND implementation
-     *
-     * PROPFIND implementation
-     *
-     * @abstract
-     * @param array &$params
-     * @returns int HTTP-Statuscode
-     */
-
-    /* abstract
+	/**
+	 * PROPFIND implementation
+	 *
+	 * PROPFIND implementation
+	 *
+	 * @abstract
+	 * @param array &$params
+	 * @returns int HTTP-Statuscode
+	 */
+
+	/* abstract
      function PROPFIND()
      {
      // dummy entry for PHPDoc
      }
     */
 
-    // }}}
+	// }}}
 
-    // {{{ PROPPATCH()
+	// {{{ PROPPATCH()
 
-    /**
-     * PROPPATCH implementation
-     *
-     * PROPPATCH implementation
-     *
-     * @abstract
-     * @param array &$params
-     * @returns int HTTP-Statuscode
-     */
-
-    /* abstract
+	/**
+	 * PROPPATCH implementation
+	 *
+	 * PROPPATCH implementation
+	 *
+	 * @abstract
+	 * @param array &$params
+	 * @returns int HTTP-Statuscode
+	 */
+
+	/* abstract
      function PROPPATCH()
      {
      // dummy entry for PHPDoc
      }
     */
-    // }}}
+	// }}}
 
-    // {{{ LOCK()
+	// {{{ LOCK()
 
-    /**
-     * LOCK implementation
-     *
-     * LOCK implementation
-     *
-     * @abstract
-     * @param array &$params
-     * @returns int HTTP-Statuscode
-     */
-
-    /* abstract
+	/**
+	 * LOCK implementation
+	 *
+	 * LOCK implementation
+	 *
+	 * @abstract
+	 * @param array &$params
+	 * @returns int HTTP-Statuscode
+	 */
+
+	/* abstract
      function LOCK()
      {
      // dummy entry for PHPDoc
      }
     */
-    // }}}
+	// }}}
 
-    // {{{ UNLOCK()
+	// {{{ UNLOCK()
 
-    /**
-     * UNLOCK implementation
-     *
-     * UNLOCK implementation
-     *
-     * @abstract
-     * @param array &$params
-     * @returns int HTTP-Statuscode
-     */
-
-    /* abstract
+	/**
+	 * UNLOCK implementation
+	 *
+	 * UNLOCK implementation
+	 *
+	 * @abstract
+	 * @param array &$params
+	 * @returns int HTTP-Statuscode
+	 */
+
+	/* abstract
      function UNLOCK()
      {
      // dummy entry for PHPDoc
      }
     */
-    // }}}
+	// }}}
 
-    // {{{ ACL()
+	// {{{ ACL()
 
-    /**
-     * ACL implementation
-     *
-     * ACL implementation
-     *
-     * @abstract
-     * @param array &$params
-     * @returns int HTTP-Statuscode
-     */
-
-    /* abstract
+	/**
+	 * ACL implementation
+	 *
+	 * ACL implementation
+	 *
+	 * @abstract
+	 * @param array &$params
+	 * @returns int HTTP-Statuscode
+	 */
+
+	/* abstract
      function ACL()
      {
      // dummy entry for PHPDoc
      }
     */
-    // }}}
+	// }}}
 
-    // }}}
+	// }}}
 
-    // {{{ other abstract methods
+	// {{{ other abstract methods
 
-    // {{{ check_auth()
+	// {{{ check_auth()
 
-    /**
-     * check authentication
-     *
-     * overload this method to retrieve and confirm authentication information
-     *
-     * @abstract
-     * @param string type Authentication type, e.g. "basic" or "digest"
-     * @param string username Transmitted username
-     * @param string passwort Transmitted password
-     * @returns bool Authentication status
-     */
-
-    /* abstract
+	/**
+	 * check authentication
+	 *
+	 * overload this method to retrieve and confirm authentication information
+	 *
+	 * @abstract
+	 * @param string type Authentication type, e.g. "basic" or "digest"
+	 * @param string username Transmitted username
+	 * @param string passwort Transmitted password
+	 * @returns bool Authentication status
+	 */
+
+	/* abstract
      function checkAuth($type, $username, $password)
      {
      // dummy entry for PHPDoc
      }
     */
 
-    // }}}
+	// }}}
 
-    // {{{ checklock()
+	// {{{ checklock()
 
-    /**
-     * check lock status for a resource
-     *
-     * overload this method to return shared and exclusive locks
-     * active for this resource
-     *
-     * @abstract
-     * @param string resource Resource path to check
-     * @returns array An array of lock entries each consisting
-     *                of 'type' ('shared'/'exclusive'), 'token' and 'timeout'
-     */
-
-    /* abstract
+	/**
+	 * check lock status for a resource
+	 *
+	 * overload this method to return shared and exclusive locks
+	 * active for this resource
+	 *
+	 * @abstract
+	 * @param string resource Resource path to check
+	 * @returns array An array of lock entries each consisting
+	 *                of 'type' ('shared'/'exclusive'), 'token' and 'timeout'
+	 */
+
+	/* abstract
      function checklock($resource)
      {
      // dummy entry for PHPDoc
      }
     */
 
-    // }}}
+	// }}}
 
-    // }}}
+	// }}}
 
-    // {{{ WebDAV HTTP method wrappers
+	// {{{ WebDAV HTTP method wrappers
 
-    // {{{ http_OPTIONS()
+	// {{{ http_OPTIONS()
 
-    /**
-     * OPTIONS method handler
-     *
-     * The OPTIONS method handler creates a valid OPTIONS reply
-     * including Dav: and Allowed: headers
-     * based on the implemented methods found in the actual instance
-     *
-     * @param  void
-     * @return void
-     */
-    function http_OPTIONS()
-    {
-        // Microsoft clients default to the Frontpage protocol
-        // unless we tell them to use WebDAV
-        header("MS-Author-Via: DAV");
-
-        // get allowed methods
-        $allow = $this->_allow();
-
-        // dav header
-        $dav = array(1);        // assume we are always dav class 1 compliant
-        if (isset($allow['LOCK'])) {
-            $dav[] = 2;         // dav class 2 requires that locking is supported
-        }
-
-        // allow extending class to modify DAV and Allow headers
+	/**
+	 * OPTIONS method handler
+	 *
+	 * The OPTIONS method handler creates a valid OPTIONS reply
+	 * including Dav: and Allowed: headers
+	 * based on the implemented methods found in the actual instance
+	 *
+	 * @param  void
+	 * @return void
+	 */
+	function http_OPTIONS()
+	{
+		// Microsoft clients default to the Frontpage protocol
+		// unless we tell them to use WebDAV
+		header("MS-Author-Via: DAV");
+
+		// get allowed methods
+		$allow = $this->_allow();
+
+		// dav header
+		$dav = array(1);        // assume we are always dav class 1 compliant
+		if (isset($allow['LOCK'])) {
+			$dav[] = 2;         // dav class 2 requires that locking is supported
+		}
+
+		// allow extending class to modify DAV and Allow headers
 		if (method_exists($this,'OPTIONS')) {
 			$this->OPTIONS($this->path,$dav,$allow);
 		}
 
-        // tell clients what we found
-        $this->http_status("200 OK");
-        header("DAV: "  .join(", ", $dav));
-        header("Allow: ".join(", ", $allow));
+		// tell clients what we found
+		$this->http_status("200 OK");
+		header("DAV: "  .join(", ", $dav));
+		header("Allow: ".join(", ", $allow));
 
-        header("Content-length: 0");
-    }
+		header("Content-length: 0");
+	}
 
-    // }}}
+	// }}}
 
 
-    // {{{ http_PROPFIND()
+	// {{{ http_PROPFIND()
 
-    /**
-     * Should the whole PROPFIND request (xml) be stored
-     *
-     * @var boolean
-     */
-    var $store_request = false;
-    /**
-     * Content of (last) PROPFIND request
-     *
-     * @var string
-     */
-    var $request;
+	/**
+	 * Should the whole PROPFIND request (xml) be stored
+	 *
+	 * @var boolean
+	 */
+	var $store_request = false;
+	/**
+	 * Content of (last) PROPFIND request
+	 *
+	 * @var string
+	 */
+	var $request;
 
-    /**
-     * PROPFIND method handler
-     *
-     * @param  string $handler ='PROPFIND' allows to use method eg. for CalDAV REPORT
-     * @return void
-     */
-    function http_PROPFIND($handler='PROPFIND')
-    {
-        $options = Array();
-        $files   = Array();
-
-        $options["path"] = $this->path;
-
-        // search depth from header (default is "infinity)
-        if (isset($this->_SERVER['HTTP_DEPTH'])) {
-            $options["depth"] = $this->_SERVER["HTTP_DEPTH"];
-        } else {
-            $options["depth"] = "infinity";
-        }
-
-        // analyze request payload
-        $propinfo = new _parse_propfind("php://input", $this->store_request);
-        if ($this->store_request) $this->request = $propinfo->request;
-        if (!$propinfo->success) {
-            $this->http_status("400 Error");
-            return;
-        }
+	/**
+	 * PROPFIND method handler
+	 *
+	 * @param  string $handler ='PROPFIND' allows to use method eg. for CalDAV REPORT
+	 * @return void
+	 */
+	function http_PROPFIND($handler='PROPFIND')
+	{
+		$options = Array();
+		$files   = Array();
+
+		$options["path"] = $this->path;
+
+		// search depth from header (default is "infinity)
+		if (isset($this->_SERVER['HTTP_DEPTH'])) {
+			$options["depth"] = $this->_SERVER["HTTP_DEPTH"];
+		} else {
+			$options["depth"] = "infinity";
+		}
+
+		// analyze request payload
+		$propinfo = new _parse_propfind("php://input", $this->store_request);
+		if ($this->store_request) $this->request = $propinfo->request;
+		if (!$propinfo->success) {
+			$this->http_status("400 Error");
+			return;
+		}
 		$options['root'] = $propinfo->root;
 		$options['props'] = $propinfo->props;
 		if ($propinfo->filters)
@@ -681,34 +681,34 @@ 
 		if ($propinfo->other)
 			$options['other'] = $propinfo->other;
 
-        // call user handler
-        if (!($retval =$this->$handler($options, $files))) {
-            $files = array("files" => array());
-            if (method_exists($this, "checkLock")) {
-                // is locked?
-                $lock = $this->checkLock($this->path);
-
-                if (is_array($lock) && count($lock)) {
-                    $created          = isset($lock['created'])  ? $lock['created']  : time();
-                    $modified         = isset($lock['modified']) ? $lock['modified'] : time();
-                    $files['files'][] = array("path"  => self::_slashify($this->path),
-                                              "props" => array($this->mkprop("displayname",      $this->path),
-                                                               $this->mkprop("creationdate",     $created),
-                                                               $this->mkprop("getlastmodified",  $modified),
-                                                               $this->mkprop("resourcetype",     ""),
-                                                               $this->mkprop("getcontenttype",   ""),
-                                                               $this->mkprop("getcontentlength", 0))
-                                              );
-                }
-            }
-
-            if (empty($files['files'])) {
-                $this->http_status("404 Not Found");
-                return;
-            }
-        }
-
-        // now we generate the reply header ...
+		// call user handler
+		if (!($retval =$this->$handler($options, $files))) {
+			$files = array("files" => array());
+			if (method_exists($this, "checkLock")) {
+				// is locked?
+				$lock = $this->checkLock($this->path);
+
+				if (is_array($lock) && count($lock)) {
+					$created          = isset($lock['created'])  ? $lock['created']  : time();
+					$modified         = isset($lock['modified']) ? $lock['modified'] : time();
+					$files['files'][] = array("path"  => self::_slashify($this->path),
+											  "props" => array($this->mkprop("displayname",      $this->path),
+															   $this->mkprop("creationdate",     $created),
+															   $this->mkprop("getlastmodified",  $modified),
+															   $this->mkprop("resourcetype",     ""),
+															   $this->mkprop("getcontenttype",   ""),
+															   $this->mkprop("getcontentlength", 0))
+											  );
+				}
+			}
+
+			if (empty($files['files'])) {
+				$this->http_status("404 Not Found");
+				return;
+			}
+		}
+
+		// now we generate the reply header ...
 		if ($retval === true)
 		{
 			$this->http_status('207 Multi-Status');
@@ -732,506 +732,506 @@ 
 			return;
 		}
 		// dav header
-        $dav = array(1);        // assume we are always dav class 1 compliant
-        $allow = false;
+		$dav = array(1);        // assume we are always dav class 1 compliant
+		$allow = false;
 
-        // allow extending class to modify DAV
+		// allow extending class to modify DAV
 		if (method_exists($this,'OPTIONS')) {
 			$this->OPTIONS($this->path,$dav,$allow);
 		}
-        header("DAV: "  .join(", ", $dav));
-        header('Content-Type: text/xml; charset="utf-8"');
+		header("DAV: "  .join(", ", $dav));
+		header('Content-Type: text/xml; charset="utf-8"');
 
-        // add Vary and Preference-Applied header for Prefer: return=minimal
-        if (isset($this->_SERVER['HTTP_PREFER']) && in_array('return=minimal', preg_split('/, ?/', $this->_SERVER['HTTP_PREFER'])))
-        {
-        	header("Preference-Applied: return=minimal");
-        	header("Vary: Prefer");
-        }
-
-        // ... and payload
-        echo "<?xml version=\"1.0\" encoding=\"utf-8\"?>\n";
-        echo $this->crrnd ? "<multistatus xmlns=\"DAV:\">\n" : "<D:multistatus xmlns:D=\"DAV:\">\n";
-
-        $this->multistatus_responses($files['files'], $options['props']);
-
-        // WebDAV sync report sync-token, can be either the sync-token or a callback (called with params in $files['sync-token-params'])
-        if (isset($files['sync-token']))
-        {
-            echo ($this->crrnd ? " <" : " <D:")."sync-token>".
-            	htmlspecialchars(!is_callable($files['sync-token']) ? $files['sync-token'] :
-            		call_user_func_array($files['sync-token'], (array)$files['sync-token-params'])).
-            	($this->crrnd ? "</" : "</D:")."sync-token>\n";
-        }
-
-        echo '</'.($this->crrnd?'':'D:')."multistatus>\n";
-    }
-
-    /**
-     * Render (echo) XML for given multistatus responses
-     *
-     * @param array|Iterator $files
-     * @param array|string $props
-     */
-    function multistatus_responses(&$files, $props, $initial_ns_hash=null, $initial_ns_defs=null)
-    {
-    	if (!isset($initial_ns_hash)) $initial_ns_hash = array('DAV:' => 'D');
-    	if (!isset($initial_ns_defs)) $initial_ns_defs = 'xmlns:ns0="urn:uuid:c2f41010-65b3-11d1-a29f-00aa00c14882/"';
-
-    	// using an ArrayIterator to prevent foreach from copying the array,
-        // as we cant loop by reference, when an iterator is given in $files
-        if (is_array($files))
-        {
-        	$files = new ArrayIterator($files);
-        }
-        // support for "Prefer: depth-noroot" header on PROPFIND
-        $skip_root = $this->_SERVER['REQUEST_METHOD'] == 'PROPFIND' &&
-        	!isset($initial_ns_hash) &&	// multistatus_response calls itself, do NOT apply skip in that case
-        	isset($this->_SERVER['HTTP_PREFER']) && in_array('depth-noroot', preg_split('/, ?/', $this->_SERVER['HTTP_PREFER']));
-
-        // now we loop over all returned file entries
-        foreach ($files as $file) {
-
-        	// skip first element (root), if requested by Prefer: depth-noroot
-        	if ($skip_root) {
-        		$skip_root = false;
-        		continue;
-        	}
-
-	        // collect namespaces here
-	        $ns_hash = $initial_ns_hash;
-
-	        // Microsoft Clients need this special namespace for date and time values
-	        $ns_defs = $initial_ns_defs;
-
-            // nothing to do if no properties were returend for a file
-			if (isset($file["props"]) && is_array($file["props"])) {
-
-	            // now loop over all returned properties
-	            foreach ($file["props"] as &$prop) {
-	                // as a convenience feature we do not require that user handlers
-	                // restrict returned properties to the requested ones
-	                // here we strip all unrequested entries out of the response
-
-	            	// this can happen if we have allprop and prop in one propfind:
-	            	// <allprop /><prop><blah /></prop>, eg. blah is not automatic returned by allprop
-	                switch(is_array($props) ? $props[0] : $props) {
-	                case "all":
-	                    // nothing to remove
-	                    break;
-
-	                case "names":
-	                    // only the names of all existing properties were requested
-	                    // so we remove all values
-	                    unset($prop["val"]);
-	                    break;
-
-	                default:
-	                    $found = false;
-
-	                    // search property name in requested properties
-	                    foreach ((array)$props as $reqprop) {
-	                        if (   $reqprop["name"]  == $prop["name"]
-	                               && @$reqprop["xmlns"] == $prop["ns"]) {
-	                            $found = true;
-	                            break;
-	                        }
-	                    }
-
-	                    // unset property and continue with next one if not found/requested
-	                    if (!$found) {
-	                        $prop="";
-	                        continue(2);
-	                    }
-	                    break;
-	                }
-
-	                // namespace handling
-	                if (empty($prop["ns"])) continue; // no namespace
-	                $ns = $prop["ns"];
-	                //if ($ns == "DAV:") continue; // default namespace
-	                if (isset($ns_hash[$ns])) continue; // already known
-
-	                // register namespace
-	                $ns_name = "ns".(count($ns_hash) + 1);
-	                $ns_hash[$ns] = $ns_name;
-	                $ns_defs .= " xmlns:$ns_name=\"$ns\"";
-	            }
-
-	            // we also need to add empty entries for properties that were requested
-	            // but for which no values where returned by the user handler
-	            if (is_array($props)) {
-	                foreach ($props as $reqprop) {
-	                    if (!is_array($reqprop) || $reqprop['name']=="") continue; // skip empty entries, or 'all' if <allprop /> used together with <prop>
-
-	                    $found = false;
-
-	                    // check if property exists in result
-	                    foreach ($file["props"] as &$prop) {
-	                        if (is_array($prop) && $reqprop["name"] == $prop["name"]
-	                               && @$reqprop["xmlns"] == $prop["ns"]) {
-	                            $found = true;
-	                            break;
-	                        }
-	                    }
-
-	                    if (!$found) {
-	                        if ($reqprop["xmlns"]==="DAV:" && $reqprop["name"]==="lockdiscovery") {
-	                            // lockdiscovery is handled by the base class
-	                            $file["props"][]
-	                                = $this->mkprop("DAV:",
-	                                                "lockdiscovery",
-	                                                $this->lockdiscovery($file['path']));
-	                        // only collect $file['noprops'] if we have NO Brief: t and NO Prefer: return=minimal HTTP Header
-	                        } elseif ((!isset($this->_SERVER['HTTP_BRIEF']) || $this->_SERVER['HTTP_BRIEF'] != 't') &&
-	                        	(!isset($this->_SERVER['HTTP_PREFER']) || !in_array('return=minimal', preg_split('/, ?/', $this->_SERVER['HTTP_PREFER'])))) {
-	                            // add empty value for this property
-	                            $file["noprops"][] =
-	                                $this->mkprop($reqprop["xmlns"], $reqprop["name"], "");
-
-	                            // register property namespace if not known yet
-	                            if ($reqprop["xmlns"] != "DAV:" && !isset($ns_hash[$reqprop["xmlns"]])) {
-	                                $ns_name = "ns".(count($ns_hash) + 1);
-	                                $ns_hash[$reqprop["xmlns"]] = $ns_name;
-	                                $ns_defs .= " xmlns:$ns_name=\"$reqprop[xmlns]\"";
-	                            }
-	                        }
-	                    }
-	                }
-	            }
-	        }
-            // ignore empty or incomplete entries
-            if (!is_array($file) || empty($file) || !isset($file["path"])) continue;
-            $path = $file['path'];
-            if (!is_string($path) || $path==="") continue;
-
-            if ($this->crrnd)
-            {
-            	echo " <response $ns_defs>\n";
-            }
-            else
-            {
-            	echo " <D:response $ns_defs>\n";
-            }
-
-            /* TODO right now the user implementation has to make sure
-             collections end in a slash, this should be done in here
-             by checking the resource attribute */
-            $href_raw = $this->_mergePaths($this->base_uri, $path);
-
-            /* minimal urlencoding is needed for the resource path */
-            $href = $this->_urlencode($href_raw);
-
-            if ($this->crrnd)
-            {
-            	echo "  <href>$href</href>\n";
-            }
-            else
-            {
-            	echo "  <D:href>$href</D:href>\n";
-            }
-
-            // report all found properties and their values (if any)
-            if (isset($file["props"]) && is_array($file["props"])) {
-                echo '   <'.($this->crrnd?'':'D:')."propstat>\n";
-                echo '    <'.($this->crrnd?'':'D:')."prop>\n";
-
-                foreach ($file["props"] as &$prop) {
-
-                    if (!is_array($prop)) continue;
-                    if (!isset($prop["name"])) continue;
-
-                    if (!isset($prop["val"]) || $prop["val"] === "" || $prop["val"] === false) {
-                        // empty properties (cannot use empty() for check as "0" is a legal value here)
-                        if ($prop["ns"]=="DAV:") {
-                            echo '     <'.($this->crrnd?'':'D:')."$prop[name]/>\n";
-                        } else if (!empty($prop["ns"])) {
-                            echo "     <".$ns_hash[$prop["ns"]].":$prop[name]/>\n";
-                        } else {
-                            echo "     <$prop[name] xmlns=\"\"/>";
-                        }
-                    }
-                    // multiple level of responses required for expand-property reports
-                    elseif(isset($prop['props']) && is_array($prop['val']))
-                    {
-                        if ($prop['ns'] && !isset($ns_hash[$prop['ns']])) {
-                            $ns_name = "ns".(count($ns_hash) + 1);
-                            $ns_hash[$prop['ns']] = $ns_name;
-                        }
-                    	echo '     <'.$ns_hash[$prop['ns']].":$prop[name]>\n";
-                        $this->multistatus_responses($prop['val'], $prop['props'], $ns_hash, '');
-                    	echo '     </'.$ns_hash[$prop['ns']].":$prop[name]>\n";
-                    } else if ($prop["ns"] == "DAV:") {
-                        // some WebDAV properties need special treatment
-                        switch ($prop["name"]) {
-                        case "creationdate":
-                            echo '     <'.($this->crrnd?'':'D:')."creationdate ns0:dt=\"dateTime.tz\">"
-                                . gmdate("Y-m-d\\TH:i:s\\Z", $prop['val'])
-                                . '</'.($this->crrnd?'':'D:')."creationdate>\n";
-                            break;
-                        case "getlastmodified":
-                            echo '     <'.($this->crrnd?'':'D:')."getlastmodified ns0:dt=\"dateTime.rfc1123\">"
-                                . gmdate("D, d M Y H:i:s ", $prop['val'])
-                                . "GMT</".($this->crrnd?'':'D:')."getlastmodified>\n";
-                            break;
-                        case "supportedlock":
-                            echo '     <'.($this->crrnd?'':'D:')."supportedlock>$prop[val]</".($this->crrnd?'':'D:')."supportedlock>\n";
-                            break;
-                        case "lockdiscovery":
-                            echo '     <'.($this->crrnd?'':'D:')."lockdiscovery>\n";
-                            echo $prop["val"];
-                            echo '     </'.($this->crrnd?'':'D:')."lockdiscovery>\n";
-                            break;
-                        // the following are non-standard Microsoft extensions to the DAV namespace
-                        case "lastaccessed":
-                            echo '     <'.($this->crrnd?'':'D:')."lastaccessed ns0:dt=\"dateTime.rfc1123\">"
-                                . gmdate("D, d M Y H:i:s ", $prop['val'])
-                                . 'GMT</'.($this->crrnd?'':'D:')."lastaccessed>\n";
-                            break;
-                        case "ishidden":
-                            echo '     <'.($this->crrnd?'':'D:')."ishidden>"
-                                . is_string($prop['val']) ? $prop['val'] : ($prop['val'] ? 'true' : 'false')
-                                . '</'.($this->crrnd?'':'D:')."</D:ishidden>\n";
-                            break;
-                        default:
-                        	$ns_defs = '';
-                            if (is_array($prop['val']))
-                            {
-                            	$hns_hash = $ns_hash;
-                            	$val = $this->_hierarchical_prop_encode($prop['val'], 'DAV:', $ns_defs, $hns_hash);
-                            } elseif (isset($prop['raw'])) {
-                            	$val = $this->_prop_encode('<![CDATA['.$prop['val'].']]>');
-                            } else {
-	                    		$val = $this->_prop_encode(htmlspecialchars($prop['val'], ENT_NOQUOTES, 'utf-8'));
-                            }
-	                        echo '     <'.($this->crrnd?'':'D:')."$prop[name]$ns_defs>$val".
-	                        	'</'.($this->crrnd?'':'D:')."$prop[name]>\n";
-                            break;
-                        }
-                    } else {
-                        // allow multiple values and attributes, required eg. for caldav:supported-calendar-component-set
-                        if ($prop['ns'] && is_array($prop['val'])) {
-                    		if (!isset($ns_hash[$prop['ns']])) {
-                                $ns_name = "ns".(count($ns_hash) + 1);
-                                $ns_hash[$prop['ns']] = $ns_name;
-                    		}
-                  			$vals = $extra_ns = '';
-                    		foreach($prop['val'] as $subprop)
-                    		{
-                    			if ($subprop['ns'] && $subprop['ns'] != 'DAV:') {
-		                    		// register property namespace if not known yet
-		                    		if (!isset($ns_hash[$subprop['ns']])) {
-			                    		$ns_name = "ns".(count($ns_hash) + 1);
-			                    		$ns_hash[$subprop['ns']] = $ns_name;
-		                    		} else {
-			                    		$ns_name = $ns_hash[$subprop['ns']];
-		                    		}
-		                    		if (strchr($extra_ns,$extra=' xmlns:'.$ns_name.'="'.$subprop['ns'].'"') === false) {
-			                    		$extra_ns .= $extra;
-		                    		}
-		                    		$ns_name .= ':';
-	                    		} elseif ($subprop['ns'] == 'DAV:') {
-		                    		$ns_name = 'D:';
-	                    		} else {
-		                    		$ns_name = '';
-	                    		}
-	                    		$vals .= "<$ns_name$subprop[name]";
-	                    		if (is_array($subprop['val']))
-	                    		{
-	                    			if (isset($subprop['val'][0]))
-	                    			{
-		                    			$vals .= '>';
-		                    			$vals .= $this->_hierarchical_prop_encode($subprop['val'], $subprop['ns'], $ns_defs, $ns_hash);
-			                    		$vals .= "</$ns_name$subprop[name]>";
-	                    			}
-	                    			else	// val contains only attributes, no value
-	                    			{
-			                    		foreach($subprop['val'] as $attr => $val)
-										{
-				                    		$vals .= ' '.$attr.'="'.htmlspecialchars($val, ENT_NOQUOTES, 'utf-8').'"';
-										}
-			                    		$vals .= '/>';
-	                    			}
-	                    		}
-	                    		else
-	                    		{
-	                    			$vals .= '>';
-	                    			if (isset($subprop['raw'])) {
-	                    				$vals .= '<![CDATA['.$subprop['val'].']]>';
-	                    			} else {
-	                    				if($subprop['name'] == 'href') $subprop['val'] = $this->_urlencode($subprop['val']);
-		                    			$vals .= htmlspecialchars($subprop['val'], ENT_NOQUOTES, 'utf-8');
-	                    			}
-	                    			$vals .= "</$ns_name$subprop[name]>";
-	                    		}
-                    		}
-                    		echo '     <'.$ns_hash[$prop['ns']].":$prop[name]$extra_ns>$vals</".$ns_hash[$prop['ns']].":$prop[name]>\n";
-                        } else {
-                        	if ($prop['raw'])
-                        	{
-                        		$val = '<![CDATA['.$prop['val'].']]>';
-                        	} else {
-                        		$val = htmlspecialchars($prop['val'], ENT_NOQUOTES, 'utf-8');
-                        	}
-                        	$val = $this->_prop_encode($val);
-	                        // properties from namespaces != "DAV:" or without any namespace
-	                        if ($prop['ns']) {
-		                        if ($this->crrnd) {
-			                        echo "     <$prop[name] xmlns=".'"'.$prop["ns"].'">'
-									. $val . "</$prop[name]>\n";
-		                        } else {
-			                        echo "     <" . $ns_hash[$prop["ns"]] . ":$prop[name]>"
-									. $val . '</'.$ns_hash[$prop['ns']].":$prop[name]>\n";
-		                        }
-	                        } else {
-		                        echo "     <$prop[name] xmlns=\"\">$val</$prop[name]>\n";
-	                        }
-                        }
-                    }
-                }
-
-                if ($this->crrnd)
-                {
-	                echo "    </prop>\n";
-	                echo "   <status>HTTP/1.1 200 OK</status>\n";
-	                echo "  </propstat>\n";
-                }
-                else
-                {
-	                echo "    </D:prop>\n";
-	                echo "   <D:status>HTTP/1.1 200 OK</D:status>\n";
-	                echo "  </D:propstat>\n";
-                }
-            }
-
-            // now report all properties requested but not found
-            if (isset($file["noprops"])) {
-                echo '   <'.($this->crrnd?'':'D:')."propstat>\n";
-                echo '    <'.($this->crrnd?'':'D:')."prop>\n";
-
-                foreach ($file["noprops"] as &$prop) {
-                    if ($prop["ns"] == "DAV:") {
-                        echo '     <'.($this->crrnd?'':'D:')."$prop[name]/>\n";
-                    } else if ($prop["ns"] == "") {
-                        echo "     <$prop[name] xmlns=\"\"/>\n";
-                    } else {
-                        echo "     <" . $ns_hash[$prop["ns"]] . ":$prop[name]/>\n";
-                    }
-                }
-
-                if ($this->crrnd)
-                {
-	                echo "   </prop>\n";
-	                echo "   <status>HTTP/1.1 404 Not Found</status>\n";
-	                echo "  </propstat>\n";
-                }
-                else
-                {
-	                echo "   </D:prop>\n";
-	                echo "   <D:status>HTTP/1.1 404 Not Found</D:status>\n";
-	                echo "  </D:propstat>\n";
-                }
-            }
-
-            // 404 Not Found status element for WebDAV sync report
-            if (!isset($file['props']) && !isset($file['noprops']))
-            {
-                if ($this->crrnd)
-                {
-	                echo "  <status>HTTP/1.1 404 Not Found</status>\n";
-                }
-                else
-                {
-	                echo "  <D:status>HTTP/1.1 404 Not Found</D:status>\n";
-                }
-            }
-
-            echo ' </'.($this->crrnd?'':'D:')."response>\n";
-        }
-    }
-
-
-    // }}}
-
-    // {{{ http_PROPPATCH()
+		// add Vary and Preference-Applied header for Prefer: return=minimal
+		if (isset($this->_SERVER['HTTP_PREFER']) && in_array('return=minimal', preg_split('/, ?/', $this->_SERVER['HTTP_PREFER'])))
+		{
+			header("Preference-Applied: return=minimal");
+			header("Vary: Prefer");
+		}
 
-    /**
-     * PROPPATCH method handler
-     *
-     * @param  void
-     * @return void
-     */
-    function http_PROPPATCH()
-    {
-        if ($this->_check_lock_status($this->path)) {
-            $options = Array();
+		// ... and payload
+		echo "<?xml version=\"1.0\" encoding=\"utf-8\"?>\n";
+		echo $this->crrnd ? "<multistatus xmlns=\"DAV:\">\n" : "<D:multistatus xmlns:D=\"DAV:\">\n";
 
-            $options["path"] = $this->path;
+		$this->multistatus_responses($files['files'], $options['props']);
 
-            $propinfo = new _parse_proppatch("php://input", $this->store_request);
-            if ($this->store_request) $this->request = $propinfo->request;
+		// WebDAV sync report sync-token, can be either the sync-token or a callback (called with params in $files['sync-token-params'])
+		if (isset($files['sync-token']))
+		{
+			echo ($this->crrnd ? " <" : " <D:")."sync-token>".
+				htmlspecialchars(!is_callable($files['sync-token']) ? $files['sync-token'] :
+					call_user_func_array($files['sync-token'], (array)$files['sync-token-params'])).
+				($this->crrnd ? "</" : "</D:")."sync-token>\n";
+		}
 
-            if (!$propinfo->success) {
-                $this->http_status("400 Error");
-                return;
-            }
+		echo '</'.($this->crrnd?'':'D:')."multistatus>\n";
+	}
 
-            $options['props'] = $propinfo->props;
+	/**
+	 * Render (echo) XML for given multistatus responses
+	 *
+	 * @param array|Iterator $files
+	 * @param array|string $props
+	 */
+	function multistatus_responses(&$files, $props, $initial_ns_hash=null, $initial_ns_defs=null)
+	{
+		if (!isset($initial_ns_hash)) $initial_ns_hash = array('DAV:' => 'D');
+		if (!isset($initial_ns_defs)) $initial_ns_defs = 'xmlns:ns0="urn:uuid:c2f41010-65b3-11d1-a29f-00aa00c14882/"';
 
-            $responsedescr = $this->PROPPATCH($options);
+		// using an ArrayIterator to prevent foreach from copying the array,
+		// as we cant loop by reference, when an iterator is given in $files
+		if (is_array($files))
+		{
+			$files = new ArrayIterator($files);
+		}
+		// support for "Prefer: depth-noroot" header on PROPFIND
+		$skip_root = $this->_SERVER['REQUEST_METHOD'] == 'PROPFIND' &&
+			!isset($initial_ns_hash) &&	// multistatus_response calls itself, do NOT apply skip in that case
+			isset($this->_SERVER['HTTP_PREFER']) && in_array('depth-noroot', preg_split('/, ?/', $this->_SERVER['HTTP_PREFER']));
+
+		// now we loop over all returned file entries
+		foreach ($files as $file) {
+
+			// skip first element (root), if requested by Prefer: depth-noroot
+			if ($skip_root) {
+				$skip_root = false;
+				continue;
+			}
 
-            $this->http_status("207 Multi-Status");
-            header('Content-Type: text/xml; charset="utf-8"');
+			// collect namespaces here
+			$ns_hash = $initial_ns_hash;
 
-            echo "<?xml version=\"1.0\" encoding=\"utf-8\"?>\n";
+			// Microsoft Clients need this special namespace for date and time values
+			$ns_defs = $initial_ns_defs;
 
-            echo "<D:multistatus xmlns:D=\"DAV:\">\n";
-            echo ' <'.($this->crrnd?'':'D:')."response>\n";
-            echo '  <'.($this->crrnd?'':'D:')."href>".$this->_urlencode($this->_mergePaths($this->_SERVER["SCRIPT_NAME"], $this->path)).'</'.($this->crrnd?'':'D:')."href>\n";
+			// nothing to do if no properties were returend for a file
+			if (isset($file["props"]) && is_array($file["props"])) {
 
-            foreach ($options["props"] as $prop) {
-                echo '   <'.($this->crrnd?'':'D:')."propstat>\n";
-                echo '    <'.($this->crrnd?'':'D:')."prop><$prop[name] xmlns=\"$prop[ns]\"/></".($this->crrnd?'':'D:')."prop>\n";
-                echo '    <'.($this->crrnd?'':'D:')."status>HTTP/1.1 $prop[status]</".($this->crrnd?'':'D:')."status>\n";
-                echo '   </'.($this->crrnd?'':'D:')."propstat>\n";
-            }
+				// now loop over all returned properties
+				foreach ($file["props"] as &$prop) {
+					// as a convenience feature we do not require that user handlers
+					// restrict returned properties to the requested ones
+					// here we strip all unrequested entries out of the response
+
+					// this can happen if we have allprop and prop in one propfind:
+					// <allprop /><prop><blah /></prop>, eg. blah is not automatic returned by allprop
+					switch(is_array($props) ? $props[0] : $props) {
+					case "all":
+						// nothing to remove
+						break;
+
+					case "names":
+						// only the names of all existing properties were requested
+						// so we remove all values
+						unset($prop["val"]);
+						break;
+
+					default:
+						$found = false;
+
+						// search property name in requested properties
+						foreach ((array)$props as $reqprop) {
+							if (   $reqprop["name"]  == $prop["name"]
+								   && @$reqprop["xmlns"] == $prop["ns"]) {
+								$found = true;
+								break;
+							}
+						}
 
-            if ($responsedescr) {
-                echo '  <'.($this->crrnd?'':'D:')."responsedescription>".
-                    $this->_prop_encode(htmlspecialchars($responsedescr, ENT_NOQUOTES, 'utf-8')).
-                    '</'.($this->crrnd?'':'D:')."responsedescription>\n";
-            }
+						// unset property and continue with next one if not found/requested
+						if (!$found) {
+							$prop="";
+							continue(2);
+						}
+						break;
+					}
 
-            echo ' </'.($this->crrnd?'':'D:')."response>\n";
-            echo '</'.($this->crrnd?'':'D:')."multistatus>\n";
-        } else {
-            $this->http_status("423 Locked");
-        }
-    }
+					// namespace handling
+					if (empty($prop["ns"])) continue; // no namespace
+					$ns = $prop["ns"];
+					//if ($ns == "DAV:") continue; // default namespace
+					if (isset($ns_hash[$ns])) continue; // already known
 
-    // }}}
+					// register namespace
+					$ns_name = "ns".(count($ns_hash) + 1);
+					$ns_hash[$ns] = $ns_name;
+					$ns_defs .= " xmlns:$ns_name=\"$ns\"";
+				}
 
+				// we also need to add empty entries for properties that were requested
+				// but for which no values where returned by the user handler
+				if (is_array($props)) {
+					foreach ($props as $reqprop) {
+						if (!is_array($reqprop) || $reqprop['name']=="") continue; // skip empty entries, or 'all' if <allprop /> used together with <prop>
+
+						$found = false;
+
+						// check if property exists in result
+						foreach ($file["props"] as &$prop) {
+							if (is_array($prop) && $reqprop["name"] == $prop["name"]
+								   && @$reqprop["xmlns"] == $prop["ns"]) {
+								$found = true;
+								break;
+							}
+						}
 
-    // {{{ http_MKCOL()
+						if (!$found) {
+							if ($reqprop["xmlns"]==="DAV:" && $reqprop["name"]==="lockdiscovery") {
+								// lockdiscovery is handled by the base class
+								$file["props"][]
+									= $this->mkprop("DAV:",
+													"lockdiscovery",
+													$this->lockdiscovery($file['path']));
+							// only collect $file['noprops'] if we have NO Brief: t and NO Prefer: return=minimal HTTP Header
+							} elseif ((!isset($this->_SERVER['HTTP_BRIEF']) || $this->_SERVER['HTTP_BRIEF'] != 't') &&
+								(!isset($this->_SERVER['HTTP_PREFER']) || !in_array('return=minimal', preg_split('/, ?/', $this->_SERVER['HTTP_PREFER'])))) {
+								// add empty value for this property
+								$file["noprops"][] =
+									$this->mkprop($reqprop["xmlns"], $reqprop["name"], "");
+
+								// register property namespace if not known yet
+								if ($reqprop["xmlns"] != "DAV:" && !isset($ns_hash[$reqprop["xmlns"]])) {
+									$ns_name = "ns".(count($ns_hash) + 1);
+									$ns_hash[$reqprop["xmlns"]] = $ns_name;
+									$ns_defs .= " xmlns:$ns_name=\"$reqprop[xmlns]\"";
+								}
+							}
+						}
+					}
+				}
+			}
+			// ignore empty or incomplete entries
+			if (!is_array($file) || empty($file) || !isset($file["path"])) continue;
+			$path = $file['path'];
+			if (!is_string($path) || $path==="") continue;
 
-    /**
-     * MKCOL method handler
-     *
-     * @param  void
-     * @return void
-     */
-    function http_MKCOL()
-    {
-        $options = Array();
+			if ($this->crrnd)
+			{
+				echo " <response $ns_defs>\n";
+			}
+			else
+			{
+				echo " <D:response $ns_defs>\n";
+			}
 
-        $options["path"] = $this->path;
+			/* TODO right now the user implementation has to make sure
+             collections end in a slash, this should be done in here
+             by checking the resource attribute */
+			$href_raw = $this->_mergePaths($this->base_uri, $path);
 
-        $stat = $this->MKCOL($options);
+			/* minimal urlencoding is needed for the resource path */
+			$href = $this->_urlencode($href_raw);
 
-        $this->http_status($stat);
-    }
+			if ($this->crrnd)
+			{
+				echo "  <href>$href</href>\n";
+			}
+			else
+			{
+				echo "  <D:href>$href</D:href>\n";
+			}
 
-    // }}}
+			// report all found properties and their values (if any)
+			if (isset($file["props"]) && is_array($file["props"])) {
+				echo '   <'.($this->crrnd?'':'D:')."propstat>\n";
+				echo '    <'.($this->crrnd?'':'D:')."prop>\n";
+
+				foreach ($file["props"] as &$prop) {
+
+					if (!is_array($prop)) continue;
+					if (!isset($prop["name"])) continue;
+
+					if (!isset($prop["val"]) || $prop["val"] === "" || $prop["val"] === false) {
+						// empty properties (cannot use empty() for check as "0" is a legal value here)
+						if ($prop["ns"]=="DAV:") {
+							echo '     <'.($this->crrnd?'':'D:')."$prop[name]/>\n";
+						} else if (!empty($prop["ns"])) {
+							echo "     <".$ns_hash[$prop["ns"]].":$prop[name]/>\n";
+						} else {
+							echo "     <$prop[name] xmlns=\"\"/>";
+						}
+					}
+					// multiple level of responses required for expand-property reports
+					elseif(isset($prop['props']) && is_array($prop['val']))
+					{
+						if ($prop['ns'] && !isset($ns_hash[$prop['ns']])) {
+							$ns_name = "ns".(count($ns_hash) + 1);
+							$ns_hash[$prop['ns']] = $ns_name;
+						}
+						echo '     <'.$ns_hash[$prop['ns']].":$prop[name]>\n";
+						$this->multistatus_responses($prop['val'], $prop['props'], $ns_hash, '');
+						echo '     </'.$ns_hash[$prop['ns']].":$prop[name]>\n";
+					} else if ($prop["ns"] == "DAV:") {
+						// some WebDAV properties need special treatment
+						switch ($prop["name"]) {
+						case "creationdate":
+							echo '     <'.($this->crrnd?'':'D:')."creationdate ns0:dt=\"dateTime.tz\">"
+								. gmdate("Y-m-d\\TH:i:s\\Z", $prop['val'])
+								. '</'.($this->crrnd?'':'D:')."creationdate>\n";
+							break;
+						case "getlastmodified":
+							echo '     <'.($this->crrnd?'':'D:')."getlastmodified ns0:dt=\"dateTime.rfc1123\">"
+								. gmdate("D, d M Y H:i:s ", $prop['val'])
+								. "GMT</".($this->crrnd?'':'D:')."getlastmodified>\n";
+							break;
+						case "supportedlock":
+							echo '     <'.($this->crrnd?'':'D:')."supportedlock>$prop[val]</".($this->crrnd?'':'D:')."supportedlock>\n";
+							break;
+						case "lockdiscovery":
+							echo '     <'.($this->crrnd?'':'D:')."lockdiscovery>\n";
+							echo $prop["val"];
+							echo '     </'.($this->crrnd?'':'D:')."lockdiscovery>\n";
+							break;
+						// the following are non-standard Microsoft extensions to the DAV namespace
+						case "lastaccessed":
+							echo '     <'.($this->crrnd?'':'D:')."lastaccessed ns0:dt=\"dateTime.rfc1123\">"
+								. gmdate("D, d M Y H:i:s ", $prop['val'])
+								. 'GMT</'.($this->crrnd?'':'D:')."lastaccessed>\n";
+							break;
+						case "ishidden":
+							echo '     <'.($this->crrnd?'':'D:')."ishidden>"
+								. is_string($prop['val']) ? $prop['val'] : ($prop['val'] ? 'true' : 'false')
+								. '</'.($this->crrnd?'':'D:')."</D:ishidden>\n";
+							break;
+						default:
+							$ns_defs = '';
+							if (is_array($prop['val']))
+							{
+								$hns_hash = $ns_hash;
+								$val = $this->_hierarchical_prop_encode($prop['val'], 'DAV:', $ns_defs, $hns_hash);
+							} elseif (isset($prop['raw'])) {
+								$val = $this->_prop_encode('<![CDATA['.$prop['val'].']]>');
+							} else {
+								$val = $this->_prop_encode(htmlspecialchars($prop['val'], ENT_NOQUOTES, 'utf-8'));
+							}
+							echo '     <'.($this->crrnd?'':'D:')."$prop[name]$ns_defs>$val".
+								'</'.($this->crrnd?'':'D:')."$prop[name]>\n";
+							break;
+						}
+					} else {
+						// allow multiple values and attributes, required eg. for caldav:supported-calendar-component-set
+						if ($prop['ns'] && is_array($prop['val'])) {
+							if (!isset($ns_hash[$prop['ns']])) {
+								$ns_name = "ns".(count($ns_hash) + 1);
+								$ns_hash[$prop['ns']] = $ns_name;
+							}
+				  			$vals = $extra_ns = '';
+							foreach($prop['val'] as $subprop)
+							{
+								if ($subprop['ns'] && $subprop['ns'] != 'DAV:') {
+									// register property namespace if not known yet
+									if (!isset($ns_hash[$subprop['ns']])) {
+										$ns_name = "ns".(count($ns_hash) + 1);
+										$ns_hash[$subprop['ns']] = $ns_name;
+									} else {
+										$ns_name = $ns_hash[$subprop['ns']];
+									}
+									if (strchr($extra_ns,$extra=' xmlns:'.$ns_name.'="'.$subprop['ns'].'"') === false) {
+										$extra_ns .= $extra;
+									}
+									$ns_name .= ':';
+								} elseif ($subprop['ns'] == 'DAV:') {
+									$ns_name = 'D:';
+								} else {
+									$ns_name = '';
+								}
+								$vals .= "<$ns_name$subprop[name]";
+								if (is_array($subprop['val']))
+								{
+									if (isset($subprop['val'][0]))
+									{
+										$vals .= '>';
+										$vals .= $this->_hierarchical_prop_encode($subprop['val'], $subprop['ns'], $ns_defs, $ns_hash);
+										$vals .= "</$ns_name$subprop[name]>";
+									}
+									else	// val contains only attributes, no value
+									{
+										foreach($subprop['val'] as $attr => $val)
+										{
+											$vals .= ' '.$attr.'="'.htmlspecialchars($val, ENT_NOQUOTES, 'utf-8').'"';
+										}
+										$vals .= '/>';
+									}
+								}
+								else
+								{
+									$vals .= '>';
+									if (isset($subprop['raw'])) {
+										$vals .= '<![CDATA['.$subprop['val'].']]>';
+									} else {
+										if($subprop['name'] == 'href') $subprop['val'] = $this->_urlencode($subprop['val']);
+										$vals .= htmlspecialchars($subprop['val'], ENT_NOQUOTES, 'utf-8');
+									}
+									$vals .= "</$ns_name$subprop[name]>";
+								}
+							}
+							echo '     <'.$ns_hash[$prop['ns']].":$prop[name]$extra_ns>$vals</".$ns_hash[$prop['ns']].":$prop[name]>\n";
+						} else {
+							if ($prop['raw'])
+							{
+								$val = '<![CDATA['.$prop['val'].']]>';
+							} else {
+								$val = htmlspecialchars($prop['val'], ENT_NOQUOTES, 'utf-8');
+							}
+							$val = $this->_prop_encode($val);
+							// properties from namespaces != "DAV:" or without any namespace
+							if ($prop['ns']) {
+								if ($this->crrnd) {
+									echo "     <$prop[name] xmlns=".'"'.$prop["ns"].'">'
+									. $val . "</$prop[name]>\n";
+								} else {
+									echo "     <" . $ns_hash[$prop["ns"]] . ":$prop[name]>"
+									. $val . '</'.$ns_hash[$prop['ns']].":$prop[name]>\n";
+								}
+							} else {
+								echo "     <$prop[name] xmlns=\"\">$val</$prop[name]>\n";
+							}
+						}
+					}
+				}
+
+				if ($this->crrnd)
+				{
+					echo "    </prop>\n";
+					echo "   <status>HTTP/1.1 200 OK</status>\n";
+					echo "  </propstat>\n";
+				}
+				else
+				{
+					echo "    </D:prop>\n";
+					echo "   <D:status>HTTP/1.1 200 OK</D:status>\n";
+					echo "  </D:propstat>\n";
+				}
+			}
+
+			// now report all properties requested but not found
+			if (isset($file["noprops"])) {
+				echo '   <'.($this->crrnd?'':'D:')."propstat>\n";
+				echo '    <'.($this->crrnd?'':'D:')."prop>\n";
+
+				foreach ($file["noprops"] as &$prop) {
+					if ($prop["ns"] == "DAV:") {
+						echo '     <'.($this->crrnd?'':'D:')."$prop[name]/>\n";
+					} else if ($prop["ns"] == "") {
+						echo "     <$prop[name] xmlns=\"\"/>\n";
+					} else {
+						echo "     <" . $ns_hash[$prop["ns"]] . ":$prop[name]/>\n";
+					}
+				}
+
+				if ($this->crrnd)
+				{
+					echo "   </prop>\n";
+					echo "   <status>HTTP/1.1 404 Not Found</status>\n";
+					echo "  </propstat>\n";
+				}
+				else
+				{
+					echo "   </D:prop>\n";
+					echo "   <D:status>HTTP/1.1 404 Not Found</D:status>\n";
+					echo "  </D:propstat>\n";
+				}
+			}
+
+			// 404 Not Found status element for WebDAV sync report
+			if (!isset($file['props']) && !isset($file['noprops']))
+			{
+				if ($this->crrnd)
+				{
+					echo "  <status>HTTP/1.1 404 Not Found</status>\n";
+				}
+				else
+				{
+					echo "  <D:status>HTTP/1.1 404 Not Found</D:status>\n";
+				}
+			}
+
+			echo ' </'.($this->crrnd?'':'D:')."response>\n";
+		}
+	}
+
+
+	// }}}
+
+	// {{{ http_PROPPATCH()
+
+	/**
+	 * PROPPATCH method handler
+	 *
+	 * @param  void
+	 * @return void
+	 */
+	function http_PROPPATCH()
+	{
+		if ($this->_check_lock_status($this->path)) {
+			$options = Array();
+
+			$options["path"] = $this->path;
+
+			$propinfo = new _parse_proppatch("php://input", $this->store_request);
+			if ($this->store_request) $this->request = $propinfo->request;
+
+			if (!$propinfo->success) {
+				$this->http_status("400 Error");
+				return;
+			}
+
+			$options['props'] = $propinfo->props;
+
+			$responsedescr = $this->PROPPATCH($options);
+
+			$this->http_status("207 Multi-Status");
+			header('Content-Type: text/xml; charset="utf-8"');
+
+			echo "<?xml version=\"1.0\" encoding=\"utf-8\"?>\n";
+
+			echo "<D:multistatus xmlns:D=\"DAV:\">\n";
+			echo ' <'.($this->crrnd?'':'D:')."response>\n";
+			echo '  <'.($this->crrnd?'':'D:')."href>".$this->_urlencode($this->_mergePaths($this->_SERVER["SCRIPT_NAME"], $this->path)).'</'.($this->crrnd?'':'D:')."href>\n";
+
+			foreach ($options["props"] as $prop) {
+				echo '   <'.($this->crrnd?'':'D:')."propstat>\n";
+				echo '    <'.($this->crrnd?'':'D:')."prop><$prop[name] xmlns=\"$prop[ns]\"/></".($this->crrnd?'':'D:')."prop>\n";
+				echo '    <'.($this->crrnd?'':'D:')."status>HTTP/1.1 $prop[status]</".($this->crrnd?'':'D:')."status>\n";
+				echo '   </'.($this->crrnd?'':'D:')."propstat>\n";
+			}
+
+			if ($responsedescr) {
+				echo '  <'.($this->crrnd?'':'D:')."responsedescription>".
+					$this->_prop_encode(htmlspecialchars($responsedescr, ENT_NOQUOTES, 'utf-8')).
+					'</'.($this->crrnd?'':'D:')."responsedescription>\n";
+			}
+
+			echo ' </'.($this->crrnd?'':'D:')."response>\n";
+			echo '</'.($this->crrnd?'':'D:')."multistatus>\n";
+		} else {
+			$this->http_status("423 Locked");
+		}
+	}
+
+	// }}}
+
+
+	// {{{ http_MKCOL()
+
+	/**
+	 * MKCOL method handler
+	 *
+	 * @param  void
+	 * @return void
+	 */
+	function http_MKCOL()
+	{
+		$options = Array();
+
+		$options["path"] = $this->path;
+
+		$stat = $this->MKCOL($options);
+
+		$this->http_status($stat);
+	}
+
+	// }}}
 
 	/**
 	 * Check or set if we want ot use compression as transfer encoding
@@ -1258,1387 +1258,1387 @@ 
 		return $compression;
 	}
 
-    // {{{ http_GET()
+	// {{{ http_GET()
 
-    /**
-     * GET method handler
-     *
-     * @param void
-     * @return void
-     */
-    function http_GET()
-    {
-        // TODO check for invalid stream
-        $options         = Array();
-        $options["path"] = $this->path;
-
-        $this->_get_ranges($options);
-
-        if (true === ($status = $this->GET($options))) {
-            if (!headers_sent()) {
-                $status = "200 OK";
-
-                if (!isset($options['mimetype'])) {
-                    $options['mimetype'] = "application/octet-stream";
-                }
-                // switching off zlib.output_compression for everything but text files,
-                // as the double compression of zip files makes problems eg. with lighttpd
-                // and anyway little sense with with other content like pictures
-                if (substr($options['mimetype'],0,5) != 'text/')
-                {
+	/**
+	 * GET method handler
+	 *
+	 * @param void
+	 * @return void
+	 */
+	function http_GET()
+	{
+		// TODO check for invalid stream
+		$options         = Array();
+		$options["path"] = $this->path;
+
+		$this->_get_ranges($options);
+
+		if (true === ($status = $this->GET($options))) {
+			if (!headers_sent()) {
+				$status = "200 OK";
+
+				if (!isset($options['mimetype'])) {
+					$options['mimetype'] = "application/octet-stream";
+				}
+				// switching off zlib.output_compression for everything but text files,
+				// as the double compression of zip files makes problems eg. with lighttpd
+				// and anyway little sense with with other content like pictures
+				if (substr($options['mimetype'],0,5) != 'text/')
+				{
 					self::use_compression(false);
-                }
-                header("Content-type: $options[mimetype]");
-
-                if (isset($options['mtime'])) {
-                    header("Last-modified:".gmdate("D, d M Y H:i:s ", $options['mtime'])."GMT");
-                }
-                // fix for IE and https, thanks to rob_burcham@yahoo.com
-                // see http://us3.php.net/manual/en/function.header.php#83219
-                // and http://support.microsoft.com/kb/812935
+				}
+				header("Content-type: $options[mimetype]");
+
+				if (isset($options['mtime'])) {
+					header("Last-modified:".gmdate("D, d M Y H:i:s ", $options['mtime'])."GMT");
+				}
+				// fix for IE and https, thanks to rob_burcham@yahoo.com
+				// see http://us3.php.net/manual/en/function.header.php#83219
+				// and http://support.microsoft.com/kb/812935
 				header("Cache-Control: maxage=1"); //In seconds
 				header("Pragma: public");
 
-                if (isset($options['stream'])) {
-                    // GET handler returned a stream
-                    if (!empty($options['ranges']) && (0===fseek($options['stream'], 0, SEEK_SET))) {
-                        // partial request and stream is seekable
-
-                        if (count($options['ranges']) === 1) {
-                            $range = $options['ranges'][0];
-
-                            if (isset($range['start'])) {
-                                fseek($options['stream'], $range['start'], SEEK_SET);
-                                if (feof($options['stream'])) {
-                                    $this->http_status("416 Requested range not satisfiable");
-                                    return;
-                                }
-
-                                if (!empty($range['end'])) {
-                                    $size = $range['end']-$range['start']+1;
-                                    $this->http_status("206 Partial content");
-                                    if (!self::use_compression()) header("Content-Length: $size");
-                                    header("Content-Range: bytes $range[start]-$range[end]/"
-                                           . (isset($options['size']) ? $options['size'] : "*"));
-                                    while ($size > 0 && !feof($options['stream'])) {
-                                        $buffer = fread($options['stream'], $size < 8192 ? $size : 8192);
-                                        $size  -= self::bytes($buffer);
-                                        echo $buffer;
-                                    }
-                                } else {
-                                    $this->http_status("206 Partial content");
-                                    if (isset($options['size'])) {
-                                        if (!self::use_compression()) header("Content-Length: ".($options['size'] - $range['start']));
-                                        header("Content-Range: bytes ".$range['start']."-".
+				if (isset($options['stream'])) {
+					// GET handler returned a stream
+					if (!empty($options['ranges']) && (0===fseek($options['stream'], 0, SEEK_SET))) {
+						// partial request and stream is seekable
+
+						if (count($options['ranges']) === 1) {
+							$range = $options['ranges'][0];
+
+							if (isset($range['start'])) {
+								fseek($options['stream'], $range['start'], SEEK_SET);
+								if (feof($options['stream'])) {
+									$this->http_status("416 Requested range not satisfiable");
+									return;
+								}
+
+								if (!empty($range['end'])) {
+									$size = $range['end']-$range['start']+1;
+									$this->http_status("206 Partial content");
+									if (!self::use_compression()) header("Content-Length: $size");
+									header("Content-Range: bytes $range[start]-$range[end]/"
+										   . (isset($options['size']) ? $options['size'] : "*"));
+									while ($size > 0 && !feof($options['stream'])) {
+										$buffer = fread($options['stream'], $size < 8192 ? $size : 8192);
+										$size  -= self::bytes($buffer);
+										echo $buffer;
+									}
+								} else {
+									$this->http_status("206 Partial content");
+									if (isset($options['size'])) {
+										if (!self::use_compression()) header("Content-Length: ".($options['size'] - $range['start']));
+										header("Content-Range: bytes ".$range['start']."-".
 											(isset($options['size']) ? $options['size']-1 : "")."/"
 										   . (isset($options['size']) ? $options['size'] : "*"));
-                                    }
-                                    fpassthru($options['stream']);
-                                }
-                            } else {
-                                if (!self::use_compression()) header("Content-length: ".$range['last']);
-                                fseek($options['stream'], -$range['last'], SEEK_END);
-                                fpassthru($options['stream']);
-                            }
-                        } else {
-                            $this->_multipart_byterange_header(); // init multipart
-                            foreach ($options['ranges'] as $range) {
-                                // TODO what if size unknown? 500?
-                                if (isset($range['start'])) {
-                                    $from = $range['start'];
-                                    $to   = !empty($range['end']) ? $range['end'] : $options['size']-1;
-                                } else {
-                                    $from = $options['size'] - $range['last']-1;
-                                    $to   = $options['size'] -1;
-                                }
-                                $total = isset($options['size']) ? $options['size'] : "*";
-                                $size  = $to - $from + 1;
-                                $this->_multipart_byterange_header($options['mimetype'], $from, $to, $total);
-
-
-                                fseek($options['stream'], $from, SEEK_SET);
-                                while ($size && !feof($options['stream'])) {
-                                    $buffer = fread($options['stream'], 4096);
-                                    $size  -= self::bytes($buffer);
-                                    echo $buffer;
-                                }
-                            }
-                            $this->_multipart_byterange_header(); // end multipart
-                        }
-                    } else {
-                        // normal request or stream isn't seekable, return full content
-                        if (isset($options['size']) && !self::use_compression()) {
-                            header("Content-Length: ".$options['size']);
-                        }
-                        fpassthru($options['stream']);
-                        return; // no more headers
-                    }
-                } elseif (isset($options['data'])) {
-                    if (is_array($options['data'])) {
-                        // reply to partial request
-                    } else {
-                        if (!self::use_compression()) header("Content-Length: ".self::bytes($options['data']));
-                        echo $options['data'];
-                    }
-                }
-            }
-        }
-
-        if (!headers_sent()) {
-            if (false === $status) {
-                $this->http_status("404 not found");
-            } else {
-                // TODO: check setting of headers in various code paths above
-                $this->http_status("$status");
-            }
-        }
-    }
+									}
+									fpassthru($options['stream']);
+								}
+							} else {
+								if (!self::use_compression()) header("Content-length: ".$range['last']);
+								fseek($options['stream'], -$range['last'], SEEK_END);
+								fpassthru($options['stream']);
+							}
+						} else {
+							$this->_multipart_byterange_header(); // init multipart
+							foreach ($options['ranges'] as $range) {
+								// TODO what if size unknown? 500?
+								if (isset($range['start'])) {
+									$from = $range['start'];
+									$to   = !empty($range['end']) ? $range['end'] : $options['size']-1;
+								} else {
+									$from = $options['size'] - $range['last']-1;
+									$to   = $options['size'] -1;
+								}
+								$total = isset($options['size']) ? $options['size'] : "*";
+								$size  = $to - $from + 1;
+								$this->_multipart_byterange_header($options['mimetype'], $from, $to, $total);
+
+
+								fseek($options['stream'], $from, SEEK_SET);
+								while ($size && !feof($options['stream'])) {
+									$buffer = fread($options['stream'], 4096);
+									$size  -= self::bytes($buffer);
+									echo $buffer;
+								}
+							}
+							$this->_multipart_byterange_header(); // end multipart
+						}
+					} else {
+						// normal request or stream isn't seekable, return full content
+						if (isset($options['size']) && !self::use_compression()) {
+							header("Content-Length: ".$options['size']);
+						}
+						fpassthru($options['stream']);
+						return; // no more headers
+					}
+				} elseif (isset($options['data'])) {
+					if (is_array($options['data'])) {
+						// reply to partial request
+					} else {
+						if (!self::use_compression()) header("Content-Length: ".self::bytes($options['data']));
+						echo $options['data'];
+					}
+				}
+			}
+		}
+
+		if (!headers_sent()) {
+			if (false === $status) {
+				$this->http_status("404 not found");
+			} else {
+				// TODO: check setting of headers in various code paths above
+				$this->http_status("$status");
+			}
+		}
+	}
+
+
+	/**
+	 * parse HTTP Range: header
+	 *
+	 * @param  array options array to store result in
+	 * @return void
+	 */
+	function _get_ranges(&$options)
+	{
+		// process Range: header if present
+		if (isset($this->_SERVER['HTTP_RANGE'])) {
+
+			// we only support standard "bytes" range specifications for now
+			$matches = null;
+			if (preg_match('/bytes\s*=\s*(.+)/', $this->_SERVER['HTTP_RANGE'], $matches)) {
+				$options["ranges"] = array();
+
+				// ranges are comma separated
+				foreach (explode(",", $matches[1]) as $range) {
+					// ranges are either from-to pairs or just end positions
+					list($start, $end) = explode("-", $range);
+					$options["ranges"][] = ($start==="")
+						? array("last"=>$end)
+						: array("start"=>$start, "end"=>$end);
+				}
+			}
+		}
+	}
+
+	/**
+	 * generate separator headers for multipart response
+	 *
+	 * first and last call happen without parameters to generate
+	 * the initial header and closing sequence, all calls inbetween
+	 * require content mimetype, start and end byte position and
+	 * optionaly the total byte length of the requested resource
+	 *
+	 * @param  string  mimetype
+	 * @param  int     start byte position
+	 * @param  int     end   byte position
+	 * @param  int     total resource byte size
+	 */
+	function _multipart_byterange_header($mimetype = false, $from = false, $to=false, $total=false)
+	{
+		if ($mimetype === false) {
+			if (!isset($this->multipart_separator)) {
+				// initial
+
+				// a little naive, this sequence *might* be part of the content
+				// but it's really not likely and rather expensive to check
+				$this->multipart_separator = "SEPARATOR_".md5(microtime());
+
+				// generate HTTP header
+				header("Content-type: multipart/byteranges; boundary=".$this->multipart_separator);
+			} else {
+				// final
+
+				// generate closing multipart sequence
+				echo "\n--{$this->multipart_separator}--";
+			}
+		} else {
+			// generate separator and header for next part
+			echo "\n--{$this->multipart_separator}\n";
+			echo "Content-type: $mimetype\n";
+			echo "Content-range: $from-$to/". ($total === false ? "*" : $total);
+			echo "\n\n";
+		}
+	}
+
+
+
+	// }}}
+
+	// {{{ http_HEAD()
+
+	/**
+	 * HEAD method handler
+	 *
+	 * @param  void
+	 * @return void
+	 */
+	function http_HEAD()
+	{
+		$status          = false;
+		$options         = Array();
+		$options["path"] = $this->path;
+
+		if (method_exists($this, "HEAD")) {
+			$status = $this->head($options);
+		} else if (method_exists($this, "GET")) {
+			ob_start();
+			$status = $this->GET($options);
+			if (!isset($options['size'])) {
+				$options['size'] = ob_get_length();
+			}
+			ob_end_clean();
+		}
+
+		if (!isset($options['mimetype'])) {
+			$options['mimetype'] = "application/octet-stream";
+		}
+		header("Content-type: $options[mimetype]");
+
+		if (isset($options['mtime'])) {
+			header("Last-modified:".gmdate("D, d M Y H:i:s ", $options['mtime'])."GMT");
+		}
+
+		if (isset($options['size'])) {
+			header("Content-Length: ".$options['size']);
+		}
+
+		if ($status === true)  $status = "200 OK";
+		if ($status === false) $status = "404 Not found";
+
+		$this->http_status($status);
+	}
+
+	// }}}
+
+	// {{{ http_POST()
+
+	/**
+	 * POST method handler
+	 *
+	 * @param  void
+	 * @return void
+	 */
+	function http_POST()
+	{
+		$status          = '405 Method not allowed';
+		$options         = Array();
+		$options['path'] = $this->path;
+
+		if (isset($this->_SERVER['CONTENT_LENGTH']))
+		{
+			$options['content_length'] = $this->_SERVER['CONTENT_LENGTH'];
+		}
+		elseif (isset($this->_SERVER['X-Expected-Entity-Length']))
+		{
+			// MacOS gives us that hint
+			$options['content_length'] = $this->_SERVER['X-Expected-Entity-Length'];
+		}
+
+		// get the Content-type
+		if (isset($this->_SERVER["CONTENT_TYPE"])) {
+			// for now we do not support any sort of multipart requests
+			if (!strncmp($this->_SERVER["CONTENT_TYPE"], 'multipart/', 10)) {
+				$this->http_status('501 not implemented');
+				echo 'The service does not support mulipart POST requests';
+				return;
+			}
+			$options['content_type'] = $this->_SERVER['CONTENT_TYPE'];
+		} else {
+			// default content type if none given
+			$options['content_type'] = 'application/octet-stream';
+		}
+
+		$options['stream'] = fopen('php://input', 'r');
+		switch($this->_SERVER['HTTP_CONTENT_ENCODING'])
+		{
+			case 'gzip':
+			case 'deflate':	//zlib
+				if (extension_loaded('zlib'))
+	 			{
+	  				stream_filter_append($options['stream'], 'zlib.inflate', STREAM_FILTER_READ);
+	   			}
+		}
+		// store request in $this->request, if requested via $this->store_request
+		if ($this->store_request)
+		{
+			$options['content'] = '';
+			while(!feof($options['stream']))
+			{
+				$options['content'] .= fread($options['stream'],8192);
+			}
+			$this->request =& $options['content'];
+			unset($options['stream']);
+		}
+
+		/* RFC 2616 2.6 says: "The recipient of the entity MUST NOT
+         ignore any Content-* (e.g. Content-Range) headers that it
+         does not understand or implement and MUST return a 501
+         (Not Implemented) response in such cases."
+         */
+		foreach ($this->_SERVER as $key => $val) {
+			if (strncmp($key, 'HTTP_CONTENT', 11)) continue;
+			switch ($key) {
+				case 'HTTP_CONTENT_ENCODING': // RFC 2616 14.11
+					switch($this->_SERVER['HTTP_CONTENT_ENCODING'])
+					{
+						case 'gzip':
+						case 'deflate':	//zlib
+							if (extension_loaded('zlib')) break;
+							// fall through for no zlib support
+						default:
+							$this->http_status('415 Unsupported Media Type');
+							echo "The service does not support '$val' content encoding";
+							return;
+					}
+					break;
+
+				case 'HTTP_CONTENT_LANGUAGE': // RFC 2616 14.12
+					// we assume it is not critical if this one is ignored
+					// in the actual POST implementation ...
+					$options['content_language'] = $val;
+					break;
+
+				case 'HTTP_CONTENT_LENGTH':
+					// defined on IIS and has the same value as CONTENT_LENGTH
+					break;
+
+				case 'HTTP_CONTENT_LOCATION': // RFC 2616 14.14
+					/* The meaning of the Content-Location header in PUT
+			         or POST requests is undefined; servers are free
+			         to ignore it in those cases. */
+					break;
+
+				case 'HTTP_CONTENT_RANGE':    // RFC 2616 14.16
+					// single byte range requests are supported
+					// the header format is also specified in RFC 2616 14.16
+					// TODO we have to ensure that implementations support this or send 501 instead
+					$matches = null;
+					if (!preg_match('@bytes\s+(\d+)-(\d+)/((\d+)|\*)@', $val, $matches)) {
+						$this->http_status('400 bad request');
+						echo 'The service does only support single byte ranges';
+						return;
+					}
+
+					$range = array('start'=>$matches[1], 'end'=>$matches[2]);
+					if (is_numeric($matches[3])) {
+						$range['total_length'] = $matches[3];
+					}
+					$options['ranges'][] = $range;
+
+					// TODO make sure the implementation supports partial POST
+					// this has to be done in advance to avoid data being overwritten
+					// on implementations that do not support this ...
+					break;
+
+				case 'HTTP_CONTENT_TYPE':
+					// defined on IIS and has the same value as CONTENT_TYPE
+					break;
+
+				case 'HTTP_CONTENT_MD5':      // RFC 2616 14.15
+					// TODO: maybe we can just pretend here?
+					$this->http_status('501 not implemented');
+					echo 'The service does not support content MD5 checksum verification';
+					return;
+
+				case 'HTTP_CONTENT_DISPOSITION':
+					// do NOT care about Content-Disposition in POST requests required by CalDAV managed attachments
+					break;
+
+				default:
+					// any other unknown Content-* headers
+					$this->http_status('501 not implemented');
+				echo "The service does not support '$key'";
+				return;
+			}
+		}
+
+		if (method_exists($this, 'POST')) {
+			$status = $this->POST($options);
+
+			if ($status === false) {
+				$status = '400 Something went wrong';
+			} else if ($status === true) {
+				$status = '200 OK';
+			} else if (is_resource($status) && get_resource_type($status) == 'stream') {
+				$stream = $status;
+
+				$status = empty($options['new']) ? '200 OK' : '201 Created';
+
+				if (!empty($options['ranges'])) {
+					// TODO multipart support is missing (see also above)
+					if (0 == fseek($stream, $range[0]['start'], SEEK_SET)) {
+						$length = $range[0]['end']-$range[0]['start']+1;
+						if (!fwrite($stream, fread($options['stream'], $length))) {
+							$status = '403 Forbidden';
+						}
+					} else {
+						$status = '403 Forbidden';
+					}
+				} else {
+					while (!feof($options['stream'])) {
+						if (false === fwrite($stream, fread($options['stream'], 4096))) {
+							$status = '403 Forbidden';
+							break;
+						}
+					}
+				}
+				fclose($stream);
+			}
+		}
+		$this->http_status($status);
+	}
+
+	// }}}
+
+	// {{{ http_PUT()
+
+	/**
+	 * PUT method handler
+	 *
+	 * @param  void
+	 * @return void
+	 */
+	function http_PUT()
+	{
+		if ($this->_check_lock_status($this->path)) {
+			$options                   = Array();
+			$options["path"]           = $this->path;
+
+			if (isset($this->_SERVER['CONTENT_LENGTH']))
+			{
+				$options['content_length'] = $this->_SERVER['CONTENT_LENGTH'];
+			}
+			elseif (isset($this->_SERVER['X-Expected-Entity-Length']))
+			{
+				// MacOS gives us that hint
+				$options['content_length'] = $this->_SERVER['X-Expected-Entity-Length'];
+			}
+
+			// get the Content-type
+			if (isset($this->_SERVER["CONTENT_TYPE"])) {
+				// for now we do not support any sort of multipart requests
+				if (!strncmp($this->_SERVER["CONTENT_TYPE"], "multipart/", 10)) {
+					$this->http_status("501 not implemented");
+					echo "The service does not support multipart PUT requests";
+					return;
+				}
+				$options["content_type"] = $this->_SERVER["CONTENT_TYPE"];
+			} else {
+				// default content type if none given
+				$options["content_type"] = "application/octet-stream";
+			}
+
+			$options["stream"] = fopen("php://input", "r");
+			switch($this->_SERVER['HTTP_CONTENT_ENCODING'])
+			{
+				case 'gzip':
+				case 'deflate':	//zlib
+					if (extension_loaded('zlib'))
+		 			{
+		  				stream_filter_append($options['stream'], 'zlib.inflate', STREAM_FILTER_READ);
+		   			}
+			}
+			// store request in $this->request, if requested via $this->store_request
+			if ($this->store_request)
+			{
+				$options['content'] = '';
+				while(!feof($options['stream']))
+				{
+					$options['content'] .= fread($options['stream'],8192);
+				}
+				$this->request =& $options['content'];
+				unset($options['stream']);
+			}
+
+			/* RFC 2616 2.6 says: "The recipient of the entity MUST NOT
+             ignore any Content-* (e.g. Content-Range) headers that it
+             does not understand or implement and MUST return a 501
+             (Not Implemented) response in such cases."
+            */
+			foreach ($this->_SERVER as $key => $val) {
+				if (strncmp($key, "HTTP_CONTENT", 11)) continue;
+				switch ($key) {
+				case 'HTTP_CONTENT_ENCODING': // RFC 2616 14.11
+					switch($this->_SERVER['HTTP_CONTENT_ENCODING'])
+					{
+						case 'gzip':
+						case 'deflate':	//zlib
+							if (extension_loaded('zlib')) break;
+							// fall through for no zlib support
+						default:
+							$this->http_status('415 Unsupported Media Type');
+							echo "The service does not support '$val' content encoding";
+							return;
+					}
+					break;
+
+				case 'HTTP_CONTENT_LANGUAGE': // RFC 2616 14.12
+					// we assume it is not critical if this one is ignored
+					// in the actual PUT implementation ...
+					$options["content_language"] = $val;
+					break;
+
+				case 'HTTP_CONTENT_LENGTH':
+					// defined on IIS and has the same value as CONTENT_LENGTH
+					break;
+
+				case 'HTTP_CONTENT_LOCATION': // RFC 2616 14.14
+					/* The meaning of the Content-Location header in PUT
+                     or POST requests is undefined; servers are free
+                     to ignore it in those cases. */
+					break;
+
+				case 'HTTP_CONTENT_RANGE':    // RFC 2616 14.16
+					// single byte range requests are supported
+					// the header format is also specified in RFC 2616 14.16
+					// TODO we have to ensure that implementations support this or send 501 instead
+					$matches = null;
+					if (!preg_match('@bytes\s+(\d+)-(\d+)/((\d+)|\*)@', $val, $matches)) {
+						$this->http_status("400 bad request");
+						echo "The service does only support single byte ranges";
+						return;
+					}
+
+					$range = array("start" => $matches[1], "end" => $matches[2]);
+					if (is_numeric($matches[3])) {
+						$range["total_length"] = $matches[3];
+					}
+
+					if (!isset($options['ranges'])) {
+						$options['ranges'] = array();
+					}
+
+					$options["ranges"][] = $range;
+
+					// TODO make sure the implementation supports partial PUT
+					// this has to be done in advance to avoid data being overwritten
+					// on implementations that do not support this ...
+					break;
+
+				case 'HTTP_CONTENT_TYPE':
+					// defined on IIS and has the same value as CONTENT_TYPE
+					break;
+
+				case 'HTTP_CONTENT_MD5':      // RFC 2616 14.15
+					// TODO: maybe we can just pretend here?
+					$this->http_status("501 not implemented");
+					echo "The service does not support content MD5 checksum verification";
+					return;
+
+				default:
+					// any other unknown Content-* headers
+					$this->http_status("501 not implemented");
+					echo "The service does not support '$key'";
+					return;
+				}
+			}
+
+			$stat = $this->PUT($options);
+
+			if ($stat === false) {
+				$stat = "403 Forbidden";
+			} else if (is_resource($stat) && get_resource_type($stat) == "stream") {
+				$stream = $stat;
+
+				$stat = $options["new"] ? "201 Created" : "204 No Content";
+
+				if (!empty($options["ranges"])) {
+					// TODO multipart support is missing (see also above)
+					if (0 == fseek($stream, $options['ranges'][0]["start"], SEEK_SET)) {
+						$length = $options['ranges'][0]["end"] - $options['ranges'][0]["start"]+1;
+
+						while (!feof($options['stream'])) {
+							if ($length <= 0) {
+							   break;
+							}
+
+							if ($length <= 8192) {
+								$data = fread($options['stream'], $length);
+							} else {
+								$data = fread($options['stream'], 8192);
+							}
+
+							if ($data === false) {
+								$stat = "400 Bad request";
+							} elseif (strlen($data)) {
+								if (false === fwrite($stream, $data)) {
+									$stat = "403 Forbidden";
+									break;
+								}
+								$length -= strlen($data);
+							}
+						}
+					} else {
+						$stat = "403 Forbidden";
+					}
+				} else {
+					while (!feof($options["stream"])) {
+						if (false === fwrite($stream, fread($options["stream"], 8192))) {
+							$stat = "403 Forbidden";
+							break;
+						}
+					}
+				}
+
+				fclose($stream);
+			}
+
+			$this->http_status($stat);
+		} else {
+			$this->http_status("423 Locked");
+		}
+	}
+
+	// }}}
+
+
+	// {{{ http_DELETE()
+
+	/**
+	 * DELETE method handler
+	 *
+	 * @param  void
+	 * @return void
+	 */
+	function http_DELETE()
+	{
+		// check RFC 2518 Section 9.2, last paragraph
+		if (isset($this->_SERVER["HTTP_DEPTH"])) {
+			if ($this->_SERVER["HTTP_DEPTH"] != "infinity") {
+				if (stripos($_SERVER['HTTP_USER_AGENT'],'webdrive') !== false)
+				{
+					// pretend we didnt see it, as webdrive does not handle the depth parameter correctly while deleting collections
+				}
+				else
+				{
+					$this->http_status("400 Bad Request");
+					return;
+				}
+			}
+		}
+
+		// check lock status
+		if ($this->_check_lock_status($this->path)) {
+			// ok, proceed
+			$options         = Array();
+			$options["path"] = $this->path;
+
+			$stat = $this->DELETE($options);
+
+			$this->http_status($stat);
+		} else {
+			// sorry, its locked
+			$this->http_status("423 Locked");
+		}
+	}
+
+	// }}}
+
+	// {{{ http_COPY()
+
+	/**
+	 * COPY method handler
+	 *
+	 * @param  void
+	 * @return void
+	 */
+	function http_COPY()
+	{
+		// no need to check source lock status here
+		// destination lock status is always checked by the helper method
+		$this->_copymove("copy");
+	}
+
+	// }}}
+
+	// {{{ http_MOVE()
+
+	/**
+	 * MOVE method handler
+	 *
+	 * @param  void
+	 * @return void
+	 */
+	function http_MOVE()
+	{
+		if ($this->_check_lock_status($this->path)) {
+			// destination lock status is always checked by the helper method
+			$this->_copymove("move");
+		} else {
+			$this->http_status("423 Locked");
+		}
+	}
+
+	// }}}
+
+
+	// {{{ http_LOCK()
+
+	/**
+	 * LOCK method handler
+	 *
+	 * @param  void
+	 * @return void
+	 */
+	function http_LOCK()
+	{
+		$options         = Array();
+		$options["path"] = $this->path;
+
+		if (isset($this->_SERVER['HTTP_DEPTH'])) {
+			$options["depth"] = $this->_SERVER["HTTP_DEPTH"];
+		} else {
+			$options["depth"] = "infinity";
+		}
+
+		if (isset($this->_SERVER["HTTP_TIMEOUT"])) {
+			$options["timeout"] = explode(",", $this->_SERVER["HTTP_TIMEOUT"]);
+		}
+
+		if (empty($this->_SERVER['CONTENT_LENGTH']) && !empty($this->_SERVER['HTTP_IF'])) {
+			// check if locking is possible
+			if (!$this->_check_lock_status($this->path)) {
+				$this->http_status("423 Locked");
+				return;
+			}
+
+			// refresh lock
+			$options["locktoken"] = substr($this->_SERVER['HTTP_IF'], 2, -2);
+			$options["update"]    = $options["locktoken"];
+
+			// setting defaults for required fields, LOCK() SHOULD overwrite these
+			$options['owner']     = "unknown";
+			$options['scope']     = "exclusive";
+			$options['type']      = "write";
+
+
+			$stat = $this->LOCK($options);
+		} else {
+			// extract lock request information from request XML payload
+			$lockinfo = new _parse_lockinfo("php://input");
+			if (!$lockinfo->success) {
+				$this->http_status("400 bad request");
+			}
+
+			// check if locking is possible
+			if (!$this->_check_lock_status($this->path, $lockinfo->lockscope === "shared")) {
+				$this->http_status("423 Locked");
+				return;
+			}
+
+			// new lock
+			$options["scope"]     = $lockinfo->lockscope;
+			$options["type"]      = $lockinfo->locktype;
+			// Todo: lockinfo::owner still contains D:href opening and closing tags, maybe they should be removed here with strip_tags
+			$options["owner"]     = $lockinfo->owner;
+			$options["locktoken"] = $this->_new_locktoken();
+
+			$stat = $this->LOCK($options);
+		}
+
+		if (is_bool($stat)) {
+			$http_stat = $stat ? "200 OK" : "423 Locked";
+		} else {
+			$http_stat = (string)$stat;
+		}
+		$this->http_status($http_stat);
+
+		if ($http_stat{0} == 2) { // 2xx states are ok
+			if ($options["timeout"]) {
+				// if multiple timeout values were given we take the first only
+				if (is_array($options["timeout"])) {
+					reset($options["timeout"]);
+					$options["timeout"] = current($options["timeout"]);
+				}
+				// if the timeout is numeric only we need to reformat it
+				if (is_numeric($options["timeout"])) {
+					// more than a million is considered an absolute timestamp
+					// less is more likely a relative value
+					if ($options["timeout"]>1000000) {
+						$timeout = "Second-".($options['timeout']-time());
+					} else {
+						$timeout = "Second-$options[timeout]";
+					}
+				} else {
+					// non-numeric values are passed on verbatim,
+					// no error checking is performed here in this case
+					// TODO: send "Infinite" on invalid timeout strings?
+					$timeout = $options["timeout"];
+				}
+			} else {
+				$timeout = "Infinite";
+			}
+
+			header('Content-Type: text/xml; charset="utf-8"');
+			header("Lock-Token: <$options[locktoken]>");
+			echo "<?xml version=\"1.0\" encoding=\"utf-8\"?>\n";
+			echo "<D:prop xmlns:D=\"DAV:\">\n";
+			echo ' <'.($this->crrnd?'':'D:')."lockdiscovery>\n";
+			echo '  <'.($this->crrnd?'':'D:')."activelock>\n";
+			echo '   <'.($this->crrnd?'':'D:')."lockscope><D:$options[scope]/></".($this->crrnd?'':'D:')."lockscope>\n";
+			echo '   <'.($this->crrnd?'':'D:')."locktype><D:$options[type]/></".($this->crrnd?'':'D:')."locktype>\n";
+			echo '   <'.($this->crrnd?'':'D:')."depth>$options[depth]</".($this->crrnd?'':'D:')."depth>\n";
+			echo '   <'.($this->crrnd?'':'D:')."owner>$options[owner]</".($this->crrnd?'':'D:')."owner>\n";
+			echo '   <'.($this->crrnd?'':'D:')."timeout>$timeout</".($this->crrnd?'':'D:')."timeout>\n";
+			echo '   <'.($this->crrnd?'':'D:')."locktoken><D:href>$options[locktoken]</D:href></".($this->crrnd?'':'D:')."locktoken>\n";
+			echo '  </'.($this->crrnd?'':'D:')."activelock>\n";
+			echo ' </'.($this->crrnd?'':'D:')."lockdiscovery>\n";
+			echo '</'.($this->crrnd?'':'D:')."prop>\n\n";
+		}
+	}
+
+
+	// }}}
+
+	// {{{ http_UNLOCK()
+
+	/**
+	 * UNLOCK method handler
+	 *
+	 * @param  void
+	 * @return void
+	 */
+	function http_UNLOCK()
+	{
+		$options         = Array();
+		$options["path"] = $this->path;
+
+		if (isset($this->_SERVER['HTTP_DEPTH'])) {
+			$options["depth"] = $this->_SERVER["HTTP_DEPTH"];
+		} else {
+			$options["depth"] = "infinity";
+		}
+
+		// strip surrounding <>
+		$options["token"] = substr(trim($this->_SERVER["HTTP_LOCK_TOKEN"]), 1, -1);
+
+		// call user method
+		$stat = $this->UNLOCK($options);
+
+		$this->http_status($stat);
+	}
+
+	// }}}
+
+	// {{{ http_ACL()
+
+	/**
+	 * ACL method handler
+	 *
+	 * @param  void
+	 * @return void
+	 */
+	function http_ACL()
+	{
+		$options         = Array();
+		$options['path'] = $this->path;
+		$options['errors'] = array();
+
+		if (isset($this->_SERVER['HTTP_DEPTH'])) {
+			$options['depth'] = $this->_SERVER['HTTP_DEPTH'];
+		} else {
+			$options['depth'] = 'infinity';
+		}
+
+		// call user method
+		$status = $this->ACL($options);
+
+		// now we generate the reply header ...
+		$this->http_status($status);
+		$content = '';
+
+		if (is_array($options['errors']) && count($options['errors'])) {
+			header('Content-Type: text/xml; charset="utf-8"');
+			// ... and payload
+			$content .= "<?xml version=\"1.0\" encoding=\"utf-8\"?>\n";
+			$content .= "<D:error xmlns:D=\"DAV:\"> \n";
+			foreach ($options['errors'] as $violation) {
+				$content .= '<'.($this->crrnd?'':'D:')."$violation/>\n";
+			}
+			$content .=  '</'.($this->crrnd?'':'D:')."error>\n";
+		}
+		if (!self::use_compression()) header("Content-Length: ".self::bytes($content));
+		if ($content) echo $options['content'];
+	}
+
+	// }}}
+
+	// }}}
+
+	// {{{ _copymove()
+
+	function _copymove($what)
+	{
+		$options         = Array();
+		$options["path"] = $this->path;
+
+		if (isset($this->_SERVER["HTTP_DEPTH"])) {
+			$options["depth"] = $this->_SERVER["HTTP_DEPTH"];
+		} else {
+			$options["depth"] = "infinity";
+		}
+
+		$http_header_host = preg_replace("/:80$/", "", $this->_SERVER["HTTP_HOST"]);
+
+		$url  = parse_url($this->_SERVER["HTTP_DESTINATION"]);
+		$path = urldecode($url["path"]);
+
+		if (isset($url["host"])) {
+			// TODO check url scheme, too
+			$http_host = $url["host"];
+			if (isset($url["port"]) && $url["port"] != 80)
+				$http_host.= ":".$url["port"];
+		} else {
+			// only path given, set host to self
+			$http_host = $http_header_host;
+		}
+
+		if ($http_host == $http_header_host &&
+			!strncmp($this->_SERVER["SCRIPT_NAME"], $path,
+					 strlen($this->_SERVER["SCRIPT_NAME"]))) {
+			$options["dest"] = substr($path, strlen($this->_SERVER["SCRIPT_NAME"]));
+			if (!$this->_check_lock_status($options["dest"])) {
+				$this->http_status("423 Locked");
+				return;
+			}
+
+		} else {
+			$options["dest_url"] = $this->_SERVER["HTTP_DESTINATION"];
+		}
+
+		// see RFC 2518 Sections 9.6, 8.8.4 and 8.9.3
+		if (isset($this->_SERVER["HTTP_OVERWRITE"])) {
+			$options["overwrite"] = $this->_SERVER["HTTP_OVERWRITE"] == "T";
+		} else {
+			$options["overwrite"] = true;
+		}
+
+		$stat = $this->$what($options);
+		$this->http_status($stat);
+	}
+
+	// }}}
+
+	// {{{ _allow()
+
+	/**
+	 * check for implemented HTTP methods
+	 *
+	 * @param  void
+	 * @return array something
+	 */
+	function _allow()
+	{
+		// OPTIONS is always there
+		$allow = array("OPTIONS" =>"OPTIONS");
+
+		// all other METHODS need both a http_method() wrapper
+		// and a method() implementation
+		// the base class supplies wrappers only
+		foreach (get_class_methods($this) as $method) {
+			if (!strncmp("http_", $method, 5)) {
+				$method = strtoupper(substr($method, 5));
+				if (method_exists($this, $method)) {
+					$allow[$method] = $method;
+				}
+			}
+		}
 
+		// we can emulate a missing HEAD implemetation using GET
+		if (isset($allow["GET"]))
+			$allow["HEAD"] = "HEAD";
 
-    /**
-     * parse HTTP Range: header
-     *
-     * @param  array options array to store result in
-     * @return void
-     */
-    function _get_ranges(&$options)
-    {
-        // process Range: header if present
-        if (isset($this->_SERVER['HTTP_RANGE'])) {
-
-            // we only support standard "bytes" range specifications for now
-			$matches = null;
-            if (preg_match('/bytes\s*=\s*(.+)/', $this->_SERVER['HTTP_RANGE'], $matches)) {
-                $options["ranges"] = array();
-
-                // ranges are comma separated
-                foreach (explode(",", $matches[1]) as $range) {
-                    // ranges are either from-to pairs or just end positions
-                    list($start, $end) = explode("-", $range);
-                    $options["ranges"][] = ($start==="")
-                        ? array("last"=>$end)
-                        : array("start"=>$start, "end"=>$end);
-                }
-            }
-        }
-    }
+		// no LOCK without checklok()
+		if (!method_exists($this, "checklock")) {
+			unset($allow["LOCK"]);
+			unset($allow["UNLOCK"]);
+		}
 
-    /**
-     * generate separator headers for multipart response
-     *
-     * first and last call happen without parameters to generate
-     * the initial header and closing sequence, all calls inbetween
-     * require content mimetype, start and end byte position and
-     * optionaly the total byte length of the requested resource
-     *
-     * @param  string  mimetype
-     * @param  int     start byte position
-     * @param  int     end   byte position
-     * @param  int     total resource byte size
-     */
-    function _multipart_byterange_header($mimetype = false, $from = false, $to=false, $total=false)
-    {
-        if ($mimetype === false) {
-            if (!isset($this->multipart_separator)) {
-                // initial
-
-                // a little naive, this sequence *might* be part of the content
-                // but it's really not likely and rather expensive to check
-                $this->multipart_separator = "SEPARATOR_".md5(microtime());
-
-                // generate HTTP header
-                header("Content-type: multipart/byteranges; boundary=".$this->multipart_separator);
-            } else {
-                // final
-
-                // generate closing multipart sequence
-                echo "\n--{$this->multipart_separator}--";
-            }
-        } else {
-            // generate separator and header for next part
-            echo "\n--{$this->multipart_separator}\n";
-            echo "Content-type: $mimetype\n";
-            echo "Content-range: $from-$to/". ($total === false ? "*" : $total);
-            echo "\n\n";
-        }
-    }
-
-
-
-    // }}}
-
-    // {{{ http_HEAD()
+		return $allow;
+	}
 
-    /**
-     * HEAD method handler
-     *
-     * @param  void
-     * @return void
-     */
-    function http_HEAD()
-    {
-        $status          = false;
-        $options         = Array();
-        $options["path"] = $this->path;
-
-        if (method_exists($this, "HEAD")) {
-            $status = $this->head($options);
-        } else if (method_exists($this, "GET")) {
-            ob_start();
-            $status = $this->GET($options);
-            if (!isset($options['size'])) {
-                $options['size'] = ob_get_length();
-            }
-            ob_end_clean();
-        }
-
-        if (!isset($options['mimetype'])) {
-            $options['mimetype'] = "application/octet-stream";
-        }
-        header("Content-type: $options[mimetype]");
-
-        if (isset($options['mtime'])) {
-            header("Last-modified:".gmdate("D, d M Y H:i:s ", $options['mtime'])."GMT");
-        }
-
-        if (isset($options['size'])) {
-            header("Content-Length: ".$options['size']);
-        }
-
-        if ($status === true)  $status = "200 OK";
-        if ($status === false) $status = "404 Not found";
-
-        $this->http_status($status);
-    }
-
-    // }}}
-
-    // {{{ http_POST()
+	// }}}
 
-    /**
-     * POST method handler
-     *
-     * @param  void
-     * @return void
-     */
-    function http_POST()
-    {
-        $status          = '405 Method not allowed';
-        $options         = Array();
-        $options['path'] = $this->path;
-
-        if (isset($this->_SERVER['CONTENT_LENGTH']))
-        {
-	        $options['content_length'] = $this->_SERVER['CONTENT_LENGTH'];
-        }
-        elseif (isset($this->_SERVER['X-Expected-Entity-Length']))
-		{
-	        // MacOS gives us that hint
-	        $options['content_length'] = $this->_SERVER['X-Expected-Entity-Length'];
-		}
-
-        // get the Content-type
-        if (isset($this->_SERVER["CONTENT_TYPE"])) {
-	        // for now we do not support any sort of multipart requests
-	        if (!strncmp($this->_SERVER["CONTENT_TYPE"], 'multipart/', 10)) {
-		        $this->http_status('501 not implemented');
-		        echo 'The service does not support mulipart POST requests';
-		        return;
-	        }
-	        $options['content_type'] = $this->_SERVER['CONTENT_TYPE'];
-        } else {
-	        // default content type if none given
-	        $options['content_type'] = 'application/octet-stream';
-        }
-
-        $options['stream'] = fopen('php://input', 'r');
-    	switch($this->_SERVER['HTTP_CONTENT_ENCODING'])
-    	{
-    		case 'gzip':
-    		case 'deflate':	//zlib
-    			if (extension_loaded('zlib'))
-     			{
-      				stream_filter_append($options['stream'], 'zlib.inflate', STREAM_FILTER_READ);
-       			}
-    	}
-		// store request in $this->request, if requested via $this->store_request
-		if ($this->store_request)
-		{
-			$options['content'] = '';
-			while(!feof($options['stream']))
-			{
-				$options['content'] .= fread($options['stream'],8192);
-			}
-			$this->request =& $options['content'];
-			unset($options['stream']);
+	/**
+	 * helper for property element creation
+	 *
+	 * @param  string  XML namespace (optional)
+	 * @param  string  property name
+	 * @param  string  property value
+	 * @praram boolen  property raw-flag
+	 * @return array   property array
+	 */
+	public static function mkprop()
+	{
+		$args = func_get_args();
+		switch (count($args)) {
+			case 4:
+				return array('ns'   => $args[0],
+					'name' => $args[1],
+					'val'  => $args[2],
+					'raw'	=> true);
+			case 3:
+				return array('ns'   => $args[0],
+					'name' => $args[1],
+					'val'  => $args[2]);
+			default:
+				return array('ns'   => 'DAV:',
+					'name' => $args[0],
+					'val'  => $args[1]);
 		}
+	}
 
-        /* RFC 2616 2.6 says: "The recipient of the entity MUST NOT
-         ignore any Content-* (e.g. Content-Range) headers that it
-         does not understand or implement and MUST return a 501
-         (Not Implemented) response in such cases."
-         */
-        foreach ($this->_SERVER as $key => $val) {
-	        if (strncmp($key, 'HTTP_CONTENT', 11)) continue;
-	        switch ($key) {
-		        case 'HTTP_CONTENT_ENCODING': // RFC 2616 14.11
-		        	switch($this->_SERVER['HTTP_CONTENT_ENCODING'])
-		        	{
-		        		case 'gzip':
-		        		case 'deflate':	//zlib
-		        			if (extension_loaded('zlib')) break;
-		        			// fall through for no zlib support
-		        		default:
-					        $this->http_status('415 Unsupported Media Type');
-					        echo "The service does not support '$val' content encoding";
-					        return;
-		        	}
-		        	break;
-
-		        case 'HTTP_CONTENT_LANGUAGE': // RFC 2616 14.12
-			        // we assume it is not critical if this one is ignored
-			        // in the actual POST implementation ...
-			        $options['content_language'] = $val;
-			        break;
-
-		        case 'HTTP_CONTENT_LENGTH':
-			        // defined on IIS and has the same value as CONTENT_LENGTH
-			        break;
-
-		        case 'HTTP_CONTENT_LOCATION': // RFC 2616 14.14
-			        /* The meaning of the Content-Location header in PUT
-			         or POST requests is undefined; servers are free
-			         to ignore it in those cases. */
-			        break;
+	// {{{ _check_auth
 
-		        case 'HTTP_CONTENT_RANGE':    // RFC 2616 14.16
-			        // single byte range requests are supported
-			        // the header format is also specified in RFC 2616 14.16
-			        // TODO we have to ensure that implementations support this or send 501 instead
-					$matches = null;
-			        if (!preg_match('@bytes\s+(\d+)-(\d+)/((\d+)|\*)@', $val, $matches)) {
-				        $this->http_status('400 bad request');
-				        echo 'The service does only support single byte ranges';
-				        return;
-			        }
-
-			        $range = array('start'=>$matches[1], 'end'=>$matches[2]);
-			        if (is_numeric($matches[3])) {
-				        $range['total_length'] = $matches[3];
-			        }
-			        $options['ranges'][] = $range;
-
-			        // TODO make sure the implementation supports partial POST
-			        // this has to be done in advance to avoid data being overwritten
-			        // on implementations that do not support this ...
-			        break;
-
-		        case 'HTTP_CONTENT_TYPE':
-			        // defined on IIS and has the same value as CONTENT_TYPE
-			        break;
-
-		        case 'HTTP_CONTENT_MD5':      // RFC 2616 14.15
-			        // TODO: maybe we can just pretend here?
-			        $this->http_status('501 not implemented');
-			        echo 'The service does not support content MD5 checksum verification';
-			        return;
-
-		        case 'HTTP_CONTENT_DISPOSITION':
-		        	// do NOT care about Content-Disposition in POST requests required by CalDAV managed attachments
-		        	break;
-
-		        default:
-			        // any other unknown Content-* headers
-			        $this->http_status('501 not implemented');
-		        echo "The service does not support '$key'";
-		        return;
-	        }
-        }
-
-        if (method_exists($this, 'POST')) {
-	        $status = $this->POST($options);
-
-	        if ($status === false) {
-		        $status = '400 Something went wrong';
-	        } else if ($status === true) {
-	        	$status = '200 OK';
-	        } else if (is_resource($status) && get_resource_type($status) == 'stream') {
-		        $stream = $status;
-
-		        $status = empty($options['new']) ? '200 OK' : '201 Created';
-
-		        if (!empty($options['ranges'])) {
-			        // TODO multipart support is missing (see also above)
-			        if (0 == fseek($stream, $range[0]['start'], SEEK_SET)) {
-				        $length = $range[0]['end']-$range[0]['start']+1;
-				        if (!fwrite($stream, fread($options['stream'], $length))) {
-					        $status = '403 Forbidden';
-				        }
-			        } else {
-				        $status = '403 Forbidden';
-			        }
-		        } else {
-			        while (!feof($options['stream'])) {
-				        if (false === fwrite($stream, fread($options['stream'], 4096))) {
-					        $status = '403 Forbidden';
-					        break;
-				        }
-			        }
-		        }
-		        fclose($stream);
-	        }
-        }
-        $this->http_status($status);
-    }
-
-    // }}}
-
-    // {{{ http_PUT()
+	/**
+	 * check authentication if check is implemented
+	 *
+	 * @param  void
+	 * @return bool  true if authentication succeded or not necessary
+	 */
+	function _check_auth()
+	{
+		if (method_exists($this, "checkAuth")) {
+			// PEAR style method name
+			return $this->checkAuth(@$this->_SERVER["AUTH_TYPE"],
+									@$this->_SERVER["PHP_AUTH_USER"],
+									@$this->_SERVER["PHP_AUTH_PW"]);
+		} else if (method_exists($this, "check_auth")) {
+			// old (pre 1.0) method name
+			return $this->check_auth(@$this->_SERVER["AUTH_TYPE"],
+									 @$this->_SERVER["PHP_AUTH_USER"],
+									 @$this->_SERVER["PHP_AUTH_PW"]);
+		} else {
+			// no method found -> no authentication required
+			return true;
+		}
+	}
 
-    /**
-     * PUT method handler
-     *
-     * @param  void
-     * @return void
-     */
-    function http_PUT()
-    {
-        if ($this->_check_lock_status($this->path)) {
-            $options                   = Array();
-            $options["path"]           = $this->path;
-
-            if (isset($this->_SERVER['CONTENT_LENGTH']))
-            {
-            	$options['content_length'] = $this->_SERVER['CONTENT_LENGTH'];
-            }
-            elseif (isset($this->_SERVER['X-Expected-Entity-Length']))
-            {
-            	// MacOS gives us that hint
-            	$options['content_length'] = $this->_SERVER['X-Expected-Entity-Length'];
-            }
-
-            // get the Content-type
-            if (isset($this->_SERVER["CONTENT_TYPE"])) {
-                // for now we do not support any sort of multipart requests
-                if (!strncmp($this->_SERVER["CONTENT_TYPE"], "multipart/", 10)) {
-                    $this->http_status("501 not implemented");
-                    echo "The service does not support multipart PUT requests";
-                    return;
-                }
-                $options["content_type"] = $this->_SERVER["CONTENT_TYPE"];
-            } else {
-                // default content type if none given
-                $options["content_type"] = "application/octet-stream";
-            }
-
-            $options["stream"] = fopen("php://input", "r");
-	    	switch($this->_SERVER['HTTP_CONTENT_ENCODING'])
-	    	{
-	    		case 'gzip':
-	    		case 'deflate':	//zlib
-	    			if (extension_loaded('zlib'))
-	     			{
-	      				stream_filter_append($options['stream'], 'zlib.inflate', STREAM_FILTER_READ);
-	       			}
-	    	}
-			// store request in $this->request, if requested via $this->store_request
-			if ($this->store_request)
-			{
-				$options['content'] = '';
-				while(!feof($options['stream']))
-				{
-					$options['content'] .= fread($options['stream'],8192);
-				}
-				$this->request =& $options['content'];
-				unset($options['stream']);
-			}
+	// }}}
 
-            /* RFC 2616 2.6 says: "The recipient of the entity MUST NOT
-             ignore any Content-* (e.g. Content-Range) headers that it
-             does not understand or implement and MUST return a 501
-             (Not Implemented) response in such cases."
-            */
-            foreach ($this->_SERVER as $key => $val) {
-                if (strncmp($key, "HTTP_CONTENT", 11)) continue;
-                switch ($key) {
-                case 'HTTP_CONTENT_ENCODING': // RFC 2616 14.11
-		        	switch($this->_SERVER['HTTP_CONTENT_ENCODING'])
-		        	{
-		        		case 'gzip':
-		        		case 'deflate':	//zlib
-		        			if (extension_loaded('zlib')) break;
-		        			// fall through for no zlib support
-		        		default:
-					        $this->http_status('415 Unsupported Media Type');
-					        echo "The service does not support '$val' content encoding";
-					        return;
-		        	}
-		        	break;
-
-                case 'HTTP_CONTENT_LANGUAGE': // RFC 2616 14.12
-                    // we assume it is not critical if this one is ignored
-                    // in the actual PUT implementation ...
-                    $options["content_language"] = $val;
-                    break;
-
-                case 'HTTP_CONTENT_LENGTH':
-                    // defined on IIS and has the same value as CONTENT_LENGTH
-                    break;
-
-                case 'HTTP_CONTENT_LOCATION': // RFC 2616 14.14
-                    /* The meaning of the Content-Location header in PUT
-                     or POST requests is undefined; servers are free
-                     to ignore it in those cases. */
-                    break;
+	// {{{ UUID stuff
 
-                case 'HTTP_CONTENT_RANGE':    // RFC 2616 14.16
-                    // single byte range requests are supported
-                    // the header format is also specified in RFC 2616 14.16
-                    // TODO we have to ensure that implementations support this or send 501 instead
-					$matches = null;
-                    if (!preg_match('@bytes\s+(\d+)-(\d+)/((\d+)|\*)@', $val, $matches)) {
-                        $this->http_status("400 bad request");
-                        echo "The service does only support single byte ranges";
-                        return;
-                    }
-
-                    $range = array("start" => $matches[1], "end" => $matches[2]);
-                    if (is_numeric($matches[3])) {
-                        $range["total_length"] = $matches[3];
-                    }
-
-                    if (!isset($options['ranges'])) {
-                        $options['ranges'] = array();
-                    }
-
-                    $options["ranges"][] = $range;
-
-                    // TODO make sure the implementation supports partial PUT
-                    // this has to be done in advance to avoid data being overwritten
-                    // on implementations that do not support this ...
-                    break;
-
-                case 'HTTP_CONTENT_TYPE':
-                    // defined on IIS and has the same value as CONTENT_TYPE
-                    break;
-
-                case 'HTTP_CONTENT_MD5':      // RFC 2616 14.15
-                    // TODO: maybe we can just pretend here?
-                    $this->http_status("501 not implemented");
-                    echo "The service does not support content MD5 checksum verification";
-                    return;
-
-                default:
-                    // any other unknown Content-* headers
-                    $this->http_status("501 not implemented");
-                    echo "The service does not support '$key'";
-                    return;
-                }
-            }
-
-            $stat = $this->PUT($options);
-
-            if ($stat === false) {
-                $stat = "403 Forbidden";
-            } else if (is_resource($stat) && get_resource_type($stat) == "stream") {
-                $stream = $stat;
-
-                $stat = $options["new"] ? "201 Created" : "204 No Content";
-
-                if (!empty($options["ranges"])) {
-                    // TODO multipart support is missing (see also above)
-                    if (0 == fseek($stream, $options['ranges'][0]["start"], SEEK_SET)) {
-                        $length = $options['ranges'][0]["end"] - $options['ranges'][0]["start"]+1;
-
-                        while (!feof($options['stream'])) {
-                            if ($length <= 0) {
-                               break;
-                            }
-
-                            if ($length <= 8192) {
-                                $data = fread($options['stream'], $length);
-                            } else {
-                                $data = fread($options['stream'], 8192);
-                            }
-
-                            if ($data === false) {
-                                $stat = "400 Bad request";
-                            } elseif (strlen($data)) {
-                                if (false === fwrite($stream, $data)) {
-                                    $stat = "403 Forbidden";
-                                    break;
-                                }
-                                $length -= strlen($data);
-                            }
-                        }
-                    } else {
-                        $stat = "403 Forbidden";
-                    }
-                } else {
-                    while (!feof($options["stream"])) {
-                        if (false === fwrite($stream, fread($options["stream"], 8192))) {
-                            $stat = "403 Forbidden";
-                            break;
-                        }
-                    }
-                }
-
-                fclose($stream);
-            }
-
-            $this->http_status($stat);
-        } else {
-            $this->http_status("423 Locked");
-        }
-    }
-
-    // }}}
-
-
-    // {{{ http_DELETE()
+	/**
+	 * generate Unique Universal IDentifier for lock token
+	 *
+	 * @param  void
+	 * @return string  a new UUID
+	 */
+	public static function _new_uuid()
+	{
+		// use uuid extension from PECL if available
+		if (function_exists("uuid_create")) {
+			return uuid_create();
+		}
 
-    /**
-     * DELETE method handler
-     *
-     * @param  void
-     * @return void
-     */
-    function http_DELETE()
-    {
-        // check RFC 2518 Section 9.2, last paragraph
-        if (isset($this->_SERVER["HTTP_DEPTH"])) {
-            if ($this->_SERVER["HTTP_DEPTH"] != "infinity") {
-				if (stripos($_SERVER['HTTP_USER_AGENT'],'webdrive') !== false)
-				{
-					// pretend we didnt see it, as webdrive does not handle the depth parameter correctly while deleting collections
-				}
-				else
-				{
-                	$this->http_status("400 Bad Request");
-                	return;
-				}
-            }
-        }
+		// fallback
+		$uuid = md5(microtime().getmypid());    // this should be random enough for now
+
+		// set variant and version fields for 'true' random uuid
+		$uuid{12} = "4";
+		$n = 8 + (ord($uuid{16}) & 3);
+		$hex = "0123456789abcdef";
+		$uuid{16} = $hex{$n};
+
+		// return formated uuid
+		return substr($uuid,  0, 8)."-"
+			.  substr($uuid,  8, 4)."-"
+			.  substr($uuid, 12, 4)."-"
+			.  substr($uuid, 16, 4)."-"
+			.  substr($uuid, 20);
+	}
 
-        // check lock status
-        if ($this->_check_lock_status($this->path)) {
-            // ok, proceed
-            $options         = Array();
-            $options["path"] = $this->path;
+	/**
+	 * create a new opaque lock token as defined in RFC2518
+	 *
+	 * @param  void
+	 * @return string  new RFC2518 opaque lock token
+	 */
+	public static function _new_locktoken()
+	{
+		return "opaquelocktoken:".self::_new_uuid();
+	}
 
-            $stat = $this->DELETE($options);
+	// }}}
 
-            $this->http_status($stat);
-        } else {
-            // sorry, its locked
-            $this->http_status("423 Locked");
-        }
-    }
+	// {{{ WebDAV If: header parsing
 
-    // }}}
+	/**
+	 *
+	 *
+	 * @param  string  header string to parse
+	 * @param  int     current parsing position
+	 * @return array   next token (type and value)
+	 */
+	function _if_header_lexer($string, &$pos)
+	{
+		// skip whitespace
+		while (ctype_space($string{$pos})) {
+			++$pos;
+		}
 
-    // {{{ http_COPY()
+		// already at end of string?
+		if (strlen($string) <= $pos) {
+			return false;
+		}
 
-    /**
-     * COPY method handler
-     *
-     * @param  void
-     * @return void
-     */
-    function http_COPY()
-    {
-        // no need to check source lock status here
-        // destination lock status is always checked by the helper method
-        $this->_copymove("copy");
-    }
-
-    // }}}
-
-    // {{{ http_MOVE()
+		// get next character
+		$c = $string{$pos++};
+
+		// now it depends on what we found
+		switch ($c) {
+		case "<":
+			// URIs are enclosed in <...>
+			$pos2 = strpos($string, ">", $pos);
+			$uri  = substr($string, $pos, $pos2 - $pos);
+			$pos  = $pos2 + 1;
+			return array("URI", $uri);
+
+		case "[":
+			//Etags are enclosed in [...]
+			if ($string{$pos} == "W") {
+				$type = "ETAG_WEAK";
+				$pos += 2;
+			} else {
+				$type = "ETAG_STRONG";
+			}
+			$pos2 = strpos($string, "]", $pos);
+			$etag = substr($string, $pos + 1, $pos2 - $pos - 2);
+			$pos  = $pos2 + 1;
+			return array($type, $etag);
+
+		case "N":
+			// "N" indicates negation
+			$pos += 2;
+			return array("NOT", "Not");
+
+		default:
+			// anything else is passed verbatim char by char
+			return array("CHAR", $c);
+		}
+	}
 
-    /**
-     * MOVE method handler
-     *
-     * @param  void
-     * @return void
-     */
-    function http_MOVE()
-    {
-        if ($this->_check_lock_status($this->path)) {
-            // destination lock status is always checked by the helper method
-            $this->_copymove("move");
-        } else {
-            $this->http_status("423 Locked");
-        }
-    }
-
-    // }}}
-
-
-    // {{{ http_LOCK()
+	/**
+	 * parse If: header
+	 *
+	 * @param  string  header string
+	 * @return array   URIs and their conditions
+	 */
+	function _if_header_parser($str)
+	{
+		$pos  = 0;
+		$len  = strlen($str);
+		$uris = array();
+
+		// parser loop
+		while ($pos < $len) {
+			// get next token
+			$token = $this->_if_header_lexer($str, $pos);
+
+			// check for URI
+			if ($token[0] == "URI") {
+				$uri   = $token[1]; // remember URI
+				$token = $this->_if_header_lexer($str, $pos); // get next token
+			} else {
+				$uri = "";
+			}
 
-    /**
-     * LOCK method handler
-     *
-     * @param  void
-     * @return void
-     */
-    function http_LOCK()
-    {
-        $options         = Array();
-        $options["path"] = $this->path;
-
-        if (isset($this->_SERVER['HTTP_DEPTH'])) {
-            $options["depth"] = $this->_SERVER["HTTP_DEPTH"];
-        } else {
-            $options["depth"] = "infinity";
-        }
-
-        if (isset($this->_SERVER["HTTP_TIMEOUT"])) {
-            $options["timeout"] = explode(",", $this->_SERVER["HTTP_TIMEOUT"]);
-        }
-
-        if (empty($this->_SERVER['CONTENT_LENGTH']) && !empty($this->_SERVER['HTTP_IF'])) {
-            // check if locking is possible
-            if (!$this->_check_lock_status($this->path)) {
-                $this->http_status("423 Locked");
-                return;
-            }
-
-            // refresh lock
-            $options["locktoken"] = substr($this->_SERVER['HTTP_IF'], 2, -2);
-            $options["update"]    = $options["locktoken"];
-
-            // setting defaults for required fields, LOCK() SHOULD overwrite these
-            $options['owner']     = "unknown";
-            $options['scope']     = "exclusive";
-            $options['type']      = "write";
-
-
-            $stat = $this->LOCK($options);
-        } else {
-            // extract lock request information from request XML payload
-            $lockinfo = new _parse_lockinfo("php://input");
-            if (!$lockinfo->success) {
-                $this->http_status("400 bad request");
-            }
-
-            // check if locking is possible
-            if (!$this->_check_lock_status($this->path, $lockinfo->lockscope === "shared")) {
-                $this->http_status("423 Locked");
-                return;
-            }
-
-            // new lock
-            $options["scope"]     = $lockinfo->lockscope;
-            $options["type"]      = $lockinfo->locktype;
-            // Todo: lockinfo::owner still contains D:href opening and closing tags, maybe they should be removed here with strip_tags
-            $options["owner"]     = $lockinfo->owner;
-            $options["locktoken"] = $this->_new_locktoken();
-
-            $stat = $this->LOCK($options);
-        }
-
-        if (is_bool($stat)) {
-            $http_stat = $stat ? "200 OK" : "423 Locked";
-        } else {
-            $http_stat = (string)$stat;
-        }
-        $this->http_status($http_stat);
-
-        if ($http_stat{0} == 2) { // 2xx states are ok
-            if ($options["timeout"]) {
-                // if multiple timeout values were given we take the first only
-                if (is_array($options["timeout"])) {
-                    reset($options["timeout"]);
-                    $options["timeout"] = current($options["timeout"]);
-                }
-                // if the timeout is numeric only we need to reformat it
-                if (is_numeric($options["timeout"])) {
-                    // more than a million is considered an absolute timestamp
-                    // less is more likely a relative value
-                    if ($options["timeout"]>1000000) {
-                        $timeout = "Second-".($options['timeout']-time());
-                    } else {
-                        $timeout = "Second-$options[timeout]";
-                    }
-                } else {
-                    // non-numeric values are passed on verbatim,
-                    // no error checking is performed here in this case
-                    // TODO: send "Infinite" on invalid timeout strings?
-                    $timeout = $options["timeout"];
-                }
-            } else {
-                $timeout = "Infinite";
-            }
-
-            header('Content-Type: text/xml; charset="utf-8"');
-            header("Lock-Token: <$options[locktoken]>");
-            echo "<?xml version=\"1.0\" encoding=\"utf-8\"?>\n";
-            echo "<D:prop xmlns:D=\"DAV:\">\n";
-            echo ' <'.($this->crrnd?'':'D:')."lockdiscovery>\n";
-            echo '  <'.($this->crrnd?'':'D:')."activelock>\n";
-            echo '   <'.($this->crrnd?'':'D:')."lockscope><D:$options[scope]/></".($this->crrnd?'':'D:')."lockscope>\n";
-            echo '   <'.($this->crrnd?'':'D:')."locktype><D:$options[type]/></".($this->crrnd?'':'D:')."locktype>\n";
-            echo '   <'.($this->crrnd?'':'D:')."depth>$options[depth]</".($this->crrnd?'':'D:')."depth>\n";
-            echo '   <'.($this->crrnd?'':'D:')."owner>$options[owner]</".($this->crrnd?'':'D:')."owner>\n";
-            echo '   <'.($this->crrnd?'':'D:')."timeout>$timeout</".($this->crrnd?'':'D:')."timeout>\n";
-            echo '   <'.($this->crrnd?'':'D:')."locktoken><D:href>$options[locktoken]</D:href></".($this->crrnd?'':'D:')."locktoken>\n";
-            echo '  </'.($this->crrnd?'':'D:')."activelock>\n";
-            echo ' </'.($this->crrnd?'':'D:')."lockdiscovery>\n";
-            echo '</'.($this->crrnd?'':'D:')."prop>\n\n";
-        }
-    }
-
-
-    // }}}
-
-    // {{{ http_UNLOCK()
+			// sanity check
+			if ($token[0] != "CHAR" || $token[1] != "(") {
+				return false;
+			}
 
-    /**
-     * UNLOCK method handler
-     *
-     * @param  void
-     * @return void
-     */
-    function http_UNLOCK()
-    {
-        $options         = Array();
-        $options["path"] = $this->path;
-
-        if (isset($this->_SERVER['HTTP_DEPTH'])) {
-            $options["depth"] = $this->_SERVER["HTTP_DEPTH"];
-        } else {
-            $options["depth"] = "infinity";
-        }
-
-        // strip surrounding <>
-        $options["token"] = substr(trim($this->_SERVER["HTTP_LOCK_TOKEN"]), 1, -1);
-
-        // call user method
-        $stat = $this->UNLOCK($options);
-
-        $this->http_status($stat);
-    }
-
-    // }}}
-
-    // {{{ http_ACL()
-
-	/**
-     * ACL method handler
-     *
-     * @param  void
-     * @return void
-     */
-    function http_ACL()
-    {
-        $options         = Array();
-        $options['path'] = $this->path;
-        $options['errors'] = array();
-
-        if (isset($this->_SERVER['HTTP_DEPTH'])) {
-            $options['depth'] = $this->_SERVER['HTTP_DEPTH'];
-        } else {
-            $options['depth'] = 'infinity';
-        }
-
-        // call user method
-        $status = $this->ACL($options);
+			$list  = array();
+			$level = 1;
+			$not   = "";
+			while ($level) {
+				$token = $this->_if_header_lexer($str, $pos);
+				if ($token[0] == "NOT") {
+					$not = "!";
+					continue;
+				}
+				switch ($token[0]) {
+				case "CHAR":
+					switch ($token[1]) {
+					case "(":
+						$level++;
+						break;
+					case ")":
+						$level--;
+						break;
+					default:
+						return false;
+					}
+					break;
 
-		// now we generate the reply header ...
-		$this->http_status($status);
-		$content = '';
+				case "URI":
+					$list[] = $not."<$token[1]>";
+					break;
 
-        if (is_array($options['errors']) && count($options['errors'])) {
-	        header('Content-Type: text/xml; charset="utf-8"');
-	        // ... and payload
-	        $content .= "<?xml version=\"1.0\" encoding=\"utf-8\"?>\n";
-	        $content .= "<D:error xmlns:D=\"DAV:\"> \n";
-	        foreach ($options['errors'] as $violation) {
-	        	$content .= '<'.($this->crrnd?'':'D:')."$violation/>\n";
-	        }
-	        $content .=  '</'.($this->crrnd?'':'D:')."error>\n";
-        }
-        if (!self::use_compression()) header("Content-Length: ".self::bytes($content));
-        if ($content) echo $options['content'];
-    }
-
-    // }}}
-
-    // }}}
-
-    // {{{ _copymove()
-
-    function _copymove($what)
-    {
-        $options         = Array();
-        $options["path"] = $this->path;
-
-        if (isset($this->_SERVER["HTTP_DEPTH"])) {
-            $options["depth"] = $this->_SERVER["HTTP_DEPTH"];
-        } else {
-            $options["depth"] = "infinity";
-        }
-
-        $http_header_host = preg_replace("/:80$/", "", $this->_SERVER["HTTP_HOST"]);
-
-        $url  = parse_url($this->_SERVER["HTTP_DESTINATION"]);
-        $path = urldecode($url["path"]);
-
-        if (isset($url["host"])) {
-            // TODO check url scheme, too
-            $http_host = $url["host"];
-            if (isset($url["port"]) && $url["port"] != 80)
-                $http_host.= ":".$url["port"];
-        } else {
-            // only path given, set host to self
-            $http_host = $http_header_host;
-        }
-
-        if ($http_host == $http_header_host &&
-            !strncmp($this->_SERVER["SCRIPT_NAME"], $path,
-                     strlen($this->_SERVER["SCRIPT_NAME"]))) {
-            $options["dest"] = substr($path, strlen($this->_SERVER["SCRIPT_NAME"]));
-            if (!$this->_check_lock_status($options["dest"])) {
-                $this->http_status("423 Locked");
-                return;
-            }
-
-        } else {
-            $options["dest_url"] = $this->_SERVER["HTTP_DESTINATION"];
-        }
-
-        // see RFC 2518 Sections 9.6, 8.8.4 and 8.9.3
-        if (isset($this->_SERVER["HTTP_OVERWRITE"])) {
-            $options["overwrite"] = $this->_SERVER["HTTP_OVERWRITE"] == "T";
-        } else {
-            $options["overwrite"] = true;
-        }
-
-        $stat = $this->$what($options);
-        $this->http_status($stat);
-    }
-
-    // }}}
-
-    // {{{ _allow()
+				case "ETAG_WEAK":
+					$list[] = $not."[W/'$token[1]']>";
+					break;
 
-    /**
-     * check for implemented HTTP methods
-     *
-     * @param  void
-     * @return array something
-     */
-    function _allow()
-    {
-        // OPTIONS is always there
-        $allow = array("OPTIONS" =>"OPTIONS");
-
-        // all other METHODS need both a http_method() wrapper
-        // and a method() implementation
-        // the base class supplies wrappers only
-        foreach (get_class_methods($this) as $method) {
-            if (!strncmp("http_", $method, 5)) {
-                $method = strtoupper(substr($method, 5));
-                if (method_exists($this, $method)) {
-                    $allow[$method] = $method;
-                }
-            }
-        }
-
-        // we can emulate a missing HEAD implemetation using GET
-        if (isset($allow["GET"]))
-            $allow["HEAD"] = "HEAD";
-
-        // no LOCK without checklok()
-        if (!method_exists($this, "checklock")) {
-            unset($allow["LOCK"]);
-            unset($allow["UNLOCK"]);
-        }
-
-        return $allow;
-    }
-
-    // }}}
+				case "ETAG_STRONG":
+					$list[] = $not."['$token[1]']>";
+					break;
 
-    /**
-     * helper for property element creation
-     *
-     * @param  string  XML namespace (optional)
-     * @param  string  property name
-     * @param  string  property value
-     * @praram boolen  property raw-flag
-     * @return array   property array
-     */
-    public static function mkprop()
-    {
-	    $args = func_get_args();
-	    switch (count($args)) {
-		    case 4:
-			    return array('ns'   => $args[0],
-				    'name' => $args[1],
-					'val'  => $args[2],
-					'raw'	=> true);
-		    case 3:
-			    return array('ns'   => $args[0],
-				    'name' => $args[1],
-					'val'  => $args[2]);
-		    default:
-			    return array('ns'   => 'DAV:',
-				    'name' => $args[0],
-					'val'  => $args[1]);
-	    }
-    }
+				default:
+					return false;
+				}
+				$not = "";
+			}
 
-    // {{{ _check_auth
+			if (@is_array($uris[$uri])) {
+				$uris[$uri] = array_merge($uris[$uri], $list);
+			} else {
+				$uris[$uri] = $list;
+			}
+		}
 
-    /**
-     * check authentication if check is implemented
-     *
-     * @param  void
-     * @return bool  true if authentication succeded or not necessary
-     */
-    function _check_auth()
-    {
-        if (method_exists($this, "checkAuth")) {
-            // PEAR style method name
-            return $this->checkAuth(@$this->_SERVER["AUTH_TYPE"],
-                                    @$this->_SERVER["PHP_AUTH_USER"],
-                                    @$this->_SERVER["PHP_AUTH_PW"]);
-        } else if (method_exists($this, "check_auth")) {
-            // old (pre 1.0) method name
-            return $this->check_auth(@$this->_SERVER["AUTH_TYPE"],
-                                     @$this->_SERVER["PHP_AUTH_USER"],
-                                     @$this->_SERVER["PHP_AUTH_PW"]);
-        } else {
-            // no method found -> no authentication required
-            return true;
-        }
-    }
-
-    // }}}
-
-    // {{{ UUID stuff
+		return $uris;
+	}
 
-    /**
-     * generate Unique Universal IDentifier for lock token
-     *
-     * @param  void
-     * @return string  a new UUID
-     */
-    public static function _new_uuid()
-    {
-        // use uuid extension from PECL if available
-        if (function_exists("uuid_create")) {
-            return uuid_create();
-        }
-
-        // fallback
-        $uuid = md5(microtime().getmypid());    // this should be random enough for now
-
-        // set variant and version fields for 'true' random uuid
-        $uuid{12} = "4";
-        $n = 8 + (ord($uuid{16}) & 3);
-        $hex = "0123456789abcdef";
-        $uuid{16} = $hex{$n};
-
-        // return formated uuid
-        return substr($uuid,  0, 8)."-"
-            .  substr($uuid,  8, 4)."-"
-            .  substr($uuid, 12, 4)."-"
-            .  substr($uuid, 16, 4)."-"
-            .  substr($uuid, 20);
-    }
+	/**
+	 * check if conditions from "If:" headers are meat
+	 *
+	 * the "If:" header is an extension to HTTP/1.1
+	 * defined in RFC 2518 section 9.4
+	 *
+	 * @param  void
+	 * @return void
+	 */
+	function _check_if_header_conditions()
+	{
+		if (isset($this->_SERVER["HTTP_IF"])) {
+			$this->_if_header_uris =
+				$this->_if_header_parser($this->_SERVER["HTTP_IF"]);
 
-    /**
-     * create a new opaque lock token as defined in RFC2518
-     *
-     * @param  void
-     * @return string  new RFC2518 opaque lock token
-     */
-    public static function _new_locktoken()
-    {
-        return "opaquelocktoken:".self::_new_uuid();
-    }
+			foreach ($this->_if_header_uris as $uri => $conditions) {
+				if ($uri == "") {
+					$uri = $this->uri;
+				}
+				// all must match
+				$state = true;
+				foreach ($conditions as $condition) {
+					// lock tokens may be free form (RFC2518 6.3)
+					// but if opaquelocktokens are used (RFC2518 6.4)
+					// we have to check the format (litmus tests this)
+					if (!strncmp($condition, "<opaquelocktoken:", strlen("<opaquelocktoken"))) {
+						if (!preg_match('/^<opaquelocktoken:[[:xdigit:]]{8}-[[:xdigit:]]{4}-[[:xdigit:]]{4}-[[:xdigit:]]{4}-[[:xdigit:]]{12}>$/', $condition)) {
+							$this->http_status("423 Locked");
+							return false;
+						}
+					}
+					if (!$this->_check_uri_condition($uri, $condition)) {
+						$this->http_status("412 Precondition failed");
+						$state = false;
+						break;
+					}
+				}
 
-    // }}}
+				// any match is ok
+				if ($state == true) {
+					return true;
+				}
+			}
+			return false;
+		}
+		return true;
+	}
 
-    // {{{ WebDAV If: header parsing
+	/**
+	 * Check a single URI condition parsed from an if-header
+	 *
+	 * Check a single URI condition parsed from an if-header
+	 *
+	 * @abstract
+	 * @param string $uri URI to check
+	 * @param string $condition Condition to check for this URI
+	 * @returns bool Condition check result
+	 */
+	function _check_uri_condition($uri, $condition)
+	{
+		unset($uri);	// not used, but required by function signature
+		// not really implemented here,
+		// implementations must override
 
-    /**
-     *
-     *
-     * @param  string  header string to parse
-     * @param  int     current parsing position
-     * @return array   next token (type and value)
-     */
-    function _if_header_lexer($string, &$pos)
-    {
-        // skip whitespace
-        while (ctype_space($string{$pos})) {
-            ++$pos;
-        }
-
-        // already at end of string?
-        if (strlen($string) <= $pos) {
-            return false;
-        }
-
-        // get next character
-        $c = $string{$pos++};
-
-        // now it depends on what we found
-        switch ($c) {
-        case "<":
-            // URIs are enclosed in <...>
-            $pos2 = strpos($string, ">", $pos);
-            $uri  = substr($string, $pos, $pos2 - $pos);
-            $pos  = $pos2 + 1;
-            return array("URI", $uri);
-
-        case "[":
-            //Etags are enclosed in [...]
-            if ($string{$pos} == "W") {
-                $type = "ETAG_WEAK";
-                $pos += 2;
-            } else {
-                $type = "ETAG_STRONG";
-            }
-            $pos2 = strpos($string, "]", $pos);
-            $etag = substr($string, $pos + 1, $pos2 - $pos - 2);
-            $pos  = $pos2 + 1;
-            return array($type, $etag);
-
-        case "N":
-            // "N" indicates negation
-            $pos += 2;
-            return array("NOT", "Not");
-
-        default:
-            // anything else is passed verbatim char by char
-            return array("CHAR", $c);
-        }
-    }
+		// a lock token can never be from the DAV: scheme
+		// litmus uses DAV:no-lock in some tests
+		if (!strncmp("<DAV:", $condition, 5)) {
+			return false;
+		}
 
-    /**
-     * parse If: header
-     *
-     * @param  string  header string
-     * @return array   URIs and their conditions
-     */
-    function _if_header_parser($str)
-    {
-        $pos  = 0;
-        $len  = strlen($str);
-        $uris = array();
-
-        // parser loop
-        while ($pos < $len) {
-            // get next token
-            $token = $this->_if_header_lexer($str, $pos);
-
-            // check for URI
-            if ($token[0] == "URI") {
-                $uri   = $token[1]; // remember URI
-                $token = $this->_if_header_lexer($str, $pos); // get next token
-            } else {
-                $uri = "";
-            }
-
-            // sanity check
-            if ($token[0] != "CHAR" || $token[1] != "(") {
-                return false;
-            }
-
-            $list  = array();
-            $level = 1;
-            $not   = "";
-            while ($level) {
-                $token = $this->_if_header_lexer($str, $pos);
-                if ($token[0] == "NOT") {
-                    $not = "!";
-                    continue;
-                }
-                switch ($token[0]) {
-                case "CHAR":
-                    switch ($token[1]) {
-                    case "(":
-                        $level++;
-                        break;
-                    case ")":
-                        $level--;
-                        break;
-                    default:
-                        return false;
-                    }
-                    break;
-
-                case "URI":
-                    $list[] = $not."<$token[1]>";
-                    break;
-
-                case "ETAG_WEAK":
-                    $list[] = $not."[W/'$token[1]']>";
-                    break;
-
-                case "ETAG_STRONG":
-                    $list[] = $not."['$token[1]']>";
-                    break;
-
-                default:
-                    return false;
-                }
-                $not = "";
-            }
-
-            if (@is_array($uris[$uri])) {
-                $uris[$uri] = array_merge($uris[$uri], $list);
-            } else {
-                $uris[$uri] = $list;
-            }
-        }
-
-        return $uris;
-    }
+		return true;
+	}
 
-    /**
-     * check if conditions from "If:" headers are meat
-     *
-     * the "If:" header is an extension to HTTP/1.1
-     * defined in RFC 2518 section 9.4
-     *
-     * @param  void
-     * @return void
-     */
-    function _check_if_header_conditions()
-    {
-        if (isset($this->_SERVER["HTTP_IF"])) {
-            $this->_if_header_uris =
-                $this->_if_header_parser($this->_SERVER["HTTP_IF"]);
-
-            foreach ($this->_if_header_uris as $uri => $conditions) {
-                if ($uri == "") {
-                    $uri = $this->uri;
-                }
-                // all must match
-                $state = true;
-                foreach ($conditions as $condition) {
-                    // lock tokens may be free form (RFC2518 6.3)
-                    // but if opaquelocktokens are used (RFC2518 6.4)
-                    // we have to check the format (litmus tests this)
-                    if (!strncmp($condition, "<opaquelocktoken:", strlen("<opaquelocktoken"))) {
-                        if (!preg_match('/^<opaquelocktoken:[[:xdigit:]]{8}-[[:xdigit:]]{4}-[[:xdigit:]]{4}-[[:xdigit:]]{4}-[[:xdigit:]]{12}>$/', $condition)) {
-                            $this->http_status("423 Locked");
-                            return false;
-                        }
-                    }
-                    if (!$this->_check_uri_condition($uri, $condition)) {
-                        $this->http_status("412 Precondition failed");
-                        $state = false;
-                        break;
-                    }
-                }
-
-                // any match is ok
-                if ($state == true) {
-                    return true;
-                }
-            }
-            return false;
-        }
-        return true;
-    }
 
-    /**
-     * Check a single URI condition parsed from an if-header
-     *
-     * Check a single URI condition parsed from an if-header
-     *
-     * @abstract
-     * @param string $uri URI to check
-     * @param string $condition Condition to check for this URI
-     * @returns bool Condition check result
-     */
-    function _check_uri_condition($uri, $condition)
-    {
-		unset($uri);	// not used, but required by function signature
-        // not really implemented here,
-        // implementations must override
+	/**
+	 *
+	 *
+	 * @param  string  path of resource to check
+	 * @param  bool    exclusive lock?
+	 */
+	function _check_lock_status($path, $exclusive_only = false)
+	{
+		// FIXME depth -> ignored for now
+		if (method_exists($this, "checkLock")) {
+			// is locked?
+			$lock = $this->checkLock($path);
+
+			// ... and lock is not owned?
+			if (is_array($lock) && count($lock)) {
+				// FIXME doesn't check uri restrictions yet
+				if (!isset($this->_SERVER["HTTP_IF"]) || !strstr($this->_SERVER["HTTP_IF"], $lock["token"])) {
+					if (!$exclusive_only || ($lock["scope"] !== "shared"))
+						return false;
+				}
+			}
+		}
+		return true;
+	}
 
-        // a lock token can never be from the DAV: scheme
-        // litmus uses DAV:no-lock in some tests
-        if (!strncmp("<DAV:", $condition, 5)) {
-            return false;
-        }
 
-        return true;
-    }
+	// }}}
 
 
-    /**
-     *
-     *
-     * @param  string  path of resource to check
-     * @param  bool    exclusive lock?
-     */
-    function _check_lock_status($path, $exclusive_only = false)
-    {
-        // FIXME depth -> ignored for now
-        if (method_exists($this, "checkLock")) {
-            // is locked?
-            $lock = $this->checkLock($path);
-
-            // ... and lock is not owned?
-            if (is_array($lock) && count($lock)) {
-                // FIXME doesn't check uri restrictions yet
-                if (!isset($this->_SERVER["HTTP_IF"]) || !strstr($this->_SERVER["HTTP_IF"], $lock["token"])) {
-                    if (!$exclusive_only || ($lock["scope"] !== "shared"))
-                        return false;
-                }
-            }
-        }
-        return true;
-    }
-
-
-    // }}}
+	/**
+	 * Generate lockdiscovery reply from checklock() result
+	 *
+	 * @param   string  resource path to check
+	 * @return  string  lockdiscovery response
+	 */
+	function lockdiscovery($path)
+	{
+		// no lock support without checklock() method
+		if (!method_exists($this, "checklock")) {
+			return "";
+		}
 
+		// collect response here
+		$activelocks = "";
+
+		// get checklock() reply
+		$lock = $this->checklock($path);
+
+		// generate <activelock> block for returned data
+		if (is_array($lock) && count($lock)) {
+			// check for 'timeout' or 'expires'
+			if (!empty($lock["expires"])) {
+				$timeout = "Second-".($lock["expires"] - time());
+			} else if (!empty($lock["timeout"])) {
+				$timeout = "Second-$lock[timeout]";
+			} else {
+				$timeout = "Infinite";
+			}
 
-    /**
-     * Generate lockdiscovery reply from checklock() result
-     *
-     * @param   string  resource path to check
-     * @return  string  lockdiscovery response
-     */
-    function lockdiscovery($path)
-    {
-        // no lock support without checklock() method
-        if (!method_exists($this, "checklock")) {
-            return "";
-        }
-
-        // collect response here
-        $activelocks = "";
-
-        // get checklock() reply
-        $lock = $this->checklock($path);
-
-        // generate <activelock> block for returned data
-        if (is_array($lock) && count($lock)) {
-            // check for 'timeout' or 'expires'
-            if (!empty($lock["expires"])) {
-                $timeout = "Second-".($lock["expires"] - time());
-            } else if (!empty($lock["timeout"])) {
-                $timeout = "Second-$lock[timeout]";
-            } else {
-                $timeout = "Infinite";
-            }
-
-            // genreate response block
-            if ($this->crrnd)
-            {
-	            $activelocks.= "
+			// genreate response block
+			if ($this->crrnd)
+			{
+				$activelocks.= "
 		            <activelock>
 		            <lockscope><$lock[scope]/></lockscope>
 		            <locktype><$lock[type]/></locktype>
@@ -2648,10 +2648,10 @@ 
 		            <locktoken><href>$lock[token]</href></locktoken>
 		            </activelock>
 		            ";
-            }
-            else
-            {
-	            $activelocks.= "
+			}
+			else
+			{
+				$activelocks.= "
 		            <D:activelock>
 		            <D:lockscope><D:$lock[scope]/></D:lockscope>
 		            <D:locktype><D:$lock[type]/></D:locktype>
@@ -2661,47 +2661,47 @@ 
 		            <D:locktoken><D:href>$lock[token]</D:href></D:locktoken>
 		            </D:activelock>
 		            ";
-            }
-        }
+			}
+		}
 
-        // return generated response
-        //error_log(__METHOD__."\n".print_r($activelocks,true));
+		// return generated response
+		//error_log(__METHOD__."\n".print_r($activelocks,true));
 		return $activelocks;
-    }
+	}
 
-    /**
-     * set HTTP return status and mirror it in a private header
-     *
-     * @param  string  status code and message
-     * @return void
-     */
-    function http_status($status)
-    {
-        // simplified success case
-        if ($status === true) {
-            $status = "200 OK";
-        }
-
-        // remember status
-        $this->_http_status = $status;
-
-        // generate HTTP status response
-        header("HTTP/1.1 $status");
-        header("X-WebDAV-Status: $status", true);
-    }
+	/**
+	 * set HTTP return status and mirror it in a private header
+	 *
+	 * @param  string  status code and message
+	 * @return void
+	 */
+	function http_status($status)
+	{
+		// simplified success case
+		if ($status === true) {
+			$status = "200 OK";
+		}
 
-    /**
-     * private minimalistic version of PHP urlencode()
-     *
-     * only blanks, percent and XML special chars must be encoded here
-     * full urlencode() encoding confuses some clients ...
-     *
-     * @param  string  URL to encode
-     * @return string  encoded URL
-     * @todo check if other not explicitly named user-agents are happy with full url-encoding too and we can make it the default
-     */
-    public static function _urlencode($url)
-    {
+		// remember status
+		$this->_http_status = $status;
+
+		// generate HTTP status response
+		header("HTTP/1.1 $status");
+		header("X-WebDAV-Status: $status", true);
+	}
+
+	/**
+	 * private minimalistic version of PHP urlencode()
+	 *
+	 * only blanks, percent and XML special chars must be encoded here
+	 * full urlencode() encoding confuses some clients ...
+	 *
+	 * @param  string  URL to encode
+	 * @return string  encoded URL
+	 * @todo check if other not explicitly named user-agents are happy with full url-encoding too and we can make it the default
+	 */
+	public static function _urlencode($url)
+	{
 		// cadaver (and probably all neon using agents) need a more complete url encoding
 		// otherwise special chars like "$,()'" in filenames do NOT work
 		if (strpos($_SERVER['HTTP_USER_AGENT'],'neon') !== false ||
@@ -2719,31 +2719,31 @@ 
 		}
 		//error_log( __METHOD__."\n" .print_r($url,true));
 		return strtr($url, array(' '	=>	'%20',
-                                 '%'	=>	'%25',
-                                 '&'	=>	'%26',
-                                 '<'	=>	'%3C',
-                                 '>'	=>	'%3E',
-                                 '+'	=>	'%2B',
-                                 ));
-    }
+								 '%'	=>	'%25',
+								 '&'	=>	'%26',
+								 '<'	=>	'%3C',
+								 '>'	=>	'%3E',
+								 '+'	=>	'%2B',
+								 ));
+	}
 
-    /**
-     * private version of PHP urldecode
-     *
-     * not really needed but added for completenes
-     *
-     * @param  string  URL to decode
-     * @return string  decoded URL
-     */
-    public static function _urldecode($path)
-    {
-        return rawurldecode($path);
-    }
+	/**
+	 * private version of PHP urldecode
+	 *
+	 * not really needed but added for completenes
+	 *
+	 * @param  string  URL to decode
+	 * @return string  decoded URL
+	 */
+	public static function _urldecode($path)
+	{
+		return rawurldecode($path);
+	}
 
-    /**
-     * Encode a hierarchical properties like:
-     *
- 	 * <D:supported-report-set>
+	/**
+	 * Encode a hierarchical properties like:
+	 *
+	 * <D:supported-report-set>
 	 *    <supported-report>
 	 *       <report>
 	 *          <addressbook-query xmlns='urn:ietf:params:xml:ns:carddav'/>
@@ -2755,60 +2755,60 @@ 
 	 *       </report>
 	 *    </supported-report>
 	 * </D:supported-report-set>
-     *
-     * @param array $props
-     * @param string $ns
-     * @param strin $ns_defs
-     * @param array $ns_hash
-     * @return string
-     */
+	 *
+	 * @param array $props
+	 * @param string $ns
+	 * @param strin $ns_defs
+	 * @param array $ns_hash
+	 * @return string
+	 */
 	function _hierarchical_prop_encode(array $props, $ns, &$ns_defs, array &$ns_hash)
-    {
-    	$ret = '';
+	{
+		$ret = '';
 
-    	//error_log(__METHOD__.'('.array2string($props).')');
-    	if (isset($props['name'])) $props = array($props);
+		//error_log(__METHOD__.'('.array2string($props).')');
+		if (isset($props['name'])) $props = array($props);
 
-    	foreach($props as $prop)
+		foreach($props as $prop)
 		{
-	    	if (!isset($ns_hash[$prop['ns']])) // unknown namespace
-	    	{
-		    	// register namespace
-		    	$ns_name = 'ns'.(count($ns_hash) + 1);
-		    	$ns_hash[$prop['ns']] = $ns_name;
-		    	$ns_defs .= ' xmlns:'.$ns_name.'="'.$prop['ns'].'"';
-	    	}
-	    	if (is_array($prop['val']))
-	    	{
-	    		$subprop = $prop['val'];
-		    	if (isset($subprop['ns']) || isset($subprop[0]['ns']))
-		    	{
-			    	$ret .= '<'.($prop['ns'] == $ns ? ($this->crrnd ? '' : $ns_hash[$ns].':') : $ns_hash[$prop['ns']].':').$prop['name'].
+			if (!isset($ns_hash[$prop['ns']])) // unknown namespace
+			{
+				// register namespace
+				$ns_name = 'ns'.(count($ns_hash) + 1);
+				$ns_hash[$prop['ns']] = $ns_name;
+				$ns_defs .= ' xmlns:'.$ns_name.'="'.$prop['ns'].'"';
+			}
+			if (is_array($prop['val']))
+			{
+				$subprop = $prop['val'];
+				if (isset($subprop['ns']) || isset($subprop[0]['ns']))
+				{
+					$ret .= '<'.($prop['ns'] == $ns ? ($this->crrnd ? '' : $ns_hash[$ns].':') : $ns_hash[$prop['ns']].':').$prop['name'].
 						(empty($prop['val']) ? '/>' : '>'.$this->_hierarchical_prop_encode($prop['val'], $prop['ns'], $ns_defs, $ns_hash).
 						'</'.($prop['ns'] == $ns ? ($this->crrnd ? '' : $ns_hash[$ns].':') : ($this->crrnd ? '' : $ns_hash[$prop['ns']].':')).$prop['name'].'>');
-		    	}
-		    	else // val contains only attributes, no value
-		    	{
-			    	$vals = '';
+				}
+				else // val contains only attributes, no value
+				{
+					$vals = '';
 
-			    	foreach($subprop as $attr => $val)
+					foreach($subprop as $attr => $val)
 					{
-				    	$vals .= ' '.$attr.'="'.htmlspecialchars($val, ENT_NOQUOTES, 'utf-8').'"';
+						$vals .= ' '.$attr.'="'.htmlspecialchars($val, ENT_NOQUOTES, 'utf-8').'"';
 					}
 
-		             $ret .= '<'.($prop['ns'] == $ns ? ($this->crrnd ? '' : $ns_hash[$ns].':') : $ns_hash[$prop['ns']].':').$prop['name'].
-				    	$vals .'/>';
-		    	}
-	    	}
-	    	else
-	    	{
-		    	if (empty($prop['val']))
-		    	{
-			    	$val = '';
-		    	}
-		    	else
-		    	{
-			    	if(isset($prop['raw']))
+					 $ret .= '<'.($prop['ns'] == $ns ? ($this->crrnd ? '' : $ns_hash[$ns].':') : $ns_hash[$prop['ns']].':').$prop['name'].
+						$vals .'/>';
+				}
+			}
+			else
+			{
+				if (empty($prop['val']))
+				{
+					$val = '';
+				}
+				else
+				{
+					if(isset($prop['raw']))
 					{
 						$val = $this->_prop_encode('<![CDATA['.$prop['val'].']]>');
 					} else {
@@ -2819,32 +2819,32 @@ 
 							$val = $this->_urlencode($val);
 						}
 					}
-		    	}
+				}
 
-		    	$ret .= '<'.($prop['ns'] == $ns ? ($this->crrnd ? '' : $ns_hash[$ns].':') : $ns_hash[$prop['ns']].':').$prop['name'].
-			    	(empty($prop['val']) ? ' />' : '>'.$val.'</'.
-			    	($prop['ns'] == $ns ? ($this->crrnd ? '' : $ns_hash[$ns].':') : ($this->crrnd ? '' : $ns_hash[$prop['ns']].':')).$prop['name'].'>');
-	    	}
+				$ret .= '<'.($prop['ns'] == $ns ? ($this->crrnd ? '' : $ns_hash[$ns].':') : $ns_hash[$prop['ns']].':').$prop['name'].
+					(empty($prop['val']) ? ' />' : '>'.$val.'</'.
+					($prop['ns'] == $ns ? ($this->crrnd ? '' : $ns_hash[$ns].':') : ($this->crrnd ? '' : $ns_hash[$prop['ns']].':')).$prop['name'].'>');
+			}
 		}
 
-    	//error_log(__METHOD__.'('.array2string($props).") crrnd=$this->crrnd returning ".array2string($ret));
-    	return $ret;
-    }
+		//error_log(__METHOD__.'('.array2string($props).") crrnd=$this->crrnd returning ".array2string($ret));
+		return $ret;
+	}
 
-    /**
-     * UTF-8 encode property values if not already done so
-     *
-     * @param  string  text to encode
-     * @return string  utf-8 encoded text
-     */
-    function _prop_encode($text)
-    {
+	/**
+	 * UTF-8 encode property values if not already done so
+	 *
+	 * @param  string  text to encode
+	 * @return string  utf-8 encoded text
+	 */
+	function _prop_encode($text)
+	{
 		//error_log( __METHOD__."\n" .print_r($text,true));
 		//error_log("prop-encode:" . print_r($this->_prop_encoding,true));
 
 		switch (strtolower($this->_prop_encoding)) {
 			case "utf-8":
-       			//error_log( __METHOD__."allready encoded\n" .print_r($text,true));
+	   			//error_log( __METHOD__."allready encoded\n" .print_r($text,true));
 				return $text;
 			case "iso-8859-1":
 			case "iso-8859-15":
@@ -2852,75 +2852,75 @@ 
 			default:
 				error_log( __METHOD__."utf8 encode\n" .print_r(utf8_encode($text),true));
 				return utf8_encode($text);
-        }
-    }
+		}
+	}
 
-    /**
-     * Slashify - make sure path ends in a slash
-     *
-     * @param   string directory path
-     * @returns string directory path wiht trailing slash
-     */
-    public static function _slashify($path)
-    {
+	/**
+	 * Slashify - make sure path ends in a slash
+	 *
+	 * @param   string directory path
+	 * @returns string directory path wiht trailing slash
+	 */
+	public static function _slashify($path)
+	{
 		//error_log(__METHOD__." called with $path");
 		if ($path[self::bytes($path)-1] != '/') {
 			//error_log(__METHOD__." added slash at the end of path");
 			$path = $path."/";
 		}
 		return $path;
-    }
+	}
 
-    /**
-     * Unslashify - make sure path doesn't in a slash
-     *
-     * @param   string directory path
-     * @returns string directory path wihtout trailing slash
-     */
-    public static function _unslashify($path)
-    {
-        //error_log(__METHOD__." called with $path");
-        if ($path[self::bytes($path)-1] == '/') {
-            $path = substr($path, 0, -1);
+	/**
+	 * Unslashify - make sure path doesn't in a slash
+	 *
+	 * @param   string directory path
+	 * @returns string directory path wihtout trailing slash
+	 */
+	public static function _unslashify($path)
+	{
+		//error_log(__METHOD__." called with $path");
+		if ($path[self::bytes($path)-1] == '/') {
+			$path = substr($path, 0, -1);
 			//error_log(__METHOD__." removed slash at the end of path");
-        }
-        return $path;
-    }
+		}
+		return $path;
+	}
 
-    /**
-     * Merge two paths, make sure there is exactly one slash between them
-     *
-     * @param  string  parent path
-     * @param  string  child path
-     * @return string  merged path
-     */
-    public static function _mergePaths($parent, $child)
-    {
-        //error_log("merge called :\n$parent \n$child\n" . function_backtrace());
-        //error_log("merge :\n".print_r($this->_mergePaths($this->_SERVER["SCRIPT_NAME"], $this->path)true));
-        if ($child{0} == '/') {
-            return self::_unslashify($parent).$child;
-        } else {
-            return self::_slashify($parent).$child;
-        }
-    }
+	/**
+	 * Merge two paths, make sure there is exactly one slash between them
+	 *
+	 * @param  string  parent path
+	 * @param  string  child path
+	 * @return string  merged path
+	 */
+	public static function _mergePaths($parent, $child)
+	{
+		//error_log("merge called :\n$parent \n$child\n" . function_backtrace());
+		//error_log("merge :\n".print_r($this->_mergePaths($this->_SERVER["SCRIPT_NAME"], $this->path)true));
+		if ($child{0} == '/') {
+			return self::_unslashify($parent).$child;
+		} else {
+			return self::_slashify($parent).$child;
+		}
+	}
 
-    /**
-     * mbstring.func_overload save strlen version: counting the bytes not the chars
-     *
-     * @param string $str
-     * @return int
-     */
-    public static function bytes($str)
-    {
-    	static $func_overload=null;
-
-    	if (is_null($func_overload))
-    	{
-    		$func_overload = @extension_loaded('mbstring') ? ini_get('mbstring.func_overload') : 0;
-    	}
-    	return $func_overload & 2 ? mb_strlen($str,'ascii') : strlen($str);
-    }
+	/**
+	 * mbstring.func_overload save strlen version: counting the bytes not the chars
+	 *
+	 * @param string $str
+	 * @return int
+	 */
+	public static function bytes($str)
+	{
+		static $func_overload=null;
+
+		if (is_null($func_overload))
+		{
+			$func_overload = @extension_loaded('mbstring') ? ini_get('mbstring.func_overload') : 0;
+		}
+		return $func_overload & 2 ? mb_strlen($str,'ascii') : strlen($str);
+	}
 }
 
 /*

Switch Indentation +179 added lines, -179 removed lines

@@ -816,34 +816,34 @@ 
 	            	// this can happen if we have allprop and prop in one propfind:
 	            	// <allprop /><prop><blah /></prop>, eg. blah is not automatic returned by allprop
 	                switch(is_array($props) ? $props[0] : $props) {
-	                case "all":
-	                    // nothing to remove
-	                    break;
-
-	                case "names":
-	                    // only the names of all existing properties were requested
-	                    // so we remove all values
-	                    unset($prop["val"]);
-	                    break;
-
-	                default:
-	                    $found = false;
-
-	                    // search property name in requested properties
-	                    foreach ((array)$props as $reqprop) {
-	                        if (   $reqprop["name"]  == $prop["name"]
-	                               && @$reqprop["xmlns"] == $prop["ns"]) {
-	                            $found = true;
-	                            break;
-	                        }
-	                    }
-
-	                    // unset property and continue with next one if not found/requested
-	                    if (!$found) {
-	                        $prop="";
-	                        continue(2);
-	                    }
-	                    break;
+	                	case "all":
+	                    	// nothing to remove
+	                    	break;
+
+	                	case "names":
+	                    	// only the names of all existing properties were requested
+	                    	// so we remove all values
+	                    	unset($prop["val"]);
+	                    	break;
+
+	                	default:
+	                    	$found = false;
+
+	                    	// search property name in requested properties
+	                    	foreach ((array)$props as $reqprop) {
+	                        	if (   $reqprop["name"]  == $prop["name"]
+	                               	&& @$reqprop["xmlns"] == $prop["ns"]) {
+	                            	$found = true;
+	                            	break;
+	                        	}
+	                    	}
+
+	                    	// unset property and continue with next one if not found/requested
+	                    	if (!$found) {
+	                        	$prop="";
+	                        	continue(2);
+	                    	}
+	                    	break;
 	                }
 
 	                // namespace handling
@@ -964,49 +964,49 @@ 
                     } else if ($prop["ns"] == "DAV:") {
                         // some WebDAV properties need special treatment
                         switch ($prop["name"]) {
-                        case "creationdate":
-                            echo '     <'.($this->crrnd?'':'D:')."creationdate ns0:dt=\"dateTime.tz\">"
-                                . gmdate("Y-m-d\\TH:i:s\\Z", $prop['val'])
-                                . '</'.($this->crrnd?'':'D:')."creationdate>\n";
-                            break;
-                        case "getlastmodified":
-                            echo '     <'.($this->crrnd?'':'D:')."getlastmodified ns0:dt=\"dateTime.rfc1123\">"
-                                . gmdate("D, d M Y H:i:s ", $prop['val'])
-                                . "GMT</".($this->crrnd?'':'D:')."getlastmodified>\n";
-                            break;
-                        case "supportedlock":
-                            echo '     <'.($this->crrnd?'':'D:')."supportedlock>$prop[val]</".($this->crrnd?'':'D:')."supportedlock>\n";
-                            break;
-                        case "lockdiscovery":
-                            echo '     <'.($this->crrnd?'':'D:')."lockdiscovery>\n";
-                            echo $prop["val"];
-                            echo '     </'.($this->crrnd?'':'D:')."lockdiscovery>\n";
-                            break;
-                        // the following are non-standard Microsoft extensions to the DAV namespace
-                        case "lastaccessed":
-                            echo '     <'.($this->crrnd?'':'D:')."lastaccessed ns0:dt=\"dateTime.rfc1123\">"
-                                . gmdate("D, d M Y H:i:s ", $prop['val'])
-                                . 'GMT</'.($this->crrnd?'':'D:')."lastaccessed>\n";
-                            break;
-                        case "ishidden":
-                            echo '     <'.($this->crrnd?'':'D:')."ishidden>"
-                                . is_string($prop['val']) ? $prop['val'] : ($prop['val'] ? 'true' : 'false')
-                                . '</'.($this->crrnd?'':'D:')."</D:ishidden>\n";
-                            break;
-                        default:
-                        	$ns_defs = '';
-                            if (is_array($prop['val']))
-                            {
-                            	$hns_hash = $ns_hash;
-                            	$val = $this->_hierarchical_prop_encode($prop['val'], 'DAV:', $ns_defs, $hns_hash);
-                            } elseif (isset($prop['raw'])) {
-                            	$val = $this->_prop_encode('<![CDATA['.$prop['val'].']]>');
-                            } else {
-	                    		$val = $this->_prop_encode(htmlspecialchars($prop['val'], ENT_NOQUOTES, 'utf-8'));
-                            }
-	                        echo '     <'.($this->crrnd?'':'D:')."$prop[name]$ns_defs>$val".
-	                        	'</'.($this->crrnd?'':'D:')."$prop[name]>\n";
-                            break;
+                        	case "creationdate":
+                            	echo '     <'.($this->crrnd?'':'D:')."creationdate ns0:dt=\"dateTime.tz\">"
+                                	. gmdate("Y-m-d\\TH:i:s\\Z", $prop['val'])
+                                	. '</'.($this->crrnd?'':'D:')."creationdate>\n";
+                            	break;
+                        	case "getlastmodified":
+                            	echo '     <'.($this->crrnd?'':'D:')."getlastmodified ns0:dt=\"dateTime.rfc1123\">"
+                                	. gmdate("D, d M Y H:i:s ", $prop['val'])
+                                	. "GMT</".($this->crrnd?'':'D:')."getlastmodified>\n";
+                            	break;
+                        	case "supportedlock":
+                            	echo '     <'.($this->crrnd?'':'D:')."supportedlock>$prop[val]</".($this->crrnd?'':'D:')."supportedlock>\n";
+                            	break;
+                        	case "lockdiscovery":
+                            	echo '     <'.($this->crrnd?'':'D:')."lockdiscovery>\n";
+                            	echo $prop["val"];
+                            	echo '     </'.($this->crrnd?'':'D:')."lockdiscovery>\n";
+                            	break;
+                        	// the following are non-standard Microsoft extensions to the DAV namespace
+                        	case "lastaccessed":
+                            	echo '     <'.($this->crrnd?'':'D:')."lastaccessed ns0:dt=\"dateTime.rfc1123\">"
+                                	. gmdate("D, d M Y H:i:s ", $prop['val'])
+                                	. 'GMT</'.($this->crrnd?'':'D:')."lastaccessed>\n";
+                            	break;
+                        	case "ishidden":
+                            	echo '     <'.($this->crrnd?'':'D:')."ishidden>"
+                                	. is_string($prop['val']) ? $prop['val'] : ($prop['val'] ? 'true' : 'false')
+                                	. '</'.($this->crrnd?'':'D:')."</D:ishidden>\n";
+                            	break;
+                        	default:
+                        		$ns_defs = '';
+                            	if (is_array($prop['val']))
+                            	{
+                            		$hns_hash = $ns_hash;
+                            		$val = $this->_hierarchical_prop_encode($prop['val'], 'DAV:', $ns_defs, $hns_hash);
+                            	} elseif (isset($prop['raw'])) {
+                            		$val = $this->_prop_encode('<![CDATA['.$prop['val'].']]>');
+                            	} else {
+	                    			$val = $this->_prop_encode(htmlspecialchars($prop['val'], ENT_NOQUOTES, 'utf-8'));
+                            	}
+	                        	echo '     <'.($this->crrnd?'':'D:')."$prop[name]$ns_defs>$val".
+	                        		'</'.($this->crrnd?'':'D:')."$prop[name]>\n";
+                            	break;
                         }
                     } else {
                         // allow multiple values and attributes, required eg. for caldav:supported-calendar-component-set
@@ -1761,9 +1761,9 @@ 
             foreach ($this->_SERVER as $key => $val) {
                 if (strncmp($key, "HTTP_CONTENT", 11)) continue;
                 switch ($key) {
-                case 'HTTP_CONTENT_ENCODING': // RFC 2616 14.11
-		        	switch($this->_SERVER['HTTP_CONTENT_ENCODING'])
-		        	{
+                	case 'HTTP_CONTENT_ENCODING': // RFC 2616 14.11
+		        		switch($this->_SERVER['HTTP_CONTENT_ENCODING'])
+		        		{
 		        		case 'gzip':
 		        		case 'deflate':	//zlib
 		        			if (extension_loaded('zlib')) break;
@@ -1772,67 +1772,67 @@ 
 					        $this->http_status('415 Unsupported Media Type');
 					        echo "The service does not support '$val' content encoding";
 					        return;
-		        	}
+		        		}
 		        	break;
 
-                case 'HTTP_CONTENT_LANGUAGE': // RFC 2616 14.12
-                    // we assume it is not critical if this one is ignored
-                    // in the actual PUT implementation ...
-                    $options["content_language"] = $val;
-                    break;
+                	case 'HTTP_CONTENT_LANGUAGE': // RFC 2616 14.12
+                    	// we assume it is not critical if this one is ignored
+                    	// in the actual PUT implementation ...
+                    	$options["content_language"] = $val;
+                    	break;
 
-                case 'HTTP_CONTENT_LENGTH':
-                    // defined on IIS and has the same value as CONTENT_LENGTH
-                    break;
+                	case 'HTTP_CONTENT_LENGTH':
+                    	// defined on IIS and has the same value as CONTENT_LENGTH
+                    	break;
 
-                case 'HTTP_CONTENT_LOCATION': // RFC 2616 14.14
-                    /* The meaning of the Content-Location header in PUT
+                	case 'HTTP_CONTENT_LOCATION': // RFC 2616 14.14
+                    	/* The meaning of the Content-Location header in PUT
                      or POST requests is undefined; servers are free
                      to ignore it in those cases. */
-                    break;
-
-                case 'HTTP_CONTENT_RANGE':    // RFC 2616 14.16
-                    // single byte range requests are supported
-                    // the header format is also specified in RFC 2616 14.16
-                    // TODO we have to ensure that implementations support this or send 501 instead
-					$matches = null;
-                    if (!preg_match('@bytes\s+(\d+)-(\d+)/((\d+)|\*)@', $val, $matches)) {
-                        $this->http_status("400 bad request");
-                        echo "The service does only support single byte ranges";
-                        return;
-                    }
-
-                    $range = array("start" => $matches[1], "end" => $matches[2]);
-                    if (is_numeric($matches[3])) {
-                        $range["total_length"] = $matches[3];
-                    }
-
-                    if (!isset($options['ranges'])) {
-                        $options['ranges'] = array();
-                    }
-
-                    $options["ranges"][] = $range;
-
-                    // TODO make sure the implementation supports partial PUT
-                    // this has to be done in advance to avoid data being overwritten
-                    // on implementations that do not support this ...
-                    break;
-
-                case 'HTTP_CONTENT_TYPE':
-                    // defined on IIS and has the same value as CONTENT_TYPE
-                    break;
-
-                case 'HTTP_CONTENT_MD5':      // RFC 2616 14.15
-                    // TODO: maybe we can just pretend here?
-                    $this->http_status("501 not implemented");
-                    echo "The service does not support content MD5 checksum verification";
-                    return;
-
-                default:
-                    // any other unknown Content-* headers
-                    $this->http_status("501 not implemented");
-                    echo "The service does not support '$key'";
-                    return;
+                    	break;
+
+                	case 'HTTP_CONTENT_RANGE':    // RFC 2616 14.16
+                    	// single byte range requests are supported
+                    	// the header format is also specified in RFC 2616 14.16
+                    	// TODO we have to ensure that implementations support this or send 501 instead
+						$matches = null;
+                    	if (!preg_match('@bytes\s+(\d+)-(\d+)/((\d+)|\*)@', $val, $matches)) {
+                        	$this->http_status("400 bad request");
+                        	echo "The service does only support single byte ranges";
+                        	return;
+                    	}
+
+                    	$range = array("start" => $matches[1], "end" => $matches[2]);
+                    	if (is_numeric($matches[3])) {
+                        	$range["total_length"] = $matches[3];
+                    	}
+
+                    	if (!isset($options['ranges'])) {
+                        	$options['ranges'] = array();
+                    	}
+
+                    	$options["ranges"][] = $range;
+
+                    	// TODO make sure the implementation supports partial PUT
+                    	// this has to be done in advance to avoid data being overwritten
+                    	// on implementations that do not support this ...
+                    	break;
+
+                	case 'HTTP_CONTENT_TYPE':
+                    	// defined on IIS and has the same value as CONTENT_TYPE
+                    	break;
+
+                	case 'HTTP_CONTENT_MD5':      // RFC 2616 14.15
+                    	// TODO: maybe we can just pretend here?
+                    	$this->http_status("501 not implemented");
+                    	echo "The service does not support content MD5 checksum verification";
+                    	return;
+
+                	default:
+                    	// any other unknown Content-* headers
+                    	$this->http_status("501 not implemented");
+                    	echo "The service does not support '$key'";
+                    	return;
                 }
             }
 
@@ -2390,34 +2390,34 @@ 
 
         // now it depends on what we found
         switch ($c) {
-        case "<":
-            // URIs are enclosed in <...>
-            $pos2 = strpos($string, ">", $pos);
-            $uri  = substr($string, $pos, $pos2 - $pos);
-            $pos  = $pos2 + 1;
-            return array("URI", $uri);
-
-        case "[":
-            //Etags are enclosed in [...]
-            if ($string{$pos} == "W") {
-                $type = "ETAG_WEAK";
-                $pos += 2;
-            } else {
-                $type = "ETAG_STRONG";
-            }
-            $pos2 = strpos($string, "]", $pos);
-            $etag = substr($string, $pos + 1, $pos2 - $pos - 2);
-            $pos  = $pos2 + 1;
-            return array($type, $etag);
-
-        case "N":
-            // "N" indicates negation
-            $pos += 2;
-            return array("NOT", "Not");
-
-        default:
-            // anything else is passed verbatim char by char
-            return array("CHAR", $c);
+        	case "<":
+            	// URIs are enclosed in <...>
+            	$pos2 = strpos($string, ">", $pos);
+            	$uri  = substr($string, $pos, $pos2 - $pos);
+            	$pos  = $pos2 + 1;
+            	return array("URI", $uri);
+
+        	case "[":
+            	//Etags are enclosed in [...]
+            	if ($string{$pos} == "W") {
+                	$type = "ETAG_WEAK";
+                	$pos += 2;
+            	} else {
+                	$type = "ETAG_STRONG";
+            	}
+            	$pos2 = strpos($string, "]", $pos);
+            	$etag = substr($string, $pos + 1, $pos2 - $pos - 2);
+            	$pos  = $pos2 + 1;
+            	return array($type, $etag);
+
+        	case "N":
+            	// "N" indicates negation
+            	$pos += 2;
+            	return array("NOT", "Not");
+
+        	default:
+            	// anything else is passed verbatim char by char
+            	return array("CHAR", $c);
         }
     }
 
@@ -2461,33 +2461,33 @@ 
                     continue;
                 }
                 switch ($token[0]) {
-                case "CHAR":
-                    switch ($token[1]) {
-                    case "(":
-                        $level++;
-                        break;
-                    case ")":
-                        $level--;
-                        break;
-                    default:
-                        return false;
-                    }
+                	case "CHAR":
+                    	switch ($token[1]) {
+                    		case "(":
+                        		$level++;
+                        		break;
+                    		case ")":
+                        		$level--;
+                        		break;
+                    		default:
+                        		return false;
+                    	}
                     break;
 
-                case "URI":
-                    $list[] = $not."<$token[1]>";
-                    break;
+                	case "URI":
+                    	$list[] = $not."<$token[1]>";
+                    	break;
 
-                case "ETAG_WEAK":
-                    $list[] = $not."[W/'$token[1]']>";
-                    break;
+                	case "ETAG_WEAK":
+                    	$list[] = $not."[W/'$token[1]']>";
+                    	break;
 
-                case "ETAG_STRONG":
-                    $list[] = $not."['$token[1]']>";
-                    break;
+                	case "ETAG_STRONG":
+                    	$list[] = $not."['$token[1]']>";
+                    	break;
 
-                default:
-                    return false;
+                	default:
+                    	return false;
                 }
                 $not = "";
             }

Spacing +141 added lines, -143 removed lines

@@ -193,7 +193,7 @@ 
      * @param  $prefix =null prefix filesystem path with given path, eg. "/webdav" for owncloud 4.5 remote.php
      * @return void
      */
-    function ServeRequest($prefix=null)
+    function ServeRequest($prefix = null)
     {
         // prevent warning in litmus check 'delete_fragment'
         if (strstr($this->_SERVER["REQUEST_URI"], '#')) {
@@ -205,7 +205,7 @@ 
         if ($this->client_require_href_as_url)
         {
 	        // default uri is the complete request uri
-	        $uri = (@$this->_SERVER["HTTPS"] === "on" ? "https:" : "http:") . '//'.$this->_SERVER['HTTP_HOST'];
+	        $uri = (@$this->_SERVER["HTTPS"] === "on" ? "https:" : "http:").'//'.$this->_SERVER['HTTP_HOST'];
         }
         $uri .= $this->_SERVER["SCRIPT_NAME"];
 
@@ -214,7 +214,7 @@ 
         // of the request URI ourselves
         // if request URI contains a full url, remove schema and domain
 		$matches = null;
-        if (preg_match('|^https?://[^/]+(/.*)$|', $path_info=$this->_SERVER["REQUEST_URI"], $matches))
+        if (preg_match('|^https?://[^/]+(/.*)$|', $path_info = $this->_SERVER["REQUEST_URI"], $matches))
         {
         	$path_info = $matches[1];
         }
@@ -234,13 +234,13 @@ 
         }
 
         $this->base_uri = $uri;
-        $this->uri      = $uri . $path_info;
+        $this->uri      = $uri.$path_info;
 
         // set path
         // $_SERVER['PATH_INFO'] is already urldecoded
         //$this->path = self::_urldecode($path_info);
         // quote '#' (e.g. OpenOffice uses this for lock-files)
-        $this->path = strtr($path_info,array(
+        $this->path = strtr($path_info, array(
         	'%' => '%25',
         	'#' => '%23',
         	'?' => '%3F',
@@ -273,7 +273,7 @@ 
         // check authentication
         // for the motivation for not checking OPTIONS requests on / see
         // http://pear.php.net/bugs/bug.php?id=5363
-        if ( (   !(($this->_SERVER['REQUEST_METHOD'] == 'OPTIONS') && ($this->path == "/")))
+        if ((!(($this->_SERVER['REQUEST_METHOD'] == 'OPTIONS') && ($this->path == "/")))
              && (!$this->_check_auth())) {
             // RFC2518 says we must use Digest instead of Basic
             // but Microsoft Clients do not support Digest
@@ -289,7 +289,7 @@ 
         }
 
         // check
-        if (! $this->_check_if_header_conditions()) {
+        if (!$this->_check_if_header_conditions()) {
             return;
         }
 
@@ -303,19 +303,19 @@ 
         }
 
         if (method_exists($this, $wrapper) && ($method == "options" || method_exists($this, $method))) {
-            $this->$wrapper();  // call method by name
+            $this->$wrapper(); // call method by name
         } else { // method not found/implemented
             if ($this->_SERVER["REQUEST_METHOD"] == "LOCK") {
             	$error = '412 Precondition failed';
             } else {
                 $error = '405 Method not allowed';
-                header("Allow: ".join(", ", $this->_allow()));  // tell client what's allowed
+                header("Allow: ".join(", ", $this->_allow())); // tell client what's allowed
             }
             $this->http_status($error);
             echo "<html><head><title>Error $error</title></head>\n";
             echo "<body><h1>$error</h1>\n";
             echo "The requested could not by handled by this server.\n";
-            echo '(URI ' . $this->_SERVER['REQUEST_URI'] . ")<br>\n<br>\n";
+            echo '(URI '.$this->_SERVER['REQUEST_URI'].")<br>\n<br>\n";
             echo "</body></html>\n";
         }
     }
@@ -611,19 +611,19 @@ 
         $allow = $this->_allow();
 
         // dav header
-        $dav = array(1);        // assume we are always dav class 1 compliant
+        $dav = array(1); // assume we are always dav class 1 compliant
         if (isset($allow['LOCK'])) {
-            $dav[] = 2;         // dav class 2 requires that locking is supported
+            $dav[] = 2; // dav class 2 requires that locking is supported
         }
 
         // allow extending class to modify DAV and Allow headers
-		if (method_exists($this,'OPTIONS')) {
-			$this->OPTIONS($this->path,$dav,$allow);
+		if (method_exists($this, 'OPTIONS')) {
+			$this->OPTIONS($this->path, $dav, $allow);
 		}
 
         // tell clients what we found
         $this->http_status("200 OK");
-        header("DAV: "  .join(", ", $dav));
+        header("DAV: ".join(", ", $dav));
         header("Allow: ".join(", ", $allow));
 
         header("Content-length: 0");
@@ -653,7 +653,7 @@ 
      * @param  string $handler ='PROPFIND' allows to use method eg. for CalDAV REPORT
      * @return void
      */
-    function http_PROPFIND($handler='PROPFIND')
+    function http_PROPFIND($handler = 'PROPFIND')
     {
         $options = Array();
         $files   = Array();
@@ -682,21 +682,21 @@ 
 			$options['other'] = $propinfo->other;
 
         // call user handler
-        if (!($retval =$this->$handler($options, $files))) {
+        if (!($retval = $this->$handler($options, $files))) {
             $files = array("files" => array());
             if (method_exists($this, "checkLock")) {
                 // is locked?
                 $lock = $this->checkLock($this->path);
 
                 if (is_array($lock) && count($lock)) {
-                    $created          = isset($lock['created'])  ? $lock['created']  : time();
+                    $created          = isset($lock['created']) ? $lock['created'] : time();
                     $modified         = isset($lock['modified']) ? $lock['modified'] : time();
                     $files['files'][] = array("path"  => self::_slashify($this->path),
-                                              "props" => array($this->mkprop("displayname",      $this->path),
-                                                               $this->mkprop("creationdate",     $created),
-                                                               $this->mkprop("getlastmodified",  $modified),
-                                                               $this->mkprop("resourcetype",     ""),
-                                                               $this->mkprop("getcontenttype",   ""),
+                                              "props" => array($this->mkprop("displayname", $this->path),
+                                                               $this->mkprop("creationdate", $created),
+                                                               $this->mkprop("getlastmodified", $modified),
+                                                               $this->mkprop("resourcetype", ""),
+                                                               $this->mkprop("getcontenttype", ""),
                                                                $this->mkprop("getcontentlength", 0))
                                               );
                 }
@@ -719,7 +719,7 @@ 
 			header('Content-Type: text/html');
 			echo "<html><head><title>Error $retval</title></head>\n";
 			echo "<body><h1>$retval</h1>\n";
-			switch (substr($retval, 0 ,3))
+			switch (substr($retval, 0, 3))
 			{
 				case '501': // Not Implemented
 					echo "The requested feature is not (yet) supported by this server.\n";
@@ -727,19 +727,19 @@ 
 				default:
 					echo "The request could not be handled by this server.\n";
 			}
-			echo '(URI ' . $this->_SERVER['REQUEST_URI'] . ")<br>\n<br>\n";
+			echo '(URI '.$this->_SERVER['REQUEST_URI'].")<br>\n<br>\n";
 			echo "</body></html>\n";
 			return;
 		}
 		// dav header
-        $dav = array(1);        // assume we are always dav class 1 compliant
+        $dav = array(1); // assume we are always dav class 1 compliant
         $allow = false;
 
         // allow extending class to modify DAV
-		if (method_exists($this,'OPTIONS')) {
-			$this->OPTIONS($this->path,$dav,$allow);
+		if (method_exists($this, 'OPTIONS')) {
+			$this->OPTIONS($this->path, $dav, $allow);
 		}
-        header("DAV: "  .join(", ", $dav));
+        header("DAV: ".join(", ", $dav));
         header('Content-Type: text/xml; charset="utf-8"');
 
         // add Vary and Preference-Applied header for Prefer: return=minimal
@@ -759,12 +759,11 @@ 
         if (isset($files['sync-token']))
         {
             echo ($this->crrnd ? " <" : " <D:")."sync-token>".
-            	htmlspecialchars(!is_callable($files['sync-token']) ? $files['sync-token'] :
-            		call_user_func_array($files['sync-token'], (array)$files['sync-token-params'])).
+            	htmlspecialchars(!is_callable($files['sync-token']) ? $files['sync-token'] : call_user_func_array($files['sync-token'], (array)$files['sync-token-params'])).
             	($this->crrnd ? "</" : "</D:")."sync-token>\n";
         }
 
-        echo '</'.($this->crrnd?'':'D:')."multistatus>\n";
+        echo '</'.($this->crrnd ? '' : 'D:')."multistatus>\n";
     }
 
     /**
@@ -773,7 +772,7 @@ 
      * @param array|Iterator $files
      * @param array|string $props
      */
-    function multistatus_responses(&$files, $props, $initial_ns_hash=null, $initial_ns_defs=null)
+    function multistatus_responses(&$files, $props, $initial_ns_hash = null, $initial_ns_defs = null)
     {
     	if (!isset($initial_ns_hash)) $initial_ns_hash = array('DAV:' => 'D');
     	if (!isset($initial_ns_defs)) $initial_ns_defs = 'xmlns:ns0="urn:uuid:c2f41010-65b3-11d1-a29f-00aa00c14882/"';
@@ -786,7 +785,7 @@ 
         }
         // support for "Prefer: depth-noroot" header on PROPFIND
         $skip_root = $this->_SERVER['REQUEST_METHOD'] == 'PROPFIND' &&
-        	!isset($initial_ns_hash) &&	// multistatus_response calls itself, do NOT apply skip in that case
+        	!isset($initial_ns_hash) && // multistatus_response calls itself, do NOT apply skip in that case
         	isset($this->_SERVER['HTTP_PREFER']) && in_array('depth-noroot', preg_split('/, ?/', $this->_SERVER['HTTP_PREFER']));
 
         // now we loop over all returned file entries
@@ -815,9 +814,8 @@ 
 
 	            	// this can happen if we have allprop and prop in one propfind:
 	            	// <allprop /><prop><blah /></prop>, eg. blah is not automatic returned by allprop
-	                switch(is_array($props) ? $props[0] : $props) {
-	                case "all":
-	                    // nothing to remove
+	                switch (is_array($props) ? $props[0] : $props) {
+	                case "all" : // nothing to remove
 	                    break;
 
 	                case "names":
@@ -831,7 +829,7 @@ 
 
 	                    // search property name in requested properties
 	                    foreach ((array)$props as $reqprop) {
-	                        if (   $reqprop["name"]  == $prop["name"]
+	                        if ($reqprop["name"] == $prop["name"]
 	                               && @$reqprop["xmlns"] == $prop["ns"]) {
 	                            $found = true;
 	                            break;
@@ -840,7 +838,7 @@ 
 
 	                    // unset property and continue with next one if not found/requested
 	                    if (!$found) {
-	                        $prop="";
+	                        $prop = "";
 	                        continue(2);
 	                    }
 	                    break;
@@ -862,7 +860,7 @@ 
 	            // but for which no values where returned by the user handler
 	            if (is_array($props)) {
 	                foreach ($props as $reqprop) {
-	                    if (!is_array($reqprop) || $reqprop['name']=="") continue; // skip empty entries, or 'all' if <allprop /> used together with <prop>
+	                    if (!is_array($reqprop) || $reqprop['name'] == "") continue; // skip empty entries, or 'all' if <allprop /> used together with <prop>
 
 	                    $found = false;
 
@@ -876,7 +874,7 @@ 
 	                    }
 
 	                    if (!$found) {
-	                        if ($reqprop["xmlns"]==="DAV:" && $reqprop["name"]==="lockdiscovery") {
+	                        if ($reqprop["xmlns"] === "DAV:" && $reqprop["name"] === "lockdiscovery") {
 	                            // lockdiscovery is handled by the base class
 	                            $file["props"][]
 	                                = $this->mkprop("DAV:",
@@ -903,7 +901,7 @@ 
             // ignore empty or incomplete entries
             if (!is_array($file) || empty($file) || !isset($file["path"])) continue;
             $path = $file['path'];
-            if (!is_string($path) || $path==="") continue;
+            if (!is_string($path) || $path === "") continue;
 
             if ($this->crrnd)
             {
@@ -933,8 +931,8 @@ 
 
             // report all found properties and their values (if any)
             if (isset($file["props"]) && is_array($file["props"])) {
-                echo '   <'.($this->crrnd?'':'D:')."propstat>\n";
-                echo '    <'.($this->crrnd?'':'D:')."prop>\n";
+                echo '   <'.($this->crrnd ? '' : 'D:')."propstat>\n";
+                echo '    <'.($this->crrnd ? '' : 'D:')."prop>\n";
 
                 foreach ($file["props"] as &$prop) {
 
@@ -943,8 +941,8 @@ 
 
                     if (!isset($prop["val"]) || $prop["val"] === "" || $prop["val"] === false) {
                         // empty properties (cannot use empty() for check as "0" is a legal value here)
-                        if ($prop["ns"]=="DAV:") {
-                            echo '     <'.($this->crrnd?'':'D:')."$prop[name]/>\n";
+                        if ($prop["ns"] == "DAV:") {
+                            echo '     <'.($this->crrnd ? '' : 'D:')."$prop[name]/>\n";
                         } else if (!empty($prop["ns"])) {
                             echo "     <".$ns_hash[$prop["ns"]].":$prop[name]/>\n";
                         } else {
@@ -952,7 +950,7 @@ 
                         }
                     }
                     // multiple level of responses required for expand-property reports
-                    elseif(isset($prop['props']) && is_array($prop['val']))
+                    elseif (isset($prop['props']) && is_array($prop['val']))
                     {
                         if ($prop['ns'] && !isset($ns_hash[$prop['ns']])) {
                             $ns_name = "ns".(count($ns_hash) + 1);
@@ -965,33 +963,33 @@ 
                         // some WebDAV properties need special treatment
                         switch ($prop["name"]) {
                         case "creationdate":
-                            echo '     <'.($this->crrnd?'':'D:')."creationdate ns0:dt=\"dateTime.tz\">"
+                            echo '     <'.($this->crrnd ? '' : 'D:')."creationdate ns0:dt=\"dateTime.tz\">"
                                 . gmdate("Y-m-d\\TH:i:s\\Z", $prop['val'])
-                                . '</'.($this->crrnd?'':'D:')."creationdate>\n";
+                                . '</'.($this->crrnd ? '' : 'D:')."creationdate>\n";
                             break;
                         case "getlastmodified":
-                            echo '     <'.($this->crrnd?'':'D:')."getlastmodified ns0:dt=\"dateTime.rfc1123\">"
+                            echo '     <'.($this->crrnd ? '' : 'D:')."getlastmodified ns0:dt=\"dateTime.rfc1123\">"
                                 . gmdate("D, d M Y H:i:s ", $prop['val'])
-                                . "GMT</".($this->crrnd?'':'D:')."getlastmodified>\n";
+                                . "GMT</".($this->crrnd ? '' : 'D:')."getlastmodified>\n";
                             break;
                         case "supportedlock":
-                            echo '     <'.($this->crrnd?'':'D:')."supportedlock>$prop[val]</".($this->crrnd?'':'D:')."supportedlock>\n";
+                            echo '     <'.($this->crrnd ? '' : 'D:')."supportedlock>$prop[val]</".($this->crrnd ? '' : 'D:')."supportedlock>\n";
                             break;
                         case "lockdiscovery":
-                            echo '     <'.($this->crrnd?'':'D:')."lockdiscovery>\n";
+                            echo '     <'.($this->crrnd ? '' : 'D:')."lockdiscovery>\n";
                             echo $prop["val"];
-                            echo '     </'.($this->crrnd?'':'D:')."lockdiscovery>\n";
+                            echo '     </'.($this->crrnd ? '' : 'D:')."lockdiscovery>\n";
                             break;
                         // the following are non-standard Microsoft extensions to the DAV namespace
                         case "lastaccessed":
-                            echo '     <'.($this->crrnd?'':'D:')."lastaccessed ns0:dt=\"dateTime.rfc1123\">"
+                            echo '     <'.($this->crrnd ? '' : 'D:')."lastaccessed ns0:dt=\"dateTime.rfc1123\">"
                                 . gmdate("D, d M Y H:i:s ", $prop['val'])
-                                . 'GMT</'.($this->crrnd?'':'D:')."lastaccessed>\n";
+                                . 'GMT</'.($this->crrnd ? '' : 'D:')."lastaccessed>\n";
                             break;
                         case "ishidden":
-                            echo '     <'.($this->crrnd?'':'D:')."ishidden>"
+                            echo '     <'.($this->crrnd ? '' : 'D:')."ishidden>"
                                 . is_string($prop['val']) ? $prop['val'] : ($prop['val'] ? 'true' : 'false')
-                                . '</'.($this->crrnd?'':'D:')."</D:ishidden>\n";
+                                . '</'.($this->crrnd ? '' : 'D:')."</D:ishidden>\n";
                             break;
                         default:
                         	$ns_defs = '';
@@ -1004,8 +1002,8 @@ 
                             } else {
 	                    		$val = $this->_prop_encode(htmlspecialchars($prop['val'], ENT_NOQUOTES, 'utf-8'));
                             }
-	                        echo '     <'.($this->crrnd?'':'D:')."$prop[name]$ns_defs>$val".
-	                        	'</'.($this->crrnd?'':'D:')."$prop[name]>\n";
+	                        echo '     <'.($this->crrnd ? '' : 'D:')."$prop[name]$ns_defs>$val".
+	                        	'</'.($this->crrnd ? '' : 'D:')."$prop[name]>\n";
                             break;
                         }
                     } else {
@@ -1016,7 +1014,7 @@ 
                                 $ns_hash[$prop['ns']] = $ns_name;
                     		}
                   			$vals = $extra_ns = '';
-                    		foreach($prop['val'] as $subprop)
+                    		foreach ($prop['val'] as $subprop)
                     		{
                     			if ($subprop['ns'] && $subprop['ns'] != 'DAV:') {
 		                    		// register property namespace if not known yet
@@ -1026,7 +1024,7 @@ 
 		                    		} else {
 			                    		$ns_name = $ns_hash[$subprop['ns']];
 		                    		}
-		                    		if (strchr($extra_ns,$extra=' xmlns:'.$ns_name.'="'.$subprop['ns'].'"') === false) {
+		                    		if (strchr($extra_ns, $extra = ' xmlns:'.$ns_name.'="'.$subprop['ns'].'"') === false) {
 			                    		$extra_ns .= $extra;
 		                    		}
 		                    		$ns_name .= ':';
@@ -1046,7 +1044,7 @@ 
 	                    			}
 	                    			else	// val contains only attributes, no value
 	                    			{
-			                    		foreach($subprop['val'] as $attr => $val)
+			                    		foreach ($subprop['val'] as $attr => $val)
 										{
 				                    		$vals .= ' '.$attr.'="'.htmlspecialchars($val, ENT_NOQUOTES, 'utf-8').'"';
 										}
@@ -1059,7 +1057,7 @@ 
 	                    			if (isset($subprop['raw'])) {
 	                    				$vals .= '<![CDATA['.$subprop['val'].']]>';
 	                    			} else {
-	                    				if($subprop['name'] == 'href') $subprop['val'] = $this->_urlencode($subprop['val']);
+	                    				if ($subprop['name'] == 'href') $subprop['val'] = $this->_urlencode($subprop['val']);
 		                    			$vals .= htmlspecialchars($subprop['val'], ENT_NOQUOTES, 'utf-8');
 	                    			}
 	                    			$vals .= "</$ns_name$subprop[name]>";
@@ -1078,10 +1076,10 @@ 
 	                        if ($prop['ns']) {
 		                        if ($this->crrnd) {
 			                        echo "     <$prop[name] xmlns=".'"'.$prop["ns"].'">'
-									. $val . "</$prop[name]>\n";
+									. $val."</$prop[name]>\n";
 		                        } else {
-			                        echo "     <" . $ns_hash[$prop["ns"]] . ":$prop[name]>"
-									. $val . '</'.$ns_hash[$prop['ns']].":$prop[name]>\n";
+			                        echo "     <".$ns_hash[$prop["ns"]].":$prop[name]>"
+									. $val.'</'.$ns_hash[$prop['ns']].":$prop[name]>\n";
 		                        }
 	                        } else {
 		                        echo "     <$prop[name] xmlns=\"\">$val</$prop[name]>\n";
@@ -1106,16 +1104,16 @@ 
 
             // now report all properties requested but not found
             if (isset($file["noprops"])) {
-                echo '   <'.($this->crrnd?'':'D:')."propstat>\n";
-                echo '    <'.($this->crrnd?'':'D:')."prop>\n";
+                echo '   <'.($this->crrnd ? '' : 'D:')."propstat>\n";
+                echo '    <'.($this->crrnd ? '' : 'D:')."prop>\n";
 
                 foreach ($file["noprops"] as &$prop) {
                     if ($prop["ns"] == "DAV:") {
-                        echo '     <'.($this->crrnd?'':'D:')."$prop[name]/>\n";
+                        echo '     <'.($this->crrnd ? '' : 'D:')."$prop[name]/>\n";
                     } else if ($prop["ns"] == "") {
                         echo "     <$prop[name] xmlns=\"\"/>\n";
                     } else {
-                        echo "     <" . $ns_hash[$prop["ns"]] . ":$prop[name]/>\n";
+                        echo "     <".$ns_hash[$prop["ns"]].":$prop[name]/>\n";
                     }
                 }
 
@@ -1146,7 +1144,7 @@ 
                 }
             }
 
-            echo ' </'.($this->crrnd?'':'D:')."response>\n";
+            echo ' </'.($this->crrnd ? '' : 'D:')."response>\n";
         }
     }
 
@@ -1186,24 +1184,24 @@ 
             echo "<?xml version=\"1.0\" encoding=\"utf-8\"?>\n";
 
             echo "<D:multistatus xmlns:D=\"DAV:\">\n";
-            echo ' <'.($this->crrnd?'':'D:')."response>\n";
-            echo '  <'.($this->crrnd?'':'D:')."href>".$this->_urlencode($this->_mergePaths($this->_SERVER["SCRIPT_NAME"], $this->path)).'</'.($this->crrnd?'':'D:')."href>\n";
+            echo ' <'.($this->crrnd ? '' : 'D:')."response>\n";
+            echo '  <'.($this->crrnd ? '' : 'D:')."href>".$this->_urlencode($this->_mergePaths($this->_SERVER["SCRIPT_NAME"], $this->path)).'</'.($this->crrnd ? '' : 'D:')."href>\n";
 
             foreach ($options["props"] as $prop) {
-                echo '   <'.($this->crrnd?'':'D:')."propstat>\n";
-                echo '    <'.($this->crrnd?'':'D:')."prop><$prop[name] xmlns=\"$prop[ns]\"/></".($this->crrnd?'':'D:')."prop>\n";
-                echo '    <'.($this->crrnd?'':'D:')."status>HTTP/1.1 $prop[status]</".($this->crrnd?'':'D:')."status>\n";
-                echo '   </'.($this->crrnd?'':'D:')."propstat>\n";
+                echo '   <'.($this->crrnd ? '' : 'D:')."propstat>\n";
+                echo '    <'.($this->crrnd ? '' : 'D:')."prop><$prop[name] xmlns=\"$prop[ns]\"/></".($this->crrnd ? '' : 'D:')."prop>\n";
+                echo '    <'.($this->crrnd ? '' : 'D:')."status>HTTP/1.1 $prop[status]</".($this->crrnd ? '' : 'D:')."status>\n";
+                echo '   </'.($this->crrnd ? '' : 'D:')."propstat>\n";
             }
 
             if ($responsedescr) {
-                echo '  <'.($this->crrnd?'':'D:')."responsedescription>".
+                echo '  <'.($this->crrnd ? '' : 'D:')."responsedescription>".
                     $this->_prop_encode(htmlspecialchars($responsedescr, ENT_NOQUOTES, 'utf-8')).
-                    '</'.($this->crrnd?'':'D:')."responsedescription>\n";
+                    '</'.($this->crrnd ? '' : 'D:')."responsedescription>\n";
             }
 
-            echo ' </'.($this->crrnd?'':'D:')."response>\n";
-            echo '</'.($this->crrnd?'':'D:')."multistatus>\n";
+            echo ' </'.($this->crrnd ? '' : 'D:')."response>\n";
+            echo '</'.($this->crrnd ? '' : 'D:')."multistatus>\n";
         } else {
             $this->http_status("423 Locked");
         }
@@ -1243,12 +1241,12 @@ 
 	 * @param boolean $set =null
 	 * @return boolean true if we use compression, false otherwise
 	 */
-	public static function use_compression($set=null)
+	public static function use_compression($set = null)
 	{
 		static $compression = null;
 		if (isset($set))
 		{
-			ini_set('zlib.output_compression', $compression=(boolean)$set);
+			ini_set('zlib.output_compression', $compression = (boolean)$set);
 		}
 		elseif (!isset($compression))
 		{
@@ -1284,7 +1282,7 @@ 
                 // switching off zlib.output_compression for everything but text files,
                 // as the double compression of zip files makes problems eg. with lighttpd
                 // and anyway little sense with with other content like pictures
-                if (substr($options['mimetype'],0,5) != 'text/')
+                if (substr($options['mimetype'], 0, 5) != 'text/')
                 {
 					self::use_compression(false);
                 }
@@ -1301,7 +1299,7 @@ 
 
                 if (isset($options['stream'])) {
                     // GET handler returned a stream
-                    if (!empty($options['ranges']) && (0===fseek($options['stream'], 0, SEEK_SET))) {
+                    if (!empty($options['ranges']) && (0 === fseek($options['stream'], 0, SEEK_SET))) {
                         // partial request and stream is seekable
 
                         if (count($options['ranges']) === 1) {
@@ -1315,7 +1313,7 @@ 
                                 }
 
                                 if (!empty($range['end'])) {
-                                    $size = $range['end']-$range['start']+1;
+                                    $size = $range['end'] - $range['start'] + 1;
                                     $this->http_status("206 Partial content");
                                     if (!self::use_compression()) header("Content-Length: $size");
                                     header("Content-Range: bytes $range[start]-$range[end]/"
@@ -1330,7 +1328,7 @@ 
                                     if (isset($options['size'])) {
                                         if (!self::use_compression()) header("Content-Length: ".($options['size'] - $range['start']));
                                         header("Content-Range: bytes ".$range['start']."-".
-											(isset($options['size']) ? $options['size']-1 : "")."/"
+											(isset($options['size']) ? $options['size'] - 1 : "")."/"
 										   . (isset($options['size']) ? $options['size'] : "*"));
                                     }
                                     fpassthru($options['stream']);
@@ -1346,10 +1344,10 @@ 
                                 // TODO what if size unknown? 500?
                                 if (isset($range['start'])) {
                                     $from = $range['start'];
-                                    $to   = !empty($range['end']) ? $range['end'] : $options['size']-1;
+                                    $to   = !empty($range['end']) ? $range['end'] : $options['size'] - 1;
                                 } else {
-                                    $from = $options['size'] - $range['last']-1;
-                                    $to   = $options['size'] -1;
+                                    $from = $options['size'] - $range['last'] - 1;
+                                    $to   = $options['size'] - 1;
                                 }
                                 $total = isset($options['size']) ? $options['size'] : "*";
                                 $size  = $to - $from + 1;
@@ -1415,7 +1413,7 @@ 
                 foreach (explode(",", $matches[1]) as $range) {
                     // ranges are either from-to pairs or just end positions
                     list($start, $end) = explode("-", $range);
-                    $options["ranges"][] = ($start==="")
+                    $options["ranges"][] = ($start === "")
                         ? array("last"=>$end)
                         : array("start"=>$start, "end"=>$end);
                 }
@@ -1436,7 +1434,7 @@ 
      * @param  int     end   byte position
      * @param  int     total resource byte size
      */
-    function _multipart_byterange_header($mimetype = false, $from = false, $to=false, $total=false)
+    function _multipart_byterange_header($mimetype = false, $from = false, $to = false, $total = false)
     {
         if ($mimetype === false) {
             if (!isset($this->multipart_separator)) {
@@ -1458,7 +1456,7 @@ 
             // generate separator and header for next part
             echo "\n--{$this->multipart_separator}\n";
             echo "Content-type: $mimetype\n";
-            echo "Content-range: $from-$to/". ($total === false ? "*" : $total);
+            echo "Content-range: $from-$to/".($total === false ? "*" : $total);
             echo "\n\n";
         }
     }
@@ -1552,7 +1550,7 @@ 
         }
 
         $options['stream'] = fopen('php://input', 'r');
-    	switch($this->_SERVER['HTTP_CONTENT_ENCODING'])
+    	switch ($this->_SERVER['HTTP_CONTENT_ENCODING'])
     	{
     		case 'gzip':
     		case 'deflate':	//zlib
@@ -1565,11 +1563,11 @@ 
 		if ($this->store_request)
 		{
 			$options['content'] = '';
-			while(!feof($options['stream']))
+			while (!feof($options['stream']))
 			{
-				$options['content'] .= fread($options['stream'],8192);
+				$options['content'] .= fread($options['stream'], 8192);
 			}
-			$this->request =& $options['content'];
+			$this->request = & $options['content'];
 			unset($options['stream']);
 		}
 
@@ -1582,7 +1580,7 @@ 
 	        if (strncmp($key, 'HTTP_CONTENT', 11)) continue;
 	        switch ($key) {
 		        case 'HTTP_CONTENT_ENCODING': // RFC 2616 14.11
-		        	switch($this->_SERVER['HTTP_CONTENT_ENCODING'])
+		        	switch ($this->_SERVER['HTTP_CONTENT_ENCODING'])
 		        	{
 		        		case 'gzip':
 		        		case 'deflate':	//zlib
@@ -1670,7 +1668,7 @@ 
 		        if (!empty($options['ranges'])) {
 			        // TODO multipart support is missing (see also above)
 			        if (0 == fseek($stream, $range[0]['start'], SEEK_SET)) {
-				        $length = $range[0]['end']-$range[0]['start']+1;
+				        $length = $range[0]['end'] - $range[0]['start'] + 1;
 				        if (!fwrite($stream, fread($options['stream'], $length))) {
 					        $status = '403 Forbidden';
 				        }
@@ -1732,7 +1730,7 @@ 
             }
 
             $options["stream"] = fopen("php://input", "r");
-	    	switch($this->_SERVER['HTTP_CONTENT_ENCODING'])
+	    	switch ($this->_SERVER['HTTP_CONTENT_ENCODING'])
 	    	{
 	    		case 'gzip':
 	    		case 'deflate':	//zlib
@@ -1745,11 +1743,11 @@ 
 			if ($this->store_request)
 			{
 				$options['content'] = '';
-				while(!feof($options['stream']))
+				while (!feof($options['stream']))
 				{
-					$options['content'] .= fread($options['stream'],8192);
+					$options['content'] .= fread($options['stream'], 8192);
 				}
-				$this->request =& $options['content'];
+				$this->request = & $options['content'];
 				unset($options['stream']);
 			}
 
@@ -1762,7 +1760,7 @@ 
                 if (strncmp($key, "HTTP_CONTENT", 11)) continue;
                 switch ($key) {
                 case 'HTTP_CONTENT_ENCODING': // RFC 2616 14.11
-		        	switch($this->_SERVER['HTTP_CONTENT_ENCODING'])
+		        	switch ($this->_SERVER['HTTP_CONTENT_ENCODING'])
 		        	{
 		        		case 'gzip':
 		        		case 'deflate':	//zlib
@@ -1848,7 +1846,7 @@ 
                 if (!empty($options["ranges"])) {
                     // TODO multipart support is missing (see also above)
                     if (0 == fseek($stream, $options['ranges'][0]["start"], SEEK_SET)) {
-                        $length = $options['ranges'][0]["end"] - $options['ranges'][0]["start"]+1;
+                        $length = $options['ranges'][0]["end"] - $options['ranges'][0]["start"] + 1;
 
                         while (!feof($options['stream'])) {
                             if ($length <= 0) {
@@ -1908,7 +1906,7 @@ 
         // check RFC 2518 Section 9.2, last paragraph
         if (isset($this->_SERVER["HTTP_DEPTH"])) {
             if ($this->_SERVER["HTTP_DEPTH"] != "infinity") {
-				if (stripos($_SERVER['HTTP_USER_AGENT'],'webdrive') !== false)
+				if (stripos($_SERVER['HTTP_USER_AGENT'], 'webdrive') !== false)
 				{
 					// pretend we didnt see it, as webdrive does not handle the depth parameter correctly while deleting collections
 				}
@@ -2057,8 +2055,8 @@ 
                 if (is_numeric($options["timeout"])) {
                     // more than a million is considered an absolute timestamp
                     // less is more likely a relative value
-                    if ($options["timeout"]>1000000) {
-                        $timeout = "Second-".($options['timeout']-time());
+                    if ($options["timeout"] > 1000000) {
+                        $timeout = "Second-".($options['timeout'] - time());
                     } else {
                         $timeout = "Second-$options[timeout]";
                     }
@@ -2076,17 +2074,17 @@ 
             header("Lock-Token: <$options[locktoken]>");
             echo "<?xml version=\"1.0\" encoding=\"utf-8\"?>\n";
             echo "<D:prop xmlns:D=\"DAV:\">\n";
-            echo ' <'.($this->crrnd?'':'D:')."lockdiscovery>\n";
-            echo '  <'.($this->crrnd?'':'D:')."activelock>\n";
-            echo '   <'.($this->crrnd?'':'D:')."lockscope><D:$options[scope]/></".($this->crrnd?'':'D:')."lockscope>\n";
-            echo '   <'.($this->crrnd?'':'D:')."locktype><D:$options[type]/></".($this->crrnd?'':'D:')."locktype>\n";
-            echo '   <'.($this->crrnd?'':'D:')."depth>$options[depth]</".($this->crrnd?'':'D:')."depth>\n";
-            echo '   <'.($this->crrnd?'':'D:')."owner>$options[owner]</".($this->crrnd?'':'D:')."owner>\n";
-            echo '   <'.($this->crrnd?'':'D:')."timeout>$timeout</".($this->crrnd?'':'D:')."timeout>\n";
-            echo '   <'.($this->crrnd?'':'D:')."locktoken><D:href>$options[locktoken]</D:href></".($this->crrnd?'':'D:')."locktoken>\n";
-            echo '  </'.($this->crrnd?'':'D:')."activelock>\n";
-            echo ' </'.($this->crrnd?'':'D:')."lockdiscovery>\n";
-            echo '</'.($this->crrnd?'':'D:')."prop>\n\n";
+            echo ' <'.($this->crrnd ? '' : 'D:')."lockdiscovery>\n";
+            echo '  <'.($this->crrnd ? '' : 'D:')."activelock>\n";
+            echo '   <'.($this->crrnd ? '' : 'D:')."lockscope><D:$options[scope]/></".($this->crrnd ? '' : 'D:')."lockscope>\n";
+            echo '   <'.($this->crrnd ? '' : 'D:')."locktype><D:$options[type]/></".($this->crrnd ? '' : 'D:')."locktype>\n";
+            echo '   <'.($this->crrnd ? '' : 'D:')."depth>$options[depth]</".($this->crrnd ? '' : 'D:')."depth>\n";
+            echo '   <'.($this->crrnd ? '' : 'D:')."owner>$options[owner]</".($this->crrnd ? '' : 'D:')."owner>\n";
+            echo '   <'.($this->crrnd ? '' : 'D:')."timeout>$timeout</".($this->crrnd ? '' : 'D:')."timeout>\n";
+            echo '   <'.($this->crrnd ? '' : 'D:')."locktoken><D:href>$options[locktoken]</D:href></".($this->crrnd ? '' : 'D:')."locktoken>\n";
+            echo '  </'.($this->crrnd ? '' : 'D:')."activelock>\n";
+            echo ' </'.($this->crrnd ? '' : 'D:')."lockdiscovery>\n";
+            echo '</'.($this->crrnd ? '' : 'D:')."prop>\n\n";
         }
     }
 
@@ -2156,9 +2154,9 @@ 
 	        $content .= "<?xml version=\"1.0\" encoding=\"utf-8\"?>\n";
 	        $content .= "<D:error xmlns:D=\"DAV:\"> \n";
 	        foreach ($options['errors'] as $violation) {
-	        	$content .= '<'.($this->crrnd?'':'D:')."$violation/>\n";
+	        	$content .= '<'.($this->crrnd ? '' : 'D:')."$violation/>\n";
 	        }
-	        $content .=  '</'.($this->crrnd?'':'D:')."error>\n";
+	        $content .= '</'.($this->crrnd ? '' : 'D:')."error>\n";
         }
         if (!self::use_compression()) header("Content-Length: ".self::bytes($content));
         if ($content) echo $options['content'];
@@ -2190,7 +2188,7 @@ 
             // TODO check url scheme, too
             $http_host = $url["host"];
             if (isset($url["port"]) && $url["port"] != 80)
-                $http_host.= ":".$url["port"];
+                $http_host .= ":".$url["port"];
         } else {
             // only path given, set host to self
             $http_host = $http_header_host;
@@ -2335,17 +2333,17 @@ 
         }
 
         // fallback
-        $uuid = md5(microtime().getmypid());    // this should be random enough for now
+        $uuid = md5(microtime().getmypid()); // this should be random enough for now
 
         // set variant and version fields for 'true' random uuid
         $uuid{12} = "4";
-        $n = 8 + (ord($uuid{16}) & 3);
+        $n = 8 + (ord($uuid{16})&3);
         $hex = "0123456789abcdef";
         $uuid{16} = $hex{$n};
 
         // return formated uuid
-        return substr($uuid,  0, 8)."-"
-            .  substr($uuid,  8, 4)."-"
+        return substr($uuid, 0, 8)."-"
+            .  substr($uuid, 8, 4)."-"
             .  substr($uuid, 12, 4)."-"
             .  substr($uuid, 16, 4)."-"
             .  substr($uuid, 20);
@@ -2562,7 +2560,7 @@ 
      */
     function _check_uri_condition($uri, $condition)
     {
-		unset($uri);	// not used, but required by function signature
+		unset($uri); // not used, but required by function signature
         // not really implemented here,
         // implementations must override
 
@@ -2638,7 +2636,7 @@ 
             // genreate response block
             if ($this->crrnd)
             {
-	            $activelocks.= "
+	            $activelocks .= "
 		            <activelock>
 		            <lockscope><$lock[scope]/></lockscope>
 		            <locktype><$lock[type]/></locktype>
@@ -2651,7 +2649,7 @@ 
             }
             else
             {
-	            $activelocks.= "
+	            $activelocks .= "
 		            <D:activelock>
 		            <D:lockscope><D:$lock[scope]/></D:lockscope>
 		            <D:locktype><D:$lock[type]/></D:locktype>
@@ -2704,15 +2702,15 @@ 
     {
 		// cadaver (and probably all neon using agents) need a more complete url encoding
 		// otherwise special chars like "$,()'" in filenames do NOT work
-		if (strpos($_SERVER['HTTP_USER_AGENT'],'neon') !== false ||
+		if (strpos($_SERVER['HTTP_USER_AGENT'], 'neon') !== false ||
 			// old netdrive does NOT use a User-Agent, but requires full urlencoding for non-ascii chars (eg. German Umlauts)
 			!isset($_SERVER['HTTP_USER_AGENT']) ||
 			// current netdrive uses "NetDrive 2.5.8" as user-agent
-			stripos($_SERVER['HTTP_USER_AGENT'],'NetDrive') !== false ||
+			stripos($_SERVER['HTTP_USER_AGENT'], 'NetDrive') !== false ||
 			// OS X Finder (WebDAVFS/3.0.0 (03008000) Darwin/14.3.0 (x86_64))
-			stripos($_SERVER['HTTP_USER_AGENT'],'WebDAVFS') !== false && stripos($_SERVER['HTTP_USER_AGENT'],'Darwin'))
+			stripos($_SERVER['HTTP_USER_AGENT'], 'WebDAVFS') !== false && stripos($_SERVER['HTTP_USER_AGENT'], 'Darwin'))
 		{
-			return strtr(rawurlencode($url),array(
+			return strtr(rawurlencode($url), array(
 				'%2F' => '/',
 				'%3A' => ':',
 			));
@@ -2769,7 +2767,7 @@ 
     	//error_log(__METHOD__.'('.array2string($props).')');
     	if (isset($props['name'])) $props = array($props);
 
-    	foreach($props as $prop)
+    	foreach ($props as $prop)
 		{
 	    	if (!isset($ns_hash[$prop['ns']])) // unknown namespace
 	    	{
@@ -2791,13 +2789,13 @@ 
 		    	{
 			    	$vals = '';
 
-			    	foreach($subprop as $attr => $val)
+			    	foreach ($subprop as $attr => $val)
 					{
 				    	$vals .= ' '.$attr.'="'.htmlspecialchars($val, ENT_NOQUOTES, 'utf-8').'"';
 					}
 
 		             $ret .= '<'.($prop['ns'] == $ns ? ($this->crrnd ? '' : $ns_hash[$ns].':') : $ns_hash[$prop['ns']].':').$prop['name'].
-				    	$vals .'/>';
+				    	$vals.'/>';
 		    	}
 	    	}
 	    	else
@@ -2808,7 +2806,7 @@ 
 		    	}
 		    	else
 		    	{
-			    	if(isset($prop['raw']))
+			    	if (isset($prop['raw']))
 					{
 						$val = $this->_prop_encode('<![CDATA['.$prop['val'].']]>');
 					} else {
@@ -2850,7 +2848,7 @@ 
 			case "iso-8859-15":
 			case "latin-1":
 			default:
-				error_log( __METHOD__."utf8 encode\n" .print_r(utf8_encode($text),true));
+				error_log(__METHOD__."utf8 encode\n".print_r(utf8_encode($text), true));
 				return utf8_encode($text);
         }
     }
@@ -2864,7 +2862,7 @@ 
     public static function _slashify($path)
     {
 		//error_log(__METHOD__." called with $path");
-		if ($path[self::bytes($path)-1] != '/') {
+		if ($path[self::bytes($path) - 1] != '/') {
 			//error_log(__METHOD__." added slash at the end of path");
 			$path = $path."/";
 		}
@@ -2880,7 +2878,7 @@ 
     public static function _unslashify($path)
     {
         //error_log(__METHOD__." called with $path");
-        if ($path[self::bytes($path)-1] == '/') {
+        if ($path[self::bytes($path) - 1] == '/') {
             $path = substr($path, 0, -1);
 			//error_log(__METHOD__." removed slash at the end of path");
         }
@@ -2913,13 +2911,13 @@ 
      */
     public static function bytes($str)
     {
-    	static $func_overload=null;
+    	static $func_overload = null;
 
     	if (is_null($func_overload))
     	{
     		$func_overload = @extension_loaded('mbstring') ? ini_get('mbstring.func_overload') : 0;
     	}
-    	return $func_overload & 2 ? mb_strlen($str,'ascii') : strlen($str);
+    	return $func_overload&2 ? mb_strlen($str, 'ascii') : strlen($str);
     }
 }
 

Braces +700 added lines, -289 removed lines

@@ -196,7 +196,8 @@ 
     function ServeRequest($prefix=null)
     {
         // prevent warning in litmus check 'delete_fragment'
-        if (strstr($this->_SERVER["REQUEST_URI"], '#')) {
+        if (strstr($this->_SERVER["REQUEST_URI"], '#'))
+        {
             $this->http_status("400 Bad Request");
             return;
         }
@@ -221,7 +222,8 @@ 
         $path_info_raw = substr($path_info, strlen($this->_SERVER["SCRIPT_NAME"]));
 
         // just in case the path came in empty ...
-        if (empty($path_info_raw)) {
+        if (empty($path_info_raw))
+        {
             $path_info_raw = "/";
         }
 
@@ -245,28 +247,36 @@ 
         	'#' => '%23',
         	'?' => '%3F',
         ));
-        if (!strlen($this->path)) {
-            if ($this->_SERVER["REQUEST_METHOD"] == "GET") {
+        if (!strlen($this->path))
+        {
+            if ($this->_SERVER["REQUEST_METHOD"] == "GET")
+            {
                 // redirect clients that try to GET a collection
                 // WebDAV clients should never try this while
                 // regular HTTP clients might ...
                 header("Location: ".$this->base_uri."/");
                 return;
-            } else {
+            }
+            else
+            {
                 // if a WebDAV client didn't give a path we just assume '/'
                 $this->path = "/";
             }
         }
 
-        if (ini_get("magic_quotes_gpc")) {
+        if (ini_get("magic_quotes_gpc"))
+        {
             $this->path = stripslashes($this->path);
         }
 
 
         // identify ourselves
-        if (empty($this->dav_powered_by)) {
+        if (empty($this->dav_powered_by))
+        {
             header("X-Dav-Powered-By: PHP class: ".get_class($this));
-        } else {
+        }
+        else
+        {
             header("X-Dav-Powered-By: ".$this->dav_powered_by);
         }
 
@@ -274,7 +284,8 @@ 
         // for the motivation for not checking OPTIONS requests on / see
         // http://pear.php.net/bugs/bug.php?id=5363
         if ( (   !(($this->_SERVER['REQUEST_METHOD'] == 'OPTIONS') && ($this->path == "/")))
-             && (!$this->_check_auth())) {
+             && (!$this->_check_auth()))
+        {
             // RFC2518 says we must use Digest instead of Basic
             // but Microsoft Clients do not support Digest
             // and we don't support NTLM and Kerberos
@@ -289,7 +300,8 @@ 
         }
 
         // check
-        if (! $this->_check_if_header_conditions()) {
+        if (! $this->_check_if_header_conditions())
+        {
             return;
         }
 
@@ -298,16 +310,24 @@ 
         $wrapper = "http_".$method;
 
         // activate HEAD emulation by GET if no HEAD method found
-        if ($method == "head" && !method_exists($this, "head")) {
+        if ($method == "head" && !method_exists($this, "head"))
+        {
             $method = "get";
         }
 
-        if (method_exists($this, $wrapper) && ($method == "options" || method_exists($this, $method))) {
+        if (method_exists($this, $wrapper) && ($method == "options" || method_exists($this, $method)))
+        {
             $this->$wrapper();  // call method by name
-        } else { // method not found/implemented
-            if ($this->_SERVER["REQUEST_METHOD"] == "LOCK") {
+        }
+        else
+        {
+// method not found/implemented
+            if ($this->_SERVER["REQUEST_METHOD"] == "LOCK")
+            {
             	$error = '412 Precondition failed';
-            } else {
+            }
+            else
+            {
                 $error = '405 Method not allowed';
                 header("Allow: ".join(", ", $this->_allow()));  // tell client what's allowed
             }
@@ -612,12 +632,14 @@ 
 
         // dav header
         $dav = array(1);        // assume we are always dav class 1 compliant
-        if (isset($allow['LOCK'])) {
+        if (isset($allow['LOCK']))
+        {
             $dav[] = 2;         // dav class 2 requires that locking is supported
         }
 
         // allow extending class to modify DAV and Allow headers
-		if (method_exists($this,'OPTIONS')) {
+		if (method_exists($this,'OPTIONS'))
+		{
 			$this->OPTIONS($this->path,$dav,$allow);
 		}
 
@@ -661,34 +683,48 @@ 
         $options["path"] = $this->path;
 
         // search depth from header (default is "infinity)
-        if (isset($this->_SERVER['HTTP_DEPTH'])) {
+        if (isset($this->_SERVER['HTTP_DEPTH']))
+        {
             $options["depth"] = $this->_SERVER["HTTP_DEPTH"];
-        } else {
+        }
+        else
+        {
             $options["depth"] = "infinity";
         }
 
         // analyze request payload
         $propinfo = new _parse_propfind("php://input", $this->store_request);
-        if ($this->store_request) $this->request = $propinfo->request;
-        if (!$propinfo->success) {
+        if ($this->store_request)
+        {
+        	$this->request = $propinfo->request;
+        }
+        if (!$propinfo->success)
+        {
             $this->http_status("400 Error");
             return;
         }
 		$options['root'] = $propinfo->root;
 		$options['props'] = $propinfo->props;
 		if ($propinfo->filters)
-			$options['filters'] = $propinfo->filters;
+		{
+					$options['filters'] = $propinfo->filters;
+		}
 		if ($propinfo->other)
-			$options['other'] = $propinfo->other;
+		{
+					$options['other'] = $propinfo->other;
+		}
 
         // call user handler
-        if (!($retval =$this->$handler($options, $files))) {
+        if (!($retval =$this->$handler($options, $files)))
+        {
             $files = array("files" => array());
-            if (method_exists($this, "checkLock")) {
+            if (method_exists($this, "checkLock"))
+            {
                 // is locked?
                 $lock = $this->checkLock($this->path);
 
-                if (is_array($lock) && count($lock)) {
+                if (is_array($lock) && count($lock))
+                {
                     $created          = isset($lock['created'])  ? $lock['created']  : time();
                     $modified         = isset($lock['modified']) ? $lock['modified'] : time();
                     $files['files'][] = array("path"  => self::_slashify($this->path),
@@ -702,7 +738,8 @@ 
                 }
             }
 
-            if (empty($files['files'])) {
+            if (empty($files['files']))
+            {
                 $this->http_status("404 Not Found");
                 return;
             }
@@ -736,7 +773,8 @@ 
         $allow = false;
 
         // allow extending class to modify DAV
-		if (method_exists($this,'OPTIONS')) {
+		if (method_exists($this,'OPTIONS'))
+		{
 			$this->OPTIONS($this->path,$dav,$allow);
 		}
         header("DAV: "  .join(", ", $dav));
@@ -775,8 +813,14 @@ 
      */
     function multistatus_responses(&$files, $props, $initial_ns_hash=null, $initial_ns_defs=null)
     {
-    	if (!isset($initial_ns_hash)) $initial_ns_hash = array('DAV:' => 'D');
-    	if (!isset($initial_ns_defs)) $initial_ns_defs = 'xmlns:ns0="urn:uuid:c2f41010-65b3-11d1-a29f-00aa00c14882/"';
+    	if (!isset($initial_ns_hash))
+    	{
+    		$initial_ns_hash = array('DAV:' => 'D');
+    	}
+    	if (!isset($initial_ns_defs))
+    	{
+    		$initial_ns_defs = 'xmlns:ns0="urn:uuid:c2f41010-65b3-11d1-a29f-00aa00c14882/"';
+    	}
 
     	// using an ArrayIterator to prevent foreach from copying the array,
         // as we cant loop by reference, when an iterator is given in $files
@@ -790,10 +834,12 @@ 
         	isset($this->_SERVER['HTTP_PREFER']) && in_array('depth-noroot', preg_split('/, ?/', $this->_SERVER['HTTP_PREFER']));
 
         // now we loop over all returned file entries
-        foreach ($files as $file) {
+        foreach ($files as $file)
+        {
 
         	// skip first element (root), if requested by Prefer: depth-noroot
-        	if ($skip_root) {
+        	if ($skip_root)
+        	{
         		$skip_root = false;
         		continue;
         	}
@@ -805,17 +851,20 @@ 
 	        $ns_defs = $initial_ns_defs;
 
             // nothing to do if no properties were returend for a file
-			if (isset($file["props"]) && is_array($file["props"])) {
+			if (isset($file["props"]) && is_array($file["props"]))
+			{
 
 	            // now loop over all returned properties
-	            foreach ($file["props"] as &$prop) {
+	            foreach ($file["props"] as &$prop)
+	            {
 	                // as a convenience feature we do not require that user handlers
 	                // restrict returned properties to the requested ones
 	                // here we strip all unrequested entries out of the response
 
 	            	// this can happen if we have allprop and prop in one propfind:
 	            	// <allprop /><prop><blah /></prop>, eg. blah is not automatic returned by allprop
-	                switch(is_array($props) ? $props[0] : $props) {
+	                switch(is_array($props) ? $props[0] : $props)
+	                {
 	                case "all":
 	                    // nothing to remove
 	                    break;
@@ -830,16 +879,19 @@ 
 	                    $found = false;
 
 	                    // search property name in requested properties
-	                    foreach ((array)$props as $reqprop) {
+	                    foreach ((array)$props as $reqprop)
+	                    {
 	                        if (   $reqprop["name"]  == $prop["name"]
-	                               && @$reqprop["xmlns"] == $prop["ns"]) {
+	                               && @$reqprop["xmlns"] == $prop["ns"])
+	                        {
 	                            $found = true;
 	                            break;
 	                        }
 	                    }
 
 	                    // unset property and continue with next one if not found/requested
-	                    if (!$found) {
+	                    if (!$found)
+	                    {
 	                        $prop="";
 	                        continue(2);
 	                    }
@@ -847,10 +899,18 @@ 
 	                }
 
 	                // namespace handling
-	                if (empty($prop["ns"])) continue; // no namespace
+	                if (empty($prop["ns"]))
+	                {
+	                	continue;
+	                }
+	                // no namespace
 	                $ns = $prop["ns"];
 	                //if ($ns == "DAV:") continue; // default namespace
-	                if (isset($ns_hash[$ns])) continue; // already known
+	                if (isset($ns_hash[$ns]))
+	                {
+	                	continue;
+	                }
+	                // already known
 
 	                // register namespace
 	                $ns_name = "ns".(count($ns_hash) + 1);
@@ -860,37 +920,50 @@ 
 
 	            // we also need to add empty entries for properties that were requested
 	            // but for which no values where returned by the user handler
-	            if (is_array($props)) {
-	                foreach ($props as $reqprop) {
-	                    if (!is_array($reqprop) || $reqprop['name']=="") continue; // skip empty entries, or 'all' if <allprop /> used together with <prop>
+	            if (is_array($props))
+	            {
+	                foreach ($props as $reqprop)
+	                {
+	                    if (!is_array($reqprop) || $reqprop['name']=="")
+	                    {
+	                    	continue;
+	                    }
+	                    // skip empty entries, or 'all' if <allprop /> used together with <prop>
 
 	                    $found = false;
 
 	                    // check if property exists in result
-	                    foreach ($file["props"] as &$prop) {
+	                    foreach ($file["props"] as &$prop)
+	                    {
 	                        if (is_array($prop) && $reqprop["name"] == $prop["name"]
-	                               && @$reqprop["xmlns"] == $prop["ns"]) {
+	                               && @$reqprop["xmlns"] == $prop["ns"])
+	                        {
 	                            $found = true;
 	                            break;
 	                        }
 	                    }
 
-	                    if (!$found) {
-	                        if ($reqprop["xmlns"]==="DAV:" && $reqprop["name"]==="lockdiscovery") {
+	                    if (!$found)
+	                    {
+	                        if ($reqprop["xmlns"]==="DAV:" && $reqprop["name"]==="lockdiscovery")
+	                        {
 	                            // lockdiscovery is handled by the base class
 	                            $file["props"][]
 	                                = $this->mkprop("DAV:",
 	                                                "lockdiscovery",
 	                                                $this->lockdiscovery($file['path']));
 	                        // only collect $file['noprops'] if we have NO Brief: t and NO Prefer: return=minimal HTTP Header
-	                        } elseif ((!isset($this->_SERVER['HTTP_BRIEF']) || $this->_SERVER['HTTP_BRIEF'] != 't') &&
-	                        	(!isset($this->_SERVER['HTTP_PREFER']) || !in_array('return=minimal', preg_split('/, ?/', $this->_SERVER['HTTP_PREFER'])))) {
+	                        }
+	                        elseif ((!isset($this->_SERVER['HTTP_BRIEF']) || $this->_SERVER['HTTP_BRIEF'] != 't') &&
+	                        	(!isset($this->_SERVER['HTTP_PREFER']) || !in_array('return=minimal', preg_split('/, ?/', $this->_SERVER['HTTP_PREFER']))))
+	                        {
 	                            // add empty value for this property
 	                            $file["noprops"][] =
 	                                $this->mkprop($reqprop["xmlns"], $reqprop["name"], "");
 
 	                            // register property namespace if not known yet
-	                            if ($reqprop["xmlns"] != "DAV:" && !isset($ns_hash[$reqprop["xmlns"]])) {
+	                            if ($reqprop["xmlns"] != "DAV:" && !isset($ns_hash[$reqprop["xmlns"]]))
+	                            {
 	                                $ns_name = "ns".(count($ns_hash) + 1);
 	                                $ns_hash[$reqprop["xmlns"]] = $ns_name;
 	                                $ns_defs .= " xmlns:$ns_name=\"$reqprop[xmlns]\"";
@@ -901,9 +974,15 @@ 
 	            }
 	        }
             // ignore empty or incomplete entries
-            if (!is_array($file) || empty($file) || !isset($file["path"])) continue;
+            if (!is_array($file) || empty($file) || !isset($file["path"]))
+            {
+            	continue;
+            }
             $path = $file['path'];
-            if (!is_string($path) || $path==="") continue;
+            if (!is_string($path) || $path==="")
+            {
+            	continue;
+            }
 
             if ($this->crrnd)
             {
@@ -932,38 +1011,56 @@ 
             }
 
             // report all found properties and their values (if any)
-            if (isset($file["props"]) && is_array($file["props"])) {
+            if (isset($file["props"]) && is_array($file["props"]))
+            {
                 echo '   <'.($this->crrnd?'':'D:')."propstat>\n";
                 echo '    <'.($this->crrnd?'':'D:')."prop>\n";
 
-                foreach ($file["props"] as &$prop) {
+                foreach ($file["props"] as &$prop)
+                {
 
-                    if (!is_array($prop)) continue;
-                    if (!isset($prop["name"])) continue;
+                    if (!is_array($prop))
+                    {
+                    	continue;
+                    }
+                    if (!isset($prop["name"]))
+                    {
+                    	continue;
+                    }
 
-                    if (!isset($prop["val"]) || $prop["val"] === "" || $prop["val"] === false) {
+                    if (!isset($prop["val"]) || $prop["val"] === "" || $prop["val"] === false)
+                    {
                         // empty properties (cannot use empty() for check as "0" is a legal value here)
-                        if ($prop["ns"]=="DAV:") {
+                        if ($prop["ns"]=="DAV:")
+                        {
                             echo '     <'.($this->crrnd?'':'D:')."$prop[name]/>\n";
-                        } else if (!empty($prop["ns"])) {
+                        }
+                        else if (!empty($prop["ns"]))
+                        {
                             echo "     <".$ns_hash[$prop["ns"]].":$prop[name]/>\n";
-                        } else {
+                        }
+                        else
+                        {
                             echo "     <$prop[name] xmlns=\"\"/>";
                         }
                     }
                     // multiple level of responses required for expand-property reports
                     elseif(isset($prop['props']) && is_array($prop['val']))
                     {
-                        if ($prop['ns'] && !isset($ns_hash[$prop['ns']])) {
+                        if ($prop['ns'] && !isset($ns_hash[$prop['ns']]))
+                        {
                             $ns_name = "ns".(count($ns_hash) + 1);
                             $ns_hash[$prop['ns']] = $ns_name;
                         }
                     	echo '     <'.$ns_hash[$prop['ns']].":$prop[name]>\n";
                         $this->multistatus_responses($prop['val'], $prop['props'], $ns_hash, '');
                     	echo '     </'.$ns_hash[$prop['ns']].":$prop[name]>\n";
-                    } else if ($prop["ns"] == "DAV:") {
+                    }
+                    else if ($prop["ns"] == "DAV:")
+                    {
                         // some WebDAV properties need special treatment
-                        switch ($prop["name"]) {
+                        switch ($prop["name"])
+                        {
                         case "creationdate":
                             echo '     <'.($this->crrnd?'':'D:')."creationdate ns0:dt=\"dateTime.tz\">"
                                 . gmdate("Y-m-d\\TH:i:s\\Z", $prop['val'])
@@ -999,40 +1096,57 @@ 
                             {
                             	$hns_hash = $ns_hash;
                             	$val = $this->_hierarchical_prop_encode($prop['val'], 'DAV:', $ns_defs, $hns_hash);
-                            } elseif (isset($prop['raw'])) {
+                            }
+                            elseif (isset($prop['raw']))
+                            {
                             	$val = $this->_prop_encode('<![CDATA['.$prop['val'].']]>');
-                            } else {
+                            }
+                            else
+                            {
 	                    		$val = $this->_prop_encode(htmlspecialchars($prop['val'], ENT_NOQUOTES, 'utf-8'));
                             }
 	                        echo '     <'.($this->crrnd?'':'D:')."$prop[name]$ns_defs>$val".
 	                        	'</'.($this->crrnd?'':'D:')."$prop[name]>\n";
                             break;
                         }
-                    } else {
+                    }
+                    else
+                    {
                         // allow multiple values and attributes, required eg. for caldav:supported-calendar-component-set
-                        if ($prop['ns'] && is_array($prop['val'])) {
-                    		if (!isset($ns_hash[$prop['ns']])) {
+                        if ($prop['ns'] && is_array($prop['val']))
+                        {
+                    		if (!isset($ns_hash[$prop['ns']]))
+                    		{
                                 $ns_name = "ns".(count($ns_hash) + 1);
                                 $ns_hash[$prop['ns']] = $ns_name;
                     		}
                   			$vals = $extra_ns = '';
                     		foreach($prop['val'] as $subprop)
                     		{
-                    			if ($subprop['ns'] && $subprop['ns'] != 'DAV:') {
+                    			if ($subprop['ns'] && $subprop['ns'] != 'DAV:')
+                    			{
 		                    		// register property namespace if not known yet
-		                    		if (!isset($ns_hash[$subprop['ns']])) {
+		                    		if (!isset($ns_hash[$subprop['ns']]))
+		                    		{
 			                    		$ns_name = "ns".(count($ns_hash) + 1);
 			                    		$ns_hash[$subprop['ns']] = $ns_name;
-		                    		} else {
+		                    		}
+		                    		else
+		                    		{
 			                    		$ns_name = $ns_hash[$subprop['ns']];
 		                    		}
-		                    		if (strchr($extra_ns,$extra=' xmlns:'.$ns_name.'="'.$subprop['ns'].'"') === false) {
+		                    		if (strchr($extra_ns,$extra=' xmlns:'.$ns_name.'="'.$subprop['ns'].'"') === false)
+		                    		{
 			                    		$extra_ns .= $extra;
 		                    		}
 		                    		$ns_name .= ':';
-	                    		} elseif ($subprop['ns'] == 'DAV:') {
+	                    		}
+	                    		elseif ($subprop['ns'] == 'DAV:')
+	                    		{
 		                    		$ns_name = 'D:';
-	                    		} else {
+	                    		}
+	                    		else
+	                    		{
 		                    		$ns_name = '';
 	                    		}
 	                    		$vals .= "<$ns_name$subprop[name]";
@@ -1047,7 +1161,7 @@ 
 	                    			else	// val contains only attributes, no value
 	                    			{
 			                    		foreach($subprop['val'] as $attr => $val)
-										{
+			                    		{
 				                    		$vals .= ' '.$attr.'="'.htmlspecialchars($val, ENT_NOQUOTES, 'utf-8').'"';
 										}
 			                    		$vals .= '/>';
@@ -1056,34 +1170,50 @@ 
 	                    		else
 	                    		{
 	                    			$vals .= '>';
-	                    			if (isset($subprop['raw'])) {
+	                    			if (isset($subprop['raw']))
+	                    			{
 	                    				$vals .= '<![CDATA['.$subprop['val'].']]>';
-	                    			} else {
-	                    				if($subprop['name'] == 'href') $subprop['val'] = $this->_urlencode($subprop['val']);
+	                    			}
+	                    			else
+	                    			{
+	                    				if($subprop['name'] == 'href')
+	                    				{
+	                    					$subprop['val'] = $this->_urlencode($subprop['val']);
+	                    				}
 		                    			$vals .= htmlspecialchars($subprop['val'], ENT_NOQUOTES, 'utf-8');
 	                    			}
 	                    			$vals .= "</$ns_name$subprop[name]>";
 	                    		}
                     		}
                     		echo '     <'.$ns_hash[$prop['ns']].":$prop[name]$extra_ns>$vals</".$ns_hash[$prop['ns']].":$prop[name]>\n";
-                        } else {
+                        }
+                        else
+                        {
                         	if ($prop['raw'])
                         	{
                         		$val = '<![CDATA['.$prop['val'].']]>';
-                        	} else {
+                        	}
+                        	else
+                        	{
                         		$val = htmlspecialchars($prop['val'], ENT_NOQUOTES, 'utf-8');
                         	}
                         	$val = $this->_prop_encode($val);
 	                        // properties from namespaces != "DAV:" or without any namespace
-	                        if ($prop['ns']) {
-		                        if ($this->crrnd) {
+	                        if ($prop['ns'])
+	                        {
+		                        if ($this->crrnd)
+		                        {
 			                        echo "     <$prop[name] xmlns=".'"'.$prop["ns"].'">'
 									. $val . "</$prop[name]>\n";
-		                        } else {
+		                        }
+		                        else
+		                        {
 			                        echo "     <" . $ns_hash[$prop["ns"]] . ":$prop[name]>"
 									. $val . '</'.$ns_hash[$prop['ns']].":$prop[name]>\n";
 		                        }
-	                        } else {
+	                        }
+	                        else
+	                        {
 		                        echo "     <$prop[name] xmlns=\"\">$val</$prop[name]>\n";
 	                        }
                         }
@@ -1105,16 +1235,23 @@ 
             }
 
             // now report all properties requested but not found
-            if (isset($file["noprops"])) {
+            if (isset($file["noprops"]))
+            {
                 echo '   <'.($this->crrnd?'':'D:')."propstat>\n";
                 echo '    <'.($this->crrnd?'':'D:')."prop>\n";
 
-                foreach ($file["noprops"] as &$prop) {
-                    if ($prop["ns"] == "DAV:") {
+                foreach ($file["noprops"] as &$prop)
+                {
+                    if ($prop["ns"] == "DAV:")
+                    {
                         echo '     <'.($this->crrnd?'':'D:')."$prop[name]/>\n";
-                    } else if ($prop["ns"] == "") {
+                    }
+                    else if ($prop["ns"] == "")
+                    {
                         echo "     <$prop[name] xmlns=\"\"/>\n";
-                    } else {
+                    }
+                    else
+                    {
                         echo "     <" . $ns_hash[$prop["ns"]] . ":$prop[name]/>\n";
                     }
                 }
@@ -1163,15 +1300,20 @@ 
      */
     function http_PROPPATCH()
     {
-        if ($this->_check_lock_status($this->path)) {
+        if ($this->_check_lock_status($this->path))
+        {
             $options = Array();
 
             $options["path"] = $this->path;
 
             $propinfo = new _parse_proppatch("php://input", $this->store_request);
-            if ($this->store_request) $this->request = $propinfo->request;
+            if ($this->store_request)
+            {
+            	$this->request = $propinfo->request;
+            }
 
-            if (!$propinfo->success) {
+            if (!$propinfo->success)
+            {
                 $this->http_status("400 Error");
                 return;
             }
@@ -1189,14 +1331,16 @@ 
             echo ' <'.($this->crrnd?'':'D:')."response>\n";
             echo '  <'.($this->crrnd?'':'D:')."href>".$this->_urlencode($this->_mergePaths($this->_SERVER["SCRIPT_NAME"], $this->path)).'</'.($this->crrnd?'':'D:')."href>\n";
 
-            foreach ($options["props"] as $prop) {
+            foreach ($options["props"] as $prop)
+            {
                 echo '   <'.($this->crrnd?'':'D:')."propstat>\n";
                 echo '    <'.($this->crrnd?'':'D:')."prop><$prop[name] xmlns=\"$prop[ns]\"/></".($this->crrnd?'':'D:')."prop>\n";
                 echo '    <'.($this->crrnd?'':'D:')."status>HTTP/1.1 $prop[status]</".($this->crrnd?'':'D:')."status>\n";
                 echo '   </'.($this->crrnd?'':'D:')."propstat>\n";
             }
 
-            if ($responsedescr) {
+            if ($responsedescr)
+            {
                 echo '  <'.($this->crrnd?'':'D:')."responsedescription>".
                     $this->_prop_encode(htmlspecialchars($responsedescr, ENT_NOQUOTES, 'utf-8')).
                     '</'.($this->crrnd?'':'D:')."responsedescription>\n";
@@ -1204,7 +1348,9 @@ 
 
             echo ' </'.($this->crrnd?'':'D:')."response>\n";
             echo '</'.($this->crrnd?'':'D:')."multistatus>\n";
-        } else {
+        }
+        else
+        {
             $this->http_status("423 Locked");
         }
     }
@@ -1274,11 +1420,14 @@ 
 
         $this->_get_ranges($options);
 
-        if (true === ($status = $this->GET($options))) {
-            if (!headers_sent()) {
+        if (true === ($status = $this->GET($options)))
+        {
+            if (!headers_sent())
+            {
                 $status = "200 OK";
 
-                if (!isset($options['mimetype'])) {
+                if (!isset($options['mimetype']))
+                {
                     $options['mimetype'] = "application/octet-stream";
                 }
                 // switching off zlib.output_compression for everything but text files,
@@ -1290,7 +1439,8 @@ 
                 }
                 header("Content-type: $options[mimetype]");
 
-                if (isset($options['mtime'])) {
+                if (isset($options['mtime']))
+                {
                     header("Last-modified:".gmdate("D, d M Y H:i:s ", $options['mtime'])."GMT");
                 }
                 // fix for IE and https, thanks to rob_burcham@yahoo.com
@@ -1299,55 +1449,82 @@ 
 				header("Cache-Control: maxage=1"); //In seconds
 				header("Pragma: public");
 
-                if (isset($options['stream'])) {
+                if (isset($options['stream']))
+                {
                     // GET handler returned a stream
-                    if (!empty($options['ranges']) && (0===fseek($options['stream'], 0, SEEK_SET))) {
+                    if (!empty($options['ranges']) && (0===fseek($options['stream'], 0, SEEK_SET)))
+                    {
                         // partial request and stream is seekable
 
-                        if (count($options['ranges']) === 1) {
+                        if (count($options['ranges']) === 1)
+                        {
                             $range = $options['ranges'][0];
 
-                            if (isset($range['start'])) {
+                            if (isset($range['start']))
+                            {
                                 fseek($options['stream'], $range['start'], SEEK_SET);
-                                if (feof($options['stream'])) {
+                                if (feof($options['stream']))
+                                {
                                     $this->http_status("416 Requested range not satisfiable");
                                     return;
                                 }
 
-                                if (!empty($range['end'])) {
+                                if (!empty($range['end']))
+                                {
                                     $size = $range['end']-$range['start']+1;
                                     $this->http_status("206 Partial content");
-                                    if (!self::use_compression()) header("Content-Length: $size");
+                                    if (!self::use_compression())
+                                    {
+                                    	header("Content-Length: $size");
+                                    }
                                     header("Content-Range: bytes $range[start]-$range[end]/"
                                            . (isset($options['size']) ? $options['size'] : "*"));
-                                    while ($size > 0 && !feof($options['stream'])) {
+                                    while ($size > 0 && !feof($options['stream']))
+                                    {
                                         $buffer = fread($options['stream'], $size < 8192 ? $size : 8192);
                                         $size  -= self::bytes($buffer);
                                         echo $buffer;
                                     }
-                                } else {
+                                }
+                                else
+                                {
                                     $this->http_status("206 Partial content");
-                                    if (isset($options['size'])) {
-                                        if (!self::use_compression()) header("Content-Length: ".($options['size'] - $range['start']));
+                                    if (isset($options['size']))
+                                    {
+                                        if (!self::use_compression())
+                                        {
+                                        	header("Content-Length: ".($options['size'] - $range['start']));
+                                        }
                                         header("Content-Range: bytes ".$range['start']."-".
 											(isset($options['size']) ? $options['size']-1 : "")."/"
 										   . (isset($options['size']) ? $options['size'] : "*"));
                                     }
                                     fpassthru($options['stream']);
                                 }
-                            } else {
-                                if (!self::use_compression()) header("Content-length: ".$range['last']);
+                            }
+                            else
+                            {
+                                if (!self::use_compression())
+                                {
+                                	header("Content-length: ".$range['last']);
+                                }
                                 fseek($options['stream'], -$range['last'], SEEK_END);
                                 fpassthru($options['stream']);
                             }
-                        } else {
+                        }
+                        else
+                        {
                             $this->_multipart_byterange_header(); // init multipart
-                            foreach ($options['ranges'] as $range) {
+                            foreach ($options['ranges'] as $range)
+                            {
                                 // TODO what if size unknown? 500?
-                                if (isset($range['start'])) {
+                                if (isset($range['start']))
+                                {
                                     $from = $range['start'];
                                     $to   = !empty($range['end']) ? $range['end'] : $options['size']-1;
-                                } else {
+                                }
+                                else
+                                {
                                     $from = $options['size'] - $range['last']-1;
                                     $to   = $options['size'] -1;
                                 }
@@ -1357,7 +1534,8 @@ 
 
 
                                 fseek($options['stream'], $from, SEEK_SET);
-                                while ($size && !feof($options['stream'])) {
+                                while ($size && !feof($options['stream']))
+                                {
                                     $buffer = fread($options['stream'], 4096);
                                     $size  -= self::bytes($buffer);
                                     echo $buffer;
@@ -1365,29 +1543,44 @@ 
                             }
                             $this->_multipart_byterange_header(); // end multipart
                         }
-                    } else {
+                    }
+                    else
+                    {
                         // normal request or stream isn't seekable, return full content
-                        if (isset($options['size']) && !self::use_compression()) {
+                        if (isset($options['size']) && !self::use_compression())
+                        {
                             header("Content-Length: ".$options['size']);
                         }
                         fpassthru($options['stream']);
                         return; // no more headers
                     }
-                } elseif (isset($options['data'])) {
-                    if (is_array($options['data'])) {
+                }
+                elseif (isset($options['data']))
+                {
+                    if (is_array($options['data']))
+                    {
                         // reply to partial request
-                    } else {
-                        if (!self::use_compression()) header("Content-Length: ".self::bytes($options['data']));
+                    }
+                    else
+                    {
+                        if (!self::use_compression())
+                        {
+                        	header("Content-Length: ".self::bytes($options['data']));
+                        }
                         echo $options['data'];
                     }
                 }
             }
         }
 
-        if (!headers_sent()) {
-            if (false === $status) {
+        if (!headers_sent())
+        {
+            if (false === $status)
+            {
                 $this->http_status("404 not found");
-            } else {
+            }
+            else
+            {
                 // TODO: check setting of headers in various code paths above
                 $this->http_status("$status");
             }
@@ -1404,15 +1597,18 @@ 
     function _get_ranges(&$options)
     {
         // process Range: header if present
-        if (isset($this->_SERVER['HTTP_RANGE'])) {
+        if (isset($this->_SERVER['HTTP_RANGE']))
+        {
 
             // we only support standard "bytes" range specifications for now
 			$matches = null;
-            if (preg_match('/bytes\s*=\s*(.+)/', $this->_SERVER['HTTP_RANGE'], $matches)) {
+            if (preg_match('/bytes\s*=\s*(.+)/', $this->_SERVER['HTTP_RANGE'], $matches))
+            {
                 $options["ranges"] = array();
 
                 // ranges are comma separated
-                foreach (explode(",", $matches[1]) as $range) {
+                foreach (explode(",", $matches[1]) as $range)
+                {
                     // ranges are either from-to pairs or just end positions
                     list($start, $end) = explode("-", $range);
                     $options["ranges"][] = ($start==="")
@@ -1438,8 +1634,10 @@ 
      */
     function _multipart_byterange_header($mimetype = false, $from = false, $to=false, $total=false)
     {
-        if ($mimetype === false) {
-            if (!isset($this->multipart_separator)) {
+        if ($mimetype === false)
+        {
+            if (!isset($this->multipart_separator))
+            {
                 // initial
 
                 // a little naive, this sequence *might* be part of the content
@@ -1448,13 +1646,17 @@ 
 
                 // generate HTTP header
                 header("Content-type: multipart/byteranges; boundary=".$this->multipart_separator);
-            } else {
+            }
+            else
+            {
                 // final
 
                 // generate closing multipart sequence
                 echo "\n--{$this->multipart_separator}--";
             }
-        } else {
+        }
+        else
+        {
             // generate separator and header for next part
             echo "\n--{$this->multipart_separator}\n";
             echo "Content-type: $mimetype\n";
@@ -1481,32 +1683,45 @@ 
         $options         = Array();
         $options["path"] = $this->path;
 
-        if (method_exists($this, "HEAD")) {
+        if (method_exists($this, "HEAD"))
+        {
             $status = $this->head($options);
-        } else if (method_exists($this, "GET")) {
+        }
+        else if (method_exists($this, "GET"))
+        {
             ob_start();
             $status = $this->GET($options);
-            if (!isset($options['size'])) {
+            if (!isset($options['size']))
+            {
                 $options['size'] = ob_get_length();
             }
             ob_end_clean();
         }
 
-        if (!isset($options['mimetype'])) {
+        if (!isset($options['mimetype']))
+        {
             $options['mimetype'] = "application/octet-stream";
         }
         header("Content-type: $options[mimetype]");
 
-        if (isset($options['mtime'])) {
+        if (isset($options['mtime']))
+        {
             header("Last-modified:".gmdate("D, d M Y H:i:s ", $options['mtime'])."GMT");
         }
 
-        if (isset($options['size'])) {
+        if (isset($options['size']))
+        {
             header("Content-Length: ".$options['size']);
         }
 
-        if ($status === true)  $status = "200 OK";
-        if ($status === false) $status = "404 Not found";
+        if ($status === true)
+        {
+        	$status = "200 OK";
+        }
+        if ($status === false)
+        {
+        	$status = "404 Not found";
+        }
 
         $this->http_status($status);
     }
@@ -1532,21 +1747,25 @@ 
 	        $options['content_length'] = $this->_SERVER['CONTENT_LENGTH'];
         }
         elseif (isset($this->_SERVER['X-Expected-Entity-Length']))
-		{
+        {
 	        // MacOS gives us that hint
 	        $options['content_length'] = $this->_SERVER['X-Expected-Entity-Length'];
 		}
 
         // get the Content-type
-        if (isset($this->_SERVER["CONTENT_TYPE"])) {
+        if (isset($this->_SERVER["CONTENT_TYPE"]))
+        {
 	        // for now we do not support any sort of multipart requests
-	        if (!strncmp($this->_SERVER["CONTENT_TYPE"], 'multipart/', 10)) {
+	        if (!strncmp($this->_SERVER["CONTENT_TYPE"], 'multipart/', 10))
+	        {
 		        $this->http_status('501 not implemented');
 		        echo 'The service does not support mulipart POST requests';
 		        return;
 	        }
 	        $options['content_type'] = $this->_SERVER['CONTENT_TYPE'];
-        } else {
+        }
+        else
+        {
 	        // default content type if none given
 	        $options['content_type'] = 'application/octet-stream';
         }
@@ -1557,7 +1776,7 @@ 
     		case 'gzip':
     		case 'deflate':	//zlib
     			if (extension_loaded('zlib'))
-     			{
+    			{
       				stream_filter_append($options['stream'], 'zlib.inflate', STREAM_FILTER_READ);
        			}
     	}
@@ -1578,15 +1797,23 @@ 
          does not understand or implement and MUST return a 501
          (Not Implemented) response in such cases."
          */
-        foreach ($this->_SERVER as $key => $val) {
-	        if (strncmp($key, 'HTTP_CONTENT', 11)) continue;
-	        switch ($key) {
+        foreach ($this->_SERVER as $key => $val)
+        {
+	        if (strncmp($key, 'HTTP_CONTENT', 11))
+	        {
+	        	continue;
+	        }
+	        switch ($key)
+	        {
 		        case 'HTTP_CONTENT_ENCODING': // RFC 2616 14.11
 		        	switch($this->_SERVER['HTTP_CONTENT_ENCODING'])
 		        	{
 		        		case 'gzip':
 		        		case 'deflate':	//zlib
-		        			if (extension_loaded('zlib')) break;
+		        			if (extension_loaded('zlib'))
+		        			{
+		        				break;
+		        			}
 		        			// fall through for no zlib support
 		        		default:
 					        $this->http_status('415 Unsupported Media Type');
@@ -1616,14 +1843,16 @@ 
 			        // the header format is also specified in RFC 2616 14.16
 			        // TODO we have to ensure that implementations support this or send 501 instead
 					$matches = null;
-			        if (!preg_match('@bytes\s+(\d+)-(\d+)/((\d+)|\*)@', $val, $matches)) {
+			        if (!preg_match('@bytes\s+(\d+)-(\d+)/((\d+)|\*)@', $val, $matches))
+			        {
 				        $this->http_status('400 bad request');
 				        echo 'The service does only support single byte ranges';
 				        return;
 			        }
 
 			        $range = array('start'=>$matches[1], 'end'=>$matches[2]);
-			        if (is_numeric($matches[3])) {
+			        if (is_numeric($matches[3]))
+			        {
 				        $range['total_length'] = $matches[3];
 			        }
 			        $options['ranges'][] = $range;
@@ -1655,31 +1884,46 @@ 
 	        }
         }
 
-        if (method_exists($this, 'POST')) {
+        if (method_exists($this, 'POST'))
+        {
 	        $status = $this->POST($options);
 
-	        if ($status === false) {
+	        if ($status === false)
+	        {
 		        $status = '400 Something went wrong';
-	        } else if ($status === true) {
+	        }
+	        else if ($status === true)
+	        {
 	        	$status = '200 OK';
-	        } else if (is_resource($status) && get_resource_type($status) == 'stream') {
+	        }
+	        else if (is_resource($status) && get_resource_type($status) == 'stream')
+	        {
 		        $stream = $status;
 
 		        $status = empty($options['new']) ? '200 OK' : '201 Created';
 
-		        if (!empty($options['ranges'])) {
+		        if (!empty($options['ranges']))
+		        {
 			        // TODO multipart support is missing (see also above)
-			        if (0 == fseek($stream, $range[0]['start'], SEEK_SET)) {
+			        if (0 == fseek($stream, $range[0]['start'], SEEK_SET))
+			        {
 				        $length = $range[0]['end']-$range[0]['start']+1;
-				        if (!fwrite($stream, fread($options['stream'], $length))) {
+				        if (!fwrite($stream, fread($options['stream'], $length)))
+				        {
 					        $status = '403 Forbidden';
 				        }
-			        } else {
+			        }
+			        else
+			        {
 				        $status = '403 Forbidden';
 			        }
-		        } else {
-			        while (!feof($options['stream'])) {
-				        if (false === fwrite($stream, fread($options['stream'], 4096))) {
+		        }
+		        else
+		        {
+			        while (!feof($options['stream']))
+			        {
+				        if (false === fwrite($stream, fread($options['stream'], 4096)))
+				        {
 					        $status = '403 Forbidden';
 					        break;
 				        }
@@ -1703,7 +1947,8 @@ 
      */
     function http_PUT()
     {
-        if ($this->_check_lock_status($this->path)) {
+        if ($this->_check_lock_status($this->path))
+        {
             $options                   = Array();
             $options["path"]           = $this->path;
 
@@ -1718,15 +1963,19 @@ 
             }
 
             // get the Content-type
-            if (isset($this->_SERVER["CONTENT_TYPE"])) {
+            if (isset($this->_SERVER["CONTENT_TYPE"]))
+            {
                 // for now we do not support any sort of multipart requests
-                if (!strncmp($this->_SERVER["CONTENT_TYPE"], "multipart/", 10)) {
+                if (!strncmp($this->_SERVER["CONTENT_TYPE"], "multipart/", 10))
+                {
                     $this->http_status("501 not implemented");
                     echo "The service does not support multipart PUT requests";
                     return;
                 }
                 $options["content_type"] = $this->_SERVER["CONTENT_TYPE"];
-            } else {
+            }
+            else
+            {
                 // default content type if none given
                 $options["content_type"] = "application/octet-stream";
             }
@@ -1737,7 +1986,7 @@ 
 	    		case 'gzip':
 	    		case 'deflate':	//zlib
 	    			if (extension_loaded('zlib'))
-	     			{
+	    			{
 	      				stream_filter_append($options['stream'], 'zlib.inflate', STREAM_FILTER_READ);
 	       			}
 	    	}
@@ -1758,15 +2007,23 @@ 
              does not understand or implement and MUST return a 501
              (Not Implemented) response in such cases."
             */
-            foreach ($this->_SERVER as $key => $val) {
-                if (strncmp($key, "HTTP_CONTENT", 11)) continue;
-                switch ($key) {
+            foreach ($this->_SERVER as $key => $val)
+            {
+                if (strncmp($key, "HTTP_CONTENT", 11))
+                {
+                	continue;
+                }
+                switch ($key)
+                {
                 case 'HTTP_CONTENT_ENCODING': // RFC 2616 14.11
 		        	switch($this->_SERVER['HTTP_CONTENT_ENCODING'])
 		        	{
 		        		case 'gzip':
 		        		case 'deflate':	//zlib
-		        			if (extension_loaded('zlib')) break;
+		        			if (extension_loaded('zlib'))
+		        			{
+		        				break;
+		        			}
 		        			// fall through for no zlib support
 		        		default:
 					        $this->http_status('415 Unsupported Media Type');
@@ -1796,18 +2053,21 @@ 
                     // the header format is also specified in RFC 2616 14.16
                     // TODO we have to ensure that implementations support this or send 501 instead
 					$matches = null;
-                    if (!preg_match('@bytes\s+(\d+)-(\d+)/((\d+)|\*)@', $val, $matches)) {
+                    if (!preg_match('@bytes\s+(\d+)-(\d+)/((\d+)|\*)@', $val, $matches))
+                    {
                         $this->http_status("400 bad request");
                         echo "The service does only support single byte ranges";
                         return;
                     }
 
                     $range = array("start" => $matches[1], "end" => $matches[2]);
-                    if (is_numeric($matches[3])) {
+                    if (is_numeric($matches[3]))
+                    {
                         $range["total_length"] = $matches[3];
                     }
 
-                    if (!isset($options['ranges'])) {
+                    if (!isset($options['ranges']))
+                    {
                         $options['ranges'] = array();
                     }
 
@@ -1838,45 +2098,65 @@ 
 
             $stat = $this->PUT($options);
 
-            if ($stat === false) {
+            if ($stat === false)
+            {
                 $stat = "403 Forbidden";
-            } else if (is_resource($stat) && get_resource_type($stat) == "stream") {
+            }
+            else if (is_resource($stat) && get_resource_type($stat) == "stream")
+            {
                 $stream = $stat;
 
                 $stat = $options["new"] ? "201 Created" : "204 No Content";
 
-                if (!empty($options["ranges"])) {
+                if (!empty($options["ranges"]))
+                {
                     // TODO multipart support is missing (see also above)
-                    if (0 == fseek($stream, $options['ranges'][0]["start"], SEEK_SET)) {
+                    if (0 == fseek($stream, $options['ranges'][0]["start"], SEEK_SET))
+                    {
                         $length = $options['ranges'][0]["end"] - $options['ranges'][0]["start"]+1;
 
-                        while (!feof($options['stream'])) {
-                            if ($length <= 0) {
+                        while (!feof($options['stream']))
+                        {
+                            if ($length <= 0)
+                            {
                                break;
                             }
 
-                            if ($length <= 8192) {
+                            if ($length <= 8192)
+                            {
                                 $data = fread($options['stream'], $length);
-                            } else {
+                            }
+                            else
+                            {
                                 $data = fread($options['stream'], 8192);
                             }
 
-                            if ($data === false) {
+                            if ($data === false)
+                            {
                                 $stat = "400 Bad request";
-                            } elseif (strlen($data)) {
-                                if (false === fwrite($stream, $data)) {
+                            }
+                            elseif (strlen($data))
+                            {
+                                if (false === fwrite($stream, $data))
+                                {
                                     $stat = "403 Forbidden";
                                     break;
                                 }
                                 $length -= strlen($data);
                             }
                         }
-                    } else {
+                    }
+                    else
+                    {
                         $stat = "403 Forbidden";
                     }
-                } else {
-                    while (!feof($options["stream"])) {
-                        if (false === fwrite($stream, fread($options["stream"], 8192))) {
+                }
+                else
+                {
+                    while (!feof($options["stream"]))
+                    {
+                        if (false === fwrite($stream, fread($options["stream"], 8192)))
+                        {
                             $stat = "403 Forbidden";
                             break;
                         }
@@ -1887,7 +2167,9 @@ 
             }
 
             $this->http_status($stat);
-        } else {
+        }
+        else
+        {
             $this->http_status("423 Locked");
         }
     }
@@ -1906,8 +2188,10 @@ 
     function http_DELETE()
     {
         // check RFC 2518 Section 9.2, last paragraph
-        if (isset($this->_SERVER["HTTP_DEPTH"])) {
-            if ($this->_SERVER["HTTP_DEPTH"] != "infinity") {
+        if (isset($this->_SERVER["HTTP_DEPTH"]))
+        {
+            if ($this->_SERVER["HTTP_DEPTH"] != "infinity")
+            {
 				if (stripos($_SERVER['HTTP_USER_AGENT'],'webdrive') !== false)
 				{
 					// pretend we didnt see it, as webdrive does not handle the depth parameter correctly while deleting collections
@@ -1921,7 +2205,8 @@ 
         }
 
         // check lock status
-        if ($this->_check_lock_status($this->path)) {
+        if ($this->_check_lock_status($this->path))
+        {
             // ok, proceed
             $options         = Array();
             $options["path"] = $this->path;
@@ -1929,7 +2214,9 @@ 
             $stat = $this->DELETE($options);
 
             $this->http_status($stat);
-        } else {
+        }
+        else
+        {
             // sorry, its locked
             $this->http_status("423 Locked");
         }
@@ -1964,10 +2251,13 @@ 
      */
     function http_MOVE()
     {
-        if ($this->_check_lock_status($this->path)) {
+        if ($this->_check_lock_status($this->path))
+        {
             // destination lock status is always checked by the helper method
             $this->_copymove("move");
-        } else {
+        }
+        else
+        {
             $this->http_status("423 Locked");
         }
     }
@@ -1988,19 +2278,25 @@ 
         $options         = Array();
         $options["path"] = $this->path;
 
-        if (isset($this->_SERVER['HTTP_DEPTH'])) {
+        if (isset($this->_SERVER['HTTP_DEPTH']))
+        {
             $options["depth"] = $this->_SERVER["HTTP_DEPTH"];
-        } else {
+        }
+        else
+        {
             $options["depth"] = "infinity";
         }
 
-        if (isset($this->_SERVER["HTTP_TIMEOUT"])) {
+        if (isset($this->_SERVER["HTTP_TIMEOUT"]))
+        {
             $options["timeout"] = explode(",", $this->_SERVER["HTTP_TIMEOUT"]);
         }
 
-        if (empty($this->_SERVER['CONTENT_LENGTH']) && !empty($this->_SERVER['HTTP_IF'])) {
+        if (empty($this->_SERVER['CONTENT_LENGTH']) && !empty($this->_SERVER['HTTP_IF']))
+        {
             // check if locking is possible
-            if (!$this->_check_lock_status($this->path)) {
+            if (!$this->_check_lock_status($this->path))
+            {
                 $this->http_status("423 Locked");
                 return;
             }
@@ -2016,15 +2312,19 @@ 
 
 
             $stat = $this->LOCK($options);
-        } else {
+        }
+        else
+        {
             // extract lock request information from request XML payload
             $lockinfo = new _parse_lockinfo("php://input");
-            if (!$lockinfo->success) {
+            if (!$lockinfo->success)
+            {
                 $this->http_status("400 bad request");
             }
 
             // check if locking is possible
-            if (!$this->_check_lock_status($this->path, $lockinfo->lockscope === "shared")) {
+            if (!$this->_check_lock_status($this->path, $lockinfo->lockscope === "shared"))
+            {
                 $this->http_status("423 Locked");
                 return;
             }
@@ -2039,36 +2339,51 @@ 
             $stat = $this->LOCK($options);
         }
 
-        if (is_bool($stat)) {
+        if (is_bool($stat))
+        {
             $http_stat = $stat ? "200 OK" : "423 Locked";
-        } else {
+        }
+        else
+        {
             $http_stat = (string)$stat;
         }
         $this->http_status($http_stat);
 
-        if ($http_stat{0} == 2) { // 2xx states are ok
-            if ($options["timeout"]) {
+        if ($http_stat{0} == 2)
+        {
+// 2xx states are ok
+            if ($options["timeout"])
+            {
                 // if multiple timeout values were given we take the first only
-                if (is_array($options["timeout"])) {
+                if (is_array($options["timeout"]))
+                {
                     reset($options["timeout"]);
                     $options["timeout"] = current($options["timeout"]);
                 }
                 // if the timeout is numeric only we need to reformat it
-                if (is_numeric($options["timeout"])) {
+                if (is_numeric($options["timeout"]))
+                {
                     // more than a million is considered an absolute timestamp
                     // less is more likely a relative value
-                    if ($options["timeout"]>1000000) {
+                    if ($options["timeout"]>1000000)
+                    {
                         $timeout = "Second-".($options['timeout']-time());
-                    } else {
+                    }
+                    else
+                    {
                         $timeout = "Second-$options[timeout]";
                     }
-                } else {
+                }
+                else
+                {
                     // non-numeric values are passed on verbatim,
                     // no error checking is performed here in this case
                     // TODO: send "Infinite" on invalid timeout strings?
                     $timeout = $options["timeout"];
                 }
-            } else {
+            }
+            else
+            {
                 $timeout = "Infinite";
             }
 
@@ -2106,9 +2421,12 @@ 
         $options         = Array();
         $options["path"] = $this->path;
 
-        if (isset($this->_SERVER['HTTP_DEPTH'])) {
+        if (isset($this->_SERVER['HTTP_DEPTH']))
+        {
             $options["depth"] = $this->_SERVER["HTTP_DEPTH"];
-        } else {
+        }
+        else
+        {
             $options["depth"] = "infinity";
         }
 
@@ -2137,9 +2455,12 @@ 
         $options['path'] = $this->path;
         $options['errors'] = array();
 
-        if (isset($this->_SERVER['HTTP_DEPTH'])) {
+        if (isset($this->_SERVER['HTTP_DEPTH']))
+        {
             $options['depth'] = $this->_SERVER['HTTP_DEPTH'];
-        } else {
+        }
+        else
+        {
             $options['depth'] = 'infinity';
         }
 
@@ -2150,18 +2471,26 @@ 
 		$this->http_status($status);
 		$content = '';
 
-        if (is_array($options['errors']) && count($options['errors'])) {
+        if (is_array($options['errors']) && count($options['errors']))
+        {
 	        header('Content-Type: text/xml; charset="utf-8"');
 	        // ... and payload
 	        $content .= "<?xml version=\"1.0\" encoding=\"utf-8\"?>\n";
 	        $content .= "<D:error xmlns:D=\"DAV:\"> \n";
-	        foreach ($options['errors'] as $violation) {
+	        foreach ($options['errors'] as $violation)
+	        {
 	        	$content .= '<'.($this->crrnd?'':'D:')."$violation/>\n";
 	        }
 	        $content .=  '</'.($this->crrnd?'':'D:')."error>\n";
         }
-        if (!self::use_compression()) header("Content-Length: ".self::bytes($content));
-        if ($content) echo $options['content'];
+        if (!self::use_compression())
+        {
+        	header("Content-Length: ".self::bytes($content));
+        }
+        if ($content)
+        {
+        	echo $options['content'];
+        }
     }
 
     // }}}
@@ -2175,9 +2504,12 @@ 
         $options         = Array();
         $options["path"] = $this->path;
 
-        if (isset($this->_SERVER["HTTP_DEPTH"])) {
+        if (isset($this->_SERVER["HTTP_DEPTH"]))
+        {
             $options["depth"] = $this->_SERVER["HTTP_DEPTH"];
-        } else {
+        }
+        else
+        {
             $options["depth"] = "infinity";
         }
 
@@ -2186,33 +2518,45 @@ 
         $url  = parse_url($this->_SERVER["HTTP_DESTINATION"]);
         $path = urldecode($url["path"]);
 
-        if (isset($url["host"])) {
+        if (isset($url["host"]))
+        {
             // TODO check url scheme, too
             $http_host = $url["host"];
             if (isset($url["port"]) && $url["port"] != 80)
-                $http_host.= ":".$url["port"];
-        } else {
+            {
+                            $http_host.= ":".$url["port"];
+            }
+        }
+        else
+        {
             // only path given, set host to self
             $http_host = $http_header_host;
         }
 
         if ($http_host == $http_header_host &&
             !strncmp($this->_SERVER["SCRIPT_NAME"], $path,
-                     strlen($this->_SERVER["SCRIPT_NAME"]))) {
+                     strlen($this->_SERVER["SCRIPT_NAME"])))
+        {
             $options["dest"] = substr($path, strlen($this->_SERVER["SCRIPT_NAME"]));
-            if (!$this->_check_lock_status($options["dest"])) {
+            if (!$this->_check_lock_status($options["dest"]))
+            {
                 $this->http_status("423 Locked");
                 return;
             }
 
-        } else {
+        }
+        else
+        {
             $options["dest_url"] = $this->_SERVER["HTTP_DESTINATION"];
         }
 
         // see RFC 2518 Sections 9.6, 8.8.4 and 8.9.3
-        if (isset($this->_SERVER["HTTP_OVERWRITE"])) {
+        if (isset($this->_SERVER["HTTP_OVERWRITE"]))
+        {
             $options["overwrite"] = $this->_SERVER["HTTP_OVERWRITE"] == "T";
-        } else {
+        }
+        else
+        {
             $options["overwrite"] = true;
         }
 
@@ -2238,10 +2582,13 @@ 
         // all other METHODS need both a http_method() wrapper
         // and a method() implementation
         // the base class supplies wrappers only
-        foreach (get_class_methods($this) as $method) {
-            if (!strncmp("http_", $method, 5)) {
+        foreach (get_class_methods($this) as $method)
+        {
+            if (!strncmp("http_", $method, 5))
+            {
                 $method = strtoupper(substr($method, 5));
-                if (method_exists($this, $method)) {
+                if (method_exists($this, $method))
+                {
                     $allow[$method] = $method;
                 }
             }
@@ -2249,10 +2596,13 @@ 
 
         // we can emulate a missing HEAD implemetation using GET
         if (isset($allow["GET"]))
-            $allow["HEAD"] = "HEAD";
+        {
+                    $allow["HEAD"] = "HEAD";
+        }
 
         // no LOCK without checklok()
-        if (!method_exists($this, "checklock")) {
+        if (!method_exists($this, "checklock"))
+        {
             unset($allow["LOCK"]);
             unset($allow["UNLOCK"]);
         }
@@ -2274,7 +2624,8 @@ 
     public static function mkprop()
     {
 	    $args = func_get_args();
-	    switch (count($args)) {
+	    switch (count($args))
+	    {
 		    case 4:
 			    return array('ns'   => $args[0],
 				    'name' => $args[1],
@@ -2301,17 +2652,22 @@ 
      */
     function _check_auth()
     {
-        if (method_exists($this, "checkAuth")) {
+        if (method_exists($this, "checkAuth"))
+        {
             // PEAR style method name
             return $this->checkAuth(@$this->_SERVER["AUTH_TYPE"],
                                     @$this->_SERVER["PHP_AUTH_USER"],
                                     @$this->_SERVER["PHP_AUTH_PW"]);
-        } else if (method_exists($this, "check_auth")) {
+        }
+        else if (method_exists($this, "check_auth"))
+        {
             // old (pre 1.0) method name
             return $this->check_auth(@$this->_SERVER["AUTH_TYPE"],
                                      @$this->_SERVER["PHP_AUTH_USER"],
                                      @$this->_SERVER["PHP_AUTH_PW"]);
-        } else {
+        }
+        else
+        {
             // no method found -> no authentication required
             return true;
         }
@@ -2330,7 +2686,8 @@ 
     public static function _new_uuid()
     {
         // use uuid extension from PECL if available
-        if (function_exists("uuid_create")) {
+        if (function_exists("uuid_create"))
+        {
             return uuid_create();
         }
 
@@ -2376,12 +2733,14 @@ 
     function _if_header_lexer($string, &$pos)
     {
         // skip whitespace
-        while (ctype_space($string{$pos})) {
+        while (ctype_space($string{$pos}))
+        {
             ++$pos;
         }
 
         // already at end of string?
-        if (strlen($string) <= $pos) {
+        if (strlen($string) <= $pos)
+        {
             return false;
         }
 
@@ -2389,7 +2748,8 @@ 
         $c = $string{$pos++};
 
         // now it depends on what we found
-        switch ($c) {
+        switch ($c)
+        {
         case "<":
             // URIs are enclosed in <...>
             $pos2 = strpos($string, ">", $pos);
@@ -2399,10 +2759,13 @@ 
 
         case "[":
             //Etags are enclosed in [...]
-            if ($string{$pos} == "W") {
+            if ($string{$pos} == "W")
+            {
                 $type = "ETAG_WEAK";
                 $pos += 2;
-            } else {
+            }
+            else
+            {
                 $type = "ETAG_STRONG";
             }
             $pos2 = strpos($string, "]", $pos);
@@ -2434,35 +2797,44 @@ 
         $uris = array();
 
         // parser loop
-        while ($pos < $len) {
+        while ($pos < $len)
+        {
             // get next token
             $token = $this->_if_header_lexer($str, $pos);
 
             // check for URI
-            if ($token[0] == "URI") {
+            if ($token[0] == "URI")
+            {
                 $uri   = $token[1]; // remember URI
                 $token = $this->_if_header_lexer($str, $pos); // get next token
-            } else {
+            }
+            else
+            {
                 $uri = "";
             }
 
             // sanity check
-            if ($token[0] != "CHAR" || $token[1] != "(") {
+            if ($token[0] != "CHAR" || $token[1] != "(")
+            {
                 return false;
             }
 
             $list  = array();
             $level = 1;
             $not   = "";
-            while ($level) {
+            while ($level)
+            {
                 $token = $this->_if_header_lexer($str, $pos);
-                if ($token[0] == "NOT") {
+                if ($token[0] == "NOT")
+                {
                     $not = "!";
                     continue;
                 }
-                switch ($token[0]) {
+                switch ($token[0])
+                {
                 case "CHAR":
-                    switch ($token[1]) {
+                    switch ($token[1])
+                    {
                     case "(":
                         $level++;
                         break;
@@ -2492,9 +2864,12 @@ 
                 $not = "";
             }
 
-            if (@is_array($uris[$uri])) {
+            if (@is_array($uris[$uri]))
+            {
                 $uris[$uri] = array_merge($uris[$uri], $list);
-            } else {
+            }
+            else
+            {
                 $uris[$uri] = $list;
             }
         }
@@ -2513,27 +2888,34 @@ 
      */
     function _check_if_header_conditions()
     {
-        if (isset($this->_SERVER["HTTP_IF"])) {
+        if (isset($this->_SERVER["HTTP_IF"]))
+        {
             $this->_if_header_uris =
                 $this->_if_header_parser($this->_SERVER["HTTP_IF"]);
 
-            foreach ($this->_if_header_uris as $uri => $conditions) {
-                if ($uri == "") {
+            foreach ($this->_if_header_uris as $uri => $conditions)
+            {
+                if ($uri == "")
+                {
                     $uri = $this->uri;
                 }
                 // all must match
                 $state = true;
-                foreach ($conditions as $condition) {
+                foreach ($conditions as $condition)
+                {
                     // lock tokens may be free form (RFC2518 6.3)
                     // but if opaquelocktokens are used (RFC2518 6.4)
                     // we have to check the format (litmus tests this)
-                    if (!strncmp($condition, "<opaquelocktoken:", strlen("<opaquelocktoken"))) {
-                        if (!preg_match('/^<opaquelocktoken:[[:xdigit:]]{8}-[[:xdigit:]]{4}-[[:xdigit:]]{4}-[[:xdigit:]]{4}-[[:xdigit:]]{12}>$/', $condition)) {
+                    if (!strncmp($condition, "<opaquelocktoken:", strlen("<opaquelocktoken")))
+                    {
+                        if (!preg_match('/^<opaquelocktoken:[[:xdigit:]]{8}-[[:xdigit:]]{4}-[[:xdigit:]]{4}-[[:xdigit:]]{4}-[[:xdigit:]]{12}>$/', $condition))
+                        {
                             $this->http_status("423 Locked");
                             return false;
                         }
                     }
-                    if (!$this->_check_uri_condition($uri, $condition)) {
+                    if (!$this->_check_uri_condition($uri, $condition))
+                    {
                         $this->http_status("412 Precondition failed");
                         $state = false;
                         break;
@@ -2541,7 +2923,8 @@ 
                 }
 
                 // any match is ok
-                if ($state == true) {
+                if ($state == true)
+                {
                     return true;
                 }
             }
@@ -2568,7 +2951,8 @@ 
 
         // a lock token can never be from the DAV: scheme
         // litmus uses DAV:no-lock in some tests
-        if (!strncmp("<DAV:", $condition, 5)) {
+        if (!strncmp("<DAV:", $condition, 5))
+        {
             return false;
         }
 
@@ -2585,16 +2969,21 @@ 
     function _check_lock_status($path, $exclusive_only = false)
     {
         // FIXME depth -> ignored for now
-        if (method_exists($this, "checkLock")) {
+        if (method_exists($this, "checkLock"))
+        {
             // is locked?
             $lock = $this->checkLock($path);
 
             // ... and lock is not owned?
-            if (is_array($lock) && count($lock)) {
+            if (is_array($lock) && count($lock))
+            {
                 // FIXME doesn't check uri restrictions yet
-                if (!isset($this->_SERVER["HTTP_IF"]) || !strstr($this->_SERVER["HTTP_IF"], $lock["token"])) {
+                if (!isset($this->_SERVER["HTTP_IF"]) || !strstr($this->_SERVER["HTTP_IF"], $lock["token"]))
+                {
                     if (!$exclusive_only || ($lock["scope"] !== "shared"))
-                        return false;
+                    {
+                                            return false;
+                    }
                 }
             }
         }
@@ -2614,7 +3003,8 @@ 
     function lockdiscovery($path)
     {
         // no lock support without checklock() method
-        if (!method_exists($this, "checklock")) {
+        if (!method_exists($this, "checklock"))
+        {
             return "";
         }
 
@@ -2625,13 +3015,19 @@ 
         $lock = $this->checklock($path);
 
         // generate <activelock> block for returned data
-        if (is_array($lock) && count($lock)) {
+        if (is_array($lock) && count($lock))
+        {
             // check for 'timeout' or 'expires'
-            if (!empty($lock["expires"])) {
+            if (!empty($lock["expires"]))
+            {
                 $timeout = "Second-".($lock["expires"] - time());
-            } else if (!empty($lock["timeout"])) {
+            }
+            else if (!empty($lock["timeout"]))
+            {
                 $timeout = "Second-$lock[timeout]";
-            } else {
+            }
+            else
+            {
                 $timeout = "Infinite";
             }
 
@@ -2678,7 +3074,8 @@ 
     function http_status($status)
     {
         // simplified success case
-        if ($status === true) {
+        if ($status === true)
+        {
             $status = "200 OK";
         }
 
@@ -2763,18 +3160,24 @@ 
      * @return string
      */
 	function _hierarchical_prop_encode(array $props, $ns, &$ns_defs, array &$ns_hash)
-    {
+	{
     	$ret = '';
 
     	//error_log(__METHOD__.'('.array2string($props).')');
-    	if (isset($props['name'])) $props = array($props);
+    	if (isset($props['name']))
+    	{
+    		$props = array($props);
+    	}
 
     	foreach($props as $prop)
-		{
-	    	if (!isset($ns_hash[$prop['ns']])) // unknown namespace
+    	{
+	    	if (!isset($ns_hash[$prop['ns']]))
+	    	{
+	    		// unknown namespace
 	    	{
 		    	// register namespace
 		    	$ns_name = 'ns'.(count($ns_hash) + 1);
+	    	}
 		    	$ns_hash[$prop['ns']] = $ns_name;
 		    	$ns_defs .= ' xmlns:'.$ns_name.'="'.$prop['ns'].'"';
 	    	}
@@ -2792,7 +3195,7 @@ 
 			    	$vals = '';
 
 			    	foreach($subprop as $attr => $val)
-					{
+			    	{
 				    	$vals .= ' '.$attr.'="'.htmlspecialchars($val, ENT_NOQUOTES, 'utf-8').'"';
 					}
 
@@ -2809,9 +3212,11 @@ 
 		    	else
 		    	{
 			    	if(isset($prop['raw']))
-					{
+			    	{
 						$val = $this->_prop_encode('<![CDATA['.$prop['val'].']]>');
-					} else {
+					}
+					else
+					{
 						$val = $this->_prop_encode(htmlspecialchars($prop['val'], ENT_NOQUOTES, 'utf-8'));
 						// for href properties we need (minimalistic) urlencoding, eg. space
 						if ($prop['name'] == 'href')
@@ -2842,7 +3247,8 @@ 
 		//error_log( __METHOD__."\n" .print_r($text,true));
 		//error_log("prop-encode:" . print_r($this->_prop_encoding,true));
 
-		switch (strtolower($this->_prop_encoding)) {
+		switch (strtolower($this->_prop_encoding))
+		{
 			case "utf-8":
        			//error_log( __METHOD__."allready encoded\n" .print_r($text,true));
 				return $text;
@@ -2864,7 +3270,8 @@ 
     public static function _slashify($path)
     {
 		//error_log(__METHOD__." called with $path");
-		if ($path[self::bytes($path)-1] != '/') {
+		if ($path[self::bytes($path)-1] != '/')
+		{
 			//error_log(__METHOD__." added slash at the end of path");
 			$path = $path."/";
 		}
@@ -2880,7 +3287,8 @@ 
     public static function _unslashify($path)
     {
         //error_log(__METHOD__." called with $path");
-        if ($path[self::bytes($path)-1] == '/') {
+        if ($path[self::bytes($path)-1] == '/')
+        {
             $path = substr($path, 0, -1);
 			//error_log(__METHOD__." removed slash at the end of path");
         }
@@ -2898,9 +3306,12 @@ 
     {
         //error_log("merge called :\n$parent \n$child\n" . function_backtrace());
         //error_log("merge :\n".print_r($this->_mergePaths($this->_SERVER["SCRIPT_NAME"], $this->path)true));
-        if ($child{0} == '/') {
+        if ($child{0} == '/')
+        {
             return self::_unslashify($parent).$child;
-        } else {
+        }
+        else
+        {
             return self::_slashify($parent).$child;
         }
     }

Upper-Lower-Casing +13 added lines, -13 removed lines

@@ -655,8 +655,8 @@ 
      */
     function http_PROPFIND($handler='PROPFIND')
     {
-        $options = Array();
-        $files   = Array();
+        $options = array();
+        $files   = array();
 
         $options["path"] = $this->path;
 
@@ -1164,7 +1164,7 @@ 
     function http_PROPPATCH()
     {
         if ($this->_check_lock_status($this->path)) {
-            $options = Array();
+            $options = array();
 
             $options["path"] = $this->path;
 
@@ -1222,7 +1222,7 @@ 
      */
     function http_MKCOL()
     {
-        $options = Array();
+        $options = array();
 
         $options["path"] = $this->path;
 
@@ -1269,7 +1269,7 @@ 
     function http_GET()
     {
         // TODO check for invalid stream
-        $options         = Array();
+        $options         = array();
         $options["path"] = $this->path;
 
         $this->_get_ranges($options);
@@ -1478,7 +1478,7 @@ 
     function http_HEAD()
     {
         $status          = false;
-        $options         = Array();
+        $options         = array();
         $options["path"] = $this->path;
 
         if (method_exists($this, "HEAD")) {
@@ -1524,7 +1524,7 @@ 
     function http_POST()
     {
         $status          = '405 Method not allowed';
-        $options         = Array();
+        $options         = array();
         $options['path'] = $this->path;
 
         if (isset($this->_SERVER['CONTENT_LENGTH']))
@@ -1704,7 +1704,7 @@ 
     function http_PUT()
     {
         if ($this->_check_lock_status($this->path)) {
-            $options                   = Array();
+            $options                   = array();
             $options["path"]           = $this->path;
 
             if (isset($this->_SERVER['CONTENT_LENGTH']))
@@ -1923,7 +1923,7 @@ 
         // check lock status
         if ($this->_check_lock_status($this->path)) {
             // ok, proceed
-            $options         = Array();
+            $options         = array();
             $options["path"] = $this->path;
 
             $stat = $this->DELETE($options);
@@ -1985,7 +1985,7 @@ 
      */
     function http_LOCK()
     {
-        $options         = Array();
+        $options         = array();
         $options["path"] = $this->path;
 
         if (isset($this->_SERVER['HTTP_DEPTH'])) {
@@ -2103,7 +2103,7 @@ 
      */
     function http_UNLOCK()
     {
-        $options         = Array();
+        $options         = array();
         $options["path"] = $this->path;
 
         if (isset($this->_SERVER['HTTP_DEPTH'])) {
@@ -2133,7 +2133,7 @@ 
      */
     function http_ACL()
     {
-        $options         = Array();
+        $options         = array();
         $options['path'] = $this->path;
         $options['errors'] = array();
 
@@ -2172,7 +2172,7 @@ 
 
     function _copymove($what)
     {
-        $options         = Array();
+        $options         = array();
         $options["path"] = $this->path;
 
         if (isset($this->_SERVER["HTTP_DEPTH"])) {

api/src/WebDAV/Server/Filesystem.php

Doc Comments +11 added lines, -9 removed lines

@@ -254,6 +254,7 @@ 
      *
      * @param  string  program name
      * @param  string  optional search path, defaults to $PATH
+     * @param string $name
      * @return bool    true if executable program found in path
      */
     function _can_execute($name, $path = false)
@@ -319,6 +320,7 @@ 
      * try to detect the mime type of a file
      *
      * @param  string  file path
+     * @param string $fspath
      * @return string  guessed mime type
      */
     function _mimetype($fspath)
@@ -416,7 +418,7 @@ 
      * GET method handler
      *
      * @param  array  parameter passing array
-     * @return bool   true on success
+     * @return null|boolean   true on success
      */
     function GET(&$options)
     {
@@ -446,7 +448,7 @@ 
      * See RFC 2518, Section 8.4 on GET/HEAD for collections
      *
      * @param  string  directory path
-     * @return void    function has to handle HTTP response itself
+     * @return null|false    function has to handle HTTP response itself
      */
     function GetDir($fspath, &$options)
     {
@@ -533,7 +535,7 @@ 
      * MKCOL method handler
      *
      * @param  array  general parameter passing array
-     * @return bool   true on success
+     * @return string   true on success
      */
     function MKCOL($options)
     {
@@ -570,7 +572,7 @@ 
      * DELETE method handler
      *
      * @param  array  general parameter passing array
-     * @return bool   true on success
+     * @return string   true on success
      */
     function DELETE($options)
     {
@@ -600,7 +602,7 @@ 
      * MOVE method handler
      *
      * @param  array  general parameter passing array
-     * @return bool   true on success
+     * @return string   true on success
      */
     function MOVE($options)
     {
@@ -611,7 +613,7 @@ 
      * COPY method handler
      *
      * @param  array  general parameter passing array
-     * @return bool   true on success
+     * @return string   true on success
      */
     function COPY($options, $del=false)
     {
@@ -751,7 +753,7 @@ 
      * PROPPATCH method handler
      *
      * @param  array  general parameter passing array
-     * @return bool   true on success
+     * @return string   true on success
      */
     function PROPPATCH(&$options)
     {
@@ -790,7 +792,7 @@ 
      * LOCK method handler
      *
      * @param  array  general parameter passing array
-     * @return bool   true on success
+     * @return string|boolean   true on success
      */
     function LOCK(&$options)
     {
@@ -848,7 +850,7 @@ 
      * UNLOCK method handler
      *
      * @param  array  general parameter passing array
-     * @return bool   true on success
+     * @return string   true on success
      */
     function UNLOCK(&$options)
     {

Indentation +827 added lines, -827 removed lines

@@ -44,793 +44,793 @@ 
  */
 class HTTP_WebDAV_Server_Filesystem extends HTTP_WebDAV_Server
 {
-    /**
-     * Root directory for WebDAV access
-     *
-     * Defaults to webserver document root (set by ServeRequest)
-     *
-     * @access private
-     * @var    string
-     */
-    var $base = "";
-
-    /**
-     * MySQL Host where property and locking information is stored
-     *
-     * @access private
-     * @var    string
-     */
-    var $db_host = "localhost";
-
-    /**
-     * MySQL database for property/locking information storage
-     *
-     * @access private
-     * @var    string
-     */
-    var $db_name = "webdav";
-
-    /**
-     * MySQL table name prefix
-     *
-     * @access private
-     * @var    string
-     */
-    var $db_prefix = "";
-
-    /**
-     * MySQL user for property/locking db access
-     *
-     * @access private
-     * @var    string
-     */
-    var $db_user = "root";
-
-    /**
-     * MySQL password for property/locking db access
-     *
-     * @access private
-     * @var    string
-     */
-    var $db_passwd = "";
-
-    /**
-     * Serve a webdav request
-     *
-     * @access public
-     * @param  string
-     */
-    function ServeRequest($base = false)
-    {
-        // special treatment for litmus compliance test
-        // reply on its identifier header
-        // not needed for the test itself but eases debugging
-        if (isset($this->_SERVER['HTTP_X_LITMUS'])) {
-            error_log("Litmus test ".$this->_SERVER['HTTP_X_LITMUS']);
-            header("X-Litmus-reply: ".$this->_SERVER['HTTP_X_LITMUS']);
-        }
-
-        // set root directory, defaults to webserver document root if not set
-        if ($base) {
-            $this->base = realpath($base); // TODO throw if not a directory
-        } else if (!$this->base) {
-            $this->base = $this->_SERVER['DOCUMENT_ROOT'];
-        }
-
-        // establish connection to property/locking db
-        mysql_connect($this->db_host, $this->db_user, $this->db_passwd) or die(mysql_error());
-        mysql_select_db($this->db_name) or die(mysql_error());
-        // TODO throw on connection problems
-
-        // let the base class do all the work
-        parent::ServeRequest();
-    }
-
-    /**
-     * No authentication is needed here
-     *
-     * @access private
-     * @param  string  HTTP Authentication type (Basic, Digest, ...)
-     * @param  string  Username
-     * @param  string  Password
-     * @return bool    true on successful authentication
-     */
-    function check_auth($type, $user, $pass)
-    {
-        return true;
-    }
-
-
-    /**
-     * PROPFIND method handler
-     *
-     * @param  array  general parameter passing array
-     * @param  array  return array for file properties
-     * @return bool   true on success
-     */
-    function PROPFIND(&$options, &$files)
-    {
-        // get absolute fs path to requested resource
-        $fspath = $this->base . $options["path"];
-
-        // sanity check
-        if (!file_exists($fspath)) {
-            return false;
-        }
-
-        // prepare property array
-        $files["files"] = array();
-
-        // store information for the requested path itself
-        $files["files"][] = $this->fileinfo($options["path"]);
-
-        // information for contained resources requested?
-        if (!empty($options["depth"]) && is_dir($fspath) && $this->_is_readable($fspath)) {
-
-            // make sure path ends with '/'
-            $options["path"] = $this->_slashify($options["path"]);
-
-            // try to open directory
-            $handle = opendir($fspath);
-
-            if ($handle) {
-                // ok, now get all its contents
-                while ($filename = readdir($handle)) {
-                    if ($filename != "." && $filename != "..") {
-                        $files["files"][] = $this->fileinfo($options["path"].$filename);
-                    }
-                }
-                // TODO recursion needed if "Depth: infinite"
-            	closedir($handle);
-            }
-        }
-
-        // ok, all done
-        return true;
-    }
-
-    /**
-     * Get properties for a single file/resource
-     *
-     * @param  string  resource path
-     * @return array   resource properties
-     */
-    function fileinfo($path)
-    {
-        // map URI path to filesystem path
-        $fspath = $this->base . $path;
-
-        // create result array
-        $info = array();
-        // TODO remove slash append code when base clase is able to do it itself
-        $info["path"]  = is_dir($fspath) ? $this->_slashify($path) : $path;
-        $info["props"] = array();
-
-        // no special beautified displayname here ...
-        $info["props"][] = $this->mkprop("displayname", strtoupper($path));
-
-        // creation and modification time
-        $info["props"][] = $this->mkprop("creationdate",    filectime($fspath));
-        $info["props"][] = $this->mkprop("getlastmodified", filemtime($fspath));
-
-        // Microsoft extensions: last access time and 'hidden' status
-        $info["props"][] = $this->mkprop("lastaccessed",    fileatime($fspath));
-        $info["props"][] = $this->mkprop("ishidden", ('.' === substr(basename($fspath), 0, 1)));
-
-        // type and size (caller already made sure that path exists)
-        if (is_dir($fspath)) {
-            // directory (WebDAV collection)
-            $info["props"][] = $this->mkprop("resourcetype", "collection");
-            $info["props"][] = $this->mkprop("getcontenttype", "httpd/unix-directory");
-        } else {
-            // plain file (WebDAV resource)
-            $info["props"][] = $this->mkprop("resourcetype", "");
-            if ($this->_is_readable($fspath)) {
-                $info["props"][] = $this->mkprop("getcontenttype", $this->_mimetype($fspath));
-            } else {
-                $info["props"][] = $this->mkprop("getcontenttype", "application/x-non-readable");
-            }
-            $info["props"][] = $this->mkprop("getcontentlength", filesize($fspath));
-        }
-
-        // get additional properties from database
-        $query = "SELECT ns, name, value
+	/**
+	 * Root directory for WebDAV access
+	 *
+	 * Defaults to webserver document root (set by ServeRequest)
+	 *
+	 * @access private
+	 * @var    string
+	 */
+	var $base = "";
+
+	/**
+	 * MySQL Host where property and locking information is stored
+	 *
+	 * @access private
+	 * @var    string
+	 */
+	var $db_host = "localhost";
+
+	/**
+	 * MySQL database for property/locking information storage
+	 *
+	 * @access private
+	 * @var    string
+	 */
+	var $db_name = "webdav";
+
+	/**
+	 * MySQL table name prefix
+	 *
+	 * @access private
+	 * @var    string
+	 */
+	var $db_prefix = "";
+
+	/**
+	 * MySQL user for property/locking db access
+	 *
+	 * @access private
+	 * @var    string
+	 */
+	var $db_user = "root";
+
+	/**
+	 * MySQL password for property/locking db access
+	 *
+	 * @access private
+	 * @var    string
+	 */
+	var $db_passwd = "";
+
+	/**
+	 * Serve a webdav request
+	 *
+	 * @access public
+	 * @param  string
+	 */
+	function ServeRequest($base = false)
+	{
+		// special treatment for litmus compliance test
+		// reply on its identifier header
+		// not needed for the test itself but eases debugging
+		if (isset($this->_SERVER['HTTP_X_LITMUS'])) {
+			error_log("Litmus test ".$this->_SERVER['HTTP_X_LITMUS']);
+			header("X-Litmus-reply: ".$this->_SERVER['HTTP_X_LITMUS']);
+		}
+
+		// set root directory, defaults to webserver document root if not set
+		if ($base) {
+			$this->base = realpath($base); // TODO throw if not a directory
+		} else if (!$this->base) {
+			$this->base = $this->_SERVER['DOCUMENT_ROOT'];
+		}
+
+		// establish connection to property/locking db
+		mysql_connect($this->db_host, $this->db_user, $this->db_passwd) or die(mysql_error());
+		mysql_select_db($this->db_name) or die(mysql_error());
+		// TODO throw on connection problems
+
+		// let the base class do all the work
+		parent::ServeRequest();
+	}
+
+	/**
+	 * No authentication is needed here
+	 *
+	 * @access private
+	 * @param  string  HTTP Authentication type (Basic, Digest, ...)
+	 * @param  string  Username
+	 * @param  string  Password
+	 * @return bool    true on successful authentication
+	 */
+	function check_auth($type, $user, $pass)
+	{
+		return true;
+	}
+
+
+	/**
+	 * PROPFIND method handler
+	 *
+	 * @param  array  general parameter passing array
+	 * @param  array  return array for file properties
+	 * @return bool   true on success
+	 */
+	function PROPFIND(&$options, &$files)
+	{
+		// get absolute fs path to requested resource
+		$fspath = $this->base . $options["path"];
+
+		// sanity check
+		if (!file_exists($fspath)) {
+			return false;
+		}
+
+		// prepare property array
+		$files["files"] = array();
+
+		// store information for the requested path itself
+		$files["files"][] = $this->fileinfo($options["path"]);
+
+		// information for contained resources requested?
+		if (!empty($options["depth"]) && is_dir($fspath) && $this->_is_readable($fspath)) {
+
+			// make sure path ends with '/'
+			$options["path"] = $this->_slashify($options["path"]);
+
+			// try to open directory
+			$handle = opendir($fspath);
+
+			if ($handle) {
+				// ok, now get all its contents
+				while ($filename = readdir($handle)) {
+					if ($filename != "." && $filename != "..") {
+						$files["files"][] = $this->fileinfo($options["path"].$filename);
+					}
+				}
+				// TODO recursion needed if "Depth: infinite"
+				closedir($handle);
+			}
+		}
+
+		// ok, all done
+		return true;
+	}
+
+	/**
+	 * Get properties for a single file/resource
+	 *
+	 * @param  string  resource path
+	 * @return array   resource properties
+	 */
+	function fileinfo($path)
+	{
+		// map URI path to filesystem path
+		$fspath = $this->base . $path;
+
+		// create result array
+		$info = array();
+		// TODO remove slash append code when base clase is able to do it itself
+		$info["path"]  = is_dir($fspath) ? $this->_slashify($path) : $path;
+		$info["props"] = array();
+
+		// no special beautified displayname here ...
+		$info["props"][] = $this->mkprop("displayname", strtoupper($path));
+
+		// creation and modification time
+		$info["props"][] = $this->mkprop("creationdate",    filectime($fspath));
+		$info["props"][] = $this->mkprop("getlastmodified", filemtime($fspath));
+
+		// Microsoft extensions: last access time and 'hidden' status
+		$info["props"][] = $this->mkprop("lastaccessed",    fileatime($fspath));
+		$info["props"][] = $this->mkprop("ishidden", ('.' === substr(basename($fspath), 0, 1)));
+
+		// type and size (caller already made sure that path exists)
+		if (is_dir($fspath)) {
+			// directory (WebDAV collection)
+			$info["props"][] = $this->mkprop("resourcetype", "collection");
+			$info["props"][] = $this->mkprop("getcontenttype", "httpd/unix-directory");
+		} else {
+			// plain file (WebDAV resource)
+			$info["props"][] = $this->mkprop("resourcetype", "");
+			if ($this->_is_readable($fspath)) {
+				$info["props"][] = $this->mkprop("getcontenttype", $this->_mimetype($fspath));
+			} else {
+				$info["props"][] = $this->mkprop("getcontenttype", "application/x-non-readable");
+			}
+			$info["props"][] = $this->mkprop("getcontentlength", filesize($fspath));
+		}
+
+		// get additional properties from database
+		$query = "SELECT ns, name, value
                         FROM {$this->db_prefix}properties
                        WHERE path = '$path'";
-        $res = mysql_query($query);
-        while ($row = mysql_fetch_assoc($res)) {
-            $info["props"][] = $this->mkprop($row["ns"], $row["name"], $row["value"]);
-        }
-        mysql_free_result($res);
-
-        return $info;
-    }
-
-    /**
-     * detect if a given program is found in the search PATH
-     *
-     * helper function used by _mimetype() to detect if the
-     * external 'file' utility is available
-     *
-     * @param  string  program name
-     * @param  string  optional search path, defaults to $PATH
-     * @return bool    true if executable program found in path
-     */
-    function _can_execute($name, $path = false)
-    {
-        // path defaults to PATH from environment if not set
-        if ($path === false) {
-            $path = getenv("PATH");
-        }
-
-        // check method depends on operating system
-        if (!strncmp(PHP_OS, "WIN", 3)) {
-            // on Windows an appropriate COM or EXE file needs to exist
-            $exts     = array(".exe", ".com");
-            $check_fn = "file_exists";
-        } else {
-            // anywhere else we look for an executable file of that name
-            $exts     = array("");
-            $check_fn = "is_executable";
-        }
-
-        // now check the directories in the path for the program
-        foreach (explode(PATH_SEPARATOR, $path) as $dir) {
-            // skip invalid path entries
-            if (!file_exists($dir)) continue;
-            if (!is_dir($dir)) continue;
-
-            // and now look for the file
-            foreach ($exts as $ext) {
-                if ($check_fn("$dir/$name".$ext)) return true;
-            }
-        }
-
-        return false;
-    }
-
-    /**
-     * Check if path is readable by current user
-     *
-     * Allow extending classes to overwrite it
-     *
-     * @param string $fspath
-     * @return boolean
-     */
-    function _is_readable($fspath)
-    {
-    	return is_readable($fspath);
-    }
-
-    /**
-     * Check if path is writable by current user
-     *
-     * Allow extending classes to overwrite it
-     *
-     * @param string $fspath
-     * @return boolean
-     */
-    function _is_writable($fspath)
-    {
-    	return is_writable($fspath);
-    }
-
-    /**
-     * try to detect the mime type of a file
-     *
-     * @param  string  file path
-     * @return string  guessed mime type
-     */
-    function _mimetype($fspath)
-    {
-        if (is_dir($fspath)) {
-            // directories are easy
-            return "httpd/unix-directory";
-        } else if (function_exists("mime_content_type")) {
-            // use mime magic extension if available
-            $mime_type = mime_content_type($fspath);
-        } else if ($this->_can_execute("file")) {
-            // it looks like we have a 'file' command,
-            // lets see it it does have mime support
-            $fp    = popen("file -i '$fspath' 2>/dev/null", "r");
-            $reply = fgets($fp);
-            pclose($fp);
-
-            // popen will not return an error if the binary was not found
-            // and find may not have mime support using "-i"
-            // so we test the format of the returned string
-
-            // the reply begins with the requested filename
-            if (!strncmp($reply, "$fspath: ", strlen($fspath)+2)) {
-                $reply = substr($reply, strlen($fspath)+2);
-                // followed by the mime type (maybe including options)
-                if (preg_match('|^[[:alnum:]_-]+/[[:alnum:]_-]+;?.*|', $reply, $matches)) {
-                    $mime_type = $matches[0];
-                }
-            }
-        }
-
-        if (empty($mime_type)) {
-            // Fallback solution: try to guess the type by the file extension
-            // TODO: add more ...
-            // TODO: it has been suggested to delegate mimetype detection
-            //       to apache but this has at least three issues:
-            //       - works only with apache
-            //       - needs file to be within the document tree
-            //       - requires apache mod_magic
-            // TODO: can we use the registry for this on Windows?
-            //       OTOH if the server is Windos the clients are likely to
-            //       be Windows, too, and tend do ignore the Content-Type
-            //       anyway (overriding it with information taken from
-            //       the registry)
-            // TODO: have a seperate PEAR class for mimetype detection?
-            switch (strtolower(strrchr(basename($fspath), "."))) {
-            case ".html":
-                $mime_type = "text/html";
-                break;
-            case ".gif":
-                $mime_type = "image/gif";
-                break;
-            case ".jpg":
-                $mime_type = "image/jpeg";
-                break;
-            default:
-                $mime_type = "application/octet-stream";
-                break;
-            }
-        }
-
-        return $mime_type;
-    }
-
-    /**
-     * HEAD method handler
-     *
-     * @param  array  parameter passing array
-     * @return bool   true on success
-     */
-    function HEAD(&$options)
-    {
-        // get absolute fs path to requested resource
-        $fspath = $this->base . $options["path"];
-
-        // sanity check
-        if (!file_exists($fspath)) return false;
-
-        // detect resource type
-        $options['mimetype'] = $this->_mimetype($fspath);
-
-        // detect modification time
-        // see rfc2518, section 13.7
-        // some clients seem to treat this as a reverse rule
-        // requiering a Last-Modified header if the getlastmodified header was set
-        $options['mtime'] = filemtime($fspath);
-
-        // detect resource size
-        $options['size'] = filesize($fspath);
-
-        return true;
-    }
-
-    /**
-     * GET method handler
-     *
-     * @param  array  parameter passing array
-     * @return bool   true on success
-     */
-    function GET(&$options)
-    {
-        // get absolute fs path to requested resource
-        $fspath = $this->base . $options["path"];
-
-        // is this a collection?
-        if (is_dir($fspath)) {
-            return $this->GetDir($fspath, $options);
-        }
-
-        // the header output is the same as for HEAD
-        if (!$this->HEAD($options)) {
-            return false;
-        }
-
-        // no need to check result here, it is handled by the base class
-        $options['stream'] = fopen($fspath, "r");
-
-        return true;
-    }
-
-    /**
-     * GET method handler for directories
-     *
-     * This is a very simple mod_index lookalike.
-     * See RFC 2518, Section 8.4 on GET/HEAD for collections
-     *
-     * @param  string  directory path
-     * @return void    function has to handle HTTP response itself
-     */
-    function GetDir($fspath, &$options)
-    {
-        $path = $this->_slashify($options["path"]);
-        if ($path != $options["path"]) {
-            header("Location: ".$this->base_uri.$path);
-            exit;
-        }
-
-        // fixed width directory column format
-        $format = "%15s  %-19s  %-s\n";
-
-        if (!$this->_is_readable($fspath)) {
-            return false;
-        }
-
-        $handle = opendir($fspath);
-        if (!$handle) {
-            return false;
-        }
-
-        echo "<html><head><title>Index of ".htmlspecialchars(urldecode($options['path']))."</title></head>\n";
-
-        echo "<h1>Index of ".htmlspecialchars($options['path'])."</h1>\n";
-
-        echo "<pre>";
-        printf($format, "Size", "Last modified", "Filename");
-        echo "<hr>";
-
-        while ($filename = readdir($handle)) {
-            if ($filename != "." && $filename != "..") {
-                $fullpath = $fspath.$filename;
-                $name     = htmlspecialchars($filename);
-                printf($format,
-                       number_format(filesize($fullpath)),
-                       strftime("%Y-%m-%d %H:%M:%S", filemtime($fullpath)),
-                       '<a href="'.$name.'">'.urldecode($name).'</a>');
-            }
-        }
-
-        echo "</pre>";
-
-        closedir($handle);
-
-        echo "</html>\n";
-
-        exit;
-    }
-
-    /**
-     * PUT method handler
-     *
-     * @param  array  parameter passing array
-     * @return bool   true on success
-     */
-    function PUT(&$options)
-    {
-        $fspath = $this->base . $options["path"];
-
-        $dir = dirname($fspath);
-        if (!file_exists($dir) || !is_dir($dir)) {
-            return "409 Conflict"; // TODO right status code for both?
-        }
-
-        $options["new"] = ! file_exists($fspath);
-
-        if ($options["new"] && !$this->_is_writable($dir)) {
-            return "403 Forbidden";
-        }
-        if (!$options["new"] && !$this->_is_writable($fspath)) {
-            return "403 Forbidden";
-        }
-        if (!$options["new"] && is_dir($fspath)) {
-            return "403 Forbidden";
-        }
-
-        $fp = fopen($fspath, "w");
-
-        return $fp;
-    }
-
-
-    /**
-     * MKCOL method handler
-     *
-     * @param  array  general parameter passing array
-     * @return bool   true on success
-     */
-    function MKCOL($options)
-    {
-        $path   = $this->base .$options["path"];
-        $parent = dirname($path);
-        $name   = basename($path);
-
-        if (!file_exists($parent)) {
-            return "409 Conflict";
-        }
-
-        if (!is_dir($parent)) {
-            return "403 Forbidden";
-        }
-
-        if ( file_exists($parent."/".$name) ) {
-            return "405 Method not allowed";
-        }
-
-        if (!empty($this->_SERVER["CONTENT_LENGTH"])) { // no body parsing yet
-            return "415 Unsupported media type";
-        }
-
-        $stat = mkdir($parent."/".$name, 0777);
-        if (!$stat) {
-            return "403 Forbidden";
-        }
-
-        return ("201 Created");
-    }
-
-
-    /**
-     * DELETE method handler
-     *
-     * @param  array  general parameter passing array
-     * @return bool   true on success
-     */
-    function DELETE($options)
-    {
-        $path = $this->base . "/" .$options["path"];
-
-        if (!file_exists($path)) {
-            return "404 Not found";
-        }
-
-        if (is_dir($path)) {
-            $query = "DELETE FROM {$this->db_prefix}properties
+		$res = mysql_query($query);
+		while ($row = mysql_fetch_assoc($res)) {
+			$info["props"][] = $this->mkprop($row["ns"], $row["name"], $row["value"]);
+		}
+		mysql_free_result($res);
+
+		return $info;
+	}
+
+	/**
+	 * detect if a given program is found in the search PATH
+	 *
+	 * helper function used by _mimetype() to detect if the
+	 * external 'file' utility is available
+	 *
+	 * @param  string  program name
+	 * @param  string  optional search path, defaults to $PATH
+	 * @return bool    true if executable program found in path
+	 */
+	function _can_execute($name, $path = false)
+	{
+		// path defaults to PATH from environment if not set
+		if ($path === false) {
+			$path = getenv("PATH");
+		}
+
+		// check method depends on operating system
+		if (!strncmp(PHP_OS, "WIN", 3)) {
+			// on Windows an appropriate COM or EXE file needs to exist
+			$exts     = array(".exe", ".com");
+			$check_fn = "file_exists";
+		} else {
+			// anywhere else we look for an executable file of that name
+			$exts     = array("");
+			$check_fn = "is_executable";
+		}
+
+		// now check the directories in the path for the program
+		foreach (explode(PATH_SEPARATOR, $path) as $dir) {
+			// skip invalid path entries
+			if (!file_exists($dir)) continue;
+			if (!is_dir($dir)) continue;
+
+			// and now look for the file
+			foreach ($exts as $ext) {
+				if ($check_fn("$dir/$name".$ext)) return true;
+			}
+		}
+
+		return false;
+	}
+
+	/**
+	 * Check if path is readable by current user
+	 *
+	 * Allow extending classes to overwrite it
+	 *
+	 * @param string $fspath
+	 * @return boolean
+	 */
+	function _is_readable($fspath)
+	{
+		return is_readable($fspath);
+	}
+
+	/**
+	 * Check if path is writable by current user
+	 *
+	 * Allow extending classes to overwrite it
+	 *
+	 * @param string $fspath
+	 * @return boolean
+	 */
+	function _is_writable($fspath)
+	{
+		return is_writable($fspath);
+	}
+
+	/**
+	 * try to detect the mime type of a file
+	 *
+	 * @param  string  file path
+	 * @return string  guessed mime type
+	 */
+	function _mimetype($fspath)
+	{
+		if (is_dir($fspath)) {
+			// directories are easy
+			return "httpd/unix-directory";
+		} else if (function_exists("mime_content_type")) {
+			// use mime magic extension if available
+			$mime_type = mime_content_type($fspath);
+		} else if ($this->_can_execute("file")) {
+			// it looks like we have a 'file' command,
+			// lets see it it does have mime support
+			$fp    = popen("file -i '$fspath' 2>/dev/null", "r");
+			$reply = fgets($fp);
+			pclose($fp);
+
+			// popen will not return an error if the binary was not found
+			// and find may not have mime support using "-i"
+			// so we test the format of the returned string
+
+			// the reply begins with the requested filename
+			if (!strncmp($reply, "$fspath: ", strlen($fspath)+2)) {
+				$reply = substr($reply, strlen($fspath)+2);
+				// followed by the mime type (maybe including options)
+				if (preg_match('|^[[:alnum:]_-]+/[[:alnum:]_-]+;?.*|', $reply, $matches)) {
+					$mime_type = $matches[0];
+				}
+			}
+		}
+
+		if (empty($mime_type)) {
+			// Fallback solution: try to guess the type by the file extension
+			// TODO: add more ...
+			// TODO: it has been suggested to delegate mimetype detection
+			//       to apache but this has at least three issues:
+			//       - works only with apache
+			//       - needs file to be within the document tree
+			//       - requires apache mod_magic
+			// TODO: can we use the registry for this on Windows?
+			//       OTOH if the server is Windos the clients are likely to
+			//       be Windows, too, and tend do ignore the Content-Type
+			//       anyway (overriding it with information taken from
+			//       the registry)
+			// TODO: have a seperate PEAR class for mimetype detection?
+			switch (strtolower(strrchr(basename($fspath), "."))) {
+			case ".html":
+				$mime_type = "text/html";
+				break;
+			case ".gif":
+				$mime_type = "image/gif";
+				break;
+			case ".jpg":
+				$mime_type = "image/jpeg";
+				break;
+			default:
+				$mime_type = "application/octet-stream";
+				break;
+			}
+		}
+
+		return $mime_type;
+	}
+
+	/**
+	 * HEAD method handler
+	 *
+	 * @param  array  parameter passing array
+	 * @return bool   true on success
+	 */
+	function HEAD(&$options)
+	{
+		// get absolute fs path to requested resource
+		$fspath = $this->base . $options["path"];
+
+		// sanity check
+		if (!file_exists($fspath)) return false;
+
+		// detect resource type
+		$options['mimetype'] = $this->_mimetype($fspath);
+
+		// detect modification time
+		// see rfc2518, section 13.7
+		// some clients seem to treat this as a reverse rule
+		// requiering a Last-Modified header if the getlastmodified header was set
+		$options['mtime'] = filemtime($fspath);
+
+		// detect resource size
+		$options['size'] = filesize($fspath);
+
+		return true;
+	}
+
+	/**
+	 * GET method handler
+	 *
+	 * @param  array  parameter passing array
+	 * @return bool   true on success
+	 */
+	function GET(&$options)
+	{
+		// get absolute fs path to requested resource
+		$fspath = $this->base . $options["path"];
+
+		// is this a collection?
+		if (is_dir($fspath)) {
+			return $this->GetDir($fspath, $options);
+		}
+
+		// the header output is the same as for HEAD
+		if (!$this->HEAD($options)) {
+			return false;
+		}
+
+		// no need to check result here, it is handled by the base class
+		$options['stream'] = fopen($fspath, "r");
+
+		return true;
+	}
+
+	/**
+	 * GET method handler for directories
+	 *
+	 * This is a very simple mod_index lookalike.
+	 * See RFC 2518, Section 8.4 on GET/HEAD for collections
+	 *
+	 * @param  string  directory path
+	 * @return void    function has to handle HTTP response itself
+	 */
+	function GetDir($fspath, &$options)
+	{
+		$path = $this->_slashify($options["path"]);
+		if ($path != $options["path"]) {
+			header("Location: ".$this->base_uri.$path);
+			exit;
+		}
+
+		// fixed width directory column format
+		$format = "%15s  %-19s  %-s\n";
+
+		if (!$this->_is_readable($fspath)) {
+			return false;
+		}
+
+		$handle = opendir($fspath);
+		if (!$handle) {
+			return false;
+		}
+
+		echo "<html><head><title>Index of ".htmlspecialchars(urldecode($options['path']))."</title></head>\n";
+
+		echo "<h1>Index of ".htmlspecialchars($options['path'])."</h1>\n";
+
+		echo "<pre>";
+		printf($format, "Size", "Last modified", "Filename");
+		echo "<hr>";
+
+		while ($filename = readdir($handle)) {
+			if ($filename != "." && $filename != "..") {
+				$fullpath = $fspath.$filename;
+				$name     = htmlspecialchars($filename);
+				printf($format,
+					   number_format(filesize($fullpath)),
+					   strftime("%Y-%m-%d %H:%M:%S", filemtime($fullpath)),
+					   '<a href="'.$name.'">'.urldecode($name).'</a>');
+			}
+		}
+
+		echo "</pre>";
+
+		closedir($handle);
+
+		echo "</html>\n";
+
+		exit;
+	}
+
+	/**
+	 * PUT method handler
+	 *
+	 * @param  array  parameter passing array
+	 * @return bool   true on success
+	 */
+	function PUT(&$options)
+	{
+		$fspath = $this->base . $options["path"];
+
+		$dir = dirname($fspath);
+		if (!file_exists($dir) || !is_dir($dir)) {
+			return "409 Conflict"; // TODO right status code for both?
+		}
+
+		$options["new"] = ! file_exists($fspath);
+
+		if ($options["new"] && !$this->_is_writable($dir)) {
+			return "403 Forbidden";
+		}
+		if (!$options["new"] && !$this->_is_writable($fspath)) {
+			return "403 Forbidden";
+		}
+		if (!$options["new"] && is_dir($fspath)) {
+			return "403 Forbidden";
+		}
+
+		$fp = fopen($fspath, "w");
+
+		return $fp;
+	}
+
+
+	/**
+	 * MKCOL method handler
+	 *
+	 * @param  array  general parameter passing array
+	 * @return bool   true on success
+	 */
+	function MKCOL($options)
+	{
+		$path   = $this->base .$options["path"];
+		$parent = dirname($path);
+		$name   = basename($path);
+
+		if (!file_exists($parent)) {
+			return "409 Conflict";
+		}
+
+		if (!is_dir($parent)) {
+			return "403 Forbidden";
+		}
+
+		if ( file_exists($parent."/".$name) ) {
+			return "405 Method not allowed";
+		}
+
+		if (!empty($this->_SERVER["CONTENT_LENGTH"])) { // no body parsing yet
+			return "415 Unsupported media type";
+		}
+
+		$stat = mkdir($parent."/".$name, 0777);
+		if (!$stat) {
+			return "403 Forbidden";
+		}
+
+		return ("201 Created");
+	}
+
+
+	/**
+	 * DELETE method handler
+	 *
+	 * @param  array  general parameter passing array
+	 * @return bool   true on success
+	 */
+	function DELETE($options)
+	{
+		$path = $this->base . "/" .$options["path"];
+
+		if (!file_exists($path)) {
+			return "404 Not found";
+		}
+
+		if (is_dir($path)) {
+			$query = "DELETE FROM {$this->db_prefix}properties
                            WHERE path LIKE '".$this->_slashify($options["path"])."%'";
-            mysql_query($query);
-            System::rm(array("-rf", $path));
-        } else {
-            unlink($path);
-        }
-        $query = "DELETE FROM {$this->db_prefix}properties
+			mysql_query($query);
+			System::rm(array("-rf", $path));
+		} else {
+			unlink($path);
+		}
+		$query = "DELETE FROM {$this->db_prefix}properties
                        WHERE path = '$options[path]'";
-        mysql_query($query);
-
-        return "204 No Content";
-    }
-
-
-    /**
-     * MOVE method handler
-     *
-     * @param  array  general parameter passing array
-     * @return bool   true on success
-     */
-    function MOVE($options)
-    {
-        return $this->COPY($options, true);
-    }
-
-    /**
-     * COPY method handler
-     *
-     * @param  array  general parameter passing array
-     * @return bool   true on success
-     */
-    function COPY($options, $del=false)
-    {
-        // TODO Property updates still broken (Litmus should detect this?)
-
-        if (!empty($this->_SERVER["CONTENT_LENGTH"])) { // no body parsing yet
-            return "415 Unsupported media type";
-        }
-
-        // no copying to different WebDAV Servers yet
-        if (isset($options["dest_url"])) {
-            return "502 bad gateway";
-        }
-
-        $source = $this->base . $options["path"];
-        if (!file_exists($source)) {
-            return "404 Not found";
-        }
-
-        if (is_dir($source)) { // resource is a collection
-            switch ($options["depth"]) {
-            case "infinity": // valid
-                break;
-            case "0": // valid for COPY only
-                if ($del) { // MOVE?
-                    return "400 Bad request";
-                }
-                break;
-            case "1": // invalid for both COPY and MOVE
-            default:
-                return "400 Bad request";
-            }
-        }
-
-        $dest         = $this->base . $options["dest"];
-        $destdir      = dirname($dest);
-
-        if (!file_exists($destdir) || !is_dir($destdir)) {
-            return "409 Conflict";
-        }
-
-
-        $new          = !file_exists($dest);
-        $existing_col = false;
-
-        if (!$new) {
-            if ($del && is_dir($dest)) {
-                if (!$options["overwrite"]) {
-                    return "412 precondition failed";
-                }
-                $dest .= basename($source);
-                if (file_exists($dest)) {
-                    $options["dest"] .= basename($source);
-                } else {
-                    $new          = true;
-                    $existing_col = true;
-                }
-            }
-        }
-
-        if (!$new) {
-            if ($options["overwrite"]) {
-                $stat = $this->DELETE(array("path" => $options["dest"]));
-                if (($stat{0} != "2") && (substr($stat, 0, 3) != "404")) {
-                    return $stat;
-                }
-            } else {
-                return "412 precondition failed";
-            }
-        }
-
-        if ($del) {
-            if (!rename($source, $dest)) {
-                return "500 Internal server error";
-            }
-            $destpath = $this->_unslashify($options["dest"]);
-            if (is_dir($source)) {
-                $query = "UPDATE {$this->db_prefix}properties
+		mysql_query($query);
+
+		return "204 No Content";
+	}
+
+
+	/**
+	 * MOVE method handler
+	 *
+	 * @param  array  general parameter passing array
+	 * @return bool   true on success
+	 */
+	function MOVE($options)
+	{
+		return $this->COPY($options, true);
+	}
+
+	/**
+	 * COPY method handler
+	 *
+	 * @param  array  general parameter passing array
+	 * @return bool   true on success
+	 */
+	function COPY($options, $del=false)
+	{
+		// TODO Property updates still broken (Litmus should detect this?)
+
+		if (!empty($this->_SERVER["CONTENT_LENGTH"])) { // no body parsing yet
+			return "415 Unsupported media type";
+		}
+
+		// no copying to different WebDAV Servers yet
+		if (isset($options["dest_url"])) {
+			return "502 bad gateway";
+		}
+
+		$source = $this->base . $options["path"];
+		if (!file_exists($source)) {
+			return "404 Not found";
+		}
+
+		if (is_dir($source)) { // resource is a collection
+			switch ($options["depth"]) {
+			case "infinity": // valid
+				break;
+			case "0": // valid for COPY only
+				if ($del) { // MOVE?
+					return "400 Bad request";
+				}
+				break;
+			case "1": // invalid for both COPY and MOVE
+			default:
+				return "400 Bad request";
+			}
+		}
+
+		$dest         = $this->base . $options["dest"];
+		$destdir      = dirname($dest);
+
+		if (!file_exists($destdir) || !is_dir($destdir)) {
+			return "409 Conflict";
+		}
+
+
+		$new          = !file_exists($dest);
+		$existing_col = false;
+
+		if (!$new) {
+			if ($del && is_dir($dest)) {
+				if (!$options["overwrite"]) {
+					return "412 precondition failed";
+				}
+				$dest .= basename($source);
+				if (file_exists($dest)) {
+					$options["dest"] .= basename($source);
+				} else {
+					$new          = true;
+					$existing_col = true;
+				}
+			}
+		}
+
+		if (!$new) {
+			if ($options["overwrite"]) {
+				$stat = $this->DELETE(array("path" => $options["dest"]));
+				if (($stat{0} != "2") && (substr($stat, 0, 3) != "404")) {
+					return $stat;
+				}
+			} else {
+				return "412 precondition failed";
+			}
+		}
+
+		if ($del) {
+			if (!rename($source, $dest)) {
+				return "500 Internal server error";
+			}
+			$destpath = $this->_unslashify($options["dest"]);
+			if (is_dir($source)) {
+				$query = "UPDATE {$this->db_prefix}properties
                                  SET path = REPLACE(path, '".$options["path"]."', '".$destpath."')
                                WHERE path LIKE '".$this->_slashify($options["path"])."%'";
-                mysql_query($query);
-            }
+				mysql_query($query);
+			}
 
-            $query = "UPDATE {$this->db_prefix}properties
+			$query = "UPDATE {$this->db_prefix}properties
                              SET path = '".$destpath."'
                            WHERE path = '".$options["path"]."'";
-            mysql_query($query);
-        } else {
-            if (is_dir($source) && $options["depth"] == "infinity") {	// no find for depth="0"
-                $files = System::find($source);
-                $files = array_reverse($files);
-            } else {
-                $files = array($source);
-            }
-
-            if (!is_array($files) || empty($files)) {
-                return "500 Internal server error";
-            }
-
-
-            foreach ($files as $file) {
-                if (is_dir($file)) {
-                    $file = $this->_slashify($file);
-                }
-
-                $destfile = str_replace($source, $dest, $file);
-
-                if (is_dir($file)) {
-                    if (!file_exists($destfile)) {
-                        if (!$this->_is_writable(dirname($destfile))) {
-                            return "403 Forbidden";
-                        }
-                        if (!mkdir($destfile)) {
-                            return "409 Conflict";
-                        }
-                    } else if (!is_dir($destfile)) {
-                        return "409 Conflict";
-                    }
-                } else {
-
-                    if (!copy($file, $destfile)) {
-                        return "409 Conflict";
-                    }
-                }
-            }
-
-            $query = "INSERT INTO {$this->db_prefix}properties
+			mysql_query($query);
+		} else {
+			if (is_dir($source) && $options["depth"] == "infinity") {	// no find for depth="0"
+				$files = System::find($source);
+				$files = array_reverse($files);
+			} else {
+				$files = array($source);
+			}
+
+			if (!is_array($files) || empty($files)) {
+				return "500 Internal server error";
+			}
+
+
+			foreach ($files as $file) {
+				if (is_dir($file)) {
+					$file = $this->_slashify($file);
+				}
+
+				$destfile = str_replace($source, $dest, $file);
+
+				if (is_dir($file)) {
+					if (!file_exists($destfile)) {
+						if (!$this->_is_writable(dirname($destfile))) {
+							return "403 Forbidden";
+						}
+						if (!mkdir($destfile)) {
+							return "409 Conflict";
+						}
+					} else if (!is_dir($destfile)) {
+						return "409 Conflict";
+					}
+				} else {
+
+					if (!copy($file, $destfile)) {
+						return "409 Conflict";
+					}
+				}
+			}
+
+			$query = "INSERT INTO {$this->db_prefix}properties
                                SELECT *
                                  FROM {$this->db_prefix}properties
                                 WHERE path = '".$options['path']."'";
-        }
-
-        return ($new && !$existing_col) ? "201 Created" : "204 No Content";
-    }
-
-    /**
-     * PROPPATCH method handler
-     *
-     * @param  array  general parameter passing array
-     * @return bool   true on success
-     */
-    function PROPPATCH(&$options)
-    {
-        global $prefs, $tab;
-
-        $msg  = "";
-        $path = $options["path"];
-        $dir  = dirname($path)."/";
-        $base = basename($path);
-
-        foreach ($options["props"] as $key => $prop) {
-            if ($prop["ns"] == "DAV:") {
-                $options["props"][$key]['status'] = "403 Forbidden";
-            } else {
-                if (isset($prop["val"])) {
-                    $query = "REPLACE INTO {$this->db_prefix}properties
+		}
+
+		return ($new && !$existing_col) ? "201 Created" : "204 No Content";
+	}
+
+	/**
+	 * PROPPATCH method handler
+	 *
+	 * @param  array  general parameter passing array
+	 * @return bool   true on success
+	 */
+	function PROPPATCH(&$options)
+	{
+		global $prefs, $tab;
+
+		$msg  = "";
+		$path = $options["path"];
+		$dir  = dirname($path)."/";
+		$base = basename($path);
+
+		foreach ($options["props"] as $key => $prop) {
+			if ($prop["ns"] == "DAV:") {
+				$options["props"][$key]['status'] = "403 Forbidden";
+			} else {
+				if (isset($prop["val"])) {
+					$query = "REPLACE INTO {$this->db_prefix}properties
                                            SET path = '$options[path]'
                                              , name = '$prop[name]'
                                              , ns= '$prop[ns]'
                                              , value = '$prop[val]'";
-                } else {
-                    $query = "DELETE FROM {$this->db_prefix}properties
+				} else {
+					$query = "DELETE FROM {$this->db_prefix}properties
                                         WHERE path = '$options[path]'
                                           AND name = '$prop[name]'
                                           AND ns = '$prop[ns]'";
-                }
-                mysql_query($query);
-            }
-        }
-
-        return "";
-    }
-
-
-    /**
-     * LOCK method handler
-     *
-     * @param  array  general parameter passing array
-     * @return bool   true on success
-     */
-    function LOCK(&$options)
-    {
-        // get absolute fs path to requested resource
-        $fspath = $this->base . $options["path"];
-
-        // TODO recursive locks on directories not supported yet
-        // makes litmus test "32. lock_collection" fail
-        if (is_dir($fspath) && !empty($options["depth"])) {
-            return "409 Conflict";
-        }
-
-        $options["timeout"] = time()+300; // 5min. hardcoded
-
-        if (isset($options["update"])) { // Lock Update
-            $where = "WHERE path = '$options[path]' AND token = '$options[update]'";
-
-            $query = "SELECT owner, exclusivelock FROM {$this->db_prefix}locks $where";
-            $res   = mysql_query($query);
-            $row   = mysql_fetch_assoc($res);
-            mysql_free_result($res);
-
-            if (is_array($row)) {
-                $query = "UPDATE {$this->db_prefix}locks
+				}
+				mysql_query($query);
+			}
+		}
+
+		return "";
+	}
+
+
+	/**
+	 * LOCK method handler
+	 *
+	 * @param  array  general parameter passing array
+	 * @return bool   true on success
+	 */
+	function LOCK(&$options)
+	{
+		// get absolute fs path to requested resource
+		$fspath = $this->base . $options["path"];
+
+		// TODO recursive locks on directories not supported yet
+		// makes litmus test "32. lock_collection" fail
+		if (is_dir($fspath) && !empty($options["depth"])) {
+			return "409 Conflict";
+		}
+
+		$options["timeout"] = time()+300; // 5min. hardcoded
+
+		if (isset($options["update"])) { // Lock Update
+			$where = "WHERE path = '$options[path]' AND token = '$options[update]'";
+
+			$query = "SELECT owner, exclusivelock FROM {$this->db_prefix}locks $where";
+			$res   = mysql_query($query);
+			$row   = mysql_fetch_assoc($res);
+			mysql_free_result($res);
+
+			if (is_array($row)) {
+				$query = "UPDATE {$this->db_prefix}locks
                                  SET expires = '$options[timeout]'
                                    , modified = ".time()."
                               $where";
-                mysql_query($query);
+				mysql_query($query);
 
-                $options['owner'] = $row['owner'];
-                $options['scope'] = $row["exclusivelock"] ? "exclusive" : "shared";
-                $options['type']  = $row["exclusivelock"] ? "write"     : "read";
+				$options['owner'] = $row['owner'];
+				$options['scope'] = $row["exclusivelock"] ? "exclusive" : "shared";
+				$options['type']  = $row["exclusivelock"] ? "write"     : "read";
 
-                return true;
-            } else {
-                return false;
-            }
-        }
+				return true;
+			} else {
+				return false;
+			}
+		}
 
-        $query = "INSERT INTO {$this->db_prefix}locks
+		$query = "INSERT INTO {$this->db_prefix}locks
                         SET token   = '$options[locktoken]'
                           , path    = '$options[path]'
                           , created = ".time()."
@@ -838,76 +838,76 @@ 
                           , owner   = '$options[owner]'
                           , expires = '$options[timeout]'
                           , exclusivelock  = " .($options['scope'] === "exclusive" ? "1" : "0")
-            ;
-        mysql_query($query);
-
-        return mysql_affected_rows() ? "200 OK" : "409 Conflict";
-    }
-
-    /**
-     * UNLOCK method handler
-     *
-     * @param  array  general parameter passing array
-     * @return bool   true on success
-     */
-    function UNLOCK(&$options)
-    {
-        $query = "DELETE FROM {$this->db_prefix}locks
+			;
+		mysql_query($query);
+
+		return mysql_affected_rows() ? "200 OK" : "409 Conflict";
+	}
+
+	/**
+	 * UNLOCK method handler
+	 *
+	 * @param  array  general parameter passing array
+	 * @return bool   true on success
+	 */
+	function UNLOCK(&$options)
+	{
+		$query = "DELETE FROM {$this->db_prefix}locks
                       WHERE path = '$options[path]'
                         AND token = '$options[token]'";
-        mysql_query($query);
-
-        return mysql_affected_rows() ? "204 No Content" : "409 Conflict";
-    }
-
-    /**
-     * checkLock() helper
-     *
-     * @param  string resource path to check for locks
-     * @return bool   true on success
-     */
-    function checkLock($path)
-    {
-        $result = false;
-
-        $query = "SELECT owner, token, created, modified, expires, exclusivelock
+		mysql_query($query);
+
+		return mysql_affected_rows() ? "204 No Content" : "409 Conflict";
+	}
+
+	/**
+	 * checkLock() helper
+	 *
+	 * @param  string resource path to check for locks
+	 * @return bool   true on success
+	 */
+	function checkLock($path)
+	{
+		$result = false;
+
+		$query = "SELECT owner, token, created, modified, expires, exclusivelock
                   FROM {$this->db_prefix}locks
                  WHERE path = '$path'
                ";
-        $res = mysql_query($query);
-
-        if ($res) {
-            $row = mysql_fetch_array($res);
-            mysql_free_result($res);
-
-            if ($row) {
-                $result = array( "type"    => "write",
-                                 "scope"   => $row["exclusivelock"] ? "exclusive" : "shared",
-                                 "depth"   => 0,
-                                 "owner"   => $row['owner'],
-                                 "token"   => $row['token'],
-                                 "created" => $row['created'],
-                                 "modified" => $row['modified'],
-                                 "expires" => $row['expires']
-                                 );
-            }
-        }
-
-        return $result;
-    }
-
-
-    /**
-     * create database tables for property and lock storage
-     *
-     * @param  void
-     * @return bool   true on success
-     */
-    function create_database()
-    {
-        // TODO
-        return false;
-    }
+		$res = mysql_query($query);
+
+		if ($res) {
+			$row = mysql_fetch_array($res);
+			mysql_free_result($res);
+
+			if ($row) {
+				$result = array( "type"    => "write",
+								 "scope"   => $row["exclusivelock"] ? "exclusive" : "shared",
+								 "depth"   => 0,
+								 "owner"   => $row['owner'],
+								 "token"   => $row['token'],
+								 "created" => $row['created'],
+								 "modified" => $row['modified'],
+								 "expires" => $row['expires']
+								 );
+			}
+		}
+
+		return $result;
+	}
+
+
+	/**
+	 * create database tables for property and lock storage
+	 *
+	 * @param  void
+	 * @return bool   true on success
+	 */
+	function create_database()
+	{
+		// TODO
+		return false;
+	}
 }
 
 

Switch Indentation +22 added lines, -22 removed lines

@@ -365,18 +365,18 @@ 
             //       the registry)
             // TODO: have a seperate PEAR class for mimetype detection?
             switch (strtolower(strrchr(basename($fspath), "."))) {
-            case ".html":
-                $mime_type = "text/html";
-                break;
-            case ".gif":
-                $mime_type = "image/gif";
-                break;
-            case ".jpg":
-                $mime_type = "image/jpeg";
-                break;
-            default:
-                $mime_type = "application/octet-stream";
-                break;
+            	case ".html":
+                	$mime_type = "text/html";
+                	break;
+            	case ".gif":
+                	$mime_type = "image/gif";
+                	break;
+            	case ".jpg":
+                	$mime_type = "image/jpeg";
+                	break;
+            	default:
+                	$mime_type = "application/octet-stream";
+                	break;
             }
         }
 
@@ -633,16 +633,16 @@ 
 
         if (is_dir($source)) { // resource is a collection
             switch ($options["depth"]) {
-            case "infinity": // valid
-                break;
-            case "0": // valid for COPY only
-                if ($del) { // MOVE?
-                    return "400 Bad request";
-                }
-                break;
-            case "1": // invalid for both COPY and MOVE
-            default:
-                return "400 Bad request";
+            	case "infinity": // valid
+                	break;
+            	case "0": // valid for COPY only
+                	if ($del) { // MOVE?
+                    	return "400 Bad request";
+                	}
+                	break;
+            	case "1": // invalid for both COPY and MOVE
+            	default:
+                	return "400 Bad request";
             }
         }
 

Spacing +21 added lines, -21 removed lines

@@ -151,7 +151,7 @@ 
     function PROPFIND(&$options, &$files)
     {
         // get absolute fs path to requested resource
-        $fspath = $this->base . $options["path"];
+        $fspath = $this->base.$options["path"];
 
         // sanity check
         if (!file_exists($fspath)) {
@@ -198,7 +198,7 @@ 
     function fileinfo($path)
     {
         // map URI path to filesystem path
-        $fspath = $this->base . $path;
+        $fspath = $this->base.$path;
 
         // create result array
         $info = array();
@@ -210,11 +210,11 @@ 
         $info["props"][] = $this->mkprop("displayname", strtoupper($path));
 
         // creation and modification time
-        $info["props"][] = $this->mkprop("creationdate",    filectime($fspath));
+        $info["props"][] = $this->mkprop("creationdate", filectime($fspath));
         $info["props"][] = $this->mkprop("getlastmodified", filemtime($fspath));
 
         // Microsoft extensions: last access time and 'hidden' status
-        $info["props"][] = $this->mkprop("lastaccessed",    fileatime($fspath));
+        $info["props"][] = $this->mkprop("lastaccessed", fileatime($fspath));
         $info["props"][] = $this->mkprop("ishidden", ('.' === substr(basename($fspath), 0, 1)));
 
         // type and size (caller already made sure that path exists)
@@ -341,8 +341,8 @@ 
             // so we test the format of the returned string
 
             // the reply begins with the requested filename
-            if (!strncmp($reply, "$fspath: ", strlen($fspath)+2)) {
-                $reply = substr($reply, strlen($fspath)+2);
+            if (!strncmp($reply, "$fspath: ", strlen($fspath) + 2)) {
+                $reply = substr($reply, strlen($fspath) + 2);
                 // followed by the mime type (maybe including options)
                 if (preg_match('|^[[:alnum:]_-]+/[[:alnum:]_-]+;?.*|', $reply, $matches)) {
                     $mime_type = $matches[0];
@@ -392,7 +392,7 @@ 
     function HEAD(&$options)
     {
         // get absolute fs path to requested resource
-        $fspath = $this->base . $options["path"];
+        $fspath = $this->base.$options["path"];
 
         // sanity check
         if (!file_exists($fspath)) return false;
@@ -421,7 +421,7 @@ 
     function GET(&$options)
     {
         // get absolute fs path to requested resource
-        $fspath = $this->base . $options["path"];
+        $fspath = $this->base.$options["path"];
 
         // is this a collection?
         if (is_dir($fspath)) {
@@ -504,14 +504,14 @@ 
      */
     function PUT(&$options)
     {
-        $fspath = $this->base . $options["path"];
+        $fspath = $this->base.$options["path"];
 
         $dir = dirname($fspath);
         if (!file_exists($dir) || !is_dir($dir)) {
             return "409 Conflict"; // TODO right status code for both?
         }
 
-        $options["new"] = ! file_exists($fspath);
+        $options["new"] = !file_exists($fspath);
 
         if ($options["new"] && !$this->_is_writable($dir)) {
             return "403 Forbidden";
@@ -537,7 +537,7 @@ 
      */
     function MKCOL($options)
     {
-        $path   = $this->base .$options["path"];
+        $path   = $this->base.$options["path"];
         $parent = dirname($path);
         $name   = basename($path);
 
@@ -549,7 +549,7 @@ 
             return "403 Forbidden";
         }
 
-        if ( file_exists($parent."/".$name) ) {
+        if (file_exists($parent."/".$name)) {
             return "405 Method not allowed";
         }
 
@@ -574,7 +574,7 @@ 
      */
     function DELETE($options)
     {
-        $path = $this->base . "/" .$options["path"];
+        $path = $this->base."/".$options["path"];
 
         if (!file_exists($path)) {
             return "404 Not found";
@@ -613,7 +613,7 @@ 
      * @param  array  general parameter passing array
      * @return bool   true on success
      */
-    function COPY($options, $del=false)
+    function COPY($options, $del = false)
     {
         // TODO Property updates still broken (Litmus should detect this?)
 
@@ -626,7 +626,7 @@ 
             return "502 bad gateway";
         }
 
-        $source = $this->base . $options["path"];
+        $source = $this->base.$options["path"];
         if (!file_exists($source)) {
             return "404 Not found";
         }
@@ -646,7 +646,7 @@ 
             }
         }
 
-        $dest         = $this->base . $options["dest"];
+        $dest         = $this->base.$options["dest"];
         $destdir      = dirname($dest);
 
         if (!file_exists($destdir) || !is_dir($destdir)) {
@@ -795,7 +795,7 @@ 
     function LOCK(&$options)
     {
         // get absolute fs path to requested resource
-        $fspath = $this->base . $options["path"];
+        $fspath = $this->base.$options["path"];
 
         // TODO recursive locks on directories not supported yet
         // makes litmus test "32. lock_collection" fail
@@ -803,7 +803,7 @@ 
             return "409 Conflict";
         }
 
-        $options["timeout"] = time()+300; // 5min. hardcoded
+        $options["timeout"] = time() + 300; // 5min. hardcoded
 
         if (isset($options["update"])) { // Lock Update
             $where = "WHERE path = '$options[path]' AND token = '$options[update]'";
@@ -822,7 +822,7 @@ 
 
                 $options['owner'] = $row['owner'];
                 $options['scope'] = $row["exclusivelock"] ? "exclusive" : "shared";
-                $options['type']  = $row["exclusivelock"] ? "write"     : "read";
+                $options['type']  = $row["exclusivelock"] ? "write" : "read";
 
                 return true;
             } else {
@@ -837,7 +837,7 @@ 
                           , modified = ".time()."
                           , owner   = '$options[owner]'
                           , expires = '$options[timeout]'
-                          , exclusivelock  = " .($options['scope'] === "exclusive" ? "1" : "0")
+                          , exclusivelock  = ".($options['scope'] === "exclusive" ? "1" : "0")
             ;
         mysql_query($query);
 
@@ -881,7 +881,7 @@ 
             mysql_free_result($res);
 
             if ($row) {
-                $result = array( "type"    => "write",
+                $result = array("type"    => "write",
                                  "scope"   => $row["exclusivelock"] ? "exclusive" : "shared",
                                  "depth"   => 0,
                                  "owner"   => $row['owner'],

Braces +212 added lines, -91 removed lines

@@ -105,15 +105,19 @@ 
         // special treatment for litmus compliance test
         // reply on its identifier header
         // not needed for the test itself but eases debugging
-        if (isset($this->_SERVER['HTTP_X_LITMUS'])) {
+        if (isset($this->_SERVER['HTTP_X_LITMUS']))
+        {
             error_log("Litmus test ".$this->_SERVER['HTTP_X_LITMUS']);
             header("X-Litmus-reply: ".$this->_SERVER['HTTP_X_LITMUS']);
         }
 
         // set root directory, defaults to webserver document root if not set
-        if ($base) {
+        if ($base)
+        {
             $this->base = realpath($base); // TODO throw if not a directory
-        } else if (!$this->base) {
+        }
+        else if (!$this->base)
+        {
             $this->base = $this->_SERVER['DOCUMENT_ROOT'];
         }
 
@@ -154,7 +158,8 @@ 
         $fspath = $this->base . $options["path"];
 
         // sanity check
-        if (!file_exists($fspath)) {
+        if (!file_exists($fspath))
+        {
             return false;
         }
 
@@ -165,7 +170,8 @@ 
         $files["files"][] = $this->fileinfo($options["path"]);
 
         // information for contained resources requested?
-        if (!empty($options["depth"]) && is_dir($fspath) && $this->_is_readable($fspath)) {
+        if (!empty($options["depth"]) && is_dir($fspath) && $this->_is_readable($fspath))
+        {
 
             // make sure path ends with '/'
             $options["path"] = $this->_slashify($options["path"]);
@@ -173,10 +179,13 @@ 
             // try to open directory
             $handle = opendir($fspath);
 
-            if ($handle) {
+            if ($handle)
+            {
                 // ok, now get all its contents
-                while ($filename = readdir($handle)) {
-                    if ($filename != "." && $filename != "..") {
+                while ($filename = readdir($handle))
+                {
+                    if ($filename != "." && $filename != "..")
+                    {
                         $files["files"][] = $this->fileinfo($options["path"].$filename);
                     }
                 }
@@ -218,16 +227,22 @@ 
         $info["props"][] = $this->mkprop("ishidden", ('.' === substr(basename($fspath), 0, 1)));
 
         // type and size (caller already made sure that path exists)
-        if (is_dir($fspath)) {
+        if (is_dir($fspath))
+        {
             // directory (WebDAV collection)
             $info["props"][] = $this->mkprop("resourcetype", "collection");
             $info["props"][] = $this->mkprop("getcontenttype", "httpd/unix-directory");
-        } else {
+        }
+        else
+        {
             // plain file (WebDAV resource)
             $info["props"][] = $this->mkprop("resourcetype", "");
-            if ($this->_is_readable($fspath)) {
+            if ($this->_is_readable($fspath))
+            {
                 $info["props"][] = $this->mkprop("getcontenttype", $this->_mimetype($fspath));
-            } else {
+            }
+            else
+            {
                 $info["props"][] = $this->mkprop("getcontenttype", "application/x-non-readable");
             }
             $info["props"][] = $this->mkprop("getcontentlength", filesize($fspath));
@@ -238,7 +253,8 @@ 
                         FROM {$this->db_prefix}properties
                        WHERE path = '$path'";
         $res = mysql_query($query);
-        while ($row = mysql_fetch_assoc($res)) {
+        while ($row = mysql_fetch_assoc($res))
+        {
             $info["props"][] = $this->mkprop($row["ns"], $row["name"], $row["value"]);
         }
         mysql_free_result($res);
@@ -259,30 +275,45 @@ 
     function _can_execute($name, $path = false)
     {
         // path defaults to PATH from environment if not set
-        if ($path === false) {
+        if ($path === false)
+        {
             $path = getenv("PATH");
         }
 
         // check method depends on operating system
-        if (!strncmp(PHP_OS, "WIN", 3)) {
+        if (!strncmp(PHP_OS, "WIN", 3))
+        {
             // on Windows an appropriate COM or EXE file needs to exist
             $exts     = array(".exe", ".com");
             $check_fn = "file_exists";
-        } else {
+        }
+        else
+        {
             // anywhere else we look for an executable file of that name
             $exts     = array("");
             $check_fn = "is_executable";
         }
 
         // now check the directories in the path for the program
-        foreach (explode(PATH_SEPARATOR, $path) as $dir) {
+        foreach (explode(PATH_SEPARATOR, $path) as $dir)
+        {
             // skip invalid path entries
-            if (!file_exists($dir)) continue;
-            if (!is_dir($dir)) continue;
+            if (!file_exists($dir))
+            {
+            	continue;
+            }
+            if (!is_dir($dir))
+            {
+            	continue;
+            }
 
             // and now look for the file
-            foreach ($exts as $ext) {
-                if ($check_fn("$dir/$name".$ext)) return true;
+            foreach ($exts as $ext)
+            {
+                if ($check_fn("$dir/$name".$ext))
+                {
+                	return true;
+                }
             }
         }
 
@@ -323,13 +354,18 @@ 
      */
     function _mimetype($fspath)
     {
-        if (is_dir($fspath)) {
+        if (is_dir($fspath))
+        {
             // directories are easy
             return "httpd/unix-directory";
-        } else if (function_exists("mime_content_type")) {
+        }
+        else if (function_exists("mime_content_type"))
+        {
             // use mime magic extension if available
             $mime_type = mime_content_type($fspath);
-        } else if ($this->_can_execute("file")) {
+        }
+        else if ($this->_can_execute("file"))
+        {
             // it looks like we have a 'file' command,
             // lets see it it does have mime support
             $fp    = popen("file -i '$fspath' 2>/dev/null", "r");
@@ -341,16 +377,19 @@ 
             // so we test the format of the returned string
 
             // the reply begins with the requested filename
-            if (!strncmp($reply, "$fspath: ", strlen($fspath)+2)) {
+            if (!strncmp($reply, "$fspath: ", strlen($fspath)+2))
+            {
                 $reply = substr($reply, strlen($fspath)+2);
                 // followed by the mime type (maybe including options)
-                if (preg_match('|^[[:alnum:]_-]+/[[:alnum:]_-]+;?.*|', $reply, $matches)) {
+                if (preg_match('|^[[:alnum:]_-]+/[[:alnum:]_-]+;?.*|', $reply, $matches))
+                {
                     $mime_type = $matches[0];
                 }
             }
         }
 
-        if (empty($mime_type)) {
+        if (empty($mime_type))
+        {
             // Fallback solution: try to guess the type by the file extension
             // TODO: add more ...
             // TODO: it has been suggested to delegate mimetype detection
@@ -364,7 +403,8 @@ 
             //       anyway (overriding it with information taken from
             //       the registry)
             // TODO: have a seperate PEAR class for mimetype detection?
-            switch (strtolower(strrchr(basename($fspath), "."))) {
+            switch (strtolower(strrchr(basename($fspath), ".")))
+            {
             case ".html":
                 $mime_type = "text/html";
                 break;
@@ -395,7 +435,10 @@ 
         $fspath = $this->base . $options["path"];
 
         // sanity check
-        if (!file_exists($fspath)) return false;
+        if (!file_exists($fspath))
+        {
+        	return false;
+        }
 
         // detect resource type
         $options['mimetype'] = $this->_mimetype($fspath);
@@ -424,12 +467,14 @@ 
         $fspath = $this->base . $options["path"];
 
         // is this a collection?
-        if (is_dir($fspath)) {
+        if (is_dir($fspath))
+        {
             return $this->GetDir($fspath, $options);
         }
 
         // the header output is the same as for HEAD
-        if (!$this->HEAD($options)) {
+        if (!$this->HEAD($options))
+        {
             return false;
         }
 
@@ -451,7 +496,8 @@ 
     function GetDir($fspath, &$options)
     {
         $path = $this->_slashify($options["path"]);
-        if ($path != $options["path"]) {
+        if ($path != $options["path"])
+        {
             header("Location: ".$this->base_uri.$path);
             exit;
         }
@@ -459,12 +505,14 @@ 
         // fixed width directory column format
         $format = "%15s  %-19s  %-s\n";
 
-        if (!$this->_is_readable($fspath)) {
+        if (!$this->_is_readable($fspath))
+        {
             return false;
         }
 
         $handle = opendir($fspath);
-        if (!$handle) {
+        if (!$handle)
+        {
             return false;
         }
 
@@ -476,8 +524,10 @@ 
         printf($format, "Size", "Last modified", "Filename");
         echo "<hr>";
 
-        while ($filename = readdir($handle)) {
-            if ($filename != "." && $filename != "..") {
+        while ($filename = readdir($handle))
+        {
+            if ($filename != "." && $filename != "..")
+            {
                 $fullpath = $fspath.$filename;
                 $name     = htmlspecialchars($filename);
                 printf($format,
@@ -507,19 +557,23 @@ 
         $fspath = $this->base . $options["path"];
 
         $dir = dirname($fspath);
-        if (!file_exists($dir) || !is_dir($dir)) {
+        if (!file_exists($dir) || !is_dir($dir))
+        {
             return "409 Conflict"; // TODO right status code for both?
         }
 
         $options["new"] = ! file_exists($fspath);
 
-        if ($options["new"] && !$this->_is_writable($dir)) {
+        if ($options["new"] && !$this->_is_writable($dir))
+        {
             return "403 Forbidden";
         }
-        if (!$options["new"] && !$this->_is_writable($fspath)) {
+        if (!$options["new"] && !$this->_is_writable($fspath))
+        {
             return "403 Forbidden";
         }
-        if (!$options["new"] && is_dir($fspath)) {
+        if (!$options["new"] && is_dir($fspath))
+        {
             return "403 Forbidden";
         }
 
@@ -541,24 +595,30 @@ 
         $parent = dirname($path);
         $name   = basename($path);
 
-        if (!file_exists($parent)) {
+        if (!file_exists($parent))
+        {
             return "409 Conflict";
         }
 
-        if (!is_dir($parent)) {
+        if (!is_dir($parent))
+        {
             return "403 Forbidden";
         }
 
-        if ( file_exists($parent."/".$name) ) {
+        if ( file_exists($parent."/".$name) )
+        {
             return "405 Method not allowed";
         }
 
-        if (!empty($this->_SERVER["CONTENT_LENGTH"])) { // no body parsing yet
+        if (!empty($this->_SERVER["CONTENT_LENGTH"]))
+        {
+// no body parsing yet
             return "415 Unsupported media type";
         }
 
         $stat = mkdir($parent."/".$name, 0777);
-        if (!$stat) {
+        if (!$stat)
+        {
             return "403 Forbidden";
         }
 
@@ -576,16 +636,20 @@ 
     {
         $path = $this->base . "/" .$options["path"];
 
-        if (!file_exists($path)) {
+        if (!file_exists($path))
+        {
             return "404 Not found";
         }
 
-        if (is_dir($path)) {
+        if (is_dir($path))
+        {
             $query = "DELETE FROM {$this->db_prefix}properties
                            WHERE path LIKE '".$this->_slashify($options["path"])."%'";
             mysql_query($query);
             System::rm(array("-rf", $path));
-        } else {
+        }
+        else
+        {
             unlink($path);
         }
         $query = "DELETE FROM {$this->db_prefix}properties
@@ -617,26 +681,35 @@ 
     {
         // TODO Property updates still broken (Litmus should detect this?)
 
-        if (!empty($this->_SERVER["CONTENT_LENGTH"])) { // no body parsing yet
+        if (!empty($this->_SERVER["CONTENT_LENGTH"]))
+        {
+// no body parsing yet
             return "415 Unsupported media type";
         }
 
         // no copying to different WebDAV Servers yet
-        if (isset($options["dest_url"])) {
+        if (isset($options["dest_url"]))
+        {
             return "502 bad gateway";
         }
 
         $source = $this->base . $options["path"];
-        if (!file_exists($source)) {
+        if (!file_exists($source))
+        {
             return "404 Not found";
         }
 
-        if (is_dir($source)) { // resource is a collection
-            switch ($options["depth"]) {
+        if (is_dir($source))
+        {
+// resource is a collection
+            switch ($options["depth"])
+            {
             case "infinity": // valid
                 break;
             case "0": // valid for COPY only
-                if ($del) { // MOVE?
+                if ($del)
+                {
+// MOVE?
                     return "400 Bad request";
                 }
                 break;
@@ -649,7 +722,8 @@ 
         $dest         = $this->base . $options["dest"];
         $destdir      = dirname($dest);
 
-        if (!file_exists($destdir) || !is_dir($destdir)) {
+        if (!file_exists($destdir) || !is_dir($destdir))
+        {
             return "409 Conflict";
         }
 
@@ -657,38 +731,52 @@ 
         $new          = !file_exists($dest);
         $existing_col = false;
 
-        if (!$new) {
-            if ($del && is_dir($dest)) {
-                if (!$options["overwrite"]) {
+        if (!$new)
+        {
+            if ($del && is_dir($dest))
+            {
+                if (!$options["overwrite"])
+                {
                     return "412 precondition failed";
                 }
                 $dest .= basename($source);
-                if (file_exists($dest)) {
+                if (file_exists($dest))
+                {
                     $options["dest"] .= basename($source);
-                } else {
+                }
+                else
+                {
                     $new          = true;
                     $existing_col = true;
                 }
             }
         }
 
-        if (!$new) {
-            if ($options["overwrite"]) {
+        if (!$new)
+        {
+            if ($options["overwrite"])
+            {
                 $stat = $this->DELETE(array("path" => $options["dest"]));
-                if (($stat{0} != "2") && (substr($stat, 0, 3) != "404")) {
+                if (($stat{0} != "2") && (substr($stat, 0, 3) != "404"))
+                {
                     return $stat;
                 }
-            } else {
+            }
+            else
+            {
                 return "412 precondition failed";
             }
         }
 
-        if ($del) {
-            if (!rename($source, $dest)) {
+        if ($del)
+        {
+            if (!rename($source, $dest))
+            {
                 return "500 Internal server error";
             }
             $destpath = $this->_unslashify($options["dest"]);
-            if (is_dir($source)) {
+            if (is_dir($source))
+            {
                 $query = "UPDATE {$this->db_prefix}properties
                                  SET path = REPLACE(path, '".$options["path"]."', '".$destpath."')
                                WHERE path LIKE '".$this->_slashify($options["path"])."%'";
@@ -699,40 +787,58 @@ 
                              SET path = '".$destpath."'
                            WHERE path = '".$options["path"]."'";
             mysql_query($query);
-        } else {
-            if (is_dir($source) && $options["depth"] == "infinity") {	// no find for depth="0"
+        }
+        else
+        {
+            if (is_dir($source) && $options["depth"] == "infinity")
+            {
+// no find for depth="0"
                 $files = System::find($source);
                 $files = array_reverse($files);
-            } else {
+            }
+            else
+            {
                 $files = array($source);
             }
 
-            if (!is_array($files) || empty($files)) {
+            if (!is_array($files) || empty($files))
+            {
                 return "500 Internal server error";
             }
 
 
-            foreach ($files as $file) {
-                if (is_dir($file)) {
+            foreach ($files as $file)
+            {
+                if (is_dir($file))
+                {
                     $file = $this->_slashify($file);
                 }
 
                 $destfile = str_replace($source, $dest, $file);
 
-                if (is_dir($file)) {
-                    if (!file_exists($destfile)) {
-                        if (!$this->_is_writable(dirname($destfile))) {
+                if (is_dir($file))
+                {
+                    if (!file_exists($destfile))
+                    {
+                        if (!$this->_is_writable(dirname($destfile)))
+                        {
                             return "403 Forbidden";
                         }
-                        if (!mkdir($destfile)) {
+                        if (!mkdir($destfile))
+                        {
                             return "409 Conflict";
                         }
-                    } else if (!is_dir($destfile)) {
+                    }
+                    else if (!is_dir($destfile))
+                    {
                         return "409 Conflict";
                     }
-                } else {
+                }
+                else
+                {
 
-                    if (!copy($file, $destfile)) {
+                    if (!copy($file, $destfile))
+                    {
                         return "409 Conflict";
                     }
                 }
@@ -762,17 +868,24 @@ 
         $dir  = dirname($path)."/";
         $base = basename($path);
 
-        foreach ($options["props"] as $key => $prop) {
-            if ($prop["ns"] == "DAV:") {
+        foreach ($options["props"] as $key => $prop)
+        {
+            if ($prop["ns"] == "DAV:")
+            {
                 $options["props"][$key]['status'] = "403 Forbidden";
-            } else {
-                if (isset($prop["val"])) {
+            }
+            else
+            {
+                if (isset($prop["val"]))
+                {
                     $query = "REPLACE INTO {$this->db_prefix}properties
                                            SET path = '$options[path]'
                                              , name = '$prop[name]'
                                              , ns= '$prop[ns]'
                                              , value = '$prop[val]'";
-                } else {
+                }
+                else
+                {
                     $query = "DELETE FROM {$this->db_prefix}properties
                                         WHERE path = '$options[path]'
                                           AND name = '$prop[name]'
@@ -799,13 +912,16 @@ 
 
         // TODO recursive locks on directories not supported yet
         // makes litmus test "32. lock_collection" fail
-        if (is_dir($fspath) && !empty($options["depth"])) {
+        if (is_dir($fspath) && !empty($options["depth"]))
+        {
             return "409 Conflict";
         }
 
         $options["timeout"] = time()+300; // 5min. hardcoded
 
-        if (isset($options["update"])) { // Lock Update
+        if (isset($options["update"]))
+        {
+// Lock Update
             $where = "WHERE path = '$options[path]' AND token = '$options[update]'";
 
             $query = "SELECT owner, exclusivelock FROM {$this->db_prefix}locks $where";
@@ -813,7 +929,8 @@ 
             $row   = mysql_fetch_assoc($res);
             mysql_free_result($res);
 
-            if (is_array($row)) {
+            if (is_array($row))
+            {
                 $query = "UPDATE {$this->db_prefix}locks
                                  SET expires = '$options[timeout]'
                                    , modified = ".time()."
@@ -825,7 +942,9 @@ 
                 $options['type']  = $row["exclusivelock"] ? "write"     : "read";
 
                 return true;
-            } else {
+            }
+            else
+            {
                 return false;
             }
         }
@@ -876,11 +995,13 @@ 
                ";
         $res = mysql_query($query);
 
-        if ($res) {
+        if ($res)
+        {
             $row = mysql_fetch_array($res);
             mysql_free_result($res);
 
-            if ($row) {
+            if ($row)
+            {
                 $result = array( "type"    => "write",
                                  "scope"   => $row["exclusivelock"] ? "exclusive" : "shared",
                                  "depth"   => 0,

Upper-Lower-Casing +3 added lines, -3 removed lines

@@ -689,13 +689,13 @@ 
             }
             $destpath = $this->_unslashify($options["dest"]);
             if (is_dir($source)) {
-                $query = "UPDATE {$this->db_prefix}properties
+                $query = "update {$this->db_prefix}properties
                                  SET path = REPLACE(path, '".$options["path"]."', '".$destpath."')
                                WHERE path LIKE '".$this->_slashify($options["path"])."%'";
                 mysql_query($query);
             }
 
-            $query = "UPDATE {$this->db_prefix}properties
+            $query = "update {$this->db_prefix}properties
                              SET path = '".$destpath."'
                            WHERE path = '".$options["path"]."'";
             mysql_query($query);
@@ -814,7 +814,7 @@ 
             mysql_free_result($res);
 
             if (is_array($row)) {
-                $query = "UPDATE {$this->db_prefix}locks
+                $query = "update {$this->db_prefix}locks
                                  SET expires = '$options[timeout]'
                                    , modified = ".time()."
                               $where";

api/src/WebDAV/Tools/_parse_proppatch.php

Doc Comments +1 added lines

@@ -95,6 +95,7 @@
      *
      * @param  string  path of input stream
      * @param boolean $store_request =false if true whole request data will be made available in $this->request
+     * @param string $path
      * @access public
      */
     function __construct($path, $store_request=false)

Indentation +192 added lines, -192 removed lines

@@ -43,198 +43,198 @@
  */
 class _parse_proppatch
 {
-    /**
-     *
-     *
-     * @var
-     * @access
-     */
-    var $success;
-
-    /**
-     *
-     *
-     * @var
-     * @access
-     */
-    var $props;
-
-    /**
-     *
-     *
-     * @var
-     * @access
-     */
-    var $depth;
-
-    /**
-     *
-     *
-     * @var
-     * @access
-     */
-    var $mode;
-
-    /**
-     *
-     *
-     * @var
-     * @access
-     */
-    var $current;
-
-    /**
-     * On return whole request, if $store_request == true was specified in constructor
-     *
-     * @var string
-     */
-    var $request;
-
-    /**
-     * constructor
-     *
-     * @param  string  path of input stream
-     * @param boolean $store_request =false if true whole request data will be made available in $this->request
-     * @access public
-     */
-    function __construct($path, $store_request=false)
-    {
-        $this->success = true;
-
-        $this->depth = 0;
-        $this->props = array();
-        $had_input = false;
-
-        $f_in = fopen($path, "r");
-        if (!$f_in) {
-            $this->success = false;
-            return;
-        }
-
-        $xml_parser = xml_parser_create_ns("UTF-8", " ");
-
-        xml_set_element_handler($xml_parser,
-                                array(&$this, "_startElement"),
-                                array(&$this, "_endElement"));
-
-        xml_set_character_data_handler($xml_parser,
-                                       array(&$this, "_data"));
-
-        xml_parser_set_option($xml_parser,
-                              XML_OPTION_CASE_FOLDING, false);
-
-        while($this->success && !feof($f_in)) {
-            $line = fgets($f_in);
-            if ($store_request) $this->request .= $line;
-            if (is_string($line)) {
-                $had_input = true;
-                $this->success &= xml_parse($xml_parser, $line, false);
-            }
-        }
-
-        if($had_input) {
-            $this->success &= xml_parse($xml_parser, "", true);
-        }
-
-        xml_parser_free($xml_parser);
-
-        fclose($f_in);
-    }
-
-    /**
-     * tag start handler
-     *
-     * @param  resource  parser
-     * @param  string    tag name
-     * @param  array     tag attributes
-     * @return void
-     * @access private
-     */
-    function _startElement($parser, $name, $attrs)
-    {
-        if (strstr($name, " ")) {
-            list($ns, $tag) = explode(" ", $name);
-            if ($ns == "")
-                $this->success = false;
-        } else {
-            $ns = "";
-            $tag = $name;
-        }
-
-        if ($this->depth == 1) {
-            $this->mode = $tag;
-        }
-
-        if ($this->depth == 3) {
-            $prop = array("name" => $tag);
-            $this->current = array("name" => $tag, "ns" => $ns, "status"=> 200);
-            if ($this->mode == "set") {
-                $this->current["val"] = "";     // default set val
-            }
-        }
-
-        if ($this->depth >= 4) {
-            $this->current["val"] .= "<$tag";
-            if (isset($attr)) {
-                foreach ($attr as $key => $val) {
-                    $this->current["val"] .= ' '.$key.'="'.str_replace('"','&quot;', $val).'"';
-                }
-            }
-            $this->current["val"] .= ">";
-        }
-
-
-
-        $this->depth++;
-    }
-
-    /**
-     * tag end handler
-     *
-     * @param  resource  parser
-     * @param  string    tag name
-     * @return void
-     * @access private
-     */
-    function _endElement($parser, $name)
-    {
-        if (strstr($name, " ")) {
-            list($ns, $tag) = explode(" ", $name);
-            if ($ns == "")
-                $this->success = false;
-        } else {
-            $ns = "";
-            $tag = $name;
-        }
-
-        $this->depth--;
-
-        if ($this->depth >= 4) {
-            $this->current["val"] .= "</$tag>";
-        }
-
-        if ($this->depth == 3) {
-            if (isset($this->current)) {
-                $this->props[] = $this->current;
-                unset($this->current);
-            }
-        }
-    }
-
-    /**
-     * input data handler
-     *
-     * @param  resource  parser
-     * @param  string    data
-     * @return void
-     * @access private
-     */
-    function _data($parser, $data)
-    {
-        if (isset($this->current)) {
-            $this->current["val"] .= $data;
-        }
-    }
+	/**
+	 *
+	 *
+	 * @var
+	 * @access
+	 */
+	var $success;
+
+	/**
+	 *
+	 *
+	 * @var
+	 * @access
+	 */
+	var $props;
+
+	/**
+	 *
+	 *
+	 * @var
+	 * @access
+	 */
+	var $depth;
+
+	/**
+	 *
+	 *
+	 * @var
+	 * @access
+	 */
+	var $mode;
+
+	/**
+	 *
+	 *
+	 * @var
+	 * @access
+	 */
+	var $current;
+
+	/**
+	 * On return whole request, if $store_request == true was specified in constructor
+	 *
+	 * @var string
+	 */
+	var $request;
+
+	/**
+	 * constructor
+	 *
+	 * @param  string  path of input stream
+	 * @param boolean $store_request =false if true whole request data will be made available in $this->request
+	 * @access public
+	 */
+	function __construct($path, $store_request=false)
+	{
+		$this->success = true;
+
+		$this->depth = 0;
+		$this->props = array();
+		$had_input = false;
+
+		$f_in = fopen($path, "r");
+		if (!$f_in) {
+			$this->success = false;
+			return;
+		}
+
+		$xml_parser = xml_parser_create_ns("UTF-8", " ");
+
+		xml_set_element_handler($xml_parser,
+								array(&$this, "_startElement"),
+								array(&$this, "_endElement"));
+
+		xml_set_character_data_handler($xml_parser,
+									   array(&$this, "_data"));
+
+		xml_parser_set_option($xml_parser,
+							  XML_OPTION_CASE_FOLDING, false);
+
+		while($this->success && !feof($f_in)) {
+			$line = fgets($f_in);
+			if ($store_request) $this->request .= $line;
+			if (is_string($line)) {
+				$had_input = true;
+				$this->success &= xml_parse($xml_parser, $line, false);
+			}
+		}
+
+		if($had_input) {
+			$this->success &= xml_parse($xml_parser, "", true);
+		}
+
+		xml_parser_free($xml_parser);
+
+		fclose($f_in);
+	}
+
+	/**
+	 * tag start handler
+	 *
+	 * @param  resource  parser
+	 * @param  string    tag name
+	 * @param  array     tag attributes
+	 * @return void
+	 * @access private
+	 */
+	function _startElement($parser, $name, $attrs)
+	{
+		if (strstr($name, " ")) {
+			list($ns, $tag) = explode(" ", $name);
+			if ($ns == "")
+				$this->success = false;
+		} else {
+			$ns = "";
+			$tag = $name;
+		}
+
+		if ($this->depth == 1) {
+			$this->mode = $tag;
+		}
+
+		if ($this->depth == 3) {
+			$prop = array("name" => $tag);
+			$this->current = array("name" => $tag, "ns" => $ns, "status"=> 200);
+			if ($this->mode == "set") {
+				$this->current["val"] = "";     // default set val
+			}
+		}
+
+		if ($this->depth >= 4) {
+			$this->current["val"] .= "<$tag";
+			if (isset($attr)) {
+				foreach ($attr as $key => $val) {
+					$this->current["val"] .= ' '.$key.'="'.str_replace('"','&quot;', $val).'"';
+				}
+			}
+			$this->current["val"] .= ">";
+		}
+
+
+
+		$this->depth++;
+	}
+
+	/**
+	 * tag end handler
+	 *
+	 * @param  resource  parser
+	 * @param  string    tag name
+	 * @return void
+	 * @access private
+	 */
+	function _endElement($parser, $name)
+	{
+		if (strstr($name, " ")) {
+			list($ns, $tag) = explode(" ", $name);
+			if ($ns == "")
+				$this->success = false;
+		} else {
+			$ns = "";
+			$tag = $name;
+		}
+
+		$this->depth--;
+
+		if ($this->depth >= 4) {
+			$this->current["val"] .= "</$tag>";
+		}
+
+		if ($this->depth == 3) {
+			if (isset($this->current)) {
+				$this->props[] = $this->current;
+				unset($this->current);
+			}
+		}
+	}
+
+	/**
+	 * input data handler
+	 *
+	 * @param  resource  parser
+	 * @param  string    data
+	 * @return void
+	 * @access private
+	 */
+	function _data($parser, $data)
+	{
+		if (isset($this->current)) {
+			$this->current["val"] .= $data;
+		}
+	}
 }
 
 /*

Spacing +5 added lines, -5 removed lines

@@ -97,7 +97,7 @@ 
      * @param boolean $store_request =false if true whole request data will be made available in $this->request
      * @access public
      */
-    function __construct($path, $store_request=false)
+    function __construct($path, $store_request = false)
     {
         $this->success = true;
 
@@ -123,7 +123,7 @@ 
         xml_parser_set_option($xml_parser,
                               XML_OPTION_CASE_FOLDING, false);
 
-        while($this->success && !feof($f_in)) {
+        while ($this->success && !feof($f_in)) {
             $line = fgets($f_in);
             if ($store_request) $this->request .= $line;
             if (is_string($line)) {
@@ -132,7 +132,7 @@ 
             }
         }
 
-        if($had_input) {
+        if ($had_input) {
             $this->success &= xml_parse($xml_parser, "", true);
         }
 
@@ -169,7 +169,7 @@ 
             $prop = array("name" => $tag);
             $this->current = array("name" => $tag, "ns" => $ns, "status"=> 200);
             if ($this->mode == "set") {
-                $this->current["val"] = "";     // default set val
+                $this->current["val"] = ""; // default set val
             }
         }
 
@@ -177,7 +177,7 @@ 
             $this->current["val"] .= "<$tag";
             if (isset($attr)) {
                 foreach ($attr as $key => $val) {
-                    $this->current["val"] .= ' '.$key.'="'.str_replace('"','&quot;', $val).'"';
+                    $this->current["val"] .= ' '.$key.'="'.str_replace('"', '&quot;', $val).'"';
                 }
             }
             $this->current["val"] .= ">";

Braces +48 added lines, -21 removed lines

@@ -106,7 +106,8 @@ 
         $had_input = false;
 
         $f_in = fopen($path, "r");
-        if (!$f_in) {
+        if (!$f_in)
+        {
             $this->success = false;
             return;
         }
@@ -123,16 +124,22 @@ 
         xml_parser_set_option($xml_parser,
                               XML_OPTION_CASE_FOLDING, false);
 
-        while($this->success && !feof($f_in)) {
+        while($this->success && !feof($f_in))
+        {
             $line = fgets($f_in);
-            if ($store_request) $this->request .= $line;
-            if (is_string($line)) {
+            if ($store_request)
+            {
+            	$this->request .= $line;
+            }
+            if (is_string($line))
+            {
                 $had_input = true;
                 $this->success &= xml_parse($xml_parser, $line, false);
             }
         }
 
-        if($had_input) {
+        if($had_input)
+        {
             $this->success &= xml_parse($xml_parser, "", true);
         }
 
@@ -152,31 +159,42 @@ 
      */
     function _startElement($parser, $name, $attrs)
     {
-        if (strstr($name, " ")) {
+        if (strstr($name, " "))
+        {
             list($ns, $tag) = explode(" ", $name);
             if ($ns == "")
-                $this->success = false;
-        } else {
+            {
+                            $this->success = false;
+            }
+        }
+        else
+        {
             $ns = "";
             $tag = $name;
         }
 
-        if ($this->depth == 1) {
+        if ($this->depth == 1)
+        {
             $this->mode = $tag;
         }
 
-        if ($this->depth == 3) {
+        if ($this->depth == 3)
+        {
             $prop = array("name" => $tag);
             $this->current = array("name" => $tag, "ns" => $ns, "status"=> 200);
-            if ($this->mode == "set") {
+            if ($this->mode == "set")
+            {
                 $this->current["val"] = "";     // default set val
             }
         }
 
-        if ($this->depth >= 4) {
+        if ($this->depth >= 4)
+        {
             $this->current["val"] .= "<$tag";
-            if (isset($attr)) {
-                foreach ($attr as $key => $val) {
+            if (isset($attr))
+            {
+                foreach ($attr as $key => $val)
+                {
                     $this->current["val"] .= ' '.$key.'="'.str_replace('"','&quot;', $val).'"';
                 }
             }
@@ -198,23 +216,31 @@ 
      */
     function _endElement($parser, $name)
     {
-        if (strstr($name, " ")) {
+        if (strstr($name, " "))
+        {
             list($ns, $tag) = explode(" ", $name);
             if ($ns == "")
-                $this->success = false;
-        } else {
+            {
+                            $this->success = false;
+            }
+        }
+        else
+        {
             $ns = "";
             $tag = $name;
         }
 
         $this->depth--;
 
-        if ($this->depth >= 4) {
+        if ($this->depth >= 4)
+        {
             $this->current["val"] .= "</$tag>";
         }
 
-        if ($this->depth == 3) {
-            if (isset($this->current)) {
+        if ($this->depth == 3)
+        {
+            if (isset($this->current))
+            {
                 $this->props[] = $this->current;
                 unset($this->current);
             }
@@ -231,7 +257,8 @@ 
      */
     function _data($parser, $data)
     {
-        if (isset($this->current)) {
+        if (isset($this->current))
+        {
             $this->current["val"] .= $data;
         }
     }