EGroupware / egroupware

doc/rpm-build/post_install.php

Spacing +80 added lines, -83 removed lines

@@ -18,7 +18,7 @@ 
 	'php'         => '/usr/bin/php',
 	'source_dir'  => '/usr/share/egroupware',
 	'data_dir'    => '/var/lib/egroupware',
-	'header'      => '$data_dir/header.inc.php',	// symlinked to source_dir by rpm
+	'header'      => '$data_dir/header.inc.php', // symlinked to source_dir by rpm
 	'setup-cli'   => '$source_dir/setup/setup-cli.php',
 	'domain'      => 'default',
 	'config_user' => 'admin',
@@ -30,13 +30,13 @@ 
 	'db_user'     => 'egroupware',
 	'db_pass'     => randomstring(),
 	'db_grant_host' => 'localhost',
-	'db_root'     => 'root',	// mysql root user/pw to create database
+	'db_root'     => 'root', // mysql root user/pw to create database
 	'db_root_pw'  => '',
 	'backup'      => '',
 	'admin_user'  => 'sysop',
 	'admin_passwd'=> randomstring(),
 	'admin_email' => '',
-	'lang'        => 'en',	// languages for admin user and extra lang to install
+	'lang'        => 'en', // languages for admin user and extra lang to install
 	'charset'     => 'utf-8',
 	'start_db'    => '/sbin/service mysqld',
 	'autostart_db' => '/sbin/chkconfig --level 345 mysqld on',
@@ -56,23 +56,23 @@ 
 	'ldap_search_filter' => '(uid=%user)',
 	'ldap_group_context' => 'ou=groups,$base',
 	'ldap_encryption_type' => '',
-	'sambaadmin/sambasid'=> '',	// SID for sambaadmin
+	'sambaadmin/sambasid'=> '', // SID for sambaadmin
 	'mailserver'    => '',
 	'smtpserver'    => 'localhost,25',
-	'smtp'          => '',	// see setup-cli.php --help config
+	'smtp'          => '', // see setup-cli.php --help config
 	'imap'          => '',
 	'sieve'         => '',
 	'folder'        => '',
-	'install-update-app' => '',	// install or update a single (non-default) app
-	'webserver_user'=> 'apache',	// required to fix permissions
+	'install-update-app' => '', // install or update a single (non-default) app
+	'webserver_user'=> 'apache', // required to fix permissions
 	'php5enmod'     => '',
 );
 
 // read language from LANG enviroment variable
 if (($lang = isset($_ENV['LANG']) ? $_ENV['LANG'] : (isset($_SERVER['LANG']) ? $_SERVER['LANG'] : null)))
 {
-	@list($lang,$nat) = preg_split('/[_.]/',$lang);
-	if (in_array($lang.'-'.strtolower($nat),array('es-es','pt-br','zh-tw')))
+	@list($lang, $nat) = preg_split('/[_.]/', $lang);
+	if (in_array($lang.'-'.strtolower($nat), array('es-es', 'pt-br', 'zh-tw')))
 	{
 		$lang .= '-'.strtolower($nat);
 	}
@@ -85,16 +85,13 @@ 
  *
  * @param string $distro =null default autodetect
  */
-function set_distro_defaults($distro=null)
+function set_distro_defaults($distro = null)
 {
 	global $config;
 	if (is_null($distro))
 	{
-		$distro = file_exists('/etc/SuSE-release') ? 'suse' :
-			(file_exists('/etc/mandriva-release') ? 'mandriva' :
-			(file_exists('/etc/lsb-release') && preg_match('/^DISTRIB_ID="?Univention"?$/mi',
-				file_get_contents('/etc/lsb-release')) ? 'univention' :
-			(file_exists('/etc/debian_version') ? 'debian' : 'rh')));
+		$distro = file_exists('/etc/SuSE-release') ? 'suse' : (file_exists('/etc/mandriva-release') ? 'mandriva' : (file_exists('/etc/lsb-release') && preg_match('/^DISTRIB_ID="?Univention"?$/mi',
+				file_get_contents('/etc/lsb-release')) ? 'univention' : (file_exists('/etc/debian_version') ? 'debian' : 'rh')));
 	}
 	switch (($config['distro'] = $distro))
 	{
@@ -162,9 +159,9 @@ 
 			}
 			elseif (!file_exists('/etc/init.d/mysqld') && file_exists('/etc/init.d/mysql'))
 			{
-				foreach(array('start_db','autostart_db') as $name)
+				foreach (array('start_db', 'autostart_db') as $name)
 				{
-					$config[$name] = str_replace('mysqld','mysql',$config[$name]);
+					$config[$name] = str_replace('mysqld', 'mysql', $config[$name]);
 				}
 			}
 			break;
@@ -180,48 +177,48 @@ 
 if (($config_set = isset($_ENV['EGW_POST_INSTALL']) ? $_ENV['EGW_POST_INSTALL'] : @$_SERVER['EGW_POST_INSTALL']))
 {
 	$conf = array();
-	$config_set = preg_split('/[ \t]+/',trim($config_set));
-	while($config_set)
+	$config_set = preg_split('/[ \t]+/', trim($config_set));
+	while ($config_set)
 	{
 		$val = array_shift($config_set);
 		if (($quote = $val[0]) == "'" || $quote == '"')	// arguments might be quoted with ' or "
 		{
-			while (substr($val,-1) != $quote)
+			while (substr($val, -1) != $quote)
 			{
 				if (!$config_set) throw new Exception('Invalid EGW_POST_INSTALL enviroment variable!');
 				$val .= ' '.array_shift($config_set);
 			}
-			$val = substr($val,1,-1);
+			$val = substr($val, 1, -1);
 		}
 		$conf[] = $val;
 	}
-	$argv = array_merge($conf,$argv);
+	$argv = array_merge($conf, $argv);
 }
 
 $auth_type_given = false;
-while(($arg = array_shift($argv)))
+while (($arg = array_shift($argv)))
 {
 	if ($arg == '-v' || $arg == '--verbose')
 	{
 		$verbose = true;
 	}
-	elseif($arg == '-h' || $arg == '--help')
+	elseif ($arg == '-h' || $arg == '--help')
 	{
 		usage();
 	}
-	elseif($arg == '--suse')
+	elseif ($arg == '--suse')
 	{
 		set_distro_defaults('suse');
 	}
-	elseif($arg == '--distro')
+	elseif ($arg == '--distro')
 	{
 		set_distro_defaults(array_shift($argv));
 	}
-	elseif(substr($arg,0,2) == '--' && isset($config[$name=substr($arg,2)]))
+	elseif (substr($arg, 0, 2) == '--' && isset($config[$name = substr($arg, 2)]))
 	{
 		$config[$name] = array_shift($argv);
 
-		switch($name)
+		switch ($name)
 		{
 			case 'auth_type':
 				$auth_type_given = true;
@@ -242,18 +239,18 @@ 
 }
 
 $replace = array();
-foreach($config as $name => $value)
+foreach ($config as $name => $value)
 {
 	$replace['$'.$name] = $value;
-	if (strpos($value,'$') !== false)
+	if (strpos($value, '$') !== false)
 	{
-		$config[$name] = strtr($value,$replace);
+		$config[$name] = strtr($value, $replace);
 	}
 }
 // basic config checks
-foreach(array('php','source_dir','data_dir','setup-cli') as $name)
+foreach (array('php', 'source_dir', 'data_dir', 'setup-cli') as $name)
 {
-	if (!file_exists($config[$name])) bail_out(1,$config[$name].' not found!');
+	if (!file_exists($config[$name])) bail_out(1, $config[$name].' not found!');
 }
 
 // fix important php.ini and conf.d/*.ini settings
@@ -278,7 +275,7 @@ 
 	}
 	// create database
 	$setup_db = $setup_cli.' --setup-cmd-database sub_command=create_db';
-	foreach(array('domain','db_type','db_host','db_port','db_name','db_user','db_pass','db_root','db_root_pw','db_grant_host') as $name)
+	foreach (array('domain', 'db_type', 'db_host', 'db_port', 'db_name', 'db_user', 'db_pass', 'db_root', 'db_root_pw', 'db_grant_host') as $name)
 	{
 		$setup_db .= ' '.escapeshellarg($name.'='.$config[$name]);
 	}
@@ -286,7 +283,7 @@ 
 
 	// check if ldap is required and initialise it
 	// we need to specify account_repository and auth_type to --install as extra config, otherwise install happens for sql!
-	@list($config['account_repository'],$config['auth_type'],$rest) = explode(',',$config['account-auth'],3);
+	@list($config['account_repository'], $config['auth_type'], $rest) = explode(',', $config['account-auth'], 3);
 	$extra_config .= ' '.escapeshellarg('account_repository='.$config['account_repository']);
 	$extra_config .= ' '.escapeshellarg('auth_type='.(empty($config['auth_type']) ? $config['account_repository'] : $config['auth_type']));
 	if (empty($rest)) unset($config['account-auth']);
@@ -297,15 +294,15 @@ 
 
 		$setup_ldap = $setup_cli.' --setup-cmd-ldap sub_command='.
 			($config['account_repository'] == 'ldap' ? 'create_ldap' : 'test_ldap');
-		foreach(array(
-			'domain','ldap_suffix','ldap_host','ldap_admin','ldap_admin_pw',	// non-egw params: only used for create
-			'ldap_base','ldap_root_dn','ldap_root_pw','ldap_context','ldap_search_filter','ldap_group_context',	// egw params
+		foreach (array(
+			'domain', 'ldap_suffix', 'ldap_host', 'ldap_admin', 'ldap_admin_pw', // non-egw params: only used for create
+			'ldap_base', 'ldap_root_dn', 'ldap_root_pw', 'ldap_context', 'ldap_search_filter', 'ldap_group_context', // egw params
 			'ldap_encryption_type', 'sambaadmin/sambasid',
 		) as $name)
 		{
-			if (strpos($value=$config[$name],'$') !== false)
+			if (strpos($value = $config[$name], '$') !== false)
 			{
-				$config[$name] = $value = strtr($value,array(
+				$config[$name] = $value = strtr($value, array(
 					'$suffix' => $config['ldap_suffix'],
 					'$base' => $config['ldap_base'],
 					'$admin_pw' => $config['ldap_admin_pw'],
@@ -313,7 +310,7 @@ 
 			}
 			$setup_ldap .= ' '.escapeshellarg($name.'='.$value);
 
-			if (!in_array($name,array('domain','ldap_suffix','ldap_admin','ldap_admin_pw')))
+			if (!in_array($name, array('domain', 'ldap_suffix', 'ldap_admin', 'ldap_admin_pw')))
 			{
 				$extra_config .= ' '.escapeshellarg($name.'='.$value);
 			}
@@ -346,7 +343,7 @@ 
 	}
 	// create mailserver config (fmail requires at least minimal config given as default, otherwise fatal error)
 	$setup_mailserver = $setup_cli.' --config '.escapeshellarg($config['domain'].','.$config['config_user'].','.$config['config_passwd']);
-	foreach(array('account-auth','smtpserver','smtp','postfix','mailserver','imap','cyrus','sieve','folder') as $name)
+	foreach (array('account-auth', 'smtpserver', 'smtp', 'postfix', 'mailserver', 'imap', 'cyrus', 'sieve', 'folder') as $name)
 	{
 		if (!empty($config[$name])) $setup_mailserver .= ' --'.$name.' '.escapeshellarg($config[$name]);
 	}
@@ -360,7 +357,7 @@ 
 	// check if webserver is started and start it (permanent) if not
 	if ($config['start_webserver'])
 	{
-		exec(build_cmd('start_webserver', 'status'),$dummy,$ret);
+		exec(build_cmd('start_webserver', 'status'), $dummy, $ret);
 		if ($ret)
 		{
 			system(build_cmd('start_webserver', 'start'));
@@ -399,7 +396,7 @@ 
 	// --> existing install --> update
 
 	// get user from header and replace password, as we dont know it
-	$old_password = patch_header($config['header'],$config['config_user'],$config['config_passwd']);
+	$old_password = patch_header($config['header'], $config['config_user'], $config['config_passwd']);
 	// register a shutdown function to put old password back in any case
 	register_shutdown_function(function() use (&$config, $old_password)
 	{
@@ -408,18 +405,18 @@ 
 
 	// update egroupware
 	$setup_update = $setup_cli.' --update '.escapeshellarg('all,'.$config['config_user'].','.$config['config_passwd'].',,'.$config['install-update-app']);
-	$ret = run_cmd($setup_update,$output,array(4,15));
+	$ret = run_cmd($setup_update, $output, array(4, 15));
 
-	switch($ret)
+	switch ($ret)
 	{
 		case 4:		// header needs an update
 			$header_update = $setup_cli.' --update-header '.escapeshellarg($config['config_passwd'].','.$config['config_user']);
 			run_cmd($header_update);
-			$ret = run_cmd($setup_update,$output,15);
+			$ret = run_cmd($setup_update, $output, 15);
 			if ($ret != 15) break;
 			// fall through
 		case 15:	// missing configuration (eg. mailserver)
-			if (!$verbose) echo implode("\n",(array)$output)."\n";
+			if (!$verbose) echo implode("\n", (array)$output)."\n";
 			break;
 
 		case 0:
@@ -462,18 +459,18 @@ 
  * @param string $password new password
  * @return string old password
  */
-function patch_header($filename,&$user,$password)
+function patch_header($filename, &$user, $password)
 {
 	$header = file_get_contents($filename);
 
 	$umatches = $pmatches = null;
-	if (!preg_match('/'.preg_quote("\$GLOBALS['egw_info']['server']['header_admin_user'] = '", '/')."([^']+)';/m",$header,$umatches) ||
-		!preg_match('/'.preg_quote("\$GLOBALS['egw_info']['server']['header_admin_password'] = '", '/')."([^']*)';/m",$header,$pmatches))
+	if (!preg_match('/'.preg_quote("\$GLOBALS['egw_info']['server']['header_admin_user'] = '", '/')."([^']+)';/m", $header, $umatches) ||
+		!preg_match('/'.preg_quote("\$GLOBALS['egw_info']['server']['header_admin_password'] = '", '/')."([^']*)';/m", $header, $pmatches))
 	{
-		bail_out(99,"$filename is no regular EGroupware header.inc.php!");
+		bail_out(99, "$filename is no regular EGroupware header.inc.php!");
 	}
-	file_put_contents($filename,preg_replace('/'.preg_quote("\$GLOBALS['egw_info']['server']['header_admin_password'] = '", '/')."([^']*)';/m",
-		"\$GLOBALS['egw_info']['server']['header_admin_password'] = '".$password."';",$header));
+	file_put_contents($filename, preg_replace('/'.preg_quote("\$GLOBALS['egw_info']['server']['header_admin_password'] = '", '/')."([^']*)';/m",
+		"\$GLOBALS['egw_info']['server']['header_admin_password'] = '".$password."';", $header));
 
 	$user = $umatches[1];
 
@@ -488,7 +485,7 @@ 
  * @param int|array|true $no_bailout =null exit code(s) to NOT bail out, or true to never bail out
  * @return int exit code of $cmd
  */
-function run_cmd($cmd,array &$output=null,$no_bailout=null)
+function run_cmd($cmd, array &$output = null, $no_bailout = null)
 {
 	global $verbose;
 
@@ -496,16 +493,16 @@ 
 	{
 		echo $cmd."\n";
 		$ret = null;
-		system($cmd,$ret);
+		system($cmd, $ret);
 	}
 	else
 	{
 		$output[] = $cmd;
-		exec($cmd,$output,$ret);
+		exec($cmd, $output, $ret);
 	}
-	if ($ret && $no_bailout !== true && !in_array($ret,(array)$no_bailout))
+	if ($ret && $no_bailout !== true && !in_array($ret, (array)$no_bailout))
 	{
-		bail_out($ret,$verbose?null:$output);
+		bail_out($ret, $verbose ? null : $output);
 	}
 	return $ret;
 }
@@ -516,9 +513,9 @@ 
  * @param int $ret =1
  * @param array|string $output line(s) to output before temination notice
  */
-function bail_out($ret=1,$output=null)
+function bail_out($ret = 1, $output = null)
 {
-	if ($output) echo implode("\n",(array)$output);
+	if ($output) echo implode("\n", (array)$output);
 	echo "\n\nInstallation failed --> exiting!\n\n";
 	exit($ret);
 }
@@ -529,21 +526,21 @@ 
  * @param int $len =16
  * @return string
  */
-function randomstring($len=16)
+function randomstring($len = 16)
 {
 	static $usedchars = array(
-		'0','1','2','3','4','5','6','7','8','9','a','b','c','d','e','f',
-		'g','h','i','j','k','l','m','n','o','p','q','r','s','t','u','v',
-		'w','x','y','z','A','B','C','D','E','F','G','H','I','J','K','L',
-		'M','N','O','P','Q','R','S','T','U','V','W','X','Y','Z',
-		'@','!','%','&','(',')','=','?',';',':','#','_','-','<',
-		'>','|','[',']','}',	// dont add /\,'"{ as we have problems dealing with them
+		'0', '1', '2', '3', '4', '5', '6', '7', '8', '9', 'a', 'b', 'c', 'd', 'e', 'f',
+		'g', 'h', 'i', 'j', 'k', 'l', 'm', 'n', 'o', 'p', 'q', 'r', 's', 't', 'u', 'v',
+		'w', 'x', 'y', 'z', 'A', 'B', 'C', 'D', 'E', 'F', 'G', 'H', 'I', 'J', 'K', 'L',
+		'M', 'N', 'O', 'P', 'Q', 'R', 'S', 'T', 'U', 'V', 'W', 'X', 'Y', 'Z',
+		'@', '!', '%', '&', '(', ')', '=', '?', ';', ':', '#', '_', '-', '<',
+		'>', '|', '[', ']', '}', // dont add /\,'"{ as we have problems dealing with them
 	);
 
 	$str = '';
-	for($i=0; $i < $len; $i++)
+	for ($i = 0; $i < $len; $i++)
 	{
-		$str .= $usedchars[mt_rand(0,count($usedchars)-1)];
+		$str .= $usedchars[mt_rand(0, count($usedchars) - 1)];
 	}
 	return $str;
 }
@@ -553,20 +550,20 @@ 
  *
  * @param string $error =null optional error-message
  */
-function usage($error=null)
+function usage($error = null)
 {
-	global $prog,$config;
+	global $prog, $config;
 
 	echo "Usage: $prog [-h|--help] [-v|--verbose] [--distro=(suse|rh|debian)] [options, ...]\n\n";
 	echo "options and their defaults:\n";
-	foreach($config as $name => $default)
+	foreach ($config as $name => $default)
 	{
-		if (in_array($name, array('postfix','cyrus'))) continue;	// do NOT report deprecated options
-		if (in_array($name,array('config_passwd','db_pass','admin_passwd','ldap_root_pw')) && strlen($config[$name]) == 16)
+		if (in_array($name, array('postfix', 'cyrus'))) continue; // do NOT report deprecated options
+		if (in_array($name, array('config_passwd', 'db_pass', 'admin_passwd', 'ldap_root_pw')) && strlen($config[$name]) == 16)
 		{
 			$default = '<16 char random string>';
 		}
-		echo '--'.str_pad($name,20).$default."\n";
+		echo '--'.str_pad($name, 20).$default."\n";
 	}
 	if ($error)
 	{
@@ -616,8 +613,8 @@ 
 	$config['distro'] = 'univention';
 
 	// set lang from ucr locale, as cloud-config at least never has anything but EN set in enviroment
-	@list($lang,$nat) = preg_split('/[_.]/', _ucr_get('locale/default'));
-	if (in_array($lang.'-'.strtolower($nat),array('es-es','pt-br','zh-tw')))
+	@list($lang, $nat) = preg_split('/[_.]/', _ucr_get('locale/default'));
+	if (in_array($lang.'-'.strtolower($nat), array('es-es', 'pt-br', 'zh-tw')))
 	{
 		$lang .= '-'.strtolower($nat);
 	}
@@ -642,7 +639,7 @@ 
 		// ldap password hash (our default blowfish_crypt seems not to work)
 		$config['ldap_encryption_type'] = 'sha512_crypt';
 
-		$config['account_min_id'] = 1200;	// UCS use 11xx for internal users/groups
+		$config['account_min_id'] = 1200; // UCS use 11xx for internal users/groups
 
 		$config['account-auth'] = 'univention,ldap';
 
@@ -652,7 +649,7 @@ 
 		// mailserver, see setup-cli.php --help config
 		if (($mailserver = exec('/usr/bin/univention-ldapsearch -x "(univentionAppID=mailserver_*)" univentionAppInstalledOnServer|sed -n "s/univentionAppInstalledOnServer: \(.*\)/\1/p"')) &&
 			// only set on host mailserver app is installed: _ucr_get('mail/cyrus/imap') == 'yes' &&
-			($domains=_ucr_get('mail/hosteddomains')))
+			($domains = _ucr_get('mail/hosteddomains')))
 		{
 			if (!is_array($domains)) $domains = explode("\n", $domains);
 			$domain = array_shift($domains);
@@ -692,12 +689,12 @@ 
  */
 function _ucr_get($name)
 {
-	static $values=null;
+	static $values = null;
 	if (!isset($values))
 	{
 		$output = $matches = null;
 		exec('/usr/sbin/ucr dump', $output);
-		foreach($output as $line)
+		foreach ($output as $line)
 		{
 			if (preg_match("/^([^:]+): (.*)\n?$/", $line, $matches))
 			{
@@ -773,7 +770,7 @@ 
  */
 function _size_with_unit($size)
 {
-	switch(strtoupper(substr($size, -1)))
+	switch (strtoupper(substr($size, -1)))
 	{
 		case 'G':
 			$size *= 1024;

calendar/inc/class.calendar_wizard_export_csv.inc.php

Spacing +1 added lines, -1 removed lines

@@ -47,7 +47,7 @@
                 );
 
 		$custom = Api\Storage\Customfields::get('resources', true);
-		foreach($custom as $name => $data) {
+		foreach ($custom as $name => $data) {
 			$this->mapping_fields['#'.$name] = $data['label'];
 		}
 

admin/inc/class.admin_wizard_export_groups_csv.inc.php

Spacing +1 added lines, -1 removed lines

@@ -47,7 +47,7 @@
                 );
 
 		$custom = Api\Storage\Customfields::get('resources', true);
-		foreach($custom as $name => $data) {
+		foreach ($custom as $name => $data) {
 			$this->mapping_fields['#'.$name] = $data['label'];
 		}
 

admin/inc/class.admin_wizard_export_users_csv.inc.php

Spacing +1 added lines, -1 removed lines

@@ -47,7 +47,7 @@
                 );
 
 		$custom = Api\Storage\Customfields::get('resources', true);
-		foreach($custom as $name => $data) {
+		foreach ($custom as $name => $data) {
 			$this->mapping_fields['#'.$name] = $data['label'];
 		}
 

timesheet/inc/class.timesheet_wizard_export_csv.inc.php

Spacing +1 added lines, -1 removed lines

@@ -47,7 +47,7 @@
                 );
 
 		$custom = Api\Storage\Customfields::get('resources', true);
-		foreach($custom as $name => $data) {
+		foreach ($custom as $name => $data) {
 			$this->mapping_fields['#'.$name] = $data['label'];
 		}
 

calendar/freebusy.php

Spacing +14 added lines, -14 removed lines

@@ -39,23 +39,23 @@ 
 	$GLOBALS['egw_info']['flags']['currentapp'] = 'calendar';
 }
 // fix for SOGo connector, which does not decode the = in our f/b url
-if (strpos($_SERVER['QUERY_STRING'],'=3D') !== false && substr($_GET['user'],0,2) == '3D')
+if (strpos($_SERVER['QUERY_STRING'], '=3D') !== false && substr($_GET['user'], 0, 2) == '3D')
 {
-	$_GET['user'] = substr($_GET['user'],2);
-	if (isset($_GET['password'])) $_GET['password'] = substr($_GET['password'],2);
-	if (isset($_GET['cred'])) $_GET['cred'] = substr($_GET['cred'],2);
+	$_GET['user'] = substr($_GET['user'], 2);
+	if (isset($_GET['password'])) $_GET['password'] = substr($_GET['password'], 2);
+	if (isset($_GET['cred'])) $_GET['cred'] = substr($_GET['cred'], 2);
 }
 if (!is_numeric($user = $_GET['user']))
 {
 	// check if user contains the current domain --> remove it
-	list(,$domain) = explode('@',$user);
+	list(,$domain) = explode('@', $user);
 	if ($domain === $GLOBALS['egw_info']['user']['domain'])
-	list($user) = explode('@',$user);
-	$user = $GLOBALS['egw']->accounts->name2id($user,'account_lid','u');
+	list($user) = explode('@', $user);
+	$user = $GLOBALS['egw']->accounts->name2id($user, 'account_lid', 'u');
 }
 if ($user === false || !($username = $GLOBALS['egw']->accounts->id2name($user)))
 {
-	fail_exit(lang("freebusy: Unknow user '%1', wrong password or not availible to not loged in users !!!"." $username($user)",$_GET['user']));
+	fail_exit(lang("freebusy: Unknow user '%1', wrong password or not availible to not loged in users !!!"." $username($user)", $_GET['user']));
 }
 if (!$loged_in)
 {
@@ -76,11 +76,11 @@ 
 		if (strpos($authuser, '@') === false)
 		{
 			$domain = $GLOBALS['egw_info']['server']['default_domain'];
-			$authuser .= '@' . $domain;
+			$authuser .= '@'.$domain;
 		}
 		else
 		{
-			list(, $domain) = explode('@',$authuser, 2);
+			list(, $domain) = explode('@', $authuser, 2);
 		}
 		if (array_key_exists($domain, $GLOBALS['egw_domain']))
 		{
@@ -90,8 +90,8 @@ 
 			$GLOBALS['egw_info']['user']['domain'] = $domain;
 			$GLOBALS['egw_info']['flags']['currentapp'] = 'login';
 			$GLOBALS['egw_info']['flags']['noapi'] = false;
-			require_once(EGW_API_INC . '/functions.inc.php');
-			$loged_in =  $GLOBALS['egw']->session->create($authuser, $password, 'text');
+			require_once(EGW_API_INC.'/functions.inc.php');
+			$loged_in = $GLOBALS['egw']->session->create($authuser, $password, 'text');
 			session_unset();
 			session_destroy();
 		}
@@ -107,6 +107,6 @@ 
 }
 else
 {
-	html::content_header('freebusy.ifb','text/calendar');
+	html::content_header('freebusy.ifb', 'text/calendar');
 }
-echo ExecMethod2('calendar.calendar_ical.freebusy',$user,$_GET['end']);
+echo ExecMethod2('calendar.calendar_ical.freebusy', $user, $_GET['end']);

calendar/egroupware.org/accept_holiday.php

Spacing +13 added lines, -13 removed lines

@@ -11,13 +11,13 @@ 
 
 die('This file is only used on http://www.egroupware.org/ and therefore disabled on local installations!');
 
-if(empty($_POST['locale']) || !preg_match('/^[A-Z]{2}$/',$_POST['locale']))
+if (empty($_POST['locale']) || !preg_match('/^[A-Z]{2}$/', $_POST['locale']))
 {
 	die('Missing or wrong value for required _POST[local]!');
 }
-$send_back_to = str_replace('submit','admin',$_SERVER['HTTP_REFERER']);
+$send_back_to = str_replace('submit', 'admin', $_SERVER['HTTP_REFERER']);
 
-function _holiday_cmp($a,$b)
+function _holiday_cmp($a, $b)
 {
 	if (($year_diff = ($a['occurence'] <= 0 ? 0 : $a['occurence']) - ($b['occurence'] <= 0 ? 0 : $b['occurence'])))
 	{
@@ -26,21 +26,21 @@ 
 	return $a['month'] - $b['month'] ? $a['month'] - $b['month'] : $a['day'] - $b['day'];
 }
 
-$send_back_to = str_replace('&locale='.$_POST['locale'],'',$send_back_to);
+$send_back_to = str_replace('&locale='.$_POST['locale'], '', $send_back_to);
 $file = './holidays.'.$_POST['locale'].'.csv';
-if(!file_exists($file) || filesize($file) < 300)	// treat very small files as not existent
+if (!file_exists($file) || filesize($file) < 300)	// treat very small files as not existent
 {
 	if (count($_POST['name']))
 	{
-		$fp = fopen($file,'w');
-		if ($_POST['charset']) fwrite($fp,"charset\t".$_POST['charset']."\n");
+		$fp = fopen($file, 'w');
+		if ($_POST['charset']) fwrite($fp, "charset\t".$_POST['charset']."\n");
 
 		$holidays = array();
-		foreach($_POST['name'] as $i => $name)
+		foreach ($_POST['name'] as $i => $name)
 		{
 			$holidays[] = array(
 				'locale' => $_POST['locale'],
-				'name'   => str_replace('\\','',$name),
+				'name'   => str_replace('\\', '', $name),
 				'day'    => $_POST['day'][$i],
 				'month'  => $_POST['month'][$i],
 				'occurence' => $_POST['occurence'][$i],
@@ -49,18 +49,18 @@ 
 			);
 		}
 		// sort holidays by year / occurence:
-		usort($holidays,'_holiday_cmp');
+		usort($holidays, '_holiday_cmp');
 
 		$last_year = -1;
-		foreach($holidays as $holiday)
+		foreach ($holidays as $holiday)
 		{
 			$year = $holiday['occurence'] <= 0 ? 0 : $holiday['occurence'];
 			if ($year != $last_year)
 			{
-				fwrite($fp,"\n".($year ? $year : 'regular (year=0)').":\n");
+				fwrite($fp, "\n".($year ? $year : 'regular (year=0)').":\n");
 				$last_year = $year;
 			}
-			fwrite($fp,"$holiday[locale]\t$holiday[name]\t$holiday[day]\t$holiday[month]\t$holiday[occurence]\t$holiday[dow]\t$holiday[observance_rule]\n");
+			fwrite($fp, "$holiday[locale]\t$holiday[name]\t$holiday[day]\t$holiday[month]\t$holiday[occurence]\t$holiday[dow]\t$holiday[observance_rule]\n");
 		}
 		fclose($fp);
 	}

calendar/sitemgr/class.module_calendar_month.inc.php

Spacing +34 added lines, -35 removed lines

@@ -51,7 +51,7 @@ 
 			'category' => array(
 				'type' => 'select',
 				'label' => lang('Choose a category'),
-				'options' => array(),	// specification of options is postponed into the get_user_interface function
+				'options' => array(), // specification of options is postponed into the get_user_interface function
 				'multiple' => true,
 			),
 			'numWeeks' => array(
@@ -103,8 +103,8 @@ 
 	function get_user_interface()
 	{
 		// copied from bookmarks module.
-		$cat = createobject('phpgwapi.categories','','calendar');
-		$cats = $cat->return_array('all',0,False,'','cat_name','',True);
+		$cat = createobject('phpgwapi.categories', '', 'calendar');
+		$cats = $cat->return_array('all', 0, False, '', 'cat_name', '', True);
 		$cat_ids = array();
 		while (list(,$category) = @each($cats))
 		{
@@ -115,12 +115,12 @@ 
 			$this->arguments['category']['multiple'] = 5;
 		}
 
-		if (! isset($GLOBALS['egw']->accounts))
+		if (!isset($GLOBALS['egw']->accounts))
 		{
 			$GLOBALS['egw']->accounts = new accounts();
 		}
-		$this->accounts =& $GLOBALS['egw']->accounts;
-		$search_params=array(
+		$this->accounts = & $GLOBALS['egw']->accounts;
+		$search_params = array(
 			'type' => 'both',
 			'app' => 'calendar',
 		);
@@ -130,7 +130,7 @@ 
 		// sort users and groups separately.
 		if (isset($GLOBALS['sitemgr_info']['anonymous_user']))
 		{
-			$anon_user = $this->accounts->name2id($GLOBALS['sitemgr_info']['anonymous_user'],'account_lid','u');
+			$anon_user = $this->accounts->name2id($GLOBALS['sitemgr_info']['anonymous_user'], 'account_lid', 'u');
 		}
 		else
 		{
@@ -139,7 +139,7 @@ 
 			 * Get possible sitemgr paths from the HTTP_REFERRER in order to unreveal the
 			 * anonymous user for the correct site.
 			 */
-			$sitemgr_path = preg_replace('/^[^\/]+:\/\/[^\/]+\/([^\?]*)(\?.*)*$/',"/\${1}",$_SERVER['HTTP_REFERER']);
+			$sitemgr_path = preg_replace('/^[^\/]+:\/\/[^\/]+\/([^\?]*)(\?.*)*$/', "/\${1}", $_SERVER['HTTP_REFERER']);
 			// Remove the trailing file- / pathname if any
 			$sitemgr_path = preg_replace('/[^\/]*$/', '', $sitemgr_path);
 			// Add leading slash if it has been lost.
@@ -151,17 +151,17 @@ 
 			// Code adapted from sitemgr-site/index.php
 			$site_urls = array();
 			$site_urls[] = $sitemgr_path;
-			$site_urls[] = ($_SERVER['HTTPS'] ? 'https://' : 'http://') . $_SERVER['SERVER_ADDR'] . $sitemgr_path;
-			$site_urls[] = $site_url = ($_SERVER['HTTPS'] ? 'https://' : 'http://') . $_SERVER['SERVER_NAME'] . $sitemgr_path;
+			$site_urls[] = ($_SERVER['HTTPS'] ? 'https://' : 'http://').$_SERVER['SERVER_ADDR'].$sitemgr_path;
+			$site_urls[] = $site_url = ($_SERVER['HTTPS'] ? 'https://' : 'http://').$_SERVER['SERVER_NAME'].$sitemgr_path;
 
-			$GLOBALS['egw']->db->select('egw_sitemgr_sites','anonymous_user,anonymous_passwd,site_id',
-				array('site_url' => $site_urls),__LINE__,__FILE__,false,'','sitemgr');
+			$GLOBALS['egw']->db->select('egw_sitemgr_sites', 'anonymous_user,anonymous_passwd,site_id',
+				array('site_url' => $site_urls), __LINE__, __FILE__, false, '', 'sitemgr');
 
 			$GLOBALS['egw']->db->next_record();
-			$anon_user = $this->accounts->name2id($GLOBALS['egw']->db->f('anonymous_user'),'account_lid','u');
+			$anon_user = $this->accounts->name2id($GLOBALS['egw']->db->f('anonymous_user'), 'account_lid', 'u');
 		}
 
-		$anon_groups = $this->accounts->memberships($anon_user,true);
+		$anon_groups = $this->accounts->memberships($anon_user, true);
 		foreach ($accounts as $entry)
 		{
 			$is_group = false;
@@ -169,9 +169,9 @@ 
 			$acl = new acl($entry['account_id']);
 			$acl->read_repository();
 			// get the rights for each account to check whether the anon user has read permissions.
-			$rights = $acl->get_rights($anon_user,'calendar');
+			$rights = $acl->get_rights($anon_user, 'calendar');
 			// also add the anon user if it's his own calendar.
-			if (($rights & EGW_ACL_READ) || ($entry['account_id'] == $anon_user))
+			if (($rights&EGW_ACL_READ) || ($entry['account_id'] == $anon_user))
 			{
 				$has_read_permissions = true;
 			}
@@ -181,8 +181,8 @@ 
 				// or ass permissions if this is the anon group's calendar.
 				foreach ($anon_groups as $parent_group)
 				{
-					$rights = $acl->get_rights($parent_group,'calendar');
-					if (($rights & EGW_ACL_READ) || ($entry['account_id'] == $parent_group))
+					$rights = $acl->get_rights($parent_group, 'calendar');
+					if (($rights&EGW_ACL_READ) || ($entry['account_id'] == $parent_group))
 					{
 						$has_read_permissions = true;
 						break;
@@ -198,7 +198,7 @@ 
 				}
 				else
 				{
-					$users[$entry['account_id']] = $GLOBALS['egw']->common->display_fullname($entry['account_lid'],$entry['account_firstname'],$entry['account_lastname']);
+					$users[$entry['account_id']] = $GLOBALS['egw']->common->display_fullname($entry['account_lid'], $entry['account_firstname'], $entry['account_lastname']);
 				}
 			}
 		}
@@ -218,7 +218,7 @@ 
 		return parent::get_user_interface();
 	}
 
-	function get_content(&$arguments,$properties)
+	function get_content(&$arguments, $properties)
 	{
 		$html = "";
 		$GLOBALS['egw']->translation->add_app('calendar');
@@ -226,34 +226,33 @@ 
 		$this->ui->allowEdit = false;
 		$this->ui->use_time_grid = isset($arguments['grid']) ? $arguments['grid'] : false;
 
-		$weeks = $arguments['numWeeks'] ? (int) $arguments['numWeeks'] : 2;
+		$weeks = $arguments['numWeeks'] ? (int)$arguments['numWeeks'] : 2;
 
-		if (($arguments['acceptDateParam']) && (get_var('date',array('POST','GET'))))
+		if (($arguments['acceptDateParam']) && (get_var('date', array('POST', 'GET'))))
 		{
-			$start = (int) (strtotime(get_var('date',array('POST','GET'))) +
+			$start = (int)(strtotime(get_var('date', array('POST', 'GET'))) +
 					(60 * 60 * 24 * 7 * $dateOffset));
 		}
 		else
 		{
-			$start = (int) ($this->bo->now_su +
+			$start = (int)($this->bo->now_su +
 					(60 * 60 * 24 * 7 * $dateOffset));
 		}
 		$first = $this->ui->datetime->get_weekday_start(
-					adodb_date('Y',$start),
-					adodb_date('m',$start),
-					adodb_date('d',$start));
-		$last = strtotime("+$weeks weeks",$first) - 1;
+					adodb_date('Y', $start),
+					adodb_date('m', $start),
+					adodb_date('d', $start));
+		$last = strtotime("+$weeks weeks", $first) - 1;
 
 		if ($arguments['showTitle'])
 		{
 			$html .= '<div id="divAppboxHeader">'.$GLOBALS['egw_info']['apps']['calendar']['title'].' - '.lang('Weekview').": ";
-			$html .= lang('After %1',$this->bo->long_date($first));
+			$html .= lang('After %1', $this->bo->long_date($first));
 			$html .= "</div>";
 		}
 
 		// set the search parameters
-		$search_params = Array
-		(
+		$search_params = Array(
 			'offset' => false,
 			'order' => 'cal_start ASC',
 			'start' => $first,
@@ -288,24 +287,24 @@ 
 		$html .= '<!-- END Calendar info -->'."\n";
 		unset($css_file);
 		// we add DAY_s/2 to $this->first (using 12h), to deal with daylight saving changes
-		for ($week_start = $first; $week_start < $last; $week_start = strtotime("+1 week",$week_start))
+		for ($week_start = $first; $week_start < $last; $week_start = strtotime("+1 week", $week_start))
 		{
 			$week = array();
 			for ($i = 0; $i < 7; ++$i)
 			{
-				$day_ymd = $this->bo->date2string($i ? strtotime("+$i days",$week_start) : $week_start);
+				$day_ymd = $this->bo->date2string($i ? strtotime("+$i days", $week_start) : $week_start);
 				$week[$day_ymd] = array_shift($rows);
 			}
 			$week_view = array(
 				'menuaction' => false,
 				'date' => $this->bo->date2string($week_start),
 			);
-			$title = lang('Wk').' '.adodb_date('W',$week_start);
+			$title = lang('Wk').' '.adodb_date('W', $week_start);
 			if (!isset($GLOBALS['egw']->template))
 			{
 				$GLOBALS['egw']->template = new Template;
 			}
-			$html .= $this->ui->timeGridWidget($this->ui->tagWholeDayOnTop($week),$weeks == 2 ? 30 : 60,200,'',$title,0,$week_start+WEEK_s >= $last);
+			$html .= $this->ui->timeGridWidget($this->ui->tagWholeDayOnTop($week), $weeks == 2 ? 30 : 60, 200, '', $title, 0, $week_start + WEEK_s >= $last);
 		}
 		// Initialize Tooltips
 		$html .= '<script language="JavaScript" type="text/javascript" src="'.$GLOBALS['egw_info']['server']['webserver_url'].'/phpgwapi/js/wz_tooltip/wz_tooltip.js"></script>'."\n";

calendar/sitemgr/class.module_calendar_list.inc.php

Spacing +37 added lines, -38 removed lines

@@ -88,7 +88,7 @@ 
 			'category' => array(
 				'type' => 'select',
 				'label' => lang('Choose a category'),
-				'options' => array(),	// specification of options is postponed into the get_user_interface function
+				'options' => array(), // specification of options is postponed into the get_user_interface function
 				'multiple' => true,
 			),
 			'numWeeks' => array(
@@ -154,8 +154,8 @@ 
 	{
 		//_debug_array($GLOBALS['Common_BO']->sites->current_site);
 		// copied from bookmarks module.
-		$cat = createobject('phpgwapi.categories','','calendar');
-		$cats = $cat->return_array('all',0,False,'','cat_name','',True);
+		$cat = createobject('phpgwapi.categories', '', 'calendar');
+		$cats = $cat->return_array('all', 0, False, '', 'cat_name', '', True);
 		$cat_ids = array();
 		while (list(,$category) = @each($cats))
 		{
@@ -170,7 +170,7 @@ 
 		{
 			$GLOBALS['egw']->accounts = new accounts();
 		}
-		$this->accounts =& $GLOBALS['egw']->accounts;
+		$this->accounts = & $GLOBALS['egw']->accounts;
 		$search_params = array(
 			'type' => 'both',
 			'app' => 'calendar',
@@ -179,8 +179,8 @@ 
 		$users = array();
 		$groups = array();
 		// sort users and groups separately.
-		$anon_user = $this->accounts->name2id($GLOBALS['Common_BO']->sites->current_site['anonymous_user'],'account_lid','u');
-		$anon_groups = $this->accounts->memberships($anon_user,true);
+		$anon_user = $this->accounts->name2id($GLOBALS['Common_BO']->sites->current_site['anonymous_user'], 'account_lid', 'u');
+		$anon_groups = $this->accounts->memberships($anon_user, true);
 		foreach ($accounts as $entry)
 		{
 			$is_group = false;
@@ -188,9 +188,9 @@ 
 			$acl = new acl($entry['account_id']);
 			$acl->read_repository();
 			// get the rights for each account to check whether the anon user has read permissions.
-			$rights = $acl->get_rights($anon_user,'calendar');
+			$rights = $acl->get_rights($anon_user, 'calendar');
 			// also add the anon user if it's his own calendar.
-			if (($rights & EGW_ACL_READ) || ($entry['account_id'] == $anon_user))
+			if (($rights&EGW_ACL_READ) || ($entry['account_id'] == $anon_user))
 			{
 				$has_read_permissions = true;
 			}
@@ -200,8 +200,8 @@ 
 				// or ass permissions if this is the anon group's calendar.
 				foreach ($anon_groups as $parent_group)
 				{
-					$rights = $acl->get_rights($parent_group,'calendar');
-					if (($rights & EGW_ACL_READ) || ($entry['account_id'] == $parent_group))
+					$rights = $acl->get_rights($parent_group, 'calendar');
+					if (($rights&EGW_ACL_READ) || ($entry['account_id'] == $parent_group))
 					{
 						$has_read_permissions = true;
 						break;
@@ -217,7 +217,7 @@ 
 				}
 				else
 				{
-					$users[$entry['account_id']] = $GLOBALS['egw']->common->display_fullname($entry['account_lid'],$entry['account_firstname'],$entry['account_lastname']);
+					$users[$entry['account_id']] = $GLOBALS['egw']->common->display_fullname($entry['account_lid'], $entry['account_firstname'], $entry['account_lastname']);
 				}
 			}
 		}
@@ -237,7 +237,7 @@ 
 		return parent::get_user_interface();
 	}
 
-	function get_content(&$arguments,$properties)
+	function get_content(&$arguments, $properties)
 	{
 		$html = "";
 		$GLOBALS['egw']->translation->add_app('calendar');
@@ -246,41 +246,40 @@ 
 		$this->ui->allowEdit = false;
 		$this->ui->use_time_grid = isset($arguments['grid']) ? $arguments['grid'] : false;
 
-		$weeks = $arguments['numWeeks'] ? (int) $arguments['numWeeks'] : 4;
-		$dateOffset = $arguments['offset'] ? (int) $arguments['offset'] : 0;
+		$weeks = $arguments['numWeeks'] ? (int)$arguments['numWeeks'] : 4;
+		$dateOffset = $arguments['offset'] ? (int)$arguments['offset'] : 0;
 
-		if (($arguments['acceptDateParam']) && (get_var('date',array('POST','GET'))))
+		if (($arguments['acceptDateParam']) && (get_var('date', array('POST', 'GET'))))
 		{
-			$first = $start = (int) (strtotime(get_var('date',array('POST','GET'))) +
+			$first = $start = (int)(strtotime(get_var('date', array('POST', 'GET'))) +
 					(60 * 60 * 24 * 7 * $dateOffset));
 		}
 		else
 		{
-			$first = $start = (int) ($this->bo->now_su +
+			$first = $start = (int)($this->bo->now_su +
 					(60 * 60 * 24 * 7 * $dateOffset));
 		}
 		if ($arguments['useWeekStart']) 
 		{
 			$first = $this->ui->datetime->get_weekday_start(
-				adodb_date('Y',$start),
-				adodb_date('m',$start),
-				adodb_date('d',$start));
+				adodb_date('Y', $start),
+				adodb_date('m', $start),
+				adodb_date('d', $start));
 		}
 
-		$last = (int) ($first +
+		$last = (int)($first +
 				(60 * 60 * 24 * 7 * $weeks));
 
 		if ($arguments['showTitle'])
 		{
 			$html .= '<div id="divAppboxHeader">'.$GLOBALS['egw_info']['apps']['calendar']['title'].' - ';
-			$html .= lang('After %1',$this->bo->long_date($first));
+			$html .= lang('After %1', $this->bo->long_date($first));
 			$html .= "</div>";
 		}
 
 		// set the search parameters
-		$search_params = Array
-		(
-			'offset' => $arguments['entryOffset'] ? (int) $arguments['entryOffset'] : false,
+		$search_params = Array(
+			'offset' => $arguments['entryOffset'] ? (int)$arguments['entryOffset'] : false,
 			'order' => 'cal_start ASC',
 			'start' => $first,
 			'end' => $last,
@@ -300,23 +299,23 @@ 
 		}
 		if ($arguments['numEntries'])
 		{
-			$search_params['num_rows'] = (int) $arguments['numEntries'];
-			$search_params['offset'] =  $arguments['entryOffset'] ? (int) $arguments['entryOffset'] :0;
+			$search_params['num_rows'] = (int)$arguments['numEntries'];
+			$search_params['offset'] = $arguments['entryOffset'] ? (int)$arguments['entryOffset'] : 0;
 		}
 		$rows = array();
 
-		foreach((array) $this->bo->search($search_params) as $event)
+		foreach ((array)$this->bo->search($search_params) as $event)
 		{
 			$event['date'] = $this->bo->date2string($event['start']);
-			if (empty($event['description'])) $event['description'] = ' ';	// no description screws the titles horz. alignment
-			if (empty($event['location'])) $event['location'] = ' ';	// no location screws the owner horz. alignment
+			if (empty($event['description'])) $event['description'] = ' '; // no description screws the titles horz. alignment
+			if (empty($event['location'])) $event['location'] = ' '; // no location screws the owner horz. alignment
 			$rows[] = $event;
 		}
 		if (($arguments['showWeeks']) && ((int)$arguments['offset'] == 0))
 		{
 			$html .= "<div>".lang('Next')." ".lang('%1 weeks', $weeks).":</div>\n";
 		}
-		if (($search_params['offset'] && $this->bo->total == 0) || count($rows)==0)
+		if (($search_params['offset'] && $this->bo->total == 0) || count($rows) == 0)
 		{
 			$html .= "<div>".lang("no events found")."</div>";
 		}
@@ -329,11 +328,11 @@ 
 			$html .= '  <div class="cal_list_weektop"></div>'."\n";
 			foreach ($rows as $event)
 			{
-				if (($last_week != 0) && (adodb_date('W-Y',$event['start']) != $last_week))
+				if (($last_week != 0) && (adodb_date('W-Y', $event['start']) != $last_week))
 				{
 					$html .= '  <div class="cal_list_weeksplit"></div>'."\n";
 				}
-				$last_week = adodb_date('W-Y',$event['start']);
+				$last_week = adodb_date('W-Y', $event['start']);
 				$html .= "  <!-- Event -->\n";
 				if ($event_count % 2 == 0) {
 					$html .= '  <div class="cal_list_event cal_event_even">'."\n";
@@ -345,17 +344,17 @@ 
 				$html .= '    <div class="cal_list_title">'.$event['title']."</div>\n";
 				$html .= '    <div class="cal_list_date">';
 				$html .= '<span class="cal_list_start">';
-				$html .= '<span class="cal_list_weekday">'.lang(adodb_date('D',$event['start'])).".".($this->bo->common_prefs['dateformat'][0] != 'd' ? ' ' : ', ')."</span>";
+				$html .= '<span class="cal_list_weekday">'.lang(adodb_date('D', $event['start'])).".".($this->bo->common_prefs['dateformat'][0] != 'd' ? ' ' : ', ')."</span>";
 				$html .= $this->bo->format_date($event['start'])."</span>";
 				$html .= '<span class="cal_list_end"> - ';
-				$html .= '<span class="cal_list_weekday">'.lang(adodb_date('D',$event['end'])).".".($this->bo->common_prefs['dateformat'][0] != 'd' ? ' ' : ', ')."</span>";
+				$html .= '<span class="cal_list_weekday">'.lang(adodb_date('D', $event['end'])).".".($this->bo->common_prefs['dateformat'][0] != 'd' ? ' ' : ', ')."</span>";
 				$html .= $this->bo->format_date($event['end'])."</span></div>\n";
 				$descr = trim($event['description']);
-				if (! empty($descr)) {
-					$html .= "    <div class=\"cal_list_descr\">\n".preg_replace('/\\n/',"<br>\n",$event['description'])."</div>\n";
+				if (!empty($descr)) {
+					$html .= "    <div class=\"cal_list_descr\">\n".preg_replace('/\\n/', "<br>\n", $event['description'])."</div>\n";
 				}
 				$html .= "  </div><!-- cal_list_event -->\n";
-				$event_count ++;
+				$event_count++;
 			}
 			$html .= '  <div class="cal_list_weekbottom"></div>'."\n";
 			$html .= "<!-- End module -->\n";