Completed
Push — 14.2 ( e07840...cec2da )
by Ralf
83:18 queued 52:04
created
resources/inc/class.resources_bo.inc.php 1 patch
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -69,7 +69,6 @@  discard block
 block discarded – undo
69 69
 	/**
70 70
 	 * Constructor
71 71
 	 *
72
-	 * @param int $user=null account_id of user to use for acl, default current user
73 72
 	 */
74 73
 	function __construct($user=null)
75 74
 	{
@@ -765,7 +764,7 @@  discard block
 block discarded – undo
765 764
 	 *
766 765
 	 * Cornelius Weiss <[email protected]>
767 766
 	 * @param array $file array with key => value
768
-	 * @param int $resource_id
767
+	 * @param int $resouce_id
769 768
 	 * @return mixed string with msg if somthing went wrong; nothing if all right
770 769
 	 */
771 770
 	function save_picture($file,$resouce_id)
Please login to merge, or discard this patch.
resources/inc/class.ui_acl.inc.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -119,6 +119,9 @@
 block discarded – undo
119 119
 		$template->pfp('out','acl',True);
120 120
 	}
121 121
 
122
+	/**
123
+	 * @param integer $right
124
+	 */
122 125
 	function selectlist($right,$users_only=false)
123 126
 	{
124 127
 		static $accountList;
Please login to merge, or discard this patch.
setup/check_install.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -313,6 +313,7 @@
 block discarded – undo
313 313
  * Check if given package is installed via composer in EGroupware's vendor directory
314 314
  *
315 315
  * @param string $package package-name in composer notation eg. "pear-pear.horde.org/Horde_Imap_Client" or "pear-pear.php.net/Net_Sieve"
316
+ * @return string
316 317
  */
317 318
 function composer_check($package)
318 319
 {
Please login to merge, or discard this patch.
setup/inc/class.setup.inc.php 1 patch
Doc Comments   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -793,9 +793,9 @@  discard block
 block discarded – undo
793 793
 
794 794
 	/**
795 795
 	 * egw version checking, is param 1 < param 2 in phpgw versionspeak?
796
-	 * @param	$a	phpgw version number to check if less than $b
797
-	 * @param	$b	phpgw version number to check $a against
798
-	 * @return	True if $a < $b
796
+	 * @param	string $a	phpgw version number to check if less than $b
797
+	 * @param	string $b	phpgw version number to check $a against
798
+	 * @return	boolean if $a < $b
799 799
 	 */
800 800
 	function alessthanb($a,$b,$DEBUG=False)
801 801
 	{
@@ -882,7 +882,7 @@  discard block
 block discarded – undo
882 882
 	 *
883 883
 	 * @param	$a	phpgw version number to check if more than $b
884 884
 	 * @param	$b	phpgw version number to check $a against
885
-	 * @return	True if $a < $b
885
+	 * @return	boolean if $a < $b
886 886
 	 */
887 887
 	function amorethanb($a,$b,$DEBUG=False)
888 888
 	{
@@ -1152,7 +1152,7 @@  discard block
 block discarded – undo
1152 1152
 	 *
1153 1153
 	 * Dont use it to set group-membership, use set_memberships instead!
1154 1154
 	 *
1155
-	 * @param string|array $apps app-names
1155
+	 * @param string $apps app-names
1156 1156
 	 * @param string $location eg. "run"
1157 1157
 	 * @param int|string $account accountid or account_lid
1158 1158
 	 * @param int $rights rights to set, default 1
@@ -1198,7 +1198,7 @@  discard block
 block discarded – undo
1198 1198
 	/**
1199 1199
 	 * checks if one of the given tables exist, returns the first match
1200 1200
 	 *
1201
-	 * @param array $tables array with possible table-names
1201
+	 * @param string[] $tables array with possible table-names
1202 1202
 	 * @return string/boolean tablename or false
1203 1203
 	 */
1204 1204
 	function table_exist($tables,$force_refresh=False)
Please login to merge, or discard this patch.
setup/inc/class.setup_cmd.inc.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
 	/**
86 86
 	 * Saving the object to the database, reimplemented to not do it in setup context
87 87
 	 *
88
-	 * @param boolean $set_modifier=true set the current user as modifier or 0 (= run by the system)
88
+	 * @param boolean $set_modifier set the current user as modifier or 0 (= run by the system)
89 89
 	 * @return boolean true on success, false otherwise
90 90
 	 */
91 91
 	function save($set_modifier=true)
@@ -172,7 +172,7 @@  discard block
 block discarded – undo
172 172
 	 *
173 173
 	 * @param string $user
174 174
 	 * @param string $pw
175
-	 * @param string $domain=null if given we also check agains config user/pw
175
+	 * @param string $domain if given we also check agains config user/pw
176 176
 	 * @throws egw_exception_no_permission(lang('Access denied: wrong username or password for manage-header !!!'),21);
177 177
 	 * @throws egw_exception_no_permission(lang("Access denied: wrong username or password to configure the domain '%1(%2)' !!!",$domain,$GLOBALS['egw_domain'][$domain]['db_type']),40);
178 178
 	 */
@@ -220,8 +220,8 @@  discard block
 block discarded – undo
220 220
 	 * Sets self::$apps_to_update and self::$apps_to_install for the last/only domain only!
221 221
 	 *
222 222
 	 * @param string $domain='' domain to check, default '' = all
223
-	 * @param int/array $stop=0 stop checks before given exit-code(s), default 0 = all checks
224
-	 * @param boolean $verbose=false echo messages as they happen, instead returning them
223
+	 * @param int/array $stop stop checks before given exit-code(s), default 0 = all checks
224
+	 * @param boolean $verbose echo messages as they happen, instead returning them
225 225
 	 * @return array with translated messages
226 226
 	 */
227 227
 	static function check_installed($domain='',$stop=0,$verbose=false)
Please login to merge, or discard this patch.
setup/inc/class.setup_cmd_admin.inc.php 1 patch
Doc Comments   +8 added lines, -10 removed lines patch added patch discarded remove patch
@@ -26,15 +26,13 @@  discard block
 block discarded – undo
26 26
 	 * Constructor
27 27
 	 *
28 28
 	 * @param string|array $domain domain-name or array with all parameters
29
-	 * @param string $config_user=null user to config the domain (or header_admin_user)
30
-	 * @param string $config_passwd=null pw of above user
31
-	 * @param string $admin_user=null
32
-	 * @param string $admin_password=null
33
-	 * @param string $admin_firstname=null
34
-	 * @param string $admin_lastname=null
35
-	 * @param string $admin_email=null
36
-	 * @param array $config=array() extra config for the account object: account_repository, ldap_*
37
-	 * @param string $lang='en'
29
+	 * @param string $config_user user to config the domain (or header_admin_user)
30
+	 * @param string $config_passwd pw of above user
31
+	 * @param string $admin_user
32
+	 * @param string $admin_password
33
+	 * @param string $admin_firstname
34
+	 * @param string $admin_lastname
35
+	 * @param string $admin_email
38 36
 	 */
39 37
 	function __construct($domain,$config_user=null,$config_passwd=null,$admin_user=null,$admin_password=null,
40 38
 		$admin_firstname=null,$admin_lastname=null,$admin_email=null,array $config=array(),$lang='en')
@@ -61,7 +59,7 @@  discard block
 block discarded – undo
61 59
 	/**
62 60
 	 * run the command: create eGW admin and standard groups
63 61
 	 *
64
-	 * @param boolean $check_only=false only run the checks (and throw the exceptions), but not the command itself
62
+	 * @param boolean $check_only only run the checks (and throw the exceptions), but not the command itself
65 63
 	 * @return string success message
66 64
 	 * @throws Exception(lang('Wrong credentials to access the header.inc.php file!'),2);
67 65
 	 * @throws Exception('header.inc.php not found!');
Please login to merge, or discard this patch.
setup/inc/class.setup_cmd_database.inc.php 1 patch
Doc Comments   +9 added lines, -15 removed lines patch added patch discarded remove patch
@@ -39,16 +39,14 @@  discard block
 block discarded – undo
39 39
 	 *
40 40
 	 * @param string/array $domain domain-name to customize the defaults or array with all parameters
41 41
 	 * @param string $db_type db-type (mysql, pgsql, ...)
42
-	 * @param string $db_host=null
43
-	 * @param string $db_port=null
44
-	 * @param string $db_name=null
45
-	 * @param string $db_user=null
46
-	 * @param string $db_pass=null
47
-	 * @param string $db_root=null
48
-	 * @param string $db_root_pw=null
49
-	 * @param string $sub_command='create_db' 'create_db', 'test_db', 'test_db_root'
50
-	 * @param string $db_grant_host='localhost' host/ip of webserver for grant
51
-	 * @param boolean $make_db_name_unique=false true: if create fails because db exists,
42
+	 * @param string $db_host
43
+	 * @param string $db_port
44
+	 * @param string $db_name
45
+	 * @param string $db_user
46
+	 * @param string $db_pass
47
+	 * @param string $db_root
48
+	 * @param string $db_root_pw
49
+	 * @param boolean $make_db_name_unique true: if create fails because db exists,
52 50
 	 * 	try creating a unique name by shortening the name and adding a number to it
53 51
 	 */
54 52
 	function __construct($domain,$db_type=null,$db_host=null,$db_port=null,$db_name=null,$db_user=null,$db_pass=null,
@@ -78,7 +76,7 @@  discard block
 block discarded – undo
78 76
 	/**
79 77
 	 * run the command: test or create database
80 78
 	 *
81
-	 * @param boolean $check_only=false only run the checks (and throw the exceptions), but not the command itself
79
+	 * @param boolean $check_only only run the checks (and throw the exceptions), but not the command itself
82 80
 	 * @return string success message
83 81
 	 * @throws Exception(lang('Wrong credentials to access the header.inc.php file!'),2);
84 82
 	 * @throws Exception('header.inc.php not found!');
@@ -127,9 +125,6 @@  discard block
 block discarded – undo
127 125
 	/**
128 126
 	 * Connect to database
129 127
 	 *
130
-	 * @param string $user=null default $this->db_user
131
-	 * @param string $pass=null default $this->db_pass
132
-	 * @param string $name=null default $this->db_name
133 128
 	 * @throws egw_exception_wrong_userinput Can not connect to database ...
134 129
 	 */
135 130
 	private function connect($user=null,$pass=null,$name=null)
@@ -267,7 +262,6 @@  discard block
 block discarded – undo
267 262
 	/**
268 263
 	 * Return default database settings for a given domain
269 264
 	 *
270
-	 * @param string $db_type='mysql'
271 265
 	 * @return array
272 266
 	 */
273 267
 	static function defaults($db_type='mysqli')
Please login to merge, or discard this patch.
setup/inc/class.setup_cmd_header.inc.php 1 patch
Doc Comments   +2 added lines, -3 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
 	 * Constructor
35 35
 	 *
36 36
 	 * @param string/array $sub_command='create' 'create','edit','delete'(-domain) or array with all arguments
37
-	 * @param array $arguments=null comand line arguments
37
+	 * @param array $arguments comand line arguments
38 38
 	 */
39 39
 	function __construct($sub_command='create',$arguments=null)
40 40
 	{
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
 	/**
67 67
 	 * Create or update header.inc.php
68 68
 	 *
69
-	 * @param boolean $check_only=false only run the checks (and throw the exceptions), but not the command itself
69
+	 * @param boolean $check_only only run the checks (and throw the exceptions), but not the command itself
70 70
 	 * @return string serialized $GLOBALS defined in the header.inc.php
71 71
 	 * @throws Exception(lang('Wrong credentials to access the header.inc.php file!'),2);
72 72
 	 * @throws Exception('header.inc.php not found!');
@@ -155,7 +155,6 @@  discard block
 block discarded – undo
155 155
 	 * Magic method to allow to call all methods from setup_header, as if they were our own
156 156
 	 *
157 157
 	 * @param string $method
158
-	 * @param array $args=null
159 158
 	 * @return mixed
160 159
 	 */
161 160
 	function __call($method,array $args=null)
Please login to merge, or discard this patch.
setup/inc/class.setup_cmd_hooks.inc.php 1 patch
Doc Comments   +3 added lines, -4 removed lines patch added patch discarded remove patch
@@ -19,9 +19,8 @@  discard block
 block discarded – undo
19 19
 	 * Constructor
20 20
 	 *
21 21
 	 * @param string $domain string with domain-name or array with all arguments
22
-	 * @param string $config_user=null user to config the domain (or header_admin_user)
23
-	 * @param string $config_passwd=null pw of above user
24
-	 * @param boolean $verbose=false if true, echos out some status information during the run
22
+	 * @param string $config_user user to config the domain (or header_admin_user)
23
+	 * @param string $config_passwd pw of above user
25 24
 	 */
26 25
 	function __construct($domain,$config_user=null,$config_passwd=null)
27 26
 	{
@@ -40,7 +39,7 @@  discard block
 block discarded – undo
40 39
 	/**
41 40
 	 * run the command: register all hooks
42 41
 	 *
43
-	 * @param boolean $check_only=false only run the checks (and throw the exceptions), but not the command itself
42
+	 * @param boolean $check_only only run the checks (and throw the exceptions), but not the command itself
44 43
 	 * @return string success message
45 44
 	 * @throws Exception(lang('Wrong credentials to access the header.inc.php file!'),2);
46 45
 	 * @throws Exception('header.inc.php not found!');
Please login to merge, or discard this patch.