Completed
Push — 14.2 ( e07840...cec2da )
by Ralf
83:18 queued 52:04
created
calendar/inc/class.calendar_rrule.inc.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -359,7 +359,7 @@
 block discarded – undo
359 359
 	/**
360 360
 	 * Return the current element
361 361
 	 *
362
-	 * @return DateTime
362
+	 * @return string
363 363
 	 */
364 364
 	public function current()
365 365
 	{
Please login to merge, or discard this patch.
calendar/inc/class.calendar_sif.inc.php 1 patch
Doc Comments   +2 added lines, -6 removed lines patch added patch discarded remove patch
@@ -409,11 +409,7 @@  discard block
 block discarded – undo
409 409
 	/**
410 410
 	* @return int event id
411 411
 	* @param string	$_sifdata   the SIFE data
412
-	* @param int	$_calID=-1	the internal addressbook id
413
-	* @param boolean $merge=false	merge data with existing entry
414
-	* @param int $recur_date=0 if set, import the recurrence at this timestamp,
415
-	*                          default 0 => import whole series (or events, if not recurring)
416
-	* @desc import a SIFE into the calendar
412
+	* @param int	$_calID	the internal addressbook id
417 413
 	*/
418 414
 	function addSIF($_sifdata, $_calID=-1, $merge=false, $recur_date=0)
419 415
 	{
@@ -797,7 +793,7 @@  discard block
 block discarded – undo
797 793
 	* return a sife
798 794
 	*
799 795
 	* @param int	$_id		the id of the event
800
-	* @param int $recur_date=0	if set export the next recurrence at or after the timestamp,
796
+	* @param int $recur_date	if set export the next recurrence at or after the timestamp,
801 797
 	*                          	default 0 => export whole series (or events, if not recurring)
802 798
 	* @return string containing the SIFE
803 799
 	*/
Please login to merge, or discard this patch.
calendar/inc/class.calendar_so.inc.php 1 patch
Doc Comments   +15 added lines, -39 removed lines patch added patch discarded remove patch
@@ -207,23 +207,11 @@  discard block
 block discarded – undo
207 207
 	 * @param int $start startdate of the search/list (servertime)
208 208
 	 * @param int $end enddate of the search/list (servertime)
209 209
 	 * @param int|array $users user-id or array of user-id's, !$users means all entries regardless of users
210
-	 * @param int|array $cat_id =0 mixed category-id or array of cat-id's (incl. all sub-categories), default 0 = all
210
+	 * @param integer $cat_id =0 mixed category-id or array of cat-id's (incl. all sub-categories), default 0 = all
211 211
 	 * @param string $filter ='default' string filter-name: all (not rejected), accepted, unknown, tentative, rejected or everything (incl. rejected, deleted)
212 212
 	 * @param int|boolean $offset =False offset for a limited query or False (default)
213 213
 	 * @param int $num_rows =0 number of rows to return if offset set, default 0 = use default in user prefs
214 214
 	 * @param array $params =array()
215
-	 * @param string|array $params['query'] string: pattern so search for, if unset or empty all matching entries are returned (no search)
216
-	 *		Please Note: a search never returns repeating events more then once AND does not honor start+end date !!!
217
-	 *      array: everything is directly used as $where
218
-	 * @param string $params['order'] ='cal_start' column-names plus optional DESC|ASC separted by comma
219
-	 * @param string $params['sql_filter'] sql to be and'ed into query (fully quoted)
220
-	 * @param string|array $params['cols'] what to select, default "$this->repeats_table.*,$this->cal_table.*,cal_start,cal_end,cal_recur_date",
221
-	 * 						if specified and not false an iterator for the rows is returned
222
-	 * @param string $params['append'] SQL to append to the query before $order, eg. for a GROUP BY clause
223
-	 * @param array $params['cfs'] custom fields to query, null = none, array() = all, or array with cfs names
224
-	 * @param array $params['users'] raw parameter as passed to calendar_bo::search() no memberships resolved!
225
-	 * @param boolean $params['master_only'] =false, true only take into account participants/status from master (for AS)
226
-	 * @param boolean $params['enum_recuring'] =true enumerate recuring events
227 215
 	 * @param int $remove_rejected_by_user =null add join to remove entry, if given user has rejected it
228 216
 	 * @return array of events
229 217
 	 */
@@ -357,7 +345,7 @@  discard block
 block discarded – undo
357 345
 	/**
358 346
 	 * Get full event information from an iterator of a select on egw_cal
359 347
 	 *
360
-	 * @param array|Iterator $rs
348
+	 * @param ADORecordSet $rs
361 349
 	 * @param int $recur_date =0
362 350
 	 * @return array
363 351
 	 */
@@ -571,7 +559,7 @@  discard block
 block discarded – undo
571 559
 	 *
572 560
 	 * @param array $query filter, keys have to use 'cal_' prefix
573 561
 	 * @param string|array $cols ='cal_id,cal_reference,cal_etag,cal_modified,cal_user_modified' cols to query
574
-	 * @return Iterator as egw_db::select
562
+	 * @return ADORecordSet as egw_db::select
575 563
 	 */
576 564
 	function get_cal_data(array $query, $cols='cal_id,cal_reference,cal_etag,cal_modified,cal_user_modified')
577 565
 	{
@@ -590,7 +578,7 @@  discard block
 block discarded – undo
590 578
 	/**
591 579
 	 * generate SQL to filter after a given category (incl. subcategories)
592 580
 	 *
593
-	 * @param array|int $cat_id cat-id or array of cat-ids, or !$cat_id for none
581
+	 * @param integer $cat_id cat-id or array of cat-ids, or !$cat_id for none
594 582
 	 * @return string SQL to include in the query
595 583
 	 */
596 584
 	function cat_filter($cat_id)
@@ -678,24 +666,11 @@  discard block
 block discarded – undo
678 666
 	 * @param int $start startdate of the search/list (servertime)
679 667
 	 * @param int $end enddate of the search/list (servertime)
680 668
 	 * @param int|array $users user-id or array of user-id's, !$users means all entries regardless of users
681
-	 * @param int|array $cat_id =0 mixed category-id or array of cat-id's (incl. all sub-categories), default 0 = all
669
+	 * @param integer $cat_id =0 mixed category-id or array of cat-id's (incl. all sub-categories), default 0 = all
682 670
 	 * @param string $filter ='all' string filter-name: all (not rejected), accepted, unknown, tentative, rejected or everything (incl. rejected, deleted)
683 671
 	 * @param int|boolean $offset =False offset for a limited query or False (default)
684 672
 	 * @param int $num_rows =0 number of rows to return if offset set, default 0 = use default in user prefs
685 673
 	 * @param array $params =array()
686
-	 * @param string|array $params['query'] string: pattern so search for, if unset or empty all matching entries are returned (no search)
687
-	 *		Please Note: a search never returns repeating events more then once AND does not honor start+end date !!!
688
-	 *      array: everything is directly used as $where
689
-	 * @param string $params['order'] ='cal_start' column-names plus optional DESC|ASC separted by comma
690
-	 * @param string|array $params['sql_filter'] sql to be and'ed into query (fully quoted), or usual filter array
691
-	 * @param string|array $params['cols'] what to select, default "$this->repeats_table.*,$this->cal_table.*,cal_start,cal_end,cal_recur_date",
692
-	 * 						if specified and not false an iterator for the rows is returned
693
-	 * @param string $params['append'] SQL to append to the query before $order, eg. for a GROUP BY clause
694
-	 * @param array $params['cfs'] custom fields to query, null = none, array() = all, or array with cfs names
695
-	 * @param array $params['users'] raw parameter as passed to calendar_bo::search() no memberships resolved!
696
-	 * @param boolean $params['master_only'] =false, true only take into account participants/status from master (for AS)
697
-	 * @param boolean $params['enum_recuring'] =true enumerate recuring events
698
-	 * @param boolean $params['use_so_events'] =false, true return result of new $this->events()
699 674
 	 * @param int $remove_rejected_by_user =null add join to remove entry, if given user has rejected it
700 675
 	 * @return Iterator|array of events
701 676
 	 */
@@ -1136,11 +1111,11 @@  discard block
 block discarded – undo
1136 1111
 	 * Ask other apps if they want to participate in calendar search / display
1137 1112
 	 *
1138 1113
 	 * @param &$selects parts of union query
1139
-	 * @param $start see search()
1140
-	 * @param $end
1114
+	 * @param integer $start see search()
1115
+	 * @param integer $end
1141 1116
 	 * @param $users as used in calendar_so ($users_raw plus all members and memberships added by calendar_bo)
1142
-	 * @param $cat_id
1143
-	 * @param $filter
1117
+	 * @param integer $cat_id
1118
+	 * @param string $filter
1144 1119
 	 * @param $query
1145 1120
 	 * @param $users_raw as passed to calendar_bo::search (no members and memberships added)
1146 1121
 	 */
@@ -1308,6 +1283,7 @@  discard block
 block discarded – undo
1308 1283
 	 * @param int &$set_recurrences_start=0 on return: time from which on the recurrences should be rebuilt, default 0=all
1309 1284
 	 * @param int $change_since =0 time from which on the repetitions should be changed, default 0=all
1310 1285
 	 * @param int &$etag etag=null etag to check or null, on return new etag
1286
+	 * @param boolean $set_recurrences
1311 1287
 	 * @return boolean|int false on error, 0 if etag does not match, cal_id otherwise
1312 1288
 	 */
1313 1289
 	function save($event,&$set_recurrences,&$set_recurrences_start=0,$change_since=0,&$etag=null)
@@ -1718,7 +1694,7 @@  discard block
 block discarded – undo
1718 1694
 	 * @param int $cal_id
1719 1695
 	 * @param int $start new starttime
1720 1696
 	 * @param int $end new endtime
1721
-	 * @param int|boolean $change_since =0 false=new entry, > 0 time from which on the repetitions should be changed, default 0=all
1697
+	 * @param integer $change_since =0 false=new entry, > 0 time from which on the repetitions should be changed, default 0=all
1722 1698
 	 * @param int $old_start =0 old starttime or (default) 0, to query it from the db
1723 1699
 	 * @param int $old_end =0 old starttime or (default) 0
1724 1700
 	 * @todo Recalculate recurrences, if timezone changes
@@ -1895,12 +1871,12 @@  discard block
 block discarded – undo
1895 1871
 	 *
1896 1872
 	 * @param int $cal_id
1897 1873
 	 * @param array $participants uid => status pairs
1898
-	 * @param int|boolean $change_since =0, false=new event,
1874
+	 * @param integer $change_since =0, false=new event,
1899 1875
 	 * 		0=all, > 0 time from which on the repetitions should be changed
1900 1876
 	 * @param boolean $add_only =false
1901 1877
 	 *		false = add AND delete participants if needed (full list of participants required in $participants)
1902 1878
 	 *		true = only add participants if needed, no participant will be deleted (participants to check/add required in $participants)
1903
-	 * @return int|boolean number of updated recurrences or false on error
1879
+	 * @return boolean number of updated recurrences or false on error
1904 1880
 	 */
1905 1881
 	function participants($cal_id,$participants,$change_since=0,$add_only=false)
1906 1882
 	{
@@ -2041,7 +2017,7 @@  discard block
 block discarded – undo
2041 2017
 	 * set the status of one participant for a given recurrence or for all recurrences since now (includes recur_date=0)
2042 2018
 	 *
2043 2019
 	 * @param int $cal_id
2044
-	 * @param char $user_type 'u' regular user, 'r' resource, 'c' contact
2020
+	 * @param string $user_type 'u' regular user, 'r' resource, 'c' contact
2045 2021
 	 * @param int|string $user_id
2046 2022
 	 * @param int|char $status numeric status (defines) or 1-char code: 'R', 'U', 'T' or 'A'
2047 2023
 	 * @param int $recur_date =0 date to change, or 0 = all since now
@@ -2958,7 +2934,7 @@  discard block
 block discarded – undo
2958 2934
 	 * Updates the modification timestamp to force an etag, ctag and sync-token change
2959 2935
 	 *
2960 2936
 	 * @param int $id event id
2961
-	 * @param int|boolean $update_master =false id of series master or true, to update series master too
2937
+	 * @param boolean $update_master =false id of series master or true, to update series master too
2962 2938
 	 * @param int $time =null new timestamp, default current (server-)time
2963 2939
 	 * @param int $modifier =null uid of the modifier, default current user
2964 2940
 	 */
Please login to merge, or discard this patch.
calendar/inc/class.calendar_ui.inc.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -521,6 +521,9 @@
 block discarded – undo
521 521
 	/**
522 522
 	* Create a select-box item in the sidebox-menu
523 523
 	* @privat used only by sidebox_menu !
524
+	* @param string $title
525
+	* @param string $name
526
+	* @param string $options
524 527
 	*/
525 528
 	function _select_box($title,$name,$options,$width='99%')
526 529
 	{
Please login to merge, or discard this patch.
calendar/inc/class.calendar_uiforms.inc.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -2202,7 +2202,7 @@  discard block
 block discarded – undo
2202 2202
 	 * Freetime search
2203 2203
 	 *
2204 2204
 	 * As the function is called in a popup via javascript, parametes get initialy transfered via the url
2205
-	 * @param array $content=null array with parameters or false (default) to use the get-params
2205
+	 * @param array $content array with parameters or false (default) to use the get-params
2206 2206
 	 * @param string start[str] start-date
2207 2207
 	 * @param string start[hour] start-hour
2208 2208
 	 * @param string start[min] start-minutes
@@ -2446,7 +2446,7 @@  discard block
 block discarded – undo
2446 2446
 	/**
2447 2447
 	 * Export events as vCalendar version 2.0 files (iCal)
2448 2448
 	 *
2449
-	 * @param int|array $content numeric cal_id or submitted content from etempalte::exec
2449
+	 * @param integer $content numeric cal_id or submitted content from etempalte::exec
2450 2450
 	 * @param boolean $return_error should an error-msg be returned or a regular page with it generated (default)
2451 2451
 	 * @return string error-msg if $return_error
2452 2452
 	 */
@@ -2683,12 +2683,12 @@  discard block
 block discarded – undo
2683 2683
 	/**
2684 2684
 	 * moves an event to another date/time
2685 2685
 	 *
2686
-	 * @param string $eventId id of the event which has to be moved
2686
+	 * @param string $_eventId id of the event which has to be moved
2687 2687
 	 * @param string $calendarOwner the owner of the calendar the event is in
2688 2688
 	 * @param string $targetDateTime the datetime where the event should be moved to, format: YYYYMMDD
2689 2689
 	 * @param string $targetOwner the owner of the target calendar
2690 2690
 	 * @param string $durationT the duration to support resizable calendar event
2691
-	 * @return string XML response if no error occurs
2691
+	 * @return false|null XML response if no error occurs
2692 2692
 	 */
2693 2693
 	function ajax_moveEvent($_eventId,$calendarOwner,$targetDateTime,$targetOwner,$durationT=null)
2694 2694
 	{
Please login to merge, or discard this patch.
calendar/inc/class.calendar_uilist.inc.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
 	/**
49 49
 	 * Constructor
50 50
 	 *
51
-	 * @param array $set_states=null to manualy set / change one of the states, default NULL = use $_REQUEST
51
+	 * @param array $set_states to manualy set / change one of the states, default NULL = use $_REQUEST
52 52
 	 */
53 53
 	function __construct($set_states=null)
54 54
 	{
@@ -542,7 +542,7 @@  discard block
 block discarded – undo
542 542
 	 * @param int &$success number of succeded actions
543 543
 	 * @param int &$failed number of failed actions (not enought permissions)
544 544
 	 * @param string &$action_msg translated verb for the actions, to be used in a message like %1 events 'deleted'
545
-	 * @param string/array $session_name 'calendar_list'
545
+	 * @param string $session_name 'calendar_list'
546 546
 	 * @return boolean true if all actions succeded, false otherwise
547 547
 	 */
548 548
 	function action($action,$checked,$use_all,&$success,&$failed,&$action_msg,$session_name,&$msg,$skip_notification=false)
Please login to merge, or discard this patch.
calendar/inc/class.calendar_uiviews.inc.php 1 patch
Doc Comments   +10 added lines, -5 removed lines patch added patch discarded remove patch
@@ -713,6 +713,8 @@  discard block
 block discarded – undo
713 713
 	 * @param int &$first timestamp 0h of first day of week containing the first of the current month
714 714
 	 * @param int &$last timestamp 23:59:59 of last day of week containg the last day of the current month
715 715
 	 * @param int $day = 1 should the alignment be based on the 1. of the month or an other date, eg. the 15.
716
+	 * @param integer $first
717
+	 * @param integer $last
716 718
 	 */
717 719
 	function _week_align_month(&$first,&$last,$day=1)
718 720
 	{
@@ -741,6 +743,8 @@  discard block
 block discarded – undo
741 743
 	 *
742 744
 	 * @param int &$first timestamp 0h of first day of week containing the first of the current year
743 745
 	 * @param int &$last timestamp 23:59:59 of last day of week containg the last day of the current year
746
+	 * @param integer $first
747
+	 * @param integer $last
744 748
 	 */
745 749
 	function _month_align_year(&$first,&$last)
746 750
 	{
@@ -1029,7 +1033,7 @@  discard block
 block discarded – undo
1029 1033
 	 *
1030 1034
 	 * @param array/string $todo_label label for the todo-box or array with 2 values: the label and a boolean show_all
1031 1035
 	 *	On return $todo_label contains the label for the todo-box
1032
-	 * @return string/boolean html with a table of open todo's or false if no hook availible
1036
+	 * @return string html with a table of open todo's or false if no hook availible
1033 1037
 	 */
1034 1038
 	function get_todos(&$todo_label)
1035 1039
 	{
@@ -1580,6 +1584,7 @@  discard block
 block discarded – undo
1580 1584
 	 * @param int $width width of the widget
1581 1585
 	 * @param string $indent string for correct indention
1582 1586
 	 * @param int $owner owner of the eventCol
1587
+	 * @param double $z_index
1583 1588
 	 */
1584 1589
 	function eventColWidget($events,$left,$width,$indent,$owner,$z_index=null)
1585 1590
 	{
@@ -1607,7 +1612,7 @@  discard block
 block discarded – undo
1607 1612
 	 * The display of the event and it's tooltip is done via the event_widget.tpl template
1608 1613
 	 *
1609 1614
 	 * @param $event array with the data of event to show
1610
-	 * @param $width int width of the widget
1615
+	 * @param integer $width int width of the widget
1611 1616
 	 * @param string $indent string for correct indention
1612 1617
 	 * @param int $owner owner of the calendar the event is in
1613 1618
 	 * @param boolean $return_array = false should an array with keys(tooltip,popup,html) be returned or the complete widget as string
@@ -1921,7 +1926,7 @@  discard block
 block discarded – undo
1921 1926
 	 * - 'edit_popup' => '400x300' (optional)
1922 1927
 	 *
1923 1928
 	 * @param string $app
1924
-	 * @param int|string $id
1929
+	 * @param string $id
1925 1930
 	 * @return string
1926 1931
 	 */
1927 1932
 	function integration_get_popup($app,$id)
@@ -1963,7 +1968,7 @@  discard block
 block discarded – undo
1963 1968
 	 * Icons specified in $events['icons'] are always displayed!
1964 1969
 	 *
1965 1970
 	 * @param string $app
1966
-	 * @param int|string $id
1971
+	 * @param string $id
1967 1972
 	 * @param array $event
1968 1973
 	 * @return array
1969 1974
 	 */
@@ -2072,7 +2077,7 @@  discard block
 block discarded – undo
2072 2077
 	 * @param array $events events to show
2073 2078
 	 * @param mixed $start start-time of the grid
2074 2079
 	 * @param mixed $end end-time of the grid
2075
-	 * @param string|int $by_cat rows by sub-categories of $by_cat (cat_id or 0 for upmost level) or by 'user' or 'month'
2080
+	 * @param integer $by_cat rows by sub-categories of $by_cat (cat_id or 0 for upmost level) or by 'user' or 'month'
2076 2081
 	 * @param string $indent = '' string for correct indention
2077 2082
 	 * @return string with widget
2078 2083
 	 */
Please login to merge, or discard this patch.
calendar/inc/class.soholiday.inc.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -78,6 +78,9 @@
 block discarded – undo
78 78
 		}
79 79
 	}
80 80
 
81
+	/**
82
+	 * @param ADORecordSet $rs
83
+	 */
81 84
 	function store_to_array(&$holidays,$rs)
82 85
 	{
83 86
 		foreach($rs as $row)
Please login to merge, or discard this patch.
calendar/setup/tables_update.inc.php 1 patch
Doc Comments   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -7,6 +7,8 @@  discard block
 block discarded – undo
7 7
  * @author Ralf Becker <RalfBecker-AT-outdoor-training.de>
8 8
  * @license http://opensource.org/licenses/gpl-license.php GPL - GNU General Public License
9 9
  * @version $Id$
10
+ * @param string $table
11
+ * @param string $field
10 12
  */
11 13
 
12 14
 function calendar_v0_9_2to0_9_3update_owner($table, $field)
@@ -2304,7 +2306,7 @@  discard block
 block discarded – undo
2304 2306
  *
2305 2307
  * Also fix recurring events containing a reference to an other master, created when an exception is made a recurring event.
2306 2308
  *
2307
- * @return type
2309
+ * @return string
2308 2310
  */
2309 2311
 function calendar_upgrade14_1()
2310 2312
 {
Please login to merge, or discard this patch.