EGroupware / egroupware

api/asyncservices.php

Braces +4 added lines, -1 removed lines

@@ -14,7 +14,10 @@
 
 use EGroupware\Api\Asyncservice;
 
-if (!isset($_REQUEST['domain'])) $_REQUEST['domain'] = isset($_SERVER['argv'][1]) ? $_SERVER['argv'][1] : 'default';
+if (!isset($_REQUEST['domain']))
+{
+	$_REQUEST['domain'] = isset($_SERVER['argv'][1]) ? $_SERVER['argv'][1] : 'default';
+}
 $path_to_egroupware = realpath(__DIR__.'/..');	//  need to be adapted if this script is moved somewhere else
 
 // remove the comment from one of the following lines to enable loging

api/images.php

Braces +4 added lines, -1 removed lines

@@ -48,7 +48,10 @@
 	exit;
 }
 
-if (empty($_GET['debug'])) $content = 'egw.set_images('.$content.", egw && egw.window !== window);\n";
+if (empty($_GET['debug']))
+{
+	$content = 'egw.set_images('.$content.", egw && egw.window !== window);\n";
+}
 
 // we run our own gzip compression, to set a correct Content-Length of the encoded content
 if (in_array('gzip', explode(',',$_SERVER['HTTP_ACCEPT_ENCODING'])) && function_exists('gzencode'))

api/src/Framework/IncludeMgr.php

Braces +16 added lines, -4 removed lines

@@ -80,7 +80,10 @@ 
 	private function parse_file($file)
 	{
 		// file is from url and can contain query-params, eg. /phpgwapi/inc/jscalendar-setup.php?dateformat=d.m.Y&lang=de
-		if (strpos($file,'?') !== false) list($file) = explode('?',$file);
+		if (strpos($file,'?') !== false)
+		{
+			list($file) = explode('?',$file);
+		}
 
 		// Mark the file as parsed
 		$this->parsed_files[$file] = true;
@@ -326,12 +329,15 @@ 
 			}
 		}
 
-		if (self::$DEBUG_MODE) // DEBUG_MODE is currently ALWAYS true. Comment this code out if you don't want error messages.
+		if (self::$DEBUG_MODE)
+		{
+			// DEBUG_MODE is currently ALWAYS true. Comment this code out if you don't want error messages.
 		{
 			//error_log(__METHOD__."($package,$file,$app) $path NOT found".($this->debug_processing_file ? " while processing file '{$this->debug_processing_file}'." : "!").' '.function_backtrace());
 		}
 
 		return false;
+		}
 	}
 
 	/**
@@ -377,7 +383,10 @@ 
 	 */
 	public function include_files(array $files, $clear_files=false)
 	{
-		if ($clear_files) $this->included_files = array();
+		if ($clear_files)
+		{
+			$this->included_files = array();
+		}
 
 		foreach ($files as $file)
 		{
@@ -394,7 +403,10 @@ 
 	public function get_included_files($clear_files=false)
 	{
 		$ret = array_keys($this->included_files);
-		if ($clear_files) $this->included_files = array();
+		if ($clear_files)
+		{
+			$this->included_files = array();
+		}
 		return $ret;
 	}
 

api/src/Framework/Template.php

Braces +4 added lines, -1 removed lines

@@ -547,7 +547,10 @@
 
 	function check_debug()
 	{
-		if (!$this->debug) return False;
+		if (!$this->debug)
+		{
+			return False;
+		}
 
 		foreach(func_get_args() as $arg)
 		{

api/src/Framework/Favorites.php

Braces +5 added lines, -1 removed lines

@@ -161,7 +161,11 @@
 		{
 			if(strpos($pref_name, $pref_prefix) === 0)
 			{
-				if(!is_array($pref)) continue;	// old favorite
+				if(!is_array($pref))
+				{
+					continue;
+				}
+				// old favorite
 
 				$favorites[(string)substr($pref_name,strlen($pref_prefix))] = $pref;
 			}

api/src/Framework/CssIncludes.php

Braces +8 added lines, -2 removed lines

@@ -107,14 +107,20 @@
 		$max_modified = 0;
 		//no more dynamic minifying: $debug_minify = $GLOBALS['egw_info']['server']['debug_minify'] === 'True';
 		$base_path = $GLOBALS['egw_info']['server']['webserver_url'];
-		if ($base_path[0] != '/') $base_path = parse_url($base_path, PHP_URL_PATH);
+		if ($base_path[0] != '/')
+		{
+			$base_path = parse_url($base_path, PHP_URL_PATH);
+		}
 		$css_files = '';
 		foreach(self::$files as $path)
 		{
 			foreach(self::resolve_css_includes($path) as $path)
 			{
 				list($file,$query) = explode('?',$path,2);
-				if (($mod = filemtime(EGW_SERVER_ROOT.$file)) > $max_modified) $max_modified = $mod;
+				if (($mod = filemtime(EGW_SERVER_ROOT.$file)) > $max_modified)
+				{
+					$max_modified = $mod;
+				}
 
 				// do NOT include app.css or categories.php, as it changes from app to app
 				//no more dynamic minifying: if ($debug_minify || substr($path, -8) == '/app.css' || substr($file,-14) == 'categories.php')

api/src/Framework/Tutorial.php

Braces +16 added lines, -4 removed lines

@@ -65,7 +65,10 @@ 
 		foreach (array_keys($tutorials) as $app)
 		{
 			// show only apps user has access to them
-			if (in_array($app, array_keys($GLOBALS['egw_info']['user']['apps']))) $apps [$app] = $app;
+			if (in_array($app, array_keys($GLOBALS['egw_info']['user']['apps'])))
+			{
+				$apps [$app] = $app;
+			}
 		}
 		$sel_options = array(
 			'apps' => $apps,
@@ -122,7 +125,10 @@ 
 		{
 			$json = file_get_contents('http://www.egroupware.de/videos/tutorials.json');
 			// Fallback tutorials.json
-			if (!$json) $json = file_get_contents('api/setup/tutorials.json');
+			if (!$json)
+			{
+				$json = file_get_contents('api/setup/tutorials.json');
+			}
 			// Cache the json object for two hours
 			Api\Cache::setCache(Api\Cache::TREE, __CLASS__, 'egw_tutorial_json', $json, 7200);
 		}
@@ -136,10 +142,16 @@ 
 	 */
 	public static function tutorial_menu()
 	{
-		if (Api\Header\UserAgent::mobile()) return;
+		if (Api\Header\UserAgent::mobile())
+		{
+			return;
+		}
 		$tutorials = json_decode(self::getJsonData(),true);
 		$appname = $GLOBALS['egw_info']['flags']['currentapp'];
-		if (!is_array($tutorials[$appname])) return false;
+		if (!is_array($tutorials[$appname]))
+		{
+			return false;
+		}
 		if (!$GLOBALS['egw_info']['server']['egw_tutorial_disable']
 			|| $GLOBALS['egw_info']['server']['egw_tutorial_disable'] == 'intro')
 		{

api/src/Framework/About.php

Braces +53 added lines, -21 removed lines

@@ -168,7 +168,11 @@ 
 				}
 			}
 		}
-		if (!isset($setup_info[$app]) || !is_array($setup_info[$app])) return null;	// app got eg. removed in filesystem
+		if (!isset($setup_info[$app]) || !is_array($setup_info[$app]))
+		{
+			return null;
+		}
+		// app got eg. removed in filesystem
 
 		$app_info  = array_merge($GLOBALS['egw_info']['apps'][$app], $setup_info[$app]);
 
@@ -191,7 +195,10 @@ 
 		{
 			$ret['author'] = $this->_getHtmlPersonalInfo($setup_info[$app], 'author');
 			$ret['maintainer'] = $this->_getHtmlPersonalInfo($setup_info[$app], 'maintainer');
-			if ($app_info['version'] != $setup_info[$app]['version']) $ret['version'] .= ' ('.$setup_info[$app]['version'].')';
+			if ($app_info['version'] != $setup_info[$app]['version'])
+			{
+				$ret['version'] .= ' ('.$setup_info[$app]['version'].')';
+			}
 			$ret['license'] = $setup_info[$app]['license'];
 			$ret['description'] = $setup_info[$app]['description'];
 			$ret['note'] = $setup_info[$app]['note'];
@@ -216,39 +223,54 @@ 
 	{
 		$authors = array();
 			// get the author(s)
-			if ($setup_info[$f]) {
+			if ($setup_info[$f])
+			{
 				// author is set
-				if (!is_array($setup_info[$f])) {
+				if (!is_array($setup_info[$f]))
+				{
 					// author is no array
 					$authors[0]['name'] = $setup_info[$f];
-					if ($setup_info[$f.'_email']) {
+					if ($setup_info[$f.'_email'])
+					{
 						$authors[0]['email'] = $setup_info[$f.'_email'];
 					}
-					if ($setup_info[$f.'_url']) {
+					if ($setup_info[$f.'_url'])
+					{
 						$authors[0]['url'] = $setup_info[$f.'_url'];
 					}
 
-				} else {
+				}
+				else
+				{
 					// author is array
-					if ($setup_info[$f]['name']) {
+					if ($setup_info[$f]['name'])
+					{
 						// only one author
 						$authors[0]['name'] = $setup_info[$f]['name'];
-						if ($setup_info[$f]['email']) {
+						if ($setup_info[$f]['email'])
+						{
 							$authors[0]['email'] = $setup_info[$f]['email'];
 						}
-						if ($setup_info[$f]['url']) {
+						if ($setup_info[$f]['url'])
+						{
 							$authors[0]['url'] = $setup_info[$f]['url'];
 						}
-					} else {
+					}
+					else
+					{
 						// may be more authors
-						foreach (array_keys($setup_info[$f]) as $number) {
-							if ($setup_info[$f][$number]['name']) {
+						foreach (array_keys($setup_info[$f]) as $number)
+						{
+							if ($setup_info[$f][$number]['name'])
+							{
 									$authors[$number]['name'] = $setup_info[$f][$number]['name'];
 							}
-							if ($setup_info[$f][$number]['email']) {
+							if ($setup_info[$f][$number]['email'])
+							{
 									$authors[$number]['email'] = $setup_info[$f][$number]['email'];
 							}
-							if ($setup_info[$f][$number]['url']) {
+							if ($setup_info[$f][$number]['url'])
+							{
 									$authors[$number]['url'] = $setup_info[$f][$number]['url'];
 							}
 						}
@@ -258,15 +280,19 @@ 
 
 		// html format authors
 		$s = '';
-		foreach ($authors as $author) {
-			if ($s != '') {
+		foreach ($authors as $author)
+		{
+			if ($s != '')
+			{
 					$s .= '<br />';
 			}
 			$s .= lang('name').': '.$author['name'];
-			if ($author['email']) {
+			if ($author['email'])
+			{
 					$s .= '<br />'.lang('email').': <a href="mailto:'.$author['email'].'">'.$author['email'].'</a>';
 			}
-			if ($author['url']) {
+			if ($author['url'])
+			{
 					$s .= '<br />'.lang('url').': <a href="'.$author['url'].'" target="_blank">'.$author['url'].'</a>';
 			}
 		}
@@ -300,8 +326,14 @@ 
 
 		if (isset(self::$knownLicenses[strtoupper($name)]))
 		{
-			if (empty($url)) $url = self::$knownLicenses[$name=strtoupper($name)][0];
-			if (empty($title)) $title = self::$knownLicenses[$name=strtoupper($name)][1];
+			if (empty($url))
+			{
+				$url = self::$knownLicenses[$name=strtoupper($name)][0];
+			}
+			if (empty($title))
+			{
+				$title = self::$knownLicenses[$name=strtoupper($name)][1];
+			}
 		}
 
 		return array(

api/src/Framework/Bundle.php

Braces +22 added lines, -5 removed lines

@@ -74,7 +74,11 @@ 
 		$query = null;
 		foreach($js_includes as $file)
 		{
-			if ($file == '/api/js/jsapi/egw.js') continue;	// loaded via own tag, and we must not load it twice!
+			if ($file == '/api/js/jsapi/egw.js')
+			{
+				continue;
+			}
+			// loaded via own tag, and we must not load it twice!
 
 			if (!isset($to_include[$file]))
 			{
@@ -133,17 +137,27 @@ 
 	{
 		$debug_minify = $GLOBALS['egw_info']['server']['debug_minify'] === 'True';
 		// ignore not existing minurl
-		if (!empty($minurl) && !file_exists(EGW_SERVER_ROOT.$minurl)) $minurl = null;
+		if (!empty($minurl) && !file_exists(EGW_SERVER_ROOT.$minurl))
+		{
+			$minurl = null;
+		}
 		$to_include_first = $to_include = $to_minify = array();
 		$max_modified = 0;
 		$query = null;
 		foreach($js_includes as $path)
 		{
-			if ($path == '/api/js/jsapi/egw.js') continue; // Leave egw.js out of bundle
+			if ($path == '/api/js/jsapi/egw.js')
+			{
+				continue;
+			}
+			// Leave egw.js out of bundle
 			unset($query);
 			list($path,$query) = explode('?',$path,2);
 			$mod = filemtime(EGW_SERVER_ROOT.$path);
-			if ($mod > $max_modified) $max_modified = $mod;
+			if ($mod > $max_modified)
+			{
+				$max_modified = $mod;
+			}
 
 			// ckeditor must be included before bundled files, as they depend on it!
 			if (strpos($path,'/ckeditor/ckeditor.js') !== false)
@@ -182,7 +196,10 @@ 
 			// need to include minified javascript before not minified stuff like jscalendar-setup, as it might depend on it
 			array_unshift($to_include, $path);
 		}
-		if ($to_include_first) $to_include = array_merge($to_include_first, $to_include);
+		if ($to_include_first)
+		{
+			$to_include = array_merge($to_include_first, $to_include);
+		}
 		//error_log(__METHOD__."("./*array2string($js_includes).*/", $max_modified, $minurl) returning ".array2string($to_include));
 		return $to_include;
 	}