EGroupware / egroupware

admin/inc/class.admin_cmd.inc.php

Indentation +5 added lines, -5 removed lines

@@ -239,11 +239,11 @@
 			unset($postdata[$name]);
 		}
 		$opts = array('http' =>
-		    array(
-		        'method'  => 'POST',
-		        'header'  => 'Content-type: application/x-www-form-urlencoded',
-		        'content' => http_build_query($postdata),
-		    )
+			array(
+				'method'  => 'POST',
+				'header'  => 'Content-type: application/x-www-form-urlencoded',
+				'content' => http_build_query($postdata),
+			)
 		);
 		$url = $remote['remote_url'].'/admin/remote.php?domain='.urlencode($remote['remote_domain']).'&secret='.urlencode($secret);
 		//echo "sending command to $url\n"; _debug_array($opts);

Braces +53 added lines, -13 removed lines

@@ -183,7 +183,10 @@ 
 				{
 					$ret = $this->remote_exec($dry_run);
 				}
-				if (is_null($this->status)) $this->status = admin_cmd::successful;
+				if (is_null($this->status))
+				{
+					$this->status = admin_cmd::successful;
+				}
 			}
 			catch (Exception $e) {
 				$this->error = $e->getMessage();
@@ -277,7 +280,10 @@ 
 	 */
 	function delete()
 	{
-		if ($this->status != admin_cmd::scheduled) return false;
+		if ($this->status != admin_cmd::scheduled)
+		{
+			return false;
+		}
 
 		$this->status = admin_cmd::deleted;
 
@@ -303,7 +309,10 @@ 
 		{
 			$this->modified = time();
 			$this->modifier = $set_modifier ? $GLOBALS['egw_info']['user']['account_id'] : 0;
-			if ($set_modifier) $this->modifier_email = admin_cmd::user_email();
+			if ($set_modifier)
+			{
+				$this->modifier_email = admin_cmd::user_email();
+			}
 		}
 		if (version_compare(PHP_VERSION,'5.1.2','>'))
 		{
@@ -411,10 +420,13 @@ 
 		}
 		$cmd = new $class($data);
 
-		if ($cmd instanceof admin_cmd)	// dont allow others classes to be executed that way!
+		if ($cmd instanceof admin_cmd)
+		{
+			// dont allow others classes to be executed that way!
 		{
 			return $cmd;
 		}
+		}
 		throw new Api\Exception\WrongParameter(lang('%1 is no command!',$class),0);
 	}
 
@@ -564,7 +576,10 @@ 
 			}
 		}
 		unset($vars['data']);
-		if ($this->data) $vars = array_merge($this->data,$vars);
+		if ($this->data)
+		{
+			$vars = array_merge($this->data,$vars);
+		}
 
 		return $vars;
 	}
@@ -583,10 +598,13 @@ 
 			admin_cmd::_instanciate_acl($this->creator);
 			// todo: check only if and with $this->creator
 			if (!admin_cmd::$acl->check('run',1,'admin') &&		// creator is no longer admin
-				$extra_acl && $extra_deny && admin_cmd::$acl->check($extra_acl,$extra_deny,'admin'))	// creator is explicitly forbidden to do something
+				$extra_acl && $extra_deny && admin_cmd::$acl->check($extra_acl,$extra_deny,'admin'))
+			{
+				// creator is explicitly forbidden to do something
 			{
 				throw new Api\Exception\NoPermission\Admin();
 			}
+			}
 		}
 	}
 
@@ -603,11 +621,14 @@ 
 		{
 			if (!isset($GLOBALS['egw_info']['apps'][$name]))
 			{
-				foreach($GLOBALS['egw_info']['apps'] as $app => $data)	// check against title and localised name
+				foreach($GLOBALS['egw_info']['apps'] as $app => $data)
+				{
+					// check against title and localised name
 				{
 					if (!strcasecmp($name,$data['title']) || !strcasecmp($name,lang($app)))
 					{
 						$apps[$key] = $name = $app;
+				}
 						break;
 					}
 				}
@@ -642,7 +663,11 @@ 
 		{
 			throw new Api\Exception\WrongUserinput(lang("Wrong account type: %1 is NO %2 !!!",$account,$allow_only_user?lang('user'):lang('group')),15);
 		}
-		if ($type == 2 && $id > 0) $id = -$id;	// groups use negative id's internally, fix it, if user given the wrong sign
+		if ($type == 2 && $id > 0)
+		{
+			$id = -$id;
+		}
+		// groups use negative id's internally, fix it, if user given the wrong sign
 
 		return $id;
 	}
@@ -658,7 +683,10 @@ 
 	 */
 	static function parse_accounts($accounts,$allow_only_user=null)
 	{
-		if (!$accounts) return null;
+		if (!$accounts)
+		{
+			return null;
+		}
 
 		$ids = array();
 		foreach(is_array($accounts) ? $accounts : explode(',',$accounts) as $account)
@@ -677,9 +705,12 @@ 
 	 */
 	static function parse_date($date)
 	{
-		if (!is_numeric($date))	// we allow to input a timestamp
+		if (!is_numeric($date))
+		{
+			// we allow to input a timestamp
 		{
 			$datein = $date;
+		}
 			// convert german DD.MM.YYYY format into ISO YYYY-MM-DD format
 			$date = preg_replace('/^([0-9]{1,2})\.([0-9]{1,2})\.([0-9]{4})$/','\3-\2-\1',$date);
 
@@ -837,10 +868,13 @@ 
 			return false;		// no schduled command, no need to setup the job
 		}
 		$next = $jobs[0];
-		if (($time = $next['scheduled']) < time())	// should run immediatly
+		if (($time = $next['scheduled']) < time())
+		{
+			// should run immediatly
 		{
 			return admin_cmd::run_queued_jobs();
 		}
+		}
 		$async = new Api\Asyncservice();
 
 		// we cant use this class as callback, as it's abstract and ExecMethod used by the async service instanciated the class!
@@ -944,10 +978,13 @@ 
 	{
 		admin_cmd::_instanciate_remote();
 
-		if ($data['install_id'] && $data['config_passwd'])	// calculate hash
+		if ($data['install_id'] && $data['config_passwd'])
+		{
+			// calculate hash
 		{
 			$data['remote_hash'] = self::remote_hash($data['install_id'],$data['config_passwd']);
 		}
+		}
 		elseif (!$data['remote_hash'] && !($data['install_id'] && $data['config_passwd']))
 		{
 			throw new Api\Exception\WrongUserinput(lang('Either Install ID AND Api\Config password needed OR the remote hash!'));
@@ -981,7 +1018,10 @@ 
 		{
 			throw new Api\Exception\WrongParameter(empty($config_passwd)?'Empty Api\Config password':'install_id no md5 hash');
 		}
-		if (!self::is_md5($config_passwd)) $config_passwd = md5($config_passwd);
+		if (!self::is_md5($config_passwd))
+		{
+			$config_passwd = md5($config_passwd);
+		}
 
 		return md5($config_passwd.$install_id);
 	}

Doc Comments +16 added lines, -20 removed lines

@@ -100,7 +100,7 @@ 
 	/**
 	 * Executes the command
 	 *
-	 * @param boolean $check_only=false only run the checks (and throw the exceptions), but not the command itself
+	 * @param boolean $check_only only run the checks (and throw the exceptions), but not the command itself
 	 * @return string success message
 	 * @throws Exception()
 	 */
@@ -141,10 +141,10 @@ 
 	 *
 	 * The command will be written to the database queue, incl. its scheduled start time or execution status
 	 *
-	 * @param int $time=null timestamp to run the command or null to run it immediatly
-	 * @param boolean $set_modifier=null should the current user be set as modifier, default true
-	 * @param booelan $skip_checks=false do not yet run the checks for a scheduled command
-	 * @param boolean $dry_run=false only run checks, NOT command itself
+	 * @param boolean $set_modifier should the current user be set as modifier, default true
+	 * @param booelan $skip_checks do not yet run the checks for a scheduled command
+	 * @param boolean $dry_run only run checks, NOT command itself
+	 * @param integer $time
 	 * @return mixed return value of the command
 	 * @throws Exceptions on error
 	 */
@@ -282,7 +282,7 @@ 
 	/**
 	 * Saving the object to the database
 	 *
-	 * @param boolean $set_modifier=true set the current user as modifier or 0 (= run by the system)
+	 * @param boolean $set_modifier set the current user as modifier or 0 (= run by the system)
 	 * @return boolean true on success, false otherwise
 	 */
 	function save($set_modifier=true)
@@ -438,15 +438,12 @@ 
 	 *
 	 * @static
 	 * @param array/string $criteria array of key and data cols, OR a SQL query (content for WHERE), fully quoted (!)
-	 * @param boolean/string/array $only_keys=true True returns only keys, False returns all cols. or
+	 * @param boolean/string/array $only_keys True returns only keys, False returns all cols. or
 	 *	comma seperated list or array of columns to return
 	 * @param string $order_by='' fieldnames + {ASC|DESC} separated by colons ',', can also contain a GROUP BY (if it contains ORDER BY)
 	 * @param string/array $extra_cols='' string or array of strings to be added to the SELECT, eg. "count(*) as num"
 	 * @param string $wildcard='' appended befor and after each criteria
-	 * @param boolean $empty=false False=empty criteria are ignored in query, True=empty have to be empty in row
-	 * @param string $op='AND' defaults to 'AND', can be set to 'OR' too, then criteria's are OR'ed together
-	 * @param mixed $start=false if != false, return only maxmatch rows begining with start, or array($start,$num), or 'UNION' for a part of a union query
-	 * @param array $filter=null if set (!=null) col-data pairs, to be and-ed (!) into the query without wildcards
+	 * @param array $filter if set (!=null) col-data pairs, to be and-ed (!) into the query without wildcards
 	 * @return array
 	 */
 	static function &search($criteria,$only_keys=True,$order_by='',$extra_cols='',$wildcard='',$empty=False,$op='AND',$start=false,$filter=null)
@@ -567,8 +564,8 @@ 
 	/**
 	 * Check if the creator is still admin and has the neccessary admin rights
 	 *
-	 * @param string $extra_acl=null further admin rights to check, eg. 'account_access'
-	 * @param int $extra_deny=null further admin rights to check, eg. 16 = deny edit accounts
+	 * @param string $extra_acl further admin rights to check, eg. 'account_access'
+	 * @param integer $extra_deny further admin rights to check, eg. 16 = deny edit accounts
 	 * @throws egw_exception_no_admin
 	 */
 	protected function _check_admin($extra_acl=null,$extra_deny=null)
@@ -619,7 +616,7 @@ 
 	 * parse account name or id
 	 *
 	 * @param string/int $account account_id or account_lid
-	 * @param boolean $allow_only_user=null true=only user, false=only groups, default both
+	 * @param boolean $allow_only_user true=only user, false=only groups, default both
 	 * @return int/array account_id
 	 * @throws egw_exception_wrong_userinput(lang("Unknown account: %1 !!!",$account),15);
 	 * @throws egw_exception_wrong_userinput(lang("Wrong account type: %1 is NO %2 !!!",$account,$allow_only_user?lang('user'):lang('group')),15);
@@ -646,7 +643,7 @@ 
 	 * parse account names or ids
 	 *
 	 * @param string/int/array $accounts array or comma-separated account_id's or account_lid's
-	 * @param boolean $allow_only_user=null true=only user, false=only groups, default both
+	 * @param boolean $allow_only_user true=only user, false=only groups, default both
 	 * @return array of account_id's or null if none specified
 	 * @throws egw_exception_wrong_userinput(lang("Unknown account: %1 !!!",$account),15);
 	 * @throws egw_exception_wrong_userinput(lang("Wrong account type: %1 is NO %2 !!!",$account,$allow_only?lang('user'):lang('group')),15);
@@ -690,7 +687,7 @@ 
 	 * Parse a boolean value
 	 *
 	 * @param string|boolean|int $value
-	 * @param boolean $default=null
+	 * @param boolean $default
 	 * @return boolean
 	 * @throws egw_exception_wrong_userinput(lang('Invalid value "%1" use yes or no!',$value),998);
 	 */
@@ -759,7 +756,7 @@ 
 	 * Instanciated acl class
 	 *
 	 * @todo acl class instanciation for setup
-	 * @param int $account=null account_id the class needs to be instanciated for, default need only account-independent methods
+	 * @param int $account account_id the class needs to be instanciated for, default need only account-independent methods
 	 * @throws egw_exception_assertion_failed(lang('%1 class not instanciated','acl'),999);
 	 */
 	protected function _instanciate_acl($account=null)
@@ -920,7 +917,7 @@ 
 	 * Read data of a remote instance
 	 *
 	 * @param array/int $keys
-	 * @return array
+	 * @return string
 	 */
 	static function read_remote($keys)
 	{
@@ -1000,7 +997,7 @@ 
 	 * Check if string is a md5 hash (32 chars of 0-9 or a-f)
 	 *
 	 * @param string $str
-	 * @return boolean
+	 * @return integer
 	 */
 	static function is_md5($str)
 	{
@@ -1046,7 +1043,6 @@ 
 	/**
 	 * Return a rand string, eg. to generate passwords
 	 *
-	 * @param int $len=16
 	 * @return string
 	 */
 	static function randomstring($len=16)

Spacing +106 added lines, -106 removed lines

@@ -20,14 +20,14 @@ 
 	const successful = 2;
 	const failed     = 3;
 	const pending    = 4;
-	const queued     = 5;	// command waits to be fetched from remote
+	const queued     = 5; // command waits to be fetched from remote
 
 	/**
 	 * Status which stil need passwords available
 	 *
 	 * @var array
 	 */
-	static $require_pw_stati = array(self::scheduled,self::pending,self::queued);
+	static $require_pw_stati = array(self::scheduled, self::pending, self::queued);
 
 	/**
 	 * The status of the command, one of either scheduled, successful, failed or deleted
@@ -104,7 +104,7 @@ 
 	 * @return string success message
 	 * @throws Exception()
 	 */
-	protected abstract function exec($check_only=false);
+	protected abstract function exec($check_only = false);
 
 	/**
 	 * Return a title / string representation for a given command, eg. to display it
@@ -129,7 +129,7 @@ 
 
 		$this->type = get_class($this);
 
-		foreach($data as $name => $value)
+		foreach ($data as $name => $value)
 		{
 			$this->$name = $name == 'data' && !is_array($value) ? json_php_unserialize($value) : $value;
 		}
@@ -148,13 +148,13 @@ 
 	 * @return mixed return value of the command
 	 * @throws Exceptions on error
 	 */
-	function run($time=null,$set_modifier=true,$skip_checks=false,$dry_run=false)
+	function run($time = null, $set_modifier = true, $skip_checks = false, $dry_run = false)
 	{
 		if (!is_null($time))
 		{
 			$this->scheduled = $time;
 			$this->status = admin_cmd::scheduled;
-			$ret = lang('Command scheduled to run at %1',date('Y-m-d H:i',$time));
+			$ret = lang('Command scheduled to run at %1', date('Y-m-d H:i', $time));
 			// running the checks of the arguments for local commands, if not explicitly requested to not run them
 			if (!$this->remote_id && !$skip_checks)
 			{
@@ -217,21 +217,21 @@ 
 	{
 		if (!($remote = $this->read_remote($this->remote_id)))
 		{
-			throw new egw_exception_wrong_userinput(lang('Invalid remote id or name "%1"!',$id_or_name),997);
+			throw new egw_exception_wrong_userinput(lang('Invalid remote id or name "%1"!', $id_or_name), 997);
 		}
 		if (!$this->uid)
 		{
-			$this->save();	// to get the uid
+			$this->save(); // to get the uid
 		}
 		$secret = md5($this->uid.$remote['remote_hash']);
 
 		$postdata = $this->as_array();
 		if (is_object($GLOBALS['egw']->translation))
 		{
-			$postdata = $GLOBALS['egw']->translation->convert($postdata,$GLOBALS['egw']->translation->charset(),'utf-8');
+			$postdata = $GLOBALS['egw']->translation->convert($postdata, $GLOBALS['egw']->translation->charset(), 'utf-8');
 		}
 		// dont send the id's which have no meaning on the remote install
-		foreach(array('id','creator','modifier','requested','remote_id') as $name)
+		foreach (array('id', 'creator', 'modifier', 'requested', 'remote_id') as $name)
 		{
 			unset($postdata[$name]);
 		}
@@ -256,11 +256,11 @@ 
 		}
 		if (is_object($GLOBALS['egw']->translation))
 		{
-			$message = $GLOBALS['egw']->translation->convert($message,'utf-8');
+			$message = $GLOBALS['egw']->translation->convert($message, 'utf-8');
 		}
-		if (is_string($message) && preg_match('/^([0-9]+) (.*)$/',$message,$matches))
+		if (is_string($message) && preg_match('/^([0-9]+) (.*)$/', $message, $matches))
 		{
-			throw new egw_exception($matches[2],(int)$matches[1]);
+			throw new egw_exception($matches[2], (int)$matches[1]);
 		}
 		return $message;
 	}
@@ -285,7 +285,7 @@ 
 	 * @param boolean $set_modifier=true set the current user as modifier or 0 (= run by the system)
 	 * @return boolean true on success, false otherwise
 	 */
-	function save($set_modifier=true)
+	function save($set_modifier = true)
 	{
 		admin_cmd::_instanciate_sql();
 
@@ -300,13 +300,13 @@ 
 			$this->modifier = $set_modifier ? $GLOBALS['egw_info']['user']['account_id'] : 0;
 			if ($set_modifier) $this->modifier_email = admin_cmd::user_email();
 		}
-		if (version_compare(PHP_VERSION,'5.1.2','>'))
+		if (version_compare(PHP_VERSION, '5.1.2', '>'))
 		{
-			$vars = get_object_vars($this);	// does not work in php5.1.2 due a bug
+			$vars = get_object_vars($this); // does not work in php5.1.2 due a bug
 		}
 		else
 		{
-			foreach(array_keys(get_class_vars(__CLASS__)) as $name)
+			foreach (array_keys(get_class_vars(__CLASS__)) as $name)
 			{
 				$vars[$name] = $this->$name;
 			}
@@ -346,13 +346,13 @@ 
 	 * @param boolean $return_serialized =true true: return json serialized string, false: return array
 	 * @return string|array see $return_serialized
 	 */
-	static function mask_passwords($data, $return_serialized=true)
+	static function mask_passwords($data, $return_serialized = true)
 	{
 		if (!is_array($data))
 		{
 			$data = json_php_unserialize($data);
 		}
-		foreach($data as $key => &$value)
+		foreach ($data as $key => &$value)
 		{
 			if (is_array($value))
 			{
@@ -402,7 +402,7 @@ 
 		}
 		if (!class_exists($class = $data['type']) || $class == 'admin_cmd')
 		{
-			throw new egw_exception_wrong_parameter(lang('Unknown command %1!',$class),0);
+			throw new egw_exception_wrong_parameter(lang('Unknown command %1!', $class), 0);
 		}
 		$cmd = new $class($data);
 
@@ -410,7 +410,7 @@ 
 		{
 			return $cmd;
 		}
-		throw new egw_exception_wrong_parameter(lang('%1 is no command!',$class),0);
+		throw new egw_exception_wrong_parameter(lang('%1 is no command!', $class), 0);
 	}
 
 	/**
@@ -422,7 +422,7 @@ 
 	 * @param array $readonlys
 	 * @return int
 	 */
-	static function get_rows($query,&$rows,$readonlys)
+	static function get_rows($query, &$rows, $readonlys)
 	{
 		admin_cmd::_instanciate_sql();
 
@@ -430,7 +430,7 @@ 
 		{
 			$query['col_filter']['remote_id'] = null;
 		}
-		return admin_cmd::$sql->get_rows($query,$rows,$readonlys);
+		return admin_cmd::$sql->get_rows($query, $rows, $readonlys);
 	}
 
 	/**
@@ -449,11 +449,11 @@ 
 	 * @param array $filter=null if set (!=null) col-data pairs, to be and-ed (!) into the query without wildcards
 	 * @return array
 	 */
-	static function &search($criteria,$only_keys=True,$order_by='',$extra_cols='',$wildcard='',$empty=False,$op='AND',$start=false,$filter=null)
+	static function &search($criteria, $only_keys = True, $order_by = '', $extra_cols = '', $wildcard = '', $empty = False, $op = 'AND', $start = false, $filter = null)
 	{
 		admin_cmd::_instanciate_sql();
 
-		return admin_cmd::$sql->search($criteria,$only_keys,$order_by,$extra_cols,$wildcard,$empty,$op,$start,$filter);
+		return admin_cmd::$sql->search($criteria, $only_keys, $order_by, $extra_cols, $wildcard, $empty, $op, $start, $filter);
 	}
 
 	/**
@@ -465,7 +465,7 @@ 
 	{
 		if (is_null(admin_cmd::$sql))
 		{
-			admin_cmd::$sql = new so_sql('admin','egw_admin_queue',null,'cmd_');
+			admin_cmd::$sql = new so_sql('admin', 'egw_admin_queue', null, 'cmd_');
 		}
 	}
 
@@ -478,7 +478,7 @@ 
 	{
 		if (is_null(admin_cmd::$remote))
 		{
-			admin_cmd::$remote = new so_sql('admin','egw_admin_remote');
+			admin_cmd::$remote = new so_sql('admin', 'egw_admin_remote');
 		}
 	}
 
@@ -490,11 +490,11 @@ 
 	 */
 	function __get($property)
 	{
-		if (property_exists('admin_cmd',$property))
+		if (property_exists('admin_cmd', $property))
 		{
-			return $this->$property;	// making all (non static) class vars readonly available
+			return $this->$property; // making all (non static) class vars readonly available
 		}
-		switch($property)
+		switch ($property)
 		{
 			case 'accounts':
 				self::_instanciate_accounts();
@@ -511,9 +511,9 @@ 
 	 */
 	function __isset($property)
 	{
-		if (property_exists('admin_cmd',$property))
+		if (property_exists('admin_cmd', $property))
 		{
-			return isset($this->$property);	// making all (non static) class vars readonly available
+			return isset($this->$property); // making all (non static) class vars readonly available
 		}
 		return isset($this->data[$property]);
 	}
@@ -525,7 +525,7 @@ 
 	 * @param mixed $value
 	 * @return mixed
 	 */
-	function __set($property,$value)
+	function __set($property, $value)
 	{
 		$this->data[$property] = $value;
 	}
@@ -547,19 +547,19 @@ 
 	 */
 	function as_array()
 	{
-		if (version_compare(PHP_VERSION,'5.1.2','>'))
+		if (version_compare(PHP_VERSION, '5.1.2', '>'))
 		{
-			$vars = get_object_vars($this);	// does not work in php5.1.2 due a bug
+			$vars = get_object_vars($this); // does not work in php5.1.2 due a bug
 		}
 		else
 		{
-			foreach(array_keys(get_class_vars(__CLASS__)) as $name)
+			foreach (array_keys(get_class_vars(__CLASS__)) as $name)
 			{
 				$vars[$name] = $this->$name;
 			}
 		}
 		unset($vars['data']);
-		if ($this->data) $vars = array_merge($this->data,$vars);
+		if ($this->data) $vars = array_merge($this->data, $vars);
 
 		return $vars;
 	}
@@ -571,14 +571,14 @@ 
 	 * @param int $extra_deny=null further admin rights to check, eg. 16 = deny edit accounts
 	 * @throws egw_exception_no_admin
 	 */
-	protected function _check_admin($extra_acl=null,$extra_deny=null)
+	protected function _check_admin($extra_acl = null, $extra_deny = null)
 	{
 		if ($this->creator)
 		{
 			admin_cmd::_instanciate_acl($this->creator);
 			// todo: check only if and with $this->creator
-			if (!admin_cmd::$acl->check('run',1,'admin') &&		// creator is no longer admin
-				$extra_acl && $extra_deny && admin_cmd::$acl->check($extra_acl,$extra_deny,'admin'))	// creator is explicitly forbidden to do something
+			if (!admin_cmd::$acl->check('run', 1, 'admin') && // creator is no longer admin
+				$extra_acl && $extra_deny && admin_cmd::$acl->check($extra_acl, $extra_deny, 'admin'))	// creator is explicitly forbidden to do something
 			{
 				throw new egw_exception_no_permission_admin();
 			}
@@ -594,13 +594,13 @@ 
 	 */
 	static function parse_apps(array $apps)
 	{
-		foreach($apps as $key => $name)
+		foreach ($apps as $key => $name)
 		{
 			if (!isset($GLOBALS['egw_info']['apps'][$name]))
 			{
-				foreach($GLOBALS['egw_info']['apps'] as $app => $data)	// check against title and localised name
+				foreach ($GLOBALS['egw_info']['apps'] as $app => $data)	// check against title and localised name
 				{
-					if (!strcasecmp($name,$data['title']) || !strcasecmp($name,lang($app)))
+					if (!strcasecmp($name, $data['title']) || !strcasecmp($name, lang($app)))
 					{
 						$apps[$key] = $name = $app;
 						break;
@@ -609,7 +609,7 @@ 
 			}
 			if (!isset($GLOBALS['egw_info']['apps'][$name]))
 			{
-				throw new egw_exception_wrong_userinput(lang("Application '%1' not found (maybe not installed or misspelled)!",$name),8);
+				throw new egw_exception_wrong_userinput(lang("Application '%1' not found (maybe not installed or misspelled)!", $name), 8);
 			}
 		}
 		return $apps;
@@ -624,20 +624,20 @@ 
 	 * @throws egw_exception_wrong_userinput(lang("Unknown account: %1 !!!",$account),15);
 	 * @throws egw_exception_wrong_userinput(lang("Wrong account type: %1 is NO %2 !!!",$account,$allow_only_user?lang('user'):lang('group')),15);
 	 */
-	static function parse_account($account,$allow_only_user=null)
+	static function parse_account($account, $allow_only_user = null)
 	{
 		admin_cmd::_instanciate_accounts();
 
 		if (!($type = admin_cmd::$accounts->exists($account)) ||
-			!is_numeric($id=$account) && !($id = admin_cmd::$accounts->name2id($account)))
+			!is_numeric($id = $account) && !($id = admin_cmd::$accounts->name2id($account)))
 		{
-			throw new egw_exception_wrong_userinput(lang("Unknown account: %1 !!!",$account),15);
+			throw new egw_exception_wrong_userinput(lang("Unknown account: %1 !!!", $account), 15);
 		}
 		if (!is_null($allow_only_user) && $allow_only_user !== ($type == 1))
 		{
-			throw new egw_exception_wrong_userinput(lang("Wrong account type: %1 is NO %2 !!!",$account,$allow_only_user?lang('user'):lang('group')),15);
+			throw new egw_exception_wrong_userinput(lang("Wrong account type: %1 is NO %2 !!!", $account, $allow_only_user ? lang('user') : lang('group')), 15);
 		}
-		if ($type == 2 && $id > 0) $id = -$id;	// groups use negative id's internally, fix it, if user given the wrong sign
+		if ($type == 2 && $id > 0) $id = -$id; // groups use negative id's internally, fix it, if user given the wrong sign
 
 		return $id;
 	}
@@ -651,14 +651,14 @@ 
 	 * @throws egw_exception_wrong_userinput(lang("Unknown account: %1 !!!",$account),15);
 	 * @throws egw_exception_wrong_userinput(lang("Wrong account type: %1 is NO %2 !!!",$account,$allow_only?lang('user'):lang('group')),15);
 	 */
-	static function parse_accounts($accounts,$allow_only_user=null)
+	static function parse_accounts($accounts, $allow_only_user = null)
 	{
 		if (!$accounts) return null;
 
 		$ids = array();
-		foreach(is_array($accounts) ? $accounts : explode(',',$accounts) as $account)
+		foreach (is_array($accounts) ? $accounts : explode(',', $accounts) as $account)
 		{
-			$ids[] = admin_cmd::parse_account($account,$allow_only_user);
+			$ids[] = admin_cmd::parse_account($account, $allow_only_user);
 		}
 		return $ids;
 	}
@@ -676,11 +676,11 @@ 
 		{
 			$datein = $date;
 			// convert german DD.MM.YYYY format into ISO YYYY-MM-DD format
-			$date = preg_replace('/^([0-9]{1,2})\.([0-9]{1,2})\.([0-9]{4})$/','\3-\2-\1',$date);
+			$date = preg_replace('/^([0-9]{1,2})\.([0-9]{1,2})\.([0-9]{4})$/', '\3-\2-\1', $date);
 
-			if (($date = strtotime($date))  === false)
+			if (($date = strtotime($date)) === false)
 			{
-				throw new egw_exception_wrong_userinput(lang('Invalid formated date "%1"!',$datein),6);
+				throw new egw_exception_wrong_userinput(lang('Invalid formated date "%1"!', $datein), 6);
 			}
 		}
 		return (int)$date;
@@ -694,7 +694,7 @@ 
 	 * @return boolean
 	 * @throws egw_exception_wrong_userinput(lang('Invalid value "%1" use yes or no!',$value),998);
 	 */
-	static function parse_boolean($value,$default=null)
+	static function parse_boolean($value, $default = null)
 	{
 		if (is_bool($value) || is_int($value))
 		{
@@ -704,15 +704,15 @@ 
 		{
 			return $default;
 		}
-		if (in_array($value,array('1','yes','true',lang('yes'),lang('true'))))
+		if (in_array($value, array('1', 'yes', 'true', lang('yes'), lang('true'))))
 		{
 			return true;
 		}
-		if (in_array($value,array('0','no','false',lang('no'),lang('false'))))
+		if (in_array($value, array('0', 'no', 'false', lang('no'), lang('false'))))
 		{
 			return false;
 		}
-		throw new egw_exception_wrong_userinput(lang('Invalid value "%1" use yes or no!',$value),998);
+		throw new egw_exception_wrong_userinput(lang('Invalid value "%1" use yes or no!', $value), 998);
 	}
 
 	/**
@@ -730,9 +730,9 @@ 
 			'remote_id' => $id_or_name,
 			'remote_name' => $id_or_name,
 			'remote_domain' => $id_or_name,
-		),true,'','','',false,'OR')) || count($remotes) != 1)
+		), true, '', '', '', false, 'OR')) || count($remotes) != 1)
 		{
-			throw new egw_exception_wrong_userinput(lang('Invalid remote id or name "%1"!',$id_or_name),997);
+			throw new egw_exception_wrong_userinput(lang('Invalid remote id or name "%1"!', $id_or_name), 997);
 		}
 		return $remotes[0]['remote_id'];
 	}
@@ -749,7 +749,7 @@ 
 		{
 			if (!is_object($GLOBALS['egw']->accounts))
 			{
-				throw new egw_exception_assertion_failed(lang('%1 class not instanciated','accounts'),999);
+				throw new egw_exception_assertion_failed(lang('%1 class not instanciated', 'accounts'), 999);
 			}
 			admin_cmd::$accounts = $GLOBALS['egw']->accounts;
 		}
@@ -762,13 +762,13 @@ 
 	 * @param int $account=null account_id the class needs to be instanciated for, default need only account-independent methods
 	 * @throws egw_exception_assertion_failed(lang('%1 class not instanciated','acl'),999);
 	 */
-	protected function _instanciate_acl($account=null)
+	protected function _instanciate_acl($account = null)
 	{
 		if (!is_object(admin_cmd::$acl) || $account && admin_cmd::$acl->account_id != $account)
 		{
 			if (!is_object($GLOBALS['egw']->acl))
 			{
-				throw new egw_exception_assertion_failed(lang('%1 class not instanciated','acl'),999);
+				throw new egw_exception_assertion_failed(lang('%1 class not instanciated', 'acl'), 999);
 			}
 			if ($account && $GLOBALS['egw']->acl->account_id != $account)
 			{
@@ -788,20 +788,20 @@ 
 	 * @param $account_id=null account_id, default current user
 	 * @return string
 	 */
-	static function user_email($account_id=null)
+	static function user_email($account_id = null)
 	{
 		if ($account_id)
 		{
 			admin_cmd::_instanciate_accounts();
-			$fullname = admin_cmd::$accounts->id2name($account_id,'account_fullname');
-			$email = admin_cmd::$accounts->id2name($account_id,'account_email');
+			$fullname = admin_cmd::$accounts->id2name($account_id, 'account_fullname');
+			$email = admin_cmd::$accounts->id2name($account_id, 'account_email');
 		}
 		else
 		{
 			$fullname = $GLOBALS['egw_info']['user']['account_fullname'];
 			$email = $GLOBALS['egw_info']['user']['account_email'];
 		}
-		return $fullname . ($email ? ' <'.$email.'>' : '');
+		return $fullname.($email ? ' <'.$email.'>' : '');
 	}
 
 	/**
@@ -825,11 +825,11 @@ 
 		{
 			return false;
 		}
-		if (!($jobs = admin_cmd::search(array(),false,'cmd_scheduled','','',false,'AND',array(0,1),array(
+		if (!($jobs = admin_cmd::search(array(), false, 'cmd_scheduled', '', '', false, 'AND', array(0, 1), array(
 			'cmd_status' => admin_cmd::scheduled,
 		))))
 		{
-			return false;		// no schduled command, no need to setup the job
+			return false; // no schduled command, no need to setup the job
 		}
 		$next = $jobs[0];
 		if (($time = $next['scheduled']) < time())	// should run immediatly
@@ -840,11 +840,11 @@ 
 		$async = new asyncservice();
 
 		// we cant use this class as callback, as it's abstract and ExecMethod used by the async service instanciated the class!
-		list($app) = explode('_',$class=$next['type']);
+		list($app) = explode('_', $class = $next['type']);
 		$callback = $app.'.'.$class.'.run_queued_jobs';
 
-		$async->cancel_timer(admin_cmd::async_job_id);	// we delete it in case a job already exists
-		return $async->set_timer($time,admin_cmd::async_job_id,$callback,null,$next['creator']);
+		$async->cancel_timer(admin_cmd::async_job_id); // we delete it in case a job already exists
+		return $async->set_timer($time, admin_cmd::async_job_id, $callback, null, $next['creator']);
 	}
 
 	/**
@@ -854,26 +854,26 @@ 
 	 */
 	static function run_queued_jobs()
 	{
-		if (!($jobs = admin_cmd::search(array(),false,'cmd_scheduled','','',false,'AND',false,array(
+		if (!($jobs = admin_cmd::search(array(), false, 'cmd_scheduled', '', '', false, 'AND', false, array(
 			'cmd_status' => admin_cmd::scheduled,
 			'cmd_scheduled <= '.time(),
 		))))
 		{
-			return false;		// no schduled commands, no need to setup the job
+			return false; // no schduled commands, no need to setup the job
 		}
-		admin_cmd::$running_queued_jobs = true;	// stop admin_cmd::run() which calls admin_cmd::save() to install a new job
+		admin_cmd::$running_queued_jobs = true; // stop admin_cmd::run() which calls admin_cmd::save() to install a new job
 
-		foreach($jobs as $job)
+		foreach ($jobs as $job)
 		{
 			try {
 				$cmd = admin_cmd::instanciate($job);
-				$cmd->run(null,false);	// false = dont set current user as modifier, as job is run by the queue/system itself
+				$cmd->run(null, false); // false = dont set current user as modifier, as job is run by the queue/system itself
 			}
 			catch (Exception $e) {	// we need to mark that command as failed, to prevent further execution
 				admin_cmd::$sql->init($job);
 				admin_cmd::$sql->save(array(
 					'status' => admin_cmd::failed,
-					'error'  => lang('Unknown command %1!',$job['type']),
+					'error'  => lang('Unknown command %1!', $job['type']),
 					'errno'  => 0,
 					'data'   => self::mask_passwords($job['data']),
 				));
@@ -894,9 +894,9 @@ 
 		admin_cmd::_instanciate_remote();
 
 		$sites = array(lang('local'));
-		if ($remote = admin_cmd::$remote->query_list('remote_name','remote_id'))
+		if ($remote = admin_cmd::$remote->query_list('remote_name', 'remote_id'))
 		{
-			$sites = array_merge($sites,$remote);
+			$sites = array_merge($sites, $remote);
 		}
 		return $sites;
 	}
@@ -909,11 +909,11 @@ 
 	 * @param array &$readonlys
 	 * @return int
 	 */
-	static function get_remotes($query,&$rows,&$readonlys)
+	static function get_remotes($query, &$rows, &$readonlys)
 	{
 		admin_cmd::_instanciate_remote();
 
-		return admin_cmd::$remote->get_rows($query,$rows,$readonlys);
+		return admin_cmd::$remote->get_rows($query, $rows, $readonlys);
 	}
 
 	/**
@@ -941,7 +941,7 @@ 
 
 		if ($data['install_id'] && $data['config_passwd'])	// calculate hash
 		{
-			$data['remote_hash'] = self::remote_hash($data['install_id'],$data['config_passwd']);
+			$data['remote_hash'] = self::remote_hash($data['install_id'], $data['config_passwd']);
 		}
 		elseif (!$data['remote_hash'] && !($data['install_id'] && $data['config_passwd']))
 		{
@@ -953,12 +953,12 @@ 
 		// check if a unique key constrain would be violated by saving the entry
 		if (($num = admin_cmd::$remote->not_unique()))
 		{
-			$col = admin_cmd::$remote->table_def['uc'][$num-1];	// $num is 1 based!
-			throw new egw_exception_db_not_unique(lang('Value for column %1 is not unique!',$this->table_name.'.'.$col),$num);
+			$col = admin_cmd::$remote->table_def['uc'][$num - 1]; // $num is 1 based!
+			throw new egw_exception_db_not_unique(lang('Value for column %1 is not unique!', $this->table_name.'.'.$col), $num);
 		}
 		if (admin_cmd::$remote->save() != 0)
 		{
-			throw new egw_exception_db(lang('Error saving to db:').' '.$this->sql->db->Error.' ('.$this->sql->db->Errno.')',$this->sql->db->Errno);
+			throw new egw_exception_db(lang('Error saving to db:').' '.$this->sql->db->Error.' ('.$this->sql->db->Errno.')', $this->sql->db->Errno);
 		}
 		return admin_cmd::$remote->data['remote_id'];
 	}
@@ -970,11 +970,11 @@ 
 	 * @param string $config_passwd
 	 * @return string 32char md5 hash
 	 */
-	static function remote_hash($install_id,$config_passwd)
+	static function remote_hash($install_id, $config_passwd)
 	{
 		if (empty($config_passwd) || !self::is_md5($install_id))
 		{
-			throw new egw_exception_wrong_parameter(empty($config_passwd)?'Empty config password':'install_id no md5 hash');
+			throw new egw_exception_wrong_parameter(empty($config_passwd) ? 'Empty config password' : 'install_id no md5 hash');
 		}
 		if (!self::is_md5($config_passwd)) $config_passwd = md5($config_passwd);
 
@@ -1004,7 +1004,7 @@ 
 	 */
 	static function is_md5($str)
 	{
-		return preg_match('/^[0-9a-f]{32}$/',$str);
+		return preg_match('/^[0-9a-f]{32}$/', $str);
 	}
 
 	/**
@@ -1021,25 +1021,25 @@ 
 	 * @param string $config_passwd of the current domain
 	 * @throws egw_exception_no_permission
 	 */
-	function check_remote_access($secret,$config_passwd)
+	function check_remote_access($secret, $config_passwd)
 	{
 		// as a security measure remote administration need to be enabled under Admin > Site configuration
-		list(,$remote_admin_install_id) = explode('-',$this->uid);
-		$allowed_remote_admin_ids = $GLOBALS['egw_info']['server']['allow_remote_admin'] ? explode(',',$GLOBALS['egw_info']['server']['allow_remote_admin']) : array();
+		list(,$remote_admin_install_id) = explode('-', $this->uid);
+		$allowed_remote_admin_ids = $GLOBALS['egw_info']['server']['allow_remote_admin'] ? explode(',', $GLOBALS['egw_info']['server']['allow_remote_admin']) : array();
 
 		// to authenticate with the installation we use a secret, which is a md5 hash build from the uid
 		// of the command (to not allow to send new commands with an earsdroped secret) and the md5 hash
 		// of the md5 hash of the config password and the install_id (egw_admin_remote.remote_hash)
-		if (is_null($config_passwd) || is_numeric($this->uid) || !in_array($remote_admin_install_id,$allowed_remote_admin_ids) ||
-			$secret != ($md5=md5($this->uid.$this->remote_hash($GLOBALS['egw_info']['server']['install_id'],$config_passwd))))
+		if (is_null($config_passwd) || is_numeric($this->uid) || !in_array($remote_admin_install_id, $allowed_remote_admin_ids) ||
+			$secret != ($md5 = md5($this->uid.$this->remote_hash($GLOBALS['egw_info']['server']['install_id'], $config_passwd))))
 		{
 			//die("secret='$secret' != '$md5', is_null($config_passwd)=".is_null($config_passwd).", uid=$this->uid, remote_install_id=$remote_admin_install_id, allowed: ".implode(', ',$allowed_remote_admin_ids));
 			$msg = lang('Permission denied!');
-			if (!in_array($remote_admin_install_id,$allowed_remote_admin_ids))
+			if (!in_array($remote_admin_install_id, $allowed_remote_admin_ids))
 			{
 				$msg .= "\n".lang('Remote administration need to be enabled in the remote instance under Admin > Site configuration!');
 			}
-			throw new egw_exception_no_permission($msg,0);
+			throw new egw_exception_no_permission($msg, 0);
 		}
 	}
 
@@ -1049,21 +1049,21 @@ 
 	 * @param int $len=16
 	 * @return string
 	 */
-	static function randomstring($len=16)
+	static function randomstring($len = 16)
 	{
 		static $usedchars = array(
-			'0','1','2','3','4','5','6','7','8','9','a','b','c','d','e','f',
-			'g','h','i','j','k','l','m','n','o','p','q','r','s','t','u','v',
-			'w','x','y','z','A','B','C','D','E','F','G','H','I','J','K','L',
-			'M','N','O','P','Q','R','S','T','U','V','W','X','Y','Z',
-			'@','!','$','%','&','/','(',')','=','?',';',':','#','_','-','<',
-			'>','|','{','[',']','}',	// dont add \,'" as we have problems dealing with them
+			'0', '1', '2', '3', '4', '5', '6', '7', '8', '9', 'a', 'b', 'c', 'd', 'e', 'f',
+			'g', 'h', 'i', 'j', 'k', 'l', 'm', 'n', 'o', 'p', 'q', 'r', 's', 't', 'u', 'v',
+			'w', 'x', 'y', 'z', 'A', 'B', 'C', 'D', 'E', 'F', 'G', 'H', 'I', 'J', 'K', 'L',
+			'M', 'N', 'O', 'P', 'Q', 'R', 'S', 'T', 'U', 'V', 'W', 'X', 'Y', 'Z',
+			'@', '!', '$', '%', '&', '/', '(', ')', '=', '?', ';', ':', '#', '_', '-', '<',
+			'>', '|', '{', '[', ']', '}', // dont add \,'" as we have problems dealing with them
 		);
 
 		$str = '';
-		for($i=0; $i < $len; $i++)
+		for ($i = 0; $i < $len; $i++)
 		{
-			$str .= $usedchars[mt_rand(0,count($usedchars)-1)];
+			$str .= $usedchars[mt_rand(0, count($usedchars) - 1)];
 		}
 		return $str;
 	}

admin/inc/class.admin_import_groups_csv.inc.php

Spacing +29 added lines, -29 removed lines

@@ -15,15 +15,15 @@ 
 /**
  * class import_csv for admin (groups)
  */
-class admin_import_groups_csv implements importexport_iface_import_plugin  {
+class admin_import_groups_csv implements importexport_iface_import_plugin {
 
 	private static $plugin_options = array(
-		'fieldsep', 		// char
-		'charset', 		// string
+		'fieldsep', // char
+		'charset', // string
 		'num_header_lines', // int number of header lines
 		'field_conversion', // array( $csv_col_num => conversion)
-		'field_mapping',	// array( $csv_col_num => adb_filed)
-		'conditions',		/* => array containing condition arrays:
+		'field_mapping', // array( $csv_col_num => adb_filed)
+		'conditions', /* => array containing condition arrays:
 				'type' => exists, // exists
 				'string' => '#kundennummer',
 				'true' => array(
@@ -40,14 +40,14 @@ 
 	/**
 	 * actions which could be done to data entries
 	 */
-	protected static $actions = array( 'none', 'update', 'create', 'delete');
+	protected static $actions = array('none', 'update', 'create', 'delete');
 
 	/**
 	 * conditions for actions
 	 *
 	 * @var array
 	 */
-	protected static $conditions = array( 'exists' );
+	protected static $conditions = array('exists');
 
 	/**
 	 * @var definition
@@ -80,8 +80,8 @@ 
 	 * @param string $_charset
 	 * @param definition $_definition
 	 */
-	public function import( $_stream, importexport_definition $_definition ) {
-		$import_csv = new importexport_import_csv( $_stream, array(
+	public function import($_stream, importexport_definition $_definition) {
+		$import_csv = new importexport_import_csv($_stream, array(
 			'fieldsep' => $_definition->plugin_options['fieldsep'],
 			'charset' => $_definition->plugin_options['charset'],
 		));
@@ -89,7 +89,7 @@ 
 		$this->definition = $_definition;
 
 		// dry run?
-		$this->dry_run = isset( $_definition->plugin_options['dry_run'] ) ? $_definition->plugin_options['dry_run'] :  false;
+		$this->dry_run = isset($_definition->plugin_options['dry_run']) ? $_definition->plugin_options['dry_run'] : false;
 
 		// set FieldMapping.
 		$import_csv->mapping = $_definition->plugin_options['field_mapping'];
@@ -98,9 +98,9 @@ 
 		$import_csv->conversion = $_definition->plugin_options['field_conversion'];
 
 		//check if file has a header lines
-		if ( isset( $_definition->plugin_options['num_header_lines'] ) && $_definition->plugin_options['num_header_lines'] > 0) {
+		if (isset($_definition->plugin_options['num_header_lines']) && $_definition->plugin_options['num_header_lines'] > 0) {
 			$import_csv->skip_records($_definition->plugin_options['num_header_lines']);
-		} elseif(isset($_definition->plugin_options['has_header_line']) && $_definition->plugin_options['has_header_line']) {
+		} elseif (isset($_definition->plugin_options['has_header_line']) && $_definition->plugin_options['has_header_line']) {
 			// First method is preferred
 			$import_csv->skip_records(1);
 		}
@@ -112,22 +112,22 @@ 
 		// Failures
 		$this->errors = array();
 
-		while ( $record = $import_csv->get_record() ) {
+		while ($record = $import_csv->get_record()) {
 			$success = false;
 			// don't import empty records
-			if( count( array_unique( $record ) ) < 2 ) continue;
+			if (count(array_unique($record)) < 2) continue;
 
 			importexport_import_csv::convert($record, admin_egw_group_record::$types, 'admin');
 
-			if ( $_definition->plugin_options['conditions'] ) {
-				foreach ( $_definition->plugin_options['conditions'] as $condition ) {
-					switch ( $condition['type'] ) {
+			if ($_definition->plugin_options['conditions']) {
+				foreach ($_definition->plugin_options['conditions'] as $condition) {
+					switch ($condition['type']) {
 						// exists
 						case 'exists' :
 							$accounts = array();
 
 							// Skip the search if the field is empty
-							if($record[$condition['string']] !== '') {
+							if ($record[$condition['string']] !== '') {
 
 								$accounts = $GLOBALS['egw']->accounts->search(array(
 									'type' => 'groups',
@@ -136,25 +136,25 @@ 
 								));
 							}
 							// Search looks in the given field, but doesn't do an exact match
-							foreach ( (array)$accounts as $key => $account )
+							foreach ((array)$accounts as $key => $account)
 							{
-								if($account[$condition['string']] != $record[$condition['string']]) unset($accounts[$key]);
+								if ($account[$condition['string']] != $record[$condition['string']]) unset($accounts[$key]);
 							}
-							if ( is_array( $accounts ) && count( $accounts ) >= 1 ) {
+							if (is_array($accounts) && count($accounts) >= 1) {
 								$account = current($accounts);
 								// apply action to all contacts matching this exists condition
 								$action = $condition['true'];
-								foreach ( (array)$accounts as $account ) {
+								foreach ((array)$accounts as $account) {
 									// Read full account, and copy needed info for accounts->save()
 									$account = $GLOBALS['egw']->accounts->read($account['account_id']);
 									$record['account_id'] = $account['account_id'];
 									$record['account_firstname'] = $account['account_firstname'];
 									$record['account_lastname'] = $account['account_lastname'];
-									$success = $this->action(  $action['action'], $record, $import_csv->get_current_position() );
+									$success = $this->action($action['action'], $record, $import_csv->get_current_position());
 								}
 							} else {
 								$action = $condition['false'];
-								$success = ($this->action(  $action['action'], $record, $import_csv->get_current_position() ));
+								$success = ($this->action($action['action'], $record, $import_csv->get_current_position()));
 							}
 							break;
 
@@ -167,9 +167,9 @@ 
 				}
 			} else {
 				// unconditional insert
-				$success = $this->action( 'insert', $record, $import_csv->get_current_position() );
+				$success = $this->action('insert', $record, $import_csv->get_current_position());
 			}
-			if($success) $count++;
+			if ($success) $count++;
 		}
 		return $count;
 	}
@@ -181,18 +181,18 @@ 
 	 * @param array $_data contact data for the action
 	 * @return bool success or not
 	 */
-	private function action ( $_action, $_data, $record_num = 0 ) {
+	private function action($_action, $_data, $record_num = 0) {
 		switch ($_action) {
 			case 'none' :
 				return true;
 			case 'update' :
 			case 'create' :
-				if(count($_data['account_members']) < 1) {
+				if (count($_data['account_members']) < 1) {
 					$this->errors[$record_num] = lang('You must select at least one group member.');
 					return false;
 				}
 				$command = new admin_cmd_edit_group($_action == 'create' ? false : $_data['account_lid'], $_data);
-				if($this->dry_run) {
+				if ($this->dry_run) {
 					$this->results[$_action]++;
 					return true;
 				}

Doc Comments +1 added lines, -2 removed lines

@@ -104,8 +104,7 @@
 	/**
 	 * imports entries according to given definition object.
 	 * @param resource $_stream
-	 * @param string $_charset
-	 * @param definition $_definition
+	 * @param importexport_definition $_definition
 	 */
 	public function import( $_stream, importexport_definition $_definition ) {
 		$import_csv = new importexport_import_csv( $_stream, array(

Indentation +28 added lines, -28 removed lines

@@ -69,9 +69,9 @@ 
 	protected $errors = array();
 
 	/**
-         * List of actions, and how many times that action was taken
-         */
-        protected $results = array();
+	 * List of actions, and how many times that action was taken
+	 */
+		protected $results = array();
 
 	/**
 	 * imports entries according to given definition object.
@@ -262,39 +262,39 @@ 
 	}
 
 	/**
-	* Returns warnings that were encountered during importing
-	* Maximum of one warning message per record, but you can concatenate them if you need to
-	*
-	* @return Array (
-	*       record_# => warning message
-	*       )
-	*/
+	 * Returns warnings that were encountered during importing
+	 * Maximum of one warning message per record, but you can concatenate them if you need to
+	 *
+	 * @return Array (
+	 *       record_# => warning message
+	 *       )
+	 */
 	public function get_warnings() {
 		return $this->warnings;
 	}
 
 	/**
-        * Returns errors that were encountered during importing
-        * Maximum of one error message per record, but you can append if you need to
-        *
-        * @return Array (
-        *       record_# => error message
-        *       )
-        */
-        public function get_errors() {
+	 * Returns errors that were encountered during importing
+	 * Maximum of one error message per record, but you can append if you need to
+	 *
+	 * @return Array (
+	 *       record_# => error message
+	 *       )
+	 */
+		public function get_errors() {
 		return $this->errors;
 	}
 
 	/**
-        * Returns a list of actions taken, and the number of records for that action.
-        * Actions are things like 'insert', 'update', 'delete', and may be different for each plugin.
-        *
-        * @return Array (
-        *       action => record count
-        * )
-        */
-        public function get_results() {
-                return $this->results;
-        }
+	 * Returns a list of actions taken, and the number of records for that action.
+	 * Actions are things like 'insert', 'update', 'delete', and may be different for each plugin.
+	 *
+	 * @return Array (
+	 *       action => record count
+	 * )
+	 */
+		public function get_results() {
+				return $this->results;
+		}
 } // end of iface_export_plugin
 ?>

Braces +71 added lines, -30 removed lines

@@ -14,7 +14,8 @@ 
 /**
  * class import_csv for admin (groups)
  */
-class admin_import_groups_csv implements importexport_iface_import_plugin  {
+class admin_import_groups_csv implements importexport_iface_import_plugin
+{
 
 	private static $plugin_options = array(
 		'fieldsep', 		// char
@@ -79,7 +80,8 @@ 
 	 * @param string $_charset
 	 * @param definition $_definition
 	 */
-	public function import( $_stream, importexport_definition $_definition ) {
+	public function import( $_stream, importexport_definition $_definition )
+	{
 		$import_csv = new importexport_import_csv( $_stream, array(
 			'fieldsep' => $_definition->plugin_options['fieldsep'],
 			'charset' => $_definition->plugin_options['charset'],
@@ -97,9 +99,12 @@ 
 		$import_csv->conversion = $_definition->plugin_options['field_conversion'];
 
 		//check if file has a header lines
-		if ( isset( $_definition->plugin_options['num_header_lines'] ) && $_definition->plugin_options['num_header_lines'] > 0) {
+		if ( isset( $_definition->plugin_options['num_header_lines'] ) && $_definition->plugin_options['num_header_lines'] > 0)
+		{
 			$import_csv->skip_records($_definition->plugin_options['num_header_lines']);
-		} elseif(isset($_definition->plugin_options['has_header_line']) && $_definition->plugin_options['has_header_line']) {
+		}
+		elseif(isset($_definition->plugin_options['has_header_line']) && $_definition->plugin_options['has_header_line'])
+		{
 			// First method is preferred
 			$import_csv->skip_records(1);
 		}
@@ -111,22 +116,30 @@ 
 		// Failures
 		$this->errors = array();
 
-		while ( $record = $import_csv->get_record() ) {
+		while ( $record = $import_csv->get_record() )
+		{
 			$success = false;
 			// don't import empty records
-			if( count( array_unique( $record ) ) < 2 ) continue;
+			if( count( array_unique( $record ) ) < 2 )
+			{
+				continue;
+			}
 
 			importexport_import_csv::convert($record, admin_egw_group_record::$types, 'admin');
 
-			if ( $_definition->plugin_options['conditions'] ) {
-				foreach ( $_definition->plugin_options['conditions'] as $condition ) {
-					switch ( $condition['type'] ) {
+			if ( $_definition->plugin_options['conditions'] )
+			{
+				foreach ( $_definition->plugin_options['conditions'] as $condition )
+				{
+					switch ( $condition['type'] )
+					{
 						// exists
 						case 'exists' :
 							$accounts = array();
 
 							// Skip the search if the field is empty
-							if($record[$condition['string']] !== '') {
+							if($record[$condition['string']] !== '')
+							{
 							
 								$accounts = $GLOBALS['egw']->accounts->search(array(
 									'type' => 'groups',
@@ -137,13 +150,18 @@ 
 							// Search looks in the given field, but doesn't do an exact match
 							foreach ( (array)$accounts as $key => $account )
 							{
-								if($account[$condition['string']] != $record[$condition['string']]) unset($accounts[$key]);
+								if($account[$condition['string']] != $record[$condition['string']])
+								{
+									unset($accounts[$key]);
+								}
 							}
-							if ( is_array( $accounts ) && count( $accounts ) >= 1 ) {
+							if ( is_array( $accounts ) && count( $accounts ) >= 1 )
+							{
 								$account = current($accounts);
 								// apply action to all contacts matching this exists condition
 								$action = $condition['true'];
-								foreach ( (array)$accounts as $account ) {
+								foreach ( (array)$accounts as $account )
+								{
 									// Read full account, and copy needed info for accounts->save()
 									$account = $GLOBALS['egw']->accounts->read($account['account_id']);
 									$record['account_id'] = $account['account_id'];
@@ -151,7 +169,9 @@ 
 									$record['account_lastname'] = $account['account_lastname'];
 									$success = $this->action(  $action['action'], $record, $import_csv->get_current_position() );
 								}
-							} else {
+							}
+							else
+							{
 								$action = $condition['false'];
 								$success = ($this->action(  $action['action'], $record, $import_csv->get_current_position() ));
 							}
@@ -162,13 +182,21 @@ 
 							die('condition / action not supported!!!');
 							break;
 					}
-					if ($action['last']) break;
+					if ($action['last'])
+					{
+						break;
+					}
 				}
-			} else {
+			}
+			else
+			{
 				// unconditional insert
 				$success = $this->action( 'insert', $record, $import_csv->get_current_position() );
 			}
-			if($success) $count++;
+			if($success)
+			{
+				$count++;
+			}
 		}
 		return $count;
 	}
@@ -180,24 +208,29 @@ 
 	 * @param array $_data contact data for the action
 	 * @return bool success or not
 	 */
-	private function action ( $_action, $_data, $record_num = 0 ) {
-		switch ($_action) {
+	private function action ( $_action, $_data, $record_num = 0 )
+	{
+		switch ($_action)
+		{
 			case 'none' :
 				return true;
 			case 'update' :
 			case 'create' :
-				if(count($_data['account_members']) < 1) {
+				if(count($_data['account_members']) < 1)
+				{
 					$this->errors[$record_num] = lang('You must select at least one group member.');
 					return false;
 				}
 				$command = new admin_cmd_edit_group($_action == 'create' ? false : $_data['account_lid'], $_data);
-				if($this->dry_run) {
+				if($this->dry_run)
+				{
 					$this->results[$_action]++;
 					return true;
 				}
 				try {
 					$command->run();
-				} catch (Exception $e) {
+				}
+				catch (Exception $e) {
 					$this->errors[$record_num] = $e->getMessage();
 					return false;
 				}
@@ -214,7 +247,8 @@ 
 	 *
 	 * @return string name
 	 */
-	public static function get_name() {
+	public static function get_name()
+	{
 		return lang('Group CSV import');
 	}
 
@@ -223,7 +257,8 @@ 
 	 *
 	 * @return string descriprion
 	 */
-	public static function get_description() {
+	public static function get_description()
+	{
 		return lang("Creates / updates user groups from CSV file");
 	}
 
@@ -232,7 +267,8 @@ 
 	 *
 	 * @return string suffix (comma seperated)
 	 */
-	public static function get_filesuffix() {
+	public static function get_filesuffix()
+	{
 		return 'csv';
 	}
 
@@ -248,7 +284,8 @@ 
 	 * 		preserv		=> array,
 	 * )
 	 */
-	public function get_options_etpl() {
+	public function get_options_etpl()
+	{
 		// lets do it!
 	}
 
@@ -257,7 +294,8 @@ 
 	 *
 	 * @return string etemplate name
 	 */
-	public function get_selectors_etpl() {
+	public function get_selectors_etpl()
+	{
 		// lets do it!
 	}
 
@@ -269,7 +307,8 @@ 
 	*       record_# => warning message
 	*       )
 	*/
-	public function get_warnings() {
+	public function get_warnings()
+	{
 		return $this->warnings;
 	}
 
@@ -281,7 +320,8 @@ 
         *       record_# => error message
         *       )
         */
-        public function get_errors() {
+        public function get_errors()
+        {
 		return $this->errors;
 	}
 
@@ -293,7 +333,8 @@ 
         *       action => record count
         * )
         */
-        public function get_results() {
+        public function get_results()
+        {
                 return $this->results;
         }
 } // end of iface_export_plugin

admin/inc/class.admin_wizard_import_users_csv.inc.php

Spacing +1 added lines, -1 removed lines

@@ -59,7 +59,7 @@
 	function wizard_step50(&$content, &$sel_options, &$readonlys, &$preserv)
 	{
 		$result = parent::wizard_step50($content, $sel_options, $readonlys, $preserv);
-		$content['msg'] .= "\n*" ;
+		$content['msg'] .= "\n*";
 		
 		return $result;
 	}

timesheet/setup/setup.inc.php

Spacing +3 added lines, -3 removed lines

@@ -13,13 +13,13 @@ 
 
 if (!defined('TIMESHEET_APP'))
 {
-	define('TIMESHEET_APP','timesheet');
+	define('TIMESHEET_APP', 'timesheet');
 }
 
 $setup_info[TIMESHEET_APP]['name']      = TIMESHEET_APP;
 $setup_info[TIMESHEET_APP]['version']   = '16.1';
 $setup_info[TIMESHEET_APP]['app_order'] = 5;
-$setup_info[TIMESHEET_APP]['tables']    = array('egw_timesheet','egw_timesheet_extra');
+$setup_info[TIMESHEET_APP]['tables']    = array('egw_timesheet', 'egw_timesheet_extra');
 $setup_info[TIMESHEET_APP]['enable']    = 1;
 $setup_info[TIMESHEET_APP]['index']     = 'timesheet.timesheet_ui.index&ajax=true';
 
@@ -28,7 +28,7 @@ 
 	'name'  => 'Ralf Becker',
 	'email' => 'RalfBecker@outdoor-training.de'
 );
-$setup_info[TIMESHEET_APP]['license']  = 'GPL';
+$setup_info[TIMESHEET_APP]['license'] = 'GPL';
 $setup_info[TIMESHEET_APP]['description'] =
 'Tracking times and other activities for the Projectmanager.';
 $setup_info[TIMESHEET_APP]['note'] =

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -37,11 +37,11 @@
 /* Dependencies for this app to work */
 $setup_info['importexport']['depends'][] = array(
 	 'appname' => 'phpgwapi',
-	 'versions' => Array('14.1')
+	 'versions' => array('14.1')
 );
 $setup_info['importexport']['depends'][] = array(
 	 'appname' => 'etemplate',
-	 'versions' => Array('14.1')
+	 'versions' => array('14.1')
 );
 
 // installation checks for importexport

timesheet/setup/tables_update.inc.php

Spacing +12 added lines, -12 removed lines

@@ -15,7 +15,7 @@ 
 
 function timesheet_upgrade0_1_001()
 {
-	$GLOBALS['egw_setup']->oProc->AddColumn('egw_timesheet','pl_id',array(
+	$GLOBALS['egw_setup']->oProc->AddColumn('egw_timesheet', 'pl_id', array(
 		'type' => 'int',
 		'precision' => '4',
 		'default' => '0'
@@ -27,13 +27,13 @@ 
 
 function timesheet_upgrade0_2_001()
 {
-	$GLOBALS['egw_setup']->oProc->CreateTable('egw_timesheet_extra',array(
+	$GLOBALS['egw_setup']->oProc->CreateTable('egw_timesheet_extra', array(
 		'fd' => array(
-			'ts_id' => array('type' => 'int','precision' => '4','nullable' => False),
-			'ts_extra_name' => array('type' => 'varchar','precision' => '32','nullable' => False),
-			'ts_extra_value' => array('type' => 'varchar','precision' => '255','nullable' => False,'default' => '')
+			'ts_id' => array('type' => 'int', 'precision' => '4', 'nullable' => False),
+			'ts_extra_name' => array('type' => 'varchar', 'precision' => '32', 'nullable' => False),
+			'ts_extra_value' => array('type' => 'varchar', 'precision' => '255', 'nullable' => False, 'default' => '')
 		),
-		'pk' => array('ts_id','ts_extra_name'),
+		'pk' => array('ts_id', 'ts_extra_name'),
 		'fk' => array(),
 		'ix' => array(),
 		'uc' => array()
@@ -52,7 +52,7 @@ 
 function timesheet_upgrade1_4()
 {
 	// delete empty cf's generated by 1.4
-	$GLOBALS['egw_setup']->db->delete('egw_timesheet_extra',"ts_extra_value=''",__LINE__,__FILE__,'timesheet');
+	$GLOBALS['egw_setup']->db->delete('egw_timesheet_extra', "ts_extra_value=''", __LINE__, __FILE__, 'timesheet');
 
 	return $GLOBALS['setup_info']['timesheet']['currentver'] = '1.6';
 }
@@ -60,12 +60,12 @@ 
 
 function timesheet_upgrade1_6()
 {
-	$GLOBALS['egw_setup']->oProc->AddColumn('egw_timesheet','ts_status',array(
+	$GLOBALS['egw_setup']->oProc->AddColumn('egw_timesheet', 'ts_status', array(
 		'type' => 'int',
 		'precision' => '4'
 	));
 
-	$GLOBALS['egw_setup']->oProc->CreateIndex('egw_timesheet','ts_status');
+	$GLOBALS['egw_setup']->oProc->CreateIndex('egw_timesheet', 'ts_status');
 
 	return $GLOBALS['setup_info']['timesheet']['currentver'] = '1.7.001';
 }
@@ -92,12 +92,12 @@ 
  */
 function timesheet_upgrade1_9_001()
 {
-	$GLOBALS['egw_setup']->oProc->AlterColumn('egw_timesheet','ts_project',array(
+	$GLOBALS['egw_setup']->oProc->AlterColumn('egw_timesheet', 'ts_project', array(
 		'type' => 'varchar',
 		'precision' => '255',
 		'comment' => 'project title'
 	));
-	$GLOBALS['egw_setup']->oProc->AlterColumn('egw_timesheet','ts_title',array(
+	$GLOBALS['egw_setup']->oProc->AlterColumn('egw_timesheet', 'ts_title', array(
 		'type' => 'varchar',
 		'precision' => '255',
 		'nullable' => False,
@@ -108,7 +108,7 @@ 
 	// returns NULL, if there are no rows!
 	if ((int)$max_description_length <= 16384 && $GLOBALS['egw_setup']->oProc->max_varchar_length >= 16384)
 	{
-		$GLOBALS['egw_setup']->oProc->AlterColumn('egw_timesheet','ts_description',array(
+		$GLOBALS['egw_setup']->oProc->AlterColumn('egw_timesheet', 'ts_description', array(
 			'type' => 'varchar',
 			'precision' => '16384',
 			'comment' => 'description of the timesheet entry'

timesheet/setup/default_records.inc.php

Spacing +3 added lines, -3 removed lines

@@ -9,7 +9,7 @@ 
  * @version $Id$
  */
 
-foreach(array(
+foreach (array(
 	'history'     => 'history',
 ) as $name => $value)
 {
@@ -19,10 +19,10 @@ 
 			'config_app' => 'timesheet',
 			'config_name' => $name,
 			'config_value' => $value,
-		),array(
+		), array(
 			'config_app' => 'timesheet',
 			'config_name' => $name,
-		),__LINE__,__FILE__
+		), __LINE__, __FILE__
 	);
 }
 

timesheet/inc/class.timesheet_wizard_import_csv.inc.php

Indentation +6 added lines, -6 removed lines

@@ -35,9 +35,9 @@ 
 		$this->mapping_fields = array('ts_id' => lang('Timesheet ID')) + $bo->field2label;
 
 		// These aren't in the list
-                $this->mapping_fields += array(
-                        'ts_modified'   => lang('Modified'),
-                );
+				$this->mapping_fields += array(
+						'ts_modified'   => lang('Modified'),
+				);
 
 		// List each custom field
 		unset($this->mapping_fields['customfields']);
@@ -113,9 +113,9 @@ 
 				);
 			}
 			$sel_options = array(
-                                'translate_status'	=> $options + array($set_to => $ui->status_labels),
-                                'translate_cat_id'	=> $options + array($set_to => $cat_list),
-                        );
+								'translate_status'	=> $options + array($set_to => $ui->status_labels),
+								'translate_cat_id'	=> $options + array($set_to => $cat_list),
+						);
 			$preserv = $content;
 			foreach($sel_options as $field => $options) {
 				if(!array_key_exists($field,$content)) $content[$field] = $content['plugin_options'][$field];

Braces +26 added lines, -10 removed lines

@@ -42,7 +42,8 @@ 
 		// List each custom field
 		unset($this->mapping_fields['customfields']);
 		$custom = Api\Storage\Customfields::get('timesheet');
-		foreach($custom as $name => $data) {
+		foreach($custom as $name => $data)
+		{
 			$this->mapping_fields['#'.$name] = $data['label'];
 		}
 
@@ -72,7 +73,10 @@ 
 
 	function wizard_step45(&$content, &$sel_options, &$readonlys, &$preserv)
 	{
-		if($this->debug) error_log(__METHOD__.'->$content '.print_r($content,true));
+		if($this->debug)
+		{
+			error_log(__METHOD__.'->$content '.print_r($content,true));
+		}
 
 		// return from step45
 		if ($content['step'] == 'wizard_step45')
@@ -104,7 +108,8 @@ 
 			$set_to = lang('Set to') . ':';
 			$categories = new Api\Categories('','timesheet');
 			$cat_list = array();
-			foreach((array)$categories->return_sorted_array(0,False,'','','',true) as $cat) {
+			foreach((array)$categories->return_sorted_array(0,False,'','','',true) as $cat)
+			{
 				$s = str_repeat(' ',$cat['level']) . stripslashes($cat['name']);
 
 				$cat_list[$cat['id']] = empty($cat['description']) ? $s : array(
@@ -117,8 +122,12 @@ 
                                 'translate_cat_id'	=> $options + array($set_to => $cat_list),
                         );
 			$preserv = $content;
-			foreach($sel_options as $field => $options) {
-				if(!array_key_exists($field,$content)) $content[$field] = $content['plugin_options'][$field];
+			foreach($sel_options as $field => $options)
+			{
+				if(!array_key_exists($field,$content))
+				{
+					$content[$field] = $content['plugin_options'][$field];
+				}
 			}
 			unset ($preserv['button']);
 			return $this->step_templates['wizard_step45'];
@@ -134,7 +143,10 @@ 
 	
 	function wizard_step60(&$content, &$sel_options, &$readonlys, &$preserv)
 	{
-		if($this->debug) error_log(__METHOD__.'->$content '.print_r($content,true));
+		if($this->debug)
+		{
+			error_log(__METHOD__.'->$content '.print_r($content,true));
+		}
 		unset($content['no_owner_map']);
 
 		// return from step60
@@ -158,17 +170,21 @@ 
 			$content['msg'] = $this->steps['wizard_step60'];
 			$content['step'] = 'wizard_step60';
 			$preserv = $content;
-			if(!array_key_exists($content['record_owner']) && $content['plugin_options']) {
+			if(!array_key_exists($content['record_owner']) && $content['plugin_options'])
+			{
 				$content['record_owner'] = $content['plugin_options']['record_owner'];
 			}
-			if(!array_key_exists($content['owner_from_csv']) && $content['plugin_options']) {
+			if(!array_key_exists($content['owner_from_csv']) && $content['plugin_options'])
+			{
 				$content['owner_from_csv'] = $content['plugin_options']['owner_from_csv'];
 			}
-			if(!array_key_exists($content['change_owner']) && $content['plugin_options']) {
+			if(!array_key_exists($content['change_owner']) && $content['plugin_options'])
+			{
 				$content['change_owner'] = $content['plugin_options']['change_owner'];
 			}
 
-			if(!in_array('ts_owner', $content['field_mapping'])) {
+			if(!in_array('ts_owner', $content['field_mapping']))
+			{
 				$content['no_owner_map'] = true;
 			}
 

Spacing +19 added lines, -19 removed lines

@@ -40,7 +40,7 @@ 
 		// List each custom field
 		unset($this->mapping_fields['customfields']);
 		$custom = config::get_customfields('timesheet');
-		foreach($custom as $name => $data) {
+		foreach ($custom as $name => $data) {
 			$this->mapping_fields['#'.$name] = $data['label'];
 		}
 
@@ -70,7 +70,7 @@ 
 
 	function wizard_step45(&$content, &$sel_options, &$readonlys, &$preserv)
 	{
-		if($this->debug) error_log(__METHOD__.'->$content '.print_r($content,true));
+		if ($this->debug) error_log(__METHOD__.'->$content '.print_r($content, true));
 
 		// return from step45
 		if ($content['step'] == 'wizard_step45')
@@ -78,13 +78,13 @@ 
 			switch (array_search('pressed', $content['button']))
 			{
 				case 'next':
-					return $GLOBALS['egw']->importexport_definitions_ui->get_step($content['step'],1);
+					return $GLOBALS['egw']->importexport_definitions_ui->get_step($content['step'], 1);
 				case 'previous' :
-					return $GLOBALS['egw']->importexport_definitions_ui->get_step($content['step'],-1);
+					return $GLOBALS['egw']->importexport_definitions_ui->get_step($content['step'], -1);
 				case 'finish':
 					return 'wizard_finish';
 				default :
-					return $this->wizard_step45($content,$sel_options,$readonlys,$preserv);
+					return $this->wizard_step45($content, $sel_options, $readonlys, $preserv);
 			}
 		}
 		// init step45
@@ -99,11 +99,11 @@ 
 				'~skip~' => lang('Skip record'),
 				'add' => lang('Add'),
 			);
-			$set_to = lang('Set to') . ':';
-			$categories = new categories('','timesheet');
+			$set_to = lang('Set to').':';
+			$categories = new categories('', 'timesheet');
 			$cat_list = array();
-			foreach((array)$categories->return_sorted_array(0,False,'','','',true) as $cat) {
-				$s = str_repeat(' ',$cat['level']) . stripslashes($cat['name']);
+			foreach ((array)$categories->return_sorted_array(0, False, '', '', '', true) as $cat) {
+				$s = str_repeat(' ', $cat['level']).stripslashes($cat['name']);
 
 				$cat_list[$cat['id']] = empty($cat['description']) ? $s : array(
 					'label' => $s,
@@ -115,8 +115,8 @@ 
                                 'translate_cat_id'	=> $options + array($set_to => $cat_list),
                         );
 			$preserv = $content;
-			foreach($sel_options as $field => $options) {
-				if(!array_key_exists($field,$content)) $content[$field] = $content['plugin_options'][$field];
+			foreach ($sel_options as $field => $options) {
+				if (!array_key_exists($field, $content)) $content[$field] = $content['plugin_options'][$field];
 			}
 			unset ($preserv['button']);
 			return $this->step_templates['wizard_step45'];
@@ -132,7 +132,7 @@ 
 	
 	function wizard_step60(&$content, &$sel_options, &$readonlys, &$preserv)
 	{
-		if($this->debug) error_log(__METHOD__.'->$content '.print_r($content,true));
+		if ($this->debug) error_log(__METHOD__.'->$content '.print_r($content, true));
 		unset($content['no_owner_map']);
 
 		// return from step60
@@ -141,13 +141,13 @@ 
 			switch (array_search('pressed', $content['button']))
 			{
 				case 'next':
-					return $GLOBALS['egw']->importexport_definitions_ui->get_step($content['step'],1);
+					return $GLOBALS['egw']->importexport_definitions_ui->get_step($content['step'], 1);
 				case 'previous' :
-					return $GLOBALS['egw']->importexport_definitions_ui->get_step($content['step'],-1);
+					return $GLOBALS['egw']->importexport_definitions_ui->get_step($content['step'], -1);
 				case 'finish':
 					return 'wizard_finish';
 				default :
-					return $this->wizard_step60($content,$sel_options,$readonlys,$preserv);
+					return $this->wizard_step60($content, $sel_options, $readonlys, $preserv);
 			}
 		}
 		// init step60
@@ -156,17 +156,17 @@ 
 			$content['msg'] = $this->steps['wizard_step60'];
 			$content['step'] = 'wizard_step60';
 			$preserv = $content;
-			if(!array_key_exists($content['record_owner']) && $content['plugin_options']) {
+			if (!array_key_exists($content['record_owner']) && $content['plugin_options']) {
 				$content['record_owner'] = $content['plugin_options']['record_owner'];
 			}
-			if(!array_key_exists($content['owner_from_csv']) && $content['plugin_options']) {
+			if (!array_key_exists($content['owner_from_csv']) && $content['plugin_options']) {
 				$content['owner_from_csv'] = $content['plugin_options']['owner_from_csv'];
 			}
-			if(!array_key_exists($content['change_owner']) && $content['plugin_options']) {
+			if (!array_key_exists($content['change_owner']) && $content['plugin_options']) {
 				$content['change_owner'] = $content['plugin_options']['change_owner'];
 			}
 
-			if(!in_array('ts_owner', $content['field_mapping'])) {
+			if (!in_array('ts_owner', $content['field_mapping'])) {
 				$content['no_owner_map'] = true;
 			}
 

timesheet/inc/class.timesheet_tracking.inc.php

Spacing +5 added lines, -5 removed lines

@@ -73,8 +73,8 @@ 
 
 		//set fields for tracking
 		$this->field2history = array_keys($this->bo->db_cols);
-		$this->field2history = array_diff(array_combine($this->field2history,$this->field2history),array('ts_modified'));
-		$this->field2history += array('customfields'   => '#c');	// to display old customfield data in history
+		$this->field2history = array_diff(array_combine($this->field2history, $this->field2history), array('ts_modified'));
+		$this->field2history += array('customfields'   => '#c'); // to display old customfield data in history
 
 		// custom fields are now handled by parent::__construct('tracker')
 		parent::__construct('timesheet');
@@ -91,7 +91,7 @@ 
 	 * @param array $old =null old/last state of the entry or null for a new entry
 	 * @return mixed
 	 */
-	function get_config($name,$data,$old=null)
+	function get_config($name, $data, $old = null)
 	{
 		$timesheet = $data['ts_id'];
 
@@ -109,7 +109,7 @@ 
 	 * @param array $old
 	 * @return string
 	 */
-	function get_subject($data,$old)
+	function get_subject($data, $old)
 	{
 		return '#'.$data['ts_id'].' - '.$data['ts_title'];
 	}
@@ -121,7 +121,7 @@ 
 	 * @param array $old
 	 * @return string
 	 */
-	function get_message($data,$old)
+	function get_message($data, $old)
 	{
 		if (!$data['ts_modified'] || !$old)
 		{

Doc Comments -6 removed lines

@@ -62,7 +62,6 @@ 
 	/**
 	 * Constructor
 	 *
-	 * @param timesheet_bo $botimesheet
 	 * @return timesheet_tracking
 	 */
 	function __construct(timesheet_bo $bo)
@@ -81,12 +80,7 @@ 
 	/**
 	 * Get a notification-config value
 	 *
-	 * @param string $what
-	 * 	- 'copy' array of email addresses notifications should be copied too, can depend on $data
-	 *  - 'lang' string lang code for copy mail
-	 *  - 'sender' string send email address
 	 * @param array $data current entry
-	 * @param array $old=null old/last state of the entry or null for a new entry
 	 * @return mixed
 	 */
 	function get_config($name,$data,$old=null)

notifications/download.php

Spacing +7 added lines, -7 removed lines

@@ -20,7 +20,7 @@ 
 	)
 );
 
-ini_set('zlib.output_compression',0);
+ini_set('zlib.output_compression', 0);
 include('../header.inc.php');
 
 ob_start();
@@ -28,8 +28,8 @@ 
 check_load_extension('zip', true);
 
 $document = EGW_SERVER_ROOT.'/notifications/java/full-eGwNotifier.jar';
-$archive = tempnam($GLOBALS['egw_info']['server']['temp_dir'], basename($document,'.jar').'-').'.jar';
-$ret=copy($document, $archive);
+$archive = tempnam($GLOBALS['egw_info']['server']['temp_dir'], basename($document, '.jar').'-').'.jar';
+$ret = copy($document, $archive);
 error_log("copy('$document', '$archive' returned ".array2string($ret));
 $document = 'zip://'.$archive.'#'.($config_file = 'lib/conf/egwnotifier.const.xml');
 
@@ -39,7 +39,7 @@ 
 function replace_callback($matches)
 {
 	$replacement = $matches[3];
-	switch($matches[1])
+	switch ($matches[1])
 	{
 		case 'egw_dc_url':
 			$replacement = $GLOBALS['egw_info']['server']['webserver_url'];
@@ -60,7 +60,7 @@ 
 		case 'egw_debuging_level':
 			break;
 		default:
-			$replacement = lang($r=$replacement);
+			$replacement = lang($r = $replacement);
 			/* uncomment this to have missing translations add to en langfile
 			// if no translation found, check if en langfile is writable and add phrase, if not already there
 			if ($r === $replacement)
@@ -89,7 +89,7 @@ 
 
 	if (is_string($htmlscflags))
 	{
-		$htmlscflags = 16;	// #define ENT_XML1		16
+		$htmlscflags = 16; // #define ENT_XML1		16
 	}
 
 	return '<'.$matches[1].'>'.htmlspecialchars($replacement, $htmlscflags, Api\Translation::charset()).'</'.$matches[1].'>';
@@ -118,6 +118,6 @@ 
 ob_end_clean();
 
 Api\Header\Content::type('egroupware-notifier-'.$GLOBALS['egw_info']['user']['account_lid'].'.jar', 'application/x-java-archive', filesize($archive));
-readfile($archive,'rb');
+readfile($archive, 'rb');
 
 @unlink($archive);