EGroupware / egroupware

api/src/Vfs.php

Braces +237 added lines, -62 removed lines

@@ -221,7 +221,10 @@ 
 		}
 		foreach($props as &$prop)
 		{
-			if ($prop['name'] == $name && $prop['ns'] == $ns) return $prop;
+			if ($prop['name'] == $name && $prop['ns'] == $ns)
+			{
+				return $prop;
+			}
 		}
 		return null;
 	}
@@ -314,11 +317,17 @@ 
 	 */
 	static function mount($url=null,$path=null,$check_url=null,$persitent_mount=true,$clear_fstab=false)
 	{
-		if (is_null($check_url)) $check_url = strpos($url,'$') === false;
+		if (is_null($check_url))
+		{
+			$check_url = strpos($url,'$') === false;
+		}
 
-		if (!isset($GLOBALS['egw_info']['server']['vfs_fstab']))	// happens eg. in setup
+		if (!isset($GLOBALS['egw_info']['server']['vfs_fstab']))
+		{
+			// happens eg. in setup
 		{
 			$api_config = Config::read('phpgwapi');
+		}
 			if (isset($api_config['vfs_fstab']) && is_array($api_config['vfs_fstab']))
 			{
 				self::$fstab = $api_config['vfs_fstab'];
@@ -334,12 +343,18 @@ 
 		}
 		if (is_null($url) || is_null($path))
 		{
-			if (self::LOG_LEVEL > 1) error_log(__METHOD__.'('.array2string($url).','.array2string($path).') returns '.array2string(self::$fstab));
+			if (self::LOG_LEVEL > 1)
+			{
+				error_log(__METHOD__.'('.array2string($url).','.array2string($path).') returns '.array2string(self::$fstab));
+			}
 			return self::$fstab;
 		}
 		if (!self::$is_root)
 		{
-			if (self::LOG_LEVEL > 0) error_log(__METHOD__.'('.array2string($url).','.array2string($path).') permission denied, you are NOT root!');
+			if (self::LOG_LEVEL > 0)
+			{
+				error_log(__METHOD__.'('.array2string($url).','.array2string($path).') permission denied, you are NOT root!');
+			}
 			return false;	// only root can mount
 		}
 		if ($clear_fstab)
@@ -348,14 +363,20 @@ 
 		}
 		if (isset(self::$fstab[$path]) && self::$fstab[$path] === $url)
 		{
-			if (self::LOG_LEVEL > 0) error_log(__METHOD__.'('.array2string($url).','.array2string($path).') already mounted.');
+			if (self::LOG_LEVEL > 0)
+			{
+				error_log(__METHOD__.'('.array2string($url).','.array2string($path).') already mounted.');
+			}
 			return true;	// already mounted
 		}
 		self::load_wrapper(self::parse_url($url,PHP_URL_SCHEME));
 
 		if ($check_url && (!file_exists($url) || opendir($url) === false))
 		{
-			if (self::LOG_LEVEL > 0) error_log(__METHOD__.'('.array2string($url).','.array2string($path).') url does NOT exist!');
+			if (self::LOG_LEVEL > 0)
+			{
+				error_log(__METHOD__.'('.array2string($url).','.array2string($path).') url does NOT exist!');
+			}
 			return false;	// url does not exist
 		}
 		self::$fstab[$path] = $url;
@@ -370,12 +391,18 @@ 
 			Config::save_value('vfs_fstab',self::$fstab,'phpgwapi');
 			$GLOBALS['egw_info']['server']['vfs_fstab'] = self::$fstab;
 			// invalidate session cache
-			if (method_exists($GLOBALS['egw'],'invalidate_session_cache'))	// egw object in setup is limited
+			if (method_exists($GLOBALS['egw'],'invalidate_session_cache'))
+			{
+				// egw object in setup is limited
 			{
 				$GLOBALS['egw']->invalidate_session_cache();
 			}
+			}
+		}
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__.'('.array2string($url).','.array2string($path).') returns true (successful new mount).');
 		}
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__.'('.array2string($url).','.array2string($path).') returns true (successful new mount).');
 		return true;
 	}
 
@@ -388,12 +415,18 @@ 
 	{
 		if (!self::$is_root)
 		{
-			if (self::LOG_LEVEL > 0) error_log(__METHOD__.'('.array2string($path).','.array2string($path).') permission denied, you are NOT root!');
+			if (self::LOG_LEVEL > 0)
+			{
+				error_log(__METHOD__.'('.array2string($path).','.array2string($path).') permission denied, you are NOT root!');
+			}
 			return false;	// only root can mount
 		}
 		if (!isset(self::$fstab[$path]) && ($path = array_search($path,self::$fstab)) === false)
 		{
-			if (self::LOG_LEVEL > 0) error_log(__METHOD__.'('.array2string($path).') NOT mounted!');
+			if (self::LOG_LEVEL > 0)
+			{
+				error_log(__METHOD__.'('.array2string($path).') NOT mounted!');
+			}
 			return false;	// $path not mounted
 		}
 		unset(self::$fstab[$path]);
@@ -401,11 +434,17 @@ 
 		Config::save_value('vfs_fstab',self::$fstab,'phpgwapi');
 		$GLOBALS['egw_info']['server']['vfs_fstab'] = self::$fstab;
 		// invalidate session cache
-		if (method_exists($GLOBALS['egw'],'invalidate_session_cache'))	// egw object in setup is limited
+		if (method_exists($GLOBALS['egw'],'invalidate_session_cache'))
+		{
+			// egw object in setup is limited
 		{
 			$GLOBALS['egw']->invalidate_session_cache();
 		}
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__.'('.array2string($path).') returns true (successful unmount).');
+		}
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__.'('.array2string($path).') returns true (successful unmount).');
+		}
 		return true;
 	}
 
@@ -460,17 +499,27 @@ 
 		$dirs_last = $options['depth'];	// put content of dirs before the dir itself
 		// show dirs on top by default, if no recursive listing (allways disabled if $type specified, as unnecessary)
 		$dirsontop = !$type && (isset($options['dirsontop']) ? (boolean)$options['dirsontop'] : isset($options['maxdepth'])&&$options['maxdepth']>0);
-		if ($dirsontop) $options['need_mime'] = true;	// otherwise dirsontop can NOT work
+		if ($dirsontop)
+		{
+			$options['need_mime'] = true;
+		}
+		// otherwise dirsontop can NOT work
 
 		// process some of the options (need to be done only once)
-		if (isset($options['name']) && !isset($options['name_preg']))	// change from simple *,? wildcards to preg regular expression once
+		if (isset($options['name']) && !isset($options['name_preg']))
+		{
+			// change from simple *,? wildcards to preg regular expression once
 		{
 			$options['name_preg'] = '/^'.str_replace(array('\\?','\\*'),array('.{1}','.*'),preg_quote($options['name'])).'$/i';
 		}
-		if (isset($options['path']) && !isset($options['preg_path']))	// change from simple *,? wildcards to preg regular expression once
+		}
+		if (isset($options['path']) && !isset($options['preg_path']))
+		{
+			// change from simple *,? wildcards to preg regular expression once
 		{
 			$options['path_preg'] = '/^'.str_replace(array('\\?','\\*'),array('.{1}','.*'),preg_quote($options['path'])).'$/i';
 		}
+		}
 		if (!isset($options['uid']))
 		{
 			if (isset($options['user']))
@@ -517,7 +566,10 @@ 
 		{
 			if (!$url)
 			{
-				if ($path[0] != '/' || !self::stat($path)) continue;
+				if ($path[0] != '/' || !self::stat($path))
+				{
+					continue;
+				}
 				$path = self::PREFIX . $path;
 			}
 			if (!isset($options['remove']))
@@ -535,9 +587,17 @@ 
 			{
 				while(($fname = readdir($dir)) !== false)
 				{
-					if ($fname == '.' || $fname == '..') continue;	// ignore current and parent dir!
+					if ($fname == '.' || $fname == '..')
+					{
+						continue;
+					}
+					// ignore current and parent dir!
 
-					if (self::is_hidden($fname, $options['show-deleted']) && !$options['hidden']) continue;	// ignore hidden files
+					if (self::is_hidden($fname, $options['show-deleted']) && !$options['hidden'])
+					{
+						continue;
+					}
+					// ignore hidden files
 
 					$file = self::concat($path, $fname);
 
@@ -549,8 +609,14 @@ 
 					if (is_dir($file) && ($options['follow'] || !is_link($file)) && (!isset($options['maxdepth']) || $options['maxdepth'] > 1))
 					{
 						$opts = $options;
-						if ($opts['mindepth']) $opts['mindepth']--;
-						if ($opts['maxdepth']) $opts['depth']++;
+						if ($opts['mindepth'])
+						{
+							$opts['mindepth']--;
+						}
+						if ($opts['maxdepth'])
+						{
+							$opts['depth']++;
+						}
 						unset($opts['order']);
 						unset($opts['limit']);
 						foreach(self::find($options['url']?$file:self::parse_url($file,PHP_URL_PATH),$opts,true) as $p => $s)
@@ -615,7 +681,10 @@ 
 		if (isset($options['limit']))
 		{
 			list($limit,$start) = explode(',',$options['limit']);
-			if (!$limit && !($limit = $GLOBALS['egw_info']['user']['preferences']['comman']['maxmatches'])) $limit = 15;
+			if (!$limit && !($limit = $GLOBALS['egw_info']['user']['preferences']['comman']['maxmatches']))
+			{
+				$limit = 15;
+			}
 			//echo "total=".self::$find_total.", limit=$options[limit] --> start=$start, limit=$limit<br>\n";
 
 			if ((int)$start || self::$find_total > $limit)
@@ -672,9 +741,13 @@ 
 			return;	// not found, should not happen
 		}
 		if ($type && (($type == 'd') == !($stat['mode'] & Vfs\Sqlfs\StreamWrapper::MODE_DIR) ||	// != is_dir() which can be true for symlinks
-		    $type == 'F' && is_dir($path)))	// symlink to a directory
+		    $type == 'F' && is_dir($path)))
 		{
-			return;	// wrong type
+			// symlink to a directory
+		{
+			return;
+		}
+		// wrong type
 		}
 		$stat = array_slice($stat,13);	// remove numerical indices 0-12
 		$stat['path'] = self::parse_url($path,PHP_URL_PATH);
@@ -697,11 +770,15 @@ 
 		}
 		if (isset($options['mime']) && $options['mime'] != $stat['mime'])
 		{
-			if ($options['mime'][0] == '/')	// perl regular expression given
+			if ($options['mime'][0] == '/')
+			{
+				// perl regular expression given
 			{
 				if (!preg_match($options['mime'], $stat['mime']))
 				{
-					return;	// wrong mime-type
+					return;
+			}
+			// wrong mime-type
 				}
 			}
 			else
@@ -1018,7 +1095,8 @@ 
 			}
 
 			// sort by length descending, to show precedence
-			usort($eacls, function($a, $b) {
+			usort($eacls, function($a, $b)
+			{
 				return strlen($b['path']) - strlen($a['path']);
 			});
 		}
@@ -1073,14 +1151,21 @@ 
 	 */
 	static function mode2int($set,$mode=0)
 	{
-		if (is_int($set))		// already an integer
+		if (is_int($set))
+		{
+			// already an integer
 		{
 			return $set;
 		}
-		if (is_numeric($set))	// octal string
+		}
+		if (is_numeric($set))
+		{
+			// octal string
 		{
 			//error_log(__METHOD__."($set,$mode) returning ".(int)base_convert($set,8,10));
-			return (int)base_convert($set,8,10);	// convert octal to decimal
+			return (int)base_convert($set,8,10);
+		}
+		// convert octal to decimal
 		}
 		foreach(explode(',',$set) as $s)
 		{
@@ -1136,34 +1221,55 @@ 
 	 */
 	static function int2mode( $mode )
 	{
-		if(($mode & self::MODE_LINK) == self::MODE_LINK) // Symbolic Link
+		if(($mode & self::MODE_LINK) == self::MODE_LINK)
+		{
+			// Symbolic Link
 		{
 			$sP = 'l';
 		}
-		elseif(($mode & 0xC000) == 0xC000) // Socket
+		}
+		elseif(($mode & 0xC000) == 0xC000)
+		{
+			// Socket
 		{
 			$sP = 's';
 		}
-		elseif($mode & 0x1000)     // FIFO pipe
+		}
+		elseif($mode & 0x1000)
+		{
+			// FIFO pipe
 		{
 			$sP = 'p';
 		}
-		elseif($mode & 0x2000) // Character special
+		}
+		elseif($mode & 0x2000)
+		{
+			// Character special
 		{
 			$sP = 'c';
 		}
-		elseif($mode & 0x4000) // Directory
+		}
+		elseif($mode & 0x4000)
+		{
+			// Directory
 		{
 			$sP = 'd';
 		}
-		elseif($mode & 0x6000) // Block special
+		}
+		elseif($mode & 0x6000)
+		{
+			// Block special
 		{
 			$sP = 'b';
 		}
-		elseif($mode & 0x8000) // Regular
+		}
+		elseif($mode & 0x8000)
+		{
+			// Regular
 		{
 			$sP = '-';
 		}
+		}
 		else                         // UNKNOWN
 		{
 			$sP = 'u';
@@ -1230,9 +1336,18 @@ 
 	 */
 	static function hsize($size)
 	{
-		if ($size < 1024) return $size;
-		if ($size < 1024*1024) return sprintf('%3.1lfk',(float)$size/1024);
-		if ($size < 1024*1024*1024) return sprintf('%3.1lfM',(float)$size/(1024*1024));
+		if ($size < 1024)
+		{
+			return $size;
+		}
+		if ($size < 1024*1024)
+		{
+			return sprintf('%3.1lfk',(float)$size/1024);
+		}
+		if ($size < 1024*1024*1024)
+		{
+			return sprintf('%3.1lfM',(float)$size/(1024*1024));
+		}
 		return sprintf('%3.1lfG',(float)$size/(1024*1024*1024));
 	}
 
@@ -1243,7 +1358,10 @@ 
 	 */
 	static function int_size($_val)
 	{
-		if(empty($_val))return 0;
+		if(empty($_val))
+		{
+			return 0;
+		}
 
 		$val = trim($_val);
 
@@ -1251,11 +1369,13 @@ 
 		preg_match('#([0-9]+)[\s]*([a-z]+)#i', $val, $matches);
 
 		$last = '';
-		if(isset($matches[2])){
+		if(isset($matches[2]))
+		{
 			$last = $matches[2];
 		}
 
-		if(isset($matches[1])){
+		if(isset($matches[1]))
+		{
 			$val = (int) $matches[1];
 		}
 
@@ -1307,7 +1427,10 @@ 
 			return false;
 		}
 		$parts = explode('/',$url);
-		if (substr($url,-1) == '/') array_pop($parts);
+		if (substr($url,-1) == '/')
+		{
+			array_pop($parts);
+		}
 		array_pop($parts);
 		if ($url[0] != '/' && count($parts) == 3 || count($parts) == 1 && $parts[0] === '')
 		{
@@ -1328,7 +1451,10 @@ 
 	 */
 	static function has_owner_rights($path,array $stat=null)
 	{
-		if (!$stat) $stat = self::url_stat($path,0);
+		if (!$stat)
+		{
+			$stat = self::url_stat($path,0);
+		}
 
 		return $stat['uid'] == self::$user ||	// user is the owner
 			self::$is_root ||					// class runs with root rights
@@ -1347,7 +1473,10 @@ 
 	static function concat($_url,$relative)
 	{
 		list($url,$query) = explode('?',$_url,2);
-		if (substr($url,-1) == '/') $url = substr($url,0,-1);
+		if (substr($url,-1) == '/')
+		{
+			$url = substr($url,0,-1);
+		}
 		$ret = ($relative === '' || $relative[0] == '/' ? $url.$relative : $url.'/'.$relative);
 
 		// now normalize the path (remove "/something/..")
@@ -1440,7 +1569,8 @@ 
 		if(count($paths) > 0)
 		{
 			// Shortest to longest
-			usort($paths, function($a, $b) {
+			usort($paths, function($a, $b)
+			{
 				return strlen($a) - strlen($b);
 			});
 
@@ -1513,7 +1643,10 @@ 
 			// Don't go infinite with app entries
 			if(self::is_link($addfile))
 			{
-				if(in_array($addfile, $links)) continue;
+				if(in_array($addfile, $links))
+				{
+					continue;
+				}
 				$links[] = $addfile;
 			}
 			// Add directory - if empty, client app might not show it though
@@ -1624,12 +1757,17 @@ 
     	// remove the lock info evtl. set in the cache
     	unset(self::$lock_cache[$path]);
 
-    	if ($timeout < 1000000)	// < 1000000 is a relative timestamp, so we add the current time
+    	if ($timeout < 1000000)
+    	{
+    		// < 1000000 is a relative timestamp, so we add the current time
     	{
     		$timeout += time();
     	}
+    	}
 
-		if ($update)	// Lock Update
+		if ($update)
+		{
+			// Lock Update
 		{
 			if (($ret = (boolean)($row = self::$db->select(self::LOCK_TABLE,array('lock_owner','lock_exclusive','lock_write'),array(
 				'lock_path' => $path,
@@ -1637,6 +1775,7 @@ 
 			),__LINE__,__FILE__)->fetch())))
 			{
 				$owner = $row['lock_owner'];
+		}
 				$scope = Db::from_bool($row['lock_exclusive']) ? 'exclusive' : 'shared';
 				$type  = Db::from_bool($row['lock_write']) ? 'write' : 'read';
 
@@ -1684,7 +1823,10 @@ 
 				$ret = false;	// there's already a lock
 			}
 		}
-		if (self::LOCK_DEBUG) error_log(__METHOD__."($path,$token,$timeout,$owner,$scope,$type,update=$update,check_writable=$check_writable) returns ".($ret ? 'true' : 'false'));
+		if (self::LOCK_DEBUG)
+		{
+			error_log(__METHOD__."($path,$token,$timeout,$owner,$scope,$type,update=$update,check_writable=$check_writable) returns ".($ret ? 'true' : 'false'));
+		}
 		return $ret;
 	}
 
@@ -1711,7 +1853,10 @@ 
         	// remove the lock from the cache too
         	unset(self::$lock_cache[$path]);
         }
-		if (self::LOCK_DEBUG) error_log(__METHOD__."($path,$token,$check_writable) returns ".($ret ? 'true' : 'false'));
+		if (self::LOCK_DEBUG)
+		{
+			error_log(__METHOD__."($path,$token,$check_writable) returns ".($ret ? 'true' : 'false'));
+		}
 		return $ret;
     }
 
@@ -1725,7 +1870,10 @@ 
 	{
 		if (isset(self::$lock_cache[$path]))
 		{
-			if (self::LOCK_DEBUG) error_log(__METHOD__."($path) returns from CACHE ".str_replace(array("\n",'    '),'',print_r(self::$lock_cache[$path],true)));
+			if (self::LOCK_DEBUG)
+			{
+				error_log(__METHOD__."($path) returns from CACHE ".str_replace(array("\n",'    '),'',print_r(self::$lock_cache[$path],true)));
+			}
 			return self::$lock_cache[$path];
 		}
 		$where = 'lock_path='.self::$db->quote($path);
@@ -1739,17 +1887,26 @@ 
 			$result['scope'] = Db::from_bool($result['exclusive']) ? 'exclusive' : 'shared';
 			$result['depth'] = Db::from_bool($result['recursive']) ? 'infinite' : 0;
 		}
-		if ($result && $result['expires'] < time())	// lock is expired --> remove it
+		if ($result && $result['expires'] < time())
+		{
+			// lock is expired --> remove it
 		{
 	        self::$db->delete(self::LOCK_TABLE,array(
 	        	'lock_path' => $result['path'],
 	        	'lock_token' => $result['token'],
 	        ),__LINE__,__FILE__);
+		}
 
-			if (self::LOCK_DEBUG) error_log(__METHOD__."($path) lock is expired at ".date('Y-m-d H:i:s',$result['expires'])." --> removed");
+			if (self::LOCK_DEBUG)
+			{
+				error_log(__METHOD__."($path) lock is expired at ".date('Y-m-d H:i:s',$result['expires'])." --> removed");
+			}
 	        $result = false;
 		}
-		if (self::LOCK_DEBUG) error_log(__METHOD__."($path) returns ".($result?array2string($result):'false'));
+		if (self::LOCK_DEBUG)
+		{
+			error_log(__METHOD__."($path) returns ".($result?array2string($result):'false'));
+		}
 		return self::$lock_cache[$path] = $result;
 	}
 
@@ -1763,10 +1920,13 @@ 
 	static function getExtraInfo($path,array $content=null)
 	{
 		$extra = array();
-		if (($extra_info = self::_call_on_backend('extra_info',array($path,$content),true)))	// true = fail silent if backend does NOT support it
+		if (($extra_info = self::_call_on_backend('extra_info',array($path,$content),true)))
+		{
+			// true = fail silent if backend does NOT support it
 		{
 			$extra[] = $extra_info;
 		}
+		}
 
 		if (($vfs_extra = Hooks::process(array(
 			'location' => 'vfs_extra',
@@ -2044,30 +2204,42 @@ 
 		}
 		if ($check_is_uploaded_file && !is_resource($tmp_name) && !is_uploaded_file($tmp_name))
 		{
-			if (self::LOG_LEVEL) error_log(__METHOD__."($tmp_name, $target, ".array2string($props).",$check_is_uploaded_file) returning FALSE !is_uploaded_file()");
+			if (self::LOG_LEVEL)
+			{
+				error_log(__METHOD__."($tmp_name, $target, ".array2string($props).",$check_is_uploaded_file) returning FALSE !is_uploaded_file()");
+			}
 			return false;
 		}
 		if (!(self::is_writable($target) || self::is_writable(self::dirname($target))))
 		{
-			if (self::LOG_LEVEL) error_log(__METHOD__."($tmp_name, $target, ".array2string($props).",$check_is_uploaded_file) returning FALSE !writable");
+			if (self::LOG_LEVEL)
+			{
+				error_log(__METHOD__."($tmp_name, $target, ".array2string($props).",$check_is_uploaded_file) returning FALSE !writable");
+			}
 			return false;
 		}
 		if ($props)
 		{
-			if (!is_array($props)) $props = array(array('name' => 'comment','val' => $props));
+			if (!is_array($props))
+			{
+				$props = array(array('name' => 'comment','val' => $props));
+			}
 
 			// if $props is name => value pairs, convert it to internal array or array with values for keys 'name', 'val' and optional 'ns'
 			if (!isset($props[0]))
 			{
 				foreach($props as $name => $val)
 				{
-					if (($name == 'comment' || $name[0] == '#') && $val)	// only copy 'comment' and cfs
+					if (($name == 'comment' || $name[0] == '#') && $val)
+					{
+						// only copy 'comment' and cfs
 					{
 						$vfs_props[] = array(
 							'name' => $name,
 							'val'  => $val,
 						);
 					}
+					}
 				}
 				$props = $vfs_props;
 			}
@@ -2094,7 +2266,10 @@ 
 		{
 			$ret = copy($tmp_name,self::PREFIX.$target) ? self::stat($target) : false;
 		}
-		if (self::LOG_LEVEL > 1 || !$ret && self::LOG_LEVEL) error_log(__METHOD__."($tmp_name, $target, ".array2string($props).") returning ".array2string($ret));
+		if (self::LOG_LEVEL > 1 || !$ret && self::LOG_LEVEL)
+		{
+			error_log(__METHOD__."($tmp_name, $target, ".array2string($props).") returning ".array2string($ret));
+		}
 		return $ret;
 	}
 

api/src/Vfs/StreamWrapper.php

Braces +184 added lines, -45 removed lines

@@ -165,7 +165,10 @@ 
 		{
 			$url = null;
 			$stat = self::check_symlink_components($path,0,$url);
-			if (self::LOG_LEVEL > 1) $log = " (check_symlink_components('$path',0,'$url') = $stat)";
+			if (self::LOG_LEVEL > 1)
+			{
+				$log = " (check_symlink_components('$path',0,'$url') = $stat)";
+			}
 		}
 		else
 		{
@@ -176,7 +179,10 @@ 
 		{
 			$url = self::resolve_url(self::parse_url($url,PHP_URL_PATH));
 		}
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($path,file_exists=$file_exists,resolve_last_symlink=$resolve_last_symlink) = '$url'$log");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."($path,file_exists=$file_exists,resolve_last_symlink=$resolve_last_symlink) = '$url'$log");
+		}
 		return $url;
 	}
 
@@ -204,7 +210,10 @@ 
 		// we do some caching here
 		if (isset(self::$resolve_url_cache[$path]) && $replace_user_pass_host)
 		{
-			if (self::LOG_LEVEL > 1) error_log(__METHOD__."('$path') = '".self::$resolve_url_cache[$path]."' (from cache)");
+			if (self::LOG_LEVEL > 1)
+			{
+				error_log(__METHOD__."('$path') = '".self::$resolve_url_cache[$path]."' (from cache)");
+			}
 			return self::$resolve_url_cache[$path];
 		}
 		// check if we can already resolve path (or a part of it) with a known symlinks
@@ -224,14 +233,24 @@ 
 			);
 		}
 		$parts = array_merge(self::parse_url($path),$defaults);
-		if (!$parts['host']) $parts['host'] = 'default';	// otherwise we get an invalid url (scheme:///path/to/something)!
+		if (!$parts['host'])
+		{
+			$parts['host'] = 'default';
+		}
+		// otherwise we get an invalid url (scheme:///path/to/something)!
 
 		if (!empty($parts['scheme']) && $parts['scheme'] != self::SCHEME)
 		{
-			if (self::LOG_LEVEL > 1) error_log(__METHOD__."('$path') = '$path' (path is already an url)");
+			if (self::LOG_LEVEL > 1)
+			{
+				error_log(__METHOD__."('$path') = '$path' (path is already an url)");
+			}
 			return $path;	// path is already a non-vfs url --> nothing to do
 		}
-		if (empty($parts['path'])) $parts['path'] = '/';
+		if (empty($parts['path']))
+		{
+			$parts['path'] = '/';
+		}
 
 		foreach(array_reverse(self::$fstab) as $mounted => $url)
 		{
@@ -257,17 +276,32 @@ 
 				{
 					$url = str_replace(array('$user','$pass','$host','$home'),array($parts['user'],$parts['pass'],$parts['host'],$parts['home']),$url);
 				}
-				if ($parts['query']) $url .= '?'.$parts['query'];
-				if ($parts['fragment']) $url .= '#'.$parts['fragment'];
+				if ($parts['query'])
+				{
+					$url .= '?'.$parts['query'];
+				}
+				if ($parts['fragment'])
+				{
+					$url .= '#'.$parts['fragment'];
+				}
 
-				if (self::LOG_LEVEL > 1) error_log(__METHOD__."('$path') = '$url'");
+				if (self::LOG_LEVEL > 1)
+				{
+					error_log(__METHOD__."('$path') = '$url'");
+				}
 
-				if ($replace_user_pass_host) self::$resolve_url_cache[$path] = $url;
+				if ($replace_user_pass_host)
+				{
+					self::$resolve_url_cache[$path] = $url;
+				}
 
 				return $url;
 			}
 		}
-		if (self::LOG_LEVEL > 0) error_log(__METHOD__."('$path') can't resolve path!\n");
+		if (self::LOG_LEVEL > 0)
+		{
+			error_log(__METHOD__."('$path') can't resolve path!\n");
+		}
 		trigger_error(__METHOD__."($path) can't resolve path!\n",E_USER_WARNING);
 		return false;
 	}
@@ -491,10 +525,13 @@ 
 	 */
 	static function unlink ( $path )
 	{
-		if (!($url = self::resolve_url_symlinks($path,true,false)))	// true,false file need to exist, but do not resolve last component
+		if (!($url = self::resolve_url_symlinks($path,true,false)))
+		{
+			// true,false file need to exist, but do not resolve last component
 		{
 			return false;
 		}
+		}
 		if (self::url_is_readonly($url))
 		{
 			return false;
@@ -547,7 +584,10 @@ 
 			$ret = stream_copy_to_stream($from,$to) !== false;
 			fclose($from);
 			fclose($to);
-			if ($ret) self::unlink($path_from);
+			if ($ret)
+			{
+				self::unlink($path_from);
+			}
 		}
 		else
 		{
@@ -584,10 +624,13 @@ 
 	 */
 	static function mkdir ( $path, $mode, $options )
 	{
-		if (!($url = self::resolve_url_symlinks($path,false)))	// false = directory does not need to exists
+		if (!($url = self::resolve_url_symlinks($path,false)))
+		{
+			// false = directory does not need to exists
 		{
 			return false;
 		}
+		}
 		$ret = mkdir($url,$mode,$options);
 
 		// call "vfs_mkdir" hook
@@ -665,7 +708,10 @@ 
 				return false;
 			}
 			$k=(string)self::parse_url($url,PHP_URL_SCHEME);
-			if (!(is_array($scheme2urls[$k]))) $scheme2urls[$k] = array();
+			if (!(is_array($scheme2urls[$k])))
+			{
+				$scheme2urls[$k] = array();
+			}
 			$scheme2urls[$k][$path] = $url;
 		}
 		$ret = array();
@@ -675,7 +721,10 @@ 
 			{
 				if (!class_exists($class = self::scheme2class($scheme)) || !method_exists($class,$name))
 				{
-					if (!$fail_silent) trigger_error("Can't $name for scheme $scheme!\n",E_USER_WARNING);
+					if (!$fail_silent)
+					{
+						trigger_error("Can't $name for scheme $scheme!\n",E_USER_WARNING);
+					}
 					return false;
 				}
 				if (!is_array($pathes))
@@ -793,10 +842,13 @@ 
 	 */
 	static function symlink($target,$link)
 	{
-		if (($ret = self::_call_on_backend('symlink',array($target,$link),false,1)))	// 1=path is in $link!
+		if (($ret = self::_call_on_backend('symlink',array($target,$link),false,1)))
+		{
+			// 1=path is in $link!
 		{
 			self::symlinkCache_remove($link);
 		}
+		}
 		return $ret;
 	}
 
@@ -866,13 +918,19 @@ 
 
 		if (!($this->opened_dir_url = self::resolve_url_symlinks($path)))
 		{
-			if (self::LOG_LEVEL > 0) error_log(__METHOD__."( $path,$options) resolve_url_symlinks() failed!");
+			if (self::LOG_LEVEL > 0)
+			{
+				error_log(__METHOD__."( $path,$options) resolve_url_symlinks() failed!");
+			}
 			return false;
 		}
 		if (!($this->opened_dir = $this->context ?
 			opendir($this->opened_dir_url, $this->context) : opendir($this->opened_dir_url)))
 		{
-			if (self::LOG_LEVEL > 0) error_log(__METHOD__."( $path,$options) opendir($this->opened_dir_url) failed!");
+			if (self::LOG_LEVEL > 0)
+			{
+				error_log(__METHOD__."( $path,$options) opendir($this->opened_dir_url) failed!");
+			}
 			return false;
 		}
 		$this->opened_dir_writable = Vfs::check_access($this->opened_dir_url,Vfs::WRITABLE);
@@ -890,7 +948,10 @@ 
 		}
 
 
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."( $path,$options): opendir($this->opened_dir_url)=$this->opened_dir, extra_dirs=".array2string($this->extra_dirs).', '.function_backtrace());
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."( $path,$options): opendir($this->opened_dir_url)=$this->opened_dir, extra_dirs=".array2string($this->extra_dirs).', '.function_backtrace());
+		}
 		return true;
 	}
 
@@ -926,7 +987,10 @@ 
 	{
 		if (!($url = self::resolve_url($path,!($flags & STREAM_URL_STAT_LINK), $check_symlink_components)))
 		{
-			if (self::LOG_LEVEL > 0) error_log(__METHOD__."('$path',$flags) can NOT resolve path!");
+			if (self::LOG_LEVEL > 0)
+			{
+				error_log(__METHOD__."('$path',$flags) can NOT resolve path!");
+			}
 			return false;
 		}
 
@@ -943,18 +1007,27 @@ 
 				{
 					if (!$check_symlink_depth)
 					{
-						if (self::LOG_LEVEL > 0) error_log(__METHOD__."('$path',$flags) maximum symlink depth exceeded, might be a circular symlink!");
+						if (self::LOG_LEVEL > 0)
+						{
+							error_log(__METHOD__."('$path',$flags) maximum symlink depth exceeded, might be a circular symlink!");
+						}
 						$stat = false;
 					}
 					elseif (($lpath = self::readlink($url)))
 					{
-						if ($lpath[0] != '/')	// concat relative path
+						if ($lpath[0] != '/')
+						{
+							// concat relative path
 						{
 							$lpath = Vfs::concat(self::parse_url($path,PHP_URL_PATH),'../'.$lpath);
 						}
+						}
 						$u_query = parse_url($url,PHP_URL_QUERY);
 						$url = Vfs::PREFIX.$lpath;
-						if (self::LOG_LEVEL > 1) error_log(__METHOD__."($path,$flags) symlif (substr($path,-1) == '/' && $path != '/') $path = substr($path,0,-1);	// remove trailing slash eg. added by WebDAVink found and resolved to $url");
+						if (self::LOG_LEVEL > 1)
+						{
+							error_log(__METHOD__."($path,$flags) symlif (substr($path,-1) == '/' && $path != '/') $path = substr($path,0,-1);	// remove trailing slash eg. added by WebDAVink found and resolved to $url");
+						}
 						// try reading the stat of the link
 						if (($stat = self::url_stat($lpath, STREAM_URL_STAT_QUIET, false, true, $check_symlink_depth-1)))
 						{
@@ -967,7 +1040,11 @@ 
 								$stat_query = http_build_query(array_merge($stat_query, $u_query));
 								$stat['url'] = $stat_url['scheme'].'://'.$stat_url['host'].$stat_url['path'].'?'.$stat_query;
 							}
-							if(isset($stat['url'])) $url = $stat['url'];	// if stat returns an url use that, as there might be more links ...
+							if(isset($stat['url']))
+							{
+								$url = $stat['url'];
+							}
+							// if stat returns an url use that, as there might be more links ...
 							self::symlinkCache_add($path,$url);
 						}
 					}
@@ -990,7 +1067,9 @@ 
 		// check if a failed url_stat was for a home dir, in that case silently create it
 		if (!$stat && $try_create_home && Vfs::dirname(self::parse_url($path,PHP_URL_PATH)) == '/home' &&
 			($id = $GLOBALS['egw']->accounts->name2id(basename($path))) &&
-			$GLOBALS['egw']->accounts->id2name($id) == basename($path))	// make sure path has the right case!
+			$GLOBALS['egw']->accounts->id2name($id) == basename($path))
+		{
+			// make sure path has the right case!
 		{
 			$hook_data = array(
 				'location' => $GLOBALS['egw']->accounts->get_type($id) == 'g' ? 'addgroup' : 'addaccount',
@@ -998,15 +1077,22 @@ 
 				'account_lid' => basename($path),
 				'account_name' => basename($path),
 			);
+		}
 			call_user_func(array(__NAMESPACE__.'\\Hooks',$hook_data['location']),$hook_data);
 			unset($hook_data);
 			$stat = self::url_stat($path,$flags,false);
 		}
 		$query = parse_url($url, PHP_URL_QUERY);
-		if (!$stat && $check_symlink_components)	// check if there's a symlink somewhere inbetween the path
+		if (!$stat && $check_symlink_components)
+		{
+			// check if there's a symlink somewhere inbetween the path
 		{
 			$stat = self::check_symlink_components($path,$flags,$url);
-			if ($stat && isset($stat['url']) && !$query) self::symlinkCache_add($path,$stat['url']);
+		}
+			if ($stat && isset($stat['url']) && !$query)
+			{
+				self::symlinkCache_add($path,$stat['url']);
+			}
 		}
 		elseif(is_array($stat) && !isset($stat['url']))
 		{
@@ -1021,7 +1107,10 @@ 
 			$stat['url'] .= '?'.$query;
 		}
 
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."('$path',$flags,try_create_home=$try_create_home,check_symlink_components=$check_symlink_components) returning ".array2string($stat));
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."('$path',$flags,try_create_home=$try_create_home,check_symlink_components=$check_symlink_components) returning ".array2string($stat));
+		}
 
 		return $stat;
 
@@ -1047,10 +1136,16 @@ 
 	{
 		if (is_null($url) && !($url = self::resolve_url($path)))
 		{
-			if (self::LOG_LEVEL > 0) error_log(__METHOD__."('$path',$flags,'$url') can NOT resolve path: ".function_backtrace(1));
+			if (self::LOG_LEVEL > 0)
+			{
+				error_log(__METHOD__."('$path',$flags,'$url') can NOT resolve path: ".function_backtrace(1));
+			}
 			return false;
 		}
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."('$path',$flags,'$url'): ".function_backtrace(1));
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."('$path',$flags,'$url'): ".function_backtrace(1));
+		}
 
 		while (($rel_path = Vfs::basename($url).($rel_path ? '/'.$rel_path : '')) &&
 		       ($url = Vfs::dirname($url)))
@@ -1059,7 +1154,10 @@ 
 			{
 				if (is_link($url) && ($lpath = self::readlink($url)))
 				{
-					if (self::LOG_LEVEL > 1) $log = "rel_path='$rel_path', url='$url': lpath='$lpath'";
+					if (self::LOG_LEVEL > 1)
+					{
+						$log = "rel_path='$rel_path', url='$url': lpath='$lpath'";
+					}
 
 					if ($lpath[0] != '/')
 					{
@@ -1067,15 +1165,24 @@ 
 					}
 					//self::symlinkCache_add($path,Vfs::PREFIX.$lpath);
 					$url = Vfs::PREFIX.Vfs::concat($lpath,$rel_path);
-					if (self::LOG_LEVEL > 1) error_log("$log --> lpath='$lpath', url='$url'");
+					if (self::LOG_LEVEL > 1)
+					{
+						error_log("$log --> lpath='$lpath', url='$url'");
+					}
 					return self::url_stat($url,$flags);
 				}
 				$url = Vfs::concat($url,$rel_path);
-				if (self::LOG_LEVEL > 1) error_log(__METHOD__."('$path',$flags,'$url') returning null");
+				if (self::LOG_LEVEL > 1)
+				{
+					error_log(__METHOD__."('$path',$flags,'$url') returning null");
+				}
 				return null;
 			}
 		}
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."('$path',$flags,'$url') returning false");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."('$path',$flags,'$url') returning false");
+		}
 		return false;	// $path does not exist
 	}
 
@@ -1096,9 +1203,16 @@ 
 	{
 		$path = self::get_path($_path);
 
-		if (isset(self::$symlink_cache[$path])) return;	// nothing to do
+		if (isset(self::$symlink_cache[$path]))
+		{
+			return;
+		}
+		// nothing to do
 
-		if ($target[0] != '/') $target = self::parse_url($target,PHP_URL_PATH);
+		if ($target[0] != '/')
+		{
+			$target = self::parse_url($target,PHP_URL_PATH);
+		}
 
 		self::$symlink_cache[$path] = $target;
 
@@ -1107,7 +1221,10 @@ 
 		{
 			return strlen($a) - strlen($b);
 		});
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($path,$target) cache now ".array2string(self::$symlink_cache));
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."($path,$target) cache now ".array2string(self::$symlink_cache));
+		}
 	}
 
 	/**
@@ -1120,7 +1237,10 @@ 
 		$path = self::get_path($_path);
 
 		unset(self::$symlink_cache[$path]);
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($path) cache now ".array2string(self::$symlink_cache));
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."($path) cache now ".array2string(self::$symlink_cache));
+		}
 	}
 
 	/**
@@ -1141,11 +1261,18 @@ 
 
 		foreach(self::$symlink_cache as $p => $t)
 		{
-			if (($strlen_p = strlen($p)) > $strlen_path) continue;	// $path can NOT start with $p
+			if (($strlen_p = strlen($p)) > $strlen_path)
+			{
+				continue;
+			}
+			// $path can NOT start with $p
 
 			if ($path == $p)
 			{
-				if ($do_symlink) $target = $t;
+				if ($do_symlink)
+				{
+					$target = $t;
+				}
 				break;
 			}
 			elseif (substr($path,0,$strlen_p+1) == $p.'/')
@@ -1154,7 +1281,10 @@ 
 				break;
 			}
 		}
-		if (self::LOG_LEVEL > 1 && isset($target)) error_log(__METHOD__."($path) = $target");
+		if (self::LOG_LEVEL > 1 && isset($target))
+		{
+			error_log(__METHOD__."($path) = $target");
+		}
 		return isset($target) ? $target : $path;
 	}
 
@@ -1203,7 +1333,10 @@ 
 				self::HIDE_UNREADABLES && !$this->opened_dir_writable &&
 				!Vfs::check_access(Vfs::concat($this->opened_dir_url,$file),Vfs::READABLE)));
 		}
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."( $this->opened_dir ) = '$file'");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."( $this->opened_dir ) = '$file'");
+		}
 		return $file;
 	}
 
@@ -1306,7 +1439,10 @@ 
 		) as $class)
 		{
 			//error_log(__METHOD__."('$scheme') class_exists('$class')=".array2string(class_exists($class)));
-			if (class_exists($class))  return $class;
+			if (class_exists($class))
+			{
+				return $class;
+			}
 		}
 	}
 
@@ -1341,7 +1477,10 @@ 
 			static $entities = array('%21', '%2A', '%27', '%28', '%29', '%3B', '%3A', '%40', '%26', '%3D', '%24', '%2C', '%2F', '%3F', '%23', '%5B', '%5D');
 			static $replacements = array('!', '*', "'", "(", ")", ";", ":", "@", "&", "=", "$", ",", "/", "?", "#", "[", "]");
 			static $str_replace = null;
-			if (!isset($str_replace)) $str_replace = function_exists('mb_str_replace') ? 'mb_str_replace' : 'str_replace';
+			if (!isset($str_replace))
+			{
+				$str_replace = function_exists('mb_str_replace') ? 'mb_str_replace' : 'str_replace';
+			}
 
 			// Create encoded URL with special URL characters decoded so it can be parsed
 			// All other characters will be encoded

api/src/Vfs/Filesystem/StreamWrapper.php

Braces +90 added lines, -22 removed lines

@@ -131,14 +131,20 @@ 
 		$read_only = str_replace('b','',$mode) == 'r';
 
 		// check access rights, based on the eGW mount perms
-		if (!($stat = self::url_stat($url,0)) || $mode[0] == 'x')	// file not found or file should NOT exist
+		if (!($stat = self::url_stat($url,0)) || $mode[0] == 'x')
+		{
+			// file not found or file should NOT exist
 		{
 			$dir = Vfs::dirname($url);
+		}
 			if ($mode[0] == 'r' ||	// does $mode require the file to exist (r,r+)
 				$mode[0] == 'x' ||	// or file should not exist, but does
-				!Vfs::check_access($dir,Vfs::WRITABLE,$dir_stat=self::url_stat($dir,0)))	// or we are not allowed to 																																			create it
+				!Vfs::check_access($dir,Vfs::WRITABLE,$dir_stat=self::url_stat($dir,0)))
+			{
+				// or we are not allowed to 																																			create it
 			{
 				if (self::LOG_LEVEL) error_log(__METHOD__."($url,$mode,$options) file does not exist or can not be created!");
+			}
 				if (!($options & STREAM_URL_STAT_QUIET))
 				{
 					trigger_error(__METHOD__."($url,$mode,$options) file does not exist or can not be created!",E_USER_WARNING);
@@ -146,9 +152,12 @@ 
 				return false;
 			}
 		}
-		elseif (!$read_only && !Vfs::check_access($url,Vfs::WRITABLE,$stat))	// we are not allowed to edit it
+		elseif (!$read_only && !Vfs::check_access($url,Vfs::WRITABLE,$stat))
+		{
+			// we are not allowed to edit it
 		{
 			if (self::LOG_LEVEL) error_log(__METHOD__."($url,$mode,$options) file can not be edited!");
+		}
 			if (!($options & STREAM_URL_STAT_QUIET))
 			{
 				trigger_error(__METHOD__."($url,$mode,$options) file can not be edited!",E_USER_WARNING);
@@ -157,7 +166,10 @@ 
 		}
 		if (!$read_only && self::deny_script($url))
 		{
-			if (self::LOG_LEVEL) error_log(__METHOD__."($url,$mode,$options) permission denied, file is a script!");
+			if (self::LOG_LEVEL)
+			{
+				error_log(__METHOD__."($url,$mode,$options) permission denied, file is a script!");
+			}
 			if (!($options & STREAM_URL_STAT_QUIET))
 			{
 				trigger_error(__METHOD__."($url,$mode,$options) permission denied, file is a script!",E_USER_WARNING);
@@ -168,7 +180,10 @@ 
 		// open the "real" file
 		if (!($this->opened_stream = fopen($path=Vfs::decodePath(Vfs::parse_url($url,PHP_URL_PATH)),$mode,$options)))
 		{
-			if (self::LOG_LEVEL) error_log(__METHOD__."($url,$mode,$options) fopen('$path','$mode',$options) returned false!");
+			if (self::LOG_LEVEL)
+			{
+				error_log(__METHOD__."($url,$mode,$options) fopen('$path','$mode',$options) returned false!");
+			}
 			return false;
 		}
 		$this->opened_stream_url = $url;
@@ -313,7 +328,10 @@ 
 		// check access rights (file need to exist and directory need to be writable
 		if (!file_exists($path) || is_dir($path) || !Vfs::check_access(Vfs::dirname($url),Vfs::WRITABLE))
 		{
-			if (self::LOG_LEVEL) error_log(__METHOD__."($url) permission denied!");
+			if (self::LOG_LEVEL)
+			{
+				error_log(__METHOD__."($url) permission denied!");
+			}
 			return false;	// no permission or file does not exist
 		}
 		return unlink($path);
@@ -339,18 +357,27 @@ 
 		// check access rights
 		if (!($from_stat = self::url_stat($url_from,0)) || !Vfs::check_access(Vfs::dirname($url_from),Vfs::WRITABLE))
 		{
-			if (self::LOG_LEVEL) error_log(__METHOD__."($url_from,$url_to): $from[path] permission denied!");
+			if (self::LOG_LEVEL)
+			{
+				error_log(__METHOD__."($url_from,$url_to): $from[path] permission denied!");
+			}
 			return false;	// no permission or file does not exist
 		}
 		$to_dir = Vfs::dirname($url_to);
 		if (!Vfs::check_access($to_dir,Vfs::WRITABLE,$to_dir_stat = self::url_stat($to_dir,0)))
 		{
-			if (self::LOG_LEVEL) error_log(__METHOD__."($url_from,$url_to): $to_dir permission denied!");
+			if (self::LOG_LEVEL)
+			{
+				error_log(__METHOD__."($url_from,$url_to): $to_dir permission denied!");
+			}
 			return false;	// no permission or parent-dir does not exist
 		}
 		if (self::deny_script($url_to))
 		{
-			if (self::LOG_LEVEL) error_log(__METHOD__."($url_from,$url_to) permission denied, file is a script!");
+			if (self::LOG_LEVEL)
+			{
+				error_log(__METHOD__."($url_from,$url_to) permission denied, file is a script!");
+			}
 			return false;
 		}
 		// the filesystem stream-wrapper does NOT allow to rename files to directories, as this makes problems
@@ -359,13 +386,19 @@ 
 			($to_stat['mime'] === self::DIR_MIME_TYPE) !== ($from_stat['mime'] === self::DIR_MIME_TYPE))
 		{
 			$is_dir = $to_stat['mime'] === self::DIR_MIME_TYPE ? 'a' : 'no';
-			if (self::LOG_LEVEL) error_log(__METHOD__."($url_to,$url_from) $to[path] is $is_dir directory!");
+			if (self::LOG_LEVEL)
+			{
+				error_log(__METHOD__."($url_to,$url_from) $to[path] is $is_dir directory!");
+			}
 			return false;	// no permission or file does not exist
 		}
 		// if destination file already exists, delete it
 		if ($to_stat && !self::unlink($url_to))
 		{
-			if (self::LOG_LEVEL) error_log(__METHOD__."($url_to,$url_from) can't unlink existing $url_to!");
+			if (self::LOG_LEVEL)
+			{
+				error_log(__METHOD__."($url_to,$url_from) can't unlink existing $url_to!");
+			}
 			return false;
 		}
 		return rename(Vfs::decodePath($from['path']),Vfs::decodePath($to['path']));
@@ -400,7 +433,10 @@ 
 		// check access rights (in real filesystem AND by mount perms)
 		if (file_exists($path) || !file_exists($parent) || !is_writable($parent) || !Vfs::check_access($parent_url,Vfs::WRITABLE))
 		{
-			if (self::LOG_LEVEL) error_log(__METHOD__."($url) permission denied!");
+			if (self::LOG_LEVEL)
+			{
+				error_log(__METHOD__."($url) permission denied!");
+			}
 			return false;
 		}
 		return mkdir($path, 0700, $recursive);	// setting mode 0700 allows (only) apache to write into the dir
@@ -426,7 +462,10 @@ 
 		// check access rights (in real filesystem AND by mount perms)
 		if (!file_exists($path) || !is_writable($parent) || !Vfs::check_access(Vfs::dirname($url),Vfs::WRITABLE))
 		{
-			if (self::LOG_LEVEL) error_log(__METHOD__."($url) permission denied!");
+			if (self::LOG_LEVEL)
+			{
+				error_log(__METHOD__."($url) permission denied!");
+			}
 			return false;
 		}
 		return rmdir($path);
@@ -448,7 +487,10 @@ 
 		// check access rights (in real filesystem AND by mount perms)
 		if (!file_exists($path) || !is_writable($parent) || !Vfs::check_access(Vfs::dirname($url),Vfs::WRITABLE))
 		{
-			if (self::LOG_LEVEL) error_log(__METHOD__."($url) permission denied!");
+			if (self::LOG_LEVEL)
+			{
+				error_log(__METHOD__."($url) permission denied!");
+			}
 			return false;
 		}
 		return touch($path,$time,$atime);
@@ -511,7 +553,10 @@ 
 	 */
 	function dir_opendir ( $url, $options )
 	{
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url,$options)");
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."($url,$options)");
+		}
 
 		$this->opened_dir = null;
 
@@ -521,7 +566,10 @@ 
 
 		if (!($this->opened_dir = opendir($path)))
 		{
-			if (self::LOG_LEVEL > 0) error_log(__METHOD__."($url,$options) opendir('$path') failed!");
+			if (self::LOG_LEVEL > 0)
+			{
+				error_log(__METHOD__."($url,$options) opendir('$path') failed!");
+			}
 			return false;
 		}
 		return true;
@@ -577,7 +625,10 @@ 
 				$stat['mode'] = $stat[2] = $stat['mode'] & ~0222;
 			}
 		}
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__."($url,$flags) path=$path, mount_mode=".sprintf('0%o',$mode).", mode=".sprintf('0%o',$stat['mode']).'='.Vfs::int2mode($stat['mode']));
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__."($url,$flags) path=$path, mount_mode=".sprintf('0%o',$mode).", mode=".sprintf('0%o',$stat['mode']).'='.Vfs::int2mode($stat['mode']));
+		}
 		return $stat;
 	}
 
@@ -598,14 +649,23 @@ 
 
 			$ignore = !($file === false ||							// stop if no more dirs or
 				($file != '.' && $file != '..' ));					// file not . or ..
-			if (self::LOG_LEVEL > 1 && $ignore) error_log(__METHOD__.'() ignoring '.array2string($file));
+			if (self::LOG_LEVEL > 1 && $ignore)
+			{
+				error_log(__METHOD__.'() ignoring '.array2string($file));
+			}
 		}
 		while ($ignore);
 
 		// encode special chars messing up url's
-		if ($file !== false) $file = Vfs::encodePathComponent($file);
+		if ($file !== false)
+		{
+			$file = Vfs::encodePathComponent($file);
+		}
 
-		if (self::LOG_LEVEL > 1) error_log(__METHOD__.'() returning '.array2string($file));
+		if (self::LOG_LEVEL > 1)
+		{
+			error_log(__METHOD__.'() returning '.array2string($file));
+		}
 
 		return $file;
 	}
@@ -760,9 +820,17 @@ 
 		list($url,$query) = explode('?',$_url,2);
 		$get = null;
 		parse_str($query,$get);
-		if (empty($get['url'])) return false;	// no download url given for this mount-point
+		if (empty($get['url']))
+		{
+			return false;
+		}
+		// no download url given for this mount-point
 
-		if (!($mount_url = Vfs::mount_url($_url))) return false;	// no mount url found, should not happen
+		if (!($mount_url = Vfs::mount_url($_url)))
+		{
+			return false;
+		}
+		// no mount url found, should not happen
 		list($mount_url) = explode('?',$mount_url);
 
 		$relpath = substr($url,strlen($mount_url));

api/src/Vfs/Links/StreamWrapper.php

Braces +26 added lines, -7 removed lines

@@ -26,7 +26,9 @@ 
  */
 if (!class_exists('EGroupware\\Api\\Vfs\\Links\\LinksParent', false))
 {
-	class LinksParent extends Vfs\Sqlfs\StreamWrapper {}
+	class LinksParent extends Vfs\Sqlfs\StreamWrapper
+	{
+}
 }
 
 /**
@@ -116,7 +118,10 @@ 
 			$access = Api\Link::file_access($app,$id,$required,$rel_path,Vfs::$user);
 			$what = "from Api\Link::file_access('$app',$id,$required,'$rel_path,".Vfs::$user.")";
 		}
-		if (self::DEBUG) error_log(__METHOD__."($url,$check) user=".Vfs::$user." ($what) ".($access?"access granted ($app:$id:$rel_path)":'no access!!!'));
+		if (self::DEBUG)
+		{
+			error_log(__METHOD__."($url,$check) user=".Vfs::$user." ($what) ".($access?"access granted ($app:$id:$rel_path)":'no access!!!'));
+		}
 		return $access;
 	}
 
@@ -180,7 +185,10 @@ 
 				);
 			}
 		}
-		if (self::DEBUG) error_log(__METHOD__."('$url', $flags) calling parent::url_stat(,,".array2string($eacl_check).') returning '.array2string($ret));
+		if (self::DEBUG)
+		{
+			error_log(__METHOD__."('$url', $flags) calling parent::url_stat(,,".array2string($eacl_check).') returning '.array2string($ret));
+		}
 		return $ret;
 	}
 
@@ -238,19 +246,30 @@ 
 
 		if($path[0] != '/')
 		{
-			if (strpos($path,'?') !== false) $query = Vfs::parse_url($path,PHP_URL_QUERY);
+			if (strpos($path,'?') !== false)
+			{
+				$query = Vfs::parse_url($path,PHP_URL_QUERY);
+			}
 			$path = Vfs::parse_url($path,PHP_URL_PATH).($query ? '?'.$query : '');
 		}
 		list(,$apps,$app,$id) = explode('/',$path);
 
 		$ret = false;
-		if ($apps == 'apps' && $app && !$id || self::check_extended_acl($path,Vfs::WRITABLE))	// app directory itself is allways ok
+		if ($apps == 'apps' && $app && !$id || self::check_extended_acl($path,Vfs::WRITABLE))
+		{
+			// app directory itself is allways ok
 		{
-			$current_is_root = Vfs::$is_root; Vfs::$is_root = true;
+			$current_is_root = Vfs::$is_root;
+		}
+		Vfs::$is_root = true;
 			$current_user = Vfs::$user; Vfs::$user = 0;
 
 			$ret = parent::mkdir($path,0,$options|STREAM_MKDIR_RECURSIVE);
-			if ($id) parent::chmod($path,0);	// no other rights
+			if ($id)
+			{
+				parent::chmod($path,0);
+			}
+			// no other rights
 
 			Vfs::$user = $current_user;
 			Vfs::$is_root = $current_is_root;

setup/fix_mysql_charset.php

Braces +33 added lines, -9 removed lines

@@ -41,7 +41,10 @@ 
 $ServerInfo = $db->Link_ID->ServerInfo();
 $db_version = (float) $ServerInfo['version'];
 
-if ($running_standalone || $_REQUEST['debug']) echo "<p>DB-Type='<b>{$GLOBALS['egw_setup']->db->Type}</b>', DB-Version=<b>$db_version</b> ($ServerInfo[description]), eGroupWare system_charset='<b>{$GLOBALS['egw_setup']->system_charset}</b>', DB-connection charset was '<b>{$GLOBALS['egw_setup']->db_charset_was}</b>'</p>\n";
+if ($running_standalone || $_REQUEST['debug'])
+{
+	echo "<p>DB-Type='<b>{$GLOBALS['egw_setup']->db->Type}</b>', DB-Version=<b>$db_version</b> ($ServerInfo[description]), eGroupWare system_charset='<b>{$GLOBALS['egw_setup']->system_charset}</b>', DB-connection charset was '<b>{$GLOBALS['egw_setup']->db_charset_was}</b>'</p>\n";
+}
 
 $mysql_system_charset = isset($charset2mysql[$GLOBALS['egw_setup']->system_charset]) ?
 	$charset2mysql[$GLOBALS['egw_setup']->system_charset] : $GLOBALS['egw_setup']->system_charset;
@@ -84,15 +87,21 @@ 
 				list(,$type,$size) = $matches;
 				list($charset) = explode('_',$column['Collation']);
 
-				if (isset($mysql2charset[$charset])) $charset = $mysql2charset[$charset];
+				if (isset($mysql2charset[$charset]))
+				{
+					$charset = $mysql2charset[$charset];
+				}
 
 				if ($charset != $GLOBALS['egw_setup']->system_charset)
 				{
 					$col = $column['Field'];
 
-					if ($type == 'varchar' || $type == 'char')	// old schema_proc (pre 1.0.1) used also char
+					if ($type == 'varchar' || $type == 'char')
+					{
+						// old schema_proc (pre 1.0.1) used also char
 					{
 						$type = 'varchar('.$size.')';
+					}
 						$bintype = 'varbinary('.$size.')';
 					}
 					else
@@ -125,7 +134,10 @@ 
 			}
 		}
 		list($charset) = explode('_',$collation);
-		if (isset($mysql2charset[$charset])) $charset = $mysql2charset[$charset];
+		if (isset($mysql2charset[$charset]))
+		{
+			$charset = $mysql2charset[$charset];
+		}
 		if ($charset != $GLOBALS['egw_setup']->system_charset)
 		{
 			$alter_table[] = " DEFAULT CHARACTER SET $mysql_system_charset";
@@ -134,7 +146,10 @@ 
 		{
 			$alter_table = "ALTER TABLE $table\n".implode(",\n",$alter_table);
 
-			if ($running_standalone || $_REQUEST['debug']) echo '<p>'.nl2br($alter_table)."</p>\n";
+			if ($running_standalone || $_REQUEST['debug'])
+			{
+				echo '<p>'.nl2br($alter_table)."</p>\n";
+			}
 			if (!$db->query($alter_table,__LINE__,__FILE__))
 			{
 				echo "<p>SQL Error: ".nl2br($alter_table)."</p>\n";
@@ -150,7 +165,10 @@ 
 			{
 				$alter_table_back = "ALTER TABLE $table\n".implode(",\n",$alter_table_back);
 
-				if ($running_standalone || $_REQUEST['debug']) echo '<p>'.nl2br($alter_table_back)."</p>\n";
+				if ($running_standalone || $_REQUEST['debug'])
+				{
+					echo '<p>'.nl2br($alter_table_back)."</p>\n";
+				}
 				if (!$db->query($alter_table_back,__LINE__,__FILE__))
 				{
 					echo "<p><b>SQL Error</b>: ".nl2br($alter_table_back)."</p>\n";
@@ -168,7 +186,10 @@ 
 	if (preg_match('/CHARACTER SET ([a-z1-9_-]+) /i',$create_db,$matches) && $matches[1] != $mysql_system_charset)
 	{
 		$alter_db = "ALTER DATABASE `$db->Database` DEFAULT CHARACTER SET $mysql_system_charset";
-		if ($running_standalone || $_REQUEST['debug']) echo '<p>'.$alter_db."</p>\n";
+		if ($running_standalone || $_REQUEST['debug'])
+		{
+			echo '<p>'.$alter_db."</p>\n";
+		}
 		$db->query($alter_db,__LINE__,__FILE__);
 	}
 }
@@ -176,5 +197,8 @@ 
 {
 	echo "<p>$tables_modified tables changed to our system_charset {$GLOBALS['egw_setup']->system_charset}($mysql_system_charset)</p>\n";
 
-	if ($running_standalone) $GLOBALS['egw_setup']->html->show_footer();
-}
+	if ($running_standalone)
+	{
+		$GLOBALS['egw_setup']->html->show_footer();
+	}
+	}

setup/check_install.php

Braces +119 added lines, -30 removed lines

@@ -239,10 +239,15 @@ 
 		foreach(explode(PATH_SEPARATOR,$open_basedir) as $dir)
 		{
 			$dir = realpath($dir);
-			if (($sp_visible = substr($session_path,0,strlen($dir)) == $dir)) break;
+			if (($sp_visible = substr($session_path,0,strlen($dir)) == $dir))
+			{
+				break;
+			}
 		}
 	}
-	if ($sp_visible)	// only check if session_save_path is visible by webserver
+	if ($sp_visible)
+	{
+		// only check if session_save_path is visible by webserver
 	{
 		$checks[$session_path] = array(
 			'func' => 'permission_check',
@@ -251,17 +256,25 @@ 
 			'error' => lang('You will NOT be able to log into eGroupWare using PHP sessions: "session could not be verified" !!!'),
 		);
 	}
+	}
 }
 $setup_info = $GLOBALS['egw_setup']->detection->get_versions();
 foreach($setup_info as $app => $app_data)
 {
-	if (!isset($app_data['check_install'])) continue;
+	if (!isset($app_data['check_install']))
+	{
+		continue;
+	}
 
 	foreach ($app_data['check_install'] as $name => $data)
 	{
 		if (isset($checks[$name]))
 		{
-			if ($checks[$name] == $data) continue;	// identical check --> ignore it
+			if ($checks[$name] == $data)
+			{
+				continue;
+			}
+			// identical check --> ignore it
 
 			if ($data['func'] == 'pear_check' || in_array($data['func'],array('extension_check','php_ini_check')) && !isset($data['warning']))
 			{
@@ -269,9 +282,18 @@ 
 				{
 					$checks[$name]['from'] = array($checks[$name]['from']);
 				}
-				if (!isset($data['from'])) $data['from'] = $app;
-				if (!isset($checks[$name]['from']) || !is_array($checks[$name]['from'])) $checks[$name]['from'] = array();
-				if (!in_array($data['from'],$checks[$name]['from'])) $checks[$name]['from'][] = $data['from'];
+				if (!isset($data['from']))
+				{
+					$data['from'] = $app;
+				}
+				if (!isset($checks[$name]['from']) || !is_array($checks[$name]['from']))
+				{
+					$checks[$name]['from'] = array();
+				}
+				if (!in_array($data['from'],$checks[$name]['from']))
+				{
+					$checks[$name]['from'][] = $data['from'];
+				}
 			}
 			else
 			{
@@ -280,7 +302,10 @@ 
 		}
 		else
 		{
-			if (!isset($data['from'])) $data['from'] = $app;
+			if (!isset($data['from']))
+			{
+				$data['from'] = $app;
+			}
 			$checks[$name] = $data;
 		}
 		//echo "added check $data[func]($name) for $app"; _debug_array($data);
@@ -298,7 +323,10 @@ 
 		}
 	}
 }
-if ($checks) $sorted_checks += $checks;
+if ($checks)
+{
+	$sorted_checks += $checks;
+}
 
 function php_version($name,$args)
 {
@@ -351,22 +379,35 @@ 
 	}
 	@include_once 'PEAR/Config.php';
 
-	if (!class_exists('PEAR_Config')) return false;
+	if (!class_exists('PEAR_Config'))
+	{
+		return false;
+	}
 
 	$config = new PEAR_Config('',$pear_config);
 	//echo "<pre>config = ".print_r($config,true)."</pre>\n";
 
-	if (empty($channel)) $channel = $config->get('default_channel');
+	if (empty($channel))
+	{
+		$channel = $config->get('default_channel');
+	}
 	//echo "<pre>channel = ".print_r($channel,true)."</pre>\n";
 
-	if (!method_exists($config,'getRegistry')) return false;	// PEAR version to old
+	if (!method_exists($config,'getRegistry'))
+	{
+		return false;
+	}
+	// PEAR version to old
 
 	$reg = &$config->getRegistry();
 	//echo "<pre>reg = ".print_r($reg,true)."</pre>\n";
 
 	// a bug in pear causes an endless loop if the install-dir does not exist
 	// bug reported: http://pear.php.net/bugs/bug.php?id=11317
-	if (!file_exists($reg->install_dir)) return false;
+	if (!file_exists($reg->install_dir))
+	{
+		return false;
+	}
 
 	$installed = $reg->packageInfo(null,null,$channel);
 
@@ -376,7 +417,10 @@ 
 	{
 		$name = isset($package['package']) ? $package['package'] : $package['name'];
 		$version = $package['version'];
-		if (is_array($version)) $version = $version['release'];
+		if (is_array($version))
+		{
+			$version = $version['release'];
+		}
 
 		$packages[$name] = $version;
 		//echo "<p>$name: ".print_r($package['version'],true)."</p>\n";
@@ -415,7 +459,10 @@ 
 		{
 			$pear_available = $found = true;
 			// check if package is installed
-			if ($package && isset($pear_packages[$package])) $available = true;
+			if ($package && isset($pear_packages[$package]))
+			{
+				$available = true;
+			}
 			// check if it's the right version
 			$version_available = $pear_packages[$package ? $package : 'PEAR'];
 		}
@@ -425,7 +472,10 @@ 
 			{
 				$pear_available = @include_once('PEAR.php');
 
-				if (!class_exists('PEAR')) $pear_available = false;
+				if (!class_exists('PEAR'))
+				{
+					$pear_available = false;
+				}
 			}
 			$found = $pear_available;
 			if ($pear_available && $package)
@@ -434,7 +484,10 @@ 
 
 				$found = @include_once($file);
 
-				if (!class_exists($package)) $found = false;
+				if (!class_exists($package))
+				{
+					$found = false;
+				}
 			}
 		}
 	}
@@ -445,10 +498,13 @@ 
 		($available ? ($version_available ? $version_available : lang('True')) :
 		($found ? lang('Found, but unknown version') : lang('False')))."</span></div>\n";
 
-	if (!$available)	// give further info only if not availible
+	if (!$available)
+	{
+		// give further info only if not availible
 	{
 		echo '<div class="setup_info">' . lang('PEAR%1 is needed by: %2.',$package ? '::'.$package : '',
 			is_array($args['from']) ? implode(', ',$args['from']) : $args['from']);
+	}
 
 		// if using Composer, dont confuse user with PEAR ;-)
 		if (file_exists(EGW_SERVER_ROOT.'/vendor'))
@@ -541,34 +597,55 @@ 
 
 function verbosePerms( $in_Perms )
 {
-	if($in_Perms & 0x1000)     // FIFO pipe
+	if($in_Perms & 0x1000)
+	{
+		// FIFO pipe
 	{
 		$sP = 'p';
 	}
-	elseif($in_Perms & 0x2000) // Character special
+	}
+	elseif($in_Perms & 0x2000)
+	{
+		// Character special
 	{
 		$sP = 'c';
 	}
-	elseif($in_Perms & 0x4000) // Directory
+	}
+	elseif($in_Perms & 0x4000)
+	{
+		// Directory
 	{
 		$sP = 'd';
 	}
-	elseif($in_Perms & 0x6000) // Block special
+	}
+	elseif($in_Perms & 0x6000)
+	{
+		// Block special
 	{
 		$sP = 'b';
 	}
-	elseif($in_Perms & 0x8000) // Regular
+	}
+	elseif($in_Perms & 0x8000)
+	{
+		// Regular
 	{
 		$sP = '-';
 	}
-	elseif($in_Perms & 0xA000) // Symbolic Link
+	}
+	elseif($in_Perms & 0xA000)
+	{
+		// Symbolic Link
 	{
 		$sP = 'l';
 	}
-	elseif($in_Perms & 0xC000) // Socket
+	}
+	elseif($in_Perms & 0xC000)
+	{
+		// Socket
 	{
 		$sP = 's';
 	}
+	}
 	else                         // UNKNOWN
 	{
 		$sP = 'u';
@@ -709,9 +786,15 @@ 
 				$Ok = $Ok && permission_check(($name!='.'?$name.'/':'').$file,$args,False);
 			}
 		}
-		if ($handle) closedir($handle);
+		if ($handle)
+		{
+			closedir($handle);
+		}
+	}
+	if ($verbose)
+	{
+		echo "\n";
 	}
-	if ($verbose) echo "\n";
 
 	return $Ok;
 }
@@ -719,7 +802,10 @@ 
 function mk_value($value)
 {
 	$matches = null;
-	if (!preg_match('/^([0-9]+)([mk]+)$/i',$value,$matches)) return $value;
+	if (!preg_match('/^([0-9]+)([mk]+)$/i',$value,$matches))
+	{
+		return $value;
+	}
 
 	return (strtolower($matches[2]) == 'm' ? 1024*1024 : 1024) * (int) $matches[1];
 }
@@ -848,7 +934,8 @@ 
 		'T_footer' => 'footer.tpl',
 	));
 	$ConfigDomain = $_REQUEST['ConfigDomain'];
-	if (@$_GET['intro']) {
+	if (@$_GET['intro'])
+	{
 		if(($ConfigLang = setup::get_lang()))
 		{
 			$GLOBALS['egw_setup']->set_cookie('ConfigLang',$ConfigLang,(int) (time()+(1200*9)),'/');
@@ -865,7 +952,9 @@ 
 		echo '<p><a href="manageheader.php">'.lang('Skip the installation tests (not recommended)')."</a></p>\n";
 		$setup_tpl->pparse('out','T_footer');
 		exit;
-	} else {
+	}
+	else
+	{
 		$GLOBALS['egw_setup']->html->show_header(lang('Checking the eGroupWare Installation'),False,'config',$ConfigDomain ? $ConfigDomain . '(' . @$GLOBALS['egw_domain'][$ConfigDomain]['db_type'] . ')' : '');
 		echo '<h1>'.lang('Checking the eGroupWare Installation')."</h1>\n";
 		# echo "<pre style=\"text-align: left;\">\n";;

setup/manageheader.php

Braces +38 added lines, -10 removed lines

@@ -84,14 +84,21 @@ 
 {
 	$GLOBALS['egw_info']['server']['server_root'] = EGW_SERVER_ROOT;
 }
-if (isset($_POST['setting']))	// Post of the header-form
+if (isset($_POST['setting']))
 {
-	$validation_errors = check_header_form();	// validate the submitted form
+	// Post of the header-form
+{
+	$validation_errors = check_header_form();
+}
+// validate the submitted form
 }
-if (!isset($_POST['action']) || $validation_errors)	// generate form to edit the header
+if (!isset($_POST['action']) || $validation_errors)
+{
+	// generate form to edit the header
 {
 	show_header_form($validation_errors);
 }
+}
 else
 {
 	$newheader = $GLOBALS['egw_setup']->header->generate($GLOBALS['egw_info'],$GLOBALS['egw_domain']);
@@ -156,7 +163,10 @@ 
 	// setting the non-domain settings from the posted content
 	foreach($_POST['setting'] as $name => $value)
 	{
-		if (get_magic_quotes_gpc()) $value = stripslashes($value);
+		if (get_magic_quotes_gpc())
+		{
+			$value = stripslashes($value);
+		}
 
 		switch($name)
 		{
@@ -166,7 +176,10 @@ 
 				$GLOBALS['egw_info']['server'][$name] = $value == 'True';
 				break;
 			case 'new_admin_password':
-				if ($value) $GLOBALS['egw_info']['server']['header_admin_password'] = $value;
+				if ($value)
+				{
+					$GLOBALS['egw_info']['server']['header_admin_password'] = $value;
+				}
 				break;
 			default:
 				$GLOBALS['egw_info']['server'][$name] = $value;
@@ -186,11 +199,17 @@ 
 
 		foreach($_POST['setting_'.$key] as $name => $value)
 		{
-			if (get_magic_quotes_gpc()) $value = stripslashes($value);
+			if (get_magic_quotes_gpc())
+			{
+				$value = stripslashes($value);
+			}
 
 			if ($name == 'new_config_passwd')
 			{
-				if ($value) $GLOBALS['egw_domain'][$domain]['config_passwd'] = $value;
+				if ($value)
+				{
+					$GLOBALS['egw_domain'][$domain]['config_passwd'] = $value;
+				}
 				continue;
 			}
 			$GLOBALS['egw_domain'][$domain][$name] = $value;
@@ -255,7 +274,10 @@ 
 	}
 	$setup_tpl->set_var('js_default_db_ports',$js_default_db_ports);
 
-	if ($validation_errors) $setup_tpl->set_var('detected','<ul><li>'.implode("</li>\n<li>",$validation_errors)."</li>\n</ul>\n");
+	if ($validation_errors)
+	{
+		$setup_tpl->set_var('detected','<ul><li>'.implode("</li>\n<li>",$validation_errors)."</li>\n</ul>\n");
+	}
 
 	if ($_POST['adddomain'])
 	{
@@ -275,7 +297,10 @@ 
 				$setup_tpl->set_var($name.($GLOBALS['egw_info']['server'][$name] ? '_yes' : '_no'),' selected="selected"');
 				break;
 			default:
-				if (!is_array($value)) $setup_tpl->set_var($name,htmlspecialchars($value));
+				if (!is_array($value))
+				{
+					$setup_tpl->set_var($name,htmlspecialchars($value));
+				}
 				break;
 		}
 	}
@@ -300,10 +325,13 @@ 
 		$setup_tpl->set_var('db_domain',htmlspecialchars($domain));
 		foreach($data as $name => $value)
 		{
-			if ($name == 'db_port' && !$value)	// Set default here if the admin didn't set a port yet
+			if ($name == 'db_port' && !$value)
+			{
+				// Set default here if the admin didn't set a port yet
 			{
 				$value = $GLOBALS['egw_setup']->header->default_db_ports[$data['db_type']];
 			}
+			}
 			$setup_tpl->set_var($name,htmlspecialchars($value));
 		}
 		$dbtype_options = '';

setup/inc/class.setup_cmd_hooks.inc.php

Braces +9 added lines, -2 removed lines

@@ -47,7 +47,11 @@ 
 	 */
 	protected function exec($check_only=false)
 	{
-		if ($check_only) return true;	// nothing to check, no arguments ...
+		if ($check_only)
+		{
+			return true;
+		}
+		// nothing to check, no arguments ...
 
 		// instanciate setup object and check authorisation
 		$this->check_setup_auth($this->config_user,$this->config_passwd,$this->domain);
@@ -57,7 +61,10 @@ 
 		global $setup_info;
 		foreach($setup_info as $appname => $info)
 		{
-			if ($info['currentver']) self::$egw_setup->register_hooks($appname);
+			if ($info['currentver'])
+			{
+				self::$egw_setup->register_hooks($appname);
+			}
 		}
 		$this->restore_db();
 

setup/inc/class.setup_detection.inc.php

Braces +20 added lines, -5 removed lines

@@ -65,7 +65,9 @@ 
 					foreach($GLOBALS['egw_setup']->db->select($GLOBALS['egw_setup']->applications_table,'*',false,__LINE__,__FILE__) as $row)
 					{
 						$app = $row['app_name'];
-						if (!isset($setup_info[$app]))	// app source no longer there
+						if (!isset($setup_info[$app]))
+						{
+							// app source no longer there
 						{
 							$setup_info[$app] = array(
 								'name' => $app,
@@ -73,6 +75,7 @@ 
 								'version' => 'deleted',
 							);
 						}
+						}
 						$setup_info[$app]['currentver'] = $row['app_version'];
 						$setup_info[$app]['enabled'] = $row['app_enabled'];
 					}
@@ -212,7 +215,9 @@ 
 					if ($setup_info['depends'][$depkey]['status'] == False)
 					{
 						/* Only set this if it has not already failed to upgrade - Milosch */
-						if($setup_info[$key]['status'] != 'F')//&& $setup_info[$key]['status'] != 'C')
+						if($setup_info[$key]['status'] != 'F')
+						{
+							//&& $setup_info[$key]['status'] != 'C')
 						{
 							/* Added check for status U - uninstalled apps carry this flag (upgrade from nothing == install).
 							 * This should fix apps showing post-install dep failure when they are not yet installed.
@@ -220,6 +225,7 @@ 
 							if($setup_info[$key]['status'] == 'C' || $setup_info[$key]['status'] == 'U')
 							{
 								$setup_info[$key]['status'] = 'D';
+						}
 							}
 							else
 							{
@@ -292,7 +298,10 @@ 
 	 */
 	function check_db($setup_info=null)
 	{
-		if (!$setup_info) $setup_info = $GLOBALS['setup_info'];
+		if (!$setup_info)
+		{
+			$setup_info = $GLOBALS['setup_info'];
+		}
 
 		try {	// catch DB errors
 			if (!$GLOBALS['egw_setup']->db->Link_ID)
@@ -482,11 +491,14 @@ 
 				{
 					echo '<br>check_app_tables(): Checking: ' . $appname . ',table: ' . $val;
 				}
-				if(!in_array($val,$tables) && !in_array(strtolower($val),$tables))	// names in tables might be lowercase
+				if(!in_array($val,$tables) && !in_array(strtolower($val),$tables))
+				{
+					// names in tables might be lowercase
 				{
 					if($GLOBALS['DEBUG'])
 					{
 						echo '<br>check_app_tables(): ' . $val . ' missing!';
+				}
 					}
 					if(!$any)
 					{
@@ -543,9 +555,12 @@ 
 			$msg = lang('does not exist');
 			return false;
 		}
-		if (!@is_writeable($dir) && $_SERVER['HTTP_HOST'])	// only do the check if we run by the webserver
+		if (!@is_writeable($dir) && $_SERVER['HTTP_HOST'])
+		{
+			// only do the check if we run by the webserver
 		{
 			$msg = lang('is not writeable by the webserver');
+		}
 			return false;
 		}
 		if ($check_in_docroot)