EGroupware /
egroupware
| Conditions | 19 |
| Paths | 395 |
| Total Lines | 78 |
| Code Lines | 44 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | #!/usr/bin/env php |
||
| 24 | function check_namespace($file) |
||
| 25 | { |
||
| 26 | global $prog; |
||
| 27 | if (basename($file) == $prog) return true; // dont fix ourself ;-) |
||
| 28 | |||
| 29 | if (($content = file_get_contents($file)) === false) return false; |
||
| 30 | |||
| 31 | // replace commented lines with empty ones |
||
| 32 | $lines = preg_replace_callback('#(//.*$|/\\*.*\\*/)#msU', function($matches) |
||
| 33 | { |
||
| 34 | return str_repeat("\n", substr_count($matches[0], "\n")); |
||
| 35 | }, $content); |
||
| 36 | |||
| 37 | // find classes declared in file itself, in case they are used |
||
| 38 | $declared = array(); |
||
| 39 | foreach(explode("\n", $lines) as $num => $line) |
||
| 40 | { |
||
| 41 | $matches = null; |
||
| 42 | if (preg_match('/class\s+([^ ]+)/', $line, $matches)) |
||
| 43 | { |
||
| 44 | $declared[] = $matches[1]; |
||
| 45 | } |
||
| 46 | } |
||
| 47 | $namespace = ''; |
||
| 48 | $use = array(); |
||
| 49 | $allways = array('self', 'parent', 'static'); |
||
| 50 | foreach(explode("\n", $lines) as $num => $line) |
||
| 51 | { |
||
| 52 | $matches = null; |
||
| 53 | if (preg_match('/namespace\s+([A-Za-z0-9_\\\\]+);/', $line, $matches)) |
||
| 54 | { |
||
| 55 | $namespace = $matches[1]; |
||
| 56 | $use = array(); |
||
| 57 | } |
||
| 58 | if ($namespace === '') continue; |
||
| 59 | |||
| 60 | if (preg_match('/use\s+([^;]+);/', $line, $matches)) |
||
| 61 | { |
||
| 62 | foreach(preg_split('/,\s*/', $matches[1]) as $alias) |
||
| 63 | { |
||
| 64 | $parts = explode('\\', $alias); |
||
| 65 | $use[$alias] = array_pop($parts); |
||
| 66 | } |
||
| 67 | } |
||
| 68 | $all_matches_raw = array(); |
||
| 69 | if (preg_match_all('/[=\s]new\s+([a-z0-9_\\\\]+)\s*\(/i', $line, $matches)) |
||
| 70 | { |
||
| 71 | $all_matches_raw = $matches[1]; |
||
| 72 | } |
||
| 73 | if (preg_match_all('/[\s,\(]([a-z0-9_\\\\]+)::/i', $line, $matches)) |
||
| 74 | { |
||
| 75 | $all_matches_raw = array_merge($all_matches_raw, $matches[1]); |
||
| 76 | } |
||
| 77 | $all_matches = array_unique($all_matches_raw); |
||
| 78 | foreach($all_matches as $c => $class) |
||
| 79 | { |
||
| 80 | $parts = explode('\\', $class); |
||
| 81 | $first_part = array_shift($parts); |
||
| 82 | if (in_array($class, $allways) || in_array($class, $declared) || $class[0] == '\\' || in_array($first_part, $use)) |
||
| 83 | { |
||
| 84 | unset($all_matches[$c]); |
||
| 85 | continue; |
||
| 86 | } |
||
| 87 | if (file_exists(dirname($file).'/'.str_replace('\\', '/', $class).'.php')) |
||
| 88 | { |
||
| 89 | $use[$namespace.'\\'.$class] = $class; |
||
| 90 | unset($all_matches[$c]); |
||
| 91 | continue; |
||
| 92 | } |
||
| 93 | } |
||
| 94 | if ($all_matches) |
||
|
|
|||
| 95 | { |
||
| 96 | echo (1+$num).":\t".$line."\n"; |
||
| 97 | echo "--> ".implode(', ', $all_matches)."\n\n"; |
||
| 98 | } |
||
| 99 | } |
||
| 100 | //print_r($use); |
||
| 101 | return true; |
||
| 102 | } |
||
| 178 | } |
Loading history...
This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.
Consider making the comparison explicit by using
empty(..)or! empty(...)instead.