EGroupware /
egroupware
| Conditions | 78 |
| Paths | > 20000 |
| Total Lines | 282 |
| Code Lines | 151 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 2 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
Methods with many parameters are not only hard to understand, but their parameters also often become inconsistent when you need more, or different data.
There are several approaches to avoid long parameter lists:
| 1 | <?php |
||
| 489 | protected function process_search(&$criteria, &$only_keys=True, &$order_by='', &$extra_cols='', &$wildcard='', &$op='AND', &$filter=null, &$join='') |
||
| 490 | { |
||
| 491 | if ($only_keys === false) |
||
| 492 | { |
||
| 493 | $only_keys = $this->table_name.'.*'; |
||
| 494 | } |
||
| 495 | $extra_join_added = $join && strpos($join, $this->extra_join) !== false; |
||
| 496 | if ($criteria && is_string($criteria)) |
||
| 497 | { |
||
| 498 | $extra_join_added = true; // we have NOT added the join, as we use a sub-query and therefore not need it |
||
| 499 | |||
| 500 | $criteria = $this->search2criteria($criteria, $wildcard, $op); |
||
| 501 | } |
||
| 502 | if ($criteria && is_array($criteria)) |
||
| 503 | { |
||
| 504 | // check if we search in the custom fields |
||
| 505 | if (isset($criteria[$this->extra_value])) |
||
| 506 | { |
||
| 507 | // we should check if the CF is (still) available, but that makes the slow search even slower :( |
||
| 508 | if (($negate = $criteria[$this->extra_value][0] === '!')) |
||
| 509 | { |
||
| 510 | $criteria[$this->extra_value] = substr($criteria[$this->extra_value],1); |
||
| 511 | } |
||
| 512 | $criteria[] = $this->extra_table.'.'.$this->extra_value . ' ' .($negate ? 'NOT ' : ''). |
||
| 513 | $this->db->capabilities[Db::CAPABILITY_CASE_INSENSITIV_LIKE]. ' ' . |
||
| 514 | $this->db->quote($wildcard.$criteria[$this->extra_value].$wildcard); |
||
| 515 | unset($criteria[$this->extra_value]); |
||
| 516 | } |
||
| 517 | // replace ambiguous auto-id with (an exact match of) table_name.autoid |
||
| 518 | if (isset($criteria[$this->autoinc_id])) |
||
| 519 | { |
||
| 520 | if ($criteria[$this->autoinc_id]) |
||
| 521 | { |
||
| 522 | $criteria[] = $this->db->expression($this->table_name,$this->table_name.'.', |
||
| 523 | array($this->autoinc_id => $criteria[$this->autoinc_id])); |
||
| 524 | } |
||
| 525 | unset($criteria[$this->autoinc_id]); |
||
| 526 | } |
||
| 527 | // replace ambiguous column with (an exact match of) table_name.column |
||
| 528 | foreach($criteria as $name => $val) |
||
| 529 | { |
||
| 530 | // only add extra_join, if we really need it |
||
| 531 | if (!$extra_join_added && ( |
||
| 532 | is_int($name) && strpos($val, $this->extra_value) !== false || |
||
| 533 | is_string($name) && $this->is_cf($name) |
||
| 534 | )) |
||
| 535 | { |
||
| 536 | $join .= $this->extra_join; |
||
| 537 | $extra_join_added = true; |
||
| 538 | } |
||
| 539 | $extra_columns = $this->db->get_table_definitions($this->app, $this->extra_table); |
||
| 540 | if(is_string($name) && $extra_columns['fd'][array_search($name, $this->db_cols)]) |
||
| 541 | { |
||
| 542 | $criteria[] = $this->db->expression($this->table_name,$this->table_name.'.',array( |
||
| 543 | array_search($name, $this->db_cols) => $val, |
||
| 544 | )); |
||
| 545 | unset($criteria[$name]); |
||
| 546 | } |
||
| 547 | elseif (is_string($name) && $this->is_cf($name)) |
||
| 548 | { |
||
| 549 | if ($op != 'AND') |
||
| 550 | { |
||
| 551 | $name = substr($name, 1); |
||
| 552 | if (($negate = $criteria[$name][0] === '!')) |
||
| 553 | { |
||
| 554 | $val = substr($val,1); |
||
| 555 | } |
||
| 556 | $cfcriteria[] = '(' . $this->extra_table.'.'.$this->extra_value . ' ' .($negate ? 'NOT ' : ''). |
||
| 557 | $this->db->capabilities[Db::CAPABILITY_CASE_INSENSITIV_LIKE]. ' ' . |
||
| 558 | $this->db->quote($wildcard.$val.$wildcard) . ' AND ' . |
||
| 559 | $this->extra_table.'.'.$this->extra_key . ' = ' . $this->db->quote($name) . |
||
| 560 | ')'; |
||
| 561 | unset($criteria[self::CF_PREFIX.$name]); |
||
| 562 | } |
||
| 563 | else |
||
| 564 | { |
||
| 565 | // criteria operator is AND we remap the criteria to be transformed to filters |
||
| 566 | $filter[$name] = $val; |
||
| 567 | unset($criteria[$name]); |
||
| 568 | } |
||
| 569 | } |
||
| 570 | } |
||
| 571 | if ($cfcriteria && $op =='OR') $criteria[] = implode(' OR ',$cfcriteria); |
||
| 572 | } |
||
| 573 | if($only_keys === true) |
||
| 574 | { |
||
| 575 | // Expand to keys here, so table_name can be prepended below |
||
| 576 | $only_keys = array_values($this->db_key_cols); |
||
| 577 | } |
||
| 578 | // replace ambiguous column with (an exact match of) table_name.column |
||
| 579 | if(is_array($only_keys)) |
||
| 580 | { |
||
| 581 | foreach($only_keys as $key => &$col) |
||
| 582 | { |
||
| 583 | if(is_numeric($key) && in_array($col, $this->db_cols, true)) |
||
| 584 | { |
||
| 585 | $col = $this->table_name .'.'.array_search($col, $this->db_cols).' AS '.$col; |
||
| 586 | } |
||
| 587 | // Check to make sure our order by doesn't have aliases that won't work |
||
| 588 | else if (stripos($col, 'AS') !== false && $order_by) |
||
| 589 | { |
||
| 590 | list($value, $alias) = explode(' AS ', $col); |
||
| 591 | if(stripos($order_by, $alias) !== FALSE && stripos($value, $this->table_name) === FALSE) |
||
| 592 | { |
||
| 593 | $order_by = str_replace($alias, $value, $order_by); |
||
| 594 | } |
||
| 595 | } |
||
| 596 | } |
||
| 597 | } |
||
| 598 | // check if we order by a custom field --> join cf table for given cf and order by it's value |
||
| 599 | if (strpos($order_by,self::CF_PREFIX) !== false) |
||
| 600 | { |
||
| 601 | // if $order_by contains more then order by columns (eg. group by) split it off before |
||
| 602 | if (($pos = stripos($order_by, 'order by')) !== false) |
||
| 603 | { |
||
| 604 | $group_by = substr($order_by, 0, $pos+9); |
||
| 605 | $order_by = substr($order_by, $pos+9); |
||
| 606 | } |
||
| 607 | // fields to order by, as cutomfields may have names with spaces, we examine each order by criteria |
||
| 608 | $fields2order = explode(',',$order_by); |
||
| 609 | foreach($fields2order as $v) |
||
| 610 | { |
||
| 611 | if (strpos($v,self::CF_PREFIX) !== false) |
||
| 612 | { |
||
| 613 | // we found a customfield, so we split that part by space char in order to get Sorting Direction and Fieldname |
||
| 614 | $buff = explode(' ',trim($v)); |
||
| 615 | $orderDir = array_pop($buff); |
||
| 616 | $key = substr(trim(implode(' ',$buff)), 1); |
||
| 617 | if (!isset($this->customfields[$key])) |
||
| 618 | { |
||
| 619 | $order_by = preg_replace('/'.preg_quote($v, '/').',?/', '', $order_by); |
||
| 620 | continue; // ignore unavaiable CF |
||
| 621 | } |
||
| 622 | switch($this->customfields[$key]['type']) |
||
| 623 | { |
||
| 624 | case 'int': |
||
| 625 | $order_by = str_replace($v, 'extra_order.'.$this->extra_value.' IS NULL,'. |
||
| 626 | $this->db->to_int('extra_order.'.$this->extra_value).' '.$orderDir, $order_by); |
||
| 627 | break; |
||
| 628 | case 'float': |
||
| 629 | $order_by = str_replace($v, 'extra_order.'.$this->extra_value.' IS NULL,'. |
||
| 630 | $this->db->to_double('extra_order.'.$this->extra_value).' '.$orderDir, $order_by); |
||
| 631 | break; |
||
| 632 | default: |
||
| 633 | $order_by = str_replace($v, 'extra_order.'.$this->extra_value.' IS NULL,extra_order.'. |
||
| 634 | $this->extra_value.' '.$orderDir, $order_by); |
||
| 635 | } |
||
| 636 | // postgres requires that expressions in order by appear in the columns of a distinct select |
||
| 637 | if ($this->db->Type != 'mysql') |
||
| 638 | { |
||
| 639 | if (!is_array($extra_cols)) |
||
| 640 | { |
||
| 641 | $extra_cols = $extra_cols ? explode(',', $extra_cols) : array(); |
||
| 642 | } |
||
| 643 | $extra_cols[] = 'extra_order.'.$this->extra_value; |
||
| 644 | $extra_cols[] = 'extra_order.'.$this->extra_value.' IS NULL'; |
||
| 645 | } |
||
| 646 | $join .= $this->extra_join_order.' AND extra_order.'.$this->extra_key.'='.$this->db->quote($key); |
||
| 647 | } |
||
| 648 | } |
||
| 649 | // add group by again |
||
| 650 | if (isset($group_by)) |
||
| 651 | { |
||
| 652 | $order_by = $group_by.$order_by; |
||
| 653 | } |
||
| 654 | } |
||
| 655 | // check if we filter by a custom field |
||
| 656 | if (is_array($filter)) |
||
| 657 | { |
||
| 658 | $_cfnames = array_keys($this->customfields); |
||
| 659 | $extra_filter = null; |
||
| 660 | foreach($filter as $name => $val) |
||
| 661 | { |
||
| 662 | // replace ambiguous auto-id with (an exact match of) table_name.autoid |
||
| 663 | if (is_string($name) && $name == $this->autoinc_id) |
||
| 664 | { |
||
| 665 | if ((int)$filter[$this->autoinc_id]) |
||
| 666 | { |
||
| 667 | $filter[] = $this->db->expression($this->table_name,$this->table_name.'.',array( |
||
| 668 | $this->autoinc_id => $filter[$this->autoinc_id], |
||
| 669 | )); |
||
| 670 | } |
||
| 671 | unset($filter[$this->autoinc_id]); |
||
| 672 | } |
||
| 673 | // replace ambiguous column with (an exact match of) table_name.column |
||
| 674 | elseif (is_string($name) && $val!=null && in_array($name, $this->db_cols)) |
||
| 675 | { |
||
| 676 | $extra_columns = $this->db->get_table_definitions($this->app, $this->extra_table); |
||
| 677 | if ($extra_columns['fd'][array_search($name, $this->db_cols)]) |
||
| 678 | { |
||
| 679 | $filter[] = $this->db->expression($this->table_name,$this->table_name.'.',array( |
||
| 680 | array_search($name, $this->db_cols) => $val, |
||
| 681 | )); |
||
| 682 | unset($filter[$name]); |
||
| 683 | } |
||
| 684 | } |
||
| 685 | elseif (is_string($name) && $this->is_cf($name)) |
||
| 686 | { |
||
| 687 | $cf_name = $this->get_cf_name($name); |
||
| 688 | if (!isset($this->customfields[$cf_name])) |
||
| 689 | { |
||
| 690 | unset($filter[$name]); |
||
| 691 | continue; // ignore unavailable CF |
||
| 692 | } |
||
| 693 | if (!empty($val)) // empty -> dont filter |
||
| 694 | { |
||
| 695 | if ($val[0] === '!') // negative filter |
||
| 696 | { |
||
| 697 | $sql_filter = 'extra_filter.'.$this->extra_value.'!='.$this->db->quote(substr($val,1)); |
||
| 698 | } |
||
| 699 | else // using Db::expression to allow to use array() with possible values or NULL |
||
| 700 | { |
||
| 701 | if($this->customfields[$cf_name]['type'] == 'select' && |
||
| 702 | $this->customfields[$cf_name]['rows'] > 1) |
||
| 703 | { |
||
| 704 | // Multi-select - any entry with the filter value selected matches |
||
| 705 | $sql_filter = str_replace($this->extra_value,'extra_filter.'. |
||
| 706 | $this->extra_value,$this->db->expression($this->extra_table,array( |
||
| 707 | $this->db->concat("','",$this->extra_value,"','").' '.$this->db->capabilities[Db::CAPABILITY_CASE_INSENSITIV_LIKE].' '.$this->db->quote('%,'.$val.',%') |
||
| 708 | )) |
||
| 709 | ); |
||
| 710 | } |
||
| 711 | elseif ($this->customfields[$cf_name]['type'] == 'text') |
||
| 712 | { |
||
| 713 | $sql_filter = str_replace($this->extra_value,'extra_filter.'.$this->extra_value, |
||
| 714 | $this->db->expression($this->extra_table,array( |
||
| 715 | $this->extra_value.' '.$this->db->capabilities[Db::CAPABILITY_CASE_INSENSITIV_LIKE].' '.$this->db->quote($wildcard.$val.$wildcard) |
||
| 716 | )) |
||
| 717 | ); |
||
| 718 | } |
||
| 719 | else |
||
| 720 | { |
||
| 721 | $sql_filter = str_replace($this->extra_value,'extra_filter.'. |
||
| 722 | $this->extra_value,$this->db->expression($this->extra_table,array($this->extra_value => $val))); |
||
| 723 | } |
||
| 724 | } |
||
| 725 | // need to use a LEFT JOIN for negative search or to allow NULL values |
||
| 726 | $need_left_join = $val[0] === '!' || strpos($sql_filter,'IS NULL') !== false ? ' LEFT ' : ''; |
||
| 727 | $join .= str_replace('extra_filter','extra_filter'.$extra_filter,$need_left_join.$this->extra_join_filter. |
||
| 728 | ' AND extra_filter.'.$this->extra_key.'='.$this->db->quote($cf_name). |
||
| 729 | ' AND '.$sql_filter); |
||
| 730 | ++$extra_filter; |
||
| 731 | } |
||
| 732 | unset($filter[$name]); |
||
| 733 | } |
||
| 734 | elseif(is_int($name) && $this->is_cf($val)) // lettersearch: #cfname LIKE 's%' |
||
| 735 | { |
||
| 736 | $_cf = explode(' ',$val); |
||
| 737 | foreach($_cf as $cf_np) |
||
| 738 | { |
||
| 739 | // building cf_name by glueing parts together (, in case someone used whitespace in their custom field names) |
||
| 740 | $tcf_name = ($tcf_name?$tcf_name.' ':'').$cf_np; |
||
| 741 | // reacts on the first one found that matches an existing customfield, should be better then the old behavior of |
||
| 742 | // simply splitting by " " and using the first part |
||
| 743 | if ($this->is_cf($tcf_name) && ($cfn = $this->get_cf_name($tcf_name)) && array_search($cfn,(array)$_cfnames,true)!==false ) |
||
| 744 | { |
||
| 745 | $cf = $tcf_name; |
||
| 746 | break; |
||
| 747 | } |
||
| 748 | } |
||
| 749 | unset($filter[$name]); |
||
| 750 | $cf_name = $this->get_cf_name($cf); |
||
| 751 | if (!isset($this->customfields[$cf_name])) continue; // ignore unavailable CF |
||
| 752 | $join .= str_replace('extra_filter','extra_filter'.$extra_filter,$this->extra_join_filter. |
||
| 753 | ' AND extra_filter.'.$this->extra_key.'='.$this->db->quote($cf_name). |
||
| 754 | ' AND '.str_replace($cf,'extra_filter.'.$this->extra_value,$val)); |
||
| 755 | ++$extra_filter; |
||
| 756 | } |
||
| 757 | } |
||
| 758 | } |
||
| 759 | // add DISTINCT as by joining custom fields for search a row can be returned multiple times |
||
| 760 | if ($join && strpos($join, $this->extra_join) !== false) |
||
| 761 | { |
||
| 762 | if (is_array($only_keys)) |
||
| 763 | { |
||
| 764 | $only_keys = array_values($only_keys); |
||
| 765 | $only_keys[0] = 'DISTINCT '.($only_keys[0] != $this->autoinc_id ? $only_keys[0] : |
||
| 766 | $this->table_name.'.'.$this->autoinc_id.' AS '.$this->autoinc_id); |
||
| 767 | } |
||
| 768 | else |
||
| 769 | { |
||
| 770 | $only_keys = 'DISTINCT '.$only_keys; |
||
| 771 | } |
||
| 820 |
Loading history...
This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.
Consider making the comparison explicit by using
empty(..)or! empty(...)instead.